chromium.git
16 min agoMake the HistoryBackend::AddPagesWithDetails not fire notifications when archived... trunk trunk
engedy@chromium.org [Thu, 17 Apr 2014 00:32:24 +0000 (00:32 +0000)]
Make the HistoryBackend::AddPagesWithDetails not fire notifications when archived URLs are modified.

The NOTIFICATION_HISTORY_URLS_MODIFIED should only be fired for URLRows that are in the main database.

Also, add unit test for this method.

BUG=316638

Review URL: https://codereview.chromium.org/221813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264366 0039d316-1c4b-4281-b951-d872f2087c98

23 min agoPepper: Move PnaclOptions outside trusted plugin.
teravest@chromium.org [Thu, 17 Apr 2014 00:25:47 +0000 (00:25 +0000)]
Pepper: Move PnaclOptions outside trusted plugin.

I ran into this while moving the Manifest code out of the trusted plugin and
figured this was big enough to stand on its own.

We have to create a PP_PNaClOptions struct instead of PnaclOptions so that the
objects of that type can be passed to functions in PPB_NaCl_Private.

BUG=239656

Review URL: https://codereview.chromium.org/235983020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264365 0039d316-1c4b-4281-b951-d872f2087c98

26 min agoFix incorrect target for bisect-perf-regression script.
aurimas@google.com [Thu, 17 Apr 2014 00:22:35 +0000 (00:22 +0000)]
Fix incorrect target for bisect-perf-regression script.

BUG=343632
R=prasadv@chromium.org

Review URL: https://codereview.chromium.org/240373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264364 0039d316-1c4b-4281-b951-d872f2087c98

29 min agoCoreAnimation: Fix text anti-aliasing in download shelf
ccameron@chromium.org [Thu, 17 Apr 2014 00:19:01 +0000 (00:19 +0000)]
CoreAnimation: Fix text anti-aliasing in download shelf

Make the download shelf buttons opaque, and have them use the download
shelf's draw function to draw.

Add a helper function to look up an ancestor view based on the view ID.
This is particularly useful because the download shelf is five views
above the download shelf button view.

Update the bookmark button view function to refer to the toolbar view
as the download shelf toolbar view (which does not have a view ID
associated with it).

BUG=363750

Review URL: https://codereview.chromium.org/240093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264363 0039d316-1c4b-4281-b951-d872f2087c98

45 min ago[Ozone] Move DRI impl from ui/gfx/ozone/dri to ui/ozone/platform/dri
dnicoara@chromium.org [Thu, 17 Apr 2014 00:03:44 +0000 (00:03 +0000)]
[Ozone] Move DRI impl from ui/gfx/ozone/dri to ui/ozone/platform/dri

Review URL: https://codereview.chromium.org/240333006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264359 0039d316-1c4b-4281-b951-d872f2087c98

47 min agoWire GL_CHROMIUM_map_sub functions up to Skia.
bsalomon@google.com [Thu, 17 Apr 2014 00:01:26 +0000 (00:01 +0000)]
Wire GL_CHROMIUM_map_sub functions up to Skia.

BUG=skia:2402

Review URL: https://codereview.chromium.org/231993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264358 0039d316-1c4b-4281-b951-d872f2087c98

50 min agoReland r263348: Add False Start tests
davidben@chromium.org [Wed, 16 Apr 2014 23:58:20 +0000 (23:58 +0000)]
Reland r263348: Add False Start tests

Failed on valgrind because it triggered broken timing cases. The original
FakeBlockingStreamSocket changes introduced bugs and didn't quite have the
desired semantics:

- If SetNextReadWouldBlock() gets called while there is a hanging Read(), we
  need to block that one.

- The synchronous Read return + block case was just broken. It forgot to save
  the callback.

Original description:
> Add False Start tests
>
> Tests both that False Start occurs when it should and doesn't
> when it shouldn't.
>
> BUG=354132
>
> Review URL: https://codereview.chromium.org/208293002

BUG=354132,362920

Review URL: https://codereview.chromium.org/237483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264356 0039d316-1c4b-4281-b951-d872f2087c98

52 min agoAdd Create Shortcuts button to App Info dialog
sashab@chromium.org [Wed, 16 Apr 2014 23:56:29 +0000 (23:56 +0000)]
Add Create Shortcuts button to App Info dialog

Add a button to the App Info dialog that launches the Create Shortcuts dialog.

BUG=266739

Review URL: https://codereview.chromium.org/231193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264355 0039d316-1c4b-4281-b951-d872f2087c98

55 min agoUse EventRouter instead of ExtensionSystem::Get->event_router() from c/b/e/api
limasdf@gmail.com [Wed, 16 Apr 2014 23:53:33 +0000 (23:53 +0000)]
Use EventRouter instead of ExtensionSystem::Get->event_router() from c/b/e/api

from P~ to X~

BUG=362672

Review URL: https://codereview.chromium.org/240183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264354 0039d316-1c4b-4281-b951-d872f2087c98

56 min agoSync type and times_used in autofill::PasswordForm.
gcasto@chromium.org [Wed, 16 Apr 2014 23:52:47 +0000 (23:52 +0000)]
Sync type and times_used in autofill::PasswordForm.

BUG=

Review URL: https://codereview.chromium.org/189743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264353 0039d316-1c4b-4281-b951-d872f2087c98

57 min ago[NaCl SDK AppEngine] Change 'more info' -> 'Click for options'
binji@chromium.org [Wed, 16 Apr 2014 23:51:24 +0000 (23:51 +0000)]
[NaCl SDK AppEngine] Change 'more info' -> 'Click for options'

This is just a string change for the Bullet AppEngine demo.

BUG=none
TBR=sbc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/240203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264352 0039d316-1c4b-4281-b951-d872f2087c98

59 min agoFix 64-bit data type encoding from JavaScript.
tsepez@chromium.org [Wed, 16 Apr 2014 23:49:31 +0000 (23:49 +0000)]
Fix 64-bit data type encoding from JavaScript.

There appears to be a typo in the division; not enough zeros.
Also, there is incorrect sign-extension for negative values in many cases due the use of (x | 0) as a poor-man's floor().

Review URL: https://codereview.chromium.org/237753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264351 0039d316-1c4b-4281-b951-d872f2087c98

60 min agoPNaCl: increase the code segment size limit to 64MB
jfb@chromium.org [Wed, 16 Apr 2014 23:47:53 +0000 (23:47 +0000)]
PNaCl: increase the code segment size limit to 64MB

The 32MB limit was somewhat arbitrary, a guess of likely upper code size
for web applications. We received a user report of this limit being
reached when using SJLJ EH, which means we should reconsider our
estimate:
  https://groups.google.com/forum/#!topic/native-client-discuss/udMW3xLdGWg

Justin agreed on us doubling the limit.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3572
R= jschuh@chromium.org, mseaborn@chromium.org
TEST= none

Review URL: https://codereview.chromium.org/240333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264350 0039d316-1c4b-4281-b951-d872f2087c98

65 min agoAdded IndexedDBTransactionTest::ScheduleNormalTask.
cmumford@chromium.org [Wed, 16 Apr 2014 23:43:16 +0000 (23:43 +0000)]
Added IndexedDBTransactionTest::ScheduleNormalTask.

BUG=

Review URL: https://codereview.chromium.org/238793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264349 0039d316-1c4b-4281-b951-d872f2087c98

66 min agoFix a bug in Arm64 atomicops.
rmcilroy@chromium.org [Wed, 16 Apr 2014 23:42:45 +0000 (23:42 +0000)]
Fix a bug in Arm64 atomicops.

BUG=354405

Review URL: https://codereview.chromium.org/237963017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264348 0039d316-1c4b-4281-b951-d872f2087c98

67 min agoUpdate .DEPS.git
chrome-admin@google.com [Wed, 16 Apr 2014 23:41:08 +0000 (23:41 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264347 0039d316-1c4b-4281-b951-d872f2087c98

68 min agoRoll third_party/webgl/src to 8f445334c2f13a6be762fbdc90c4d80397d31788.
kbr@chromium.org [Wed, 16 Apr 2014 23:40:23 +0000 (23:40 +0000)]
Roll third_party/webgl/src to 8f445334c2f13a6be762fbdc90c4d80397d31788.

This allows addition of the IMPLEMENTATION_COLOR_READ_FORMAT and _TYPE
constants to WebGLRenderingContext.

BUG=363842

Review URL: https://codereview.chromium.org/236133014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264346 0039d316-1c4b-4281-b951-d872f2087c98

78 min agoAvoid having entries with an empty URL configured at chrome://settings/startup
ltilve@igalia.com [Wed, 16 Apr 2014 23:30:50 +0000 (23:30 +0000)]
Avoid having entries with an empty URL configured at chrome://settings/startup

BUG=282286

Review URL: https://codereview.chromium.org/221203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264345 0039d316-1c4b-4281-b951-d872f2087c98

81 min agoMove MojoChannelInit to mojo/common
cmasone@chromium.org [Wed, 16 Apr 2014 23:27:07 +0000 (23:27 +0000)]
Move MojoChannelInit to mojo/common

This class has general utility for bootstrapping mojo
services over a variety of communication channels,
so pull it into mojo itself.

BUG=None
TEST=None
R=sky@chromium.org

Review URL: https://codereview.chromium.org/232073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264342 0039d316-1c4b-4281-b951-d872f2087c98

85 min agoStop displaying layers with non-invertible transforms.
avallee@chromium.org [Wed, 16 Apr 2014 23:23:29 +0000 (23:23 +0000)]
Stop displaying layers with non-invertible transforms.

According to the CSS spec, if the transform of an object is
non-invertible the object and its content do not get displayed.

+ Added transform_is_invertible to Layer and LayerImpl which gets
  calculated once when the transform is set. When pusing to another layer
  the transform invertibility isn't recalculated.
+ Added invertibility check to LTHC::SubtreeShouldBeSkipped.

BUG=173726

Review URL: https://codereview.chromium.org/217313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264341 0039d316-1c4b-4281-b951-d872f2087c98

91 min agoRoll Clang 204777:206155
hans@chromium.org [Wed, 16 Apr 2014 23:17:46 +0000 (23:17 +0000)]
Roll Clang 204777:206155

BUG=363667

Review URL: https://codereview.chromium.org/239243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264340 0039d316-1c4b-4281-b951-d872f2087c98

92 min agosync: remove sessions v1 code + flags and move 'sessions2' to 'sessions'
tim@chromium.org [Wed, 16 Apr 2014 23:16:04 +0000 (23:16 +0000)]
sync: remove sessions v1 code + flags and move 'sessions2' to 'sessions'
BUG=none
TBR=asargent@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/235873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264339 0039d316-1c4b-4281-b951-d872f2087c98

98 min agoMove Android resources for Chromoting
lambroslambrou@chromium.org [Wed, 16 Apr 2014 23:10:34 +0000 (23:10 +0000)]
Move Android resources for Chromoting

This moves the Android-specific resources to a /res/ folder alongside
the Java sources.

R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/235923015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264338 0039d316-1c4b-4281-b951-d872f2087c98

104 min agoDocs: Remove unnecessary redirects from directories to 'index' files since we
kalman@chromium.org [Wed, 16 Apr 2014 23:04:47 +0000 (23:04 +0000)]
Docs: Remove unnecessary redirects from directories to 'index' files since we
now do that automatically. Fix a bug preventing the root directory from
redirecting to 'index'.

R=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/240303006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264337 0039d316-1c4b-4281-b951-d872f2087c98

2 hours ago[MemSheriff] Uninitialized member in RenderLayerCompositor
groby@chromium.org [Wed, 16 Apr 2014 22:42:34 +0000 (22:42 +0000)]
[MemSheriff] Uninitialized member in RenderLayerCompositor

NOTRY=true
TBR=thestig@chromium.org, ykyyip@chromium.org
BUG=364274

Review URL: https://codereview.chromium.org/239513012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264334 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoDisable the User Manager context menu
noms@chromium.org [Wed, 16 Apr 2014 22:42:02 +0000 (22:42 +0000)]
Disable the User Manager context menu

Having a context menu doesn't really make sense, because the User Manager
is meant to look like a widget, and the context menu is for the webui,
with most of the options disabled anyway.

BUG=350306

Review URL: https://codereview.chromium.org/236303018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264333 0039d316-1c4b-4281-b951-d872f2087c98

2 hours ago[Telemetry] Check in a couple of missing prebuilt linux binaries.
tonyg@chromium.org [Wed, 16 Apr 2014 22:34:15 +0000 (22:34 +0000)]
[Telemetry] Check in a couple of missing prebuilt linux binaries.

Also fix .gitignore and enfore that only .sha1s are in subdirs.

BUG=

Review URL: https://codereview.chromium.org/238813013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264332 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoRefactors WebsiteSettingsBubbleController to use PermissionMenuModel.
leng@chromium.org [Wed, 16 Apr 2014 22:24:08 +0000 (22:24 +0000)]
Refactors WebsiteSettingsBubbleController to use PermissionMenuModel.

In so doing, moves common code into a new base class, PermissionSelector,
which can be used by both views and cocoa UI code to define the menu for
each permission.

I'd like to take this farther and move the call to OnSitePermissionChanged() to
PermissionSelector.  It would require the PermissionSelector keeping a (weak)
pointer to the WebsiteSettings object - is that a reasonable change to make?

The two subclasses for PermissionSelector deviate a bit - for views, the
PermissionSelectorView contains all of the UI for displaying the whole line.
For cocoa, it only acts as a bridge between the menu model and the UI for the
menu.

BUG=None

Review URL: https://codereview.chromium.org/193383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264329 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoAdd SetManagementSettings() in DeviceSettingsService.
davidyu@chromium.org [Wed, 16 Apr 2014 22:23:36 +0000 (22:23 +0000)]
Add SetManagementSettings() in DeviceSettingsService.

Extend SignAndStoreSettingsOperation so that it can take PolicyData.

BUG=353050
TEST=manual

Review URL: https://codereview.chromium.org/215743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264328 0039d316-1c4b-4281-b951-d872f2087c98

2 hours ago[MemSheriff] Data race suppression.
groby@chromium.org [Wed, 16 Apr 2014 22:16:20 +0000 (22:16 +0000)]
[MemSheriff] Data race suppression.

This is possibly a false positive - see reasoning on bug

TBR=bulach@chromium.org, glider@chromium.org
NOTRY=true
BUG=343802

Review URL: https://codereview.chromium.org/239973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264326 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agokiosk: Fix keyboard flow on network config UI.
xiyuan@chromium.org [Wed, 16 Apr 2014 22:15:49 +0000 (22:15 +0000)]
kiosk: Fix keyboard flow on network config UI.

- Shift stripping in KeyboardDrivenEventRewriter should happen before
  session start to cover network config UI which is after login but
  before session start;
- Fix html and css so that the blue halo shows up;

BUG=364123

Review URL: https://codereview.chromium.org/236303019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264325 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoRemove resource strings unused after GTK removal.
msw@chromium.org [Wed, 16 Apr 2014 22:15:18 +0000 (22:15 +0000)]
Remove resource strings unused after GTK removal.

These were found auditing IDS references removed by r263101.
I tried to CC all the string authors/editors, just in case.
(let me know if you have any objections to this cleanup)

IDS_ALERT_DIALOG_WIDTH_CHARS

IDS_CERT_EMAIL_ADDRESSES_FORMAT

IDS_CERT_ISSUERNAME_FORMAT
IDS_CERT_SELECTOR_CERT_EXPIRED
IDS_CERT_SELECTOR_CERT_NOT_YET_VALID
IDS_CERT_SELECTOR_CHOOSE_DESCRIPTION_LABEL
IDS_CERT_SELECTOR_DETAILS_DESCRIPTION_LABEL
IDS_CERT_SELECTOR_SITE_DESCRIPTION_LABEL
IDS_CERT_SUBJECTNAME_FORMAT
IDS_CERT_TOKEN_FORMAT
IDS_CERT_VALIDITY_RANGE_FORMAT
IDS_CERT_X509_EXTENDED_KEY_USAGE_FORMAT
IDS_CERT_X509_KEY_USAGE_FORMAT

IDS_CREATE_SHORTCUTS_ERROR_DIALOG_HEIGHT_LINES
IDS_CREATE_SHORTCUTS_ERROR_DIALOG_WIDTH_CHARS

IDS_CREATE_SHORTCUTS_ERROR_LABEL
IDS_CREATE_SHORTCUTS_ERROR_TITLE

IDS_EXTENSIONS_DETAILS

IDS_FIRSTRUN_DLG_OK
IDS_FIRSTRUN_DLG_TITLE

IDS_NOTIFICATION_BALLOON_DISMISS_LABEL
IDS_NOTIFICATION_BALLOON_SOURCE_LABEL
IDS_NOTIFICATION_OPTIONS_MENU_LABEL

IDS_ONE_CLICK_SIGNIN_BUBBLE_MESSAGE_FULL

IDS_XPFRAME_CLOSE_TOOLTIP
IDS_XPFRAME_MAXIMIZE_TOOLTIP
IDS_XPFRAME_MINIMIZE_TOOLTIP
IDS_XPFRAME_RESTORE_TOOLTIP

BUG=297026
TEST=No build errors or complaints.
R=erg@chromium.org

Review URL: https://codereview.chromium.org/238813009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264324 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoBreak a single histogram into two histograms
asargent@chromium.org [Wed, 16 Apr 2014 22:14:47 +0000 (22:14 +0000)]
Break a single histogram into two histograms

This histogram records a networking result that if positive indicates a
byte count, and if negative indicates an error code. Since histograms
can't handle negative values, this splits that up into two: one for the
byte count, and one that will use an existing enum for the network
error code.

This was based off of a suggestion in codereview.chromium.org/236023005

BUG=360909

Review URL: https://codereview.chromium.org/235893017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264323 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoRevert 264313 "Add activity recording capability to gcm internal..."
asargent@chromium.org [Wed, 16 Apr 2014 22:00:33 +0000 (22:00 +0000)]
Revert 264313 "Add activity recording capability to gcm internal..."

This caused a compile error on the Win x64 builder:

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/17353/steps/compile/logs/stdio

FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\google_apis\gcm\tools\mcs_probe.mcs_probe.obj.rsp /c ..\..\google_apis\gcm\tools\mcs_probe.cc /Foobj\google_apis\gcm\tools\mcs_probe.mcs_probe.obj /Fdobj\google_apis\gcm\mcs_probe.cc.pdb
c:\b\build\slave\cr-win-rel-x64\build\src\google_apis\gcm\tools\mcs_probe.cc(309) :error C2661: 'gcm::MCSClient::MCSClient' : no overloaded function takes 4 arguments
ninja: build stopped: subcommand failed.

> Add activity recording capability to gcm internals page. User can refresh, start/stop recording, and clear recording logs.
> Also added more information to the device info section and fixed a bug there.
>
> arv: owner review of chrome/browser/resources/*.
> jianli & fgorski please review the rest of the code, and zea for owner review of these code.
>
> BUG=341256
>
> Review URL: https://codereview.chromium.org/202083005

TBR=juyik@chromium.org

Review URL: https://codereview.chromium.org/240583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264319 0039d316-1c4b-4281-b951-d872f2087c98

2 hours ago[Mac] Set the same minimum window size for the User Manager as on Win
noms@chromium.org [Wed, 16 Apr 2014 22:00:07 +0000 (22:00 +0000)]
[Mac] Set the same minimum window size for the User Manager as on Win

BUG=347947

Review URL: https://codereview.chromium.org/239313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264318 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoCast: Fix default parameters for cast_sender_app
hclam@chromium.org [Wed, 16 Apr 2014 21:58:39 +0000 (21:58 +0000)]
Cast: Fix default parameters for cast_sender_app

There were two issues:
1. start bitrate was smaller than min bitrate.
2. remote port was 0 by default.

They are both fixed in this change.

TBR=miu

Review URL: https://codereview.chromium.org/240033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264317 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agogyp performance: don't invoke python to check dir existance
bratell@opera.com [Wed, 16 Apr 2014 21:52:49 +0000 (21:52 +0000)]
gyp performance: don't invoke python to check dir existance

We spend a few tenths of a second every gyp invocation starting
the dir_exists.py program. Seems a bit unnecessary.

BUG=362075
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/234963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264316 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoDisable WallpaperManageerBrowserTest.DisplayChange for flakiness.
yoz@chromium.org [Wed, 16 Apr 2014 21:44:38 +0000 (21:44 +0000)]
Disable WallpaperManageerBrowserTest.DisplayChange for flakiness.

BUG=362847
TBR=alemate@chromium.org

Review URL: https://codereview.chromium.org/240453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264314 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoAdd activity recording capability to gcm internals page. User can refresh, start...
juyik@chromium.org [Wed, 16 Apr 2014 21:41:44 +0000 (21:41 +0000)]
Add activity recording capability to gcm internals page. User can refresh, start/stop recording, and clear recording logs.
Also added more information to the device info section and fixed a bug there.

arv: owner review of chrome/browser/resources/*.
jianli & fgorski please review the rest of the code, and zea for owner review of these code.

BUG=341256

Review URL: https://codereview.chromium.org/202083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264313 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoRename IDS ids to be more consistent in ui_strings.grd.
tnagel@chromium.org [Wed, 16 Apr 2014 21:39:27 +0000 (21:39 +0000)]
Rename IDS ids to be more consistent in ui_strings.grd.

This fixes the awkward sorting in grit_whitelist.txt and had been suggested by
Bartosz some time ago.

BUG=none

Review URL: https://codereview.chromium.org/240113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264312 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoReduce dependency of TiclInvalidationService on Profile
bartfab@chromium.org [Wed, 16 Apr 2014 21:38:50 +0000 (21:38 +0000)]
Reduce dependency of TiclInvalidationService on Profile

With this CL, a URLRequestContext and an InvalidationStateTracker are
passed to TiclInvalidationService as explicit dependencies. This reduces
the dependency of TiclInvalidationService on Profile, taking a step toward
eventually removing the dependency altogether.

BUG=358696
TEST=Updated unit tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264226

Review URL: https://codereview.chromium.org/221963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264311 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoLinux: Add more CHECKs to better debug setuid sandbox startup failures.
thestig@chromium.org [Wed, 16 Apr 2014 21:35:00 +0000 (21:35 +0000)]
Linux: Add more CHECKs to better debug setuid sandbox startup failures.

BUG=328883

Review URL: https://codereview.chromium.org/239883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264308 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoScroll on main if impl-hit testing isn't guaranteed to be correct
vollick@chromium.org [Wed, 16 Apr 2014 21:22:51 +0000 (21:22 +0000)]
Scroll on main if impl-hit testing isn't guaranteed to be correct

It often happens that we have composited layers with
holes. Sometimes we'll try and interact through the
hole (we might, say, want to scroll something back
there). The cc machinery isn't currently smart enough to
figure out exactly what got hit, so when we detect that
our hit testing result might be inaccurate we fall back
to main thread scrolling.

Here are the specifics on how I determine if me might
have hit a "holey" occluder.

I find two starting layers:
 1) The first layer below the viewport point.
 2) The first scrolling layer below the viewport point.

If we haven't hit an interfering occluder, the first
scrolling layer we should reach when we walk up from 1)
is 2). If we find some other layer, things have likely
gone wonky, so we bail.

I've also added stats so that we can track how often we
fall back to main thread scrolling because we couldn't
figure out what was going on.

R=enne@chromium.org
BUG=364090

Review URL: https://codereview.chromium.org/238803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264306 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoOnly build win static_initializers tool on Pro where DIA is available
scottmg@chromium.org [Wed, 16 Apr 2014 21:15:57 +0000 (21:15 +0000)]
Only build win static_initializers tool on Pro where DIA is available

Otherwise, 'all' fails when using Express toolchain.

R=grt@chromium.org
BUG=https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/j5xzCWuwam4

Review URL: https://codereview.chromium.org/239603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264305 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agowin: When use_goma=1, favor fastbuild=1 over win_z7=1.
thakis@chromium.org [Wed, 16 Apr 2014 21:11:46 +0000 (21:11 +0000)]
win: When use_goma=1, favor fastbuild=1 over win_z7=1.

BUG=332697
NOTRY=true

Review URL: https://codereview.chromium.org/239113010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264304 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agogyp performance: Add a DoMain version of build/compiler_version
bratell@opera.com [Wed, 16 Apr 2014 20:59:15 +0000 (20:59 +0000)]
gyp performance: Add a DoMain version of build/compiler_version

No need to start a full python interpreter for compiler_version.py. This saves about 0.6 CPU seconds.

BUG=362075
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/235083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264303 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoRebase nacl size epxectations; minor increase on 32bit linux.
thakis@chromium.org [Wed, 16 Apr 2014 20:57:47 +0000 (20:57 +0000)]
Rebase nacl size epxectations; minor increase on 32bit linux.

BUG=none
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/240343005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264302 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoMove bookmark_prompt_prefs.{cc,h} to components/bookmarks
sdefresne@chromium.org [Wed, 16 Apr 2014 20:45:00 +0000 (20:45 +0000)]
Move bookmark_prompt_prefs.{cc,h} to components/bookmarks

The files chrome/browser/bookmarks/bookmark_prompt_prefs.{cc,h} does
not have any dependencies on other files, so move them to the
bookmarks component.

BUG=360646
TBR=sky

Review URL: https://codereview.chromium.org/236193015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264301 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoRevert 264277 "Revert "Revert of Only create webrtc MediaStreams..."
fischman@chromium.org [Wed, 16 Apr 2014 20:45:00 +0000 (20:45 +0000)]
Revert 264277 "Revert "Revert of Only create webrtc MediaStreams..."

Reason for revert: broke a bunch of webrtc bots including:
http://build.chromium.org/p/chromium.webrtc/builders/WinXP%20Tester/builds/8185
http://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/1202
http://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/21768
(when you reland this, please make clear in your CL description that this is not
only a Revert^4, but actually a reland :))

> Revert "Revert of Only create webrtc MediaStreams when added to a PeerConnection
> https://codereview.chromium.org/227163007/
>
> This reverts commit caa70d180ff72cbf5f5ffd542b97de86794d5e00.
>
> The reason for the original revert is fixed in https://codereview.chromium.org/237433003/.
>
> Original CL desription:
> This cl adds a new class WebRtcMediaStreamAdapter. The responsibility of the class is to create and own a representation of a webrtc MediaStream that can be added and removed from a PeerConnection.
> An instance of WebRtcMediaStreamAdapter is created when a MediaStream is added to RTCPeerConnection object.
>
> The purpose is to clean up the the webrtc specific use of MediaStreams.
>
> TBR= ronghuawu@chromium.org
> BUG=323223
>
> Review URL: https://codereview.chromium.org/235503011

TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/240533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264300 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoFix for unable to enter decimal in number input field
avi.nitk@samsung.com [Wed, 16 Apr 2014 20:43:00 +0000 (20:43 +0000)]
Fix for unable to enter decimal in number input field

Steps:
1. Open google.com
2. Search for "Currency converter"
3. User unable to enter decimal values in number input field

This issue is caused because InputType.TYPE_NUMBER_FLAG_DECIMAL
was not being set for number input type.

BUG=151738

Review URL: https://codereview.chromium.org/234563005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264298 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoFill out the rest of the net targets in the GN build except Android.
brettw@chromium.org [Wed, 16 Apr 2014 20:34:31 +0000 (20:34 +0000)]
Fill out the rest of the net targets in the GN build except Android.

This also fixes some missing base files and libresolv naming.

R=jar@chromium.org

Review URL: https://codereview.chromium.org/236063018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264296 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoRemove --disable-accelerated-compositing
piman@chromium.org [Wed, 16 Apr 2014 20:25:56 +0000 (20:25 +0000)]
Remove --disable-accelerated-compositing

After r264075, this is not used by the renderer. Also, nothing sets it
but tests (and for the wrong reasons). Also, it's not like it works any
more after r264103.  Replace it in tests by --disable-gpu, and remove
from the code.

BUG=362164
R=danakj@chromium.org, kbr@chromium.org, shess@chromium.org

Review URL: https://codereview.chromium.org/238933009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264295 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoRemove VIEW_TYPE_NOTIFICATION since it's not used anymore.
jam@chromium.org [Wed, 16 Apr 2014 20:23:13 +0000 (20:23 +0000)]
Remove VIEW_TYPE_NOTIFICATION since it's not used anymore.

BUG=137297
R=yoz@chromium.org

Review URL: https://codereview.chromium.org/238263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264294 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoEnable build and upload of experimental bionic SDK
noelallen@chromium.org [Wed, 16 Apr 2014 20:21:35 +0000 (20:21 +0000)]
Enable build and upload of experimental bionic SDK

BUG=
R=binji@chromium.org

Review URL: https://codereview.chromium.org/239543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264293 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoAdd reference test for supervised user password signature generation.
antrim@chromium.org [Wed, 16 Apr 2014 20:21:27 +0000 (20:21 +0000)]
Add reference test for supervised user password signature generation.

R=nkostylev@chromium.org
BUG=363601

Review URL: https://codereview.chromium.org/239543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264292 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoPreserve Page::openedByDOM state across process swaps.
davidben@chromium.org [Wed, 16 Apr 2014 20:19:49 +0000 (20:19 +0000)]
Preserve Page::openedByDOM state across process swaps.

Every Page in Blink has an openedByDOM bit which partially determines whether
window.close() may be called. This bit is equivalent to whether the WebContents
was created with an opener. Move this bit up to WebContents and forward it to
new renderers to be preserved across process swaps. Add a suite of tests to
ensure it's preserved correctly.

This also fixes a bug where the bit was not preserved for blocked-then-opened
popups. Add a test for this case.

BUG=357579

Review URL: https://codereview.chromium.org/212703005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264291 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoAdd app_shell_browsertests to trybot configurations for chromeos.
yoz@chromium.org [Wed, 16 Apr 2014 20:19:01 +0000 (20:19 +0000)]
Add app_shell_browsertests to trybot configurations for chromeos.

Follows https://chromiumcodereview.appspot.com/232053003/
BUG=353600

Review URL: https://codereview.chromium.org/237813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264290 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoTelemetry: adds link to feature guidelines.
bulach@chromium.org [Wed, 16 Apr 2014 20:18:37 +0000 (20:18 +0000)]
Telemetry: adds link to feature guidelines.

BUG=

Review URL: https://codereview.chromium.org/235893019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264289 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoValidate TouchPoint in EventSender.
zeeshanq@chromium.org [Wed, 16 Apr 2014 19:59:41 +0000 (19:59 +0000)]
Validate TouchPoint in EventSender.

There was noise created in ClusterFuzz by tests crashing on invalid input to
EventSender, this should address it.

BUG=346339

Review URL: https://codereview.chromium.org/237853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264288 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoMove all remaining unittests from webkit/browser/quota/ to content/browser/quota/
pilgrim@chromium.org [Wed, 16 Apr 2014 19:49:00 +0000 (19:49 +0000)]
Move all remaining unittests from webkit/browser/quota/ to content/browser/quota/

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/239253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264287 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoCombine settings about compositing scrollable frames (Chromium side)
wangxianzhu@chromium.org [Wed, 16 Apr 2014 19:48:29 +0000 (19:48 +0000)]
Combine settings about compositing scrollable frames (Chromium side)

Chromium side change required by https://codereview.chromium.org/239533002/.

BUG=304900

Review URL: https://codereview.chromium.org/239463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264286 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agorAc: allowing firing 'invalid' events on inputs while filling.
dbeam@chromium.org [Wed, 16 Apr 2014 19:37:12 +0000 (19:37 +0000)]
rAc: allowing firing 'invalid' events on inputs while filling.

R=isherman@chromium.org
BUG=361843

Review URL: https://codereview.chromium.org/233223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264283 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoRemove the libc++ and ASan/TSan/MSan runtime dependencies from base.gyp:sanitizer_options
glider@chromium.org [Wed, 16 Apr 2014 19:27:56 +0000 (19:27 +0000)]
Remove the libc++ and ASan/TSan/MSan runtime dependencies from base.gyp:sanitizer_options

This is needed to avoid pulling the sanitizer symbols into the targets that want to opt-out
from linking with sanitizer runtimes.

BUG=302040
R=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/238773007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264282 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoMove instrumented-libraries-related settings out of common.gypi.
earthdok@chromium.org [Wed, 16 Apr 2014 19:23:26 +0000 (19:23 +0000)]
Move instrumented-libraries-related settings out of common.gypi.

Instead, apply them as direct_dependent_settings to dependents of the
instrumented_libraries target. This is functionally equivalent, but reduces code
duplication, improves locality and also allows us to disable the use of
instrumented libraries on a target-by-target basis.

BUG=313751
TBR=glider@chromium.org
TEST=MSan
NOTRY=true

Review URL: https://codereview.chromium.org/240413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264281 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoImplementation of Window Shape using SkAlphaThresholdFilter
zork@chromium.org [Wed, 16 Apr 2014 19:21:28 +0000 (19:21 +0000)]
Implementation of Window Shape using SkAlphaThresholdFilter

BUG=324071

Review URL: https://codereview.chromium.org/132343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264280 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoUpdate .DEPS.git
chrome-admin@google.com [Wed, 16 Apr 2014 19:20:08 +0000 (19:20 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264279 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoFix broken CLD2 dynamic build
andrewhayden@chromium.org [Wed, 16 Apr 2014 19:19:41 +0000 (19:19 +0000)]
Fix broken CLD2 dynamic build

This configuration isn't yet enabled on any bots; hopefully soon, so that it
will stop breaking.

notry, since the bots won't build it anyhow.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/235923018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264278 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoRevert "Revert of Only create webrtc MediaStreams when added to a PeerConnection
perkj@chromium.org [Wed, 16 Apr 2014 19:19:14 +0000 (19:19 +0000)]
Revert "Revert of Only create webrtc MediaStreams when added to a PeerConnection
https://codereview.chromium.org/227163007/

This reverts commit caa70d180ff72cbf5f5ffd542b97de86794d5e00.

The reason for the original revert is fixed in https://codereview.chromium.org/237433003/.

Original CL desription:
This cl adds a new class WebRtcMediaStreamAdapter. The responsibility of the class is to create and own a representation of a webrtc MediaStream that can be added and removed from a PeerConnection.
An instance of WebRtcMediaStreamAdapter is created when a MediaStream is added to RTCPeerConnection object.

The purpose is to clean up the the webrtc specific use of MediaStreams.

TBR= ronghuawu@chromium.org
BUG=323223

Review URL: https://codereview.chromium.org/235503011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264277 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoNaCl: Update revision in DEPS, r13006 -> r13018
mseaborn@chromium.org [Wed, 16 Apr 2014 19:19:07 +0000 (19:19 +0000)]
NaCl: Update revision in DEPS, r13006 -> r13018

This pulls in the following Native Client changes:

r13007: (dyen) Fixed URLs for package archives uploaded by glibc and newlib NaCl bots.
r13008: (dschuff) Fix name of PNaCl binutils json file and don't build redundantly
r13009: (dyen) Fixed a bad merge which caused order issues in buildbot annotations.
r13010: (dyen) Cleaned up buildbot toolchain scripts and annotations.
r13011: (noelallen) Roll GN
r13012: (dschuff) Fix fake cross target name for libstdc++ bitcode builds in toolchain_build
r13013: (dschuff) Add basic sanity check for host binaries and gold plugin
r13014: (teravest) Remove unnecessary nameservice test.
r13015: (dyen) Fixed some issues with package version script.
r13016: (dyen) Fixed an issue with pnacl buildbot using the old toolchain path.
r13017: (dschuff) Add package_version.py json file for pinned PNaCl version
r13018: (dyen) Uploads PNaCl translator package info during the PNaCl build.

BUG=none
TEST=browser_tests and nacl_integration
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/240303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264276 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoHistograms.xml changes to go with codereview.chromium.org/227943003
asargent@chromium.org [Wed, 16 Apr 2014 19:17:21 +0000 (19:17 +0000)]
Histograms.xml changes to go with codereview.chromium.org/227943003

Doing this in a separate CL to make a potential merge easier

BUG=360909
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/236023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264275 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoFix prerender test to use unprefixed MediaSource API.
acolwell@chromium.org [Wed, 16 Apr 2014 19:09:50 +0000 (19:09 +0000)]
Fix prerender test to use unprefixed MediaSource API.

The prefixed MediaSource implementation is being removed
so this prerender test that depends on it needs to be
migrated to the unprefixed API.

BUG=363444
TEST=PrerenderBrowserTest.PrerenderHTML5MediaSourceVideo

Review URL: https://codereview.chromium.org/238523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264274 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoozone: evdev: Add libgestures bindings for touchpad & mouse support
spang@chromium.org [Wed, 16 Apr 2014 19:04:30 +0000 (19:04 +0000)]
ozone: evdev: Add libgestures bindings for touchpad & mouse support

The gestures library converts kernel input events into gestures. This
currently happens inside X11 in the xf86-input-cmt driver, but without
X11 we have to do use it from EventFactoryEvdev

BUG=351168

Review URL: https://codereview.chromium.org/193813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264273 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoFix case of IOReturn.h.
torne@chromium.org [Wed, 16 Apr 2014 19:04:01 +0000 (19:04 +0000)]
Fix case of IOReturn.h.

The real file has a capital R - fix reference in our code to avoid the
build failing on case sensitive mac filesystems.

BUG=

Review URL: https://codereview.chromium.org/240283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264272 0039d316-1c4b-4281-b951-d872f2087c98

5 hours ago[MemSheriff] Suppress V8 UNINITIALIZE READ
groby@chromium.org [Wed, 16 Apr 2014 18:53:46 +0000 (18:53 +0000)]
[MemSheriff] Suppress V8 UNINITIALIZE READ

Seems like DrMemory and V8 are currently not playing along nicely

TBR=eugenis@chromium.org, earthdok@chromium.orb
NOTRY=true
BUG=364146

Review URL: https://codereview.chromium.org/239243012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264271 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoNew binary size tool visualization options.
andrewhayden@chromium.org [Wed, 16 Apr 2014 18:53:18 +0000 (18:53 +0000)]
New binary size tool visualization options.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/231803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264270 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoTelemetry: Fix JS typo in conversion to python (True->true)
epenner@chromium.org [Wed, 16 Apr 2014 18:50:55 +0000 (18:50 +0000)]
Telemetry: Fix JS typo in conversion to python (True->true)

BUG=364131
TBR=tonyg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/240253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264269 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoAdd myself in the AUTHORS file
rtakacs.u-szeged@partner.samsung.com [Wed, 16 Apr 2014 18:49:23 +0000 (18:49 +0000)]
Add myself in the AUTHORS file

NOTRY=true

Review URL: https://codereview.chromium.org/239063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264268 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoRemove calls to WebMediaPlayerClient::setOpaque().
scherkus@chromium.org [Wed, 16 Apr 2014 18:44:49 +0000 (18:44 +0000)]
Remove calls to WebMediaPlayerClient::setOpaque().

As of blink r171720 they're no longer needed now that WebMediaPlayer implementations call WebLayerImpl::setOpaque() directly.

BUG=110814

Review URL: https://codereview.chromium.org/239393007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264266 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoGN: fix operators not short-circuiting
scottmg@chromium.org [Wed, 16 Apr 2014 18:43:43 +0000 (18:43 +0000)]
GN: fix operators not short-circuiting

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/239813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264265 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoDisplay close buttons in correct position on correct root window.
flackr@chromium.org [Wed, 16 Apr 2014 18:41:44 +0000 (18:41 +0000)]
Display close buttons in correct position on correct root window.

BUG=354951
TEST=Enter overview with windows on multiple monitors. Close buttons should be displayed on both monitors.

Review URL: https://codereview.chromium.org/240153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264264 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoRemove ForceCompositingMode from the GPU blacklist.
danakj@chromium.org [Wed, 16 Apr 2014 18:40:30 +0000 (18:40 +0000)]
Remove ForceCompositingMode from the GPU blacklist.

This mode is always on for everything we ship, so we never need to
blacklist it.

R=jbauman@chromium.org
BUG=363772

Review URL: https://codereview.chromium.org/239253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264263 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoUpdating XTBs based on .GRDs from branch 1916
karen@chromium.org [Wed, 16 Apr 2014 18:38:48 +0000 (18:38 +0000)]
Updating XTBs based on .GRDs from branch 1916

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264262 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoRemove unused image assets and IDRs.
msw@chromium.org [Wed, 16 Apr 2014 18:37:31 +0000 (18:37 +0000)]
Remove unused image assets and IDRs.

I ran the following command which yielded the IDRs below.
tools/resources/find_unused_resources.py chrome/app/theme/theme_resources.grd
IDR_DOCK_HIGH
IDR_DOCK_MAX
IDR_DOCK_WIDE
IDR_EXTENSIONS_SCRIPT_BUBBLE
IDR_FEEDBACK_H
IDR_FILES_APP_ICON
IDR_INCOGNITO_SWITCH_OFF
IDR_INCOGNITO_SWITCH_ON
IDR_PORTAL_DETECTION_GLOBE
IDR_TEMPORARY_GOOGLE_PLUS_ICON
IDR_THROBBER_WAITING_LIGHT

Auditing GTK removal CL r263101 also found:
IDR_UPDATE_BADGE4

Further, the tool missed these unused IDRs:
IDR_FEEDBACK
IDR_FEEDBACK_P

The tool also didn't list some asset files, which I found.

I tried to CC all the image authors/editors, just in case.
(let me know if you have any objections to this cleanup)

BUG=297026
TEST=No build errors or complaints.
R=jamescook@chromium.org
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/239533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264261 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoAllow passing frontend page url as an argument to testRunner.showWebInspector
yurys@chromium.org [Wed, 16 Apr 2014 18:35:33 +0000 (18:35 +0000)]
Allow passing frontend page url as an argument to testRunner.showWebInspector

We are going to use a simple page instead of full-fledged DevTools front-end to run DevTools protocol tests. The page URL will be passed as a param to showWebInspector.

BUG=364013

Review URL: https://codereview.chromium.org/240133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264259 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoFix AwContentsTest#testDownload.
davidben@chromium.org [Wed, 16 Apr 2014 18:34:55 +0000 (18:34 +0000)]
Fix AwContentsTest#testDownload.

The handler could cause the request to be cancelled out-of-band in
OnReadCompleted without returning false.

BUG=363563

Review URL: https://codereview.chromium.org/238933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264258 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoEF_NUMPAD_KEY flag for ui::KeyEvent
kpschoedel@chromium.org [Wed, 16 Apr 2014 18:32:49 +0000 (18:32 +0000)]
EF_NUMPAD_KEY flag for ui::KeyEvent

Added a flag to distinguish between a KeyEvent that originates from
a number pad key and one that does not, where the KeyboardCode is
the same. For example, VKEY_LEFT can originate both from the cursor
block and the number pad '4' key, and the latter will have the
EF_NUMPAD_KEY flag set. This is needed to rewrite number pad events
to number key events without affecting editing key events.

BUG=354034
TEST=events_unittests EventsXTest.NumpadKeyEvents
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/239313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264257 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoMake iterating over a corrupted IndexedDB fail.
cmumford@chromium.org [Wed, 16 Apr 2014 18:32:19 +0000 (18:32 +0000)]
Make iterating over a corrupted IndexedDB fail.

If an open corrupted IndexedDB was iterated over it would silently fail and the
web page would never be informed. This change fixes that bug so that cursor
iteration fails just like a get operation did previously.

BUG=332524

Review URL: https://codereview.chromium.org/237143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264256 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoMake NSS work in GN build on Windows.
brettw@chromium.org [Wed, 16 Apr 2014 18:29:50 +0000 (18:29 +0000)]
Make NSS work in GN build on Windows.

This also adds sqlite which is a dependency.

This required some build config changes since nss needs to opt-out of certain default settings.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/235863024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264255 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSection 2.4 of the ICCCM spec requires: "The requestor must delete the property named...
pkotwicz@chromium.org [Wed, 16 Apr 2014 18:26:00 +0000 (18:26 +0000)]
Section 2.4 of the ICCCM spec requires: "The requestor must delete the property named in the SelectionNotify once all the data has been retrieved."
Make Chrome follow this requirement. This has the side effect of allowing pasting into Chrome while Synergy is running

BUG=363293
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/237583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264254 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoUse default CSP for resource loading in webview (instead of platform app's CSP)
lazyboy@chromium.org [Wed, 16 Apr 2014 18:25:16 +0000 (18:25 +0000)]
Use default CSP for resource loading in webview (instead of platform app's CSP)

<webview> loads page in an isolated context inside platform app and hosts drive-by web. Platform app's CSP is too restrictive for <webview>, we stop using that CSP and use the default instead in this CL.

BUG=363437
Test=Load an chrome app. Load a webview html from accessible resources. Make the webview page contain inline JS. Check that the JS loads. It didn't use to load w/o this CL.

Review URL: https://codereview.chromium.org/237793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264253 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSeparate display utilities in a different component
dnicoara@chromium.org [Wed, 16 Apr 2014 18:23:59 +0000 (18:23 +0000)]
Separate display utilities in a different component

The separation will allow other components (views, ozone) to use the utilities
without pulling in the whole display components.

TBR=sadrul@chromium.org
BUG=333413

Review URL: https://codereview.chromium.org/239393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264252 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoAdd new cryptohome error codes,
antrim@chromium.org [Wed, 16 Apr 2014 18:23:23 +0000 (18:23 +0000)]
Add new cryptohome error codes,
Use correct constant for schema.

R=nkostylev@chromium.org
TBR=stevenjb@chromium.org

BUG=363601

Review URL: https://codereview.chromium.org/238353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264251 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoResubmit "Expand ActivityLog to recognize ad injection"
rdevlin.cronin@chromium.org [Wed, 16 Apr 2014 17:59:47 +0000 (17:59 +0000)]
Resubmit "Expand ActivityLog to recognize ad injection"

This relands https://codereview.chromium.org/209853006/ after a fix to the
logging, which caused a compile error (that somehow wasn't caught in trybots).

TBR=jochen@chromium.org
TBR=pmarch@chromium.org
TBR=felt@chromium.org
TBR=mpearson@chromium.org
TBR=kalman@chromium.org

BUG=357204

Review URL: https://codereview.chromium.org/238803006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264250 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoAndroid: Java-side Battery Status API + JNI
timvolodine@chromium.org [Wed, 16 Apr 2014 17:59:05 +0000 (17:59 +0000)]
Android: Java-side Battery Status API + JNI

Initial java-side impementation of the Battery Status API
and the skeleton for the browser-side manager class with
the JNI bindings.

BUG=360068

Review URL: https://codereview.chromium.org/225403007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264249 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoMore suppressions for ThreadSanitizer v2:
glider@chromium.org [Wed, 16 Apr 2014 17:58:36 +0000 (17:58 +0000)]
More suppressions for ThreadSanitizer v2:
 -- issue 364014 (race on WTF::Latin1Encoding()::globalLatin1Encoding guard)
 -- issue 364006 (concurrent destruction of gfx::Image)
 -- issue 363999 (race on thread_local_.debugger_entry_ in v8::internal::Debug)
 -- issue 361790 (UAF in EmbeddedWorkerBrowserTest.StartAndStop)

BUG=361790,363999,364006,364014
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/239243011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264248 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSet the original url correctly if the frame is loaded via loadData
hush@chromium.org [Wed, 16 Apr 2014 17:58:08 +0000 (17:58 +0000)]
Set the original url correctly if the frame is loaded via loadData

BUG=348234

Review URL: https://codereview.chromium.org/176883012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264247 0039d316-1c4b-4281-b951-d872f2087c98

7 hours ago[Android WebView] Add an API to configure mixed-mode content behavior.
benm@chromium.org [Wed, 16 Apr 2014 17:36:15 +0000 (17:36 +0000)]
[Android WebView] Add an API to configure mixed-mode content behavior.

Additionally allows us to have an SSL as well as a regular instance of the test server running at once to facilitate testing.

BUG=362478

Review URL: https://codereview.chromium.org/234983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264246 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoUpdate .DEPS.git
chrome-admin@google.com [Wed, 16 Apr 2014 17:36:07 +0000 (17:36 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264245 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoBlink roll 171752:171763
eseidel@chromium.org [Wed, 16 Apr 2014 17:35:08 +0000 (17:35 +0000)]
Blink roll 171752:171763

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171752:171763&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/238923008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264244 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoSwitching Chromium to use new Skia SkPictureRecorder API
robertphillips@google.com [Wed, 16 Apr 2014 17:34:21 +0000 (17:34 +0000)]
Switching Chromium to use new Skia SkPictureRecorder API

The Skia SkPicture recording API is changing to make it
clearer when the SkPicture is valid. In the new API
SkPictureRecorder::endRecording returns the new SkPicture.

This isn't landable until Skia DEPS rolls past r14171.

Review URL: https://codereview.chromium.org/236633008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264243 0039d316-1c4b-4281-b951-d872f2087c98