mvanouwerkerk@chromium.org [Tue, 21 May 2013 14:00:17 +0000 (14:00 +0000)]
Hide location bar on Javascript-initiated scroll.
Many sites use window.scrollTo(0,1) and other offsets as a means of
hiding the location bar on mobile. In fact, Android Browser and
iOS support hiding the location bar on any Javascript-initiated
scroll.
See also corresponding WebKit bugs:
https://bugs.webkit.org/show_bug.cgi?id=107027
This is a patch based on on jknottten's work:
https://chromiumcodereview.appspot.com/
11967015/
TEST=Test that URL bar is hidden when pressing on the various test buttons in http://jsbin.com/eruxon/5
BUG=165317
Review URL: https://chromiumcodereview.appspot.com/
14139013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201303
0039d316-1c4b-4281-b951-
d872f2087c98
jamescook@chromium.org [Tue, 21 May 2013 13:55:45 +0000 (13:55 +0000)]
Unit test for ImmersiveModeControllerAsh
Refactor ImmersiveModeController to break dependency on BrowserView
BUG=none
TEST=unit_tests ImmersiveModeControllerAshTest.*
Review URL: https://chromiumcodereview.appspot.com/
15020019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201302
0039d316-1c4b-4281-b951-
d872f2087c98
chrome-admin@google.com [Tue, 21 May 2013 13:45:36 +0000 (13:45 +0000)]
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201301
0039d316-1c4b-4281-b951-
d872f2087c98
robertphillips@google.com [Tue, 21 May 2013 13:44:06 +0000 (13:44 +0000)]
Roll Skia DEPS to r9204
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
15518002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201300
0039d316-1c4b-4281-b951-
d872f2087c98
chrome-admin@google.com [Tue, 21 May 2013 13:36:40 +0000 (13:36 +0000)]
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201299
0039d316-1c4b-4281-b951-
d872f2087c98
pneubeck@chromium.org [Tue, 21 May 2013 13:36:09 +0000 (13:36 +0000)]
Cleanup NetworkPropertyUIData.
This removes the dependency on NetworkUIData.
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/
15297002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201298
0039d316-1c4b-4281-b951-
d872f2087c98
battre@chromium.org [Tue, 21 May 2013 13:35:47 +0000 (13:35 +0000)]
Extension errors should not need developer mode in order to be displayed
BUG=237569
Review URL: https://chromiumcodereview.appspot.com/
14911002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201297
0039d316-1c4b-4281-b951-
d872f2087c98
mkwst@chromium.org [Tue, 21 May 2013 13:34:04 +0000 (13:34 +0000)]
Blink roll 150719:150777
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=150720:150777&mode=html
TBR=jchaffraix@chromium.org
Review URL: https://codereview.chromium.org/
15567003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201296
0039d316-1c4b-4281-b951-
d872f2087c98
dmikurube@chromium.org [Tue, 21 May 2013 12:30:28 +0000 (12:30 +0000)]
Use UNIX time (seconds since January 1, 1970, 00:00:00) in deep-heap-profile.cc.
BUG=None
TBR=willchan@chromium.org
Review URL: https://codereview.chromium.org/
15250007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201294
0039d316-1c4b-4281-b951-
d872f2087c98
jeremy@chromium.org [Tue, 21 May 2013 12:28:21 +0000 (12:28 +0000)]
Telemetry: Add option to create a dirty profile as part of a test run
Add a dirty_small profile type, when used this creates a "small" dirty profile which is used in the subsequent test run.
BUG=136664
Review URL: https://chromiumcodereview.appspot.com/
14359012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201293
0039d316-1c4b-4281-b951-
d872f2087c98
chrome-admin@google.com [Tue, 21 May 2013 11:36:34 +0000 (11:36 +0000)]
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201291
0039d316-1c4b-4281-b951-
d872f2087c98
gman@chromium.org [Tue, 21 May 2013 11:35:44 +0000 (11:35 +0000)]
Roll ANGLE to r2243
TBR=apatrick@chromium.org
BUG=238839,238837
Review URL: https://chromiumcodereview.appspot.com/
15489007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201290
0039d316-1c4b-4281-b951-
d872f2087c98
hidehiko@chromium.org [Tue, 21 May 2013 11:25:23 +0000 (11:25 +0000)]
Refactor CreateFileOperation by touching metadata and cache directly on blocking pool.
This CL extracts some consecutive accesses to metadata and cache, and moves it
onto blocking pool, so that it reduces the number of methods.
BUG=242025
TEST=Ran unit_tests
Review URL: https://chromiumcodereview.appspot.com/
15253003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201289
0039d316-1c4b-4281-b951-
d872f2087c98
chrome-admin@google.com [Tue, 21 May 2013 11:21:38 +0000 (11:21 +0000)]
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201288
0039d316-1c4b-4281-b951-
d872f2087c98
mkwst@chromium.org [Tue, 21 May 2013 11:19:06 +0000 (11:19 +0000)]
Blink roll 150614:150719
TBR=junov
Review URL: https://codereview.chromium.org/
15367007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201287
0039d316-1c4b-4281-b951-
d872f2087c98
satorux@chromium.org [Tue, 21 May 2013 11:17:35 +0000 (11:17 +0000)]
drive: Polish comments in drive.proto
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/
15536005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201286
0039d316-1c4b-4281-b951-
d872f2087c98
isherman@chromium.org [Tue, 21 May 2013 11:12:03 +0000 (11:12 +0000)]
[Autofill] Grant user consent for geolocation requests on Wallet dialog acceptance.
Geolocation includes network requests to Google servers, so the user needs to
consent to the collection of this information prior to us being able to collect
it. The Autofill dialog (in Wallet mode) includes a notice informing the user
that location data will be collected for Risk purposes, so acceptance
(submission) of the dialog grants this consent.
BUG=166596,173505
TEST=none
Review URL: https://chromiumcodereview.appspot.com/
14819016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201285
0039d316-1c4b-4281-b951-
d872f2087c98
stuartmorgan@chromium.org [Tue, 21 May 2013 11:08:49 +0000 (11:08 +0000)]
Enable C++11 mode for iOS
Matches the flags to the OS X clang settings for C++11 to minimize
confusion, but it would be straightforward to enable the string literal
warning on iOS at this point.
Removes a warning suppression that's duplicated by an Xcode setting just
above (again, matching OS X)
BUG=226494
Review URL: https://chromiumcodereview.appspot.com/
13936005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201284
0039d316-1c4b-4281-b951-
d872f2087c98
mtomasz@chromium.org [Tue, 21 May 2013 10:41:30 +0000 (10:41 +0000)]
Swapped window control assents for consistency.
This patch updates the assets to match Chrome windows' controls.
R=hirono@chromium.org
TEST=Run Files.app and verify.
BUG=239909
Review URL: https://codereview.chromium.org/
15337004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201283
0039d316-1c4b-4281-b951-
d872f2087c98
nduca@chromium.org [Tue, 21 May 2013 10:24:31 +0000 (10:24 +0000)]
Remove cc counters that aren't getting a lot of use
These counters are burning a lot of valuable vertical real estate, but
after talking to people, they're never being read. I propose we just kill them.
R=enne
Review URL: https://chromiumcodereview.appspot.com/
14699006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201282
0039d316-1c4b-4281-b951-
d872f2087c98
vmpstr@chromium.org [Tue, 21 May 2013 10:01:30 +0000 (10:01 +0000)]
cc: Renamed drawing_info to tile_version
Tile Version more accurately describes what is stored
in the class. This also makes it easier to reason about
having multiple versions, which is a goal we have in
for low quality tiles.
Review URL: https://chromiumcodereview.appspot.com/
15332004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201281
0039d316-1c4b-4281-b951-
d872f2087c98
toyoshim@chromium.org [Tue, 21 May 2013 10:01:14 +0000 (10:01 +0000)]
Translate: use IsTranslatableURL to check if it should be in the context menu
Replace ShouldShowTranslateItem with TranslateManager::IsTranslatableURL.
It should be the same, but these two are slightly different due to lack
of maintenance.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/
15257003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201280
0039d316-1c4b-4281-b951-
d872f2087c98
scottmg@chromium.org [Tue, 21 May 2013 09:44:02 +0000 (09:44 +0000)]
split file path constants out for split link
This is a follow on of work started in https://codereview.chromium.org/
15310002/
TBR=brettw@chromium.org
R=cpu@chromium.org
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/
15495003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201279
0039d316-1c4b-4281-b951-
d872f2087c98
tfarina@chromium.org [Tue, 21 May 2013 09:35:05 +0000 (09:35 +0000)]
bookmarks: bookmark_pasteboard_helper_mac.h only needs to include clipboard_sourcetag.h
ui::SourceTag now lives in clipboard_sourcetag.h, so we only need to include that
in the header file.
BUG=None
TEST=None
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
15532002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201278
0039d316-1c4b-4281-b951-
d872f2087c98
tyoshino@chromium.org [Tue, 21 May 2013 09:19:02 +0000 (09:19 +0000)]
Add two new WebSocket histograms to track adoption of the permessage-deflate extension.
WebCore.WebSocket.HandshakeResult provides baseline by counting the number of
WebSocket handshake attempts for each results.
WebCore.WebSocket.PerMessageDeflateContextTakeOverMode tells us how many
WebSocket connections are established with the permessage-deflate extension
turned on including the value of the no_context_takeover extension parameter.
BUG=128156
Review URL: https://chromiumcodereview.appspot.com/
15380004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201277
0039d316-1c4b-4281-b951-
d872f2087c98
zork@chromium.org [Tue, 21 May 2013 09:16:18 +0000 (09:16 +0000)]
Add expected content size to streamsPrivate.onExecuteMimeTypeHandler
BUG=230346
Review URL: https://chromiumcodereview.appspot.com/
14753006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201276
0039d316-1c4b-4281-b951-
d872f2087c98
joi@chromium.org [Tue, 21 May 2013 09:14:39 +0000 (09:14 +0000)]
Document in //content/DEPS that //content shouldn't depend on //components.
I'm working with the owners of the one exception to this rule to find
a correct home for it.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/
15490006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201275
0039d316-1c4b-4281-b951-
d872f2087c98
toyoshim@chromium.org [Tue, 21 May 2013 09:07:16 +0000 (09:07 +0000)]
Translate: add an UMA to report error infobars
Add an UMA to report error infobars. This UMA will be helpful to notice
client side and server side regression.
BUG=179277
TBR=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
15298006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201274
0039d316-1c4b-4281-b951-
d872f2087c98
msw@chromium.org [Tue, 21 May 2013 08:58:16 +0000 (08:58 +0000)]
Remove the uninstall dialog black border.
UninstallView uses Widget::CreateWindow.
Use DialogDelegate::CreateDialogWidget instead.
(it should be okay to continue using NULL parent/context)
See before/after pics at http://crbug.com/166075#c88
Trigger the dialog with debug code in Patch Set 1.
BUG=166075
TEST=Uninstall dialog does not have an extra border, test Win8!
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
15496003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201273
0039d316-1c4b-4281-b951-
d872f2087c98
ataly@chromium.org [Tue, 21 May 2013 08:57:50 +0000 (08:57 +0000)]
Adding end-to-end tests for the DOM and HTML5 APIs to the ActivityLog test extension.
BUG=161002
Review URL: https://chromiumcodereview.appspot.com/
15399002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201272
0039d316-1c4b-4281-b951-
d872f2087c98
gman@chromium.org [Tue, 21 May 2013 08:57:16 +0000 (08:57 +0000)]
Make unrenderable check not consider never bound textures.
the command buffer has to check for unrenderable textures
but a texture who's target is 0 by definition is not being
used so don't consider target=0 textures when counting
unrenderable textures.
BUG=242321
Review URL: https://chromiumcodereview.appspot.com/
15505005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201271
0039d316-1c4b-4281-b951-
d872f2087c98
bulach@chromium.org [Tue, 21 May 2013 08:56:56 +0000 (08:56 +0000)]
DMP / Android: fixes directory estimation for ICS builds.
On older devices, the path is slightly different.
BUG=
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/
15470007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201270
0039d316-1c4b-4281-b951-
d872f2087c98
hirono@chromium.org [Tue, 21 May 2013 08:47:57 +0000 (08:47 +0000)]
Test: Remove flakyness of file transfer tests.
Currently test.util.waitForFiles function that is used from FileTransferTest of
Files.app can be failed by timeout. This may be caused freakiness of
FileTransferTest.
This CL remove the timeout feature from waitForFiles function.
BUG=242395
TEST=browser_tests --gtest_filter=*TransferFrom*
Review URL: https://chromiumcodereview.appspot.com/
15469006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201269
0039d316-1c4b-4281-b951-
d872f2087c98
tim@chromium.org [Tue, 21 May 2013 08:47:38 +0000 (08:47 +0000)]
sync: deferred initialization support for autofill profiles
(based off of https://codereview.chromium.org/
15408004/, which I'll land before this CL is committed.)
BUG=80194
Review URL: https://chromiumcodereview.appspot.com/
15410002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201268
0039d316-1c4b-4281-b951-
d872f2087c98
dgrogan@chromium.org [Tue, 21 May 2013 08:46:56 +0000 (08:46 +0000)]
When Retrier succeeds, record errors it encountered.
Right now we just know that retrying a file operation
eventually succeeds and the approximate number of times it
was retried. With this patch we'll know which kinds of
filesystem errors can be overcome by retrying. It will give
us a better idea of what's causing the errors in the first
place.
BUG=225051
Review URL: https://chromiumcodereview.appspot.com/
15304008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201267
0039d316-1c4b-4281-b951-
d872f2087c98
hidehiko@chromium.org [Tue, 21 May 2013 08:46:41 +0000 (08:46 +0000)]
Move SearchMetadata into internal namespace.
The function is the detailed implementation for drive file system, and we
don't want to touch it from outside of the drive file system.
BUG=230235
TEST=Ran unit_tests
Review URL: https://chromiumcodereview.appspot.com/
15295002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201266
0039d316-1c4b-4281-b951-
d872f2087c98
chrome-admin@google.com [Tue, 21 May 2013 08:39:32 +0000 (08:39 +0000)]
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201265
0039d316-1c4b-4281-b951-
d872f2087c98
scottmg@chromium.org [Tue, 21 May 2013 08:37:28 +0000 (08:37 +0000)]
Pull string constants into separate .cc for split dll build
Requires https://codereview.chromium.org/
15310002/ before landing.
TBR=brettw@chromium.org
R=cpu@chromium.org
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/
15300017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201264
0039d316-1c4b-4281-b951-
d872f2087c98
nona@chromium.org [Tue, 21 May 2013 08:37:09 +0000 (08:37 +0000)]
Remove obsolete code in input method handling
I checked this code and comment is obsolete and working correctly on password field.
We should not call IMM32 API in the case of pure TSF, otherwise seems state of input method become inconsistent state.
BUG=239690
TEST=Manually done on Win 8 both TSF and IMM32 implementation.
Review URL: https://chromiumcodereview.appspot.com/
15296005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201263
0039d316-1c4b-4281-b951-
d872f2087c98
niklase@chromium.org [Tue, 21 May 2013 08:36:40 +0000 (08:36 +0000)]
Roll WebRTC to r4073
Review URL: https://chromiumcodereview.appspot.com/
15271014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201262
0039d316-1c4b-4281-b951-
d872f2087c98
toyoshim@chromium.org [Tue, 21 May 2013 08:36:23 +0000 (08:36 +0000)]
Translate: enable context menu against pages having notranslate meta tag
<meta name="google" value="notranslate"> tag disables Chrome Translate
feature completely. But, it is better to enable it in context menu.
- enable context menu against pages having notranslate meta tag
- rename confusing parameter name |page_translatable| to |page_needs_translation|
- rename confusing function name IsPageTranslatable to IsTranslationAllowed
- implement GetMetaElementsWithAttribute directly since this function is removed from webkit/glue
BUG=172593
TBR=palmer@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
15271002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201261
0039d316-1c4b-4281-b951-
d872f2087c98
tapted@chromium.org [Tue, 21 May 2013 08:27:07 +0000 (08:27 +0000)]
Create an app list shim for the App Launcher on OSX in response to a startup flag.
This allows an app launcher .app shim to be created on OSX with steps:
- Quit Chrome, and
- $ open Chromium.app --args --enable-app-list-shim
Chrome will start, and a finder window will be opened showing the newly
created .app. This can then be launched and pinned to the dock.
The .app can be deleted with --enable-app-list-shim=0 (or it can be
dragged to Trash).
BUG=138633
TEST=Steps as above.
Review URL: https://chromiumcodereview.appspot.com/
14760002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201260
0039d316-1c4b-4281-b951-
d872f2087c98
halton.huo@intel.com [Tue, 21 May 2013 08:26:42 +0000 (08:26 +0000)]
install-build-deps: Install libudev1 for Ubuntu 13.04
Install libudev1 Ubuntu 13.04, keep libudev0 for other Ubuntu releases.
Add 13.04 (racing) codename
BUG=240963
TEST=Tested manually
Review URL: https://chromiumcodereview.appspot.com/
14718016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201259
0039d316-1c4b-4281-b951-
d872f2087c98
kinuko@chromium.org [Tue, 21 May 2013 08:26:36 +0000 (08:26 +0000)]
Move browser-specific FileAPI code from webkit/fileapi to webkit/browser/fileapi
This moves following files from webkit/fileapi to webkit/browser/fileapi:
- copy_or_move_file_validator*
- cross_operation_delegate*
- file_system_quota_client*
- recursive_operation_delegate*
BUG=239710
TBR=tzik@chromium.org
Review URL: https://codereview.chromium.org/
15535006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201258
0039d316-1c4b-4281-b951-
d872f2087c98
msw@chromium.org [Tue, 21 May 2013 08:26:24 +0000 (08:26 +0000)]
Remove the update recommended dialog black border.
UpdateRecommendedMessageBox uses Widget::CreateWindow.
Use DialogDelegate::CreateDialogWidget instead.
See before/after pics at http://crbug.com/166075#c89
Trigger the dialog with debug code in Patch Set 1.
BUG=166075
TEST=Update recommended dialog does not have a black border.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
15497003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201257
0039d316-1c4b-4281-b951-
d872f2087c98
mukai@chromium.org [Tue, 21 May 2013 08:26:04 +0000 (08:26 +0000)]
Redesign display options for ChromeOS.
Several new features have been added recently, and this new UI
allows users to customize them through web UI.
Updates display options page.
BUG=190897
R=oshima@chromium.org, xiyuan@chromium.org, jhawkins@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
14710011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201256
0039d316-1c4b-4281-b951-
d872f2087c98
dmikurube@chromium.org [Tue, 21 May 2013 08:20:05 +0000 (08:20 +0000)]
Add sizes in MMAP_LIST by deep-heap-profile.cc.
BUG=None
R=glider@chromium.org
Review URL: https://codereview.chromium.org/
15316009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201255
0039d316-1c4b-4281-b951-
d872f2087c98
cpu@chromium.org [Tue, 21 May 2013 08:16:44 +0000 (08:16 +0000)]
Add a baground color for Ash on Windows
Right now it is a skbitmap 8x8 tiled with a single color.
BUG=227247
TEST=the ash background is dark grey.
Review URL: https://chromiumcodereview.appspot.com/
15137011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201254
0039d316-1c4b-4281-b951-
d872f2087c98
Yukawa@chromium.org [Tue, 21 May 2013 08:16:24 +0000 (08:16 +0000)]
Ignore MoveImeWindow when the target window has no input focus.
In issue 240189, I found that the renderer generates
SelectionBoundsChanged event even when it has no input
focus. (e.g, typing something in the search text box,
which causes relayouting in the Blink and the selection
bounds may change)
When this happens, ImmSetCandidateWindow/ImmSetCompositionWindow/
SetCaretPos will be called for an unfocused window with
unexpected caret position.
With this patch set, ImeInput::MoveImeWindow does nothing
when the target window has no input focus.
BUG=240189
TEST=Manually done on Windows 7 with built-in Chinese Simplified QuanPin (version 6.0)
Review URL: https://chromiumcodereview.appspot.com/
15126002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201253
0039d316-1c4b-4281-b951-
d872f2087c98
jamesr@chromium.org [Tue, 21 May 2013 08:16:08 +0000 (08:16 +0000)]
Move child-common classes to content/common_child
We need a place to put code that is shared between child processes of different
types but not used in the browser process. For instance, the NPObject bindings
code is used in the plugin and renderer processes but depends on WebBindings
which the browser shouldn't depend on. Some web platform features require shared
code between renderer and worker processe. The WebKit image decoders are used
by worker, renderer and utility processes.
This creates a content/common_child directory for code shared by more than one
child process type. content/common_child can depend on content/common and all
content/ subdirs except for content/browser and content/common can depend on it.
The java bridge code is (more than a) bit busted since it pulls the NPObject
bindings in to the browser, but since this code is only intended for use on
android single-process configurations I've just created DEPS exceptions for
this bit of code.
BUG=241606
Review URL: https://chromiumcodereview.appspot.com/
15047014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201252
0039d316-1c4b-4281-b951-
d872f2087c98
kinuko@chromium.org [Tue, 21 May 2013 08:15:51 +0000 (08:15 +0000)]
Cleanup: Use existing MockQuotaManager class in LocalFileSystemOperationWriteTest
Also gradually deprecate LocalFileSystemTestOriginHelper (test_helper_)
in non-sandbox tests.
BUG=241701
TEST=LocalFileSystemOperationWriteTest.*
R=nhiroki@chromium.org
Review URL: https://codereview.chromium.org/
15486002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201251
0039d316-1c4b-4281-b951-
d872f2087c98
ygorshenin@chromium.org [Tue, 21 May 2013 08:15:41 +0000 (08:15 +0000)]
Exposed PPB_TCPServerSocketPrivate::GetLocalAddress().
BUG=223006
NOTRY=true
TEST=browser_tests:*TCPServerSocketPrivate*
Review URL: https://chromiumcodereview.appspot.com/
14172007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201250
0039d316-1c4b-4281-b951-
d872f2087c98
nona@chromium.org [Tue, 21 May 2013 07:24:43 +0000 (07:24 +0000)]
Remove Extension IME button.
With this CL all extension IME will be shown in each language menu same as other input methods.
BUG=180094
TEST=Manually checked on lumpy.
Review URL: https://chromiumcodereview.appspot.com/
14969041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201248
0039d316-1c4b-4281-b951-
d872f2087c98
joth@chromium.org [Tue, 21 May 2013 07:24:24 +0000 (07:24 +0000)]
Makes the resource provider and tile manager optional in LayerTreeHostImpl.
This is used with ForcedDrawToSoftwareDevice / tile-free rendering, in the
android webview synchronous compositor, to enable just-in-time software
renderer and prepare way for lazy GL render initialization (crbug.com/230197)
(Inc. minor fix to tracing category used in SyncInputEventFilter)
BUG=230226
Review URL: https://chromiumcodereview.appspot.com/
14918013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201247
0039d316-1c4b-4281-b951-
d872f2087c98
rouslan@chromium.org [Tue, 21 May 2013 07:24:04 +0000 (07:24 +0000)]
Add ability to send feedback for spelling service
This CL adds the ability to send user feedback for spelling suggestions from
spelling service. This feedback will be used to improve the spelling
suggestions. The feedback will be collected in a follow-up CL. This CL does not
actually send out feedback, because no feedback is collected yet.
BUG=170514
Review URL: https://chromiumcodereview.appspot.com/
14721010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201246
0039d316-1c4b-4281-b951-
d872f2087c98
mtomasz@chromium.org [Tue, 21 May 2013 07:23:47 +0000 (07:23 +0000)]
Introduce a priority queue to the image loader.
Image loader used to start loading all requests at once, which caused long loading times in some scenarios. Eg. while images in the mosaic view are being loaded in the background, switching to the next image in the slide view is slow. It may happen that there are hundreds of pending images (for mosaic view preload) which have to be handled before the one is important (slide view).
To fix this issue (1) priorities were introduces, (2) tasks are queued, (3) number of tasks performed in parallel is limited to 5.
In practice, it gives a guarantee that there will be at most 5 tasks with lower priority executed before a task with higher priority. Taking into account an average resizing time, which is around 200ms, this gives a guarantee that on average, the image with the highest priority will be handled in the worst case with 1 second of delay.
Along the way, the selected images in the mosaic view have higher priority than other tiles. Also, background thumbnail generation for copying images has now very low priority to minimize load of important images.
TEST=Tested manually.
BUG=239237
Review URL: https://chromiumcodereview.appspot.com/
14623021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201245
0039d316-1c4b-4281-b951-
d872f2087c98
hashimoto@chromium.org [Tue, 21 May 2013 07:20:51 +0000 (07:20 +0000)]
drive: Remove ResourceMetadata::DirectoryChildrenToProtoVector
This method is only used in two places and one of them does not need ResourceEntry at all.
BUG=None
TEST=unit_tests
R=hidehiko@chromium.org
Review URL: https://codereview.chromium.org/
15528003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201244
0039d316-1c4b-4281-b951-
d872f2087c98
satorux@chromium.org [Tue, 21 May 2013 07:16:36 +0000 (07:16 +0000)]
drive: Rename DriveSystemService to DriveIntegrationService
This class is used to integrate Drive to Chrome, hence
DriveIntegrationService is a better name than DriveSystemService
which doesn't tell much about what it does.
BUG=242072
TEST=none
R=kinaba@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/
15430002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201241
0039d316-1c4b-4281-b951-
d872f2087c98
hashimoto@chromium.org [Tue, 21 May 2013 05:35:36 +0000 (05:35 +0000)]
Revert 201204 "add more string -> unsigned number conversion uni..."
This change generates "integer constant is too large for 'unsigned long' type" compile error on "Google Chrome Linux" buildbot
> add more string -> unsigned number conversion unit tests
>
> Add unit tests for the following functions in base:
> StringToUint
> StringToUint64
> StringToSizeT
>
> Review URL: https://chromiumcodereview.appspot.com/
14794002
TBR=mostynb@opera.com
Review URL: https://codereview.chromium.org/
15464016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201237
0039d316-1c4b-4281-b951-
d872f2087c98
thestig@chromium.org [Tue, 21 May 2013 05:33:48 +0000 (05:33 +0000)]
StorageMonitor: Make GetStorageInfoForPath()'s device_info parameter non-optional.
- The only place where it's optional is in tests.
- It's already non-optional in some platform implementations.
Do the same for MediaStorageUtil::GetDeviceInfoFromPath().
Review URL: https://chromiumcodereview.appspot.com/
15233005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201236
0039d316-1c4b-4281-b951-
d872f2087c98
ahutter@chromium.org [Tue, 21 May 2013 05:33:35 +0000 (05:33 +0000)]
Validate user input phone numbers in AutofillDialog using shared phone number validation code and displays user facing error messages if phone numbers are invalid.
BUG= 233277
Review URL: https://chromiumcodereview.appspot.com/
14246021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201235
0039d316-1c4b-4281-b951-
d872f2087c98
hashimoto@chromium.org [Tue, 21 May 2013 05:21:00 +0000 (05:21 +0000)]
Disable flaky InstantExtendedTest.MiddleClickOnSuggestionOpensInNewTab on Mac
BUG=242415
TBR=kinaba@chromium.org
Review URL: https://codereview.chromium.org/
15537002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201234
0039d316-1c4b-4281-b951-
d872f2087c98
sail@chromium.org [Tue, 21 May 2013 05:20:10 +0000 (05:20 +0000)]
Wrench Icon - fix minor bugs
If there was an existing error it wouldn't cause the wrench icon to
be colored. The problem was that the icon wasn't initially updated.
Also, for severe upgrades, WrenchIconPainter::SeverityFromUpgradeLevel
was returning the wrong values.
BUG=240909, 236596
Review URL: https://chromiumcodereview.appspot.com/
15500005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201233
0039d316-1c4b-4281-b951-
d872f2087c98
rltoscano@chromium.org [Tue, 21 May 2013 05:19:55 +0000 (05:19 +0000)]
Begins preview generation as soon as initial state is loaded. Doesn't wait for print destination to load.
BUG=239588
Review URL: https://chromiumcodereview.appspot.com/
15495007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201232
0039d316-1c4b-4281-b951-
d872f2087c98
jvoung@chromium.org [Tue, 21 May 2013 05:19:36 +0000 (05:19 +0000)]
Don't copy old timestamps when setting up pnacl files.
Otherwise, ninja will think that "output" files are
outdated compared to the "inputs" and need to be re-built.
Just use the latest timestamp.
BUG=242307
TEST= rm -rf out/Release/pnacl && ninja -C out/Release chrome -d explain && ninja -C out/Release chrome -d explain
ninja: Entering directory `out/Release'
ninja explain: output pnacl/pnacl_public_pnacl_json doesn't exist
ninja explain: pnacl/pnacl_public_pnacl_json is dirty
...
[8/8] LINK chrome
ninja: Entering directory `out/Release'
ninja: no work to do.
Review URL: https://chromiumcodereview.appspot.com/
15271013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201231
0039d316-1c4b-4281-b951-
d872f2087c98
piman@chromium.org [Tue, 21 May 2013 05:18:53 +0000 (05:18 +0000)]
Remove dead snapshotting code
BUG=None
Review URL: https://chromiumcodereview.appspot.com/
14663014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201230
0039d316-1c4b-4281-b951-
d872f2087c98
kinuko@chromium.org [Tue, 21 May 2013 05:15:26 +0000 (05:15 +0000)]
Move FileAPI sandboxed filesystem related code from webkit/fileapi to webkit/browser/fileapi
This moves following files from webkit/fileapi to webkit/browser/fileapi:
- obfuscated_file_util*
- sandbox_database_test_helper*
- sandbox_directory_database*
- sandbox_file_stream_writer*
- sandbox_mount_point_provider*
- sandbox_origin_database*
- sandbox_quota_observer*
BUG=239710
TBR=avi@chromium.org, calvinlo@chromium.org, thestig@chromium.org, tzik@chromium.org
Review URL: https://codereview.chromium.org/
15442002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201229
0039d316-1c4b-4281-b951-
d872f2087c98
abarth@chromium.org [Tue, 21 May 2013 05:09:28 +0000 (05:09 +0000)]
Expose WebThread::isCurrentThread()
In order to move web workers over to Chromium threading, we need to be able to
query whether a given WebThread is the thread upon which we are currently
executing. A future CL will actually expose this API in Blink.
Review URL: https://chromiumcodereview.appspot.com/
15490004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201228
0039d316-1c4b-4281-b951-
d872f2087c98
kaanb@chromium.org [Tue, 21 May 2013 05:09:13 +0000 (05:09 +0000)]
Change lock/unlock to map/unmap in DrawGL methods. It also changes the API to take the map mode as a public enum rather than an int.
BUG=175012
Review URL: https://chromiumcodereview.appspot.com/
15268007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201227
0039d316-1c4b-4281-b951-
d872f2087c98
sergeyu@chromium.org [Tue, 21 May 2013 05:08:55 +0000 (05:08 +0000)]
Cleanup dependencies on src/base from screen capturers.
Screen capturers will be moved to webrtc where they can't depend on
chromium base. This change removes base dependices on base the
capturers can live without. There are some remaining dependencies -
I will replace them with webrtc base libraries when moving this code.
Review URL: https://chromiumcodereview.appspot.com/
15020018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201226
0039d316-1c4b-4281-b951-
d872f2087c98
brianderson@chromium.org [Tue, 21 May 2013 05:08:39 +0000 (05:08 +0000)]
gpu: Fix range[2] initializion lists
BUG=none
Review URL: https://chromiumcodereview.appspot.com/
13050003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201225
0039d316-1c4b-4281-b951-
d872f2087c98
kmadhusu@chromium.org [Tue, 21 May 2013 04:04:04 +0000 (04:04 +0000)]
Move AutocompleteMatch::Type enum to chrome/common/autocomplete_match_type.h
Move AutocompleteMatch::TypeToString() to chrome/common/autocomplete_match_type.h
BUG=239173
TEST=none
TBR=mpcomplete@chromium.org, phajdan.jr@chromium.org, isherman@chromium.org, shishir@chromium.org, sail@chromium.org, estade@chromium.org, brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
14672014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201221
0039d316-1c4b-4281-b951-
d872f2087c98
chrome-release@google.com [Tue, 21 May 2013 04:01:14 +0000 (04:01 +0000)]
Updating trunk VERSION from 1513.0 to 1514.0
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201218
0039d316-1c4b-4281-b951-
d872f2087c98
boliu@chromium.org [Tue, 21 May 2013 04:01:03 +0000 (04:01 +0000)]
Prevent infinite invalidate-draw loop
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15502005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201217
0039d316-1c4b-4281-b951-
d872f2087c98
scottmg@chromium.org [Tue, 21 May 2013 03:57:12 +0000 (03:57 +0000)]
Revert 201202 "base: Support setting thread priorities generically."
Broke "sizes" by adding may static initializers.
> base: Support setting thread priorities generically.
>
> This patch supports setting priorities across platforms
> at the PlatformThread level, by stashing thread id into the
> thread handle on linux/android.
>
> Since this adds more platform specific code, and #ifdefs
> were starting to get unwieldy, all platform specific code
> is moved into _platform.cc files, with the exception of the
> 'default' implementation, which stay in _posix.
>
> BUG=170549
>
> Review URL: https://chromiumcodereview.appspot.com/
12741012
TBR=epenner@chromium.org
Review URL: https://codereview.chromium.org/
15311004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201215
0039d316-1c4b-4281-b951-
d872f2087c98
hidehiko@chromium.org [Tue, 21 May 2013 03:39:17 +0000 (03:39 +0000)]
Move update for WebAppsRegistry from ChangeListLoader to DriveWebAppsRegistry.
Historically it is done in ChangeListLoader because of the GData WAPI's
protocol. However, now we're moving to Drive API v2, so it can be moved
to DriveWebAppsRegistry.
BUG=236677
TEST=Ran unit_tests and tested manually
R=hashimoto@chromium.org, kinaba@chromium.org
Review URL: https://codereview.chromium.org/
15261002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201214
0039d316-1c4b-4281-b951-
d872f2087c98
nhiroki@chromium.org [Tue, 21 May 2013 03:39:10 +0000 (03:39 +0000)]
Drive API: Move ExtractResourceIdFromUrl() out of chromeos directory
This is a preparation patch to migrate SyncFS from WAPI to DriveAPI.
On chromeos, there is a convenient function "ExtractResourceIdFromUrl()"
which enables to pick up a resource id from entry url. To use this on
other platform, this change moves the function out of chromeos directory.
SyncFS will use this to get a parent resource id from a parent link
which converted from ChangeResource using ChangeResource-ResourceEntry
converter since a converted link does not contain parent's resource id.
BUG=234557
TEST=none
R=hidehiko@chromium.org, kinaba@chromium.org, tzik@chromium.org
Review URL: https://codereview.chromium.org/
15254003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201213
0039d316-1c4b-4281-b951-
d872f2087c98
tfarina@chromium.org [Tue, 21 May 2013 03:36:31 +0000 (03:36 +0000)]
bookmarks: Add "Bookmark open pages" to Bookmarks Menu.
The tab context menu has "Bookmark all tabs", but the Bookmarks Menu in the
Chrome menu (where you'd expect to find this) doesn't. This add this menu item
right next to "Bookmark this page".
BUG=181704
TEST=
1- launch chrome
2- click on the hotdog menu (chrome menu) in the right side.
3- select "Bookmarks" menu
4- Right after "Bookmark this page" you should see the new menu item.
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/
15366003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201212
0039d316-1c4b-4281-b951-
d872f2087c98
shess@chromium.org [Tue, 21 May 2013 03:27:02 +0000 (03:27 +0000)]
Record startup sizes for tagged SQLite databases.
BUG=240396
Review URL: https://chromiumcodereview.appspot.com/
15499003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201211
0039d316-1c4b-4281-b951-
d872f2087c98
hashimoto@chromium.org [Tue, 21 May 2013 03:26:45 +0000 (03:26 +0000)]
drive: Stop mentioning 'proto' in ChangeListProcessor
BUG=None
TEST=build
R=hidehiko@chromium.org
Review URL: https://codereview.chromium.org/
15381004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201210
0039d316-1c4b-4281-b951-
d872f2087c98
yusufo@chromium.org [Tue, 21 May 2013 03:26:45 +0000 (03:26 +0000)]
Disable intreactive autocomplete and remove command line flag for Android
Disabling this feature on beta and stable channels for now. This change will
be reverted on trunk after it is cherrypicked to the branch.
BUG=239478
Review URL: https://chromiumcodereview.appspot.com/
15491005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201209
0039d316-1c4b-4281-b951-
d872f2087c98
mukai@chromium.org [Tue, 21 May 2013 03:26:27 +0000 (03:26 +0000)]
Removes all "RemoveAllChildViews", instead sets visibility.
BUG=241261
R=dewittj@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
15476002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201208
0039d316-1c4b-4281-b951-
d872f2087c98
aurimas@chromium.org [Tue, 21 May 2013 03:25:57 +0000 (03:25 +0000)]
[Android] Replace setBackground() call with one that exists on ICS.
Switch from using View#setBackround(null) to View#setBackgroundResource(0)
as the first was only introduced in JB.
BUG=241878
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15463004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201207
0039d316-1c4b-4281-b951-
d872f2087c98
yoshiki@chromium.org [Tue, 21 May 2013 03:16:49 +0000 (03:16 +0000)]
Adds interface to change mouse cursor icon size to aura/ash.
This CL adds interface to change the cursor size to aura/ash layer. This is a part of the large cursor work (crbug.com/126942).
BUG=126942
R=oshima@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/
15093003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201206
0039d316-1c4b-4281-b951-
d872f2087c98
scottmg@chromium.org [Tue, 21 May 2013 03:16:43 +0000 (03:16 +0000)]
split ui/base/clipboard constants out for split_link
This is a follow on of work started in https://codereview.chromium.org/
15310002/
TBR=ben@chromium.org
R=cpu@chromium.org
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/
15271009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201205
0039d316-1c4b-4281-b951-
d872f2087c98
mostynb@opera.com [Tue, 21 May 2013 03:16:25 +0000 (03:16 +0000)]
add more string -> unsigned number conversion unit tests
Add unit tests for the following functions in base:
StringToUint
StringToUint64
StringToSizeT
Review URL: https://chromiumcodereview.appspot.com/
14794002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201204
0039d316-1c4b-4281-b951-
d872f2087c98
harrym@chromium.org [Tue, 21 May 2013 03:16:06 +0000 (03:16 +0000)]
Side launcher animations, unit tests.
BUG=187495, 229960, 229963, 150772
Review URL: https://chromiumcodereview.appspot.com/
14671005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201203
0039d316-1c4b-4281-b951-
d872f2087c98
epenner@chromium.org [Tue, 21 May 2013 03:15:49 +0000 (03:15 +0000)]
base: Support setting thread priorities generically.
This patch supports setting priorities across platforms
at the PlatformThread level, by stashing thread id into the
thread handle on linux/android.
Since this adds more platform specific code, and #ifdefs
were starting to get unwieldy, all platform specific code
is moved into _platform.cc files, with the exception of the
'default' implementation, which stay in _posix.
BUG=170549
Review URL: https://chromiumcodereview.appspot.com/
12741012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201202
0039d316-1c4b-4281-b951-
d872f2087c98
asargent@chromium.org [Tue, 21 May 2013 02:24:55 +0000 (02:24 +0000)]
Restrict use of chrome.bookmarks.{import,export} to component extensions
BUG=242264
TEST=Export and Import (in the "Organize" menu) in the bookmarks manager should
still work properly.
Review URL: https://chromiumcodereview.appspot.com/
15491003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201199
0039d316-1c4b-4281-b951-
d872f2087c98
ttuttle@chromium.org [Tue, 21 May 2013 02:24:34 +0000 (02:24 +0000)]
Remove ConstructSpdyHeader
Remove ConstructSpdyHeader from spdy_test_util_spdy[23], since it's not used anywhere. (I was going to merge it into spdy_test_util_common.)
BUG=226192
Review URL: https://chromiumcodereview.appspot.com/
15347002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201198
0039d316-1c4b-4281-b951-
d872f2087c98
isherman@chromium.org [Tue, 21 May 2013 02:24:06 +0000 (02:24 +0000)]
[Autofill] Set origins for all new profiles and credit cards.
Not included in this CL: Android and Sync changes.
BUG=170401, 231029
TEST=none
Review URL: https://chromiumcodereview.appspot.com/
15051007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201197
0039d316-1c4b-4281-b951-
d872f2087c98
sail@chromium.org [Tue, 21 May 2013 02:23:51 +0000 (02:23 +0000)]
Instant Extended: Hide info bar tip when instant overlay is visible
This CL hides the info bar tip when showing an instant overlay. This
prevents the infobar anti-spoof arrow from being visible under the
overlay.
BUG=174077
TEST=Ran chrome with instant extended enabled. Navigated to
http://www.consulfrance-toronto.org/
and waited for the translate info bar. Typed http://cnn.com in the
omnibox. Verified that the infobar arrow was not visible.
Review URL: https://chromiumcodereview.appspot.com/
14905009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201196
0039d316-1c4b-4281-b951-
d872f2087c98
cpu@chromium.org [Tue, 21 May 2013 01:42:10 +0000 (01:42 +0000)]
Remving global statics from the headers, so we can split-link.
The issue is that the split linker has issues with data exports vs function exports
currently only function exports are supported.
NOTRY=true
TBR=brettw,jam
TEST=none
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/
15403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201194
0039d316-1c4b-4281-b951-
d872f2087c98
frankf@chromium.org [Tue, 21 May 2013 01:34:07 +0000 (01:34 +0000)]
[chromedriver] Disable all TypingTests on Android.
TBR=craigdh@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
15500006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201192
0039d316-1c4b-4281-b951-
d872f2087c98
qinmin@chromium.org [Tue, 21 May 2013 01:33:37 +0000 (01:33 +0000)]
Remove android media player IPC messages from non-android build
media_player_messages.h only contains IPC for android IPCs
However, it is not excluded from non-android build, and that makes it unable to include params from media/base/android/ without "#ifdef defined(OS_ANDROID")
Add _android in the filename should exclude it from non-android build.
BUG=233420
Review URL: https://chromiumcodereview.appspot.com/
15367004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201191
0039d316-1c4b-4281-b951-
d872f2087c98
boliu@chromium.org [Tue, 21 May 2013 01:17:53 +0000 (01:17 +0000)]
shallowFlush in synchronous compositor swap buffer
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15453004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201189
0039d316-1c4b-4281-b951-
d872f2087c98
skuhne@chromium.org [Tue, 21 May 2013 01:07:13 +0000 (01:07 +0000)]
Adding new icons for messageboxes
BUG=239201
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/
15497004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201188
0039d316-1c4b-4281-b951-
d872f2087c98
jered@chromium.org [Tue, 21 May 2013 01:07:07 +0000 (01:07 +0000)]
net: Expose NetworkChangeObserver::DisableForTest.
Instant relies on net::NetworkChangeObserver so our tests need to
disable it in some cases. Rather than introduce a friend declaration for
code in chrome/browser/ui/search into net/base, expose the helper we
need.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
15120011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201187
0039d316-1c4b-4281-b951-
d872f2087c98
dfalcantara@chromium.org [Tue, 21 May 2013 01:06:14 +0000 (01:06 +0000)]
Add resources for the Android port
First half of https://chromiumcodereview.appspot.com/
14772036/
We need to create copies of the resources and put them into the Drawable
directories Android can access. This is separated from the other half of the CL
because Rietveld can't handle binary files.
BUG=237034,238668
R=yfriedman@chromium.org
Review URL: https://codereview.chromium.org/
15136005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201186
0039d316-1c4b-4281-b951-
d872f2087c98
sail@chromium.org [Tue, 21 May 2013 01:05:41 +0000 (01:05 +0000)]
Fix toolbar height changing after toggling bookmark bar
The toolbar height in the nib file was different from the constant in
the code. This meant that when the bookmark bar was toggled the
toolbar height would change.
I think the nib file is correct so I've updated the constant to match
it.
BUG=240987
TEST=Show and hide the bookmark bar. Verify that the toolbar is
exactly the same height.
Review URL: https://chromiumcodereview.appspot.com/
14676014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201185
0039d316-1c4b-4281-b951-
d872f2087c98