chromium/chromium.git
28 min agoUpdating trunk VERSION from 1954.0 to 1955.0 trunk
chrome-release@google.com [Wed, 23 Apr 2014 15:04:14 +0000 (15:04 +0000)]
Updating trunk VERSION from 1954.0 to 1955.0

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265643 0039d316-1c4b-4281-b951-d872f2087c98

45 min agoWiFiService::GetProperties now correctly populates BSSID and Frequency of connected...
mef@chromium.org [Wed, 23 Apr 2014 14:47:10 +0000 (14:47 +0000)]
WiFiService::GetProperties now correctly populates BSSID and Frequency of connected network.

BUG=364907

Review URL: https://codereview.chromium.org/245313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265640 0039d316-1c4b-4281-b951-d872f2087c98

57 min agoEnable check_printf=1 for ASan.
glider@chromium.org [Wed, 23 Apr 2014 14:35:42 +0000 (14:35 +0000)]
Enable check_printf=1 for ASan.

BUG=365620
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/246403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265639 0039d316-1c4b-4281-b951-d872f2087c98

62 min agoRemove finch experiment enforcing signin to launch packaged apps.
benwells@chromium.org [Wed, 23 Apr 2014 14:30:40 +0000 (14:30 +0000)]
Remove finch experiment enforcing signin to launch packaged apps.

We are not going ahead with this policy.

BUG=322153

Review URL: https://codereview.chromium.org/246993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265638 0039d316-1c4b-4281-b951-d872f2087c98

74 min agoApply default wallpaper from customization manifest.
alemate@chromium.org [Wed, 23 Apr 2014 14:17:57 +0000 (14:17 +0000)]
Apply default wallpaper from customization manifest.

This CL also fixes bug with default wallpaper cache.

BUG=348136,363134
TEST=manual

Review URL: https://codereview.chromium.org/236013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265636 0039d316-1c4b-4281-b951-d872f2087c98

87 min agocc: Use CHROMIUM_sync_query in GLRenderer when available.
reveman@chromium.org [Wed, 23 Apr 2014 14:05:43 +0000 (14:05 +0000)]
cc: Use CHROMIUM_sync_query in GLRenderer when available.

Use COMMANDS_COMPLETED queries instead of making assumptions about
the pipeline depth to determine when resources can be reused.

BUG=273274

Review URL: https://codereview.chromium.org/242513011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265635 0039d316-1c4b-4281-b951-d872f2087c98

89 min agoWebRTC: Remove neteq_unittests test.
kjellander@chromium.org [Wed, 23 Apr 2014 14:03:25 +0000 (14:03 +0000)]
WebRTC: Remove neteq_unittests test.

These tests are being removed in favor for
the test for NetEQ v4 that are a part of the
modules_unittests binary.

BUG=webrtc:2996
NOTRY=True

Review URL: https://codereview.chromium.org/249193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265633 0039d316-1c4b-4281-b951-d872f2087c98

104 min agoPassword autofill: Check for user gesture switches to new Blink backend
vabr@chromium.org [Wed, 23 Apr 2014 13:48:04 +0000 (13:48 +0000)]
Password autofill: Check for user gesture switches to new Blink backend

After landing https://codereview.chromium.org/235983016/ in Blink, there is a better way to check for user gesture, which does also work for gesture events on Android. The new way is a callback from Blink through WebAutofillAgent::firstUserGestureObserved, this CL switches to the new way, and also cleans up unneeded additions to cotent/renderer from https://codereview.chromium.org/163843002

BUG=163072, 345510

Review URL: https://codereview.chromium.org/241193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265632 0039d316-1c4b-4281-b951-d872f2087c98

106 min agoDon't compile events.gyp:events on Android.
tdresser@chromium.org [Wed, 23 Apr 2014 13:46:13 +0000 (13:46 +0000)]
Don't compile events.gyp:events on Android.

Review URL: https://codereview.chromium.org/241213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265631 0039d316-1c4b-4281-b951-d872f2087c98

107 min ago[DevTools] HiDPI cursors for touch emulation.
dgozman@chromium.org [Wed, 23 Apr 2014 13:45:05 +0000 (13:45 +0000)]
[DevTools] HiDPI cursors for touch emulation.

BUG=337142,316394
TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/247313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265630 0039d316-1c4b-4281-b951-d872f2087c98

110 min agoDevTools: Fix DEBUG_DEVTOOLS scenario with two browsers.
kaznacheev@chromium.org [Wed, 23 Apr 2014 13:42:21 +0000 (13:42 +0000)]
DevTools: Fix DEBUG_DEVTOOLS scenario with two browsers.

After https://chromiumcodereview.appspot.com/240283009 the debugging setup where one Chrome instance connects to another was broken.

TBR=vsevik
BUG=None

Review URL: https://codereview.chromium.org/248113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265629 0039d316-1c4b-4281-b951-d872f2087c98

119 min agoUpdate .DEPS.git
chrome-admin@google.com [Wed, 23 Apr 2014 13:33:08 +0000 (13:33 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265628 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoRemove useless code from RenderWidget.
jbauman@chromium.org [Wed, 23 Apr 2014 13:32:37 +0000 (13:32 +0000)]
Remove useless code from RenderWidget.

This code doesn't do much since DoDeferredUpdate was removed.

BUG=

Review URL: https://codereview.chromium.org/248083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265627 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoRoll Breakpad from 1313 to 1318.
rmcilroy@chromium.org [Wed, 23 Apr 2014 13:31:46 +0000 (13:31 +0000)]
Roll Breakpad from 1313 to 1318.

Skips core dump unittests on Android platforms which don't dump core files.

 - r1314: Limit the workaround in r1313 to Android only
 - r1315: Allow symupload to upload to multiple URLs on the same command line
 - r1316: Change the way function and public symbols are obtained to use the findChildren DIA function
 - r1317: minidump-2-core: Allow user to override shared lib basedir
 - r1318: Skip ElfCoreDumpTest and LinuxCoreDumperTest on Android if no core file is dumped

BUG=364943

Review URL: https://codereview.chromium.org/249183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265626 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoRevert of Use platform's device scale factor for cursor (https://codereview.chromium...
pfeldman@chromium.org [Wed, 23 Apr 2014 13:24:08 +0000 (13:24 +0000)]
Revert of Use platform's device scale factor for cursor (https://codereview.chromium.org/226293005/)

Reason for revert:
There are no resize cursors in DevTools on Linux Aura anymore.

Original issue's description:
> Use platform's device scale factor for cursor instead of gfx::Display because gfx::Display's DSF may differ from
> platform's one when UI scaling is used.
>
> BUG=361672
> TEST=covered by unit test
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265592

TBR=tdanderson@chromium.org,sky@chromium.org,oshima@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=361672

Review URL: https://codereview.chromium.org/249303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265625 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoRemove unused menu_message_pump_dispatcher_linux.cc
tapted@chromium.org [Wed, 23 Apr 2014 13:22:25 +0000 (13:22 +0000)]
Remove unused menu_message_pump_dispatcher_linux.cc

As of r262008, it is not compiled/used.

BUG=354062

Review URL: https://codereview.chromium.org/246903007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265624 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoFix serialization of sparse arrays in V8ValueConverter
mnaganov@chromium.org [Wed, 23 Apr 2014 13:12:55 +0000 (13:12 +0000)]
Fix serialization of sparse arrays in V8ValueConverter

This change makes V8ValueConverter to match JSON.stringify behaviour:

 JSON.stringify(new Array(3)) => "[null,null,null]"

Review URL: https://codereview.chromium.org/246333007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265622 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoAdd native_heap support to the memory_inspector frontend.
primiano@chromium.org [Wed, 23 Apr 2014 13:03:44 +0000 (13:03 +0000)]
Add native_heap support to the memory_inspector frontend.

This is a follow-up to crrev.com/239543009/ and adds the frontend code
(both server-side and client side) to support native heaps and
symbolization.

BUG=340294
NOTRY=true

Review URL: https://codereview.chromium.org/237743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265621 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoAdd native heap support to the memory_inspector periodic tracer.
primiano@chromium.org [Wed, 23 Apr 2014 13:00:58 +0000 (13:00 +0000)]
Add native heap support to the memory_inspector periodic tracer.

This change introduces:
 - The code which interfaces with the elf_symbolizer.
 - The plumbing required for symbolizing native heaps.
 - A heuristic native heap classifier to auto infer rules from stacktraces.
 - Unittests.

BUG=340294
NOTRY=true

Review URL: https://codereview.chromium.org/239543009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265620 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSupport drag and drop of files with filesystem: URL
hashimoto@chromium.org [Wed, 23 Apr 2014 12:19:48 +0000 (12:19 +0000)]
Support drag and drop of files with filesystem: URL

Filter filesystem files in RenderViewHostImpl::OnStartDragging.

Create isolated filesystem for each filesystem file in RenderViewHostImpl::DragTargetDragEnter.

Add file_system_files to content::DropData.

Wire information from blink::WebDragData to ui::OSExchangeData.
  blink::WebDragData -[drop_data_builder.cc]-> content::DropData -[web_contents_view_aura.cc]-> ui::OSExchangeData

Wire information from ui::OSExchangeData to blink::WebDragData.
  ui::OSExchangeData -[web_contents_view_aura.cc]-> content::DropData -[render_view_impl.cc]-> blink::WebDragData

BUG=126766

Review URL: https://codereview.chromium.org/242643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265616 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoCreate CrxInstaller directly in WebstoreInstaller
msimonides@opera.com [Wed, 23 Apr 2014 12:03:33 +0000 (12:03 +0000)]
Create CrxInstaller directly in WebstoreInstaller

The WebstoreInstaller needs a way to keep track of extensions being
downloaded and installed. The installation is handled by CrxInstaller
but when it used to be created automatically by the
ChromeDownloadManagerDelegate, the WebstoreInstaller had little control
over it and needed the CrxInstaller to keep the original_download_url as
sort of an identifier.

With this change the WebstoreInstaller creates the CrxInstaller itself
and keeps a pointer to it so there is no more need for
CrxInstaller::original_download_url().

This is also more robust because URLs are not unique identifiers (there
could be two installations run simultaneously for one download URL which
would have led to a crash in the old code).

BUG=360487

Review URL: https://codereview.chromium.org/226023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265615 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoUpdate Javadoc comments for PKCS11AuthenticationManager.initialize().
bauerb@chromium.org [Wed, 23 Apr 2014 11:57:24 +0000 (11:57 +0000)]
Update Javadoc comments for PKCS11AuthenticationManager.initialize().

BUG=361698

Review URL: https://codereview.chromium.org/239053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265614 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoCleanup GPU dependencies for gl_in_process_context
primiano@chromium.org [Wed, 23 Apr 2014 11:56:58 +0000 (11:56 +0000)]
Cleanup GPU dependencies for gl_in_process_context

This CL decouples the gl_in_process_context from gles2_implementation,
introducing a dedicated target (gl_in_process_context) and fixing the
corresponding dependencies.
This is a pre-requisite for crrev.com/228003006 and crbug.com/159847

BUG=159847

Review URL: https://codereview.chromium.org/247073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265613 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoFix WebContextmenuData leak in EventSender
kouhei@chromium.org [Wed, 23 Apr 2014 11:53:48 +0000 (11:53 +0000)]
Fix WebContextmenuData leak in EventSender

MakeMenuItemStringFor function takes WebContextMenuData*, but do not take its ownership.
However, a scoped_ptr was |release()|d to be passed to its argument. This patch fixes the issue.

BUG=364395

Review URL: https://codereview.chromium.org/248603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265612 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoImplement ManifestService::StartupInitializationComplete().
hidehiko@chromium.org [Wed, 23 Apr 2014 11:53:13 +0000 (11:53 +0000)]
Implement ManifestService::StartupInitializationComplete().

This CL introduces StartupInitializationComplete() message between a plugin
and the renderer, focusing on non-SFI mode.
Currently PluginReverseInterface::StartupInitializationComplete() is called
directly in ServiceRuntime::InitReverseService in non-SFI mode. However, it
is too early. Since it blocks the renderer's main thread by sync PPAPI IPC
message, when we support the open_resource() for non-SFI mode, it would cause
a deadlock issue.
This CL delays the invocation of StartupInitializationComplete until when
PPAPI IPC channel is ready in plugin side to follow NaCl's manner in SFI-mode.

TBR=jln@chromium.org
TEST=Ran browser_tests --gtest_filter=*NonSfi* locally, and ran trybots.
BUG=358431

Review URL: https://codereview.chromium.org/238353016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265611 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoFix link error when compiling with OpenSSL while using OS certs.
haavardm@opera.com [Wed, 23 Apr 2014 11:51:21 +0000 (11:51 +0000)]
Fix link error when compiling with OpenSSL while using OS certs.

Turn off OpenSSL client auth tests when use_openssl_certs==0.

OS client certifiates other than OpenSSL's struct x509 are not
yet supported for the OpenSSL integration.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/233133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265610 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoRe-enable rasterize_and_record_micro
skyostil@chromium.org [Wed, 23 Apr 2014 11:50:43 +0000 (11:50 +0000)]
Re-enable rasterize_and_record_micro

BUG=350684, 360666

Review URL: https://codereview.chromium.org/235173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265609 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoAdd chromium-side plumbing for ServiceWorkerGlobalScope.clients
kinuko@chromium.org [Wed, 23 Apr 2014 11:07:45 +0000 (11:07 +0000)]
Add chromium-side plumbing for ServiceWorkerGlobalScope.clients

BUG=363965
TEST=to be added in blink side
R=jam@chromium.org, jsbell@chromium.org, michaeln@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/246023004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265607 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoUpdate .DEPS.git
chrome-admin@google.com [Wed, 23 Apr 2014 10:41:12 +0000 (10:41 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265606 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoUpdate WebRtc/libjingle revision from r5831 to r5963.
perkj@chromium.org [Wed, 23 Apr 2014 10:40:20 +0000 (10:40 +0000)]
Update WebRtc/libjingle revision from r5831 to r5963.

This also temporaryly disable all WebRtcBrowserTest on Android.

TBR Ronghua for README file change.
R=henrika@chromium.org, phoglund@chromium.org
TBR=ronghuawu
BUG= 362852

Review URL: https://codereview.chromium.org/246063008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265605 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoRevert 265598 "Remove title and icon from chrome apps native sty..."
hashimoto@chromium.org [Wed, 23 Apr 2014 10:18:06 +0000 (10:18 +0000)]
Revert 265598 "Remove title and icon from chrome apps native sty..."

Causing failures on "Linux ASan LSan Tests (2)" with unit_tests ("ShapedAppWindowTargeterTest.ResizeInsetsWithinBounds")
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/1874

> Remove title and icon from chrome apps native style title bars.
>
> These windows aren't meant to have titles or icons, but still need to
> get a proper title as far as the OS is concerned. This means using a
> custom but glass frame, similarly to how unthemed browser windows look.
>
> BUG=339558
> TEST=Try out frame:chrome app windows windows on Windows 7, 8 and XP.
> Use the windows in various states (maximised, fullscreen, normal).
> Make sure they work after switching in and out of aero mode.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262516
>
> Review URL: https://codereview.chromium.org/213743017

TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/248083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265604 0039d316-1c4b-4281-b951-d872f2087c98

5 hours ago[SyncFS] Wrap callbacks on SyncWorker to relay them to original thread.
tzik@chromium.org [Wed, 23 Apr 2014 09:49:04 +0000 (09:49 +0000)]
[SyncFS] Wrap callbacks on SyncWorker to relay them to original thread.

Introduce a helper function to wrap a callback to ensure it runs on a specific thread.

BUG=347425
TEST=unit_tests --gtest_filter=DriveBackendCallbackHelperTest.*

Review URL: https://codereview.chromium.org/241633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265602 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoAdd command line flag for enabling notifications.
akuegel@chromium.org [Wed, 23 Apr 2014 09:47:52 +0000 (09:47 +0000)]
Add command line flag for enabling notifications.

This CL adds a command line flag that enables notifications a
custodian receives when a supervised user creates an access
request. Also the profile name is now uploaded in the access
request instead of the username (which is empty for a supervised user).

BUG=362553

Review URL: https://codereview.chromium.org/236593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265601 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSet proper default for multi-profile behavior of enterprise users.
mnissler@chromium.org [Wed, 23 Apr 2014 09:31:00 +0000 (09:31 +0000)]
Set proper default for multi-profile behavior of enterprise users.

The desired behavior in absence of policy is primary-only, i.e.
managed accounts shouldn't be allowed to become secondary profiles in
a multi-profile session by default. This change injects a default
policy setting if we don't get one from the server.

BUG=chromium:362412
TEST=Manual

Review URL: https://codereview.chromium.org/240783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265600 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoLand Recent QUIC changes.
rtenneti@chromium.org [Wed, 23 Apr 2014 09:23:25 +0000 (09:23 +0000)]
Land Recent QUIC changes.

Enable QUIC version 18.

Merge internal change: 65253875

Sent QUIC PING frames (or their equivalent) when a stream is open and
the connection has been idle for the half idle network timeout.

Merge internal change: 65326830
https://codereview.chromium.org/247723004/

In the QuicDispatcher we create two supported version vectors: one
containing all supported versions, one with the flow control versions
(i.e. >= 17) removed. This is so we can flip the flow control
reloadable flag off, and have the dispatcher create new connections
which don't support flow control.

Until we remove the flag, each endpoint MUST support at least one
version that does not use flow control. This fixes the end to end test
that would otherwise trigger:

https://code.google.com/p/chromium/codesearch#chromium/src/net/tools/quic/quic_dispatcher.cc&l=193

Merge internal change: 65249146
https://codereview.chromium.org/248373002/

Change log severity from DFATAL to ERROR, and remove test log
expectation. LOG(DFATAL) doesn't work well with parameterised tests.

Merge internal change: 65248174
https://codereview.chromium.org/246233008/

Add a new recent_min_rtt to QUIC's RttStats for use in BBR and similar
min_rtt dependent congestion control.

Merge internal change: 65224389
https://codereview.chromium.org/248213003/

Properly format IFCW values as numbers when printing QUIC handshakes.

Merge internal change: 65208800
https://codereview.chromium.org/246893011/

Added connection_creation_time to QuicConnectionStats. Deleted
connection creation_time_ from QuicConnection.

Merge internal change: 65189147
https://codereview.chromium.org/248353002/

Property pretty-print QUIC LOSS and LOSA handshake message values.

Merge internal change: 65143557
https://codereview.chromium.org/247193005/

Introduce QUIC version 18 which adds support for a PING frame, but does
not yet add support for {*sending* PING frames.

Fix to quic_connection_tests.cc which attempts to do a ping frame if the
version is > 18.

Merge internal change: 65137790
https://codereview.chromium.org/246773005/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/246673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265599 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoRemove title and icon from chrome apps native style title bars.
benwells@chromium.org [Wed, 23 Apr 2014 09:22:41 +0000 (09:22 +0000)]
Remove title and icon from chrome apps native style title bars.

These windows aren't meant to have titles or icons, but still need to
get a proper title as far as the OS is concerned. This means using a
custom but glass frame, similarly to how unthemed browser windows look.

BUG=339558
TEST=Try out frame:chrome app windows windows on Windows 7, 8 and XP.
Use the windows in various states (maximised, fullscreen, normal).
Make sure they work after switching in and out of aero mode.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262516

Review URL: https://codereview.chromium.org/213743017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265598 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoFix Watchlist for DeviceSensors
rijubrata.bhaumik@intel.com [Wed, 23 Apr 2014 09:12:48 +0000 (09:12 +0000)]
Fix Watchlist for DeviceSensors

After r265421, DeviceMotionAndOrientation is renamed to
DeviceSensors.

BUG=336424
NOTRY=true

Review URL: https://codereview.chromium.org/249063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265597 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoFix find_runtime_tools.py as a command-line tool.
dmikurube@chromium.org [Wed, 23 Apr 2014 09:12:07 +0000 (09:12 +0000)]
Fix find_runtime_tools.py as a command-line tool.

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/248573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265596 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoMove creation of webrtc specific MediaStreamVideoTrack classes to WebRtcMediaStreamAd...
perkj@chromium.org [Wed, 23 Apr 2014 09:10:53 +0000 (09:10 +0000)]
Move creation of webrtc specific MediaStreamVideoTrack classes to WebRtcMediaStreamAdapter.
This cl adds a new container for each webrtc Video track called WebRtcVideoTrackAdapter owned by WebRtcMediaStreamAdapter.
Furthermore it cleans up the use of MediaStreamDepencyFactory now when its not needed.

BUG=323223

Review URL: https://codereview.chromium.org/230833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265595 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoVEATest: Add more testcases for bitrate/framerate changes mid-stream.
posciak@chromium.org [Wed, 23 Apr 2014 09:05:50 +0000 (09:05 +0000)]
VEATest: Add more testcases for bitrate/framerate changes mid-stream.

Add mid-stream bitrate and framerate switch tests. Also move performance
test earlier to just after receiving the last frame in order to not
include time used for flushing the encoder and cleanup.

BUG=None
TEST=Run the test

Review URL: https://codereview.chromium.org/246563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265594 0039d316-1c4b-4281-b951-d872f2087c98

6 hours ago[SyncFS] Make ListChangesTask run as a background task
tzik@chromium.org [Wed, 23 Apr 2014 09:04:09 +0000 (09:04 +0000)]
[SyncFS] Make ListChangesTask run as a background task

ListChangesTask is ready to run in parallel after this CL lands.
Note that the number of background task is still limited to 0 in production code, so the task runs in sequential.

BUG=44769
TEST=unit_tests --gtest_filter=ListChangesTaskTest.*

Review URL: https://codereview.chromium.org/246163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265593 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoUse platform's device scale factor for cursor instead of gfx::Display because gfx...
oshima@chromium.org [Wed, 23 Apr 2014 09:03:29 +0000 (09:03 +0000)]
Use platform's device scale factor for cursor instead of gfx::Display because gfx::Display's DSF may differ from
platform's one when UI scaling is used.

BUG=361672
TEST=covered by unit test

Review URL: https://codereview.chromium.org/226293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265592 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoMake streamlined hosted apps browser toolbar only appear for bookmark apps.
calamity@chromium.org [Wed, 23 Apr 2014 09:02:09 +0000 (09:02 +0000)]
Make streamlined hosted apps browser toolbar only appear for bookmark apps.

This CL makes streamlined hosted apps only show the browser toolbar if the
app is a bookmark app. This CL also fixes an issue where the browser toolbar
was not showing on any app windows in streamlined hosted app mode.

BUG=318607

Review URL: https://codereview.chromium.org/240213008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265591 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoAdd a flag to use the video overlay for the embedded video forcefully.
ycheo@chromium.org [Wed, 23 Apr 2014 08:57:05 +0000 (08:57 +0000)]
Add a flag to use the video overlay for the embedded video forcefully.

This flag is for the purpose to test the hole punching logic in Android WebView.

BUG=329447

Review URL: https://codereview.chromium.org/231643007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265590 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoFiles.app: Use volumeInfo.label in util.getEntryLabel.
kinaba@chromium.org [Wed, 23 Apr 2014 08:55:35 +0000 (08:55 +0000)]
Files.app: Use volumeInfo.label in util.getEntryLabel.

This way, all uses of human-readable string representation of each volume in
Files.app consistently refer the same single source.

BUG=366001

Review URL: https://codereview.chromium.org/248093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265589 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoRemove socket hacks for FreeBSD and OpenBSD
mdempsky@chromium.org [Wed, 23 Apr 2014 08:54:16 +0000 (08:54 +0000)]
Remove socket hacks for FreeBSD and OpenBSD

Support for UNIX-domain SOCK_SEQPACKET sockets was added in FreeBSD 9
(Jan 2012) and OpenBSD 5.0 (Nov 2011):

http://www.freebsd.org/cgi/man.cgi?query=unix&sektion=4&manpath=FreeBSD+9.0-RELEASE&format=html
http://www.openbsd.org/cgi-bin/man.cgi?query=unix&sektion=4&manpath=OpenBSD+5.0&format=html

Review URL: https://codereview.chromium.org/247733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265588 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agosync: always send entity specifics with bookmark tombstones
tim@chromium.org [Wed, 23 Apr 2014 08:53:37 +0000 (08:53 +0000)]
sync: always send entity specifics with bookmark tombstones
BUG=365752

Review URL: https://codereview.chromium.org/248053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265587 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoNon-SFI NaCl: Do not run sandbox tests with ASan or TSan
hamaji@chromium.org [Wed, 23 Apr 2014 08:51:04 +0000 (08:51 +0000)]
Non-SFI NaCl: Do not run sandbox tests with ASan or TSan

This test started failing (again) with ASan:

http://build.chromium.org/p/tryserver.chromium/builders/linux_asan/builds/69810

For some reason, I cannot locally reproduce this issue but it
looks like ASan started calling stat internally. ASan would
give us a few benefits, but it seems to cost too much. As for
TSan, I do not see any reason we want it.

ASan and TSan will not work after we switch to newlib anyway,
so let's just stop working for them.

Now we do not return EPERM from getpid, ioctl, and readlink.
We changed them for ASan but now they can just raise SIGSYS.

TEST=out/Release/nacl_loader_unittests
TEST=trybots
BUG=359285, 365890
R=jln@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/244333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265586 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoCoreAnimation: Fix fade-out effect on resize
ccameron@chromium.org [Wed, 23 Apr 2014 08:48:18 +0000 (08:48 +0000)]
CoreAnimation: Fix fade-out effect on resize

Wrap all setFrame calls made by TabContentsView in
ScopedCAActionDisablers, to disable the fade-in and
fade-out animations when resizing.

BUG=364808

Review URL: https://codereview.chromium.org/247193008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265585 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoPost the callback methods on correct thread and address some nits
sgurun@chromium.org [Wed, 23 Apr 2014 08:46:44 +0000 (08:46 +0000)]
Post the callback methods on correct thread and address some nits

BUG=b/12983007

Review URL: https://codereview.chromium.org/247063008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265584 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoFix blink_perf indentation mistake.
nednguyen@google.com [Wed, 23 Apr 2014 08:45:26 +0000 (08:45 +0000)]
Fix blink_perf indentation mistake.
Line 37 was indented due to mistake in https://codereview.chromium.org/241853004/
BUG=

Review URL: https://codereview.chromium.org/247033005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265583 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoRefactor media::VideoRendererImpl tests to use more human-friendly notation for queue...
scherkus@chromium.org [Wed, 23 Apr 2014 08:43:54 +0000 (08:43 +0000)]
Refactor media::VideoRendererImpl tests to use more human-friendly notation for queueing frames.

While the tests are more verbose there is now less magic happening when using helper functions. The end result is a more flexible and understandable test harness, which will be handy when switching to using VideoFrameScheduler.

BUG=110814

Review URL: https://codereview.chromium.org/246313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265582 0039d316-1c4b-4281-b951-d872f2087c98

6 hours ago[Telemetry] Set the browser in the backend before starting it.
tonyg@chromium.org [Wed, 23 Apr 2014 08:39:20 +0000 (08:39 +0000)]
[Telemetry] Set the browser in the backend before starting it.

This is a partial reland of r264756 which was reverted.

BUG=223572
TBR=oysteine@chromium.org

Review URL: https://codereview.chromium.org/248053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265581 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoCleanup: Fix a bunch of random style cleanups and lint errors.
thestig@chromium.org [Wed, 23 Apr 2014 08:37:35 +0000 (08:37 +0000)]
Cleanup: Fix a bunch of random style cleanups and lint errors.

Review URL: https://codereview.chromium.org/246403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265580 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoModify smoothness measurement to measure smoothness for ranges around gestures.
nednguyen@google.com [Wed, 23 Apr 2014 08:36:45 +0000 (08:36 +0000)]
Modify smoothness measurement to measure smoothness for ranges around gestures.

BUG=364046

Review URL: https://codereview.chromium.org/240443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265579 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoMojo: Generate TypeTraits specializations for enums.
sammc@chromium.org [Wed, 23 Apr 2014 08:35:35 +0000 (08:35 +0000)]
Mojo: Generate TypeTraits specializations for enums.

This is necessary to use interfaces with responses directly containing
enums. Without this change, Callback<>::Runnable::Run() takes enum
arguments by const reference, but the generated ProxyToResponder tries
to override it with a method that takes enum arguments by value. This
change causes Callback<>::Runnable::Run() to also take enums by value.

BUG=None

Review URL: https://codereview.chromium.org/246783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265578 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoAdding check for MIME types that do not take codecs parameter
amogh.bihani@samsung.com [Wed, 23 Apr 2014 08:29:52 +0000 (08:29 +0000)]
Adding check for MIME types that do not take codecs parameter

audio/mpeg, audio/mp3, audio/x-mp3 do not take any 'codecs' parameter and
canPlayType query must return "probably" of them. Browser in general returns
"maybe" when no 'codecs' parameter is present.
We need to check whether the mime type specifically wants 'codecs' parameter
to be absent.

BUG=53193

Review URL: https://codereview.chromium.org/228823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265577 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agonet: Remove unused NetLog parameter from FileStream's ctor
hashimoto@chromium.org [Wed, 23 Apr 2014 08:28:45 +0000 (08:28 +0000)]
net: Remove unused NetLog parameter from FileStream's ctor

Remove NetLog parameter from FileStream's ctor to which all users are passing NULL.
Remove BoundNetLog from FileStream which does nothing if net_log==NULL.

Remove an enum (FileErrorSource), methods (RecordError, BeginOpenEvent, ProcessOpenError, ProcessAsyncResult, OnAsyncCompleted) and member variables (bound_net_log_ and error_source_) from file_stream_context.h.

BUG=361496
TEST=git cl try

Review URL: https://codereview.chromium.org/242873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265576 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoPaint the background instead of setting background when booting with multiple displays
oshima@chromium.org [Wed, 23 Apr 2014 08:28:09 +0000 (08:28 +0000)]
Paint the background instead of setting background when booting with multiple displays

BUG=chrome-os-partner:27441
TEST=tested on lumpy + daisy

Review URL: https://codereview.chromium.org/245293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265575 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoCleanup: Get rid of base::UTF16ToWideHack.
thestig@chromium.org [Wed, 23 Apr 2014 08:26:59 +0000 (08:26 +0000)]
Cleanup: Get rid of base::UTF16ToWideHack.

BUG=23581

Review URL: https://codereview.chromium.org/246553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265574 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoAddition of assets for moving the local ntp images.
calamity@chromium.org [Wed, 23 Apr 2014 08:26:03 +0000 (08:26 +0000)]
Addition of assets for moving the local ntp images.

This is the binary addition portion of:
https://codereview.chromium.org/209663003/

BUG=349727
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/248843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265573 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoLinux: Detect host g++ version as well as target g++ version.
thestig@chromium.org [Wed, 23 Apr 2014 08:20:16 +0000 (08:20 +0000)]
Linux: Detect host g++ version as well as target g++ version.

BUG=360082

Review URL: https://codereview.chromium.org/247623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265572 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoMove ui_test_support target into ui_base.gyp
tfarina@chromium.org [Wed, 23 Apr 2014 08:19:44 +0000 (08:19 +0000)]
Move ui_test_support target into ui_base.gyp

This target is related to ui/base and in turn contain only files from
ui/base. So move it to the appropriate place and rename to
ui_base_test_support.

BUG=299841,331829
TEST=ash_unittests,unit_tests,aura_unittests,ui_unittests,views_unittests
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/247293008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265571 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agodrive: Add drive::test_util::SetUpTestEntries
hashimoto@chromium.org [Wed, 23 Apr 2014 08:19:02 +0000 (08:19 +0000)]
drive: Add drive::test_util::SetUpTestEntries

Add SetUpTestEntries() to replace root_feed.json

Move MIME type constants from drive_api_util.cc to drive_api_util.h
Add FakeDriveService::AddNewDirectoryWithResourceId().
Change handling of empty parent_resource_id in FakeDriveService::AddNewEntry() to add orphaned files.

BUG=334544

Review URL: https://codereview.chromium.org/246963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265570 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agocontent: Move WebTestProxy and WebFrameTestProxy into content namespace.
tfarina@chromium.org [Wed, 23 Apr 2014 08:18:27 +0000 (08:18 +0000)]
content: Move WebTestProxy and WebFrameTestProxy into content namespace.

BUG=331299
TEST=None, built it. No functional change.
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/248633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265569 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoRemove suppressions for ServiceWorkerDispatcher leak (hopefully fixed now)
kinuko@chromium.org [Wed, 23 Apr 2014 08:14:31 +0000 (08:14 +0000)]
Remove suppressions for ServiceWorkerDispatcher leak (hopefully fixed now)

BUG=364822
TBR=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/247133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265568 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoUnbreak GN bootstrap script.
tfarina@chromium.org [Wed, 23 Apr 2014 08:10:18 +0000 (08:10 +0000)]
Unbreak GN bootstrap script.

It now should bootstrap GN and then build gn with itself through the end
without errors.

BUG=348272
TEST=./bootstrap.py
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/246753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265567 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoFix relative/absolute path handling in checkdeps.py
nbarth@chromium.org [Wed, 23 Apr 2014 08:09:48 +0000 (08:09 +0000)]
Fix relative/absolute path handling in checkdeps.py

Currently checkdeps.py fails if you specify a start dir and a *relative* path for root, such as:
tools/checkdeps/checkdeps.py --root third_party/WebKit Source/bindings
(Exact error is a stack overflow, due to infinite recursion on /)
This is because it makes the start dir absolute, but doesn't make the root dir absolute.

Simple fix, by making the root dir absolute.
Also checks that directory to check is actually a subdirectory of root, which otherwise has the same stack overflow error.

R=joi
BUG=365190

Review URL: https://codereview.chromium.org/244673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265566 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoChanges layer reparenting to happen after a window parent is changed in aura::Window...
varkha@chromium.org [Wed, 23 Apr 2014 08:09:10 +0000 (08:09 +0000)]
Changes layer reparenting to happen after a window parent is changed in aura::Window::AddChild

BUG=364498
TEST=Follow steps in the bug or at https://code.google.com/p/chromium/issues/detail?id=364517. Ensure no crash.
TEST=aura_unittests --gtest_filter=WindowTest.RootWindowSetWhenReparenting

This addresses a class of crashes that happen when layers bounds are updated while the code is in child->ReparentLayers inside Window::AddChild where the window is removed from its old parent but not yet added to the new parent. GetRootWindow would return NULL causing crashes in places where we assume that (Window::IsVisible() == (Window::GetRootWindow() != NULL)).
There was a discussion about windows that are detached from the root - see here - https://codereview.chromium.org/82283002#msg12. It looks like the result of that discussion was that we should fix places where we assume that IsVisible() == (Window::GetRootWindow() != NULL). VideoDetector::MaybeNotifyObservers is one such place, NativeWidgetAura::IsMouseEventsEnabled() is another such place, there are probably many more.

This CL tries to avoid this whole class of errors by restoring the sequence in AddChild that existed before https://codereview.chromium.org/82283002.

Review URL: https://codereview.chromium.org/241243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265565 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoDo not provide the input level if the APM is not enabled in Chrome.
xians@chromium.org [Wed, 23 Apr 2014 08:08:42 +0000 (08:08 +0000)]
Do not provide the input level if the APM is not enabled in Chrome.

NOTRY=true
BUG=365616
TEST=content_unittests --gtest_filter=*GetSignalLevel*"

Review URL: https://codereview.chromium.org/247183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265564 0039d316-1c4b-4281-b951-d872f2087c98

8 hours agoUpdate .DEPS.git
chrome-admin@google.com [Wed, 23 Apr 2014 07:17:12 +0000 (07:17 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265563 0039d316-1c4b-4281-b951-d872f2087c98

8 hours agoBlink roll 172130:172317
dominicc@google.com [Wed, 23 Apr 2014 07:16:47 +0000 (07:16 +0000)]
Blink roll 172130:172317

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172131:172317&mode=html
TBR=aboxhall@chromium.org
BUG=

Review URL: https://codereview.chromium.org/248813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265562 0039d316-1c4b-4281-b951-d872f2087c98

8 hours agoRevert "Move Files.app files to ui/file_manager"
hashimoto@chromium.org [Wed, 23 Apr 2014 07:10:58 +0000 (07:10 +0000)]
Revert "Move Files.app files to ui/file_manager"

> Move Files.app files to ui/file_manager
>
> BUG=345171
> TEST=manually tested
> R=hirono@chromium.org
>
> Review URL: https://codereview.chromium.org/247123002

TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/246533008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265561 0039d316-1c4b-4281-b951-d872f2087c98

8 hours agoUpdate .DEPS.git
chrome-admin@google.com [Wed, 23 Apr 2014 07:06:08 +0000 (07:06 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265560 0039d316-1c4b-4281-b951-d872f2087c98

8 hours agoRevert of SDK building script now uses package_version to extract. (https://coderevie...
hidehiko@chromium.org [Wed, 23 Apr 2014 07:05:22 +0000 (07:05 +0000)]
Revert of SDK building script now uses package_version to extract. (https://codereview.chromium.org/235603004/)

Reason for revert:
This update breaks PPAPI*NonSfi tests on linux-32bits bot. See also crbug.com/365817

Original issue's description:
> NaCl: Update revision in DEPS, r13018 -> r13062.
>
> Chromium NaCl scripts now uses package_version to extract.
>
> Now that we have split up the toolchain into multiple tars, we should
> use the package versioning script to manage which tars to extract.
> Unfortunately, currently the SDK uses different directory names compared
> to what the NaCl toolchain directories normally use, so we also must map
> and move the toolchain directories to the SDK ones.
>
> TEST= trybots
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265303

TBR=noelallen@chromium.org,bradnelson@chromium.org,jvoung@chromium.org,mseaborn@chromium.org,dyen@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/247143007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265559 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoServiceWorker should be able to send messages to browser (not only for reply)
kinuko@chromium.org [Wed, 23 Apr 2014 06:31:22 +0000 (06:31 +0000)]
ServiceWorker should be able to send messages to browser (not only for reply)

Currently ServiceWorker (in an EmbeddedWorker) can only send a 'reply'
message to the browser, as ServiceWorkerScriptContext::SendMessageToBrowser()
always takes |request_id| and the message is handled based on the |request_id|
in the receiver side, but in order to implement more features (e.g. .clients)
it needs to be able to initiate the communication.

This patch:
- Splits SendMessageToBrowser message into two: MessageToBrowser and ReplyToBrowser
- Renames SendMessageTo* message names to MessageTo* or ReplyTo* (cleanup, to avoid confusion)
- Renames OnSendMessageTo* message handlers to OnMessageTo* or OnReplyTo* (ditto)
- Renames EmbeddedWorkerInstance::Observer to ::Listener to make it clear what it does

BUG=363965
TEST=ServiceWorkerVersionTest.ReceiveMessageFromWorker
R=falken@chromium.org, jam@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/240243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265558 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoAllow external file systems to overlap for media galleries only.
vandebo@chromium.org [Wed, 23 Apr 2014 06:29:26 +0000 (06:29 +0000)]
Allow external file systems to overlap for media galleries only.

The restriction that external file systems should not overlap is only
needed by the Files app and should be tracked at a higher level. This
makes the external mount point provider blind to overlaps involving
media galleries until the restriction can be hoisted to higher level
code.

BUG=363454,365502

Review URL: https://codereview.chromium.org/247993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265557 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoCherry-pick upstream bugfix for incremental decode of lossy-alpha
urvang@google.com [Wed, 23 Apr 2014 06:24:13 +0000 (06:24 +0000)]
Cherry-pick upstream bugfix for incremental decode of lossy-alpha

When remapping buffer, br->eos_ was wrongly being set to true for
certain images.

Cherry-picked from: https://gerrit.chromium.org/gerrit/#/c/69849/
Tested in libwebp upstream.

BUG=364830

Review URL: https://codereview.chromium.org/246773006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265556 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoRemove bookmark_model.h includes from places where it is not needed.
tfarina@chromium.org [Wed, 23 Apr 2014 06:22:25 +0000 (06:22 +0000)]
Remove bookmark_model.h includes from places where it is not needed.

Those places just want to mess with BookmarkNode, so we can just include
components/bookmarks/core/browser/bookmark_node.h instead.

BUG=360643
TEST=chrome, unit_tests they both link
R=sky@chromium.org

Review URL: https://codereview.chromium.org/245893006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265555 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoUpdate .DEPS.git
chrome-admin@google.com [Wed, 23 Apr 2014 06:22:08 +0000 (06:22 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265554 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoMake registrations being installed for the first time findable
michaeln@chromium.org [Wed, 23 Apr 2014 06:21:57 +0000 (06:21 +0000)]
Make registrations being installed for the first time findable

Change the semantics of the ServiceWorkerStorage::Find methods so unstored
registrations being installed for the very first time can also be found. The
ServiceWorkerRequestHandler has a use case for that behavior.
Also updated the unittests to check for that behavior.

BUG=364247
TEST=service_worker_storage_unittest.cc

Review URL: https://codereview.chromium.org/246483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265553 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoUpdate src/tools/gyp from r1892 to r1895.
wtc@chromium.org [Wed, 23 Apr 2014 06:21:13 +0000 (06:21 +0000)]
Update src/tools/gyp from r1892 to r1895.

R=scottmg@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/247193007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265552 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoMove Files.app files to ui/file_manager
yoshiki@chromium.org [Wed, 23 Apr 2014 06:16:35 +0000 (06:16 +0000)]
Move Files.app files to ui/file_manager

BUG=345171
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/247123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265551 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoFix two accessibility audit errors of Autofill edit address overlay.
tkent@chromium.org [Wed, 23 Apr 2014 06:14:46 +0000 (06:14 +0000)]
Fix two accessibility audit errors of Autofill edit address overlay.

- Country selector didn't have any accessibility label.
- Delete button of DeletableItem didn't have any accessibility label.

BUG=

Review URL: https://codereview.chromium.org/246603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265550 0039d316-1c4b-4281-b951-d872f2087c98

9 hours ago[Telemetry] Always update device apk.
tonyg@chromium.org [Wed, 23 Apr 2014 06:13:50 +0000 (06:13 +0000)]
[Telemetry] Always update device apk.

This allows the bisect bot to rely on Telemetry to do apk installation of the
most recently built local ChromeShell.

BUG=343632

Review URL: https://codereview.chromium.org/248133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265549 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoRevert of mac: History swiping doesn't work right with iframes. (https://codereview...
erikchen@chromium.org [Wed, 23 Apr 2014 06:13:04 +0000 (06:13 +0000)]
Revert of mac: History swiping doesn't work right with iframes. (https://codereview.chromium.org/227043012/)

Reason for revert:
This CL causes regressions in vertical content scrolling.

https://code.google.com/p/chromium/issues/detail?id=365034

Original issue's description:
> mac: History swiping doesn't work right with iframes.
>
> This CL is a reland of crrev.com/194713016. The reason that the previous
> attempt to land this CL failed was because Blink was claiming to handle events
> that it was actually ignoring. This has been fixed in crrev.com/219473003,
> which also added unit-tests to ensure that the new behavior is correct.
>
> In addition, this reland removes all logic related to the isPinnedLeft and
> isPinnedRight properties of the history swiper. They are no longer required
> because they are a subset of the state that determines whether blink will
> handle an event, which is now being correctly propagated to the history swiper.
> This fixes a long outstanding bug (I don't think it's ever worked) where the
> pinned state is not correctly propagated to the history swiper, which prevents
> history navigation. (Blink only sends callbacks for when a user scrolls or the
> window is resized. If the user performs a history navigation, the pinned state
> might change, but Blink will not send a callback to update the state of the
> history swiper).
>
> ----------------Description from first attempt to land this CL----------------
>
> In the previous behavior, it was possible for a user to start scrolling an
> iframe with the touch pad, and then trigger history navigation. This happened
> because the Cocoa view only received callbacks for whether an event in a
> gesture wasn't handled. If any event in a gesture happened to not be handled by
> blink, then that event could trigger history swiping, even though blink may
> have handled earlier events in the same gesture!
>
> My solution is to propagate the information for whether an event was handled to
> the Cocoa view. History swiping is only enabled if no event is ever handled by
> blink.
>
> BUG=321437
> TEST=Navigate to www.google.com. Then navigate to
> http://codepen.io/anon/pen/ujsec. Place the cursor in the box that says "place
> cursor here", and start a downwards 2-finger swipe. Half way through the swipe,
> change directions and swipe to the left (or right, depending on your settings)
> to navigate backwards in history. Prior to this change, the history swipe arrow
> would appear. In this change, the history swipe arrow no longer appears.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262572

TBR=thakis@chromium.org,avi@chromium.org
BUG=321437

Review URL: https://codereview.chromium.org/248383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265548 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agocc: Use TaskGraphRunner instance in DirectRasterWorkerPool to run tasks.
reveman@chromium.org [Wed, 23 Apr 2014 06:12:18 +0000 (06:12 +0000)]
cc: Use TaskGraphRunner instance in DirectRasterWorkerPool to run tasks.

This makes the DirectRasterWorkerPool code consistent with
ImageRasterWorkerPool. At the moment this means some code
duplication but that can be reduced in follow up patches.

This is expected to have a negative effect on perftests.
DirectRasterWorkerPool is expected to have similar
performance as ImageRasterWorkerPool after this change.

BUG=365840

Review URL: https://codereview.chromium.org/246633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265547 0039d316-1c4b-4281-b951-d872f2087c98

10 hours agoRevert 265530 "Gets Add/Remove working correctly in the view man..."
sky@chromium.org [Wed, 23 Apr 2014 04:50:08 +0000 (04:50 +0000)]
Revert 265530 "Gets Add/Remove working correctly in the view man..."

> Gets Add/Remove working correctly in the view manager
>
> Also adds tests
>
> BUG=365012
> TEST=covered by tests
> R=ben@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265509
>
> Review URL: https://codereview.chromium.org/247363006

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/248663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265545 0039d316-1c4b-4281-b951-d872f2087c98

10 hours agoRevert 265496 "Rewrite functions from WebPasswordFormData and We..."
sky@chromium.org [Wed, 23 Apr 2014 04:47:01 +0000 (04:47 +0000)]
Revert 265496 "Rewrite functions from WebPasswordFormData and We..."

Reverting as this seems to have caused a bunch of leaks on asan
bots. See following for one:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/1584/steps/browser_tests/logs/EnsureNoFormSeenIfTooFewFields

> Rewrite functions from WebPasswordFormData and WebPasswordFormUtils in
> password_form_conversion_utils.
>
> There are Some old Blink code implemented in Webkit that predates the
> Chromium/WebKit API, specifically WebPasswordFormData and WebPasswordFormUtils. At
> this point the split just makes this code harder to update, as you need to wait
> for a Blink roll when adding a new element to autofill::PasswordForm. This patch is
> re-writing this code in components/autofill/content/renderer/password_form_conversion_util
> s to make it cleaner.
>
> BUG=None
>
> Review URL: https://codereview.chromium.org/225823006

TBR=ziran.sun@samsung.com

Review URL: https://codereview.chromium.org/246393011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265544 0039d316-1c4b-4281-b951-d872f2087c98

10 hours agoRevert 265469 "Fix slow TextureManager::StopTracking()"
sky@chromium.org [Wed, 23 Apr 2014 04:45:19 +0000 (04:45 +0000)]
Revert 265469 "Fix slow TextureManager::StopTracking()"

This broke mac and asan builders. See following for one:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/1584/steps/gpu_unittests/logs/AsyncPixelTransfers

> Fix slow TextureManager::StopTracking()
>
> Iterating an ObserverList which uses WeakPtr items seems very slow.
>
> Changing to std::vector<> gives about a 15X speedup.
> Further skipping the observer call backs for TextureRefs with no current observers should cut this close to 0.
>
> BUG=365536
>
> Review URL: https://codereview.chromium.org/246353002

TBR=vmiura@chromium.org

Review URL: https://codereview.chromium.org/247343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265542 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agoRemoves InputMethodContainer, merge into SettingsBubbleContainer (2)
mukai@chromium.org [Wed, 23 Apr 2014 04:29:11 +0000 (04:29 +0000)]
Removes InputMethodContainer, merge into SettingsBubbleContainer (2)

We don't have to have a container for IME separately, the settings
bubble container is better for the IME UIs.

This switch also makes the following effects:
- IME UIs would appear in the lock screen / login screen
- IME UIs wouldn't move across the root window when removed (like
  display state switch among mirroring<->extended)

The first is good, because we can show the mode indicator when
switching the layout between qwerty and Dvorak. Candidate windows
will not appear in lock/login screen anyways.

The second seems no problem because IME UIs are more ephemeral
anyways. People won't get frustrated if disappears in such situation.
They will re-appear when the user types another key.

This is the reland of r265161. r265161 was reverted because
there's a conflict about keyboard focus among the candidate window
and the text-input context. This CL contains the fix for this
situation.

BUG=364667
TBR=oshima@chromium.org, shuchen@chromium.org

Review URL: https://codereview.chromium.org/248133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265541 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agoUTF8 Adjustments for FormatURL(): Fix Overly-Aggressive DCHECK
mpearson@chromium.org [Wed, 23 Apr 2014 04:28:38 +0000 (04:28 +0000)]
UTF8 Adjustments for FormatURL(): Fix Overly-Aggressive DCHECK

This DCHECK is hard to understand, but now it's right.

I'm okay with removing it if you think it's too confusing.

TBR=willchan
(no review necessary; just for owners approval.  only mucks with tests.)

BUG=365384

Review URL: https://codereview.chromium.org/248453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265540 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agoOmnibox: Make URLs of Bookmarks Searchable
mpearson@chromium.org [Wed, 23 Apr 2014 04:28:07 +0000 (04:28 +0000)]
Omnibox: Make URLs of Bookmarks Searchable

In particular, this makes
* BookmarkIndex index the URLs for bookmarks
* BookmarkIndex search for matches (match positions) within those URLs
* BookmarkProvider score based on both title and URL matches

All these is guarded by a field trial, also added in this changelist.

I added ample unit tests.

I also verified this works by testing it interactively using a local variations server and --force-fieldtrials.

BUG=157204

Review URL: https://codereview.chromium.org/184663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265539 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agoUpdate current time and pipeline of time update on first audio buffer.
dalecurtis@chromium.org [Wed, 23 Apr 2014 04:27:27 +0000 (04:27 +0000)]
Update current time and pipeline of time update on first audio buffer.

Previously we always waited until the 2nd audio buffer before
firing Pipeline::OnAudioTimeUpdate(). This causes the first time
update to be delayed according to the audio buffer size, which is
awkward.

Instead, notify the pipeline on the first audio buffer to avoid the
extra latency incurred while waiting for the next buffer.

BUG=365470
TEST=new unittest.

Review URL: https://codereview.chromium.org/245963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265538 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agosync: Sticky scroll-to-bottom on about:sync
rlarocque@chromium.org [Wed, 23 Apr 2014 04:20:28 +0000 (04:20 +0000)]
sync: Sticky scroll-to-bottom on about:sync

Updates the sync protocol events UI to keep scrolling down if new events
are added while the scroll bar is already at the bottom.  If the logs
were not scrolled to the bottom, then the scrollTop is left unmodified.

Think of it as "gnome-terminal" style scrolling.

Also fixes a few comments in about.js.

BUG=362820

Review URL: https://codereview.chromium.org/246643011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265535 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agoCopy Android select popup image files in preparation for dropdown popup on tablets
keishi@chromium.org [Wed, 23 Apr 2014 04:20:17 +0000 (04:20 +0000)]
Copy Android select popup image files in preparation for dropdown popup on tablets

Copying Android select popup image files in preparation for the dropdown popup on tablets
https://codereview.chromium.org/231953003/

BUG=314713
R=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/246233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265534 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agoFixing odd animations for the backdrop when exiting / entering overview / maximize...
skuhne@chromium.org [Wed, 23 Apr 2014 04:19:58 +0000 (04:19 +0000)]
Fixing odd animations for the backdrop when exiting / entering overview / maximize mode & missing fill behind shelf

BUG=365866, 365740
TEST=visual

Review URL: https://codereview.chromium.org/248413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265533 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agoFixing a race condition in landmines.py
smut@google.com [Wed, 23 Apr 2014 04:19:23 +0000 (04:19 +0000)]
Fixing a race condition in landmines.py

Landmines.py had some logic where it would first check if a directory existed before creating it, but this was sometimes causing an exception wherein the file was reported as existing during the os.mkdirs call, even though it was not reported as existing during the os.path.exists call.

Review URL: https://codereview.chromium.org/248343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265532 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agoFix client certificate regressions on Android < 4.2
tsniatowski@opera.com [Wed, 23 Apr 2014 04:18:50 +0000 (04:18 +0000)]
Fix client certificate regressions on Android < 4.2

https://codereview.chromium.org/166143002 refactored the code to use the
AndroidPrivateKey wrapper class rather than Java's PrivateKey directly,
but this one line of code was not updated.  As a result, the test will
always fail and client certificates won't work on Android versions prior
to 4.2 (this is a compatibility code path, which is probably why it
wasn't caught in testing or review).

In addition, while https://codereview.chromium.org/182933002 updated the
code to to fix 64-bit compilation issues, it missed the point that this
is compatibility code meant to run only on earlier versions of Android
that aren't 64-bit safe to begin with. As a result, a method called via
reflection will return an unexpected integer instead of a long, causing
the code to fail (even in 32-bit mode).

Fix by conservatively casting the return value through Number instead,
which will work with both int and long. (The earlier Android versions
that this code is targeting are still not 64-bit safe, but the
compatibility code should not cause any compile issues.)

Investigation credit goes out to kimn@opera.com.

BUG=360406

Review URL: https://codereview.chromium.org/246423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265531 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agoGets Add/Remove working correctly in the view manager
sky@chromium.org [Wed, 23 Apr 2014 04:18:12 +0000 (04:18 +0000)]
Gets Add/Remove working correctly in the view manager

Also adds tests

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265509

Review URL: https://codereview.chromium.org/247363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265530 0039d316-1c4b-4281-b951-d872f2087c98