chromium/deps/icu46.git
2 weeks agoEnable 64-bit build of host toolset master
torne@chromium.org [Thu, 10 Apr 2014 08:04:20 +0000 (08:04 +0000)]
Enable 64-bit build of host toolset

When building v8 mksnapshot host toolset as 64-bit, it requires icu to
be 64-bit also.

BUG=346626
R=jochen@chromium.org, jshin@chromium.org

Review URL: https://codereview.chromium.org/212593002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@262949 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoAdd the minimal Tajik locale part 2
jshin@chromium.org [Tue, 25 Mar 2014 19:58:08 +0000 (19:58 +0000)]
Add the minimal Tajik locale part 2

Add lang/tg.txt to get GetAvailableLocale not return Tajik.

R=rouslan@chromium.org
TBR=rouslan@chromium.org
BUG=354658
TEST=See the bug.

Review URL: https://codereview.chromium.org/211623002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@259309 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoFix the assembly file for Mac
jshin@chromium.org [Thu, 20 Mar 2014 18:30:42 +0000 (18:30 +0000)]
Fix the assembly file for Mac

icu_use_data_file_flag is the default so that this file is not used unless icu_use_data_file_flag is set to 0. Just in case, I'm fixing this file.

A fix is a one liner (one character long). '_' was missing in the previous check-in.

@@ -5,7 +5,7 @@
        .data
        .const
        .align 4
-icudt46_dat:
+_icudt46_dat:

R=mark@chromium.org, torne@chromium.org
TBR=mark@chromium.org
BUG=NONE
TEST=With icu_use_data_file_flag=0 in GYPDEFINES, Mac build succeeds.

Review URL: https://codereview.chromium.org/206273002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@258359 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoAdd support for QNX Neutrino part2
jshin@chromium.org [Thu, 20 Mar 2014 00:02:18 +0000 (00:02 +0000)]
Add support for QNX Neutrino part2

pqnx.h was not added in the previous CL by mistake
(https://codereview.chromium.org/195973005/ ).

A spurious tab in icu.gyp was removed.

README.chromium was updated to clarify how pqnx.h was generated.
platform.qnx.patch was made against a copy of plinux.h

BUG=NONE
TEST=icu is built properly on qnx. After DEPS roll, net_unittests:*IDN* and base_unittests:*String* all pass on qnx.`
R=mark@chromium.org

Review URL: https://codereview.chromium.org/203823003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@258166 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoAdd support for QNX Neutrino.
jshin@chromium.org [Mon, 17 Mar 2014 21:59:42 +0000 (21:59 +0000)]
Add support for QNX Neutrino.

This patch incorporates a change to source/common/putil.c
fetched from upstream.

In addition, it undefines 'si_value' in source/common/ucnvmbcs.c to
avoid a collision with 'si_value' defined on some platforms.

Patch by:
 Eli Fidler <efidler@blackberry.com>,
 Jeff Rogers <jrogers@blackberry.com>,
 Cosmin Truta <ctruta@blackberry.com>.

The original CL is at https://codereview.chromium.org/141063008/

README.chromium was slightly updated to refer to the upstream change for
si_value.

TBR=mark@chromium.org
BUG=NONE
TEST=icu is built properly on qnx. After DEPS roll, net_unittests:*IDN* and base_unittests:*String* all pass on qnx.

Review URL: https://codereview.chromium.org/195973005

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@257503 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoAdd the minimal Tajik locale data and update tz data
jshin@chromium.org [Mon, 17 Mar 2014 17:34:49 +0000 (17:34 +0000)]
Add the minimal Tajik locale data and update tz data

1. Add the minimal Tajik locale (exemplar character sets and script) for
   for Tajik spellchecking

2. Update the timezone data to 2014a  (the latest as of today)

3. Drop tranlsiteration files for case changes except for el_Upper.txt because
   all others (Turkic and Lithuanian) are covered by ICU's case changing API
   without relying on the transliterator.  Blink was already changed to use the regular ICU case changing API except for Greek uppercasing for which transliteration (el_Upper) is used.

4. Rebuild icudtl.dat for non-Android and Android
   (for build icu_use_data_file_flag=1) as well as the assembly source
   files for Linux, Mac and Android (icu_use_data_file_flag=0).

   icudt.dll for Windows (icu_use_data_file_flag=0) is not updated in this CL.
We don't need it because icu_use_data_file_flag=1 on all platforms now. Just in
case, I'll update that in a separate CL.

For the record, icudtl.dat got smaller by ~ 11kB. The difference mainly comes from a smaller zoneinfo64.res :

icudtold/translit/root.res 2256
icudtnew/translit/root.res 832
icudtold/windowsZones.res 20288
icudtnew/windowsZones.res 20256
icudtold/zoneinfo64.res 160400
icudtnew/zoneinfo64.res 149520
icudtold/metaZones.res 39824
icudtnew/metaZones.res 39968

TBR=mark
BUG=349194
TEST=None until this version of ICU is rolled in.

Review URL: https://codereview.chromium.org/201133002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@257461 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 months agoUse Android-specific icudata file
jshin@chromium.org [Thu, 6 Feb 2014 18:57:03 +0000 (18:57 +0000)]
Use Android-specific icudata file

Android build needs to use a separate icu data file. When
icu_use_data_file_flag is on, it has to copy android/icudtl.dat.

The Chrome-side of change is https://codereview.chromium.org/156333002/

BUG=72633
TEST=When rolled in in DEPS, Linux/Mac/Windows builds go as before (i.e. have third_party/icu/source/data/in/icudtl.dat copied to the top build directory).
R=andrewhayden@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/149953006

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@249466 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 months agoThis has to be checked in first so it can be rolled in the next CL for this bug.
maruel@chromium.org [Tue, 21 Jan 2014 21:34:43 +0000 (21:34 +0000)]
This has to be checked in first so it can be rolled in the next CL for this bug.

Description:
Add support for component=shared_library for base_unittests.

R=jshin@chromium.org
BUG=336439

Review URL: https://codereview.chromium.org/143903004

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@246118 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 months agoCorrect gyp toolsets for all combinations of want_separate_host_toolset and use_syste...
jochen@chromium.org [Fri, 10 Jan 2014 09:36:18 +0000 (09:36 +0000)]
Correct gyp toolsets for all combinations of want_separate_host_toolset and use_system_icu.

This CL ensures following logics:
if want_separate_host_toolset == 0 and use_system_icu == 0
  don't use system icu
  build icu for target toolset

elif want_separate_host_toolset == 0 and use_system_icu == 1
  use system icu for target toolset
  don't build icu

elif want_separate_host_toolset == 1 and use_system_icu == 0
  don't use system icu
  build icu for host and target

elif want_separate_host_toolset == 1 and use_system_icu == 1
  use system icu for target toolset
  build icu for host toolset

All complexity is due to the condition: want_separate_host_toolset == 1 and use_system_icu == 1.
Although use_system_icu == 1, this condition requires to build icu for host toolset.

BUG=
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/124003004

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@244134 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 months agoRename ICU NaCl targets
sergeyu@chromium.org [Thu, 9 Jan 2014 19:17:34 +0000 (19:17 +0000)]
Rename ICU NaCl targets

Use _nacl suffix for NaCl targets instead of _untrusted.

R=mark@chromium.org

Review URL: https://codereview.chromium.org/129893002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@243949 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 months agoFix icu link warning on Windows
wfh@chromium.org [Tue, 7 Jan 2014 23:14:09 +0000 (23:14 +0000)]
Fix icu link warning on Windows

BUG=325982
TEST=run builds with and without component=shared_library and verify no linker warning are emitted. Run net_unittests --gtest_filter=NetUtil*.*
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/117663003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@243425 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 months agoAdd icu.isolate
jshin@chromium.org [Tue, 7 Jan 2014 20:43:08 +0000 (20:43 +0000)]
Add icu.isolate

icu.isolate add either icudtl.dat or icudt.dll to |track...| depending on
icu_use_data_file_flag and OS.

icu.isolate will be included by *isolate files that currently list icudt.dll on
Windows.

This is a prerequisite for the following CLs to use icudtl.dat :

Windows : https://codereview.chromium.org/99473012
Linux : https://codereview.chromium.org/102413007
Mac : https://codereview.chromium.org/109013004

It's also a prerequisite for the following CLs to refer to icu.isolate :

https://codereview.chromium.org/124143002/

BUG=72633
TEST=Once rolled in, *swam testbots work fine.
R=mark@chromium.org, maruel@chromium.org

Review URL: https://codereview.chromium.org/99073008

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@243376 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 months agoCompile ICU for [P]NaCl
sergeyu@chromium.org [Fri, 20 Dec 2013 21:05:36 +0000 (21:05 +0000)]
Compile ICU for [P]NaCl

Added new targets icuuc_untrusted, icui18n_untrusted and icudata_untrusted
that compile ICU for NaCl and PNaCl.

BUG=276739
R=mark@chromium.org

Review URL: https://codereview.chromium.org/109553005

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@242173 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 months agoAdd back link_settings for iOS.
jshin@chromium.org [Thu, 19 Dec 2013 01:17:32 +0000 (01:17 +0000)]
Add back link_settings for iOS.

In https://codereview.chromium.org/111723007, link_settings was dropped on
all platforms including iOS. iOS does need link_settings (see
post-checkin comments in the CL aforementioned).

BUG=72633
TEST=Once this is rolled in, ios* bots pass *unittests without an error in loading icudtl.dat.
R=mark@chromium.org

Review URL: https://codereview.chromium.org/118373006

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@241739 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 months agoAdd support for icu_use_data_file=1 to icu.gyp on Windows/Linux
jshin@chromium.org [Wed, 18 Dec 2013 18:03:33 +0000 (18:03 +0000)]
Add support for icu_use_data_file=1 to icu.gyp on Windows/Linux

1. When icu_use_data_file_flag is set to 1 on Windows, we don't need
to copy icudt.dll. Instead, we have to copy icudt*.dat.

2. Put copies statement for icudt*.dat outside link_settings on all platforms.

For static builds on Linux, Windows and Mac,
'copies' should be pulled out of 'link_settings'. Putting it outside
'link_settings' does not hurt shared builds, either.

iOS is the only platform with icu_use_data_file=1 at the moment and
is affected directly by this CL (dropping link_settings).

3. Simplify the condition for mac_bundle_resource by dropping
'OS=="mac" and _mac_bundle' because it's never satisfied here.

4. Rename icudt46l.dat in source/data/in and android to icudtl.dat. This
is to simplify the ICU upgrade process down the road.
With the version number removed, there's no need to change the data filename
in multiple gyp files and windows package configuration files when upgrading
ICU. (the same was done for icudt.dll on Windows a few years ago.)

This CL has to go first before we land the chromium-side changes
to set icu_use_data_file to 1 on
Windows (https://codereview.chromium.org/99473012 ),
Linux ( https://codereview.chromium.org/102413007 ), and
Mac ( https://codereview.chromium.org/109013004 )

The chromium-side change for Mac will follow this, too.

BUG=72633
TEST=None (until this is rolled).
R=mark@chromium.org, scottmg@chromium.org

Review URL: https://codereview.chromium.org/111723007

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@241597 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 months agoUpdate icudt46l.dat and related files.
jshin@chromium.org [Sat, 7 Dec 2013 01:19:13 +0000 (01:19 +0000)]
Update icudt46l.dat and related files.

We're about to enable using icudt46l.dat instead of static-linking it on
Linux, Android and Chrome OS.

While testing that CL, it's found that source/data/in/icudt46l.dat was not
updated last time when {linux,mac,android}/icudt*S and windows/icudt.dll
were updated.

The following two items are also updated:

1) The timezone data (latest version : 2013h)
2) Added trnslit/{tr,el,az}_{Upper,Lower,Title}.txt and
translit/css3transform.txt so that we can support CSS3 locale-dependent
transform.

With the above changes, all the ICU data files (*.S, *dll, *dat) on
all platforms are regenerated.

The section on the ICU data file generation in README.chromium was made
clearer as to where to find / how to generate *S and *dat files if one
wishes to customize ICU data differently than Chromium does.

BUG=72633,292214,234797,304911
TEST=Once ICU is rolled in, 1) build goes fine 2) Israeli DST transition is up to date (see bug 292214 comment 9 as to how to test).
R=mark@chromium.org

Review URL: https://codereview.chromium.org/102283003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@239289 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 months agoUse the system stdint.h on Windows.
bungeman@chromium.org [Mon, 14 Oct 2013 20:23:54 +0000 (20:23 +0000)]
Use the system stdint.h on Windows.

This is now possible since VC2010 and later provide a stdint.h. VC2008
has been deprecated for building Chromium for a full year now.

There are a number of stdint.h implementations in the codebase, some of
which hide others, and most of which are not complete, and some are not
named stdint.h. The one here in icu is pwin32.h and it is the last file
which implements parts of stdint.h which prevents Blink from using the
system stdint.h.

R=jshin@chromium.org

Review URL: https://codereview.chromium.org/27079003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@228516 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 months agoTo use C++ API for BreakIterator in Blink, port getRuleStatus from ICU 52
jshin@chromium.org [Mon, 23 Sep 2013 22:41:45 +0000 (22:41 +0000)]
To use C++ API for BreakIterator in Blink, port getRuleStatus from ICU 52

See https://codereview.chromium.org/23618052 for the Blink change.

Patch by Igor Oliveira.

Original review : https://codereview.chromium.org/23480090/

BUG=232922
TEST=ICU is built and Blink is built with Blink CL above once ICU is rolled.
TBR=cpu

Review URL: https://codereview.chromium.org/23532086

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@224814 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 months agoFix icu compilation on VS2013
scottmg@chromium.org [Mon, 16 Sep 2013 19:49:33 +0000 (19:49 +0000)]
Fix icu compilation on VS2013

(And move .patch file which was accidentally in the root).

R=jshin@chromium.org
BUG=288948

Review URL: https://chromiumcodereview.appspot.com/23889022

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@223384 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

8 months agoFix a bug in UTF-16/32 detection.
jshin@chromium.org [Thu, 22 Aug 2013 16:38:39 +0000 (16:38 +0000)]
Fix a bug in UTF-16/32 detection.

Add a missing buffer length check.

The upstream bug : http://bugs.icu-project.org/trac/ticket/10318

While I'm at it, I'm adding two patches that I forgot to include
in the previous check-in (http://crrev.com/121777 http://crrev.com/158118 )

BUG=275803
TEST=SyzyASAN does not complain any more after this version of ICU is rolled.
R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/22911033

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@219032 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

8 months agoFix building icu for android on mac host.
torne@chromium.org [Mon, 29 Jul 2013 12:55:48 +0000 (12:55 +0000)]
Fix building icu for android on mac host.

ICU was not building correctly when OS==android, _toolset=host and
host_os=mac. Fix the conditionals to use the right data files when
building for host.

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/21031003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@214189 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 months agoOnly depend on libgabi++ for the target toolset.
jochen@chromium.org [Wed, 24 Jul 2013 06:57:54 +0000 (06:57 +0000)]
Only depend on libgabi++ for the target toolset.

R=marja@chromium.org

Review URL: https://codereview.chromium.org/20043007

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@213354 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 months agoTurn on want_separate_host_toolset on by default, as it's on by default in chrome
jochen@chromium.org [Tue, 23 Jul 2013 11:44:28 +0000 (11:44 +0000)]
Turn on want_separate_host_toolset on by default, as it's on by default in chrome

BUG=none
R=torne@chromium.org

Review URL: https://codereview.chromium.org/19485007

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@213076 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 months agoSet proper flags when cross-compiling with separate toolsets.
jochen@chromium.org [Mon, 22 Jul 2013 11:39:38 +0000 (11:39 +0000)]
Set proper flags when cross-compiling with separate toolsets.

Currently, this is only done by standalone-V8 which already sets the correct
flags. However, when ICU is compiled within chromium for V8, we need to set
the correct flags ourselves.

BUG=none
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/19780003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@212871 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 months agoMake it possible to compile ICU both with the host and target toolset.
jochen@chromium.org [Fri, 19 Jul 2013 15:30:08 +0000 (15:30 +0000)]
Make it possible to compile ICU both with the host and target toolset.

If the system ICU library is supposed to be used, still compile ICU for the
host toolset if we're using separate host and target toolsets, as the system
ICU in general is only available for the target.

BUG=none
R=mark@chromium.org

Review URL: https://codereview.chromium.org/19490004

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@212587 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 months agoICU header move part 3 of 3.
jshin@chromium.org [Tue, 16 Jul 2013 21:28:48 +0000 (21:28 +0000)]
ICU header move part 3 of 3.

Delete public directory.  It's landed manually because 'gcl upload' does
not work when deleting empty directories.

All-in-one CL was reviewed and approved at

https://codereview.chromium.org/18836004/

The upstream has headers in source/{common,i18n}/unicode.
With Blink's ICU headers removed, there's no need to keep them
in a location different than the upstream. Future ICU updates will
be a bit more streamlined. v8 also likes to have this change.

The Chrome-side of change is at http://codereview.chromium.org/18252003

This revision will be rolled in along with the global replacements
of include-references to ICU headers and DEPS changes.

See also http://crbug.com/232922 where ICU headers in Blink are removed.

BUG=251433
TEST=NONE for now.
TBR=mark,cpu

---All lines above this line become the description.
---Repository Root: /usr/local/google/w/cr/tos/src/third_party/icu
---Paths in this changelist (ihm3):

D      public
D      public/i18n
D      public/common

---Paths modified but not in any changelist:

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@211851 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 months agoMove ICU header part 2
jshin@chromium.org [Tue, 16 Jul 2013 21:23:16 +0000 (21:23 +0000)]
Move ICU header part 2

Move public/i18n/unicode to source/i18n/unicode, delete public/{common,i18n}.
Update icu.gyp accordingly.

This move is done in stages to work around a problem with gcl handling a
large patch.

All-in-one patch was approved at https://codereview.chromium.org/18836004/

The upstream has headers in source/{common,i18n}/unicode.
With Blink's ICU headers removed, there's no need to keep them
in a location different than the upstream. Future ICU updates will
be a bit more streamlined. v8 also likes to have this change.

The Chrome-side of change is at http://codereview.chromium.org/18252003

This revision will be rolled in along with the global replacements
of include-references to ICU headers and DEPS changes.

See also http://crbug.com/232922 where ICU headers in Blink are removed.

BUG=251433
TEST=NONE for now.
TBR=mark,cpu

Review URL: https://codereview.chromium.org/19417002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@211848 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 months agoMove ICU headers part 1
jshin@chromium.org [Tue, 16 Jul 2013 21:06:14 +0000 (21:06 +0000)]
Move ICU headers part 1

This is a part 1 of ICU header move. I have to do this in stages because
'split gcl upload' does not work very well with a large CL.
(the all-in-one CL was already approved at
https://codereview.chromium.org/18836004/ ).

The upstream has headers in source/{common,i18n}/unicode.
With Blink's ICU headers removed, there's no need to keep them
in a location different than the upstream. Future ICU updates will
be a bit more streamlined. v8 also likes to have this change.

The Chrome-side of change is at http://codereview.chromium.org/18252003

This revision will be rolled in along with the global replacements
of include-references to ICU headers and DEPS changes.

See also http://crbug.com/232922 where ICU headers in Blink are removed.

BUG=251433
TEST=NONE for now.
TBR=mark,cpu

Review URL: https://codereview.chromium.org/19276009

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@211838 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 months agoHarden _getKeywords in uloc.c
jshin@chromium.org [Tue, 9 Jul 2013 23:30:40 +0000 (23:30 +0000)]
Harden _getKeywords in uloc.c

It crashes when an input locale name has a zero-length key or zero-length value
followed by another key-value pair such as 'ko@foo= ;bar=blah', '@ = ;'.
Note that  _getKeywords was patch to avoid a crash given 'ko@foo= ' in the
past.

An upstream bug was filed as well (http://bugs.icu-project.org/trac/ticket/10250 ).

When rolling in this change via DEPS, we'll add a webkit layout test.

BUG=257875
TEST=See the bug.
R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/18877004

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@210659 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 months agoFix the typo in the previous CL for uClibc support in ICU
jshin@chromium.org [Wed, 12 Jun 2013 21:37:05 +0000 (21:37 +0000)]
Fix the typo in the previous CL for uClibc support in ICU

patch by Mostyn Bramley-Moore

TBR=cpu
BUG=NONE
TEST=ICU build works fine on Linux/CrOS after DEPS change.

Review URL: https://codereview.chromium.org/16862003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@205936 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 months agoDon't use __timezone when using uClibc
jshin@chromium.org [Tue, 11 Jun 2013 23:14:51 +0000 (23:14 +0000)]
Don't use __timezone when using uClibc

It appears that plinux.h is a generated file, created by autoconf on a
glibc system, so it naturally outputs a config for glibc.  This patch
changes one of the settings so that it doesn't break when used with
uClibc.

Patch by Mostyn Bramley-Moore

BUG=NONE
TEST=Opera builds work fine.
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/15973007

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@205673 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 months agoAndroid: Disable 'sincos' optimization to avoid 'icu' link errors.
yfriedman@chromium.org [Thu, 9 May 2013 19:03:31 +0000 (19:03 +0000)]
Android: Disable 'sincos' optimization to avoid 'icu' link errors.

This started failing with the roll to Android NDK r8e. This only happens
with the component build, presumably because in the regular build this
code is optimized out.

BUG=237460
R=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/14759026

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@199252 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

12 months agoRevert r172827 to fix the FTP directory listing on Windows.
jshin@chromium.org [Tue, 9 Apr 2013 00:28:41 +0000 (00:28 +0000)]
Revert r172827 to fix the FTP directory listing on Windows.

r172827  (http://src.chromium.org/viewvc/chrome?revision=172827&view=revision )
was to take care of the race condition, but the condition is hard to exploit.

BUG=177428
TEST=See the bug.
TBR=tsepez
Review URL: https://codereview.chromium.org/13812006

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@192960 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

14 months agoGenerate shim headers on Android when using system ICU.
benm@google.com [Thu, 14 Feb 2013 17:20:45 +0000 (17:20 +0000)]
Generate shim headers on Android when using system ICU.

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@182486 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

14 months agoNo need to compare library variable against 'shared_library'.
tfarina@chromium.org [Mon, 4 Feb 2013 21:51:50 +0000 (21:51 +0000)]
No need to compare library variable against 'shared_library'.

We don't need to compare it here, because as it is defined in build/common.gypi,
it's always 'static_library', so this condition is always true. Which turns out
we are always defining U_HIDE_DATA_SYMBOL. Just do it unconditionally.

BUG=111541
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/12093111

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@180531 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

15 months agoRemove <(library) usage from icu.gyp.
tfarina@chromium.org [Fri, 18 Jan 2013 21:08:15 +0000 (21:08 +0000)]
Remove <(library) usage from icu.gyp.

BUG=111541
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/12018021

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@177751 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

15 months agoFix build with system ICU headers.
phajdan.jr@chromium.org [Thu, 10 Jan 2013 18:45:47 +0000 (18:45 +0000)]
Fix build with system ICU headers.

BUG=165264
Review URL: https://codereview.chromium.org/11826015

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@176115 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

15 months agoMake icu compile for Win64
jschuh@chromium.org [Sat, 5 Jan 2013 19:39:03 +0000 (19:39 +0000)]
Make icu compile for Win64

This is just disabling a warning we're already ignoring on other 64-bit platforms. I'll circle back and investigate if code changes make sense.

BUG=http://crbug.com/166496
BUG=http://crbug.com/167187
TBR=jshin
Review URL: https://codereview.chromium.org/11787014

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@175290 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

15 months agoLinux: generate shim headers for ICU.
phajdan.jr@chromium.org [Thu, 3 Jan 2013 17:43:21 +0000 (17:43 +0000)]
Linux: generate shim headers for ICU.

BUG=165264
Review URL: https://codereview.chromium.org/11642008

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@174977 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

16 months agoFix a race condition in ICU's locid.
jshin@chromium.org [Thu, 13 Dec 2012 05:50:35 +0000 (05:50 +0000)]
Fix a race condition in ICU's locid.

Patch by tsepez.

The upstream bug is http://bugs.icu-project.org/trac/ticket/9737 and the
upstream has a different patch than this, but we can't take it now because
it uses UMutex not available in Chrome's copy of ICU. We'll get it when
we upgrade to 50.1

BUG=152442
TEST=No more 'heap-use-after-free' in ICU from clusterfuzz as shown in the bug report.

Review URL: https://chromiumcodereview.appspot.com/11358202

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@172827 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

18 months agoFix compilation errors on VS2012
scottmg@chromium.org [Thu, 11 Oct 2012 23:25:34 +0000 (23:25 +0000)]
Fix compilation errors on VS2012

R=cpu@chromium.org
BUG=143646

Review URL: https://chromiumcodereview.appspot.com/11103047

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@161442 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

19 months agoFix a heap buffer overaflow in ucstrTextExtract
jshin@chromium.org [Fri, 21 Sep 2012 23:19:30 +0000 (23:19 +0000)]
Fix a heap buffer overaflow in ucstrTextExtract

Merge the upstream patch http://bugs.icu-project.org/trac/changeset/29356

BUG=146892
TEST=See the bug report.
Review URL: https://codereview.chromium.org/10957050

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@158118 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

20 months agoMake 'License' field in third-party metadata required
steveblock@chromium.org [Wed, 1 Aug 2012 00:42:33 +0000 (00:42 +0000)]
Make 'License' field in third-party metadata required

This will simplify the addition of a tool to check licenses for the purpose of
the Android WebView build.

See also http://codereview.chromium.org/10821103.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10827099

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@149334 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

21 months agoFix ICU time zone support on iOS
stuartmorgan@chromium.org [Fri, 13 Jul 2012 05:59:37 +0000 (05:59 +0000)]
Fix ICU time zone support on iOS

tzfile.h isn't available on iOS, and the time zone is not set the way it is on OS X, so don't define U_TIMEZONE. Also disables a code path in the non-U_TIMEZONE implmentation that makes a correction that is incorrect on iOS.

Fixes the following upstream ICU bugs:
  http://bugs.icu-project.org/trac/ticket/9051
  http://bugs.icu-project.org/trac/ticket/8661

BUG=None
TEST=None (will be covered by base unit tests once they come online upstream)

Review URL: https://chromiumcodereview.appspot.com/10692124

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@146527 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

21 months agoFix ICU to work with Android's system stlport
steveblock@chromium.org [Thu, 12 Jul 2012 15:05:15 +0000 (15:05 +0000)]
Fix ICU to work with Android's system stlport

The version of stlport in the Android ADK includes support for RTTI, but the
system version does not. ICU requires RTTI, so we have to explicitly depend
upon gabi++ to provide RTTI when using the system stlport.

Note that we can't simply include gabi++ with all modules when using the system
stlport, as the gabi++ headers conflict with bionic when used with some other
modules.

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@146346 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

21 months agoImplement use_system_icu for Android.
torne@chromium.org [Tue, 10 Jul 2012 13:14:23 +0000 (13:14 +0000)]
Implement use_system_icu for Android.

It will be useful to be able to use the Android system version of ICU on
some future chromium build configs. Add the appropriate options to the
gyp file to enable this, since icu-config can't be used for
crosscompilation.

Review URL: https://chromiumcodereview.appspot.com/10632003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@145871 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

21 months agoAdd iOS support to icu.gyp
stuartmorgan@chromium.org [Thu, 5 Jul 2012 11:12:36 +0000 (11:12 +0000)]
Add iOS support to icu.gyp

This simply makes iOS follow all the same gyp paths as Mac does.

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10695096

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@145521 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

22 months agoRemove host target of ICU on Android
wangxianzhu@chromium.org [Sat, 2 Jun 2012 00:59:11 +0000 (00:59 +0000)]
Remove host target of ICU on Android

Previously host target of ICU is required on Android because ImageDiff
depends on WTF and in turn on icu. WTF dependency of ImageDiff has been
removed in https://bugs.webkit.org/show_bug.cgi?id=88147.

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10491006/

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@140144 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

23 months agoExclude most lang, all region and all curr data for chromium-android.
wangxianzhu@chromium.org [Fri, 4 May 2012 19:09:20 +0000 (19:09 +0000)]
Exclude most lang, all region and all curr data for chromium-android.

Curr data is unused by chromium-android which doesn't support JavaScript i18n
API for now. On Android, display name of region and lang are accessed through
Java API (except for zh_Hans and zh_Hant which are not supported by Java API),
so we also exclude lang (except for language zh and scripts Hans and Hant) and
region data. This could totally reduce the uncompressed binary size of
chromium-android by nearly 2MB.

Also BTW upstreaming some other Android local changes to third_party/icu.

BUG=none
TEST=L10nUtilTest.GetDisplayNameForLocale,L10nUtilTest.GetDisplayNameForCountry

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@135385 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years ago Use original CJK segmetation rules on Android. (Part 2) git-svn
wangxianzhu@chromium.org [Wed, 7 Mar 2012 21:22:28 +0000 (21:22 +0000)]
Use original CJK segmetation rules on Android. (Part 2)

    The original CJK segmenation rules are the rules before patches/brkitr.patch
    applied. Use that to avoid using the cjdict to reduce binary size.

    BUG=none
    TEST=none
    Review URL: https://chromiumcodereview.appspot.com/9599024/

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@125456 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years ago Use original CJK segmetation rules on Android.
wangxianzhu@chromium.org [Wed, 7 Mar 2012 21:20:14 +0000 (21:20 +0000)]
Use original CJK segmetation rules on Android.

    The original CJK segmenation rules are the rules before patches/brkitr.patch
    applied. Use that to avoid using the cjdict to reduce binary size.

    BUG=none
    TEST=none
    Review URL: https://chromiumcodereview.appspot.com/9599024/

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@125455 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoICU: Merge upstream r30255 to fix a clang warning.
thakis@chromium.org [Tue, 21 Feb 2012 18:37:24 +0000 (18:37 +0000)]
ICU: Merge upstream r30255 to fix a clang warning.

BUG=chromium:114969
Review URL: https://chromiumcodereview.appspot.com/9425042

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@122842 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoAdd 4068 to the list of warnings to suppress in VS.
jshin@chromium.org [Fri, 17 Feb 2012 22:50:10 +0000 (22:50 +0000)]
Add 4068 to the list of warnings to suppress in VS.

We added pragmas to disable warnings from clang to i18n/decNum.c. They're
not recognized by Visual Studio. To suppress that warning, add 4068
to the suppressed VC warning list.

BUG=84851
TEST=Visual Stuido doesn't complain while compiling decNumc.
Review URL: https://chromiumcodereview.appspot.com/9355015

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@122609 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoTake care of two Clang warnings.
jshin@chromium.org [Fri, 17 Feb 2012 01:21:04 +0000 (01:21 +0000)]
Take care of two Clang warnings.

- decNumber.c has several places where Clang complains about array index
  out-of-bounds error. According to udecnum.h, it's done on purpose because
  the array in question (lsu) is followed by additional spaces for digits.
  So, we suppress 'array-bounds' warning with clang-specific pragmas.
  GCC 4.6 also complains about this, but it's hard to make GCC 4.4 and
  GCC 4.6 happy at the same time without getting too ugly because GCC 4.4
  does not support 'pragra diagnostic {push|pop}'

  See http://bugs.icu-project.org/trac/ticket/8954

- colldata.cpp copies an array of UnicodeString's with memcpy. It's changed to
  to use a for-loop, instead. The upstream ToT has fixed this.

BUG=84851,92756
TEST=Compile with Clang and it does not complain any more in devNumber.c and colldata.cpp
Review URL: https://chromiumcodereview.appspot.com/9420032

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@122423 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoicu: Warning tweaks in preparation for the next clang roll.
thakis@chromium.org [Thu, 16 Feb 2012 22:44:56 +0000 (22:44 +0000)]
icu: Warning tweaks in preparation for the next clang roll.

BUG=chromium:84851,chromium:102390
Review URL: https://chromiumcodereview.appspot.com/9417025

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@122379 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoFix another buffer overflow bug in ICU
jshin@chromium.org [Thu, 16 Feb 2012 21:45:13 +0000 (21:45 +0000)]
Fix another buffer overflow bug in ICU

This is a 'hot' fix and a better patch will be made in the upstream and will be merged down later.  The investigation and the patch by tsepez.

BUG=114342
TEST=See the bug.
TBR=tsepez
Review URL: https://chromiumcodereview.appspot.com/9415012

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@122360 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoMove -Wno-switch in ICU to the target that actually needs it :-/
thakis@chromium.org [Wed, 15 Feb 2012 17:47:29 +0000 (17:47 +0000)]
Move -Wno-switch in ICU to the target that actually needs it :-/

(Follow-up to http://codereview.chromium.org/9347044/)
TBR=evan
Review URL: https://chromiumcodereview.appspot.com/9407013

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@122103 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoAdd -Wno-switch to ICU.
thakis@chromium.org [Wed, 15 Feb 2012 16:41:42 +0000 (16:41 +0000)]
Add -Wno-switch to ICU.

-Wswitch started warning about a construct that ICU uses here:
http://llvm.org/viewvc/llvm-project?view=rev&revision=148649

TBR=evan
Review URL: https://chromiumcodereview.appspot.com/9347044

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@122096 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoFix two ICU bugs.
jshin@chromium.org [Tue, 14 Feb 2012 00:21:48 +0000 (00:21 +0000)]
Fix two ICU bugs.

1. _getKeywords() in uloc.cpp has a buffer overflow error.  Patch by tsepez
2. ubrk_setText() in ubrk.cpp has a null pointer access error.

The patch for the first one was added to existing canonicalize.patch, which is
renamed to uloc.patch because all the patches there touch uloc.cpp
The patch for the second one was in ubrk.patch.

These issues haven't been filed in the upstream bug tracker, yet because
I'm being on the safe side now. I'll file them upstreams once we have
them fixed in Chrome ToT and release branch. So, the bug reference in
README.chromium is currenly 'xxxx'.

BUG=112834,95486
TEST=See the bugs.
Review URL: https://chromiumcodereview.appspot.com/9387016

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@121777 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoAdd Malay (ms) locale data to pre-build ICU data file.
jshin@chromium.org [Fri, 3 Feb 2012 00:43:13 +0000 (00:43 +0000)]
Add Malay (ms) locale data to pre-build ICU data file.

lang, curr, zone files for ms are less populated in ICU 4.6 than we need. So, I got them from ICU 4.8.

icudt file size increase is about 7kB.

BUG=111670
TEST=None (until we have this version of ICU rolled in via DEPS)
TBR=tony
Review URL: https://chromiumcodereview.appspot.com/9317044

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@120256 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoRevise EUC-JP mapping so that {0x8E 0xE3} and {0x8E 0xE4} are not
jshin@chromium.org [Tue, 31 Jan 2012 20:32:56 +0000 (20:32 +0000)]
Revise EUC-JP mapping so that {0x8E 0xE3} and {0x8E 0xE4} are not
mapped to U+005C and U+007E.

After this is landed, ICU has to be rolled in to get this change.

Patch originally by Tom Sepez. (see the bug).

BUG=109574
TEST=Go to http://i18nl10n.com/chrome/euc_webkit_8EEE3.html and make sure there's no alert box popping up.
Review URL: https://chromiumcodereview.appspot.com/9233048

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@119946 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoAdd plain-text copy of license
jbauman@chromium.org [Mon, 30 Jan 2012 20:45:40 +0000 (20:45 +0000)]
Add plain-text copy of license

Needed to automatically generate about:credits.

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@119726 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoSwitch 'settings' to 'none', as the former is deprecated.
evan@chromium.org [Tue, 24 Jan 2012 18:24:54 +0000 (18:24 +0000)]
Switch 'settings' to 'none', as the former is deprecated.
Review URL: https://chromiumcodereview.appspot.com/9146044

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@118861 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoDisable harmless warnings for 3rdparty code: ICU.
thakis@chromium.org [Tue, 17 Jan 2012 19:17:27 +0000 (19:17 +0000)]
Disable harmless warnings for 3rdparty code: ICU.

BUG=102390
Review URL: https://chromiumcodereview.appspot.com/9178024

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@117933 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoFix buffer overflow in _canonicalize.
falken@chromium.org [Thu, 8 Dec 2011 03:05:30 +0000 (03:05 +0000)]
Fix buffer overflow in _canonicalize.

Upstream bug is http://bugs.icu-project.org/trac/ticket/8984

BUG=chromium:106441
Review URL: http://codereview.chromium.org/8822005

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@113543 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoUpdate the pre-built ICU data file for the following changes:
jshin@chromium.org [Mon, 5 Dec 2011 21:55:31 +0000 (21:55 +0000)]
Update the pre-built ICU data file for the following changes:

1. Update Olson timezone data file to 2011n (the latest)

  Among other things, Moscow time should be *always* 4 hrs ahead of UTC.

2. Fix a typoe in the timezone name for US Pacific time in Korean locale.
3. Fix AmPm markers in Indonesian locale
4. Fix the abbrebiated day name for Wednesday in Spanish
5. Add timezone display data for the following locales:
   am, bn, fa, gu, kn, ml, mr, sw, ta, te
  (they're supposed to be included, but were missing in the previous pre-built data check-in.)

For the first two changes, see
   http://codereview.chromium.org/8724009

The pre-built data files are in source/data/in, windows, mac and linux. Assembly files in linux and mac are too large and  don't show up here although they're included in the CL.

BUG=74566,chromium-os:23256
TEST=1. Change the timezone to MSK (Moscow timezone) during winter. It should be UT C+4:00 instead of UTC+3:00
2. In Korean locale, the US Pacific time display name should start with '북미 태평양' instead of '북미 평양'.
3. In Indonesian locale, AmPm markers should be 'AM' and 'PM'.
4. In locales listed for item 5 above, the timezone selection menu shows time zone names in the language on CrOS.
TBR=nkostylev
Review URL: http://codereview.chromium.org/8801026

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@113037 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoUpdate timezone data files to 2011n
jshin@chromium.org [Tue, 29 Nov 2011 23:44:51 +0000 (23:44 +0000)]
Update timezone data files to 2011n

This will update timezone data to the latest. Among other things, Moscow time
should be *always* 4 hrs ahead of UTC.

While doing so, I'm fixing the timezone name for US Pacific time in Korean locale. There's a typo.

As for MSK having 'Moscow Summer Time/Moscow Standard Time' in zone files,
it should not hurt. As long as DST is not used any more, we'll not get
'Moscow Summer Time' in our UI.

This CL will be follwed by actual data file updated for all the
platforms we care about.

BUG=74566,chromium-os:23256
TEST=Change the timezone to MSK (Moscow timezone) during winter. It should be UTC+4:00 instead of UTC+3:00
TBR=nkostylev
Review URL: http://codereview.chromium.org/8724009

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@112069 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoUpstream: Android's ICU change
michaelbai@google.com [Mon, 31 Oct 2011 18:03:49 +0000 (18:03 +0000)]
Upstream: Android's ICU change

BUG=
TEST=
Review URL: http://codereview.chromium.org/8403006

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@107982 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoMake unistr.h compile with -Werror and gcc4.6
jshin@chromium.org [Fri, 21 Oct 2011 20:47:51 +0000 (20:47 +0000)]
Make unistr.h compile with -Werror and gcc4.6

BUG=87490
TEST=icu builds with -Werror and gcc 4.6

Original Review: http://codereview.chromium.org/8120001
CL by pph34r@gmail.com

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@106776 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoUse the OpenBSD header for ICU on OpenBSD
mark@chromium.org [Thu, 20 Oct 2011 14:45:40 +0000 (14:45 +0000)]
Use the OpenBSD header for ICU on OpenBSD

add ICU header for OpenBSD

Patch by Robert Nagy <robert.nagy@gmail.com>

BUG=
TEST=
Review URL: http://codereview.chromium.org/8230006

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@106495 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoFixing an oversite in my first fix (7891051).
bradchen@google.com [Wed, 14 Sep 2011 22:57:13 +0000 (22:57 +0000)]
Fixing an oversite in my first fix (7891051).

BUG=81753
TEST=unit_tests

Review URL: http://codereview.chromium.org/7886048

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@101184 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoFix for bug 81753, do not read past the end of unicode strings
bradchen@google.com [Wed, 14 Sep 2011 21:45:11 +0000 (21:45 +0000)]
Fix for bug 81753, do not read past the end of unicode strings

BUG=81753
TEST=unit_tests

Review URL: http://codereview.chromium.org/7891051

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@101167 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoRemove a separate ICU data file for CrOS.
jshin@chromium.org [Thu, 25 Aug 2011 23:12:27 +0000 (23:12 +0000)]
Remove a separate ICU data file for CrOS.

The set of languages CrOS is localized to is now sync'd to the set
of languages Chromium/Chrome is localized to.

This will not be included until DEPS file is updated to roll this change in along with the following Chrome change ( http://codereview.chromium.org/7726003/ )

BUG=chromium-os:19465
TEST=ChromeOS build goes through.
Review URL: http://codereview.chromium.org/7725002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@98343 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoAdd the pre-built ICU data for Mac.
jshin@chromium.org [Mon, 25 Jul 2011 11:28:04 +0000 (11:28 +0000)]
Add the pre-built ICU data for Mac.

The previous check-in (http://crrev.com/93864) has the Linux data file in
Mac directory.

BUG=28604
TEST=None (actual roll CL will have tests).
TBR=cira
Review URL: http://codereview.chromium.org/7491042

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@93875 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoUpdate the pre-built ICU data files for Win, Linux, Mac and CrOS
chrome-bot@google.com [Mon, 25 Jul 2011 09:40:25 +0000 (09:40 +0000)]
Update the pre-built ICU data files for Win, Linux, Mac and CrOS

Listed below are files being updated (they're not shown in codereview).

windows/icudt.dll
linux/icudt46l_dat.S
mac/icudt46l_dat.S
source/data/in/icudt46l.dat
cros/icudt46l_dat.S

For the description of changes made, see

http://codereview.chromium.org/7046066
http://codereview.chromium.org/7488050

This update increases the ICU data file size (uncompressed) by 900kB
because the curreny display names are added for ECMAScript I18N API.

BUG=28604
TEST=NumberFormat with currency works as expected.
TBR=cira
Review URL: http://codereview.chromium.org/7484064

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@93864 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoAdd the currency display name for JavaScript I18N API
jshin@chromium.org [Mon, 25 Jul 2011 09:19:35 +0000 (09:19 +0000)]
Add the currency display name for JavaScript I18N API

This CL does not update the pre-built ICU data files. They'll be
added in the next CL.

It'll increase the ICU data file about 900kB (uncompressed).

BUG=28604
TEST=No test yet until pre-built data files are checked in and rolled in via DEPS file update.
TBR=cira
Review URL: http://codereview.chromium.org/7488050

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@93861 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoFix some ICU locale data
jshin@chromium.org [Mon, 25 Jul 2011 06:08:43 +0000 (06:08 +0000)]
Fix some ICU locale data

1. region name for '419' : drop 'Carribean' and make it just 'Latin America'.
   : this cuts down the width of our language selection menu.
     The CLDR upstream plans to make this change as well.
2. Delete the display names for all the numeric region codes other than 419 because
   we don't use them at the moment. This saves about 50kB.
3. Swap the thousand separator and decimal mark symbol in Serbian
4. Fix some date formats in various locales.
5. Merge the upstream (CLDR) changes on the way line-breaking works with
   small kana characters.
6. Update timezone (metazone) display names in ko, it, de, ja (for CrOS and JS I18N API).

BUG=None
TEST=No change in behavior until this change and a follow-up change to update
pre-built binary data files is rolled in to Chrome.
TBR=cira
Review URL: http://codereview.chromium.org/7046066

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@93846 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoFix the Korean find-in-page bug.
jshin@chromium.org [Wed, 20 Jul 2011 23:24:18 +0000 (23:24 +0000)]
Fix the Korean find-in-page bug.

Apply the upstream (ICU 4.6.1) patch to our copy of ICU 4.6

Upstream bug is http://bugs.icu-project.org/trac/ticket/8290

BUG=88434
TEST=See the bug description (http://crbug.com/89844)
TBR=finnur
Review URL: http://codereview.chromium.org/7465014

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@93281 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoICU Regex patch.
jshin@chromium.org [Tue, 28 Jun 2011 17:34:38 +0000 (17:34 +0000)]
ICU Regex patch.

Apply the upstream patch ( http://bugs.icu-project.org/trac/changeset/30244 ) to our
copy of ICU.

BUG=86900
TEST=In debug build, run Chrome and load testcase.htm file. It should not result in a sad tab.
Review URL: http://codereview.chromium.org/7276039

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@90787 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoFixed handling of different decimal separators on DigitList::set().
joaodasilva@chromium.org [Wed, 8 Jun 2011 11:35:08 +0000 (11:35 +0000)]
Fixed handling of different decimal separators on DigitList::set().

BUG=chromium:60476
TEST=chromium unit_tests:TimeFormat.FAILS_DecimalPointNotDot
Review URL: http://codereview.chromium.org/7004021

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@88321 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoFix an ICU bug found by PSV (static analysis tool)
jshin@chromium.org [Thu, 2 Jun 2011 20:36:27 +0000 (20:36 +0000)]
Fix an ICU bug found by PSV (static analysis tool)

Removes the unnecessary code.  The bug found was

if (A) {...} else if (A) {...} in msgfmt.cpp

The other bug is about the condition being always true.

BUG=84112,83911,84749
TEST=ICU builds fine and PSV does not report bugs any more.
Review URL: http://codereview.chromium.org/7109008

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@87668 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoAdd support for FreeBSD to Chrome's ICU
jshin@chromium.org [Fri, 13 May 2011 20:55:19 +0000 (20:55 +0000)]
Add support for FreeBSD to Chrome's ICU

Landing on behalf of ruben (chromium@hybridsource.org)

BUG=NONE
TEST=After this change is rolled in with DEPS update, all the platforms build as usual.

Original Review: http://codereview.chromium.org/6953014

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@85319 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 years agoDisable warnings in VS that won't be fixed anyway.
maruel@chromium.org [Sat, 30 Apr 2011 15:18:54 +0000 (15:18 +0000)]
Disable warnings in VS that won't be fixed anyway.

This is to enable warnings as error.

TBR=jungshik@chromium.org
Review URL: http://codereview.chromium.org/6893058

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@83674 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoDefine U_STATIC_IMPLEMENTATION on all platforms unless we're
evan@chromium.org [Tue, 26 Apr 2011 00:01:16 +0000 (00:01 +0000)]
Define U_STATIC_IMPLEMENTATION on all platforms unless we're
building a non-static ICU.

This #define appears to control whether symbols are explicitly
exported or not.   It also appears in headers used by ICU users,
so we need it in the export settings (and it doesn't hurt).

This is necessary for components=shared_library build on Linux.
Review URL: http://codereview.chromium.org/6905012

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@82955 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoCopy the README.chromium from icu42/.../brkitr to icu46/.../brkitr to make license...
mal@chromium.org [Fri, 22 Apr 2011 01:14:38 +0000 (01:14 +0000)]
Copy the README.chromium from icu42/.../brkitr to icu46/.../brkitr to make license checking happy.

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@82602 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoLanding http://codereview.chromium.org/6691033/
thakis@chromium.org [Tue, 5 Apr 2011 17:36:59 +0000 (17:36 +0000)]
Landing http://codereview.chromium.org/6691033/

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@80478 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFixing icu to work with msvs2010.
bradnelson@google.com [Tue, 29 Mar 2011 00:06:45 +0000 (00:06 +0000)]
Fixing icu to work with msvs2010.

BUG=None
TEST=None
R=jeanluc@chromium.org
Review URL: http://codereview.chromium.org/6760010

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@79636 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoChanging icu to use gyp 'copies', rather than use a rules file.
bradnelson@google.com [Tue, 15 Mar 2011 21:44:25 +0000 (21:44 +0000)]
Changing icu to use gyp 'copies', rather than use a rules file.
msbuild won't use the same rules files, so this blocks msbuild support.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6648016

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@78292 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFormatting the readmes in deps to follow the proper format and making sure they conta...
cdn@chromium.org [Mon, 14 Mar 2011 19:29:03 +0000 (19:29 +0000)]
Formatting the readmes in deps to follow the proper format and making sure they contain Short Name and Version fields for version tracking.

BUG=None
TEST=N/A
Review URL: http://codereview.chromium.org/6624034

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@78071 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoCoverity INFINITE_LOOP Fix.
ctguil@chromium.org [Fri, 11 Mar 2011 01:57:17 +0000 (01:57 +0000)]
Coverity INFINITE_LOOP Fix.

CID=15208

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6676011

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@77756 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoDrop ICU version number from the name of icu data dll file on Windows.
jshin@chromium.org [Mon, 7 Mar 2011 21:09:59 +0000 (21:09 +0000)]
Drop ICU version number from the name of icu data dll file on Windows.

This is to avoid having to update a bunch of build/release configuration files
whenever ICU is upgraded. (see http://crbug.com/73991)

This will be followed by three CLs (googleurl, chrome and internal build config).

BUG=74076
TEST=Chrome can be built and a binary built runs fine with an accompanying Chrome CL in place.
TBR=nsylvain

Review URL: http://codereview.chromium.org/6625032

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@77181 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoMake ICU build with Clang.
jshin@chromium.org [Thu, 24 Feb 2011 18:40:41 +0000 (18:40 +0000)]
Make ICU build with Clang.

BUG=74018
TEST=ICU builds with Clang and -Wsign-compare turned on.
TBR=thakis
Review URL: http://codereview.chromium.org/6578023

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@75916 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoDelete svn:executable properties.
hbono@chromium.org [Thu, 24 Feb 2011 08:45:54 +0000 (08:45 +0000)]
Delete svn:executable properties.
This change just removes svn:executable properties from files under 'third_party/icu46'.

TBR=jshin
BUG=none
TEST=check_perms.py
Review URL: http://codereview.chromium.org/6579033

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@75856 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAdd back U_WCHAR_IS_UTF32 macro to pmac.h
jshin@chromium.org [Wed, 23 Feb 2011 19:40:52 +0000 (19:40 +0000)]
Add back U_WCHAR_IS_UTF32 macro to pmac.h

That was accidentally dropped when upgrading to ICU 4.6.
That leads to a failure in ICUStringConversionsTest.ConvertCodepageUTF8
on Mac.

__STDC_ISO_10646__  is not defined on Mac. Neither is _UCS_4. So, u_strFromWCS
ends up calling wcstombs on Mac instead of u_strFromUTF32. I'm gonna change
WideToCodepage in base/i18n/icu_string*.cc to use u_strFromUTF32 directly.
However, there might be other places where the absence of U_WCHAR_IS_UTF32 can
lead to a problem. To be safe, I'm adding back this to pmac.h

BUG=61514
TEST=With this version of ICU 4.6 pulled in, all the tests pass
including 'base_unittests --gtest_filter=ICU*.Conv*'

Review URL: http://codereview.chromium.org/6578003

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@75773 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAdd the ICU 4.6 locale file (pre-generated) for CrOS along with
jshin@chromium.org [Wed, 23 Feb 2011 01:08:35 +0000 (01:08 +0000)]
Add the ICU 4.6 locale file (pre-generated) for CrOS along with
abridged locale files used in the generation of ICU data file on Linux.

BUG=61514
TEST=CrOS build goes fine with the ICU 4.6 pulled in.
TBR=mark

Review URL: http://codereview.chromium.org/6469108

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@75690 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAdd up-to-date README.chromium for ICU 4.6
jshin@chromium.org [Thu, 17 Feb 2011 19:19:49 +0000 (19:19 +0000)]
Add up-to-date README.chromium for ICU 4.6

In addition,
  - add rtti.patch (see http://codereview.chromium.org/6484008)
  - add platform.patch : this changes platform.h.in to
    streamline the process of making plinux.h and pmac.h
    Note that we don't need plinux.h.patch any more thanks to this
    change.
  - plinux.h, pmac.h and platform.h.in are updated accordingly.
  - update brkitr.patch (which was not updated by mistake)

Note that cros directory is not yet populated. I'll add files
referred to in README.chromium in another CL.

BUG=61514
TEST=Chrome can be built on Linux and Mac.

Review URL: http://codereview.chromium.org/6537010

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@75292 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoEnable RTTI for ICU.
jshin@chromium.org [Wed, 16 Feb 2011 21:58:54 +0000 (21:58 +0000)]
Enable RTTI for ICU.

ICU 4.6 uses RTTI (dynamic_cast and typeid) in many places.

It'll increase the vtbl size. I'm gonna measure the size impact by
making two builds:

1. With rtti enabled
2. With rtti disabled, but with dynamic_cast replaced with
static_cast and typeid with 'something' buildable. This build wouldn't run
properly, but for the size comparision, just compiling it should be fine.

On Windows, we set _HAS_EXCEPTIONS to 0 in common.gypi. To build ICU
without enabling exception as well on Windows, we replaced the following line

#include <typeinfo>

with

#include "unicode/utypeinfo.h"

and add a new file 'common/unicode/utypeinfo.h' with the following:

#if defined(_MSC_VERSION) && _HAS_EXCEPTIONS == 0
#include <exception>
using std::exception;
#endif
#include <typeinfo>

BUG=61514
TEST=On all 3 platforms, Chrome can be built and can be run without crash.

Review URL: http://codereview.chromium.org/6484008

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@75186 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRename the variable to not end in "_file" since that triggers gyp relative
thomasvl@chromium.org [Fri, 11 Feb 2011 15:36:11 +0000 (15:36 +0000)]
Rename the variable to not end in "_file" since that triggers gyp relative
path munging when you try to set it in common.gypi.
Review URL: http://codereview.chromium.org/6474038

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@74592 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoPort wpo.patch to ICU 4.6
jshin@chromium.org [Fri, 11 Feb 2011 00:55:52 +0000 (00:55 +0000)]
Port wpo.patch to ICU 4.6

udata.c is replaced by udata.cpp.

Besides, I'm just adding eol styles to a few patch files.

See also:
http://bugs.icu-project.org/trac/ticket/8043
http://bugs.icu-project.org/trac/ticket/5701

BUG==61514
TEST=Build an official build.

Review URL: http://codereview.chromium.org/6462019

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@74538 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAdd support for using ICU with a data file instead of compiling the data in.
thomasvl@chromium.org [Thu, 10 Feb 2011 18:04:31 +0000 (18:04 +0000)]
Add support for using ICU with a data file instead of compiling the data in.

Landed for icu42 already, just doing this in this version also.

icu42 version:
  http://src.chromium.org/viewvc/chrome?view=rev&revision=74439

Review URL: http://codereview.chromium.org/6474002

git-svn-id: http://src.chromium.org/svn/trunk/deps/third_party/icu46@74453 4ff67af0-8c30-449e-8e8b-ad334ec8d88c