chromium/src.git
26 min agoSVN changes up to revision 265872 master
gitdeps [Thu, 24 Apr 2014 06:35:23 +0000 (23:35 -0700)]
SVN changes up to revision 265872

26 min agoFiles.app: Ensure FileTransferController to handle touch end. git-svn
hirono@chromium.org [Thu, 24 Apr 2014 06:35:02 +0000 (06:35 +0000)]
Files.app: Ensure FileTransferController to handle touch end.

Previously we cannot handle touch end for the following two cases:

* The context menu blocks touchend events.
* Touchend events turn to touchcancel events.

BUG=chrome-os-partner:28122
TEST=test on a real device.
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/248773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265872 0039d316-1c4b-4281-b951-d872f2087c98

63 min agoSVN changes up to revision 265868
gitdeps [Thu, 24 Apr 2014 05:58:23 +0000 (22:58 -0700)]
SVN changes up to revision 265868

64 min agoFiles.app: add metadata simple parser for WebP extended file format.
kinaba@chromium.org [Thu, 24 Apr 2014 05:57:18 +0000 (05:57 +0000)]
Files.app: add metadata simple parser for WebP extended file format.

Parse canvas width and height. Reference:
https://developers.google.com/speed/webp/docs/riff_container#extended_file_format

BUG=361485

Review URL: https://codereview.chromium.org/250453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265868 0039d316-1c4b-4281-b951-d872f2087c98

74 min agoSVN changes up to revision 265867
gitdeps [Thu, 24 Apr 2014 05:47:25 +0000 (22:47 -0700)]
SVN changes up to revision 265867

74 min agoDon't pass a null ServiceWorker registration with OK status code.
falken@chromium.org [Thu, 24 Apr 2014 05:47:05 +0000 (05:47 +0000)]
Don't pass a null ServiceWorker registration with OK status code.

Null registration should have a NOT_FOUND status code, so the callback
knows not to dereference it.

BUG=364247
R=michaeln@chromium.org

Review URL: https://codereview.chromium.org/257483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265867 0039d316-1c4b-4281-b951-d872f2087c98

75 min agoNon-SFI NaCl: Disallow epoll family and allow poll instead
hamaji@chromium.org [Thu, 24 Apr 2014 05:46:18 +0000 (05:46 +0000)]
Non-SFI NaCl: Disallow epoll family and allow poll instead

libevent tries to use epoll_create, but if it fails, it
gracefully falls back to poll and will not call other epoll
APIs. So, we return EPERM from epoll_create, allow poll, and
disallow epoll_ctl and epoll_wait.

TEST=out/Release/nacl_loader_unittests
TEST=out/Release/browser_tests --gtest_filter='*NaCl*NonSfi*'
TEST=trybots
BUG=359285

Review URL: https://codereview.chromium.org/244013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265866 0039d316-1c4b-4281-b951-d872f2087c98

84 min agoSVN changes up to revision 265865
gitdeps [Thu, 24 Apr 2014 05:37:23 +0000 (22:37 -0700)]
SVN changes up to revision 265865

85 min agodrive: Use test_util::SetUpTestEntries in FakeDriveServiceTest
hashimoto@chromium.org [Thu, 24 Apr 2014 05:36:28 +0000 (05:36 +0000)]
drive: Use test_util::SetUpTestEntries in FakeDriveServiceTest

Use SetUpTestEntries in tests to replace root_feed.json.
Fix FakeDriveServiceTest.InitiateUpload_ExistingFile and ResumeUpload_ExistingFile.
Set a default value to FakeDriveService::share_url_base_ to satisfy FakeDriveServiceTest.GetShareURL.

BUG=334544
TEST=unit_tests

Review URL: https://codereview.chromium.org/248883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265865 0039d316-1c4b-4281-b951-d872f2087c98

94 min agoSVN changes up to revision 265864
gitdeps [Thu, 24 Apr 2014 05:27:24 +0000 (22:27 -0700)]
SVN changes up to revision 265864

96 min agoSVN changes up to revision 265863
gitdeps [Thu, 24 Apr 2014 05:25:24 +0000 (22:25 -0700)]
SVN changes up to revision 265863

96 min agoAdjust to the new Files.app path in comment and watchlist.
yoshiki@chromium.org [Thu, 24 Apr 2014 05:25:20 +0000 (05:25 +0000)]
Adjust to the new Files.app path in comment and watchlist.

BUG=345171
TEST=none
R=mtomasz@chromium.org
TBR=jochen@chromium.org
# TBRing for modifying comments.

Review URL: https://codereview.chromium.org/250383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265864 0039d316-1c4b-4281-b951-d872f2087c98

96 min agodrive: Handle entries not under the grand root correctly
hashimoto@chromium.org [Thu, 24 Apr 2014 05:24:58 +0000 (05:24 +0000)]
drive: Handle entries not under the grand root correctly

After FileCacheEntry gets merged to ResourceEntry,
cache-only entries will be stored in the DB as orphaned entries.

In SearchMetadata(), hide all entries by default, only whitelisted entries are returned
In GetFilePath(), Return empty FilePath for entries not under the grand root.

BUG=275271
TEST=unit_tests

Review URL: https://codereview.chromium.org/248043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265863 0039d316-1c4b-4281-b951-d872f2087c98

97 min agoDisable network in demo mode.
rkc@chromium.org [Thu, 24 Apr 2014 05:24:25 +0000 (05:24 +0000)]
Disable network in demo mode.

R=stevenjb@chromium.org
BUG=358978
TEST=Wrote a custom demo app and tested on the device to ensure that after the patch, the app could no longer access the network.

Review URL: https://codereview.chromium.org/248043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265862 0039d316-1c4b-4281-b951-d872f2087c98

103 min agoSVN changes up to revision 265861
gitdeps [Thu, 24 Apr 2014 05:18:28 +0000 (22:18 -0700)]
SVN changes up to revision 265861

103 min agoUpdate .DEPS.git
chrome-admin@google.com [Thu, 24 Apr 2014 05:18:12 +0000 (05:18 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265861 0039d316-1c4b-4281-b951-d872f2087c98

103 min agoRemove title and icon from chrome apps native style title bars.
benwells@chromium.org [Thu, 24 Apr 2014 05:18:10 +0000 (05:18 +0000)]
Remove title and icon from chrome apps native style title bars.

These windows aren't meant to have titles or icons, but still need to
get a proper title as far as the OS is concerned. This means using a
custom but glass frame, similarly to how unthemed browser windows look.

BUG=339558
TEST=Try out frame:chrome app windows windows on Windows 7, 8 and XP.
Use the windows in various states (maximised, fullscreen, normal).
Make sure they work after switching in and out of aero mode.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262516

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265598

Review URL: https://codereview.chromium.org/213743017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265860 0039d316-1c4b-4281-b951-d872f2087c98

104 min agoBlink roll 172351:172428
eseidel@chromium.org [Thu, 24 Apr 2014 05:16:56 +0000 (05:16 +0000)]
Blink roll 172351:172428

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=172351:172428&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/257423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265859 0039d316-1c4b-4281-b951-d872f2087c98

105 min agoSVN changes up to revision 265857
gitdeps [Thu, 24 Apr 2014 05:16:23 +0000 (22:16 -0700)]
SVN changes up to revision 265857

105 min agoCast: Audio transcoding support for cast_sender_app
hclam@chromium.org [Thu, 24 Apr 2014 05:16:19 +0000 (05:16 +0000)]
Cast: Audio transcoding support for cast_sender_app

Test cast sender app now supports audio transcoding. AV sync is still
not perfect but it's good enough for now.

Remaining things I need to improve:
* AV sync: video seems to be late
* Looping: AV sync will get worse after each loop
* Onscreen display: tells us the current AV drift and decoded frames

Review URL: https://codereview.chromium.org/250233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265858 0039d316-1c4b-4281-b951-d872f2087c98

105 min agoPersist choice to not show CAEDT (Chrome Apps and Extensions Developer Tool) promo...
rdevlin.cronin@chromium.org [Thu, 24 Apr 2014 05:15:48 +0000 (05:15 +0000)]
Persist choice to not show CAEDT (Chrome Apps and Extensions Developer Tool) promo in chrome:extensions.

BUG=365696

Review URL: https://codereview.chromium.org/246833007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265857 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoSVN changes up to revision 265850
gitdeps [Thu, 24 Apr 2014 04:11:23 +0000 (21:11 -0700)]
SVN changes up to revision 265850

2 hours agoRe-disable rasterize_and_record_micro on mac
skyostil@chromium.org [Thu, 24 Apr 2014 04:11:03 +0000 (04:11 +0000)]
Re-disable rasterize_and_record_micro on mac

BUG=350684
NOTRY=True

Review URL: https://codereview.chromium.org/249923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265850 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoSVN changes up to revision 265849
gitdeps [Thu, 24 Apr 2014 04:10:22 +0000 (21:10 -0700)]
SVN changes up to revision 265849

2 hours agoDisable page set inheritance if the page set was not constructed with dictionary...
nednguyen@google.com [Thu, 24 Apr 2014 04:10:03 +0000 (04:10 +0000)]
Disable page set inheritance if the page set was not constructed with dictionary (python page set).

BUG=366367

Review URL: https://codereview.chromium.org/253353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265849 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265846
gitdeps [Thu, 24 Apr 2014 03:50:27 +0000 (20:50 -0700)]
SVN changes up to revision 265846

3 hours agoUpdate Dr. Memory suppressions for new optimized whole-module-suppression support...
bruening@google.com [Thu, 24 Apr 2014 03:48:29 +0000 (03:48 +0000)]
Update Dr. Memory suppressions for new optimized whole-module-suppression support.  This avoids overhead from osmesa.dll and other suppressions. Also updates the Dr. Memory suppression parsing script to understand the imprecise counts for these suppressions.

TBR=zhaoqin@chromium.org
BUG=347967,364146

Review URL: https://codereview.chromium.org/259523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265846 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265845
gitdeps [Thu, 24 Apr 2014 03:48:23 +0000 (20:48 -0700)]
SVN changes up to revision 265845

3 hours agoAdded bolian as chrome_proxy test owner.
bolian@chromium.org [Thu, 24 Apr 2014 03:47:40 +0000 (03:47 +0000)]
Added bolian as chrome_proxy test owner.

NOTRY=True

Review URL: https://codereview.chromium.org/252403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265845 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265842
gitdeps [Thu, 24 Apr 2014 03:45:28 +0000 (20:45 -0700)]
SVN changes up to revision 265842

3 hours agoSVN changes up to revision 265841
gitdeps [Thu, 24 Apr 2014 03:43:24 +0000 (20:43 -0700)]
SVN changes up to revision 265841

3 hours agoCoreAnimation: Evict IOSurfaces after use
ccameron@chromium.org [Thu, 24 Apr 2014 03:43:15 +0000 (03:43 +0000)]
CoreAnimation: Evict IOSurfaces after use

CoreAnimation stores contents in CALayers, so it is
not necessary to keep around IOSurfaces after they
have been drawn (except in the case of being
backgrounded and then made visible again).

Discard these IOSurfaces if we have more than 8 of
them around. Only discard surfaces when they have
been drawn and the have no pending copy requests.

This relieves an increase in virtual address space used
by CoreAnimation.

Also move where size and scale factor are assigned so
that the size of the IOSurface can be un-set when it
is freed.

BUG=364808

Review URL: https://codereview.chromium.org/243133008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265842 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265839
gitdeps [Thu, 24 Apr 2014 03:41:25 +0000 (20:41 -0700)]
SVN changes up to revision 265839

3 hours agoLoosen timestamp requirement for VideoRendererImplTest.Rebuffer* tests.
scherkus@chromium.org [Thu, 24 Apr 2014 03:41:13 +0000 (03:41 +0000)]
Loosen timestamp requirement for VideoRendererImplTest.Rebuffer* tests.

While displaying _a_ frame during rebuffer is deterministic, knowing exactly _which_ frame is displayed is non-deterministic.

BUG=366361

Review URL: https://codereview.chromium.org/259463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265841 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoFix gs url in logcat dump, and set content type to text/plain
luqui@chromium.org [Thu, 24 Apr 2014 03:39:52 +0000 (03:39 +0000)]
Fix gs url in logcat dump, and set content type to text/plain

BUG=362787
TBR=navabi@chromium.org

Review URL: https://codereview.chromium.org/250153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265839 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265838
gitdeps [Thu, 24 Apr 2014 03:39:24 +0000 (20:39 -0700)]
SVN changes up to revision 265838

3 hours agoMacViews: Aura-related cleanups around ui/views
tapted@chromium.org [Thu, 24 Apr 2014 03:39:00 +0000 (03:39 +0000)]
MacViews: Aura-related cleanups around ui/views

This is a small group of changes to help ui/views compile when
use_aura=0.

- Fixes a few occurrences of NativeView <-> NativeWidget
- Removes NativeViewHost::kRenderNativeControlFocus (always false)
- Removes view_aura.cc (folds it into view.cc)
- Moves NativeWidgetAura::GetWindowTitleFontList to NativeWidgetPrivate

BUG=366007

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265815

Review URL: https://codereview.chromium.org/247803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265838 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265836
gitdeps [Thu, 24 Apr 2014 03:36:25 +0000 (20:36 -0700)]
SVN changes up to revision 265836

3 hours agoSVN changes up to revision 265835
gitdeps [Thu, 24 Apr 2014 03:34:24 +0000 (20:34 -0700)]
SVN changes up to revision 265835

3 hours agoExtract SandboxIPCProcess into its own file.
jorgelo@chromium.org [Thu, 24 Apr 2014 03:34:16 +0000 (03:34 +0000)]
Extract SandboxIPCProcess into its own file.

This is the first step to turning SandboxIPCProcess into a thread
in the browser process.

BUG=322185
TEST=Chrome builds and loads web pages.

Review URL: https://codereview.chromium.org/240563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265836 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoAdd support for 308 permanent redirects.
mmenke@chromium.org [Thu, 24 Apr 2014 03:32:37 +0000 (03:32 +0000)]
Add support for 308 permanent redirects.

See https://datatracker.ietf.org/doc/draft-reschke-http-status-308/

This should not break 308 Resume Incomplete responses, since they
don't have Location headers.

R=willchan@chromium.org
BUG=109012

Review URL: https://codereview.chromium.org/9816011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265835 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265834
gitdeps [Thu, 24 Apr 2014 03:32:23 +0000 (20:32 -0700)]
SVN changes up to revision 265834

3 hours agoAdd mDns firewall rules during chrome install or autoupdate.
vitalybuka@chromium.org [Thu, 24 Apr 2014 03:31:11 +0000 (03:31 +0000)]
Add mDns firewall rules during chrome install or autoupdate.
On Vista+ we rule allowing inbound traffic on 5353.
On XP we add rule blocking all inbound traffic for chrome.

BUG=360901

Review URL: https://codereview.chromium.org/238793008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265834 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265833
gitdeps [Thu, 24 Apr 2014 03:30:23 +0000 (20:30 -0700)]
SVN changes up to revision 265833

3 hours agoMake context_lost test more of a stress test.
kbr@chromium.org [Thu, 24 Apr 2014 03:29:54 +0000 (03:29 +0000)]
Make context_lost test more of a stress test.

This change much more reliably catches the assertion failure in Issue 365904.

BUG=365904

Review URL: https://codereview.chromium.org/256433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265833 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265832
gitdeps [Thu, 24 Apr 2014 03:26:23 +0000 (20:26 -0700)]
SVN changes up to revision 265832

3 hours ago[Telemetry] Convert a bunch of file opens to with-blocks.
tonyg@chromium.org [Thu, 24 Apr 2014 03:26:06 +0000 (03:26 +0000)]
[Telemetry] Convert a bunch of file opens to with-blocks.

This is intended to ensure the file is quickly closed to minimize chances for
flake.

BUG=

Review URL: https://codereview.chromium.org/247683007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265832 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265831
gitdeps [Thu, 24 Apr 2014 03:23:24 +0000 (20:23 -0700)]
SVN changes up to revision 265831

3 hours agoAdd a main menu item for disabling the notification bell on Mac.
dewittj@chromium.org [Thu, 24 Apr 2014 03:22:29 +0000 (03:22 +0000)]
Add a main menu item for disabling the notification bell on Mac.

The menu item reads "Hide Notifications Icon" and is default un-checked.  When
clicked, it is checked (and remains that way even across restarts.)  This selection
is saved in a machine-wide preference.

R=rsesek@chromium.org,thakis@chromium.org
TBR=gene@chromium.org,atwilson@chromium.org,stevenjb@chromium.org
BUG=305398

Review URL: https://codereview.chromium.org/242453012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265831 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265829
gitdeps [Thu, 24 Apr 2014 03:21:25 +0000 (20:21 -0700)]
SVN changes up to revision 265829

3 hours agoInit HWNDMessageHandler::msg_handled_ in the constructor.
msw@chromium.org [Thu, 24 Apr 2014 03:21:24 +0000 (03:21 +0000)]
Init HWNDMessageHandler::msg_handled_ in the constructor.

I noticed the value was 0xcdcdcdcd while debugging.

BUG=NONE
TEST=NONE
R=sky@chromium.org

Review URL: https://codereview.chromium.org/246893018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265830 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoMac: Add tracing of the CoreAnimation presentation state
ccameron@chromium.org [Thu, 24 Apr 2014 03:20:44 +0000 (03:20 +0000)]
Mac: Add tracing of the CoreAnimation presentation state

Track two pieces of state useful in debugging Mac drawing
performance: (1) the period over which a swap ack is pending
and (2) the instants at which CoreAnimation queries if we have
content to draw.

Ideally these would be trace instants and async events on a
pseudo-thread, but that functionality is incomplete. Instead,
use a counter to indicate the state, and instantaneous jumps
in the counter for the instants.

BUG=

Review URL: https://codereview.chromium.org/246933010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265829 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265828
gitdeps [Thu, 24 Apr 2014 03:18:24 +0000 (20:18 -0700)]
SVN changes up to revision 265828

3 hours agoRevert of Moves the notification icon out of the status area overflow. (https://coder...
thestig@chromium.org [Thu, 24 Apr 2014 03:17:52 +0000 (03:17 +0000)]
Revert of Moves the notification icon out of the status area overflow. (https://codereview.chromium.org/110693004/)

Reason for revert:
From Vista Tests 1:

StatusTrayStateChangerWinTest.TraySizeApiTest (run #1):
[ RUN      ] StatusTrayStateChangerWinTest.TraySizeApiTest
c:\b\build\slave\cr-win-rel\build\src\chrome\browser\ui\views\status_icons\status_tray_state_changer_interactive_uitest_win.cc(149): error: Expected: (new_width) > (width), actual: 241 vs 241
[  FAILED  ] StatusTrayStateChangerWinTest.TraySizeApiTest (94 ms)

Original issue's description:
> Moves the notification icon out of the status area overflow.
>
> This only happens the first time it is created per data dir,
> so that the user can change back their setting if desired.
>
> This approach uses COM to talk with Windows Explorer to
> change the user's notification area preferences.
>
> R=dimich@chromium.org
> BUG=347693
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265807

TBR=dimich@chromium.org,atwilson@chromium.org,sky@chromium.org,cpu@chromium.org,dewittj@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=347693

Review URL: https://codereview.chromium.org/256443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265828 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265827
gitdeps [Thu, 24 Apr 2014 03:11:53 +0000 (20:11 -0700)]
SVN changes up to revision 265827

3 hours ago[Android] Restore old exception types alongside new ones.
jbudorick@chromium.org [Thu, 24 Apr 2014 03:10:23 +0000 (03:10 +0000)]
[Android] Restore old exception types alongside new ones.

BUG=366305

Review URL: https://codereview.chromium.org/250343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265827 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoRemove TransportDIB methods from RenderProcess(Host)
jbauman@chromium.org [Thu, 24 Apr 2014 03:09:49 +0000 (03:09 +0000)]
Remove TransportDIB methods from RenderProcess(Host)

These aren't needed now that the legacy 2d path is gone.

BUG=362164

Review URL: https://codereview.chromium.org/247263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265826 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265823
gitdeps [Thu, 24 Apr 2014 03:09:24 +0000 (20:09 -0700)]
SVN changes up to revision 265823

3 hours ago[Telemetry] Fix potential flake in testPagesetRepeat.
tonyg@chromium.org [Thu, 24 Apr 2014 03:09:16 +0000 (03:09 +0000)]
[Telemetry] Fix potential flake in testPagesetRepeat.

A previous patch of mine (which seems unrelated) triggered flake in os.remove()
complaining that the file was still open. It seems like there could be a race
with closing the file here. The with-block should make it deterministic.

BUG=223572

Review URL: https://codereview.chromium.org/256413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265825 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoui/display/chromeos: Flush Xlib output buffer after calling XUngrabServer
djkurtz@chromium.org [Thu, 24 Apr 2014 03:08:30 +0000 (03:08 +0000)]
ui/display/chromeos: Flush Xlib output buffer after calling XUngrabServer

One of the horrors of using Xlib is its Output buffer.  When calling Xlib
functions, the X command bitstream is not actually sent right away.
Commands are first queued up in the Xlib output buffer, and only sent over
the wire when the output buffer is flushed.

X clients typically don't have to worry about this, since (a) commands
that require return a response are flushed immediately, and
(b) they usually have an event loop that calls XPending() (XNextEvent(),
or XWindowEvent()), which does a Flush internally.

Chrome, however, listens to the Xserver fd, and only enters its XPending()
loop if the File Can be Read Without Blocking.

Now, when output configurator updates the Output Configuration, it does
it while grabbing the server:
  XGrabServer
  // Update a bunch of stuff
  XUngrabServer

When the X server is grabbed by a client, it ignores requests from all
other X clients.  In particular, it ignores requests from the Chrome GPU
process.

But the "XUngrabServer()" command doesn't generate a response.  So, the
command just sits there in the Xlib output buffer...   Meanwhile, the
browser process continues on and will request that the GPU process do some
stuff, for which the GPU process will send a request to the X server.  The
GPU process blocks, waiting for the X server's response which never
arrives.  After 10 seconds, the GPU watchdog timer expires, restarting the
GPU Process.  As a side effect of this, the X server will send some data
to the Browser process, its X connection becomes readable, Chrome fetches
some events, and finally gets around to sending the XUngrabServer()
request, un-grabbing the server after ~10 seconds.

The quick and dirty fix is to just send an explicit XFlush() after
XUngrabServer().

The scary thing is that there could be other places throughout Chrome that
need the same treatment.

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
BUG=chromium:366125
TEST=connect hdmi monitor
TEST=switch to mirror mode (Ctrl+F4)
TEST=unplug monitor
    => No ui freeze.  GPU process does not crash (/var/log/ui/ui.LATEST)
TEST=re-plug monitor
    => No ui freeze.  GPU process does not crash (/var/log/ui/ui.LATEST)

R=oshima@chromium.org
R=dbehr@chromium.org
R=marcheu@chromium.org

Review URL: https://codereview.chromium.org/249253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265823 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoSVN changes up to revision 265822
gitdeps [Thu, 24 Apr 2014 03:07:43 +0000 (20:07 -0700)]
SVN changes up to revision 265822

3 hours agoUpdating trunk VERSION from 1955.0 to 1956.0
chrome-release@google.com [Thu, 24 Apr 2014 03:04:32 +0000 (03:04 +0000)]
Updating trunk VERSION from 1955.0 to 1956.0

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265822 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoSVN changes up to revision 265820
gitdeps [Thu, 24 Apr 2014 02:37:27 +0000 (19:37 -0700)]
SVN changes up to revision 265820

4 hours agoEnsure that the last used bookmark folder is actually a folder.
newt@chromium.org [Thu, 24 Apr 2014 02:36:43 +0000 (02:36 +0000)]
Ensure that the last used bookmark folder is actually a folder.

If the user has been creating and deleting bookmarks and bookmark folders
recently, the ID of the last used bookmark folder may actually now correspond to
a bookmark -- not a folder. Detect and correct this situation.

BUG=365933
NOTRY=true

Review URL: https://codereview.chromium.org/247283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265820 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoSVN changes up to revision 265819
gitdeps [Thu, 24 Apr 2014 02:21:23 +0000 (19:21 -0700)]
SVN changes up to revision 265819

4 hours agoRevert 265815 "MacViews: Aura-related cleanups around ui/views"
yosin@chromium.org [Thu, 24 Apr 2014 02:21:01 +0000 (02:21 +0000)]
Revert 265815 "MacViews: Aura-related cleanups around ui/views"

This patch is a prepearation of reverting r265814.

> MacViews: Aura-related cleanups around ui/views
>
> This is a small group of changes to help ui/views compile when
> use_aura=0.
>
> - Fixes a few occurrences of NativeView <-> NativeWidget
> - Removes NativeViewHost::kRenderNativeControlFocus (always false)
> - Removes view_aura.cc (folds it into view.cc)
> - Moves NativeWidgetAura::GetWindowTitleFontList to NativeWidgetPrivate
>
> BUG=366007
>
> Review URL: https://codereview.chromium.org/247803004

TBR=tapted@chromium.org

Review URL: https://codereview.chromium.org/250423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265819 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoSVN changes up to revision 265818
gitdeps [Thu, 24 Apr 2014 02:09:23 +0000 (19:09 -0700)]
SVN changes up to revision 265818

4 hours agoRevert 265814 "MacViews: Better layering for the touch selection..."
vadimsh@chromium.org [Thu, 24 Apr 2014 02:08:55 +0000 (02:08 +0000)]
Revert 265814 "MacViews: Better layering for the touch selection..."

Failed to compile on ChromiumOS Linux:

./../ui/views/touchui/touch_selection_controller_impl_unittest.cc:20:57: fatal error: ui/views/touch_selection_controller_factory.h: No such file or directory

See http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/2921

> MacViews: Better layering for the touch selection controller
>
> This CL moves ViewsTouchSelectionControllerFactory out of
> views/touchui/touch_selection_controller_impl.cc and into its own file
> one level higher.
>
> Result: the single touchui dependency moves from views_delegate.cc to a
> file that can be controlled on a per-platform basis. The touchui
> subfolder assumes aura is available. This allows touchui to be excluded
> from a build that doesn't need it.
>
> BUG=366007
>
> Review URL: https://codereview.chromium.org/248763003

TBR=tapted@chromium.org

Review URL: https://codereview.chromium.org/250403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265818 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoSVN changes up to revision 265815
gitdeps [Thu, 24 Apr 2014 01:50:23 +0000 (18:50 -0700)]
SVN changes up to revision 265815

5 hours agoMacViews: Aura-related cleanups around ui/views
tapted@chromium.org [Thu, 24 Apr 2014 01:48:55 +0000 (01:48 +0000)]
MacViews: Aura-related cleanups around ui/views

This is a small group of changes to help ui/views compile when
use_aura=0.

- Fixes a few occurrences of NativeView <-> NativeWidget
- Removes NativeViewHost::kRenderNativeControlFocus (always false)
- Removes view_aura.cc (folds it into view.cc)
- Moves NativeWidgetAura::GetWindowTitleFontList to NativeWidgetPrivate

BUG=366007

Review URL: https://codereview.chromium.org/247803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265815 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoSVN changes up to revision 265813
gitdeps [Thu, 24 Apr 2014 01:48:23 +0000 (18:48 -0700)]
SVN changes up to revision 265813

5 hours agoMacViews: Better layering for the touch selection controller
tapted@chromium.org [Thu, 24 Apr 2014 01:48:20 +0000 (01:48 +0000)]
MacViews: Better layering for the touch selection controller

This CL moves ViewsTouchSelectionControllerFactory out of
views/touchui/touch_selection_controller_impl.cc and into its own file
one level higher.

Result: the single touchui dependency moves from views_delegate.cc to a
file that can be controlled on a per-platform basis. The touchui
subfolder assumes aura is available. This allows touchui to be excluded
from a build that doesn't need it.

BUG=366007

Review URL: https://codereview.chromium.org/248763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265814 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agocros: Restore accidentally deleted multiprofile prefs.
xiyuan@chromium.org [Thu, 24 Apr 2014 01:47:53 +0000 (01:47 +0000)]
cros: Restore accidentally deleted multiprofile prefs.

BUG=364599

Review URL: https://codereview.chromium.org/256403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265813 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoEliminate functions from RenderViewImpl whose only job is to fire notifications.
avi@chromium.org [Thu, 24 Apr 2014 01:47:17 +0000 (01:47 +0000)]
Eliminate functions from RenderViewImpl whose only job is to fire notifications.

BUG=361761
TEST=no visible change

Review URL: https://codereview.chromium.org/248043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265812 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoSVN changes up to revision 265811
gitdeps [Thu, 24 Apr 2014 01:36:26 +0000 (18:36 -0700)]
SVN changes up to revision 265811

5 hours agoMove Files.app files to ui/file_manager
yoshiki@chromium.org [Thu, 24 Apr 2014 01:36:00 +0000 (01:36 +0000)]
Move Files.app files to ui/file_manager

This is a reland of r265551.

BUG=345171
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/247123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265811 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoSVN changes up to revision 265810
gitdeps [Thu, 24 Apr 2014 01:19:23 +0000 (18:19 -0700)]
SVN changes up to revision 265810

5 hours agocc: Use the onscreen context to perform composited ganesh filters.
danakj@chromium.org [Thu, 24 Apr 2014 01:17:52 +0000 (01:17 +0000)]
cc: Use the onscreen context to perform composited ganesh filters.

This avoids the need for an offscreen context at all. Since the GPU
rasterization path is already doing similar stuff, we need to support
both cc and ganesh using the same context. This is a bit trickier
since it occurs in the middle of drawing a frame instead of between
frames, but as long as we restore all state that GLRenderer ever sets,
it works.

R=enne@chromium.org, senorblanco@chromium.org
BUG=366132

Review URL: https://codereview.chromium.org/250083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265810 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoSVN changes up to revision 265808
gitdeps [Thu, 24 Apr 2014 01:17:23 +0000 (18:17 -0700)]
SVN changes up to revision 265808

5 hours agoImporter: Clean up a bunch of old TODOs and convert observer interfaces to base:...
thestig@chromium.org [Thu, 24 Apr 2014 01:17:17 +0000 (01:17 +0000)]
Importer: Clean up a bunch of old TODOs and convert observer interfaces to base::Callbacks.

Review URL: https://codereview.chromium.org/246323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265809 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoAdded a public function to cancel any fling gestures
elisabets@opera.com [Thu, 24 Apr 2014 01:16:41 +0000 (01:16 +0000)]
Added a public function to cancel any fling gestures

BUG=

Review URL: https://codereview.chromium.org/227303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265808 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoMoves the notification icon out of the status area overflow.
dewittj@chromium.org [Thu, 24 Apr 2014 01:16:11 +0000 (01:16 +0000)]
Moves the notification icon out of the status area overflow.

This only happens the first time it is created per data dir,
so that the user can change back their setting if desired.

This approach uses COM to talk with Windows Explorer to
change the user's notification area preferences.

R=dimich@chromium.org
BUG=347693

Review URL: https://codereview.chromium.org/110693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265807 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoSVN changes up to revision 265803
gitdeps [Thu, 24 Apr 2014 01:03:27 +0000 (18:03 -0700)]
SVN changes up to revision 265803

5 hours agoUpdate Chromium to new Skia headers & beginRecording signature
robertphillips@google.com [Thu, 24 Apr 2014 01:02:25 +0000 (01:02 +0000)]
Update Chromium to new Skia headers & beginRecording signature

As of Skia r14295 the SkPictureRecorder class resides in
its own header (SkPictureRecorder.h) and beginRecording
takes an additional (factory) parameter. Temporarily the
new signature doesn't allow default parameters so as to
avoid compiler confusion with the deprecated signature.
The SkTileGridPicture has been replaced by the
SkTileGridFactory which is now passed into beginRecording.

Note: this cannot be landed until Skia r14295 is rolled
into Chromium (presumably this morning).

enne : cc
fmalita: skia

Review URL: https://codereview.chromium.org/246753009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265803 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSVN changes up to revision 265802
gitdeps [Thu, 24 Apr 2014 01:00:25 +0000 (18:00 -0700)]
SVN changes up to revision 265802

6 hours agoRefactor SSL error handling callback.
sgurun@chromium.org [Thu, 24 Apr 2014 00:59:27 +0000 (00:59 +0000)]
Refactor SSL error handling callback.

Move the logic to post to UI thread to aw, to make glue even thinner. the counterpart CL
will be up after this rolls in.
BUG=

Review URL: https://codereview.chromium.org/246513007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265802 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSVN changes up to revision 265801
gitdeps [Thu, 24 Apr 2014 00:58:22 +0000 (17:58 -0700)]
SVN changes up to revision 265801

6 hours agoautofill: Convert WindowedPersonalDataManagerObserver to use InfoBarManager::Observer.
tfarina@chromium.org [Thu, 24 Apr 2014 00:57:43 +0000 (00:57 +0000)]
autofill: Convert WindowedPersonalDataManagerObserver to use InfoBarManager::Observer.

This makes us move away from the deprecated content NotificationService API and
use the new Observer style.

BUG=354380
TEST=browser_tests --gtest_filter=AutofillTest.*
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/246643012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265801 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSVN changes up to revision 265800
gitdeps [Thu, 24 Apr 2014 00:56:24 +0000 (17:56 -0700)]
SVN changes up to revision 265800

6 hours agoAdd telemetry tests to Android tester.
navabi@google.com [Thu, 24 Apr 2014 00:55:22 +0000 (00:55 +0000)]
Add telemetry tests to Android tester.

BUG=337829

Review URL: https://codereview.chromium.org/235573010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265800 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSVN changes up to revision 265795
gitdeps [Thu, 24 Apr 2014 00:38:24 +0000 (17:38 -0700)]
SVN changes up to revision 265795

6 hours agoAdd BUILD.gn to build components resources from grit.
tfarina@chromium.org [Thu, 24 Apr 2014 00:37:30 +0000 (00:37 +0000)]
Add BUILD.gn to build components resources from grit.

In Debug configuration:

$ gn gen out/Debug_gn
$ ninja -C out/Debug_gn components_resources

In Release configuration:

$ gn gen out/Release_gn --args=is_debug=false
$ ninja -C out/Release_gn components_resources

BUG=None
TEST=see above
R=brettw@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/246023006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265795 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoRename WiFiService::GetConnectedProperties into GetCurrentProperties to reflect the...
mef@chromium.org [Thu, 24 Apr 2014 00:37:30 +0000 (00:37 +0000)]
Rename WiFiService::GetConnectedProperties into GetCurrentProperties to reflect the fact that current network associated with wlan interface may be not connected but transitioning on Windows.

BUG=364907

Review URL: https://codereview.chromium.org/249683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265794 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSVN changes up to revision 265792
gitdeps [Thu, 24 Apr 2014 00:36:23 +0000 (17:36 -0700)]
SVN changes up to revision 265792

6 hours agoUpdates to GCMClientImpl to use and update gservices settings.
fgorski@chromium.org [Thu, 24 Apr 2014 00:35:37 +0000 (00:35 +0000)]
Updates to GCMClientImpl to use and update gservices settings.
Triggering periodic checkin based on checkin interval.
Adding ability to skip a periodic checkin when it would be too early.

BUG=359254

Review URL: https://codereview.chromium.org/243813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265792 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSVN changes up to revision 265791
gitdeps [Thu, 24 Apr 2014 00:32:25 +0000 (17:32 -0700)]
SVN changes up to revision 265791

6 hours agoChange "percentage change" function and add comments/test for it.
qyearsley@chromium.org [Thu, 24 Apr 2014 00:31:45 +0000 (00:31 +0000)]
Change "percentage change" function and add comments/test for it.

Goal: To make it clearer how percentage change is calculated, and make it so that it's the same as how the dashboard calculates it.

BUG=

Review URL: https://codereview.chromium.org/241273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265791 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSVN changes up to revision 265790
gitdeps [Thu, 24 Apr 2014 00:26:25 +0000 (17:26 -0700)]
SVN changes up to revision 265790

6 hours agoChecked validity of status_widget before calling IsActive method.
shrikant@chromium.org [Thu, 24 Apr 2014 00:24:36 +0000 (00:24 +0000)]
Checked validity of status_widget before calling IsActive method.
Rest of the code seem to suggest that we always check validity of status_area_widget() pointer before calling method on it.
Also a specific comment in the code "status_area_widget() may be NULL during the shutdown." seems to suggest status_area_widget being NULL is expected.
shelf_ could have been a possible culprit here, but before we reach this particular statment, we have already called methods on it, so possibility of status_area_widget() being culprit is more. This bug doesn't repro on my machine so have to go with guess work.

BUG=365631
R=skuhne@chromium.org

Review URL: https://codereview.chromium.org/251343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265790 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoSVN changes up to revision 265789
gitdeps [Thu, 24 Apr 2014 00:24:27 +0000 (17:24 -0700)]
SVN changes up to revision 265789