chromium/src/build.git
24 min agoextract_build failure should be fatal master
eseidel@chromium.org [Mon, 28 Jul 2014 15:59:04 +0000 (15:59 +0000)]
extract_build failure should be fatal

This code has been here since this script was created back
in bug 154525, however these days the warning code is 88.
Maybe the warning code has always been 88, but its always been
OK for an extract_build step to be non-fatal.

I would be happy to test this if someone could explain
to me how this file is tested.

These days we expect extract_build to fail the build, if it doesn't
then we just go and run test with the wrong revision, etc.

BUG=397710, 154525

Review URL: https://codereview.chromium.org/416243007

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285914 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

48 min agoAdd arch support for tombstone.py
halton.huo@intel.com [Mon, 28 Jul 2014 15:35:18 +0000 (15:35 +0000)]
Add arch support for tombstone.py

'stack' tool has archtechture support by passing --arch argument, if it
is not given, arm will be used by default. Thus the stack trace will be
wrongly reported.

To resolve it, 'arch' prop is added to tombstone when fetching from
device, and pass it to symbol.ARCH at end.

R=jbudorick@chromium.org
BUG=

Review URL: https://codereview.chromium.org/416983004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285910 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

12 hours agoRe-disable warning 4018 in the GN Windows build.
brettw@chromium.org [Mon, 28 Jul 2014 04:04:20 +0000 (04:04 +0000)]
Re-disable warning 4018 in the GN Windows build.

Note even base compiles with the change to disable it.

TBR=pkasting

Review URL: https://codereview.chromium.org/422773002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285860 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

29 hours agoMove DesktopWindowTreeHostX11Test.Deactivate to interactive_ui_tests
pkotwicz@chromium.org [Sun, 27 Jul 2014 11:21:55 +0000 (11:21 +0000)]
Move DesktopWindowTreeHostX11Test.Deactivate to interactive_ui_tests

Hopefully the move will make DesktopWindowTreeHostX11Test.Deactivate no longer
flaky. Only a single window can be active at a time. I suspect that this test
sometimes fails when run in parallel with other tests

BUG=396491
TEST=None

Review URL: https://codereview.chromium.org/414123005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285834 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 days agoRe-enable various MSVC warnings.
pkasting@chromium.org [Sat, 26 Jul 2014 00:01:53 +0000 (00:01 +0000)]
Re-enable various MSVC warnings.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/415773009

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285730 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 days agoRevert of Run android tests through runtest.py. (https://codereview.chromium.org...
dmichael@chromium.org [Fri, 25 Jul 2014 22:55:28 +0000 (22:55 +0000)]
Revert of Run android tests through runtest.py. (https://codereview.chromium.org/410033002/)

Reason for revert:
Broke a ton of tests:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14823

Original issue's description:
> Run android tests through runtest.py.
>
> BUG=329102
> R=qyearsley@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285667

TBR=qyearsley@chromium.org,jbudorick@chromium.org,klundberg@chromium.org,navabi@chromium.org,yfriedman@chromium.org,eseidel@chromium.org,zty@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329102

Review URL: https://codereview.chromium.org/423593002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285716 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 days agoDisable exceptions on Windows in all builds (take 4)
hwennborg@google.com [Fri, 25 Jul 2014 21:02:28 +0000 (21:02 +0000)]
Disable exceptions on Windows in all builds (take 4)

They were previously enabled in shared_library builds for historical reasons.

Turning them off makes things nice and consistent across all build types,
and helps the Windows Clang build, which currently doesn't support exceptions.

Previous attemps failed due to:

- mojo_public_environment_unittests unreachable code warning in
  DrMemory shared_library Release builds (crbug.com/397465)
  Fixed in Chromium r285674.

- chrome_elf_unittests on x64 (crbug.com/396244)
  Fixed in Chromium r285377.

- blink_platform_unittests:DateTimeFormatTest.CommonPattern et al.
  Fixed in Blink r176189

BUG=82385
TBR=thakis

Review URL: https://codereview.chromium.org/419973003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285676 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 days agoRun android tests through runtest.py.
zty@chromium.org [Fri, 25 Jul 2014 20:40:35 +0000 (20:40 +0000)]
Run android tests through runtest.py.

BUG=329102
R=qyearsley@chromium.org

Review URL: https://codereview.chromium.org/410033002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285667 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 days agoRevert 285458 "Disable exceptions on Windows in all builds (take 3)"
zhaoqin@google.com [Fri, 25 Jul 2014 17:33:42 +0000 (17:33 +0000)]
Revert 285458 "Disable exceptions on Windows in all builds (take 3)"

BUG=397465

> Disable exceptions on Windows in all builds (take 3)
>
> They were previously enabled in shared_library builds for historical reasons.
>
> This change is relevant for Clang, which currently doesn't support exceptions
> on Windows.
>
> Previous attemps failed due to:
> - chrome_elf_unittests on x64 (crbug.com/396244)
>   Fixed in Chromium r285377.
>
> - blink_platform_unittests:DateTimeFormatTest.CommonPattern et al.
>   Fixed in Blink r176189
>
> BUG=82385
> TBR=thakis
>
> Review URL: https://codereview.chromium.org/420593002

TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/418393002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285614 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 days agoandroid: Fix parameter for onFinishGetBitmap in ContentReadbackHandler
powei@chromium.org [Fri, 25 Jul 2014 17:21:42 +0000 (17:21 +0000)]
android: Fix parameter for onFinishGetBitmap in ContentReadbackHandler

The boolean parameter is not necessary as we can just use null to indicate
readback failure.

android= https://chrome-internal-review.googlesource.com/#/c/169047/
BUG=

Review URL: https://codereview.chromium.org/390933003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285609 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 days agoDrop unneeded warning suppression on mac
tzik@chromium.org [Fri, 25 Jul 2014 12:38:07 +0000 (12:38 +0000)]
Drop unneeded warning suppression on mac

BUG=162783

Review URL: https://codereview.chromium.org/400873003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285578 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 days ago[MIPS] Add seccomp bpf support
nedeljko.babic@imgtec.com [Fri, 25 Jul 2014 09:03:43 +0000 (09:03 +0000)]
[MIPS] Add seccomp bpf support

Add support for seccomp bpf sandboxing on MIPS architecture.
Enable testing of seccomp bpf sandbox.

Support for seccomp bpf for MIPS was added in Linux kernel version 3.15.

This patchset was reviewed in https://chromiumcodereview.appspot.com/260793003/ and re-created
to workaround a commit-queue issue.

BUG=369594
TEST=sandbox_linux_unittests

Review URL: https://codereview.chromium.org/409403003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285538 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 days agogn win: Always warnings as errors
scottmg@chromium.org [Fri, 25 Jul 2014 06:12:45 +0000 (06:12 +0000)]
gn win: Always warnings as errors

R=brettw@chromium.org
BUG=393046,354261

Review URL: https://codereview.chromium.org/412423002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285502 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 days agoDisable exceptions on Windows in all builds (take 3)
hans@chromium.org [Fri, 25 Jul 2014 02:31:10 +0000 (02:31 +0000)]
Disable exceptions on Windows in all builds (take 3)

They were previously enabled in shared_library builds for historical reasons.

This change is relevant for Clang, which currently doesn't support exceptions
on Windows.

Previous attemps failed due to:
- chrome_elf_unittests on x64 (crbug.com/396244)
  Fixed in Chromium r285377.

- blink_platform_unittests:DateTimeFormatTest.CommonPattern et al.
  Fixed in Blink r176189

BUG=82385
TBR=thakis

Review URL: https://codereview.chromium.org/420593002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285458 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 days agoAdding xsltproc and ant to support some naclports dependencies.
bradnelson@google.com [Thu, 24 Jul 2014 23:25:31 +0000 (23:25 +0000)]
Adding xsltproc and ant to support some naclports dependencies.

BUG=None
TEST=None
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/418973002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285405 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 days agoMiscellaneous GN updates.
brettw@chromium.org [Thu, 24 Jul 2014 23:10:53 +0000 (23:10 +0000)]
Miscellaneous GN updates.

Removes some unnecessary prints accidentally checked in to the Android build.

Removes a GYP TODO now that angle has rolled.

Updates commented-out labels of targets that now exist.

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/419053002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285400 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 days agoozone: Fix GN build for ozone_egl_demo, ozone_unittests
spang@chromium.org [Thu, 24 Jul 2014 20:44:16 +0000 (20:44 +0000)]
ozone: Fix GN build for ozone_egl_demo, ozone_unittests

This fixes the GN build for the ui/ozone component (and tests). The
following build should work going forward:

 gn gen out_gn_ozone --args="use_ozone=true"
 ninja -C out_gn_ozone -j1000 -k50 ozone_egl_demo ozone_unittests

BUG=396316
TEST=compile & run ozone_egl_demo, ozone_unittests
TBR=darin

Review URL: https://codereview.chromium.org/409163004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285362 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 days agoFix perf control to check for file before reading.
navabi@google.com [Thu, 24 Jul 2014 20:11:52 +0000 (20:11 +0000)]
Fix perf control to check for file before reading.

This is failing on our new 64-bit devices:
https://uberchromegw.corp.google.com/i/clank/builders/volantis-official-perf-clankium-lmp/builds/15/steps/dromaeo.jslibeventjquery/logs/stdio

BUG=392153

Review URL: https://codereview.chromium.org/400493003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285354 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 days agoAdd missing base files to GN build.
brettw@chromium.org [Thu, 24 Jul 2014 18:24:30 +0000 (18:24 +0000)]
Add missing base files to GN build.

Fix the devtools resources target to use the grit template.

Fix the grit template to use the correct output directory for the expected files if one is specified

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/414973002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285334 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 days agoThe sandbox setup script now uses CHROMIUM_OUT_DIR when defined.
mustaq@chromium.org [Thu, 24 Jul 2014 16:37:20 +0000 (16:37 +0000)]
The sandbox setup script now uses CHROMIUM_OUT_DIR when defined.

BUG=

Review URL: https://codereview.chromium.org/409133006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285296 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoRevert the re-enabling of heap_profiler unittests.
johnme@chromium.org [Thu, 24 Jul 2014 16:01:59 +0000 (16:01 +0000)]
Revert the re-enabling of heap_profiler unittests.

This reverts the build/android/pylib/gtest/gtest_config.py change from
commit 70412aeeba4e4053a001a921a91a2748643dbbd6
(https://codereview.chromium.org/395543003/) in order to disable the
heap_profiler_unittests suite, as it's been failing on
yakju-clang-clankium ever since it was added in
https://chromegw.corp.google.com/i/clank/builders/yakju-clang-clankium/builds/9921

NOTRY=true
TBR=primiano@chromium.org
NOTREECHECKS=true
BUG=393964

Review URL: https://codereview.chromium.org/416003005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285291 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoMake it possible to generate static and dynamic CLD2 libraries in one build.
andrewhayden@chromium.org [Thu, 24 Jul 2014 15:58:30 +0000 (15:58 +0000)]
Make it possible to generate static and dynamic CLD2 libraries in one build.

This is necessary to allow building multiple targets with conflicting
requirements, such as chrome_shell (needing a statically-linked CLD2) at the
same time as the APK for Android (using, e.g., the "component" CLD2 data
source). For more information and background, refer to the linked bug.

This change should be a no-op in all current build configurations, but moves
closer to enabling the behavior described above.

BUG=367239
TBR=toyoshim
NOTRY=true

Review URL: https://codereview.chromium.org/416863002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285289 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoDon't set use_custom_libcxx in ASan builds on CrOS.
glider@chromium.org [Thu, 24 Jul 2014 15:41:42 +0000 (15:41 +0000)]
Don't set use_custom_libcxx in ASan builds on CrOS.

BUG=396979
R=earthdok@chromium.org

Review URL: https://codereview.chromium.org/419493002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285282 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoUpdate isolate file for sync_integration_tests and enable swarming for it.
jam@chromium.org [Thu, 24 Jul 2014 14:14:14 +0000 (14:14 +0000)]
Update isolate file for sync_integration_tests and enable swarming for it.

TBR=sky

Review URL: https://codereview.chromium.org/417843002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285246 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoAdd chrome_proxy tests to Android tester.
bolian@chromium.org [Thu, 24 Jul 2014 11:44:27 +0000 (11:44 +0000)]
Add chrome_proxy tests to Android tester.

This is modeled after https://codereview.chromium.org/235573010.  chrome_proxy tests were originally part of telemetry pref tests and split out with https://codereview.chromium.org/397483002/

Review URL: https://codereview.chromium.org/408873003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285197 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoMove apps/shell to extensions/shell.
yoz@chromium.org [Thu, 24 Jul 2014 03:39:36 +0000 (03:39 +0000)]
Move apps/shell to extensions/shell.

This does:
- Move files
- Fix up all namespaces in these files to be extensions, not apps
- Clean up DEPS files

This does not:
- Change the name of the build targets (app_shell, app_shell_browsertests)

BUG=394987
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/412713002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285144 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days ago[Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.
jbudorick@chromium.org [Thu, 24 Jul 2014 01:03:49 +0000 (01:03 +0000)]
[Android] Switch to DeviceUtils versions of GetMemoryUsageForPid and __str__.

BUG=267773

Review URL: https://codereview.chromium.org/404993004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285097 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoDon't wipe data when provisioning non-rooted devices.
tonyg@chromium.org [Wed, 23 Jul 2014 19:11:02 +0000 (19:11 +0000)]
Don't wipe data when provisioning non-rooted devices.

If EnableAdbRoot fails, then we can't wipe the data because then we're
not able to restore the adb_keys and the device never reappears.

BUG=396120

Review URL: https://codereview.chromium.org/413523006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@285008 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoSuppress MissingApplicationIcon Android lint warning.
newt@chromium.org [Wed, 23 Jul 2014 17:57:05 +0000 (17:57 +0000)]
Suppress MissingApplicationIcon Android lint warning.

We have lots of test APKs that don't need application icons. And I think
we'd notice if Chrome itself was missing an icon even without this
warning ;)

BUG=393235
NOTRY=true

Review URL: https://codereview.chromium.org/410683007

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284992 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoAdd 'hi' locale for iOS.
lliabraa@chromium.org [Wed, 23 Jul 2014 17:14:53 +0000 (17:14 +0000)]
Add 'hi' locale for iOS.

BUG=396534

Review URL: https://codereview.chromium.org/417473003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284971 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoUpdate the tracing grit GN rule
brettw@chromium.org [Wed, 23 Jul 2014 16:34:40 +0000 (16:34 +0000)]
Update the tracing grit GN rule

Previously this rule had a lot of custom stuff to work around the fact that the grit rule couldn't run at GN time to get the inputs and outputs. Now that the inputs are lazy, we can use the template.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/414623002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284948 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 days agoEncode all grit outputs in .gn files
brettw@chromium.org [Wed, 23 Jul 2014 16:32:32 +0000 (16:32 +0000)]
Encode all grit outputs in .gn files

This finishes the rest of the Grit outputs that was started in a previous pass, and removes the ability to optionally deduce outputs at GN-time (which is slow so we don't want to do it).

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/411543005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284947 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoRevert 284930 "Use libc++ for all non-Windows ASan builds."
asvitkine@chromium.org [Wed, 23 Jul 2014 15:50:25 +0000 (15:50 +0000)]
Revert 284930 "Use libc++ for all non-Windows ASan builds."

Broke Mac ASan Builder gclient runhooks step:

Error: Command /Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium returned non-zero exit status 1 in /Volumes/data/b/build/slave/Mac_ASan_Builder/build
Updating projects from gyp files...
Using overrides found in /Users/chrome-bot/.gyp/include.gypi
gyp: Found /Volumes/data/b/build/slave/Mac_ASan_Builder/build/src/third_party/libc++/libc++.gyp:libcxx_proxy#target in dependencies! of /Volumes/data/b/build/slave/Mac_ASan_Builder/build/src/base/base.gyp:sanitizer_options#target, but not in dependencies
builder -> 'ninja'
gyp_defines -> {'asan': '1', 'gomadir': '/Volumes/data/b/build/goma', 'use_goma': '1', 'component': 'static_library', 'release_extra_cflags': '-gline-tables-only'}
IsWindows -> False
IsLinux -> False
platform -> 'mac'
Running build/landmines.py...
Hook '/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/python src/build/gyp_chromium' took 51.21 secs

> Use libc++ for all non-Windows ASan builds.
>
> BUG=318770
> TBR=earthdok@chromium.org
>
> Review URL: https://codereview.chromium.org/414703002

TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/410213002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284932 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoUse libc++ for all non-Windows ASan builds.
glider@chromium.org [Wed, 23 Jul 2014 15:35:55 +0000 (15:35 +0000)]
Use libc++ for all non-Windows ASan builds.

BUG=318770
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/414703002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284930 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoGN: Fix extra escaping of rpath=$ORIGIN/lib ldflag
jamesr@chromium.org [Wed, 23 Jul 2014 08:57:26 +0000 (08:57 +0000)]
GN: Fix extra escaping of rpath=$ORIGIN/lib ldflag

As written the argument ended up in the .ninja file as \\\$$ORIGIN/lib/
but we want \$$ORIGIN/lib/ to match gyp.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/409883009

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284888 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoAdding lib32ncurses5-dev to install-builds-deps.sh
bradnelson@google.com [Wed, 23 Jul 2014 02:25:08 +0000 (02:25 +0000)]
Adding lib32ncurses5-dev to install-builds-deps.sh

This library is required to be build tui mode support into nacl gdb.

BUG=https://code.google.com/p/chromium/issues/detail?id=391170
TEST=local + bots
R=dyen@chromium.org,uekawa@chromium.org

Review URL: https://codereview.chromium.org/407663002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284840 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoGN chrome/common build, rename enable_printing.
brettw@chromium.org [Tue, 22 Jul 2014 21:49:52 +0000 (21:49 +0000)]
GN chrome/common build, rename enable_printing.

This adds the missing conditions to the chrome/common GN build file (previously
only the basic files were there). Some refactoring of the GYP file to make this
possible.

Renames the enable_printing flag to printing_mode since this is an integer
tri-state.

Minor improvements to chrome/renderer

TBR=jamesr@chromium.org
Original review=https://codereview.chromium.org/400243003/

BUG=

Review URL: https://codereview.chromium.org/409683003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284783 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoAdded fastbuild config variable to isolate.gypi to let isolates test it.
kbr@chromium.org [Tue, 22 Jul 2014 19:51:31 +0000 (19:51 +0000)]
Added fastbuild config variable to isolate.gypi to let isolates test it.

Also added chrome_child.dll.pdb to telemetry_gpu_test isolate. This is
in order to get better stack traces for debugging Issue 383963.

BUG=385976,383963
NOTRY=true

Review URL: https://codereview.chromium.org/409113005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284760 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoMakes embedded content shell build without pango
varkha@chromium.org [Tue, 22 Jul 2014 19:50:47 +0000 (19:50 +0000)]
Makes embedded content shell build without pango

BUG=178543
TEST=build embedded content shell with chromeos=1 and embedded=1

Review URL: https://codereview.chromium.org/400793002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284759 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoMake the GN Android builds goma-aware.
dpranke@chromium.org [Tue, 22 Jul 2014 19:35:01 +0000 (19:35 +0000)]
Make the GN Android builds goma-aware.

R=brettw@chromium.org
BUG=394501

Review URL: https://codereview.chromium.org/409743002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284756 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoUpdate isolate files for content tests and enable swarming for them.
jam@chromium.org [Tue, 22 Jul 2014 18:29:51 +0000 (18:29 +0000)]
Update isolate files for content tests and enable swarming for them.

Review URL: https://codereview.chromium.org/401923004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284736 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoDisable lint errors about assertions.
newt@chromium.org [Tue, 22 Jul 2014 18:21:27 +0000 (18:21 +0000)]
Disable lint errors about assertions.

For now, these warnings are just noise (and lots of it).

BUG=393235
R=aurimas@chromium.org

Review URL: https://codereview.chromium.org/397843006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284730 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoSwitch to BoringSSL.
davidben@chromium.org [Tue, 22 Jul 2014 18:20:37 +0000 (18:20 +0000)]
Switch to BoringSSL.

This is a reland of r284079 which was reverted in r284248 for components build
issues. That, in turn, was a reland of r283813 which was reverted in r283845
because it broke WebRTC tests on Android. That, in turn, was a reland of
r283542 which was reverted in r283591 because it broke the WebView build.

This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.

BUG=393317
R=agl@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/401153002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284729 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoHook up .d files and outputs to grit
brettw@chromium.org [Tue, 22 Jul 2014 16:37:26 +0000 (16:37 +0000)]
Hook up .d files and outputs to grit

Pull grit 171 to get the new deps fixes required to implement this.

This removes the call to grit for querying inputs completely, and enables depfile writing to enable automatic rebuilds when things are out-of-date.

Adds a new outputs variable that bypasses querying grit for outputs. This will assert that the given files exist in grit. This version allows outputs to be empty in which case it will revert to the old dynamic behavior. I'm going to land this with just the worst cases fixed to make landing easier. Then followup with converting the rest of the grit targets and removing the dynamic option.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/407653003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284705 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoMove mojo java bindings to mojo/public
qsr@chromium.org [Tue, 22 Jul 2014 16:29:39 +0000 (16:29 +0000)]
Move mojo java bindings to mojo/public

R=cmasone@chromium.org,viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/407733006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284701 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoEnable libc++ under ASan by default.
glider@chromium.org [Tue, 22 Jul 2014 13:28:08 +0000 (13:28 +0000)]
Enable libc++ under ASan by default.

BUG=318770
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/235953006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284675 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days ago[Android] Only build relocation_packer_unittests on ARM and ARM64.
bauerb@chromium.org [Tue, 22 Jul 2014 12:36:09 +0000 (12:36 +0000)]
[Android] Only build relocation_packer_unittests on ARM and ARM64.

This fixes building "all" on non-ARM platforms.

TBR=ben@chromium.org
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/404353004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284669 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoRevert of Disable exceptions on Windows also in the shared_library build (https:...
ksakamoto@chromium.org [Tue, 22 Jul 2014 04:31:52 +0000 (04:31 +0000)]
Revert of Disable exceptions on Windows also in the shared_library build (https://codereview.chromium.org/404853002/)

Reason for revert:
Speculative revert to try to fix chrome_elf_unittests on Win7 x64.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%282%29/builds/18370
  AddDllsFromRegistryToBlacklist
  LoadBlacklistedLibrary

I'll reland if that's not it.

Original issue's description:
> Disable exceptions on Windows also in the shared_library build
>
> They were previously only disabled in static_library builds. This is believed
> to have been due to problems with old MSVC versions, but it should work now.
>
> This change is relevant for Clang, which currently doesn't support exceptions
> on Windows.
>
> Last time I attempted to do this, it broke some tests due to a debug assertion.
> Gtest had previously been catching the exception, but with exceptions disabled
> it crashed. Those tests were actually broken in static_library Debug builds
> too, but we don't seem to have bots for that. After Blink r176189, we no longer
> hit that debug assertion, so the tests now pass.
>
> BUG=82385
> TEST=blink_platform_unittests --gtest_filter=DateTimeFormatTest.CommonPattern,
>      content_browsertests --gtest_filter=RenderViewImplTest.SetEditableSelectionAndComposition
>      webkit_unit_tests
>
> R=thakis@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284519

TBR=maruel@chromium.org,thakis@chromium.org,hans@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/410613002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284626 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoAdd chromium_builder_lkgr_drmemory_win target for LKGR DrMemory build on ClusterFuzz
zhaoqin@google.com [Tue, 22 Jul 2014 02:25:49 +0000 (02:25 +0000)]
Add chromium_builder_lkgr_drmemory_win target for LKGR DrMemory build on ClusterFuzz

R=bruening@chromium.org
NOTRY=TRUE
BUG=NONE

Review URL: https://codereview.chromium.org/406853003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284596 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoCopy the PGO runtime library to the release directory (take 2)
sebmarchand@chromium.org [Tue, 22 Jul 2014 00:18:32 +0000 (00:18 +0000)]
Copy the PGO runtime library to the release directory (take 2)

This is a reland of https://codereview.chromium.org/402993002/ with an additional check to make sure that the DLLs exist before trying to copy them.

BUG=395183

Review URL: https://codereview.chromium.org/405983003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284550 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoDisable exceptions on Windows also in the shared_library build
hans@chromium.org [Mon, 21 Jul 2014 22:35:48 +0000 (22:35 +0000)]
Disable exceptions on Windows also in the shared_library build

They were previously only disabled in static_library builds. This is believed
to have been due to problems with old MSVC versions, but it should work now.

This change is relevant for Clang, which currently doesn't support exceptions
on Windows.

Last time I attempted to do this, it broke some tests due to a debug assertion.
Gtest had previously been catching the exception, but with exceptions disabled
it crashed. Those tests were actually broken in static_library Debug builds
too, but we don't seem to have bots for that. After Blink r176189, we no longer
hit that debug assertion, so the tests now pass.

BUG=82385
TEST=blink_platform_unittests --gtest_filter=DateTimeFormatTest.CommonPattern,
     content_browsertests --gtest_filter=RenderViewImplTest.SetEditableSelectionAndComposition
     webkit_unit_tests

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/404853002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284519 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoRevert 284508 "GN chrome/common build, rename enable_printing."
brettw@chromium.org [Mon, 21 Jul 2014 22:19:59 +0000 (22:19 +0000)]
Revert 284508 "GN chrome/common build, rename enable_printing."

> GN chrome/common build, rename enable_printing.
>
> This adds the missing conditions to the chrome/common GN build file (previously
> only the basic files were there). Some refactoring of the GYP file to make this
> possible.
>
> Renames the enable_printing flag to printing_mode since this is an integer
> tri-state.
>
> Minor improvements to chrome/renderer
>
> R=jamesr@chromium.org
>
> Review URL: https://codereview.chromium.org/400243003

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/409543008

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284517 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoGN chrome/common build, rename enable_printing.
brettw@chromium.org [Mon, 21 Jul 2014 21:47:22 +0000 (21:47 +0000)]
GN chrome/common build, rename enable_printing.

This adds the missing conditions to the chrome/common GN build file (previously
only the basic files were there). Some refactoring of the GYP file to make this
possible.

Renames the enable_printing flag to printing_mode since this is an integer
tri-state.

Minor improvements to chrome/renderer

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/400243003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284508 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 days agoAttempt to re-enable webrtc tests which were flaky on Android bots.
xians@chromium.org [Mon, 21 Jul 2014 12:31:17 +0000 (12:31 +0000)]
Attempt to re-enable webrtc tests which were flaky on Android bots.

There had some CLs landed before to try fixing the flakiness of those webrtc tests on Android bot. But since the flakiness only happens on bots but not locally, so I enabled it again to see if those CLs help or not.

If any of the WebRTC tests still flake on bots, this CL should be reverted.

BUG=343604
TEST=bots

Review URL: https://codereview.chromium.org/408463002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284413 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 days agoPort r282246 to gn.
thakis@chromium.org [Sun, 20 Jul 2014 19:08:58 +0000 (19:08 +0000)]
Port r282246 to gn.

Temporarily disable -Werror on linux, since the gn build isn't yet
warning-free with clang. Since gn doesn't use -Werror for all targets yet
anyways (http://crbug.com/393046) that seems acceptable.

BUG=360311,393046
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/387693002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284372 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

8 days agoRevert of Copy the PGO runtime library to the release directory (https://codereview...
sebmarchand@chromium.org [Sun, 20 Jul 2014 13:53:15 +0000 (13:53 +0000)]
Revert of Copy the PGO runtime library to the release directory (https://codereview.chromium.org/402993002/)

Reason for revert:
pgort120.dll isn't present in the express version of VC.

Original issue's description:
> Copy the PGO runtime library to the release directory
>
> BUG=395183
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284261

TBR=scottmg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=395183

Review URL: https://codereview.chromium.org/401173002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284369 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoCopy the PGO runtime library to the release directory
sebmarchand@chromium.org [Sat, 19 Jul 2014 00:25:18 +0000 (00:25 +0000)]
Copy the PGO runtime library to the release directory

BUG=395183

Review URL: https://codereview.chromium.org/402993002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284261 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoRemove intsafe_workaround.h
thakis@chromium.org [Fri, 18 Jul 2014 23:56:37 +0000 (23:56 +0000)]
Remove intsafe_workaround.h

It's no longer needed.

BUG=308740
R=scottmg@chromium.org
TBR=cpu

Review URL: https://codereview.chromium.org/404443003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284256 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoRevert "Switch to BoringSSL."
agl@chromium.org [Fri, 18 Jul 2014 23:18:18 +0000 (23:18 +0000)]
Revert "Switch to BoringSSL."

This reverts commit r284079.

BUG=395271

Review URL: https://codereview.chromium.org/406693004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284248 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoRemove -fsanitize=null for ubsan_vptr=1 build.
byoungyoung@chromium.org [Fri, 18 Jul 2014 23:09:24 +0000 (23:09 +0000)]
Remove -fsanitize=null for ubsan_vptr=1 build.

As functional dependencies on -fsanitize=null are removed for -fsanitize=vptr
(Clang r213393), removing the -fsanitize=null option accordingly.

BUG=174801
R=aarya@google.com

Review URL: https://codereview.chromium.org/402983002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284245 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoMove adb_profile_chrome to profile_chrome.
alokp@chromium.org [Fri, 18 Jul 2014 21:36:55 +0000 (21:36 +0000)]
Move adb_profile_chrome to profile_chrome.

This is being done with the intention to port this tool to other
platforms. The first step is to move the existing code to a common
location.

Review URL: https://codereview.chromium.org/402803005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284207 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoReally disable clang's SLP vectorizer on Linux.
thakis@chromium.org [Fri, 18 Jul 2014 20:14:47 +0000 (20:14 +0000)]
Really disable clang's SLP vectorizer on Linux.

Follow-up to https://codereview.chromium.org/393193003/ .
-fno-slp-vectorize was passed before -O2 on linux, and -O2 would
reenable it. I checked that the order of -O3 and -fno-slp-vectorize
is correct as-is on Mac.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/408523002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284191 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoAdding a router class to handle messages that expect responses.
qsr@chromium.org [Fri, 18 Jul 2014 18:51:05 +0000 (18:51 +0000)]
Adding a router class to handle messages that expect responses.

This also introduce the notion of message header to allow routing.

R=rmcilroy@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283767

Review URL: https://codereview.chromium.org/371603003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284170 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoRoll ICU to icu52
jshin@chromium.org [Fri, 18 Jul 2014 18:47:57 +0000 (18:47 +0000)]
Roll ICU to icu52

The ICU update does the following among other things:
  - Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG
    encoding spec.
  - Add CP866
  - Add far better/more extensive support for plural, format, etc
  - Numerous locale data update
  - Khmer/Lao line/word-breaking support
  - More compact Chinese/Japanese dictionary (now a part of the upstream
    instead of our local patch)
  - Better plural support that we plan to use right away.

- Update icu/BUILD.gn : file list update, new defines, etc.
- Update tests
  a. icu_string_conversions_unittests : drop iscii (nobody uses it) and
     remove JIS X 212 code points from the round-trip test
  b. l10n_util_unittests: Display names for zh-*.
  c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change).
  d. Update Expected results in file_manager_browsertest/test_util.js
     (see http://crbug.com/383930)
- Update SpellcheckerWordIterator
  a. Add U+0027 back to MidNumLet
  b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based
     word-breaking.
- l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino)
- Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full
  has 'at' before time, which is not handled by Date.parse()
- update license.py because we don't have a separate Chinese/Japanese
  dictionary any more. It's now a part of ICU

Note to Sheriff :
1. 140 ~ 200 kB size increase is expected for all platforms.
This size increase was singed off by laforge@.
The expected size has to be updated with both reva/revb pointing to the
revision corresponding to this CL.

2.  http://codereview.chromium.org/348913002 has to be applied before running make_expectations.py to update tools/perf_expectations/perf_expectations.json
after this CL is landed.

BUG=132145,277023,136148,360433,364072
TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*,
     browser_tests (encoding related, Iden*verifyGet*),
     unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*,
     layout tests (encoding, date/calendar, line breaking, and others),
     build 'base_i18n_nacl', GN build bots.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277111

R=arv@chromium.org, brettw@chromium.org, fgorski@chromium.org, groby@chromium.org, hirono@chromium.org, tony@chromium.org, toyoshim@chromium.org

Review URL: https://codereview.chromium.org/265613002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284167 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoHook up symbol files to the Windows GN build.
brettw@chromium.org [Fri, 18 Jul 2014 17:24:30 +0000 (17:24 +0000)]
Hook up symbol files to the Windows GN build.

Previously the GN Windows build specified the symbol file $pdbfile but this variable was never defined, so the command like would just say "/Fd" and the default one would be used.

This patch defines some per-target variables in the ninja file for the toolchain to use. The Windows toolchain uses these to construct C- and C++-specific pdb files (the MS tools can't share between these two) for the current target.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/406453002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284137 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoRoll Breakpad from 1345 to 1351.
rmcilroy@chromium.org [Fri, 18 Jul 2014 17:14:37 +0000 (17:14 +0000)]
Roll Breakpad from 1345 to 1351.

This pulls in the following CLs:
 - r1346 Don't free pointer in BasicCodeModules::BasicCodeModules before possibly using it
 - r1347 Stringify minidump stream_type constants in minidump_dump output
 - r1348 Ensure C:/Dumps/ exists in crash_generation_app
 - r1349 Change some ELF utils to return the length as a size_t
 - r1350 Add frame pointer recovery to the AMD64 Stackwalker.
 - r1351 [Android]: Remove __system_property_get(ro.build.fingerprint) from
WriteOSInformation.

BUG=394841,393903

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284101

R=mark@chromium.org

Review URL: https://codereview.chromium.org/400203002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284134 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

9 days agoUpdate targetSdkVersion to 20.
aurimas@chromium.org [Fri, 18 Jul 2014 17:05:22 +0000 (17:05 +0000)]
Update targetSdkVersion to 20.

Applications targeting this or a later release will get these new changes
in behavior:
  - AlertDialog might not have a default background if the theme does not
    specify one.

BUG=393019
TBR=stgao@chromium.org,blundell@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/402613008

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284131 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoSwitch to BoringSSL.
agl@chromium.org [Fri, 18 Jul 2014 13:51:03 +0000 (13:51 +0000)]
Switch to BoringSSL.

(This is a reland of r283813 which was reverted in r283845 because it broke
WebRTC tests on Android. That, in turn, was a reland of of r283542 which was
reverted in r283591 because it broke the WebView build.)

This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.

BUG=none

Review URL: https://codereview.chromium.org/401613008

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284079 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoRevert of Adding a router class to handle messages that expect responses. (https...
johnme@chromium.org [Fri, 18 Jul 2014 11:25:15 +0000 (11:25 +0000)]
Revert of Adding a router class to handle messages that expect responses. (https://codereview.chromium.org/371603003/)

Reason for revert:
This appears to have broken mojotest_instrumentation_tests with the errors like the ones listed below.

http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/20270

C   52.086s Main  [FAIL] org.chromium.mojo.bindings.ConnectorTest#testErrors:
C   52.086s Main  java.lang.NoClassDefFoundError: java.util.Objects
C   52.086s Main   at org.chromium.mojo.bindings.MessageHeader.equals(MessageHeader.java:189)
C   52.086s Main   at org.chromium.mojo.bindings.MessageWithHeader.<init>(MessageWithHeader.java:29)
C   52.086s Main   at org.chromium.mojo.bindings.MessageWithHeader.<init>(MessageWithHeader.java:39)
C   52.086s Main   at org.chromium.mojo.bindings.BindingsTestUtils.newRandomMessageWithHeader(BindingsTestUtils.java:85)
C   52.086s Main   at org.chromium.mojo.bindings.ConnectorTest.setUp(ConnectorTest.java:53)
C   52.086s Main   at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C   52.086s Main   at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C   52.086s Main   at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C   52.086s Main   at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

C   52.091s Main  [CRASH] org.chromium.mojo.bindings.RouterTest#testReceivingViaRouterWithResponse:
C   52.091s Main  Native crash: Segmentation fault

Original issue's description:
> Adding a router class to handle messages that expect responses.
>
> This also introduce the notion of message header to allow routing.
>
> R=rmcilroy@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283767

TBR=qsr
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/392223004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284059 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoDrop unused v8 config var from chromium config
jochen@chromium.org [Fri, 18 Jul 2014 09:59:35 +0000 (09:59 +0000)]
Drop unused v8 config var from chromium config

The default platform no longer exists.

BUG=none
TBR=dcarney@chromium.org

Review URL: https://codereview.chromium.org/406503002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284046 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agowin: Add /d2Zi+ to compile flags
scottmg@chromium.org [Fri, 18 Jul 2014 09:30:33 +0000 (09:30 +0000)]
win: Add /d2Zi+ to compile flags

This makes debugging and stacks in Release builds much more accurate
(locals, arguments, information about inlining, etc.). The drawback is
somewhat larger .pdb files. Here's the sizes for the top 10 pdbs:

With /d2Zi+
-----------
07/17/2014  09:52 PM       280,408,064 content_unittests.exe.pdb
07/17/2014  09:47 PM       477,401,088 blink_web.dll.pdb
07/17/2014  09:50 PM       506,949,632 content.dll.pdb
07/17/2014  10:01 PM       955,576,320 sync_performance_tests.exe.pdb
07/17/2014  09:59 PM       955,912,192 performance_browser_tests.exe.pdb
07/17/2014  10:04 PM       965,382,144 sync_integration_tests.exe.pdb
07/17/2014  09:59 PM       987,688,960 chrome.dll.pdb
07/17/2014  10:03 PM     1,228,763,136 interactive_ui_tests.exe.pdb
07/17/2014  10:05 PM     1,398,632,448 browser_tests.exe.pdb
07/17/2014  10:07 PM     1,569,222,656 unit_tests.exe.pdb

Without
-------

07/17/2014  10:44 PM       238,104,576 content_unittests.exe.pdb
07/17/2014  10:39 PM       399,175,680 blink_web.dll.pdb
07/17/2014  10:44 PM       439,767,040 content.dll.pdb
07/17/2014  10:57 PM       837,832,704 sync_performance_tests.exe.pdb
07/17/2014  10:51 PM       838,119,424 performance_browser_tests.exe.pdb
07/17/2014  10:57 PM       846,286,848 sync_integration_tests.exe.pdb
07/17/2014  10:51 PM       864,194,560 chrome.dll.pdb
07/17/2014  10:58 PM     1,071,509,504 interactive_ui_tests.exe.pdb
07/17/2014  10:58 PM     1,219,203,072 browser_tests.exe.pdb
07/17/2014  10:58 PM     1,351,118,848 unit_tests.exe.pdb

So there is appreciable growth (~15%). The limit is currently 4G, so it
seems worth turning on for now, and if we must disable it later, we can.

R=wfh@chromium.org
BUG=350018,388264

Review URL: https://codereview.chromium.org/399843007

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284043 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoDisable clang's SLP vectorizer.
thakis@chromium.org [Fri, 18 Jul 2014 07:32:44 +0000 (07:32 +0000)]
Disable clang's SLP vectorizer.

It currently generates invalid code, see
http://llvm.org/bugs/show_bug.cgi?id=20354

BUG=none

Review URL: https://codereview.chromium.org/393193003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284029 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoRemove win_third_party_warn_as_error.
thakis@chromium.org [Fri, 18 Jul 2014 07:22:09 +0000 (07:22 +0000)]
Remove win_third_party_warn_as_error.

Its last client disappeared in https://codereview.chromium.org/373643002/

BUG=none

Review URL: https://codereview.chromium.org/395403002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284027 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoEnable x64 Chromoting host and installer
dcaiafa@chromium.org [Fri, 18 Jul 2014 05:32:11 +0000 (05:32 +0000)]
Enable x64 Chromoting host and installer

N.B. I had to move the sawbuck_provider in the .wxs out of the
installation directory. Even though it only contains registry changes,
candle will complain if it is not inside a directory, but the
application directory is platform specific, whereas sawbuck_provider is
always 32-bit.

BUG=394467

Review URL: https://codereview.chromium.org/398173002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@284007 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoAvoid macro redefinition in tools_sanity_unittest.cc
tzik@chromium.org [Fri, 18 Jul 2014 02:40:40 +0000 (02:40 +0000)]
Avoid macro redefinition in tools_sanity_unittest.cc

This causes build failure by macro redefinition on ASan-enabled build without -w flag.

BUG=162783

Review URL: https://codereview.chromium.org/389313002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283978 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoMake goma work for the GN build on linux.
dpranke@chromium.org [Fri, 18 Jul 2014 01:51:08 +0000 (01:51 +0000)]
Make goma work for the GN build on linux.

This drops the old gyp-compatible settings and wires up the
Linux and Android toolchains to be goma-aware. Mac and Win can
follow in subsequent CLs.

R=brettw@chromium.org, thakis@chromium.org
BUG=394501

Review URL: https://codereview.chromium.org/397173004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283971 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agolinux: Add tests for FontRenderParams on Linux.
derat@chromium.org [Fri, 18 Jul 2014 01:44:22 +0000 (01:44 +0000)]
linux: Add tests for FontRenderParams on Linux.

Add some tests for FontRenderParams's interactions with
Fontconfig, which is used on desktop Linux and Chrome OS.

Also re-add platform_font_pango_unittest.cc for gn.

BUG=125235

Review URL: https://codereview.chromium.org/394963002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283969 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days ago[Android]: Roll NDK to r10b-rc1.
rmcilroy@chromium.org [Thu, 17 Jul 2014 23:45:37 +0000 (23:45 +0000)]
[Android]: Roll NDK to r10b-rc1.

This roll updates the arm64 and x86_64 ABIS to include changes in NDK r10b-rc1.
This also removes android_tools/ndk_experimental and moves all 64 bit targets
over to using android_tools/ndk instead.

BUG=393903

Review URL: https://codereview.chromium.org/404553002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283926 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoMake provision_devices failures abort the build
eseidel@chromium.org [Thu, 17 Jul 2014 21:51:21 +0000 (21:51 +0000)]
Make provision_devices failures abort the build

Otherwise if the devices are gone lots of tests will just fail.

Already fixed this for recipe based builders in crbug.com/393681

I don't know how to test this, but happy to write one if shown.

BUG=393681
NOTRY=True

Review URL: https://codereview.chromium.org/390993003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283890 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoAdd env_chromium_unittests to the chromium_builder_dbg_tsan_win target.
cmumford@chromium.org [Thu, 17 Jul 2014 20:31:15 +0000 (20:31 +0000)]
Add env_chromium_unittests to the chromium_builder_dbg_tsan_win target.

This one change should have been part of an earlier CL (r274947).

BUG=326304

Review URL: https://codereview.chromium.org/393083003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283857 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoRevert 283813 "Switch to BoringSSL."
vitalybuka@chromium.org [Thu, 17 Jul 2014 20:07:06 +0000 (20:07 +0000)]
Revert 283813 "Switch to BoringSSL."
Failed WebRtcBrowserTest on android_dbg_triggered_tests.

> Switch to BoringSSL.
>
> (This is a reland of r283542 which was reverted in r283591 because it
> broke the WebView build. The android_aosp trybots are broken[1] so this
> based on hope.)
>
> This is a much larger change than its diff suggests. If it breaks
> something, please revert first and ask questions later.
>
> [1] http://code.google.com/p/chromium/issues/detail?id=394597
>
> BUG=none
>
> Review URL: https://codereview.chromium.org/399993002

TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/405503002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283845 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

10 days agoSwitch to BoringSSL.
agl@chromium.org [Thu, 17 Jul 2014 17:59:10 +0000 (17:59 +0000)]
Switch to BoringSSL.

(This is a reland of r283542 which was reverted in r283591 because it
broke the WebView build. The android_aosp trybots are broken[1] so this
based on hope.)

This is a much larger change than its diff suggests. If it breaks
something, please revert first and ask questions later.

[1] http://code.google.com/p/chromium/issues/detail?id=394597

BUG=none

Review URL: https://codereview.chromium.org/399993002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283813 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoAdding a router class to handle messages that expect responses.
qsr@chromium.org [Thu, 17 Jul 2014 13:32:30 +0000 (13:32 +0000)]
Adding a router class to handle messages that expect responses.

This also introduce the notion of message header to allow routing.

R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/371603003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283767 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days ago[Android] Switch to DeviceUtils versions of GetPid, TakeScreenshot, and GetIoStats.
jbudorick@chromium.org [Thu, 17 Jul 2014 09:54:06 +0000 (09:54 +0000)]
[Android] Switch to DeviceUtils versions of GetPid, TakeScreenshot, and GetIoStats.

BUG=267773

Review URL: https://codereview.chromium.org/386053002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283731 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoRestrict relocation packing to Release build.
simonb@chromium.org [Thu, 17 Jul 2014 09:05:10 +0000 (09:05 +0000)]
Restrict relocation packing to Release build.

Pass CONFIGURATION_NAME as an argument to pack_arm_relocations.py, and
turn on packing only if its value is 'Release'.  (CONFIGURATION_NAME
cannot be used in conditionals because it is not resolved until after
the conditional has been processed.)

Prior art:
  https://code.google.com/p/chromium/codesearch#chromium/src/build/android/gyp/apk_obfuscate.py&l=103
  https://code.google.com/p/chromium/codesearch#chromium/src/build/java_apk.gypi&l=742

BUG=385553

Review URL: https://codereview.chromium.org/396283002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283721 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoImprove Android Test Size Annotation support in test_runner.py
mckev@amazon.com [Thu, 17 Jul 2014 07:17:38 +0000 (07:17 +0000)]
Improve Android Test Size Annotation support in test_runner.py

- Add explicit support for EnormousTest
- Warn at runtime if a test size annotation isn't recognized
  (see: http://www.chromium.org/developers/testing/android-tests)
- Remove EnormousTest annotation from a test that wasn't actually using it
  (it was effectively using the SmallTest timeout value at runtime).
- Add SmallTest annotation to InstallerDelegateTest (it was the only
  set of tests that did not include these annotations).

TEST=ChromeShellTest instrumentation tests
BUG=392297

Review URL: https://codereview.chromium.org/376873008

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283684 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoFix sharded perf test host forwarder sharing
tonyg@chromium.org [Thu, 17 Jul 2014 07:16:50 +0000 (07:16 +0000)]
Fix sharded perf test host forwarder sharing

This code is subtle. Since killing the host forwarder is a global operation, it
keeps a temp file with the shared pid and process start time so that it knows
whether the forwarder is the correct one that should be shared or a stray one
that should be killed.

This failed because not all of the sharded perf test processes had the same
parent pid. This caused the sharded tests to stomp on the global forwarder.

We didn't notice this previously because we only had narrow sharding, and 3
retries so the flake was papered over. When we added 8-way sharding on
chromium.perf, the flake rose to the level where it appeared every run.

This patch fixes it by using the process group instead of using the parent
process ID as a proxy.

BUG=163503

Review URL: https://codereview.chromium.org/391383005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283683 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days ago[MIPS] Do not force clang for mipsel Linux
petarj@mips.com [Thu, 17 Jul 2014 04:42:26 +0000 (04:42 +0000)]
[MIPS] Do not force clang for mipsel Linux

Fix the MIPS Linux build that was broken by r282266 (and r282246).
Related r282266 review is at https://codereview.chromium.org/382743002

TEST= build Chrome Linux for target_arch=mipsel

Review URL: https://codereview.chromium.org/396243002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283645 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoRevert "Switch to BoringSSL."
agl@chromium.org [Thu, 17 Jul 2014 00:20:36 +0000 (00:20 +0000)]
Revert "Switch to BoringSSL."

This reverts commit 283542.

This broke the WebView Android build.

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283591 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoExpose the CLD data source in chrome://translate-internals
andrewhayden@chromium.org [Wed, 16 Jul 2014 22:33:10 +0000 (22:33 +0000)]
Expose the CLD data source in chrome://translate-internals

BUG=367239
TBR=toyoshim

Review URL: https://codereview.chromium.org/397623002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283550 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoSwitch to BoringSSL.
agl@chromium.org [Wed, 16 Jul 2014 22:15:31 +0000 (22:15 +0000)]
Switch to BoringSSL.

(This is a much larger change than its diff suggests. If it breaks something, please revert first and ask questions later.)

R=davidben@chromium.org, eroman@chromium.org, rsleevi@chromium.org

Review URL: https://codereview.chromium.org/345063006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283542 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoEnable warning on ASan-enabled build
tzik@chromium.org [Wed, 16 Jul 2014 22:02:30 +0000 (22:02 +0000)]
Enable warning on ASan-enabled build

Enables most of compiler warning on ASan build.

BUG=162783

Review URL: https://codereview.chromium.org/391743002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283535 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoRoll Android SDK to v20
aurimas@chromium.org [Wed, 16 Jul 2014 21:47:17 +0000 (21:47 +0000)]
Roll Android SDK to v20

BUG=393019
NOTRY=true

Review URL: https://codereview.chromium.org/394593002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283526 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoAdd display, message_center, shell_dialogs, webview to GN build.
brettw@chromium.org [Wed, 16 Jul 2014 21:33:36 +0000 (21:33 +0000)]
Add display, message_center, shell_dialogs, webview to GN build.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/393953008

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283516 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoChange FileArg syntax
cjhopman@chromium.org [Wed, 16 Jul 2014 20:24:45 +0000 (20:24 +0000)]
Change FileArg syntax

This changes the syntax from:
 @(filepath:key0:key1)
to:
 @FileArg(filepath:key0:key1)

This should make it much easier for someone who encounters this syntax
to figure out what it is (currently a `git grep FileArg` returns only
results about/using this feature).

Also changes it to use a simple regex search instead of adhoc stuff.

BUG=359249

Review URL: https://codereview.chromium.org/377803003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283484 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days ago[Android] Check for Java object types covariance in Java Bridge
mnaganov@chromium.org [Wed, 16 Jul 2014 18:54:43 +0000 (18:54 +0000)]
[Android] Check for Java object types covariance in Java Bridge

ART does check covariance of types passed via JNI anyway, causing the VM to
crash if they doesn't. We'd better check this in Java Bridge and throw a
JavaScript exception, as LiveConnect spec suggests.

BUG=392489

Review URL: https://codereview.chromium.org/393733002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283457 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoFix 'except' and 'prefer' spelling.
tnagel@chromium.org [Wed, 16 Jul 2014 17:53:20 +0000 (17:53 +0000)]
Fix 'except' and 'prefer' spelling.

TBR=marja, stevenjb, yosin
BUG=none

Review URL: https://codereview.chromium.org/382153006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283419 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoAdd search_engines and precache components to GN build.
brettw@chromium.org [Wed, 16 Jul 2014 17:50:51 +0000 (17:50 +0000)]
Add search_engines and precache components to GN build.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/393193002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283416 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoAdd ash to the GN build.
brettw@chromium.org [Wed, 16 Jul 2014 17:50:09 +0000 (17:50 +0000)]
Add ash to the GN build.

Minor fixes to ash.gyp: remove tabs, convert sources/ excludes to sources!.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/390983002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283415 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

12 days agoBug Fix: Video file name not updated properly.
satyanarayana@google.com [Wed, 16 Jul 2014 07:38:24 +0000 (07:38 +0000)]
Bug Fix: Video file name not updated properly.

BUG=

Review URL: https://codereview.chromium.org/396023002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@283386 4ff67af0-8c30-449e-8e8b-ad334ec8d88c