chromium/src/build.git
4 weeks agoRemove myself from some android owners files. master
yfriedman@chromium.org [Fri, 22 Aug 2014 01:24:47 +0000 (01:24 +0000)]
Remove myself from some android owners files.

Replace me with Jared for ui/ places.
I'm not familiar with what's going on in buildbot anymore.

NOTRY=true
TBR=sky

Review URL: https://codereview.chromium.org/477133005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@291295 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoDisable garbage collection for gyp_chromium.
joaodasilva@chromium.org [Fri, 22 Aug 2014 01:07:01 +0000 (01:07 +0000)]
Disable garbage collection for gyp_chromium.

Python always does reference counting and that handles most of the
objects used by GYP. The GC is used to detect and drop circular
references. If GC is turned off then the heap scanning can be skipped
to save some CPU cycles, and the memory leaked due to circular
references isn't noticeable.

This saves about 1 second out of 16 on Linux in a Z620 workstation.

BUG=None

Review URL: https://codereview.chromium.org/495993002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@291287 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoAdd linting for java libraries/apks to gn
cjhopman@chromium.org [Thu, 21 Aug 2014 23:27:22 +0000 (23:27 +0000)]
Add linting for java libraries/apks to gn

BUG=359249

Review URL: https://codereview.chromium.org/465713002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@291240 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks ago[Android] Fix provisioning for perf bots on L and/or user builds.
jbudorick@chromium.org [Thu, 21 Aug 2014 23:15:53 +0000 (23:15 +0000)]
[Android] Fix provisioning for perf bots on L and/or user builds.

BUG=405950

Review URL: https://codereview.chromium.org/495123002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@291231 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks ago[Android] Turn heap_profiler_unittests into an apk and reenable them.
primiano@chromium.org [Thu, 21 Aug 2014 21:35:37 +0000 (21:35 +0000)]
[Android] Turn heap_profiler_unittests into an apk and reenable them.

heap_profiler_unittests was previously a native executable target.
It turns out that we don't have the harness in place to run native
executable tests reliably on all Android versions due to the PIE
vs non-PIE issue (L vs ICS, see crbug.com/373219).
This caused a revert in crrev.com/416003005.
This change is making heap_profiler_unittests an apk target, following
the same pattern of the other tests we have in the codebase.
This change is also re-adding the tests to the the bot list.

BUG=393964

Review URL: https://codereview.chromium.org/465223005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@291197 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoFix empty resource IDs file in GN build.
brettw@chromium.org [Thu, 21 Aug 2014 20:38:44 +0000 (20:38 +0000)]
Fix empty resource IDs file in GN build.

Previously, if you specified an empty resource ID file in the grit template in the GN build, it would send "-f" with no argument to grit, and this would cause the command line parsing to get messed up and it wouldn't generate any files.

This patch just omits the "-f" argument in this case.

R=jam@chromium.org

Review URL: https://codereview.chromium.org/495183002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@291173 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoMove default sanitizer options into build/ so that WebRTC can import them.
glider@chromium.org [Thu, 21 Aug 2014 20:34:46 +0000 (20:34 +0000)]
Move default sanitizer options into build/ so that WebRTC can import them.

BUG=302040
TBR=noelallen@chromium.org

Review URL: https://codereview.chromium.org/357623003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@291168 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoGet lastchange.py to work correctly on Git repositories.
agable@chromium.org [Thu, 21 Aug 2014 20:27:40 +0000 (20:27 +0000)]
Get lastchange.py to work correctly on Git repositories.

This changes lastchange.py in two ways:
1) If the commit it finds is a Git hash, it outputs the whole hash, not just
   the first 7 characters.
2) It only looks at HEAD to see if there is a git-svn id. Previously, it used
   --grep=git-svn-id, which would find the most recent commit containing a
   git-svn id. This would be broken after the switch to git, as it would always
   find the last commit before the switch. Now, it only inspects the most recent
   commit, and falls through to pure-Git if that fails.

R=dilmah@chromium.org, stip@chromium.org
BUG=399113

Review URL: https://codereview.chromium.org/488733002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@291165 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks ago[Android] Parallelize provision_devices.py.
jbudorick@chromium.org [Thu, 21 Aug 2014 04:17:07 +0000 (04:17 +0000)]
[Android] Parallelize provision_devices.py.

BUG=401163

Review URL: https://codereview.chromium.org/434193002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290988 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoAdd native libraries to gn apks
cjhopman@chromium.org [Thu, 21 Aug 2014 00:42:57 +0000 (00:42 +0000)]
Add native libraries to gn apks

First, change the NativeLibraries template to use preprocessor defines
instead of includes. This allows us to delete all the corresponding
headers.

Then, change the ordered libraries file to be a dict with both the list
of library paths and the java-style list of library names.

Update a bunch of things that used the ordered libraries file to instead
take the list of libraries directly as an argument (as a FileArg in
every case).

Add calculating the list of libraries to write_build_config and add it
to the build config (gn can use this then instead of a separate ordered
libraries file).

Add a simple copy step in gn to set up the native libraries directory
for an apk. Use this directory when creating the apk.

BUG=359249
NOTRY=true

Review URL: https://codereview.chromium.org/456493002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290963 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoPull new GN, update toolchain definitions
brettw@chromium.org [Wed, 20 Aug 2014 19:39:43 +0000 (19:39 +0000)]
Pull new GN, update toolchain definitions

This pulls buildtools to get GN 290714 and updates to the new style of toolchain definitions in that revision.

Unfortunately, this new version doesn't support getting the outputs of excutables, which made the android unit test template a bit less automatic. We can consider how to best fix this in the future.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/485833003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290894 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoAdd libxkbcommon-dev to install-build-deps
spang@chromium.org [Wed, 20 Aug 2014 01:57:42 +0000 (01:57 +0000)]
Add libxkbcommon-dev to install-build-deps

We'll use this under ChromeOS ozone/freon builds for keyboard layout
support.

BUG=362698
TEST=ran install-build-deps.sh on trusty

Review URL: https://codereview.chromium.org/488833003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290727 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoFix install-build-deps-android for Trusty
erikcorry@chromium.org [Tue, 19 Aug 2014 20:10:06 +0000 (20:10 +0000)]
Fix install-build-deps-android for Trusty

BUG=

Review URL: https://codereview.chromium.org/463353004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290646 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoAdd git-svn dependency.
mmoss@chromium.org [Tue, 19 Aug 2014 18:31:00 +0000 (18:31 +0000)]
Add git-svn dependency.

This is needed by committers for repos that are still svn-based.

R=iannucci@chromium.org
BUG=366926

Review URL: https://codereview.chromium.org/489573002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290620 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks ago[Android] Fix KillHostHeartbeat for numerical user IDs.
jbudorick@chromium.org [Tue, 19 Aug 2014 18:17:26 +0000 (18:17 +0000)]
[Android] Fix KillHostHeartbeat for numerical user IDs.

BUG=405033

Review URL: https://codereview.chromium.org/490563002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290615 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoMove blink<->cc bindings to cc/blink
jamesr@chromium.org [Tue, 19 Aug 2014 02:47:18 +0000 (02:47 +0000)]
Move blink<->cc bindings to cc/blink

These files provide the implementations of the public Blink API that
bind to the cc implementation. This moves them out of content/ into a
subdirectory of cc/ so that we can reuse these files in mojo which
can depend on cc/ and on blink but not on content/. To make sure we
don't introduce dependencies from cc/ on blink proper, cc/DEPS forbids
including cc/blink/ and cc/blink/DEPS allows using the blink headers.
cc_blink is built as a separate component to avoid linking anything from
blink into targets that don't care about the blink bindings (such as
the browser compositor).

R=darin@chromium.org

Review URL: https://codereview.chromium.org/470983004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290464 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoDon't disable -Wabsolute-value when building for arm.
thakis@chromium.org [Mon, 18 Aug 2014 23:12:29 +0000 (23:12 +0000)]
Don't disable -Wabsolute-value when building for arm.

The things requiring this have been fixed.

BUG=395832
TBR=sbc@chromium.org

Review URL: https://codereview.chromium.org/483793002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290396 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoUse a qualified path for grit/net_resources.h
thakis@chromium.org [Mon, 18 Aug 2014 22:36:01 +0000 (22:36 +0000)]
Use a qualified path for grit/net_resources.h

BUG=401588
R=thestig@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/483703004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290382 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoMake udev target disappear on linux when use_udev==0
spang@chromium.org [Mon, 18 Aug 2014 22:14:13 +0000 (22:14 +0000)]
Make udev target disappear on linux when use_udev==0

So we don't break builds that don't use it by running pkg-config, and so
we don't accidently link against it when it is disabled.

The embedded=1 build has OS=="linux" use_udev==0 for small devices such
as the chromecast.

BUG=403162

Review URL: https://codereview.chromium.org/467983002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290377 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoDisable Clang's warnings about undefined pointer comparisons in Debug builds
hans@chromium.org [Mon, 18 Aug 2014 21:01:08 +0000 (21:01 +0000)]
Disable Clang's warnings about undefined pointer comparisons in Debug builds

The address of a reference, or the 'this' pointer, are always non-NULL
in well-defined C/C++ programs, and Clang warns about comparing them to NULL,
because the comparisons may be optimized away.

However, it can still be useful to do such comparisons in Debug builds.
For example, Skia does a lot of SkASSERT(&a), where a is a reference
parameter.

BUG=404271

Review URL: https://codereview.chromium.org/479293002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290361 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agolandmines: use CHROMIUM_OUT_DIR if set
scottmg@chromium.org [Mon, 18 Aug 2014 20:37:35 +0000 (20:37 +0000)]
landmines: use CHROMIUM_OUT_DIR if set

R=skyostil@chromium.org
BUG=404591

Review URL: https://codereview.chromium.org/464263005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290354 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks ago[Android] Fix the location prompt flake in provision_devices.
jbudorick@chromium.org [Mon, 18 Aug 2014 20:34:44 +0000 (20:34 +0000)]
[Android] Fix the location prompt flake in provision_devices.

BUG=401163

Review URL: https://codereview.chromium.org/481433004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290353 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoDon't pass -target arm-linux-gnueabihf on android.
thakis@chromium.org [Mon, 18 Aug 2014 18:21:18 +0000 (18:21 +0000)]
Don't pass -target arm-linux-gnueabihf on android.

Fixes a regression from r395832. (This isn't a visible change as the android
build happens to pass -target arm-linux-androideabi later on the compile line,
but relying on this is risky.)

BUG=395832
TBR=sbc@chromium.org

Review URL: https://codereview.chromium.org/485783002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290308 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks ago[Android] Make adb shell commands with single quotes run correctly.
jbudorick@chromium.org [Mon, 18 Aug 2014 18:05:42 +0000 (18:05 +0000)]
[Android] Make adb shell commands with single quotes run correctly.

BUG=401163

Review URL: https://codereview.chromium.org/477153003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290299 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoEnable ARM/linux cross compile to use clang.
sbc@chromium.org [Mon, 18 Aug 2014 15:41:07 +0000 (15:41 +0000)]
Enable ARM/linux cross compile to use clang.

BUG=395832
NOTRY=true

Review URL: https://codereview.chromium.org/408393002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290261 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoclang/win: Disable -Wexit-time-destructors for now, 2nd try.
thakis@chromium.org [Mon, 18 Aug 2014 14:13:33 +0000 (14:13 +0000)]
clang/win: Disable -Wexit-time-destructors for now, 2nd try.

BUG=404525
TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/482733002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290252 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRemove lib32 code from install-build-deps.sh
phajdan.jr@chromium.org [Mon, 18 Aug 2014 12:30:23 +0000 (12:30 +0000)]
Remove lib32 code from install-build-deps.sh

Please see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/_bkkbzJTLWw/SrLN3_XgEJQJ
for more info.

BUG=none
R=mmoss@chromium.org

Review URL: https://codereview.chromium.org/472863002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290235 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoclang/win: Disable -Wexit-time-destructors for now.
thakis@chromium.org [Mon, 18 Aug 2014 04:38:15 +0000 (04:38 +0000)]
clang/win: Disable -Wexit-time-destructors for now.

I'm not 100% sure this will be evaluated at the right time to have an effect.

BUG=404525
TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/481823002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290208 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRemove ui/ directory from build/secondary.
tfarina@chromium.org [Sun, 17 Aug 2014 17:28:02 +0000 (17:28 +0000)]
Remove ui/ directory from build/secondary.

This directory contains a GN build file that defines a dummy "ui"
component target that does not really do anything that matters.

ui/ targets are almost finished at this time, so there is no point in
keeping this ui/ BUILD file in build/secondary.

BUG=None
TEST=None
R=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/451553002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290188 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks ago[Android] Print timestamp + threadid with provision_devices output.
jbudorick@chromium.org [Sat, 16 Aug 2014 08:21:34 +0000 (08:21 +0000)]
[Android] Print timestamp + threadid with provision_devices output.

BUG=401266

Review URL: https://codereview.chromium.org/473293002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290132 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks ago[Android] Fix misc minor provisioning issues.
jbudorick@chromium.org [Fri, 15 Aug 2014 21:45:40 +0000 (21:45 +0000)]
[Android] Fix misc minor provisioning issues.

BUG=401163

Review URL: https://codereview.chromium.org/477953002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@290020 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoChanged the test package for chrome_document tests
mikecase@chromium.org [Fri, 15 Aug 2014 18:56:52 +0000 (18:56 +0000)]
Changed the test package for chrome_document tests

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/481513002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289960 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRefactor lazy JNI registration support.
torne@chromium.org [Fri, 15 Aug 2014 18:19:03 +0000 (18:19 +0000)]
Refactor lazy JNI registration support.

Rename the "linker_script_copy" target to "android_exports" and move the
link_settings clause to that target. This avoids the linker flag being
duplicated once for every target which includes jni_generator.gypi,
which causes problems on some linker versions.

BUG=402003

Review URL: https://codereview.chromium.org/473173004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289941 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoChromecast: MP2TS stream parser should always be enabled.
gunsch@chromium.org [Fri, 15 Aug 2014 04:28:01 +0000 (04:28 +0000)]
Chromecast: MP2TS stream parser should always be enabled.

R=lcwu@chromium.org,damienv@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/471973004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289779 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRevert 289650 "Roll buildtools, this updates VS2013 Pro to Update 3"
scottmg@chromium.org [Fri, 15 Aug 2014 00:07:27 +0000 (00:07 +0000)]
Revert 289650 "Roll buildtools, this updates VS2013 Pro to Update 3"

gfx_unittests fails on x64_rel.

Unclear why tryjob was successful, perhaps different hardware between tryjob and waterfall.

> Roll buildtools, this updates VS2013 Pro to Update 3
>
> TBR=iannucci@chromium.org
> NOTRY=true
> BUG=402543
>
> Review URL: https://codereview.chromium.org/458353003

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/477013002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289729 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoAdded Hera package info in order to run uiautomator tests with hera
mikecase@chromium.org [Thu, 14 Aug 2014 23:50:06 +0000 (23:50 +0000)]
Added Hera package info in order to run uiautomator tests with hera

BUG=

Review URL: https://codereview.chromium.org/453773002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289725 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoReland: Update iOS deployment target to 7.0
stuartmorgan@chromium.org [Thu, 14 Aug 2014 21:22:31 +0000 (21:22 +0000)]
Reland: Update iOS deployment target to 7.0

iOS 6 will no longer be supported.

Replaces deprecated sizeWithFont: with sizeWithAttributes: (adding a
ceilf since according to the internet, the former rounds up, and the
latter does not) to fix compilation.

Special-cases the nil font case, since sizeWithFont:nil would work
and return zero, but it's impossible to construct an attribute
dictionary with a nil font.

BUG=402921

Review URL: https://codereview.chromium.org/470923005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289702 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoAdds chromecast/tools/build to gyp_chromium paths for pymod_do_main.
gunsch@chromium.org [Thu, 14 Aug 2014 21:15:40 +0000 (21:15 +0000)]
Adds chromecast/tools/build to gyp_chromium paths for pymod_do_main.

This allows for Chromecast's locale repack script (based off the
implementation in chrome/) to specificy Chromecast-specific files.

R=lcwu@chromium.org
BUG=403104

Review URL: https://codereview.chromium.org/466133003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289699 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoAllow the grit GN targets to specify an output name.
brettw@chromium.org [Thu, 14 Aug 2014 20:32:17 +0000 (20:32 +0000)]
Allow the grit GN targets to specify an output name.

This resolves collisions if two grit targets with the same name (often
"resources") end up in the same output directory.

This reverts 289283 and replaces it with the unique output names rather than
the duplicative target names. The original problem was from 289264.

BUG=
R=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/469893002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289691 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRoll buildtools, this updates VS2013 Pro to Update 3
scottmg@chromium.org [Thu, 14 Aug 2014 18:48:18 +0000 (18:48 +0000)]
Roll buildtools, this updates VS2013 Pro to Update 3

TBR=iannucci@chromium.org
NOTRY=true
BUG=402543

Review URL: https://codereview.chromium.org/458353003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289650 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoAdding atomic ops for MIPS64.
Gordana.Cmiljanovic@imgtec.com [Thu, 14 Aug 2014 17:14:05 +0000 (17:14 +0000)]
Adding atomic ops for MIPS64.

This change adds atomic operations for MIPS64.

BUG=400684

Review URL: https://codereview.chromium.org/450343002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289624 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoCreate NaCl build of gtest.
ncbray@chromium.org [Thu, 14 Aug 2014 14:22:42 +0000 (14:22 +0000)]
Create NaCl build of gtest.

Originally landed as 289216 and reverted as 289223 due to a GYP bug.

BUG=401761

Review URL: https://codereview.chromium.org/401453002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289558 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoMake landmines work on local builds too
scottmg@chromium.org [Thu, 14 Aug 2014 14:03:30 +0000 (14:03 +0000)]
Make landmines work on local builds too

Moves (some of) gyp environment setup out of gyp_chromium into separate
module, and shares that between gyp_chromium and landmines.py.

landmines.py is added as the first entry in DEPS hooks so that it can
clobber the entire build directory before running other hooks that
extract/generate into the build dir.

Reland with fix for ios, and for clean pull.

R=iannucci@chromium.org
BUG=400011

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099

Review URL: https://codereview.chromium.org/457003004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289546 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoDo not use device if it had to be turned off because of critical battery level.
navabi@google.com [Thu, 14 Aug 2014 10:24:06 +0000 (10:24 +0000)]
Do not use device if it had to be turned off because of critical battery level.

BUG=401098
TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/473683003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289512 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRevert 289403 "Update iOS deployment target to 7.0"
bartfab@chromium.org [Thu, 14 Aug 2014 10:10:17 +0000 (10:10 +0000)]
Revert 289403 "Update iOS deployment target to 7.0"

This appears to have broken gfx_unittests on iOS:

http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/17689

> Update iOS deployment target to 7.0
>
> iOS 6 will no longer be supported.
>
> Replaces deprecated sizeWithFont: with sizeWithAttributes: (adding a
> ceilf since according to the internet, the former rounds up, and the
> latter does not) to fix compilation.
>
> BUG=402921
>
> Review URL: https://codereview.chromium.org/463333002

TBR=stuartmorgan@chromium.org

Review URL: https://codereview.chromium.org/473883002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289510 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoUpdate iOS deployment target to 7.0
stuartmorgan@chromium.org [Wed, 13 Aug 2014 22:50:20 +0000 (22:50 +0000)]
Update iOS deployment target to 7.0

iOS 6 will no longer be supported.

Replaces deprecated sizeWithFont: with sizeWithAttributes: (adding a
ceilf since according to the internet, the former rounds up, and the
latter does not) to fix compilation.

BUG=402921

Review URL: https://codereview.chromium.org/463333002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289403 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoProvide a maximum size on the number of tests to run in one group.
anton@chromium.org [Wed, 13 Aug 2014 21:46:34 +0000 (21:46 +0000)]
Provide a maximum size on the number of tests to run in one group.

The implementation of thread local storage on Android does not free slots
in a fixed size datastructure with 256 slots. When a large number of tests
run in a single process it is easy to exceed the limit. We don't have
control over how many slots are burnt per test, so we just assume that
one slot is burnt per test. We split the tests so only 256 run in a given
process.

BUG=354405

Review URL: https://codereview.chromium.org/453953003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289386 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks ago+jbudorick, -craigdh for build/android/pylib/OWNERS.
jbudorick@chromium.org [Wed, 13 Aug 2014 16:27:13 +0000 (16:27 +0000)]
+jbudorick, -craigdh for build/android/pylib/OWNERS.

BUG=

Review URL: https://codereview.chromium.org/451083004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289313 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRevert of Run pkg-config for Udev only if use_udev==1 (patchset #1 of https://coderev...
dnicoara@chromium.org [Wed, 13 Aug 2014 13:50:18 +0000 (13:50 +0000)]
Revert of Run pkg-config for Udev only if use_udev==1 (patchset #1 of https://codereview.chromium.org/429723002/)

Reason for revert:
Breaks builds where use_udev==0 since certain targets just assume udev and never check against use_udev.

Udev package should be wrapped in a use_udev confitional altogether and all the locations using Udev should check against use_udev.

Original issue's description:
> Run pkg-config for Udev only if use_udev==1
>
> Some embedded platforms do not have udev support. The change will skip
> running pkg-config if use_udev=0.
>
> BUG=none
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288770

TBR=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/469763002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289280 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agomake it possible to disable the use of libpci on linux again
mostynb@opera.com [Wed, 13 Aug 2014 10:35:40 +0000 (10:35 +0000)]
make it possible to disable the use of libpci on linux again

When CL 430573002 landed, it forced the use of libpci on linux, but
many embedded systems lack this library (and probably lack a pci bus
altogether). Let's add a new config variable to make it possible to
disable the use of libpci.

BUG=398416

Review URL: https://codereview.chromium.org/462433002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289262 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRun android tests through runtest.py.
zty@chromium.org [Wed, 13 Aug 2014 09:36:34 +0000 (09:36 +0000)]
Run android tests through runtest.py.

This CL re-lands https://codereview.chromium.org/414383002. It fixed a bug
where debug testers failed to find binaries. TryServer failed to catch this
bug due to the fact that rel and dbg testers are sharing the same checkout on
bots. https://codereview.chromium.org/452263002/ was submitted to make sure any
tester that downloads and extracts archive will clean it up.

BUG=329102
R=yfriedman@chromium.org, navabi@chromium.org, jbudorick@chromium.org

Review URL: https://codereview.chromium.org/465723002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289231 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRevert 289216 "Create NaCl build of gtest."
joaodasilva@chromium.org [Wed, 13 Aug 2014 09:06:37 +0000 (09:06 +0000)]
Revert 289216 "Create NaCl build of gtest."

> Create NaCl build of gtest.
>
> BUG=401761
>
> Review URL: https://codereview.chromium.org/401453002

TBR=ncbray@chromium.org

Review URL: https://codereview.chromium.org/466303002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289223 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoCreate NaCl build of gtest.
ncbray@chromium.org [Wed, 13 Aug 2014 08:50:41 +0000 (08:50 +0000)]
Create NaCl build of gtest.

BUG=401761

Review URL: https://codereview.chromium.org/401453002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289216 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRevert of Make landmines work on local builds too (patchset #3 of https://codereview...
iannucci@chromium.org [Wed, 13 Aug 2014 02:07:35 +0000 (02:07 +0000)]
Revert of Make landmines work on local builds too (patchset #3 of https://codereview.chromium.org/457003004/)

Reason for revert:
Apparently this requires win_toolchain.json to exist, but I'm not sure how it's supposed to get there (as seen on a clobber build):

Traceback (most recent call last):
  File "src/build/landmines.py", line 132, in <module>
    sys.exit(main())
  File "src/build/landmines.py", line 119, in main
    gyp_environment.SetEnvironment()
  File "C:\b\build\slave\win_trunk\build\src\build\gyp_environment.py", line 33, in SetEnvironment
    vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
  File "C:\b\build\slave\win_trunk\build\src\build\vs_toolchain.py", line 33, in SetEnvironmentAndGetRuntimeDllDirs
    with open(json_data_file, 'r') as tempf:
IOError: [Errno 2] No such file or directory: 'C:\\b\\build\\slave\\win_trunk\\build\\src\\build\\win_toolchain.json'

Original issue's description:
> Make landmines work on local builds too
>
> Moves (some of) gyp environment setup out of gyp_chromium into separate
> module, and shares that between gyp_chromium and landmines.py.
>
> landmines.py is added as the first entry in DEPS hooks so that it can
> clobber the entire build directory before running other hooks that
> extract/generate into the build dir.
>
> R=iannucci@chromium.org
> BUG=400011
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289099

TBR=scottmg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400011

Review URL: https://codereview.chromium.org/469623002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289158 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoAdd and start using Checkstyle 5.7
aurimas@google.com [Tue, 12 Aug 2014 23:40:57 +0000 (23:40 +0000)]
Add and start using Checkstyle 5.7

Start including Checkstyle 5.7 binary to use for Java style presubmit
checks.

BUG=318404
NOTRY=true
R=brettw@chromium.org, yfriedman@chromium.org

Review URL: https://codereview.chromium.org/451313002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289117 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRequire more precise exclusions in remove_bundled_libraries.py
phajdan.jr@chromium.org [Tue, 12 Aug 2014 23:01:11 +0000 (23:01 +0000)]
Require more precise exclusions in remove_bundled_libraries.py

This handles nested third_party directories.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/462063002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289106 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoMake landmines work on local builds too
scottmg@chromium.org [Tue, 12 Aug 2014 22:52:11 +0000 (22:52 +0000)]
Make landmines work on local builds too

Moves (some of) gyp environment setup out of gyp_chromium into separate
module, and shares that between gyp_chromium and landmines.py.

landmines.py is added as the first entry in DEPS hooks so that it can
clobber the entire build directory before running other hooks that
extract/generate into the build dir.

R=iannucci@chromium.org
BUG=400011

Review URL: https://codereview.chromium.org/457003004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289099 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoTest Runner changes for @IntegrationTest.
yojan@google.com [Tue, 12 Aug 2014 22:51:19 +0000 (22:51 +0000)]
Test Runner changes for @IntegrationTest.

Changes made to treat @IntegrationTest annotation as a test size annotation
with a timeout greater than @EnormousTest. Changes to test runner also made
to allow new line escapes for the .flags file.

BUG=None

Review URL: https://codereview.chromium.org/462613005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289098 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRandom analyzer cleanup
sky@chromium.org [Tue, 12 Aug 2014 22:43:45 +0000 (22:43 +0000)]
Random analyzer cleanup

Analyze exceptions have been centralized, so I can remove the
exceptions from each of the trybot files.
--analyzer2 is no longer used by the recipes.

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/463193002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289094 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoClean up out/<target> directory in the end if extract_build.
zty@chromium.org [Tue, 12 Aug 2014 19:05:22 +0000 (19:05 +0000)]
Clean up out/<target> directory in the end if extract_build.

Many slaves are shared between rel/dbg builders with the same build directory names. This makes sure we are testing what we intend to test.
BUG=401781
R=navabi@chromium.org, luqui@chromium.org

Review URL: https://codereview.chromium.org/452263002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289042 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoGN: Make content_shell and webkit_unit_tests work in component build
jamesr@chromium.org [Tue, 12 Aug 2014 17:07:12 +0000 (17:07 +0000)]
GN: Make content_shell and webkit_unit_tests work in component build

Except for webrtc, this produces content_shell and webkit_unit_tests
binaries that link and run successfully on linux.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/462983002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@289007 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoGN: Only define UNIT_TEST in direct gtest deps
jamesr@chromium.org [Tue, 12 Aug 2014 15:45:19 +0000 (15:45 +0000)]
GN: Only define UNIT_TEST in direct gtest deps

This matches the gyp build and is important for parts of the code that
guard their API with UNIT_TEST. For instance,
chrome/browser/ui/views/omnibox/omnibox_view_views.h has a GetRenderText
function guarded by #if UNIT_TEST that shadows a protected function
GetRenderText from its parent class views::Textfield, but with different
const-ness. If c/b/u/v/o/omnibox_view_views.cc is compiled with UNIT_TEST
set, it attempts to use the guarded member function instead of the base
class which fails to compile.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/464503003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288988 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoUpdate lint and findbugs to use jars instead of class files
cjhopman@chromium.org [Tue, 12 Aug 2014 15:10:38 +0000 (15:10 +0000)]
Update lint and findbugs to use jars instead of class files

Now that this is done, we don't need to leave the class files laying
around anymore. So don't.

Review URL: https://codereview.chromium.org/458653002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288971 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoWhitespace change to kick off bots.
phajdan.jr@chromium.org [Tue, 12 Aug 2014 11:04:25 +0000 (11:04 +0000)]
Whitespace change to kick off bots.

BUG=none

Review URL: https://codereview.chromium.org/464873002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288929 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoPut GPU isolate targets under archive_gpu_tests=1 GYP variable.
kbr@chromium.org [Mon, 11 Aug 2014 20:36:04 +0000 (20:36 +0000)]
Put GPU isolate targets under archive_gpu_tests=1 GYP variable.

This avoids the majority of the Chromium builders attempting to build
these isolates.

BUG=401985
NOTRY=true

Review URL: https://codereview.chromium.org/457813002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288789 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRun pkg-config for Udev only if use_udev==1
dnicoara@chromium.org [Mon, 11 Aug 2014 19:49:30 +0000 (19:49 +0000)]
Run pkg-config for Udev only if use_udev==1

Some embedded platforms do not have udev support. The change will skip
running pkg-config if use_udev=0.

BUG=none

Review URL: https://codereview.chromium.org/429723002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288770 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoPort r288424 to gn.
thakis@chromium.org [Mon, 11 Aug 2014 18:01:21 +0000 (18:01 +0000)]
Port r288424 to gn.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/457193002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288746 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRemove unused gn tool script.
thakis@chromium.org [Mon, 11 Aug 2014 16:44:40 +0000 (16:44 +0000)]
Remove unused gn tool script.

No intended behavior change.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/461463002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288728 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoMove WebViewShell from Android to Chromium
hjd@chromium.org [Mon, 11 Aug 2014 13:41:23 +0000 (13:41 +0000)]
Move WebViewShell from Android to Chromium

This lets us build the WebViewShell via ninja using the
target android_webview_telemetry_shell_apk.

the licence information was updated to use the Chromium
licence and the package was changed to: org.chromium.telemetry_shell

This meant updating:
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py
to use the new package name.

BUG=

Review URL: https://codereview.chromium.org/443953002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288698 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoDon't register JNI methods for the android_webview.
mkosiba@chromium.org [Mon, 11 Aug 2014 11:27:12 +0000 (11:27 +0000)]
Don't register JNI methods for the android_webview.

Rather than registering all jni bindings at startup, only get references
to the class object for those files which require bindings. All others
are satisfied by exporting symbols which can be found automatically by
the VM.

BUG=402003

Review URL: https://codereview.chromium.org/454923002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288685 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agounbundle: do not remove .isolate files, that results in gyp errors
phajdan.jr@chromium.org [Mon, 11 Aug 2014 09:56:26 +0000 (09:56 +0000)]
unbundle: do not remove .isolate files, that results in gyp errors

BUG=none
R=maruel@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/454013002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288682 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoForce the build with a whitespace change.
tfarina@chromium.org [Sat, 9 Aug 2014 20:04:39 +0000 (20:04 +0000)]
Force the build with a whitespace change.

To see it clears the errors from r288589 and r288588.

BUG=None
TEST=None
TBR=ckocagil@chromium.org

Review URL: https://codereview.chromium.org/457123002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288592 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRoll gtest and gmock DEPS.
ncbray@chromium.org [Sat, 9 Aug 2014 05:24:02 +0000 (05:24 +0000)]
Roll gtest and gmock DEPS.

These DEPS have not been updated for ~2 years, so there is a good chance
something will blow up. Due to interdependancy between the repos,
rolling gtest required gmock also be rolled.

This CL was originally landed as 288164 and reverted as 288239 because it allows
more aggressive LTO in MSVS. This resulted in the compiler noticing an
intentional arithmetic overflow and warning about it.

BUG=401761

Review URL: https://codereview.chromium.org/425333002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288505 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoUse toolchain hash that's in buildtools
scottmg@chromium.org [Sat, 9 Aug 2014 00:27:26 +0000 (00:27 +0000)]
Use toolchain hash that's in buildtools

Hash copied at https://codereview.chromium.org/449673003/.

R=iannucci@chromium.org
BUG=400830

Review URL: https://codereview.chromium.org/447183005

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288477 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoImplement HiDPI and pinch-zoom scaling of filter params
garykac@chromium.org [Fri, 8 Aug 2014 21:25:32 +0000 (21:25 +0000)]
Implement HiDPI and pinch-zoom scaling of filter params

This change implements HiDPI scaling of filter params in CC. It also fixes content scaling of filter params (e.g.,
with -webkit-transform: scale(X)) as well as pinch-zoom scaling.

This code is mostly from http://crrev.com/191123002
   "Implement hidpi and pinch-zoom scaling of filter params in cc"
and replaces http://crrev.com/317663005
   "Scale the ALPHA_THRESHOLD filter's region based on the device scale factor"
because this fixes all filters rather than just the AlphaThresholdFilter.

BUG=376532, 281516, 281518, 349493
R=brettw@chromium.org, danakj@chromium.org, enne@chromium.org, jschuh@chromium.org

Review URL: https://codereview.chromium.org/394193003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288436 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoclang supports -fuse-ld these days, remove a few special cases.
thakis@chromium.org [Fri, 8 Aug 2014 20:53:34 +0000 (20:53 +0000)]
clang supports -fuse-ld these days, remove a few special cases.

This is shorter, and it allows us to remove two trampoline files on Android
(which still weren't updated to trampoline to the 4.8 toolchain and still
referred to the 4.6 toolchain instead).

No intended visible behavior change.

BUG=none

Review URL: https://codereview.chromium.org/450843002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288424 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoMakes --analyzer behave same as --analyzer2
sky@chromium.org [Fri, 8 Aug 2014 14:43:40 +0000 (14:43 +0000)]
Makes --analyzer behave same as --analyzer2

Then I can convert recipes back to --analyzer and finally remove
--analyzer2. Oy!

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/447183006

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288360 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoWhitespace change to trigger bots.
machenbach@chromium.org [Fri, 8 Aug 2014 13:24:17 +0000 (13:24 +0000)]
Whitespace change to trigger bots.

TBR=phajdan.jr@chromium.org
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/454893002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288339 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoBoringSSL: switch around GYP files again.
agl@chromium.org [Fri, 8 Aug 2014 08:14:58 +0000 (08:14 +0000)]
BoringSSL: switch around GYP files again.

Any leak of boringssl.gyp (which included unittests) ends up pulling in base/
and breaks the WebRTC build.

However, switching targets to boringssl_lib.gypi:boringssl breaks GYP because
then there are two targets with the same name (boringssl.gyp:boringssl and
boringssl_lib.gypi:boringssl).

This change gives up and splits the unittests into a different .gyp file.

BUG=none

Review URL: https://codereview.chromium.org/447213004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288251 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRevert 288164 "Roll gtest and gmock DEPS."
tommi@chromium.org [Fri, 8 Aug 2014 07:57:23 +0000 (07:57 +0000)]
Revert 288164 "Roll gtest and gmock DEPS."
Suspected to have broken the Chrome Win build:

c:\b\build\slave\google-chrome-rel-win\build\src\base\numerics\safe_numerics_unittest.cc(577) : error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\google-chrome-rel-win\build\src\base\numerics\safe_numerics_unittest.cc(577) : warning C4756: overflow in constant arithmetic

> Roll gtest and gmock DEPS.
>
> These DEPS have not been updated for ~2 years, so there is a good chance
> something will blow up. Due to interdependancy between the repos,
> rolling gtest required gmock also be rolled.
>
> BUG=none
>
> Review URL: https://codereview.chromium.org/425333002

TBR=ncbray@chromium.org

Review URL: https://codereview.chromium.org/454823002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288239 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoWhitespace change to verify dcommit is happy again
iannucci@chromium.org [Fri, 8 Aug 2014 07:35:45 +0000 (07:35 +0000)]
Whitespace change to verify dcommit is happy again

TBR=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/450053004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288237 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoYet another whitespace change for Cr-Commit-Position
vadimsh@chromium.org [Fri, 8 Aug 2014 02:43:06 +0000 (02:43 +0000)]
Yet another whitespace change for Cr-Commit-Position

Through CQ this time.

R=iannucci@chromium.org
BUG=366924
NOTRY=true
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/452703002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288207 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoAnother whitespace change for Cr-Commit-Position
iannucci@chromium.org [Fri, 8 Aug 2014 02:22:45 +0000 (02:22 +0000)]
Another whitespace change for Cr-Commit-Position

R=vadimsh@chromium.org
BUG=366924

Review URL: https://codereview.chromium.org/453753002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288204 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoTest Runner changes for Integration tests.
yojan@google.com [Fri, 8 Aug 2014 01:45:59 +0000 (01:45 +0000)]
Test Runner changes for Integration tests.

Test Runner changes to allow integration tests as well as the ability
to point the device's google_base_url (or any android shell flag) to
a specified value in stored in a .flags file.

BUG=None

Review URL: https://codereview.chromium.org/444243002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288202 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoWhitespace change for Cr-Commit-Position
iannucci@chromium.org [Fri, 8 Aug 2014 01:23:04 +0000 (01:23 +0000)]
Whitespace change for Cr-Commit-Position

R=vadimsh@chromium.org
BUG=366924

Review URL: https://codereview.chromium.org/453743002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288192 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRevert of Run android tests through runtest.py. (https://codereview.chromium.org...
abodenha@chromium.org [Fri, 8 Aug 2014 01:11:47 +0000 (01:11 +0000)]
Revert of Run android tests through runtest.py. (https://codereview.chromium.org/414383002/)

Reason for revert:
Looks like the cause of http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/22085 failing.

runtest.py was repeatedly unable to find the test targets it was supposed to run.

partial log:
@@@BUILD_STEP base_unittests@@@
> /b/build/scripts/slave/runtest.py '--factory-properties={"generate_gtest_json": true, "target": "Debug", "gclient_env": {}, "build_url": "http://build1-a1/b/build/slave/Android_Builder__dbg_/chrome_staging/full-build-linux.zip", "clobber": false, "GYP_DEFINES": " component=shared_library", "target_os": "android", "android_bot_id": "main-tests-dbg"}' '--build-properties={"parentname": "Android Builder (dbg)", "got_nacl_revision": "13580", "parent_wk_revision": "179716", "parent_got_v8_revision": "22960", "parent_got_swarming_client_revision": "bbf1fcca7932d92cca9d7dab46ea271a7f6d61fb", "got_revision": "288139", "parent_revision": "288139", "blamelist_real": ["achaulk@chromium.org", "jamescook@chromium.org", "mef@chromium.org", "morrita@chromium.org", "varkha@chromium.org", "zty@chromium.org (:zty)"], "got_webkit_revision_git": "08c40136a44dd5b3f5bf976d5c75e7623afb8e29", "parent_slavename": "build1-a1", "got_v8_revision_git": "9d72b8dd94263d9f500f18255d67f0c7b8c3527a", "got_webrtc_revision_git": "a288b8cbb568cbf1735e6d5d0012524f4f8e5f74", "buildnumber": 22085, "got_webkit_revision": "179716", "parent_scheduler": "android", "got_swarming_client_revision": "bbf1fcca7932d92cca9d7dab46ea271a7f6d61fb", "parent_buildnumber": "63404", "slavename": "build42-a1", "blamelist": "achaulk@chromium.org,jamescook@chromium.org,mef@chromium.org,morrita@chromium.org,varkha@chromium.org,zty@chromium.org", "branch": "src", "patchset": "", "issue": "", "revision": "288139", "workdir": "/b/build/slave/Android_Tests__dbg_", "repository": "svn://svn-mirror.golo.chromium.org/chrome/trunk", "buildername": "Android Tests (dbg)", "parent_try_job_key": "", "got_webrtc_revision": "6825", "mastername": "chromium.linux", "parent_got_webkit_revision": "179716", "parent_builddir": "", "parent_branch": "src", "got_nacl_revision_git": "1fb9738130a80c961cf1ed46cdb38caf0d165543", "scheduler": "android_trigger_dbg", "requester": "", "buildbotURL": "http://build.chromium.org/p/chromium.linux/", "parent_cr_revision": "288139", "got_revision_git": "3afe85add41986693e47da5e33a01a2989c96354", "rietveld": "", "parent_got_nacl_revision": "13580", "parent_buildername": "Android Builder (dbg)", "got_v8_revision": "22960", "parent_got_revision": "288139", "project": "", "patch_url": "", "parentslavename": "build1-a1", "root": "", "primary_repo": ""}' --test-platform android --generate-json-file -o gtest-results/base_unittests --annotate gtest --build-number 22085 --builder-name 'Android Tests (dbg)' base_unittests --verbose
[Running on builder: "Android Tests (dbg)"]
DBUS_SESSION_BUS_ADDRESS env var not found, starting dbus-launch
 setting DBUS_SESSION_BUS_ADDRESS to unix:abstract=/tmp/dbus-p2NSrlwT6t,guid=118a14e22115547464aef590000002f4
 setting DBUS_SESSION_BUS_PID to 8386
Additional test environment:
  LLVM_SYMBOLIZER_PATH=/b/build/slave/Android_Tests__dbg_/build/src/third_party/llvm-build/Release+Asserts/bin/llvm-symbolizer

src/build/android/test_runner.py gtest --release -s base_unittests
Traceback (most recent call last):
  File "src/build/android/test_runner.py", line 836, in <module>
    sys.exit(main())
  File "src/build/android/test_runner.py", line 832, in main
    return command_option_parser.ParseAndExecute(option_parser)
  File "/b/build/slave/Android_Tests__dbg_/build/src/build/android/pylib/utils/command_option_parser.py", line 75, in ParseAndExecute
    return cmd.run_command_func(argv[1], options, args, option_parser)
  File "src/build/android/test_runner.py", line 746, in RunTestsCommand
    return _RunGTests(options, devices)
  File "src/build/android/test_runner.py", line 527, in _RunGTests
    runner_factory, tests = gtest_setup.Setup(gtest_options, devices)
  File "/b/build/slave/Android_Tests__dbg_/build/src/build/android/pylib/gtest/setup.py", line 325, in Setup
    % test_options.suite_name)
Exception: Did not find base_unittests target. Ensure it has been built.
using JSON summary output instead of gtest XML
No data was available to update the JSON results

Original issue's description:
> Run android tests through runtest.py.
>
> This CL re-lands https://codereview.chromium.org/410033002 while addressed a few issues.
> 1. --results-directory must be passed along with --generate-gtest-json
> 2. --test-platform, --annotate, --build-number, --builder-name should be passed in order to upload results to correct dashboard
> 3. This CL depends on https://codereview.chromium.org/414223011/ to fix a bug in runtest.py
>
> BUG=329102
> R=yfriedman@chromium.org, navabi@chromium.org, jbudorick@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288134

TBR=jbudorick@chromium.org,navabi@chromium.org,yfriedman@chromium.org,zty@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329102

Review URL: https://codereview.chromium.org/455493002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288191 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRoll gtest and gmock DEPS.
ncbray@chromium.org [Thu, 7 Aug 2014 23:40:18 +0000 (23:40 +0000)]
Roll gtest and gmock DEPS.

These DEPS have not been updated for ~2 years, so there is a good chance
something will blow up. Due to interdependancy between the repos,
rolling gtest required gmock also be rolled.

BUG=none

Review URL: https://codereview.chromium.org/425333002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288164 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRun android tests through runtest.py.
zty@chromium.org [Thu, 7 Aug 2014 20:25:10 +0000 (20:25 +0000)]
Run android tests through runtest.py.

This CL re-lands https://codereview.chromium.org/410033002 while addressed a few issues.
1. --results-directory must be passed along with --generate-gtest-json
2. --test-platform, --annotate, --build-number, --builder-name should be passed in order to upload results to correct dashboard
3. This CL depends on https://codereview.chromium.org/414223011/ to fix a bug in runtest.py

BUG=329102
R=yfriedman@chromium.org, navabi@chromium.org, jbudorick@chromium.org

Review URL: https://codereview.chromium.org/414383002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288134 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoUse a qualified path to blink resources, content part.
thakis@chromium.org [Thu, 7 Aug 2014 16:35:02 +0000 (16:35 +0000)]
Use a qualified path to blink resources, content part.

This should prevent problems such as described in

  [chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_*
                 compile errors in blink_platform_impl.cc

Depends on https://codereview.chromium.org/431883002

BUG=400860
TBR=brettw

Review URL: https://codereview.chromium.org/430083002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288077 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks ago[Android]: Fix tombstones.py architecture detection.
rmcilroy@chromium.org [Thu, 7 Aug 2014 16:22:47 +0000 (16:22 +0000)]
[Android]: Fix tombstones.py architecture detection.

This CL fixes tombstones.py architecture detection in two ways:
 - If the tombstone contains an ABI line, use this in preference to the devices
   default ABI, since some devices support multiple ABIs (e.g., 'arm' and 'arm64').
 - Map the abi to an arch which the stack tool accepts, e.g., armeabi-v7a -> arm, arm64-v8a -> arm64.

NOTRY=true

Review URL: https://codereview.chromium.org/446273003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288072 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoWhitespace change to check if build fail is flake.
mlamouri@chromium.org [Thu, 7 Aug 2014 14:38:26 +0000 (14:38 +0000)]
Whitespace change to check if build fail is flake.

NOTRY=true
NOTREECHECKS=true

BUG=None

Review URL: https://codereview.chromium.org/450703002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@288042 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRemove some GN Build files related to blink from build/secondary tree.
tfarina@chromium.org [Thu, 7 Aug 2014 03:00:23 +0000 (03:00 +0000)]
Remove some GN Build files related to blink from build/secondary tree.

Blink now has the real implementations of these files in their repo:

platform -> https://src.chromium.org/viewvc/blink?view=rev&revision=172998
wtf ->  https://src.chromium.org/viewvc/blink?view=rev&revision=172321

BUG=None
TEST=trybots
R=brettw@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/420113002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287947 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoIf device does not come back after provisioning, add to bad devices.
navabi@google.com [Thu, 7 Aug 2014 00:09:07 +0000 (00:09 +0000)]
If device does not come back after provisioning, add to bad devices.

BUG=391071

Review URL: https://codereview.chromium.org/442173002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287910 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoSet the grit .d file dir in GN build properly.
brettw@chromium.org [Wed, 6 Aug 2014 22:34:55 +0000 (22:34 +0000)]
Set the grit .d file dir in GN build properly.

Put the .d file in the same directory as the output from grit. Currently it
uses the default location for the .d file all the time, even in cases where the
output directory is overridden and the rest of the files go somewhere else.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/450483004

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287877 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoUse the new trim modes in the GN build.
brettw@chromium.org [Wed, 6 Aug 2014 22:11:59 +0000 (22:11 +0000)]
Use the new trim modes in the GN build.

This uses the new "trim" input conversion option and also the default arguments to exec script to clean up some calls.

R=bbudge@chromium.org, bbudge

Review URL: https://codereview.chromium.org/138693003

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287873 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoEnable Android lint by default
cjhopman@chromium.org [Wed, 6 Aug 2014 19:12:24 +0000 (19:12 +0000)]
Enable Android lint by default

BUG=393235

Review URL: https://codereview.chromium.org/447793002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287823 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRevert of Enable Android lint by default (https://codereview.chromium.org/396293002/)
aberent@chromium.org [Wed, 6 Aug 2014 10:26:09 +0000 (10:26 +0000)]
Revert of Enable Android lint by default (https://codereview.chromium.org/396293002/)

Reason for revert:
Two Android build bots (downstream) are failing as a result of this CL.

Reverting as Android Build Sheriff.

BUG=401020
TBR=cjhopman
NOTRY=true

Original issue's description:
> Enable Android lint by default
>
> BUG=393235
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287676

Review URL: https://codereview.chromium.org/446833002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287751 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoMake android_apk template actually create an apk
cjhopman@chromium.org [Wed, 6 Aug 2014 07:29:42 +0000 (07:29 +0000)]
Make android_apk template actually create an apk

This is essentially three steps, packaging resources, packaging code,
and then signing+zipaligning the apk.

The apk does not currently contain the native libraries.

Depends on http://crrev.com/386473002/

BUG=359249

Review URL: https://codereview.chromium.org/383613002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287729 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks ago[Android] Temporarily suppress RTL start&end check error.
kkimlabs@chromium.org [Wed, 6 Aug 2014 06:37:40 +0000 (06:37 +0000)]
[Android] Temporarily suppress RTL start&end check error.

The newest Android SDK had start&end attributes in non -v17 resources.
Temporarily change the checking script from error to warning so that
people can continue to work before it is fixed. This should be
reverted once the issue is addressed

BUG=None

Review URL: https://codereview.chromium.org/445753002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287711 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks ago[Android] Fix type-parameterized gtest parsing.
jbudorick@chromium.org [Wed, 6 Aug 2014 06:16:16 +0000 (06:16 +0000)]
[Android] Fix type-parameterized gtest parsing.

BUG=

Review URL: https://codereview.chromium.org/441023002

git-svn-id: http://src.chromium.org/svn/trunk/src/build@287701 4ff67af0-8c30-449e-8e8b-ad334ec8d88c