chromium/src/ppapi.git
16 hours agoRevert 284684 "Pepper: Delete FileDownloader in trusted plugin." master
sky@chromium.org [Tue, 22 Jul 2014 23:09:52 +0000 (23:09 +0000)]
Revert 284684 "Pepper: Delete FileDownloader in trusted plugin."

Reverting as broke chrome and chromeos dbg builders:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32615/steps/browser_tests/logs/SuccessfulLoadUMA
[ RUN      ] NaClBrowserTestPnacl.SuccessfulLoadUMA
Xlib:  extension "RANDR" missing on display ":9".
Xlib:  extension "RANDR" missing on display ":9".
[18889:18889:0722/130648:WARNING:password_store_factory.cc(215)] Using
basic (unencrypted) store for password storage. See
http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more
information about password storage options.
HTTP server started on http://127.0.0.1:56115...
sending server_data: {"host": "127.0.0.1", "port": 56115} (36 bytes)
[9:10:0722/130650:ERROR:pnacl_translation_resource_host.cc(135)] Got
invalid platformfilefortransit
/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/vector:461:
    error: attempt to insert into container with an iterator from a
    different container.

Objects involved in the operation:
sequence "this" @ 0x0x392ba6c93260 {
}
iterator "__position" @ 0x0x7fff9ff24e20 {
  state = past-the-end;
  references sequence @ 0x0x7fff9ff24e20
}
[18889:18938:0722/130651:WARNING:raw_channel_posix.cc(214)] recvmsg:
Connection reset by peer
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7fe4bf491cee base::debug::StackTrace::StackTrace()
#1 0x000004af93fa content::(anonymous
namespace)::DumpStackTraceSignalHandler()
#2 0x7fe4b68074a0 \u003Cunknown>
#3 0x7fe4b68b9a43 __poll
#4 0x7fe4b76faff6 \u003Cunknown>
#5 0x7fe4b76fb124 g_main_context_iteration
#6 0x7fe4bf44ff75 base::MessagePumpGlib::Run()
#7 0x7fe4bf54b1f0 base::MessageLoop::RunHandler()
#8 0x7fe4bf5b18e2 base::RunLoop::Run()
#9 0x000004b63969 content::RunThisRunLoop()
#10 0x000004b638fa content::RunMessageLoop()
#11 0x000004b0ea15 content::JavascriptTestObserver::Run()
#12 0x000001312927 NaClBrowserTestBase::RunJavascriptTest()
#13 0x000001312a48 NaClBrowserTestBase::RunLoadTest()
#14 0x00000130f514 (anonymous
namespace)::NaClBrowserTestPnacl_SuccessfulLoadUMA_Test::RunTestOnMai
...

> Pepper: Delete FileDownloader in trusted plugin.
>
> This simplifies PnaclCoordinator considerably and reduces the total
> amount of code in the trusted plugin.
>
> BUG=239656
>
> Review URL: https://codereview.chromium.org/393693004

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/406323003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@284791 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

16 hours agoRevert 284766 "Pepper: Simplify TempFile in trusted plugin."
sky@chromium.org [Tue, 22 Jul 2014 23:08:18 +0000 (23:08 +0000)]
Revert 284766 "Pepper: Simplify TempFile in trusted plugin."

Sorry I had to revert this. It's not because it caused problems, but
rather I needed to revert r284684 as it caused problems and your patch
touches the same files.

> Pepper: Simplify TempFile in trusted plugin.
>
> This change makes the behavior of internal_handle_ in TempFile easier to reason
> about. This change is possible after a large refactoring of PnaclCoordinator
> that happened as a result of removing FileDownloader.
>
> BUG=239656
> R=bbudge@chromium.org
>
> Review URL: https://codereview.chromium.org/413493002

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/406383002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@284790 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

18 hours agoPepper: Simplify TempFile in trusted plugin.
teravest@chromium.org [Tue, 22 Jul 2014 21:06:11 +0000 (21:06 +0000)]
Pepper: Simplify TempFile in trusted plugin.

This change makes the behavior of internal_handle_ in TempFile easier to reason
about. This change is possible after a large refactoring of PnaclCoordinator
that happened as a result of removing FileDownloader.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/413493002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@284766 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

23 hours agoPepper: Delete FileDownloader in trusted plugin.
teravest@chromium.org [Tue, 22 Jul 2014 15:54:45 +0000 (15:54 +0000)]
Pepper: Delete FileDownloader in trusted plugin.

This simplifies PnaclCoordinator considerably and reduces the total
amount of code in the trusted plugin.

BUG=239656

Review URL: https://codereview.chromium.org/393693004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@284684 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

40 hours agoRemove an out of date comment in PPAPI code.
thestig@chromium.org [Mon, 21 Jul 2014 22:46:00 +0000 (22:46 +0000)]
Remove an out of date comment in PPAPI code.

NOTRY=true

Review URL: https://codereview.chromium.org/391413004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@284524 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

46 hours agoAdd to GN ppapi build.
brettw@chromium.org [Mon, 21 Jul 2014 17:25:31 +0000 (17:25 +0000)]
Add to GN ppapi build.

This should be everything except tests and examples.

R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/403023002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@284451 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 days agoPepper: Remove unused ppapi.gypi file.
teravest@chromium.org [Thu, 17 Jul 2014 20:26:03 +0000 (20:26 +0000)]
Pepper: Remove unused ppapi.gypi file.

I came across this while trying to figure out how to make entry points work for
the trusted plugin. It's confusing to have these gypi variables around
when they're not used anywhere.

BUG=
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/405433006

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@283855 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoAdd PPAPI interface for OpenGL ES 2.0 Vertex Array Objects.
zork@chromium.org [Thu, 17 Jul 2014 11:14:08 +0000 (11:14 +0000)]
Add PPAPI interface for OpenGL ES 2.0 Vertex Array Objects.

BUG=72612,370496

Review URL: https://codereview.chromium.org/397183002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@283750 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoUpdate and enable PPApiTest.URLLoaderTest3
yhirano@chromium.org [Thu, 17 Jul 2014 08:23:54 +0000 (08:23 +0000)]
Update and enable PPApiTest.URLLoaderTest3

The test was disabled[1] when XMLHttpRequest forbidden header names changed[2].
This CL updates and enables it.

1: https://src.chromium.org/viewvc/chrome?view=rev&revision=282507
2: https://src.chromium.org/viewvc/blink?view=rev&revision=178023

BUG=373120

Review URL: https://codereview.chromium.org/391213003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@283709 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoPepper: Remove some gyp defines for trusted plugin.
teravest@chromium.org [Thu, 17 Jul 2014 06:46:34 +0000 (06:46 +0000)]
Pepper: Remove some gyp defines for trusted plugin.

As far as I can tell, these defines shouldn't have any effect. I'd like to make
the trusted plugin build more similar to what we have for the renderer so that
the transition will be easier when we get rid of the trusted plugin shared
library.

This mirrors a change made to native_client in 2012:
  http://git.chromium.org/gitweb/?p=native_client/src/native_client.git;a=commitdiff;h=c0a9077e3a604521f67f35c9bec3be031dd21465

BUG=394497

Review URL: https://codereview.chromium.org/391343006

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@283668 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoPepper: Change PPB_VideoDecoder::Reset behavior so plugin always manages textures.
bbudge@chromium.org [Wed, 16 Jul 2014 20:24:01 +0000 (20:24 +0000)]
Pepper: Change PPB_VideoDecoder::Reset behavior so plugin always manages textures.
Reset now will allow plugin to call RecyclePicture. The plugin must recycle any
texture it receives now. This makes plugin code simpler, since it can treat all
textures it receives in the same way (no special Reset handling).

Also fix a bug where Reset didn't return textures to the hardware decoder, which
already has this behavior.

BUG=281689

Review URL: https://codereview.chromium.org/390213002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@283483 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 days agoShorten gyp target names for PNaCl IRT shim
dschuff@chromium.org [Wed, 16 Jul 2014 15:51:46 +0000 (15:51 +0000)]
Shorten gyp target names for PNaCl IRT shim

These are basically the longest generated names, and the trybots appear
to have shorter overall names than the buildbots, because try jobs pass
and then the builders break.

R=jvoung@chromium.org
TBR=binji@chromium.org, teravest@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3846

Review URL: https://codereview.chromium.org/399523002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@283402 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

8 days agoRemove return value for PpapiHostMsg_PPBVar_AddRefObject
jbauman@chromium.org [Mon, 14 Jul 2014 23:55:37 +0000 (23:55 +0000)]
Remove return value for PpapiHostMsg_PPBVar_AddRefObject

It's unused and not necessary.

BUG=391025

Review URL: https://codereview.chromium.org/380423002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@283090 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoPepper: Clarify end-of-bitcode-stream behavior.
teravest@chromium.org [Fri, 11 Jul 2014 23:36:35 +0000 (23:36 +0000)]
Pepper: Clarify end-of-bitcode-stream behavior.

The PutBytes() method in PnaclTranslateThread is used for two purposes: giving
data to the translator processes and signaling the end of the stream.  The way
it's currently done is a bit confusing; this breaks the method into two
for clarity. This is to make code review easier to read for an upcoming change
which removes FileDownloader from the trusted plugin.

BUG=370556

Review URL: https://codereview.chromium.org/383213005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@282734 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoPepper: Make sure 'out' params are initialized for all code paths.
bbudge@chromium.org [Fri, 11 Jul 2014 21:00:15 +0000 (21:00 +0000)]
Pepper: Make sure 'out' params are initialized for all code paths.
Change PPB_ImageData_Proxy and PPB_Instance_Proxy to always initialize
'out' params, to avoid sending uninitialized memory from renderer to
plugin.

BUG=391023

Review URL: https://codereview.chromium.org/383143003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@282692 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days agoPepper: Add GL_TEXTURE_EXTERNAL_OES texture target to PPB_VideoDecoder docs and example.
bbudge@chromium.org [Fri, 11 Jul 2014 20:01:47 +0000 (20:01 +0000)]
Pepper: Add GL_TEXTURE_EXTERNAL_OES texture target to PPB_VideoDecoder docs and example.

GL_TEXTURE_2D is used by x86 non-OSX platforms and by software fallback.
GL_TEXTURE_RECTANGLE_ARB will be used on OSX hardware.
GL_TEXTURE_EXTERNAL_OES is used on ARM ChromeOS.

BUG=281689

Review URL: https://codereview.chromium.org/354763003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@282674 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days ago[NaCl SDK] docs: Remove references to obsolete debugging env vars.
jvoung@chromium.org [Fri, 11 Jul 2014 18:08:44 +0000 (18:08 +0000)]
[NaCl SDK] docs: Remove references to obsolete debugging env vars.

Make also complained about some broken links and stopped w/
warnings as errors.

I assume a bunch these went away w/ the really old proxy switch =)

BUG=266395
NOTRY=true

Review URL: https://codereview.chromium.org/383523004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@282653 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

11 days ago[PPAPI] Make the NaCl SDK presubmit check a warning instead of an error.
binji@chromium.org [Fri, 11 Jul 2014 16:43:57 +0000 (16:43 +0000)]
[PPAPI] Make the NaCl SDK presubmit check a warning instead of an error.

There are some PPAPI dev interfaces that should not be added to the SDK, so it
is better to warn instead of making it a presubmit error.

BUG=none
R=teravest@chromium.org
TEST=made change to ppapi/cpp/buffer_dev.h, ran git cl presubmit

Review URL: https://codereview.chromium.org/379923010

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@282637 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

12 days agoEnsures that input Pepper Flash supports the newly added AudioBus interface.
henrika@chromium.org [Thu, 10 Jul 2014 16:44:01 +0000 (16:44 +0000)]
Ensures that input Pepper Flash supports the newly added AudioBus interface.

This CL (https://codereview.chromium.org/344583002) has modified the data structure in shared memory and the original CL did not take the input side of Pepper Flash into account. Pepper Flash recording was therefore broken. This CL ensures that Pepper knows about the new audio structure and accounts for it using by mapping shared memory to an audio bus and then interleaves the data into a plain byte vector before sending it to the Pepper callback.

Adding vrk@ as TBR for the added dependency in media.

R=piman@chromium.org, xians@chromium.org
TBR=vrk
BUG=387303
TEST=www.youtube.com/my_webcam

Review URL: https://codereview.chromium.org/371273004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@282357 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

13 days agoPepper: Initialize PP_ImageDataDesc when creating ImageData.
bbudge@chromium.org [Thu, 10 Jul 2014 02:54:11 +0000 (02:54 +0000)]
Pepper: Initialize PP_ImageDataDesc when creating ImageData.
Clears memory so we don't send unitialized memory to the
renderer.

BUG=391023

Review URL: https://codereview.chromium.org/383543004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@282222 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

13 days agoPepper: Small PnaclResources cleanup
teravest@chromium.org [Wed, 9 Jul 2014 23:39:22 +0000 (23:39 +0000)]
Pepper: Small PnaclResources cleanup

This fixes a place where the wrong URL is used for the ld process when
performing PNaCl translation. I don't believe the effect of this is severe,
though it will cause the wrong url to be displayed when it's running.

This also removes an unnecessary string constant usage in the trusted plugin.

BUG=

Review URL: https://codereview.chromium.org/373003005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@282176 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

13 days agoFixes for re-enabling more MSVC level 4 warnings: ppapi/ edition
pkasting@chromium.org [Wed, 9 Jul 2014 21:41:02 +0000 (21:41 +0000)]
Fixes for re-enabling more MSVC level 4 warnings: ppapi/ edition

This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Possibly-uninitialized local variable
* Signedness mismatch

This also contains a small number of other cleanups/simplifications to nearby
code.

BUG=81439
TEST=none
R=teravest@chromium.org

Review URL: https://codereview.chromium.org/375133003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@282133 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 weeks agoMove webpreferences.* from webkit/ to content/
tfarina@chromium.org [Wed, 9 Jul 2014 06:25:05 +0000 (06:25 +0000)]
Move webpreferences.* from webkit/ to content/

BUG=338338
TEST=None
R=jam@chromium.org
TBR=boliu@chromium.org # for android_webview
TBR=bauerb@chromium.org # for components/plugins
TBR=dmichael@chromium.org # for ppapi

Review URL: https://codereview.chromium.org/357203003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@281978 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 weeks agoPepper: Narrow dev channel whitelisting behavior.
teravest@chromium.org [Mon, 7 Jul 2014 21:30:21 +0000 (21:30 +0000)]
Pepper: Narrow dev channel whitelisting behavior.

An earlier change whitelisted all "dev channel" Pepper APIs for two select
application origins. This change narrows the whitelisting behavior to only
grant access to the Compositor and VideoDecode APIs. This makes this instance
of whitelisting easier to remove in the future.

BUG=386743

Review URL: https://codereview.chromium.org/346263006

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@281588 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

2 weeks agoPepper: Remove program_url in trusted plugin.
teravest@chromium.org [Thu, 3 Jul 2014 00:22:03 +0000 (00:22 +0000)]
Pepper: Remove program_url in trusted plugin.

This reduces the amount of state in the trusted plugin (slightly).

BUG=239656

Review URL: https://codereview.chromium.org/367153004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@281127 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoAdd support for strong future sync points.
jbauman@chromium.org [Tue, 1 Jul 2014 00:27:22 +0000 (00:27 +0000)]
Add support for strong future sync points.

If InsertFutureSyncPoint() is used (this is only allowed from the browser process), the sync point will not be retired automatically but can be retired later manually with RetireSyncPoint. Any command buffer that waits on it before it's retired can wait indefinitely.

BUG=365454

Review URL: https://codereview.chromium.org/284233008

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@280708 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoPepper: SelLdrLauncherChrome cleanup.
teravest@chromium.org [Mon, 30 Jun 2014 22:56:28 +0000 (22:56 +0000)]
Pepper: SelLdrLauncherChrome cleanup.

The indirection provided by SelLdrLauncherChrome::Start() isn't much help.
Instead, we just expose the channel so that ServiceRuntime can pass it to
LaunchSelLdr directly.

BUG=239656

Review URL: https://codereview.chromium.org/360743002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@280686 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoEnable mmap and identity-based validation caching on pnacl-{llc,ld}.nexe
jvoung@chromium.org [Mon, 30 Jun 2014 16:18:53 +0000 (16:18 +0000)]
Enable mmap and identity-based validation caching on pnacl-{llc,ld}.nexe

Register the executables w/ the validation cache on open and hook up the
file info just like the other NaCl module loads.

The non-executable files are still opened without the windows-specific
FLAG_EXEC.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3614
TEST= ValidationCacheOfTranslatorNexes

Review URL: https://codereview.chromium.org/356923004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@280605 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoPepper: Remove PPP_ManifestService.
teravest@chromium.org [Fri, 27 Jun 2014 02:07:29 +0000 (02:07 +0000)]
Pepper: Remove PPP_ManifestService.

Now that enough logic has been moved out of the trusted plugin, we can get rid
of PPP_ManifestService and make the code in the Non-SFI case much clearer.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32
BUG=239656

Review URL: https://codereview.chromium.org/356053004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@280204 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoNaCl: begin reducing ServiceRuntime's dependance on Plugin in the trusted plugin.
ncbray@chromium.org [Fri, 27 Jun 2014 01:41:42 +0000 (01:41 +0000)]
NaCl: begin reducing ServiceRuntime's dependance on Plugin in the trusted plugin.

BUG=

Review URL: https://codereview.chromium.org/342553004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@280197 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoAdd preliminary support for UBsan's vptr in Chromium (-fsanitize=vptr).
byoungyoung@google.com [Thu, 26 Jun 2014 23:31:40 +0000 (23:31 +0000)]
Add preliminary support for UBsan's vptr in Chromium (-fsanitize=vptr).

Can be enabled using ubsan_vptr=1, but not working right now due to
1) Clang's missing library and 2) Clang's link bug.

BUG=174801

TBR=kbr@chromium.org, mseaborn@chromium.org
R=glider@chromium.org, inferno@chromium.org

Review URL: https://codereview.chromium.org/357753002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@280162 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoMove PPB_TrueTypeFont_Dev host from renderer to browser.
bbudge@chromium.org [Thu, 26 Jun 2014 21:28:18 +0000 (21:28 +0000)]
Move PPB_TrueTypeFont_Dev host from renderer to browser.

On Linux, we can now use FontConfig in the browser process since it
is thread-safe, so we don't need to use SandboxIPC from the renderer.
In the browser, the needed functionality is split off from
SandboxIPCHandler into a static function,
MatchFontFaceWithFallback in a new pair of files, font_utils_linux.*.

This change also moves any potentially blocking font creation and
reading to the browser's blocking thread pool.

I reworked the PepperTrueTypeFont base class to make Create simpler.
- Added an Initialize method which returns the font descriptor.
- Removed the Describe method.

I reworked the resource to delay calls to the host until we receive the desc
and initialization is complete. Describe will now wait until Initialize completes,
and the host uses a SequencedTaskRunner to serialize tasks, so Initialize
completes before GetTableTags and GetTable calls complete.

The Describe method can be implemented without IPC since we have the desc
on the plugin side.

BUG=382729

Review URL: https://codereview.chromium.org/337203003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@280107 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoPepper: Move Pnacl init time out of trusted plugin.
teravest@chromium.org [Thu, 26 Jun 2014 20:08:31 +0000 (20:08 +0000)]
Pepper: Move Pnacl init time out of trusted plugin.

This change moves the pnacl init time out of the trusted plugin. It's part of a
series of changes to get rid of the trusted plugin entirely.

BUG=239656
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/356923002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@280082 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoPepper: Remove method in PluginReverseInterface.
teravest@chromium.org [Thu, 26 Jun 2014 20:03:04 +0000 (20:03 +0000)]
Pepper: Remove method in PluginReverseInterface.

CloseManifestEntry has been removed from nacl::ReverseInterface, so we don't
need this empty method anymore.

BUG=
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/357863002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@280079 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoExport ResourceMessageParams::SerializedHandles
hans@chromium.org [Thu, 26 Jun 2014 17:36:39 +0000 (17:36 +0000)]
Export ResourceMessageParams::SerializedHandles

The inner class needs to be exported in case any uses in inline methods
or vtable of the outer class causes it to potentially be referenced across
a shared library boundary.

On non-Windows, the visibility attribute is already inherited by nested
classes, but on Windows, they must be marked explicitly.

BUG=82385
TEST=use Clang to do component release build of chrome on Windows

Review URL: https://codereview.chromium.org/359503003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@280038 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoTidy up stray semicolons and missing include guard in message files.
tsepez@chromium.org [Thu, 26 Jun 2014 06:08:40 +0000 (06:08 +0000)]
Tidy up stray semicolons and missing include guard in message files.

These manifested when I was making an ipc utility for my own use. They
are wrong even if they don't break the builders.

R=jam@chromium.org

Review URL: https://codereview.chromium.org/354493007

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@279919 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoPepper: Refactor OpenManifestEntry.
teravest@chromium.org [Wed, 25 Jun 2014 22:01:20 +0000 (22:01 +0000)]
Pepper: Refactor OpenManifestEntry.

This change pulls out more OpenManifestEntry code from service_runtime, making
PPB_NaCl_Private a smallter interface, and preparing for pulling all of that
logic out of the trusted plugin.

An earlier version of this change was reverted after breaking Non-SFI mode, but
the Non-SFI case no longer uses this codepath.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32
BUG=239656

Review URL: https://codereview.chromium.org/357773002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@279832 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 weeks agoNaCl: clean up nexe loading logic in trusted plugin.
ncbray@chromium.org [Wed, 25 Jun 2014 18:35:15 +0000 (18:35 +0000)]
NaCl: clean up nexe loading logic in trusted plugin.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32
BUG=none

Review URL: https://codereview.chromium.org/338353008

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@279762 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoPepper: Remove callback for resource loading.
teravest@chromium.org [Tue, 24 Jun 2014 20:47:07 +0000 (20:47 +0000)]
Pepper: Remove callback for resource loading.

Using CompletionCallbacks for PNaClResources::StartLoad and
PNaClResources::ReadResourceInfo doesn't accomplish much and makes
the code more complicated. This is in preparation for a larger
change to get rid of FileDownloader for streaming pexe downloads.

BUG=239656

Review URL: https://codereview.chromium.org/358443002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@279485 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoRemove bogus include paths from NaCl gyp files.
sergeyu@chromium.org [Tue, 24 Jun 2014 00:12:43 +0000 (00:12 +0000)]
Remove bogus include paths from NaCl gyp files.

BUG=384752

Review URL: https://codereview.chromium.org/336023003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@279241 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoPpapi: Avoid entering resource three times in BindGraphics().
penghuang@chromium.org [Mon, 23 Jun 2014 23:34:04 +0000 (23:34 +0000)]
Ppapi: Avoid entering resource three times in BindGraphics().

BUG=None

Review URL: https://codereview.chromium.org/355493002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@279227 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoRemove LoadModule SRPC for non-SFI mode.
hidehiko@chromium.org [Mon, 23 Jun 2014 09:44:08 +0000 (09:44 +0000)]
Remove LoadModule SRPC for non-SFI mode.

This CL removes LoadModule SRPC for non-SFI mode. Instead, non-SFI mode
starts to pass nexe file to LaunchSelLdr, which is eventually passed to
NaClListener::OnStart().

TEST=Ran browser_tests --gtest_filter=*NonSfi*:*NonSFI* locally and trybots
BUG=333950
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Review URL: https://codereview.chromium.org/337463002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@279069 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoPepper: Simplify OpenResource() for Non-SFI.
teravest@chromium.org [Fri, 20 Jun 2014 23:31:34 +0000 (23:31 +0000)]
Pepper: Simplify OpenResource() for Non-SFI.

The Non-SFI implementation of OpenResource is pretty complicated. This is
because the logic to support that operation was entirely in the trusted
plugin. Now, we can perform the necessary logic entirely in Chromium, so
it can be made much simpler.

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32
BUG=239656

Review URL: https://codereview.chromium.org/339213003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278859 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks ago[PPAPI] Add browser tests for compositor API
penghuang@chromium.org [Fri, 20 Jun 2014 18:42:39 +0000 (18:42 +0000)]
[PPAPI] Add browser tests for compositor API

 And fix a bug found with the tests.
 BindGraphics() does not work for a device which is in the same type with the current bound device.

BUG=374383
R=piman@chromium.org, raymes@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278728

Review URL: https://codereview.chromium.org/324983005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278779 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoRevert 278728 "[PPAPI] Add browser tests for compositor API"
yzshen@chromium.org [Fri, 20 Jun 2014 18:08:31 +0000 (18:08 +0000)]
Revert 278728 "[PPAPI] Add browser tests for compositor API"

> [PPAPI] Add browser tests for compositor API
>
>  And fix a bug found with the tests.
>  BindGraphics() does not work for a device which is in the same type with the current bound device.
>
> BUG=374383
> R=piman@chromium.org, raymes@chromium.org
>
> Review URL: https://codereview.chromium.org/324983005

TBR=penghuang@chromium.org

Review URL: https://codereview.chromium.org/342323006

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278765 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks ago[PPAPI] Add browser tests for compositor API
penghuang@chromium.org [Fri, 20 Jun 2014 17:00:46 +0000 (17:00 +0000)]
[PPAPI] Add browser tests for compositor API

 And fix a bug found with the tests.
 BindGraphics() does not work for a device which is in the same type with the current bound device.

BUG=374383
R=piman@chromium.org, raymes@chromium.org

Review URL: https://codereview.chromium.org/324983005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278728 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoPepper: Whitelist dev channel APIs for some apps.
hamaji@chromium.org [Fri, 20 Jun 2014 07:51:42 +0000 (07:51 +0000)]
Pepper: Whitelist dev channel APIs for some apps.

Some applications need access to dev channel APIs before they will
become stable. As written, this change only performs whitelisting for NaCl
apps; I don't think we have any need for enabling this in the non-NaCl case.

I need to find a good way to test this.

BUG=383937
R=dmichael@chromium.org, jln@chromium.org, piman@chromium.org

Review URL: https://codereview.chromium.org/338523007

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278645 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoPPAPI: Move PPB_TraceEvent to have dev-channel permissions
dmichael@chromium.org [Thu, 19 Jun 2014 21:53:39 +0000 (21:53 +0000)]
PPAPI: Move PPB_TraceEvent to have dev-channel permissions

PPB_TraceEvent should be available to developers who want to profile
their application on Dev channel or Canary.

BUG=386636

Review URL: https://codereview.chromium.org/349443002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278499 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoQuiet output when untarring the pnacl translator from gyp builds.
dyen@chromium.org [Thu, 19 Jun 2014 19:05:24 +0000 (19:05 +0000)]
Quiet output when untarring the pnacl translator from gyp builds.

BUG= https://code.google.com/p/chromium/issues/detail?id=370981
TEST= Run "ninja -C out/Debug untar_pnacl_translator"

Review URL: https://codereview.chromium.org/341893003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278451 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoRemoved ManagedMemoryStats.
vmpstr@chromium.org [Thu, 19 Jun 2014 07:01:41 +0000 (07:01 +0000)]
Removed ManagedMemoryStats.

As of r277056, the gpu memory manager is no longer using
managed memory stats produced. This patch removes the managed
memory stats calculation from the tile manager. As well, this
patch removes ununsed gpu managed memory stats plumbing.

BUG=377065

Review URL: https://codereview.chromium.org/342483007

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278294 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoPepper: Add latency calculation to ppapi/examples/video_decode.
bbudge@chromium.org [Thu, 19 Jun 2014 06:29:43 +0000 (06:29 +0000)]
Pepper: Add latency calculation to ppapi/examples/video_decode.

Also, flip picture vertically (it was upside down).

BUG=281689

Review URL: https://codereview.chromium.org/340163002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278281 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoAdd GetScrollOffset function to PPB_View
raymes@chromium.org [Thu, 19 Jun 2014 01:48:14 +0000 (01:48 +0000)]
Add GetScrollOffset function to PPB_View

This adds a function to PPB_View which allows plugins to know the scroll offset
of the page when they are in view. This is useful for OOP PDF which uses the
scroll offset of the window it is contained in to determine the document's
scroll location. A web page can send scroll location via postMessage but
this is slow. Sending the offset directly via view messages is much faster
and seems reasonable.

We don't send the scroll offset in the cases where the plugin is off screen
to avoid any more additional IPC traffic than what currently exists.

BUG=303491

Review URL: https://codereview.chromium.org/329033003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278236 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks ago[PPAPI] Using ProduceTextureDirectCHROMIUM() to avoid binding and restoring GL_TEXTUR...
penghuang@chromium.org [Wed, 18 Jun 2014 20:48:42 +0000 (20:48 +0000)]
[PPAPI] Using ProduceTextureDirectCHROMIUM() to avoid binding and restoring GL_TEXTURE_2D target.

BUG=374383
R=bbudge@chromium.org, danakj@chromium.org

Review URL: https://codereview.chromium.org/341893004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278165 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoPepper: Small cleanup in PNaClCoordinator.
teravest@chromium.org [Wed, 18 Jun 2014 19:19:48 +0000 (19:19 +0000)]
Pepper: Small cleanup in PNaClCoordinator.

This simplifies the case where we fail to open all the necessary temporary
files as part of PNaCl translation.

RunTranslate() isn't called if num_object_files_opened_ != split_module_count_
anyway, so this should be equivalent to the existing behavior.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/335343006

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278143 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

4 weeks agoPPAPI: Implement synchronous postMessage
dmichael@chromium.org [Wed, 18 Jun 2014 16:44:00 +0000 (16:44 +0000)]
PPAPI: Implement synchronous postMessage

BUG=367896

Review URL: https://codereview.chromium.org/264303002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278102 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoPossible narrowing conversion build fix for Compositor API example.
pgal.u-szeged@partner.samsung.com [Wed, 18 Jun 2014 15:08:23 +0000 (15:08 +0000)]
Possible narrowing conversion build fix for Compositor API example.

In the compositor API example gcc 4.9 reports a possible
type narrowing when using fabs call. To fix this use fabsf instead.

BUG=385988
R=dmichael

Review URL: https://codereview.chromium.org/335383003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@278076 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRemove redundant use_nonsfi_mode from SelLdrStartParams.
hidehiko@chromium.org [Tue, 17 Jun 2014 21:13:26 +0000 (21:13 +0000)]
Remove redundant use_nonsfi_mode from SelLdrStartParams.

The params is used for ServiceRuntime::StartSelLdr(). ServiceRuntime
already knows if it is for nonsfi or not. So the use_nonsfi_mode in
SelLdrStartParams is just redundant. Remove it.

BUG=333950
TEST=Ran browser_tests --gtest_filter=*NonSfi*:*NonSFI* locally, and trybots.
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Review URL: https://codereview.chromium.org/332333003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277864 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoPepper: Add VP9 support to PPB_VideoDecoder API.
bbudge@chromium.org [Tue, 17 Jun 2014 20:40:10 +0000 (20:40 +0000)]
Pepper: Add VP9 support to PPB_VideoDecoder API.
Improve documentation for Reset and Flush.
Use VpxVideoDecoder in implementation code.

BUG=281689

Review URL: https://codereview.chromium.org/336833003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277860 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoFix race condition on ManifestService initialization.
hidehiko@chromium.org [Tue, 17 Jun 2014 20:06:29 +0000 (20:06 +0000)]
Fix race condition on ManifestService initialization.

SyncMessageFilter::Send() returns false immediately, if the IPC connection
is not yet established. As connecting is done asynchronously, there is
no guarantee that the connection is established on the first Send() invocation.
By this CL, Send() blocks the caller thread if the connection is not yet
established.
Note that currently the ratio should be probably low, because there are some
more initialization steps between the ManifestService creation and the first
Send() invocation. We're switching to changing the initialization procedure,
and then this race would be hit more easily.

TEST=Ran browser_tests --gtest_filter=*NonSfi*:*NonSFI* locally, and trybots. Also, locally modified the code to delay OnFilterAdded with and without this CL, and made sure this CL works well.
BUG=333950
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Review URL: https://codereview.chromium.org/334593004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277840 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRemove --disable-extensions-resource-whitelist.
pkasting@chromium.org [Tue, 17 Jun 2014 02:26:26 +0000 (02:26 +0000)]
Remove --disable-extensions-resource-whitelist.

BUG=357720
TEST=none
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/324793002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277625 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoPepper: Fix texture management in VideoDecoderShim on Reset.
bbudge@chromium.org [Mon, 16 Jun 2014 22:01:20 +0000 (22:01 +0000)]
Pepper: Fix texture management in VideoDecoderShim on Reset.

- Use a hash_set to track available textures. This prevents weird behavior
if the plugin recycles a texture twice.
- Fix Reset, so all textures are made available on completion.
- Fix the plugin, which had a bug that allowed pictures to jump the queue
and didn't behave correctly on Reset.

BUG=281689

Review URL: https://codereview.chromium.org/337743003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277548 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRemove apps in Pepper support and the PPB_Alarms_Dev API.
yzshen@chromium.org [Mon, 16 Jun 2014 19:09:38 +0000 (19:09 +0000)]
Remove apps in Pepper support and the PPB_Alarms_Dev API.

BUG=366304
TEST=None

Review URL: https://codereview.chromium.org/314823002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277513 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoPepper: Move more UMA stuff out of trusted plugin.
teravest@chromium.org [Mon, 16 Jun 2014 14:22:19 +0000 (14:22 +0000)]
Pepper: Move more UMA stuff out of trusted plugin.

This is yet another pretty simple change just lifting more lines out of the
trusted plugin. I added a method to PPB_NaCl_Private that's safe to call from
a background thread (there are other methods that are safe as well) to keep the
call sites simple.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/331973002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277424 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks ago[PPAPI] Compositor API implementation.
penghuang@chromium.org [Mon, 16 Jun 2014 14:20:26 +0000 (14:20 +0000)]
[PPAPI] Compositor API implementation.

Implement the compositor API which allows a plugin to combine different sources of visual data efficiently, such as PPB_ImageData and OpengGL texture.

API Proposal http://goo.gl/V7xcu3

BUG=374383

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277208

Review URL: https://codereview.chromium.org/298023004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277422 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRevert 277208 "[PPAPI] Compositor API implementation."
tzik@chromium.org [Mon, 16 Jun 2014 07:21:26 +0000 (07:21 +0000)]
Revert 277208 "[PPAPI] Compositor API implementation."

This CL seems to cause perf bot failure.
The log said nacl_helper-data size gained exceeds expectation.

http://build.chromium.org/p/chromium/builders/Linux/builds/50560
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper-data&rev=277212&checked=core

> [PPAPI] Compositor API implementation.
>
> Implement the compositor API which allows a plugin to combine different sources of visual data efficiently, such as PPB_ImageData and OpengGL texture.
>
> API Proposal http://goo.gl/V7xcu3
>
> BUG=374383
>
> Review URL: https://codereview.chromium.org/298023004

TBR=penghuang@chromium.org

Review URL: https://codereview.chromium.org/331123003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277372 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks ago[PPAPI] Compositor API implementation.
penghuang@chromium.org [Sat, 14 Jun 2014 08:41:25 +0000 (08:41 +0000)]
[PPAPI] Compositor API implementation.

Implement the compositor API which allows a plugin to combine different sources of visual data efficiently, such as PPB_ImageData and OpengGL texture.

API Proposal http://goo.gl/V7xcu3

BUG=374383

Review URL: https://codereview.chromium.org/298023004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277208 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoPepper: Refactor some coordinator histograms.
teravest@chromium.org [Fri, 13 Jun 2014 19:40:43 +0000 (19:40 +0000)]
Pepper: Refactor some coordinator histograms.

We have a bunch of histograms that log data at the same time as
ReportTranslationFinished(), so we may as well move some of that logic out of
the trusted plugin. We use a different time range for translation for other
metrics, so I had to add a "HistogramTimeTranslate" method in addition to the
existing ones for "small", "medium", and "large" times.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/307403005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277073 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRevert of Revert of Implement software fallback for PPB_VideoDecoder. (https://codere...
schenney@chromium.org [Fri, 13 Jun 2014 15:00:14 +0000 (15:00 +0000)]
Revert of Revert of Implement software fallback for PPB_VideoDecoder. (https://codereview.chromium.org/337683002/)

Reason for revert:
Revert of revert, which apparently wasn't a full revert.

Original issue's description:
> Revert of Implement software fallback for PPB_VideoDecoder. (https://codereview.chromium.org/311853005/)
>
> Reason for revert:
> Broke blink Linux tests compile.http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/37259
>
> Original issue's description:
> > Implement software fallback for PPB_VideoDecoder.
> > This modifies the proxy to implement software fallback mode.
> > The main change is to the host, which now can work with
> > media::VideoDecoders.
> >
> > media::VideoDecoder works differently from media::VideoDecodeAccelerator
> > so an adapter object, content::VideoDecoderShim is defined. It lives on the main thread and drives the actual decoder on the media thread via a child DecoderImpl class, which sends back frames of video. VideoDecoderShim receives those and converts frames to GL textures.
> >
> > gpu::Mailboxes are used so the host can create textures that are aliased
> > to the plugin's textures.
> >
> > The test plugin has been changed to include bitstream data for VP8 in order to
> > test the software decoder. The data is in ppapi/examples/video_decode/testdata.h
> > alongside the H264 data. The file diff is too large for this site but is structured
> > something like this:
> >
> > const unsigned char kData[] = {
> > #if defined USE_VP8_TESTDATA_INSTEAD_OF_H264
> > ...  lots of VP8 data
> >
> > #else  // !USE_VP8_TESTDATA_INSTEAD_OF_H264
> > ...  lots of H264 data
> >
> > #endif  // USE_VP8_TESTDATA_INSTEAD_OF_H264
> > };
> >
> >
> > There is a TODO to convert the example to load a file. I'm not sure how to go
> > about that but am willing to do the work if someone can point the way.
> >
> > BUG=281689
> > R=dmichael@chromium.org, fischman@chromium.org, sievers@chromium.org, tsepez@chromium.org
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277012
>
> TBR=dmichael@chromium.org,fischman@chromium.org,igorc@chromium.org,piman@chromium.org,sievers@chromium.org,tsepez@chromium.org,bbudge@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=281689
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277015

TBR=dmichael@chromium.org,fischman@chromium.org,igorc@chromium.org,piman@chromium.org,sievers@chromium.org,tsepez@chromium.org,bbudge@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=281689

Review URL: https://codereview.chromium.org/333903002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277020 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoRevert of Implement software fallback for PPB_VideoDecoder. (https://codereview.chrom...
schenney@chromium.org [Fri, 13 Jun 2014 14:35:15 +0000 (14:35 +0000)]
Revert of Implement software fallback for PPB_VideoDecoder. (https://codereview.chromium.org/311853005/)

Reason for revert:
Broke blink Linux tests compile.http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests/builds/37259

Original issue's description:
> Implement software fallback for PPB_VideoDecoder.
> This modifies the proxy to implement software fallback mode.
> The main change is to the host, which now can work with
> media::VideoDecoders.
>
> media::VideoDecoder works differently from media::VideoDecodeAccelerator
> so an adapter object, content::VideoDecoderShim is defined. It lives on the main thread and drives the actual decoder on the media thread via a child DecoderImpl class, which sends back frames of video. VideoDecoderShim receives those and converts frames to GL textures.
>
> gpu::Mailboxes are used so the host can create textures that are aliased
> to the plugin's textures.
>
> The test plugin has been changed to include bitstream data for VP8 in order to
> test the software decoder. The data is in ppapi/examples/video_decode/testdata.h
> alongside the H264 data. The file diff is too large for this site but is structured
> something like this:
>
> const unsigned char kData[] = {
> #if defined USE_VP8_TESTDATA_INSTEAD_OF_H264
> ...  lots of VP8 data
>
> #else  // !USE_VP8_TESTDATA_INSTEAD_OF_H264
> ...  lots of H264 data
>
> #endif  // USE_VP8_TESTDATA_INSTEAD_OF_H264
> };
>
>
> There is a TODO to convert the example to load a file. I'm not sure how to go
> about that but am willing to do the work if someone can point the way.
>
> BUG=281689
> R=dmichael@chromium.org, fischman@chromium.org, sievers@chromium.org, tsepez@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277012

TBR=dmichael@chromium.org,fischman@chromium.org,igorc@chromium.org,piman@chromium.org,sievers@chromium.org,tsepez@chromium.org,bbudge@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=281689

Review URL: https://codereview.chromium.org/337683002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277015 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoFix the dev version of the PPAPI video decoder plugin.
bbudge@chromium.org [Fri, 13 Jun 2014 14:04:57 +0000 (14:04 +0000)]
Fix the dev version of the PPAPI video decoder plugin.
TBR=dmichael@chromium.org

BUG=281689

Review URL: https://codereview.chromium.org/334883002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277013 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoImplement software fallback for PPB_VideoDecoder.
bbudge@chromium.org [Fri, 13 Jun 2014 13:43:11 +0000 (13:43 +0000)]
Implement software fallback for PPB_VideoDecoder.
This modifies the proxy to implement software fallback mode.
The main change is to the host, which now can work with
media::VideoDecoders.

media::VideoDecoder works differently from media::VideoDecodeAccelerator
so an adapter object, content::VideoDecoderShim is defined. It lives on the main thread and drives the actual decoder on the media thread via a child DecoderImpl class, which sends back frames of video. VideoDecoderShim receives those and converts frames to GL textures.

gpu::Mailboxes are used so the host can create textures that are aliased
to the plugin's textures.

The test plugin has been changed to include bitstream data for VP8 in order to
test the software decoder. The data is in ppapi/examples/video_decode/testdata.h
alongside the H264 data. The file diff is too large for this site but is structured
something like this:

const unsigned char kData[] = {
#if defined USE_VP8_TESTDATA_INSTEAD_OF_H264
...  lots of VP8 data

#else  // !USE_VP8_TESTDATA_INSTEAD_OF_H264
...  lots of H264 data

#endif  // USE_VP8_TESTDATA_INSTEAD_OF_H264
};

There is a TODO to convert the example to load a file. I'm not sure how to go
about that but am willing to do the work if someone can point the way.

BUG=281689
R=dmichael@chromium.org, fischman@chromium.org, sievers@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/311853005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@277012 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoDecouple IPC::MessageFilter from IPC::Channel
morrita@chromium.org [Fri, 13 Jun 2014 06:07:14 +0000 (06:07 +0000)]
Decouple IPC::MessageFilter from IPC::Channel

This change gets rid of Channel dependency from MessageFilter
so that it depends only on IPC::Sender.

TEST=none
BUG=377980
R=jam@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/324143002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@276939 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

5 weeks agoPepper: Remove nacl_entry_points.h.
teravest@chromium.org [Wed, 11 Jun 2014 18:43:57 +0000 (18:43 +0000)]
Pepper: Remove nacl_entry_points.h.

This function indirection is no longer necessary, and I was getting frustrated
by having the type signature of LaunchSelLdr twice in the source. I came across
this in an experimental CL modifying LaunchSelLdr to also receive information
for the user nexe.

BUG=333950
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/322403005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@276466 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoAdd limitation that LoadNexeAndStart must be called on the main thread.
hidehiko@chromium.org [Wed, 11 Jun 2014 12:55:09 +0000 (12:55 +0000)]
Add limitation that LoadNexeAndStart must be called on the main thread.

Now we're switching LoadNexeAndStart from synchronous implementation to
asynchronous one. Under PPAPI implementation, the async callbacks are
handled on main thread.
To keep the similicity of the thread model, this CL introduces the limitation
that Plugin::LoadNexeAndStart must be called on the main thread.

TEST=Ran browser_tests --gtest_filter=NaCl* locally and trybots.
BUG=333950
R=teravest@chromium.org

Review URL: https://codereview.chromium.org/321053004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@276371 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoMake ServiceRuntime::LoadModule asynchornize-able.
hidehiko@chromium.org [Wed, 11 Jun 2014 05:04:40 +0000 (05:04 +0000)]
Make ServiceRuntime::LoadModule asynchornize-able.

This is just a refactoring to prepare making trusted plugin channel
an async IPC. Currently, we're using sync SRPC call. This CL still
keeps using it as is, but makes the function interfaces friendly
to async calls.

TEST=run browser_tests --gtest_filter=NaCl* locally, and trybots.
BUG=333950
R=teravest@chromium.org

Review URL: https://codereview.chromium.org/326593002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@276268 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRemove base::kInvalidPlatformFileValue from components, ipc and ppapi.
rvargas@chromium.org [Tue, 10 Jun 2014 12:58:29 +0000 (12:58 +0000)]
Remove base::kInvalidPlatformFileValue from components, ipc and ppapi.

BUG=322664
TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/316363003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@276003 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRemove cdn from OWNERS for IPC security review.
palmer@chromium.org [Sun, 8 Jun 2014 20:16:35 +0000 (20:16 +0000)]
Remove cdn from OWNERS for IPC security review.

Since he is no longer on the project. Sniff. :'(

BUG=none
R=jln@chromium.org

Review URL: https://codereview.chromium.org/317243005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275756 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRemove fischman from WATCHLISTS and OWNERS as I am leaving the Chrome PA. Au revoir.
fischman@chromium.org [Sat, 7 Jun 2014 20:26:05 +0000 (20:26 +0000)]
Remove fischman from WATCHLISTS and OWNERS as I am leaving the Chrome PA.  Au revoir.

TBR=vrk@chromium.org, posciak@chromium.org

Review URL: https://codereview.chromium.org/322483006

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275692 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoAdd Promises for EME (Chromium side)
jrummell@chromium.org [Sat, 7 Jun 2014 08:54:25 +0000 (08:54 +0000)]
Add Promises for EME (Chromium side)

Now that the EME-WD spec has changed to specify promises, implement
them on the Chromium side. They currently get converted back to
events before passing them to blink:: until the blink interface gets
changed.

Additional changes in this CL:
1. Pass a reference to the promise though PPAPI.
2. Roll DEPS for CDM.h to include CDM_5.
3. Update cdm_adapter to use CDM_5 (in addition to existing CDM_4).
4. Change External Clear Key to use CDM_5.
5. Since CDM_5 references sessions by the actual session id (a string,
   web_session_id), switch to using it rather than the previously used
   session_id (which is an integer, and used as a reference).

BUG=358271
TEST=all existing encrypted media layout and browser tests pass

Review URL: https://codereview.chromium.org/265993002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275656 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoPPAPI: Remove PP_ALLOW_THIS_IN_INITIALIZER_LIST
dmichael@chromium.org [Fri, 6 Jun 2014 20:37:44 +0000 (20:37 +0000)]
PPAPI: Remove PP_ALLOW_THIS_IN_INITIALIZER_LIST

BUG=380827

Review URL: https://codereview.chromium.org/324453003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275514 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoNaCl: Fix irt_shim_ppapi.c to compile with -Wstrict-prototypes
mseaborn@chromium.org [Fri, 6 Jun 2014 20:28:47 +0000 (20:28 +0000)]
NaCl: Fix irt_shim_ppapi.c to compile with -Wstrict-prototypes

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3114
TEST=compile

Review URL: https://codereview.chromium.org/322443007

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275510 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks ago[PPAPI] API definition for compositor artifacts
miletus@chromium.org [Fri, 6 Jun 2014 18:57:38 +0000 (18:57 +0000)]
[PPAPI] API definition for compositor artifacts

API Proposal http://goo.gl/V7xcu3

BUG=374383
R=binji@chromium.org, dmichael@chromium.org, mpearson@chromium.org, piman@chromium.org, raymes@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/292523003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275490 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoFix Unaddr error from ppapi::proxy::MediaStreamAudioTrackResource::ReleaseBuffers
penghuang@chromium.org [Fri, 6 Jun 2014 10:05:45 +0000 (10:05 +0000)]
Fix Unaddr error from ppapi::proxy::MediaStreamAudioTrackResource::ReleaseBuffers

BUG=380669

Review URL: https://codereview.chromium.org/319703005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275364 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoNaCl: Fix irt_ppapi.h to compile with -Wstrict-prototypes
mseaborn@chromium.org [Fri, 6 Jun 2014 01:45:04 +0000 (01:45 +0000)]
NaCl: Fix irt_ppapi.h to compile with -Wstrict-prototypes

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3114
TEST=compile

Review URL: https://codereview.chromium.org/312323005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275297 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRemove stale references to PlatformFile flags, errors or functions.
rvargas@chromium.org [Thu, 5 Jun 2014 22:07:41 +0000 (22:07 +0000)]
Remove stale references to PlatformFile flags, errors or functions.

BUG=322664

Review URL: https://codereview.chromium.org/318753007

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275258 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoPepper: Clean up trusted plugin error reporting.
teravest@chromium.org [Thu, 5 Jun 2014 19:40:40 +0000 (19:40 +0000)]
Pepper: Clean up trusted plugin error reporting.

This change cleans up some error reporting and removes some unnecessary and
dead code. Not a very exciting change; just doing more cleanup.

BUG=239656

Review URL: https://codereview.chromium.org/311273007

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275220 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoPepper: Preparation for async LoadAndStartNexe.
teravest@chromium.org [Thu, 5 Jun 2014 18:27:58 +0000 (18:27 +0000)]
Pepper: Preparation for async LoadAndStartNexe.

This is a preperatory change for moving nexe loading and starting from SRPC to
Chrome IPC. It's much simpler from an IPC and threading perspective if the new
IPC traffic is asynchronous. This change updates Plugin::LoadAndStartNexe() to
prepare for having an asynchronous interface in ServiceRuntime.

BUG=333950

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275097

R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/316013005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275196 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoRevert 275097 "Pepper: Preparation for async LoadAndStartNexe."
nasko@chromium.org [Thu, 5 Jun 2014 17:46:06 +0000 (17:46 +0000)]
Revert 275097 "Pepper: Preparation for async LoadAndStartNexe."

Speculative revert due to broken Pepper tests.

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%285%29/builds/26837/steps/browser_tests/logs/PepperCDMsNotRegistered

> Pepper: Preparation for async LoadAndStartNexe.
>
> This is a preperatory change for moving nexe loading and starting from SRPC to
> Chrome IPC. It's much simpler from an IPC and threading perspective if the new
> IPC traffic is asynchronous. This change updates Plugin::LoadAndStartNexe() to
> prepare for having an asynchronous interface in ServiceRuntime.
>
> BUG=333950
>
> Review URL: https://codereview.chromium.org/316013005

TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/315073006

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275180 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoAdd IPC::ChannelProxy::Create() and IPC::SyncChannel::Create()
morrita@chromium.org [Thu, 5 Jun 2014 16:15:38 +0000 (16:15 +0000)]
Add IPC::ChannelProxy::Create() and IPC::SyncChannel::Create()

This change replaces constructors with Create() methods of
ChannelProxy and SyncChannel. This open the possibility to introduce
polymorphism to these classes.

This is a revision of r274310 (https://codereview.chromium.org/301973003/)
in which I added bunch of Create*() method variants.
The chagne was reverted. This change no longer does it and just keeps
using Channel::Mode to specify the channel type.

TEST=none
BUG=377980
R=darin@chromium.org,jam@chromium.org

Review URL: https://codereview.chromium.org/310853003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275140 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoPepper: Preparation for async LoadAndStartNexe.
teravest@chromium.org [Thu, 5 Jun 2014 14:28:17 +0000 (14:28 +0000)]
Pepper: Preparation for async LoadAndStartNexe.

This is a preperatory change for moving nexe loading and starting from SRPC to
Chrome IPC. It's much simpler from an IPC and threading perspective if the new
IPC traffic is asynchronous. This change updates Plugin::LoadAndStartNexe() to
prepare for having an asynchronous interface in ServiceRuntime.

BUG=333950

Review URL: https://codereview.chromium.org/316013005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@275097 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

6 weeks agoPepper: Miscellaneous trusted plugin cleanup.
teravest@chromium.org [Wed, 4 Jun 2014 20:29:48 +0000 (20:29 +0000)]
Pepper: Miscellaneous trusted plugin cleanup.

This removes some more unnecessary methods and moves some more UMA reporting
out of the trusted plugin, reducing the total line count.

It's a little awkward that we have to pass the max value of NaClErrorCode to
the new reporting method, but it keeps that enum out of the public NaCl
interface.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/315753003

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@274898 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 weeks agoPepper: Simplify error reporting in PnaclResources.
teravest@chromium.org [Tue, 3 Jun 2014 21:02:15 +0000 (21:02 +0000)]
Pepper: Simplify error reporting in PnaclResources.

This change reduces the size of the public API for PnaclCoordinator and
simplifies error reporting inside PnaclResources, making it easier to follow.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/315583005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@274621 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 weeks agoPepper: Remove Plugin::EnqueueProgressEvent.
teravest@chromium.org [Tue, 3 Jun 2014 19:57:20 +0000 (19:57 +0000)]
Pepper: Remove Plugin::EnqueueProgressEvent.

This wrapper isn't providing much benefit; we may as well tear it out. This
also removes the LengthComputable enum.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/316653002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@274598 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 weeks agoRevert of Pepper: Refactor OpenManifestEntry. (https://codereview.chromium.org/302093...
teravest@chromium.org [Tue, 3 Jun 2014 19:14:48 +0000 (19:14 +0000)]
Revert of Pepper: Refactor OpenManifestEntry. (https://codereview.chromium.org/302093012/)

Reason for revert:
This broke NaClBrowserTestPnaclNonSfi.IrtManifestFile on linux 32. That test will have to pass on the right trybot before landing. I'm not sure why it broke yet.

Original issue's description:
> Pepper: Refactor OpenManifestEntry.
>
> This change pulls out more OpenManifestEntry code from service_runtime, making
> PPB_NaCl_Private a smallter interface, and preparing for pulling all of that
> logic out of the trusted plugin.
>
> BUG=239656
> R=dmichael@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274530

TBR=dmichael@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=239656

Review URL: https://codereview.chromium.org/318463002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@274588 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 weeks agoPepper: Narrow locking at ld subprocess start.
teravest@chromium.org [Tue, 3 Jun 2014 17:14:48 +0000 (17:14 +0000)]
Pepper: Narrow locking at ld subprocess start.

Currently, subprocess_mu_ is held the entire time the ld subprocess is
starting. This blocks a larger refactor that I'd like to make as part of nexe
loading.

I'd like to change ServiceRuntime::LoadModule() to be asynchronous to simplify
threading behavior on the plugin side when loading nexe modules. However, this
requires that many methods are made asynchronous, including
Plugin::LoadHelperNaClModule().

PnaclTranslateThread will need to use a pattern similar to WaitForSelLdrStart()
to resume execution on a background thread. However, I don't like the idea of
introducing another mutex and condvar to deal with while holding
subprocess_mu_.

This change narrows the time that subprocess_mu_ is held to make that refactor
possible. This follows a similar change made for the llc subprocess.

BUG=333950
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/308193004

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@274557 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 weeks agoPepper: Refactor OpenManifestEntry.
teravest@chromium.org [Tue, 3 Jun 2014 15:02:34 +0000 (15:02 +0000)]
Pepper: Refactor OpenManifestEntry.

This change pulls out more OpenManifestEntry code from service_runtime, making
PPB_NaCl_Private a smallter interface, and preparing for pulling all of that
logic out of the trusted plugin.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/302093012

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@274530 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 weeks agoSupport configuring number of audio buffers in MediaStream Pepper API.
thembrown@gmail.com [Tue, 3 Jun 2014 13:36:42 +0000 (13:36 +0000)]
Support configuring number of audio buffers in MediaStream Pepper API.

A optionally larger number of buffers makes recording audio in a pnacl module
more reliable when latency is not an issue.

BUG=330851

Review URL: https://codereview.chromium.org/290993005

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@274511 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 weeks agoChanging default_url to destination_url for consistency
amogh.bihani@samsung.com [Tue, 3 Jun 2014 13:07:38 +0000 (13:07 +0000)]
Changing default_url to destination_url for consistency

At most of the places default_url was changed to destination_url, however, it was missed at some places.
This patch changes the remaining default_url(s) to destination_url.

BUG=378737

Review URL: https://codereview.chromium.org/301933002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@274497 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 weeks agoAdd missing 'break' statements to ppapi::proxy::NaClMessageScanner.
bbudge@chromium.org [Tue, 3 Jun 2014 02:13:22 +0000 (02:13 +0000)]
Add missing 'break' statements to ppapi::proxy::NaClMessageScanner.
Two cases don't have breaks and fall through incorrectly. The first
may be responsible for issue http://crbug.com/370919.

BUG=370919

Review URL: https://codereview.chromium.org/307293002

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@274408 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

7 weeks agoAdd trace events for PPB audio callbacks.
dalecurtis@chromium.org [Tue, 3 Jun 2014 01:05:09 +0000 (01:05 +0000)]
Add trace events for PPB audio callbacks.

BUG=336096
TEST=Play audio.  Run trace.  Observe entries.

Review URL: https://codereview.chromium.org/309483015

git-svn-id: http://src.chromium.org/svn/trunk/src/ppapi@274397 4ff67af0-8c30-449e-8e8b-ad334ec8d88c