chromium/tools/build.git
3 weeks agoRename chromium.webkit Mac Retina bot in recipes. master
dpranke@chromium.org [Wed, 29 Apr 2015 15:52:14 +0000 (15:52 +0000)]
Rename chromium.webkit Mac Retina bot in recipes.

I renamed the bot in the slave and master configs,
but forgot to rename it in the recipe.

We should probably have a test for this somewhere :(.

TBR=stip@chromium.org,iannucci@chromium.org, phajdan.jr@chromium.org
BUG=358412,482234

Review URL: https://codereview.chromium.org/1102353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295062 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd gitpoller directory to blacklist for pylint.
akuegel@chromium.org [Wed, 29 Apr 2015 14:10:18 +0000 (14:10 +0000)]
Add gitpoller directory to blacklist for pylint.

These directories are working directories for
master.client.dynamorio and master.client.drmemory and do not
contain code that is checked-in to tools/build.

BUG=481861

Review URL: https://codereview.chromium.org/1112853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295061 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoClusterfuzz archive: Get zip entry types before zipping.
machenbach@chromium.org [Wed, 29 Apr 2015 13:58:19 +0000 (13:58 +0000)]
Clusterfuzz archive: Get zip entry types before zipping.

BUG=478039
TBR=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1109343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295060 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoSkia: disable link-time code generation on compile bots.
mtklein@chromium.org [Wed, 29 Apr 2015 12:14:26 +0000 (12:14 +0000)]
Skia: disable link-time code generation on compile bots.

The Windows Debug builders are fast (1-2 minutes) but the Release ones are
still slow (10-15 minutes).  Let's see how much of that is bottlenecked on
link-time code generation, something we only do on Windows.  LTCG is only
relevant for our perf bots.  We don't need it on the compile bots (or the test
bots, but let's leave that for a follow up).

BUG=

Review URL: https://codereview.chromium.org/1111263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295059 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoWebRTC: Add more Mac and Windows VMs to tryserver.webrtc (fix)
kjellander@chromium.org [Wed, 29 Apr 2015 12:07:26 +0000 (12:07 +0000)]
WebRTC: Add more Mac and Windows VMs to tryserver.webrtc (fix)

In https://codereview.chromium.org/1115593002 I swapped
the Windows and Mac machines. This sets the right bot at
the right place.

List from the bug:
Windows:
vm363-m4
vm407-m4
vm495-m4

Mac:
vm510-m4
vm511-m4
vm512-m4

BUG=480845

Review URL: https://codereview.chromium.org/1111253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295058 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd a third slave to the presubmit pool.
akuegel@chromium.org [Wed, 29 Apr 2015 11:18:37 +0000 (11:18 +0000)]
Add a third slave to the presubmit pool.

BUG=482186

Review URL: https://codereview.chromium.org/1114863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295057 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRecipes: make cwd default to slave_build
phajdan.jr@chromium.org [Wed, 29 Apr 2015 10:19:28 +0000 (10:19 +0000)]
Recipes: make cwd default to slave_build

This is a step towards running recipes on swarming.

BUG=437264

Review URL: https://codereview.chromium.org/1115453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295056 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdded build to the list of solutions for build_internal
sergiyb@chromium.org [Wed, 29 Apr 2015 08:41:59 +0000 (08:41 +0000)]
Added build to the list of solutions for build_internal

This is needed since running build_internal presubmit on a slave requires file
build/scripts/common/env.py to be present and we can't use DEPS to checkout
build on a slave.

R=agable@chromium.org, pgervais@chromium.org, phajdan.jr@chromium.org
BUG=480694

Review URL: https://codereview.chromium.org/1112633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295055 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoWebRTC: Add more Mac and Windows VMs to tryserver.webrtc
kjellander@chromium.org [Wed, 29 Apr 2015 07:11:01 +0000 (07:11 +0000)]
WebRTC: Add more Mac and Windows VMs to tryserver.webrtc

BUG=480845
TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/1115593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295054 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoCheck token expiration more aggressively
nodir@chromium.org [Wed, 29 Apr 2015 05:40:07 +0000 (05:40 +0000)]
Check token expiration more aggressively

https://codereview.chromium.org/1091593002/ did not achieve desired
results: a token is refreshed too late, buildbucket log still has
warning entries with "Invalid credentials" message.

This CL refreshes token in advance to prevent warning entries.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1112023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295053 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoFix returns_placeholder to prevent it from getting wrapped as a composite_step.
iannucci@chromium.org [Tue, 28 Apr 2015 23:42:08 +0000 (23:42 +0000)]
Fix returns_placeholder to prevent it from getting wrapped as a composite_step.

R=luqui@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1111093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295050 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdjust column widths in the buildbot waterfall for tryserver.chromium.linux.
dpranke@chromium.org [Tue, 28 Apr 2015 23:21:38 +0000 (23:21 +0000)]
Adjust column widths in the buildbot waterfall for tryserver.chromium.linux.

This should allow the builder names to actually be legible.

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1104363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295048 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRename WebKit Mac10.8 (retina) bot -> 10.9.
dpranke@chromium.org [Tue, 28 Apr 2015 23:07:40 +0000 (23:07 +0000)]
Rename WebKit Mac10.8 (retina) bot -> 10.9.

R=iannucci@chromium.org
BUG=358412

Review URL: https://codereview.chromium.org/1101943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295047 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoLarge profile generator recipe should use parent_build_archive_url.
erikchen@chromium.org [Tue, 28 Apr 2015 22:50:49 +0000 (22:50 +0000)]
Large profile generator recipe should use parent_build_archive_url.

Previously, the recipe was trying to construct the url by using the builder
name, which is much more fragile.

BUG=

Review URL: https://codereview.chromium.org/1108403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295046 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agodeferred_resource: improved retries
nodir@chromium.org [Tue, 28 Apr 2015 21:41:11 +0000 (21:41 +0000)]
deferred_resource: improved retries

Move retries out of the thread pool, so other requests don't wait for
one stuck request to be retried

R=vadimsh@chromium.org
BUG=480704

Review URL: https://codereview.chromium.org/1108943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295045 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agobuildbucket: requester property
nodir@chromium.org [Tue, 28 Apr 2015 21:36:53 +0000 (21:36 +0000)]
buildbucket: requester property

Buildbucket-Buildbot integration copies an email address from created_by
build attribute to requester build property. created_attribute is
verified by buildbucket to be valid and so can be trusted, whereas
requester property is not

Blocked on https://chromereviews.googleplex.com/183177013/

BUG=

Review URL: https://codereview.chromium.org/1081253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295044 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoMove upstream AMP CQ experimental bots to a4 bots.
navabi@google.com [Tue, 28 Apr 2015 21:26:21 +0000 (21:26 +0000)]
Move upstream AMP CQ experimental bots to a4 bots.

BUG=477423

Review URL: https://codereview.chromium.org/1108223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295043 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRefactor chromium_perf_fyi.py and add config for nexus 9.
simonhatch@chromium.org [Tue, 28 Apr 2015 21:03:57 +0000 (21:03 +0000)]
Refactor chromium_perf_fyi.py and add config for nexus 9.

The new Nexus 9 bot was failing to run src-side scripts properly on the FYI waterfall since there was no config defined (which get_common_args_for_scripts() uses to pull perf-id and results-url from). This CL refactors chromium_perf_fyi a bit so we don't have to specify them manually in SPEC, and adds a config for the nexus 9.

BUG=475991

Review URL: https://codereview.chromium.org/1099423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295042 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRun mojo_runner_unittests on Chromium Mojo FYI waterfall.
msw@chromium.org [Tue, 28 Apr 2015 20:21:57 +0000 (20:21 +0000)]
Run mojo_runner_unittests on Chromium Mojo FYI waterfall.

New tests suite added in: https://codereview.chromium.org/1091513005
Add the step and update the expectations:
  scripts/slave/unittests/recipe_simulation_test.py train
See the waterfall: http://build.chromium.org/p/chromium.mojo/console

BUG=NONE
TEST=Chromium Mojo FYI waterfall passes mojo_runner_unittests.
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1110593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295041 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoMade simulation tests detect superfluous expectation files.
luqui@chromium.org [Tue, 28 Apr 2015 19:20:35 +0000 (19:20 +0000)]
Made simulation tests detect superfluous expectation files.

BUG=478992

Review URL: https://codereview.chromium.org/1056343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295040 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoSet Mac 10.6 builder in master.chromium.chromedriver to auto reboot
pschmidt@google.com [Tue, 28 Apr 2015 19:03:41 +0000 (19:03 +0000)]
Set Mac 10.6 builder in chromium.chromedriver to auto reboot

BUG=442419

Review URL: https://codereview.chromium.org/1021283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295039 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks ago[Android] Make the N9 perf bot use arm64.
jbudorick@chromium.org [Tue, 28 Apr 2015 18:24:28 +0000 (18:24 +0000)]
[Android] Make the N9 perf bot use arm64.

BUG=475990
R=luqui@chromium.org

Review URL: https://codereview.chromium.org/1108893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295038 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoSupport 'runtest.py --test-platform android' via api.chromium.runtest.
msw@chromium.org [Tue, 28 Apr 2015 18:05:37 +0000 (18:05 +0000)]
Support 'runtest.py --test-platform android' via api.chromium.runtest.

Parallels ios change: https://codereview.chromium.org/355653003
Retrain: scripts/slave/unittests/recipe_simulation_test.py train
Bot: http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android

BUG=466129
TEST=Chromium Mojo Android bot starts running tests correctly.
R=dpranke@chromium.org,navabi@chromium.org

Review URL: https://codereview.chromium.org/1081383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295037 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd OWNERS for critical CQ recipe infrastructure
phajdan.jr@chromium.org [Tue, 28 Apr 2015 17:58:38 +0000 (17:58 +0000)]
Add OWNERS for critical CQ recipe infrastructure

Please see https://goto.google.com/vpegg for context (Googlers only).

BUG=none

Review URL: https://codereview.chromium.org/1112523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295036 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoFix infra/publish_tarball so that export_tarball.py can find src directory
phajdan.jr@chromium.org [Tue, 28 Apr 2015 17:55:52 +0000 (17:55 +0000)]
Fix infra/publish_tarball so that export_tarball.py can find src directory

BUG=433338

Review URL: https://codereview.chromium.org/1112563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295035 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd mock package testing to the package waterfall
ricow@google.com [Tue, 28 Apr 2015 17:51:31 +0000 (17:51 +0000)]
Add mock package testing to the package waterfall

R=kevmoo@google.com, whesse@google.com
TBR=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/1113673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295034 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoClean up most indirect recipe configs in chromium_tests module
phajdan.jr@chromium.org [Tue, 28 Apr 2015 16:11:12 +0000 (16:11 +0000)]
Clean up most indirect recipe configs in chromium_tests module

BUG=none

Review URL: https://codereview.chromium.org/1110973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295033 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd remoting unit-tests to Android Remoting Builder. Rename existing test to Chromoti...
anandc@chromium.org [Tue, 28 Apr 2015 15:51:09 +0000 (15:51 +0000)]
Add remoting unit-tests to Android Remoting Builder. Rename existing test to ChromotingInstrumentationTests.

BUG=341964

Review URL: https://codereview.chromium.org/1111443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295032 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd linux_arm_compile builder to list of CQ bots
sbc@chromium.org [Tue, 28 Apr 2015 15:38:39 +0000 (15:38 +0000)]
Add linux_arm_compile builder to list of CQ bots

This will add the builder to most slaves which should
allow us to move this bot from 10% experiment to full
CQ bot: https://codereview.chromium.org/1088343002/

BUG=384104

Review URL: https://codereview.chromium.org/953303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295031 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks ago[Android] Enable ContentShellTests on the Appurify FYI bot.
jbudorick@chromium.org [Tue, 28 Apr 2015 15:12:59 +0000 (15:12 +0000)]
[Android] Enable ContentShellTests on the Appurify FYI bot.

BUG=448629
R=luqui@chromium.org

Review URL: https://codereview.chromium.org/1106383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295030 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoEnable tree closures from chromium.infra waterfall.
tandrii@chromium.org [Tue, 28 Apr 2015 15:05:49 +0000 (15:05 +0000)]
Enable tree closures from chromium.infra waterfall.

Let chromium gnumbd builder failure close chromium tree.
Let continious builders of infra close infra tree.

BUG=479735
R=stip@chromium.org

Review URL: https://codereview.chromium.org/1100143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295029 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoDisplay infra-status app at chromium.infra .
tandrii@google.com [Tue, 28 Apr 2015 14:54:05 +0000 (14:54 +0000)]
Display infra-status app at chromium.infra .

R=phajdan.jr@chromium.org
BUG=479735

Review URL: https://codereview.chromium.org/1102303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295028 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAllow for custom favicon in waterfalls.
tandrii@google.com [Tue, 28 Apr 2015 14:24:34 +0000 (14:24 +0000)]
Allow for custom favicon in waterfalls.

R=sergiyb@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1108763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295027 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd a second slave to the presubmit pool.
akuegel@chromium.org [Tue, 28 Apr 2015 13:27:22 +0000 (13:27 +0000)]
Add a second slave to the presubmit pool.

BUG=420910

Review URL: https://codereview.chromium.org/1111763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295026 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoFix package_index_test.
akuegel@chromium.org [Tue, 28 Apr 2015 13:24:46 +0000 (13:24 +0000)]
Fix package_index_test.

This test relied on a certain gcc version being installed on the bot.
This CL should make it only dependent on having the stdio.h system header.

BUG=481861

Review URL: https://codereview.chromium.org/1110833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295025 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoV8 Buildbot: Fix dart mac builders.
machenbach@chromium.org [Tue, 28 Apr 2015 12:11:04 +0000 (12:11 +0000)]
V8 Buildbot: Fix dart mac builders.

TBR=Rico, kustermann@chromium.org

Review URL: https://codereview.chromium.org/1107353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295024 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRevert of Reland V8 Buildbot: Migrate asan symbolized bot to recipes. (patchset ...
machenbach@chromium.org [Tue, 28 Apr 2015 08:29:50 +0000 (08:29 +0000)]
Revert of Reland V8 Buildbot: Migrate asan symbolized bot to recipes. (patchset #3 id:60001 of https://codereview.chromium.org/1102353002/)

Reason for revert:
Next gotcha: The recipe zip module doesn't zip recursively like the legacy one did. Apparently, the files to zip need to be gathered first and then handed to the zip module. Will reland as soon as the recipe is repaired again...

Original issue's description:
> Reland V8 Buildbot: Migrate asan symbolized bot to recipes.
>
> TBR=phajdan.jr@chromium.org,tandrii@chromium.org,kjellander@chromium.org
> BUG=315202
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295022

TBR=phajdan.jr@chromium.org,tandrii@chromium.org,kjellander@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=315202

Review URL: https://codereview.chromium.org/1113483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295023 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoReland V8 Buildbot: Migrate asan symbolized bot to recipes.
machenbach@chromium.org [Tue, 28 Apr 2015 07:21:10 +0000 (07:21 +0000)]
Reland V8 Buildbot: Migrate asan symbolized bot to recipes.

TBR=phajdan.jr@chromium.org,tandrii@chromium.org,kjellander@chromium.org
BUG=315202

Review URL: https://codereview.chromium.org/1102353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295022 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoWebRTC: Add more Linux VMs to tryserver.webrtc
kjellander@chromium.org [Tue, 28 Apr 2015 07:21:05 +0000 (07:21 +0000)]
WebRTC: Add more Linux VMs to tryserver.webrtc

BUG=480845
TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/1110883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295021 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agochromium_trybot recipe had MSan and ChromeOS MSan mixed up.
luqui@chromium.org [Tue, 28 Apr 2015 05:51:32 +0000 (05:51 +0000)]
chromium_trybot recipe had MSan and ChromeOS MSan mixed up.

R=phajdan.jr@chromium.org
CC=earthdok@chromium.org

Review URL: https://codereview.chromium.org/1103773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295020 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agomaking GOMA_DISABLED work on Windows.
yyanagisawa@chromium.org [Tue, 28 Apr 2015 02:20:31 +0000 (02:20 +0000)]
making GOMA_DISABLED work on Windows.

Since Windows ninja use an environment written in
environment.{x86,x64} at compile time, any environment
updates in compile.py are ignored.  It means that even if
GOMA_DISABLED=yes is set in compile.py, gomacc does not
stop using goma.

This change reflects environment update in compile.py to
environmnet.{x86,x64} files.

Our previous attempt was executing "gclient runhook" on
environment change, which did not work well because compile.py does not have GYP_DEFINES.
For example, use_goma=1 set in gclient step vanishes after
"gclient runhook" in compile.py.
https://codereview.chromium.org/1032273002/

Minor change:
- fixed pylint warnings.

Review URL: https://codereview.chromium.org/1044013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295019 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRevert of Enable goma for all NaCl builds (retry). (patchset #1 id:1 of https://coder...
shinyak@chromium.org [Tue, 28 Apr 2015 02:10:43 +0000 (02:10 +0000)]
Revert of Enable goma for all NaCl builds (retry). (patchset #1 id:1 of https://codereview.chromium.org/1093773003/)

Reason for revert:
causes build error.

Original issue's description:
> Enable goma for all NaCl builds (retry).
>
> This is the 3rd revival of r294339. The reason of failure is that
> archive contains 0 byte object file, so LINK fails.
> We thought that object file was not created correctly when archiving.
> However, it was not. All object files were not 0 byte. Then, maybe
> archiver couldn't read object file in some reason.
>
> We have added a new check in archiving process in NaCl build. We check
> the content of archive, and if it contains 0 byte object, we
> regenerate archive again (at most 3 times). I've confirmed that the
> archiver can create valid archive from the object files that produced
> invalid archive. So, I believe the problem is a kind of archiver flake,
> and I hope we have workaround in nativeclient revision 10a72113.
>
> BUG=390764
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294999

TBR=thakis@chromium.org,ukai@chromium.org,yyanagisawa@chromium.org,phajdan.jr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=390764

Review URL: https://codereview.chromium.org/1110033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295018 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoHook up large profile generators to master.chromium.perf.fyi.
erikchen@chromium.org [Tue, 28 Apr 2015 00:10:27 +0000 (00:10 +0000)]
Hook up large profile generators to chromium.perf.fyi.

BUG=472711

Review URL: https://codereview.chromium.org/1109983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295017 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoChange the build step text from 'mb gen' to 'Generate build files'.
dpranke@chromium.org [Mon, 27 Apr 2015 23:50:35 +0000 (23:50 +0000)]
Change the build step text from 'mb gen' to 'Generate build files'.

This patch changes the step text for the 'mb gen' step
(api.run_mb in the chromium module) from 'mb gen' to 'Generate build
files', which is way more intelligible.

TBR=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1110603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295016 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRefresh access token before making request
nodir@chromium.org [Mon, 27 Apr 2015 23:09:13 +0000 (23:09 +0000)]
Refresh access token before making request

DeferredResource used to refresh token only when it received 403 for the
first time. This causes warning events in the buildbucket log.

This CL refreshes access token to prevent this.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1091593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295015 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd Cmake to the path for run_slave.py
hinoka@chromium.org [Mon, 27 Apr 2015 22:40:58 +0000 (22:40 +0000)]
Add Cmake to the path for run_slave.py

BUG=303794

Review URL: https://codereview.chromium.org/1105833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295014 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoUpdate the contact email for gsubtreed-mojo builder.
ppi@chromium.org [Mon, 27 Apr 2015 17:48:48 +0000 (17:48 +0000)]
Update the contact email for gsubtreed-mojo builder.

mojo-sdk-mirror-team@google.com becomes mojo-mirror-infra@google.com.

Review URL: https://codereview.chromium.org/1104173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295013 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoV8 Buildbot: Add benchmarks to release trybot.
machenbach@chromium.org [Mon, 27 Apr 2015 17:04:12 +0000 (17:04 +0000)]
V8 Buildbot: Add benchmarks to release trybot.

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1107083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295012 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoFixed event monitoring in status_logger
pgervais@chromium.org [Mon, 27 Apr 2015 16:14:12 +0000 (16:14 +0000)]
Fixed event monitoring in status_logger

BUG=473796

Review URL: https://codereview.chromium.org/1103853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295011 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdded build_internal config for run_presubmit
sergiyb@google.com [Mon, 27 Apr 2015 15:27:23 +0000 (15:27 +0000)]
Added build_internal config for run_presubmit

R=akuegel@google.com
BUG=480694

Review URL: https://codereview.chromium.org/1105173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295010 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoV8 Buildbot: Switch slaves to speed up msan bot.
machenbach@chromium.org [Mon, 27 Apr 2015 15:15:03 +0000 (15:15 +0000)]
V8 Buildbot: Switch slaves to speed up msan bot.

BUG=425187
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1106983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295009 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd a notifier for Codesearch bots.
akuegel@chromium.org [Mon, 27 Apr 2015 14:55:04 +0000 (14:55 +0000)]
Add a notifier for Codesearch bots.

BUG=

Review URL: https://codereview.chromium.org/1110593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295008 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoEnable bot_update for master.chromium.infra.cron.
akuegel@chromium.org [Mon, 27 Apr 2015 14:35:50 +0000 (14:35 +0000)]
Enable bot_update for master.chromium.infra.cron.

BUG=473210

Review URL: https://codereview.chromium.org/1105153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295006 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoSeparate infra presubmit into a separate builder
sergiyb@google.com [Mon, 27 Apr 2015 13:40:42 +0000 (13:40 +0000)]
Separate infra presubmit into a separate builder

R=phajdan@chromium.org
BUG=478651

Review URL: https://codereview.chromium.org/1104083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295005 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoV8 Buildbot: Switch msan bot to ninja.
machenbach@chromium.org [Mon, 27 Apr 2015 13:18:17 +0000 (13:18 +0000)]
V8 Buildbot: Switch msan bot to ninja.

BUG=425187
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1104143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295004 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRefactoring: Extract static archive configurations.
machenbach@chromium.org [Mon, 27 Apr 2015 09:23:08 +0000 (09:23 +0000)]
Refactoring: Extract static archive configurations.

Define constant top-level sets for excluded files instead
of local lists. The sets are only used for inclusion
checks, hence, no non-determinism problems.

The old comments and todos are kept as they were.

Tiny behavioral change: Instead of a not-implemented
exception, we'd see a KeyError if a file exclusion config
for an unsupported platform was used.

BUG=478039

Review URL: https://codereview.chromium.org/1093413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295002 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoV8 Buildbot: Disable snapshot for stand-alone msan bot.
machenbach@chromium.org [Mon, 27 Apr 2015 09:19:28 +0000 (09:19 +0000)]
V8 Buildbot: Disable snapshot for stand-alone msan bot.

This prepares for switching on a working msan config on the
v8-side (currently only works without snapshot).

Tree closing is temporarily disabled until the bot is stable
again.

BUG=425187
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/1107833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295001 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd a separate builder for running presubmits.
akuegel@chromium.org [Mon, 27 Apr 2015 09:10:11 +0000 (09:10 +0000)]
Add a separate builder for running presubmits.

Presubmits cycle fast, and developers probably expect a fast
turn-around for those. Therefore they should not be served
from the big pool of slaves which might be busy processing
longer-running tests.
Also remove unused variable (pylint complained about it).

BUG=420910

Review URL: https://codereview.chromium.org/1063063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@295000 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoEnable goma for all NaCl builds (retry).
shinyak@chromium.org [Mon, 27 Apr 2015 03:52:49 +0000 (03:52 +0000)]
Enable goma for all NaCl builds (retry).

This is the 3rd revival of r294339. The reason of failure is that
archive contains 0 byte object file, so LINK fails.
We thought that object file was not created correctly when archiving.
However, it was not. All object files were not 0 byte. Then, maybe
archiver couldn't read object file in some reason.

We have added a new check in archiving process in NaCl build. We check
the content of archive, and if it contains 0 byte object, we
regenerate archive again (at most 3 times). I've confirmed that the
archiver can create valid archive from the object files that produced
invalid archive. So, I believe the problem is a kind of archiver flake,
and I hope we have workaround in nativeclient revision 10a72113.

BUG=390764

Review URL: https://codereview.chromium.org/1093773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294999 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoUpdate chromium_gn recipes to handle the win x64 trybots.
dpranke@chromium.org [Sat, 25 Apr 2015 17:21:09 +0000 (17:21 +0000)]
Update chromium_gn recipes to handle the win x64 trybots.

TBR=phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1108513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294997 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoExtract functions from path recipe module so that step can depend on it
phajdan.jr@chromium.org [Sat, 25 Apr 2015 01:53:56 +0000 (01:53 +0000)]
Extract functions from path recipe module so that step can depend on it

This will be needed to run recipes on swarming - step will default
cwd to slave_build path.

BUG=437264

Review URL: https://codereview.chromium.org/1101673005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294996 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd mac continuous builder to infra waterfall.
agable@chromium.org [Sat, 25 Apr 2015 00:16:18 +0000 (00:16 +0000)]
Add mac continuous builder to infra waterfall.

R=iannucci@chromium.org
BUG=477486

Review URL: https://codereview.chromium.org/1094153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294995 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agomaster.chromium.infra: don't merge publish_tarball build requests (attempt #2)
phajdan.jr@chromium.org [Fri, 24 Apr 2015 23:57:23 +0000 (23:57 +0000)]
chromium.infra: don't merge publish_tarball build requests (attempt #2)

See earlier https://codereview.chromium.org/1050153003 for context.

BUG=433338

Review URL: https://codereview.chromium.org/1103773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294994 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAfter https://codereview.chromium.org/1092083002 was reverted due to test failures...
sullivan@google.com [Fri, 24 Apr 2015 22:52:14 +0000 (22:52 +0000)]
After https://codereview.chromium.org/1092083002 was reverted due to test failures, reland changes which removed unnecessary FYI bots.

BUG=477399

Review URL: https://codereview.chromium.org/1106823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294993 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoHook up 'sizes.py' to work with recipie-based buildbots and use it for the Win Clang...
hans@chromium.org [Fri, 24 Apr 2015 22:13:53 +0000 (22:13 +0000)]
Hook up 'sizes.py' to work with recipie-based buildbots and use it for the Win Clang perf builder

BUG=451078

Review URL: https://codereview.chromium.org/1056653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294992 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoLift cf_archive_script into recipe module.
machenbach@chromium.org [Fri, 24 Apr 2015 21:37:58 +0000 (21:37 +0000)]
Lift cf_archive_script into recipe module.

This migrates the contents of the legacy script
cf_archive_script.py into the archive recipe module.

This is the first migration step with a focus on preserving
the old behavior (mostly) and on easy review (by keeping
the old code structure).

In a follow up CL this code should be refactored and
cleaned up.

BUG=478039

Review URL: https://codereview.chromium.org/1091263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294991 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoSwap slaves of lkgr-tag-pusher and publish_tarball on chromium.infra.cron waterfall.
tandrii@chromium.org [Fri, 24 Apr 2015 21:06:29 +0000 (21:06 +0000)]
Swap slaves of lkgr-tag-pusher and publish_tarball on chromium.infra.cron waterfall.

BUG=
R=friedman@chromium.org,agable@chromium.org

Review URL: https://codereview.chromium.org/1107733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294990 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRevert of Remove outdated telemetry tests from build configurations. This also involv...
sullivan@chromium.org [Fri, 24 Apr 2015 20:12:36 +0000 (20:12 +0000)]
Revert of Remove outdated telemetry tests from build configurations. This also involved moving Mac Perf Testeā€¦ (patchset #2 id:20001 of https://codereview.chromium.org/1092083002/)

Reason for revert:
Broke internal tests (see crbug.com/480685)

Original issue's description:
> Remove outdated telemetry tests from build configurations. This also involved moving Mac Perf Tester and Memory tester from FYI waterfall. These are both replaced by bots on chromium.perf waterfall.
>
> BUG=477399
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294879

TBR=stip@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=477399

Review URL: https://codereview.chromium.org/1109453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294989 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoSplit chromium.infra waterfall into continious and cron.
tandrii@chromium.org [Fri, 24 Apr 2015 19:44:38 +0000 (19:44 +0000)]
Split chromium.infra waterfall into continious and cron.

Create new master.chromium.infra.cron and move gnumbd*, codesearch*,
and other periodic infra builders to it.
master.chromium.infra now contains only continious builders,
which will close only infra tree.

This also buys us time to revive sections in gatekeeper,
see https://codereview.chromium.org/1100143002/#msg3 .

BUG=473210
R=stip@chromium.org,agable@chromium.org

Review URL: https://codereview.chromium.org/1101743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294988 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoinfra/publish_tarball: move export_tarball.py to recipes
phajdan.jr@chromium.org [Fri, 24 Apr 2015 19:11:12 +0000 (19:11 +0000)]
infra/publish_tarball: move export_tarball.py to recipes

BUG=433338

Review URL: https://codereview.chromium.org/1100783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294987 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoFix android_blink_compile_dbg to build into //out/Debug.
dpranke@chromium.org [Fri, 24 Apr 2015 18:29:47 +0000 (18:29 +0000)]
Fix android_blink_compile_dbg to build into //out/Debug.

TBR=phajdan.jr@chromium.org
BUG=479509

Review URL: https://codereview.chromium.org/1075143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294986 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoFix blink_android_trybot debug config by flipping it to MB.
dpranke@chromium.org [Fri, 24 Apr 2015 18:07:06 +0000 (18:07 +0000)]
Fix blink_android_trybot debug config by flipping it to MB.

The android_blink_compile_dbg bot was actually doing a release build.
This CL fixes that, and also fixes it by flipping both boths
that use this recipe to use MB to generate the build files, rather
than calling gyp directly during runhooks.

R=phajdan.jr@chromium.org
BUG=479509

Review URL: https://codereview.chromium.org/1061983005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294985 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoestimate_capacity.py: print more details about each build
phajdan.jr@chromium.org [Fri, 24 Apr 2015 17:56:45 +0000 (17:56 +0000)]
estimate_capacity.py: print more details about each build

BUG=431479

Review URL: https://codereview.chromium.org/1084433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294984 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoUpdate recipes.isolate to work with chromium_trybot recipe
phajdan.jr@chromium.org [Fri, 24 Apr 2015 17:56:38 +0000 (17:56 +0000)]
Update recipes.isolate to work with chromium_trybot recipe

BUG=437264

Review URL: https://codereview.chromium.org/1106693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294983 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoruntest.py: don't crash on SlaveBuildName
phajdan.jr@chromium.org [Fri, 24 Apr 2015 17:49:56 +0000 (17:49 +0000)]
runtest.py: don't crash on SlaveBuildName

BUG=437264

Review URL: https://codereview.chromium.org/1108443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294982 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd ability to run MB with a custom config file to api.chromium.
dpranke@chromium.org [Fri, 24 Apr 2015 17:39:16 +0000 (17:39 +0000)]
Add ability to run MB with a custom config file to api.chromium.

For private repos, we need the ability to point MB
at a custom config file, rather than using the one
in the Chromium repo.

R=phajdan.jr@chromium.org, luqui@chromium.org
BUG=480618

Review URL: https://codereview.chromium.org/1087483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294981 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoWe need toolbox too.
ngeoffray@google.com [Fri, 24 Apr 2015 14:49:17 +0000 (14:49 +0000)]
We need toolbox too.

Review URL: https://codereview.chromium.org/1096713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294980 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoxvfb: set dpi to 96 (xvfb defaults to 100).
stapelberg@google.com [Fri, 24 Apr 2015 14:26:08 +0000 (14:26 +0000)]
xvfb: set dpi to 96 (xvfb defaults to 100).

Tests assume that the DPI is effectively 96. Up until recently, this was
the case because chromium only supported 100% (corresponding to 96 dpi)
or 200% (corresponding to 192 dpi) scaling in its UI.

With https://codereview.chromium.org/1078423002/, we want to change that
to better reflect the hardware that many people have today. Applying
that CL without also changing the DPI results in tests failing because
of off-by-a-few-pixel errors.

BUG=477716,143619

Review URL: https://codereview.chromium.org/1105903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294979 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoSkia: stop running nanobench on debug-mode test bots
borenet@google.com [Fri, 24 Apr 2015 13:38:55 +0000 (13:38 +0000)]
Skia: stop running nanobench on debug-mode test bots

BUG=

Review URL: https://codereview.chromium.org/1108433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294978 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoWebRTC: Add trybots for Android testers with Samsung S{3,4,5} devices.
kjellander@chromium.org [Fri, 24 Apr 2015 13:14:26 +0000 (13:14 +0000)]
WebRTC: Add trybots for Android testers with Samsung S{3,4,5} devices.

Having trybots will make it easier to try fixes for the currently
failing tests for the buildbots that are currently running in the
client.webrtc.fyi waterfall.

BUG=458018

Review URL: https://codereview.chromium.org/1101113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294977 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRevert of Re^3land of 'Make subannotations more robust' (patchset #5 id:80001 of...
kjellander@chromium.org [Fri, 24 Apr 2015 12:08:30 +0000 (12:08 +0000)]
Revert of Re^3land of 'Make subannotations more robust' (patchset #5 id:80001 of https://codereview.chromium.org/1080283003/)

Reason for revert:
This breaks our Windows perf bot exactly as last time I reverted this (in https://codereview.chromium.org/1072823002).

Build failures:
http://build.chromium.org/p/client.webrtc/builders/Win32%20Release%20%5Blarge%20tests%5D/builds/4210
http://build.chromium.org/p/client.webrtc/builders/Win32%20Release%20%5Blarge%20tests%5D/builds/4211
http://build.chromium.org/p/client.webrtc/builders/Win32%20Release%20%5Blarge%20tests%5D/builds/4212
http://build.chromium.org/p/client.webrtc/builders/Win32%20Release%20%5Blarge%20tests%5D/builds/4213

Please at least monitor that bot for the next re-land. I'd be interested in knowing what's causing this and if we're doing something wrong. AFAIK there are no hacks involved in that bot's perf setup (except that it's Windows, which always is tricky).

Original issue's description:
> Re^3land of 'Make subannotations more robust'
>
> Re^0land: https://codereview.chromium.org/1001183002/
> Re^1land: https://codereview.chromium.org/1076643002/
> Re^2land: https://chromiumcodereview.appspot.com/1075053002/
>
> This patch makes the recipe engine parse and re-emit subannotations when allow_subannotations is True.  This means that any of the subannotator's steps which are duplicates of other steps executed will be disambiguated.  When an allow_subannotations step is actually emits annotations, an (end) step is emitted after it is done to have something to hang metadata on (it also conveniently communicates when we re-enter recipes).
>
> BUG=466409
> TBR=iannucci@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294973

TBR=iannucci@chromium.org,luqui@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466409

Review URL: https://codereview.chromium.org/1108573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294976 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd toybox to the list of things to build.
ngeoffray@google.com [Fri, 24 Apr 2015 11:49:35 +0000 (11:49 +0000)]
Add toybox to the list of things to build.

Review URL: https://codereview.chromium.org/1059303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294975 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoMake stable builder pull from 1.10
ricow@google.com [Fri, 24 Apr 2015 08:23:54 +0000 (08:23 +0000)]
Make stable builder pull from 1.10

R=kasperl@google.com
BUG=

Review URL: https://codereview.chromium.org/1107673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294974 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRe^3land of 'Make subannotations more robust'
luqui@chromium.org [Fri, 24 Apr 2015 00:20:56 +0000 (00:20 +0000)]
Re^3land of 'Make subannotations more robust'

Re^0land: https://codereview.chromium.org/1001183002/
Re^1land: https://codereview.chromium.org/1076643002/
Re^2land: https://chromiumcodereview.appspot.com/1075053002/

This patch makes the recipe engine parse and re-emit subannotations when allow_subannotations is True.  This means that any of the subannotator's steps which are duplicates of other steps executed will be disambiguated.  When an allow_subannotations step is actually emits annotations, an (end) step is emitted after it is done to have something to hang metadata on (it also conveniently communicates when we re-enter recipes).

BUG=466409
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/1080283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294973 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoMake Chromium Mojo Android bot use android gclient_apply_config.
msw@chromium.org [Fri, 24 Apr 2015 00:14:16 +0000 (00:14 +0000)]
Make Chromium Mojo Android bot use android gclient_apply_config.

Apply android gclient config and arm TARGET_ARCH.
Update a comment.

Retrain the expectations:
  scripts/slave/unittests/recipe_simulation_test.py train

Hopefully the bot now passes the gn step:
  http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android

BUG=466129
TEST=Bot passes gn step?
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1093183005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294972 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoHandling test failure and some output enhancements.
robertocn@chromium.org [Fri, 24 Apr 2015 00:09:38 +0000 (00:09 +0000)]
Handling test failure and some output enhancements.

R=qyearsley@chromium.org,prasadv@chromium.org

Review URL: https://codereview.chromium.org/1086923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294971 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRevert of master.chromium.infra: don't merge publish_tarball build requests (patchset...
phajdan.jr@chromium.org [Thu, 23 Apr 2015 23:44:45 +0000 (23:44 +0000)]
Revert of chromium.infra: don't merge publish_tarball build requests (patchset #1 id:1 of https://codereview.chromium.org/1095793005/)

Reason for revert:
2015-04-23 16:43:20-0700 [-] in maybeStartBuild for <Builder ''gnumbd'' at 62342640>
        Traceback (most recent call last):
          File "/home/chrome-bot/buildbot/build/third_party/buildbot_8_4p1/buildbot/process/builder.py", line 729, in maybeStartBuild
            mergeRequests_fn))
          File "/home/chrome-bot/buildbot/build/third_party/twisted_10_2/twisted/internet/defer.py", line 964, in unwindGenerator
            return _deferGenerator(f(*args, **kwargs), Deferred())
          File "/home/chrome-bot/buildbot/build/third_party/twisted_10_2/twisted/internet/defer.py", line 866, in _deferGenerator
            result = g.next()
          File "/home/chrome-bot/buildbot/build/third_party/buildbot_8_4p1/buildbot/process/builder.py", line 860, in _mergeRequests
            defer.maybeDeferred(lambda :
        --- <exception caught here> ---
          File "/home/chrome-bot/buildbot/build/third_party/twisted_10_2/twisted/internet/defer.py", line 133, in maybeDeferred
            result = f(*args, **kw)
          File "/home/chrome-bot/buildbot/build/third_party/buildbot_8_4p1/buildbot/process/builder.py", line 861, in <lambda>
            mergeRequests_fn(breq_object, other_breq_object)))
        exceptions.TypeError: mergeRequests() takes exactly 3 arguments (2 given)

Original issue's description:
> master.chromium.infra: don't merge publish_tarball build requests
>
> See earlier https://codereview.chromium.org/1050153003 for context.
>
> BUG=433338
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294968

TBR=agable@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=433338

Review URL: https://codereview.chromium.org/1080593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294970 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoDo not try to strip the GN binary on windows.
dpranke@chromium.org [Thu, 23 Apr 2015 22:53:28 +0000 (22:53 +0000)]
Do not try to strip the GN binary on windows.

TBR=tfarina@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1106673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294969 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agomaster.chromium.infra: don't merge publish_tarball build requests
phajdan.jr@chromium.org [Thu, 23 Apr 2015 22:39:44 +0000 (22:39 +0000)]
chromium.infra: don't merge publish_tarball build requests

See earlier https://codereview.chromium.org/1050153003 for context.

BUG=433338

Review URL: https://codereview.chromium.org/1095793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294968 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd notification on failure for Remoting Android tests.
anandc@chromium.org [Thu, 23 Apr 2015 19:56:30 +0000 (19:56 +0000)]
Add notification on failure for Remoting Android tests.

BUG=341964

Review URL: https://codereview.chromium.org/1084433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294967 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoReplace build{76..79}-a1 with build{106..109}-m1 in master.chromium.gpu.fyi
pschmidt@google.com [Thu, 23 Apr 2015 19:05:37 +0000 (19:05 +0000)]
Replace build{76..79}-a1 with build{106..109}-m1 in chromium.gpu.fyi

BUG=479938

Review URL: https://codereview.chromium.org/1100943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294966 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd Android Remoting tests to triggerable scheduler.
anandc@chromium.org [Thu, 23 Apr 2015 18:50:20 +0000 (18:50 +0000)]
Add Android Remoting tests to triggerable scheduler.

This CL: https://codereview.chromium.org/1094193003/ that kills android/tester.py, removes the new builder for Remoting tests from the trigger-able scheduler. I missed that during its review, and would like to add it back.

BUG=341964

Review URL: https://codereview.chromium.org/1060503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294965 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd support for retries without patch to ios trybot recipe
phajdan.jr@chromium.org [Thu, 23 Apr 2015 18:05:24 +0000 (18:05 +0000)]
Add support for retries without patch to ios trybot recipe

BUG=none

Review URL: https://codereview.chromium.org/1083243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294964 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoWebRTC: Remove video_capture_tests on Android.
kjellander@chromium.org [Thu, 23 Apr 2015 17:43:39 +0000 (17:43 +0000)]
WebRTC: Remove video_capture_tests on Android.

The test is being removed from the code soon.

BUG=webrtc:4475
TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/1104703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294963 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd project identity to the BuildmasterConfig.
ngeoffray@google.com [Thu, 23 Apr 2015 15:58:39 +0000 (15:58 +0000)]
Add project identity to the BuildmasterConfig.

This improves the messages sent when builds fail.

Review URL: https://codereview.chromium.org/1103693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294962 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoV8 Buildbot: Experimental fix for clusterfuzz arm64 build compile error.
machenbach@chromium.org [Thu, 23 Apr 2015 12:41:46 +0000 (12:41 +0000)]
V8 Buildbot: Experimental fix for clusterfuzz arm64 build compile error.

The compiler uses the wrong binutils (not the bundled
version). Switch off goma to see if it's a goma-side problem.

BUG=412706
TBR=kjellander, tandrii

Review URL: https://codereview.chromium.org/1107553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294961 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoMove new mojo slave.
navabi@chromium.org [Thu, 23 Apr 2015 09:44:56 +0000 (09:44 +0000)]
Move new mojo slave.

BUG=477159

Review URL: https://codereview.chromium.org/1105623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294960 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRemove use_allocator=none where it's implied.
machenbach@chromium.org [Thu, 23 Apr 2015 08:48:59 +0000 (08:48 +0000)]
Remove use_allocator=none where it's implied.

Review URL: https://codereview.chromium.org/1083543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294959 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoSplit tryserver.chromium.linux android testers pool into CQ and optional one
phajdan.jr@chromium.org [Thu, 23 Apr 2015 04:43:58 +0000 (04:43 +0000)]
Split tryserver.chromium.linux android testers pool into CQ and optional one

BUG=431479

Review URL: https://codereview.chromium.org/1101803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294958 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoOptimize tryserver.chromium.linux slave pools:
phajdan.jr@chromium.org [Thu, 23 Apr 2015 04:39:30 +0000 (04:39 +0000)]
Optimize tryserver.chromium.linux slave pools:

- move linux_clang_tsan and linux_site_isolation to the common optional pool
  as opposed to each having its own 1 slave pool

- move more slaves from optional pool to CQ pool

- move some slaves from android compile pool to CQ pool

BUG=431479

Review URL: https://codereview.chromium.org/1100253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@294957 0039d316-1c4b-4281-b951-d872f2087c98