chromium/tools/build.git
8 hours agoUse complete Memcheck/DrMemory reports to generate snippets. master
earthdok@chromium.org [Fri, 30 Jan 2015 00:51:52 +0000 (00:51 +0000)]
Use complete Memcheck/DrMemory reports to generate snippets.

Previously snippets only contained suppressions.

Depends: https://codereview.chromium.org/884813002/

BUG=453020
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/879093005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293875 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoDon't zap the timestamps in the binaries that are older than build.ninja.
sebmarchand@chromium.org [Thu, 29 Jan 2015 23:50:58 +0000 (23:50 +0000)]
Don't zap the timestamps in the binaries that are older than build.ninja.

BUG=453053

Review URL: https://codereview.chromium.org/888763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293874 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoSwitch recipe's default gsutil from built in 3.25 to vanilla 3.25
hinoka@chromium.org [Thu, 29 Jan 2015 23:33:12 +0000 (23:33 +0000)]
Switch recipe's default gsutil from built in 3.25 to vanilla 3.25

Now that the change has been sitting on a couple of builders successfully, lets
switch the binary, but not the version.

BUG=434422

Review URL: https://codereview.chromium.org/876313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293873 0039d316-1c4b-4281-b951-d872f2087c98

10 hours agoFixed a typo in slaves.py.
zty@chromium.org [Thu, 29 Jan 2015 22:43:18 +0000 (22:43 +0000)]
Fixed a typo in slaves.py.

BUG=
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/882253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293872 0039d316-1c4b-4281-b951-d872f2087c98

12 hours agoMerged Android and non-Android code paths to reuse code in GTestTest
sergiyb@chromium.org [Thu, 29 Jan 2015 20:25:59 +0000 (20:25 +0000)]
Merged Android and non-Android code paths to reuse code in GTestTest

With this change results for Android GTests will be correctly parsed and
interpreted by the *-ng bots.

BUG=451020
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/892463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293871 0039d316-1c4b-4281-b951-d872f2087c98

13 hours agoUpstream iOS recipe infrastructure host info script
smut@google.com [Thu, 29 Jan 2015 20:17:23 +0000 (20:17 +0000)]
Upstream iOS recipe infrastructure host info script

This upstreams the script which prints out information about the host machine, useful for sheriffing iOS bots.

This depends on https://codereview.chromium.org/880593004.

BUG=452193

Review URL: https://codereview.chromium.org/875753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293870 0039d316-1c4b-4281-b951-d872f2087c98

13 hours agoUpstream iOS recipe infrastructure find Xcode script
smut@google.com [Thu, 29 Jan 2015 20:17:18 +0000 (20:17 +0000)]
Upstream iOS recipe infrastructure find Xcode script

This upstreams the script which finds and attempts to switch to a specific Xcode version, required for our recipe infrastructure.

This depends on https://codereview.chromium.org/880593004.

BUG=452193

Review URL: https://codereview.chromium.org/867843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293869 0039d316-1c4b-4281-b951-d872f2087c98

13 hours agoUpstream iOS recipe infrastructure utils
smut@google.com [Thu, 29 Jan 2015 20:08:46 +0000 (20:08 +0000)]
Upstream iOS recipe infrastructure utils

This upstreams the function in utils.py which are necessary for upstreaming the rest of the downstream recipes infrastructure.

BUG=452193

Review URL: https://codereview.chromium.org/880593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293868 0039d316-1c4b-4281-b951-d872f2087c98

14 hours agoAdd Skia ASAN and UBSAN bots to gatekeeper
borenet@google.com [Thu, 29 Jan 2015 19:01:19 +0000 (19:01 +0000)]
Add Skia ASAN and UBSAN bots to gatekeeper

BUG=skia:2353

Review URL: https://codereview.chromium.org/886633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293867 0039d316-1c4b-4281-b951-d872f2087c98

15 hours agoAdd config for win asan dll bot.
thakis@chromium.org [Thu, 29 Jan 2015 17:44:24 +0000 (17:44 +0000)]
Add config for win asan dll bot.

BUG=448790

Review URL: https://codereview.chromium.org/883113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293866 0039d316-1c4b-4281-b951-d872f2087c98

17 hours agoSkia: Fix Galaxy S3 config
borenet@google.com [Thu, 29 Jan 2015 15:58:54 +0000 (15:58 +0000)]
Skia: Fix Galaxy S3 config

BUG=
TBR=rmistry

Review URL: https://codereview.chromium.org/882993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293865 0039d316-1c4b-4281-b951-d872f2087c98

18 hours agoCorrect suffix for Android Instrumentation tests and add a check if suffix is in...
sergiyb@chromium.org [Thu, 29 Jan 2015 14:58:51 +0000 (14:58 +0000)]
Correct suffix for Android Instrumentation tests and add a check if suffix is in self._test_runs for LocalGTest

This would allow to see name of the test which failed on builds like http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/9

BUG=451020
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/890583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293864 0039d316-1c4b-4281-b951-d872f2087c98

18 hours agoAdd support for multiple branches in package testing, enable on unittest for stable...
ricow@google.com [Thu, 29 Jan 2015 14:57:27 +0000 (14:57 +0000)]
Add support for multiple branches in package testing, enable on unittest for stable branch

TBR=sigmund@google.com
BUG=

Review URL: https://codereview.chromium.org/886763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293863 0039d316-1c4b-4281-b951-d872f2087c98

19 hours agoSkia: Add Galaxy S3 bots
borenet@google.com [Thu, 29 Jan 2015 14:08:34 +0000 (14:08 +0000)]
Skia: Add Galaxy S3 bots

BUG=skia:3353

Review URL: https://codereview.chromium.org/889573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293862 0039d316-1c4b-4281-b951-d872f2087c98

19 hours agoSkia: set skia_warnings_as_errors=1 for Win x86_64
borenet@google.com [Thu, 29 Jan 2015 14:00:28 +0000 (14:00 +0000)]
Skia: set skia_warnings_as_errors=1 for Win x86_64

BUG=skia:3363

Review URL: https://codereview.chromium.org/883263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293861 0039d316-1c4b-4281-b951-d872f2087c98

19 hours agoAdd chromium_trybot_legacy recipe
phajdan.jr@chromium.org [Thu, 29 Jan 2015 13:57:42 +0000 (13:57 +0000)]
Add chromium_trybot_legacy recipe

The bots will be switched to it in a separate CL.

This will allow removing the legacy code from chromium_trybot recipe
and make it easier to work with it (e.g. GenTests are currently shared between
two codepaths, and in general they're confusing).

Eventually the chromium_trybot_legacy recipe will be removed,
but we can't do that easily now, e.g. because of linux_chromium_asan_rel which
is in CQ, but we don't have resources to increase number of swarming shards
for linux_chromium_asan_rel_ng so that its cycle time doesn't regress
(it matches main waterfall and so runs more tests, and so takes longer).

BUG=380709

Review URL: https://codereview.chromium.org/880323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293860 0039d316-1c4b-4281-b951-d872f2087c98

20 hours agoAdded support for swarming tags and added 'gpu_test:1' for GPU tasks
sergiyb@chromium.org [Thu, 29 Jan 2015 13:22:41 +0000 (13:22 +0000)]
Added support for swarming tags and added 'gpu_test:1' for GPU tasks

BUG=452234
R=phajdan.jr@chromium.org
CC=maruel@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/879383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293858 0039d316-1c4b-4281-b951-d872f2087c98

20 hours agoAllow v8 component builds to sync to HEAD on chromium tryjobs.
machenbach@chromium.org [Thu, 29 Jan 2015 13:07:04 +0000 (13:07 +0000)]
Allow v8 component builds to sync to HEAD on chromium tryjobs.

When using "git cl try" or pressing the "try more bots"
button with a v8 stand-alone patch, choosing a chromium
trybot, v8 will be synced to HEAD now.

Other clients could make use of this feature too by just
adding a config to the new apply_patch_project method.

This requires https://codereview.chromium.org/867983002/

BUG=

Review URL: https://codereview.chromium.org/878563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293857 0039d316-1c4b-4281-b951-d872f2087c98

22 hours agoAdd support for pulling in java in the package factory
ricow@google.com [Thu, 29 Jan 2015 11:14:47 +0000 (11:14 +0000)]
Add support for pulling in java in the package factory

R=ager@google.com
BUG=

Review URL: https://codereview.chromium.org/880373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293856 0039d316-1c4b-4281-b951-d872f2087c98

22 hours agoImplement failure_hash build property to summarize tryserver failures
phajdan.jr@chromium.org [Thu, 29 Jan 2015 10:35:40 +0000 (10:35 +0000)]
Implement failure_hash build property to summarize tryserver failures

BUG=451408

Review URL: https://codereview.chromium.org/872773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293855 0039d316-1c4b-4281-b951-d872f2087c98

27 hours agoFix MailNotifier startup when buildsets are enabled
rkubiak@chromium.org [Thu, 29 Jan 2015 06:10:22 +0000 (06:10 +0000)]
Fix MailNotifier startup when buildsets are enabled

R=agable@chromium.org, agable
BUG=

Review URL: https://codereview.chromium.org/880613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293854 0039d316-1c4b-4281-b951-d872f2087c98

27 hours agoBuild just chrome instead of everything.
brucedawson@chromium.org [Thu, 29 Jan 2015 06:01:58 +0000 (06:01 +0000)]
Build just chrome instead of everything.

Building all of the tests increases the exposure to compiler errors,
such as this one which recently hit in gmock:
https://connect.microsoft.com/VisualStudio/feedback/details/1106363/internal-compiler-error-with-analyze-due-to-failure-to-infer-move

While a bug has been filed to get gmock changed to work-around this
compiler error, stopping building things besides Chrome in the
interim seems worthwhile. The gmock bug is:
https://code.google.com/p/googlemock/issues/detail?id=172

And, building just Chrome may be more valuable anyway. Building the
unit tests increases the build times and the noise level, which
makes finding important issues trickier. And, some of the
unique warnings in the tests are intentional bugs.

It's a worthwhile experiment that will get the /analyze builder
running again.

BUG=427616

Review URL: https://codereview.chromium.org/888503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293853 0039d316-1c4b-4281-b951-d872f2087c98

30 hours agoFix explain arg
scottmg@chromium.org [Thu, 29 Jan 2015 02:33:20 +0000 (02:33 +0000)]
Fix explain arg

Follow up to http://crrev.com/883933002

TBR=zty@chromium.org

Review URL: https://codereview.chromium.org/884133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293852 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agocompile.py support for no-op build checking, and add to Linux clobber builders
scottmg@chromium.org [Wed, 28 Jan 2015 20:58:24 +0000 (20:58 +0000)]
compile.py support for no-op build checking, and add to Linux clobber builders

This checks ninja's output string for "no work to do". If we decide to add
support for that query to ninja (with a returncode or similar) we can amend
this checking code to be a bit simpler/more robust.

This only adds the check to the Linux clobber builders. We would especially
like it on Windows in the future, but it doesn't work there yet due to
always-build steps building the installer archive. (Mac is also currently
minorly broken.)

R=thakis@chromium.org
BUG=342974,451499

Review URL: https://codereview.chromium.org/883933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293850 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agoFix runtest.py following r293842.
earthdok@chromium.org [Wed, 28 Jan 2015 20:51:18 +0000 (20:51 +0000)]
Fix runtest.py following r293842.

Fix a Python error that affected pre-recipes sanitizer bots.

BUG=none
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/881573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293849 0039d316-1c4b-4281-b951-d872f2087c98

37 hours agobuildbucket: do not poll prod server locally
nodir@chromium.org [Wed, 28 Jan 2015 20:21:02 +0000 (20:21 +0000)]
buildbucket: do not poll prod server locally

If ActiveMater.is_production_host is False, do not try to talk to the
prod server. Use cr-buildbucket-test server instead.

R=sheyang@chromium.org, vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/864223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293848 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoRemoved polymer master.
tandrii@chromium.org [Wed, 28 Jan 2015 17:12:13 +0000 (17:12 +0000)]
Removed polymer master.

BUG=451097
R=nodir@chromium.org

Review URL: https://codereview.chromium.org/880263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293843 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoRefactor sanitizer code in runtest.py
earthdok@chromium.org [Wed, 28 Jan 2015 17:05:02 +0000 (17:05 +0000)]
Refactor sanitizer code in runtest.py

Mostly just hoist it out of main().

BUG=none
R=glider@chromium.org

Review URL: https://codereview.chromium.org/863203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293842 0039d316-1c4b-4281-b951-d872f2087c98

41 hours agoRemove obsolete trybots, round #3
phajdan.jr@chromium.org [Wed, 28 Jan 2015 15:44:32 +0000 (15:44 +0000)]
Remove obsolete trybots, round #3

Please see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/8j5XLIfb604/uFKH_MsfttEJ
for discussion.

BUG=none

Review URL: https://codereview.chromium.org/883833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293841 0039d316-1c4b-4281-b951-d872f2087c98

44 hours agoV8 Buildbot: Let auto-roller try to push new versions more frequently.
machenbach@chromium.org [Wed, 28 Jan 2015 13:12:56 +0000 (13:12 +0000)]
V8 Buildbot: Let auto-roller try to push new versions more frequently.

BUG=451975
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/885633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293840 0039d316-1c4b-4281-b951-d872f2087c98

47 hours agoWebRTC: Add client.webrtc.fyi master to GIT_MASTERS in bot_update.py
kjellander@chromium.org [Wed, 28 Jan 2015 10:21:50 +0000 (10:21 +0000)]
WebRTC: Add client.webrtc.fyi master to GIT_MASTERS in bot_update.py

Start with this master only instead of all three as in
https://codereview.chromium.org/769203002/

BUG=438170
TBR=hinoka@chromium.org

Review URL: https://codereview.chromium.org/884043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293838 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoFix accidental read-only in cros_chromite.
djacques@chromium.org [Wed, 28 Jan 2015 03:31:41 +0000 (03:31 +0000)]
Fix accidental read-only in cros_chromite.

BUG=chromium:452528
TEST=local
  - Delete cache, run: `gclient runhooks` has read only error.
  - Apply this CL, run: `gclient runhooks` works.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/882713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293836 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoMake goma canary run goma with GOMA_HERMETIC=error.
yyanagisawa@chromium.org [Wed, 28 Jan 2015 03:27:00 +0000 (03:27 +0000)]
Make goma canary run goma with GOMA_HERMETIC=error.

Before turning on GOMA_HERMETIC=error on anything else, let me set
GOMA_HERMETIC=error on goma's trybot to see the effect of the flag.
BUG=https://code.google.com/p/chromium/issues/detail?id=366967

Review URL: https://codereview.chromium.org/878033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293835 0039d316-1c4b-4281-b951-d872f2087c98

2 days ago'cros_chromite' is tolerant of missing 'requests'.
dnj@chromium.org [Wed, 28 Jan 2015 03:21:29 +0000 (03:21 +0000)]
'cros_chromite' is tolerant of missing 'requests'.

BUG=chromium:452528
TEST=local
  - Ran unittests.
  - Started chromiumos.tryserver master, confirmed that it loads
    cache/slaves.
  - Ran `gclient runhooks --force`, confirmed that it loads cache.
  - Faked ImportError, confirmed that the module loaded successfully.

Review URL: https://codereview.chromium.org/878933006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293834 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoSwitch CrOS build deputy to rotations link.
dnj@chromium.org [Wed, 28 Jan 2015 03:12:49 +0000 (03:12 +0000)]
Switch CrOS build deputy to rotations link.

BUG=chromium:452113
TEST=local
  - Ran page locally, confirmed that it works.

Review URL: https://codereview.chromium.org/872673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293833 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRemove obsolete sandbox disabling logic from runtest.py.
earthdok@chromium.org [Tue, 27 Jan 2015 23:04:40 +0000 (23:04 +0000)]
Remove obsolete sandbox disabling logic from runtest.py.

Previously, we disabled the SUID sandbox by setting CHROME_DEVEL_SANDBOX="" in
the following cases:
- If LSan or TSan were enabled. However, we already pass --no-sandbox in this
case, so setting the env variable to an empty string is unnecessary.
- If the SUID sandbox binary was not present or not configured correctly.
This was useful when SUID sandbox was being rolled out. However, according to
https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment
the sandbox binary must now be present on all bots. If it isn't, it makes more
sense to fail than to disable the sandbox. Also, according to the same doc,
setting the env variable to "" is no longer a supported way of disabling the
sandbox.

BUG=245376
R=stip@chromium.org

Review URL: https://codereview.chromium.org/881743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293832 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdd logging to package_index.py
akuegel@chromium.org [Tue, 27 Jan 2015 22:20:09 +0000 (22:20 +0000)]
Add logging to package_index.py

The step that executes this step takes approximately 90 minutes, and it is
currently killed after 20 minutes of no output. Therefore add some progress
logging.

BUG=429684

Review URL: https://codereview.chromium.org/878313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293830 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoruntest.py: add back --parallel as a dummy flag
earthdok@chromium.org [Tue, 27 Jan 2015 21:39:06 +0000 (21:39 +0000)]
runtest.py: add back --parallel as a dummy flag

Can't remove the flag until all masters which pass it have restarted.

BUG=452647
TBR=zty@chromium.org

Review URL: https://codereview.chromium.org/878273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293829 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdd debug output in case of error.
akuegel@chromium.org [Tue, 27 Jan 2015 19:14:57 +0000 (19:14 +0000)]
Add debug output in case of error.

The execution of the package_index.py script is currently failing on the bots.
Add some debug output in a potential error case to figure out what is happening.

TBR=sergiyb@chromium.org
BUG=429684

Review URL: https://codereview.chromium.org/878923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293828 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdded missing methods to AndroidInstrumentationTest
sergiyb@chromium.org [Tue, 27 Jan 2015 17:25:57 +0000 (17:25 +0000)]
Added missing methods to AndroidInstrumentationTest

BUG=451020
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/882463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293827 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdd 'requests' to the slave PYTHONPATH.
djacques@chromium.org [Tue, 27 Jan 2015 17:07:47 +0000 (17:07 +0000)]
Add 'requests' to the slave PYTHONPATH.

BUG=
TEST=slave
  - Ran with this update on slave, confirmed that it now imports
    correctly.

R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/884443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293826 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoClean up runtest.py.
earthdok@chromium.org [Tue, 27 Jan 2015 15:16:02 +0000 (15:16 +0000)]
Clean up runtest.py.

- run_test_cases.py and the sharding supervisor have been
gone for a while, which makes a bunch of flags obsolete,
- some sanitizer related stuff have been moved into recipe configs,
- the --brave-new-test-launcher flag is obsolete,
- the --parallel flag no longer has any effect beyond what --annotate=gtest does, and is passed only when --annotate=gtest is passed, which makes it redundant.

BUG=none
R=maruel@chromium.org,phajdan.jr@chromium.org,stip@chromium.org

Review URL: https://codereview.chromium.org/855373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293824 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoWebRTC: Reshuffle Mac slaves in client.webrtc
kjellander@chromium.org [Tue, 27 Jan 2015 13:39:05 +0000 (13:39 +0000)]
WebRTC: Reshuffle Mac slaves in client.webrtc

After adding the GN bots for Mac, we ended up with
too many checkouts on the slave machines.
This should reduce the number to max two checkouts.

This is similar to https://codereview.chromium.org/883633002

TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/865783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293823 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoWebRTC: Reshuffle Mac trybot slaves.
kjellander@chromium.org [Tue, 27 Jan 2015 08:41:17 +0000 (08:41 +0000)]
WebRTC: Reshuffle Mac trybot slaves.

After adding the GN trybots for Mac, we ended up with
too many checkouts on the slave machines.
This should reduce the number to max two checkouts.

Review URL: https://codereview.chromium.org/883633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293820 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdd recipe changes to make new index pack work.
akuegel@chromium.org [Tue, 27 Jan 2015 03:09:01 +0000 (03:09 +0000)]
Add recipe changes to make new index pack work.

In the first step, the new index pack format is only supported
on the new Chromium Mac Codesearch buildbot and the two staging bots.
Once the other Linux slaves run on Trusty and the pipeline has switched over,
we can switch them over as well.

BUG=429684

Review URL: https://codereview.chromium.org/858613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293819 0039d316-1c4b-4281-b951-d872f2087c98

3 days agobuildbucket: do not check request merging
nodir@chromium.org [Tue, 27 Jan 2015 02:14:04 +0000 (02:14 +0000)]
buildbucket: do not check request merging

Do not assert that request merging is disabled.

TBR=vadimsh@chromium.org
BUG=451259

Review URL: https://codereview.chromium.org/878823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293818 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoBuildbucket: fail builds with invalid def
nodir@chromium.org [Tue, 27 Jan 2015 00:52:49 +0000 (00:52 +0000)]
Buildbucket: fail builds with invalid def

If build definition is invalid (missing param, etc), do not just
silently skip it, but mark as failed with "INVALID_BUILD_DEFINITION"
reason

R=sheyang@chromium.org, vadimsh@chromium.org
BUG=450413

Review URL: https://codereview.chromium.org/866953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293817 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoBuildbucket: cancel build sync
nodir@chromium.org [Tue, 27 Jan 2015 00:49:58 +0000 (00:49 +0000)]
Buildbucket: cancel build sync

If a build request is cancelled on buildbot, mark it as cancelled on
buildbucket

R=sheyang@chromium.org, sergeyberezin@chromium.org, vadimsh@chromium.org
BUG=450793

Review URL: https://codereview.chromium.org/878553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293816 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoRemove good_revisions from nacl masters.
stip@chromium.org [Tue, 27 Jan 2015 00:32:39 +0000 (00:32 +0000)]
Remove good_revisions from nacl masters.

Review URL: https://codereview.chromium.org/878603008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293815 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoUpdate .DEPS.git
chrome-admin@google.com [Tue, 27 Jan 2015 00:23:04 +0000 (00:23 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293814 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoCrOS: Use soft-pinned Chromite for master configs.
dnj@chromium.org [Tue, 27 Jan 2015 00:22:13 +0000 (00:22 +0000)]
CrOS: Use soft-pinned Chromite for master configs.

- Introduce a library to retrieve Chromite configurations for a given
  named branch. This library supports pinning branches.
- Have 'chromiumos.tryserver' use the new Chromite wrapper library.
- Remove 'build' dependency on Chromite (cbuildbot_chromite) and clean
  up its legacy.

BUG=

Review URL: https://codereview.chromium.org/849103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293813 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoConnected chromium tryservers to buildbucket
nodir@chromium.org [Mon, 26 Jan 2015 23:12:20 +0000 (23:12 +0000)]
Connected chromium tryservers to buildbucket

Connected master.tryserver.chromium.{gpu, linux, mac, perf, win} to
buildbucket. Each polling a bucket of the master name.

R=sheyang@chromium.org, phajdan.jr@chromium.org, agable@chromium.org
BUG=448073

Review URL: https://codereview.chromium.org/860183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293812 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdd clobber = True to the win_analyze config so that /analyze builds
brucedawson@chromium.org [Mon, 26 Jan 2015 23:08:50 +0000 (23:08 +0000)]
Add clobber = True to the win_analyze config so that /analyze builds
are always full and complete. This allows comparing warning sets to
easily determine when warnings appear and when they are fixed.

BUG=427616

Review URL: https://codereview.chromium.org/875003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293811 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoWebRTC: Fix trigger typo in chromium.webrtc.fyi
kjellander@chromium.org [Mon, 26 Jan 2015 21:10:48 +0000 (21:10 +0000)]
WebRTC: Fix trigger typo in chromium.webrtc.fyi

I made a typo in https://codereview.chromium.org/875843002
making the trigger invalid.

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/877883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293810 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoRemove stale script env_dump.py.
maruel@chromium.org [Mon, 26 Jan 2015 19:43:09 +0000 (19:43 +0000)]
Remove stale script env_dump.py.

R=navabi@chromium.org
BUG=

Review URL: https://codereview.chromium.org/780093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293805 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdd assert for permitted_domains.
kjellander@chromium.org [Mon, 26 Jan 2015 18:51:46 +0000 (18:51 +0000)]
Add assert for permitted_domains.

Add an assert to protect from user mistakes as the
one that was fixed in https://chromereviews.googleplex.com/93877013/

Unfortunately this code is usually never parsed until it's run
on the production master (I filed a bug a while back for exactly
that: https://code.google.com/p/chromium/issues/detail?id=173336).

BUG=

Review URL: https://codereview.chromium.org/610383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293804 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoRemove mac_asan and mac_asan_64 to free up disk space on bots
phajdan.jr@chromium.org [Mon, 26 Jan 2015 16:36:24 +0000 (16:36 +0000)]
Remove mac_asan and mac_asan_64 to free up disk space on bots

These bots were scheduled for removal anyway in favor of
mac_chromium_asan_rel_ng .

BUG=448811

Review URL: https://codereview.chromium.org/871403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293803 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoClean up android/{builder,tester} recipes (remove unused bots)
phajdan.jr@chromium.org [Mon, 26 Jan 2015 15:16:52 +0000 (15:16 +0000)]
Clean up android/{builder,tester} recipes (remove unused bots)

The bots in question have been switched to the chromium recipe.

BUG=442688

Review URL: https://codereview.chromium.org/864363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293802 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoV8 Buildbot: Clean up of release scripts.
machenbach@chromium.org [Mon, 26 Jan 2015 14:24:30 +0000 (14:24 +0000)]
V8 Buildbot: Clean up of release scripts.

Buildbot side of
https://codereview.chromium.org/868473004/

BUG=451975
TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/875023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293801 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoWebRTC: ARM64 builder+tester for chromium.webrtc.fyi
kjellander@chromium.org [Mon, 26 Jan 2015 13:58:11 +0000 (13:58 +0000)]
WebRTC: ARM64 builder+tester for chromium.webrtc.fyi

Need to setup a new builder for an ARM64 archive to be
consumed by the tester running the 64-bit Nexus 9 device.

BUG=450062

Review URL: https://codereview.chromium.org/875843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293800 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoV8 Buildbot: Allow running chromium try jobs for v8 patches.
machenbach@chromium.org [Mon, 26 Jan 2015 12:28:13 +0000 (12:28 +0000)]
V8 Buildbot: Allow running chromium try jobs for v8 patches.

BUG=

Review URL: https://codereview.chromium.org/867983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293799 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoWebRTC: Move SyzyASan to FYI due to bug.
kjellander@chromium.org [Sun, 25 Jan 2015 19:08:23 +0000 (19:08 +0000)]
WebRTC: Move SyzyASan to FYI due to bug.

In https://webrtc-codereview.appspot.com/33059004/ a bug
in SyzyASan makes it fail to apply ASan for our bots.
Since that is blocking us from rolling Chromium revision
the commit bot is moved into the FYI waterfall and the
trybot is removed.

BUG=webrtc:4222
TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/872263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293798 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoWebRTC: Fix builder triggering in client.webrtc.fyi
kjellander@chromium.org [Sun, 25 Jan 2015 16:39:16 +0000 (16:39 +0000)]
WebRTC: Fix builder triggering in client.webrtc.fyi

In https://codereview.chromium.org/867283002 I missed to
add the new builders to the triggering.

TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/875733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293797 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoAdded Linux bots to the list of GPU swarming dimensions
sergiyb@chromium.org [Sat, 24 Jan 2015 20:47:20 +0000 (20:47 +0000)]
Added Linux bots to the list of GPU swarming dimensions

BUG=426897
R=kbr@chromium.org,phajdan.jr@chromium.org,maruel@chromium.org

Review URL: https://codereview.chromium.org/795163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293796 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoRemoved linux_gpu and linux_gpu_triggered_tests from tryserver.chromium.gpu
sergiyb@chromium.org [Sat, 24 Jan 2015 19:45:26 +0000 (19:45 +0000)]
Removed linux_gpu and linux_gpu_triggered_tests from tryserver.chromium.gpu

BUG=426897
R=kbr@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/797683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293795 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoV8 Buildbot: Shuffle slaves to save some disc space.
machenbach@chromium.org [Sat, 24 Jan 2015 13:36:33 +0000 (13:36 +0000)]
V8 Buildbot: Shuffle slaves to save some disc space.

Five chromium builders on one bot run out of disc space.

TBR=tandrii@chromium.org

Review URL: https://codereview.chromium.org/868893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293794 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoTry to fix isolate step on win clang asan bot. See bug for details.
thakis@chromium.org [Sat, 24 Jan 2015 08:12:27 +0000 (08:12 +0000)]
Try to fix isolate step on win clang asan bot. See bug for details.

BUG=451686
TBR=timurrrr@chromium.org

Review URL: https://codereview.chromium.org/873983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293793 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoEnable isolates and swarming on all remaining win clang bots.
thakis@chromium.org [Sat, 24 Jan 2015 03:25:23 +0000 (03:25 +0000)]
Enable isolates and swarming on all remaining win clang bots.

BUG=446368

Review URL: https://codereview.chromium.org/874753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293792 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRemoved broken test suite on infra_continuous
pgervais@chromium.org [Sat, 24 Jan 2015 01:23:33 +0000 (01:23 +0000)]
Removed broken test suite on infra_continuous

git cl presubmit does not work with a detached head.

BUG=

Review URL: https://codereview.chromium.org/868243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293791 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoFix MailNotifier bug for buildsets
rkubiak@chromium.org [Sat, 24 Jan 2015 00:30:58 +0000 (00:30 +0000)]
Fix MailNotifier bug for buildsets

Implementing a fix from buildbot 0.8.6p1.
http://trac.buildbot.net/ticket/2254
https://github.com/buildbot/buildbot/commit/4d3b0318025ca38c148a09e2fec5f2f97f61be57

I wasn't entirely sure of the implications of removing self.db from
status/master.py.  I found two files using status.master.db
(buildbot/status/builder.py, buildbot/status/web/status_json.py).
Neither of these are imported and they both seem to still work by
inherting status from their parent.

I've run this patch on a testing instance and everything seems to still
work, although I have not tested the MailNotifier.

R=agable@chromium.org, agable, dnj, iannucci, luqui
BUG=

Review URL: https://codereview.chromium.org/869873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293789 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoStop using disable_nacl=1 and disabling isolates on the win asan bot.
thakis@chromium.org [Sat, 24 Jan 2015 00:01:06 +0000 (00:01 +0000)]
Stop using disable_nacl=1 and disabling isolates on the win asan bot.

After https://codereview.chromium.org/871973004 this should no longer be
needed, and isolates are required to enable swarming (which in turn is required
to get content_browsertests to pass; they don't pass without swarming, see
crbug.com/440579).

BUG=416078

Review URL: https://codereview.chromium.org/867883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293788 0039d316-1c4b-4281-b951-d872f2087c98

6 days ago[Android] Fix Android Tests (amp)(dbg) by removing uirobot tests.
jbudorick@chromium.org [Fri, 23 Jan 2015 23:42:00 +0000 (23:42 +0000)]
[Android] Fix Android Tests (amp)(dbg) by removing uirobot tests.

Broken by https://codereview.chromium.org/840393003/, and running
uirobot tests against ChromeShell is of minimal value to us anyway.

TBR=luqui@chromium.org
BUG=448629

Review URL: https://codereview.chromium.org/867373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293787 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAdded trace_test to list of gpu tests.
dyen@chromium.org [Fri, 23 Jan 2015 22:19:30 +0000 (22:19 +0000)]
Added trace_test to list of gpu tests.

Added the "trace_test" as a test to be run on the bots. Currently this
test will always pass since it will be skipped using this CL:

https://codereview.chromium.org/847773006/

After both of these changes have landed, I will enable it on bots that
support the GL Timer extensions.

R=bajones@chromium.org, vmiura@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/850593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293786 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoEnable ipc fuzzer and v8 enable verify heap flag on windows asan lkgr bot.
inferno@chromium.org [Fri, 23 Jan 2015 22:13:57 +0000 (22:13 +0000)]
Enable ipc fuzzer and v8 enable verify heap flag on windows asan lkgr bot.

BUG=450268
R=rnk@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/869233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293785 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRe-enable compile on Android GN trybots.
dpranke@chromium.org [Fri, 23 Jan 2015 20:05:40 +0000 (20:05 +0000)]
Re-enable compile on Android GN trybots.

It turns out that we have been building way too many targets by
default, and we were building them w/ full symbols, when the
GYP bots build with minimal symbols. This was causing us to
use 5x-10x too much disk space per build.

TBR=luqui@chromium.org, cjhopman@chromium.org
BUG=451227

Review URL: https://codereview.chromium.org/875513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293784 0039d316-1c4b-4281-b951-d872f2087c98

6 days agobot_update: Infer sensible default for --revision_mapping
sbc@chromium.org [Fri, 23 Jan 2015 19:30:16 +0000 (19:30 +0000)]
bot_update: Infer sensible default for --revision_mapping

Without a default for --revision_mapping bot_update will
set got_revsion to whatever is passed as --revsion, which
is not always useful (e.g. HEAD is not useful value for
got_revsion, neither is the empty string).

With this change if no revision mappying is specified and
the defaults in GOT_REVISION_MAPPINGS do not apply then we
infer a mapping or: { solution0_repo : 'got_revision' }

BUG=450688

Review URL: https://codereview.chromium.org/862913005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293783 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoWebRTC: Add more Windows bots running tests in parallel.
kjellander@chromium.org [Fri, 23 Jan 2015 15:37:36 +0000 (15:37 +0000)]
WebRTC: Add more Windows bots running tests in parallel.

We need more data on when we have fixed all the tests that
have issues when being run in parallel.

BUG=445880
TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/867283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293782 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRevert of Enable parallel test execution for Windows (re-land) (patchset #2 id:20001...
kjellander@chromium.org [Fri, 23 Jan 2015 15:16:00 +0000 (15:16 +0000)]
Revert of Enable parallel test execution for Windows (re-land) (patchset #2 id:20001 of https://codereview.chromium.org/868063002/)

Reason for revert:
Discovered a lot more failing tests:
http://build.chromium.org/p/client.webrtc/builders/Win32%20Release/builds/3600/steps/libjingle_media_unittest/logs/stdio
http://build.chromium.org/p/client.webrtc/builders/Win64%20Debug/builds/3204/steps/rtc_unittests/logs/stdio
http://build.chromium.org/p/client.webrtc/builders/Win32%20Debug/builds/3523/steps/rtc_unittests/logs/stdio

Original issue's description:
> Enable parallel test execution for Windows (re-land)
>
> After fixing a few parallel-execution bugs we're going
> to try this again.
> This is a re-land of https://codereview.chromium.org/827423008/
>
> TBR=phoglund@chromium.org
> BUG=445880
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293777

TBR=phoglund@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=445880

Review URL: https://codereview.chromium.org/871053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293781 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAdded gitiles/download_file function
sergiyb@chromium.org [Fri, 23 Jan 2015 15:03:34 +0000 (15:03 +0000)]
Added gitiles/download_file function

R=iannucci@chromium.org,sergeyberezin@chromium.org

Review URL: https://codereview.chromium.org/851143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293780 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoDo not override hard-coded patch project roots with passed ones
sergiyb@chromium.org [Fri, 23 Jan 2015 14:36:02 +0000 (14:36 +0000)]
Do not override hard-coded patch project roots with passed ones

This will allow to pass additional patch roots from the recipes that are
used for both common and uncommon projects.

R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/874543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293779 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAdd linux_chromium_dbg_32_ng optional trybot
phajdan.jr@chromium.org [Fri, 23 Jan 2015 14:28:46 +0000 (14:28 +0000)]
Add linux_chromium_dbg_32_ng optional trybot

BUG=380709

Review URL: https://codereview.chromium.org/870613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293778 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoEnable parallel test execution for Windows (re-land)
kjellander@chromium.org [Fri, 23 Jan 2015 14:07:33 +0000 (14:07 +0000)]
Enable parallel test execution for Windows (re-land)

After fixing a few parallel-execution bugs we're going
to try this again.
This is a re-land of https://codereview.chromium.org/827423008/

TBR=phoglund@chromium.org
BUG=445880

Review URL: https://codereview.chromium.org/868063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293777 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoV8 Buildbot: Remove clang bot.
machenbach@chromium.org [Fri, 23 Jan 2015 14:01:01 +0000 (14:01 +0000)]
V8 Buildbot: Remove clang bot.

Clang is the default on linux now, so we don't need
a separate bot.

Review URL: https://codereview.chromium.org/871903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293776 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoWebRTC: Make Windows builders share slaves machines again.
kjellander@chromium.org [Fri, 23 Jan 2015 10:42:09 +0000 (10:42 +0000)]
WebRTC: Make Windows builders share slaves machines again.

After http://crbug.com/451064 was fixed, these Windows VMs
now have 250GB disk, making it more efficient to have the builders
share the slave machines.

Review URL: https://codereview.chromium.org/867533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293775 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoExtend infra/publish_tarball recipe to trigger builds for missing tarballs
phajdan.jr@chromium.org [Fri, 23 Jan 2015 09:41:55 +0000 (09:41 +0000)]
Extend infra/publish_tarball recipe to trigger builds for missing tarballs

BUG=433338

Review URL: https://codereview.chromium.org/840293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293774 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoTry to fix clang/win asan tester bot after recipes switch.
thakis@chromium.org [Fri, 23 Jan 2015 06:07:23 +0000 (06:07 +0000)]
Try to fix clang/win asan tester bot after recipes switch.

Currently, asan is set in GYP_DEFINES, to force the --enable-asan flag for
runtests.py.  But this also causes the bot to try and build clang, which fails.
Instead, add an explicit flag for forcing --enable-asan.

BUG=446368
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/872613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293773 0039d316-1c4b-4281-b951-d872f2087c98

7 days ago[Android] Fix --app-under-test param for Android Tests (amp)(dbg)
jbudorick@chromium.org [Fri, 23 Jan 2015 02:54:23 +0000 (02:54 +0000)]
[Android] Fix --app-under-test param for Android Tests (amp)(dbg)

TBR=luqui@chromium.org
BUG=448629

Review URL: https://codereview.chromium.org/866333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293772 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoMove all other cr win clang bots to recipes.
thakis@chromium.org [Fri, 23 Jan 2015 02:30:55 +0000 (02:30 +0000)]
Move all other cr win clang bots to recipes.

This doesn't enable isolates or swarming yet, so in theory it hopefully
won't change behavior (other than the bots now using recipes instead of buildbot
code to do what they're already doing).

BUG=446368

Review URL: https://codereview.chromium.org/859273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293771 0039d316-1c4b-4281-b951-d872f2087c98

7 days agobuildbucket merge request check
nodir@chromium.org [Fri, 23 Jan 2015 02:13:10 +0000 (02:13 +0000)]
buildbucket merge request check

Use dict.get to check build request merging

TBR=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/866813006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293770 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoRevert "bulidbucket: check service account file existance"
nodir@chromium.org [Fri, 23 Jan 2015 02:09:25 +0000 (02:09 +0000)]
Revert "bulidbucket: check service account file existance"

This reverts commit d01ea7ad4521bcfc298d5898febd6b612da10102
https://codereview.chromium.org/865493003/

TBR=vadimsh@chromium.org

Review URL: https://codereview.chromium.org/871713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293769 0039d316-1c4b-4281-b951-d872f2087c98

7 days agobulidbucket: check service account file existance
nodir@chromium.org [Fri, 23 Jan 2015 01:33:38 +0000 (01:33 +0000)]
bulidbucket: check service account file existance

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/865493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293768 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoConnected master.chromium.infra to buildbucket
nodir@chromium.org [Fri, 23 Jan 2015 01:33:34 +0000 (01:33 +0000)]
Connected master.chromium.infra to buildbucket

master.chromium.infra polls "master.chromium.infra" bucket with "infra"
service account

R=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/858023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293767 0039d316-1c4b-4281-b951-d872f2087c98

7 days agobuildbucket: build request merge not supported
nodir@chromium.org [Fri, 23 Jan 2015 01:24:50 +0000 (01:24 +0000)]
buildbucket: build request merge not supported

Raise an exception in buildbucket.setup if config['mergeRequests'] is
not set to False explicitly

R=vadimsh@chromium.org
BUG=451259

Review URL: https://codereview.chromium.org/871703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293766 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoTemporarily disable the compile on the Android GN bots.
dpranke@chromium.org [Thu, 22 Jan 2015 23:43:09 +0000 (23:43 +0000)]
Temporarily disable the compile on the Android GN bots.

The build is taking up way too much disk space, due to some
as-yet-unknown combination of building too many targets and
perhaps building with the wrong flags.

TBR=luqui@chromium.org, cjhopman@chromium.org
BUG=451227

Review URL: https://codereview.chromium.org/870813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293764 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoMade build archiving fail with purple instead of red.
luqui@chromium.org [Thu, 22 Jan 2015 23:16:11 +0000 (23:16 +0000)]
Made build archiving fail with purple instead of red.

BUG=
R=vadimsh@chromium.org

Review URL: https://codereview.chromium.org/865273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293763 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoAdd a "check" step on the GN bots..
dpranke@chromium.org [Thu, 22 Jan 2015 22:48:14 +0000 (22:48 +0000)]
Add a "check" step on the GN bots..

This change adds a new step by default for all of the bots in this recipe,
which should affect Chromium and V8 but not WebRTC, libyuv, or Mojo.

It might be safe to turn those last three on as well, but let's see if this
causes any problems first.

This change is coded in such a way that it will be easy to turn --check off
bot-by-bot if need be (otherwise we could just hard-code it in the run_gn()
implementation.

I didn't use a recipe 'config' context for this because it felt more awkward and
less clear.

We run this as a separate step rather than 'gn gen --check' because it may take a significant amount of time (at least seconds) and so we're not likely to make this on by default in gn. As a result, if we ran this on the bots then they would be running gen differently than developers mostly will do, which seems like it would be confusing.

BUG=367595, 376000
R=tfarina@chromium.org,brettw@chromium.org, iannucci@chromium.org

Review URL: https://codereview.chromium.org/854763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293762 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoFix a syntax error in runtest.py following r293755.
earthdok@chromium.org [Thu, 22 Jan 2015 21:48:24 +0000 (21:48 +0000)]
Fix a syntax error in runtest.py following r293755.

BUG=372458
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/868863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293761 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoFix the order of the operations in the PGO recipe.
sebmarchand@chromium.org [Thu, 22 Jan 2015 21:43:18 +0000 (21:43 +0000)]
Fix the order of the operations in the PGO recipe.

increase_pgomgr_stack_size.py should be called *after* calling runhooks.

BUG=

Review URL: https://codereview.chromium.org/868803005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293759 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoArchive binaries on the deterministic build.
maruel@chromium.org [Thu, 22 Jan 2015 21:13:41 +0000 (21:13 +0000)]
Archive binaries on the deterministic build.

This has two goals:
- Archive the binaries for inspection.
- Fix the .isolated, as the .isolated files will be different after the step
  remove_build_metadata ran. This caused false-positives on the diffing on OSes
  where remove_build_metadata is not a no-op.

R=sebmarchand@chromium.org
BUG=314403

Review URL: https://codereview.chromium.org/863393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293758 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoDisabled 'root' again
sergiyb@chromium.org [Thu, 22 Jan 2015 21:09:12 +0000 (21:09 +0000)]
Disabled 'root' again

BUG=webrtc:4150
R=iannucci@chromium.org,sergeyberezin@chromium.org

Review URL: https://codereview.chromium.org/832583006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@293757 0039d316-1c4b-4281-b951-d872f2087c98