chromium/tools/build.git
89 min agoadded chromium_perf linux builder tester specs. master
zty@chromium.org [Sat, 2 Aug 2014 00:57:14 +0000 (00:57 +0000)]
added chromium_perf linux builder tester specs.

BUG=388885
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/417913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@287138 0039d316-1c4b-4281-b951-d872f2087c98

108 min agoRemoved bare strings.
martiniss@chromium.org [Sat, 2 Aug 2014 00:38:13 +0000 (00:38 +0000)]
Removed bare strings.

This removes bare strings of status messages, and replaces them with references to the step module.

Private version: https://chromereviews.googleplex.com/70887013/

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/424543008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@287134 0039d316-1c4b-4281-b951-d872f2087c98

3 hours agoRemove Android GN Perf (master side half).
tonyg@chromium.org [Fri, 1 Aug 2014 22:57:36 +0000 (22:57 +0000)]
Remove Android GN Perf (master side half).

The MotoE provides the low-end device coverage that this used to.

BUG=393575

Review URL: https://codereview.chromium.org/440473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@287113 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoFix bucket name on chromium.memory mac asan builders
hinoka@chromium.org [Fri, 1 Aug 2014 22:23:54 +0000 (22:23 +0000)]
Fix bucket name on chromium.memory mac asan builders

https://codereview.chromium.org/417303003 switches builders to transfer builds
using GS rather than lighttpd. There was a typo and the bucket name is incorrect.
This fixes the bucket name to point at a real GS bucket.

BUG=399547

Review URL: https://codereview.chromium.org/435003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@287106 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoAdd change_filter option to GitilesPoller initializer.
szager@chromium.org [Fri, 1 Aug 2014 21:14:29 +0000 (21:14 +0000)]
Add change_filter option to GitilesPoller initializer.

R=kmg@chromium.org,iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/423073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@287089 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoDefined undefined variable in runtest.py
pgervais@chromium.org [Fri, 1 Aug 2014 19:51:23 +0000 (19:51 +0000)]
Defined undefined variable in runtest.py

This was causing the finally clause to crash the script when an exception
was raised before json_file_name was defined.

BUG=399691

Review URL: https://codereview.chromium.org/436013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@287073 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoAdd ZipBuild archive for both factory parameter and factory property
hinoka@chromium.org [Fri, 1 Aug 2014 19:39:22 +0000 (19:39 +0000)]
Add ZipBuild archive for both factory parameter and factory property

Some master configs uses factory_properties to indicate build_url

BUG=396865

Review URL: https://codereview.chromium.org/433153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@287072 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoUpdate GitBranchPoller with the ability to exclude arbitrary refs from polling
smut@google.com [Fri, 1 Aug 2014 18:48:47 +0000 (18:48 +0000)]
Update GitBranchPoller with the ability to exclude arbitrary refs from polling

Review URL: https://codereview.chromium.org/424763005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@287055 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoSwitch one of the MSan runners from vm855-m1 to vm923-m1.
earthdok@chromium.org [Fri, 1 Aug 2014 17:25:00 +0000 (17:25 +0000)]
Switch one of the MSan runners from vm855-m1 to vm923-m1.

BUG=399651,178409
TBR=pschmidt@chromium.org

Review URL: https://codereview.chromium.org/433093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@287031 0039d316-1c4b-4281-b951-d872f2087c98

10 hours agoRemove dict comprehension from chromium_factory.py
smut@google.com [Fri, 1 Aug 2014 16:17:11 +0000 (16:17 +0000)]
Remove dict comprehension from chromium_factory.py

This is for legacy compatibility with Python 2.6.

BUG=399650
TBR=hinoka

Review URL: https://codereview.chromium.org/440433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@287014 0039d316-1c4b-4281-b951-d872f2087c98

11 hours agoUpdate mini_installer test wrapper script.
grt@chromium.org [Fri, 1 Aug 2014 14:47:58 +0000 (14:47 +0000)]
Update mini_installer test wrapper script.

This tracks changes made to the script in r286837.

BUG=264859,399511
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/437593008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286999 0039d316-1c4b-4281-b951-d872f2087c98

12 hours agoMSan: add two more runners for browser_tests.
earthdok@chromium.org [Fri, 1 Aug 2014 13:28:32 +0000 (13:28 +0000)]
MSan: add two more runners for browser_tests.

Also, rename the existing bots.

BUG=178409, 396042
R=glider@chromium.org

Review URL: https://codereview.chromium.org/428953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286986 0039d316-1c4b-4281-b951-d872f2087c98

14 hours agoV8 Buildbot: Make leak check fail the overall build.
machenbach@chromium.org [Fri, 1 Aug 2014 12:26:30 +0000 (12:26 +0000)]
V8 Buildbot: Make leak check fail the overall build.

Continuation of https://codereview.chromium.org/438613002/

TBR=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/424033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286980 0039d316-1c4b-4281-b951-d872f2087c98

14 hours agoFix typo in r286572 "Pass build archive URL explicitly from builder to tester."
earthdok@chromium.org [Fri, 1 Aug 2014 11:58:25 +0000 (11:58 +0000)]
Fix typo in r286572 "Pass build archive URL explicitly from builder to tester."

"archvive" -> "archive"

BUG=none
TBR=szager@chromium.org

Review URL: https://codereview.chromium.org/431323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286979 0039d316-1c4b-4281-b951-d872f2087c98

14 hours agoRevert of Run the windows mini_installer tests on chromium win trybots. (https:/...
phajdan.jr@chromium.org [Fri, 1 Aug 2014 11:48:44 +0000 (11:48 +0000)]
Revert of Run the windows mini_installer tests on chromium win trybots. (https://codereview.chromium.org/423533002/)

Reason for revert:
Broken on win_chromium_x64_rel, e.g. http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/2334/steps/test_installer%20%28with%20patch%29/logs/stdio

F[0801/040546:ERROR:shell_util.cc(1361)] Cannot resolve shortcut at C:\Users\chrome-bot\AppData\Roaming\Microsoft\Internet Explorer\Quick Launch\User Pinned\TaskBar\Windows Media Player.lnk
[0801/040546:ERROR:product.cc(126)] Failed to Open or Write MSI valueto client state key. error: 2
[0801/040546:ERROR:product.cc(126)] Failed to Open or Write MSI valueto client state key. error: 2
[0801/040547:ERROR:product.cc(126)] Failed to Open or Write MSI valueto client state key. error: 2
F[0801/040559:ERROR:shell_util.cc(1361)] Cannot resolve shortcut at C:\ProgramData\Microsoft\Windows\Start Menu\Programs\Windows Media Player.lnk
[0801/040559:ERROR:shell_util.cc(1361)] Cannot resolve shortcut at C:\Users\chrome-bot\AppData\Roaming\Microsoft\Internet Explorer\Quick Launch\User Pinned\TaskBar\Windows Media Player.lnk
[0801/040559:ERROR:product.cc(126)] Failed to Open or Write MSI valueto client state key. error: 2
[0801/040559:ERROR:product.cc(126)] Failed to Open or Write MSI valueto client state key. error: 2
[0801/040600:ERROR:product.cc(126)] Failed to Open or Write MSI valueto client state key. error: 2

Original issue's description:
> Run the windows mini_installer tests on chromium win trybots.
>
> BUG=264859
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=286840
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=286883

TBR=agable@chromium.org,dpranke@chromium.org,grt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=264859

Review URL: https://codereview.chromium.org/434623007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286976 0039d316-1c4b-4281-b951-d872f2087c98

15 hours agoV8 Buildbot: Redistribute mac slaves.
machenbach@chromium.org [Fri, 1 Aug 2014 10:48:39 +0000 (10:48 +0000)]
V8 Buildbot: Redistribute mac slaves.

This balances the overall cycle time of the bots.

Continuation of https://codereview.chromium.org/436843002/

TBR=nodir@chromium.org

Review URL: https://codereview.chromium.org/438903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286973 0039d316-1c4b-4281-b951-d872f2087c98

15 hours agoV8 Buildbot: Let mac bots share common build dirs.
machenbach@chromium.org [Fri, 1 Aug 2014 10:44:39 +0000 (10:44 +0000)]
V8 Buildbot: Let mac bots share common build dirs.

Release and debug can share the same build directory to save
sync time. Slaves are going to be shared in a follow up.

Continuation of https://codereview.chromium.org/423593004/

TBR=nodir@chromium.org

Review URL: https://codereview.chromium.org/436843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286972 0039d316-1c4b-4281-b951-d872f2087c98

18 hours agoDisable unit_tests on the mac_asan trybot to match the behavior of the Mac ASan buildbot
glider@chromium.org [Fri, 1 Aug 2014 08:01:39 +0000 (08:01 +0000)]
Disable unit_tests on the mac_asan trybot to match the behavior of the Mac ASan buildbot
on the Memory waterfall. unit_tests crash at startup in 32-bit OSX builds because some
libraries interleave with the shadow memory mapping.

mac_asan_64 trybot and the Mac ASan 64-bit bot on the Memory waterfall run unit_tests,
so we do not lose much coverage here.

BUG=381489,238398
R=sergeyberezin@chromium.org

Review URL: https://codereview.chromium.org/424753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286966 0039d316-1c4b-4281-b951-d872f2087c98

18 hours agoV8 revision fix part 2
hinoka@chromium.org [Fri, 1 Aug 2014 07:40:35 +0000 (07:40 +0000)]
V8 revision fix part 2

https://codereview.chromium.org/426243009/ attempted to thread a got_revision_mapping_override
through chromium_factory.ChromiumFactory(), but it instead threaded it
through chromium_factory.ChromiumFactory().ChromiumFactory().  This CL threads it through the right place.

Also makes sure that src/v8 points to got_revision, since the backwards update can strip out src/v8: got_revision in favor of src/v8: got_v8_revision.

got_revision_mapping really is backwards, but we'll just have to hack around it for now.

BUG=393784

Review URL: https://codereview.chromium.org/437463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286958 0039d316-1c4b-4281-b951-d872f2087c98

25 hours agoLengthen timeout for master start testing.
petermayo@chromium.org [Fri, 1 Aug 2014 00:51:49 +0000 (00:51 +0000)]
Lengthen timeout for master start testing.

On my machine chromiumos.tryserver is too often failing to start in 10
seconds but does in 20.

R=nodir@chromium.org, agable@chromium.org
BUG=None
TEST=local

Review URL: https://codereview.chromium.org/420683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286926 0039d316-1c4b-4281-b951-d872f2087c98

26 hours agomoving build63-a1 to ccompute
friedman@google.com [Fri, 1 Aug 2014 00:19:26 +0000 (00:19 +0000)]
moving build63-a1 to ccompute

R=tonyg@chromium.org, pgervais@google.com, tonyg@google.com
BUG=

Review URL: https://codereview.chromium.org/431903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286924 0039d316-1c4b-4281-b951-d872f2087c98

26 hours agoUpdate chromiumos template referencing chromium.chromiumos
petermayo@chromium.org [Fri, 1 Aug 2014 00:04:22 +0000 (00:04 +0000)]
Update chromiumos template referencing chromium.chromiumos

BUG=363401, None
TEST=local start, examine html, try modified urls
R=dnj@chromium.org

Review URL: https://codereview.chromium.org/428783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286921 0039d316-1c4b-4281-b951-d872f2087c98

28 hours agoRemove all the files in the temp directory on a slave, instead of a whitelist of...
jam@chromium.org [Thu, 31 Jul 2014 21:41:10 +0000 (21:41 +0000)]
Remove all the files in the temp directory on a slave, instead of a whitelist of files.

The current whitelist still left > 60K files on some windows trybots, and that led to an increase of 15-20 minutes per try job on the most cluttered bots.

BUG=399109

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=286846

Review URL: https://codereview.chromium.org/431863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286896 0039d316-1c4b-4281-b951-d872f2087c98

30 hours agoRun the windows mini_installer tests on chromium win trybots.
grt@chromium.org [Thu, 31 Jul 2014 20:26:31 +0000 (20:26 +0000)]
Run the windows mini_installer tests on chromium win trybots.

BUG=264859

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=286840

Review URL: https://codereview.chromium.org/423533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286883 0039d316-1c4b-4281-b951-d872f2087c98

30 hours agoRevert of Run the windows mini_installer tests on chromium win trybots. (https:/...
grt@chromium.org [Thu, 31 Jul 2014 19:37:50 +0000 (19:37 +0000)]
Revert of Run the windows mini_installer tests on chromium win trybots. (https://codereview.chromium.org/423533002/)

Reason for revert:
Doesn't work.

Original issue's description:
> Run the windows mini_installer tests on chromium win trybots.
>
> BUG=264859
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=286840

TBR=phajdan.jr@chromium.org,agable@chromium.org,dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=264859

Review URL: https://codereview.chromium.org/430313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286865 0039d316-1c4b-4281-b951-d872f2087c98

30 hours agoAdd /json/trybots to client.skia
borenet@google.com [Thu, 31 Jul 2014 19:37:43 +0000 (19:37 +0000)]
Add /json/trybots to client.skia

This is needed so that Rietveld can query the /json/trybots page instead of
/json/builders, which will contain both trybots and waterfall bots on the
client.skia master.

The page currently gives a NotImplementedError because there are no trybots
yet to display.

Part of a set of changes split out from https://codereview.chromium.org/417513003/

BUG=skia:761

Review URL: https://codereview.chromium.org/421033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286864 0039d316-1c4b-4281-b951-d872f2087c98

31 hours agoRevert of Remove all the files in the temp directory on a slave, instead of a whiteli...
tonyg@chromium.org [Thu, 31 Jul 2014 19:19:42 +0000 (19:19 +0000)]
Revert of Remove all the files in the temp directory on a slave, instead of a whitelist of files. (https://codereview.chromium.org/431863002/)

Reason for revert:
Breaks StartVirtualX() because it relies on a temp file. I'm sure we can fix that and reland, but I'm reverting for now to get the bots green in the meantime.

Traceback (most recent call last):
  File "../../../scripts/slave/runtest.py", line 1904, in <module>
    sys.exit(main())
  File "../../../scripts/slave/runtest.py", line 1875, in main
    result = _MainLinux(options, args, extra_env)
  File "../../../scripts/slave/runtest.py", line 1261, in _MainLinux
    server_dir=special_xvfb_dir)
  File "/b/build/scripts/slave/xvfb.py", line 61, in StartVirtualX
    raise Exception('Display already present.')
Exception: Display already present.

Example:
http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%282%29/builds/2519/steps/page_cycler.intl_ja_zh/logs/stdio

Original issue's description:
> Remove all the files in the temp directory on a slave, instead of a whitelist of files.
>
> The current whitelist still left > 60K files on some windows trybots, and that led to an increase of 15-20 minutes per try job on the most cluttered bots.
>
> BUG=399109
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=286846

TBR=maruel@chromium.org,iannucci@chromium.org,jam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=399109

Review URL: https://codereview.chromium.org/432003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286863 0039d316-1c4b-4281-b951-d872f2087c98

31 hours agoV8 Buildbot: Redistribute win xp slaves.
machenbach@chromium.org [Thu, 31 Jul 2014 18:53:11 +0000 (18:53 +0000)]
V8 Buildbot: Redistribute win xp slaves.

TBR=nodir@chromium.org

Review URL: https://codereview.chromium.org/423593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286861 0039d316-1c4b-4281-b951-d872f2087c98

31 hours agoUse GYP_CROSSCOMPILE=1 in ARM/linux cross builders.
sbc@chromium.org [Thu, 31 Jul 2014 18:38:36 +0000 (18:38 +0000)]
Use GYP_CROSSCOMPILE=1 in ARM/linux cross builders.

And remove setting of CC/CXX in the bot config.  The
setting of the compiler is now done in common.gypi
for both clang and gcc.

This change is needed as part of the transition to using
clang be default.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/417283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286860 0039d316-1c4b-4281-b951-d872f2087c98

32 hours agoRemove all the files in the temp directory on a slave, instead of a whitelist of...
jam@chromium.org [Thu, 31 Jul 2014 17:51:03 +0000 (17:51 +0000)]
Remove all the files in the temp directory on a slave, instead of a whitelist of files.

The current whitelist still left > 60K files on some windows trybots, and that led to an increase of 15-20 minutes per try job on the most cluttered bots.

BUG=399109

Review URL: https://codereview.chromium.org/431863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286846 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoRun the windows mini_installer tests on chromium win trybots.
grt@chromium.org [Thu, 31 Jul 2014 17:19:56 +0000 (17:19 +0000)]
Run the windows mini_installer tests on chromium win trybots.

BUG=264859

Review URL: https://codereview.chromium.org/423533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286840 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoReland support for retrying of telemetry_unittests again (take 3).
dpranke@chromium.org [Thu, 31 Jul 2014 16:46:06 +0000 (16:46 +0000)]
Reland support for retrying of telemetry_unittests again (take 3).

The previous two commits that got reverted - r286260 and r285595 -
were actually both fine, but they revealed bugs in chrome code
that caused badness.

This patch is the same as the others, with one additional check to
ensure that the json results files are consistent with the
exit code from the python command.

R=iannucci@chromium.org
BUG=359521

Review URL: https://codereview.chromium.org/433703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286821 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoV8 Buildbot: Refactor test results presentation.
machenbach@chromium.org [Thu, 31 Jul 2014 16:33:46 +0000 (16:33 +0000)]
V8 Buildbot: Refactor test results presentation.

BUG=398391
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/434683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286816 0039d316-1c4b-4281-b951-d872f2087c98

34 hours agoChange to using external_master by default on public buildbots.
petermayo@chromium.org [Thu, 31 Jul 2014 15:55:53 +0000 (15:55 +0000)]
Change to using external_master by default on public buildbots.

R=dnj@chromium.org
TBR=dnj@chromium.org

BUG=398079
TEST=local start

Review URL: https://codereview.chromium.org/434453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286815 0039d316-1c4b-4281-b951-d872f2087c98

34 hours agoV8 Buildbot: Separate memcheck from linux debug.
machenbach@chromium.org [Thu, 31 Jul 2014 15:37:36 +0000 (15:37 +0000)]
V8 Buildbot: Separate memcheck from linux debug.

BUG=
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/435633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286814 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agoV8 Buildbot: Fix win perf.
machenbach@chromium.org [Thu, 31 Jul 2014 14:52:56 +0000 (14:52 +0000)]
V8 Buildbot: Fix win perf.

Made this 64 bits by mistake in https://codereview.chromium.org/423393004/

BUG=
TBR=ishell@chromium.org

Review URL: https://codereview.chromium.org/429453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286810 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agoRemove Angle build hack
hjd@chromium.org [Thu, 31 Jul 2014 13:50:25 +0000 (13:50 +0000)]
Remove Angle build hack

BUG=395705

Review URL: https://codereview.chromium.org/431943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286799 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agoV8 Buildbot: Make simple leak check show failures.
machenbach@chromium.org [Thu, 31 Jul 2014 13:43:16 +0000 (13:43 +0000)]
V8 Buildbot: Make simple leak check show failures.

This step silently failed since a while now.

This is an experimental fix attempt. Unfortunately, valgrind
is never returning a different error code than 0 on leak
checks, so we fish in the output now.

BUG=
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/438613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286795 0039d316-1c4b-4281-b951-d872f2087c98

37 hours agoV8 Buildbot: Fix test results summary and make tests always run.
machenbach@chromium.org [Thu, 31 Jul 2014 13:04:45 +0000 (13:04 +0000)]
V8 Buildbot: Fix test results summary and make tests always run.

This is hijacking https://codereview.chromium.org/424153003/

BUG=398391
TBR=martiniss@chromium.org

Review URL: https://codereview.chromium.org/435603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286780 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoclient.skia: Use GitilesPoller instead of GitPoller
borenet@google.com [Thu, 31 Jul 2014 11:26:26 +0000 (11:26 +0000)]
client.skia: Use GitilesPoller instead of GitPoller

BUG=skia:761

Review URL: https://codereview.chromium.org/431623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286734 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoAdd configuration for arm64 testers.
navabi@google.com [Thu, 31 Jul 2014 10:32:55 +0000 (10:32 +0000)]
Add configuration for arm64 testers.

BUG=

Review URL: https://codereview.chromium.org/428153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286732 0039d316-1c4b-4281-b951-d872f2087c98

41 hours agoAdd akuegel@ to codesearch notification list
jochen@chromium.org [Thu, 31 Jul 2014 09:05:14 +0000 (09:05 +0000)]
Add akuegel@ to codesearch notification list

R=akuegel@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/435523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286727 0039d316-1c4b-4281-b951-d872f2087c98

43 hours agoV8 Buildbot: Shorten runtime of nightly deopt fuzzer.
machenbach@chromium.org [Thu, 31 Jul 2014 07:20:53 +0000 (07:20 +0000)]
V8 Buildbot: Shorten runtime of nightly deopt fuzzer.

It takes currently longer than a night.

TBR=jkummerow@chromium.org

BUG=

Review URL: https://codereview.chromium.org/432723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286722 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoFixes perf recipe being aborted early due to failure.
martiniss@chromium.org [Thu, 31 Jul 2014 00:57:37 +0000 (00:57 +0000)]
Fixes perf recipe being aborted early due to failure.

Right now, the perf recipe quits as soon as any step fails. This is bad
both because we don't run the other tests, and because cleanup and build
progress uploads never occur. This occurred because of the Recipes 1.5
refactoring.

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/423583005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286664 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoFix v8 got_revisions
hinoka@chromium.org [Thu, 31 Jul 2014 00:22:57 +0000 (00:22 +0000)]
Fix v8 got_revisions

So the way got_revisions work right now is a bit scary.  Instead of using the
normal got_revision_mapping codepath, at the end of the GClient step, chromium_steps.py's
Gclient step catches the got_revision emission, tosses it on the ground, and replaces
it with got_v8_revision.

The problem with this is that it completely bypasses the existing and sanctioned
"got_revision_mapping" passed into the step, and hacks it at the end of a step
on the master side to mask what gclient has already emitted to something else.
But this only happens on the gclient step, and is not portable (and we don't want
it to be portable) over to bot_update.  This is why bot_update client.v8 builders
are currently emitting a chromium got_revision instead of a V8 got_revision.

This CL adds an option to do got_revision_mapping_overrides at the ChromiumFactory
initilization level so that bot_update can also get the same revision_mapping.

BUG=393784

Review URL: https://codereview.chromium.org/426243009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286655 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdded the ok_ret keyword argument to api.step.run()
martiniss@chromium.org [Wed, 30 Jul 2014 23:51:52 +0000 (23:51 +0000)]
Added the ok_ret keyword argument to api.step.run()

This allows for nicer control of when exceptions get thrown by the
recipe engine.

BUG=398487

Review URL: https://codereview.chromium.org/425873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286640 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoFix typo in logcat_dump gs uploads
luqui@chromium.org [Wed, 30 Jul 2014 22:33:15 +0000 (22:33 +0000)]
Fix typo in logcat_dump gs uploads

BUG=378944

Review URL: https://codereview.chromium.org/427343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286620 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoReplace vm737-m4 with vm747-m4 in master.tryserver.nacl
pschmidt@chromium.org [Wed, 30 Jul 2014 22:02:07 +0000 (22:02 +0000)]
Replace vm737-m4 with vm747-m4 in tryserver.nacl

BUG=394156

Review URL: https://codereview.chromium.org/429393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286612 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoReland (try 3) of stripping revs from custom deps in bot_update
hinoka@chromium.org [Wed, 30 Jul 2014 21:57:37 +0000 (21:57 +0000)]
Reland (try 3) of stripping revs from custom deps in bot_update

Reland of https://codereview.chromium.org/426353002/
Which was reverted in https://codereview.chromium.org/432553002/
This CL fixes the bug in the last patch.
Tested and passed locally via local master+slave config.

Turns out this is necessary otherwise gclient sync turns src/v8 back
into an SVN dep.

BUG=261741
TBR=machenbach

Review URL: https://codereview.chromium.org/428333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286610 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRevert of Reland of stripping $$ revs from custom deps in bot_update (https://coderev...
hinoka@google.com [Wed, 30 Jul 2014 21:39:36 +0000 (21:39 +0000)]
Revert of Reland of stripping $$ revs from custom deps in bot_update (https://codereview.chromium.org/426353002/)

Reason for revert:
Bug that testing didn't catch QQ, breaks the world

Original issue's description:
> Reland of stripping $$ revs from custom deps in bot_update
>
> Turns out this is necessary otherwise gclient sync turns src/v8 back
> into an SVN dep.
>
> BUG=261741
> TBR=machenbach
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=286600

TBR=machenbach@chromium.org,iannucci@chromium.org,hinoka@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=261741

Review URL: https://codereview.chromium.org/432553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286601 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoReland of stripping $$ revs from custom deps in bot_update
hinoka@chromium.org [Wed, 30 Jul 2014 21:30:37 +0000 (21:30 +0000)]
Reland of stripping $$ revs from custom deps in bot_update

Turns out this is necessary otherwise gclient sync turns src/v8 back
into an SVN dep.

BUG=261741
TBR=machenbach

Review URL: https://codereview.chromium.org/426353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286600 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoMake arm64_builder_rel compile hera targets.
jbudorick@chromium.org [Wed, 30 Jul 2014 21:14:03 +0000 (21:14 +0000)]
Make arm64_builder_rel compile hera targets.

Expectation changes are in https://chromereviews.googleplex.com/69947016/

BUG=

Review URL: https://codereview.chromium.org/423393007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286597 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdding lkgr builder for UBSan vptr
byoungyoung@chromium.org [Wed, 30 Jul 2014 21:06:30 +0000 (21:06 +0000)]
Adding lkgr builder for UBSan vptr

Since the slave VM for UBSan vptr is not ready yet, TSAN's builder is used for now.

BUG=174801
TBR=inferno@chromium.org

Review URL: https://codereview.chromium.org/428243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286596 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoEnable bot_update on the rest of client.v8 builders
hinoka@chromium.org [Wed, 30 Jul 2014 20:51:08 +0000 (20:51 +0000)]
Enable bot_update on the rest of client.v8 builders

V8 revision change landed.  This is probably ready, will watch.

BUG=393784
TBR=machenbach

Review URL: https://codereview.chromium.org/425403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286592 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdd smoothness.tough_filters_cases to default benchmark set.
senorblanco@chromium.org [Wed, 30 Jul 2014 20:28:11 +0000 (20:28 +0000)]
Add smoothness.tough_filters_cases to default benchmark set.

BUG=398624

Review URL: https://codereview.chromium.org/425263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286591 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRevert portion of 286574 that strips out custom_deps
hinoka@chromium.org [Wed, 30 Jul 2014 19:23:40 +0000 (19:23 +0000)]
Revert portion of 286574 that strips out custom_deps

https://codereview.chromium.org/397373002/ has a broken portion of bot_update.
This CL reverts that portion

BUG=261741
TBR=agable

Review URL: https://codereview.chromium.org/429863007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286579 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoEnable bot_update for ChromiumOS Codesearch
hinoka@chromium.org [Wed, 30 Jul 2014 19:19:30 +0000 (19:19 +0000)]
Enable bot_update for ChromiumOS Codesearch

BUG=393781
TBR=agable

Review URL: https://codereview.chromium.org/421033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286578 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoEnable bot_update for webkit DEPS builders
hinoka@chromium.org [Wed, 30 Jul 2014 19:10:41 +0000 (19:10 +0000)]
Enable bot_update for webkit DEPS builders

This is the last of it!
As of https://codereview.chromium.org/422843005/ chromium.webkit no longer
schedules webkit changes to the DEPS builders.  That means bot_update will
actually receive correct revisions all the time even on those builders.

BUG=373456

Review URL: https://codereview.chromium.org/431493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286575 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdd v8 revision resolution for bot_update to commands.py
hinoka@chromium.org [Wed, 30 Jul 2014 19:09:40 +0000 (19:09 +0000)]
Add v8 revision resolution for bot_update to commands.py

Based on top of https://codereview.chromium.org/401703002/

BUG=393784,393785,394150, 393507

Review URL: https://codereview.chromium.org/397373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286574 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoPass build archive URL explicitly from builder to tester.
szager@chromium.org [Wed, 30 Jul 2014 19:06:14 +0000 (19:06 +0000)]
Pass build archive URL explicitly from builder to tester.

R=hinoka@chromium.org,iannucci@chromium.org,agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286572 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRemoved 'master.' prefix in GCStorage
pgervais@chromium.org [Wed, 30 Jul 2014 18:36:24 +0000 (18:36 +0000)]
Removed 'master.' prefix in GCStorage

This makes sure the file name on GCS does not contain a 'master.' prefix.

BUG=376490

Review URL: https://codereview.chromium.org/424303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286565 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoFix time zone handling for git time stamps.
szager@chromium.org [Wed, 30 Jul 2014 18:01:24 +0000 (18:01 +0000)]
Fix time zone handling for git time stamps.

BUG=398846
R=kmg@chromium.org,mmoss@chromium.org,iannucci@chromium.org

Review URL: https://codereview.chromium.org/428213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286559 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRevert r286260 - support retrying of telemetry_unittests.
dpranke@chromium.org [Wed, 30 Jul 2014 17:53:41 +0000 (17:53 +0000)]
Revert r286260 - support retrying of telemetry_unittests.

It looks like the retry logic is wrong, as we're seeing
failures in telemetry_unittests, but we're not retrying
the tests without the patch.

TBR=iannucci@chromium.org
BUG=359521

Review URL: https://codereview.chromium.org/426083007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286556 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoEnable bot_update for chromium codesearch
hinoka@chromium.org [Wed, 30 Jul 2014 17:49:46 +0000 (17:49 +0000)]
Enable bot_update for chromium codesearch

This changes the codesearch builder on chromium.fyi to split out all of its
dependencies into top level solutions (instead of one massive build/ dep) and
turns on bot_update.

The reason this is done in conjunction with turning on bot_update is because
gclient is not able to have slashes in the solution name.

BUG=393781,351896

Review URL: https://codereview.chromium.org/420603015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286555 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoFix GYP environment and executable path for Skia recipe
borenet@google.com [Wed, 30 Jul 2014 17:15:57 +0000 (17:15 +0000)]
Fix GYP environment and executable path for Skia recipe

BUG=skia:761

Review URL: https://codereview.chromium.org/422703007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286544 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoV8 Buildbot: Use updated config for win perf bot.
machenbach@chromium.org [Wed, 30 Jul 2014 12:50:52 +0000 (12:50 +0000)]
V8 Buildbot: Use updated config for win perf bot.

The bot is currently broken. The original config on the perf
waterfall and v8's config diverged. This is an attempt to fix
by making it the same again.

TBR=jochen@chromium.org,
BUG=

Review URL: https://codereview.chromium.org/423393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286500 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoV8 Buildbot: Repair shown revision on blink downstream bots.
machenbach@chromium.org [Wed, 30 Jul 2014 11:58:28 +0000 (11:58 +0000)]
V8 Buildbot: Repair shown revision on blink downstream bots.

The console view should always use the revision of the first
sync attempt. In case of test failures, the recipe syncs to
the pinned revision for comparison, but it should not be used
on the waterfall.

This also adds me to the OWNERS which I forgot in the
initial CLs.

BUG=376950

Review URL: https://codereview.chromium.org/426153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286488 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRestore flakiness dashboard link for gtest annotated runs
phajdan.jr@chromium.org [Wed, 30 Jul 2014 10:24:27 +0000 (10:24 +0000)]
Restore flakiness dashboard link for gtest annotated runs

BUG=378378

Review URL: https://codereview.chromium.org/415113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286466 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoV8 Buildbot: Add 32 bit clang builder.
machenbach@chromium.org [Wed, 30 Jul 2014 09:48:43 +0000 (09:48 +0000)]
V8 Buildbot: Add 32 bit clang builder.

BUG=

Review URL: https://codereview.chromium.org/429843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286456 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoV8 Buildbot: Fix ASAN builder's archive step.
machenbach@chromium.org [Wed, 30 Jul 2014 07:17:06 +0000 (07:17 +0000)]
V8 Buildbot: Fix ASAN builder's archive step.

Fix based on https://codereview.chromium.org/418283007/

TBR=hinoka@chromium.org
BUG=396865

Review URL: https://codereview.chromium.org/423383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286432 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoV8 Buildbot: Add reliable blink bots for all platforms.
machenbach@chromium.org [Wed, 30 Jul 2014 06:32:56 +0000 (06:32 +0000)]
V8 Buildbot: Add reliable blink bots for all platforms.

BUG=376950

Review URL: https://codereview.chromium.org/426963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286422 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoReplace vm530-m4 with vm107-m4 for win_drmemory in master.tryserver.chromium.win
pschmidt@chromium.org [Wed, 30 Jul 2014 02:21:07 +0000 (02:21 +0000)]
Replace vm530-m4 with vm107-m4 for win_drmemory in tryserver.chromium.win

BUG=392340

Review URL: https://codereview.chromium.org/430463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286375 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoNo goma on GN win fyi for now until it's closer to working
scottmg@chromium.org [Wed, 30 Jul 2014 00:35:23 +0000 (00:35 +0000)]
No goma on GN win fyi for now until it's closer to working

R=dpranke@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/431433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286359 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoClean up how Zip build uploads things.
hinoka@chromium.org [Wed, 30 Jul 2014 00:28:02 +0000 (00:28 +0000)]
Clean up how Zip build uploads things.

This does:
1. If no build_url is specified, then skip the package_build step.  This is done
   so that the builders that are classified as "Builders" but don't have triggered
   steps don't waste time trying to package and upload builds.
2. Remove an obsolete builder. (Chromium OS (Obsolete)) on webkit.
3. Add build_url to triggered builders that don't have it.

BUG=396865
TBR=iannucci

Review URL: https://codereview.chromium.org/418283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286357 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoBand-aid fix for ZipBuild to make it not do an exception
hinoka@chromium.org [Tue, 29 Jul 2014 23:37:25 +0000 (23:37 +0000)]
Band-aid fix for ZipBuild to make it not do an exception

https://codereview.chromium.org/413133009/ caused a regression where the builders
that don't set build_url explicitly now fail on an exception.
The fix is in review at https://codereview.chromium.org/418283007/

In the meantime this is a temporary fix so that things aren't completely broken.

BUG=396865
TBR=iannucci

Review URL: https://codereview.chromium.org/429723004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286334 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdded frozen dictionary implementation
dnj@chromium.org [Tue, 29 Jul 2014 23:02:14 +0000 (23:02 +0000)]
Added frozen dictionary implementation

Added implementation of a frozen (immutable) dictionary.

BUG=

Review URL: https://codereview.chromium.org/352213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286327 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoHave webkit deps builder trigger off only src
hinoka@chromium.org [Tue, 29 Jul 2014 22:07:51 +0000 (22:07 +0000)]
Have webkit deps builder trigger off only src

Instead of triggering off both src and trunk, and then ignoring trunk.

BUG=310735

Review URL: https://codereview.chromium.org/422843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286314 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoEdit a few comments in results_dashboard.py.
qyearsley@chromium.org [Tue, 29 Jul 2014 20:54:27 +0000 (20:54 +0000)]
Edit a few comments in results_dashboard.py.

BUG=

Review URL: https://codereview.chromium.org/418753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286287 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdded 'gsutil' metadata support; enabled for CF
dnj@chromium.org [Tue, 29 Jul 2014 20:53:24 +0000 (20:53 +0000)]
Added 'gsutil' metadata support; enabled for CF

Added metadata support to 'gsutil cp' invocations in both 'slave_utils' and
the 'gsutil' recipe module.

Updated ClusterFuzz build script to add 'bot_update'-supplied Chrome revision
metadata when requested.

BUG=384100

Review URL: https://codereview.chromium.org/385813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286286 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoMake first gpu compile failure critical on main waterfall.
iannucci@chromium.org [Tue, 29 Jul 2014 19:30:39 +0000 (19:30 +0000)]
Make first gpu compile failure critical on main waterfall.

R=kbr@chromium.org
BUG=398500

Review URL: https://codereview.chromium.org/426033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286278 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoUpdate links on the main waterfall console for the tryserver split.
sergeyberezin@chromium.org [Tue, 29 Jul 2014 19:09:46 +0000 (19:09 +0000)]
Update links on the main waterfall console for the tryserver split.

R=iannucci@chromium.org
BUG=398101

Review URL: https://codereview.chromium.org/423983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286274 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoChanged uploaded file names in log_uploader
pgervais@chromium.org [Tue, 29 Jul 2014 18:53:24 +0000 (18:53 +0000)]
Changed uploaded file names in log_uploader

This is making the file names more consistent with the buildbot step
names.

BUG=376490

Review URL: https://codereview.chromium.org/417193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286271 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoSwitch broken out-dated 'Aura Ash' fyi bots to Win GN rel/dbg
scottmg@chromium.org [Tue, 29 Jul 2014 18:44:15 +0000 (18:44 +0000)]
Switch broken out-dated 'Aura Ash' fyi bots to Win GN rel/dbg

R=dpranke@chromium.org
BUG=354261

Review URL: https://codereview.chromium.org/422823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286269 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoBug fix for expect tests handling of trailing slashes on directories.
martiniss@chromium.org [Tue, 29 Jul 2014 18:31:30 +0000 (18:31 +0000)]
Bug fix for expect tests handling of trailing slashes on directories.

This fixes a bug where the trailing slash on a directory was the framework
to accidentally delete newly created tests. The fix is to normalize the
directory string when expect tests first gets it.

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/422823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286266 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoHave the arm-l-builder build target hera_test_apk in addition to its current targets.
jbudorick@chromium.org [Tue, 29 Jul 2014 18:14:24 +0000 (18:14 +0000)]
Have the arm-l-builder build target hera_test_apk in addition to its current targets.

BUG=
TBR=navabi@chromium.org

Review URL: https://codereview.chromium.org/429543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286261 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoRe-land r285595 and support retrying telemetry_unittest failures.
dpranke@chromium.org [Tue, 29 Jul 2014 18:14:19 +0000 (18:14 +0000)]
Re-land r285595 and support retrying telemetry_unittest failures.

This patch ports the logic used to retry mojo python tests over
for telemetry and creates a new common subclass.

This patch is also updated to be recipes-1.5-compliant :).

R=iannucci@chromium.org, phajdan.jr@chromium.org
BUG=359521

Review URL: https://codereview.chromium.org/425863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286260 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoFix unicode bug in Skia recipe
borenet@google.com [Tue, 29 Jul 2014 18:03:33 +0000 (18:03 +0000)]
Fix unicode bug in Skia recipe

BUILDER_NAME is getting passed in as a unicode string, which gets split
by builder_name_schema.DictForBuilderName and causes an error when trying
to set c.configuration which expects a regular string.

TBR=rmistry,iannucci

BUG=skia:761

Review URL: https://codereview.chromium.org/426993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286255 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoUpload logs to google storage on android_dbg_triggered_tests_recipe.
luqui@chromium.org [Tue, 29 Jul 2014 17:37:43 +0000 (17:37 +0000)]
Upload logs to google storage on android_dbg_triggered_tests_recipe.

FYI this recipe is only in testing mode and will not cause try failures if it breaks.

BUG=378944

Review URL: https://codereview.chromium.org/426813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286246 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoSupport regular expressions in GitilesPoller branch spec.
szager@chromium.org [Tue, 29 Jul 2014 17:32:45 +0000 (17:32 +0000)]
Support regular expressions in GitilesPoller branch spec.

New branches that match a given regular expression will be
discovered and polled without a master restart.

R=kmg@chromium.org,nodir@chromium.org

Review URL: https://codereview.chromium.org/421293007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286240 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoMake gpu test failure handling correct.
iannucci@chromium.org [Tue, 29 Jul 2014 16:51:11 +0000 (16:51 +0000)]
Make gpu test failure handling correct.

R=kbr@chromium.org, phajdan.jr@chromium.org
BUG=398364

Review URL: https://codereview.chromium.org/425053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286221 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoMake error logic in chromium a bit more robust.
iannucci@chromium.org [Tue, 29 Jul 2014 16:47:40 +0000 (16:47 +0000)]
Make error logic in chromium a bit more robust.

R=machenbach@chromium.org, phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/422293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286218 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoclient.skia: Change NoGPU slavename
borenet@google.com [Tue, 29 Jul 2014 15:10:24 +0000 (15:10 +0000)]
client.skia: Change NoGPU slavename

Required to avoid name collision between slaves on client.skia and old Skia master.

BUG=skia:761

Review URL: https://codereview.chromium.org/423753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286197 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoMake chromium recipe retain first test error and run all tests, raising
machenbach@chromium.org [Tue, 29 Jul 2014 12:55:28 +0000 (12:55 +0000)]
Make chromium recipe retain first test error and run all tests, raising

Continuation of issue https://codereview.chromium.org/422703004/

BUG=398364

Review URL: https://codereview.chromium.org/426913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286183 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoSet test spec when determining dynamic compile targets.
iannucci@chromium.org [Tue, 29 Jul 2014 07:25:18 +0000 (07:25 +0000)]
Set test spec when determining dynamic compile targets.

The pre-1.5 code used a global variable to communicate this information, and
it was missed during the conversion. Because of the defaults (use of .get()),
we missed this during the conversion.

R=jam@chromium.org, martiniss@chromium.org
BUG=398321

Review URL: https://codereview.chromium.org/430453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286107 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAlso remove "%" character from variable name in stats page.
jam@chromium.org [Tue, 29 Jul 2014 06:15:36 +0000 (06:15 +0000)]
Also remove "%" character from variable name in stats page.

BUG=397153,397830

Review URL: https://codereview.chromium.org/422683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286106 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoEnable bot_update for client.skia
hinoka@chromium.org [Tue, 29 Jul 2014 01:30:01 +0000 (01:30 +0000)]
Enable bot_update for client.skia

BUG=261741
TBR=agable,rmistry

Review URL: https://codereview.chromium.org/422143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286043 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoSigh... another GitilesPoller comparator fix.
szager@chromium.org [Tue, 29 Jul 2014 00:28:41 +0000 (00:28 +0000)]
Sigh... another GitilesPoller comparator fix.

TBR=hinoka@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/426783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286041 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoYet another GitilesPoller comparator fix.
szager@chromium.org [Tue, 29 Jul 2014 00:07:15 +0000 (00:07 +0000)]
Yet another GitilesPoller comparator fix.

TBR=stip@chromium.org
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/420863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286035 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoFix GitilesPoller.isRevisionEarlier.
szager@chromium.org [Mon, 28 Jul 2014 23:53:06 +0000 (23:53 +0000)]
Fix GitilesPoller.isRevisionEarlier.

TBR=agable@chromium.org
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/428643005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286030 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoEnable bot_update on Win SyzyASAN LKGR on chromium.fyi
hinoka@chromium.org [Mon, 28 Jul 2014 23:14:52 +0000 (23:14 +0000)]
Enable bot_update on Win SyzyASAN LKGR on chromium.fyi

As of https://codereview.chromium.org/410083006/ cf_archive_build.py should
upload svn revisions even if its bot_update.

BUG=377963,261741,384681
TBR=agable

Review URL: https://codereview.chromium.org/422123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@286023 0039d316-1c4b-4281-b951-d872f2087c98