chromium/tools/build.git
2 hours agoAdd bot_update to chromium gn recipes master
hinoka@google.com [Fri, 25 Apr 2014 03:02:56 +0000 (03:02 +0000)]
Add bot_update to chromium gn recipes

This would also turn on bot_update for chromium_gn, since all of chromium.linux
is whitelisted.

BUG=261741

Review URL: https://codereview.chromium.org/255743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266103 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoSwitch master.chromium.lkgr to poll the chromium-status app.
agable@chromium.org [Fri, 25 Apr 2014 02:36:20 +0000 (02:36 +0000)]
Switch chromium.lkgr to poll the chromium-status app.

Using a PBChangeSource is silly, opaque, and potentially dangerous. We already
have a URLPoller for exactly this use-case (already in use by chromium.endure)
so let's use it here too. This also has the advantage of making sure
the LKGR waterfall picks up *all* updates to LKGR, including manual ones.

R=iannucci@chromium.org, phajdan.jr@chromium.org
BUG=366954

Review URL: https://codereview.chromium.org/255753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266093 0039d316-1c4b-4281-b951-d872f2087c98

4 hours agoRun nacl_loader_unittests on Linux buildbots
hamaji@chromium.org [Fri, 25 Apr 2014 00:44:51 +0000 (00:44 +0000)]
Run nacl_loader_unittests on Linux buildbots

This test is a small test which takes ~8 secs. This test is
built only on Linux.

TEST=scripts/slave/unittests/recipe_configs_test.py
TEST=scripts/slave/unittests/recipe_simulation_test.py
TEST=tests/masters_test.py
BUG=364751

Review URL: https://codereview.chromium.org/243433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266071 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoEnable bot_update for all recipe chromium.linux bots
hinoka@google.com [Fri, 25 Apr 2014 00:20:17 +0000 (00:20 +0000)]
Enable bot_update for all recipe chromium.linux bots

Note this would not turn on Android GN since it is not a chromium.py recipe

BUG=261741
TBR=agable

Review URL: https://codereview.chromium.org/251413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266068 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agorenamed vm421-m4 to slave453-c4
pgervais@chromium.org [Fri, 25 Apr 2014 00:14:01 +0000 (00:14 +0000)]
renamed vm421-m4 to slave453-c4

BUG=302063

Review URL: https://codereview.chromium.org/255543008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266065 0039d316-1c4b-4281-b951-d872f2087c98

5 hours agoArchive android builds to chrome-perf bucket.
tonyg@chromium.org [Fri, 25 Apr 2014 00:13:58 +0000 (00:13 +0000)]
Archive android builds to chrome-perf bucket.

This is to put all builds in the same place for easier use by the auto bisect bot.

BUG=362728

Review URL: https://codereview.chromium.org/251653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266064 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoHandle other "passing" results from run-webkit-tests properly.
dpranke@chromium.org [Thu, 24 Apr 2014 23:18:01 +0000 (23:18 +0000)]
Handle other "passing" results from run-webkit-tests properly.

We were rejecting a test result as a failure because the results from
run-webkit-tests were ['CRASH', 'NEEDSMANUALREBASELINE']; the latter
result indicates that the test actually passed.

I really need to re-work run-webkit-tests to just spit out the list
of failures that matter rather than force the recipe to duplicate all of this
complicated logic.

R=iannucci@chromium.org, eseidel@chromium.org, ojan@chromium.org
BUG=366439

Review URL: https://codereview.chromium.org/250743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266035 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoFix the target of the bisect bot.
navabi@google.com [Thu, 24 Apr 2014 23:15:40 +0000 (23:15 +0000)]
Fix the target of the bisect bot.

The bisect script always builds/run Release target.

BUG=336981,362909
TBR=stip@chromium.org

Review URL: https://codereview.chromium.org/254703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266032 0039d316-1c4b-4281-b951-d872f2087c98

6 hours agoAdd get_real_git_hash() to bot_update
hinoka@google.com [Thu, 24 Apr 2014 22:53:24 +0000 (22:53 +0000)]
Add get_real_git_hash() to bot_update

This is to workaround if theres a patch applied on top of our revision from apply_patch

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/259473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266015 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoEnable android ts bots on bot_update.py
hinoka@google.com [Thu, 24 Apr 2014 22:15:12 +0000 (22:15 +0000)]
Enable android ts bots on bot_update.py

https://codereview.chromium.org/255453006 enabled them for recipes but these
are actually non-recipe bots (oops)

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/258693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266005 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoAlso add the vm linux bots to bot_update.py
hinoka@google.com [Thu, 24 Apr 2014 22:03:16 +0000 (22:03 +0000)]
Also add the vm linux bots to bot_update.py

https://codereview.chromium.org/250703002 missed the non-recipe bots.

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/250523005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266004 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoEnable bot_update for android triggered test trybots
hinoka@google.com [Thu, 24 Apr 2014 22:00:03 +0000 (22:00 +0000)]
Enable bot_update for android triggered test trybots

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/255453006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266003 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoEnable bot update for the remainder of the linux bots (vmxyz-m4
hinoka@google.com [Thu, 24 Apr 2014 21:53:21 +0000 (21:53 +0000)]
Enable bot update for the remainder of the linux bots (vmxyz-m4

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/250703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@266001 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agoEnable bot_update for slave[350:400] and slave[102:121]
hinoka@google.com [Thu, 24 Apr 2014 21:44:25 +0000 (21:44 +0000)]
Enable bot_update for slave[350:400] and slave[102:121]

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/253383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265997 0039d316-1c4b-4281-b951-d872f2087c98

8 hours agoMake git step names more specific
kmg@google.com [Thu, 24 Apr 2014 21:24:16 +0000 (21:24 +0000)]
Make git step names more specific

The git step names are very generic, and can only be used once per
recipe execution.  This CL makes them specific to a checkout, so
multiple git repositories can be checked out within a single recipe.

R=iannucci@chromium.org, nodir@chromium.org
BUG=363611

Review URL: https://codereview.chromium.org/240273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265995 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoDisable bot_update on linux_chromeos_browser_asan
hinoka@google.com [Thu, 24 Apr 2014 20:17:10 +0000 (20:17 +0000)]
Disable bot_update on linux_chromeos_browser_asan

Re-enable after TS restart to pick up https://codereview.chromium.org/248463002/

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/253483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265979 0039d316-1c4b-4281-b951-d872f2087c98

12 hours agoSet up FYI buildbots for Windows Clang in Debug and ASan mode
hans@chromium.org [Thu, 24 Apr 2014 17:05:59 +0000 (17:05 +0000)]
Set up FYI buildbots for Windows Clang in Debug and ASan mode

BUG=363676

Review URL: https://codereview.chromium.org/250303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265945 0039d316-1c4b-4281-b951-d872f2087c98

12 hours agochromium_win_clang: run the standard set of windows tests
hans@chromium.org [Thu, 24 Apr 2014 17:05:54 +0000 (17:05 +0000)]
chromium_win_clang: run the standard set of windows tests

This seems to be tests_win_1 + tests_win_2. I noticed that this doesn't
include content_unittests, which we're currently running. Maybe that should
be added to this list?

Also, don't set Clobber=true. The clang update script will automatically clobber
the build if a new clang version is pulled down and it would be good for the
bot the exercise this functionality.

BUG=82385

Review URL: https://codereview.chromium.org/253343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265944 0039d316-1c4b-4281-b951-d872f2087c98

14 hours agoRevert of Revert of Revert of WebRTC: Switch client.webrtc Android bots over to recip...
kjellander@chromium.org [Thu, 24 Apr 2014 15:04:30 +0000 (15:04 +0000)]
Revert of Revert of Revert of WebRTC: Switch client.webrtc Android bots over to recipes (take 2) (https://codereview.chromium.org/259563002/)

Reason for revert:
Somehow, the builders gets the revision passed correctly but testers that are triggered by the builders gets WebRTC revisions instead of HEAD synced like this: --revision src@5550

Reverting again for further investigation.

Original issue's description:
> Revert of Revert of WebRTC: Switch client.webrtc Android bots over to recipes (take 2) (https://codereview.chromium.org/240363002/)
>
> Reason for revert:
> Re-landing this as https://codereview.chromium.org/247943002/ should fix the issues discovered in previous landing attempt.
>
> Original issue's description:
> > Revert of WebRTC: Switch client.webrtc Android bots over to recipes (take 2) (https://codereview.chromium.org/240143002/)
> >
> > Reason for revert:
> > Build failures due to --revision src@5919 being passed to gclient sync.
> >
> >
> > Original issue's description:
> > > WebRTC: Switch client.webrtc Android bots over to recipes (take 2)
> > >
> > > This re-deploys the buildbot config of
> > > https://codereview.chromium.org/229463005
> > > (that was reverted in r262948)
> > >
> > > With the fixes in https://codereview.chromium.org/235243003/
> > > and the mentioned WebRTC fixes in that CL, this switch
> > > should work.
> > >
> > > BUG=346198
> > > TEST=None
> > >
> > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=264193
> >
> > TBR=phoglund@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=346198
> >
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=264195
>
> TBR=phoglund@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=346198
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=265874

TBR=phoglund@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=346198

Review URL: https://codereview.chromium.org/251393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265920 0039d316-1c4b-4281-b951-d872f2087c98

17 hours agoPRESUBMIT: Exclude isolate folders from pylint check.
kjellander@chromium.org [Thu, 24 Apr 2014 12:29:49 +0000 (12:29 +0000)]
PRESUBMIT: Exclude isolate folders from pylint check.

When running local slaves, folders prefixed with 'isolate'
show up on the same level as the build directory for the
builder working directories.
This makes the pylint pick up all .py files in there during
PRESUBMIT.

TEST=Presubmit when uploaded this CL.
BUG=

Review URL: https://codereview.chromium.org/249213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265916 0039d316-1c4b-4281-b951-d872f2087c98

17 hours agoWebRTC: Poll Chromium's SVN mirror instead of Google Code.
kjellander@chromium.org [Thu, 24 Apr 2014 11:37:00 +0000 (11:37 +0000)]
WebRTC: Poll Chromium's SVN mirror instead of Google Code.

When switching builders to recipes, the bots uses the Chromium
mirror by default instead of the Google Code Subversion URL we've
been using before. This causes problems since the builders are
being triggered by changes in the Google Code Subversion repo
and fails to sync from the mirror since that revision has not yet
reached the mirror.

Switching to polling the Chromium mirror instead should solve this.

TEST=Started a local master and checked the right SVN URL is polled.

Review URL: https://codereview.chromium.org/257593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265909 0039d316-1c4b-4281-b951-d872f2087c98

18 hours agoFix LKCR after deploying bot_update to 'Mac Builder'
phajdan.jr@chromium.org [Thu, 24 Apr 2014 10:31:55 +0000 (10:31 +0000)]
Fix LKCR after deploying bot_update to 'Mac Builder'

TBR=hinoka

BUG=none

Review URL: https://codereview.chromium.org/250543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265900 0039d316-1c4b-4281-b951-d872f2087c98

22 hours agoRevert of Revert of WebRTC: Switch client.webrtc Android bots over to recipes (take...
kjellander@chromium.org [Thu, 24 Apr 2014 06:58:38 +0000 (06:58 +0000)]
Revert of Revert of WebRTC: Switch client.webrtc Android bots over to recipes (take 2) (https://codereview.chromium.org/240363002/)

Reason for revert:
Re-landing this as https://codereview.chromium.org/247943002/ should fix the issues discovered in previous landing attempt.

Original issue's description:
> Revert of WebRTC: Switch client.webrtc Android bots over to recipes (take 2) (https://codereview.chromium.org/240143002/)
>
> Reason for revert:
> Build failures due to --revision src@5919 being passed to gclient sync.
>
>
> Original issue's description:
> > WebRTC: Switch client.webrtc Android bots over to recipes (take 2)
> >
> > This re-deploys the buildbot config of
> > https://codereview.chromium.org/229463005
> > (that was reverted in r262948)
> >
> > With the fixes in https://codereview.chromium.org/235243003/
> > and the mentioned WebRTC fixes in that CL, this switch
> > should work.
> >
> > BUG=346198
> > TEST=None
> >
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=264193
>
> TBR=phoglund@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=346198
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=264195

TBR=phoglund@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=346198

Review URL: https://codereview.chromium.org/259563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265874 0039d316-1c4b-4281-b951-d872f2087c98

22 hours agoWebRTC recipe: Fix revision passing for Android APK commit bots.
kjellander@chromium.org [Thu, 24 Apr 2014 06:40:07 +0000 (06:40 +0000)]
WebRTC recipe: Fix revision passing for Android APK commit bots.

When deploying these bots to the client.webrtc build
waterfall, revision information is passed to the gclient sync
command like this example: --revision src@5919
This happens because the code that handles overwriting that
was only turned on for the trybot part of the recipe.

This CL fixes this and also makes use of the 'webrtc_revision'
variable which produces a less hacky gclient spec.

BUG=346198
TEST=I ran:
scripts/tools/run_recipe.py webrtc/android_apk buildername="Android Chromium-APK Builder" mastername="client.webrtc" revision="'5956'"
and verified the right revision flag gets passed and that the build is successful.

Review URL: https://codereview.chromium.org/247943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265873 0039d316-1c4b-4281-b951-d872f2087c98

23 hours agoUpdate list of top box vm slaves displayed on the dart waterfall.
ricow@google.com [Thu, 24 Apr 2014 06:20:13 +0000 (06:20 +0000)]
Update list of top box vm slaves displayed on the dart waterfall.

I forgot this yesterday when sharding on architecture and there was a few missing ones already.

Review URL: https://codereview.chromium.org/254583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265869 0039d316-1c4b-4281-b951-d872f2087c98

28 hours agoAdd Linux Sync to bot_update
hinoka@google.com [Thu, 24 Apr 2014 00:41:37 +0000 (00:41 +0000)]
Add Linux Sync to bot_update

BUG=261741

Review URL: https://codereview.chromium.org/259463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265798 0039d316-1c4b-4281-b951-d872f2087c98

29 hours agoChanged old-style STEP_EXCEPTION to real exception in order to red build
luqui@chromium.org [Thu, 24 Apr 2014 00:05:14 +0000 (00:05 +0000)]
Changed old-style STEP_EXCEPTION to real exception in order to red build

BUG=364082

Review URL: https://codereview.chromium.org/245973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265781 0039d316-1c4b-4281-b951-d872f2087c98

29 hours agoEnable bot_update for Mac Builder
hinoka@google.com [Thu, 24 Apr 2014 00:01:54 +0000 (00:01 +0000)]
Enable bot_update for Mac Builder

BUG=261741

Review URL: https://codereview.chromium.org/250283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265779 0039d316-1c4b-4281-b951-d872f2087c98

30 hours agoAdd a git mode parameter for bot_update
hinoka@google.com [Wed, 23 Apr 2014 23:00:46 +0000 (23:00 +0000)]
Add a git mode parameter for bot_update

This is because --revision HEAD is ambiguous as to whether or not we want to
output a git or SVN got_revision.

BUG=361346

Review URL: https://codereview.chromium.org/258433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265761 0039d316-1c4b-4281-b951-d872f2087c98

31 hours agoFix svn assumption in try_job_base.py's lkgr logic
hinoka@google.com [Wed, 23 Apr 2014 21:59:28 +0000 (21:59 +0000)]
Fix svn assumption in try_job_base.py's lkgr logic

BUG=

Review URL: https://codereview.chromium.org/246403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265746 0039d316-1c4b-4281-b951-d872f2087c98

32 hours agoadded arm64 builder to chromium.fyi
zty@chromium.org [Wed, 23 Apr 2014 21:05:23 +0000 (21:05 +0000)]
added arm64 builder to chromium.fyi

BUG=360540

Review URL: https://codereview.chromium.org/245093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265737 0039d316-1c4b-4281-b951-d872f2087c98

32 hours agoAdd comments and style changes in runtest.py.
qyearsley@chromium.org [Wed, 23 Apr 2014 21:01:10 +0000 (21:01 +0000)]
Add comments and style changes in runtest.py.

BUG=

Review URL: https://codereview.chromium.org/243993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265736 0039d316-1c4b-4281-b951-d872f2087c98

32 hours agoEnable bot_update for slave[300:350]-c4
hinoka@google.com [Wed, 23 Apr 2014 20:33:01 +0000 (20:33 +0000)]
Enable bot_update for slave[300:350]-c4

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/249303006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265729 0039d316-1c4b-4281-b951-d872f2087c98

34 hours agoRevert 265682 "Enable running TabCaptureApiTests.EndToEnd on GPU..."
hubbe@chromium.org [Wed, 23 Apr 2014 18:35:13 +0000 (18:35 +0000)]
Revert 265682 "Enable running TabCaptureApiTests.EndToEnd on GPU..."

> Enable running TabCaptureApiTests.EndToEnd on GPU bots.
>
> BUG=365927
>
> Review URL: https://codereview.chromium.org/247163004

TBR=hubbe@chromium.org

Review URL: https://codereview.chromium.org/249933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265692 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agoEnable running TabCaptureApiTests.EndToEnd on GPU bots.
hubbe@chromium.org [Wed, 23 Apr 2014 17:59:47 +0000 (17:59 +0000)]
Enable running TabCaptureApiTests.EndToEnd on GPU bots.

BUG=365927

Review URL: https://codereview.chromium.org/247163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265682 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agoSplit the vm mac/linux testing on more bots
ricow@google.com [Wed, 23 Apr 2014 16:43:16 +0000 (16:43 +0000)]
Split the vm mac/linux testing on more bots

This will split on architecture.
Also, remove mac bots used for testing the checked config fyi

Review URL: https://codereview.chromium.org/248593005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265670 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoFix checked mode config when default value is None
ricow@google.com [Wed, 23 Apr 2014 14:51:03 +0000 (14:51 +0000)]
Fix checked mode config when default value is None

We actually add it to the map as None, so we can't just use a default value on get here.

Review URL: https://codereview.chromium.org/248153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265641 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoRename dart/dartium_builder recipe to dartium_build.
whesse@google.com [Wed, 23 Apr 2014 14:21:04 +0000 (14:21 +0000)]
Rename dart/dartium_builder recipe to dartium_build.

BUG=

Review URL: https://codereview.chromium.org/248713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265637 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoAdd support for specifying checked mode on the vm tests.
ricow@google.com [Wed, 23 Apr 2014 14:04:31 +0000 (14:04 +0000)]
Add support for specifying checked mode on the vm tests.

The checked_config can be 'checked', 'unchecked', 'both' - defaulting to both.

Add 4 new mac machines on fyi to test this.

Review URL: https://codereview.chromium.org/249303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265634 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoWebRTC: Remove neteq_unittests test from buildbots
kjellander@chromium.org [Wed, 23 Apr 2014 13:18:55 +0000 (13:18 +0000)]
WebRTC: Remove neteq_unittests test from buildbots

These tests are being removed in favor for
the test for NetEQ v4 that are a part of the
modules_unittests binary.

BUG=webrtc:2996

Review URL: https://codereview.chromium.org/249203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265623 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoFix broken links to buildbot steps
kmg@google.com [Wed, 23 Apr 2014 12:56:45 +0000 (12:56 +0000)]
Fix broken links to buildbot steps

Links to buildbot steps would previously fail if the step name contained
a '/' character.  This CL fixes the URL escaping to escape those
characters.

R=agable@chromium.org, iannucci@chromium.org, nodir@chromium.org
BUG=356131

Review URL: https://codereview.chromium.org/240743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265619 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoSplit dartium and multivm builders and testers to separate slaves.
whesse@google.com [Wed, 23 Apr 2014 12:55:25 +0000 (12:55 +0000)]
Split dartium and multivm builders and testers to separate slaves.

BUG=

Review URL: https://codereview.chromium.org/248963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265618 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoRefactore testing commands into seperate methods
ricow@google.com [Wed, 23 Apr 2014 12:40:28 +0000 (12:40 +0000)]
Refactore testing commands into seperate methods

Review URL: https://codereview.chromium.org/249223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265617 0039d316-1c4b-4281-b951-d872f2087c98

41 hours agoWebRTC: Add new slave machines to client.webrtc.
kjellander@chromium.org [Wed, 23 Apr 2014 11:30:16 +0000 (11:30 +0000)]
WebRTC: Add new slave machines to client.webrtc.

BUG=361959

Review URL: https://codereview.chromium.org/247143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265608 0039d316-1c4b-4281-b951-d872f2087c98

43 hours agoAdded cronet_builder config to chromium_android recipes.
mef@chromium.org [Wed, 23 Apr 2014 09:58:53 +0000 (09:58 +0000)]
Added cronet_builder config to chromium_android recipes.
Added cronet recipe with cronet_builder and cronet_rel builders for Android.

BUG=354143

Review URL: https://codereview.chromium.org/243493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265603 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoDisable bot_update on linux_chromeos_asan
hinoka@google.com [Wed, 23 Apr 2014 01:17:33 +0000 (01:17 +0000)]
Disable bot_update on linux_chromeos_asan

We need a TS restart to pick up the cros fix before this works, so lets just
disable bot_update on this builder for now.

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/248193006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265464 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoEnable bot_update for vm[666:671]-m4
hinoka@google.com [Wed, 23 Apr 2014 00:46:59 +0000 (00:46 +0000)]
Enable bot_update for vm[666:671]-m4

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/248543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265447 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRemove cros_deps
hinoka@google.com [Wed, 23 Apr 2014 00:20:03 +0000 (00:20 +0000)]
Remove cros_deps

This isn't used anymore, it just links to a DEPS file with a "Remove me" comment.

BUG=361346

Review URL: https://codereview.chromium.org/248463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265438 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoEnable bot_update for vm[800:810]-m4
hinoka@google.com [Wed, 23 Apr 2014 00:14:56 +0000 (00:14 +0000)]
Enable bot_update for vm[800:810]-m4

This covers mac_x64_rel

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/248283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265435 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoIf using append_deps_patch_sha, don't use the buildnumber in the zip name.
stip@chromium.org [Wed, 23 Apr 2014 00:12:22 +0000 (00:12 +0000)]
If using append_deps_patch_sha, don't use the buildnumber in the zip name.

BUG=310228
R=prasadv@chromium.org, hinoka@chromium.org

Review URL: https://codereview.chromium.org/248233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265434 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoReland of bot_update on official with fix
hinoka@google.com [Tue, 22 Apr 2014 23:45:28 +0000 (23:45 +0000)]
Reland of bot_update on official with fix

Reland of https://codereview.chromium.org/238063010/
Which was reverted in https://codereview.chromium.org/248303002/

The fix was that the DEPS -> .DEPS.git rewriting was removed in the CL.  Its now
added back with some logic to resolve official DEPS.

BUG=261741

Review URL: https://codereview.chromium.org/248183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265419 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoFixing error in generator script module when json.output is None
smut@google.com [Tue, 22 Apr 2014 23:25:54 +0000 (23:25 +0000)]
Fixing error in generator script module when json.output is None

BUG=364948

Review URL: https://codereview.chromium.org/243603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265409 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoDisable cros.DEPS bots from bot_update
hinoka@google.com [Tue, 22 Apr 2014 23:20:03 +0000 (23:20 +0000)]
Disable cros.DEPS bots from bot_update

linux_chromeos_clang has a special solution and is not currently supported by
bot_update.

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/247683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265406 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRevert of Bot Update support on official builders (https://codereview.chromium.org...
hinoka@google.com [Tue, 22 Apr 2014 22:11:45 +0000 (22:11 +0000)]
Revert of Bot Update support on official builders (https://codereview.chromium.org/238063010/)

Reason for revert:
This might be causing a failure here: http://build.chromium.org/p/chromium.linux/builders/Android%20Webview%20AOSP%20Builder/builds/10475

Doing a speculative revert.

Original issue's description:
> Bot Update support on official builders
>
> BUG=
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=265371

TBR=agable@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/248303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265379 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoTurn bot_update on for slave[256:300]
hinoka@google.com [Tue, 22 Apr 2014 21:57:48 +0000 (21:57 +0000)]
Turn bot_update on for slave[256:300]

This seems to be running okay on a couple of trybot instances, lets expand
it from 5 to 50 bots.

BUG=361346

Review URL: https://codereview.chromium.org/247063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265375 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoBot Update support on official builders
hinoka@google.com [Tue, 22 Apr 2014 21:48:07 +0000 (21:48 +0000)]
Bot Update support on official builders

BUG=

Review URL: https://codereview.chromium.org/238063010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265371 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoDo device status check before provisioning instead of after.
luqui@chromium.org [Tue, 22 Apr 2014 21:25:06 +0000 (21:25 +0000)]
Do device status check before provisioning instead of after.

BUG=364650
R=navabi@chromium.org

Review URL: https://codereview.chromium.org/247033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265364 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoReplacing mac builders with 10.8
bevc@chromium.org [Tue, 22 Apr 2014 21:17:38 +0000 (21:17 +0000)]
Replacing mac builders with 10.8

BUG=353529

Review URL: https://codereview.chromium.org/246153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265363 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoEnable bot_update on slave[250:256] on non-recipe builders for the tryserver
hinoka@google.com [Tue, 22 Apr 2014 21:16:29 +0000 (21:16 +0000)]
Enable bot_update on slave[250:256] on non-recipe builders for the tryserver

The last commit enabled it for recipe bots, this enables it for non-recipe bots also.

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/248203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265362 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRevert of Revert of Enable bot update on slave[250:256]-c4 on the tryserver (https...
hinoka@google.com [Tue, 22 Apr 2014 20:30:10 +0000 (20:30 +0000)]
Revert of Revert of Enable bot update on slave[250:256]-c4 on the tryserver (https://codereview.chromium.org/240353004/)

Reason for revert:
Relanding after fix in https://codereview.chromium.org/245983002

Original issue's description:
> Revert of Enable bot update on slave[250:256]-c4 on the tryserver (https://codereview.chromium.org/238023008/)
>
> Reason for revert:
> Failure here:
> http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/16293
>
> Original issue's description:
> > Enable bot update on slave[250:256]-c4 on the tryserver
> >
> > BUG=361346
> >
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=264217
>
> TBR=agable@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=361346
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=264267

TBR=agable@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=361346

Review URL: https://codereview.chromium.org/246993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265348 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoBot Update fixes for tryserver
hinoka@google.com [Tue, 22 Apr 2014 19:22:58 +0000 (19:22 +0000)]
Bot Update fixes for tryserver

* apply_issue.py doesn't need revision mapping, bot_update takes care of that.
* if "origin/lkcr" is passed in for --revision, theres a special case to make bot_update use svn revisions.  This is because that since we're using the exact mechanism to signal to bot_update to checkout lkcr (via --revision origin/lkcr) once we switch to git, theres no way for bot_update to know if it should spit out a git or svn got_revision.
* pass in --ignore_deps to apply_issue so that it doesn't run gclient sync on a deps change.

BUG=361346
TBR=agable

Review URL: https://codereview.chromium.org/245983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265326 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRevert of whitespace change (https://codereview.chromium.org/246973005/)
stip@chromium.org [Tue, 22 Apr 2014 19:16:19 +0000 (19:16 +0000)]
Revert of whitespace change (https://codereview.chromium.org/246973005/)

Reason for revert:
test

Original issue's description:
> whitespace change
>
> TBR=stip@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=265320

TBR=
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/247693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265323 0039d316-1c4b-4281-b951-d872f2087c98

2 days agowhitespace change
stip@chromium.org [Tue, 22 Apr 2014 19:11:27 +0000 (19:11 +0000)]
whitespace change

TBR=stip@chromium.org

Review URL: https://codereview.chromium.org/246973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265320 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdd 5 bots for browser_tests with Dr.Memory full mode on FYI
zhaoqin@google.com [Tue, 22 Apr 2014 18:13:19 +0000 (18:13 +0000)]
Add 5 bots for browser_tests with Dr.Memory full mode on FYI

R=timurrrr@chromium.org, burening@chromium.org
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/247043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265301 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdd the Skia sheriff to the roll email
borenet@google.com [Tue, 22 Apr 2014 17:33:57 +0000 (17:33 +0000)]
Add the Skia sheriff to the roll email

BUG=skia:1945

Review URL: https://codereview.chromium.org/245213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265296 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRemove unused chromium.devtools master.
thakis@chromium.org [Tue, 22 Apr 2014 17:08:32 +0000 (17:08 +0000)]
Remove unused chromium.devtools master.

See discussion on https://codereview.chromium.org/8775010/

BUG=332697

Review URL: https://codereview.chromium.org/245603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265288 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdd support for x64 config
zty@chromium.org [Tue, 22 Apr 2014 16:30:45 +0000 (16:30 +0000)]
Add support for x64 config

BUG=362031

Review URL: https://codereview.chromium.org/245553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265274 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoMove two Dr.Memory light browser_tests bots from MFYI to FYI
zhaoqin@google.com [Tue, 22 Apr 2014 16:06:17 +0000 (16:06 +0000)]
Move two Dr.Memory light browser_tests bots from MFYI to FYI

R=timurrrr@chromium.org, bruening@chromium.org
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/247293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265268 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdd a scheduler for the new Android GN bot.
dpranke@chromium.org [Tue, 22 Apr 2014 15:52:15 +0000 (15:52 +0000)]
Add a scheduler for the new Android GN bot.

I added the "Android GN" bot to the chromium.linux waterfall in r265089,
but it looks like I missed wiring it up to a scheduler. This change
adds that.

R=phajdan.jr@chromium.org
BUG=362329

Review URL: https://codereview.chromium.org/246653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265265 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAutoRoll Bot: if we close an issue, open another one
borenet@google.com [Tue, 22 Apr 2014 15:23:42 +0000 (15:23 +0000)]
AutoRoll Bot: if we close an issue, open another one

BUG=skia:1945

Review URL: https://codereview.chromium.org/230653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265262 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoIncrease win_chromium_x64* timeout to 3600 seconds
phajdan.jr@chromium.org [Tue, 22 Apr 2014 11:49:39 +0000 (11:49 +0000)]
Increase win_chromium_x64* timeout to 3600 seconds

This matches other recipe bot timeouts and is needed
because sometimes the default 1200 seconds timeout
is exceeded.

BUG=none

Review URL: https://codereview.chromium.org/246213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265232 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoFixed pattern matching bug in adb module
luqui@chromium.org [Mon, 21 Apr 2014 21:59:38 +0000 (21:59 +0000)]
Fixed pattern matching bug in adb module

BUG=364086

Review URL: https://codereview.chromium.org/245363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265090 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdd an Android GN bot to the chromium.linux waterfall.
dpranke@chromium.org [Mon, 21 Apr 2014 21:49:54 +0000 (21:49 +0000)]
Add an Android GN bot to the chromium.linux waterfall.

R=phajdan.jr@chromium.org
BUG=362329

Review URL: https://codereview.chromium.org/238413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265089 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdd android_chromium_gn_compile_{dbg,rel} trybots.
dpranke@chromium.org [Mon, 21 Apr 2014 21:47:44 +0000 (21:47 +0000)]
Add android_chromium_gn_compile_{dbg,rel} trybots.

These are compile-only bots w/o devices attached, and they use the
same 'chromium_gn' recipe that the linux bots use, so I'm adding them
the same way I added the linux bots and am re-using the same GCE pool
of VMs (though using new slavebuilddirs, since the checkouts are different).

R=phajdan.jr@chromium.org
BUG=360938

Review URL: https://codereview.chromium.org/240373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265088 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoFixing path module's listdir method
smut@google.com [Mon, 21 Apr 2014 20:59:50 +0000 (20:59 +0000)]
Fixing path module's listdir method

The inline Python script was trying to write to the filename. The file needs to be opened first.

TBR=agable

Review URL: https://codereview.chromium.org/245553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265068 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoSmall changes to fix perf dashboard. Using mastername for 'master' field and 'master...
joshualitt@chromium.org [Mon, 21 Apr 2014 16:51:30 +0000 (16:51 +0000)]
Small changes to fix perf dashboard.  Using mastername for 'master' field and 'masterid' field on dashboard.  using 'slavename' for 'bot' on dashboard.

BUG=

Review URL: https://codereview.chromium.org/240183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265010 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdd URL repository to Polymer checkout.
agable@chromium.org [Mon, 21 Apr 2014 15:42:53 +0000 (15:42 +0000)]
Add URL repository to Polymer checkout.

R=dfreedm@chromium.org, nodir@chromium.org
BUG=361788

Review URL: https://codereview.chromium.org/234063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@265000 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoadjust retry logic in chromium_gn recipe
dpranke@chromium.org [Sun, 20 Apr 2014 21:48:33 +0000 (21:48 +0000)]
adjust retry logic in chromium_gn recipe

Previously we would attempt to check out the code, apply the patch, and
run the hooks, and only then check for error codes and nuke the checkout
is something failed. If the checkout step fails, there's no point in
applying the patch or running the hooks, so this patch now nukes after
the first checkout.

We could theoretically nuke *again* if the checkout works but applying
the patch or running the hooks fails, but that seems like a pretty rare
occurrence, so we'll leave it be for now.

If this turns out to be a real source of flaky try jobs failures, we can
add it back in.

R=phajdan.jr@chromium.org,
BUG=362226

Review URL: https://codereview.chromium.org/228473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264938 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoStop logging the annotated JSON results from webkit_tests to stdio.
dpranke@chromium.org [Fri, 18 Apr 2014 22:22:46 +0000 (22:22 +0000)]
Stop logging the annotated JSON results from webkit_tests to stdio.

This should make our log files a fair amount smaller and more readable.
We don't really need the logging since the results are also uploaded to
googlestorage.

R=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/243833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264872 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRe-land r264861 - "Add Android support to chromium_gn recipe ." w/ fix.
dpranke@chromium.org [Fri, 18 Apr 2014 22:13:23 +0000 (22:13 +0000)]
Re-land r264861 - "Add Android support to chromium_gn recipe ." w/ fix.

The original patch had an extra layer of shell-escaping in it that confused
the GN arg parsing code.

TBR=brettw@chromium.org
BUG=362324

Review URL: https://codereview.chromium.org/242103005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264870 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRevert "Add Android support to chromium_gn recipe ."
dpranke@chromium.org [Fri, 18 Apr 2014 21:55:40 +0000 (21:55 +0000)]
Revert "Add Android support to chromium_gn recipe ."

This reverts commit 05ad9cdd7ffac5f7f9ad3710cd547ecd02c2b6bb.

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/242323005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264864 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAdd Android support to chromium_gn recipe .
dpranke@chromium.org [Fri, 18 Apr 2014 21:36:47 +0000 (21:36 +0000)]
Add Android support to chromium_gn recipe .

Note that this recipe is still compile-only (for both Linux and Android). Nothing yet uses the Andoid support; adding bots for that will follow in separate CLs.

R=phajdan.jr@chromium.org
BUG=362324

Review URL: https://codereview.chromium.org/236293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264861 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAdd content and some other tests with DrMemory light and full mode in FYI bots
zhaoqin@google.com [Fri, 18 Apr 2014 21:03:49 +0000 (21:03 +0000)]
Add content and some other tests with DrMemory light and full mode in FYI bots

R=timurrrr@chromium.org
NOTRY=TRUE

Review URL: https://codereview.chromium.org/240513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264853 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRevert 264828 "Make results_dashboard send just one request per ..."
eroman@chromium.org [Fri, 18 Apr 2014 20:17:04 +0000 (20:17 +0000)]
Revert 264828 "Make results_dashboard send just one request per ..."

> Make results_dashboard send just one request per test run. (version 3)
>
> After version 2, https://codereview.chromium.org/227233011/, we verified that somehow the old list of arguments are being passed to SendResults somewhere somehow even though that CL was also supposed to change the call site in runtest.py.
>
> For this CL, I've made it so that SendResults would also work if called with the original list of arguments; it takes an optional parameter logs_dict, and if logs_dict wasn't given it makes it.
> BUG=
>
> Review URL: https://codereview.chromium.org/236593004

TBR=qyearsley@chromium.org

Review URL: https://codereview.chromium.org/243583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264840 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoMake results_dashboard send just one request per test run. (version 3)
qyearsley@chromium.org [Fri, 18 Apr 2014 19:39:33 +0000 (19:39 +0000)]
Make results_dashboard send just one request per test run. (version 3)

After version 2, https://codereview.chromium.org/227233011/, we verified that somehow the old list of arguments are being passed to SendResults somewhere somehow even though that CL was also supposed to change the call site in runtest.py.

For this CL, I've made it so that SendResults would also work if called with the original list of arguments; it takes an optional parameter logs_dict, and if logs_dict wasn't given it makes it.
BUG=

Review URL: https://codereview.chromium.org/236593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264828 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAdding os.listdir wrapper to recipes path module
smut@google.com [Fri, 18 Apr 2014 18:36:35 +0000 (18:36 +0000)]
Adding os.listdir wrapper to recipes path module

BUG=342817

Review URL: https://codereview.chromium.org/239333010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264819 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoMSan: add content_browsertests to the experimental bot.
earthdok@chromium.org [Fri, 18 Apr 2014 17:57:25 +0000 (17:57 +0000)]
MSan: add content_browsertests to the experimental bot.

BUG=362159, 178409
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/243453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264814 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoMake it possible to exclude builders in chromium_trybot.json
phajdan.jr@chromium.org [Fri, 18 Apr 2014 15:00:42 +0000 (15:00 +0000)]
Make it possible to exclude builders in chromium_trybot.json

This will be needed to exclude slow tests on win_chromium_x64_rel
before we can get more slaves.

BUG=364819

Review URL: https://codereview.chromium.org/243003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264786 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRun gclient sync after gclient revert
phajdan.jr@chromium.org [Fri, 18 Apr 2014 14:55:21 +0000 (14:55 +0000)]
Run gclient sync after gclient revert

This prevents incomplete reverts e.g. when rolling DEPS.

BUG=358528

Review URL: https://codereview.chromium.org/242973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264784 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoAdd --verbose flag to recipe_config_test.py to print exception stack traces.
vadimsh@chromium.org [Thu, 17 Apr 2014 23:43:54 +0000 (23:43 +0000)]
Add --verbose flag to recipe_config_test.py to print exception stack traces.

Without stack traces errors reported by recipe_configs_test are hard to debug
(especially considering an esoteric nature of config system).

Also make exceptions in config evaluation to fail the test.

Also fix a minor bug in v8 recipe module that went unnoticied because
config test failures were not counted as failures if coverage is at 100%.

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/240573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264673 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoAdd vm[798..799]-m4 to win_gpu configuration.
kbr@chromium.org [Thu, 17 Apr 2014 17:25:54 +0000 (17:25 +0000)]
Add vm[798..799]-m4 to win_gpu configuration.

BUG=360364

Review URL: https://codereview.chromium.org/240533005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264558 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoRemove build[41..48]-b4 from linux_gpu on master.tryserver.chromium.gpu.
kbr@chromium.org [Thu, 17 Apr 2014 17:11:12 +0000 (17:11 +0000)]
Remove build[41..48]-b4 from linux_gpu on tryserver.chromium.gpu.

Returning these physical builders to the machine pool.

BUG=360364

Review URL: https://codereview.chromium.org/239343016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264549 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoSupport running Monkey tests on different channel builds.
klundberg@chromium.org [Thu, 17 Apr 2014 16:31:20 +0000 (16:31 +0000)]
Support running Monkey tests on different channel builds.

To support https://chromereviews.googleplex.com/33437013/

BUG=360126

Review URL: https://codereview.chromium.org/227553009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264544 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoUse use_allocator instead of linux_use_tcmalloc in buildbots.
dmikurube@chromium.org [Thu, 17 Apr 2014 07:34:21 +0000 (07:34 +0000)]
Use use_allocator instead of linux_use_tcmalloc in buildbots.

See http://crrev.com/177353002 and the bug for the details.

BUG=345554

Review URL: https://codereview.chromium.org/212883012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264460 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoVarious minor improvements to recipe_simulation_test.py.
vadimsh@chromium.org [Thu, 17 Apr 2014 00:57:28 +0000 (00:57 +0000)]
Various minor improvements to recipe_simulation_test.py.

* Implicitly append '*' to the test glob. That way
  'recipe_simluation_test train <recipe_name>' will actually discover required
  tests (named <recipe_name>.<test_name>) which is expected behavior.
* Print a message and fail the run if given test glob doesn't match any tests.
* Do not break in mods.step.API.__call__ when running in debug mode. It's
  very confusing. Still break at GenSteps though.

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/240053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264370 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoStop running components_unittests on linux_tsan
hamaji@chromium.org [Thu, 17 Apr 2014 00:07:50 +0000 (00:07 +0000)]
Stop running components_unittests on linux_tsan

Dmitry said TSAN v1 is deprecated and excluding tests is fine:

http://codereview.chromium.org/196793023/

In the above change, we will add a test for a new seccomp-bpf
filter into components_unittests and Seccomp-BPF is not
compatible with TSAN.

As far as I checked, these two builders are the only ones who
run components_unittests on TSAN v1.

BUG=243968, 359285

Review URL: https://codereview.chromium.org/238353010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264360 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoAdded slave[423..452]-c4 to linux_gpu, to replace the physical builders.
kbr@chromium.org [Wed, 16 Apr 2014 22:57:04 +0000 (22:57 +0000)]
Added slave[423..452]-c4 to linux_gpu, to replace the physical builders.

BUG=360364

Review URL: https://codereview.chromium.org/237583012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264336 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoRevert "linux_arm_tester: enabled bot_update"
nodir@chromium.org [Wed, 16 Apr 2014 22:44:59 +0000 (22:44 +0000)]
Revert "linux_arm_tester: enabled bot_update"

This reverts commit 26a484d1dc0d946f2fb42244c1478e58956e90d6.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264335 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoFix to be able build python's coverage package on Windows.
sebmarchand@chromium.org [Wed, 16 Apr 2014 22:20:01 +0000 (22:20 +0000)]
Fix to be able build python's coverage package on Windows.

If we want to be able to build the coverage package on Windows we need to have the VS90COMNTOOLS environment variable set.

This shouldn't necessary point to an installation of VS2008 (at least for this package), this is only used by http://svn.python.org/projects/python/branches/release27-maint/Lib/distutils/msvc9compiler.py to find vcvarsall.bat. We can fake it to point to the version of MSVC checked in to depot_tools.

This mean that we'll use VS2013 compiler and linker, to build this package (while Python27's build with VS2008).

R=iannucci@chromium.org, scottmg@chromium.org

BUG=361796

Review URL: https://codereview.chromium.org/239163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264327 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoRetry failed gclient revert steps in the GPU recipe.
kbr@chromium.org [Wed, 16 Apr 2014 21:44:51 +0000 (21:44 +0000)]
Retry failed gclient revert steps in the GPU recipe.

BUG=354731,357767

Review URL: https://codereview.chromium.org/239263010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264315 0039d316-1c4b-4281-b951-d872f2087c98