chromium/tools/build.git
53 min agoRevert 264076 "win: Remove explicit goma-related GYP_DEFINES." master
jochen@chromium.org [Wed, 16 Apr 2014 09:17:19 +0000 (09:17 +0000)]
Revert 264076 "win: Remove explicit goma-related GYP_DEFINES."

> win: Remove explicit goma-related GYP_DEFINES.
>
> Chromium's build/common.gypi should set things like this automatically now
> that we use use_goma=1.
>
> BUG=332697
>
> Review URL: https://codereview.chromium.org/237673010

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/240203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264154 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoRevert 263959 "Set use_goma=1 and gomadir=path in GYP_DEFINES on..."
jochen@chromium.org [Wed, 16 Apr 2014 07:44:52 +0000 (07:44 +0000)]
Revert 263959 "Set use_goma=1 and gomadir=path in GYP_DEFINES on..."

Breaks jsonclang based bots (codesearch)

> Set use_goma=1 and gomadir=path in GYP_DEFINES on master.
>
> That way, the bots will use goma the same way developers do. It's also what
> recipes and the android buildbot already use.
>
> Once all masters were restarted with this change,
> scripts/slave/compile.py can be simplified.
>
> Eventually, --compiler=goma-clang can go away, since --compiler=goma and
> GYP_DEFINES=clang=1 should do the right thing after this change.
>
> BUG=332697
>
> Review URL: https://codereview.chromium.org/228903003

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/240003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264152 0039d316-1c4b-4281-b951-d872f2087c98

2 hours agoRevert 263974 "Try to fix runhooks_wrapper.py on Windows after r..."
jochen@chromium.org [Wed, 16 Apr 2014 07:44:02 +0000 (07:44 +0000)]
Revert 263974 "Try to fix runhooks_wrapper.py on Windows after r..."

Reverting as precondition to revert 263959

> Try to fix runhooks_wrapper.py on Windows after r263959.
>
> It's currently failing on Windows:
> http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20Ninja%20Goma%20%28shared%29/builds/27608/steps/runhooks/logs/stdio
>
> gclient runhooks
> Traceback (most recent call last):
>   File "..\..\..\scripts\slave\runhooks_wrapper.py", line 49, in <module>
>     sys.exit(main())
>   File "..\..\..\scripts\slave\runhooks_wrapper.py", line 45, in main
>     return chromium_utils.RunCommand(['gclient', 'runhooks'])
>   File "C:\b\build\scripts\common\chromium_utils.py", line 868, in RunCommand
>     bufsize=0, **kwargs)
>   File "C:\b\depot_tools\python276_bin\lib\subprocess.py", line 709, in __init__
>     errread, errwrite)
>   File "C:\b\depot_tools\python276_bin\lib\subprocess.py", line 957, in _execute_child
>     startupinfo)
> WindowsError: [Error 2] The system cannot find the file specified
>
> BUG=332697
> TBR=iannucci@chromium.org
>
> Review URL: https://codereview.chromium.org/239153006

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/240073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264151 0039d316-1c4b-4281-b951-d872f2087c98

7 hours agowin: Remove explicit goma-related GYP_DEFINES.
thakis@chromium.org [Wed, 16 Apr 2014 02:38:14 +0000 (02:38 +0000)]
win: Remove explicit goma-related GYP_DEFINES.

Chromium's build/common.gypi should set things like this automatically now
that we use use_goma=1.

BUG=332697

Review URL: https://codereview.chromium.org/237673010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264076 0039d316-1c4b-4281-b951-d872f2087c98

8 hours agoAndroid builder recipe should be using public SDK.
navabi@google.com [Wed, 16 Apr 2014 01:48:05 +0000 (01:48 +0000)]
Android builder recipe should be using public SDK.

Locally tested that build works with the version changes.

BUG=353155
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/236193017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264060 0039d316-1c4b-4281-b951-d872f2087c98

8 hours agolinux_arm_tester: enabled bot_update
nodir@chromium.org [Wed, 16 Apr 2014 01:44:09 +0000 (01:44 +0000)]
linux_arm_tester: enabled bot_update

TBR=hinoka@chromium.org
BUG=359338

Review URL: https://codereview.chromium.org/236063021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264055 0039d316-1c4b-4281-b951-d872f2087c98

8 hours agoDo not seed 'swarming: <task>' steps twice.
vadimsh@chromium.org [Wed, 16 Apr 2014 01:25:22 +0000 (01:25 +0000)]
Do not seed 'swarming: <task>' steps twice.

It confuses buildbot. One seed happens (explicitly) when corresponding 'trigger'
step is invoked. Another one is implicitly happens when recipe engine sees
a list of 'swarming: ...' steps returned by 'collect' method.

Keep only implicit one. It's difficult to disable it (without converting
'collect' to a generator, which I do not want to do since it makes adding
concurrency in 'collect' more difficult later).

R=maruel@chromium.org, iannucci@chromium.org

Review URL: https://codereview.chromium.org/239923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264051 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoAdd android to bot_update
hinoka@google.com [Wed, 16 Apr 2014 00:34:20 +0000 (00:34 +0000)]
Add android to bot_update

BUG=261741

Review URL: https://codereview.chromium.org/238023007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264047 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoChromium Trybot Bot Update Recipe
hinoka@google.com [Wed, 16 Apr 2014 00:26:34 +0000 (00:26 +0000)]
Chromium Trybot Bot Update Recipe

This adds bot_update support to the chromium trybot recipe.  Only theoretically turns it on for linux_rel_alt, which isn't actually a recipe bot (its just there so that we have a buildername to use to active bot_update for coverage testing.)

BUG=361346

Review URL: https://codereview.chromium.org/229413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264045 0039d316-1c4b-4281-b951-d872f2087c98

9 hours agoAndroid AOSP fixes for bot_update
hinoka@google.com [Wed, 16 Apr 2014 00:19:31 +0000 (00:19 +0000)]
Android AOSP fixes for bot_update

BUG=

Review URL: https://codereview.chromium.org/237583009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@264043 0039d316-1c4b-4281-b951-d872f2087c98

13 hours agofix for libvpx waterfall
joshualitt@chromium.org [Tue, 15 Apr 2014 20:48:30 +0000 (20:48 +0000)]
fix for libvpx waterfall
(ie, don't just idle wait while scraping input)

BUG=

Review URL: https://codereview.chromium.org/239163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263991 0039d316-1c4b-4281-b951-d872f2087c98

13 hours agoAdd support for chromium_trybot.py test selection based on chromium_config.
yoz@chromium.org [Tue, 15 Apr 2014 20:39:11 +0000 (20:39 +0000)]
Add support for chromium_trybot.py test selection based on chromium_config.

BUG=353600

Review URL: https://codereview.chromium.org/232053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263986 0039d316-1c4b-4281-b951-d872f2087c98

13 hours agoAdding env recipe module
smut@google.com [Tue, 15 Apr 2014 20:37:55 +0000 (20:37 +0000)]
Adding env recipe module

BUG=362290

Review URL: https://codereview.chromium.org/232843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263985 0039d316-1c4b-4281-b951-d872f2087c98

13 hours agoFix adb script to deal correctly with status messages from adb
luqui@chromium.org [Tue, 15 Apr 2014 20:24:19 +0000 (20:24 +0000)]
Fix adb script to deal correctly with status messages from adb

In particular, adb sometimes outputs status messages like

* daemon not running. starting it now on port 5037 *
* daemon started successfully *

which the script didn't correctly handle.

BUG=

Review URL: https://codereview.chromium.org/239693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263982 0039d316-1c4b-4281-b951-d872f2087c98

13 hours agoupdate example for coverage
zty@chromium.org [Tue, 15 Apr 2014 20:19:31 +0000 (20:19 +0000)]
update example for coverage

R=navabi@google.com
BUG=301552

Review URL: https://codereview.chromium.org/239263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263981 0039d316-1c4b-4281-b951-d872f2087c98

14 hours agoAutoSetupMaster: mail_notifier_mode parameter
nodir@chromium.org [Tue, 15 Apr 2014 19:51:06 +0000 (19:51 +0000)]
AutoSetupMaster: mail_notifier_mode parameter

Added mail_notifier_mode parameter to AutoSetupMaster, defaults to
'problem'.

R=stip@chromium.org, iannucci@chromium.org
BUG=362640

Review URL: https://codereview.chromium.org/238493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263975 0039d316-1c4b-4281-b951-d872f2087c98

14 hours agoTry to fix runhooks_wrapper.py on Windows after r263959.
thakis@chromium.org [Tue, 15 Apr 2014 19:47:44 +0000 (19:47 +0000)]
Try to fix runhooks_wrapper.py on Windows after r263959.

It's currently failing on Windows:
http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20Ninja%20Goma%20%28shared%29/builds/27608/steps/runhooks/logs/stdio

gclient runhooks
Traceback (most recent call last):
  File "..\..\..\scripts\slave\runhooks_wrapper.py", line 49, in <module>
    sys.exit(main())
  File "..\..\..\scripts\slave\runhooks_wrapper.py", line 45, in main
    return chromium_utils.RunCommand(['gclient', 'runhooks'])
  File "C:\b\build\scripts\common\chromium_utils.py", line 868, in RunCommand
    bufsize=0, **kwargs)
  File "C:\b\depot_tools\python276_bin\lib\subprocess.py", line 709, in __init__
    errread, errwrite)
  File "C:\b\depot_tools\python276_bin\lib\subprocess.py", line 957, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

BUG=332697
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/239153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263974 0039d316-1c4b-4281-b951-d872f2087c98

15 hours agoSet use_goma=1 and gomadir=path in GYP_DEFINES on master.
thakis@chromium.org [Tue, 15 Apr 2014 19:03:59 +0000 (19:03 +0000)]
Set use_goma=1 and gomadir=path in GYP_DEFINES on 

That way, the bots will use goma the same way developers do. It's also what
recipes and the android buildbot already use.

Once all masters were restarted with this change,
scripts/slave/compile.py can be simplified.

Eventually, --compiler=goma-clang can go away, since --compiler=goma and
GYP_DEFINES=clang=1 should do the right thing after this change.

BUG=332697

Review URL: https://codereview.chromium.org/228903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263959 0039d316-1c4b-4281-b951-d872f2087c98

16 hours agoEnable bot_update for Linux Builder dbg 32/64
hinoka@google.com [Tue, 15 Apr 2014 17:16:09 +0000 (17:16 +0000)]
Enable bot_update for Linux Builder dbg 32/64

BUG=261741

Review URL: https://codereview.chromium.org/239513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263900 0039d316-1c4b-4281-b951-d872f2087c98

17 hours agoFix type in package_source
jochen@chromium.org [Tue, 15 Apr 2014 16:44:13 +0000 (16:44 +0000)]
Fix type in package_source

TBR=phajdan.jr@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/239373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263878 0039d316-1c4b-4281-b951-d872f2087c98

20 hours agoTighten filter what to package for codesearch
jochen@chromium.org [Tue, 15 Apr 2014 13:20:55 +0000 (13:20 +0000)]
Tighten filter what to package for codesearch

Restrict generated resources to non-nacl sources, and remove nacl test
data

BUG=none
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/239103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263834 0039d316-1c4b-4281-b951-d872f2087c98

21 hours agoWebRTC: Remove virtual webcam check step.
kjellander@chromium.org [Tue, 15 Apr 2014 12:54:42 +0000 (12:54 +0000)]
WebRTC: Remove virtual webcam check step.

We're moving away from using virtual webcam software
and using the Chrome fake video device instead.

We keep the AddVirtualWebcamCheck() in chromium_commands.py
since we're still using it for WebRTC standalone.

BUG=363554

Review URL: https://codereview.chromium.org/238573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263822 0039d316-1c4b-4281-b951-d872f2087c98

22 hours agoPoint nacl tests to correct browser on 64-bit Windows
phajdan.jr@chromium.org [Tue, 15 Apr 2014 12:06:04 +0000 (12:06 +0000)]
Point nacl tests to correct browser on 64-bit Windows

BUG=358130

Review URL: https://codereview.chromium.org/238953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263814 0039d316-1c4b-4281-b951-d872f2087c98

22 hours agolibyuv: Add iOS gclient_deps
kjellander@chromium.org [Tue, 15 Apr 2014 11:21:44 +0000 (11:21 +0000)]
libyuv: Add iOS gclient_deps

This fixes the iOS build for libyuv.

TEST=Ran a successful local build for Debug and Release.
BUG=

Review URL: https://codereview.chromium.org/235983014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263813 0039d316-1c4b-4281-b951-d872f2087c98

24 hours agoAlso exclude .git directories from the codesearch tarball
jochen@chromium.org [Tue, 15 Apr 2014 09:30:07 +0000 (09:30 +0000)]
Also exclude .git directories from the codesearch tarball

BUG=none

Review URL: https://codereview.chromium.org/238913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263809 0039d316-1c4b-4281-b951-d872f2087c98

24 hours agoBail out if one of the pipes fails in RunCommand
jochen@chromium.org [Tue, 15 Apr 2014 09:30:03 +0000 (09:30 +0000)]
Bail out if one of the pipes fails in RunCommand

BUG=b/14041095
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/238423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263808 0039d316-1c4b-4281-b951-d872f2087c98

24 hours agoWebRTC recipe: Fix Android standalone builds.
kjellander@chromium.org [Tue, 15 Apr 2014 09:19:14 +0000 (09:19 +0000)]
WebRTC recipe: Fix Android standalone builds.

The Android standalone build configurations were
missing the target_os=['android'] part of the gclient
spec.

Also change the 'Android Clang' builder to be
'Android Clang (dbg)' since that's what we currently
run in the client.webrtc waterfall.

BUG=346198
TEST=Successful builds using:
scripts/tools/run_recipe.py webrtc/standalone buildername="Android" mastername=client.webrtc
scripts/tools/run_recipe.py webrtc/standalone buildername="Android (dbg)" mastername=client.webrtc
scripts/tools/run_recipe.py webrtc/standalone buildername="Android Clang (dbg)" mastername=client.webrtc

Review URL: https://codereview.chromium.org/235243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263807 0039d316-1c4b-4281-b951-d872f2087c98

28 hours agoClean up slave allocations.
djacques@chromium.org [Tue, 15 Apr 2014 05:16:51 +0000 (05:16 +0000)]
Clean up slave allocations.

Some required updates were missing from the landed patch.
https://src.chromium.org/viewvc/chrome?view=rev&revision=263541
The wrong slaves were sharing and a comment was missing, from review
https://codereview.chromium.org/234483002/

BUG=361801
TEST=localstart
R=davidjames@chromium.org, djacques@google.com

Review URL: https://codereview.chromium.org/235923012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263790 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoFirst cut at a blink_android_trybot recipe.
dpranke@chromium.org [Tue, 15 Apr 2014 01:02:25 +0000 (01:02 +0000)]
First cut at a blink_android_trybot recipe.

R=phajdan.jr@chromium.org, iannucci@chromium.org
BUG=353856

Review URL: https://codereview.chromium.org/227433018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263762 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoEnable memory.tough_dom_memory_cases at chromeperf
hajimehoshi@chromium.org [Tue, 15 Apr 2014 00:52:56 +0000 (00:52 +0000)]
Enable memory.tough_dom_memory_cases at chromeperf

This enables memory.tough_dom_memory_cases which is added at https://codereview.chromium.org/208793007.

BUG=332630

Review URL: https://codereview.chromium.org/232013007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263760 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoRemoved /bots prefix to RietveldApi
pgervais@chromium.org [Tue, 15 Apr 2014 00:25:44 +0000 (00:25 +0000)]
Removed /bots prefix to RietveldApi

This prefix is automatically added by JwtOAuth2Rietveld

BUG=329077

Review URL: https://codereview.chromium.org/237893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263749 0039d316-1c4b-4281-b951-d872f2087c98

37 hours agoTryJobGit switched to ChromiumGitPoller
nodir@chromium.org [Mon, 14 Apr 2014 20:40:17 +0000 (20:40 +0000)]
TryJobGit switched to ChromiumGitPoller

In contrast to vanilla GitPoller, ChromiumGitPoller checks
POLLER_DRY_RUN environment variable, which prevents actual polling.

R=agable@chromium.org, vadimsh@chromium.org
BUG=363287

Review URL: https://codereview.chromium.org/237453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263721 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoDeploying more mac naclports builders.
bradnelson@google.com [Mon, 14 Apr 2014 20:08:34 +0000 (20:08 +0000)]
Deploying more mac naclports builders.

Deploying additional mac builders for naclports.
Turning off mac bionic build to match linux.

BUG=https://code.google.com/p/chromium/issues/detail?id=359625
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/237613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263713 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoRemove build[10..13].m4 from linux_gpu and win_gpu on tryserver.chromium.gpu.
kbr@chromium.org [Mon, 14 Apr 2014 20:02:43 +0000 (20:02 +0000)]
Remove build[10..13].m4 from linux_gpu and win_gpu on tryserver.chromium.gpu.

These physical machines are going to be reprovisioned as VMWare hosts.
30 of the resulting VMs will replace the physical linux_gpu builders.

BUG=360364

Review URL: https://codereview.chromium.org/237603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263712 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoRe-land 263561 / Revert 263653 ("Revert of Remove the GN logic from the ...")
dpranke@chromium.org [Mon, 14 Apr 2014 19:53:52 +0000 (19:53 +0000)]
Re-land 263561 / Revert 263653 ("Revert of Remove the GN logic from the ...")

This patch re-lands the change to remove GN from the main chromium trybot
recipe, with the fix to the GN-specific recipe that caused it to be reverted.

TBR=iannucci@chromium.org
BUG=355097

Review URL: https://codereview.chromium.org/235483011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263709 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoShorten the slave build directory name for all nacl builders.
bradnelson@google.com [Mon, 14 Apr 2014 19:47:34 +0000 (19:47 +0000)]
Shorten the slave build directory name for all nacl builders.

We've hit the character limit for windows in a few cases recently.
As our builds are always clobbers, this sharing should be ok (we do it on the
trybots already).

Shortening only the slave build-dir name as on the master they are not allowed
to collide.

BUG=None
TEST=None
R=agable@chromium.org,dyen@chromium.org,noelallen@chromium.org

Review URL: https://codereview.chromium.org/237183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263703 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoAdding a bionic nacl sdk builder (canary only).
bradnelson@google.com [Mon, 14 Apr 2014 19:46:48 +0000 (19:46 +0000)]
Adding a bionic nacl sdk builder (canary only).

Borrowing a bot from:
http://code.google.com/p/chromium/issues/detail?id=361231

BUG=None
TEST=local restart
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/237243006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263701 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoRevised android unittests now send data to perf dashboard
joshualitt@chromium.org [Mon, 14 Apr 2014 17:37:15 +0000 (17:37 +0000)]
Revised android unittests now send data to perf dashboard

BUG=

Review URL: https://codereview.chromium.org/212223008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263653 0039d316-1c4b-4281-b951-d872f2087c98

45 hours agoWebRTC recipes: Switch standalone builders to Goma.
kjellander@chromium.org [Mon, 14 Apr 2014 13:09:57 +0000 (13:09 +0000)]
WebRTC recipes: Switch standalone builders to Goma.

In https://codereview.chromium.org/197873038/
and https://codereview.chromium.org/223313002/
all builders for WebRTC standalone were switched to Goma.
This updates the recipe to reflect that.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/236933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263622 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoWebRTC: Add Dr Memory "Full" trybot
kjellander@chromium.org [Mon, 14 Apr 2014 09:34:56 +0000 (09:34 +0000)]
WebRTC: Add Dr Memory "Full" trybot

In https://codereview.chromium.org/225663005/
a Dr Memory trybot was added for the "Light" configuration.
The idea behind this was that the "Full" configuration takes
too long to execute for a trybot (~3 hours).
Considering that some developers still don't have Windows
machines and that you can pass test filters to the trybots,
I think it's useful to have a trybot for the "Full" configuration
that is not part of the default set of trybots (decided
by the list in the PRESUBMIT.py of WebRTC checkouts).

BUG=360054

Review URL: https://codereview.chromium.org/232313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263607 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoWebRTC: Remove WebRTC FYI waterfall from overview.
kjellander@chromium.org [Mon, 14 Apr 2014 09:33:06 +0000 (09:33 +0000)]
WebRTC: Remove WebRTC FYI waterfall from overview.

Our WebRTC standalone FYI waterfall is confusing users
since it's red most of the time, so it's better to remove
it from the overview.

BUG=

Review URL: https://codereview.chromium.org/236853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263606 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoCompletely removes NO_NACL_GOMA.
yyanagisawa@chromium.org [Mon, 14 Apr 2014 02:14:53 +0000 (02:14 +0000)]
Completely removes NO_NACL_GOMA.

Although there are some increase of NaCl gcc/g++ and PNaCl clang usage,
I think it acceptable and I do not see any issues on bots.
As a result, I am going to completely remove NO_NACL_GOMA env.

Since the hostname variable is used in the other test, I moved it code
location near the test.

BUG=334124

Review URL: https://codereview.chromium.org/235483007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263579 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoMake test training compatible with svn checkouts.
iannucci@chromium.org [Mon, 14 Apr 2014 02:05:16 +0000 (02:05 +0000)]
Make test training compatible with svn checkouts.

R=agable@chromium.org, petermayo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/235863008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263577 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRevert of Remove the GN logic from the chromium_trybot recipe, clean up chromium...
ckocagil@chromium.org [Mon, 14 Apr 2014 01:25:51 +0000 (01:25 +0000)]
Revert of Remove the GN logic from the chromium_trybot recipe, clean up chromium module. (https://codereview.chromium.org/232153003/)

Reason for revert:
GN bots broke!

ninja -C /mnt/data/b/build/slave/Linux_GN/build/src/out/Release All chromium_builder_tests -j50
ninja: Entering directory `/mnt/data/b/build/slave/Linux_GN/build/src/out/Release'
ninja:error: unknown target 'All', did you mean 'all'?

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/1/steps/compile/logs/stdio

Original issue's description:
> Remove the GN logic from the chromium_trybot recipe, clean up chromium module.
>
> Now that we have dedicated GN bot coverage for both trybots and builders,
> we no longer need the hacks in the chromium_trybot.py recipe and
> chromium module that supported running GN and ninja with nonstandard
> directories under src/out.
>
> R=iannucci@chromium.org
> BUG=355097
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=263561

TBR=iannucci@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=355097

Review URL: https://codereview.chromium.org/236473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263574 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoRemove the GN logic from the chromium_trybot recipe, clean up chromium module.
dpranke@chromium.org [Sun, 13 Apr 2014 19:22:01 +0000 (19:22 +0000)]
Remove the GN logic from the chromium_trybot recipe, clean up chromium module.

Now that we have dedicated GN bot coverage for both trybots and builders,
we no longer need the hacks in the chromium_trybot.py recipe and
chromium module that supported running GN and ninja with nonstandard
directories under src/out.

R=iannucci@chromium.org
BUG=355097

Review URL: https://codereview.chromium.org/232153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263561 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdd repaint benchmark to perf bots.
ernstm@chromium.org [Sat, 12 Apr 2014 23:13:24 +0000 (23:13 +0000)]
Add repaint benchmark to perf bots.

Review URL: https://codereview.chromium.org/228663007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263549 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoMove all ToT builders off Amd slaves.
petermayo@chromium.org [Sat, 12 Apr 2014 17:56:17 +0000 (17:56 +0000)]
Move all ToT builders off Amd slaves.

Needs to land with corresponding internal change.

BUG=361801, 355931
TEST=localstart
R=davidjames@chromium.org, djacques@google.com

Review URL: https://codereview.chromium.org/234483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263541 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoRevert r263357 - Shorten the build directory name for all nacl builders.
petermayo@chromium.org [Sat, 12 Apr 2014 17:36:08 +0000 (17:36 +0000)]
Revert r263357 - Shorten the build directory name for all nacl builders.

https://codereview.chromium.org/233523003

>Shorten the build directory name for all nacl builders.
>
>We've hit the character limit for windows in a few cases recently.
>As our builds are always clobbers, this sharing should be ok (we do it on the
>trybots already).
>
>BUG=None
>TEST=None
>R=agable@chromium.org,dyen@chromium.org,noelallen@chromium.org
>
>Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=263357

TBR=agable@chromium.org, bradnelson@chromium.org
R=agable@chromium.org, nodir@chromium.org, bradnelson@chromium.org
BUG=362905
TEST=local presubmit

Review URL: https://codereview.chromium.org/236393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263537 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoWebRTC: Move Dr Memory bots to main waterfall.
kjellander@chromium.org [Sat, 12 Apr 2014 16:45:44 +0000 (16:45 +0000)]
WebRTC: Move Dr Memory bots to main waterfall.

Move Dr Memory bots from FYI to the main WebRTC standalone
waterfall, since they're finally green and we have a trybot
that can be used (running the "light" configuration).

TBR=phoglund
BUG=360054
TEST=None

Review URL: https://codereview.chromium.org/236083006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263531 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoWebRTC: Add DrMemory trybot and remove Pattern commitbot
kjellander@chromium.org [Sat, 12 Apr 2014 16:27:57 +0000 (16:27 +0000)]
WebRTC: Add DrMemory trybot and remove Pattern commitbot

This CL adds a DrMemory "Light" trybot for WebRTC.
The DrMemory "Full" configuration takes about 3 hours for a full
run so it's not very useful for try purposes (light takes about
28 minutes).
I also learned that "Pattern" is similar to the "Light" configuration
these days, so I'm removing that one from the FYI waterfall.

This CL shouldn't be submitted until they have been greened up.

BUG=360054

Review URL: https://codereview.chromium.org/225663005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263528 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoPoint telemetry tests to correct browser on 64-bit Windows
phajdan.jr@chromium.org [Sat, 12 Apr 2014 09:10:01 +0000 (09:10 +0000)]
Point telemetry tests to correct browser on 64-bit Windows

BUG=358130

Review URL: https://codereview.chromium.org/235423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263502 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoAdd mac perf bisect bots to tryserver.
stip@chromium.org [Sat, 12 Apr 2014 05:40:05 +0000 (05:40 +0000)]
Add mac perf bisect bots to tryserver.

These were allocated in crbug.com/347707.

TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/235443007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263492 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoChanges timeout to be 25 minutes, even though we should really figure out why this...
stip@chromium.org [Sat, 12 Apr 2014 05:39:24 +0000 (05:39 +0000)]
Changes timeout to be 25 minutes, even though we should really figure out why this is so slow.

BUG=362187
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/236283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263491 0039d316-1c4b-4281-b951-d872f2087c98

4 days agotryserver recipe: use FETCH_HEAD to checkout
nodir@chromium.org [Fri, 11 Apr 2014 23:59:42 +0000 (23:59 +0000)]
tryserver recipe: use FETCH_HEAD to checkout

When the ref fetched by a bot is not a branch, a local branch is not
created, the the checkout step fails. Instead check FETCH_HEAD out.

R=agable@chromium.org
BUG=362264

Review URL: https://codereview.chromium.org/233893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263417 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoadded bisect script step to chromium_android module
zty@chromium.org [Fri, 11 Apr 2014 21:55:55 +0000 (21:55 +0000)]
added bisect script step to chromium_android module

BUG=301552

Review URL: https://codereview.chromium.org/233973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263372 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoAdd a Linux GN (release) bot to the chromium.linux waterfall.
dpranke@chromium.org [Fri, 11 Apr 2014 21:54:22 +0000 (21:54 +0000)]
Add a Linux GN (release) bot to the chromium.linux waterfall.

GN the build tool, not Galaxy Nexus. Also, this is a Release bot.

R=phajdan.jr@chromium.org
BUG=353690

Review URL: https://codereview.chromium.org/234223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263371 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoAdd oilpan bots to blink_trybot recipe, tryserver.blink.
dpranke@chromium.org [Fri, 11 Apr 2014 21:41:48 +0000 (21:41 +0000)]
Add oilpan bots to blink_trybot recipe, tryserver.blink.

R=iannucci@chromium.org, phajdan.jr@chromium.org
BUG=362258

Review URL: https://codereview.chromium.org/234123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263366 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoShorten the build directory name for all nacl builders.
bradnelson@google.com [Fri, 11 Apr 2014 21:17:54 +0000 (21:17 +0000)]
Shorten the build directory name for all nacl builders.

We've hit the character limit for windows in a few cases recently.
As our builds are always clobbers, this sharing should be ok (we do it on the
trybots already).

BUG=None
TEST=None
R=agable@chromium.org,dyen@chromium.org,noelallen@chromium.org

Review URL: https://codereview.chromium.org/233523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263357 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoGet bot_update to print got_revision_git
hinoka@google.com [Fri, 11 Apr 2014 20:47:26 +0000 (20:47 +0000)]
Get bot_update to print got_revision_git

This is supposed to help out with LKGR finder, so that it can get both the git
and svn revisions without calculating it.

BUG=

Review URL: https://codereview.chromium.org/226293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263347 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoAdd bot_update to android builder
hinoka@google.com [Fri, 11 Apr 2014 20:46:16 +0000 (20:46 +0000)]
Add bot_update to android builder

* Generalized "step_history['bot_update']" to step_history.last_step()
* Added support for adding a suffix to the bot update step name
* "None" got revision now works correctly.
* Adds bot_update to Android bots

BUG=261741

Review URL: https://codereview.chromium.org/226723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263346 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoRefactor chromium_trybot recipe to use a map of builders
phajdan.jr@chromium.org [Fri, 11 Apr 2014 14:47:14 +0000 (14:47 +0000)]
Refactor chromium_trybot recipe to use a map of builders

BUG=317931

Review URL: https://codereview.chromium.org/235013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263244 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoV8 Buildbot: Fix arm novfp3 recipe.
machenbach@chromium.org [Fri, 11 Apr 2014 10:51:22 +0000 (10:51 +0000)]
V8 Buildbot: Fix arm novfp3 recipe.

BUG=315202
TBR=dcarney@chromium.org

Review URL: https://codereview.chromium.org/234803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263207 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoV8 Buildbot: Make win shared nosnap bot a tree closer.
machenbach@chromium.org [Fri, 11 Apr 2014 10:29:07 +0000 (10:29 +0000)]
V8 Buildbot: Make win shared nosnap bot a tree closer.

TBR=dcarney@chromium.org

Review URL: https://codereview.chromium.org/234573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263206 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoStop running the old rasterize_and_record benchmark
skyostil@google.com [Fri, 11 Apr 2014 09:51:27 +0000 (09:51 +0000)]
Stop running the old rasterize_and_record benchmark

The rasterize_and_record benchmark has been superseded by
rasterize_and_record_micro.

BUG=359858
R=ernstm@chromium.org, nduca@chromium.org, stip@chromium.org

Review URL: https://codereview.chromium.org/227723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263203 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoSet cleanup_temp timeout to 300s.
stip@chromium.org [Fri, 11 Apr 2014 09:03:13 +0000 (09:03 +0000)]
Set cleanup_temp timeout to 300s.

BUG=362187
TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/234553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263199 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoUpdate v8 to 3.25
ricow@google.com [Fri, 11 Apr 2014 05:43:41 +0000 (05:43 +0000)]
Update v8 to 3.25

TBR=kasperl

Review URL: https://codereview.chromium.org/234663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263165 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoLeak detector on build bots
hajimehoshi@chromium.org [Fri, 11 Apr 2014 02:08:54 +0000 (02:08 +0000)]
Leak detector on build bots

This CL introduces the leak detector as chromium.webkit bots. The only
difference between these new bots and the existing WebKit bots is that
--enable-leak-detection is added to the run_webkit_test.py to execute
leak detection on layout tests.

The new bots are not tree closers for the duration.

We suppose that leaks should be treated as red errors, and the other
errors should be ignored like ASAN bots.

BUG=359024

Review URL: https://codereview.chromium.org/224963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263154 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoDon't use official_release=True for naclports builders.
sbc@chromium.org [Fri, 11 Apr 2014 01:20:54 +0000 (01:20 +0000)]
Don't use official_release=True for naclports builders.

This was causing the build directory to build nuked
on each run which meant we were re-downloading all
the upstream archives each time.

Review URL: https://codereview.chromium.org/231943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263152 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoIncrease gclient_timeout for ARM linux hardware trybot.
sbc@chromium.org [Fri, 11 Apr 2014 01:20:04 +0000 (01:20 +0000)]
Increase gclient_timeout for ARM linux hardware trybot.

BUG=336994

Review URL: https://codereview.chromium.org/232233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263151 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoRemove obsolete GYP_MSVS_VERSION settings from buildbot configs
scottmg@chromium.org [Thu, 10 Apr 2014 23:16:46 +0000 (23:16 +0000)]
Remove obsolete GYP_MSVS_VERSION settings from buildbot configs

The msvs version is controlled by hashes in the src/ tree now.

R=iannucci@chromium.org
BUG=309197

Review URL: https://codereview.chromium.org/230473007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263122 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoAdd browser_tests to the Windows Clang FYI bot
rnk@chromium.org [Thu, 10 Apr 2014 22:54:31 +0000 (22:54 +0000)]
Add browser_tests to the Windows Clang FYI bot

unit_tests is currently passing for me locally.  Time to run something
bigger.

Sort the test targets while I'm here, since Nico asked for that last
time.

TBR=thakis@chromium.org
BUG=82385

Review URL: https://codereview.chromium.org/233893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263111 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoDon't do shallow clones of chromium/src.
szager@chromium.org [Thu, 10 Apr 2014 21:36:32 +0000 (21:36 +0000)]
Don't do shallow clones of chromium/src.

BUG=
TBR=agable@chromium.org,iannucci@chromium.org

Review URL: https://codereview.chromium.org/233993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263089 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoDon't print double newlines on Windows.
szager@chromium.org [Thu, 10 Apr 2014 21:15:22 +0000 (21:15 +0000)]
Don't print double newlines on Windows.

TBR=hinoka@chromium.org
BUG=

Review URL: https://codereview.chromium.org/231893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263084 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoAdd more logging to cleanup_temp.py.
stip@chromium.org [Thu, 10 Apr 2014 18:53:31 +0000 (18:53 +0000)]
Add more logging to cleanup_temp.py.

BUG=362187

Review URL: https://codereview.chromium.org/233173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263039 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoPass --local -shared to git clone.
szager@chromium.org [Thu, 10 Apr 2014 17:11:05 +0000 (17:11 +0000)]
Pass --local -shared to git clone.

BUG=
R=hinoka@google.com

Review URL: https://codereview.chromium.org/231893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@263019 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoMake it possible to specify additional command-line arguments in json test spec
phajdan.jr@chromium.org [Thu, 10 Apr 2014 15:48:38 +0000 (15:48 +0000)]
Make it possible to specify additional command-line arguments in json test spec

This is needed for https://codereview.chromium.org/221873004/

BUG=355084, 236893, 317931

Review URL: https://codereview.chromium.org/233253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262998 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoRemove list of gtest-based tests hardcoded in the chromium_trybot recipe
phajdan.jr@chromium.org [Thu, 10 Apr 2014 14:49:17 +0000 (14:49 +0000)]
Remove list of gtest-based tests hardcoded in the chromium_trybot recipe

After https://codereview.chromium.org/228823004/ the entire list
is stored in the chromium src repo.

BUG=317931

Review URL: https://codereview.chromium.org/233243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262989 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoRename linux distribution bots.
ricow@google.com [Thu, 10 Apr 2014 12:16:12 +0000 (12:16 +0000)]
Rename linux distribution bots.

This are now running under a wheezy chroot

TBR=sgjesse

Review URL: https://codereview.chromium.org/233013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262952 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoPartially revert "WebRTC: Switch client.webrtc Android bots over to recipes."
kjellander@chromium.org [Thu, 10 Apr 2014 07:32:46 +0000 (07:32 +0000)]
Partially revert "WebRTC: Switch client.webrtc Android bots over to recipes."

This reverts the change in the waterfall config of r262688.
When deploying to the live master, a few quirks were detected
that will need to be addressed before moving over these builders
to recipes.

BUG=346198
TBR=phoglund

Review URL: https://codereview.chromium.org/232643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262948 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoIncrease the number of slaves for linux_chromeos_asan from 3 to 6
phajdan.jr@chromium.org [Thu, 10 Apr 2014 05:44:24 +0000 (05:44 +0000)]
Increase the number of slaves for linux_chromeos_asan from 3 to 6

This is a response to number of build requests coming to that builder.

BUG=none

Review URL: https://codereview.chromium.org/212063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262941 0039d316-1c4b-4281-b951-d872f2087c98

6 days ago50% experiment on removing NO_NACL_GOMA flag.
yyanagisawa@chromium.org [Thu, 10 Apr 2014 01:21:20 +0000 (01:21 +0000)]
50% experiment on removing NO_NACL_GOMA flag.

Review URL: https://codereview.chromium.org/227523006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262889 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoChange git_cache call for bot_update call git_cache.py directly
hinoka@google.com [Thu, 10 Apr 2014 01:14:41 +0000 (01:14 +0000)]
Change git_cache call for bot_update call git_cache.py directly

BUG=

Review URL: https://codereview.chromium.org/232343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262886 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAdd 7z to windows path
hinoka@google.com [Wed, 9 Apr 2014 23:20:40 +0000 (23:20 +0000)]
Add 7z to windows path

BUG=361793

Review URL: https://codereview.chromium.org/231743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262852 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRemove Linux GTK from bot config.
jam@chromium.org [Wed, 9 Apr 2014 22:05:42 +0000 (22:05 +0000)]
Remove Linux GTK from bot config.

BUG=297026

Review URL: https://codereview.chromium.org/231543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262835 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRevert of Bot update newline fix (https://codereview.chromium.org/221723002/)
hinoka@google.com [Wed, 9 Apr 2014 22:01:41 +0000 (22:01 +0000)]
Revert of Bot update newline fix (https://codereview.chromium.org/221723002/)

Reason for revert:
We want more output for now because \r on windows might be masking output.

Original issue's description:
> Bot update newline fix
>
> This should fix the double spacing issue in windows.
>
> BUG=
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=261199

TBR=agable@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/232133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262834 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRevert of Make results_dashboard send just one request per test run (version 2)....
stip@chromium.org [Wed, 9 Apr 2014 20:14:37 +0000 (20:14 +0000)]
Revert of Make results_dashboard send just one request per test run (version 2). (https://chromiumcodereview.appspot.com/227233011/)

Reason for revert:
causing most of the chromium.perf waterfall to cycle purple. we need to correct those issues and then re-deploy a change like this

Original issue's description:
> Make results_dashboard send just one request per test run (version 2).
>
> This is a second version of crrev.com/217053012.
>
> The previous version got reverted because it appeared to be causing a couple of errors:
>  1. Undefined variable "revision" (probably because of empty logs_dict)
>  2. ValueError when calling results['supplemental_columns'].update(supplemental_columns), probably because the supplemental_columns passed in wasn't a dictionary.
>
> It seems like both of these might be caused by some incorrect values are passed into SendResults, but the arguments passed to SendResults from runtest.py seem to match the ones expected in results_dashboard.py.
>
> Does this look like the right way to validate arguments?
> Should I leave off the STEP_EXCEPTION part?
>
> BUG=
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=262749

TBR=qyearsley@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/231623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262790 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoMake it possible to pass env settings to the android compile step.
mkosiba@chromium.org [Wed, 9 Apr 2014 18:20:31 +0000 (18:20 +0000)]
Make it possible to pass env settings to the android compile step.

BUG=None

Review URL: https://codereview.chromium.org/230983003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262750 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoMake results_dashboard send just one request per test run (version 2).
qyearsley@chromium.org [Wed, 9 Apr 2014 18:20:23 +0000 (18:20 +0000)]
Make results_dashboard send just one request per test run (version 2).

This is a second version of crrev.com/217053012.

The previous version got reverted because it appeared to be causing a couple of errors:
 1. Undefined variable "revision" (probably because of empty logs_dict)
 2. ValueError when calling results['supplemental_columns'].update(supplemental_columns), probably because the supplemental_columns passed in wasn't a dictionary.

It seems like both of these might be caused by some incorrect values are passed into SendResults, but the arguments passed to SendResults from runtest.py seem to match the ones expected in results_dashboard.py.

Does this look like the right way to validate arguments?
Should I leave off the STEP_EXCEPTION part?

BUG=

Review URL: https://codereview.chromium.org/227233011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262749 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAutoRoll Bot: use --force flag to safely-roll-deps, remove duplicated work from wrapper
borenet@google.com [Wed, 9 Apr 2014 14:57:56 +0000 (14:57 +0000)]
AutoRoll Bot: use --force flag to safely-roll-deps, remove duplicated work from wrapper

BUG=skia:1945

Review URL: https://codereview.chromium.org/213493006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262695 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoV8 Buildbot: Minor recipe refactoring.
machenbach@chromium.org [Wed, 9 Apr 2014 14:03:16 +0000 (14:03 +0000)]
V8 Buildbot: Minor recipe refactoring.

Rename flaky_step->add_flaky_step.
Remove recipe config. There will be only one recipe config in this recipe.

BUG=315202

Review URL: https://codereview.chromium.org/230223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262689 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoWebRTC: Switch client.webrtc Android bots over to recipes.
kjellander@chromium.org [Wed, 9 Apr 2014 14:02:23 +0000 (14:02 +0000)]
WebRTC: Switch client.webrtc Android bots over to recipes.

Fix the recipe so the got_revision reported to buildbot
comes from the src/third_party/webrtc dir instead of the
Chromium revision in src.

The perf configuration for the testers have never been used
so far, since we were blocked by lack of support for arbitrary
tests logging perf numbers in the Chrome for Android toolchain
scripts. It's just one test affected in WebRTC and the plan is
to move that into a separate executable to run on the chromium.perf
waterfall anyway.

BUG=346198
TEST=

Review URL: https://codereview.chromium.org/229463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262688 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoV8 Buildbot: Sync chromium builders to lkcr.
machenbach@chromium.org [Wed, 9 Apr 2014 13:46:50 +0000 (13:46 +0000)]
V8 Buildbot: Sync chromium builders to lkcr.

Only the compile step of V8's chromium builders is a tree closer. Therefore we should sync to a version where chromium is known to compile. The lkgr was often lacking too far behind, making e.g. synchronization with blink layout test expectation changes very difficult.

BUG=

Review URL: https://codereview.chromium.org/230303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262687 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoV8 Buildbot: Switch arm simulators to recipes.
machenbach@chromium.org [Wed, 9 Apr 2014 13:45:37 +0000 (13:45 +0000)]
V8 Buildbot: Switch arm simulators to recipes.

Follow up of https://codereview.chromium.org/228513002/.

BUG=315202

Review URL: https://codereview.chromium.org/230703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262686 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoV8 Buildbot: Add the ability to disable tests in nosnap mode.
machenbach@chromium.org [Wed, 9 Apr 2014 13:00:39 +0000 (13:00 +0000)]
V8 Buildbot: Add the ability to disable tests in nosnap mode.

Depends on https://codereview.chromium.org/230743002/.

BUG=v8:3216

Review URL: https://codereview.chromium.org/230473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262677 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoWebRTC: Android testers with Nexus 5 devices.
kjellander@chromium.org [Wed, 9 Apr 2014 12:51:43 +0000 (12:51 +0000)]
WebRTC: Android testers with Nexus 5 devices.

BUG=359456

Review URL: https://codereview.chromium.org/230363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262672 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoMove hackish clobbering to the script that calls the dartium annotated steps
ricow@google.com [Wed, 9 Apr 2014 12:28:22 +0000 (12:28 +0000)]
Move hackish clobbering to the script that calls the dartium annotated steps

Also clean it up, we don't have any builders that starts with release

I will remove this functionality from the dartium annotated step since it does not work correctly. This change allow us to use the normal chromium_utils function which we know work

TBR=whesse

Review URL: https://codereview.chromium.org/230683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262656 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAdd 64-bit recipe-based Windows tryserver.chromium builders
phajdan.jr@chromium.org [Wed, 9 Apr 2014 11:23:53 +0000 (11:23 +0000)]
Add 64-bit recipe-based Windows tryserver.chromium builders

BUG=358130

Review URL: https://codereview.chromium.org/228823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262647 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoMove around some slaves in preperation for experimenting with chroot on the liniux...
ricow@google.com [Wed, 9 Apr 2014 11:12:45 +0000 (11:12 +0000)]
Move around some slaves in preperation for experimenting with chroot on the liniux distrubution bot.

Review URL: https://codereview.chromium.org/229943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262646 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoWebRTC: Update client.webrtc Android mobiles to Nexus 5
kjellander@chromium.org [Wed, 9 Apr 2014 07:10:10 +0000 (07:10 +0000)]
WebRTC: Update client.webrtc Android mobiles to Nexus 5

Renaming the builders names as these new devices are now
up and running.

BUG=317508
TBR=phoglund

Review URL: https://codereview.chromium.org/230133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262633 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoReplace mini56-a1 with vm640-m1 in master.chromium.chromedriver
pschmidt@google.com [Wed, 9 Apr 2014 01:45:24 +0000 (01:45 +0000)]
Replace mini56-a1 with vm640-m1 in chromium.chromedriver

BUG=350620
R=stgao@chromium.org

Review URL: https://codereview.chromium.org/227073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@262588 0039d316-1c4b-4281-b951-d872f2087c98