chromium/tools/commit-queue.git
3 months agoRe-add the CQ directory to chrome/trunk/tools. master
agable@chromium.org [Fri, 4 Apr 2014 03:57:24 +0000 (03:57 +0000)]
Re-add the CQ directory to chrome/trunk/tools.

This directory is still pulled by DEPS and is in official Buildspecs.
Re-add it for now until we can remove it from all of those.

TBR=maruel@chromium.org,cmp@chromium.org

Review URL: https://codereview.chromium.org/224913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@261659 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoDelete public commit queue to avoid confusion after move to internal repo
phajdan.jr@chromium.org [Wed, 5 Feb 2014 23:20:43 +0000 (23:20 +0000)]
Delete public commit queue to avoid confusion after move to internal repo

BUG=340808

Review URL: https://codereview.chromium.org/135363007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@249148 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoRevert of CQ to always post a message when Commit box is unchecked. (https://coderevi...
sergeyberezin@chromium.org [Tue, 4 Feb 2014 00:10:44 +0000 (00:10 +0000)]
Revert of CQ to always post a message when Commit box is unchecked. (https://codereview.chromium.org/138173005/)

Reason for revert:
This created a lot of spam at commit event for some obscure reason. I couldn't fix it fast, so reverting.

Original issue's description:
> Made _discard_pending() always post a message. Added meaningful
> default messages to all the places where it is called in the code.  In
> particular, CQ will now always post a message whenever the Commit
> checkbox is unchecked, for any reason.
>
> Updated unit tests accordingly, and made them a bit more robust by
> adding an error message to the failing FakeVerifier.
>
> This does NOT fix the bug, but will hopefully give more visibility to
> developers when a CL is dropped.
>
> BUG=238283
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=247488

TBR=phajdan.jr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=238283

Review URL: https://codereview.chromium.org/138133014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@248624 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoRevert of Reduce spam from CQ. (https://codereview.chromium.org/130983010/)
sergeyberezin@chromium.org [Tue, 4 Feb 2014 00:09:51 +0000 (00:09 +0000)]
Revert of Reduce spam from CQ. (https://codereview.chromium.org/130983010/)

Reason for revert:
This did not fix the noise from the CQ. Reverting this and the previous patches.

Original issue's description:
> Reduce spam from CQ.
>
> My previous change https://codereview.chromium.org/138173005/ made CQ
> post a message when the commit box was unchecked.  It shouldn't have
> posted it when CQ committed a change, but for some obscure reason it
> did.  Sometimes twice...
>
> This patch unifies the way an issue is removed from the queue, and in
> particular, should eliminate most of the unwanted messages.  Some CQ
> messages about unchecked CQ box will still be posted when CQ drops it,
> and it is expected to be rare.
>
> BUG=339116
> R=phajdan.jr@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=248553

TBR=phajdan.jr@chromium.org,iannucci@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=339116

Review URL: https://codereview.chromium.org/136643007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@248623 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoReduce spam from CQ.
sergeyberezin@chromium.org [Mon, 3 Feb 2014 19:49:29 +0000 (19:49 +0000)]
Reduce spam from CQ.

My previous change https://codereview.chromium.org/138173005/ made CQ
post a message when the commit box was unchecked.  It shouldn't have
posted it when CQ committed a change, but for some obscure reason it
did.  Sometimes twice...

This patch unifies the way an issue is removed from the queue, and in
particular, should eliminate most of the unwanted messages.  Some CQ
messages about unchecked CQ box will still be posted when CQ drops it,
and it is expected to be rare.

BUG=339116
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/130983010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@248553 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoAdding iOS ninja builder to the commit queue
smut@google.com [Mon, 3 Feb 2014 19:01:27 +0000 (19:01 +0000)]
Adding iOS ninja builder to the commit queue

BUG=336572

Review URL: https://codereview.chromium.org/136693015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@248540 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoAdd components_unittests to the ios_dbg_simulator bots.
iannucci@chromium.org [Fri, 31 Jan 2014 11:20:58 +0000 (11:20 +0000)]
Add components_unittests to the ios_dbg_simulator bots.

R=blundell@chromium.org, pgervais@chromium.org, smut@chromium.org
BUG=335162

Review URL: https://codereview.chromium.org/147353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@248166 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoUpdate Skia's tryserver URL since we have split our masters.
rmistry@google.com [Thu, 30 Jan 2014 15:24:47 +0000 (15:24 +0000)]
Update Skia's tryserver URL since we have split our masters.
skia.org is not up yet, but that will eventually become our master's URL.

Review URL: https://codereview.chromium.org/142043012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@247963 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoSort issues by their age in the commit queue.
sergeyberezin@chromium.org [Wed, 29 Jan 2014 22:52:10 +0000 (22:52 +0000)]
Sort issues by their age in the commit queue.

Previously, CQ was processing issues sorted by issue ID, which may result in processing a very recent CL before a very old CL. The age is based on when the Commit box was last checked (and not when the CL was first created).

This will hopefully help to clear the oldest CLs first, improve patch success rate, and keep the CQ's maximum age down.

BUG=335187

Review URL: https://codereview.chromium.org/145293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@247767 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoMade _discard_pending() always post a message. Added meaningful
sergeyberezin@chromium.org [Tue, 28 Jan 2014 20:03:26 +0000 (20:03 +0000)]
Made _discard_pending() always post a message. Added meaningful
default messages to all the places where it is called in the code.  In
particular, CQ will now always post a message whenever the Commit
checkbox is unchecked, for any reason.

Updated unit tests accordingly, and made them a bit more robust by
adding an error message to the failing FakeVerifier.

This does NOT fix the bug, but will hopefully give more visibility to
developers when a CL is dropped.

BUG=238283

Review URL: https://codereview.chromium.org/138173005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@247488 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoCQ: do not force HEAD revision for chromium_trybot builders
phajdan.jr@chromium.org [Tue, 28 Jan 2014 19:12:47 +0000 (19:12 +0000)]
CQ: do not force HEAD revision for chromium_trybot builders

This will make it possible to use LKCR.

BUG=317931

Review URL: https://codereview.chromium.org/141233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@247481 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoRevert "Added support for private projects."
cmp@chromium.org [Tue, 28 Jan 2014 18:23:28 +0000 (18:23 +0000)]
Revert "Added support for private projects."

This reverts commit r247456.  With that change in the CQ,
the Chromium CQ fails to start because it could not import
projects_internal.  It may be that the CQ checkout needed
updates to other source trees, but that clearly was not
happening and the CQ outage was disrupting Chromium devs.

TBR=pgervais@chromium.org
BUG=336455

Review URL: https://codereview.chromium.org/135363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@247470 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoAdded support for private projects.
pgervais@chromium.org [Tue, 28 Jan 2014 16:36:18 +0000 (16:36 +0000)]
Added support for private projects.

_gen_* functions are defined in projects.py. This file now looks for
../commit-queue-internal/projects_internal.py for more _gen_* functions.

BUG=336455

Review URL: https://codereview.chromium.org/144163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@247456 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoHandle URLError timeout from Rietveld
sergeyberezin@chromium.org [Tue, 28 Jan 2014 01:37:34 +0000 (01:37 +0000)]
Handle URLError timeout from Rietveld

While communicating to Rietveld, urllib2 request timed out and raised URLError, which was not handled in try_job_on_rietveld._update_jobs_from_rietveld() and propagated to the top CQ loop causing a crash. This patch fixes it.

BUG=337907

Review URL: https://codereview.chromium.org/144343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@247376 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoAdd telemetry_perf_unittests and flesh out telemetry_unittests.
stip@chromium.org [Fri, 24 Jan 2014 06:08:23 +0000 (06:08 +0000)]
Add telemetry_perf_unittests and flesh out telemetry_unittests.

BUG=156398

Review URL: https://codereview.chromium.org/140583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@246794 0039d316-1c4b-4281-b951-d872f2087c98

5 months agoUpdated log messages in async_push for better debuggability.
sergeyberezin@chromium.org [Thu, 23 Jan 2014 23:41:44 +0000 (23:41 +0000)]
Updated log messages in async_push for better debuggability.

This requires CQ restart to take effect, but it can wait till the next natural restart, no rush.

BUG=none

Review URL: https://codereview.chromium.org/142793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@246728 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoPass empty email & password to ReadOnlyRietveld in dry run of commit queue
sergeyberezin@chromium.org [Thu, 23 Jan 2014 02:01:20 +0000 (02:01 +0000)]
Pass empty email & password to ReadOnlyRietveld in dry run of commit queue

This avoids requiring real Rietveld credentials or specifying empty
user name on the command line (which is counterintuitive).

It also additionally ensures that nothing on Rietveld will change, even if there is a bug in ReadOnlyRietveld wrapper.

BUG=none

Review URL: https://codereview.chromium.org/145173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@246483 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoRemove experimental Debug builders.
phajdan.jr@chromium.org [Wed, 22 Jan 2014 04:11:55 +0000 (04:11 +0000)]
Remove experimental Debug builders.

They take approx. twice as long as Release and might be adding too much load.

BUG=317931

Review URL: https://codereview.chromium.org/144643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@246231 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoIncrease the percentage of jobs sent to the experimental recipe builders to 25%
phajdan.jr@chromium.org [Tue, 21 Jan 2014 22:39:32 +0000 (22:39 +0000)]
Increase the percentage of jobs sent to the experimental recipe builders to 25%

Note that on the recipes inline JSON output has been disabled by https://codereview.chromium.org/140463002 ,
which fixed the most likely root cause of latest slowdown.

BUG=317931

Review URL: https://codereview.chromium.org/143963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@246138 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoTurn up the batch/burst size for draining the pending queue faster.
petermayo@chromium.org [Thu, 16 Jan 2014 04:39:39 +0000 (04:39 +0000)]
Turn up the batch/burst size for draining the pending queue faster.

BUG=334681
TEST=None

Review URL: https://codereview.chromium.org/139583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@245112 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoAdd 'blink_heap_unittests' as a test step to run in the Blink CQ.
dpranke@chromium.org [Thu, 16 Jan 2014 01:21:43 +0000 (01:21 +0000)]
Add 'blink_heap_unittests' as a test step to run in the Blink CQ.

R=iannucci@chromium.org, phajdan.jr@chromium.org
BUG=334018

Review URL: https://codereview.chromium.org/139473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@245047 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoDisable recipe CQ requirements.
petermayo@chromium.org [Wed, 15 Jan 2014 16:26:52 +0000 (16:26 +0000)]
Disable recipe CQ requirements.

TBR=phajdan.jr@chromium.org
R=phajdan.jr@chromium.org
BUG=334681
TEST=None

Review URL: https://codereview.chromium.org/139463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@244897 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoIncrease the percentage of jobs sent to the experimental recipe builders to 25%
phajdan.jr@chromium.org [Tue, 14 Jan 2014 19:58:19 +0000 (19:58 +0000)]
Increase the percentage of jobs sent to the experimental recipe builders to 25%

BUG=317931

Review URL: https://codereview.chromium.org/138713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@244792 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoImproved user-facing messages
pgervais@chromium.org [Tue, 14 Jan 2014 18:38:06 +0000 (18:38 +0000)]
Improved user-facing messages

Updated some (pylint) comments/docstrings.

BUG=

Review URL: https://codereview.chromium.org/102703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@244775 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoIncrease the percentage of jobs sent to the experimental recipe builders to 10%
phajdan.jr@chromium.org [Mon, 13 Jan 2014 20:03:35 +0000 (20:03 +0000)]
Increase the percentage of jobs sent to the experimental recipe builders to 10%

BUG=317931

Review URL: https://codereview.chromium.org/134103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@244567 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoTrigger experimental recipe-based trybots for 1% of Chromium CLs.
phajdan.jr@chromium.org [Fri, 10 Jan 2014 17:21:16 +0000 (17:21 +0000)]
Trigger experimental recipe-based trybots for 1% of Chromium CLs.

BUG=317931

Review URL: https://codereview.chromium.org/133993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@244188 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoRemoved an assert in presubmit_shim.py
pgervais@chromium.org [Fri, 3 Jan 2014 22:16:51 +0000 (22:16 +0000)]
Removed an assert in presubmit_shim.py

The removed assert prevents calling presubmit_support with an empty
password. But an empty password is required to connect to a locally-
running rietveld instance.

BUG=330923

Review URL: https://codereview.chromium.org/117513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@242939 0039d316-1c4b-4281-b951-d872f2087c98

6 months agoAdd stats script.
cmp@chromium.org [Fri, 27 Dec 2013 18:13:26 +0000 (18:13 +0000)]
Add stats script.

This includes some feature additions and bug fixes:
- Add additional date modifiers.
- Handle case where patchset is missing from an issue.
- Fix date issue that occurs with some CLs.
- Add support for importing 'stats' and calling its methods.
- Add BERSERK and BINARY_FILE2 message handling.
- Add FAILED_PATCHSET and INTERNAL_ERROR message handling.
- Add APPLY2 message handling.
- Change number of items per search to 100.
- Make output unbuffered.
- Change the QPS throttle to allow up to 20 QPS.

Also some extra changes:
- Add script to call stats.py.
- Ensure all lines are < 80 chars and indent is +2.
- Add skia tracking.

Original author: eseidel@chromium.org
Modifications by: ilevy@chromium.org
Further modifications by: cmp@chromium.org

TBR=eseidel@chromium.org
BUG=330869

Review URL: https://codereview.chromium.org/121763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@242625 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoDrop '2' from chromedriver2_unittests for the cq.
kkania@chromium.org [Wed, 18 Dec 2013 21:39:35 +0000 (21:39 +0000)]
Drop '2' from chromedriver2_unittests for the cq.
BUG=298192

Review URL: https://codereview.chromium.org/108443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@241660 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoAdd chrome_elf_unittests to the CQ for Windows.
csharp@chromium.org [Tue, 17 Dec 2013 23:06:14 +0000 (23:06 +0000)]
Add chrome_elf_unittests to the CQ for Windows.

BUG=

Review URL: https://codereview.chromium.org/115243005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@241400 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoAdd Windows on Swarm usage for the Chromium CQ.
maruel@chromium.org [Tue, 17 Dec 2013 22:24:13 +0000 (22:24 +0000)]
Add Windows on Swarm usage for the Chromium CQ.

It took a long time but Windows is now stable enough to be used by the CQ.
Fallbacks are still using non-Swarm jobs as a safety precaution.

Linux was added in r232775.
OSX was added in r234506.

R=phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/105823014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@241387 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoAdd check_deps2git to CQ.
phajdan.jr@chromium.org [Tue, 17 Dec 2013 09:41:51 +0000 (09:41 +0000)]
Add check_deps2git to CQ.

BUG=251988

Review URL: https://codereview.chromium.org/16867013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@241245 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoAdd google_apis_unittests to win bots.
tfarina@chromium.org [Sat, 14 Dec 2013 02:32:29 +0000 (02:32 +0000)]
Add google_apis_unittests to win bots.

See https://codereview.chromium.org/96943003

BUG=257421
R=stip@chromium.org

Review URL: https://codereview.chromium.org/96903006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@240845 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoAdd nacl_integration back on win_rel.
maruel@chromium.org [Wed, 11 Dec 2013 20:17:56 +0000 (20:17 +0000)]
Add nacl_integration back on win_rel.

The underlying issue with python 2.7 and nacl_integration_tests is fixed.

R=phajdan.jr@chromium.org
BUG=319558,319585

Review URL: https://codereview.chromium.org/112953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@240164 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoCQ: Remove one out of two usages of buildbot_json in try_job_on_rietveld.py
phajdan.jr@chromium.org [Thu, 5 Dec 2013 22:27:08 +0000 (22:27 +0000)]
CQ: Remove one out of two usages of buildbot_json in try_job_on_rietveld.py

The next step will be to remove the second usage. I'm starting with the one
that seems simpler and easier to remove.

BUG=none

Review URL: https://codereview.chromium.org/103383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@239056 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoAdd Skia's Git base url to the Commit Queue
rmistry@google.com [Thu, 5 Dec 2013 17:55:09 +0000 (17:55 +0000)]
Add Skia's Git base url to the Commit Queue

Review URL: https://codereview.chromium.org/104743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@238990 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoAdd ability to point to local rietveld.
stip@chromium.org [Thu, 5 Dec 2013 02:14:45 +0000 (02:14 +0000)]
Add ability to point to local rietveld.

Review URL: https://codereview.chromium.org/106043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@238860 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoRemove Chrome Frame tests from the CQ.
grt@chromium.org [Tue, 3 Dec 2013 16:39:04 +0000 (16:39 +0000)]
Remove Chrome Frame tests from the CQ.

BUG=316496

Review URL: https://codereview.chromium.org/93563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@238412 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoRun events_unittests on linux-aura, linux-chromeos, and windows for the commit-queue.
sadrul@chromium.org [Thu, 28 Nov 2013 03:26:11 +0000 (03:26 +0000)]
Run events_unittests on linux-aura, linux-chromeos, and windows for the commit-queue.

Review URL: https://codereview.chromium.org/81453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@237663 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoCQ: Avoid making an expensive request to http://build.chromium.org/p/tryserver.chromi...
phajdan.jr@chromium.org [Thu, 28 Nov 2013 02:03:13 +0000 (02:03 +0000)]
CQ: Avoid making an expensive request to build.chromium.org/p/tryserver.chromium/json/builders?filter=1

The request for specific build will fail anyway if builder has been removed,
and both code paths do the same thing.

BUG=324119

Review URL: https://codereview.chromium.org/93493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@237658 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoCQ: increase request timeout to 15 minutes.
phajdan.jr@chromium.org [Thu, 28 Nov 2013 00:10:04 +0000 (00:10 +0000)]
CQ: increase request timeout to 15 minutes.

BUG=324119
R=cmp@chromium.org

Review URL: https://codereview.chromium.org/93173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@237649 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoCQ: print buildbot URL it's trying to access on errors
phajdan.jr@chromium.org [Wed, 27 Nov 2013 23:35:30 +0000 (23:35 +0000)]
CQ: print buildbot URL it's trying to access on errors

BUG=none

Review URL: https://codereview.chromium.org/93103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@237643 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoCQ: include more information in exception warnings
phajdan.jr@chromium.org [Wed, 27 Nov 2013 22:26:44 +0000 (22:26 +0000)]
CQ: include more information in exception warnings

BUG=none

Review URL: https://codereview.chromium.org/92903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@237633 0039d316-1c4b-4281-b951-d872f2087c98

7 months agoCQ: don't treat the commit box as unchecked on network errors
phajdan.jr@chromium.org [Tue, 26 Nov 2013 20:37:22 +0000 (20:37 +0000)]
CQ: don't treat the commit box as unchecked on network errors

BUG=309076

Review URL: https://codereview.chromium.org/83173008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@237402 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoCQ: catch more errors (IOError in this case, mostly for socket errors).
phajdan.jr@chromium.org [Thu, 21 Nov 2013 01:21:59 +0000 (01:21 +0000)]
CQ: catch more errors (IOError in this case, mostly for socket errors).

Note that while some errors are indeed socket.error, sometimes we get
IOError which is a superclass of socket.error so just catching that
makes the code simpler.

BUG=none

Review URL: https://codereview.chromium.org/78773006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@236367 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoCQ: catch more exceptions when looking for new pending changes.
phajdan.jr@chromium.org [Sat, 16 Nov 2013 01:49:42 +0000 (01:49 +0000)]
CQ: catch more exceptions when looking for new pending changes.

BUG=none

Review URL: https://codereview.chromium.org/62273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@235490 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoCQ: catch more exceptions when applying a patch
phajdan.jr@chromium.org [Sat, 16 Nov 2013 01:00:32 +0000 (01:00 +0000)]
CQ: catch more exceptions when applying a patch

BUG=none

Review URL: https://codereview.chromium.org/68213029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@235480 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoAdd google_apis_unittests to more bots.
tfarina@chromium.org [Fri, 15 Nov 2013 19:19:07 +0000 (19:19 +0000)]
Add google_apis_unittests to more bots.

This adds google_apis_unittests to 'linux_chromeos', 'linux_rel' and 'win_rel'.

See https://codereview.chromium.org/63423007/.

BUG=257421
R=maruel@chromium.org,stip@chromium.org

Review URL: https://codereview.chromium.org/70953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@235396 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoRemove nacl_integration_tests from win_rel.
maruel@chromium.org [Fri, 15 Nov 2013 14:30:30 +0000 (14:30 +0000)]
Remove nacl_integration_tests from win_rel.

It is blocking the commit queue.

TBR=ilevy@chromium.org
BUG=319585

Review URL: https://codereview.chromium.org/73403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@235327 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoRevert "Remove linux_aura from CQ, merge aura tests onto linux_rel."
agable@chromium.org [Fri, 15 Nov 2013 01:08:04 +0000 (01:08 +0000)]
Revert "Remove linux_aura from CQ, merge aura tests onto linux_rel."

This reverts commit 706b8aa5feddd9c2d7523bac3901da895e83b380.

The reverted CL was part of an effort to bring down TryServer / CQ load after
Aura was being built on ToT, merging linux_rel and linux_aura since they were
essentially the same config. Building Aura by default is now being reverted, so
this CL is being reverted as well.

BUG=319075
R=cmp@chromium.org, dpranke@chromium.org, stip@chromium.org

Review URL: https://codereview.chromium.org/61593009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@235270 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoAdding support for NOTREECHECKS.
rmistry@google.com [Thu, 14 Nov 2013 12:41:17 +0000 (12:41 +0000)]
Adding support for NOTREECHECKS.

The motivation for this CL is https://codereview.appspot.com/22410044/ ('One-Click Revert in Rietveld'). One of the main use-cases of One-Click revert is to be able to do a quick revert of a breaking change when the tree is closed.

Review URL: https://codereview.chromium.org/68113009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@235127 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoRemove linux_aura from CQ, merge aura tests onto linux_rel.
stip@chromium.org [Thu, 14 Nov 2013 00:49:10 +0000 (00:49 +0000)]
Remove linux_aura from CQ, merge aura tests onto linux_rel.

Since Aura is now on by default, these two configurations are redundant, and merging them should reduce some of the overall load on the try servers.

R=erg@chromium.org,iannucci@chromium.org

Review URL: https://codereview.chromium.org/67173011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@234989 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoCQ: don't give up on update and clobber build failures
phajdan.jr@chromium.org [Wed, 13 Nov 2013 20:30:50 +0000 (20:30 +0000)]
CQ: don't give up on update and clobber build failures

With HEAD being possibly broken these should not be fatal.

BUG=none

Review URL: https://codereview.chromium.org/66963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@234892 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoRemove win7_aura from the CQ since it's a subset of win_rel now.
jam@chromium.org [Tue, 12 Nov 2013 15:55:46 +0000 (15:55 +0000)]
Remove win7_aura from the CQ since it's a subset of win_rel now.

BUG=316199

Review URL: https://codereview.chromium.org/65533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@234533 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoAdd OSX tests to run on Swarming.
maruel@chromium.org [Tue, 12 Nov 2013 14:11:11 +0000 (14:11 +0000)]
Add OSX tests to run on Swarming.

They are fast enough they should handle the load. I'll closely monitor and will
revert if it causes an issue.

R=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/60733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@234506 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoMake win_rel contain all the targets that are in win7_aura in preparation for removin...
jam@chromium.org [Tue, 12 Nov 2013 06:59:32 +0000 (06:59 +0000)]
Make win_rel contain all the targets that are in win7_aura in preparation for removing that config.

BUG=316199

Review URL: https://codereview.chromium.org/62333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@234441 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoCQ: stop swallowing exceptions
phajdan.jr@chromium.org [Fri, 8 Nov 2013 19:03:09 +0000 (19:03 +0000)]
CQ: stop swallowing exceptions

This makes the control flow more predictable, and errors more visible.

BUG=none

Review URL: https://codereview.chromium.org/59103014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@233952 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoCQ: catch IOError thrown on socket timeouts
phajdan.jr@chromium.org [Fri, 8 Nov 2013 19:01:10 +0000 (19:01 +0000)]
CQ: catch IOError thrown on socket timeouts

BUG=none

Review URL: https://codereview.chromium.org/64983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@233950 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoRemove weborigin_unittests from commit queue
jochen@chromium.org [Fri, 8 Nov 2013 09:59:20 +0000 (09:59 +0000)]
Remove weborigin_unittests from commit queue

BUG=316246
R=ilevy@chromium.org

Review URL: https://codereview.chromium.org/66453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@233856 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoAdd google_apis_unittests to mac_rel.
stip@chromium.org [Wed, 6 Nov 2013 03:54:15 +0000 (03:54 +0000)]
Add google_apis_unittests to mac_rel.

See https://chromiumcodereview.appspot.com/57843006/.

R=maruel@chromium.org
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/59793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@233203 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoCQ: add a timeout for socket operations
phajdan.jr@chromium.org [Wed, 6 Nov 2013 01:02:17 +0000 (01:02 +0000)]
CQ: add a timeout for socket operations

BUG=314388

Review URL: https://codereview.chromium.org/59693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@233167 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoCQ: do not second-guess the tryserver
phajdan.jr@chromium.org [Mon, 4 Nov 2013 22:28:49 +0000 (22:28 +0000)]
CQ: do not second-guess the tryserver

Once a try job is triggered through Rietveld, do not submit more jobs
when they look "lost". This overloads tryserver when it is restarted.

I tested this change locally with a dry run (over 24 hours and counting).
I'll coordinate landing this with the trooper and will send a heads-up
e-mail to chrome-troopers.

BUG=none
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/54673016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@232822 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoReenable linux swarm for CQ.
maruel@chromium.org [Mon, 4 Nov 2013 20:14:01 +0000 (20:14 +0000)]
Reenable linux swarm for CQ.

It's now back into stable state.

R=phajdan.jr@chromium.org,ilevy@chromium.org
BUG=

Review URL: https://codereview.chromium.org/56023008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@232775 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoCQ: assert instead of re-running verifiers
phajdan.jr@chromium.org [Thu, 31 Oct 2013 20:45:05 +0000 (20:45 +0000)]
CQ: assert instead of re-running verifiers

This is not a valid state for CQ to be in,
and it makes CQ flood Rietveld with comments.

It does not happen under normal operation,
but has happened at least once. Exception
stack trace should help identify how CQ
went there and prevent it from misbehaving.

BUG=none

Review URL: https://codereview.chromium.org/41583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@232201 0039d316-1c4b-4281-b951-d872f2087c98

8 months agoCQ: handle more error conditions in try_job_on_rietveld.py
phajdan.jr@chromium.org [Thu, 24 Oct 2013 19:21:05 +0000 (19:21 +0000)]
CQ: handle more error conditions in try_job_on_rietveld.py

This catches errors I observed running local CQ instance.
All errors are temporary network/service hiccups
and so are caught and logged as warnings.

BUG=none

Review URL: https://codereview.chromium.org/33443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@230786 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoMake CQ use linux_blink instead of linux_layout
iannucci@chromium.org [Thu, 24 Oct 2013 01:28:47 +0000 (01:28 +0000)]
Make CQ use linux_blink instead of linux_layout

R=abarth@chromium.org, ojan@chromium.org
BUG=310887

Review URL: https://codereview.chromium.org/38983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@230589 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoDisable linux_swarm_triggered.
maruel@chromium.org [Tue, 22 Oct 2013 19:09:28 +0000 (19:09 +0000)]
Disable linux_swarm_triggered.

It was enabled in r230165 (a few moments ago, really) but we want to do
infrastructure work on the swarming master before increasing usage. This
CL will be reverted soon, we simply do not want the CQ to be restarted
in the meantime and having it start using linux_swarm_triggered while
maintenance is going on.

TBR=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/35813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@230173 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoConvert swarm_triggered to OS specific builder.
maruel@chromium.org [Tue, 22 Oct 2013 18:23:47 +0000 (18:23 +0000)]
Convert swarm_triggered to OS specific builder.

The try server is splitting up these builders so the CQ has to
adapt accordingly.

Reenable linux_swarm_triggered.

TBR=xusydoc@chromium.org
BUG=

Review URL: https://codereview.chromium.org/24633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@230165 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoRemove app_list_unittests from win7_aura requirements.
cmp@chromium.org [Sat, 19 Oct 2013 03:21:25 +0000 (03:21 +0000)]
Remove app_list_unittests from win7_aura requirements.

The tryserver doesn't run app_list_unittests right
now, and it's causing the CQ to get backed up for
no reason.

TBR=stip@chromium.org,tapted@chromium.org
BUG=169114, 166730, 224343

Review URL: https://codereview.chromium.org/29593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@229509 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoAdd app_list_unittests to the CQ steps on mac, windows and linux_aura.
tapted@chromium.org [Thu, 17 Oct 2013 23:23:06 +0000 (23:23 +0000)]
Add app_list_unittests to the CQ steps on mac, windows and linux_aura.

It is currently a step only on linux_chromeos.

This is a follow-up to CL-27296002 that adds the test step to the waterfall.

BUG=169114, 166730, 224343
R=stip@chromium.org, xusydoc@chromium.org

Review URL: https://codereview.chromium.org/26484004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@229249 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoCQ: handle more HTTP-related errors
phajdan.jr@chromium.org [Mon, 14 Oct 2013 21:58:02 +0000 (21:58 +0000)]
CQ: handle more HTTP-related errors

BUG=none

Review URL: https://codereview.chromium.org/26951002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@228544 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoCQ: improve the warning when the tree is closed
phajdan.jr@chromium.org [Mon, 14 Oct 2013 18:49:34 +0000 (18:49 +0000)]
CQ: improve the warning when the tree is closed

Currently it's not really obvious what it means without
looking at the code and its history.

BUG=none
R=ilevy@chromium.org

Review URL: https://codereview.chromium.org/26425005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@228498 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoFix commit queue to actually abort on import error.
agable@chromium.org [Thu, 10 Oct 2013 23:21:50 +0000 (23:21 +0000)]
Fix commit queue to actually abort on import error.

BUG=306111
R=phajdan.jr@chromium.org,iannucci@chromium.org,vadimsh@chromium.org

Review URL: https://codereview.chromium.org/26933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@228037 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoCQ: handle HTTP errors when accessing Rietveld
phajdan.jr@chromium.org [Thu, 10 Oct 2013 00:34:05 +0000 (00:34 +0000)]
CQ: handle HTTP errors when accessing Rietveld

BUG=none
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/26564004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@227843 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoDisable using Swarming for linux.
maruel@chromium.org [Tue, 8 Oct 2013 13:49:04 +0000 (13:49 +0000)]
Disable using Swarming for linux.

The linux swarming slaves are broken.
All comments about enabling/disabling Swarming usage.
Fix one variable aliasing.

R=csharp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/26248005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@227509 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoCQ: do not parallelize remote requests to Rietveld/TS
phajdan.jr@chromium.org [Tue, 8 Oct 2013 00:29:25 +0000 (00:29 +0000)]
CQ: do not parallelize remote requests to Rietveld/TS

According to breakpad data we're getting exceptions there.

Instead of swallowing them at a very high level as it's currently done,
they should be handled at a local level, possibly returning failure.

Furthermore, parallelization exacerbates the issues on AppEngine
and actually makes the errors more likely to happen.

I'm not aware of any evidence indicating this is on CQ's critical
path, and during my local testing this worked totally fine.

BUG=none
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/26339004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@227404 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoTarget base_unittests on win_x64_rel bots to avoid failing All target for now.
iannucci@chromium.org [Mon, 7 Oct 2013 18:10:10 +0000 (18:10 +0000)]
Target base_unittests on win_x64_rel bots to avoid failing All target for now.

R=maruel@chromium.org, scottmg@chromium.org
BUG=304877

Review URL: https://chromiumcodereview.appspot.com/26299002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@227300 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoAdd blink_platform_unittests to CQ.
iannucci@chromium.org [Mon, 30 Sep 2013 23:39:26 +0000 (23:39 +0000)]
Add blink_platform_unittests to CQ.

Original patch by abarth@chromium.org

R=abarth@chromium.org, xusydoc@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/25393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@226080 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoGTTF: Restore a change that makes local testing possible.
phajdan.jr@chromium.org [Mon, 30 Sep 2013 19:18:03 +0000 (19:18 +0000)]
GTTF: Restore a change that makes local testing possible.

This depends on https://codereview.chromium.org/24846002/ in depot_tools.

BUG=291335
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/25088005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@226023 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoFalse -> 'False' to fix CQ crash loop.
agable@chromium.org [Thu, 26 Sep 2013 01:58:57 +0000 (01:58 +0000)]
False -> 'False' to fix CQ crash loop.

R=phajdan.jr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/24495008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@225296 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoCQ: add landmines to delete database after unclean shutdown
phajdan.jr@chromium.org [Wed, 25 Sep 2013 23:27:40 +0000 (23:27 +0000)]
CQ: add landmines to delete database after unclean shutdown

This is an improved version of https://codereview.chromium.org/23011039/
using an approach recommended by Isaac.

I've tested it locally (thanks to recently committed changes),
and it behaves as expected and doesn't break any other things.

BUG=239272
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/24434003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@225276 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoUpdate CQ script to use codereview.chromium.org instead of appspot.
jam@chromium.org [Tue, 24 Sep 2013 23:06:49 +0000 (23:06 +0000)]
Update CQ script to use codereview.chromium.org instead of appspot.

BUG=273810

Review URL: https://chromiumcodereview.appspot.com/23875051

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@225098 0039d316-1c4b-4281-b951-d872f2087c98

9 months agoGTTF: changes that allow testing CQ locally
phajdan.jr@chromium.org [Tue, 24 Sep 2013 20:02:10 +0000 (20:02 +0000)]
GTTF: changes that allow testing CQ locally

This includes the following changes:

1) Use ReadOnlyRietveld from depot_tools (so that it can stay in sync with Rietveld)
2) No longer support --only-issue in dry run mode
3) Fix a unicode bug leading to an exception during testing

I've tested this as "./commit_queue.py --fake --no-try --project chromium"

BUG=291335
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/24303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@225056 0039d316-1c4b-4281-b951-d872f2087c98

10 months agoPointing to a skia master domain name and reading list of required build steps from...
rmistry@google.com [Sat, 21 Sep 2013 19:17:16 +0000 (19:17 +0000)]
Pointing to a skia master domain name and reading list of required build steps from the 

Note: The Skia CQ will have to be resynced and restarted after this goes in.

Review URL: https://chromiumcodereview.appspot.com/24243015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@224610 0039d316-1c4b-4281-b951-d872f2087c98

10 months agoAdd message_center_unittests to mac CQ.
xusydoc@chromium.org [Fri, 20 Sep 2013 22:01:20 +0000 (22:01 +0000)]
Add message_center_unittests to mac CQ.

BUG=195800

Review URL: https://chromiumcodereview.appspot.com/23464101

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@224501 0039d316-1c4b-4281-b951-d872f2087c98

10 months agoAdd support for chromium.googlesource.com/a/chromium... to the CQ.
maruel@chromium.org [Fri, 13 Sep 2013 02:16:05 +0000 (02:16 +0000)]
Add support for chromium.googlesource.com/a/chromium... to the CQ.

I fetch occasionally directly from there.

R=iannucci@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23523056

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@222960 0039d316-1c4b-4281-b951-d872f2087c98

10 months agoEnable Swarmed tests on linux for the CQ.
maruel@chromium.org [Mon, 9 Sep 2013 15:42:02 +0000 (15:42 +0000)]
Enable Swarmed tests on linux for the CQ.

This CL is a big deal, it's enabling all tests to run on Swarming server. This
CL downgrades to do it only on linux, since only linux has enough provisioning
for Swarming jobs.

R=csharp@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23591009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@222040 0039d316-1c4b-4281-b951-d872f2087c98

10 months agoRevert 221358 "Boot ios_dbg_simulator tests from CQ"
smut@google.com [Sat, 7 Sep 2013 01:17:37 +0000 (01:17 +0000)]
Revert 221358 "Boot ios_dbg_simulator tests from CQ"

> Boot ios_dbg_simulator tests from CQ
>
> These are blocking CQ. Not failing on main waterfall
> and can't figure out cause.  Boot first, ask questions later.
>
> BUG=285659
> TBR=cmp
>
> Review URL: https://chromiumcodereview.appspot.com/23702022

TBR=ilevy@chromium.org

Review URL: https://codereview.chromium.org/23861010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@221847 0039d316-1c4b-4281-b951-d872f2087c98

10 months agoBoot ios_dbg_simulator tests from CQ
ilevy@chromium.org [Thu, 5 Sep 2013 07:12:17 +0000 (07:12 +0000)]
Boot ios_dbg_simulator tests from CQ

These are blocking CQ. Not failing on main waterfall
and can't figure out cause.  Boot first, ask questions later.

BUG=285659
TBR=cmp

Review URL: https://chromiumcodereview.appspot.com/23702022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@221358 0039d316-1c4b-4281-b951-d872f2087c98

10 months agoA buildstep has been renamed this is causing the Skia Commit Queue to fail.
rmistry@google.com [Tue, 27 Aug 2013 16:40:43 +0000 (16:40 +0000)]
A buildstep has been renamed this is causing the Skia Commit Queue to fail.

Review URL: https://chromiumcodereview.appspot.com/23612002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@219802 0039d316-1c4b-4281-b951-d872f2087c98

10 months agoLog exceptions that terminate CQ loop
ilevy@chromium.org [Mon, 26 Aug 2013 22:57:52 +0000 (22:57 +0000)]
Log exceptions that terminate CQ loop

CQ exceptions currently only print to the console
and are eventually lost in scrollback.

R=maruel@chromium.org
BUG=239272

Review URL: https://chromiumcodereview.appspot.com/22866026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@219632 0039d316-1c4b-4281-b951-d872f2087c98

11 months agoPointing to Skia's new buildbot master.
rmistry@google.com [Mon, 19 Aug 2013 21:27:55 +0000 (21:27 +0000)]
Pointing to Skia's new buildbot master.

Review URL: https://chromiumcodereview.appspot.com/22859026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@218331 0039d316-1c4b-4281-b951-d872f2087c98

11 months agoDisable media_unittests for ios_dbg_simulator
iannucci@chromium.org [Sun, 18 Aug 2013 18:33:32 +0000 (18:33 +0000)]
Disable media_unittests for ios_dbg_simulator

Counterpart to https://codereview.chromium.org/23099010

TBR=ilevy@chromium.org, maruel@chromium.org, smut@google.com
BUG=

Review URL: https://chromiumcodereview.appspot.com/22923018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@218203 0039d316-1c4b-4281-b951-d872f2087c98

11 months agoRead Skia's CQ required steps from the buildbot master.
rmistry@google.com [Tue, 6 Aug 2013 16:57:28 +0000 (16:57 +0000)]
Read Skia's CQ required steps from the buildbot 

Created to fix the feature request https://code.google.com/p/skia/issues/detail?id=1334 : Commit Queue should get the list of required build steps from Skia's master.

Review URL: https://chromiumcodereview.appspot.com/22409003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@215906 0039d316-1c4b-4281-b951-d872f2087c98

11 months agoAdded CQ alerts for when logs are 120 seconds stale.
hinoka@google.com [Wed, 31 Jul 2013 23:21:58 +0000 (23:21 +0000)]
Added CQ alerts for when logs are 120 seconds stale.

Heartbeat.py uploads status messages to chromelogs.appspot.com, which emails
alerts when a message with a status != 0 is sent.

This monitors /b/commit-queue/logs-chromium/commit_queue.log to see when its
last modified, and sets an erroneous status when its been modified more than 120
seconds ago.

Things that need to be done for this to work:
* A fresh version of pycrypto needs to be compiled and place next to heartbeat.py
* A cron job needs to call heartbeat.py -d every minute or so

BUG=255702

Review URL: https://chromiumcodereview.appspot.com/18493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@214858 0039d316-1c4b-4281-b951-d872f2087c98

11 months agoSwitch CQ to use blink trybots for tests.
iannucci@chromium.org [Sun, 28 Jul 2013 04:32:27 +0000 (04:32 +0000)]
Switch CQ to use blink trybots for tests.

This time based on SVN, they seem to be much more stable.

R=eseidel@chromium.org
BUG=238381

Review URL: https://chromiumcodereview.appspot.com/20905003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@214073 0039d316-1c4b-4281-b951-d872f2087c98

11 months agoAdd android webview aosp to the default commit queue.
iannucci@chromium.org [Fri, 26 Jul 2013 19:49:22 +0000 (19:49 +0000)]
Add android webview aosp to the default commit queue.

R=mkosiba@chromium.org, xusydoc@chromium.org
BUG=245620

Review URL: https://chromiumcodereview.appspot.com/20609005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@213973 0039d316-1c4b-4281-b951-d872f2087c98

11 months agoSimplify cq url match rules and add http urls
ilevy@chromium.org [Fri, 26 Jul 2013 04:14:34 +0000 (04:14 +0000)]
Simplify cq url match rules and add http urls

BUG=238287

Review URL: https://chromiumcodereview.appspot.com/20284003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@213762 0039d316-1c4b-4281-b951-d872f2087c98

12 months agoAdd telemetry_unittests to win_rel and mac_rel.
xusydoc@chromium.org [Wed, 24 Jul 2013 23:20:09 +0000 (23:20 +0000)]
Add telemetry_unittests to win_rel and mac_rel.

BUG=246638

Review URL: https://chromiumcodereview.appspot.com/20099005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@213541 0039d316-1c4b-4281-b951-d872f2087c98

12 months agoRevert "Switch CQ to use blink trybots."
iannucci@chromium.org [Sat, 20 Jul 2013 23:04:31 +0000 (23:04 +0000)]
Revert "Switch CQ to use blink trybots."

This reverts commit 237416caeb3d2b9490c066c171f5672be4b6bc72.

New trybots are not ready for prime time yet

TBR=eseidel@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/19894002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/commit-queue@212802 0039d316-1c4b-4281-b951-d872f2087c98