chromium/tools/depot_tools.git
33 hours agoFix handling of ast.Str object. master
szager@chromium.org [Wed, 29 Oct 2014 22:19:26 +0000 (22:19 +0000)]
Fix handling of ast.Str object.

TBR=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/686183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292733 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAdded orphaned compiled Python file checks.
dnj@chromium.org [Tue, 28 Oct 2014 19:29:54 +0000 (19:29 +0000)]
Added orphaned compiled Python file checks.

There have been a handful of cases where orphaned compiled Python files (.pyc
files without an accompanying .py file) have been loaded preferentially by
the presubmit scripts, causing weird problems. This adds a check and a mode for
such files, either warning the user or deleting them.

BUG=None
TEST=local
  - Tested against local repository.

R=iannucci@chromium.org, szager@chromium.org

Review URL: https://codereview.chromium.org/621533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292703 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoHandle unusual case in rebase-update where second rebase attempt works.
sbc@chromium.org [Mon, 27 Oct 2014 20:26:04 +0000 (20:26 +0000)]
Handle unusual case in rebase-update where second rebase attempt works.

Previously we just added an assert here but better
to simply succeed in this case, while outputting
the intial failure message.

BUG=425696

Review URL: https://codereview.chromium.org/667793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292687 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoMake git auto-svn idempotent.
agable@chromium.org [Fri, 24 Oct 2014 08:13:03 +0000 (08:13 +0000)]
Make git auto-svn idempotent.

By directly using git-config rather than git-svn-init, this ensures that
crazy values don't get set. It could be "safer" (e.g. check to see if any
other git-svn configuration already exists and prompt before overwriting it),
but I think that simplicity is better here.

R=pgervais@chromium.org
BUG=425838

Review URL: https://codereview.chromium.org/675713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292640 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoLet gclient config accept file:// urls.
agable@chromium.org [Thu, 23 Oct 2014 08:28:30 +0000 (08:28 +0000)]
Let gclient config accept file:// urls.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/615443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292613 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoGet rid of spurious warning about bad --revision flag.
szager@chromium.org [Wed, 22 Oct 2014 21:13:52 +0000 (21:13 +0000)]
Get rid of spurious warning about bad --revision flag.

R=vadimsh@chromium.org,mmoss@chromium.org
BUG=

Review URL: https://codereview.chromium.org/671003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292601 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoAdd a Mojo recipe to make mojo fetch-able.
dpranke@chromium.org [Wed, 22 Oct 2014 17:49:54 +0000 (17:49 +0000)]
Add a Mojo recipe to make mojo fetch-able.

R=jamesr@chromium.org, agable@chromium.org

Review URL: https://codereview.chromium.org/666293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292598 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoUpdate fetch to support more flexible refspecs
agable@chromium.org [Wed, 22 Oct 2014 10:35:33 +0000 (10:35 +0000)]
Update fetch to support more flexible refspecs

R=machenbach@chromium.org
BUG=415464

Review URL: https://codereview.chromium.org/656623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292588 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoAdd a fetch recipe for infra_internal.
agable@chromium.org [Wed, 22 Oct 2014 09:59:38 +0000 (09:59 +0000)]
Add a fetch recipe for infra_internal.

Although many things are private, the urls of the infra_internal and
build_internal repositories are not. So let's just add a fetch recipe
for them anyway.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/544863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292586 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoAdd optional <DEPS file> argument to roll-dep.
szager@chromium.org [Tue, 21 Oct 2014 19:00:06 +0000 (19:00 +0000)]
Add optional <DEPS file> argument to roll-dep.

BUG=chromium:425117
R=agable@chromium.org,kjellander@chromium.org

Review URL: https://codereview.chromium.org/666713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292563 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoMake 'git cl patch' work when not on a named branch.
szager@chromium.org [Mon, 20 Oct 2014 22:33:21 +0000 (22:33 +0000)]
Make 'git cl patch' work when not on a named branch.

R=maruel@chromium.org,pgervais@chromium.org
BUG=

Review URL: https://codereview.chromium.org/661413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292537 0039d316-1c4b-4281-b951-d872f2087c98

13 days agoRevert 292493 since it broke CQ
jam@chromium.org [Fri, 17 Oct 2014 18:43:02 +0000 (18:43 +0000)]
Revert 292493 since it broke CQ

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292513 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoFix reitveld base URL for googlesource.com repos.
sbc@chromium.org [Thu, 16 Oct 2014 21:01:25 +0000 (21:01 +0000)]
Fix reitveld base URL for googlesource.com repos.

The base url was previously being generated as
URL@BRANCH.  I'm not sure if this works anywhere
but it certainly doesn't on googlesource.com.
Here we want URL/+/BRANCH.

R=iannucci@chromium.org, sergeyberezin@chromium.org

Review URL: https://codereview.chromium.org/652193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292493 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoFix clang-format canned check warning text
enne@chromium.org [Thu, 16 Oct 2014 19:23:07 +0000 (19:23 +0000)]
Fix clang-format canned check warning text

input_api.basename is a function, so printing it out yields:
"The <function basename at 0x7fccd3735410> directory requires..>"

Instead, use it to resolve the local presubmit path that has
requested clang formatting.

R=dpranke@chromium.org
BUG=422332

Review URL: https://codereview.chromium.org/665493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292491 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoGit footer fix for v8
hinoka@chromium.org [Mon, 13 Oct 2014 21:25:43 +0000 (21:25 +0000)]
Git footer fix for v8

Git footers doesn't seem to support v8, let alone know that trunk actually maps
to the candidate branch.  This should fix it.

BUG=
TBR=agable

Review URL: https://codereview.chromium.org/645183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292445 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoImprove error handling in git-rebase-update
sbc@chromium.org [Mon, 13 Oct 2014 21:01:00 +0000 (21:01 +0000)]
Improve error handling in git-rebase-update

Don't discard stderr from failed rebase operations
I had an issue where stdout of the failed rebase was
empty but stderr contained:
First, rewinding head to replay your work on top of it...
Dirty index: cannot apply patches (dirty: internal_gyp
third_party/html_office).

Also, in my case the second rebase was actually succeeding
for some reason, which is clearly no expected, so assert
in this case.

BUG=410339

Review URL: https://codereview.chromium.org/645763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292444 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoMake MIME boundary harder to accidentally match.
jrobbins@chromium.org [Mon, 13 Oct 2014 16:30:36 +0000 (16:30 +0000)]
Make MIME boundary harder to accidentally match.
This is just making the same change to the copy of upload.py that is in depot_tools.

BUG=419156
R=iannucci@chromium.org

Original Review URL: https://codereview.chromium.org/624513002

Review URL: https://codereview.chromium.org/639503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292432 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoChange CheckPatchFormatted to report which directory failed.
jkarlin@chromium.org [Fri, 10 Oct 2014 17:00:37 +0000 (17:00 +0000)]
Change CheckPatchFormatted to report which directory failed.

If presubmit.py for a directory (such as net/) fails due to not being clang formatted, then 'git cl format' needs to be run for that directory, not the entire patch.

BUG=422332

Review URL: https://codereview.chromium.org/648713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292407 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRemove useless comments from git bash wrappers.
agable@chromium.org [Thu, 9 Oct 2014 07:49:39 +0000 (07:49 +0000)]
Remove useless comments from git bash wrappers.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/621783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292379 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoSuppress readability/inheritance check for cpplint.py for now.
dcheng@chromium.org [Sat, 4 Oct 2014 06:47:08 +0000 (06:47 +0000)]
Suppress readability/inheritance check for cpplint.py for now.

This check never triggered before, since cpplint.py was looking for
override not OVERRIDE. Since Chromium prefers override now, the
linter is now (correctly) warning. However, the old Chromium convention
(and the one implemented by the clang plugin) is to explicitly annotate
all overrides with both virtual and override. The clang plugin code has
been updated, but new binaries have not yet been built. Until clang
rolls, suppress the warning.

BUG=417463
TBR=stip@chromium.org

Review URL: https://codereview.chromium.org/627163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292319 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdded os to input_api
pgervais@chromium.org [Thu, 2 Oct 2014 23:23:46 +0000 (23:23 +0000)]
Added os to input_api

BUG=
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/614413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292291 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoIntroduct git-auto-svn
agable@chromium.org [Wed, 1 Oct 2014 09:40:10 +0000 (09:40 +0000)]
Introduct git-auto-svn

This tool can automatically set up the necessary git-svn metadata for our
repos that live in SVN but are mirrored to Chrome.

R=iannucci@chromium.org, tandrii@chromium.org
BUG=418973

Review URL: https://codereview.chromium.org/611253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292241 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoReport the entire hash in the "committed" message.
mark@chromium.org [Fri, 26 Sep 2014 21:48:02 +0000 (21:48 +0000)]
Report the entire hash in the "committed" message.

This concerns the "committed" message posted to Rietveld. Prior to
34504a15bb3e, this used the committer's own core.abbrev. Now it's using
a hard-coded 7. Per recent discussions on chromium-dev, 7 is
insufficient to uniquely identify commits in large repositories such as
ours. If any abbreviation is to be done, a 12-digit minimum should be
used, but there's no reason not to use the entire hash.

Review URL: https://codereview.chromium.org/592293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292164 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoFix roll_dep.py to print the right latest SVN revision number on error.
thestig@chromium.org [Wed, 24 Sep 2014 23:48:33 +0000 (23:48 +0000)]
Fix roll_dep.py to print the right latest SVN revision number on error.

TEST="roll_dep.py breakpad/src 10000" should print ~1387, not 4.

Review URL: https://codereview.chromium.org/604463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292129 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoFix regexp used for enumerating remotes.
asanka@chromium.org [Wed, 24 Sep 2014 20:11:17 +0000 (20:11 +0000)]
Fix regexp used for enumerating remotes.

R=szager@chromium.org
BUG=413391

Review URL: https://codereview.chromium.org/598153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292123 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoFix logic for determing remote name from remote branch.
szager@chromium.org [Wed, 24 Sep 2014 17:25:45 +0000 (17:25 +0000)]
Fix logic for determing remote name from remote branch.

BUG=413391
R=iannucci@chromium.org,agable@chromium.org

Review URL: https://codereview.chromium.org/567873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292117 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoRough verification code to ensure deps hosts \in allowed_hosts.
tandrii@chromium.org [Tue, 23 Sep 2014 11:49:52 +0000 (11:49 +0000)]
Rough verification code to ensure deps hosts \in allowed_hosts.

BUG=371012

Review URL: https://codereview.chromium.org/562953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292088 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoUse three-way merge when applying Git patches.
primiano@chromium.org [Tue, 23 Sep 2014 08:14:39 +0000 (08:14 +0000)]
Use three-way merge when applying Git patches.

After switching to a pure git workflow, most of the patchset we upload
to rietveld have git metadata. Apparently, however, the scripts here in
depot tools, which are used by the CQ and trybots, are ignoring that
and applying patches without taking advantage of git metadata.
In practice this causes people to rebase and reupload patches more than
necessary, even in the cases when it could be handled automatically by
means of a three way merge.
This change updates the GitCheckout class of depot_tools to use that.

BUG=416003

Review URL: https://codereview.chromium.org/577203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292087 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoFix map-branches issues and add coloring for 'branch-heads',
calamity@chromium.org [Tue, 23 Sep 2014 03:30:50 +0000 (03:30 +0000)]
Fix map-branches issues and add coloring for 'branch-heads',

This CL fixes some issues with map-branches:
* Branches with no upstream were not being shown.
* -vv from a detached HEAD would crash
* GONE upstreams would crash when git cleaned up in a way that caused
  hash_one to fail

This CL also adds a blue coloring to branches that start with
'branch-heads' for Chromium release branches.

BUG=416530

Review URL: https://codereview.chromium.org/576423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292083 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoOmit <include> lines over 80+ columns.
dbeam@chromium.org [Tue, 23 Sep 2014 00:42:22 +0000 (00:42 +0000)]
Omit <include> lines over 80+ columns.

R=dpranke@chromium.org
BUG=none
TEST=no whining about <include src="long/path/name.js">

Review URL: https://codereview.chromium.org/579383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292080 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoUse CheckCallAndFilterAndHeader for git commands.
sbc@chromium.org [Mon, 22 Sep 2014 21:17:59 +0000 (21:17 +0000)]
Use CheckCallAndFilterAndHeader for git commands.

Then this was changed to CheckCallAndFilter it broke
the expectations of code in the buildbot tree:
 scripts/slave/chromium_commands.py:extract_revisions

Alternatively we could update the expectations
of chromium_commands.py.

BUG= https://code.google.com/p/chromium/issues/detail?id=412818

Review URL: https://codereview.chromium.org/587253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292072 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoMake check_output of subprocess2 compatible with Python's subprocess.
tandrii@chromium.org [Fri, 19 Sep 2014 11:51:43 +0000 (11:51 +0000)]
Make check_output of subprocess2 compatible with Python's subprocess.

According to Python's doc (
https://docs.python.org/2/library/subprocess.html#subprocess.check_output
):
if check_output raises exception CalledProcessError, the exception object
should contain stdout data as `output` attribute. Before this commit,
subprocess2.CalledProcessError had `output` always None, and used `stdout`
instead. This commit fixes this problem storing the same data in both `stdout`
and `output`.

BUG=NONE

Review URL: https://codereview.chromium.org/582933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292036 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoroll-dep: If applicable, include svn revision range in commit message
borenet@google.com [Mon, 15 Sep 2014 21:00:23 +0000 (21:00 +0000)]
roll-dep: If applicable, include svn revision range in commit message

This is analogous to the change made in
https://codereview.chromium.org/559243002/.  I want to change ARB to use the
commit message generated by roll-dep.

BUG=408700

Review URL: https://codereview.chromium.org/564363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291975 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoRevert "Make check for dirty index work."
smut@google.com [Thu, 11 Sep 2014 19:57:55 +0000 (19:57 +0000)]
Revert "Make check for dirty index work."

This reverts commit 931b6c6a6c72038b8994565aff5926d5050fb329.

This was causing our try bots to fail on DEPS changes.

After applying the patch successfully, apply_issue.py tries to run gclient sync to get the updated DEPS, resulting in this error:
src (ERROR)
----------------------------------------
[0:00:00] Started.
----------------------------------------
Error:
____ src at origin/master
Your index contains uncommitted changes
Please commit, stash, or reset.

BUG=413326
TESTED=Manually: https://paste.googleplex.com/6375653263802368

Review URL: https://codereview.chromium.org/563873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291932 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoFactor out Changelist GetStatus() for eventual use by other tools
jsbell@chromium.org [Thu, 11 Sep 2014 17:29:28 +0000 (17:29 +0000)]
Factor out Changelist GetStatus() for eventual use by other tools

Pulls the logic for computing an issue's "status" - has LGTM, is in
CQ, etc. - out of the "git cl status" command itself, so that other
tools can get the status of a Changelist.

BUG=379849
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/555973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291928 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoFix ascii art escaping.
maruel@chromium.org [Wed, 10 Sep 2014 11:08:06 +0000 (11:08 +0000)]
Fix ascii art escaping.

This was done because a line ending with a '\' will not be printed properly.
Completely escape the string.

R=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/557143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291906 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoSwitching off svn in naclports fetch recipe.
bradnelson@google.com [Wed, 10 Sep 2014 01:25:38 +0000 (01:25 +0000)]
Switching off svn in naclports fetch recipe.

BUG=https://code.google.com/p/chromium/issues/detail?id=409185
TEST=local
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/555383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291900 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoAllow trunk to not end in a slash for git_footers.
iannucci@chromium.org [Tue, 9 Sep 2014 23:07:36 +0000 (23:07 +0000)]
Allow trunk to not end in a slash for git_footers.

R=luqui@chromium.org, prasadv@chromium.org
BUG=

Review URL: https://codereview.chromium.org/559773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291897 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoExpand git-footers to read the svn position for any trunk path in any repo.
iannucci@chromium.org [Tue, 9 Sep 2014 22:35:03 +0000 (22:35 +0000)]
Expand git-footers to read the svn position for any trunk path in any repo.

This is to support non-chrome repos in the bisect scripts.

R=hinoka@chromium.org, luqui@chromium.org
BUG=

Review URL: https://codereview.chromium.org/552403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291895 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoFix typo in git-footers docs.
mmoss@chromium.org [Tue, 9 Sep 2014 22:09:53 +0000 (22:09 +0000)]
Fix typo in git-footers docs.

R=luqui@chromium.org

Review URL: https://codereview.chromium.org/558783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291893 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoClear up some git-drover docs confusion.
mmoss@chromium.org [Tue, 9 Sep 2014 21:06:30 +0000 (21:06 +0000)]
Clear up some git-drover docs confusion.

TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/561433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291889 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoFix gclient branch ref mangling and allow --force branch switches.
mmoss@chromium.org [Tue, 9 Sep 2014 18:23:39 +0000 (18:23 +0000)]
Fix gclient branch ref mangling and allow --force branch switches.

R=iannucci@chromium.org, maruel@chromium.org
BUG=410959

Review URL: https://codereview.chromium.org/549733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291883 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoMake check for dirty index work.
mmoss@chromium.org [Tue, 9 Sep 2014 16:57:26 +0000 (16:57 +0000)]
Make check for dirty index work.

Without --exit-code, diff-index always returns 0 and thus never throws
the exception for a dirty index.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/548553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291881 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoAdd git cl lol.
maruel@chromium.org [Mon, 8 Sep 2014 22:58:00 +0000 (22:58 +0000)]
Add git cl lol.

Because everyone needs humour.

Fix a small bug in subcommands.py with undocumented commands.

R=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/554123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291867 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoRun prune in git cache update bootstrap to remove loose objects
hinoka@chromium.org [Mon, 8 Sep 2014 21:40:50 +0000 (21:40 +0000)]
Run prune in git cache update bootstrap to remove loose objects

BUG=411236

Review URL: https://codereview.chromium.org/545213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291865 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoAdd pgp key for davidjames to repo.
szager@chromium.org [Mon, 8 Sep 2014 17:50:45 +0000 (17:50 +0000)]
Add pgp key for davidjames to repo.

This incorporates:

https://chromium-review.googlesource.com/#/c/216850

R=davidjames@chromium.org,petermayo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/554723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291857 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoFix git-map-branches crashing on HEAD, and other minor quality-of-life
iannucci@chromium.org [Mon, 8 Sep 2014 02:12:24 +0000 (02:12 +0000)]
Fix git-map-branches crashing on HEAD, and other minor quality-of-life
improvements.

  * No longer crash on HEAD
  * Always correctly highlight lines based on hash-matching-ness
  * Only import git_cl if you want it (it can be slow)
  * Print a message when NO branches are found (instead of blank output)

R=calamity@chromium.org, jsbell@chromium.org
BUG=410353

Review URL: https://codereview.chromium.org/554523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291847 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoSkip tracking status in map-branches when -v flag is not supplied.
calamity@chromium.org [Mon, 8 Sep 2014 01:03:19 +0000 (01:03 +0000)]
Skip tracking status in map-branches when -v flag is not supplied.

This CL prevents map-branches from loading the tracking status when
the -v flag is not supplied. This prevents the vanilla map-branches
from taking a potentially long time to retrieve the tracking status.

BUG=410137

Review URL: https://codereview.chromium.org/536793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291846 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoAdd 'revert' example to git-drover docs.
mmoss@chromium.org [Sat, 6 Sep 2014 00:06:24 +0000 (00:06 +0000)]
Add 'revert' example to git-drover docs.

TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/549643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291840 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoGrammar up.
thakis@chromium.org [Fri, 5 Sep 2014 21:33:23 +0000 (21:33 +0000)]
Grammar up.

BUG=
TBR=iannucci

Review URL: https://codereview.chromium.org/549613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291835 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoMake git cl format work on my Windows box.
thakis@chromium.org [Fri, 5 Sep 2014 18:54:22 +0000 (18:54 +0000)]
Make git cl format work on my Windows box.

For me, PATH was a unicode instead of a str for some reason, so things
failed with

D:\src\chromefetch\src>git cl format
Traceback (most recent call last):
  File "d:\src\depot_tools\git_cl.py", line 2821, in <module>
    sys.exit(main(sys.argv[1:]))
  File "d:\src\depot_tools\git_cl.py", line 2807, in main
    return dispatcher.execute(OptionParser(), argv)
  File "d:\src\depot_tools\subcommand.py", line 245, in execute
    return command(parser, args[1:])
  File "d:\src\depot_tools\git_cl.py", line 2768, in CMDformat
    stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
  File "d:\src\depot_tools\git_cl.py", line 81, in RunCommand
    return subprocess2.check_output(args, shell=False, **kwargs)
  File "d:\src\depot_tools\subprocess2.py", line 515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "d:\src\depot_tools\subprocess2.py", line 475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File "d:\src\depot_tools\subprocess2.py", line 449, in communicate
    proc = Popen(args, **kwargs)
  File "d:\src\depot_tools\subprocess2.py", line 237, in __init__
    super(Popen, self).__init__(args, **kwargs)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 709, in __init__
    errread, errwrite)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 957, in _execute_child
    startupinfo)
TypeError: environment can only contain strings
Sending crash report ...
  args: ['d:\\src\\depot_tools\\git_cl.py', 'format']
  cwd: D:\src\chromefetch\src
  exception: environment can only contain strings
  host: THAKIS1-W.ad.corp.google.com
  stack:   File "d:\src\depot_tools\git_cl.py", line 2821,
  user: thakis
  version: 2.7.6 (default, Nov 10 2013, 19:24:18)

This fixes the glitch.

Review URL: https://codereview.chromium.org/545333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291825 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoReturn 1 from git_cl land when you Ctrl-C it in the middle.
iannucci@chromium.org [Fri, 5 Sep 2014 18:25:51 +0000 (18:25 +0000)]
Return 1 from git_cl land when you Ctrl-C it in the middle.

R=agable@chromium.org, mmoss@chromium.org
BUG=

Review URL: https://codereview.chromium.org/549513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291823 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoMake gn.py support root directories other than 'src'.
kjellander@chromium.org [Fri, 5 Sep 2014 12:40:28 +0000 (12:40 +0000)]
Make gn.py support root directories other than 'src'.

In https://codereview.chromium.org/341533006/ a change
was made so that gn.py is not looking for the .gn file
to identify the root of the checkout. This breaks
GN functionality for projects that uses gclient but
have a top directory named something else than 'src'.

This change adds support for arbitrarily named primary (the first)
solutions in the .gclient file.
It also adds a check for the generated GN path so a friendly
error message can be printed if the GN executable cannot be found.

BUG=389883
TESTED=Various cases of Chromium, WebRTC and custom checkouts
with .gclient containing empty solution list, solution missing the
'name' key and so on.

Review URL: https://codereview.chromium.org/538393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291819 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoMake git cache delete a defunct directory instead of moving it
hinoka@chromium.org [Fri, 5 Sep 2014 11:10:35 +0000 (11:10 +0000)]
Make git cache delete a defunct directory instead of moving it

So the original intention of moving it to a different directory to be deleted later
was to (1) save it for diagnosis (2) be a single inode swap rather than a long
rmtree delete.

1. No one is actually looking at these directories
2. The tmpdir sometimes end up on a different partition, so it ends up being
   a copy + delete instead.  Since we're not getting timeouts from that, its
   probably actually better to just straight up delete it.

BUG=410727

Review URL: https://codereview.chromium.org/538993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291818 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoAdd a --tbr-owners option to git cl upload
piman@chromium.org [Thu, 4 Sep 2014 02:16:55 +0000 (02:16 +0000)]
Add a --tbr-owners option to git cl upload

BUG=410125

Review URL: https://codereview.chromium.org/543463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291794 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoAdded git footers tool to parse conventional metadata from git commits
luqui@chromium.org [Wed, 3 Sep 2014 02:31:03 +0000 (02:31 +0000)]
Added git footers tool to parse conventional metadata from git commits

BUG=407316

Review URL: https://codereview.chromium.org/521033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291777 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoGive git map-branches extra information behind -v and -vv flags.
calamity@chromium.org [Wed, 3 Sep 2014 02:04:46 +0000 (02:04 +0000)]
Give git map-branches extra information behind -v and -vv flags.

This CL adds information to the git map-branches command. Invoking
it map-branches with -v, will show tracking status of branches and
invoking with -vv will additionally show the Rietveld URL and the
branch hash.

BUG=None

Review URL: https://codereview.chromium.org/509843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291776 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoRequire 'CHROME_HEADLESS' to use 'git-number'.
dnj@chromium.org [Tue, 2 Sep 2014 20:49:59 +0000 (20:49 +0000)]
Require 'CHROME_HEADLESS' to use 'git-number'.

Updated 'git-number' to produce an error message if it's run without the
CHROME_HEADLESS (bot) environment variable. This is intended to alert developers
who may be incorrectly using this tool to get positioning information instead of
the commit position.

BUG=409917
TEST=local
  - Ran with and without 'CHROME_HEADLESS'; observed the error message in the
    'without' case.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/534703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291773 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUse full hash in Committed link when closing issue via git-cl.
iannucci@chromium.org [Fri, 29 Aug 2014 23:51:37 +0000 (23:51 +0000)]
Use full hash in Committed link when closing issue via git-cl.

R=agable@chromium.org, vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/526523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291751 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoRemove ilevy-cc from WATCHLIST, depot_tools edition :-(
thakis@chromium.org [Fri, 29 Aug 2014 23:09:12 +0000 (23:09 +0000)]
Remove ilevy-cc from WATCHLIST, depot_tools edition :-(

BUG=

Review URL: https://codereview.chromium.org/520053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291748 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoMake git-cl-{dcommit,land} fail if retcode is not zero after push.
iannucci@chromium.org [Fri, 29 Aug 2014 22:10:59 +0000 (22:10 +0000)]
Make git-cl-{dcommit,land} fail if retcode is not zero after push.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=409170

Review URL: https://codereview.chromium.org/523113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291745 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix transient error regexes.
iannucci@chromium.org [Fri, 29 Aug 2014 22:10:55 +0000 (22:10 +0000)]
Fix transient error regexes.

R=agable@chromium.org, dnj@chromium.org, vadimsh@chromium.org
BUG=409167

Review URL: https://codereview.chromium.org/521583008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291744 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoModify roll_dep's commit message
borenet@google.com [Fri, 29 Aug 2014 22:03:07 +0000 (22:03 +0000)]
Modify roll_dep's commit message

This conforms to the convention of using a single-line short description
followed by an empty line followed by a long description. Shortened the
revisions to more easily fit on one line.

BUG=408700

Review URL: https://codereview.chromium.org/513383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291743 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoMake git-cl-land wait
iannucci@chromium.org [Fri, 29 Aug 2014 01:38:03 +0000 (01:38 +0000)]
Make git-cl-land wait

R=vadimsh@chromium.org
BUG=406198

Review URL: https://codereview.chromium.org/519563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291719 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUpdate the Blink recipe to use 'webkit_revision' instead of 'webkit_rev'
philipj@opera.com [Thu, 28 Aug 2014 21:54:23 +0000 (21:54 +0000)]
Update the Blink recipe to use 'webkit_revision' instead of 'webkit_rev'

With the deletion of .DEPS.git, 'webkit_rev' became 'webkit_revision':
https://codereview.chromium.org/497313003

Without this change, gclient sync will not get the latest Blink commit.

Review URL: https://codereview.chromium.org/496443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291716 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoMake git-nav-downstream synchronous
asanka@chromium.org [Thu, 28 Aug 2014 00:25:22 +0000 (00:25 +0000)]
Make git-nav-downstream synchronous

Currently git-nav-downstream invokes 'git checkout' in a subprocess, but
exits without waiting for the checkout to complete. Instead wait for the
subprocess to complete.

BUG=376101

Review URL: https://codereview.chromium.org/509163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291701 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd the patchset id to the manual commit messages
rmistry@google.com [Wed, 27 Aug 2014 14:44:41 +0000 (14:44 +0000)]
Add the patchset id to the manual commit messages

Context is here:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/M7f9VTqrR8w/RECOX2Y5YasJ

Review URL: https://codereview.chromium.org/513763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291687 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoRetry fetching patch from rietveld on a 404
hinoka@chromium.org [Wed, 27 Aug 2014 14:00:41 +0000 (14:00 +0000)]
Retry fetching patch from rietveld on a 404

Also added a tiny bit of exponential backoff.

BUG=375479

Review URL: https://codereview.chromium.org/350433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291682 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoRevert hard-coded src.git DEPS file name.
mmoss@chromium.org [Tue, 26 Aug 2014 23:24:09 +0000 (23:24 +0000)]
Revert hard-coded src.git DEPS file name.

This is breaking the ability to specify an alternate DEPS file, and do
things like sync release tags where DEPS is still from svn and we need
.DEPS.git to do a git checkout.

R=iannucci@chromium.org, szager@chromium.org
BUG=407049

Review URL: https://codereview.chromium.org/511533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291665 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoBe verbose about what's happening in 'git cl land' when pusing to pending ref.
vadimsh@chromium.org [Tue, 26 Aug 2014 21:57:53 +0000 (21:57 +0000)]
Be verbose about what's happening in 'git cl land' when pusing to pending ref.

Also reduce number of attempts and give up right away on ACL errors.

R=iannucci@chromium.org
BUG=407369,407470

Review URL: https://codereview.chromium.org/512493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291656 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd some more context to git-drover tutorial.
mmoss@chromium.org [Mon, 25 Aug 2014 23:58:16 +0000 (23:58 +0000)]
Add some more context to git-drover tutorial.

BUG=407284
R=iannucci@google.com

Review URL: https://codereview.chromium.org/507513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291619 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoHave 'fetch chromium' set up with .DEPS.git to support recursion.
agable@chromium.org [Mon, 25 Aug 2014 20:48:07 +0000 (20:48 +0000)]
Have 'fetch chromium' set up with .DEPS.git to support recursion.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/504933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291613 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoOnly clear cache locks if the cache exists.
dnj@chromium.org [Mon, 25 Aug 2014 19:17:12 +0000 (19:17 +0000)]
Only clear cache locks if the cache exists.

BUG=407259
TEST=None

Review URL: https://codereview.chromium.org/462363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291609 0039d316-1c4b-4281-b951-d872f2087c98

2 months agodepot_tools: update cpplint.py to r137
avakulenko@google.com [Mon, 25 Aug 2014 16:26:18 +0000 (16:26 +0000)]
depot_tools: update cpplint.py to r137

Implements 'linelength' option in CPPLINT.cfg.
See:
https://code.google.com/p/google-styleguide/source/browse/trunk/cpplint/cpplint.py?r=137

BUG=None
TEST=None

Change-Id: I7b017078d997dfafc524a2f50a32289391d011f9

Review URL: https://codereview.chromium.org/495413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291601 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoEnsure deps_file=.DEPS.git in .gclient
szager@chromium.org [Sun, 24 Aug 2014 19:38:43 +0000 (19:38 +0000)]
Ensure deps_file=.DEPS.git in .gclient

R=agable@chromium.org,cmp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/500903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291592 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix git cache unlock invocation to specify cache dir.
szager@chromium.org [Sun, 24 Aug 2014 19:16:31 +0000 (19:16 +0000)]
Fix git cache unlock invocation to specify cache dir.

TBR=cmp@chromium.org,agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/498043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291591 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoForce break git cache locks when CHROME_HEADLESS is set.
szager@chromium.org [Sun, 24 Aug 2014 18:56:32 +0000 (18:56 +0000)]
Force break git cache locks when CHROME_HEADLESS is set.

BUG=406669
R=dnj@chromium.org,agable@chromium.org

Review URL: https://codereview.chromium.org/500903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291590 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoDon't remove "'deps_file': '.DEPS.git'" for chromium/src
szager@chromium.org [Sun, 24 Aug 2014 18:41:38 +0000 (18:41 +0000)]
Don't remove "'deps_file': '.DEPS.git'" for chromium/src

BUG=406880
R=iannucci@chromium.org,cmp@chromium.org

Review URL: https://codereview.chromium.org/498023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291589 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoRemove the old cache dir before moving the bootstrapped cache dir into the real location
hinoka@chromium.org [Sun, 24 Aug 2014 12:09:13 +0000 (12:09 +0000)]
Remove the old cache dir before moving the bootstrapped cache dir into the real location

Seems like some combination of things (bad cache dir, shallow checkout, etc) causes
git cache to not clean up properly before trying to move new directory A into
already existing directory B.

So the logic is all there to detect that the cache is invalid, its just not
being cleaned up properly during shallow checkouts.

BUG=406864
TBR=iannucci

Review URL: https://codereview.chromium.org/499123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291587 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix git-cl when working on branches.
mmoss@chromium.org [Sun, 24 Aug 2014 01:41:11 +0000 (01:41 +0000)]
Fix git-cl when working on branches.

This updates various assumptions to coincide with how gclient fetches
branch-heads refs from chromium repos.

R=iannucci@google.com
BUG=406858

Review URL: https://codereview.chromium.org/498013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291586 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix gclient hook for stubborn hooks.
iannucci@chromium.org [Sat, 23 Aug 2014 03:44:18 +0000 (03:44 +0000)]
Fix gclient hook for stubborn hooks.

R=szager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/497333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291574 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoDo threading.Lock the Right Way.
szager@chromium.org [Sat, 23 Aug 2014 03:33:28 +0000 (03:33 +0000)]
Do threading.Lock the Right Way.

R=cmp@chromium.org, dnj@chromium.org, iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/499003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291573 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix thread lock around cachepath access.
szager@chromium.org [Sat, 23 Aug 2014 02:35:23 +0000 (02:35 +0000)]
Fix thread lock around cachepath access.

R=cmp@chromium.org, agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/468253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291571 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd thread locking around GetCachePath().
szager@chromium.org [Sat, 23 Aug 2014 01:57:59 +0000 (01:57 +0000)]
Add thread locking around GetCachePath().

BUG=406662
R=cmp@chromium.org, agable@chromium.org

Review URL: https://codereview.chromium.org/469073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291569 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAuto-update .gclient files for git.
szager@chromium.org [Sat, 23 Aug 2014 00:57:31 +0000 (00:57 +0000)]
Auto-update .gclient files for git.

TBR=iannucci@chromium.org,stip@chromium.org

Review URL: https://codereview.chromium.org/503563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291567 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoMake fetch chromium operate in git-only mode.
agable@chromium.org [Sat, 23 Aug 2014 00:20:42 +0000 (00:20 +0000)]
Make fetch chromium operate in git-only mode.

DO NOT LAND until Flag Day.

R=stip@chromium.org
BUG=406165

Review URL: https://codereview.chromium.org/494993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291565 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoDon't freak out if 'ignore_locks' options is not set.
vadimsh@chromium.org [Fri, 22 Aug 2014 23:56:49 +0000 (23:56 +0000)]
Don't freak out if 'ignore_locks' options is not set.

BUG=406636
R=stip@chromium.org

Review URL: https://codereview.chromium.org/497293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291561 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoStop git cl using CQ_TRYBOTS.
jam@chromium.org [Fri, 22 Aug 2014 22:13:21 +0000 (22:13 +0000)]
Stop git cl using CQ_TRYBOTS.

This is broken for a few reasons (see bug for details). Also, this works automatically now with the analyze step.

This is a revert of r280039.

BUG=406238
R=iannucci@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/501503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291526 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoSometimes options won't have a 'shallow' field. Don't freak out.
szager@chromium.org [Fri, 22 Aug 2014 21:00:22 +0000 (21:00 +0000)]
Sometimes options won't have a 'shallow' field.  Don't freak out.

BUG=406535
R=stip@chromium.org,vadimsh@chromium.org

Review URL: https://codereview.chromium.org/504473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291502 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUse a regex instead of shlex.split() to get remote url
hinoka@chromium.org [Fri, 22 Aug 2014 18:08:53 +0000 (18:08 +0000)]
Use a regex instead of shlex.split() to get remote url

shlex.spit(), in addition to doing str.split(' '), also strips out '\\'
from windows paths, which causes the cache_dir check to fail and Gclient to think
that we're not in cache_dir mode even if we are.

Instead of using shlex to strip data from a stdout log, I think regex is more
suited for this job.

BUG=405973

Review URL: https://codereview.chromium.org/497053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291446 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoTeach 'git cl land' to land to pending ref.
vadimsh@chromium.org [Fri, 22 Aug 2014 01:34:13 +0000 (01:34 +0000)]
Teach 'git cl land' to land to pending ref.

R=iannucci@chromium.org
BUG=404214

Review URL: https://codereview.chromium.org/496073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291302 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoDon't be pedantic about .gclient file for non-mutating commands.
szager@chromium.org [Thu, 21 Aug 2014 15:10:10 +0000 (15:10 +0000)]
Don't be pedantic about .gclient file for non-mutating commands.

This is primarily a hack to enable the chromeos ebuild.

BUG=367027
TBR=iannucci@chromium.org,mmoss@chromium.org

Review URL: https://codereview.chromium.org/490233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291075 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd stub git-drover documentation.
mmoss@chromium.org [Wed, 20 Aug 2014 23:23:28 +0000 (23:23 +0000)]
Add stub git-drover documentation.

R=iannucci@google.com
BUG=261738

Review URL: https://codereview.chromium.org/494873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290946 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoOnly check for clean repos when not (--force or --reset).
iannucci@chromium.org [Wed, 20 Aug 2014 23:08:00 +0000 (23:08 +0000)]
Only check for clean repos when not (--force or --reset).

This allows cache_dir to be enabled on bots when the individual repo path has
changes (like android_tools, which has a bunch of generated, non-ignored .h
files)

R=agable@chromium.org, szager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/488273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290943 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix manpage creation error.
mmoss@chromium.org [Wed, 20 Aug 2014 22:54:14 +0000 (22:54 +0000)]
Fix manpage creation error.

When running make_docs.sh, I get the error:
  asciidoc: FAILED: manpage document title is mandatory
  make: *** [git-cherry-pick-upload.xml] Error 1

I don't fully understand why, or why this hasn't come up before, but it
seems to be complaining about the formatting of "===" in
git-cherry-pick-upload.txt. This was with xmlto version 0.0.25 on
Precise.

R=iannucci@google.com

Review URL: https://codereview.chromium.org/489143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290939 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoHave git-cl try fail when used on a closed CL
agable@chromium.org [Wed, 20 Aug 2014 16:31:19 +0000 (16:31 +0000)]
Have git-cl try fail when used on a closed CL

R=phajdan.jr@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/494713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290844 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd --with_tags to enable git tag fetching.
szager@chromium.org [Tue, 19 Aug 2014 22:49:16 +0000 (22:49 +0000)]
Add --with_tags to enable git tag fetching.

Needed for chromeos ebuild.

BUG=chromium:376027
R=mmoss@chromium.org,hinoka@chromium.org

Review URL: https://codereview.chromium.org/490743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290683 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoNon-destructive editing of git cache config.
szager@chromium.org [Tue, 19 Aug 2014 21:19:19 +0000 (21:19 +0000)]
Non-destructive editing of git cache config.

R=agable@chromium.org,iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/485663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290665 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd expect_tests and testing_support to infra recipe.
iannucci@chromium.org [Sun, 17 Aug 2014 17:55:03 +0000 (17:55 +0000)]
Add expect_tests and testing_support to infra recipe.

For more better access :)

R=eseidel@chromium.org, stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/466923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290190 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoDiscover git.bat even if git_cl.py is executed using relative path
techtonik@gmail.com [Fri, 15 Aug 2014 20:01:53 +0000 (20:01 +0000)]
Discover git.bat even if git_cl.py is executed using relative path

This allows git_cl.py to be used without adding depot_tools to PATH

BUG=
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/471413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@289992 0039d316-1c4b-4281-b951-d872f2087c98