chromium/tools/depot_tools.git
7 hours agoRun `svn cleanup` before every update and reset. master
stip@chromium.org [Fri, 18 Apr 2014 08:05:01 +0000 (08:05 +0000)]
Run `svn cleanup` before every update and reset.

Testing on a bot with an 'unclean' Chromium checkout:

Unpatched `gclient revert -v -v -v --nohooks --upstream` (unclean checkout)
real    9m14.280s
user    0m37.238s
sys     0m37.738s

Patched 'gclient revert -v -v -v --nohooks --upstream'  (unclean checkout)
real    5m50.065s
user    1m18.889s
sys     0m57.860s

---------------- after patched gclient revert run (cleans the checkout)

Unpatched 'gclient revert -v -v -v --nohooks --upstream' (clean checkout)
real    0m21.602s
user    0m24.966s
sys     0m13.969s

Patched 'gclient revert -v -v -v --nohooks --upstream' (clean checkout)
real    0m27.467s
user    0m28.382s
sys     0m22.629s

BUG=336983

Review URL: https://codereview.chromium.org/240503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@264753 0039d316-1c4b-4281-b951-d872f2087c98

18 hours agoFixed reauthentication issue
pgervais@chromium.org [Thu, 17 Apr 2014 21:19:36 +0000 (21:19 +0000)]
Fixed reauthentication issue

Renewal of OAuth2 credentials did not work on appengine because it
replies with 302 instead of 401 when authentication fails. Configured
it to attempt credentials renewal on a 302.

Of course this will prevent any 302 from working normally, but it works
with Rietveld since it does not use 302.

BUG=319446

Review URL: https://codereview.chromium.org/238273011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@264639 0039d316-1c4b-4281-b951-d872f2087c98

22 hours agoMake Lockfile._remove_lockfile more robust on win32
pgervais@chromium.org [Thu, 17 Apr 2014 17:24:15 +0000 (17:24 +0000)]
Make Lockfile._remove_lockfile more robust on win32

Sometimes, removing lockfiles fails on windows, for obscure reasons.
Following advice from gclient_utils.rmtree, lock file removal has
been improved by using the builtin executable 'del' and retrying 3
times in case it fails.

BUG=

Review URL: https://codereview.chromium.org/240653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@264557 0039d316-1c4b-4281-b951-d872f2087c98

41 hours agobranch heads fix
hinoka@google.com [Wed, 16 Apr 2014 22:29:23 +0000 (22:29 +0000)]
branch heads fix

--with_branch_heads doesn't work with cache_dir, this fixes it.

BUG=

Review URL: https://codereview.chromium.org/239083007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@264331 0039d316-1c4b-4281-b951-d872f2087c98

2 days agoAbort git tools if git repo has too many local branches.
iannucci@chromium.org [Tue, 15 Apr 2014 20:02:44 +0000 (20:02 +0000)]
Abort git tools if git repo has too many local branches.

This is a stopgap to prevent people with >20 local branches from running tools
like 'git rebase-update'. This usually indicates that the user isn't in the
habit of cleaning up old branches, which makes these tools unlikely to be useful
in the current state of their repo anyway.

R=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/238213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263978 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdded implicit empty password to 'presubmit_support.py'
djacques@chromium.org [Tue, 15 Apr 2014 04:02:32 +0000 (04:02 +0000)]
Added implicit empty password to 'presubmit_support.py'

BUG=363477
TEST=localtest

Review URL: https://codereview.chromium.org/238603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263781 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAdded POST capability to oauth Rietveld
pgervais@chromium.org [Tue, 15 Apr 2014 00:30:37 +0000 (00:30 +0000)]
Added POST capability to oauth Rietveld

BUG=319446

Review URL: https://codereview.chromium.org/236093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263750 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoMove walkthrough to end of tutorial, add real TL;DR section.
iannucci@chromium.org [Mon, 14 Apr 2014 23:34:46 +0000 (23:34 +0000)]
Move walkthrough to end of tutorial, add real TL;DR section.

R=scottmg@chromium.org
BUG=261743

Review URL: https://codereview.chromium.org/238203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263746 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoAdd a bleeding-edge git version mode to depot_tools.
iannucci@chromium.org [Sat, 12 Apr 2014 20:01:49 +0000 (20:01 +0000)]
Add a bleeding-edge git version mode to depot_tools.

R=mmoss@google.com, mmoss@chromium.org
BUG=238428

Review URL: https://codereview.chromium.org/236303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263544 0039d316-1c4b-4281-b951-d872f2087c98

6 days agotrychange.py: create patch refs in refs/patches/
nodir@chromium.org [Sat, 12 Apr 2014 01:15:04 +0000 (01:15 +0000)]
trychange.py: create patch refs in refs/patches/

In Git-mode, the previous version of code created a ref in
refs/heads/refs/patches/...  instead of refs/patches/....
This commit fixes the problem.

R=maruel@chromium.org, agable@chromium.org
BUG=362264

Review URL: https://codereview.chromium.org/233913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263439 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoPut patches to refs/patches/<user>/<name>
nodir@chromium.org [Sat, 12 Apr 2014 01:01:31 +0000 (01:01 +0000)]
Put patches to refs/patches/<user>/<name>

When using Git, trychange.py used to put patches to refs/patches/<name>
refs, where <name> is a name of a patch. Now the using the username as a part
of the path.

This way we have better control over permissions per user basis

R=agable@chromium.org, iannucci@chromium.org
TEST=Sent a change to quickoffice try server. Master and slave do not
     need to be modified because the ref file in master branch points to
     the correct branch name

Review URL: https://codereview.chromium.org/231663005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263432 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoFix empty section appearing in git config for every rebase-update.
iannucci@chromium.org [Sat, 12 Apr 2014 00:14:41 +0000 (00:14 +0000)]
Fix empty section appearing in git config for every rebase-update.

Previously a `[depot-tools "rebase-update"]` section would show up in the
.git/config on every `git rebase-update` cycle.

R=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/228353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263423 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRun get_toolchain_if_necessary.py with depot_tools Python under Cygwin
wittman@chromium.org [Fri, 11 Apr 2014 18:57:09 +0000 (18:57 +0000)]
Run get_toolchain_if_necessary.py with depot_tools Python under Cygwin

get_toolchain_if_necessary.py contains a number of Windows-isms, including
computing hashes on Windows-style path names, so does not work under
Cygwin. This change reruns it under depot_tools' Windows Python if run
from Cygwin Python.

Review URL: https://codereview.chromium.org/233563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263301 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoImprovements and bugfixes to the depot_tools doc generation process.
iannucci@chromium.org [Fri, 11 Apr 2014 18:37:08 +0000 (18:37 +0000)]
Improvements and bugfixes to the depot_tools doc generation process.

Works on linux in addition to OS X now.

TBR=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/234733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263292 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoMake it possible to refer to github-style URLs.
scr@chromium.org [Fri, 11 Apr 2014 15:51:33 +0000 (15:51 +0000)]
Make it possible to refer to github-style URLs.

BUG=362248

Review URL: https://codereview.chromium.org/233333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263252 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoAbort `git cl push` if pushing into a local branch.
iannucci@chromium.org [Fri, 11 Apr 2014 09:32:56 +0000 (09:32 +0000)]
Abort `git cl push` if pushing into a local branch.

R=agable@chromium.org, szager@chromium.org
BUG=338102

Review URL: https://codereview.chromium.org/224863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263202 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoAdd a tutorial / walkthrough for pure-git workflow.
iannucci@chromium.org [Fri, 11 Apr 2014 04:51:49 +0000 (04:51 +0000)]
Add a tutorial / walkthrough for pure-git workflow.

TBR=agable@chromium.org, szager@chromium.org
BUG=261743

Review URL: https://codereview.chromium.org/225433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263164 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoAdd file:// case in presubmit_canned_checks.CheckLongLines
nednguyen@google.com [Fri, 11 Apr 2014 00:13:51 +0000 (00:13 +0000)]
Add file:// case in presubmit_canned_checks.CheckLongLines

BUG=

Review URL: https://codereview.chromium.org/234293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263142 0039d316-1c4b-4281-b951-d872f2087c98

7 days agogclient: fix deletion warning for checkouts created with "gclient config --name ."
borenet@google.com [Thu, 10 Apr 2014 21:12:25 +0000 (21:12 +0000)]
gclient: fix deletion warning for checkouts created with "gclient config --name ."

BUG=skia:1945

Review URL: https://codereview.chromium.org/226613011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263081 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoSplitUrlRevision when obtaining the cache_dir in gclient_scm.GetActualRemoteURL
borenet@google.com [Thu, 10 Apr 2014 18:50:23 +0000 (18:50 +0000)]
SplitUrlRevision when obtaining the cache_dir in gclient_scm.GetActualRemoteURL

BUG=361155

Review URL: https://codereview.chromium.org/230773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@263038 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoFix for GitWrapper._Capture
borenet@google.com [Thu, 10 Apr 2014 13:58:18 +0000 (13:58 +0000)]
Fix for GitWrapper._Capture

BUG=361155

Review URL: https://codereview.chromium.org/232993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262977 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoFix to path search redux.
szager@chromium.org [Wed, 9 Apr 2014 21:56:46 +0000 (21:56 +0000)]
Fix to path search redux.

TBR=agable@chromium.org,hinoka@chromium.org
BUG=

Review URL: https://codereview.chromium.org/232093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262832 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoFix PATH searching for Windows.
szager@chromium.org [Wed, 9 Apr 2014 21:54:21 +0000 (21:54 +0000)]
Fix PATH searching for Windows.

I am TBR-ing everything today.

TBR=agable@chromium.org,hinoka@chromium.org

Review URL: https://codereview.chromium.org/232083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262831 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoFix upload.py to properly use a local logger
agable@chromium.org [Wed, 9 Apr 2014 20:19:29 +0000 (20:19 +0000)]
Fix upload.py to properly use a local logger

When rietveld.py overrides upload.py's logging module, it generally works fine...
until someone tries to run upload.py with any level of verbosity. Then the
calls to logging.getLogger and logging.INFO/logging.DEBUG fail. This patches
upload.py to properly use a module-scope logger so that rietveld.py doesn't
have to perform invasive surgery, and everything just works.

This version of upload.py taken from upstream Rietveld at:
changeset:   1267:d7b39eca7dbe
branch:      chromium

R=djacques@chromium.org, maruel@chromium.org

Review URL: https://codereview.chromium.org/221423007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262793 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoFix order of format string parameters.
szager@chromium.org [Wed, 9 Apr 2014 19:45:40 +0000 (19:45 +0000)]
Fix order of format string parameters.

BUG=

Review URL: https://codereview.chromium.org/231623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262776 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoGet rid of UpdateSubmoduleConfig.
szager@chromium.org [Wed, 9 Apr 2014 19:27:25 +0000 (19:27 +0000)]
Get rid of UpdateSubmoduleConfig.

It runs very slowly on Windows, and it will soon be obsolete.

BUG=
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/229683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262770 0039d316-1c4b-4281-b951-d872f2087c98

8 days agogclient: print a warning if a dep would get deleted or moved in the future
borenet@google.com [Wed, 9 Apr 2014 19:09:08 +0000 (19:09 +0000)]
gclient: print a warning if a dep would get deleted or moved in the future

BUG=skia:1638

Review URL: https://codereview.chromium.org/189913020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262761 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoMake git_cache.py import-able.
szager@chromium.org [Wed, 9 Apr 2014 19:06:44 +0000 (19:06 +0000)]
Make git_cache.py import-able.

Evidence indicates that running non-builtin git commands is very
slow in msysgit, slow enough to dominate the running time of
gclient sync.  With this change, gclient never shells out to
git-cache; it import the lib directly instead.

R=agable@chromium.org,hinoka@chromium.org
BUG=

Review URL: https://codereview.chromium.org/229653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262759 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoRefactoring in trychange: _ParseSendChangeOptions
nodir@chromium.org [Wed, 9 Apr 2014 18:16:18 +0000 (18:16 +0000)]
Refactoring in trychange: _ParseSendChangeOptions

R=iannucci@chromium.org, agable@chromium.org
BUG=360180

Review URL: https://codereview.chromium.org/228113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262746 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoAdd --last_week/-W option to my_activity.py
jsbell@chromium.org [Wed, 9 Apr 2014 17:14:54 +0000 (17:14 +0000)]
Add --last_week/-W option to my_activity.py

Some weeks, writing snippets on Monday just doesn't happen. And during
those weeks, doing date arithmetic then correctly formatting a U.S.
date is too hard.

R=szager@chromium.org, deymo@chromium.org

Review URL: https://codereview.chromium.org/230823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262723 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoFor determining OWNERS, drop reviewers specified via '-r' that aren't in email addres...
isherman@chromium.org [Wed, 9 Apr 2014 09:06:19 +0000 (09:06 +0000)]
For determining OWNERS, drop reviewers specified via '-r' that aren't in email address format.

BUG=none
R=agable@chromium.org

Review URL: https://codereview.chromium.org/215153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262641 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoAlso fetch branch heads if requested on initial sync
jochen@chromium.org [Tue, 8 Apr 2014 21:06:11 +0000 (21:06 +0000)]
Also fetch branch heads if requested on initial sync

BUG=none
R=agable@chromium.org

Review URL: https://codereview.chromium.org/228293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262506 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoRevamped terminal output for update.
szager@chromium.org [Tue, 8 Apr 2014 20:50:44 +0000 (20:50 +0000)]
Revamped terminal output for update.

Features:

- Non-verbose output is now limited to a one-line progress
indicator.

- Verbose output is now collated per subprocess.  As soon as a
subprocess finishes, its full output is dumped to terminal.

- Verbose output is prefixed with timestamps representing elapsed
time since the beginning of the gclient invocation.

- git progress indicators ("Receiving objects", etc.) are limited to
one line every 10 seconds.

- In both verbose and non-verbose mode, if a failure occurs, the
full output of the failed update operation is dumped to terminal
just before exit.

- In the event that updates are progressing, but slowly,
"Still working" messages will be printed periodically, to pacify
users and buildbots.

BUG=
R=hinoka@google.com

Review URL: https://codereview.chromium.org/227163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262500 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoAllow trychange to submit empty patch sets again.
bradnelson@google.com [Tue, 8 Apr 2014 20:04:40 +0000 (20:04 +0000)]
Allow trychange to submit empty patch sets again.

A recent change to trychange prevents empty patches from being submitted:
https://codereview.chromium.org/184343003/diff/210001/trychange.py

parasite (used for the gyp waterfall) relies on empty patches to share nacl
trybots to build gyp at particular revisions.

BUG=None
TEST=local on master3
R=nodir@chromium.org

Review URL: https://codereview.chromium.org/228883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262493 0039d316-1c4b-4281-b951-d872f2087c98

9 days agogclient: Fix cache_dir functionality
borenet@google.com [Tue, 8 Apr 2014 19:40:30 +0000 (19:40 +0000)]
gclient: Fix cache_dir functionality

BUG=361155

Review URL: https://codereview.chromium.org/228793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262478 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoClarify the .gclient URL mismatch error message
borenet@google.com [Mon, 7 Apr 2014 20:06:02 +0000 (20:06 +0000)]
Clarify the .gclient URL mismatch error message

BUG=

Review URL: https://codereview.chromium.org/227603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@262182 0039d316-1c4b-4281-b951-d872f2087c98

13 days agoFix colorization bug in git_map.
iannucci@chromium.org [Fri, 4 Apr 2014 17:13:33 +0000 (17:13 +0000)]
Fix colorization bug in git_map.

Previously BRIGHT+WHITE would wrap around to the asterisk on the next line.

R=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/224933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@261783 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoUse get_or_create_merge_base in git-cl-upload to correctly deal with rebased
iannucci@chromium.org [Fri, 4 Apr 2014 00:31:55 +0000 (00:31 +0000)]
Use get_or_create_merge_base in git-cl-upload to correctly deal with rebased
upstreams.

In the event that users are NOT using the enhanced tooling, this is equivalent
to `git merge-base "@{u}" HEAD`. In the event that they are, this will catch
the case where their parent branch got rebased, but this branch hasn't been
rebased on the parent yet.

R=agable@chromium.org, szager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/224703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@261601 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoHave fetch set up tag fetch refspecs.
iannucci@chromium.org [Thu, 3 Apr 2014 02:36:44 +0000 (02:36 +0000)]
Have fetch set up tag fetch refspecs.

R=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/212413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@261264 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agogit-number cannot commit-tree without user config
nodir@chromium.org [Thu, 3 Apr 2014 01:43:32 +0000 (01:43 +0000)]
git-number cannot commit-tree without user config

user.name and/or user.email may be not configured, so specify them
explictly for commit-tree.

R=iannucci@chromium.org
BUG=354276

Review URL: https://codereview.chromium.org/222103006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@261256 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoRevert of revert and fix "Now trychange can...
nodir@chromium.org [Thu, 3 Apr 2014 01:01:06 +0000 (01:01 +0000)]
Revert of revert and fix "Now trychange can...

Bug=359292
Original commit: b1391c6a68b7154446b9acd4eb3eec5e7de27db3
Revert: 8e5f7d308fde74c52e321587649c16568e4a9644

Original commit comment:

> Now trychange can store patches in a Git repo

> A git patch repo is cloned to .git/git-try/patches-git, if was not
> cloned before. Otherwise, changes are pulled. Then a patch is committed a
> pushed.

> --revision=auto (Git only) is resolved to the revision the diff is genera
> against.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@261247 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoHave depot_tools manpage generation pin asciidoc version too.
iannucci@chromium.org [Thu, 3 Apr 2014 00:10:33 +0000 (00:10 +0000)]
Have depot_tools manpage generation pin asciidoc version too.

R=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/223053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@261235 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoRevert "Now trychange can store patches in a..."
nodir@chromium.org [Wed, 2 Apr 2014 23:32:08 +0000 (23:32 +0000)]
Revert "Now trychange can store patches in a..."

This reverts commit b1391c6a68b7154446b9acd4eb3eec5e7de27db3.

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@261220 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoRevert of Revert "gclient: Change the .gclient URL mismatch warning into an error...
borenet@google.com [Wed, 2 Apr 2014 19:12:13 +0000 (19:12 +0000)]
Revert of Revert "gclient: Change the .gclient URL mismatch warning into an error." (https://codereview.chromium.org/213483003/)

Reason for revert:
Re-landing this after https://codereview.chromium.org/214813002/

Original issue's description:
> Revert "gclient: Change the .gclient URL mismatch warning into an error."
>
> This reverts commit c01bff751856165467bd67abb3757a701deaa375.
>
> BUG=356881
> TBR=iannucci
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259727

TBR=iannucci@chromium.org,smut@google.com
NOTREECHECKS=true
NOTRY=true
BUG=356881

Review URL: https://codereview.chromium.org/221423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@261158 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoAdd a way for git cache to bootstrap off Google Storage.
hinoka@google.com [Wed, 2 Apr 2014 00:36:24 +0000 (00:36 +0000)]
Add a way for git cache to bootstrap off Google Storage.

This is based off the svn tarball bootstrap script in gclient_scm.py
Also included is a new command to create a new zarchive/zipball.

BUG=261741

Review URL: https://codereview.chromium.org/220423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@261002 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoIgnore anything after '@' in SCMWrapper.DoesRemoteURLMatch
borenet@google.com [Tue, 1 Apr 2014 16:41:36 +0000 (16:41 +0000)]
Ignore anything after '@' in SCMWrapper.DoesRemoteURLMatch

BUG=356881

Review URL: https://codereview.chromium.org/214813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260887 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoUse CheckCallAndFilterAndHeader for git commands.
agable@chromium.org [Tue, 1 Apr 2014 02:35:44 +0000 (02:35 +0000)]
Use CheckCallAndFilterAndHeader for git commands.

This causes git commands to be completely silent (they don't even print
______ running 'git foo bar') if the git command itself is completely silent.
This mirrors the behavior of SVN commands. This is useful for commands like
'gclient diff', which should print no output at all if there is no diff.

R=szager@chromium.org, vadimsh@chromium.org

Review URL: https://codereview.chromium.org/218993009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260758 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoRemember what branches we delete and do not try to reparent them in cleanup.
iannucci@chromium.org [Mon, 31 Mar 2014 23:36:10 +0000 (23:36 +0000)]
Remember what branches we delete and do not try to reparent them in cleanup.

R=agable@chromium.org
BUG=357367

Review URL: https://codereview.chromium.org/214133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260704 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoNow trychange can store patches in a Git repo
nodir@chromium.org [Sun, 30 Mar 2014 22:10:20 +0000 (22:10 +0000)]
Now trychange can store patches in a Git repo

A git patch repo is cloned to .git/git-try/patches-git, if was not
cloned before. Otherwise, changes are pulled. Then a patch is committed and
pushed.

--revision=auto (Git only) is resolved to the revision the diff is generated
against.

R=stip@chromium.org, agable@chromium.org, iannucci@chromium.org, maruel@chromium.org
BUG=325882

Review URL: https://codereview.chromium.org/184343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260471 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoDon't put unicode strings into the environment
rnk@chromium.org [Sun, 30 Mar 2014 00:56:32 +0000 (00:56 +0000)]
Don't put unicode strings into the environment

This fixes 'gclient recurse ...' on Windows.

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/167443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260405 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoReplaced boto certificate
pgervais@chromium.org [Fri, 28 Mar 2014 22:24:00 +0000 (22:24 +0000)]
Replaced boto certificate

Removed check on certificate SHA1 in gsutil

BUG=348233

Review URL: https://codereview.chromium.org/212553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260297 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoSuppress spurious warning about overriding cache dir.
szager@chromium.org [Fri, 28 Mar 2014 06:24:12 +0000 (06:24 +0000)]
Suppress spurious warning about overriding cache dir.

R=iannucci@chromium.org,hinoka@chromium.org
BUG=

Review URL: https://codereview.chromium.org/216013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260078 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoImprove error message in subprocess2.py.
luqui@chromium.org [Fri, 28 Mar 2014 00:57:44 +0000 (00:57 +0000)]
Improve error message in subprocess2.py.

BUG=

Review URL: https://codereview.chromium.org/215673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260049 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRe-enable git-1.9.0
szager@chromium.org [Thu, 27 Mar 2014 22:07:15 +0000 (22:07 +0000)]
Re-enable git-1.9.0

There is now a separate XP-compatible release which doesn't have
the performance fix for index-pack.

BUG=
NOTRY=true
R=mmoss@google.com

Review URL: https://codereview.chromium.org/215133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@260010 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoFix the gn wrapper to be aware of the --root argument.
dpranke@chromium.org [Thu, 27 Mar 2014 21:44:36 +0000 (21:44 +0000)]
Fix the gn wrapper to be aware of the --root argument.

The gn binary itself is capable of being run from outside of a
checkout as long as you pass the --root flag.

However, the gn.py wrapper script needs to *also* know where the the
checkout is, in order to figure out how to find the gn binary itself.

This patch changes the wrapper to be aware of the --root arg :).

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/212173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259998 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoFixing inadvertant CQ breakage from depot tools change.
sergeyberezin@chromium.org [Thu, 27 Mar 2014 19:06:33 +0000 (19:06 +0000)]
Fixing inadvertant CQ breakage from depot tools change.

CL that cause the issue: https://codereview.chromium.org/183793010

Symptoms: commit queue presubmit checks failed.

BUG=None

Review URL: https://codereview.chromium.org/215163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259947 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agowin_toolchain: Note that google.com credentials are required
scottmg@chromium.org [Thu, 27 Mar 2014 16:50:37 +0000 (16:50 +0000)]
win_toolchain: Note that google.com credentials are required

TBR=iannucci@chromium.org

Review URL: https://codereview.chromium.org/213913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259915 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAllow prodaccess based gsutil to also write into a bucket
hinoka@google.com [Thu, 27 Mar 2014 01:05:02 +0000 (01:05 +0000)]
Allow prodaccess based gsutil to also write into a bucket

The Telemetry workflow happily uses this gsutil to download artifacts, but they would also like to use the same workflow to upload artifacts.

I don't see a big harm in enabling read_write access for prodaccess based gsutil since its already more restrictive than the normal gsutil auth flow.  I could also be convinced to make this full_control, but that need has not arisen yet.

BUG= 341665

Review URL: https://codereview.chromium.org/148203012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259761 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRevert of Replaced boto certificate (https://codereview.chromium.org/212993005/)
hinoka@google.com [Wed, 26 Mar 2014 23:59:44 +0000 (23:59 +0000)]
Revert of Replaced boto certificate (https://codereview.chromium.org/212993005/)

Reason for revert:
This causes download_from_google_storage to fail:
Failure: CA certificates file does not have expected SHA1 sum; expected: ed024a78d9327f8669b3b117d9eac9e3c9460e9b, actual: 433e5589520cd2f1f29dea3e077cfbc2b74fb78c.

You'll need to also update the expectations on the gsutil side, and then reland.

Test it by running "gsutil ls".

Original issue's description:
> Replaced boto certificate
>
> BUG=348233
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=259692

TBR=stip@chromium.org,rsleevi@chromium.org,pgervais@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=348233

Review URL: https://codereview.chromium.org/213963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259744 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRevert "gclient: Change the .gclient URL mismatch warning into an error."
smut@google.com [Wed, 26 Mar 2014 22:36:03 +0000 (22:36 +0000)]
Revert "gclient: Change the .gclient URL mismatch warning into an error."

This reverts commit c01bff751856165467bd67abb3757a701deaa375.

BUG=356881
TBR=iannucci

Review URL: https://codereview.chromium.org/213483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259727 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoMake mark-merge-base cap the marked merge base at the real merge-base.
iannucci@chromium.org [Wed, 26 Mar 2014 21:27:47 +0000 (21:27 +0000)]
Make mark-merge-base cap the marked merge base at the real merge-base.

R=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/212213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259697 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoFix the print of the rebase error message, and make the output prettier too.
iannucci@chromium.org [Wed, 26 Mar 2014 21:23:09 +0000 (21:23 +0000)]
Fix the print of the rebase error message, and make the output prettier too.

For some reason .output doesn't throw an AttributeError, but returns None ,
instead. .stdout is the correct attribute.

R=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/212493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259695 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoReplaced boto certificate
pgervais@chromium.org [Wed, 26 Mar 2014 21:17:28 +0000 (21:17 +0000)]
Replaced boto certificate

BUG=348233

Review URL: https://codereview.chromium.org/212993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259692 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agogclient: Change the .gclient URL mismatch warning into an error.
borenet@google.com [Wed, 26 Mar 2014 20:54:45 +0000 (20:54 +0000)]
gclient: Change the .gclient URL mismatch warning into an error.

BUG=skia:1638

Review URL: https://codereview.chromium.org/208623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259681 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoSplit 'summary' manpages into section 7 (misc).
iannucci@chromium.org [Wed, 26 Mar 2014 19:20:34 +0000 (19:20 +0000)]
Split 'summary' manpages into section 7 (misc).

R=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/212593006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259655 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoMake udiff print reasonable errors while not on a branch.
iannucci@chromium.org [Wed, 26 Mar 2014 18:55:39 +0000 (18:55 +0000)]
Make udiff print reasonable errors while not on a branch.

R=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/212493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259647 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoExplicitly include root() in the git-map call to git-log.
iannucci@chromium.org [Wed, 26 Mar 2014 18:53:32 +0000 (18:53 +0000)]
Explicitly include root() in the git-map call to git-log.

This is in-place of --remotes. With repos like src.git that have alternate roots
this causes git-map to be faster (since it's not trying to display
origin/master).

R=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/212183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259646 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdded OAuth2 authentication to apply_issue
pgervais@chromium.org [Wed, 26 Mar 2014 18:44:43 +0000 (18:44 +0000)]
Added OAuth2 authentication to apply_issue

Added oauth2client and httplib to third_party

BUG=348233

Review URL: https://codereview.chromium.org/183793010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259643 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoLet ReadOnlyRietveld access the password.
agable@chromium.org [Wed, 26 Mar 2014 17:08:51 +0000 (17:08 +0000)]
Let ReadOnlyRietveld access the password.

The commit queue can't successfully run presubmit checks on top of
ReadOnlyRietveld because it requires access to the password field to pass
through to presubmit_shim.

R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/197213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259611 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoFix bad interpreters.
iannucci@chromium.org [Wed, 26 Mar 2014 06:54:55 +0000 (06:54 +0000)]
Fix bad interpreters.

Somehow some (but not all) git helper scripts got the wrong interpreter. This
fixes them to use /usr/bin/env.

TBR=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/212293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259522 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoFix bug in git_squash_branch.py.
iannucci@chromium.org [Wed, 26 Mar 2014 06:29:46 +0000 (06:29 +0000)]
Fix bug in git_squash_branch.py.

main takes args starting from 1, not 0.

TBR=agable@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/212223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259521 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd a family of git-commands to assist with the management of multiple CLs/branches.
iannucci@chromium.org [Wed, 26 Mar 2014 06:18:50 +0000 (06:18 +0000)]
Add a family of git-commands to assist with the management of multiple CLs/branches.

git-rebase-update - ensure all branches are up to date
git-new-branch - create branches
git-rename-branch - rename a branch while preserving parentage relationships
git-reparent-branch - change the parent of a branch, including rebasing it correctly onto that new parent.
git-squash-branch - collapse a branch into a single commit
git-upstream-diff - show the diff between the current branch and it's upstream branch
git-mark-merge-base - explicitly set what you want the above tools to consider the merge-base for the current branch.

R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/184253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259520 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd documentation for git-map-branches, git-map, git-nav-downstream,
iannucci@chromium.org [Tue, 25 Mar 2014 21:30:37 +0000 (21:30 +0000)]
Add documentation for git-map-branches, git-map, git-nav-downstream,
git-nav-upstream, as well as introduce a generic 'depot_tools' manpage with a
listing of the other tools.

This change also fully colorizes the EXAMPLE sections for the git-* commands to
reflect their actual appearance on the console (html only, manpage has bolding
hints).

R=agable@chromium.org, szager@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/200903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259338 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoInfer CL author and reviewer list from local state if the issue has not previously...
isherman@chromium.org [Tue, 25 Mar 2014 17:47:57 +0000 (17:47 +0000)]
Infer CL author and reviewer list from local state if the issue has not previously been uploaded.

R=agable@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/195793021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259250 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoDisabled threaded index-pack for known difficult repositories.
szager@chromium.org [Tue, 25 Mar 2014 06:02:08 +0000 (06:02 +0000)]
Disabled threaded index-pack for known difficult repositories.

BUG=349576
R=mmoss@google.com

Review URL: https://codereview.chromium.org/210063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259164 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agogclient: Fix nested checkout bug when validating .gclient
borenet@google.com [Mon, 24 Mar 2014 19:04:45 +0000 (19:04 +0000)]
gclient: Fix nested checkout bug when validating .gclient

BUG=355492

Review URL: https://codereview.chromium.org/209963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258989 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd warning batching in gclient_utils
borenet@google.com [Mon, 24 Mar 2014 18:35:23 +0000 (18:35 +0000)]
Add warning batching in gclient_utils

BUG=

Review URL: https://codereview.chromium.org/209393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258982 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agogclient: in managed mode, warn if .gclient has a mismatched URL
borenet@google.com [Fri, 21 Mar 2014 17:24:48 +0000 (17:24 +0000)]
gclient: in managed mode, warn if .gclient has a mismatched URL

BUG=

Review URL: https://codereview.chromium.org/195913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258617 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agomy_activity.py: Parse rietveld dates without milliseconds.
deymo@chromium.org [Thu, 20 Mar 2014 01:55:55 +0000 (01:55 +0000)]
my_activity.py: Parse rietveld dates without milliseconds.

Sometimes rietveld returns a datetime without the milliseconds part,
presumably when it is 0. This patch fixes the parsing of those cases.

BUG=chromium:323615
TEST=Ran "my_activity.py --week_of 11/18/13 --user jsbell" which returns "2013-11-18 20:42:30" for a bug.

Review URL: https://codereview.chromium.org/204013009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258189 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoFix compatibility for gcl-try/git-try with repos not using tryserver.chromium
phajdan.jr@chromium.org [Thu, 20 Mar 2014 00:31:23 +0000 (00:31 +0000)]
Fix compatibility for gcl-try/git-try with repos not using tryserver.chromium

BUG=334892

Review URL: https://codereview.chromium.org/205633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258174 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRevert git-1.9.0.
szager@chromium.org [Wed, 19 Mar 2014 23:28:17 +0000 (23:28 +0000)]
Revert git-1.9.0.

I've received a few reports of:

error: inflate: data stream error (incorrect header check)
fatal: serious inflate inconsistency
fatal: index-pack failed
error: Could not fetch origin

TBR=mmoss@chromium.org
BUG=

Review URL: https://codereview.chromium.org/205443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258147 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRemove force push from GitCheckout.commit()
agable@chromium.org [Wed, 19 Mar 2014 21:07:38 +0000 (21:07 +0000)]
Remove force push from GitCheckout.commit()

The CQ should not be able to force push -- this allows it to wipe out legitimate
commits if something goes wrong internally. This happened recently, with a CQ
commit orphaning 20 commits from the previous few days. This may have happened
any number of times previously, probably only wiping out one commit at a time,
whenever there was a race between the CQ and a developer's direct commit+push.

Repositories should also protect themselves by disallowing force push in their
ACLs.

BUG=261619

Review URL: https://codereview.chromium.org/196573041

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258092 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoUpdate to git-1.9.0.
szager@chromium.org [Wed, 19 Mar 2014 19:22:08 +0000 (19:22 +0000)]
Update to git-1.9.0.

Also, allow multiple git installations to exist side-by-side.
This makes it easier to revert back to an old version quickly.

BUG=
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/203463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258058 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRevert changes to checkout.GitCheckout.
agable@chromium.org [Wed, 19 Mar 2014 16:47:37 +0000 (16:47 +0000)]
Revert changes to checkout.GitCheckout.

Things have gone wrong. This change and subsequent fixes were not as safe as
they should have been. Reverting until we can diagnose exactly what has gone
wrong, and how to prevent it from happening again.

This reverts commit fa3c388ec59ec7949682d2ada6300da3f6f09b5a.
This reverts commit e569f50330b5d0b5cc564781a599a18674ac748b.
This reverts commit 7dc11449f0cb0aacc9ef72773d4d768d9e7bf775.

R=rmistry@chromium.org
TBR=rmistry@chromium.org
BUG=261619

Review URL: https://codereview.chromium.org/200923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258003 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRevert making apply_issue assume 'master'
agable@chromium.org [Wed, 19 Mar 2014 02:37:46 +0000 (02:37 +0000)]
Revert making apply_issue assume 'master'

Review URL: https://codereview.chromium.org/204013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257841 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAssume 'master' when remote branch not specified.
agable@chromium.org [Tue, 18 Mar 2014 21:27:59 +0000 (21:27 +0000)]
Assume 'master' when remote branch not specified.

This prevents apply_patch from attempting to check out a branch tracking 'origin/None'.

R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/202483008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257763 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoFix push-basic.sh. How did it ever pass? We may never know.
szager@chromium.org [Tue, 18 Mar 2014 20:45:46 +0000 (20:45 +0000)]
Fix push-basic.sh.  How did it ever pass?  We may never know.

BUG=

Review URL: https://codereview.chromium.org/203383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257738 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRationalize the git config settings for index-pack performance.
szager@chromium.org [Tue, 18 Mar 2014 20:32:04 +0000 (20:32 +0000)]
Rationalize the git config settings for index-pack performance.

BUG=

Review URL: https://codereview.chromium.org/202753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257728 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoPresubmit check improvements.
szager@chromium.org [Tue, 18 Mar 2014 17:23:48 +0000 (17:23 +0000)]
Presubmit check improvements.

- Don't pylint files in .gitignore or .git/info/excludes
- Print full path to modules in pylint.

BUG=

Review URL: https://codereview.chromium.org/202773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257672 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRemove --shallow from git cache call in gclient
hinoka@google.com [Tue, 18 Mar 2014 02:10:38 +0000 (02:10 +0000)]
Remove --shallow from git cache call in gclient

We don't want to do a shallow clone into the cache because it is not supported
on versions of git older than 1.9.

BUG=261741

Review URL: https://codereview.chromium.org/198103012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257578 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoFix error messages
szager@chromium.org [Tue, 18 Mar 2014 00:05:19 +0000 (00:05 +0000)]
Fix error messages

BUG=
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/198723010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257541 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRemove python.new.bat instead of pylint.new.bat
iannucci@chromium.org [Mon, 17 Mar 2014 20:36:57 +0000 (20:36 +0000)]
Remove python.new.bat instead of pylint.new.bat

python.new.bat was inadvertantly removed when iannucci@ committed
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/c64d3765a03aa66d980f66109f58eb3b05a4cb18

This restores pylint.new.bat and removes python.new.bat

Original CL: https://chromiumcodereview.appspot.com/140183007/

BUG=328453
AUTHOR=techtonik@gmail.com
R=agable@chromium.org

Review URL: https://codereview.chromium.org/196343024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257489 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoWindows: Bootstrap Python first and get rid of Python 2.6 legacy
iannucci@chromium.org [Fri, 14 Mar 2014 23:52:31 +0000 (23:52 +0000)]
Windows: Bootstrap Python first and get rid of Python 2.6 legacy

If loaded first, Python can then be used to replace JS bootstrapping
logic if appropriate libs are already present in depot_tools.

BUG=328453
AUTHOR=techtonik@gmail.com
R=iannucci@chromium.org, maruel@chromium.org

Review URL: https://codereview.chromium.org/140183007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257248 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd git_docs folder to depot_tools.
iannucci@chromium.org [Fri, 14 Mar 2014 21:40:49 +0000 (21:40 +0000)]
Add git_docs folder to depot_tools.

Includes trial documentation for git-freeze and git-thaw, as well as a
make_docs.sh script which generates man and html documentation from the input
asciidoc files, using git 1.9's documentation toolchain.

R=szager@chromium.org, agable@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/196133007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257214 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoPresubmit: fix accepted copyright dates.
rvargas@chromium.org [Fri, 14 Mar 2014 19:43:20 +0000 (19:43 +0000)]
Presubmit: fix accepted copyright dates.

2006-2009/10 was a valid copyright date format before 2011 (when we decided to
use only one year, not a range).

The current directive with copyright is in fact to not change old copyright
dates, so there is no plan to go back and "fix" old files. As such, the
presubmit checks should not be complaining about old files.

BUG=none

Review URL: https://codereview.chromium.org/200643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257181 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoAdd an error message when explicitly specifying bots without specifying the master
phajdan.jr@chromium.org [Fri, 14 Mar 2014 01:28:39 +0000 (01:28 +0000)]
Add an error message when explicitly specifying bots without specifying the master

BUG=352029

Review URL: https://codereview.chromium.org/199723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256972 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoFix gcl try after PRESUBMIT files have been modified for multiple tryserver support
phajdan.jr@chromium.org [Thu, 13 Mar 2014 22:25:53 +0000 (22:25 +0000)]
Fix gcl try after PRESUBMIT files have been modified for multiple tryserver support

Note that other waterfalls are not guaranteed to support triggering via HTTP
or SVN. That's why this hardcodes tryserver.chromium.

BUG=334892

Review URL: https://codereview.chromium.org/197553009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256947 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoEmergency fix to avoid gerrit 2.9
szager@chromium.org [Thu, 13 Mar 2014 21:09:12 +0000 (21:09 +0000)]
Emergency fix to avoid gerrit 2.9

BUG=

Review URL: https://codereview.chromium.org/199553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256925 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoAdd git thaw/freeze to depot_tools.
iannucci@chromium.org [Thu, 13 Mar 2014 07:55:15 +0000 (07:55 +0000)]
Add git thaw/freeze to depot_tools.

R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/181043018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256778 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoFix git_nav_downstream.py when origin/master is checked out.
iannucci@chromium.org [Thu, 13 Mar 2014 07:47:50 +0000 (07:47 +0000)]
Fix git_nav_downstream.py when origin/master is checked out.

Also fix missing copyright notices.

R=agable@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/196433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256777 0039d316-1c4b-4281-b951-d872f2087c98