chromium/tools/depot_tools.git
30 hours agogit_cl: Add reverse issue lookup. master
dnj@chromium.org [Tue, 3 Mar 2015 17:22:28 +0000 (17:22 +0000)]
git_cl: Add reverse issue lookup.

Add the ability to lookup the branch(es) corresponding to a specific
issue. This helps keep track of issues when switching between multiple
branches.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/969263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294307 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agoStop defaulting unrecognized branches to master except for handful of special refs.
rmistry@google.com [Tue, 3 Mar 2015 12:48:06 +0000 (12:48 +0000)]
Stop defaulting unrecognized branches to master except for handful of special refs.

Context:
In https://codereview.chromium.org/781523002/ I added the ability for target_ref to be set to any branch name. Eg: For Skia a ref of 'refs/remotes/origin/chrome/m42' would be correctly set to 'refs/heads/chrome/m42'.

But in https://codereview.chromium.org/822503005/ this was changed to treat any branch that did not start with 'refs/remotes/branch-heads' or 'refs/remotes/origin/refs' to be 'refs/remotes/origin/master'.
This makes it very chromium specific, there are plenty of other projects that use depot_tools that does not work like this.
For Skia 'refs/remotes/origin/chrome/m42' would now change to 'refs/remotes/origin/master' which is wrong.

The default behavior should be to preserve the original ref not to override it to master.

I handled 'lkgr' and 'lkcr' as special cases in this CL because many developers track it and would like it to land in master by default.

BUG=chromium:463109
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/967453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294303 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoFix the argument passed to main() in clang_format.py
tfarina@chromium.org [Sat, 28 Feb 2015 19:20:22 +0000 (19:20 +0000)]
Fix the argument passed to main() in clang_format.py

Passing arg[1] rather than argv[1:] is causing the following with
Python 2.7.3.

Traceback (most recent call last):
File "/home/tfarina/depot_tools/clang_format.py", line 70, in
<module>
sys.exit(main(sys.argv[1]))
File "/home/tfarina/depot_tools/clang_format.py", line 65,
in main
return subprocess.call([tool] + args)
TypeError: can only concatenate list (not "str") to list
No output from clang-format (crashed?).
Please report to bugs.llvm.org.

This started to happening after
http://src.chromium.org/viewvc/chrome?view=rev&revision=294250

BUG=None
TEST=try to format a c++ file using clang-format
TBR=sbc@chromium.org,maruel@chromium.org

Review URL: https://codereview.chromium.org/972453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294267 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoHandle KeyboardInterrupt consistently in python scripts
sbc@chromium.org [Thu, 26 Feb 2015 18:28:43 +0000 (18:28 +0000)]
Handle KeyboardInterrupt consistently in python scripts

Handle KeyboardInterrupt gracefully rather the printing a
backtrace. Most users of these tools don't expect a
backtrace when then hit Ctrl-C.

Also, fix a few other inconsistencies found in the python
startup code of these different scripts:
- always call main function 'main' (rather than 'Main')
- always return 0 from main function
- if main takes args never include argv[0]

Review URL: https://codereview.chromium.org/955993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294250 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAdd ability to specify and run post upload hooks.
rmistry@google.com [Thu, 26 Feb 2015 14:03:30 +0000 (14:03 +0000)]
Add ability to specify and run post upload hooks.

Motivation: There are a few things we want to do in Skia infrastructure that is not possible to do without this functionality.
Eg1: If there is a change made to Skia's markdown then automatically include a 'DOCS_PREVIEW_URL=https://skia.org?cl=1234' in the CL's description.
Eg2: Automatically add 'NOTRY=true' for changes impacting things that do not need trybot runs.
Eg3: Include CL specific links to skia's perf (https://perf.skia.org/) and correctness (https://gold.skia.org/) servers.

BUG=chromium:462208

Review URL: https://codereview.chromium.org/949273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294242 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoLet clients pass the verbose level they want to cpplint.
tfarina@chromium.org [Wed, 25 Feb 2015 03:23:11 +0000 (03:23 +0000)]
Let clients pass the verbose level they want to cpplint.

This came in this CL review https://codereview.chromium.org/947983003/

BUG=None
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/955713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294207 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoRun dartfmt when invoking git cl format.
erg@chromium.org [Mon, 23 Feb 2015 20:30:08 +0000 (20:30 +0000)]
Run dartfmt when invoking git cl format.

If the repository has third_party/dart-sdk/ unpacked, use that to
format dart files modified in the current patch.

BUG=459376
R=maruel@chromium.org, zra@google.com

Review URL: https://codereview.chromium.org/933383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294179 0039d316-1c4b-4281-b951-d872f2087c98

12 days agogclient: Add '--auto_rebase' sync option.
dnj@chromium.org [Fri, 20 Feb 2015 21:25:57 +0000 (21:25 +0000)]
gclient: Add '--auto_rebase' sync option.

This adds the '--auto_rebase' sync option, enabling parallel updates to
automatically rebase local Git branches during sync.

BUG=None
TEST=local

Review URL: https://codereview.chromium.org/930693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294151 0039d316-1c4b-4281-b951-d872f2087c98

13 days agoRemove the Singleton<T> presubmit check from presubmit_canned_checks.py
glider@chromium.org [Thu, 19 Feb 2015 16:33:33 +0000 (16:33 +0000)]
Remove the Singleton<T> presubmit check from presubmit_canned_checks.py
This check is specific to Chromium codebase, there's no point in having it in depot_tools.

BUG=None
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/924863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294124 0039d316-1c4b-4281-b951-d872f2087c98

13 days agoFix a bug in setting maxtries
phajdan.jr@chromium.org [Thu, 19 Feb 2015 11:42:45 +0000 (11:42 +0000)]
Fix a bug in setting maxtries

Noticed by Jens Widell in https://codereview.chromium.org/932333003/

TBR=maruel

BUG=459855

Review URL: https://codereview.chromium.org/933373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294123 0039d316-1c4b-4281-b951-d872f2087c98

13 days agoMake maxtries for Rietveld configurable
phajdan.jr@chromium.org [Thu, 19 Feb 2015 11:29:00 +0000 (11:29 +0000)]
Make maxtries for Rietveld configurable

R=machenbach
TBR=maruel

BUG=459855

Review URL: https://codereview.chromium.org/932333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294121 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoAdd hinoka@ to depot_tools OWNERS
hinoka@chromium.org [Tue, 17 Feb 2015 21:30:28 +0000 (21:30 +0000)]
Add hinoka@ to depot_tools OWNERS

BUG=

Review URL: https://codereview.chromium.org/874763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294095 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks ago[download_from_google_storage] Don't list ALL objects to check for ACLs
primiano@chromium.org [Tue, 17 Feb 2015 12:33:35 +0000 (12:33 +0000)]
[download_from_google_storage] Don't list ALL objects to check for ACLs

Currently check_bucket_permissions() in download_from_google_storage.py
performs a gsutil ls gs://bucket to determine whether the user has access
to the bucket or not.
This can be an EXTREMELY expensive operation (~minutes) if the bucket in
question has a lot of objects in the root (real case: chrome-telemetry).
It is worth noting that check_bucket_permissions() is not called just for
uploads but also for downloads, hence this is slowing down all invocations
of gclient sync on users and bots machine.
Removing the check_bucket_permissions() and let gsutil fail with an
Unauthorized error message if ACLs are not met.

BUG=458059

Review URL: https://codereview.chromium.org/923473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294083 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoReland "Make gclient ready for the Blink (DEPS to main project)"
primiano@chromium.org [Tue, 17 Feb 2015 11:15:40 +0000 (11:15 +0000)]
Reland "Make gclient ready for the Blink (DEPS to main project)"

Reland crrev.com/743083002, which was reverted in crrev.com/796053002
due to some test flakiness, probably related with an old version of Git on
the bots. Relanding now that the infra has been updated to Trusty (plus
adding some de-flake precautions).

Original CL Description:
Make gclient ready for the Blink (DEPS to main project) transition

This CL makes gclient understand correctly whether a git project is
being moved from DEPS to an upper project and vice-versa.
The driving use case for this is the upcoming Blink merge, where
third_party/Webkit will be removed from DEPS (and .gitignore) and will
become part of the main project.

At present state, gclient leaves the .git folder around when a project
is removed from DEPS, and that causes many problems.

Furthermore this CL solves the performance problem of bisecting across
the merge point. The subproject's (Blink) .git/ folder is moved to a
backup location (in the main checkout root) and is restored when moving
backwards, avoiding a re-fetch when bisecting across the merge point.

BUG=431469

Review URL: https://codereview.chromium.org/910913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294082 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoAdd a --squash option to Gerrit uploads.
bauerb@chromium.org [Mon, 16 Feb 2015 10:45:39 +0000 (10:45 +0000)]
Add a --squash option to Gerrit uploads.

This makes uploading to Gerrit with `git cl` more similar to uploading to Rietveld, by uploading a squashed commit containing the diff to the newest common ancestor.

Uploaded commits are stored in refs/heads/git_cl_uploads/<branch> (and their commit message is used for the squash commit), which allows amending the commit message to change it on the uploaded CL, and looking through the reflog to find old uploaded versions.

BUG=none

Review URL: https://codereview.chromium.org/200023004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294077 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoCreate brillo wrapper command.
dgarrett@chromium.org [Wed, 11 Feb 2015 00:58:10 +0000 (00:58 +0000)]
Create brillo wrapper command.

Add support for 'brillo' as an entry command distinct from 'cros'. It
still does exactly the same thing... for now.

BUG=brillo:162
TEST=Ran "brillo help" successfully.

Review URL: https://codereview.chromium.org/896393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294021 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoFix infra and infra_internal fetch recipes.
iannucci@chromium.org [Thu, 5 Feb 2015 01:56:14 +0000 (01:56 +0000)]
Fix infra and infra_internal fetch recipes.

expect_tests and testing_support are now pulled in via DEPS.

R=cmp@chromium.org, pgervais@chromium.org
BUG=

Review URL: https://codereview.chromium.org/901083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293963 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoThe original assertions trigger pylint unreachable warnings, and they are replaced...
wychen@chromium.org [Tue, 3 Feb 2015 21:46:52 +0000 (21:46 +0000)]
The original assertions trigger pylint unreachable warnings, and they are replaced by fail() calls.

Review URL: https://codereview.chromium.org/899503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293930 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAllow branch name to be the same as directory name for "git cl diff"
wychen@chromium.org [Tue, 3 Feb 2015 02:11:29 +0000 (02:11 +0000)]
Allow branch name to be the same as directory name for "git cl diff"

Remove the ambiguity between revision and filename (or directory name)
when using command "git cl diff".

BUG=454032

Review URL: https://codereview.chromium.org/889093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293914 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agomy_activity.py: Add brillo bug tracker.
deymo@chromium.org [Mon, 2 Feb 2015 22:19:46 +0000 (22:19 +0000)]
my_activity.py: Add brillo bug tracker.

BUG=brillo:90
TEST=./my_activity.py shows brillo bugs.

Review URL: https://codereview.chromium.org/891543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293912 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRemove redundant checks.
cmp@chromium.org [Mon, 2 Feb 2015 22:09:46 +0000 (22:09 +0000)]
Remove redundant checks.

R=maruel@chromium.org

Review URL: https://codereview.chromium.org/884243006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293911 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoSet default Windows git to 1.9.5-chromium.6 build.
mmoss@chromium.org [Mon, 2 Feb 2015 20:37:38 +0000 (20:37 +0000)]
Set default Windows git to 1.9.5-chromium.6 build.

R=iannucci@chromium.org, iannucci@google.com
BUG=444470

Review URL: https://codereview.chromium.org/887563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293909 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoBump bleeding edge git to 1.9.5-chromium.6 build.
scottmg@chromium.org [Fri, 30 Jan 2015 22:47:41 +0000 (22:47 +0000)]
Bump bleeding edge git to 1.9.5-chromium.6 build.

BUG=444470
R=scottmg@chromium.org, iannucci@google.com

Review URL: https://codereview.chromium.org/888923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293889 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoSupport --target-branch option to git-cl upload for Rietveld
wittman@chromium.org [Mon, 26 Jan 2015 20:15:50 +0000 (20:15 +0000)]
Support --target-branch option to git-cl upload for Rietveld

This is similar to the Gerrit behavior in that we default to master,
unless the remote upstream is a branch head.

BUG=435702

Review URL: https://codereview.chromium.org/822503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293807 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agopylint: upgrade to 1.4.1
vapier@chromium.org [Mon, 26 Jan 2015 20:04:40 +0000 (20:04 +0000)]
pylint: upgrade to 1.4.1

This is largely a bugfix release, so should be much easier to transition.

BUG=chromium:431514
TEST=ran on some code bases and checked output

Review URL: https://codereview.chromium.org/876793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293806 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoHook sys.stdio directly to the gsutil subprocess for the gsutil call
hinoka@chromium.org [Sat, 24 Jan 2015 00:55:46 +0000 (00:55 +0000)]
Hook sys.stdio directly to the gsutil subprocess for the gsutil call

So that gsutil.py config works.

I would've preferred the execv solution, but apparently that didn't work on Windows :(

BUG=451551

Review URL: https://codereview.chromium.org/870093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293790 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoConvenience git extension for converting a chromium git commit number to a git hash.
szager@chromium.org [Fri, 23 Jan 2015 00:56:04 +0000 (00:56 +0000)]
Convenience git extension for converting a chromium git commit number to a git hash.

Context:

https://groups.google.com/a/chromium.org/d/msg/chromium-dev/IcZ3C_ooKUM/ux559wpM_9cJ

R=stip@chromium.org, iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/868943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293765 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoRemove testfilter support from "git cl"
phajdan.jr@chromium.org [Thu, 22 Jan 2015 10:37:09 +0000 (10:37 +0000)]
Remove testfilter support from "git cl"

BUG=432498

Review URL: https://codereview.chromium.org/860353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293743 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoRemove the 'author_counts_as_owner' option from CheckOwners().
dpranke@chromium.org [Fri, 16 Jan 2015 22:38:38 +0000 (22:38 +0000)]
Remove the 'author_counts_as_owner' option from CheckOwners().

Way back in r185294 I added the ability to request that, when
checking owners, the patch author *should not* count (normally it does
count). We did this in order to be able to mimic the review processes
of WebKit in the Blink repo.

However, we ended up never using this feature, so I'm finally getting
around to deleting it.

R=maruel@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/851103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293685 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoSupport optional BOTO specification with --no_auth.
mmoss@chromium.org [Thu, 15 Jan 2015 19:00:49 +0000 (19:00 +0000)]
Support optional BOTO specification with --no_auth.

This prevents --no_auth from always clearing BOTO_CONFIG, since there
are times when a BOTO is needed for other things than just auth info
(e.g. proxy settings).

BUG=443523
R=hinoka@chromium.org, szager@chromium.org

Review URL: https://codereview.chromium.org/844373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293652 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoAdd checks to GitSanityChecks (upstream branch or current branch can be None)
sbc@chromium.org [Wed, 14 Jan 2015 21:18:12 +0000 (21:18 +0000)]
Add checks to GitSanityChecks (upstream branch or current branch can be None)

I've run in the exceptions a few times when doing
'git cl presubmit' or 'git cl lint' from a detached
HEAD state (not uncommon when using 'git rebase-update')

Review URL: https://codereview.chromium.org/792933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293643 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoUpdate dpranke's entry in the WATCHLISTS.
dpranke@chromium.org [Tue, 13 Jan 2015 23:45:00 +0000 (23:45 +0000)]
Update dpranke's entry in the WATCHLISTS.

TBR=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/848133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293621 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoFixed ``smart'' quotes in code block.
dnj@chromium.org [Tue, 13 Jan 2015 23:38:11 +0000 (23:38 +0000)]
Fixed ``smart'' quotes in code block.

This document generation round also includes additional generated content that
was not checked in from previous commits.

BUG=chromium:440844
TEST=local
  - Loaded HTML page in local browser, confirmed quotes were correct.

Review URL: https://codereview.chromium.org/788293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293620 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoSwitching nacl git recipe for fetch.
bradnelson@google.com [Sat, 10 Jan 2015 01:07:13 +0000 (01:07 +0000)]
Switching nacl git recipe for fetch.

BUG=None
TEST=local
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/824153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293595 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoPRESUBMIT: Ignore external_bin/.
raphael.kubo.da.costa@intel.com [Thu, 8 Jan 2015 22:28:34 +0000 (22:28 +0000)]
PRESUBMIT: Ignore external_bin/.

This is created for the external gsutil since r293320, and was creating
needless churn in presubmit tests when it is present.

R=pgervais@chromium.org,hinoka@google.com
BUG=434422

Review URL: https://codereview.chromium.org/831913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293574 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoAdd cross-platform resilience to gclient CPU count probe.
dnj@chromium.org [Wed, 7 Jan 2015 19:54:57 +0000 (19:54 +0000)]
Add cross-platform resilience to gclient CPU count probe.

BUG=chromium:444597

Review URL: https://codereview.chromium.org/819133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293549 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoAdded error check to git cl that we are on a branch when we try to upload.
luqui@chromium.org [Wed, 7 Jan 2015 00:29:29 +0000 (00:29 +0000)]
Added error check to git cl that we are on a branch when we try to upload.

BUG=443264

R=iannucci@chromium.org,maruel@chromium.org

Review URL: https://codereview.chromium.org/811023003/

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293537 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoAdd category property to tryjob
sheyang@chromium.org [Tue, 6 Jan 2015 00:42:39 +0000 (00:42 +0000)]
Add category property to tryjob

BUG=431792

Review URL: https://codereview.chromium.org/805663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293525 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix gsutil execution on Windows.
djacques@chromium.org [Mon, 29 Dec 2014 19:50:00 +0000 (19:50 +0000)]
Fix gsutil execution on Windows.

5498b95831de0711fda19f2aabac4645ffb6cc78 runs gsutil using 'os.execv',
which, on Windows, apparently causes it to return before completion.

Also add verbosity to '7z' failures on toolchain downloading.

BUG=chromium:445425
TEST=bot
  - Ran on bot, this fix solves the problem that we were seeing.

R=pgervais@chromium.org, sergeyberezin@chromium.org

Review URL: https://codereview.chromium.org/828463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293507 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix for print(file=something)
loislo@chromium.org [Thu, 25 Dec 2014 15:28:22 +0000 (15:28 +0000)]
Fix for print(file=something)

BUG=
TBR= dpranke@chromium.org, enne@chromium.org, apavlov@chromium.org

Review URL: https://codereview.chromium.org/829453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293503 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoSpeculative fix for build on windows build bots.
loislo@chromium.org [Thu, 25 Dec 2014 13:48:37 +0000 (13:48 +0000)]
Speculative fix for build on windows build bots.

The root of problem is a _cache_temp file.
git_cache expected that it is a folder.
So rmtree failed to remove it.

BUG=
TBR= dpranke@chromium.org, enne@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/825133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293502 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoMade gsutil.py truly transparent
pgervais@chromium.org [Tue, 23 Dec 2014 23:40:29 +0000 (23:40 +0000)]
Made gsutil.py truly transparent

The previous version was modifying gsutil output by adding a
stacktrace upon non-zero return code, which broke existing code.

BUG=400871
R=hinoka@chromium.org

Review URL: https://codereview.chromium.org/822093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293501 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoSwitch default windows git version to 1.9.5.
iannucci@chromium.org [Sat, 20 Dec 2014 02:00:52 +0000 (02:00 +0000)]
Switch default windows git version to 1.9.5.

R=pgervais@chromium.org, agable@chromium.org, friedman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/800003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293482 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoSwitch the remaining third_party gsutil references to gsutil.py
hinoka@chromium.org [Sat, 20 Dec 2014 01:47:31 +0000 (01:47 +0000)]
Switch the remaining third_party gsutil references to gsutil.py

BUG=
R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/809203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293481 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoGreatly clean up depot_tools handling of git binaries, add bleeding edge support...
iannucci@chromium.org [Sat, 20 Dec 2014 01:42:44 +0000 (01:42 +0000)]
Greatly clean up depot_tools handling of git binaries, add bleeding edge support for 1.9.5

R=agable@chromium.org, friedman@google.com, maruel@chromium.org, pgervais@chromium.org, friedman@chromium.org, mmoss@chromium.org, szager@chromium.org, vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/816173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293480 0039d316-1c4b-4281-b951-d872f2087c98

2 months agopresubmit_unittest: Fix pylint errors.
raphael.kubo.da.costa@intel.com [Fri, 19 Dec 2014 17:04:15 +0000 (17:04 +0000)]
presubmit_unittest: Fix pylint errors.

The recent pylint 1.3.1 and 1.4.0 upgrades have caused some new errors
to be reported for presubmit_unittest:

* presubmit_support.InputApi.AffectedFiles() expectes a parameter called
  |include_deletes|, not |include_deleted|.

* The mock AffectedFiles() implementation in
  CannedChecksUnittest.testCannedCheckChangeHasNoTabs() had its
  signature updated to match the one in presubmit_support.InputApi,
  otherwise pylint would (erroneously) consider that this mock
  implementation was used in all other AffectedFiles() invocations in
  CannedChecksUnittest and complain that some parameters were missing.
  It makes more sense to do this than disable the check and miss real
  problems in the future.

R=maruel@chromium.org, iannucci@chromium.org, pgervais@chromium.org
BUG=443232

Review URL: https://codereview.chromium.org/802403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293468 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAllow to skip revision check in roll-dep.
machenbach@chromium.org [Thu, 18 Dec 2014 15:42:43 +0000 (15:42 +0000)]
Allow to skip revision check in roll-dep.

Without this change, roll-dep requires dependencies to be
checked out and up to date in order to roll a newer revision.

This change allows to use roll-dep with less checking and
makes the script user responsible to verify the correctness
of the deps path and git hash.

This eases writing a deps roller that updates multiple deps
including a variety of os deps, which might not be checked
out on the host of the deps roller.

BUG=438705, 437462
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/801643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293444 0039d316-1c4b-4281-b951-d872f2087c98

2 months agogsutil: Use urllib2 instead of urllib.
primiano@chromium.org [Thu, 18 Dec 2014 11:12:34 +0000 (11:12 +0000)]
gsutil: Use urllib2 instead of urllib.

This is similar to r247914 and r149742: urllib does not work with SSL
connections behind proxies, we need to use urllib2 instead. Doing this
should allow people behind proxies to download gsutils 4.7 after
r293413.

(Setting NOTRY here to be able to land the issue, otherwise the CQ fails when running some presubmit checks, see crbug.com/443232)

R=maruel@chromium.org, hinoka@chromium.org, pgervais@chromium.org, primiano@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/809053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293439 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoArgs fix for gsutil.py
hinoka@chromium.org [Thu, 18 Dec 2014 01:06:20 +0000 (01:06 +0000)]
Args fix for gsutil.py

"--" is the hard keyword to separate gsutil commands from gsutil.py commands.

BUG=
R=dnj@chromium.org

Review URL: https://codereview.chromium.org/812223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293433 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix setting the executable bit in download_from_google_storage.
dpranke@chromium.org [Wed, 17 Dec 2014 23:47:23 +0000 (23:47 +0000)]
Fix setting the executable bit in download_from_google_storage.

The new GSUtil (or gs protocol, who knows) strips off the redundent x-goog-meta
string from the metadata key.  This CL compensates for that.

Also since we're on 4.7, we can use the faster gsutil stat instead of gsutil ls -L.

BUG=
TEST=ran download_from_google_storage against compiler_proxy.sha, works
NOTREECHECKS=true
NOTRY=true
R=dnj@chromium.org, pgervais@chromium.org

Review URL: https://codereview.chromium.org/809123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293432 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUse gsutil.py for download_from_google_storage instead of the builtin one
hinoka@chromium.org [Wed, 17 Dec 2014 02:17:14 +0000 (02:17 +0000)]
Use gsutil.py for download_from_google_storage instead of the builtin one

This pins gsutil to a vanilla 4.7 instead of the weird custom 3.4 we have in depot_tools

BUG=
R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/797663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293413 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUpdate documentation to accurately reflect the new URL of depot_tools.
erikchen@chromium.org [Tue, 16 Dec 2014 00:48:01 +0000 (00:48 +0000)]
Update documentation to accurately reflect the new URL of depot_tools.

BUG=

Review URL: https://codereview.chromium.org/789733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293401 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUpdates the depot_tools repository URL in the docs.
charliea@google.com [Mon, 15 Dec 2014 20:01:52 +0000 (20:01 +0000)]
Updates the depot_tools repository URL in the docs.

Review URL: https://codereview.chromium.org/809473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293398 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUse grep -e --force instead of grep "--force" since apparently the latter doesn't...
pkasting@chromium.org [Fri, 12 Dec 2014 19:26:49 +0000 (19:26 +0000)]
Use grep -e --force instead of grep "--force" since apparently the latter doesn't work properly in all cases.

BUG=441072
TEST=No errors from gclient :/

Review URL: https://codereview.chromium.org/802513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293380 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd lint_filters parameter to CheckChangeLintsClean function.
tfarina@chromium.org [Fri, 12 Dec 2014 00:03:49 +0000 (00:03 +0000)]
Add lint_filters parameter to CheckChangeLintsClean function.

The idea here is that when one of the filters are cleaned up in Chromium,
they should not be filtered out, otherwise we won't catch them in
the presubmit step.

See for example -> https://codereview.chromium.org/788493002/

BUG=None
R=agable@chromium.org, dpranke@chromium.org

Review URL: https://codereview.chromium.org/779033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293357 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd pending prefix to the target_ref if it is specified
rmistry@google.com [Thu, 11 Dec 2014 23:41:21 +0000 (23:41 +0000)]
Add pending prefix to the target_ref if it is specified

BUG=435702

Review URL: https://codereview.chromium.org/797793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293356 0039d316-1c4b-4281-b951-d872f2087c98

2 months agopylint: upgrade to 1.4.0
vapier@chromium.org [Thu, 11 Dec 2014 21:40:52 +0000 (21:40 +0000)]
pylint: upgrade to 1.4.0

This is largely a bugfix release, so should be much easier to transition.

BUG=chromium:431514
TEST=ran on some code bases and checked output

Review URL: https://codereview.chromium.org/753543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293355 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoRevert of Make gclient ready for the Blink (DEPS to main project) transition (patchse...
primiano@chromium.org [Thu, 11 Dec 2014 17:25:28 +0000 (17:25 +0000)]
Revert of Make gclient ready for the Blink (DEPS to main project) transition (patchset #6 id:180001 of https://codereview.chromium.org/743083002/)

Reason for revert:
The test intoruced is flake (see crrev.com/753543006/).
Need to look into that with more patience as it reproduces only on precise.

Original issue's description:
> Make gclient ready for the Blink (DEPS to main project) transition
>
> This CL makes gclient understand correctly whether a git project is
> being moved from DEPS to an upper project and vice-versa.
> The driving use case for this is the upcoming Blink merge, where
> third_party/Webkit will be removed from DEPS (and .gitignore) and will
> become part of the main project.
>
> At present state, gclient leaves the .git folder around when a project
> is removed from DEPS, and that causes many problems.
>
> Furthermore this CL solves the performance problem of bisecting across
> the merge point. The subproject's (Blink) .git/ folder is moved to a
> backup location (in the main checkout root) and is restored when moving
> backwards, avoiding a re-fetch when bisecting across the merge point.
>
> BUG=431469
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293329

TBR=iannucci@chromium.org,maruel@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=431469

Review URL: https://codereview.chromium.org/796053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293352 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoImprove default email address for my_reviews.py
sbc@chromium.org [Thu, 11 Dec 2014 17:15:26 +0000 (17:15 +0000)]
Improve default email address for my_reviews.py

Also, fix assertion that fires if all the reviews are
on the same day (first_day == last_day)

Also, don't print backtrace if no arguments at all are
specified.

Review URL: https://codereview.chromium.org/797523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293351 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix test failures on Ubuntu/Trusty.
sbc@chromium.org [Thu, 11 Dec 2014 03:06:48 +0000 (03:06 +0000)]
Fix test failures on Ubuntu/Trusty.

I ran into several failures running the presubmit checks
on my Ubuntu/Trusty laptop and it looks like a some of
the tests were broken by recent versions of svn and git.

Review URL: https://codereview.chromium.org/795723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293341 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAvoid =~ since msysgit bash doesn't support it.
pkasting@chromium.org [Wed, 10 Dec 2014 23:29:25 +0000 (23:29 +0000)]
Avoid =~ since msysgit bash doesn't support it.

This uses grep instead.  Note that just grepping for "--force" matches other
things, e.g. "foo--force--foo", but that's a problem with the original code as
well, I think.

BUG=435729
TEST=Run gclient under msysgit bash.  No error should occur.

Review URL: https://codereview.chromium.org/789353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293340 0039d316-1c4b-4281-b951-d872f2087c98

2 months agodepot_tools: Send the remote tracked ref to Rietveld via upload.py.
rmistry@google.com [Wed, 10 Dec 2014 20:58:24 +0000 (20:58 +0000)]
depot_tools: Send the remote tracked ref to Rietveld via upload.py.

This change goes hand in hand with the corresponding Rietveld change here:
https://codereview.chromium.org/773083004/
The motivation for both CLs came from the discussion in the internal CL: https://chromereviews.googleplex.com/115567013/

AFAIK either change can be submitted first without breaking anything in the other framework.

Observe the "Tracked Ref" field in the below CLs-

Tracking a remote ref:
* https://skia-codereview-staging.appspot.com/8861001 (Tracking skiabot-test's refs/heads/master)
* https://skia-codereview-staging.appspot.com/851002 (Tracking skiabot-test's refs/diff/test1)
* https://skia-codereview-staging.appspot.com/2891001 (Tracking Chromium's refs/heads/master)
* https://skia-codereview-staging.appspot.com/1931003 (Tracking Chromium's refs/branch-heads/1916)

Tracking a local branch which in turn tracks a remote ref:
* https://skia-codereview-staging.appspot.com/3891002 (Transitively tracking skiabot-test's refs/heads/master)
* https://skia-codereview-staging.appspot.com/4921001 (Transitively tracking Chromium's refs/branch-heads/1916)

CL when no target_ref is specified in depot_tools/third_party/upload.py:
* https://skia-codereview-staging.appspot.com/3871003 (CL with missing target_ref should default to /refs/heads/master)

Try the above links with and without the 'Deprecated UI' checked in https://skia-codereview-staging.appspot.com/settings

BUG=435702

Review URL: https://codereview.chromium.org/781523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293334 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoMake gclient ready for the Blink (DEPS to main project) transition
primiano@chromium.org [Wed, 10 Dec 2014 15:53:41 +0000 (15:53 +0000)]
Make gclient ready for the Blink (DEPS to main project) transition

This CL makes gclient understand correctly whether a git project is
being moved from DEPS to an upper project and vice-versa.
The driving use case for this is the upcoming Blink merge, where
third_party/Webkit will be removed from DEPS (and .gitignore) and will
become part of the main project.

At present state, gclient leaves the .git folder around when a project
is removed from DEPS, and that causes many problems.

Furthermore this CL solves the performance problem of bisecting across
the merge point. The subproject's (Blink) .git/ folder is moved to a
backup location (in the main checkout root) and is restored when moving
backwards, avoiding a re-fetch when bisecting across the merge point.

BUG=431469

Review URL: https://codereview.chromium.org/743083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293329 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoGSUtil.py wrapper script
hinoka@chromium.org [Wed, 10 Dec 2014 02:04:39 +0000 (02:04 +0000)]
GSUtil.py wrapper script

This is for transitioning us out of the horribly outdated gsutil 3.4 thats
currently residing in depot_tools.  This script:
1. Downloads GSUtil, pinned to a version (4.6 by default).
2. Executes GSUtil with the given parameters
3. (TODO) Runs the fallback GSUtil if #2 fails.

The transition plan is:
1. Set the fallback as default, making this script a no-op
2. Modify recipes (main consumer of gsutil) to pass in --force_version 4.6
3. Switch 4.6 as the default for gsutil.py
4. Make fallback failure a loud red failure
5. Remove depot_tools/third_party/gsutil

BUG=434422

Review URL: https://codereview.chromium.org/742173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293320 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoLet `git cl format` format java files, too.
thakis@chromium.org [Tue, 9 Dec 2014 21:21:53 +0000 (21:21 +0000)]
Let `git cl format` format java files, too.

This will only have an effect if one's buildtools checkout is new enough, since
only then:

a) clang-format will be new enough to do a decent job for java files
b) clang-format-diff.py will be new enough to look at java files

So for older buildtools checkouts, `git cl format` will continue to ignore java
files.  For newer buildtools checkouts (like the one pulled by `gclient sync`
with a recent chromium checkout), it'll work and do a fairly decent job.

BUG=429372

Review URL: https://codereview.chromium.org/788933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293312 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd fetch recipe for Skia's Buildbot repository.
tfarina@chromium.org [Sat, 6 Dec 2014 21:43:25 +0000 (21:43 +0000)]
Add fetch recipe for Skia's Buildbot repository.

Tested with the following command lines:

$ cd
$ mkdir skia_test
$ cd skia_test
$ fetch skia_buildbot
$ cd skia_buildbot
 # confirm the repo is what one would expect.

BUG=None
TEST=see above
R=agable@chromium.org

Review URL: https://codereview.chromium.org/777513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293283 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFail noisily when git auto-svn can't authenticate.
tandrii@chromium.org [Fri, 5 Dec 2014 22:56:20 +0000 (22:56 +0000)]
Fail noisily when git auto-svn can't authenticate.

R=agable@chromium.org
BUG=N/A

Review URL: https://codereview.chromium.org/707233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293277 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUpdate cpplint.py to r141.
avakulenko@google.com [Fri, 5 Dec 2014 22:19:55 +0000 (22:19 +0000)]
Update cpplint.py to r141.

This just a copy of cpplint.py from upstream [1].

[1] https://code.google.com/p/google-styleguide/source/detail?spec=svn141&r=141

The change in gclient_scm.py is to address a presubmit check error
which was introduced by https://codereview.chromium.org/227163002
"print_func" parameter was being passed to a function instead of
the object constructor.

BUG=None
NOTRY=True

Change-Id: I4dca890d5f02957ddae33c4bd4269fd37758be3d

Review URL: https://codereview.chromium.org/777533005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293276 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix git-cl-dcommit hook tests.
iannucci@chromium.org [Fri, 5 Dec 2014 22:15:56 +0000 (22:15 +0000)]
Fix git-cl-dcommit hook tests.

TBR=agable@chromium.org, jrobbins@chromium.org, maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/726673008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293275 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd canned presubmit check for GN formatting
scottmg@chromium.org [Fri, 5 Dec 2014 17:24:26 +0000 (17:24 +0000)]
Add canned presubmit check for GN formatting

Requires https://codereview.chromium.org/779883002/ to be landed/rolled before it's useful.

R=dpranke@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/779513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293269 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUpdate upload.py in depot_tools to infra.git@3d174a0959ba68a4cd83a5abce9f497e30bfce68
iannucci@chromium.org [Fri, 5 Dec 2014 02:05:56 +0000 (02:05 +0000)]
Update upload.py in depot_tools to infra.git@3d174a0959ba68a4cd83a5abce9f497e30bfce68

Includes fix for bug 388937.

R=agable@chromium.org, jrobbins@chromium.org, maruel@chromium.org
BUG=388937

Review URL: https://codereview.chromium.org/785433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293259 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix upload_to_google_storage.py.
ojan@chromium.org [Fri, 5 Dec 2014 00:03:01 +0000 (00:03 +0000)]
Fix upload_to_google_storage.py.

r293250 broke it. I didn't realize that check_bucket_permissions
was shared code. It now only returns a single value.

TBR=vadimsh@chromium.org

Review URL: https://codereview.chromium.org/782643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293256 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFixed download_from_google_storage for real.
ojan@chromium.org [Thu, 4 Dec 2014 23:03:04 +0000 (23:03 +0000)]
Fixed download_from_google_storage for real.

check_bucket_permissions should no longer return a tuple.

TBR=vadimsh@chromium.org

Review URL: https://codereview.chromium.org/759013007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293255 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix download_from_google_storage.py.
ojan@chromium.org [Thu, 4 Dec 2014 22:44:52 +0000 (22:44 +0000)]
Fix download_from_google_storage.py.

check_bucket_permissions() takes exactly 2 arguments (3 given)

TBR=vadimsh@chromium.org

Review URL: https://codereview.chromium.org/780113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293254 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoMake --output and --sha1_filename work well together.
ojan@chromium.org [Thu, 4 Dec 2014 22:18:36 +0000 (22:18 +0000)]
Make --output and --sha1_filename work well together.

--sha1_filename unnecessarily forces the output to have
the same filename and be in the same directory. The code
in main already correctly sets the file name to the
sha1_filename minus the .sha1, so the only change is
to actually use the --output path the same way the
rest of the code does.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/752803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293251 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoDon't check bucket permissions if --no-auth.
ojan@chromium.org [Thu, 4 Dec 2014 22:11:08 +0000 (22:11 +0000)]
Don't check bucket permissions if --no-auth.

Checking bucket permissions takes ~400ms. We don't
need to do this if --no-auth because we know we
won't get a 403 and the 404 check will be handled
later when we try to actually download the file.

Also, remove the check for a null bucket. This
can't happen since we will throw a parser error
in the main function before we get to this code.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/772203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293250 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoDisable Express path for Windows toolchain, and point to instructions
scottmg@chromium.org [Tue, 2 Dec 2014 21:20:46 +0000 (21:20 +0000)]
Disable Express path for Windows toolchain, and point to instructions

This could be simplified a bunch more, but this path was already
non-functional and tries to download Express which is a waste of
time and confusing for people.

R=dpranke@chromium.org
BUG=433551

Review URL: https://codereview.chromium.org/775733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293199 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoAdd scottmg to depot_tools/win_toolchain OWNERS
scottmg@chromium.org [Tue, 2 Dec 2014 19:31:14 +0000 (19:31 +0000)]
Add scottmg to depot_tools/win_toolchain OWNERS

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/771233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293192 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoRewrite Google Code http URLs with https on git svn dcommit.
kjellander@chromium.org [Tue, 2 Dec 2014 07:34:49 +0000 (07:34 +0000)]
Rewrite Google Code http URLs with https on git svn dcommit.

This fix is created to avoid having to rebuild all the WebRTC
Git mirrors since they're configured to sync with the http URL
instead of https (resulting in git-svn-id Git footers with the
http URL in the commit messages). Without rewriting this, it is
not possible to commit to SVN since Google code disallows committing
to a http URL.

BUG=412012
TEST=Created a CL using a Git repo like this (both before and after landing https://webrtc-codereview.appspot.com/32569004):
git clone https://chromium.googlesource.com/external/webrtc.git
cd webrtc
git auto-svn
git checkout master
git checkout -b test
(edit whitespace change)
git commit -am "Whitespace edit
git cl upload --bypass-hooks"
git cl dcommit

R=agable@chromium.org, machenbach@chromium.org, mmoss@chromium.org

Review URL: https://codereview.chromium.org/760903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293171 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoRevert of git_auto_svn.py: Rewrite http SVN URLs to https (patchset #3 id:40001 of...
kjellander@chromium.org [Sat, 29 Nov 2014 17:03:55 +0000 (17:03 +0000)]
Revert of git_auto_svn.py: Rewrite http SVN URLs to https (patchset #3 id:40001 of https://codereview.chromium.org/745473003/)

Reason for revert:
This actually makes the Git mirrors unusable for git svn, since there's a mismatch between the svn remote URL and the URLs of the git-svn-id footers in each Git commit (which confuses scripts like git_cl.py and makes uploading and committing CLs impossible).

Original issue's description:
> git_auto_svn.py: Rewrite http SVN URLs to https
>
> BUG=435091
> TESTED=Ran the following:
> git clone https://chromium.googlesource.com/external/webrtc
> cd webrtc
> git auto-svn
> cat .git/config
> Verified the URL was using http before this patch, and https after applying it.
>
> R=agable@chromium.org, mmoss@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293041

TBR=agable@chromium.org,mmoss@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=435091

Review URL: https://codereview.chromium.org/767913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293148 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoAdd fetch recipe for the Skia repository.
tfarina@chromium.org [Thu, 27 Nov 2014 13:26:49 +0000 (13:26 +0000)]
Add fetch recipe for the Skia repository.

Tested with the following command lines:

$ cd somewhere
$ mkdir some-test-dir
$ cd some-test-dir
$ fetch skia
$ cd skia
 # confirm it is what we expected.

BUG=None
TEST=see above
R=agable@chromium.org

Review URL: https://codereview.chromium.org/746363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293135 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoRun "svn revert" in update_depot_tools --force
agable@chromium.org [Tue, 25 Nov 2014 23:34:41 +0000 (23:34 +0000)]
Run "svn revert" in update_depot_tools --force

R=iannucci@chromium.org, szager@chromium.org, pdr@chromium.org
BUG=435729

Review URL: https://codereview.chromium.org/756233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293112 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoHave fetch pretty-print the .gclient solution.
agable@chromium.org [Tue, 25 Nov 2014 22:15:26 +0000 (22:15 +0000)]
Have fetch pretty-print the .gclient solution.

R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/753383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293110 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoWebRTC: Add fetch recipes to depot_tools.
kjellander@chromium.org [Mon, 24 Nov 2014 21:58:56 +0000 (21:58 +0000)]
WebRTC: Add fetch recipes to depot_tools.

For Mac, we're depending on having both ios+mac for target_os.

R=agable@chromium.org

Review URL: https://codereview.chromium.org/753123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293085 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoUpdate ninja to v1.5.3 on Mac, Linux32, Linux64, Windows.
thakis@chromium.org [Mon, 24 Nov 2014 21:19:14 +0000 (21:19 +0000)]
Update ninja to v1.5.3 on Mac, Linux32, Linux64, Windows.

See the bug for how these were built.

The linux binaries were built by thestig@chromium.org.
The windows binary was built by scottmg@chromium.org.
The mac binary was built by thakis@chromium.org

BUG=436109
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/755753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293084 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoRevert "Revert "pylint: upgrade to 1.3.1""
vapier@chromium.org [Thu, 20 Nov 2014 22:41:07 +0000 (22:41 +0000)]
Revert "Revert "pylint: upgrade to 1.3.1""

The reason cited for reverting was invalid, so reland the update.

BUG=chromium:431514

Review URL: https://codereview.chromium.org/739393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293049 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoRevert "pylint: upgrade to 1.3.1"
smut@google.com [Thu, 20 Nov 2014 20:02:49 +0000 (20:02 +0000)]
Revert "pylint: upgrade to 1.3.1"

This reverts commit e642ee868c9191c9ba90b0afa0fa2bceb31312bd.

Conflicts:
pylintrc

Reason:
All repos are borked.

TBR=vapier

Review URL: https://codereview.chromium.org/741023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293042 0039d316-1c4b-4281-b951-d872f2087c98

3 months agogit_auto_svn.py: Rewrite http SVN URLs to https
kjellander@chromium.org [Thu, 20 Nov 2014 19:45:46 +0000 (19:45 +0000)]
git_auto_svn.py: Rewrite http SVN URLs to https

BUG=435091
TESTED=Ran the following:
git clone https://chromium.googlesource.com/external/webrtc
cd webrtc
git auto-svn
cat .git/config
Verified the URL was using http before this patch, and https after applying it.

R=agable@chromium.org, mmoss@chromium.org

Review URL: https://codereview.chromium.org/745473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293041 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoIgnore any import error for upload.py
jochen@chromium.org [Wed, 19 Nov 2014 20:45:10 +0000 (20:45 +0000)]
Ignore any import error for upload.py

BUG=none
TBR=jrobbins@chromium.org

Review URL: https://codereview.chromium.org/733923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293010 0039d316-1c4b-4281-b951-d872f2087c98

3 months agodisable new pylint warnings
vapier@chromium.org [Wed, 19 Nov 2014 03:06:38 +0000 (03:06 +0000)]
disable new pylint warnings

People are just ignoring these and bypassing the presubmit entirely, so
disable all the warnings until someone feels like shaving these yaks one
by one.

BUG=chromium:431514
TEST=ran presubmit on build/ and so no more warnings

Review URL: https://codereview.chromium.org/721833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292997 0039d316-1c4b-4281-b951-d872f2087c98

3 months agopylint: upgrade to 1.3.1
vapier@chromium.org [Tue, 18 Nov 2014 18:58:49 +0000 (18:58 +0000)]
pylint: upgrade to 1.3.1

The current pylint is very old at this point.  Pull in the latest version
as it supports a lot more features.  Also need to fix the pylint wrapper
to actually update sys.path to use the local modules.

We include the six module since not all bots have it, and it's small.

This will trigger new warnings in files, but they look like legitimate
issues that should be fixed at some point.

BUG=chromium:431514
TEST=ran on some code bases and checked output

Review URL: https://codereview.chromium.org/741503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292988 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoRevert "pylint: upgrade to 1.3.1"
kbr@chromium.org [Sat, 15 Nov 2014 02:18:25 +0000 (02:18 +0000)]
Revert "pylint: upgrade to 1.3.1"

This reverts commit 451939d582195f20d721bee5ee4d4f4b929c728d.

Throws an exception with a missing import, breaking Telemetry's
presubmit checks and presumably presubmit checks for all Python files
in Chromium. See comment on https://codereview.chromium.org/707353002/ .

BUG=chromium:431514

Review URL: https://codereview.chromium.org/719313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292955 0039d316-1c4b-4281-b951-d872f2087c98

3 months agopylint: upgrade to 1.3.1
vapier@chromium.org [Sat, 15 Nov 2014 01:41:04 +0000 (01:41 +0000)]
pylint: upgrade to 1.3.1

The current pylint is very old at this point.  Pull in the latest version
as it supports a lot more features.  Also need to fix the pylint wrapper
to actually update sys.path to use the local modules.

This will trigger new warnings in files, but they look like legitimate
issues that should be fixed at some point.

BUG=chromium:431514
TEST=ran on some code bases and checked output

Review URL: https://codereview.chromium.org/707353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292954 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoUpdate toolchain script to package SDK 8.1 instead of 8.0
scottmg@chromium.org [Fri, 14 Nov 2014 22:51:23 +0000 (22:51 +0000)]
Update toolchain script to package SDK 8.1 instead of 8.0

See also https://codereview.chromium.org/720033003/

BUG=311488,432748

Review URL: https://codereview.chromium.org/719343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292950 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoImproved git cl patch generated commit message to include patchset information
carlosk@chromium.org [Fri, 14 Nov 2014 18:12:50 +0000 (18:12 +0000)]
Improved git cl patch generated commit message to include patchset information
and a link to it.

BUG=

Review URL: https://codereview.chromium.org/731473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292940 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoRemove old Gerrit instances.
jorgelo@chromium.org [Fri, 14 Nov 2014 02:03:45 +0000 (02:03 +0000)]
Remove old Gerrit instances.

BUG=None
TEST=my_activity.py still works.

Review URL: https://codereview.chromium.org/714373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292935 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoSearch for buildtools in the gclient root, if not in the main repo.
ncbray@chromium.org [Wed, 12 Nov 2014 22:38:51 +0000 (22:38 +0000)]
Search for buildtools in the gclient root, if not in the main repo.

BUG=https://code.google.com/p/chromium/issues/detail?id=430602
R=bradnelson@google.com, dpranke@chromium.org

Review URL: https://codereview.chromium.org/718213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292912 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoSwitch v8 to git.
machenbach@chromium.org [Wed, 12 Nov 2014 17:52:43 +0000 (17:52 +0000)]
Switch v8 to git.

BUG=415464
R=agable@chromium.org, tandrii@chromium.org

Review URL: https://codereview.chromium.org/704773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292909 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoFix git cl comments when there's no issue associated with the current branch.
maruel@chromium.org [Tue, 11 Nov 2014 18:32:41 +0000 (18:32 +0000)]
Fix git cl comments when there's no issue associated with the current branch.

It currently crashes, which is sad.

R=pgervais@chromium.org
BUG=

Review URL: https://codereview.chromium.org/683283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292899 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoAdded transient 502 errors to 'git_retry' list.
dnj@chromium.org [Thu, 6 Nov 2014 19:36:42 +0000 (19:36 +0000)]
Added transient 502 errors to 'git_retry' list.

BUG=chromium:430343
TEST=None

Review URL: https://codereview.chromium.org/701843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292868 0039d316-1c4b-4281-b951-d872f2087c98