chromium/tools/depot_tools.git
42 hours agoSwitch default windows git version to 1.9.5. master
iannucci@chromium.org [Sat, 20 Dec 2014 02:00:52 +0000 (02:00 +0000)]
Switch default windows git version to 1.9.5.

R=pgervais@chromium.org, agable@chromium.org, friedman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/800003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293482 0039d316-1c4b-4281-b951-d872f2087c98

43 hours agoSwitch the remaining third_party gsutil references to gsutil.py
hinoka@chromium.org [Sat, 20 Dec 2014 01:47:31 +0000 (01:47 +0000)]
Switch the remaining third_party gsutil references to gsutil.py

BUG=
R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/809203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293481 0039d316-1c4b-4281-b951-d872f2087c98

43 hours agoGreatly clean up depot_tools handling of git binaries, add bleeding edge support...
iannucci@chromium.org [Sat, 20 Dec 2014 01:42:44 +0000 (01:42 +0000)]
Greatly clean up depot_tools handling of git binaries, add bleeding edge support for 1.9.5

R=agable@chromium.org, friedman@google.com, maruel@chromium.org, pgervais@chromium.org, friedman@chromium.org, mmoss@chromium.org, szager@chromium.org, vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/816173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293480 0039d316-1c4b-4281-b951-d872f2087c98

2 days agopresubmit_unittest: Fix pylint errors.
raphael.kubo.da.costa@intel.com [Fri, 19 Dec 2014 17:04:15 +0000 (17:04 +0000)]
presubmit_unittest: Fix pylint errors.

The recent pylint 1.3.1 and 1.4.0 upgrades have caused some new errors
to be reported for presubmit_unittest:

* presubmit_support.InputApi.AffectedFiles() expectes a parameter called
  |include_deletes|, not |include_deleted|.

* The mock AffectedFiles() implementation in
  CannedChecksUnittest.testCannedCheckChangeHasNoTabs() had its
  signature updated to match the one in presubmit_support.InputApi,
  otherwise pylint would (erroneously) consider that this mock
  implementation was used in all other AffectedFiles() invocations in
  CannedChecksUnittest and complain that some parameters were missing.
  It makes more sense to do this than disable the check and miss real
  problems in the future.

R=maruel@chromium.org, iannucci@chromium.org, pgervais@chromium.org
BUG=443232

Review URL: https://codereview.chromium.org/802403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293468 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoAllow to skip revision check in roll-dep.
machenbach@chromium.org [Thu, 18 Dec 2014 15:42:43 +0000 (15:42 +0000)]
Allow to skip revision check in roll-dep.

Without this change, roll-dep requires dependencies to be
checked out and up to date in order to roll a newer revision.

This change allows to use roll-dep with less checking and
makes the script user responsible to verify the correctness
of the deps path and git hash.

This eases writing a deps roller that updates multiple deps
including a variety of os deps, which might not be checked
out on the host of the deps roller.

BUG=438705, 437462
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/801643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293444 0039d316-1c4b-4281-b951-d872f2087c98

3 days agogsutil: Use urllib2 instead of urllib.
primiano@chromium.org [Thu, 18 Dec 2014 11:12:34 +0000 (11:12 +0000)]
gsutil: Use urllib2 instead of urllib.

This is similar to r247914 and r149742: urllib does not work with SSL
connections behind proxies, we need to use urllib2 instead. Doing this
should allow people behind proxies to download gsutils 4.7 after
r293413.

(Setting NOTRY here to be able to land the issue, otherwise the CQ fails when running some presubmit checks, see crbug.com/443232)

R=maruel@chromium.org, hinoka@chromium.org, pgervais@chromium.org, primiano@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/809053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293439 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoArgs fix for gsutil.py
hinoka@chromium.org [Thu, 18 Dec 2014 01:06:20 +0000 (01:06 +0000)]
Args fix for gsutil.py

"--" is the hard keyword to separate gsutil commands from gsutil.py commands.

BUG=
R=dnj@chromium.org

Review URL: https://codereview.chromium.org/812223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293433 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoFix setting the executable bit in download_from_google_storage.
dpranke@chromium.org [Wed, 17 Dec 2014 23:47:23 +0000 (23:47 +0000)]
Fix setting the executable bit in download_from_google_storage.

The new GSUtil (or gs protocol, who knows) strips off the redundent x-goog-meta
string from the metadata key.  This CL compensates for that.

Also since we're on 4.7, we can use the faster gsutil stat instead of gsutil ls -L.

BUG=
TEST=ran download_from_google_storage against compiler_proxy.sha, works
NOTREECHECKS=true
NOTRY=true
R=dnj@chromium.org, pgervais@chromium.org

Review URL: https://codereview.chromium.org/809123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293432 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoUse gsutil.py for download_from_google_storage instead of the builtin one
hinoka@chromium.org [Wed, 17 Dec 2014 02:17:14 +0000 (02:17 +0000)]
Use gsutil.py for download_from_google_storage instead of the builtin one

This pins gsutil to a vanilla 4.7 instead of the weird custom 3.4 we have in depot_tools

BUG=
R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/797663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293413 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoUpdate documentation to accurately reflect the new URL of depot_tools.
erikchen@chromium.org [Tue, 16 Dec 2014 00:48:01 +0000 (00:48 +0000)]
Update documentation to accurately reflect the new URL of depot_tools.

BUG=

Review URL: https://codereview.chromium.org/789733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293401 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoUpdates the depot_tools repository URL in the docs.
charliea@google.com [Mon, 15 Dec 2014 20:01:52 +0000 (20:01 +0000)]
Updates the depot_tools repository URL in the docs.

Review URL: https://codereview.chromium.org/809473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293398 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoUse grep -e --force instead of grep "--force" since apparently the latter doesn't...
pkasting@chromium.org [Fri, 12 Dec 2014 19:26:49 +0000 (19:26 +0000)]
Use grep -e --force instead of grep "--force" since apparently the latter doesn't work properly in all cases.

BUG=441072
TEST=No errors from gclient :/

Review URL: https://codereview.chromium.org/802513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293380 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoAdd lint_filters parameter to CheckChangeLintsClean function.
tfarina@chromium.org [Fri, 12 Dec 2014 00:03:49 +0000 (00:03 +0000)]
Add lint_filters parameter to CheckChangeLintsClean function.

The idea here is that when one of the filters are cleaned up in Chromium,
they should not be filtered out, otherwise we won't catch them in
the presubmit step.

See for example -> https://codereview.chromium.org/788493002/

BUG=None
R=agable@chromium.org, dpranke@chromium.org

Review URL: https://codereview.chromium.org/779033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293357 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoAdd pending prefix to the target_ref if it is specified
rmistry@google.com [Thu, 11 Dec 2014 23:41:21 +0000 (23:41 +0000)]
Add pending prefix to the target_ref if it is specified

BUG=435702

Review URL: https://codereview.chromium.org/797793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293356 0039d316-1c4b-4281-b951-d872f2087c98

9 days agopylint: upgrade to 1.4.0
vapier@chromium.org [Thu, 11 Dec 2014 21:40:52 +0000 (21:40 +0000)]
pylint: upgrade to 1.4.0

This is largely a bugfix release, so should be much easier to transition.

BUG=chromium:431514
TEST=ran on some code bases and checked output

Review URL: https://codereview.chromium.org/753543006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293355 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoRevert of Make gclient ready for the Blink (DEPS to main project) transition (patchse...
primiano@chromium.org [Thu, 11 Dec 2014 17:25:28 +0000 (17:25 +0000)]
Revert of Make gclient ready for the Blink (DEPS to main project) transition (patchset #6 id:180001 of https://codereview.chromium.org/743083002/)

Reason for revert:
The test intoruced is flake (see crrev.com/753543006/).
Need to look into that with more patience as it reproduces only on precise.

Original issue's description:
> Make gclient ready for the Blink (DEPS to main project) transition
>
> This CL makes gclient understand correctly whether a git project is
> being moved from DEPS to an upper project and vice-versa.
> The driving use case for this is the upcoming Blink merge, where
> third_party/Webkit will be removed from DEPS (and .gitignore) and will
> become part of the main project.
>
> At present state, gclient leaves the .git folder around when a project
> is removed from DEPS, and that causes many problems.
>
> Furthermore this CL solves the performance problem of bisecting across
> the merge point. The subproject's (Blink) .git/ folder is moved to a
> backup location (in the main checkout root) and is restored when moving
> backwards, avoiding a re-fetch when bisecting across the merge point.
>
> BUG=431469
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293329

TBR=iannucci@chromium.org,maruel@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=431469

Review URL: https://codereview.chromium.org/796053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293352 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoImprove default email address for my_reviews.py
sbc@chromium.org [Thu, 11 Dec 2014 17:15:26 +0000 (17:15 +0000)]
Improve default email address for my_reviews.py

Also, fix assertion that fires if all the reviews are
on the same day (first_day == last_day)

Also, don't print backtrace if no arguments at all are
specified.

Review URL: https://codereview.chromium.org/797523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293351 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoFix test failures on Ubuntu/Trusty.
sbc@chromium.org [Thu, 11 Dec 2014 03:06:48 +0000 (03:06 +0000)]
Fix test failures on Ubuntu/Trusty.

I ran into several failures running the presubmit checks
on my Ubuntu/Trusty laptop and it looks like a some of
the tests were broken by recent versions of svn and git.

Review URL: https://codereview.chromium.org/795723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293341 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoAvoid =~ since msysgit bash doesn't support it.
pkasting@chromium.org [Wed, 10 Dec 2014 23:29:25 +0000 (23:29 +0000)]
Avoid =~ since msysgit bash doesn't support it.

This uses grep instead.  Note that just grepping for "--force" matches other
things, e.g. "foo--force--foo", but that's a problem with the original code as
well, I think.

BUG=435729
TEST=Run gclient under msysgit bash.  No error should occur.

Review URL: https://codereview.chromium.org/789353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293340 0039d316-1c4b-4281-b951-d872f2087c98

10 days agodepot_tools: Send the remote tracked ref to Rietveld via upload.py.
rmistry@google.com [Wed, 10 Dec 2014 20:58:24 +0000 (20:58 +0000)]
depot_tools: Send the remote tracked ref to Rietveld via upload.py.

This change goes hand in hand with the corresponding Rietveld change here:
https://codereview.chromium.org/773083004/
The motivation for both CLs came from the discussion in the internal CL: https://chromereviews.googleplex.com/115567013/

AFAIK either change can be submitted first without breaking anything in the other framework.

Observe the "Tracked Ref" field in the below CLs-

Tracking a remote ref:
* https://skia-codereview-staging.appspot.com/8861001 (Tracking skiabot-test's refs/heads/master)
* https://skia-codereview-staging.appspot.com/851002 (Tracking skiabot-test's refs/diff/test1)
* https://skia-codereview-staging.appspot.com/2891001 (Tracking Chromium's refs/heads/master)
* https://skia-codereview-staging.appspot.com/1931003 (Tracking Chromium's refs/branch-heads/1916)

Tracking a local branch which in turn tracks a remote ref:
* https://skia-codereview-staging.appspot.com/3891002 (Transitively tracking skiabot-test's refs/heads/master)
* https://skia-codereview-staging.appspot.com/4921001 (Transitively tracking Chromium's refs/branch-heads/1916)

CL when no target_ref is specified in depot_tools/third_party/upload.py:
* https://skia-codereview-staging.appspot.com/3871003 (CL with missing target_ref should default to /refs/heads/master)

Try the above links with and without the 'Deprecated UI' checked in https://skia-codereview-staging.appspot.com/settings

BUG=435702

Review URL: https://codereview.chromium.org/781523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293334 0039d316-1c4b-4281-b951-d872f2087c98

11 days agoMake gclient ready for the Blink (DEPS to main project) transition
primiano@chromium.org [Wed, 10 Dec 2014 15:53:41 +0000 (15:53 +0000)]
Make gclient ready for the Blink (DEPS to main project) transition

This CL makes gclient understand correctly whether a git project is
being moved from DEPS to an upper project and vice-versa.
The driving use case for this is the upcoming Blink merge, where
third_party/Webkit will be removed from DEPS (and .gitignore) and will
become part of the main project.

At present state, gclient leaves the .git folder around when a project
is removed from DEPS, and that causes many problems.

Furthermore this CL solves the performance problem of bisecting across
the merge point. The subproject's (Blink) .git/ folder is moved to a
backup location (in the main checkout root) and is restored when moving
backwards, avoiding a re-fetch when bisecting across the merge point.

BUG=431469

Review URL: https://codereview.chromium.org/743083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293329 0039d316-1c4b-4281-b951-d872f2087c98

11 days agoGSUtil.py wrapper script
hinoka@chromium.org [Wed, 10 Dec 2014 02:04:39 +0000 (02:04 +0000)]
GSUtil.py wrapper script

This is for transitioning us out of the horribly outdated gsutil 3.4 thats
currently residing in depot_tools.  This script:
1. Downloads GSUtil, pinned to a version (4.6 by default).
2. Executes GSUtil with the given parameters
3. (TODO) Runs the fallback GSUtil if #2 fails.

The transition plan is:
1. Set the fallback as default, making this script a no-op
2. Modify recipes (main consumer of gsutil) to pass in --force_version 4.6
3. Switch 4.6 as the default for gsutil.py
4. Make fallback failure a loud red failure
5. Remove depot_tools/third_party/gsutil

BUG=434422

Review URL: https://codereview.chromium.org/742173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293320 0039d316-1c4b-4281-b951-d872f2087c98

11 days agoLet `git cl format` format java files, too.
thakis@chromium.org [Tue, 9 Dec 2014 21:21:53 +0000 (21:21 +0000)]
Let `git cl format` format java files, too.

This will only have an effect if one's buildtools checkout is new enough, since
only then:

a) clang-format will be new enough to do a decent job for java files
b) clang-format-diff.py will be new enough to look at java files

So for older buildtools checkouts, `git cl format` will continue to ignore java
files.  For newer buildtools checkouts (like the one pulled by `gclient sync`
with a recent chromium checkout), it'll work and do a fairly decent job.

BUG=429372

Review URL: https://codereview.chromium.org/788933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293312 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoAdd fetch recipe for Skia's Buildbot repository.
tfarina@chromium.org [Sat, 6 Dec 2014 21:43:25 +0000 (21:43 +0000)]
Add fetch recipe for Skia's Buildbot repository.

Tested with the following command lines:

$ cd
$ mkdir skia_test
$ cd skia_test
$ fetch skia_buildbot
$ cd skia_buildbot
 # confirm the repo is what one would expect.

BUG=None
TEST=see above
R=agable@chromium.org

Review URL: https://codereview.chromium.org/777513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293283 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoFail noisily when git auto-svn can't authenticate.
tandrii@chromium.org [Fri, 5 Dec 2014 22:56:20 +0000 (22:56 +0000)]
Fail noisily when git auto-svn can't authenticate.

R=agable@chromium.org
BUG=N/A

Review URL: https://codereview.chromium.org/707233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293277 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoUpdate cpplint.py to r141.
avakulenko@google.com [Fri, 5 Dec 2014 22:19:55 +0000 (22:19 +0000)]
Update cpplint.py to r141.

This just a copy of cpplint.py from upstream [1].

[1] https://code.google.com/p/google-styleguide/source/detail?spec=svn141&r=141

The change in gclient_scm.py is to address a presubmit check error
which was introduced by https://codereview.chromium.org/227163002
"print_func" parameter was being passed to a function instead of
the object constructor.

BUG=None
NOTRY=True

Change-Id: I4dca890d5f02957ddae33c4bd4269fd37758be3d

Review URL: https://codereview.chromium.org/777533005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293276 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoFix git-cl-dcommit hook tests.
iannucci@chromium.org [Fri, 5 Dec 2014 22:15:56 +0000 (22:15 +0000)]
Fix git-cl-dcommit hook tests.

TBR=agable@chromium.org, jrobbins@chromium.org, maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/726673008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293275 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoAdd canned presubmit check for GN formatting
scottmg@chromium.org [Fri, 5 Dec 2014 17:24:26 +0000 (17:24 +0000)]
Add canned presubmit check for GN formatting

Requires https://codereview.chromium.org/779883002/ to be landed/rolled before it's useful.

R=dpranke@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/779513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293269 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoUpdate upload.py in depot_tools to infra.git@3d174a0959ba68a4cd83a5abce9f497e30bfce68
iannucci@chromium.org [Fri, 5 Dec 2014 02:05:56 +0000 (02:05 +0000)]
Update upload.py in depot_tools to infra.git@3d174a0959ba68a4cd83a5abce9f497e30bfce68

Includes fix for bug 388937.

R=agable@chromium.org, jrobbins@chromium.org, maruel@chromium.org
BUG=388937

Review URL: https://codereview.chromium.org/785433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293259 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoFix upload_to_google_storage.py.
ojan@chromium.org [Fri, 5 Dec 2014 00:03:01 +0000 (00:03 +0000)]
Fix upload_to_google_storage.py.

r293250 broke it. I didn't realize that check_bucket_permissions
was shared code. It now only returns a single value.

TBR=vadimsh@chromium.org

Review URL: https://codereview.chromium.org/782643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293256 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoFixed download_from_google_storage for real.
ojan@chromium.org [Thu, 4 Dec 2014 23:03:04 +0000 (23:03 +0000)]
Fixed download_from_google_storage for real.

check_bucket_permissions should no longer return a tuple.

TBR=vadimsh@chromium.org

Review URL: https://codereview.chromium.org/759013007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293255 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoFix download_from_google_storage.py.
ojan@chromium.org [Thu, 4 Dec 2014 22:44:52 +0000 (22:44 +0000)]
Fix download_from_google_storage.py.

check_bucket_permissions() takes exactly 2 arguments (3 given)

TBR=vadimsh@chromium.org

Review URL: https://codereview.chromium.org/780113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293254 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoMake --output and --sha1_filename work well together.
ojan@chromium.org [Thu, 4 Dec 2014 22:18:36 +0000 (22:18 +0000)]
Make --output and --sha1_filename work well together.

--sha1_filename unnecessarily forces the output to have
the same filename and be in the same directory. The code
in main already correctly sets the file name to the
sha1_filename minus the .sha1, so the only change is
to actually use the --output path the same way the
rest of the code does.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/752803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293251 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoDon't check bucket permissions if --no-auth.
ojan@chromium.org [Thu, 4 Dec 2014 22:11:08 +0000 (22:11 +0000)]
Don't check bucket permissions if --no-auth.

Checking bucket permissions takes ~400ms. We don't
need to do this if --no-auth because we know we
won't get a 403 and the 404 check will be handled
later when we try to actually download the file.

Also, remove the check for a null bucket. This
can't happen since we will throw a parser error
in the main function before we get to this code.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/772203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293250 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoDisable Express path for Windows toolchain, and point to instructions
scottmg@chromium.org [Tue, 2 Dec 2014 21:20:46 +0000 (21:20 +0000)]
Disable Express path for Windows toolchain, and point to instructions

This could be simplified a bunch more, but this path was already
non-functional and tries to download Express which is a waste of
time and confusing for people.

R=dpranke@chromium.org
BUG=433551

Review URL: https://codereview.chromium.org/775733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293199 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoAdd scottmg to depot_tools/win_toolchain OWNERS
scottmg@chromium.org [Tue, 2 Dec 2014 19:31:14 +0000 (19:31 +0000)]
Add scottmg to depot_tools/win_toolchain OWNERS

R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/771233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293192 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoRewrite Google Code http URLs with https on git svn dcommit.
kjellander@chromium.org [Tue, 2 Dec 2014 07:34:49 +0000 (07:34 +0000)]
Rewrite Google Code http URLs with https on git svn dcommit.

This fix is created to avoid having to rebuild all the WebRTC
Git mirrors since they're configured to sync with the http URL
instead of https (resulting in git-svn-id Git footers with the
http URL in the commit messages). Without rewriting this, it is
not possible to commit to SVN since Google code disallows committing
to a http URL.

BUG=412012
TEST=Created a CL using a Git repo like this (both before and after landing https://webrtc-codereview.appspot.com/32569004):
git clone https://chromium.googlesource.com/external/webrtc.git
cd webrtc
git auto-svn
git checkout master
git checkout -b test
(edit whitespace change)
git commit -am "Whitespace edit
git cl upload --bypass-hooks"
git cl dcommit

R=agable@chromium.org, machenbach@chromium.org, mmoss@chromium.org

Review URL: https://codereview.chromium.org/760903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293171 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRevert of git_auto_svn.py: Rewrite http SVN URLs to https (patchset #3 id:40001 of...
kjellander@chromium.org [Sat, 29 Nov 2014 17:03:55 +0000 (17:03 +0000)]
Revert of git_auto_svn.py: Rewrite http SVN URLs to https (patchset #3 id:40001 of https://codereview.chromium.org/745473003/)

Reason for revert:
This actually makes the Git mirrors unusable for git svn, since there's a mismatch between the svn remote URL and the URLs of the git-svn-id footers in each Git commit (which confuses scripts like git_cl.py and makes uploading and committing CLs impossible).

Original issue's description:
> git_auto_svn.py: Rewrite http SVN URLs to https
>
> BUG=435091
> TESTED=Ran the following:
> git clone https://chromium.googlesource.com/external/webrtc
> cd webrtc
> git auto-svn
> cat .git/config
> Verified the URL was using http before this patch, and https after applying it.
>
> R=agable@chromium.org, mmoss@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293041

TBR=agable@chromium.org,mmoss@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=435091

Review URL: https://codereview.chromium.org/767913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293148 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd fetch recipe for the Skia repository.
tfarina@chromium.org [Thu, 27 Nov 2014 13:26:49 +0000 (13:26 +0000)]
Add fetch recipe for the Skia repository.

Tested with the following command lines:

$ cd somewhere
$ mkdir some-test-dir
$ cd some-test-dir
$ fetch skia
$ cd skia
 # confirm it is what we expected.

BUG=None
TEST=see above
R=agable@chromium.org

Review URL: https://codereview.chromium.org/746363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293135 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRun "svn revert" in update_depot_tools --force
agable@chromium.org [Tue, 25 Nov 2014 23:34:41 +0000 (23:34 +0000)]
Run "svn revert" in update_depot_tools --force

R=iannucci@chromium.org, szager@chromium.org, pdr@chromium.org
BUG=435729

Review URL: https://codereview.chromium.org/756233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293112 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoHave fetch pretty-print the .gclient solution.
agable@chromium.org [Tue, 25 Nov 2014 22:15:26 +0000 (22:15 +0000)]
Have fetch pretty-print the .gclient solution.

R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/753383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293110 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoWebRTC: Add fetch recipes to depot_tools.
kjellander@chromium.org [Mon, 24 Nov 2014 21:58:56 +0000 (21:58 +0000)]
WebRTC: Add fetch recipes to depot_tools.

For Mac, we're depending on having both ios+mac for target_os.

R=agable@chromium.org

Review URL: https://codereview.chromium.org/753123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293085 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoUpdate ninja to v1.5.3 on Mac, Linux32, Linux64, Windows.
thakis@chromium.org [Mon, 24 Nov 2014 21:19:14 +0000 (21:19 +0000)]
Update ninja to v1.5.3 on Mac, Linux32, Linux64, Windows.

See the bug for how these were built.

The linux binaries were built by thestig@chromium.org.
The windows binary was built by scottmg@chromium.org.
The mac binary was built by thakis@chromium.org

BUG=436109
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/755753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293084 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRevert "Revert "pylint: upgrade to 1.3.1""
vapier@chromium.org [Thu, 20 Nov 2014 22:41:07 +0000 (22:41 +0000)]
Revert "Revert "pylint: upgrade to 1.3.1""

The reason cited for reverting was invalid, so reland the update.

BUG=chromium:431514

Review URL: https://codereview.chromium.org/739393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293049 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoRevert "pylint: upgrade to 1.3.1"
smut@google.com [Thu, 20 Nov 2014 20:02:49 +0000 (20:02 +0000)]
Revert "pylint: upgrade to 1.3.1"

This reverts commit e642ee868c9191c9ba90b0afa0fa2bceb31312bd.

Conflicts:
pylintrc

Reason:
All repos are borked.

TBR=vapier

Review URL: https://codereview.chromium.org/741023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293042 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agogit_auto_svn.py: Rewrite http SVN URLs to https
kjellander@chromium.org [Thu, 20 Nov 2014 19:45:46 +0000 (19:45 +0000)]
git_auto_svn.py: Rewrite http SVN URLs to https

BUG=435091
TESTED=Ran the following:
git clone https://chromium.googlesource.com/external/webrtc
cd webrtc
git auto-svn
cat .git/config
Verified the URL was using http before this patch, and https after applying it.

R=agable@chromium.org, mmoss@chromium.org

Review URL: https://codereview.chromium.org/745473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293041 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoIgnore any import error for upload.py
jochen@chromium.org [Wed, 19 Nov 2014 20:45:10 +0000 (20:45 +0000)]
Ignore any import error for upload.py

BUG=none
TBR=jrobbins@chromium.org

Review URL: https://codereview.chromium.org/733923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293010 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agodisable new pylint warnings
vapier@chromium.org [Wed, 19 Nov 2014 03:06:38 +0000 (03:06 +0000)]
disable new pylint warnings

People are just ignoring these and bypassing the presubmit entirely, so
disable all the warnings until someone feels like shaving these yaks one
by one.

BUG=chromium:431514
TEST=ran presubmit on build/ and so no more warnings

Review URL: https://codereview.chromium.org/721833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292997 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agopylint: upgrade to 1.3.1
vapier@chromium.org [Tue, 18 Nov 2014 18:58:49 +0000 (18:58 +0000)]
pylint: upgrade to 1.3.1

The current pylint is very old at this point.  Pull in the latest version
as it supports a lot more features.  Also need to fix the pylint wrapper
to actually update sys.path to use the local modules.

We include the six module since not all bots have it, and it's small.

This will trigger new warnings in files, but they look like legitimate
issues that should be fixed at some point.

BUG=chromium:431514
TEST=ran on some code bases and checked output

Review URL: https://codereview.chromium.org/741503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292988 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoRevert "pylint: upgrade to 1.3.1"
kbr@chromium.org [Sat, 15 Nov 2014 02:18:25 +0000 (02:18 +0000)]
Revert "pylint: upgrade to 1.3.1"

This reverts commit 451939d582195f20d721bee5ee4d4f4b929c728d.

Throws an exception with a missing import, breaking Telemetry's
presubmit checks and presumably presubmit checks for all Python files
in Chromium. See comment on https://codereview.chromium.org/707353002/ .

BUG=chromium:431514

Review URL: https://codereview.chromium.org/719313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292955 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agopylint: upgrade to 1.3.1
vapier@chromium.org [Sat, 15 Nov 2014 01:41:04 +0000 (01:41 +0000)]
pylint: upgrade to 1.3.1

The current pylint is very old at this point.  Pull in the latest version
as it supports a lot more features.  Also need to fix the pylint wrapper
to actually update sys.path to use the local modules.

This will trigger new warnings in files, but they look like legitimate
issues that should be fixed at some point.

BUG=chromium:431514
TEST=ran on some code bases and checked output

Review URL: https://codereview.chromium.org/707353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292954 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoUpdate toolchain script to package SDK 8.1 instead of 8.0
scottmg@chromium.org [Fri, 14 Nov 2014 22:51:23 +0000 (22:51 +0000)]
Update toolchain script to package SDK 8.1 instead of 8.0

See also https://codereview.chromium.org/720033003/

BUG=311488,432748

Review URL: https://codereview.chromium.org/719343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292950 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoImproved git cl patch generated commit message to include patchset information
carlosk@chromium.org [Fri, 14 Nov 2014 18:12:50 +0000 (18:12 +0000)]
Improved git cl patch generated commit message to include patchset information
and a link to it.

BUG=

Review URL: https://codereview.chromium.org/731473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292940 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoRemove old Gerrit instances.
jorgelo@chromium.org [Fri, 14 Nov 2014 02:03:45 +0000 (02:03 +0000)]
Remove old Gerrit instances.

BUG=None
TEST=my_activity.py still works.

Review URL: https://codereview.chromium.org/714373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292935 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoSearch for buildtools in the gclient root, if not in the main repo.
ncbray@chromium.org [Wed, 12 Nov 2014 22:38:51 +0000 (22:38 +0000)]
Search for buildtools in the gclient root, if not in the main repo.

BUG=https://code.google.com/p/chromium/issues/detail?id=430602
R=bradnelson@google.com, dpranke@chromium.org

Review URL: https://codereview.chromium.org/718213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292912 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoSwitch v8 to git.
machenbach@chromium.org [Wed, 12 Nov 2014 17:52:43 +0000 (17:52 +0000)]
Switch v8 to git.

BUG=415464
R=agable@chromium.org, tandrii@chromium.org

Review URL: https://codereview.chromium.org/704773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292909 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoFix git cl comments when there's no issue associated with the current branch.
maruel@chromium.org [Tue, 11 Nov 2014 18:32:41 +0000 (18:32 +0000)]
Fix git cl comments when there's no issue associated with the current branch.

It currently crashes, which is sad.

R=pgervais@chromium.org
BUG=

Review URL: https://codereview.chromium.org/683283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292899 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoAdded transient 502 errors to 'git_retry' list.
dnj@chromium.org [Thu, 6 Nov 2014 19:36:42 +0000 (19:36 +0000)]
Added transient 502 errors to 'git_retry' list.

BUG=chromium:430343
TEST=None

Review URL: https://codereview.chromium.org/701843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292868 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoDon't enforce allowed_hosts for custom_deps.
szager@chromium.org [Wed, 5 Nov 2014 18:43:08 +0000 (18:43 +0000)]
Don't enforce allowed_hosts for custom_deps.

BUG=430123
R=iannucci@chromium.org,agable@chromium.org

Review URL: https://codereview.chromium.org/701893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292853 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoExtend the git-cl-comments command functionality
apavlov@chromium.org [Wed, 5 Nov 2014 09:05:29 +0000 (09:05 +0000)]
Extend the git-cl-comments command functionality

The "comments" command is taught to:
- accept an arbitrary review issue id;
- post comments on the current or specified review issue.

This is required for the auto-rebaseline bot to notify a
rebaseline requestor of the fact that the rebaseline has happened
by means of posting a comment to the review issue that requested
the rebaseline, as suggested by iannucci@.

R=iannucci, szager, dpranke

Review URL: https://codereview.chromium.org/693873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292844 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoAdding myself as an owner.
pgervais@chromium.org [Tue, 4 Nov 2014 00:50:05 +0000 (00:50 +0000)]
Adding myself as an owner.

BUG=

Review URL: https://codereview.chromium.org/697283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292820 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoDelete before cp in download_from_google_storage
hinoka@chromium.org [Tue, 4 Nov 2014 00:40:53 +0000 (00:40 +0000)]
Delete before cp in download_from_google_storage

BUG=

Review URL: https://codereview.chromium.org/696023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292819 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoRevert of Added orphaned compiled Python file checks. (patchset #2 id:20001 of https...
thakis@chromium.org [Tue, 4 Nov 2014 00:13:54 +0000 (00:13 +0000)]
Revert of Added orphaned compiled Python file checks. (patchset #2 id:20001 of https://codereview.chromium.org/621533002/)

Reason for revert:
Makes `git cl upload` very slow in chrome checkouts.

Original issue's description:
> Added orphaned compiled Python file checks.
>
> There have been a handful of cases where orphaned compiled Python files (.pyc
> files without an accompanying .py file) have been loaded preferentially by
> the presubmit scripts, causing weird problems. This adds a check and a mode for
> such files, either warning the user or deleting them.
>
> BUG=None
> TEST=local
>   - Tested against local repository.
>
> R=iannucci@chromium.org, szager@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292703

TBR=iannucci@chromium.org,szager@chromium.org,dnj@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/701683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292818 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoBe a bit more space-efficient.
thakis@chromium.org [Sun, 2 Nov 2014 02:20:32 +0000 (02:20 +0000)]
Be a bit more space-efficient.

BUG=none

Review URL: https://codereview.chromium.org/695113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292792 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoFix handling of ast.Str object.
szager@chromium.org [Wed, 29 Oct 2014 22:19:26 +0000 (22:19 +0000)]
Fix handling of ast.Str object.

TBR=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/686183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292733 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoAdded orphaned compiled Python file checks.
dnj@chromium.org [Tue, 28 Oct 2014 19:29:54 +0000 (19:29 +0000)]
Added orphaned compiled Python file checks.

There have been a handful of cases where orphaned compiled Python files (.pyc
files without an accompanying .py file) have been loaded preferentially by
the presubmit scripts, causing weird problems. This adds a check and a mode for
such files, either warning the user or deleting them.

BUG=None
TEST=local
  - Tested against local repository.

R=iannucci@chromium.org, szager@chromium.org

Review URL: https://codereview.chromium.org/621533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292703 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoHandle unusual case in rebase-update where second rebase attempt works.
sbc@chromium.org [Mon, 27 Oct 2014 20:26:04 +0000 (20:26 +0000)]
Handle unusual case in rebase-update where second rebase attempt works.

Previously we just added an assert here but better
to simply succeed in this case, while outputting
the intial failure message.

BUG=425696

Review URL: https://codereview.chromium.org/667793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292687 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoMake git auto-svn idempotent.
agable@chromium.org [Fri, 24 Oct 2014 08:13:03 +0000 (08:13 +0000)]
Make git auto-svn idempotent.

By directly using git-config rather than git-svn-init, this ensures that
crazy values don't get set. It could be "safer" (e.g. check to see if any
other git-svn configuration already exists and prompt before overwriting it),
but I think that simplicity is better here.

R=pgervais@chromium.org
BUG=425838

Review URL: https://codereview.chromium.org/675713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292640 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoLet gclient config accept file:// urls.
agable@chromium.org [Thu, 23 Oct 2014 08:28:30 +0000 (08:28 +0000)]
Let gclient config accept file:// urls.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/615443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292613 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoGet rid of spurious warning about bad --revision flag.
szager@chromium.org [Wed, 22 Oct 2014 21:13:52 +0000 (21:13 +0000)]
Get rid of spurious warning about bad --revision flag.

R=vadimsh@chromium.org,mmoss@chromium.org
BUG=

Review URL: https://codereview.chromium.org/671003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292601 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoAdd a Mojo recipe to make mojo fetch-able.
dpranke@chromium.org [Wed, 22 Oct 2014 17:49:54 +0000 (17:49 +0000)]
Add a Mojo recipe to make mojo fetch-able.

R=jamesr@chromium.org, agable@chromium.org

Review URL: https://codereview.chromium.org/666293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292598 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoUpdate fetch to support more flexible refspecs
agable@chromium.org [Wed, 22 Oct 2014 10:35:33 +0000 (10:35 +0000)]
Update fetch to support more flexible refspecs

R=machenbach@chromium.org
BUG=415464

Review URL: https://codereview.chromium.org/656623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292588 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoAdd a fetch recipe for infra_internal.
agable@chromium.org [Wed, 22 Oct 2014 09:59:38 +0000 (09:59 +0000)]
Add a fetch recipe for infra_internal.

Although many things are private, the urls of the infra_internal and
build_internal repositories are not. So let's just add a fetch recipe
for them anyway.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/544863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292586 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd optional <DEPS file> argument to roll-dep.
szager@chromium.org [Tue, 21 Oct 2014 19:00:06 +0000 (19:00 +0000)]
Add optional <DEPS file> argument to roll-dep.

BUG=chromium:425117
R=agable@chromium.org,kjellander@chromium.org

Review URL: https://codereview.chromium.org/666713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292563 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoMake 'git cl patch' work when not on a named branch.
szager@chromium.org [Mon, 20 Oct 2014 22:33:21 +0000 (22:33 +0000)]
Make 'git cl patch' work when not on a named branch.

R=maruel@chromium.org,pgervais@chromium.org
BUG=

Review URL: https://codereview.chromium.org/661413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292537 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoRevert 292493 since it broke CQ
jam@chromium.org [Fri, 17 Oct 2014 18:43:02 +0000 (18:43 +0000)]
Revert 292493 since it broke CQ

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292513 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix reitveld base URL for googlesource.com repos.
sbc@chromium.org [Thu, 16 Oct 2014 21:01:25 +0000 (21:01 +0000)]
Fix reitveld base URL for googlesource.com repos.

The base url was previously being generated as
URL@BRANCH.  I'm not sure if this works anywhere
but it certainly doesn't on googlesource.com.
Here we want URL/+/BRANCH.

R=iannucci@chromium.org, sergeyberezin@chromium.org

Review URL: https://codereview.chromium.org/652193004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292493 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix clang-format canned check warning text
enne@chromium.org [Thu, 16 Oct 2014 19:23:07 +0000 (19:23 +0000)]
Fix clang-format canned check warning text

input_api.basename is a function, so printing it out yields:
"The <function basename at 0x7fccd3735410> directory requires..>"

Instead, use it to resolve the local presubmit path that has
requested clang formatting.

R=dpranke@chromium.org
BUG=422332

Review URL: https://codereview.chromium.org/665493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292491 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoGit footer fix for v8
hinoka@chromium.org [Mon, 13 Oct 2014 21:25:43 +0000 (21:25 +0000)]
Git footer fix for v8

Git footers doesn't seem to support v8, let alone know that trunk actually maps
to the candidate branch.  This should fix it.

BUG=
TBR=agable

Review URL: https://codereview.chromium.org/645183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292445 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoImprove error handling in git-rebase-update
sbc@chromium.org [Mon, 13 Oct 2014 21:01:00 +0000 (21:01 +0000)]
Improve error handling in git-rebase-update

Don't discard stderr from failed rebase operations
I had an issue where stdout of the failed rebase was
empty but stderr contained:
First, rewinding head to replay your work on top of it...
Dirty index: cannot apply patches (dirty: internal_gyp
third_party/html_office).

Also, in my case the second rebase was actually succeeding
for some reason, which is clearly no expected, so assert
in this case.

BUG=410339

Review URL: https://codereview.chromium.org/645763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292444 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoMake MIME boundary harder to accidentally match.
jrobbins@chromium.org [Mon, 13 Oct 2014 16:30:36 +0000 (16:30 +0000)]
Make MIME boundary harder to accidentally match.
This is just making the same change to the copy of upload.py that is in depot_tools.

BUG=419156
R=iannucci@chromium.org

Original Review URL: https://codereview.chromium.org/624513002

Review URL: https://codereview.chromium.org/639503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292432 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoChange CheckPatchFormatted to report which directory failed.
jkarlin@chromium.org [Fri, 10 Oct 2014 17:00:37 +0000 (17:00 +0000)]
Change CheckPatchFormatted to report which directory failed.

If presubmit.py for a directory (such as net/) fails due to not being clang formatted, then 'git cl format' needs to be run for that directory, not the entire patch.

BUG=422332

Review URL: https://codereview.chromium.org/648713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292407 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoRemove useless comments from git bash wrappers.
agable@chromium.org [Thu, 9 Oct 2014 07:49:39 +0000 (07:49 +0000)]
Remove useless comments from git bash wrappers.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/621783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292379 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoSuppress readability/inheritance check for cpplint.py for now.
dcheng@chromium.org [Sat, 4 Oct 2014 06:47:08 +0000 (06:47 +0000)]
Suppress readability/inheritance check for cpplint.py for now.

This check never triggered before, since cpplint.py was looking for
override not OVERRIDE. Since Chromium prefers override now, the
linter is now (correctly) warning. However, the old Chromium convention
(and the one implemented by the clang plugin) is to explicitly annotate
all overrides with both virtual and override. The clang plugin code has
been updated, but new binaries have not yet been built. Until clang
rolls, suppress the warning.

BUG=417463
TBR=stip@chromium.org

Review URL: https://codereview.chromium.org/627163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292319 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdded os to input_api
pgervais@chromium.org [Thu, 2 Oct 2014 23:23:46 +0000 (23:23 +0000)]
Added os to input_api

BUG=
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/614413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292291 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoIntroduct git-auto-svn
agable@chromium.org [Wed, 1 Oct 2014 09:40:10 +0000 (09:40 +0000)]
Introduct git-auto-svn

This tool can automatically set up the necessary git-svn metadata for our
repos that live in SVN but are mirrored to Chrome.

R=iannucci@chromium.org, tandrii@chromium.org
BUG=418973

Review URL: https://codereview.chromium.org/611253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292241 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoReport the entire hash in the "committed" message.
mark@chromium.org [Fri, 26 Sep 2014 21:48:02 +0000 (21:48 +0000)]
Report the entire hash in the "committed" message.

This concerns the "committed" message posted to Rietveld. Prior to
34504a15bb3e, this used the committer's own core.abbrev. Now it's using
a hard-coded 7. Per recent discussions on chromium-dev, 7 is
insufficient to uniquely identify commits in large repositories such as
ours. If any abbreviation is to be done, a 12-digit minimum should be
used, but there's no reason not to use the entire hash.

Review URL: https://codereview.chromium.org/592293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292164 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix roll_dep.py to print the right latest SVN revision number on error.
thestig@chromium.org [Wed, 24 Sep 2014 23:48:33 +0000 (23:48 +0000)]
Fix roll_dep.py to print the right latest SVN revision number on error.

TEST="roll_dep.py breakpad/src 10000" should print ~1387, not 4.

Review URL: https://codereview.chromium.org/604463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292129 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix regexp used for enumerating remotes.
asanka@chromium.org [Wed, 24 Sep 2014 20:11:17 +0000 (20:11 +0000)]
Fix regexp used for enumerating remotes.

R=szager@chromium.org
BUG=413391

Review URL: https://codereview.chromium.org/598153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292123 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix logic for determing remote name from remote branch.
szager@chromium.org [Wed, 24 Sep 2014 17:25:45 +0000 (17:25 +0000)]
Fix logic for determing remote name from remote branch.

BUG=413391
R=iannucci@chromium.org,agable@chromium.org

Review URL: https://codereview.chromium.org/567873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292117 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoRough verification code to ensure deps hosts \in allowed_hosts.
tandrii@chromium.org [Tue, 23 Sep 2014 11:49:52 +0000 (11:49 +0000)]
Rough verification code to ensure deps hosts \in allowed_hosts.

BUG=371012

Review URL: https://codereview.chromium.org/562953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292088 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUse three-way merge when applying Git patches.
primiano@chromium.org [Tue, 23 Sep 2014 08:14:39 +0000 (08:14 +0000)]
Use three-way merge when applying Git patches.

After switching to a pure git workflow, most of the patchset we upload
to rietveld have git metadata. Apparently, however, the scripts here in
depot tools, which are used by the CQ and trybots, are ignoring that
and applying patches without taking advantage of git metadata.
In practice this causes people to rebase and reupload patches more than
necessary, even in the cases when it could be handled automatically by
means of a three way merge.
This change updates the GitCheckout class of depot_tools to use that.

BUG=416003

Review URL: https://codereview.chromium.org/577203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292087 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix map-branches issues and add coloring for 'branch-heads',
calamity@chromium.org [Tue, 23 Sep 2014 03:30:50 +0000 (03:30 +0000)]
Fix map-branches issues and add coloring for 'branch-heads',

This CL fixes some issues with map-branches:
* Branches with no upstream were not being shown.
* -vv from a detached HEAD would crash
* GONE upstreams would crash when git cleaned up in a way that caused
  hash_one to fail

This CL also adds a blue coloring to branches that start with
'branch-heads' for Chromium release branches.

BUG=416530

Review URL: https://codereview.chromium.org/576423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292083 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoOmit <include> lines over 80+ columns.
dbeam@chromium.org [Tue, 23 Sep 2014 00:42:22 +0000 (00:42 +0000)]
Omit <include> lines over 80+ columns.

R=dpranke@chromium.org
BUG=none
TEST=no whining about <include src="long/path/name.js">

Review URL: https://codereview.chromium.org/579383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292080 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUse CheckCallAndFilterAndHeader for git commands.
sbc@chromium.org [Mon, 22 Sep 2014 21:17:59 +0000 (21:17 +0000)]
Use CheckCallAndFilterAndHeader for git commands.

Then this was changed to CheckCallAndFilter it broke
the expectations of code in the buildbot tree:
 scripts/slave/chromium_commands.py:extract_revisions

Alternatively we could update the expectations
of chromium_commands.py.

BUG= https://code.google.com/p/chromium/issues/detail?id=412818

Review URL: https://codereview.chromium.org/587253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292072 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoMake check_output of subprocess2 compatible with Python's subprocess.
tandrii@chromium.org [Fri, 19 Sep 2014 11:51:43 +0000 (11:51 +0000)]
Make check_output of subprocess2 compatible with Python's subprocess.

According to Python's doc (
https://docs.python.org/2/library/subprocess.html#subprocess.check_output
):
if check_output raises exception CalledProcessError, the exception object
should contain stdout data as `output` attribute. Before this commit,
subprocess2.CalledProcessError had `output` always None, and used `stdout`
instead. This commit fixes this problem storing the same data in both `stdout`
and `output`.

BUG=NONE

Review URL: https://codereview.chromium.org/582933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@292036 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoroll-dep: If applicable, include svn revision range in commit message
borenet@google.com [Mon, 15 Sep 2014 21:00:23 +0000 (21:00 +0000)]
roll-dep: If applicable, include svn revision range in commit message

This is analogous to the change made in
https://codereview.chromium.org/559243002/.  I want to change ARB to use the
commit message generated by roll-dep.

BUG=408700

Review URL: https://codereview.chromium.org/564363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291975 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoRevert "Make check for dirty index work."
smut@google.com [Thu, 11 Sep 2014 19:57:55 +0000 (19:57 +0000)]
Revert "Make check for dirty index work."

This reverts commit 931b6c6a6c72038b8994565aff5926d5050fb329.

This was causing our try bots to fail on DEPS changes.

After applying the patch successfully, apply_issue.py tries to run gclient sync to get the updated DEPS, resulting in this error:
src (ERROR)
----------------------------------------
[0:00:00] Started.
----------------------------------------
Error:
____ src at origin/master
Your index contains uncommitted changes
Please commit, stash, or reset.

BUG=413326
TESTED=Manually: https://paste.googleplex.com/6375653263802368

Review URL: https://codereview.chromium.org/563873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291932 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoFactor out Changelist GetStatus() for eventual use by other tools
jsbell@chromium.org [Thu, 11 Sep 2014 17:29:28 +0000 (17:29 +0000)]
Factor out Changelist GetStatus() for eventual use by other tools

Pulls the logic for computing an issue's "status" - has LGTM, is in
CQ, etc. - out of the "git cl status" command itself, so that other
tools can get the status of a Changelist.

BUG=379849
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/555973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291928 0039d316-1c4b-4281-b951-d872f2087c98

3 months agoFix ascii art escaping.
maruel@chromium.org [Wed, 10 Sep 2014 11:08:06 +0000 (11:08 +0000)]
Fix ascii art escaping.

This was done because a line ending with a '\' will not be printed properly.
Completely escape the string.

R=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/557143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291906 0039d316-1c4b-4281-b951-d872f2087c98