chromium/tools/depot_tools.git
26 min agoRequire 'CHROME_HEADLESS' to use 'git-number'. master
dnj@chromium.org [Tue, 2 Sep 2014 20:49:59 +0000 (20:49 +0000)]
Require 'CHROME_HEADLESS' to use 'git-number'.

Updated 'git-number' to produce an error message if it's run without the
CHROME_HEADLESS (bot) environment variable. This is intended to alert developers
who may be incorrectly using this tool to get positioning information instead of
the commit position.

BUG=409917
TEST=local
  - Ran with and without 'CHROME_HEADLESS'; observed the error message in the
    'without' case.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/534703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291773 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoUse full hash in Committed link when closing issue via git-cl.
iannucci@chromium.org [Fri, 29 Aug 2014 23:51:37 +0000 (23:51 +0000)]
Use full hash in Committed link when closing issue via git-cl.

R=agable@chromium.org, vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/526523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291751 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoRemove ilevy-cc from WATCHLIST, depot_tools edition :-(
thakis@chromium.org [Fri, 29 Aug 2014 23:09:12 +0000 (23:09 +0000)]
Remove ilevy-cc from WATCHLIST, depot_tools edition :-(

BUG=

Review URL: https://codereview.chromium.org/520053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291748 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoMake git-cl-{dcommit,land} fail if retcode is not zero after push.
iannucci@chromium.org [Fri, 29 Aug 2014 22:10:59 +0000 (22:10 +0000)]
Make git-cl-{dcommit,land} fail if retcode is not zero after push.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=409170

Review URL: https://codereview.chromium.org/523113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291745 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoFix transient error regexes.
iannucci@chromium.org [Fri, 29 Aug 2014 22:10:55 +0000 (22:10 +0000)]
Fix transient error regexes.

R=agable@chromium.org, dnj@chromium.org, vadimsh@chromium.org
BUG=409167

Review URL: https://codereview.chromium.org/521583008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291744 0039d316-1c4b-4281-b951-d872f2087c98

3 days agoModify roll_dep's commit message
borenet@google.com [Fri, 29 Aug 2014 22:03:07 +0000 (22:03 +0000)]
Modify roll_dep's commit message

This conforms to the convention of using a single-line short description
followed by an empty line followed by a long description. Shortened the
revisions to more easily fit on one line.

BUG=408700

Review URL: https://codereview.chromium.org/513383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291743 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoMake git-cl-land wait
iannucci@chromium.org [Fri, 29 Aug 2014 01:38:03 +0000 (01:38 +0000)]
Make git-cl-land wait

R=vadimsh@chromium.org
BUG=406198

Review URL: https://codereview.chromium.org/519563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291719 0039d316-1c4b-4281-b951-d872f2087c98

4 days agoUpdate the Blink recipe to use 'webkit_revision' instead of 'webkit_rev'
philipj@opera.com [Thu, 28 Aug 2014 21:54:23 +0000 (21:54 +0000)]
Update the Blink recipe to use 'webkit_revision' instead of 'webkit_rev'

With the deletion of .DEPS.git, 'webkit_rev' became 'webkit_revision':
https://codereview.chromium.org/497313003

Without this change, gclient sync will not get the latest Blink commit.

Review URL: https://codereview.chromium.org/496443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291716 0039d316-1c4b-4281-b951-d872f2087c98

5 days agoMake git-nav-downstream synchronous
asanka@chromium.org [Thu, 28 Aug 2014 00:25:22 +0000 (00:25 +0000)]
Make git-nav-downstream synchronous

Currently git-nav-downstream invokes 'git checkout' in a subprocess, but
exits without waiting for the checkout to complete. Instead wait for the
subprocess to complete.

BUG=376101

Review URL: https://codereview.chromium.org/509163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291701 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoAdd the patchset id to the manual commit messages
rmistry@google.com [Wed, 27 Aug 2014 14:44:41 +0000 (14:44 +0000)]
Add the patchset id to the manual commit messages

Context is here:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/M7f9VTqrR8w/RECOX2Y5YasJ

Review URL: https://codereview.chromium.org/513763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291687 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRetry fetching patch from rietveld on a 404
hinoka@chromium.org [Wed, 27 Aug 2014 14:00:41 +0000 (14:00 +0000)]
Retry fetching patch from rietveld on a 404

Also added a tiny bit of exponential backoff.

BUG=375479

Review URL: https://codereview.chromium.org/350433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291682 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoRevert hard-coded src.git DEPS file name.
mmoss@chromium.org [Tue, 26 Aug 2014 23:24:09 +0000 (23:24 +0000)]
Revert hard-coded src.git DEPS file name.

This is breaking the ability to specify an alternate DEPS file, and do
things like sync release tags where DEPS is still from svn and we need
.DEPS.git to do a git checkout.

R=iannucci@chromium.org, szager@chromium.org
BUG=407049

Review URL: https://codereview.chromium.org/511533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291665 0039d316-1c4b-4281-b951-d872f2087c98

6 days agoBe verbose about what's happening in 'git cl land' when pusing to pending ref.
vadimsh@chromium.org [Tue, 26 Aug 2014 21:57:53 +0000 (21:57 +0000)]
Be verbose about what's happening in 'git cl land' when pusing to pending ref.

Also reduce number of attempts and give up right away on ACL errors.

R=iannucci@chromium.org
BUG=407369,407470

Review URL: https://codereview.chromium.org/512493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291656 0039d316-1c4b-4281-b951-d872f2087c98

7 days agoAdd some more context to git-drover tutorial.
mmoss@chromium.org [Mon, 25 Aug 2014 23:58:16 +0000 (23:58 +0000)]
Add some more context to git-drover tutorial.

BUG=407284
R=iannucci@google.com

Review URL: https://codereview.chromium.org/507513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291619 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoHave 'fetch chromium' set up with .DEPS.git to support recursion.
agable@chromium.org [Mon, 25 Aug 2014 20:48:07 +0000 (20:48 +0000)]
Have 'fetch chromium' set up with .DEPS.git to support recursion.

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/504933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291613 0039d316-1c4b-4281-b951-d872f2087c98

8 days agoOnly clear cache locks if the cache exists.
dnj@chromium.org [Mon, 25 Aug 2014 19:17:12 +0000 (19:17 +0000)]
Only clear cache locks if the cache exists.

BUG=407259
TEST=None

Review URL: https://codereview.chromium.org/462363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291609 0039d316-1c4b-4281-b951-d872f2087c98

8 days agodepot_tools: update cpplint.py to r137
avakulenko@google.com [Mon, 25 Aug 2014 16:26:18 +0000 (16:26 +0000)]
depot_tools: update cpplint.py to r137

Implements 'linelength' option in CPPLINT.cfg.
See:
https://code.google.com/p/google-styleguide/source/browse/trunk/cpplint/cpplint.py?r=137

BUG=None
TEST=None

Change-Id: I7b017078d997dfafc524a2f50a32289391d011f9

Review URL: https://codereview.chromium.org/495413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291601 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoEnsure deps_file=.DEPS.git in .gclient
szager@chromium.org [Sun, 24 Aug 2014 19:38:43 +0000 (19:38 +0000)]
Ensure deps_file=.DEPS.git in .gclient

R=agable@chromium.org,cmp@chromium.org
BUG=

Review URL: https://codereview.chromium.org/500903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291592 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoFix git cache unlock invocation to specify cache dir.
szager@chromium.org [Sun, 24 Aug 2014 19:16:31 +0000 (19:16 +0000)]
Fix git cache unlock invocation to specify cache dir.

TBR=cmp@chromium.org,agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/498043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291591 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoForce break git cache locks when CHROME_HEADLESS is set.
szager@chromium.org [Sun, 24 Aug 2014 18:56:32 +0000 (18:56 +0000)]
Force break git cache locks when CHROME_HEADLESS is set.

BUG=406669
R=dnj@chromium.org,agable@chromium.org

Review URL: https://codereview.chromium.org/500903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291590 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoDon't remove "'deps_file': '.DEPS.git'" for chromium/src
szager@chromium.org [Sun, 24 Aug 2014 18:41:38 +0000 (18:41 +0000)]
Don't remove "'deps_file': '.DEPS.git'" for chromium/src

BUG=406880
R=iannucci@chromium.org,cmp@chromium.org

Review URL: https://codereview.chromium.org/498023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291589 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoRemove the old cache dir before moving the bootstrapped cache dir into the real location
hinoka@chromium.org [Sun, 24 Aug 2014 12:09:13 +0000 (12:09 +0000)]
Remove the old cache dir before moving the bootstrapped cache dir into the real location

Seems like some combination of things (bad cache dir, shallow checkout, etc) causes
git cache to not clean up properly before trying to move new directory A into
already existing directory B.

So the logic is all there to detect that the cache is invalid, its just not
being cleaned up properly during shallow checkouts.

BUG=406864
TBR=iannucci

Review URL: https://codereview.chromium.org/499123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291587 0039d316-1c4b-4281-b951-d872f2087c98

9 days agoFix git-cl when working on branches.
mmoss@chromium.org [Sun, 24 Aug 2014 01:41:11 +0000 (01:41 +0000)]
Fix git-cl when working on branches.

This updates various assumptions to coincide with how gclient fetches
branch-heads refs from chromium repos.

R=iannucci@google.com
BUG=406858

Review URL: https://codereview.chromium.org/498013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291586 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoFix gclient hook for stubborn hooks.
iannucci@chromium.org [Sat, 23 Aug 2014 03:44:18 +0000 (03:44 +0000)]
Fix gclient hook for stubborn hooks.

R=szager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/497333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291574 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoDo threading.Lock the Right Way.
szager@chromium.org [Sat, 23 Aug 2014 03:33:28 +0000 (03:33 +0000)]
Do threading.Lock the Right Way.

R=cmp@chromium.org, dnj@chromium.org, iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/499003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291573 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoFix thread lock around cachepath access.
szager@chromium.org [Sat, 23 Aug 2014 02:35:23 +0000 (02:35 +0000)]
Fix thread lock around cachepath access.

R=cmp@chromium.org, agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/468253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291571 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoAdd thread locking around GetCachePath().
szager@chromium.org [Sat, 23 Aug 2014 01:57:59 +0000 (01:57 +0000)]
Add thread locking around GetCachePath().

BUG=406662
R=cmp@chromium.org, agable@chromium.org

Review URL: https://codereview.chromium.org/469073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291569 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoAuto-update .gclient files for git.
szager@chromium.org [Sat, 23 Aug 2014 00:57:31 +0000 (00:57 +0000)]
Auto-update .gclient files for git.

TBR=iannucci@chromium.org,stip@chromium.org

Review URL: https://codereview.chromium.org/503563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291567 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoMake fetch chromium operate in git-only mode.
agable@chromium.org [Sat, 23 Aug 2014 00:20:42 +0000 (00:20 +0000)]
Make fetch chromium operate in git-only mode.

DO NOT LAND until Flag Day.

R=stip@chromium.org
BUG=406165

Review URL: https://codereview.chromium.org/494993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291565 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoDon't freak out if 'ignore_locks' options is not set.
vadimsh@chromium.org [Fri, 22 Aug 2014 23:56:49 +0000 (23:56 +0000)]
Don't freak out if 'ignore_locks' options is not set.

BUG=406636
R=stip@chromium.org

Review URL: https://codereview.chromium.org/497293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291561 0039d316-1c4b-4281-b951-d872f2087c98

10 days agoStop git cl using CQ_TRYBOTS.
jam@chromium.org [Fri, 22 Aug 2014 22:13:21 +0000 (22:13 +0000)]
Stop git cl using CQ_TRYBOTS.

This is broken for a few reasons (see bug for details). Also, this works automatically now with the analyze step.

This is a revert of r280039.

BUG=406238
R=iannucci@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/501503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291526 0039d316-1c4b-4281-b951-d872f2087c98

11 days agoSometimes options won't have a 'shallow' field. Don't freak out.
szager@chromium.org [Fri, 22 Aug 2014 21:00:22 +0000 (21:00 +0000)]
Sometimes options won't have a 'shallow' field.  Don't freak out.

BUG=406535
R=stip@chromium.org,vadimsh@chromium.org

Review URL: https://codereview.chromium.org/504473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291502 0039d316-1c4b-4281-b951-d872f2087c98

11 days agoUse a regex instead of shlex.split() to get remote url
hinoka@chromium.org [Fri, 22 Aug 2014 18:08:53 +0000 (18:08 +0000)]
Use a regex instead of shlex.split() to get remote url

shlex.spit(), in addition to doing str.split(' '), also strips out '\\'
from windows paths, which causes the cache_dir check to fail and Gclient to think
that we're not in cache_dir mode even if we are.

Instead of using shlex to strip data from a stdout log, I think regex is more
suited for this job.

BUG=405973

Review URL: https://codereview.chromium.org/497053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291446 0039d316-1c4b-4281-b951-d872f2087c98

11 days agoTeach 'git cl land' to land to pending ref.
vadimsh@chromium.org [Fri, 22 Aug 2014 01:34:13 +0000 (01:34 +0000)]
Teach 'git cl land' to land to pending ref.

R=iannucci@chromium.org
BUG=404214

Review URL: https://codereview.chromium.org/496073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291302 0039d316-1c4b-4281-b951-d872f2087c98

12 days agoDon't be pedantic about .gclient file for non-mutating commands.
szager@chromium.org [Thu, 21 Aug 2014 15:10:10 +0000 (15:10 +0000)]
Don't be pedantic about .gclient file for non-mutating commands.

This is primarily a hack to enable the chromeos ebuild.

BUG=367027
TBR=iannucci@chromium.org,mmoss@chromium.org

Review URL: https://codereview.chromium.org/490233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291075 0039d316-1c4b-4281-b951-d872f2087c98

12 days agoAdd stub git-drover documentation.
mmoss@chromium.org [Wed, 20 Aug 2014 23:23:28 +0000 (23:23 +0000)]
Add stub git-drover documentation.

R=iannucci@google.com
BUG=261738

Review URL: https://codereview.chromium.org/494873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290946 0039d316-1c4b-4281-b951-d872f2087c98

12 days agoOnly check for clean repos when not (--force or --reset).
iannucci@chromium.org [Wed, 20 Aug 2014 23:08:00 +0000 (23:08 +0000)]
Only check for clean repos when not (--force or --reset).

This allows cache_dir to be enabled on bots when the individual repo path has
changes (like android_tools, which has a bunch of generated, non-ignored .h
files)

R=agable@chromium.org, szager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/488273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290943 0039d316-1c4b-4281-b951-d872f2087c98

12 days agoFix manpage creation error.
mmoss@chromium.org [Wed, 20 Aug 2014 22:54:14 +0000 (22:54 +0000)]
Fix manpage creation error.

When running make_docs.sh, I get the error:
  asciidoc: FAILED: manpage document title is mandatory
  make: *** [git-cherry-pick-upload.xml] Error 1

I don't fully understand why, or why this hasn't come up before, but it
seems to be complaining about the formatting of "===" in
git-cherry-pick-upload.txt. This was with xmlto version 0.0.25 on
Precise.

R=iannucci@google.com

Review URL: https://codereview.chromium.org/489143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290939 0039d316-1c4b-4281-b951-d872f2087c98

13 days agoHave git-cl try fail when used on a closed CL
agable@chromium.org [Wed, 20 Aug 2014 16:31:19 +0000 (16:31 +0000)]
Have git-cl try fail when used on a closed CL

R=phajdan.jr@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/494713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290844 0039d316-1c4b-4281-b951-d872f2087c98

13 days agoAdd --with_tags to enable git tag fetching.
szager@chromium.org [Tue, 19 Aug 2014 22:49:16 +0000 (22:49 +0000)]
Add --with_tags to enable git tag fetching.

Needed for chromeos ebuild.

BUG=chromium:376027
R=mmoss@chromium.org,hinoka@chromium.org

Review URL: https://codereview.chromium.org/490743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290683 0039d316-1c4b-4281-b951-d872f2087c98

13 days agoNon-destructive editing of git cache config.
szager@chromium.org [Tue, 19 Aug 2014 21:19:19 +0000 (21:19 +0000)]
Non-destructive editing of git cache config.

R=agable@chromium.org,iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/485663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290665 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoAdd expect_tests and testing_support to infra recipe.
iannucci@chromium.org [Sun, 17 Aug 2014 17:55:03 +0000 (17:55 +0000)]
Add expect_tests and testing_support to infra recipe.

For more better access :)

R=eseidel@chromium.org, stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/466923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@290190 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoDiscover git.bat even if git_cl.py is executed using relative path
techtonik@gmail.com [Fri, 15 Aug 2014 20:01:53 +0000 (20:01 +0000)]
Discover git.bat even if git_cl.py is executed using relative path

This allows git_cl.py to be used without adding depot_tools to PATH

BUG=
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/471413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@289992 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoAuto find tryserver master for git cl try
sheyang@chromium.org [Thu, 14 Aug 2014 22:18:42 +0000 (22:18 +0000)]
Auto find tryserver master for git cl try

BUG=352461

TEST=local tests

Review URL: https://codereview.chromium.org/447363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@289711 0039d316-1c4b-4281-b951-d872f2087c98

2 weeks agoAllow chromium buildtools path to be overriden in the environment.
zturner@chromium.org [Wed, 13 Aug 2014 23:15:25 +0000 (23:15 +0000)]
Allow chromium buildtools path to be overriden in the environment.

This is useful in certain (admittedly unsupported) cases
when trying to use tools from depot_tools outside of a
chrome repository.  In this particular case, I was trying
to "git cl format" something that wasn't a chrome
repository.

BUG=0

Review URL: https://codereview.chromium.org/472553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@289412 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agowin: Add recipe to package Pro toolchain
scottmg@chromium.org [Tue, 12 Aug 2014 02:53:12 +0000 (02:53 +0000)]
win: Add recipe to package Pro toolchain

Previously https://codereview.chromium.org/284663003/, this was done
manually. This script attempts to automates that manual process.

R=iannucci@chromium.org
BUG=402543

Review URL: https://codereview.chromium.org/462913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@288877 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoUpdate cpplint.py to r136.
avakulenko@google.com [Mon, 11 Aug 2014 20:20:55 +0000 (20:20 +0000)]
Update cpplint.py to r136.

The only difference compared to upstream[1] is the shebang line from
depot_tools.

[1] https://code.google.com/p/google-styleguide/source/browse/trunk/cpplint/cpplint.py?r=136

BUG=None

Review URL: https://codereview.chromium.org/460003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@288783 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdded hyphen-only options
pgervais@chromium.org [Fri, 8 Aug 2014 15:52:33 +0000 (15:52 +0000)]
Added hyphen-only options

Some options have words separated by underscores. Added options with
same name and underscores replaced by hyphens.

BUG=400953

Review URL: https://codereview.chromium.org/436963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@288366 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoChange chromium fetch spec to use master as the git-svn ref.
iannucci@chromium.org [Fri, 8 Aug 2014 02:34:11 +0000 (02:34 +0000)]
Change chromium fetch spec to use master as the git-svn ref.

R=vadimsh@chromium.org
BUG=366924

Review URL: https://codereview.chromium.org/450863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@288205 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdded support for relative paths for the .gclient cache_dir field.
dyen@chromium.org [Thu, 7 Aug 2014 21:41:37 +0000 (21:41 +0000)]
Added support for relative paths for the .gclient cache_dir field.

R=iannucci@chromium.org
BUG=None
TEST=gclient sync with a relative and absolute "cache_dir"

Review URL: https://codereview.chromium.org/415713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@288146 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd 'git cache fetch' subcommand.
szager@chromium.org [Thu, 7 Aug 2014 21:02:36 +0000 (21:02 +0000)]
Add 'git cache fetch' subcommand.

If you're in a git checkout cloned from the git cache, this will:
  - Update the cache with the latest upstream commits.
  - Update the cwd with the latest commits from the cache.

For example:

> cd $HOME/workspace/chromium/src
> git cache fetch

R=agable@chromium.org,iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/440213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@288140 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoMake fetch help display all known recipes.
iannucci@chromium.org [Wed, 6 Aug 2014 19:47:54 +0000 (19:47 +0000)]
Make fetch help display all known recipes.

R=agable@chromium.org
BUG=366884

Review URL: https://codereview.chromium.org/358203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@287832 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoReland: Add --no-history option to fetch and gclient for shallow clones.
primiano@chromium.org [Wed, 6 Aug 2014 17:18:18 +0000 (17:18 +0000)]
Reland: Add --no-history option to fetch and gclient for shallow clones.

Original CL: https://codereview.chromium.org/440263002/

Many people* have complained on chromium-dev about the long times
required to perform a full fetch over a DSL. This seems to be mostly
due to the huge size of chromium's history (~9 GB). On the other side,
not everybody is interested in downloading the full git history of
the projects. The size of git packs required to fetch a working HEAD
is one order of magnitude smaller (1.5 GB).
This change makes it possible to perform a shallow fetch (in a way
which is consistent with DEPS, leveraging git templates on clone),
reducing fetch times by 80% for those not interested in the history.

* See:
[chromium-dev] "fetch chromium" keeps hanging/getting stuck on Windows 7
[chromium-dev] Initial checkout with git taking long
[chromium-dev] Trying to get latest source code fails when fetching
[chromium-dev] Gclient sync takes too long

BUG=228996
TBR=iannucci@chromium.org,szager@chromium.org,wtc@chromium.org

Review URL: https://codereview.chromium.org/440273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@287793 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoRevert of Add --no-history option to fetch and gclient for shallow clones. (https...
primiano@chromium.org [Tue, 5 Aug 2014 23:19:29 +0000 (23:19 +0000)]
Revert of Add --no-history option to fetch and gclient for shallow clones. (https://codereview.chromium.org/437903002/)

Reason for revert:
Broke the WebRTC waterfall:
http://build.chromium.org/p/tryserver.webrtc/builders/win/builds/3958/steps/gclient%20revert/logs/stdio

Original issue's description:
> Add --no-history option to fetch and gclient for shallow clones.
>
> Many people* have complained on chromium-dev about the long times
> required to perform a full fetch over a DSL. This seems to be mostly
> due to the huge size of chromium's history (~9 GB). On the other side,
> not everybody is interested in downloading the full git history of
> the projects. The size of git packs required to fetch a working HEAD
> is one order of magnitude smaller (1.5 GB).
> This change makes it possible to perform a shallow fetch (in a way
> which is consistent with DEPS, leveraging git templates on clone),
> reducing fetch times by 80% for those not interested in the history.
>
> * See:
> [chromium-dev] "fetch chromium" keeps hanging/getting stuck on Windows 7
> [chromium-dev] Initial checkout with git taking long
> [chromium-dev] Trying to get latest source code fails when fetching
> [chromium-dev] Gclient sync takes too long
>
> BUG=228996
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=287606

TBR=iannucci@chromium.org,szager@chromium.org,wtc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=228996

Review URL: https://codereview.chromium.org/440263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@287637 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoWhen getting content for a moved file w/ history, don't convert newlines in output...
jrobbins@chromium.org [Tue, 5 Aug 2014 22:19:09 +0000 (22:19 +0000)]
When getting content for a moved file w/ history, don't convert newlines in output of 'git show'

BUG=339068

Review URL: https://codereview.chromium.org/442893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@287615 0039d316-1c4b-4281-b951-d872f2087c98

3 weeks agoAdd --no-history option to fetch and gclient for shallow clones.
primiano@chromium.org [Tue, 5 Aug 2014 21:50:44 +0000 (21:50 +0000)]
Add --no-history option to fetch and gclient for shallow clones.

Many people* have complained on chromium-dev about the long times
required to perform a full fetch over a DSL. This seems to be mostly
due to the huge size of chromium's history (~9 GB). On the other side,
not everybody is interested in downloading the full git history of
the projects. The size of git packs required to fetch a working HEAD
is one order of magnitude smaller (1.5 GB).
This change makes it possible to perform a shallow fetch (in a way
which is consistent with DEPS, leveraging git templates on clone),
reducing fetch times by 80% for those not interested in the history.

* See:
[chromium-dev] "fetch chromium" keeps hanging/getting stuck on Windows 7
[chromium-dev] Initial checkout with git taking long
[chromium-dev] Trying to get latest source code fails when fetching
[chromium-dev] Gclient sync takes too long

BUG=228996

Review URL: https://codereview.chromium.org/437903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@287606 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoAdd comment with svn revision number.
szager@chromium.org [Fri, 1 Aug 2014 18:53:45 +0000 (18:53 +0000)]
Add comment with svn revision number.

R=iannucci@chromium.org,hinoka@chromium.org,mark@chromium.org
BUG=

Review URL: https://codereview.chromium.org/431003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@287057 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoDo not put an 'r' in front of the revision when commenting on Rietveld after committing.
rsesek@chromium.org [Fri, 1 Aug 2014 01:06:24 +0000 (01:06 +0000)]
Do not put an 'r' in front of the revision when commenting on Rietveld after committing.

When using `git cl land` this would result in r<hash>, which is not desirable.

R=maruel@chromium.org

Review URL: https://codereview.chromium.org/432023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@286931 0039d316-1c4b-4281-b951-d872f2087c98

4 weeks agoMake “git cl land” handle core.abbrev > 7.
mark@chromium.org [Thu, 31 Jul 2014 17:09:36 +0000 (17:09 +0000)]
Make “git cl land” handle core.abbrev > 7.

This also fixes the confusing help message that appears when using “git
cl dcommit” in a git project. “git cl push” was totally removed in
abbaa843f4ad.

Review URL: https://codereview.chromium.org/437593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@286835 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoAdd git cherry picking extension
smut@google.com [Tue, 29 Jul 2014 19:01:13 +0000 (19:01 +0000)]
Add git cherry picking extension

This extension uploads a fake cherry pick-style diff to rietveld with a modified project parameter. The modified project is intended to be used by the commit queue to attempt to land the change on a branch.

This works by grabbing the parent of the targeted revision and generating the diff. It is intended to be used to CQ trivial cherry picks which apply cleanly on top of other branches without conflicts.

BUG=387111

Review URL: https://codereview.chromium.org/397593004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@286273 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoUpdate git cl try command to mention tryserver.chromium.linux.
sergeyberezin@chromium.org [Tue, 29 Jul 2014 17:17:20 +0000 (17:17 +0000)]
Update git cl try command to mention tryserver.chromium.linux.

This is a purely cosmetic CL.

R=agable@chromium.org
BUG=395196

Review URL: https://codereview.chromium.org/415903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@286230 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agodepot_tools: modify cpplint.py to allow CPPLINT.cfg overrides
avakulenko@google.com [Mon, 28 Jul 2014 22:13:33 +0000 (22:13 +0000)]
depot_tools: modify cpplint.py to allow CPPLINT.cfg overrides

Added the ability to provide CPPLINT.cfg files to provide
linter message filters per sub-directory and special exclusion
rules. Each file can have instructions like:

filter=-build/include_order,+build/include_alpha
exclude_files=.*\.cc

The above disables build/include_order warning and enables
build/include_alpha as well as excludes all .cc from being
processed by linter, in the current directory (where the .cfg
file is located) and all sub-directories.

Related CL: https://chromium-review.googlesource.com/#/c/209384/

BUG=chromium:395296
TEST=ran cpplint.py on a bunch of directories in platform2/

Review URL: https://codereview.chromium.org/406373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285999 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoAdded 'git-retry' bootstrap
dnj@chromium.org [Mon, 28 Jul 2014 17:39:08 +0000 (17:39 +0000)]
Added 'git-retry' bootstrap

Added the 'git-retry' bootstrap command. This can be used to wrap other 'git'
commands around a fault-tolerant retry wrapper.

BUG=295109
TEST=localtest
R=iannucci@chromium.org, petermayo@chromium.org

Review URL: https://codereview.chromium.org/401673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285939 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoRevert 284349 "Add winrt to the INCLUDE directories of the toolc..."
scottmg@chromium.org [Mon, 28 Jul 2014 16:42:14 +0000 (16:42 +0000)]
Revert 284349 "Add winrt to the INCLUDE directories of the toolc..."

Sorry, I screwed up. This breaks Express-only per skia:2781. I'll reland it before I push the next VS update.

> Add winrt to the INCLUDE directories of the toolchain bundler.
>
> The motivation is that vcvarsall sets it, and that it might make it possible to
> land https://codereview.chromium.org/405723002/ one day.
>
> BUG=395405
> TBR=jochen
>
> Review URL: https://codereview.chromium.org/393233004

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/424813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285924 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoDo not fetch the CL description when using git cl status --fast.
maruel@chromium.org [Mon, 28 Jul 2014 15:37:55 +0000 (15:37 +0000)]
Do not fetch the CL description when using git cl status --fast.

This causes a network I/O, which is not fast. Also this is a non-starter in the
case of no network connectivity, causing a crash instead of completing
successfully. Until Air Canada provides on-flight internet, this is a
non-starter. #firstworldproblem.

Also fix git cl presubmit in case of lack of network connectivity.

R=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/418293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285911 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoAdd exception for long url(..) lines in css files in presubmit_canned_checks.CheckLon...
treib@chromium.org [Mon, 28 Jul 2014 14:23:11 +0000 (14:23 +0000)]
Add exception for long url(..) lines in css files in presubmit_canned_checks.CheckLongLines

BUG=397508

Review URL: https://codereview.chromium.org/424733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285901 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoRemoved git cl push command
pgervais@chromium.org [Fri, 25 Jul 2014 14:30:33 +0000 (14:30 +0000)]
Removed git cl push command

The user message says the subcommand will stop working on July 1.

BUG=

Review URL: https://codereview.chromium.org/396233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285586 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoFix off-by-one error in gclient progress indicator.
szager@chromium.org [Fri, 25 Jul 2014 00:28:06 +0000 (00:28 +0000)]
Fix off-by-one error in gclient progress indicator.

BUG=368673
R=iannucci@chromium.org,cmp@chromium.org

Review URL: https://codereview.chromium.org/412403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285434 0039d316-1c4b-4281-b951-d872f2087c98

5 weeks agoRemove confirmation from git cl land.
maruel@chromium.org [Wed, 23 Jul 2014 23:05:07 +0000 (23:05 +0000)]
Remove confirmation from git cl land.

It serves no purpose, and it's annoying when the presubmit checks take more than
2-3 seconds because I always switch off to another window, so I come back
minutes later seeing this prompt waiting for me.

R=stip@chromium.org
BUG=

Review URL: https://codereview.chromium.org/407413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@285071 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoAdd winrt to the INCLUDE directories of the toolchain bundler.
thakis@chromium.org [Sat, 19 Jul 2014 22:20:37 +0000 (22:20 +0000)]
Add winrt to the INCLUDE directories of the toolchain bundler.

The motivation is that vcvarsall sets it, and that it might make it possible to
land https://codereview.chromium.org/405723002/ one day.

BUG=395405
TBR=jochen

Review URL: https://codereview.chromium.org/393233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@284349 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoGit Cache speculative fix for windows
hinoka@chromium.org [Sat, 19 Jul 2014 01:23:45 +0000 (01:23 +0000)]
Git Cache speculative fix for windows

Git cache sometimes fail on:
Traceback (most recent call last):
  File "E:\b\depot_tools\\gclient.py", line 2064, in <module>
    sys.exit(Main(sys.argv[1:]))
  File "E:\b\depot_tools\\gclient.py", line 2052, in Main
    return dispatcher.execute(OptionParser(), argv)
  File "E:\b\depot_tools\subcommand.py", line 245, in execute
    return command(parser, args[1:])
  File "E:\b\depot_tools\\gclient.py", line 1830, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "E:\b\depot_tools\\gclient.py", line 1342, in RunOnDeps
    work_queue.flush(revision_overrides, command, args, options=self._options)
  File "E:\b\depot_tools\gclient_utils.py", line 852, in flush
    self._run_one_task(self.queued.pop(i), args, kwargs)
  File "E:\b\depot_tools\gclient_utils.py", line 944, in _run_one_task
    task_item.run(*args, **kwargs)
  File "E:\b\depot_tools\\gclient.py", line 744, in run
    file_list)
  File "E:\b\depot_tools\gclient_scm.py", line 160, in RunCommand
    return getattr(self, command)(options, args, file_list)
  File "E:\b\depot_tools\gclient_scm.py", line 387, in update
    self._UpdateMirror(mirror, options)
  File "E:\b\depot_tools\gclient_scm.py", line 802, in _UpdateMirror
    ignore_lock=options.ignore_locks)
  File "E:\b\depot_tools\git_cache.py", line 409, in populate
    os.rename(tempdir, self.mirror_path)
WindowsError: [Error 183] Cannot create a file when that file already exists

It would appear that its being racy, but otherwise it doesn't make any sense.  A theory
is that this could be running twice and stepping on each other.  Allowing this
to pass on OSError allows us to test this theory.

BUG=395333

Review URL: https://codereview.chromium.org/408653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@284272 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoAdd fetch recipe for the open source infra repo.
agable@chromium.org [Sat, 19 Jul 2014 00:26:01 +0000 (00:26 +0000)]
Add fetch recipe for the open source infra repo.

R=iannucci@chromium.org, primiano@chromium.org

Review URL: https://codereview.chromium.org/404643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@284262 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoConvert recursedeps test syntax to list literal.
cmp@chromium.org [Thu, 17 Jul 2014 19:15:40 +0000 (19:15 +0000)]
Convert recursedeps test syntax to list literal.

This will remove a Python 2.7 dependency from the tests.

TBR=agable@chromium.org,iannucci@chromium.org

Review URL: https://codereview.chromium.org/399223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@283834 0039d316-1c4b-4281-b951-d872f2087c98

6 weeks agoUpdate recursedeps to support use_relative_path.
cmp@chromium.org [Wed, 16 Jul 2014 19:48:54 +0000 (19:48 +0000)]
Update recursedeps to support use_relative_path.

Also cast recursedeps to a set.  We'll continue
to support using a list literal form in DEPS for
now.

R=iannucci@chromium.org,agable@chromium.org
BUG=393000

Review URL: https://codereview.chromium.org/385123008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@283474 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoAdd CanAccessToolchainBucket() to ways to use GStorage.
liamjm@chromium.org [Tue, 15 Jul 2014 20:37:53 +0000 (20:37 +0000)]
Add CanAccessToolchainBucket() to ways to use GStorage.
This allows Googlers who didn't pass existing checks to use G storage and
the Pro version of Visual studio.

BUG=
TBR=maruel

Review URL: https://codereview.chromium.org/382373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@283250 0039d316-1c4b-4281-b951-d872f2087c98

7 weeks agoRoll windows git binary package up to v6 everywhere.
iannucci@chromium.org [Tue, 8 Jul 2014 22:03:31 +0000 (22:03 +0000)]
Roll windows git binary package up to v6 everywhere.

Thus solving the sh.exe problem once and for all...

R=hinoka@google.com, hinoka@chromium.org
BUG=383455, 241556, 389361, 380958

Review URL: https://codereview.chromium.org/372413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281844 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoBump git bleeding edge up to 6.
iannucci@chromium.org [Tue, 8 Jul 2014 02:53:17 +0000 (02:53 +0000)]
Bump git bleeding edge up to 6.

This includes the new (fast) custom sh.exe/bash.exe/msys-1.0.dll.

R=hinoka@google.com, hinoka@chromium.org
BUG=383455,241556,389361,380958

Review URL: https://codereview.chromium.org/364133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281645 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoRevert of Consolidated 'git' refish parsing into a class (https://codereview.chromium...
smut@google.com [Mon, 7 Jul 2014 19:35:18 +0000 (19:35 +0000)]
Revert of Consolidated 'git' refish parsing into a class (https://codereview.chromium.org/328843005/)

Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=391871

Original issue's description:
> Consolidated 'git' refish parsing into a class
>
> Created the 'GitRefish' class to centralize 'git' refish parsing and consistent
> usage by 'gclient' 'git' code.
>
> BUG=373504
> TEST=localtest
> R=agable@chromium.org, iannucci@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=281553

TBR=dnj
BUG=391871

Review URL: https://codereview.chromium.org/370393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281572 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoConsolidated 'git' refish parsing into a class
dnj@chromium.org [Mon, 7 Jul 2014 17:08:48 +0000 (17:08 +0000)]
Consolidated 'git' refish parsing into a class

Created the 'GitRefish' class to centralize 'git' refish parsing and consistent
usage by 'gclient' 'git' code.

BUG=373504
TEST=localtest
R=agable@chromium.org, iannucci@chromium.org

Review URL: https://codereview.chromium.org/328843005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281553 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoRevert of Allow git cl also in repos with read-only git-svn. (https://codereview...
bratell@opera.com [Mon, 7 Jul 2014 09:30:23 +0000 (09:30 +0000)]
Revert of Allow git cl also in repos with read-only git-svn. (https://codereview.chromium.org/344013005/)

Reason for revert:
Breaks WebRTC (and possibly other projects actually using https:// for svn access).

Original issue's description:
> Allow git cl also in repos with read-only git-svn.
>
> If you have read-only git-svn git cl would still try
> to use svn commands, which would then fail. This
> changes git cl to only use git-svn if the remote
> svn repository use the svn:// protocol. It matches
> how chromium works and it allowed me to upload a patch.
>
> BUG=391430
>
> R=iannucci
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=281500

TBR=iannucci@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391430

Review URL: https://codereview.chromium.org/375553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281513 0039d316-1c4b-4281-b951-d872f2087c98

8 weeks agoAllow git cl also in repos with read-only git-svn.
bratell@opera.com [Mon, 7 Jul 2014 07:28:34 +0000 (07:28 +0000)]
Allow git cl also in repos with read-only git-svn.

If you have read-only git-svn git cl would still try
to use svn commands, which would then fail. This
changes git cl to only use git-svn if the remote
svn repository use the svn:// protocol. It matches
how chromium works and it allowed me to upload a patch.

BUG=391430

R=iannucci

Review URL: https://codereview.chromium.org/344013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281500 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUpdate recurselist to be a set, call it recursedeps now.
cmp@chromium.org [Wed, 2 Jul 2014 23:20:08 +0000 (23:20 +0000)]
Update recurselist to be a set, call it recursedeps now.

Now that recurselist is no longer a list, it doesn't make
sense to call it recurselist.  recurseset is available, but
that's not as easy to read/say compared to recurselist.
Call this recursedeps, instead.

R=iannucci@chromium.org
BUG=390246

Review URL: https://codereview.chromium.org/363103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@281107 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoChange clang_format.py to search for clang-format in buildtools
jochen@chromium.org [Wed, 2 Jul 2014 07:35:31 +0000 (07:35 +0000)]
Change clang_format.py to search for clang-format in buildtools

BUG=none
R=brettw@chromium.org,nick@chromium.org

Review URL: https://codereview.chromium.org/356733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280971 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd fallback to DEPS from a missing deps file.
cmp@chromium.org [Wed, 2 Jul 2014 00:13:18 +0000 (00:13 +0000)]
Add fallback to DEPS from a missing deps file.

It's possible to tell gclient to use a different
"deps" file from the default DEPS through the "deps_file"
variable in the .gclient file.

If this file is missing, fallback to DEPS (the
default).

BUG=390700

Review URL: https://codereview.chromium.org/368713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280921 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoDon't pass in --revision into gclient sync on the DEPS sync in apply_issue.py if git
hinoka@chromium.org [Tue, 1 Jul 2014 18:48:28 +0000 (18:48 +0000)]
Don't pass in --revision into gclient sync on the DEPS sync in apply_issue.py if git

We changed apply_issue to stage the patch if its on git, so it doesn't make sense to pass in --revision because that causes gclient to run solutions in managed mode.

BUG=388374

Review URL: https://codereview.chromium.org/359443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280855 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd recurselist DEPS var setting.
cmp@chromium.org [Mon, 30 Jun 2014 23:14:35 +0000 (23:14 +0000)]
Add recurselist DEPS var setting.

Previously, recursion overrides were only available by setting
a numeric 'depth' value in a DEPS file.  This meant that it
was not possible to control recursion per-dependency entry.

This change adds a recurselist variable with a list structure.
If a named dependency is present in the list, then gclient will
recurse into that dependency's DEPS.

As part of this change, I move the recursion controls off of
DependencySetting and onto Dependency.  The new setup of being
based on Dependency allows access to the dependency's name.

The controls are only called from Dependency instances.  They
have always needed access to self.parent (in the Dependency
context), so this should be more correct than the previous setup.

BUG=390246

Review URL: https://codereview.chromium.org/331373009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280690 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUpdate ninja to v1.5.1 on Mac, Linux32, Linux64, Windows.
thakis@chromium.org [Sat, 28 Jun 2014 00:00:36 +0000 (00:00 +0000)]
Update ninja to v1.5.1 on Mac, Linux32, Linux64, Windows.

See the bug for how these were built.

The linux binaries were built by thestig@chromium.org.
The windows binary was built by scottmg@chromium.org.
The mac binary was built by thakis@chromium.org

BUG=389683
TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/357043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280451 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoRevert r280425.
thakis@chromium.org [Fri, 27 Jun 2014 22:37:00 +0000 (22:37 +0000)]
Revert r280425.

Might have caused

ninja: error: '..\..\third_party\qunit\src', needed by 'remoting\unittests\qunit\src', missing and no known rule to make it

on the windows bots.

BUG=389683

Review URL: https://codereview.chromium.org/341253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280434 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoUpdate ninja to v1.5.0 on Mac, Linux32, Linux64, Windows.
thakis@chromium.org [Fri, 27 Jun 2014 22:04:30 +0000 (22:04 +0000)]
Update ninja to v1.5.0 on Mac, Linux32, Linux64, Windows.

See the bug for how these were built.

The linux binaries were built by thestig@chromium.org.
The windows binary was built by scottmg@chromium.org.
The mac binary was built by thakis@chromium.org

BUG=389683
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/339083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280425 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoFix undefined default_config_path_bak in gsutil config.
dtu@chromium.org [Fri, 27 Jun 2014 19:55:54 +0000 (19:55 +0000)]
Fix undefined default_config_path_bak in gsutil config.

This is already fixed upstream in gsutil.

BUG=None.
TEST=None.

Review URL: https://codereview.chromium.org/341833005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280386 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoHave git-gs search .gni files
jamesr@chromium.org [Fri, 27 Jun 2014 12:47:02 +0000 (12:47 +0000)]
Have git-gs search .gni files

Review URL: https://codereview.chromium.org/358903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280308 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoHave git cache bootstrap repo if repo is corrupt
hinoka@chromium.org [Thu, 26 Jun 2014 21:58:51 +0000 (21:58 +0000)]
Have git cache bootstrap repo if repo is corrupt

We're seeing fetches fail in interesting ways:
running "git fetch -v --progress origin +refs/heads/*:refs/heads/*" in "/mnt/scratch0/b_used/build/slave/cache_dir/chrome--internal.googlesource.com-chrome-src--internal"
error: object file ./objects/a1/4bd89aa4cc7d7bbad7594cba0ae73e99dbb54c is empty
error: object file ./objects/a1/4bd89aa4cc7d7bbad7594cba0ae73e99dbb54c is empty
fatal: loose object a14bd89aa4cc7d7bbad7594cba0ae73e99dbb54c (stored in ./objects/a1/4bd89aa4cc7d7bbad7594cba0ae73e99dbb54c) is corrupt
fatal: The remote end hung up unexpectedly

And then the cache becomes corrupted.  This blows the cache away if this happens.

BUG=261741

Review URL: https://codereview.chromium.org/352543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280123 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoMoved around pylint disable warning comments
martiniss@chromium.org [Thu, 26 Jun 2014 18:06:24 +0000 (18:06 +0000)]
Moved around pylint disable warning comments

BUG=

Review URL: https://codereview.chromium.org/355063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280051 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdded support for git cl upload automatic trybot determination.
martiniss@chromium.org [Thu, 26 Jun 2014 17:38:38 +0000 (17:38 +0000)]
Added support for git cl upload automatic trybot determination.

This is part of my intern project, which is detailed here:
  "https://docs.google.com/a/google.com/document/d/10bkzag1UUbtESPkEWHYaZtGMEEbCN5Zad72PuoRpwZE/edit#"

The idea is to have "git cl upload" annotate the CL description with a
flag like "CQ_TRYBOTS=...", which CQ will then look at to determine which
trybots to run the the given CL.

The CL for the change for CQ is at "https://chromereviews.googleplex.com/51757013/".

R=dpranke@google.com, iannucci@google.com
BUG=378097

Review URL: https://codereview.chromium.org/348473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280039 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd PROJECT to tools
sheyang@google.com [Wed, 25 Jun 2014 22:52:32 +0000 (22:52 +0000)]
Add PROJECT to tools

BUG=374398
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/351943004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@279843 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdded common git 'fetch' function
dnj@chromium.org [Wed, 25 Jun 2014 00:39:32 +0000 (00:39 +0000)]
Added common git 'fetch' function

Replaced multiple various invocations of 'git fetch' with calls to a common
fetch function.

BUG=373504
TEST=localtest

Review URL: https://codereview.chromium.org/327803006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@279560 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoShow an error message when the user tries to set the commit flag or add trybots to...
jrobbins@chromium.org [Tue, 24 Jun 2014 22:14:36 +0000 (22:14 +0000)]
Show an error message when the user tries to set the commit flag or add trybots to a private issue.

BUG=387088

Review URL: https://codereview.chromium.org/348933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@279514 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoIncreased timeout for rietveld lint calls.
jrobbins@chromium.org [Tue, 24 Jun 2014 19:30:42 +0000 (19:30 +0000)]
Increased timeout for rietveld lint calls.

BUG=

Review URL: https://codereview.chromium.org/342543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@279463 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdded common git 'checkout' function
dnj@chromium.org [Mon, 23 Jun 2014 22:42:51 +0000 (22:42 +0000)]
Added common git 'checkout' function

Replaced multiple various invocations of 'git checkout' with calls to a common
checkout function.

BUG=373504
TEST=localtest
R=agable@chromium.org, iannucci@chromium.org

Review URL: https://codereview.chromium.org/326153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@279207 0039d316-1c4b-4281-b951-d872f2087c98

2 months agoAdd option to gclient to ignore cache locks
hinoka@chromium.org [Mon, 23 Jun 2014 18:38:57 +0000 (18:38 +0000)]
Add option to gclient to ignore cache locks

BUG=261741

Review URL: https://codereview.chromium.org/349643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@279150 0039d316-1c4b-4281-b951-d872f2087c98