chromiumos/platform/google-breakpad.git
12 months agoRevert "change version number to the svn snapshot we synced to" 14/66014/2 master
Mike Frysinger [Fri, 16 Aug 2013 00:17:54 +0000 (20:17 -0400)]
Revert "change version number to the svn snapshot we synced to"

This reverts commit 232fb3ad52342305e55b3a1d51632a9bd52d18cc.

Now that we changed the version script to look for the svn rev in the
git log, we no longer need to modify the configure script.

BUG=None
TEST=`cbuildbot arm-generic-paladin` uprevs breakpad
CQ-DEPEND=CL:65931

Change-Id: I41d8ad9b77e57bb3293defac99a652201e85ed25
Reviewed-on: https://gerrit.chromium.org/gerrit/66014
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

15 months agogoogle-breakpad: Merge with upstream breakpad r1181 factory-4128.B factory-4290.B factory-4455.B factory-pit-4280.B factory-pit-4390.B factory-pit-4471.B factory-spring-4131.B factory-spring-4262.B firmware-falco_peppy-4389.B firmware-leon-4389.26.B firmware-pit-4482.B firmware-wolf-4389.24.B release-R29-4319.B release-R30-4537.B stabilize-4255.B stabilize-4287.B stabilize-4443.B stabilize-4512.B
Ben Chan [Sat, 11 May 2013 03:46:04 +0000 (20:46 -0700)]
google-breakpad: Merge with upstream breakpad r1181

BUG=none
TEST=Verified the following:
1. emerge google-breadpad for {x86,amd64,arm}-generic
2. cros_run_unit_tests google-breakpad for {x86,amd64}-generic
3. Run the following autotest tests:
   - logging_CrashSender
   - logging_UserCrash

Change-Id: Iff41513d46aab59884c46d01e2f1fda1b787e2d0

15 months agoCompile issue when using global string "::string". For more details take a look...
ivan.penkov@gmail.com [Sat, 11 May 2013 00:23:41 +0000 (00:23 +0000)]
Compile issue when using global string "::string".  For more details take a look at src/common/using_std_string.h.
Review URL: https://breakpad.appspot.com/577002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1181 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoFix a "set but not used" compiler warning in a test
mseaborn@chromium.org [Fri, 10 May 2013 20:58:49 +0000 (20:58 +0000)]
Fix a "set but not used" compiler warning in a test

Add a missing assertion whose absence made the test ineffective.
Make the test a little stricter too.

BUG=none
TEST="make check" to run the test + use "-Wall -Werror"

Review URL: https://breakpad.appspot.com/592003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1180 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoFix a "set but not used" compiler warning in libdisasm
mseaborn@chromium.org [Fri, 10 May 2013 15:49:23 +0000 (15:49 +0000)]
Fix a "set but not used" compiler warning in libdisasm

BUG=none
TEST=none apart from compiling with "-Wall -Werror"

Review URL: https://breakpad.appspot.com/594002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1179 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoFix following r1175: the section name is __debug_info, not .debug_info.
mark@chromium.org [Thu, 9 May 2013 21:56:18 +0000 (21:56 +0000)]
Fix following r1175: the section name is __debug_info, not .debug_info.

Review URL: https://breakpad.appspot.com/583003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1178 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoCheck in new Windows binaries.
chrisha@chromium.org [Thu, 9 May 2013 16:29:56 +0000 (16:29 +0000)]
Check in new Windows binaries.

These binaries include recent changes to pdb_source_line_writer for handling
PDBs with OMAP data. They were built using the GYP build files, MSVS 2010 and
DIA SDK 8.0.

Review URL: https://breakpad.appspot.com/584002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1177 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoMac: Fix more errors from clang to get crash_report.xcodeproj close to compiling.
thestig@chromium.org [Wed, 8 May 2013 20:24:03 +0000 (20:24 +0000)]
Mac: Fix more errors from clang to get crash_report.xcodeproj close to compiling.

R=mark@chromium.org

Review URL: https://breakpad.appspot.com/593002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1176 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoFix mac dump_syms after r1163.
thestig@chromium.org [Wed, 8 May 2013 17:41:12 +0000 (17:41 +0000)]
Fix mac dump_syms after r1163.

R=mark@chromium.org

Review URL: https://breakpad.appspot.com/592002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1175 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoNULL-check the entry in NonAllocatingMap before setting on it.
rsesek@chromium.org [Wed, 8 May 2013 16:06:33 +0000 (16:06 +0000)]
NULL-check the entry in NonAllocatingMap before setting on it.

Using just an assert will still cause a crash in a release build.

BUG=http://code.google.com/p/chromium/issues/detail?id=238757
R=mark@chromium.org

Review URL: https://breakpad.appspot.com/593003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1174 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoMake x86-64 stack walking work for Native Client minidumps
mseaborn@chromium.org [Wed, 8 May 2013 02:37:15 +0000 (02:37 +0000)]
Make x86-64 stack walking work for Native Client minidumps

For NaCl, a stack walker should ignore the top 32 bits of %rip, %rsp
and %rbp, otherwise it will try to read from %r15-extended stack
addresses and look up symbol info for %r15-extended code addresses,
which will fail.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3424
TEST=tested manually with a NaCl minidump

Review URL: https://breakpad.appspot.com/591002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1173 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoAdd MD_OS_NACL platform_id value for identifying NaCl minidumps
mseaborn@chromium.org [Mon, 6 May 2013 23:33:02 +0000 (23:33 +0000)]
Add MD_OS_NACL platform_id value for identifying NaCl minidumps

Change minidump-2-core to accept minidumps with this platform_id value
rather than rejecting them as non-Linux dumps.

Add a missing "break" for a MD_OS_PS3 case.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3424
TEST= tested with work-in-progress NaCl minidump generator

Review URL: https://breakpad.appspot.com/590002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1172 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoFix an "unused variable" compiler warning in exploitability_win.cc
mseaborn@chromium.org [Mon, 6 May 2013 23:27:28 +0000 (23:27 +0000)]
Fix an "unused variable" compiler warning in exploitability_win.cc

BUG=none
TEST=compile with "-Wall -Werror"

Review URL: https://breakpad.appspot.com/588003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1171 4c0a9323-5329-0410-9bdc-e9ce6186880e

15 months agoFix GetLoadingAddress() to work for Native Client executables
mark@chromium.org [Mon, 6 May 2013 19:53:48 +0000 (19:53 +0000)]
Fix GetLoadingAddress() to work for Native Client executables

NaCl executables have ELF program headers that look like this (for the
original NaCl x86 GCC toolchain):

Program Header:
    LOAD off    0x00010000 vaddr 0x00020000 paddr 0x00020000 align 2**16
         filesz 0x00017ce0 memsz 0x00017ce0 flags r-x
    LOAD off    0x00030000 vaddr 0x10020000 paddr 0x10020000 align 2**16
         filesz 0x00001c98 memsz 0x00001c98 flags r--
    LOAD off    0x00040000 vaddr 0x10030000 paddr 0x10030000 align 2**16
         filesz 0x000025ec memsz 0x00002b88 flags rw-

or this (for the newer NaCl ARM GCC toolchain):

Program Header:
    LOAD off    0x00010000 vaddr 0x00020000 paddr 0x00020000 align 2**16
         filesz 0x000193b0 memsz 0x000193b0 flags r-x
    LOAD off    0x00000000 vaddr 0x10020000 paddr 0x10020000 align 2**16
         filesz 0x00000978 memsz 0x00000978 flags r--
    LOAD off    0x00001000 vaddr 0x10031000 paddr 0x10031000 align 2**16
         filesz 0x00000abc memsz 0x00000fac flags rw-

Fix GetLoadingAddress() to return the start address of the first
segment, 0x20000, in these cases.  Looking at p_offset for this isn't
correct, and the first segment doesn't have p_offset == 0 here because
NaCl can't map the ELF file headers as part of the first segment
(which is for validatable code only).

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3424
TEST= check addresses in output of "dump_syms" when run on NaCl nexe

Patch by Mark Seaborn <mseaborn@chromium.org>
Review URL: https://breakpad.appspot.com/588002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1170 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoFix minidump generation from exception.
qsr@chromium.org [Fri, 3 May 2013 15:04:12 +0000 (15:04 +0000)]
Fix minidump generation from exception.
Review URL: https://breakpad.appspot.com/583002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1169 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoAdd GYP file for tools\windows\symupload.
chrisha@chromium.org [Wed, 1 May 2013 19:02:32 +0000 (19:02 +0000)]
Add GYP file for tools\windows\symupload.

This creates a GYP project file for the Windows symupload binary, allowing for
easier building. It also updates the old VC 8.0 project file to reflect recent
changes to PdbSourceLineWriter.

Review URL: https://breakpad.appspot.com/579002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1168 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoAdd explicit OMAP support to dump_syms.
chrisha@chromium.org [Wed, 1 May 2013 18:18:46 +0000 (18:18 +0000)]
Add explicit OMAP support to dump_syms.

This CL adds new utilities to common/windows for handling OMAP information in
PDB files. It then augments PdbSourceLineWriter with explicit OMAP knowledge so
that symbolization will proceed more cleanly for images whose PDB files contain
OMAP information. This makes breakpad handle OMAPped symbol files as cleanly as
WinDbg.

Review URL: https://breakpad.appspot.com/570002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1167 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoFixing a clang warning.
ivan.penkov@gmail.com [Thu, 25 Apr 2013 21:32:55 +0000 (21:32 +0000)]
Fixing a clang warning.

This is a followup change from https://breakpad.appspot.com/569002/

This prevents push_back from ever calling Realloc()
with 0 (which could happen if wasteful_vector was
constructed with size_hint set to 0, causing
allocated_ to be 0.
Review URL: https://breakpad.appspot.com/576002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1166 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoAdd MD_OS_PS3 to breakpad and exception types.
thestig@chromium.org [Thu, 25 Apr 2013 20:36:31 +0000 (20:36 +0000)]
Add MD_OS_PS3 to breakpad and exception types.

A=Jia Ji <jijia@google.com>
Original review: https://breakpad.appspot.com/571002/

Review URL: https://breakpad.appspot.com/574002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1165 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoCleanup: Use scoped_ptr where appropriate in DwarfCUToModule.
thestig@chromium.org [Wed, 24 Apr 2013 21:40:27 +0000 (21:40 +0000)]
Cleanup: Use scoped_ptr where appropriate in DwarfCUToModule.

Review URL: https://breakpad.appspot.com/572002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1164 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoAdd an option to not handle DWARF inter-compilation unit references in Linux dump_syms.
thestig@chromium.org [Wed, 24 Apr 2013 21:18:44 +0000 (21:18 +0000)]
Add an option to not handle DWARF inter-compilation unit references in Linux dump_syms.

This saves a lot of memory for dump_syms.

Review URL: https://breakpad.appspot.com/565002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1163 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoFix Clang warning regarding null pointer argument.
ivan.penkov@gmail.com [Wed, 24 Apr 2013 21:02:55 +0000 (21:02 +0000)]
Fix Clang warning regarding null pointer argument.

This warning was showing up in the Clang static analyzer in Xcode: "Null pointer argument in call to memory copy function"

Fix provided by Ian Wilkinson.
Review URL: https://breakpad.appspot.com/569002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1162 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoRewrite SimpleStringDictionary with NonAllocatingMap.
rsesek@chromium.org [Wed, 24 Apr 2013 18:15:48 +0000 (18:15 +0000)]
Rewrite SimpleStringDictionary with NonAllocatingMap.

NonAllocatingMap has a near-identical interface, but is significantly less code,
more customizable, and has storage that is POD.

BUG=http://code.google.com/p/chromium/issues/detail?id=77656

Review URL: https://breakpad.appspot.com/568002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1161 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoImprove ARM CPU info reporting.
digit@chromium.org [Wed, 24 Apr 2013 10:06:14 +0000 (10:06 +0000)]
Improve ARM CPU info reporting.

This patch improves several things for Linux/ARM:

- Better detection of the number of CPUs on the target
  device. The content of /proc/cpuinfo only matches the
  number of "online" CPUs, which varies over time with
  recent Android devices.

- Reconstruct the CPUID and ELF hwcaps values from
  /proc/cpuinfo, this is useful to better identify
  target devices in minidumps.

- Make minidump_dump display the new information
  in useful ways.

- Write a small helper class to parse /proc/cpuinfo
  and also use it for x86/64.

- Write a small helper class to parse sysfds cpu lists.

- Add a my_memchr() implementation.

- Add unit tests.

Tested on a Nexus S (1 CPU), Galaxy Nexus (2 CPUs)
and a Nexus 4 (4 CPUs).

Review URL: https://breakpad.appspot.com/540003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1160 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoCleanup: Remove duplicate wording in license headers.
thestig@chromium.org [Tue, 23 Apr 2013 23:18:39 +0000 (23:18 +0000)]
Cleanup: Remove duplicate wording in license headers.

BUG=505

Review URL: https://breakpad.appspot.com/498002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1159 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoThis change allows compiling sym_upload.cc and minidump_upload.cc using a global...
ivan.penkov@gmail.com [Tue, 23 Apr 2013 21:04:31 +0000 (21:04 +0000)]
This change allows compiling sym_upload.cc and minidump_upload.cc using a global ::string class instead of std::string.  For more details take a look at common/using_std_string.h

A few other fixes:

 - getopt() returns (int)(-1) when options are exhausted.  This was already sent out for code review by mattdr but only for sym_upload.cc (https://breakpad.appspot.com/561002/).  I'm applying the fix for both files.

 - Fixed a couple of lint warning about improper usage of white-spaces.

Thanks,
-Ivan
Review URL: https://breakpad.appspot.com/567002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1158 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoAllow option for efficient and safe opt out of in-proc dump generation for Windows...
ivan.penkov@gmail.com [Tue, 23 Apr 2013 00:47:53 +0000 (00:47 +0000)]
Allow option for efficient and safe opt out of in-proc dump generation for Windows breakpad clients.

https://breakpad.appspot.com/549002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1157 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoFix Bigcluster build error with minidump.cc after r1147.
thestig@chromium.org [Fri, 19 Apr 2013 22:05:07 +0000 (22:05 +0000)]
Fix Bigcluster build error with minidump.cc after r1147.

A=Jia Ji <jijia@google.com>
Original review: https://breakpad.appspot.com/563002/

Review URL: https://breakpad.appspot.com/564003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1156 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoGet SimpleStringDictionary compiling on Linux.
rsesek@chromium.org [Fri, 19 Apr 2013 19:32:20 +0000 (19:32 +0000)]
Get SimpleStringDictionary compiling on Linux.

BUG=http://code.google.com/p/chromium/issues/detail?id=77656

Review URL: https://breakpad.appspot.com/564002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1155 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoMove SimpleStringDictionary from common/mac/ to just common/.
rsesek@chromium.org [Thu, 18 Apr 2013 20:17:29 +0000 (20:17 +0000)]
Move SimpleStringDictionary from common/mac/ to just common/.

This also cleans up some things like the file name, trailing whitespace,
and making the test use gtest instead of sentest, since there's nothing
Mac specific about this.

BUG=https://code.google.com/p/chromium/issues/detail?id=77656

Review URL: https://breakpad.appspot.com/561003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1154 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoAdd Android ifdef to fix issue 526
ted.mielczarek@gmail.com [Thu, 18 Apr 2013 13:24:33 +0000 (13:24 +0000)]
Add Android ifdef to fix issue 526

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1153 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoFix missing result check in Mac exception handler
ted.mielczarek@gmail.com [Thu, 18 Apr 2013 12:47:08 +0000 (12:47 +0000)]
Fix missing result check in Mac exception handler
Patch by Georg Fritzsche <georg.fritzsche@googlemail.com>, R=ted at https://breakpad.appspot.com/554003/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1152 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agominidump_stackwalk should display r12 in ARM stack traces
ted.mielczarek@gmail.com [Wed, 17 Apr 2013 13:37:39 +0000 (13:37 +0000)]
minidump_stackwalk should display r12 in ARM stack traces
A=torne@google.com, R=ted, http://code.google.com/p/google-breakpad/issues/detail?id=456

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1151 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoDon't print an error when a user-set max frames limit has been reached in the stackwalker
ted.mielczarek@gmail.com [Tue, 16 Apr 2013 17:55:21 +0000 (17:55 +0000)]
Don't print an error when a user-set max frames limit has been reached in the stackwalker
Patch by Julian Seward <jseward@acm.org>, R=ted at https://bugzilla.mozilla.org/show_bug.cgi?id=859745

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1150 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoESP is zero in dumps created by CrashGenerationClient::RequestDump on i386 Linux
ted.mielczarek@gmail.com [Tue, 16 Apr 2013 17:51:10 +0000 (17:51 +0000)]
ESP is zero in dumps created by CrashGenerationClient::RequestDump on i386 Linux
Patch by Bruce Dawson <bruce.dawson@gmail.com>, R=ted at https://breakpad.appspot.com/533002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1149 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agogoogle-breakpad: Merge with upstream breakpad r1148 release-R28-4100.B stabilize-4008.0.B stabilize-4035.0.B stabilize-4068.0.B stabilize-4100.38.B stabilize-spring-4100.53.B toolchainB
Ben Chan [Mon, 15 Apr 2013 02:28:39 +0000 (19:28 -0700)]
google-breakpad: Merge with upstream breakpad r1148

BUG=none
TEST=Verified the following:
1. emerge google-breadpad for {x86,amd64,arm}-generic
2. cros_run_unit_tests google-breakpad for {x86,amd64}-generic
3. Run the following autotest tests:
   - logging_CrashSender
   - logging_UserCrash

Change-Id: I674a1a29a769641aa7e56b1169eebee41512230e

16 months agoChange MDRawSystemInfo.processor_architecture value for PPC64 to 0x8002.
thestig@chromium.org [Sat, 13 Apr 2013 02:24:36 +0000 (02:24 +0000)]
Change MDRawSystemInfo.processor_architecture value for PPC64 to 0x8002.
Review URL: https://breakpad.appspot.com/559002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1148 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoAdd PPC64 support to breakpad processor.
thestig@chromium.org [Fri, 12 Apr 2013 23:24:02 +0000 (23:24 +0000)]
Add PPC64 support to breakpad processor.

A=Jia Ji <jijia@google.com>
Original review: https://breakpad.appspot.com/557002/
Review URL: https://breakpad.appspot.com/558002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1147 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoFix build on Android - put the missing NT_GNU_BUILD_ID #define in elf_gnu_compat...
thestig@chromium.org [Wed, 10 Apr 2013 03:33:09 +0000 (03:33 +0000)]
Fix build on Android - put the missing NT_GNU_BUILD_ID #define in elf_gnu_compat.h and use it where needed.
Review URL: https://breakpad.appspot.com/554004

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1146 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoRemove auto_ptr usage in Breakpad. Also fix some lint errors.
thestig@chromium.org [Tue, 9 Apr 2013 18:58:39 +0000 (18:58 +0000)]
Remove auto_ptr usage in Breakpad. Also fix some lint errors.
Review URL: https://breakpad.appspot.com/553002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1145 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoTurn off verbose logging but keep logic for future reference for debug logging.
jessicag.feedback [Fri, 5 Apr 2013 00:53:45 +0000 (00:53 +0000)]
Turn off verbose logging but keep logic for future reference for debug logging.

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1144 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoTry to find a build-id through PT_NOTE program headers
ted.mielczarek@gmail.com [Thu, 4 Apr 2013 16:24:52 +0000 (16:24 +0000)]
Try to find a build-id through PT_NOTE program headers
A=Mike Hommey <mh@glandium.org>
R=ted at https://breakpad.appspot.com/544003/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1143 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoSupport generic Elf notes, with unit tests
ted.mielczarek@gmail.com [Thu, 4 Apr 2013 16:24:44 +0000 (16:24 +0000)]
Support generic Elf notes, with unit tests
A=Mike Hommey <mh@glandium.org>
R=ted at https://breakpad.appspot.com/546002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1142 4c0a9323-5329-0410-9bdc-e9ce6186880e

16 months agoRefactor BasicElf synth_elf unitest
ted.mielczarek@gmail.com [Thu, 4 Apr 2013 16:24:38 +0000 (16:24 +0000)]
Refactor BasicElf synth_elf unitest
A=Mike Hommey <mh@glandium.org>
R=ted at https://breakpad.appspot.com/544002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1141 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoThese are prerequisites needed for a wider effort inside Google to enable
mark@chromium.org [Wed, 3 Apr 2013 18:31:16 +0000 (18:31 +0000)]
These are prerequisites needed for a wider effort inside Google to enable
structured logging.  This is basically wrapping std::ostream within a new type.
No functional differences from this change are expected.

Patch by Ivan Penkov <ivan.penkov@gmail.com>

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1140 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoRemoving redundant calls to string::c_str().
ivan.penkov@gmail.com [Fri, 29 Mar 2013 21:37:42 +0000 (21:37 +0000)]
Removing redundant calls to string::c_str().

https://breakpad.appspot.com/539002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1139 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoRefactor file_id_unittest
ted.mielczarek@gmail.com [Fri, 29 Mar 2013 15:10:50 +0000 (15:10 +0000)]
Refactor file_id_unittest
A=Mike Hommey <mh@glandium.org>
R=ted at https://breakpad.appspot.com/543003/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1138 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoAdd tests for section headers in synth_elf unittest
ted.mielczarek@gmail.com [Fri, 29 Mar 2013 15:06:43 +0000 (15:06 +0000)]
Add tests for section headers in synth_elf unittest
A=Mike Hommey <mh@glandium.org>
R=ted at https://breakpad.appspot.com/542003/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1137 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoRefactor BasicElf synth_elf unitest
ted.mielczarek@gmail.com [Fri, 29 Mar 2013 15:06:37 +0000 (15:06 +0000)]
Refactor BasicElf synth_elf unitest
A=Mike Hommey <mh@glandium.org>
R=ted at https://breakpad.appspot.com/544002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1136 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoDefer adding sections until ELF::Finish in synth_elf
ted.mielczarek@gmail.com [Fri, 29 Mar 2013 15:06:29 +0000 (15:06 +0000)]
Defer adding sections until ELF::Finish in synth_elf
A=Mike Hommey <mh@glandium.org>
R=ted at https://breakpad.appspot.com/543002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1135 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoGet the complete linux gate mapping instead of only one page
ted.mielczarek@gmail.com [Fri, 29 Mar 2013 15:06:24 +0000 (15:06 +0000)]
Get the complete linux gate mapping instead of only one page
A=Mike Hommey <mh@glandium.org>
R=ted at https://breakpad.appspot.com/542002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1134 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoFix Windows unittest build on VC2012
ted.mielczarek@gmail.com [Fri, 29 Mar 2013 14:39:55 +0000 (14:39 +0000)]
Fix Windows unittest build on VC2012
R=mark at https://breakpad.appspot.com/539003/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1133 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoFix three unit tests on recent ARM devices.
digit@chromium.org [Thu, 21 Mar 2013 08:22:37 +0000 (08:22 +0000)]
Fix three unit tests on recent ARM devices.

Three unit tests were failing on recent ARM devices (e.g. Galaxy Nexus
or Nexus 4), while ran properly on older ones (e.g. Nexus S).

The main issue is that the instruction cache needs to be explicitely
cleared on ARM after writing machine code bytes to a malloc()-ed
page with PROT_EXEC.
Review URL: https://breakpad.appspot.com/540002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1132 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoLinux MinidumpWriter should properly set number_of_processors on ARM
ted.mielczarek@gmail.com [Tue, 12 Mar 2013 18:08:30 +0000 (18:08 +0000)]
Linux MinidumpWriter should properly set number_of_processors on ARM
R=digit at http://breakpad.appspot.com/425002

This doesn't fix this problem in all possible cases, but it makes it
slightly better in some cases, so I think that's a net positive.

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1131 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months ago Remove "library" variable
ted.mielczarek@gmail.com [Thu, 7 Mar 2013 19:02:46 +0000 (19:02 +0000)]
 Remove "library" variable
A=Thiago Farina <tfarina@chromium.org>
BUG=http://code.google.com/p/chromium/issues/detail?id=111541
R=thestig@chromium.org at https://breakpad.appspot.com/537002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1130 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agofix size types w/x32
ted.mielczarek@gmail.com [Thu, 7 Mar 2013 19:02:44 +0000 (19:02 +0000)]
fix size types w/x32
A=vapier@chromium.org R=ted at https://breakpad.appspot.com/526002/
BUG=chromium-os:36866
TEST=compiled the code for x86_64 (64bit) & x86_64 (x32)

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1129 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoProvide a ReadSymbolData API for Mac dump_syms
ted.mielczarek@gmail.com [Wed, 6 Mar 2013 20:14:34 +0000 (20:14 +0000)]
Provide a ReadSymbolData API for Mac dump_syms
R=mark at https://breakpad.appspot.com/522002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1128 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoMake OOP mac crashreporting exit after writing dump
ted.mielczarek@gmail.com [Wed, 6 Mar 2013 20:14:32 +0000 (20:14 +0000)]
Make OOP mac crashreporting exit after writing dump
R=mark at https://breakpad.appspot.com/538002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1127 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoKeeping track of modules without symbols during crash report processing.
ivan.penkov@gmail.com [Wed, 6 Mar 2013 19:32:13 +0000 (19:32 +0000)]
Keeping track of modules without symbols during crash report processing.

http://breakpad.appspot.com/534002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1126 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoAllow building symbol dumping without STABS support
ted.mielczarek@gmail.com [Wed, 6 Mar 2013 15:33:02 +0000 (15:33 +0000)]
Allow building symbol dumping without STABS support
R=mark at https://breakpad.appspot.com/536002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1125 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoAllow reading just CFI data when reading symbols
ted.mielczarek@gmail.com [Wed, 6 Mar 2013 15:32:53 +0000 (15:32 +0000)]
Allow reading just CFI data when reading symbols
R=thestig at https://breakpad.appspot.com/517002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1124 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoMinor Android fixup for symbol dumping code
ted.mielczarek@gmail.com [Wed, 6 Mar 2013 14:43:02 +0000 (14:43 +0000)]
Minor Android fixup for symbol dumping code
Patch by Julian Seward <jseward@acm.org>
R=digit at https://breakpad.appspot.com/521002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1123 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoFix some more Win32 compat issues in processor code
ted.mielczarek@gmail.com [Wed, 6 Mar 2013 14:06:52 +0000 (14:06 +0000)]
Fix some more Win32 compat issues in processor code
R=mark at https://breakpad.appspot.com/535003/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1122 4c0a9323-5329-0410-9bdc-e9ce6186880e

17 months agoUse stdint types everywhere
ted.mielczarek@gmail.com [Wed, 6 Mar 2013 14:04:42 +0000 (14:04 +0000)]
Use stdint types everywhere
R=mark at https://breakpad.appspot.com/535002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1121 4c0a9323-5329-0410-9bdc-e9ce6186880e

18 months agoWork around Windows headers #defining ERROR by renaming enum values in StackFrameSymb...
ted.mielczarek@gmail.com [Mon, 4 Mar 2013 15:42:50 +0000 (15:42 +0000)]
Work around Windows headers #defining ERROR by renaming enum values in StackFrameSymbolizer
Patch by Julian Seward <jseward@acm.org>, R=ted

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1120 4c0a9323-5329-0410-9bdc-e9ce6186880e

18 months agoRemove unnecessary #include unistd.h
ted.mielczarek@gmail.com [Fri, 1 Mar 2013 17:33:25 +0000 (17:33 +0000)]
Remove unnecessary #include unistd.h
(no review, trivial change)

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1119 4c0a9323-5329-0410-9bdc-e9ce6186880e

18 months agoMake CompareStringPtrs::operator() a const method
ted.mielczarek@gmail.com [Thu, 28 Feb 2013 19:52:51 +0000 (19:52 +0000)]
Make CompareStringPtrs::operator() a const method
Patch by Julian Seward <jseward@acm.org>, R=ted

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1118 4c0a9323-5329-0410-9bdc-e9ce6186880e

18 months agoAdd missing "using std::sort" to dwarf_cu_to_module.cc.
ted.mielczarek@gmail.com [Thu, 28 Feb 2013 19:52:37 +0000 (19:52 +0000)]
Add missing "using std::sort" to dwarf_cu_to_module.cc.
Patch by Julian Seward <jseward@acm.org>, R=ted

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1117 4c0a9323-5329-0410-9bdc-e9ce6186880e

18 months agoFix DumpSymbols error message when using multiple debug_dirs, followup from r1102.
ted.mielczarek@gmail.com [Wed, 27 Feb 2013 16:43:26 +0000 (16:43 +0000)]
Fix DumpSymbols error message when using multiple debug_dirs, followup from r1102.
Patch by Julian Seward <jseward@acm.org>, R=ted

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1116 4c0a9323-5329-0410-9bdc-e9ce6186880e

18 months agosize_limit_ member of minidump_descriptor ignored in copy constructor
ted.mielczarek@gmail.com [Thu, 14 Feb 2013 14:03:54 +0000 (14:03 +0000)]
size_limit_ member of minidump_descriptor ignored in copy constructor
Patch by Avishai Hendel <avish@fb.com>, R=mkrebs at https://codereview.appspot.com/7305060/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1114 4c0a9323-5329-0410-9bdc-e9ce6186880e

18 months agoMake MmapWrapper a little less silly
ted.mielczarek@gmail.com [Thu, 14 Feb 2013 14:03:51 +0000 (14:03 +0000)]
Make MmapWrapper a little less silly
R=thestig at https://breakpad.appspot.com/527002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1113 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoFix some issues with -Werror=sign-compare on Android builds
ted.mielczarek@gmail.com [Fri, 1 Feb 2013 19:20:34 +0000 (19:20 +0000)]
Fix some issues with -Werror=sign-compare on Android builds
R=digit at https://breakpad.appspot.com/524002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1110 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months ago Add API to find out if there is crash reports to send to the server.
qsr@chromium.org [Fri, 1 Feb 2013 09:49:09 +0000 (09:49 +0000)]
 Add API to find out if there is crash reports to send to the server.
Review URL: https://breakpad.appspot.com/518002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1109 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agominidump_stackwalk: Show argument registers for ARM stack traces
ted.mielczarek@gmail.com [Thu, 31 Jan 2013 19:49:03 +0000 (19:49 +0000)]
minidump_stackwalk: Show argument registers for ARM stack traces
Patch by Michael Krebs <mkrebs@chromium.org>, R=ted at https://breakpad.appspot.com/497002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1108 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoRemove a call to new[] from WriteDSODebugStream
ted.mielczarek@gmail.com [Thu, 31 Jan 2013 16:15:55 +0000 (16:15 +0000)]
Remove a call to new[] from WriteDSODebugStream
R=mark at https://breakpad.appspot.com/523002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1107 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoInclude the compilation directory for FILE entries, making them absolute instead...
ted.mielczarek@gmail.com [Wed, 23 Jan 2013 18:01:28 +0000 (18:01 +0000)]
Include the compilation directory for FILE entries, making them absolute instead of relative
A=Ryan Sleevi <rsleevi@chromium.org> R=mark,ted at https://breakpad.appspot.com/385001/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1106 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoPrint the correct return address, even on architectures where StackFrame::instruction...
jimblandy [Tue, 22 Jan 2013 22:38:41 +0000 (22:38 +0000)]
Print the correct return address, even on architectures where StackFrame::instruction is offset.

a=bruce.dawson, r=jimblandy

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1105 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoFix remaining processor/scoped_ptr.h references for reals.
thestig@chromium.org [Tue, 22 Jan 2013 18:49:58 +0000 (18:49 +0000)]
Fix remaining processor/scoped_ptr.h references for reals.
Review URL: https://breakpad.appspot.com/516003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1104 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoFix remaining processor/scoped_ptr.h references after r1096.
thestig@chromium.org [Tue, 22 Jan 2013 17:20:42 +0000 (17:20 +0000)]
Fix remaining processor/scoped_ptr.h references after r1096.
Review URL: https://breakpad.appspot.com/516002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1103 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoMake DumpSymbols methods take a vector of debug_dirs
ted.mielczarek@gmail.com [Tue, 22 Jan 2013 13:36:39 +0000 (13:36 +0000)]
Make DumpSymbols methods take a vector of debug_dirs
r=thestig at https://breakpad.appspot.com/512002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1102 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agochange version number to the svn snapshot we synced to 44/41544/2 factory-spring-3842.B firmware-spring-3824.4.B firmware-spring-3824.55.B firmware-spring-3824.84.B firmware-spring-3824.B firmware-spring-3833.B release-R26-3701.B release-R27-3912.B stabilize-3658.0.0 stabilize-3701.30.0 stabilize-3701.30.0b stabilize-3701.46.B stabilize-3701.81.B stabilize-3881.0.B stabilize-3912.79.B stabilize-bluetooth-smart toolchain-3701.42.B toolchainA
Mike Frysinger [Thu, 17 Jan 2013 16:20:14 +0000 (11:20 -0500)]
change version number to the svn snapshot we synced to

This makes it a bit easier to track what svn version we're at.

BUG=None
TEST=None

Change-Id: I3e433aa6ba44ccc09c066fc9257b36398414dcd4
Reviewed-on: https://gerrit.chromium.org/gerrit/41544
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
19 months agoRemove <(library) usage from gyp files.
thestig@chromium.org [Sat, 19 Jan 2013 00:19:16 +0000 (00:19 +0000)]
Remove <(library) usage from gyp files.

BUG=chromium:111541

Patch by Thiago Farina <tfarina@chromium.org>.
Original code review: https://breakpad.appspot.com/513002/
Review URL: https://breakpad.appspot.com/515002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1101 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoProvide a ReadSymbolData function to get symbol data in a Module instead of just...
ted.mielczarek@gmail.com [Fri, 18 Jan 2013 20:24:16 +0000 (20:24 +0000)]
Provide a ReadSymbolData function to get symbol data in a Module instead of just serializing it
R=thestig at https://breakpad.appspot.com/510002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1099 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoDon't make MmapWrapper's destructor assert
ted.mielczarek@gmail.com [Fri, 18 Jan 2013 13:51:05 +0000 (13:51 +0000)]
Don't make MmapWrapper's destructor assert
R=mark at https://breakpad.appspot.com/511002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1098 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoFix a couple of warnings in stack_frame_symbolizer code
ted.mielczarek@gmail.com [Fri, 18 Jan 2013 13:40:40 +0000 (13:40 +0000)]
Fix a couple of warnings in stack_frame_symbolizer code
R=SiyangXie at https://breakpad.appspot.com/509003/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1097 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoupdate OWNERS 33/41533/2
Mike Frysinger [Thu, 17 Jan 2013 15:57:43 +0000 (10:57 -0500)]
update OWNERS

Mike is taking over for Mike.

BUG=None
TEST=None

Change-Id: I6fa771383f505d144cb3bb0113d50c822768816c
Reviewed-on: https://gerrit.chromium.org/gerrit/41533
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
19 months agoMove scoped_ptr.h to common
ted.mielczarek@gmail.com [Thu, 17 Jan 2013 15:53:56 +0000 (15:53 +0000)]
Move scoped_ptr.h to common
R=mark at https://breakpad.appspot.com/509002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1096 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoExceptionHandler::HandleSignal
mark@chromium.org [Mon, 14 Jan 2013 18:53:18 +0000 (18:53 +0000)]
ExceptionHandler::HandleSignal
(https://code.google.com/searchframe#OAMlx_jo-ck/src/breakpad/src/client/linux/handler/exception_handler.cc&exact_package=chromium&q=SI_USER&type=cs&l=389)
requires si_pid to be equal to getpid() for SI_USER signals.

This is a patch by Lei Zhang (thestig@chromium.org) that fixes the issue with
Chrome+ASan being unable to upload the crash dump to the crash server when the
seccomp sandbox is on.

Patch by Alexander Potapenko <glider@chromium.org>
Review URL: https://codereview.appspot.com/7066068/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1095 4c0a9323-5329-0410-9bdc-e9ce6186880e

19 months agoDWARF can store DW_AT_high_pc as either an address or a constant. In the latter
jimblandy [Tue, 8 Jan 2013 02:14:44 +0000 (02:14 +0000)]
DWARF can store DW_AT_high_pc as either an address or a constant. In the latter
case it's the length of the function. breakpad always treats it as an address.

a=mattdr, r=jimb

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1094 4c0a9323-5329-0410-9bdc-e9ce6186880e

20 months ago Fix typo.
qsr@chromium.org [Mon, 17 Dec 2012 14:48:45 +0000 (14:48 +0000)]
 Fix typo.
Review URL: https://breakpad.appspot.com/506002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1093 4c0a9323-5329-0410-9bdc-e9ce6186880e

20 months ago Updating BreakpadController to allow start and stop being nop.
qsr@chromium.org [Mon, 17 Dec 2012 14:20:13 +0000 (14:20 +0000)]
 Updating BreakpadController to allow start and stop being nop.

 When BreakpadController is already started or stopped, trying to restart it or
restopping it will now be no-op instead of asserting.
Review URL: https://breakpad.appspot.com/505002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1092 4c0a9323-5329-0410-9bdc-e9ce6186880e

20 months agoRemove dead code.
mark@chromium.org [Wed, 12 Dec 2012 04:02:58 +0000 (04:02 +0000)]
Remove dead code.

Patch by Rafael Espindola <rafael.espindola@gmail.com>

Review URL: http://breakpad.appspot.com/502003/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1091 4c0a9323-5329-0410-9bdc-e9ce6186880e

20 months agoFix minidump size limit used for MinidumpSizeLimit unittest
mkrebs@chromium.org [Wed, 12 Dec 2012 02:30:09 +0000 (02:30 +0000)]
Fix minidump size limit used for MinidumpSizeLimit unittest

If the stack sizes for threads in the MinidumpSizeLimit test are too big,
then subtracting 64KB from the normal minidump file size is not enough to
trigger the size-limiting logic.  Instead of basing the arbitrary limit off
of the normal file size, make it relative to the 8KB stack size the logic
assumes.

BUG=google-breakpad:510
TEST=Ran unittests
Review URL: https://breakpad.appspot.com/504002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1090 4c0a9323-5329-0410-9bdc-e9ce6186880e

20 months agoAllow the Mac and iOS Breakpad clients to build without exceptions when the C++ stand...
mark@chromium.org [Tue, 11 Dec 2012 13:46:41 +0000 (13:46 +0000)]
Allow the Mac and iOS Breakpad clients to build without exceptions when the C++ standard library is not provided by libstdc++. libc++, for example, does
not provide its own try and catch replacement macros when exceptions are
disabled.

BUG=509
Review URL: https://breakpad.appspot.com/503002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1089 4c0a9323-5329-0410-9bdc-e9ce6186880e

20 months agoThe Google-breakpad processor rejects (ignores) context records that lack CPU type...
ivan.penkov@gmail.com [Sat, 8 Dec 2012 03:18:52 +0000 (03:18 +0000)]
The Google-breakpad processor rejects (ignores) context records that lack CPU type information in their context_flags fields.  Such context records can be valid (e.g. contexts captured by ::RtlCaptureContext).

http://code.google.com/p/google-breakpad/issues/detail?id=493

http://breakpad.appspot.com/500002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1088 4c0a9323-5329-0410-9bdc-e9ce6186880e

20 months agoExplicitly include unistd.h for getpagesize().
mark@chromium.org [Fri, 7 Dec 2012 21:31:00 +0000 (21:31 +0000)]
Explicitly include unistd.h for getpagesize().

Patch by Nico Weber <thakis@chromium.org>

Review URL: https://breakpad.appspot.com/502002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1087 4c0a9323-5329-0410-9bdc-e9ce6186880e

20 months agoAllow StackwalkerARM to scan much farther to find the caller of the context frame
ted.mielczarek@gmail.com [Tue, 4 Dec 2012 19:30:31 +0000 (19:30 +0000)]
Allow StackwalkerARM to scan much farther to find the caller of the context frame
R=jimb at https://breakpad.appspot.com/501002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1086 4c0a9323-5329-0410-9bdc-e9ce6186880e

21 months ago Add assertion on initialization sequence.
qsr@chromium.org [Wed, 28 Nov 2012 17:04:52 +0000 (17:04 +0000)]
 Add assertion on initialization sequence.

 The order at which to call the controller methods is:
1) Any method that change the configuration_ field
2) start
3) Any other method

 This change adds assertion that it is done correctly.
Review URL: https://breakpad.appspot.com/499003

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1085 4c0a9323-5329-0410-9bdc-e9ce6186880e

21 months agogoogle-breakpad: Merge with upstream breakpad r1084 factory-3536.B release-R25-3428.B stabilize-3428.110.0 stabilize-3428.149 stabilize-3428.149.B stabilize-3428.193 stabilize2 toolchain-3428.65.B
Ben Chan [Sun, 25 Nov 2012 06:17:50 +0000 (22:17 -0800)]
google-breakpad: Merge with upstream breakpad r1084

BUG=none
TEST=Verified the following:
1. emerge google-breadpad for {x86,amd64,arm}-generic
2. cros_run_unit_tests google-breakpad for {x86,amd64}-generic
3. Run the following autotest tests:
   - logging_CrashSender
   - logging_UserCrash

Change-Id: I75185b12fe5f9bf0784b32505eeb812ea057dcec

21 months agoFix unused variable warning in optimized build (fix proveded by Matthew Riley)
ivan.penkov@gmail.com [Wed, 21 Nov 2012 01:38:58 +0000 (01:38 +0000)]
Fix unused variable warning in optimized build (fix proveded by Matthew Riley)

http://breakpad.appspot.com/499002/

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1084 4c0a9323-5329-0410-9bdc-e9ce6186880e