summary |
shortlog | log |
commit |
commitdiff |
tree
first ⋅ prev ⋅ next
Toni Barzic [Wed, 12 Jun 2013 23:18:45 +0000 (16:18 -0700)]
Get rid of image_burner_tester
and while here, fix two missing returns.
BUG=chromium:221781
TEST=image burner unittests; verified chrome://imageburner not broken
Change-Id: Ie185d7c692b2da4584954953ab4b681c487c3415
Reviewed-on: https://gerrit.chromium.org/gerrit/58459
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Tested-by: Toni Barzic <tbarzic@chromium.org>
Gaurav Shah [Sun, 24 Mar 2013 22:55:50 +0000 (15:55 -0700)]
imageburner: Calculate gmock/gtest library dependencies programatically
(gmock/gtest doesn't generate pkg-config metadata, calculating lib
dependencies this way makes it easier to upgrade gmock/gtest packages.)
BUG=chromium:211445
TEST=build and run tests for package using gtest 1.6
Change-Id: I11e552297e5d5b99ee8387b0388b1f51ffb0d616
Reviewed-on: https://gerrit.chromium.org/gerrit/46421
Reviewed-by: <tbarzic@google.com>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Tested-by: Gaurav Shah <gauravsh@chromium.org>
Commit-Queue: Gaurav Shah <gauravsh@chromium.org>
Chris Masone [Wed, 27 Feb 2013 19:07:03 +0000 (11:07 -0800)]
Build against libchrome-180609
BUG=chromium-os:38932
TEST=build, unit tests
STATUS=Fixed
Change-Id: Ic3edabfcd1d1486edd497e58baca01eae90c72c4
Reviewed-on: https://gerrit.chromium.org/gerrit/44201
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>
Yunlian Jiang [Wed, 2 May 2012 18:07:47 +0000 (11:07 -0700)]
Add unistd.h to make gcc 4.7 can compile
BUG=None
TEST=compile pass
Change-Id: I6353902cbdffc3397b5c5a3eafac667481514bbf
Reviewed-on: https://gerrit.chromium.org/gerrit/21649
Reviewed-by: <tbarzic@google.com>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Mike Frysinger [Wed, 11 Apr 2012 18:49:44 +0000 (14:49 -0400)]
update to newer libbase
BUG=chromium-os:25872
TEST=`emerge-x86-alex chromeos-imageburner` works
TEST=`cros_run_unit_tests --board=x86-alex -p chromeos-imageburner` passed
Change-Id: I3ad0704cdc893e40c3ced494b1edfb49b7cf822d
Reviewed-on: https://gerrit.chromium.org/gerrit/20009
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Elly Jones [Fri, 6 Apr 2012 19:23:00 +0000 (15:23 -0400)]
[image-burner] add OWNERS
TEST=None
BUG=chromium-os:22007
Change-Id: Idfb7ee235256d7b8bd18e2d46ec2cd6917f779b2
Signed-off-by: Elly Jones <ellyjones@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/19771
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Mike Frysinger [Thu, 8 Mar 2012 19:13:19 +0000 (14:13 -0500)]
convert to SLOT-ed libbase
This includes a couple of fixes:
- use the right compiler flag names
- execute pkg-config twice total, and not once per compile
- build against SLOT-ed libbase
- drop link info that was just for libbase as that handles
things all by itself now without bothering external users
BUG=chromium-os:16623
TEST=`emerge-x86-alex chromeos-imageburner` works
TEST=`cros_run_unit_tests --board x86-alex -p chromeos-imageburner` works
Change-Id: I51680c036d14eb9eac14b4fc615be5deb6b941ea
Reviewed-on: https://gerrit.chromium.org/gerrit/17600
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Elly Jones [Wed, 18 Jan 2012 22:21:36 +0000 (17:21 -0500)]
[imageburner] refactor makefile
Refactor the Makefile to reduce dummy variable use, generally clean it up. Also,
use libchromeos.pc instead of hardcoding library dependencies.
BUG=chromium-os:24959
TEST=build
Change-Id: I57c612f2b4903f1e63795dad2af7b3603238bc0c
Signed-off-by: Elly Jones <ellyjones@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/14404
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Ryo Hashimoto [Tue, 17 Jan 2012 12:58:32 +0000 (21:58 +0900)]
Fix mulfunctioning signal ratio limit.
Limit by amount instead of number of calls.
BUG=chromium-os:25125
TEST=gmerge chromeos-imageburn
Change-Id: Ib26e15838a2453ff61361290b9f0ba298924d9b0
Reviewed-on: https://gerrit.chromium.org/gerrit/14283
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
tbarzic [Tue, 21 Jun 2011 20:34:26 +0000 (13:34 -0700)]
Changing BurnWriter Open function so it fails if the file we are opening does not exist
Previously, target file would be created if it didn't exist.
Also, for both BurnWriter and BurnReader, in Open function we now check if they
had previously opened file. We close the file if that is the case.
BUG=None
TEST=Run image_burner_tester with no device attached and check it fails.
var/log/image_burner.log should contain ERROR:
Couldn't open target path /dev/sdb: no souch path or directory (or something similar).
Change-Id: Iea2e97a46fb5f6ba553be8d43c5e82d330f0e335
Reviewed-on: http://gerrit.chromium.org/gerrit/2936
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Tested-by: Toni Barzic <tbarzic@chromium.org>
tbarzic [Fri, 10 Jun 2011 03:27:58 +0000 (20:27 -0700)]
Refactoring image burn service and adding some unittests.
Mostly extracting existing logic to separate interfaces:
FileWriter, FileReader, SignalSender
Also, we don't asume that boot device is on /dev/sda
TEST=Run unittests for imageburner;
On ChromeOS: /usr/sbin/image_burner_tester (needs root device to be on sda,
and a removable device on sdb (which gets destroyed)).
BUG=chromium-os:16318
Change-Id: I58d4191ddb3c793cd2ca840ed533c00187e33e26
Reviewed-on: http://gerrit.chromium.org/gerrit/2705
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Tested-by: Toni Barzic <tbarzic@chromium.org>
tbarzic [Thu, 12 May 2011 22:48:25 +0000 (15:48 -0700)]
Making imageburn service async + removing unmounting + nicer error setting
BUG=chromium-os:15322,chromium-os:12226
TEST=Make sure imageburner works, insert removable device after
reboot and run ./usr/sbin/image_burner_tester from shell
(this will erase your device)
Change-Id: I03b737ae7439e71cb2fb98f576e5555a1fb8eaf5
Reviewed-on: http://gerrit.chromium.org/gerrit/896
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Tested-by: Toni Barzic <tbarzic@chromium.org>
Chris Masone [Thu, 12 May 2011 22:43:32 +0000 (15:43 -0700)]
[image-burner] Roll forward to new libchrome
BUG=chromium-os:14304
TEST=build, unit tests
Change-Id: I9b32600077aae9c0154cabfe3241443da73b882a
Reviewed-on: http://gerrit.chromium.org/gerrit/818
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Steven Bennetts [Wed, 23 Feb 2011 23:37:11 +0000 (15:37 -0800)]
Move lbase after lcrosapi.
crosapi now depends on base for Time::Now().
Change-Id: I3b3df169b028455c71bf6a815ae8bb7d6bc788c1
BUG=none
TEST=make sure image-burner builds on all platforms.
Review URL: http://codereview.chromium.org/6551022
Achuith Bhandarkar [Tue, 25 Jan 2011 22:31:29 +0000 (14:31 -0800)]
Use chromeos::IsBootDevicePath.
Cleanup.
BUG=chromium-os:6788
TEST=none
Change-Id: I7de901f3e00c2c35bfcf78eacda4185f07b81dec
Review URL: http://codereview.chromium.org/6357012
Achuith Bhandarkar [Thu, 21 Oct 2010 00:29:30 +0000 (17:29 -0700)]
Fix security issue with imageburn service.
Rename UnmountPartition to UnmountAndValidatePartition.
BurnImageTimeoutCallback should be private.
Rewrite UnmountPartition to ensure that target destination is a valid removable partition before allowing the burn.
Handle the case where the USB drive is unpartitioned.
Call FreeMountStatus to fix a minor leak.
BUG=7019
TEST=image_burner_tester
Change-Id: I6c846e6614a0447f88c326843d5a2462fffbfab6
Review URL: http://codereview.chromium.org/3735007
Satoru Takabayashi [Fri, 8 Oct 2010 03:31:45 +0000 (12:31 +0900)]
Remove ownership of org.chromium.ImageBurner from chronos.
chronos should not own the service.
Change-Id: I4a23caab5b4fafc6b1cb9584cd714a7e87446954
BUG=chromium-os:7187
TEST=sudo gmerge chromeos-imageburner; reboot; confirmed that chrome://imageburner worked as before.
Review URL: http://codereview.chromium.org/3582011
Ken Mixter [Wed, 15 Sep 2010 01:11:16 +0000 (18:11 -0700)]
Add inherit-review-settings-ok
Change-Id: I8b85420a5dab2571d730cb2fde4160e9f330e2c5
Remove -lcrash
Change-Id: I1734fee6bd98e3e9a216ddd759f217e0258d38ff
BUG=5870
TEST=build_packages
Review URL: http://codereview.chromium.org/3426003
Toni Barzic [Fri, 20 Aug 2010 00:44:24 +0000 (17:44 -0700)]
Dbus service for burning image to usb key
TEST: Download chromeos image (in .gz format ) to location home/chronos/Downloads/chromeos_image/chromeos_image.bin.gz
Run application /usr/sbin/image_burner_tester.
This should burn downloaded image to USB key on /dev/sdb (all information on the key will be lost).
During burning progress information should be displayed.
Review URL: http://codereview.chromium.org/3015065
J. Richard Barnette [Thu, 5 Aug 2010 21:13:48 +0000 (14:13 -0700)]
Add LICENSE file
Zelidrag Hornung [Sat, 31 Jul 2010 00:29:56 +0000 (17:29 -0700)]
initial repo