login: Make Chrome log external-display-related info.

This enables VLOG(1) for *output_configurator* to help debug
reports of issues related to external displays.

BUG=none
TEST=manual

Change-Id: Ifd07a181bc3a47ea9c0fd7dda622451b6927b86f
Reviewed-on: https://gerrit.chromium.org/gerrit/56271
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>

Move ui-related upstart jobs to login_manager repo

These should live next to the code they manage.  This facilitates
extracting a whole system daemon from a build using USE flags.

BUG=chromium:242234
TEST=building this package should still work, but not install these files.

Change-Id: I34c627aed6d9b3d2ec28185f73a65ce88b0991c2
Reviewed-on: https://gerrit.chromium.org/gerrit/55818
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Use correct name for RetrieveActiveSessions in dbus config

The DBus policy was broken, because I used the wrong name
for the new method I added.  This led to Chrome being unable
to call RetrieveActiveSessions.

BUG=chromium:239830
TEST=start a session, run dbus-send from the command line as the chronos user.

Change-Id: Iab84b17bf92b4046acc74bc4889e9416f190cf87
Reviewed-on: https://gerrit.chromium.org/gerrit/55765
Reviewed-by: Nikita Kostylev <nkostylev@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Add --login-profile flag when restarting browser after crash

This is actually important when the (newly added) --multi-profiles
flag is passed to the session manager.  When that flag is not specified,
the session_manager needs to maintain the old behavior of passing
--login-profile=user.

If --multi-profiles is not specified, when restarting the browser
after a crash, the session manager will append two flags to the
browser command line:
   --login-user=<user@email> --login-profile=user

If --multi-profiles _is_ specified, the session manager will do the following:
1) Add --multi-profiles to the browser command line
2) When restarting the browser after a crash, the session manager will append
   two flags to the browser command line:
   --login-user=<user@email> --login-profile=<sanitized user name>

BUG=chromium:235181
TEST=unit
TEST=suite:smoke

Change-Id: Ia00f42e1d1f1203b6147a5dd31ff6111de57944a
Reviewed-on: https://gerrit.chromium.org/gerrit/50511
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

Removed the old user policy DBus calls.

These calls have been obsoleted by new variants that include the
username as a parameter.

BUG=chromium:187482
TEST=unit tests are green; manually verified on a VM image that user
policy still works.

Change-Id: Ic09bcebb96214772f16997b39d7688aa8ff63d1d
Reviewed-on: https://gerrit.chromium.org/gerrit/50450
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Reviewed-by: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>

Add RetrieveActiveSessions DBus method

RetriveActiveSessions() returns a dictionary of currently
attached user sessions, mapping username to sanitized username
(a.k.a. user hash).

BUG=chromium:239830
TEST=unit

Change-Id: I315ee1cecea7c8af6df9968b569a084381ea9167
Reviewed-on: https://gerrit.chromium.org/gerrit/50894
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

Enable session_manager to address per-user NSSDBs

Per-user DB handles are stored in each user's UserSession object
upon StartSession(), and used to scope owner key generation and lookup to
the appropriate user.

CQ-DEPEND=I912d3ded053a7f0f41c604f5ffef15477d634017
CQ-DEPEND=CL:50071

BUG=chromium:235179
TEST=unit tests
TEST=new autotests login_MultipleSessions and login_SameSessionTwice
TEST=login_OwnershipTaken login_RemoteOwnership login_OwnershipRetaken  login_OwnershipNotRetaken login_OwnershipApi login_UserPolicyKeys
TEST=suite:smoke
STATUS=Fixed

Change-Id: I5ee9fb18e1f8c1a933b899acc62618323f2df9bf
Reviewed-on: https://gerrit.chromium.org/gerrit/48428
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Enable Chrome side audio routing.

Enable the flag that tells chrome it is responsible for decisions
about where to route audio.

CQ-DEPEND=CL:49812
BUG=chromium:175798
TEST=plug/unplug audio devices and check that Chrome is routing audio
correctly

Change-Id: Ifa8f15c9cf5e4865f39c3c07cf076641943a7a0e
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/49921
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>

session_manager: Handle new-style device-local account IDs.

Update session_manager after deprecation and rename of the
DeviceLocalAccountInfoProto.id field and introduction of the account_id
and type fields. Note that this will only compile after protofiles has
been rolled to protofiles-0.0.1-r14.ebuild.

BUG=chromium:216359
TEST=unit tests
CQ-DEPEND=CL:50170

Change-Id: Ia1aa3facd699443cebd88a756d44f9b0dc0fb986
Reviewed-on: https://gerrit.chromium.org/gerrit/50169
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>

Enable login_manager::NssUtil to support per-user NSS DBs.

Add support for explicit NSS DB paths to login_manager::NssUtil in
order to support per-user NSS DBs.

Since upstream is not looking to change RSAPrivateKey::CreateSensitive()
and RSAPrivateKey::FindPublicKeyInfo() to support per-DB operations,
move the additional logic to support these into login_manager::NssUtil
as well.

CQ-DEPEND=CL:50071

BUG=chromium:221770
TEST=unit
TEST=suite:smoke

Change-Id: I20836238e9e32dac8e8d930a66f5a78bda704963
Reviewed-on: https://gerrit.chromium.org/gerrit/50073
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Added multi-profile user-policy DBus calls.

Introduced StorePolicyForUser and RetrievePolicyForUser calls,
which are the multi-profile version of StoreUserPolicy and
RetrieveUserPolicy. These allow storing and retrieving user policy for
more than one user.

The old StoreUserPolicy and RetrieveUserPolicy calls will be removed
once Chrome is updated to use the new ones.

BUG=chromium:187482
TEST=unit tests are green; manually verified on a VM image that user
policy still works.

Change-Id: Ib748e2d59150034f4caa882ca01caf86eddbc9d4
Reviewed-on: https://gerrit.chromium.org/gerrit/48932
Tested-by: Joao da Silva <joaodasilva@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>

Fixed NetworkPortalDetector logging.

As NetworkPortalDetector was split to NetworkPortalDetectorStub and NetworkPortalDetectorImpl, module name in vmodules need to be fixed.

BUG=chromium:170104
TEST=none

Change-Id: I6ceda4b2e9b6ee7f75b85c2121e9a00ce12628d2
Reviewed-on: https://gerrit.chromium.org/gerrit/50167
Reviewed-by: Yuri Gorshenin <ygorshenin@chromium.org>
Tested-by: Yuri Gorshenin <ygorshenin@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Yuri Gorshenin <ygorshenin@chromium.org>

[login_manager] Remove --enable-impl-side-painting flag.

BUG=chromium:178317
TEST=local build

Change-Id: Ied01efa68959701a943eec2be344713a53fab8c9
Reviewed-on: https://gerrit.chromium.org/gerrit/50047
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>

Add notion of "user sessions" to session_manager

To support multiprofile, the session manager will need to be able to keep
track of multiple user sessions at the same time.  This CL introduces a
UserSession structure to store pertinent data, and stores a map of username
to UserSession that's updated upon each call to StartSession().

This CL does NOT make multiprofile work correctly for everything.  Device
Ownership issues are not sorted out, and many operations that currently
only make sense inside a user session barf if multiple sessions have been
started.

BUG=chromium:235179
TEST=unit
TEST=suite:smoke
TEST=login_*Ownership*

Change-Id: Ib295a562735076fde84b8ad0d05e81bf6035fa23
Reviewed-on: https://gerrit.chromium.org/gerrit/50040
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Joao da Silva <joaodasilva@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Honor new guest 'magic string' in session_manager

We're standardizing around using '' as the name for the guest user, so
make StartSession() accept that as well.

BUG=chromium:237815
TEST=unit
TEST=login_CryptohomeIncognitoMounted

Change-Id: Ida8abe323a7be3ee5f69c56d2df949553aa6f84a
Reviewed-on: https://gerrit.chromium.org/gerrit/50037
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Reviewed-by: Nikita Kostylev <nkostylev@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Remove superfluous check for user nssdb existence

Some time ago, we ensured that all cryptohomes were pre-populated with
an NSSDB at creation time.  As such, this logic to check if one exists
before trying to use it is now redundant.

BUG=None
TEST=unit
TEST=suite:smoke

Change-Id: I892e09fb5f71c400964daab9a270b1bcad316d8c
Reviewed-on: https://gerrit.chromium.org/gerrit/49735
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Use one NssUtil instance, owned by SessionManagerService

This removes the last remnants of the factory pattern used to allow
any class to instantiate an NssUtil at any time, which was kinda awkward
anyhow.

BUG=chromium:235197
TEST=unit
STATUS=Fixed

Change-Id: I68ca763966693d41d51161989c452d03dfe9cb97
Reviewed-on: https://gerrit.chromium.org/gerrit/49115
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

Use a single KeyGenerator, owned by SessionManagerService

Code in SessionManagerService is written assuming that there's only
one KeyGenerator object in use by the process, while the reality is
that we have one used when mitigating the loss of an owner keypair and
another used when generating an owner keypair for the first time.

Fix this up so that there's only one.

BUG=chromium:235185
TEST=unit
TEST=login_OwnershipRetaken, login_OwnershipTaken
STATUS=Fixed

Change-Id: Ida69cc03ca2cf08856c69491dc9f527f69f5e4dd
Reviewed-on: https://gerrit.chromium.org/gerrit/49097
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

Remove username payload from SessionStateChanged

The SessionStateChanged signal and RetrieveSessionState method
shouldn't report what user's session has started.  This data
isn't used, and reporting it will only become more complicated
in a multiprofile world.

The signature of RetrieveSessionState is changed in this CL
because it only has one caller, and the CL to change the
callsite will go in at the same time.

CQ-DEPEND=CL:48958
CQ-DEPEND=CL:48960
BUG=chromium:234763
TEST=unit
TEST=with above CLs, watch powerd logs while starting/ending sessions, and restarting powerd.
TEST=with above CLs, run the following autotests:
   - platform_CrosDisksDBus
   - platform_CrosDisksArchive
   - platform_CrosDisksFilesystem

Change-Id: Ic7636e8b9f6e5da35d5e7aa23114533869f9a604
Reviewed-on: https://gerrit.chromium.org/gerrit/48972
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

The screen should be 'locked' when the lock process begins

The session_manager handles browser crashes while the screen is locked
specially, in that it ends the user session instead of restarting the
browser.  This is to keep user data safe; the user has indicated that
she wants someone to have to reauthenticate to see her stuff, and if a
crash happens while the screen is locked and we just restart things,
we'd be violating that.

The old behavior was to trigger that behavior only if we'd succeeded
in putting the lock screen up.  Instead, we should trigger the behavior
as soon as we know the user asked for screen lock.

BUG=chromium:233827
TEST=unit

Change-Id: Icfadce9c51f83c29963cab93aa66781ba1aa57a5
Reviewed-on: https://gerrit.chromium.org/gerrit/48964
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>

[login_manager] Increase default tile size to 512x512 on hi-dpi devices.

BUG=chromium:178317
TEST=local build, tested on link

Change-Id: Iae99b69a82d2c77a5e321efd61e0a956c7d96c49
Reviewed-on: https://gerrit.chromium.org/gerrit/48899
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>

Remove 'OVERRIDE' from non virtual function.

BUG=chromium:233393
TEST=CXXFLANGS="-clang" FEATURES="test" emerge-lumpy chromeos-login
     passes

Change-Id: I07fbe3d8b53da2367db08c51fa977a6902975d9f
Reviewed-on: https://gerrit.chromium.org/gerrit/48577
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>

Remove unused MockNssUtil subclasses

Nothing uses ShortKeyGenerator or ShortKeyUtil anymore, so
get rid of them.

BUG=None
TEST=unit

Change-Id: Ia9b8a1a3aa451312fe7f73e5254a9467a82dcbad
Reviewed-on: https://gerrit.chromium.org/gerrit/48449
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Remove Sign() from PolicyKey class

PolicyKey really represents the public half of a key pair.  In retrospect,
it's weird to have it provide a Sign() method that silently goes and
finds its private half in some implicit NSSDB in order to generate
a signature.  This becomes even funkier when we move to a world where
the session_manager is tracking multiple user sessions, each with its
own NSSDB.  So, get rid of this abstraction and make code that signs
things call NssUtil methods directly.  This will ease the transition
to multiprofile.

BUG=chromium:221770
TEST=unit tests
TEST=login_*Ownership* autotests

Change-Id: I78a32cb288b9712519f0fa81d4d8760a4c576fc6
Reviewed-on: https://gerrit.chromium.org/gerrit/48394
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

Remove redundant --ui-enable-threaded-compositing flag.

As of crrev.com/193431 this flag is on by default in Chromium for
ChromeOS builds. This has no functional change.

BUG=chromium:173417
TEST=local build, run on stumpy

Change-Id: If2c287453f7c44701c046a2c91d559105812754a
Reviewed-on: https://gerrit.chromium.org/gerrit/47770
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Tested-by: Jonathan Backer <backer@chromium.org>

Remove redundant --ui-enable-partial-swap flag.

As of crrev.com/193763 this flag is on by default in Chromium for
ChromeOS builds. This CL should have no functional change.

BUG=chromium:173417
TEST=local build, run on stumpy

Change-Id: Iec1bf4b77c674d41def7f95ece54d83bb08eb1a3
Reviewed-on: https://gerrit.chromium.org/gerrit/48240
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Tested-by: Jonathan Backer <backer@chromium.org>

Adjust touch-calibration for recent touchscreen config changes.

https://gerrit-int.chromium.org/#/c/35850/ increased size of bottom bezel,
so increase it here as well.

BUG=chromium:226290
TEST=Verify that touches are properly vertically aligned (see bug).
Also verify that bottom bezel gesture behaves as expected.

Change-Id: Iee9cf68b1333483c21a9ecab7768a754080eed1f
Reviewed-on: https://gerrit.chromium.org/gerrit/48498
Reviewed-by: Yufeng Shen <miletus@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tested-by: Yuly Novikov <ynovikov@chromium.org>

Increase the default auto-enrollment upload bits to 6.

The auto-enrollment check uploads a limited number of bits from the
hash of the device serial number to determine the device's bucket on the
server-side. The buckets are now large enough that an additional bit is
required.

BUG=chromium:233111
TEST=Auto-enrollment still works.

Change-Id: I4acd37b06c21a02f0606f91aa0526e901c746d49
Reviewed-on: https://gerrit.chromium.org/gerrit/48492
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>

Fix '-Wbind-to-temporary-copy' warning with clang.

This fixes the error
user_policy_service.cc:72:25: error: C++98 requires an
accessible copy constructor for class 'login_manager::PolicyService::Error'
when binding a reference to a temporary; was private [-Werror,-Wbind-to-temporary-copy]
completion->Failure(Error(CHROMEOS_LOGIN_ERROR_DECODE_FAIL, msg));
                        ^
/login_manager/policy_service.h:60:30: note: declared
      private here
    DISALLOW_COPY_AND_ASSIGN(Error);
                             ^
/build/lumpy/usr/include/base-180609/base/basictypes.h:74:3: note: expanded from
macro 'DISALLOW_COPY_AND_ASSIGN' TypeName(const TypeName&);

BUG=chromium:231403
TEST=the clang syntax checking passed.
Change-Id: I7999173fdba2062c693346dee0b3663e7250afb0
Reviewed-on: https://gerrit.chromium.org/gerrit/48134
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>

Move the sentinel flags definitions to a common header shared by Chrome and ChromeOS

BUG=chromium:221354
TEST=Still compiles and passes unit tests.
CQ-DEPEND=Id611c8d6eb9362fc85ee8c19c78998a118d9b0a3

Change-Id: Icea7a1076ac1716800ffab474c5065237619496e
Reviewed-on: https://gerrit.chromium.org/gerrit/47643
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>

Update to new common.mk, fix Makefile errors

The clean: rule for cros-xauth was broken, and the one for $(TEST_BIN) was
a bit funky too.  Also, update to the new common.mk.

BUG=None
TEST=cros_workon_make chromeos-login, then make clean in src/platform/login_manager.  cros-xauth should be deleted.

Change-Id: I21cc43b3b535fffe75e53079483c6445ae75633e
Reviewed-on: https://gerrit.chromium.org/gerrit/47595
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Make sure we support flags with and without dashes.

Further sanitize flags that are empty since this can trick chrome in thinking
that consecutive flags are plain arguments.

BUG=chromium-os:39251
TEST=DevicePolicyServiceTest.StartUpFlagsSanitizer

Change-Id: I0bfe004530b79dce8b6536fdf3d5e0ad388eacbd
Reviewed-on: https://gerrit.chromium.org/gerrit/47311
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>

[login_manager] Reduce ResourcePool size when possible.

Reduce maximum amount of unused resource memory with impl-side
painting to 5% of total memory budget by adding:
--max-unused-resource-memory-usage-percentage=5

BUG=chromium:179460
TEST=local build, tested on daisy and link

Change-Id: I76d7ee44bab0e829e2ee5c8428e85e84a15a91c5
Reviewed-on: https://gerrit.chromium.org/gerrit/47286
Tested-by: David Reveman <reveman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>

[login] repair accidentally-uppercased policy dirs

These were created uppercase because of crbug.com/225472; migrate them to
lowercase.

BUG=chromium:225472,chromium:225487
TEST=unit

Change-Id: Ic28d9c5cf95a93fb201a174d6ebe3b1bcc122daa
Signed-off-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/47061
Reviewed-by: Mattias Nissler <mnissler@chromium.org>

[login_manager] Add --enable-impl-side-painting flag.

BUG=chromium:178317
TEST=local build, tested on daisy and link

Change-Id: I246ffa60177011c41175bb97781ebd867bc17de4
Reviewed-on: https://gerrit.chromium.org/gerrit/45506
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Zelidrag Hornung <zelidrag@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>

login_manager: Calculate gmock/gtest library dependencies programatically

This makes package upgrades for gmock/gtest easier (1.6 adds a pthreads
dependency).

BUG=chromium:211445
TEST=build tests for package using gtest 1.6

Change-Id: I14f87bb4b884b30bf51e33e16fa96752638a0055
Reviewed-on: https://gerrit.chromium.org/gerrit/46426
Commit-Queue: Gaurav Shah <gauravsh@chromium.org>
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
Tested-by: Gaurav Shah <gauravsh@chromium.org>

Guard the policy added flags with sentinel flags.

That way it will be easier for the client to decide and do filtering
on those flags whenever required.

BUG=chromium:221354
TEST=Set the StartUpFlags policy and verify that the sentinel flags are present.

Change-Id: I3ad56f0c6b92eb9a2bc66783d8712da2a3c47d57
Reviewed-on: https://gerrit.chromium.org/gerrit/46162
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>

[login_manager] Enable --enable-impl-side-painting flag when using highdpi.

BUG=chromium:178317
TEST=local build, tested on daisy and link

Change-Id: Ied1954ea565ec392cb958224effd0091db262514
Reviewed-on: https://gerrit.chromium.org/gerrit/45618
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>

Enforce the StartUpFlags device policy through session manager.

In order to make sure flags specified through policy are enforced
and applied before the browser had the chance to initialize we
should set them through session manager before it spawns the
browser process. This feature will not be exposed until we have
some way to ensure that only the set of flags inteded to be used
through this mechanism is enfoced either in the session manager or
on the browser side.

BUG=chromium-os:39251
TEST=Set the policy and check that the policy is respected.

Change-Id: I1bc5e0bfd93bcb61230a0c87f9d63edee00dfaea
Reviewed-on: https://gerrit.chromium.org/gerrit/45434
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>

session_manager should refuse to lock outside user session

If there's no currently active user session, locking the
screen isn't a sensical thing to do.  So...refuse to do it.

BUG=chromium:174488
TEST=unit
TEST=desktopui_ScreenLocker still passes

Change-Id: I574936a05b7737de2f8197133e448f77cc928841
Reviewed-on: https://gerrit.chromium.org/gerrit/45517
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Limit the number of UI frames in flight to at most 1.

By limiting the number of frames in flight, we are less likely to have
a blocking call to SwapBuffers or MakeCurrent (gated on vblank). This
can lead to smoother scroll and video playback.

BUG=chromium:181317,chromium:189142
TEST=local build, run on daisy and link
Change-Id: I4d1579f70e6d05eb3aa92959862c94be3fa3776f
Reviewed-on: https://gerrit.chromium.org/gerrit/45340
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Tested-by: Jonathan Backer <backer@chromium.org>

Re-enable EVDA

Remaining video decode issues on Exynos are not EVDA-specific, so
re-enable EVDA.

BUG=chromium-os:37807
BUG=chromium:173201

TEST=local build, run on Exynos

Change-Id: I4833b0cdb878160eab238353eee49c9f9e491165
Reviewed-on: https://gerrit.chromium.org/gerrit/45258
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Tested-by: John Sheu <sheu@chromium.org>
Commit-Queue: John Sheu <sheu@chromium.org>

Removed auto-login switch by popular demand.

BUG=none
TEST=make sure that 'Do you want to sign in as ...' info bar does not show up anymore.

Change-Id: I29a6cfa0bc56e75de9f6ac2338b2b7bacc0843f1
Reviewed-on: https://gerrit.chromium.org/gerrit/45225
Tested-by: Zelidrag Hornung <zelidrag@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Zelidrag Hornung <zelidrag@chromium.org>

Remove /tmp/machine-info deletion code from session_manager.

This is now handled by the /etc/init/machine-info.conf script.

BUG=chromium-os:26681
TEST=/tmp/machine-info.conf is not present after session start on unowned device.

Change-Id: I313c0eb849facbbb54620c8ce8ba227e0e1c49fa
Reviewed-on: https://gerrit.chromium.org/gerrit/44091
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>

Pass --enable-experimental-bluetooth for BlueZ 5

BUG=chromium-os:38832
TEST=start ui on machine with older and newer bluez

Change-Id: Ifda54669eaaa508eeb8334e61b062ce9440321b1
Reviewed-on: https://gerrit.chromium.org/gerrit/44900
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Zelidrag Hornung <zelidrag@chromium.org>
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>

cros-xauth: mini replacement for xauth

The xauth package depends on a bunch of libs that no one else does to
support legacy formats we don't care about.  Since we only need it to
write out a <100 byte file, implement the logic ourselves.

BUG=chromium-os:39422
TEST=`./cros-xauth foo` produced a file that looks right

Change-Id: I4c2de5effcde627fcd7d4e3063892091814f6a94
Reviewed-on: https://gerrit.chromium.org/gerrit/44402
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

Disable accelerated-overflow-scroll

There are lingering bugs in accelerated overflow scrolling, so
disable it on ToT.

BUG=chromium:179714
TEST=lumpy paladin trybot

Change-Id: I296d3ca47d037cfc89ffedfd264008ea3fe939d4
Reviewed-on: https://gerrit.chromium.org/gerrit/44522
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Commit-Queue: Chris Wolfe <cwolfe@chromium.org>
Tested-by: Chris Wolfe <cwolfe@chromium.org>

session_manager: Modify ACCELERATED_FLAGS for EGL/GLX

Modify session_manager_setup.sh to force
chrome to follow EGL/GLX rendering based
on egl flag defined selectively for a
specific overlay.

BUG=None
TEST=Build and boot till UI login screen
with S/W X11 Mesa libs on Ricochet overlay.
Build and boot till UI on Daisy.

Change-Id: I209fe1eac367e5a0163f79db6f9cdd6cba273416
Signed-off-by: abhinav <abhinav@chromium.org>
Signed-off-by: Arjun.K.V <arjun.kv@samsung.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/43033
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Katie Roberts-Hoffman <katierh@chromium.org>
Reviewed-by: Katie Roberts-Hoffman <katierh@chromium.org>
Tested-by: Katie Roberts-Hoffman <katierh@chromium.org>

session: Re-enable Chrome liveness checks and use SIGFPE.

This re-enables the session manager's periodic Chrome
liveness checks via D-Bus.  It also makes the session
manager send SIGFPE rather than SIGABRT to make it easier to
distinguish liveness-check-induced crashes from other
crashes.

BUG=chromium-os:35729,chromium-os:38892
TEST=unit tests and desktopui_HangDetector pass; also
     manually tested that SIGFPE is sent after inducing a
     chrome hang via gdb

Change-Id: Iad40dc0d240bd97f4684192ec6e0160a8ea92594
Reviewed-on: https://gerrit.chromium.org/gerrit/43968
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>

session_manager_setup.sh: Remove network_change_notifer.cc logging

crosbug.com/34399 was recently root caused and fixed. So remove the logging
we added to help investigate it.

BUG=chromium-os:34399
TEST=see no vlogs network_change_notifier

Change-Id: Ied1c1f611d9d2b3bdd96d24b133e3972ba5a179c
Reviewed-on: https://gerrit.chromium.org/gerrit/43972
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Gaurav Shah <gauravsh@chromium.org>
Tested-by: Gaurav Shah <gauravsh@chromium.org>

Remove unused SessionManagerImpl::CurrentUser()

This method was incorrectly tagged as being an override.  It's
also totally unused, though, so just remove it.

BUG=chromium-os:39222
TEST=unit tests

Change-Id: I3ef9d27c1cf5be0640e4fa53a5e1d202e512b910
Reviewed-on: https://gerrit.chromium.org/gerrit/43969
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Guozhi Wei <carrot@google.com>
Reviewed-by: Chris Masone <cmasone@chromium.org>

login_manager: Updating common.mk to ToT to enable profiling

This update replaces the current common.mk used in this project with the newest
version. This will allow all of the common.mk based projects to be on the same
version for debugging and enables profiling support.

BUG=chromium-os:37854
TEST=Exectuted the following commands to confirm the build works:
     MODE=profiling cros_workon_make --board=link
     MODE=profiling cros_workon_make --board=link --test
     cros_workon_make --board=link
     cros_workon_make --board=link --test
     Repeated these with emerge-link, USE=profiling, and
     FEATURES=test as need.
     For the emerge command with profiling and testing enable, confirmed the
     appropriate coverage files were created in /usr/share/profiling/...

Change-Id: I168c48af4f3997a12449b9ba75b0b4302202e456
Reviewed-on: https://gerrit.chromium.org/gerrit/42788
Tested-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

Set audio buffer size to 2048.

Chrome recently changed the default buffer size from 2048 to 512.  Set
it back to 2048 because 512 causes problems with USB audio devices.
This needs to be fixed, but will not happen in time to be merged to
R26.

BUG=chromium-os:39017
TEST=gmerge chromeos-login and check audio buffer size.

Change-Id: Ibd9c987737c65fda4cddf0c85736d39ef2a0c7e9
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/43702
Reviewed-by: Chris Masone <cmasone@chromium.org>

Unify shutdown code pathways in SessionManagerService

I added a ScheduleShutdown() method for SessionManagerImpl to call
that was a bit redundant with the private method SetExitAndServiceShutdown.
This change converts the former into a convenience wrapper around the
latter.

BUG=None
TEST=unit
TEST=Smoke suite

Change-Id: Iab99cb941ad4abd442b44e9b7b285441703419ef
Reviewed-on: https://gerrit.chromium.org/gerrit/43558
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

Remove deprecated MessageLoop calls from SessionManagerService

MessageLoop::Run() is deprecated.  Replace with instantiation and
use of RunLoop objects.

BUG=chromium-os:38845
TEST=unit
STATUS=Fixed

Change-Id: I19f3a49af077c8bb6256e8ed8d054746d354101c
Reviewed-on: https://gerrit.chromium.org/gerrit/43540
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

Temporarily disable EVDA for Snow until related bugs are fixed.

BUG=chromium:173201
TEST=manual

Change-Id: I504911d7713e270e7c17e51fa0fb5a6ae692d9ef
Reviewed-on: https://gerrit.chromium.org/gerrit/43562
Reviewed-by: John Sheu <sheu@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Tested-by: Pawel Osciak <posciak@chromium.org>

Add /var/run bind mount for debugfs GPU memory dir

/sys/kernel/debug is now only readable by debugd. However, Chrome
sometimes needs real-time access to GEM object memory information in
/sys/kernel/debug/dri/0. Add a bind mount for this specific directory
to /var/run.

BUG=chromium:175828
TEST=manual, verify /var/run/debugfs_gpu exists and files inside are
readable by chronos

Change-Id: I6d7ece58359a2e4a40204ccc94fbe6891df659bc
Reviewed-on: https://gerrit.chromium.org/gerrit/43446
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Tested-by: James Cook <jamescook@chromium.org>

[login_manager] Build against new libchrome, libchrome_crypto

The main difference is that MessageLoop::RunAllPending() -- used
a lot in unit tests -- has been removed.  It's replaced with a
RunLoop class in libchrome, so convert test code to use that
instead.

CQ-DEPEND=CL:43122 CL:43099 CL:43100

BUG=chromium-os:38842
TEST=build and run unittests.

Change-Id: Id46c54d2302c1df22d117b6ecbbba9bc7d7135cb
Reviewed-on: https://gerrit.chromium.org/gerrit/43121
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

session_manager: Unset --enable-hang-detection.

This turns off the session manager's Chrome liveness checks
to determine if they're responsible for an increase in
Chrome SIGABRT crashes within poll() in 25.

BUG=chromium-os:38892
TEST=manual: built an image; flag isn't passed

Change-Id: Iadbc7d80fd736b9d662a9aaff40c2d8a6248907c
Reviewed-on: https://gerrit.chromium.org/gerrit/43239
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>

session: Let "power" user call StopSession D-Bus method.

The power manager needs to be able to call the session
manager's StopSession method if Chrome has set a policy
where users are logged out after being inactive.

BUG=chromium-os:38281
TEST=manual: user is logged out after timeout after setting
     idle action to stop_session
TBR=cmasone@chromium.org

Change-Id: I95762bed903b6fd2761edf18b6d0baad0c91b7de
Reviewed-on: https://gerrit.chromium.org/gerrit/42973
Commit-Queue: Daniel Erat <derat@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>

Enable platform specific optimizations on all Exynos based machines

We want to use EVDA and libvpx specific NEON optimizations on all boards
using Exynos system on chips.
So we just check for the "exynos" USE flag (added to the IUSE clause of
the ebuild) instead of testing the board name.

BUG=chrome-os-partner:17747
TEST=on Spring and Snow, run "ps aux | grep exynos" and see Chrome processes
running with the "--use-exynos-vda" flag.
on Link, run trybot software and check chrome processes flags.

CQ-DEPEND=I62da533ea9e9e3b82447b95aa6d4f2486a0631a7

Change-Id: I04da1244f6b51fd8de51ad09c3daf7e5205278ca
Reviewed-on: https://gerrit.chromium.org/gerrit/42902
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Vincent Palatin <vpalatin@chromium.org>

Write the user policy key in a subdirectory of /var/run/user_policy.

This will make it easier to cache additional data per user in that
directory, in case that is ever needed.

BUG=chromium:163318
TEST=sign-in; /var/run/user_policy/$hash/policy.pub contain the user's policy
key. sign-out; the directory has been wiped.

Change-Id: I2aeb4679350bfdb5851246604db89a19cbeed5a4
Reviewed-on: https://gerrit.chromium.org/gerrit/42542
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>

Force PPAPI plugin to run out of process on Daisy.

This is in preparation for a new Netflix plugin to be landed on Daisy, which
requires to run out of process.

In general, it is recommended to run PPAPI plugins out of process by PPAPI team.
Since currently we don't really have any PPAPI plugin running in-process on
Daisy, the risk of this change is small.

BUG=none
TEST=Tested on Daisy and existing plugins work fine.

Change-Id: Ic826ef5a407b4450deee04debe945c9066fa723f
Reviewed-on: https://gerrit.chromium.org/gerrit/42423
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Tested-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>

[chromeos-login] don't mount /tmp/cgroups

Nobody uses it after https://chromiumcodereview.appspot.com/12036104/

BUG=chromium-os:32633
TEST=adhoc
mount | grep cgroups does not show /tmp/cgroups

Change-Id: I10d0bc88d8cb2295dce828d377b563598dcbfcb1
Signed-off-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/42025
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

Revert: Disable --ui-prioritize-in-gpu-process on daisy

BUG=chrome-os-partner:17175
TEST=manual

Change-Id: I8e62a013a487440a1a4ad0ef78dbbeeff9f1c48a
Reviewed-on: https://gerrit.chromium.org/gerrit/42034
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Tested-by: Jonathan Backer <backer@chromium.org>

Added auto-login (browser only) switch, removed unnecessary compositing switches.

Browser auto login is stil needed on ChromeOS for following use cases:
- User can nuke their auth cookie (i.e. click on sign out) and still land on GAIA sign in page
- Auth cookie session restore does not block login and you can end up with your browser session restored before we get all GAIA cookies merged.

BUG=chromium:170948
TEST=none

Change-Id: I1982d59359a3a875756fb7b9866aa7a4664ef03c
Reviewed-on: https://gerrit.chromium.org/gerrit/41648
Commit-Queue: Zelidrag Hornung <zelidrag@chromium.org>
Reviewed-by: Zelidrag Hornung <zelidrag@chromium.org>
Tested-by: Zelidrag Hornung <zelidrag@chromium.org>

login: Update reference to deprecated constant.

This changes a reference to
power_manager::kRequestRestartSignal to
kRequestRestartMethod.  (Both contain the same value,
"RequestRestart".)

BUG=none
TEST=built it

Change-Id: Id6e4c77d469b32579bd20c70d439625df75e1f4a
Reviewed-on: https://gerrit.chromium.org/gerrit/41826
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>

Write readable copies of user policy keys in /var/run/user_policy.

Whenever the user policy key is loaded or persisted from the user's
vault, a copy is stored at /var/run/user_policy that is readable by
chronos. This allows the chrome process to read the user policy key to
perform additional validation.

BUG=chromium:163318
TEST=sign-in; /var/run/user_policy/$hash.pub contain the user's policy
key. sign-out; the directory has been wiped.

CQ-DEPEND=I34c96f3e5c9dc46b1ad1a053e7ba611b65e8c070

Change-Id: I91608aa3c1b03185b3b49fbe6dc3a81e7201c10e
Reviewed-on: https://gerrit.chromium.org/gerrit/41551
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>

Remove --enable-ui-release-front-surface flag (on by default)

BUG=None
TEST=None

Change-Id: If969a46736c17b75f8b17d4df53fb800cd6f9679
Reviewed-on: https://gerrit.chromium.org/gerrit/41588
Reviewed-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Tested-by: Antoine Labour <piman@chromium.org>

Remove --enable-gesture-tap-highlight from session_manager_setup.sh.

BUG=chrome-os-partner:17293
TEST=Flag is not in chrome://version on device.

Change-Id: I73a21d7f69b6ae7f9606288a77844752b1a0a37e
Reviewed-on: https://gerrit.chromium.org/gerrit/41509
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Tested-by: Robert Flack <flackr@chromium.org>

Use EVDA on snow.

Now that the Exynos VDA has landed in Chromium, turn it on for snow
boards.

BUG=chrome-os-partner:10057
BUG=chromium-os:37807
TEST=local build, run on snow

Change-Id: Ib22ff6906d6408f1de511ae6b5a514c663511854
Reviewed-on: https://gerrit.chromium.org/gerrit/41496
Tested-by: John Sheu <sheu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: John Sheu <sheu@chromium.org>

[login_manager] Only one class inherits from SessionManagerTest; merge them.

There used to be two test classes that derived from SessionManagerTest,
for code-sharing purposes.  Now there's only one, so merge the base and
derived class.

BUG=chromium-os:35215
TEST=unit tests

Change-Id: Ic5aa4dd1f8584d54ed22e601a8aac45796627df5
Reviewed-on: https://gerrit.chromium.org/gerrit/41220
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

Handle --has-chromeos-diamond-key in session_manager_setup.sh

BUG=chromium:163916
TEST=manual

Change-Id: I5890857490f427da7e83fce70b566c62b9c63e87
Reviewed-on: https://gerrit.chromium.org/gerrit/41107
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Yasuhiro Matsuda <mazda@chromium.org>
Tested-by: Yasuhiro Matsuda <mazda@chromium.org>

[login_manager] Add unit test for browser, keygen still running at exit

In general, the session_manager only manages a browser process.  During
"device owner" key generation, though, it is managing the lifetimes of
both the browser process and a special key generation process.

This CL adds a unit test for the case where the session_manager exits while
managing both processes.  Existing tests cover only managing the browser
process.

BUG=chromium-os:37632
TEST=unit
STATUS=Fixed

Change-Id: Ic0289024e253cf374e4c9bc7a4fb5c81d364b9f5
Reviewed-on: https://gerrit.chromium.org/gerrit/40484
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

[login_manager] Add better logging around opening NSSDB

Apparently, we are still seeing keygen fail to open the user's NSSDB.
As the db is supposed to be pre-installed in the user's cryptohome as
it's made, this is surprising.  This change adds more checks for
various kinds of problems that might exist and aborts the process
before we attempt to open the nssdb at all, so we can diagnose the
issue from crash reports.

BUG=chrome-os-partner:16365
TEST=unit
TEST=http://chromegw/i/chromiumos.tryserver/builders/alex-paladin/builds/560

Change-Id: Ibe835c226bdc19dc35956a1f94b0d34524fd1776
Reviewed-on: https://gerrit.chromium.org/gerrit/41149
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Disable --ui-prioritize-in-gpu-process on daisy

BUG=chrome-os-partner:17175
TEST=manual

Change-Id: Ief05043930bb8b87ab786f06493438bd58bafa9c
Reviewed-on: https://gerrit.chromium.org/gerrit/41151
Tested-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Chris Wolfe <cwolfe@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>

[login_manager] Split DBus code into SessionManagerImpl

This is a BIG refactor to move the code that handles calls to the
SessionManager DBus interface into a new class: SessionManagerImpl.

SessionManagerService used to implement both
ProcessManagerServiceInterface and SessionManagerInterface, meaning
that it managed all of subordinate process lifetimes, the main process
event loop, and all incoming RPCs.

This change introduces SessionManagerImpl, a separate
SessionManagerInterface implementation, and removes those
responsibilities from SessionManagerService.  A small number of
methods have been added to SessionManagerInterface allow
SessionManagerImpl and SessionManagerService to communicate as needed.

Concretely, all methods exposed via RPC have been moved from
session_manager_service.{h,cc} into session_manager_impl.{h,cc}.  As
this includes pretty much all of the policy management logic,
SessionManagerImpl owns all the policy service objects now as well.
The code that's now in session_manager_impl_unittest.cc was mostly
originally taken from session_manager_dbus_unittest.cc, but has changed
enough (mostly simplified!) that gerrit doesn't consider this a rename.
Some tests (around cleaning up processes at shutdown time) were moved
to session_manager_process_unittest.cc instead, as they made more sense
there.

BUG=chromium-os:36655
TEST=unit
TEST=http://chromegw/i/chromiumos.tryserver/builders/lumpy-paladin/builds/488
TEST=suite:smoke; All OwnershipAPI autotests

Change-Id: I8deb56f46fde52709d5d4fd62e4b82487f343360
Reviewed-on: https://gerrit.chromium.org/gerrit/40458
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

session_manager: Pass --touch-calibration flag only for Link

The touch calibration parameter is only valid for Link board.
Also remove obsolete --enable-touch-calibration flag.

BUG=chrome-os-partner:16570
TEST=manually tested that the calibration parameter is set only
     on Link.

Change-Id: Ia14b0fbf30b56cc733e9e2e697c38b85df20f879
Reviewed-on: https://gerrit.chromium.org/gerrit/40537
Reviewed-by: Yufeng Shen <miletus@chromium.org>
Tested-by: Yufeng Shen <miletus@chromium.org>
Commit-Queue: Yufeng Shen <miletus@chromium.org>

[login_manager] Add ProcessManagerServiceInterface

Introduce ProcessManagerServiceInterface, an abstraction layer that
will allow the DBus-facing SessionManagerService code to be pulled out
of that massive class, but still be able to call back into
SessionManagerService for the few process-management-related tasks it
needs to perform (killing/restarting the browser and a few other
things).

BUG=chromium-os:36655
TEST=unit

Change-Id: Ic0e6265af2b581efd75357425c9f7c4cb2a69773
Reviewed-on: https://gerrit.chromium.org/gerrit/40454
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

[login_manager] Gather custom GMock matchers into a single file

Reduces duplicate definitions of similar predicates.

BUG=chromium-os:35215
TEST=unit

Change-Id: Ie1f237f5912e838d841027ccf27697d791df2eae
Reviewed-on: https://gerrit.chromium.org/gerrit/40456
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

[login_manager] ChildJob::SetArguments should take a vector<string>

SetExtraArguments() takes a vector of arguments, while SetArguments()
was taking a string that needed to be parsed into a vector of strings.
That's silly.  Make the two calls consistent.

BUG=chromium-os:35215
TEST=unit tests
TEST=smoke suite
TEST=ensure, manually, that signing in as guest works.
TEST=http://chromegw/i/chromiumos.tryserver/builders/lumpy-paladin/builds/462
TEST=http://chromegw/i/chromiumos.tryserver/builders/mario-paladin/builds/1117

Change-Id: I71d1ed6f2da5f9803bc243dcb9a9fd8ca133e111
Reviewed-on: https://gerrit.chromium.org/gerrit/40336
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

[login_manager] Clean up some confusing paths to shutting down

To support tests and some dev behavior, I had some extra abstraction around
shutting down the session manager.  I can clean up a bit of that, now.

BUG=chromium-os:35215
TEST=unit tests
TEST=run smoke suite

Change-Id: I41e1f2da343b514597de8d0c95c469f1424cd8b9
Reviewed-on: https://gerrit.chromium.org/gerrit/40099
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

Allow Xorg to startup as nonroot user

Allow the Xorg server to be run as sudo to some other user.  Presently
still using "root" user, since the other pieces of the nonroot-X story
aren't in yet, but when that happens we should just be able to change
the "XUSER" var in session_manager_setup.sh and we'll be all good to go.

Towards the nonroot-X effort.

TEST=local build, run on x86, ARM
BUG=chromium-os:388

Change-Id: Ic46af8163b724ef18e341659512af16786ffd130
Reviewed-on: https://gerrit.chromium.org/gerrit/39301
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: John Sheu <sheu@chromium.org>
Tested-by: John Sheu <sheu@chromium.org>

session_manager: Remove ply-image --clear.

This removes session_manager_setup.sh's call to ply-image
--clear.  This call is being moved to a dedicated Upstart
job so that it will be reaped after it exits.

BUG=chromium-os:11285
TEST=manual
CQ-DEPEND=Ic31e8c0a32ed7d7fe686dde8937bd4bdec7f1f96

Change-Id: Ibba36ac9a78adc4713bd4530d53db477659c66ad
Reviewed-on: https://gerrit.chromium.org/gerrit/39928
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>

[login_manager] Make check for 'demouser' be 'demouser@' instead

Currently "" is passed for demo mode.  That will soon be 'demouser@', so make
my code match that expectation.

BUG=chromium-os:37004
TEST=unittests

Change-Id: Ic7bfeff33d3d0e39d095fdc581d307aacbe5c2a6
Reviewed-on: https://gerrit.chromium.org/gerrit/39779
Reviewed-by: Nikita Kostylev <nkostylev@chromium.org>
Commit-Ready: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

Add --enable-accelerated-overflow-scroll flag.

Add the chrome command-line flag to enable accelerated overflow
scroll when the highdpi USE flag is enabled.

BUG=chromium-os:37305
TEST=Modified lumpy to enable highdpi and checked ps output.

Change-Id: Id2c5010935861bc967703083e131cb2a02159b9f
Reviewed-on: https://gerrit.chromium.org/gerrit/39787
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Tested-by: Chris Wolfe <cwolfe@chromium.org>
Commit-Ready: Chris Wolfe <cwolfe@chromium.org>

Set LC_ALL=en_US.utf8 before launching Chrome for i18n flash support.

Remove the previous patch (see https://gerrit.chromium.org/gerrit/#/c/17490/)
which sets LC_CTYPE=en_US.utf8 because LC_ALL export encompasses LC_CTYPE.

BUG=chromium:165239
TEST=the following:
(1) Song Pop and Farmville2 work with non-English OS locales (tested German, Japanese).
(2) French keyboard input still works (see crbug.com/165239#c6).

Change-Id: I5f09f60c5a28c3df90db7f0f306fc690f88e638d
Reviewed-on: https://gerrit.chromium.org/gerrit/39531
Commit-Ready: Haixia Shi <hshi@chromium.org>
Tested-by: Haixia Shi <hshi@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Haixia Shi <hshi@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

Revert "Disable Flash hardware decode on Intel."

This reverts commit 5b321918bad433eaf3175eb5084cddcec318b2ab

The Flash binary has been updated.

Change-Id: Iefd651d46f19c094ff015aab7a3c311ef6273565
Reviewed-on: https://gerrit.chromium.org/gerrit/39644
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

Slightly increase the cpu.shares to background rendering.

This allows us to put even lower priority processes like the update-engine
lower than background rendering. This is important to ensuring we don't hear
jank if audio from video is playing from a background tab while AU
is in progress.

BUG=chromium-os:36229
TEST=Ran with it on a Snow device.

Change-Id: I3dec5d76689cc1b6142db2dd739784abe5bfc82f
Reviewed-on: https://gerrit.chromium.org/gerrit/38886
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Ready: Chris Sosa <sosa@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>

session_manager: Clean up D-Bus policy.

This removes some <deny> directives.  Per keybuk@,
"deny is the default behavior, denying further 'undoes'
allowed messages like method replies, signals, dbus-monitor
etc."

BUG=chromium-os:36912
TEST=updated 'power' and 'cras' users to have /bin/bash as
     their shells and confirmed the following:
     - RetrieveSessionState as 'power' succeeds
     - RetrieveSessionState as 'chronos' succeeds
     - RetrieveSessionState as 'cras' fails
     - EnableChromeTesting as 'chronos' fails
     (used commands like:
      su -c 'dbus-send --system \
        --dest=org.chromium.SessionManager \
        --type=method_call \
        --print-reply /org/chromium/SessionManager \
        org.chromium.SessionManagerInterface.RetrieveSessionState' \
        cras
     )

Change-Id: I9bbbfe53a7935312b44d2ffcd1d9fd5e9358fa08
Reviewed-on: https://gerrit.chromium.org/gerrit/39267
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Commit-Ready: Daniel Erat <derat@chromium.org>

session_manager: Stop passing --enable-gview to Chrome.

In Chrome, this flag and the code that it enabled are gone.

BUG=chromium:143164
TEST=none

Change-Id: Ied0f83dad137e611a7d22cafa6c2d63c1139f9f7
Reviewed-on: https://gerrit.chromium.org/gerrit/39191
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Ready: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>

[login_manager] Switch glib signals to DBus signals

Instead of emitting glib signals that get automagically converted
to dbus signals by dbus-glib, we should emit dbus signals directly.

This removes a dependency on dbus-glib, which is deprecated.

BUG=chromium-os:36656
TEST=unit
TEST=http://chromegw/i/chromiumos.tryserver/builders/stumpy-paladin/builds/133
TEST=http://chromegw/i/chromiumos.tryserver/builders/mario-paladin/builds/1017

Change-Id: Id56f0a6b7b53eccef4196adefacf939d79239557
Reviewed-on: https://gerrit.chromium.org/gerrit/39035
Commit-Ready: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>

session_manager: Let "power" user call D-Bus methods.

This lets the new "power" user (soon to be used for running
the powerd process) call the session manager's LockScreen
and RetrieveSessionState methods.

BUG=chromium-os:36510
TEST=manual: checked powerd's log and saw that it got the
     session state and can lock the screen

Change-Id: Idc6b7d825a380caaa3cac6cd88ce2ce0605a0eb9
Reviewed-on: https://gerrit.chromium.org/gerrit/39126
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Ready: Daniel Erat <derat@chromium.org>

[login_manager] Use signal name kConstants from right namespace

Many signal names used by the session_manager were originally defined in
the chromium namespace, as the browser was their intended target.  This
doesn't make sense in the DBus world, where signals are always broadcast.

Use the kConstants defined in the login_manager namespace instead.

BUG=chromium-os:36668
TEST=build, unit test.
TEST=http://chromegw/i/chromiumos.tryserver/builders/mario-paladin/builds/1009

CQ-DEPEND=Id6a94e79702b0cff75945573f8f8215e672a08f6

Change-Id: Ie38d7e209e72bce3832a3766b99101c845ada192
Reviewed-on: https://gerrit.chromium.org/gerrit/39083
Reviewed-by: Daniel Erat <derat@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Commit-Ready: Chris Masone <cmasone@chromium.org>

init: Remove unneeded Chrome flags.

This removes a bunch of command-line flags that we no longer
need to pass to Chrome:

  --compress-sys-feedback      (doesn't exist)
  --enable-accelerated-layers  (doesn't exist)
  --enable-accelerated-plugins (doesn't exist)
  --load-opencryptoki          (hardcoded on real devices)
  --no-first-run               (hardcoded for Chrome OS)
  --reload-killed-tabs         (doesn't exist)
  --scroll-pixels              (doesn't exist)

BUG=chromium:143164
TEST=built and booted it

Change-Id: I56c69c533b9e6c1bcf909e77029e552059cdac3b
Reviewed-on: https://gerrit.chromium.org/gerrit/39087
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Ready: Daniel Erat <derat@chromium.org>

[login_manager] Use Async method call for liveness checking

Chromium apparently supports method calls.  So, instead of pinging with a signal
and waiting for a callback, the session_manager should just call Chromium and
wait for a response asynchronously.

BUG=chromium-os:36686
TEST=unit
TEST=create a VM image and run mod_test_image_for_dbusspy.sh on it.  Boot and run dbus-monitor --system --monitor.  Wait for >60s and you should see a CheckLiveness call.
STATUS=Fixed

Change-Id: I3877a12955a927394ecfa522cb35f45f93a8b0f1
Reviewed-on: https://gerrit.chromium.org/gerrit/38923
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Ready: Chris Masone <cmasone@chromium.org>

[login-manager] enable logging for error_screen_handler and network_portal_detector modules.

This enables logging for network_portal_detector module.

network_portal_detector is a new module, that initiates portal
detection on the signin-screen. As we're planning to make it a default
portal detection module on the signin-screen, logging must be enabled
for it (at least until we will have enough logs from different places
with networks behind captive portal).

BUG=chromium:123579
TEST=manual tests on Lumpy

Change-Id: Ief4b8e63bdfa7c39af7b5be45acb387dd6e5a05e
Reviewed-on: https://gerrit.chromium.org/gerrit/38592
Reviewed-by: Yuri Gorshenin <ygorshenin@chromium.org>
Tested-by: Yuri Gorshenin <ygorshenin@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Ready: Yuri Gorshenin <ygorshenin@chromium.org>

Disable Flash hardware decode on Intel.

Fallback to software is broken. This won't affect the ARM binary.
BUG=chromium:163219
TEST=None.

Change-Id: If82decfa9b8bcf0fb19a9f6c1f3fffd9058cb895
Reviewed-on: https://gerrit.chromium.org/gerrit/38977
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Commit-Ready: Haixia Shi <hshi@chromium.org>
Reviewed-by: Haixia Shi <hshi@chromium.org>

Revert "session_manager: Reset stdin/stdout/stderr to /dev/null before exec-ing child"

This reverts commit 631908b971f979aad7bfc60b13d074409967fa8b

Some non-Chrome internal components (Pepper flash, GPU driver, etc) rely on stderr being redirected to the /var/log/ui* for their logging (since they can't use the Chrome's logging infrastructure).

BUG=chromium-os:36688

Change-Id: I280d9c450580fc1e0965af334481041816e3d92e
Reviewed-on: https://gerrit.chromium.org/gerrit/38788
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
Tested-by: Gaurav Shah <gauravsh@chromium.org>

Enable Flash hardware video decode.

This enables Flash hardware video decoding on all platforms, in
particular on Intel SNB+.

TEST=Youtube on Lumpy and Arrow.
BUG=chromium:140363

Change-Id: I20539c9cdbd4669b4ed8a51ea454ce0e67e76c87
Reviewed-on: https://gerrit.chromium.org/gerrit/38715
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>