chromiumos/platform/login_manager.git
7 months agoDisable Flash hardware decode on Atom boards v2. 71/66571/3 master
Ilja Friedel [Wed, 21 Aug 2013 22:40:24 +0000 (15:40 -0700)]
Disable Flash hardware decode on Atom boards v2.

Fixes previous commit a06154b007a26ea9dbe8539ffedf9550c092828f.

BUG=chromium:276738, chromium:277690
TEST=Ran on Alex using x86-alex, checked about:chrome and flag shows =0.

Change-Id: I17b3d47985215075f80dcef6c0a272e091dc09b3
Reviewed-on: https://gerrit.chromium.org/gerrit/66571
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
7 months agoDisable Flash hardware decode on Atom boards. 67/66467/2
Ilja Friedel [Wed, 21 Aug 2013 01:38:42 +0000 (18:38 -0700)]
Disable Flash hardware decode on Atom boards.

This avoids a frequent crasher until a proper fix is put into Flash.

BUG=chromium:276738
TEST=Ran on Alex, checked flags in about:chrome

Change-Id: I01bb2b9939a8c2082d65664dc8c0c28f3654a5d9
Reviewed-on: https://gerrit.chromium.org/gerrit/66467
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
8 months agologin: Remove --first-boot flag. 06/65406/2
Daniel Erat [Fri, 9 Aug 2013 22:04:27 +0000 (15:04 -0700)]
login: Remove --first-boot flag.

Chrome is checking for --first-exec-after-boot instead now.

BUG=none
TEST=manual: chrome honors new flag

Change-Id: I13d14ceb45c46e46adc0f43294b09135d1e4ce19
Reviewed-on: https://gerrit.chromium.org/gerrit/65406
Tested-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
8 months agoChange touch-calibration flag to match firmware change. 16/64816/2
WeiNan-Peter, Wen [Tue, 6 Aug 2013 20:40:46 +0000 (16:40 -0400)]
Change touch-calibration flag to match firmware change.

Increasing side bezels' calibration from 0 to 45 pixels to match change
in firmware. Events from side bezels are filtered by chrome according to
this flag, thus the two changes should be atomic.

BUG=chromium:263591
TEST=Tested on dev pixel. Works well with this calibration.
CQ-DEPEND=CL:*42404

Change-Id: Ie6fc1720a7d78295f741e329d6834d4882637a43
Reviewed-on: https://gerrit.chromium.org/gerrit/64816
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Yufeng Shen <miletus@chromium.org>
Tested-by: WeiNan-Peter, Wen <wnwen@chromium.org>
Commit-Queue: WeiNan-Peter, Wen <wnwen@chromium.org>

8 months agoAdd GPU_FLAGS for session_manager 80/62380/5
Andrew Chew [Wed, 17 Jul 2013 20:48:37 +0000 (13:48 -0700)]
Add GPU_FLAGS for session_manager

Add another set of flags (GPU_FLAGS) that are applied to session_manager.

Currently, we use the USE flag gpu_sandbox_allow_sysv_shm to pass
--gpu-sandbox-allow-sysv-shm to session_manager.  Other, similar USE flags
can be used to pass GPU-related flags.

The --gpu-sandbox-allow-sysv-shm parameter is used to allow the shmat system
call to be used by the Tegra GPU sandbox.

BUG=none
TEST=emerge-puppy chromeos-login, see that gpu_sandbox_allow_sysv_shm is set in
/etc/session_manager_use_flags.txt.

Change-Id: If83b154c96e00d3011b21e8a75ace44334ed8fdd
Signed-off-by: Andrew Chew <achew@nvidia.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/62380
Reviewed-by: Chris Masone <cmasone@chromium.org>
8 months agoAdd informational logging to ui-respawn 25/65325/3
Chris Masone [Fri, 9 Aug 2013 17:26:35 +0000 (10:26 -0700)]
Add informational logging to ui-respawn

Add logging in the cases where ui-respawn is considering
rebooting to attempt to mitigate a crashy UI. The standard
code paths have no logging, so this should not spam the
logs at all.

BUG=None
TEST=run desktopui_CrashyRebootServer and inspect /var/log/messages

Change-Id: Id087a653b46964f0ef069790f244fa657a151b7e
Reviewed-on: https://gerrit.chromium.org/gerrit/65325
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

8 months agologin: Pass --first-exec-after-boot flag to Chrome. 21/65321/2
Daniel Erat [Fri, 9 Aug 2013 16:45:48 +0000 (09:45 -0700)]
login: Pass --first-exec-after-boot flag to Chrome.

This adds a new --first-exec-after-boot flag to replace the
existing, vaguely-named --first-boot flag. It also adds
support for multiple one-time arguments to the session
manager.

BUG=none
TEST=unit tests pass; manually checked that both flags are
     passed appropriately

Change-Id: I5d471db5efe9bb8b1f2be27bb7ad176f0c91a86f
Reviewed-on: https://gerrit.chromium.org/gerrit/65321
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
8 months agoRemove "--use-exynos-vda" from session_manager_setup.sh 91/64791/2
John Sheu [Tue, 6 Aug 2013 18:18:15 +0000 (11:18 -0700)]
Remove "--use-exynos-vda" from session_manager_setup.sh

This flag has been removed from Chrome, as we default to using the
Exynos VDA now.

BUG=chromium:223194
TEST=local build on CrOS snow

Change-Id: Ic1a6f3f1c771a111db39266ed72298a2d9ff93c3
Reviewed-on: https://gerrit.chromium.org/gerrit/64791
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Ami Fischman <fischman@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: John Sheu <sheu@chromium.org>
Tested-by: John Sheu <sheu@chromium.org>
8 months agoCreate /var/cache/external_cache for default apps cache 22/63522/2 stabilize-4512.B
Dmitry Polukhin [Thu, 25 Jul 2013 22:50:44 +0000 (15:50 -0700)]
Create /var/cache/external_cache for default apps cache

BUG=chromium:261215
TEST=manual

Change-Id: Icd919e07406c0aadb3c9e50b5a653ff4f9722808
Reviewed-on: https://gerrit.chromium.org/gerrit/63522
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Dmitry Polukhin <dpolukhin@chromium.org>
Commit-Queue: Dmitry Polukhin <dpolukhin@chromium.org>

8 months agoManage ui restarting with a separate upstart job. 81/62781/6
Chris Masone [Sun, 21 Jul 2013 22:13:25 +0000 (15:13 -0700)]
Manage ui restarting with a separate upstart job.

Sometimes a GPU hang will cause Chrome to be unable to start. In order to
mitigate these issues, we'd like to reboot the device when this happens.
A good indicator that we might be in this situation is the ui job exiting
with a certain status code. The difficulty is that, in order to take special
action on certain exit status codes, we need to take normal respawn handling
out of the hands of upstart as well.

The new per-exit-code respawning policy implemented is:
 0: Normal exit; respawn forever.
 2: (Defined in session_manager_service.h) The browser is exiting too much too
    quickly. In some cases, such as a hung GPU, rebooting the device will allow
    the system to recover. If this happens 2 times in 180 seconds, try
    a reboot. If the device has already rebooted to try to mitigate this issue
    in the last 540 seconds, stop the UI and wait for an AU.
 All nonzero: All thing being equal, respawn up to 6 times in 60 seconds,
              then stop.

CQ-DEPEND=CL:63820, CL:62660, CL:63945

BUG=chromium:261784
TEST=pkill -9 -o "^chrome$" 8 times in 3 minutes; device should reboot
TEST=pkill -9 session_manager 7 times in a minute; ui should be stopped
TEST=stop ui and start ui should work as expected

Change-Id: If13a0c274886bce45833e7f6f218bcecdf575251
Reviewed-on: https://gerrit.chromium.org/gerrit/62781
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
8 months agoExpand definition of 'child exiting too fast' 60/62660/2 factory-4455.B factory-pit-4471.B firmware-pit-4482.B stabilize-4443.B
Chris Masone [Fri, 19 Jul 2013 18:38:09 +0000 (11:38 -0700)]
Expand definition of 'child exiting too fast'

The session_manager has always bailed if the browser exits too
much too fast. Until now, this has been 'more than once a second'.
To address some crashes that happen when the GPU process hangs,
this threshold is now '4 times in 60 seconds'.

The session manager exiting will cause the UI to bounce, which
causes X to be killed and restarted as well. This should address
some funkiness, though not all. We will also add some logic to
reboot in certain circumstances.

BUG=chromium:261784
TEST=unit tests, booted device and SIGKILL'd chrome 4 times in < 1 minutes. Checked logs to see that the session manager exited after the 4th time.

Change-Id: I3c9caa02628c43091872a703fea10e37ad4f6a1d
Reviewed-on: https://gerrit.chromium.org/gerrit/62660
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Zelidrag Hornung <zelidrag@chromium.org>
9 months agoui.conf should kill processes with open files in any cryptohome 92/60292/2 factory-pit-4390.B firmware-falco_peppy-4389.B firmware-leon-4389.26.B firmware-wolf-4389.24.B
Chris Masone [Thu, 27 Jun 2013 22:43:55 +0000 (15:43 -0700)]
ui.conf should kill processes with open files in any cryptohome

Until now, we've been looking for processes with files open in only the
legacy cryptohome mountpoint, which is not multiprofile safe.  Now, when
trying to clean up user session processes, ui.conf will check across
all cryptohome mount points.

BUG=chromium:255091
TEST=leave a process running with an open file in /home/chronos/u-<hash>; ensure it gets killed by a ui restart
STATUS=Fixed

Change-Id: I75c866238520d2a4ae2a7a38182c10993021d59e
Reviewed-on: https://gerrit.chromium.org/gerrit/60292
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

9 months agoAddress fatal syntax errors in ui.conf post-stop 85/60485/3
Chris Masone [Fri, 28 Jun 2013 18:14:57 +0000 (11:14 -0700)]
Address fatal syntax errors in ui.conf post-stop

When logging info about unkillable 'chronos' processes, I should pipe
into logger, not redirect.  Also, use custom ps output instead of
awk'ing stuff from /proc to get the info I want.

BUG=chromium:234382
TEST=restart UI, ensure that still works
TEST=kill the session manager during a session, ensure the cryptohome is unmounted

Change-Id: I4e84305520ba17755dea55c608fdd13e6c9652d2
Reviewed-on: https://gerrit.chromium.org/gerrit/60485
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
9 months agoUse a USE option "deep_memory_profiler" in chromeos-login. 04/60204/3
Dai Mikurube [Thu, 27 Jun 2013 08:03:54 +0000 (17:03 +0900)]
Use a USE option "deep_memory_profiler" in chromeos-login.

The option is added to enable Deep Memory Profiler (DMP) in ChromeOS.
to understnad memory usage of Chrome processes in ChromeOS.

See http://dev.chromium.org/developers/deep-memory-profiler for DMP.

BUG=chromium:129111
TEST=None:This change is not visible for users.

Change-Id: Id0c91fc883b73dd9fed46df006cec4ff94320c4b
Reviewed-on: https://gerrit.chromium.org/gerrit/60204
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Dai Mikurube <dmikurube@chromium.org>
Tested-by: Dai Mikurube <dmikurube@chromium.org>
9 months agoUpdate kill syntax in ui.conf post-stop 70/60270/3
Chris Masone [Thu, 27 Jun 2013 21:39:28 +0000 (14:39 -0700)]
Update kill syntax in ui.conf post-stop

Apparently, the new version of /bin/kill doesn't handle command-line
switches right.  It used to be that 'kill -9 -1' SIGKILL'd all the
processes the user was allowed to touch.  Now, it thinks that we
want to send signal 1 to no processes.  Whoops.

BUG=chromium:234382
TEST=desktopui_KillRestart

Change-Id: I1ac8eabef129502b73778697512e1d4283fa11d6
Reviewed-on: https://gerrit.chromium.org/gerrit/60270
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
9 months agoLog info about unkillable processes at UI shutdown 69/60269/4
Chris Masone [Thu, 27 Jun 2013 21:34:10 +0000 (14:34 -0700)]
Log info about unkillable processes at UI shutdown

This is to help us diagnose why we might have some chrome process
that lives past UI death and causes trouble when we try to restart
the UI.

BUG=chromium:234382
TEST=restart UI, ensure that still works

Change-Id: I64899a7b2e5ead9bac2328ba8408b3bedd0918e9
Reviewed-on: https://gerrit.chromium.org/gerrit/60269
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
9 months agoReduce audio buffer size to 512. 47/59447/3
Adrian Li [Thu, 20 Jun 2013 17:33:11 +0000 (10:33 -0700)]
Reduce audio buffer size to 512.

Audio buffer size was previously increased to 2048 due to poor speaker
performance. Issue has since been fixed by setting audio threads to
realtime. This change reverts the audio buffer size to the default 512
for better latency. No significant difference in power consumption
when changing the buffer size.

BUG=chromium:221207
TEST=Played audio in background while working with multiple
tabs. Compared performance with larger (2048) audio buffer size.

Change-Id: I64ceb1c227b01acff9a454727c95c1dd182ae62a
Reviewed-on: https://gerrit.chromium.org/gerrit/59447
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Tested-by: Dylan Reid <dgreid@chromium.org>
9 months agoDrop --enable-encrypted-media flag. 71/60171/3
Xiaohan Wang [Thu, 27 Jun 2013 02:05:33 +0000 (19:05 -0700)]
Drop --enable-encrypted-media flag.

Prefixed EME is supported in chrome by default. Unprefixed EME is disabled by
default and can be enabled with --enable-encrytped-media flag. On ChromeOS
devices we should not enable unprefixed EME for now.

For the Chrome side change, see: http://codereview.chromium.org/12090061

BUG=chromium:254759
TEST=none

Change-Id: Ia7fdf97efff3f072e1c0718b7e86477635108153
Reviewed-on: https://gerrit.chromium.org/gerrit/60171
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Tested-by: Xiaohan Wang <xhwang@chromium.org>
9 months agoRevert "[login_manager] Add --enable-impl-side-painting flag." 20/59620/3
David Reveman [Mon, 24 Jun 2013 09:02:34 +0000 (05:02 -0400)]
Revert "[login_manager] Add --enable-impl-side-painting flag."

This reverts commit 7c9bd76706b442f4ea5c6bf1c6ebbc1ce18cadba

Change-Id: I7632c5c71a7607393aaac14a08132648ccfe1e94
Reviewed-on: https://gerrit.chromium.org/gerrit/59620
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>
9 months agologin: Add ash wallpaper flags. 39/59439/2
Daniel Erat [Fri, 14 Jun 2013 22:52:59 +0000 (15:52 -0700)]
login: Add ash wallpaper flags.

Make session_manager_setup.sh look for wallpapers in
/usr/share/chromeos-assets/wallpapers and instruct Chrome to
use them if they're present.

BUG=chromium:248764
TEST=flags are set when wallpapers and present and aren't
     set when they aren't present

Change-Id: I814fbccd3f0007594d1efaa031b0dfb731215319
Reviewed-on: https://gerrit.chromium.org/gerrit/59439
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>

9 months ago[login_manager] Increase default interest area used by impl-side painting. 65/59065/2
David Reveman [Tue, 18 Jun 2013 15:21:44 +0000 (11:21 -0400)]
[login_manager] Increase default interest area used by impl-side painting.

Increases the amount of initialized tiles that are cached. This
reduces checkerboarding and low-res contents.

BUG=chromium:179482
TEST=local build, tested on link

Change-Id: I01cbff76da401a9af97cecd00d7a5cdef8c171c9
Reviewed-on: https://gerrit.chromium.org/gerrit/59065
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>
10 months agoBluetooth: remove experimental flag 78/50478/3 factory-4290.B factory-pit-4280.B factory-spring-4262.B stabilize-4287.B
Scott James Remnant [Wed, 8 May 2013 18:48:45 +0000 (11:48 -0700)]
Bluetooth: remove experimental flag

BUG=chromium:221813
TEST=verify Bluetooth still enabled with updated Chrome

Change-Id: I97f4173c0879d9f76eced586252cd3a029224e60
Reviewed-on: https://gerrit.chromium.org/gerrit/50478
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
10 months agoAdd a DBus call to specify a set of extra flags to be applied on in-session restarts. 87/58187/3
Julian Pastarmov [Tue, 11 Jun 2013 14:50:28 +0000 (16:50 +0200)]
Add a DBus call to specify a set of extra flags to be applied on in-session restarts.

BUG=chromium:221352
TEST=Specify per user flags in chrome and observe them applied on next sign-in.

Change-Id: I63eaf9bb8122324354fddcc16dc7740bc9691cac
Reviewed-on: https://gerrit.chromium.org/gerrit/58187
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>

10 months agoIncrease the default auto-enrollment upload bits to 7. 76/58176/2
Joao da Silva [Tue, 11 Jun 2013 08:00:52 +0000 (10:00 +0200)]
Increase the default auto-enrollment upload bits to 7.

The auto-enrollment check uploads a limited number of bits from the
hash of the device serial number to determine the device's bucket on the
server-side. The buckets are now large enough that an additional bit is
required.

BUG=chromium:248462
TEST=Auto-enrollment still works.

Change-Id: Id48ead1fa6c5e08a8909d5ba183fe19330f3e12e
Reviewed-on: https://gerrit.chromium.org/gerrit/58176
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>
10 months agoAllow Chrome to set audio threads to realtime priority of 10. 93/57493/2 stabilize-4255.B
Dylan Reid [Tue, 4 Jun 2013 19:22:49 +0000 (12:22 -0700)]
Allow Chrome to set audio threads to realtime priority of 10.

Chrome's audio threads don't require much CPU, but they have to meet
short scheduling deadlines.  Audio buffers must be filled in as little
as a couple of milliseconds.  Setting these threads to real time
allows these deadlines to be met on ChromeOS.

Set the nice limit back to where it was before allowing advantageous
nice levels.

BUG=chromium:213118,chromium:221207
TEST=play audio in the background on a heavily loaded system.  Modify
Chrome to set audio threads to realtime and notice it is much better,
even with smaller buffer sizes.

Note this was already reviewed at:
https://gerrit.chromium.org/gerrit/#/c/51494/

Change-Id: Ie2dd5a15fc3e0bdf906b95fa2a050ffb06e2dfc1
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/57493
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Sonny Rao <sonnyrao@chromium.org>
10 months agoRemove deprecated magic 'incognito' user name 12/57512/2
Chris Masone [Tue, 4 Jun 2013 21:06:01 +0000 (14:06 -0700)]
Remove deprecated magic 'incognito' user name

Chrome used to pass '' to indicate a guest user session.  Now
we're using a kOnstant defined in libchromeos instead, so
remove the deprecated string.

BUG=chromium:237816
TEST=trybot
STATUS=Fixed

Change-Id: I4cacad6b11e8863a6c06894538887c0ac7d6c191
Reviewed-on: https://gerrit.chromium.org/gerrit/57512
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Reviewed-by: Nikita Kostylev <nkostylev@chromium.org>
10 months agoEnable composited scrolling for high DPI 24/57224/2
Ian Vollick [Fri, 31 May 2013 17:39:36 +0000 (13:39 -0400)]
Enable composited scrolling for high DPI

Adds --enable-accelerated-overflow-scroll to the list of flags
used on high DPI devices.

BUG=chromium:177710
TEST=copied session_manager_setup.sh to link and tested manually.

Change-Id: Ia91100a461d03eab27edaee41c513fd53998452c
Reviewed-on: https://gerrit.chromium.org/gerrit/57224
Reviewed-by: Chris Wolfe <cwolfe@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Tested-by: Ian Vollick <vollick@chromium.org>
10 months agoFix link for bug. 36/57036/2
Jorge Lucangeli Obes [Wed, 29 May 2013 22:41:38 +0000 (15:41 -0700)]
Fix link for bug.

BUG=None
TEST=None

Change-Id: I3da289a0e416c42af7b46541446811b0dbab5f92
Reviewed-on: https://gerrit.chromium.org/gerrit/57036
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>

10 months agoRemove unused sandboxing-related flags. 43/57043/2
Jorge Lucangeli Obes [Wed, 29 May 2013 22:45:45 +0000 (15:45 -0700)]
Remove unused sandboxing-related flags.

The original seccomp sandbox code has been removed from Chrome,
and the GPU sandbox is now enabled by default.

BUG=None
TEST=about:gpu shows sandbox is enabled.

Change-Id: I19aad15a8a43d5bfbc9f7d8982a88cc76e7bf5dc
Reviewed-on: https://gerrit.chromium.org/gerrit/57043
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>

10 months agoEnable off-thread uploads on exynos. 25/57125/2
Jonathan Backer [Thu, 30 May 2013 16:57:41 +0000 (12:57 -0400)]
Enable off-thread uploads on exynos.

Enables off-thread uploads when --enable-impl-side-painting is set.
Currently only enabling on exynos. Work is on going on intel to
prevent driver serialization in this use case (crbug.com/236504).

BUG=chromium:196245
TEST=local build
Change-Id: Ibebfb9c3e5150072b7169901caa88104da89df1a
Reviewed-on: https://gerrit.chromium.org/gerrit/57125
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Tested-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>

10 months ago[login_manager] Add --enable-impl-side-painting flag. 12/56812/3
David Reveman [Tue, 28 May 2013 15:50:54 +0000 (11:50 -0400)]
[login_manager] Add --enable-impl-side-painting flag.

BUG=chromium:178317
TEST=local build

Change-Id: I8f9c9b56fde5bb36adc6b3b22d02bf69c50dc7df
Reviewed-on: https://gerrit.chromium.org/gerrit/56812
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Tested-by: Jonathan Backer <backer@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>

10 months agoKill X after other processes. 97/57097/3
Xiyuan Xia [Thu, 30 May 2013 07:32:54 +0000 (00:32 -0700)]
Kill X after other processes.

Old window manager is gone now and X does not need to be killed first to avoid
screen artifacts. Make it to be killed after other processes as it was.

BUG=chromium:238937,chromium:245151
TEST=desktopui_KillRestart should not cause chrome to crash.

Change-Id: Iad47ed1ffca561cb00f7c8cb0293fe56cbb26c6d
Reviewed-on: https://gerrit.chromium.org/gerrit/57097
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Tested-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Puneet Kumar <puneetster@chromium.org>
Reviewed-by: Puneet Kumar <puneetster@chromium.org>
10 months agoRemove legacy code that showed recovery UI in Chrome 35/56735/2
Nikita Kostylev [Mon, 27 May 2013 13:34:41 +0000 (17:34 +0400)]
Remove legacy code that showed recovery UI in Chrome

BUG=chromium:244224
TEST=none

Change-Id: If125789764470864c2cd8ba24e0371dd79c262b8
Reviewed-on: https://gerrit.chromium.org/gerrit/56735
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Nikita Kostylev <nkostylev@chromium.org>
Commit-Queue: Nikita Kostylev <nkostylev@chromium.org>

10 months agologin: Make Chrome log external-display-related info. 71/56271/2
Daniel Erat [Wed, 22 May 2013 17:48:27 +0000 (10:48 -0700)]
login: Make Chrome log external-display-related info.

This enables VLOG(1) for *output_configurator* to help debug
reports of issues related to external displays.

BUG=none
TEST=manual

Change-Id: Ifd07a181bc3a47ea9c0fd7dda622451b6927b86f
Reviewed-on: https://gerrit.chromium.org/gerrit/56271
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
10 months agoMove ui-related upstart jobs to login_manager repo 18/55818/3
Chris Masone [Mon, 20 May 2013 19:36:07 +0000 (12:36 -0700)]
Move ui-related upstart jobs to login_manager repo

These should live next to the code they manage.  This facilitates
extracting a whole system daemon from a build using USE flags.

BUG=chromium:242234
TEST=building this package should still work, but not install these files.

Change-Id: I34c627aed6d9b3d2ec28185f73a65ce88b0991c2
Reviewed-on: https://gerrit.chromium.org/gerrit/55818
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

10 months agoUse correct name for RetrieveActiveSessions in dbus config 65/55765/2
Chris Masone [Mon, 20 May 2013 15:37:24 +0000 (08:37 -0700)]
Use correct name for RetrieveActiveSessions in dbus config

The DBus policy was broken, because I used the wrong name
for the new method I added.  This led to Chrome being unable
to call RetrieveActiveSessions.

BUG=chromium:239830
TEST=start a session, run dbus-send from the command line as the chronos user.

Change-Id: Iab84b17bf92b4046acc74bc4889e9416f190cf87
Reviewed-on: https://gerrit.chromium.org/gerrit/55765
Reviewed-by: Nikita Kostylev <nkostylev@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

11 months agoAdd --login-profile flag when restarting browser after crash 11/50511/10
Chris Masone [Wed, 8 May 2013 23:09:31 +0000 (16:09 -0700)]
Add --login-profile flag when restarting browser after crash

This is actually important when the (newly added) --multi-profiles
flag is passed to the session manager.  When that flag is not specified,
the session_manager needs to maintain the old behavior of passing
--login-profile=user.

If --multi-profiles is not specified, when restarting the browser
after a crash, the session manager will append two flags to the
browser command line:
   --login-user=<user@email> --login-profile=user

If --multi-profiles _is_ specified, the session manager will do the following:
1) Add --multi-profiles to the browser command line
2) When restarting the browser after a crash, the session manager will append
   two flags to the browser command line:
   --login-user=<user@email> --login-profile=<sanitized user name>

BUG=chromium:235181
TEST=unit
TEST=suite:smoke

Change-Id: Ia00f42e1d1f1203b6147a5dd31ff6111de57944a
Reviewed-on: https://gerrit.chromium.org/gerrit/50511
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
11 months agoRemoved the old user policy DBus calls. 50/50450/3
Joao da Silva [Wed, 8 May 2013 13:35:25 +0000 (15:35 +0200)]
Removed the old user policy DBus calls.

These calls have been obsoleted by new variants that include the
username as a parameter.

BUG=chromium:187482
TEST=unit tests are green; manually verified on a VM image that user
policy still works.

Change-Id: Ic09bcebb96214772f16997b39d7688aa8ff63d1d
Reviewed-on: https://gerrit.chromium.org/gerrit/50450
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Reviewed-by: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>
11 months agoAdd RetrieveActiveSessions DBus method 94/50894/3 factory-4128.B factory-spring-4131.B
Chris Masone [Fri, 10 May 2013 18:07:31 +0000 (11:07 -0700)]
Add RetrieveActiveSessions DBus method

RetriveActiveSessions() returns a dictionary of currently
attached user sessions, mapping username to sanitized username
(a.k.a. user hash).

BUG=chromium:239830
TEST=unit

Change-Id: I315ee1cecea7c8af6df9968b569a084381ea9167
Reviewed-on: https://gerrit.chromium.org/gerrit/50894
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
11 months agoEnable session_manager to address per-user NSSDBs 28/48428/16
Chris Masone [Wed, 17 Apr 2013 23:02:20 +0000 (16:02 -0700)]
Enable session_manager to address per-user NSSDBs

Per-user DB handles are stored in each user's UserSession object
upon StartSession(), and used to scope owner key generation and lookup to
the appropriate user.

CQ-DEPEND=I912d3ded053a7f0f41c604f5ffef15477d634017
CQ-DEPEND=CL:50071

BUG=chromium:235179
TEST=unit tests
TEST=new autotests login_MultipleSessions and login_SameSessionTwice
TEST=login_OwnershipTaken login_RemoteOwnership login_OwnershipRetaken  login_OwnershipNotRetaken login_OwnershipApi login_UserPolicyKeys
TEST=suite:smoke
STATUS=Fixed

Change-Id: I5ee9fb18e1f8c1a933b899acc62618323f2df9bf
Reviewed-on: https://gerrit.chromium.org/gerrit/48428
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

11 months agoEnable Chrome side audio routing. 21/49921/2
Dylan Reid [Wed, 1 May 2013 22:29:27 +0000 (15:29 -0700)]
Enable Chrome side audio routing.

Enable the flag that tells chrome it is responsible for decisions
about where to route audio.

CQ-DEPEND=CL:49812
BUG=chromium:175798
TEST=plug/unplug audio devices and check that Chrome is routing audio
correctly

Change-Id: Ifa8f15c9cf5e4865f39c3c07cf076641943a7a0e
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/49921
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
11 months agosession_manager: Handle new-style device-local account IDs. 69/50169/4
Mattias Nissler [Mon, 6 May 2013 14:15:07 +0000 (16:15 +0200)]
session_manager: Handle new-style device-local account IDs.

Update session_manager after deprecation and rename of the
DeviceLocalAccountInfoProto.id field and introduction of the account_id
and type fields. Note that this will only compile after protofiles has
been rolled to protofiles-0.0.1-r14.ebuild.

BUG=chromium:216359
TEST=unit tests
CQ-DEPEND=CL:50170

Change-Id: Ia1aa3facd699443cebd88a756d44f9b0dc0fb986
Reviewed-on: https://gerrit.chromium.org/gerrit/50169
Tested-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>

11 months agoEnable login_manager::NssUtil to support per-user NSS DBs. 73/50073/8
Chris Masone [Thu, 2 May 2013 01:00:22 +0000 (18:00 -0700)]
Enable login_manager::NssUtil to support per-user NSS DBs.

Add support for explicit NSS DB paths to login_manager::NssUtil in
order to support per-user NSS DBs.

Since upstream is not looking to change RSAPrivateKey::CreateSensitive()
and RSAPrivateKey::FindPublicKeyInfo() to support per-DB operations,
move the additional logic to support these into login_manager::NssUtil
as well.

CQ-DEPEND=CL:50071

BUG=chromium:221770
TEST=unit
TEST=suite:smoke

Change-Id: I20836238e9e32dac8e8d930a66f5a78bda704963
Reviewed-on: https://gerrit.chromium.org/gerrit/50073
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

11 months agoAdded multi-profile user-policy DBus calls. 32/48932/3
Joao da Silva [Tue, 23 Apr 2013 14:01:34 +0000 (18:01 +0400)]
Added multi-profile user-policy DBus calls.

Introduced StorePolicyForUser and RetrievePolicyForUser calls,
which are the multi-profile version of StoreUserPolicy and
RetrieveUserPolicy. These allow storing and retrieving user policy for
more than one user.

The old StoreUserPolicy and RetrieveUserPolicy calls will be removed
once Chrome is updated to use the new ones.

BUG=chromium:187482
TEST=unit tests are green; manually verified on a VM image that user
policy still works.

Change-Id: Ib748e2d59150034f4caa882ca01caf86eddbc9d4
Reviewed-on: https://gerrit.chromium.org/gerrit/48932
Tested-by: Joao da Silva <joaodasilva@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>

11 months agoFixed NetworkPortalDetector logging. 67/50167/2
Yuri Gorshenin [Mon, 6 May 2013 09:41:09 +0000 (13:41 +0400)]
Fixed NetworkPortalDetector logging.

As NetworkPortalDetector was split to NetworkPortalDetectorStub and NetworkPortalDetectorImpl, module name in vmodules need to be fixed.

BUG=chromium:170104
TEST=none

Change-Id: I6ceda4b2e9b6ee7f75b85c2121e9a00ce12628d2
Reviewed-on: https://gerrit.chromium.org/gerrit/50167
Reviewed-by: Yuri Gorshenin <ygorshenin@chromium.org>
Tested-by: Yuri Gorshenin <ygorshenin@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Yuri Gorshenin <ygorshenin@chromium.org>

11 months ago[login_manager] Remove --enable-impl-side-painting flag. 47/50047/2
David Reveman [Fri, 3 May 2013 17:39:47 +0000 (13:39 -0400)]
[login_manager] Remove --enable-impl-side-painting flag.

BUG=chromium:178317
TEST=local build

Change-Id: Ied01efa68959701a943eec2be344713a53fab8c9
Reviewed-on: https://gerrit.chromium.org/gerrit/50047
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>
11 months agoAdd notion of "user sessions" to session_manager 40/50040/3
Chris Masone [Thu, 2 May 2013 19:57:47 +0000 (12:57 -0700)]
Add notion of "user sessions" to session_manager

To support multiprofile, the session manager will need to be able to keep
track of multiple user sessions at the same time.  This CL introduces a
UserSession structure to store pertinent data, and stores a map of username
to UserSession that's updated upon each call to StartSession().

This CL does NOT make multiprofile work correctly for everything.  Device
Ownership issues are not sorted out, and many operations that currently
only make sense inside a user session barf if multiple sessions have been
started.

BUG=chromium:235179
TEST=unit
TEST=suite:smoke
TEST=login_*Ownership*

Change-Id: Ib295a562735076fde84b8ad0d05e81bf6035fa23
Reviewed-on: https://gerrit.chromium.org/gerrit/50040
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Joao da Silva <joaodasilva@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

11 months agoHonor new guest 'magic string' in session_manager 37/50037/2
Chris Masone [Fri, 3 May 2013 15:44:20 +0000 (08:44 -0700)]
Honor new guest 'magic string' in session_manager

We're standardizing around using '' as the name for the guest user, so
make StartSession() accept that as well.

BUG=chromium:237815
TEST=unit
TEST=login_CryptohomeIncognitoMounted

Change-Id: Ida8abe323a7be3ee5f69c56d2df949553aa6f84a
Reviewed-on: https://gerrit.chromium.org/gerrit/50037
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Reviewed-by: Nikita Kostylev <nkostylev@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

11 months agoRemove superfluous check for user nssdb existence 35/49735/3
Chris Masone [Wed, 1 May 2013 17:45:23 +0000 (10:45 -0700)]
Remove superfluous check for user nssdb existence

Some time ago, we ensured that all cryptohomes were pre-populated with
an NSSDB at creation time.  As such, this logic to check if one exists
before trying to use it is now redundant.

BUG=None
TEST=unit
TEST=suite:smoke

Change-Id: I892e09fb5f71c400964daab9a270b1bcad316d8c
Reviewed-on: https://gerrit.chromium.org/gerrit/49735
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

11 months agoUse one NssUtil instance, owned by SessionManagerService 15/49115/4 stabilize-4068.0.B
Chris Masone [Wed, 24 Apr 2013 23:24:23 +0000 (16:24 -0700)]
Use one NssUtil instance, owned by SessionManagerService

This removes the last remnants of the factory pattern used to allow
any class to instantiate an NssUtil at any time, which was kinda awkward
anyhow.

BUG=chromium:235197
TEST=unit
STATUS=Fixed

Change-Id: I68ca763966693d41d51161989c452d03dfe9cb97
Reviewed-on: https://gerrit.chromium.org/gerrit/49115
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
11 months agoUse a single KeyGenerator, owned by SessionManagerService 97/49097/3
Chris Masone [Wed, 24 Apr 2013 21:39:57 +0000 (14:39 -0700)]
Use a single KeyGenerator, owned by SessionManagerService

Code in SessionManagerService is written assuming that there's only
one KeyGenerator object in use by the process, while the reality is
that we have one used when mitigating the loss of an owner keypair and
another used when generating an owner keypair for the first time.

Fix this up so that there's only one.

BUG=chromium:235185
TEST=unit
TEST=login_OwnershipRetaken, login_OwnershipTaken
STATUS=Fixed

Change-Id: Ida69cc03ca2cf08856c69491dc9f527f69f5e4dd
Reviewed-on: https://gerrit.chromium.org/gerrit/49097
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
11 months agoRemove username payload from SessionStateChanged 72/48972/2
Chris Masone [Tue, 23 Apr 2013 21:56:03 +0000 (14:56 -0700)]
Remove username payload from SessionStateChanged

The SessionStateChanged signal and RetrieveSessionState method
shouldn't report what user's session has started.  This data
isn't used, and reporting it will only become more complicated
in a multiprofile world.

The signature of RetrieveSessionState is changed in this CL
because it only has one caller, and the CL to change the
callsite will go in at the same time.

CQ-DEPEND=CL:48958
CQ-DEPEND=CL:48960
BUG=chromium:234763
TEST=unit
TEST=with above CLs, watch powerd logs while starting/ending sessions, and restarting powerd.
TEST=with above CLs, run the following autotests:
   - platform_CrosDisksDBus
   - platform_CrosDisksArchive
   - platform_CrosDisksFilesystem

Change-Id: Ic7636e8b9f6e5da35d5e7aa23114533869f9a604
Reviewed-on: https://gerrit.chromium.org/gerrit/48972
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

11 months agoThe screen should be 'locked' when the lock process begins 64/48964/2
Chris Masone [Tue, 23 Apr 2013 21:35:14 +0000 (14:35 -0700)]
The screen should be 'locked' when the lock process begins

The session_manager handles browser crashes while the screen is locked
specially, in that it ends the user session instead of restarting the
browser.  This is to keep user data safe; the user has indicated that
she wants someone to have to reauthenticate to see her stuff, and if a
crash happens while the screen is locked and we just restart things,
we'd be violating that.

The old behavior was to trigger that behavior only if we'd succeeded
in putting the lock screen up.  Instead, we should trigger the behavior
as soon as we know the user asked for screen lock.

BUG=chromium:233827
TEST=unit

Change-Id: Icfadce9c51f83c29963cab93aa66781ba1aa57a5
Reviewed-on: https://gerrit.chromium.org/gerrit/48964
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
11 months ago[login_manager] Increase default tile size to 512x512 on hi-dpi devices. 99/48899/2
David Reveman [Tue, 23 Apr 2013 15:45:57 +0000 (11:45 -0400)]
[login_manager] Increase default tile size to 512x512 on hi-dpi devices.

BUG=chromium:178317
TEST=local build, tested on link

Change-Id: Iae99b69a82d2c77a5e321efd61e0a956c7d96c49
Reviewed-on: https://gerrit.chromium.org/gerrit/48899
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>
11 months agoRemove 'OVERRIDE' from non virtual function. 77/48577/3 stabilize-4035.0.B
Yunlian Jiang [Thu, 18 Apr 2013 23:09:12 +0000 (16:09 -0700)]
Remove 'OVERRIDE' from non virtual function.

BUG=chromium:233393
TEST=CXXFLANGS="-clang" FEATURES="test" emerge-lumpy chromeos-login
     passes

Change-Id: I07fbe3d8b53da2367db08c51fa977a6902975d9f
Reviewed-on: https://gerrit.chromium.org/gerrit/48577
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
11 months agoRemove unused MockNssUtil subclasses 49/48449/2
Chris Masone [Thu, 18 Apr 2013 01:57:55 +0000 (18:57 -0700)]
Remove unused MockNssUtil subclasses

Nothing uses ShortKeyGenerator or ShortKeyUtil anymore, so
get rid of them.

BUG=None
TEST=unit

Change-Id: Ia9b8a1a3aa451312fe7f73e5254a9467a82dcbad
Reviewed-on: https://gerrit.chromium.org/gerrit/48449
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

11 months agoRemove Sign() from PolicyKey class 94/48394/4
Chris Masone [Wed, 17 Apr 2013 19:44:13 +0000 (12:44 -0700)]
Remove Sign() from PolicyKey class

PolicyKey really represents the public half of a key pair.  In retrospect,
it's weird to have it provide a Sign() method that silently goes and
finds its private half in some implicit NSSDB in order to generate
a signature.  This becomes even funkier when we move to a world where
the session_manager is tracking multiple user sessions, each with its
own NSSDB.  So, get rid of this abstraction and make code that signs
things call NssUtil methods directly.  This will ease the transition
to multiprofile.

BUG=chromium:221770
TEST=unit tests
TEST=login_*Ownership* autotests

Change-Id: I78a32cb288b9712519f0fa81d4d8760a4c576fc6
Reviewed-on: https://gerrit.chromium.org/gerrit/48394
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
11 months agoRemove redundant --ui-enable-threaded-compositing flag. 70/47770/3
Jonathan Backer [Wed, 10 Apr 2013 20:33:28 +0000 (16:33 -0400)]
Remove redundant --ui-enable-threaded-compositing flag.

As of crrev.com/193431 this flag is on by default in Chromium for
ChromeOS builds. This has no functional change.

BUG=chromium:173417
TEST=local build, run on stumpy

Change-Id: If2c287453f7c44701c046a2c91d559105812754a
Reviewed-on: https://gerrit.chromium.org/gerrit/47770
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Tested-by: Jonathan Backer <backer@chromium.org>
11 months agoRemove redundant --ui-enable-partial-swap flag. 40/48240/3
Jonathan Backer [Tue, 16 Apr 2013 19:08:28 +0000 (15:08 -0400)]
Remove redundant --ui-enable-partial-swap flag.

As of crrev.com/193763 this flag is on by default in Chromium for
ChromeOS builds. This CL should have no functional change.

BUG=chromium:173417
TEST=local build, run on stumpy

Change-Id: Iec1bf4b77c674d41def7f95ece54d83bb08eb1a3
Reviewed-on: https://gerrit.chromium.org/gerrit/48240
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Tested-by: Jonathan Backer <backer@chromium.org>
11 months agoAdjust touch-calibration for recent touchscreen config changes. 98/48498/2
Yuly Novikov [Thu, 18 Apr 2013 15:52:48 +0000 (11:52 -0400)]
Adjust touch-calibration for recent touchscreen config changes.

https://gerrit-int.chromium.org/#/c/35850/ increased size of bottom bezel,
so increase it here as well.

BUG=chromium:226290
TEST=Verify that touches are properly vertically aligned (see bug).
Also verify that bottom bezel gesture behaves as expected.

Change-Id: Iee9cf68b1333483c21a9ecab7768a754080eed1f
Reviewed-on: https://gerrit.chromium.org/gerrit/48498
Reviewed-by: Yufeng Shen <miletus@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tested-by: Yuly Novikov <ynovikov@chromium.org>
11 months agoIncrease the default auto-enrollment upload bits to 6. 92/48492/2
Joao da Silva [Thu, 18 Apr 2013 08:58:20 +0000 (12:58 +0400)]
Increase the default auto-enrollment upload bits to 6.

The auto-enrollment check uploads a limited number of bits from the
hash of the device serial number to determine the device's bucket on the
server-side. The buckets are now large enough that an additional bit is
required.

BUG=chromium:233111
TEST=Auto-enrollment still works.

Change-Id: I4acd37b06c21a02f0606f91aa0526e901c746d49
Reviewed-on: https://gerrit.chromium.org/gerrit/48492
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>
11 months agoFix '-Wbind-to-temporary-copy' warning with clang. 34/48134/5
Yunlian Jiang [Mon, 15 Apr 2013 20:50:36 +0000 (13:50 -0700)]
Fix '-Wbind-to-temporary-copy' warning with clang.

This fixes the error
user_policy_service.cc:72:25: error: C++98 requires an
accessible copy constructor for class 'login_manager::PolicyService::Error'
when binding a reference to a temporary; was private [-Werror,-Wbind-to-temporary-copy]
completion->Failure(Error(CHROMEOS_LOGIN_ERROR_DECODE_FAIL, msg));
                        ^
/login_manager/policy_service.h:60:30: note: declared
      private here
    DISALLOW_COPY_AND_ASSIGN(Error);
                             ^
/build/lumpy/usr/include/base-180609/base/basictypes.h:74:3: note: expanded from
macro 'DISALLOW_COPY_AND_ASSIGN' TypeName(const TypeName&);

BUG=chromium:231403
TEST=the clang syntax checking passed.
Change-Id: I7999173fdba2062c693346dee0b3663e7250afb0
Reviewed-on: https://gerrit.chromium.org/gerrit/48134
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
12 months agoMove the sentinel flags definitions to a common header shared by Chrome and ChromeOS 43/47643/2 stabilize-4008.0.B
Julian Pastarmov [Tue, 9 Apr 2013 15:02:17 +0000 (17:02 +0200)]
Move the sentinel flags definitions to a common header shared by Chrome and ChromeOS

BUG=chromium:221354
TEST=Still compiles and passes unit tests.
CQ-DEPEND=Id611c8d6eb9362fc85ee8c19c78998a118d9b0a3

Change-Id: Icea7a1076ac1716800ffab474c5065237619496e
Reviewed-on: https://gerrit.chromium.org/gerrit/47643
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>
12 months agoUpdate to new common.mk, fix Makefile errors 95/47595/2
Chris Masone [Mon, 8 Apr 2013 21:26:25 +0000 (14:26 -0700)]
Update to new common.mk, fix Makefile errors

The clean: rule for cros-xauth was broken, and the one for $(TEST_BIN) was
a bit funky too.  Also, update to the new common.mk.

BUG=None
TEST=cros_workon_make chromeos-login, then make clean in src/platform/login_manager.  cros-xauth should be deleted.

Change-Id: I21cc43b3b535fffe75e53079483c6445ae75633e
Reviewed-on: https://gerrit.chromium.org/gerrit/47595
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

12 months agoMake sure we support flags with and without dashes. 11/47311/3
Julian Pastarmov [Thu, 4 Apr 2013 11:28:19 +0000 (13:28 +0200)]
Make sure we support flags with and without dashes.

Further sanitize flags that are empty since this can trick chrome in thinking
that consecutive flags are plain arguments.

BUG=chromium-os:39251
TEST=DevicePolicyServiceTest.StartUpFlagsSanitizer

Change-Id: I0bfe004530b79dce8b6536fdf3d5e0ad388eacbd
Reviewed-on: https://gerrit.chromium.org/gerrit/47311
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>
12 months ago[login_manager] Reduce ResourcePool size when possible. 86/47286/2
David Reveman [Wed, 3 Apr 2013 22:38:01 +0000 (18:38 -0400)]
[login_manager] Reduce ResourcePool size when possible.

Reduce maximum amount of unused resource memory with impl-side
painting to 5% of total memory budget by adding:
--max-unused-resource-memory-usage-percentage=5

BUG=chromium:179460
TEST=local build, tested on daisy and link

Change-Id: I76d7ee44bab0e829e2ee5c8428e85e84a15a91c5
Reviewed-on: https://gerrit.chromium.org/gerrit/47286
Tested-by: David Reveman <reveman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>

12 months ago[login] repair accidentally-uppercased policy dirs 61/47061/4
Elly Fong-Jones [Mon, 1 Apr 2013 22:48:57 +0000 (18:48 -0400)]
[login] repair accidentally-uppercased policy dirs

These were created uppercase because of crbug.com/225472; migrate them to
lowercase.

BUG=chromium:225472,chromium:225487
TEST=unit

Change-Id: Ic28d9c5cf95a93fb201a174d6ebe3b1bcc122daa
Signed-off-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/47061
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
12 months ago[login_manager] Add --enable-impl-side-painting flag. 06/45506/3
David Reveman [Tue, 22 Jan 2013 22:35:02 +0000 (17:35 -0500)]
[login_manager] Add --enable-impl-side-painting flag.

BUG=chromium:178317
TEST=local build, tested on daisy and link

Change-Id: I246ffa60177011c41175bb97781ebd867bc17de4
Reviewed-on: https://gerrit.chromium.org/gerrit/45506
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Zelidrag Hornung <zelidrag@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>

12 months agologin_manager: Calculate gmock/gtest library dependencies programatically 26/46426/4
Gaurav Shah [Sun, 24 Mar 2013 22:47:14 +0000 (15:47 -0700)]
login_manager: Calculate gmock/gtest library dependencies programatically

This makes package upgrades for gmock/gtest easier (1.6 adds a pthreads
dependency).

BUG=chromium:211445
TEST=build tests for package using gtest 1.6

Change-Id: I14f87bb4b884b30bf51e33e16fa96752638a0055
Reviewed-on: https://gerrit.chromium.org/gerrit/46426
Commit-Queue: Gaurav Shah <gauravsh@chromium.org>
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
Tested-by: Gaurav Shah <gauravsh@chromium.org>
12 months agoGuard the policy added flags with sentinel flags. 62/46162/2
Julian Pastarmov [Thu, 21 Mar 2013 21:25:27 +0000 (22:25 +0100)]
Guard the policy added flags with sentinel flags.

That way it will be easier for the client to decide and do filtering
on those flags whenever required.

BUG=chromium:221354
TEST=Set the StartUpFlags policy and verify that the sentinel flags are present.

Change-Id: I3ad56f0c6b92eb9a2bc66783d8712da2a3c47d57
Reviewed-on: https://gerrit.chromium.org/gerrit/46162
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>

12 months ago[login_manager] Enable --enable-impl-side-painting flag when using highdpi. 18/45618/2
David Reveman [Fri, 15 Mar 2013 20:56:02 +0000 (16:56 -0400)]
[login_manager] Enable --enable-impl-side-painting flag when using highdpi.

BUG=chromium:178317
TEST=local build, tested on daisy and link

Change-Id: Ied1954ea565ec392cb958224effd0091db262514
Reviewed-on: https://gerrit.chromium.org/gerrit/45618
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Tested-by: David Reveman <reveman@chromium.org>
12 months agoEnforce the StartUpFlags device policy through session manager. 34/45434/10
Julian Pastarmov [Fri, 15 Mar 2013 17:02:53 +0000 (18:02 +0100)]
Enforce the StartUpFlags device policy through session manager.

In order to make sure flags specified through policy are enforced
and applied before the browser had the chance to initialize we
should set them through session manager before it spawns the
browser process. This feature will not be exposed until we have
some way to ensure that only the set of flags inteded to be used
through this mechanism is enfoced either in the session manager or
on the browser side.

BUG=chromium-os:39251
TEST=Set the policy and check that the policy is respected.

Change-Id: I1bc5e0bfd93bcb61230a0c87f9d63edee00dfaea
Reviewed-on: https://gerrit.chromium.org/gerrit/45434
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>

13 months agosession_manager should refuse to lock outside user session 17/45517/2 factory-spring-3842.B stabilize-3881.0.B
Chris Masone [Thu, 14 Mar 2013 23:26:28 +0000 (16:26 -0700)]
session_manager should refuse to lock outside user session

If there's no currently active user session, locking the
screen isn't a sensical thing to do.  So...refuse to do it.

BUG=chromium:174488
TEST=unit
TEST=desktopui_ScreenLocker still passes

Change-Id: I574936a05b7737de2f8197133e448f77cc928841
Reviewed-on: https://gerrit.chromium.org/gerrit/45517
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

13 months agoLimit the number of UI frames in flight to at most 1. 40/45340/3
Jonathan Backer [Wed, 13 Mar 2013 21:01:07 +0000 (17:01 -0400)]
Limit the number of UI frames in flight to at most 1.

By limiting the number of frames in flight, we are less likely to have
a blocking call to SwapBuffers or MakeCurrent (gated on vblank). This
can lead to smoother scroll and video playback.

BUG=chromium:181317,chromium:189142
TEST=local build, run on daisy and link
Change-Id: I4d1579f70e6d05eb3aa92959862c94be3fa3776f
Reviewed-on: https://gerrit.chromium.org/gerrit/45340
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Tested-by: Jonathan Backer <backer@chromium.org>
13 months agoRe-enable EVDA 58/45258/2
John Sheu [Tue, 12 Mar 2013 22:13:14 +0000 (15:13 -0700)]
Re-enable EVDA

Remaining video decode issues on Exynos are not EVDA-specific, so
re-enable EVDA.

BUG=chromium-os:37807
BUG=chromium:173201

TEST=local build, run on Exynos

Change-Id: I4833b0cdb878160eab238353eee49c9f9e491165
Reviewed-on: https://gerrit.chromium.org/gerrit/45258
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: St├ęphane Marchesin <marcheu@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Tested-by: John Sheu <sheu@chromium.org>
Commit-Queue: John Sheu <sheu@chromium.org>

13 months agoRemoved auto-login switch by popular demand. 25/45225/2 firmware-spring-3833.B
Zelidrag Hornung [Tue, 12 Mar 2013 17:52:52 +0000 (10:52 -0700)]
Removed auto-login switch by popular demand.

BUG=none
TEST=make sure that 'Do you want to sign in as ...' info bar does not show up anymore.

Change-Id: I29a6cfa0bc56e75de9f6ac2338b2b7bacc0843f1
Reviewed-on: https://gerrit.chromium.org/gerrit/45225
Tested-by: Zelidrag Hornung <zelidrag@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Zelidrag Hornung <zelidrag@chromium.org>

13 months agoRemove /tmp/machine-info deletion code from session_manager. 91/44091/3
Mattias Nissler [Tue, 26 Feb 2013 20:52:32 +0000 (21:52 +0100)]
Remove /tmp/machine-info deletion code from session_manager.

This is now handled by the /etc/init/machine-info.conf script.

BUG=chromium-os:26681
TEST=/tmp/machine-info.conf is not present after session start on unowned device.

Change-Id: I313c0eb849facbbb54620c8ce8ba227e0e1c49fa
Reviewed-on: https://gerrit.chromium.org/gerrit/44091
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Mattias Nissler <mnissler@chromium.org>
Tested-by: Mattias Nissler <mnissler@chromium.org>
13 months agoPass --enable-experimental-bluetooth for BlueZ 5 00/44900/3 firmware-spring-3824.4.B firmware-spring-3824.55.B firmware-spring-3824.84.B firmware-spring-3824.B
Scott James Remnant [Fri, 8 Mar 2013 01:46:54 +0000 (17:46 -0800)]
Pass --enable-experimental-bluetooth for BlueZ 5

BUG=chromium-os:38832
TEST=start ui on machine with older and newer bluez

Change-Id: Ifda54669eaaa508eeb8334e61b062ce9440321b1
Reviewed-on: https://gerrit.chromium.org/gerrit/44900
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Zelidrag Hornung <zelidrag@chromium.org>
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
13 months agocros-xauth: mini replacement for xauth 02/44402/6
Mike Frysinger [Fri, 1 Mar 2013 19:15:16 +0000 (14:15 -0500)]
cros-xauth: mini replacement for xauth

The xauth package depends on a bunch of libs that no one else does to
support legacy formats we don't care about.  Since we only need it to
write out a <100 byte file, implement the logic ourselves.

BUG=chromium-os:39422
TEST=`./cros-xauth foo` produced a file that looks right

Change-Id: I4c2de5effcde627fcd7d4e3063892091814f6a94
Reviewed-on: https://gerrit.chromium.org/gerrit/44402
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
13 months agoDisable accelerated-overflow-scroll 22/44522/2
Chris Wolfe [Mon, 4 Mar 2013 14:55:41 +0000 (09:55 -0500)]
Disable accelerated-overflow-scroll

There are lingering bugs in accelerated overflow scrolling, so
disable it on ToT.

BUG=chromium:179714
TEST=lumpy paladin trybot

Change-Id: I296d3ca47d037cfc89ffedfd264008ea3fe939d4
Reviewed-on: https://gerrit.chromium.org/gerrit/44522
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Commit-Queue: Chris Wolfe <cwolfe@chromium.org>
Tested-by: Chris Wolfe <cwolfe@chromium.org>
13 months agosession_manager: Modify ACCELERATED_FLAGS for EGL/GLX 33/43033/6
abhinav [Mon, 11 Feb 2013 13:49:27 +0000 (19:19 +0530)]
session_manager: Modify ACCELERATED_FLAGS for EGL/GLX

Modify session_manager_setup.sh to force
chrome to follow EGL/GLX rendering based
on egl flag defined selectively for a
specific overlay.

BUG=None
TEST=Build and boot till UI login screen
with S/W X11 Mesa libs on Ricochet overlay.
Build and boot till UI on Daisy.

Change-Id: I209fe1eac367e5a0163f79db6f9cdd6cba273416
Signed-off-by: abhinav <abhinav@chromium.org>
Signed-off-by: Arjun.K.V <arjun.kv@samsung.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/43033
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Katie Roberts-Hoffman <katierh@chromium.org>
Reviewed-by: Katie Roberts-Hoffman <katierh@chromium.org>
Tested-by: Katie Roberts-Hoffman <katierh@chromium.org>
13 months agosession: Re-enable Chrome liveness checks and use SIGFPE. 68/43968/3
Daniel Erat [Mon, 25 Feb 2013 22:33:51 +0000 (14:33 -0800)]
session: Re-enable Chrome liveness checks and use SIGFPE.

This re-enables the session manager's periodic Chrome
liveness checks via D-Bus.  It also makes the session
manager send SIGFPE rather than SIGABRT to make it easier to
distinguish liveness-check-induced crashes from other
crashes.

BUG=chromium-os:35729,chromium-os:38892
TEST=unit tests and desktopui_HangDetector pass; also
     manually tested that SIGFPE is sent after inducing a
     chrome hang via gdb

Change-Id: Iad40dc0d240bd97f4684192ec6e0160a8ea92594
Reviewed-on: https://gerrit.chromium.org/gerrit/43968
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
13 months agosession_manager_setup.sh: Remove network_change_notifer.cc logging 72/43972/2
Gaurav Shah [Tue, 20 Nov 2012 01:11:47 +0000 (17:11 -0800)]
session_manager_setup.sh: Remove network_change_notifer.cc logging

crosbug.com/34399 was recently root caused and fixed. So remove the logging
we added to help investigate it.

BUG=chromium-os:34399
TEST=see no vlogs network_change_notifier

Change-Id: Ied1c1f611d9d2b3bdd96d24b133e3972ba5a179c
Reviewed-on: https://gerrit.chromium.org/gerrit/43972
Reviewed-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Gaurav Shah <gauravsh@chromium.org>
Tested-by: Gaurav Shah <gauravsh@chromium.org>
13 months agoRemove unused SessionManagerImpl::CurrentUser() 69/43969/2
Chris Masone [Mon, 25 Feb 2013 22:38:30 +0000 (14:38 -0800)]
Remove unused SessionManagerImpl::CurrentUser()

This method was incorrectly tagged as being an override.  It's
also totally unused, though, so just remove it.

BUG=chromium-os:39222
TEST=unit tests

Change-Id: I3ef9d27c1cf5be0640e4fa53a5e1d202e512b910
Reviewed-on: https://gerrit.chromium.org/gerrit/43969
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Guozhi Wei <carrot@google.com>
Reviewed-by: Chris Masone <cmasone@chromium.org>
13 months agologin_manager: Updating common.mk to ToT to enable profiling 88/42788/3
Ryan Harrison [Wed, 6 Feb 2013 21:41:47 +0000 (16:41 -0500)]
login_manager: Updating common.mk to ToT to enable profiling

This update replaces the current common.mk used in this project with the newest
version. This will allow all of the common.mk based projects to be on the same
version for debugging and enables profiling support.

BUG=chromium-os:37854
TEST=Exectuted the following commands to confirm the build works:
     MODE=profiling cros_workon_make --board=link
     MODE=profiling cros_workon_make --board=link --test
     cros_workon_make --board=link
     cros_workon_make --board=link --test
     Repeated these with emerge-link, USE=profiling, and
     FEATURES=test as need.
     For the emerge command with profiling and testing enable, confirmed the
     appropriate coverage files were created in /usr/share/profiling/...

Change-Id: I168c48af4f3997a12449b9ba75b0b4302202e456
Reviewed-on: https://gerrit.chromium.org/gerrit/42788
Tested-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>

13 months agoSet audio buffer size to 2048. 02/43702/3
Dylan Reid [Thu, 21 Feb 2013 01:52:32 +0000 (17:52 -0800)]
Set audio buffer size to 2048.

Chrome recently changed the default buffer size from 2048 to 512.  Set
it back to 2048 because 512 causes problems with USB audio devices.
This needs to be fixed, but will not happen in time to be merged to
R26.

BUG=chromium-os:39017
TEST=gmerge chromeos-login and check audio buffer size.

Change-Id: Ibd9c987737c65fda4cddf0c85736d39ef2a0c7e9
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/43702
Reviewed-by: Chris Masone <cmasone@chromium.org>
13 months agoUnify shutdown code pathways in SessionManagerService 58/43558/4
Chris Masone [Tue, 19 Feb 2013 23:58:13 +0000 (15:58 -0800)]
Unify shutdown code pathways in SessionManagerService

I added a ScheduleShutdown() method for SessionManagerImpl to call
that was a bit redundant with the private method SetExitAndServiceShutdown.
This change converts the former into a convenience wrapper around the
latter.

BUG=None
TEST=unit
TEST=Smoke suite

Change-Id: Iab99cb941ad4abd442b44e9b7b285441703419ef
Reviewed-on: https://gerrit.chromium.org/gerrit/43558
Commit-Queue: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
13 months agoRemove deprecated MessageLoop calls from SessionManagerService 40/43540/5
Chris Masone [Tue, 19 Feb 2013 22:22:42 +0000 (14:22 -0800)]
Remove deprecated MessageLoop calls from SessionManagerService

MessageLoop::Run() is deprecated.  Replace with instantiation and
use of RunLoop objects.

BUG=chromium-os:38845
TEST=unit
STATUS=Fixed

Change-Id: I19f3a49af077c8bb6256e8ed8d054746d354101c
Reviewed-on: https://gerrit.chromium.org/gerrit/43540
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
13 months agoTemporarily disable EVDA for Snow until related bugs are fixed. 62/43562/4
Pawel Osciak [Wed, 20 Feb 2013 00:05:41 +0000 (16:05 -0800)]
Temporarily disable EVDA for Snow until related bugs are fixed.

BUG=chromium:173201
TEST=manual

Change-Id: I504911d7713e270e7c17e51fa0fb5a6ae692d9ef
Reviewed-on: https://gerrit.chromium.org/gerrit/43562
Reviewed-by: John Sheu <sheu@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Tested-by: Pawel Osciak <posciak@chromium.org>
13 months agoAdd /var/run bind mount for debugfs GPU memory dir 46/43446/2
James Cook [Fri, 15 Feb 2013 23:47:36 +0000 (15:47 -0800)]
Add /var/run bind mount for debugfs GPU memory dir

/sys/kernel/debug is now only readable by debugd. However, Chrome
sometimes needs real-time access to GEM object memory information in
/sys/kernel/debug/dri/0. Add a bind mount for this specific directory
to /var/run.

BUG=chromium:175828
TEST=manual, verify /var/run/debugfs_gpu exists and files inside are
readable by chronos

Change-Id: I6d7ece58359a2e4a40204ccc94fbe6891df659bc
Reviewed-on: https://gerrit.chromium.org/gerrit/43446
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Tested-by: James Cook <jamescook@chromium.org>
13 months ago[login_manager] Build against new libchrome, libchrome_crypto 21/43121/5
Chris Masone [Tue, 12 Feb 2013 19:52:07 +0000 (11:52 -0800)]
[login_manager] Build against new libchrome, libchrome_crypto

The main difference is that MessageLoop::RunAllPending() -- used
a lot in unit tests -- has been removed.  It's replaced with a
RunLoop class in libchrome, so convert test code to use that
instead.

CQ-DEPEND=CL:43122 CL:43099 CL:43100

BUG=chromium-os:38842
TEST=build and run unittests.

Change-Id: Id46c54d2302c1df22d117b6ecbbba9bc7d7135cb
Reviewed-on: https://gerrit.chromium.org/gerrit/43121
Reviewed-by: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

14 months agosession_manager: Unset --enable-hang-detection. 39/43239/2
Daniel Erat [Thu, 14 Feb 2013 00:11:43 +0000 (16:11 -0800)]
session_manager: Unset --enable-hang-detection.

This turns off the session manager's Chrome liveness checks
to determine if they're responsible for an increase in
Chrome SIGABRT crashes within poll() in 25.

BUG=chromium-os:38892
TEST=manual: built an image; flag isn't passed

Change-Id: Iadbc7d80fd736b9d662a9aaff40c2d8a6248907c
Reviewed-on: https://gerrit.chromium.org/gerrit/43239
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
14 months agosession: Let "power" user call StopSession D-Bus method. 73/42973/2 stabilize-bluetooth-smart
Daniel Erat [Sat, 9 Feb 2013 00:35:59 +0000 (16:35 -0800)]
session: Let "power" user call StopSession D-Bus method.

The power manager needs to be able to call the session
manager's StopSession method if Chrome has set a policy
where users are logged out after being inactive.

BUG=chromium-os:38281
TEST=manual: user is logged out after timeout after setting
     idle action to stop_session
TBR=cmasone@chromium.org

Change-Id: I95762bed903b6fd2761edf18b6d0baad0c91b7de
Reviewed-on: https://gerrit.chromium.org/gerrit/42973
Commit-Queue: Daniel Erat <derat@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
14 months agoEnable platform specific optimizations on all Exynos based machines 02/42902/5
Vincent Palatin [Thu, 7 Feb 2013 23:06:55 +0000 (15:06 -0800)]
Enable platform specific optimizations on all Exynos based machines

We want to use EVDA and libvpx specific NEON optimizations on all boards
using Exynos system on chips.
So we just check for the "exynos" USE flag (added to the IUSE clause of
the ebuild) instead of testing the board name.

BUG=chrome-os-partner:17747
TEST=on Spring and Snow, run "ps aux | grep exynos" and see Chrome processes
running with the "--use-exynos-vda" flag.
on Link, run trybot software and check chrome processes flags.

CQ-DEPEND=I62da533ea9e9e3b82447b95aa6d4f2486a0631a7

Change-Id: I04da1244f6b51fd8de51ad09c3daf7e5205278ca
Reviewed-on: https://gerrit.chromium.org/gerrit/42902
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Vincent Palatin <vpalatin@chromium.org>

14 months agoWrite the user policy key in a subdirectory of /var/run/user_policy. 42/42542/4
Joao da Silva [Mon, 4 Feb 2013 17:31:46 +0000 (18:31 +0100)]
Write the user policy key in a subdirectory of /var/run/user_policy.

This will make it easier to cache additional data per user in that
directory, in case that is ever needed.

BUG=chromium:163318
TEST=sign-in; /var/run/user_policy/$hash/policy.pub contain the user's policy
key. sign-out; the directory has been wiped.

Change-Id: I2aeb4679350bfdb5851246604db89a19cbeed5a4
Reviewed-on: https://gerrit.chromium.org/gerrit/42542
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>
14 months agoForce PPAPI plugin to run out of process on Daisy. 23/42423/2 stabilize-3658.0.0
Xiaohan Wang [Thu, 31 Jan 2013 23:41:33 +0000 (15:41 -0800)]
Force PPAPI plugin to run out of process on Daisy.

This is in preparation for a new Netflix plugin to be landed on Daisy, which
requires to run out of process.

In general, it is recommended to run PPAPI plugins out of process by PPAPI team.
Since currently we don't really have any PPAPI plugin running in-process on
Daisy, the risk of this change is small.

BUG=none
TEST=Tested on Daisy and existing plugins work fine.

Change-Id: Ic826ef5a407b4450deee04debe945c9066fa723f
Reviewed-on: https://gerrit.chromium.org/gerrit/42423
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Tested-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>

14 months ago[chromeos-login] don't mount /tmp/cgroups 25/42025/2
Elly Fong-Jones [Fri, 25 Jan 2013 19:06:59 +0000 (14:06 -0500)]
[chromeos-login] don't mount /tmp/cgroups

Nobody uses it after https://chromiumcodereview.appspot.com/12036104/

BUG=chromium-os:32633
TEST=adhoc
mount | grep cgroups does not show /tmp/cgroups

Change-Id: I10d0bc88d8cb2295dce828d377b563598dcbfcb1
Signed-off-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/42025
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
14 months agoRevert: Disable --ui-prioritize-in-gpu-process on daisy 34/42034/2
Jonathan Backer [Fri, 25 Jan 2013 21:06:47 +0000 (16:06 -0500)]
Revert: Disable --ui-prioritize-in-gpu-process on daisy

BUG=chrome-os-partner:17175
TEST=manual

Change-Id: I8e62a013a487440a1a4ad0ef78dbbeeff9f1c48a
Reviewed-on: https://gerrit.chromium.org/gerrit/42034
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Tested-by: Jonathan Backer <backer@chromium.org>
14 months agoAdded auto-login (browser only) switch, removed unnecessary compositing switches. 48/41648/6
Zelidrag Hornung [Fri, 18 Jan 2013 18:40:27 +0000 (10:40 -0800)]
Added auto-login (browser only) switch, removed unnecessary compositing switches.

Browser auto login is stil needed on ChromeOS for following use cases:
- User can nuke their auth cookie (i.e. click on sign out) and still land on GAIA sign in page
- Auth cookie session restore does not block login and you can end up with your browser session restored before we get all GAIA cookies merged.

BUG=chromium:170948
TEST=none

Change-Id: I1982d59359a3a875756fb7b9866aa7a4664ef03c
Reviewed-on: https://gerrit.chromium.org/gerrit/41648
Commit-Queue: Zelidrag Hornung <zelidrag@chromium.org>
Reviewed-by: Zelidrag Hornung <zelidrag@chromium.org>
Tested-by: Zelidrag Hornung <zelidrag@chromium.org>
14 months agologin: Update reference to deprecated constant. 26/41826/2
Daniel Erat [Wed, 23 Jan 2013 18:17:00 +0000 (10:17 -0800)]
login: Update reference to deprecated constant.

This changes a reference to
power_manager::kRequestRestartSignal to
kRequestRestartMethod.  (Both contain the same value,
"RequestRestart".)

BUG=none
TEST=built it

Change-Id: Id6e4c77d469b32579bd20c70d439625df75e1f4a
Reviewed-on: https://gerrit.chromium.org/gerrit/41826
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>