chromiumos/platform/system_api.git
14 months agoRemove ReleaseTrack related constants out of DBus. 38/63838/2 master release-R30-4537.B stabilize-4512.B
Chris Sosa [Wed, 31 Jul 2013 01:19:35 +0000 (18:19 -0700)]
Remove ReleaseTrack related constants out of DBus.

Get/SetTrack methods have been deprecated. This CL removes their DBus
constants.

BUG=chromium:221850
TEST=Built with https://codereview.chromium.org/21015010

Change-Id: I8294d852e668bc789daeca28a0058ecf0686def4
Reviewed-on: https://gerrit.chromium.org/gerrit/63838
Reviewed-by: Darren Krahn <dkrahn@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>
Commit-Queue: Chris Sosa <sosa@chromium.org>

14 months agoAdded new cryptohome method CreateCertRequestByProfile. 02/63402/2
Darren Krahn [Thu, 25 Jul 2013 22:31:18 +0000 (15:31 -0700)]
Added new cryptohome method CreateCertRequestByProfile.

BUG=chromium:260504
TEST=emerge cryptohome

Change-Id: Ife8fdc2647553a664a0469873214560136236580
Reviewed-on: https://gerrit.chromium.org/gerrit/63402
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
Tested-by: Darren Krahn <dkrahn@chromium.org>
Commit-Queue: Darren Krahn <dkrahn@chromium.org>

14 months agoUpdate system_api GYP file to reflect current protos 31/61931/5
Liam McLoughlin [Mon, 15 Jul 2013 19:49:52 +0000 (12:49 -0700)]
Update system_api GYP file to reflect current protos

BUG=chromium:220003
TEST=Platform2 trybots pass

Change-Id: Idfe3c3b3875aee1acb3ee7281758745fc59f418e
Reviewed-on: https://gerrit.chromium.org/gerrit/61931
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Liam McLoughlin <lmcloughlin@chromium.org>
Commit-Queue: Liam McLoughlin <lmcloughlin@chromium.org>

14 months agoAdd MountPublic/AsyncMountPublic for cryptohome. 86/61586/2 factory-pit-4471.B firmware-pit-4482.B
Xiyuan Xia [Thu, 11 Jul 2013 19:40:02 +0000 (12:40 -0700)]
Add MountPublic/AsyncMountPublic for cryptohome.

BUG=chromium:243099
TEST=none.

Change-Id: Ie977fb06054bdec0dfbb24862173bab2d46585bb
Reviewed-on: https://gerrit.chromium.org/gerrit/61586
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Tested-by: Xiyuan Xia <xiyuan@chromium.org>
15 months agoAdd debugd GetWiMaxStatus DBus method. 75/62975/3 factory-4455.B
Ben Chan [Thu, 18 Jul 2013 20:52:22 +0000 (13:52 -0700)]
Add debugd GetWiMaxStatus DBus method.

BUG=chrome-os-partner:21256
TEST=emerge system_api

Change-Id: I368f826e10b8510bcae7cb150352e2d0350c0368
Reviewed-on: https://gerrit.chromium.org/gerrit/62975
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Philipp Neubeck <pneubeck@chromium.org>
Reviewed-by: Elly Jones <ellyjones@chromium.org>
15 months agoAdd WiMaxManager DBus interface names. 93/62593/2 stabilize-4443.B
Ben Chan [Thu, 18 Jul 2013 08:24:19 +0000 (01:24 -0700)]
Add WiMaxManager DBus interface names.

BUG=chrome-os-partner:21109
TEST=emerge system_api

Change-Id: I8d763b5145f607065d17ab21da8f3aa4578dcee8
Reviewed-on: https://gerrit.chromium.org/gerrit/62593
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
15 months agoapi: Add power_manager::UserActivityType enum. 65/61665/2
Daniel Erat [Fri, 12 Jul 2013 04:43:39 +0000 (21:43 -0700)]
api: Add power_manager::UserActivityType enum.

This will be passed to powerd's HandleUserActivity D-Bus
method by Chrome.

BUG=chromium:254841
TEST=built it

Change-Id: Ie41ae7e0dfe6abcec8cf69baab702f4b23a7960e
Reviewed-on: https://gerrit.chromium.org/gerrit/61665
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
15 months agosystem_api: add constant for LogKernelTaskStates 70/61270/2 factory-pit-4390.B firmware-falco_peppy-4389.B firmware-leon-4389.26.B firmware-wolf-4389.24.B
Yuly Novikov [Fri, 28 Jun 2013 00:23:26 +0000 (20:23 -0400)]
system_api: add constant for LogKernelTaskStates

BUG=chromium:244916
TEST=compiles

Change-Id: Ied63ea2e474a60f4643fb8e5c17239305516b4fc
Reviewed-on: https://gerrit.chromium.org/gerrit/61270
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Tested-by: Yuly Novikov <ynovikov@chromium.org>
15 months agoAdd SetProperties property for Shill 91/61291/2
Steven Bennetts [Tue, 9 Jul 2013 17:52:39 +0000 (10:52 -0700)]
Add SetProperties property for Shill

BUG=None
TEST=None

Change-Id: Ib7eb53dfd119b119e825efba70288c862413c0c0
Reviewed-on: https://gerrit.chromium.org/gerrit/61291
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: mukesh agrawal <quiche@chromium.org>
15 months agoapi: Remove VideoActivityUpdate protocol buffer. 28/60928/2
Daniel Erat [Wed, 3 Jul 2013 17:43:29 +0000 (10:43 -0700)]
api: Remove VideoActivityUpdate protocol buffer.

Chrome doesn't send these anymore.

Also update some comments in PowerSupplyProperties.

BUG=none
TEST=manual: did a build
CQ-DEPEND=I31f42ebeb44118120cc3e2e4a1fef483036dfb0b

Change-Id: I669da8f8244e43bdae3126d995d1f94e929aca21
Reviewed-on: https://gerrit.chromium.org/gerrit/60928
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
15 months agoDefine serialization format for Finch state. 33/59833/2
Chris Masone [Mon, 24 Jun 2013 20:59:16 +0000 (13:59 -0700)]
Define serialization format for Finch state.

We'd like to enable Chrome to push Finch experiment state to the rest of
the system, so we can run experiments outside the browser. To support this,
we want to allow Chrome to serialize this state to disk using a protobuf.

BUG=chromium:253627
TEST=protoc --cpp_out=. field_trial_list.proto

Change-Id: Ib943f63bf244503a39a8ec7b3a7dd8f0b5250038
Reviewed-on: https://gerrit.chromium.org/gerrit/59833
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

15 months agoAdd new cras dbus api for setting per audio node output volume and input gain. 51/60551/3
Jenny Zhang [Fri, 28 Jun 2013 23:22:10 +0000 (16:22 -0700)]
Add new cras dbus api for setting per audio node output volume and input gain.

Change-Id: I30e8cf10fecaa92b7e4d441413a7de3f71b7782e
BUG=chromium:244597
TEST=NONE
Reviewed-on: https://gerrit.chromium.org/gerrit/60551
Commit-Queue: <jennyz@google.com>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: <jennyz@google.com>
Tested-by: <jennyz@google.com>
15 months agoapi: Separate power manager idle actions for AC and battery. 22/60122/3
Daniel Erat [Wed, 26 Jun 2013 15:18:10 +0000 (08:18 -0700)]
api: Separate power manager idle actions for AC and battery.

This renames the PowerManagementPolicy protocol buffer's
|idle_action| field to |ac_idle_action| and adds a new
|battery_idle_action| field.

BUG=chromium:254404
TEST=built it
CQ-DEPEND=Ife6da36b23f83273277033b3d71f85c62c42f4c1

Change-Id: I89034188a1c8baee2e508372560187fb9e4a42f6
Reviewed-on: https://gerrit.chromium.org/gerrit/60122
Reviewed-by: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>

16 months agoAdd WebProxyAutoDiscoveryUrl property 90/59990/2
Paul Stewart [Tue, 25 Jun 2013 23:08:41 +0000 (16:08 -0700)]
Add WebProxyAutoDiscoveryUrl property

Add a property to be used in IPConfigs to display the Web Proxy
Auto Discovery URL as discovered over DHCP.

BUG=chromium:253915
TEST=Recompile shill

Change-Id: I88be8872c334fc5e612706f9d7625ff22930934b
Reviewed-on: https://gerrit.chromium.org/gerrit/59990
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
16 months agosystem_api: add constant for cryptohome AsyncAddKey 43/59543/2
Yuri Gorshenin [Fri, 21 Jun 2013 12:37:17 +0000 (16:37 +0400)]
system_api: add constant for cryptohome AsyncAddKey

BUG=chromium:243342
TEST=none

Change-Id: I8727c06adbf586f8cea2d556a61c62f8b07a37ad
Reviewed-on: https://gerrit.chromium.org/gerrit/59543
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Nikita Kostylev <nkostylev@chromium.org>
Tested-by: Yuri Gorshenin <ygorshenin@chromium.org>
Commit-Queue: Nikita Kostylev <nkostylev@chromium.org>
Tested-by: Nikita Kostylev <nkostylev@chromium.org>
16 months agosystem_api: add constants for {Get|Set}Channel. 27/59427/2 release-R29-4319.B
Yuri Gorshenin [Thu, 20 Jun 2013 14:37:46 +0000 (18:37 +0400)]
system_api: add constants for {Get|Set}Channel.

BUG=chromium:219292
TEST=none

Change-Id: I2f1b7e3122c059c939f7fef87404a3bb120122c1
Reviewed-on: https://gerrit.chromium.org/gerrit/59427
Reviewed-by: Yuri Gorshenin <ygorshenin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Yuri Gorshenin <ygorshenin@chromium.org>
Commit-Queue: Yuri Gorshenin <ygorshenin@chromium.org>

16 months agoRevert "system_api: Remove presentation_idle_delay_factor." 53/59453/2
Daniel Erat [Thu, 20 Jun 2013 19:20:16 +0000 (12:20 -0700)]
Revert "system_api: Remove presentation_idle_delay_factor."

This reverts commit 07f96f16, which removed a field that
Chrome was still setting.

BUG=chromium:248276
TEST=none

Change-Id: I128d3f48904fdd3b41f6cdd7cbb73408656febb0
Reviewed-on: https://gerrit.chromium.org/gerrit/59453
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
16 months agosystem_api: add constant for WiFiService frequency list 19/59119/2
mukesh agrawal [Tue, 18 Jun 2013 23:26:40 +0000 (16:26 -0700)]
system_api: add constant for WiFiService frequency list

BUG=chromium:248791
TEST=emerge-link system_api

Change-Id: Ib439b4dcf25e4de4883a91a9e04b58055ace3ae8
Reviewed-on: https://gerrit.chromium.org/gerrit/59119
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: mukesh agrawal <quiche@chromium.org>

16 months agoAdd a few OpenVPN property constants 18/58918/6 factory-4290.B stabilize-4287.B
Paul Stewart [Mon, 17 Jun 2013 21:51:28 +0000 (14:51 -0700)]
Add a few OpenVPN property constants

These constants were previously defined in shill, but they should
really be here in the common service constants file.

CQ-DEPEND=CL:58919
BUG=chromium:250999
TEST=shill unit tests

Change-Id: I7bca8f1a5796b4fec054fbefe923ce94c7f247ed
Reviewed-on: https://gerrit.chromium.org/gerrit/58918
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
16 months agosystem_api: Remove presentation_idle_delay_factor. 34/58534/3
Daniel Erat [Wed, 12 Jun 2013 21:17:09 +0000 (14:17 -0700)]
system_api: Remove presentation_idle_delay_factor.

This removes the PowerManagementPolicy protocol buffer's
deprecated presentation_idle_delay_factor field.

BUG=chromium:248276
TEST=built an image
CQ-DEPEND=Ia2676294d443488447bbb32e059f04765f8daca2

Change-Id: I640d5980c9a22314d6548e05680ad465f41bece7
Reviewed-on: https://gerrit.chromium.org/gerrit/58534
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>

16 months agoAdd OpenVPN.ExtraCertPEM property 26/58726/2
Paul Stewart [Fri, 14 Jun 2013 22:49:20 +0000 (15:49 -0700)]
Add OpenVPN.ExtraCertPEM property

Adds a property for specifying an extra set of certificates to
be used while completing the certificate chain from the remote
server.  None of these certificates can be used to directly sign
the remote server (these must come from the specified CA
certificate).

BUG=chromium:249363
TEST=Recompile shill

Change-Id: I997eb4e6cb73b121db4d896b24ad5a84f59dad98
Reviewed-on: https://gerrit.chromium.org/gerrit/58726
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
16 months agoAdd constant for debugd TestICMPWithOptions DBus call. 68/58668/2 factory-pit-4280.B
Xiaowen Xin [Fri, 14 Jun 2013 09:14:04 +0000 (02:14 -0700)]
Add constant for debugd TestICMPWithOptions DBus call.

BUG=chromium:249608
TEST=emerge-link system_api

Change-Id: Idb275436a18fc7086d7bf2befccb9eb2e3dfbb25
Reviewed-on: https://gerrit.chromium.org/gerrit/58668
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Xiaowen Xin <xiaowenx@chromium.org>
Tested-by: Xiaowen Xin <xiaowenx@chromium.org>
16 months agoapi: Scale dim, rather than idle, delays while presenting. 93/58193/2 factory-spring-4262.B
Daniel Erat [Mon, 10 Jun 2013 20:31:05 +0000 (13:31 -0700)]
api: Scale dim, rather than idle, delays while presenting.

This deprecates PowerManagementPolicy's
presentation_idle_delay_factor field and adds a new
presentation_screen_dim_delay_factor field. Basing the
scaling on the screen-dimming delay is more useful and
matches the style of scaling done by
user_activity_screen_dim_delay_factor.

BUG=chromium:248276
TEST=built it
CQ-DEPEND=I025a9c1cb9d7af1ae1e1c028744318295b1e85e5

Change-Id: I0bac41b585231fde1d5236ec1599c9756fe7aba2
Reviewed-on: https://gerrit.chromium.org/gerrit/58193
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>

16 months agoBluetooth: remove old names of constants 51/58351/2
Scott James Remnant [Wed, 8 May 2013 21:42:06 +0000 (14:42 -0700)]
Bluetooth: remove old names of constants

BUG=chromium:221813
TEST=compile chrome after CL to switch to new constant names

Change-Id: I1b0abef17b1a36ed890334e1f37fb66db76fcb59
Reviewed-on: https://gerrit.chromium.org/gerrit/58351
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
16 months agoAdd the constant for the SetFlagsForUser DBus call. 86/58186/2
Julian Pastarmov [Fri, 7 Jun 2013 12:23:30 +0000 (14:23 +0200)]
Add the constant for the SetFlagsForUser DBus call.

BUG=chromium:221352
TEST=none

Change-Id: I8ea1f37d6f8c2a33bf4aa7a9665ef4f97c1f1082
Reviewed-on: https://gerrit.chromium.org/gerrit/58186
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>
16 months agodbus: Add GetRichPerfData() method. 17/58117/2
Ahmad Sharif [Mon, 10 Jun 2013 20:42:29 +0000 (16:42 -0400)]
dbus: Add GetRichPerfData() method.

BUG=chromium:224056
TEST=none

Change-Id: Id0d84ed10dd66e13d7b00d4ac160da7640a74867
Reviewed-on: https://gerrit.chromium.org/gerrit/58117
Reviewed-by: Simon Que <sque@chromium.org>
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Commit-Queue: asharif <asharif@chromium.org>
Tested-by: asharif <asharif@chromium.org>
16 months agosystem_api: Remove deprecated fields from power status. 68/57668/2 stabilize-4255.B
Daniel Erat [Wed, 5 Jun 2013 15:28:48 +0000 (08:28 -0700)]
system_api: Remove deprecated fields from power status.

This removes the deprecated |old_battery_state| and
|battery_is_present| fields from the PowerSupplyProperties
protocol buffer sent from powerd to Chrome. Chrome no longer
reads these fields.

BUG=chromium:245108
TEST=built it
CQ-DEPEND=Ibd62f7193e7c32f05003958c5b53a31511a1d248

Change-Id: I4b0fb044ada49cbac2744045bee0ec7a7392ffbf
Reviewed-on: https://gerrit.chromium.org/gerrit/57668
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>

16 months agosystem_api: Improve charger and battery status reporting. 97/57397/2
Daniel Erat [Fri, 31 May 2013 03:54:41 +0000 (20:54 -0700)]
system_api: Improve charger and battery status reporting.

This splits the PowerSupplyProperties protocol buffer's
BatteryState enum into separate ExternalPower and
BatteryState enums to permit better reporting of cases where
the battery is discharging due to a low-current charger
being connected.

BUG=chromium:245108
TEST=built and tested it in conjunction with powerd and
     chrome changes
CQ-DEPEND=If3ac3135f8e259981c4b9ed5641b7fb3c0123c8e

Change-Id: Ib3c53286e72750a98b4ad862a5d55007c60e571e
Reviewed-on: https://gerrit.chromium.org/gerrit/57397
Reviewed-by: James Cook <jamescook@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>

16 months agoBluetooth: update non-legacy API constants 66/57366/2
Scott James Remnant [Wed, 8 May 2013 21:40:14 +0000 (14:40 -0700)]
Bluetooth: update non-legacy API constants

Some errors specified in the documentation were missing, and others
were placed in the wrong namespace so fix appropriately.

BUG=chromium:221813
TEST=compile chrome after CL to remove legacy D-Bus clients,
  and compile chrome after CL to switch to new constant names

Change-Id: Ia9be5533c413beaa54850de0a175cec02154b170
Reviewed-on: https://gerrit.chromium.org/gerrit/57366
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
16 months agoBluetooth: remove legacy API constants 65/57365/2
Scott James Remnant [Wed, 8 May 2013 21:38:34 +0000 (14:38 -0700)]
Bluetooth: remove legacy API constants

BUG=chromium:221813
TEST=compile chrome after CL to remove legacy D-Bus clients

Change-Id: I7fcfe974d2a3fcf489ab1a10bdc2ec8c48cd4fa7
Reviewed-on: https://gerrit.chromium.org/gerrit/57365
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
17 months agoAdd OutputUserMute Method to CRAS api. 94/56494/2
Dylan Reid [Thu, 23 May 2013 18:56:37 +0000 (11:56 -0700)]
Add OutputUserMute Method to CRAS api.

The new method is used to set the mute state requested by the user.
It is differentiated from mutes initiated by the system such as
suspend and resume.

BUG=chromium:240814
TEST=emerge-link system_api

Change-Id: I001ac6238d00f0944b06c145d343cb5df96eeb86
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/56494
Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
17 months agoRevert "Bluetooth: remove old names of constants" 64/56164/2
Nikita Kostylev [Wed, 22 May 2013 08:16:21 +0000 (12:16 +0400)]
Revert "Bluetooth: remove old names of constants"
This reverts commit 78eb08b2c664a6bd236973ad7592ccc82a7597d2

Revert "Bluetooth: update non-legacy API constants"
This reverts commit a912a7b0d0ac3ac26b737a98d08bdf448973b03b

Revert "Bluetooth: remove legacy API constants"
This reverts commit f1ba9d3cd0b575834280e663c3fdbfb3f1be669e.

Reason for revert: Chrome is not ready for these changes yet.
See http://crbug.com/221813.

BUG=chromium:221813
TEST=none

Change-Id: I8c726d1245d3eca0c762738ab2ba32e341adeb4e
Reviewed-on: https://gerrit.chromium.org/gerrit/56164
Tested-by: Nikita Kostylev <nkostylev@chromium.org>
Reviewed-by: Dmitry Polukhin <dpolukhin@chromium.org>
Commit-Queue: Nikita Kostylev <nkostylev@chromium.org>

17 months agoAdd RetrieveActiveSessions constant to service_constants.h 10/55610/2
Chris Masone [Sat, 18 May 2013 02:01:50 +0000 (19:01 -0700)]
Add RetrieveActiveSessions constant to service_constants.h

BUG=None
TEST=emerge- system_api

Change-Id: I1bb49a3aaf31fa58c81303a31f6618f2226fb154
Reviewed-on: https://gerrit.chromium.org/gerrit/55610
Commit-Queue: Chris Masone <cmasone@chromium.org>
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
17 months agoRemoved old constants for user policy calls. 51/50451/2
Joao da Silva [Wed, 8 May 2013 13:27:14 +0000 (15:27 +0200)]
Removed old constants for user policy calls.

BUG=chromium:187482

Change-Id: If8bfe465f889bf3b06ab0cdc9439278d208df42f
Reviewed-on: https://gerrit.chromium.org/gerrit/50451
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>
17 months agoBluetooth: remove old names of constants 05/50505/2 factory-4128.B factory-spring-4131.B
Scott James Remnant [Wed, 8 May 2013 21:42:06 +0000 (14:42 -0700)]
Bluetooth: remove old names of constants

BUG=chromium:221813
TEST=compile chrome after CL to switch to new constant names

Change-Id: Ia22558bf0c533eee42ece9cdaf04ed39e1857bf5
Reviewed-on: https://gerrit.chromium.org/gerrit/50505
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
17 months agoBluetooth: update non-legacy API constants 04/50504/2
Scott James Remnant [Wed, 8 May 2013 21:40:14 +0000 (14:40 -0700)]
Bluetooth: update non-legacy API constants

Some errors specified in the documentation were missing, and others
were placed in the wrong namespace so fix appropriately.

BUG=chromium:221813
TEST=compile chrome after CL to remove legacy D-Bus clients,
  and compile chrome after CL to switch to new constant names

Change-Id: I6088d8fe6a5b5e3a3b5e7276ac985db6c9824e73
Reviewed-on: https://gerrit.chromium.org/gerrit/50504
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
17 months agoBluetooth: remove legacy API constants 03/50503/2
Scott James Remnant [Wed, 8 May 2013 21:38:34 +0000 (14:38 -0700)]
Bluetooth: remove legacy API constants

BUG=chromium:221813
TEST=compile chrome after CL to remove legacy D-Bus clients

Change-Id: I45e6c8a61e6cb7b6cdcf4a3b2ef5d4baf0ee1915
Reviewed-on: https://gerrit.chromium.org/gerrit/50503
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
17 months agoAdded constants for the multi-profile user-policy calls. 70/50270/2
Joao da Silva [Tue, 7 May 2013 12:30:47 +0000 (14:30 +0200)]
Added constants for the multi-profile user-policy calls.

BUG=chromium:187482
CQ-DEPEND=Ib748e2d59150034f4caa882ca01caf86eddbc9d4

Change-Id: I1aca34770fbd6fb2f78edc94e70d6b7d037c0aed
Reviewed-on: https://gerrit.chromium.org/gerrit/50270
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>
17 months agoAdd system_api GYP file 99/42999/9
Liam McLoughlin [Sun, 10 Feb 2013 14:10:46 +0000 (09:10 -0500)]
Add system_api GYP file

BUG=chromium:220003
TEST=Run emerge-<board> -v platform2 with and without platform2 USE
flag on a range of boards plus the host

Change-Id: I72f14c578227d2077d9a50f7007d9aaf618b339a
Reviewed-on: https://gerrit.chromium.org/gerrit/42999
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Liam McLoughlin <lmcloughlin@chromium.org>
Tested-by: Liam McLoughlin <lmcloughlin@chromium.org>
17 months agoRemove unused L2TPIPsec.GroupName property 09/49909/2 release-R28-4100.B stabilize-4100.38.B stabilize-spring-4100.53.B toolchainB
Paul Stewart [Thu, 2 May 2013 17:21:45 +0000 (10:21 -0700)]
Remove unused L2TPIPsec.GroupName property

kL2tpIpsecGroupNameProperty is not used in shill or chrome,
and I've confused it at least once with kL2tpIpsecTunnelGroupProperty.
Make it go away.

BUG=chromium:224834
TEST=Recompile shill, codesearch in cs.chromium.org

Change-Id: I5d288043c8fa0d83b60f75a230cf1d11cfb163e2
Reviewed-on: https://gerrit.chromium.org/gerrit/49909
Reviewed-by: Philipp Neubeck <pneubeck@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>

17 months agoAdd shill::kSIMOperatorIdProperty. 89/49689/2
Thieu Le [Wed, 1 May 2013 00:14:28 +0000 (17:14 -0700)]
Add shill::kSIMOperatorIdProperty.

BUG=chromium:237033
TEST=Build shill

Change-Id: Ida58025cab907703cb3f6eb57c617c631abb4a76
Reviewed-on: https://gerrit.chromium.org/gerrit/49689
Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Thieu Le <thieule@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>
17 months agoAdd plugged in time property constant to the system api. 98/49498/2
Rahul Chaturvedi [Mon, 29 Apr 2013 18:54:37 +0000 (11:54 -0700)]
Add plugged in time property constant to the system api.

BUG=chromium:175798
TEST=None.

Change-Id: I641d1067624b29f302c855041949d47255359930
Reviewed-on: https://gerrit.chromium.org/gerrit/49498
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Tested-by: Rahul Chaturvedi <rkc@chromium.org>
17 months agosystem_api: Add CONNECTED_TO_USB to PowerSupplyProperties. 70/49470/2 stabilize-4068.0.B
Daniel Erat [Sat, 27 Apr 2013 20:25:21 +0000 (13:25 -0700)]
system_api: Add CONNECTED_TO_USB to PowerSupplyProperties.

This adds a new value to the BatteryState enum for USB power
sources.

BUG=chromium:172894
TEST=built it
CQ-DEPEND=I875148cb64c782240fcbf08d0fc4b112b5523fe6

Change-Id: Iae3cd53325998bdb882b00273a990ff216556e58
Reviewed-on: https://gerrit.chromium.org/gerrit/49470
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>

17 months agoAdd GetLoadableProfileEntries shill Service method 50/49350/3
Paul Stewart [Fri, 26 Apr 2013 20:22:20 +0000 (13:22 -0700)]
Add GetLoadableProfileEntries shill Service method

Add a method call for listing the possible profile/entry
pairs that are available to configure a given service.

BUG=chromium:235674
TEST=Recompile shill

Change-Id: I58adf4fdb4450a546ff79c16c95e771087b0b61c
Reviewed-on: https://gerrit.chromium.org/gerrit/49350
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
18 months agosystem_api: Remove unused PowerSupplyProperties fields. 13/49213/2
Daniel Erat [Wed, 24 Apr 2013 22:59:31 +0000 (15:59 -0700)]
system_api: Remove unused PowerSupplyProperties fields.

BUG=chromium:234786
TEST=built chrome and powerd

Change-Id: I21f14389a4d6197edb7557a26357d7e2642afb6a
Reviewed-on: https://gerrit.chromium.org/gerrit/49213
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
18 months agosystem_api: Add user_activity_screen_dim_delay_factor. 34/49134/3
Daniel Erat [Tue, 23 Apr 2013 23:14:46 +0000 (16:14 -0700)]
system_api: Add user_activity_screen_dim_delay_factor.

This adds a user_activity_screen_dim_delay_factor field to
the PowerManagementPolicy protocol buffer.

BUG=chromium:212394
TEST=built it

Change-Id: I4a773c4cc8e5f4427a21eadde127e00d537656a2
Reviewed-on: https://gerrit.chromium.org/gerrit/49134
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>

18 months agoapi: Move PowerSupplyProperties and add an enum. 08/49008/3
Daniel Erat [Tue, 23 Apr 2013 23:23:35 +0000 (16:23 -0700)]
api: Move PowerSupplyProperties and add an enum.

This moves power_supply_properties.proto to the
power_manager subdirectory, adds an enum field to it, and
renames some of the existing fields.  I'm leaving the old
file in place until Chrome and powerd have been updated to
not compile it.

BUG=chromium:196402
TEST=compiled it

Change-Id: Ia98bdce63e4368f6bf6b6d241c7d6a69b1a427ad
Reviewed-on: https://gerrit.chromium.org/gerrit/49008
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
18 months agoAdd "UserHash" Profile property 78/48378/2 stabilize-4035.0.B
Paul Stewart [Wed, 17 Apr 2013 17:53:04 +0000 (10:53 -0700)]
Add "UserHash" Profile property

Add a read-only property to Profile that contains a hash representing
the logged-in user associated with this profile.

BUG=chromium:231858
TEST=Emerge, then compile shill

Change-Id: If9d181525fbfc4d3984daa04c2b293c24b16a3ad
Reviewed-on: https://gerrit.chromium.org/gerrit/48378
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>

18 months agoAdd "etherneteap" technology type 27/48227/2
Paul Stewart [Tue, 16 Apr 2013 16:31:00 +0000 (09:31 -0700)]
Add "etherneteap" technology type

Add a type for configuring shared EAP authentication parameters
for Ethernet networks.

BUG=chromium:227433
TEST=Recompile shill

Change-Id: Iac6e3943bf1bb8f41e25b231d295bf89f6e5ec98
Reviewed-on: https://gerrit.chromium.org/gerrit/48227
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
18 months agoAdd property names used in the GetNodes API of CRAS. 35/47835/3 stabilize-4008.0.B
Chih-Chung Chang [Thu, 11 Apr 2013 03:18:38 +0000 (11:18 +0800)]
Add property names used in the GetNodes API of CRAS.

BUG=chromium:215835
TEST=build_image

Change-Id: I499dd6e68699700682507c31ee29d8fba778dfe9
Reviewed-on: https://gerrit.chromium.org/gerrit/47835
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Chih-Chung Chang <chihchung@chromium.org>
Reviewed-by: Chih-Chung Chang <chihchung@chromium.org>
Tested-by: Chih-Chung Chang <chihchung@chromium.org>
18 months agoBluetooth experimental: Add the new Input1 experimental interface. 27/47827/3
Alex Deymo [Thu, 11 Apr 2013 01:48:14 +0000 (18:48 -0700)]
Bluetooth experimental: Add the new Input1 experimental interface.

A new Input1 Bluetooth interface was introduced on our BlueZ code exposing
the "connectability" of a HID device through a new property with 4 possible
values. This patch adds the needed constants to retrieve that property from
chromium.

BUG=chromium:220553
TEST=None

Change-Id: I46d533ec125fd7ce58e90cb39403110dbff29819
Reviewed-on: https://gerrit.chromium.org/gerrit/47827
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
18 months agoAdd shared header for common switches used by Chrome and ChromeOS modules. 44/47644/2
Julian Pastarmov [Tue, 9 Apr 2013 15:04:26 +0000 (17:04 +0200)]
Add shared header for common switches used by Chrome and ChromeOS modules.

BUG=chromium:221354
TEST=none

Change-Id: I21a0a6f3c1e1a2d818c9e6a6de240b57d860d558
Reviewed-on: https://gerrit.chromium.org/gerrit/47644
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org>
Tested-by: Julian Pastarmov <pastarmovj@chromium.org>
18 months agoAdded new cryptohome dbus APIs for attestation. 79/47379/2
Darren Krahn [Thu, 4 Apr 2013 22:52:45 +0000 (15:52 -0700)]
Added new cryptohome dbus APIs for attestation.

BUG=chromium:219959
TEST=emerge chromeos-cryptohome

Change-Id: I20f77c230e3869fc88023c610b1d2377a63a3387
Reviewed-on: https://gerrit.chromium.org/gerrit/47379
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
Tested-by: Darren Krahn <dkrahn@chromium.org>
Commit-Queue: Darren Krahn <dkrahn@chromium.org>

18 months agoAdd Device property "EapAuthenticationCompleted" 03/47403/2
Paul Stewart [Wed, 3 Apr 2013 05:15:26 +0000 (22:15 -0700)]
Add Device property "EapAuthenticationCompleted"

Provide a property that Ethernet devices will use to indicate
whether an EAP authentication has successfully completed on
this link.

BUG=chromium:225914
TEST=Compile shill, use symbol (upcoming shill CL) and use
list-devices to test that this property is available.

Change-Id: I30ffe8a42b96b7f1b17bff4256f09711e6c48556
Reviewed-on: https://gerrit.chromium.org/gerrit/47403
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
18 months agoAdd Device property "EapAuthenticatorDetected" 27/47227/2
Paul Stewart [Wed, 3 Apr 2013 05:15:26 +0000 (22:15 -0700)]
Add Device property "EapAuthenticatorDetected"

Provide a property that Ethernet devices will use to indicate
whether an EAP authenticator has been detected on this link.
While here perform a little local sorting.

BUG=chromium:225914
TEST=Compile shill, use symbol (upcoming shill CL) and use
list-devices to test that this property is available.

Change-Id: If606d2f84447d61094d230358f7757483d19b80c
Reviewed-on: https://gerrit.chromium.org/gerrit/47227
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
18 months agosystem_api: Add power_manager::kPeripheralBatteryStatusSignal 08/46708/7
Yufeng Shen [Wed, 27 Mar 2013 22:45:06 +0000 (18:45 -0400)]
system_api: Add power_manager::kPeripheralBatteryStatusSignal

This signal is used for power_manager to send Chrome the battery
status of peripheral devices.

Also add the proto buffer definition for PeripheralBatteryStatus.

BUG=chromium:221420
TEST=built it

Change-Id: I26751758500c4028807d8d29f7036eb8777aeca9
Reviewed-on: https://gerrit.chromium.org/gerrit/46708
Commit-Queue: Yufeng Shen <miletus@chromium.org>
Reviewed-by: Yufeng Shen <miletus@chromium.org>
Tested-by: Yufeng Shen <miletus@chromium.org>
18 months agoFix method name for explicitly connect to "best" services 61/46661/2
Paul Stewart [Tue, 26 Mar 2013 22:49:18 +0000 (15:49 -0700)]
Fix method name for explicitly connect to "best" services

Add method name "ConnectToBestServices", added to shill in:
https://gerrit.chromium.org/gerrit/45781

BUG=chromium:221838
TEST=Recompile shill

Change-Id: I7533b3f0abdfd6c74f095bc2f8b7864472111c70
Reviewed-on: https://gerrit.chromium.org/gerrit/46661
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
18 months agoAdd method to explicitly connect to "best" services 71/46571/2
Paul Stewart [Tue, 26 Mar 2013 22:49:18 +0000 (15:49 -0700)]
Add method to explicitly connect to "best" services

Add method name "ConnectToBestServices", added to shill in:
https://gerrit.chromium.org/gerrit/45781

BUG=chromium:221838
TEST=Recompile shill

Change-Id: I1064d470d3f69da9f25b31e71d6785a13b7e7ac6
Reviewed-on: https://gerrit.chromium.org/gerrit/46571
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
19 months agoAdd CRAS Control interface. 27/46527/2 release-R27-3912.B stabilize-3912.79.B toolchainA
Dylan Reid [Tue, 26 Mar 2013 17:56:56 +0000 (10:56 -0700)]
Add CRAS Control interface.

The control interface lives in the root cras object and is what Chrome
will use to control both volume and device selection.

BUG=chromium-os:33666
TEST=dbus-monitor --system while hitting volume keys

Change-Id: I0e5e91f4b5575af7819a80fcc9f7adf0a6e32170
Reviewed-on: https://gerrit.chromium.org/gerrit/46527
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Commit-Queue: Dylan Reid <dgreid@chromium.org>
Tested-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
19 months agosystem_api: Add chromeos::kSetDisplaySoftwareDimming. 63/46363/2
Daniel Erat [Sat, 23 Mar 2013 19:36:43 +0000 (12:36 -0700)]
system_api: Add chromeos::kSetDisplaySoftwareDimming.

This adds a constant for a new SetDisplaySoftwareDimming
D-Bus method that will be exported by Chrome.  It will
replace the SoftwareScreenDimmingRequested signal that's
currently emitted by powerd.

BUG=chromium:221391
TEST=built it
TBR=marcheu@chromium.org

Change-Id: I9f7cf7095d8f57f48cd92e2c6e420249f2739abb
Reviewed-on: https://gerrit.chromium.org/gerrit/46363
Commit-Queue: Daniel Erat <derat@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
19 months agosystem_api: Delete old power manager constants and protos. 62/46362/2
Daniel Erat [Thu, 21 Mar 2013 18:29:56 +0000 (11:29 -0700)]
system_api: Delete old power manager constants and protos.

This deletes D-Bus constants that are no longer used, along
with PowerAccumulation (never used, as far as I can tell)
and PowerStateControl .proto files.

BUG=chromium:176405,chromium:221391
TEST=did a build
TBR=cmasone@chromium.org
CQ-DEPEND=I76373cb22a40347aa6a3f011ef250481799ddf55

Change-Id: Ic3d731363d0c3520a6e1b8783ddcf505c5b811e1
Reviewed-on: https://gerrit.chromium.org/gerrit/46362
Commit-Queue: Daniel Erat <derat@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
19 months agoAdd CRAS DBUS constants. 70/46170/3
Dylan Reid [Thu, 21 Mar 2013 22:28:21 +0000 (15:28 -0700)]
Add CRAS DBUS constants.

Constants that Chrome will use to communicate with CRAS over DBUS.

BUG=chromium-os:33666
TEST=compile and run chrome.

Change-Id: I5e6b20f65295f555601656dd682fa99778fbcc5c
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/46170
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
19 months agosystem_api: add BlueZ 5 Profile Errors 84/46184/3
Scott James Remnant [Thu, 21 Mar 2013 23:53:09 +0000 (16:53 -0700)]
system_api: add BlueZ 5 Profile Errors

BUG=chromium-os:38832
TEST=make chrome

Change-Id: I2514d34003643ab624b528dc645601b9010c7dec
Reviewed-on: https://gerrit.chromium.org/gerrit/46184
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
19 months agosystem_api: add BlueZ 5 interfaces 47/45147/6
Scott James Remnant [Mon, 11 Mar 2013 22:34:56 +0000 (15:34 -0700)]
system_api: add BlueZ 5 interfaces

Many of the interfaces are the same as the old; though some methods,
signals and properties have been removed, moved or renamed. For the
most part just re-use the existing constants, except prefix the new
interface name with 'Experimental' to match the way we're supporting
both interfaces in Chromium during development.

BUG=chromium-os:38832
TEST=make chrome

Change-Id: Ia69db2cc4002f0dc3944dae71d9982df667f5d12
Reviewed-on: https://gerrit.chromium.org/gerrit/45147
Reviewed-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
19 months agoAdd property for Cisco Tunnel Group 45/46145/3
Paul Stewart [Thu, 21 Mar 2013 18:13:20 +0000 (11:13 -0700)]
Add property for Cisco Tunnel Group

Provide a service property for providing a tunnel group to be
assigned to this L2TPIpsec connection.

BUG=chromium:199004
TEST=Compile

Change-Id: Ie16db7717e5b514e52cbd703c852b030cd092d21
Reviewed-on: https://gerrit.chromium.org/gerrit/46145
Commit-Queue: Paul Stewart <pstew@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
19 months agosystem_api: Add PowerManagementPolicy.reason. 95/45995/3
Daniel Erat [Wed, 20 Mar 2013 14:57:24 +0000 (07:57 -0700)]
system_api: Add PowerManagementPolicy.reason.

This adds a "reason" field that can be logged by the power
manager to aid in debugging.

BUG=chromium:176405
TEST=built it
TBR=bartfab@chromium.org

Change-Id: I2b8522ea6f64bad985b6efdfbda3f74f0799ae3e
Reviewed-on: https://gerrit.chromium.org/gerrit/45995
Reviewed-by: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>

19 months agosystem_api: Add idle_notify_ms to PowerManagementPolicy. 01/45801/2 stabilize-3881.0.B
Daniel Erat [Thu, 14 Mar 2013 16:23:07 +0000 (09:23 -0700)]
system_api: Add idle_notify_ms to PowerManagementPolicy.

This also adds constants for IdleActionImminent and
IdleActionDeferred D-Bus signals that will be emitted by
powerd.

BUG=chromium:195560
TEST=built it

Change-Id: Ie7ce73c72078da3cb757879a4097324828ba4205
Reviewed-on: https://gerrit.chromium.org/gerrit/45801
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
19 months agosystem_api: add D-Bus ObjectManager interface 46/45146/4
Scott James Remnant [Mon, 11 Mar 2013 22:34:24 +0000 (15:34 -0700)]
system_api: add D-Bus ObjectManager interface

This is a new standard interface

BUG=none
TEST=none

Change-Id: I54a9f49129e8234ea883d72f3991a48df385a915
Reviewed-on: https://gerrit.chromium.org/gerrit/45146
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
19 months agosystem-api: Add PEM certificate Properties 42/45442/3
Paul Stewart [Thu, 14 Mar 2013 17:50:59 +0000 (10:50 -0700)]
system-api: Add PEM certificate Properties

Add service properties that provide the PEM contents of the
CA certificate to be used in an 802.1x, L2TPIpsec and OpenVPN
connections in shill.

BUG=chromium-os:39685
TEST=Compile

Change-Id: I8f42f28f9aaff050c586b4388ee7e7a7bd6df37a
Reviewed-on: https://gerrit.chromium.org/gerrit/45442
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
19 months agoservice_api: complete D-Bus Properties interface 45/45145/3
Scott James Remnant [Mon, 11 Mar 2013 22:33:29 +0000 (15:33 -0700)]
service_api: complete D-Bus Properties interface

BUG=none
TEST=none

Change-Id: I9e52b21a2066ba71d65c1bdd7cb2174f211551f7
Reviewed-on: https://gerrit.chromium.org/gerrit/45145
Reviewed-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
19 months agoAdded new cryptohome dbus constants. 77/45477/2
Darren Krahn [Thu, 14 Mar 2013 20:23:46 +0000 (13:23 -0700)]
Added new cryptohome dbus constants.

BUG=chromium-os:39830
TEST=emerge system_api and chromeos-cryptohome

Change-Id: Icab6661dceb9ccc4c6af6536c22588d9beb3001b
Reviewed-on: https://gerrit.chromium.org/gerrit/45477
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
Commit-Queue: Darren Krahn <dkrahn@chromium.org>
Tested-by: Darren Krahn <dkrahn@chromium.org>
19 months agoAdd shill's ConfigureServiceForProfile function 27/45127/2 factory-spring-3842.B
Paul Stewart [Mon, 11 Mar 2013 20:21:21 +0000 (13:21 -0700)]
Add shill's ConfigureServiceForProfile function

This method will allow adding / modifying the properties in a
profile entry regardless of state of a matching visible service
associated with a different profile.

BUG=chromium-os:39513
TEST=Unit tests

Change-Id: Ifef028749b0b7221b87ded8fe0b80159e785b771
Reviewed-on: https://gerrit.chromium.org/gerrit/45127
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
19 months agoAdd new "Cellular.OutOfCredits" property to shill cellular service. 58/45358/2
Thieu Le [Wed, 13 Mar 2013 22:22:52 +0000 (15:22 -0700)]
Add new "Cellular.OutOfCredits" property to shill cellular service.

BUG=chromium-os:18137
TEST=emerge system_api and shill

Change-Id: Id46ab01c7e0d1327a1b7e7ec5ceda2da0b002a69
Reviewed-on: https://gerrit.chromium.org/gerrit/45358
Reviewed-by: Arman Uguray <armansito@chromium.org>
Commit-Queue: Thieu Le <thieule@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>
19 months agoAdd new service constants for org.torproject.tlsdate TimeUpdated signal. 44/45144/2 firmware-spring-3833.B
Jenny Zhang [Mon, 11 Mar 2013 22:53:08 +0000 (15:53 -0700)]
Add new service constants for org.torproject.tlsdate TimeUpdated signal.

Change-Id: Ide79f7a932b4eb04cc51bb63fe5424650b7d8847
BUG=chrome-os-partner:14436
TEST=NONE
Reviewed-on: https://gerrit.chromium.org/gerrit/45144
Tested-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>

19 months agoAdd shill's Service.ErrorDetails property. 69/45069/4
Darin Petkov [Mon, 11 Mar 2013 13:16:48 +0000 (14:16 +0100)]
Add shill's Service.ErrorDetails property.

The property will be used to propagate custom server-supplied error
messages to the UI. See CL:45070.

BUG=chromium-os:31410
TEST=emerged system_api along with shill

Change-Id: I8a481be6b4c13cb5ca232d5e65b9a20e977ce5c0
Reviewed-on: https://gerrit.chromium.org/gerrit/45069
Tested-by: Darin Petkov <petkov@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Darin Petkov <petkov@chromium.org>

19 months agosystem_api: Add DISPLAY_POWER_INTERNAL_ON_EXTERNAL_OFF. 85/44685/2 firmware-spring-3824.4.B firmware-spring-3824.55.B firmware-spring-3824.84.B firmware-spring-3824.B
Daniel Erat [Tue, 5 Mar 2013 22:21:01 +0000 (14:21 -0800)]
system_api: Add DISPLAY_POWER_INTERNAL_ON_EXTERNAL_OFF.

This adds an additional value to the
chromeos::DisplayPowerState enum: just before suspending, we
want to turn the internal displays back on while leaving
external displays off.

BUG=chromium-os:39289
TEST=manual: built it

Change-Id: I0854379e5d8691aea7fb5dc23c78b44ac82ad04f
Reviewed-on: https://gerrit.chromium.org/gerrit/44685
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
19 months agosystem_api: RequestSuspend should be method, not signal. 29/44529/2
Daniel Erat [Mon, 4 Mar 2013 17:43:19 +0000 (09:43 -0800)]
system_api: RequestSuspend should be method, not signal.

This renames the power_manager::kRequestSuspendSignal
constant to power_manager::kRequestSuspendMethod.

BUG=chromium:179713
TEST=built it
CQ-DEPEND=I0bb7c80073b4fe437f08c75370744c436fefa96e

Change-Id: Ib7e15923355e499346029d4f9d3e59c52848d2ce
Reviewed-on: https://gerrit.chromium.org/gerrit/44529
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Sameer Nanda <snanda@chromium.org>
Commit-Queue: Daniel Erat <derat@chromium.org>

19 months agoRename VerifyAndSignData to VerifyAndEncryptData 07/44307/3
Greg Spencer [Tue, 26 Feb 2013 02:28:06 +0000 (18:28 -0800)]
Rename VerifyAndSignData to VerifyAndEncryptData

The Shill team prefers this name (because it's more accurate).

TEST=emerge system_api
BUG=chromium-os:38993

Change-Id: I74af23022d9102744b0b427093596c7010a77930
Reviewed-on: https://gerrit.chromium.org/gerrit/44307
Tested-by: Greg Spencer <gspencer@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Greg Spencer <gspencer@chromium.org>

19 months agosystem_api: Add chromeos::kSetDisplayPower. 57/44257/2
Daniel Erat [Wed, 27 Feb 2013 23:30:50 +0000 (15:30 -0800)]
system_api: Add chromeos::kSetDisplayPower.

This defines the name of a "SetDisplayPower" method call
that will be exported by Chrome for the power manager and
adds a DisplayPowerState enum.

BUG=chromium-os:39289
TEST=built it

Change-Id: I8a1cf19e68b26fd2f84dcd560ed4c21a9565814e
Reviewed-on: https://gerrit.chromium.org/gerrit/44257
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
20 months agoAdded manager API constants for new Shill APIs. 67/43367/4
Greg Spencer [Fri, 15 Feb 2013 01:10:26 +0000 (17:10 -0800)]
Added manager API constants for new Shill APIs.

BUG=chromium-os:38726
TEST=emerge system_api, built chromiumos image.

Change-Id: I9feb3325e2a4e3d36cf35c3be943f468d0f2039c
Reviewed-on: https://gerrit.chromium.org/gerrit/43367
Commit-Queue: Greg Spencer <gspencer@chromium.org>
Reviewed-by: Greg Spencer <gspencer@chromium.org>
Tested-by: Greg Spencer <gspencer@chromium.org>
20 months agoAdd shill CompleteCellularActivation DBus method constant. 68/43368/3
Ben Chan [Thu, 14 Feb 2013 21:47:31 +0000 (13:47 -0800)]
Add shill CompleteCellularActivation DBus method constant.

BUG=chromium-os:38974
TEST=emerge system_api

Change-Id: I0cd0b25d1f6d48234d176fc596f2129c7f1561f5
Reviewed-on: https://gerrit.chromium.org/gerrit/43368
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
20 months agowifi: Manager: Create CompleteServices property 82/41982/3 stabilize-3701.30.0 stabilize-3701.30.0b stabilize-bluetooth-smart toolchain-3701.42.B
Paul Stewart [Fri, 25 Jan 2013 01:05:08 +0000 (17:05 -0800)]
wifi: Manager: Create CompleteServices property

The "Services" property of the manager returns only visible
services.  Provide another property which will provide the
entire list of services, including those that are not visible.

BUG=chromium-os:38017
TEST=Compile

Change-Id: Ic8af4999b25503c3b002504edd12405dc91cc824
Reviewed-on: https://gerrit.chromium.org/gerrit/41982
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
20 months agosystem_api: Add PowerManagementPolicy protobuf. 49/40349/10 stabilize-3658.0.0
Daniel Erat [Wed, 2 Jan 2013 23:52:00 +0000 (15:52 -0800)]
system_api: Add PowerManagementPolicy protobuf.

This defines a PowerManagementPolicy protocol buffer that
can be sent from Chrome to powerd to dynamically change
powerd's behavior.  It is intended to be comprehensive
enough to be used for currently-planned per-user enterprise
policies (including Public Accounts) as well as supporting
PowerSaveBlocker in Chrome (e.g. disabling suspend while
downloading files, disabling screen-dimming while watching
videos, etc.).

BUG=chromium-os:36889,chromium-os:38281
TEST=built it

Change-Id: I1dea398f03bd67623d30e22ab8ca2525dd1594d4
Reviewed-on: https://gerrit.chromium.org/gerrit/40349
Commit-Queue: Daniel Erat <derat@chromium.org>
Reviewed-by: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
20 months agodbus: add GetPerfData() method. 54/42254/2
Ahmad Sharif [Tue, 29 Jan 2013 22:48:54 +0000 (14:48 -0800)]
dbus: add GetPerfData() method.

BUG=chromium-os:37970
TEST=Tested in conjunction with:
https://gerrit.chromium.org/gerrit/#/c/41546/
https://codereview.chromium.org/11185038/

Change-Id: Ie5f73fe035bffec606ccde2608473bd506209a15
Reviewed-on: https://gerrit.chromium.org/gerrit/42254
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Elly Jones <ellyjones@chromium.org>
Commit-Queue: asharif <asharif@chromium.org>
Tested-by: asharif <asharif@chromium.org>
20 months agoAdded constant for the GetSanitizedUsername() dbus call. 98/42298/2
Joao da Silva [Wed, 30 Jan 2013 12:09:17 +0000 (13:09 +0100)]
Added constant for the GetSanitizedUsername() dbus call.

This method will be implemented in cryptohomed.

BUG=chromium:163318
TEST=none

Change-Id: I33d066eea8ebf8d793b4a6451b639be406a8155f
Reviewed-on: https://gerrit.chromium.org/gerrit/42298
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: Joao da Silva <joaodasilva@chromium.org>
Tested-by: Joao da Silva <joaodasilva@chromium.org>
21 months agosystem_api: Add description to suspend delay proto. 34/41934/3
Daniel Erat [Thu, 24 Jan 2013 17:40:34 +0000 (09:40 -0800)]
system_api: Add description to suspend delay proto.

Adds a 'description' string to RegisterSuspendDelay protocol
buffers to aid in debugging.

BUG=chromium-os:36980
TEST=it builds

Change-Id: I661570a23b42f3fba892671edc730ffe5584f35a
Reviewed-on: https://gerrit.chromium.org/gerrit/41934
Commit-Queue: Daniel Erat <derat@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
21 months agosystem_api: Remove deprecated power manager constants. 66/41866/2
Daniel Erat [Thu, 17 Jan 2013 17:30:02 +0000 (09:30 -0800)]
system_api: Remove deprecated power manager constants.

This removes D-Bus constants related to the previous suspend
delay implementation and powerm.

BUG=chromium-os:36980,chromium-os:36804
TEST=built an image

Change-Id: I4f544f5c21086cb83e20f72ed477fd94cfa88f34
Reviewed-on: https://gerrit.chromium.org/gerrit/41866
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Queue: David James <davidjames@chromium.org>

21 months agoAdd shill Reset DBus method constant. 49/41849/3
Ben Chan [Wed, 23 Jan 2013 20:16:19 +0000 (12:16 -0800)]
Add shill Reset DBus method constant.

BUG=chromium-os:37678
TEST=emerge system_api

Change-Id: I1cf21b37d8b8bfaa5043b2ce0ad3bff889a88b8f
Reviewed-on: https://gerrit.chromium.org/gerrit/41849
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
21 months agoAdd shill Manager.UninitializedTechnologies property. 48/41348/2
Ben Chan [Wed, 16 Jan 2013 05:52:04 +0000 (21:52 -0800)]
Add shill Manager.UninitializedTechnologies property.

BUG=chromium-os:37877
TEST=emerge system_api

Change-Id: I9e9982ec07db9bcf9cdc42106c988a6379f317b7
Reviewed-on: https://gerrit.chromium.org/gerrit/41348
Reviewed-by: Darin Petkov <petkov@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
21 months agoAdd GetNetworksForGeolocation 64/41064/2 factory-3536.B
Steven Bennetts [Thu, 10 Jan 2013 23:04:47 +0000 (15:04 -0800)]
Add GetNetworksForGeolocation

BUG=None
TEST=None

Change-Id: I9dd3d51e137dbee75ae045a3fda3b605f41df9aa
Reviewed-on: https://gerrit.chromium.org/gerrit/41064
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Commit-Queue: Brian Harring <ferringb@chromium.org>

21 months agoshill: wifi: Add constant for 802.11w (PMF) 72/40972/3
Paul Stewart [Thu, 10 Jan 2013 00:28:17 +0000 (16:28 -0800)]
shill: wifi: Add constant for 802.11w (PMF)

Add a WiFi service property that indicates whether an AP for this
service has been seen that requires Protected Management Frame
support.

BUG=chromium-os:37698
TEST=Compile

Change-Id: I1fb5f35cd85f2b8c0e7a0bb2ac69cc920d988830
Reviewed-on: https://gerrit.chromium.org/gerrit/40972
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
22 months agobluetooth: New constant for a BlueZ error response. 92/39992/3
Alex Deymo [Thu, 20 Dec 2012 00:08:57 +0000 (16:08 -0800)]
bluetooth: New constant for a BlueZ error response.

BlueZ may return a NotSupported error message while trying to pair
to a not supported device. We want to show a especial message to
the user in this case.

BUG=chromium-os:27902
TEST=cros_chrome_make

Change-Id: I0922889c60a7c971eaeb9561e30aefa6d113ec31
Reviewed-on: https://gerrit.chromium.org/gerrit/39992
Reviewed-by: Ben Chan <benchan@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>

22 months agoAdd shill's Service disconnect and misconnect history properties. 41/39241/3 toolchain-3428.65.B
Darin Petkov [Wed, 5 Dec 2012 12:40:44 +0000 (13:40 +0100)]
Add shill's Service disconnect and misconnect history properties.

BUG=chromium-os:36924
TEST=emerged along with shill using the new properties, unit tests

Change-Id: I5e1852af18381995c30c5e1f356d3c2745c44d2f
Reviewed-on: https://gerrit.chromium.org/gerrit/39241
Reviewed-by: Darin Petkov <petkov@chromium.org>
Tested-by: Darin Petkov <petkov@chromium.org>
Commit-Ready: Darin Petkov <petkov@chromium.org>

22 months agoRemove deprecated cashew DBus service constants. 78/39678/2
Ben Chan [Thu, 13 Dec 2012 22:19:56 +0000 (14:19 -0800)]
Remove deprecated cashew DBus service constants.

BUG=chromium-os:37243
TEST=Build system_api and Chrome OS.

Change-Id: I378e725543f0d2506a6ddd21ecdb78e099cf98ed
Reviewed-on: https://gerrit.chromium.org/gerrit/39678
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Thieu Le <thieule@chromium.org>
Commit-Ready: Ben Chan <benchan@chromium.org>

22 months agoAdd shill Cellular.ActivateOverNonCellularNetwork property. 96/39496/3 master-backup
Ben Chan [Mon, 10 Dec 2012 19:31:31 +0000 (11:31 -0800)]
Add shill Cellular.ActivateOverNonCellularNetwork property.

BUG=chromium-os:37117
TEST=emerge system_api

Change-Id: I1e51039df70612202206c94e75e041faf27f0216
Reviewed-on: https://gerrit.chromium.org/gerrit/39496
Reviewed-by: Darin Petkov <petkov@chromium.org>
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
22 months agosystem_api: Rename a 'delay' field to 'timeout'. 73/39373/2 stabilize2
Daniel Erat [Fri, 7 Dec 2012 15:32:53 +0000 (07:32 -0800)]
system_api: Rename a 'delay' field to 'timeout'.

This gives a field in RegisterSuspendDelayRequest a slightly
more accurate name.

BUG=chromium-os:36980
TEST=it builds (field isn't used by any checked-in code)

Change-Id: I7cdd39bc80c5e8b56c1da8992f4ad58e14b053b9
Reviewed-on: https://gerrit.chromium.org/gerrit/39373
Tested-by: Daniel Erat <derat@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Commit-Ready: Daniel Erat <derat@chromium.org>

22 months agoAdded cryptohome attestation calls. 72/39272/2
Darren Krahn [Wed, 5 Dec 2012 23:18:21 +0000 (15:18 -0800)]
Added cryptohome attestation calls.

Only the calls needed by Chrome have been added.

BUG=chromium-os:36561
TEST=emerge system_api

Change-Id: Ia12711166de1c7c4fcf2b2e5b413c2a0b48b2566
Reviewed-on: https://gerrit.chromium.org/gerrit/39272
Reviewed-by: Gaurav Shah <gauravsh@chromium.org>
Commit-Ready: Darren Krahn <dkrahn@chromium.org>
Tested-by: Darren Krahn <dkrahn@chromium.org>
22 months agobluetooth: Added some bluez error constants more. Fix ',' --> '.' 77/39377/2
Alex Deymo [Fri, 7 Dec 2012 17:48:44 +0000 (09:48 -0800)]
bluetooth: Added some bluez error constants more. Fix ',' --> '.'

BUG=chromium-os:27902
TEST=cros_chrome_make

Change-Id: I69cac2022cbba8eb80077bafb428c54753a56752
Reviewed-on: https://gerrit.chromium.org/gerrit/39377
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Commit-Ready: Alex Deymo <deymo@chromium.org>

22 months agosystem_api: Add suspend-delay constants and protos. 77/39277/5
Daniel Erat [Wed, 5 Dec 2012 23:57:18 +0000 (15:57 -0800)]
system_api: Add suspend-delay constants and protos.

This adds new signal and method name constants and protocol
buffers for the power manager's suspend delay feature.  I'm
attempting to clean up the D-Bus usage here (by using
signals vs. methods correctly and using protocol buffers
instead of bare D-Bus arguments) and to make suspend delays
safer and easier to troubleshoot (by adding delay IDs
instead of maintaining a counter).

BUG=chromium-os:36980
TEST=none

Change-Id: I60a49f6c5d4046eabcf22d0a6352e817fa97c4bb
Reviewed-on: https://gerrit.chromium.org/gerrit/39277
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Tested-by: Daniel Erat <derat@chromium.org>
Commit-Ready: Daniel Erat <derat@chromium.org>

22 months agoshill: Add error constants for EAP failures 07/39007/2
Paul Stewart [Fri, 30 Nov 2012 19:29:25 +0000 (11:29 -0800)]
shill: Add error constants for EAP failures

BUG=chromium-os:31466
TEST=Upcoming change to shill

Change-Id: Ifae8eeb45c1f9ef5a9f0406482a15c0c9adca12c
Reviewed-on: https://gerrit.chromium.org/gerrit/39007
Reviewed-by: mukesh agrawal <quiche@chromium.org>
Commit-Ready: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>