tests/*/scrolling_with_low_press_fingers*: make tests more strict

The patch makes those tests more strict by penalizing any cursor
movement since we have found a solution to the problem.

BUG=chromium:219126
TEST=These are the tests

Change-Id: I787d6b695cb0f2d49dfa1ebc592817b9ea851d43
Reviewed-on: https://gerrit.chromium.org/gerrit/48362
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Tai-Hsu Lin <sheckylin@chromium.org>
Tested-by: Tai-Hsu Lin <sheckylin@chromium.org>

Generalize middle button test for Link

This test regressed accidentally due to one of its movement gestures
getting split up for some reason.  The test isn't really interested in
that move, so I just added a merge=True flag so it would keep passing,
since the Clicks are still the same and it's a test for clicks.

BUG=chromium:236446
TEST=regression tests

Change-Id: I82a149031cfb7f1d335b5ecd084929de6e9130c1
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/49509
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

Update Touchtests w/ a missed right click test

This adds a new regression test for a missed right click on Spring.

BUG=chromium:236446
TEST=regression tests
CQ-DEPEND=Icbf8d455d8668c5a95a3dc9fb0ba4dabe14e39d4

Change-Id: Ib64986a67e488e4163da1e0050dc126d3989a1bd
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/49508
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

tests/stout/null_when_scroll_intended3: add test

Large wiggle max distance limits some fast scroll gestures.

BUG=chromium:236880
TEST=this is the test

Change-Id: I7bbc615cc743a4fd961a3d66b225ec8b4cc6c070
Reviewed-on: https://gerrit.chromium.org/gerrit/50165
Commit-Queue: Chung-yih Wang <cywang@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>
Tested-by: Chung-yih Wang <cywang@chromium.org>

test/magicmouse/no_scrolls: Add test

Adds a test of using the magic mouse that should not have any
scrolling.

BUG=chromium:237692
TEST=this is the test

Change-Id: Ifa2e15fe81c07f7ccdf6e9add1cb634bac0038bd
Reviewed-on: https://gerrit.chromium.org/gerrit/49992
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>

tests/stout/tap_on_the_bottom: add test

BUG=none
TEST=this is the test

Change-Id: I5c302628f63d839c3680cbff7270e172763aa330
Reviewed-on: https://gerrit.chromium.org/gerrit/49894
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Chung-yih Wang <cywang@chromium.org>
Tested-by: Chung-yih Wang <cywang@chromium.org>

tests/stout/null_when_scroll_intended2: add test

High pressure change duration limits some fast scroll gestures.

BUG=chromium:236880
TEST=this is the test

Change-Id: I01ef92ec17097784771b6c4f079410943fdfc958
Reviewed-on: https://gerrit.chromium.org/gerrit/49720
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Chung-yih Wang <cywang@chromium.org>
Tested-by: Chung-yih Wang <cywang@chromium.org>

tests/stout: add tests

This patch adds two tests for two 2f-scroll issues:
  1. null_when_scroll_intended
  2. right_click_when_scrolling_intended

BUG=chromium:233797, chromium:215124
TEST=these are the tests

Change-Id: I61dc90ea0cac8ad63343bb6706b9b6758e0f2bb5
Reviewed-on: https://gerrit.chromium.org/gerrit/49155
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Chung-yih Wang <cywang@chromium.org>
Tested-by: Chung-yih Wang <cywang@chromium.org>

tests/stout/move_when_scroll_intended: add test

On stout, X,Y ranges and resolutions reported from firmware are
incorrect, the platform.dat created in the patch is modified
accordingly to match what hardware properties are seen in the
gesture library.

BUG=chromium:233797
TEST=this is the test

Change-Id: I474787978aecf8f1d3a1d0274583bed413afcd14
Reviewed-on: https://gerrit.chromium.org/gerrit/49043
Commit-Queue: Chung-yih Wang <cywang@chromium.org>
Tested-by: Chung-yih Wang <cywang@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

Add pointer to xorg conf file for magic mouse

BUG=none
TEST=Successfully create touchtests for magic mouse

Change-Id: Idc9d2892ae27ee4b33546313af3422f174b7c311
Reviewed-on: https://gerrit.chromium.org/gerrit/49078
Tested-by: Che-Liang Chiou <clchiou@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Che-Liang Chiou <clchiou@chromium.org>

test_factory: Use current year in copyright notice for new tests

BUG=chromium:234388
TEST=created new test, saw 2013 year

Change-Id: I5e40dc379f7db90e68f1f858f8b171ccc0c33c36
Reviewed-on: https://gerrit.chromium.org/gerrit/48828
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>

spring1/drumroll_fail: Add test

This is a test from an accidental drumroll I got on Spring.

BUG=chromium:233601
TEST=This is the test

Change-Id: If7a1be6fa8616681550c328bd0e0cfae9806ccf7
Reviewed-on: https://gerrit.chromium.org/gerrit/48826
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

Also adding the additional props to snow1.3

I forgot to check the other Snow test directory when adding
the additional property identifier to Snow.  Both of them need to pick
up all of the Cyapa xorg-conf properties, not just snow2.3, or several
tests regress.

BUG=chromium:234385
TEST=manual testing + regression test

Change-Id: I79979976b4c3abd318782520746b7a355bb6b42d
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/48901
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

Add tap-to-click regression test for spring

This adds a tap-to-click test for Spring to the regression suite.  It
consists of two taps in quick succession and checks to confirm that both
register as both down and up clicks without any movement around them.

BUG=chromium:233602
TEST=regression test

Change-Id: Ibb2c603826df6a6cf3b289ace07334ec9783ce23
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/48903
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

tests/lumpy/2f_scroll_fail: Add test

This test shows a sample of log data where scrolling failed.

BUG=chromium:231984
TEST=This is the test

Change-Id: I1c9b306d65daadaf73537f0b0093fcddf43acc56
Reviewed-on: https://gerrit.chromium.org/gerrit/48581
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

tests/spring1: Add platform

Add a new platform directory for Spring.

BUG=chromium:234375
TEST=None

Change-Id: I4fe31b010c279dda091a4ab8822bfcb826667095
Reviewed-on: https://gerrit.chromium.org/gerrit/48824
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

Get snow2.3 to pick up all of its props

After the snow properties got split into 2 parts in xorg-conf, the
regression test for snow2.3 only picks up half of them so all the tests
that rely on those properties broke.

This just adds another identifier so it gets all the properties it
should.

BUG=chromium:234385
TEST=regression test

Change-Id: Iaf526fd4fbd81fba31ea50732ef183f978764e1d
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/48827
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

touchtests: allow --gdb mode for creation of tests

this will run the trimmer in gdb which allows to debug problems with
trimming.

BUG=chromium:233823
TEST=run touchtests -c 'feedback...' --gdb

Change-Id: Id8ca5ea192baf7bd70193c68e30e9cc520a94fa5
Reviewed-on: https://gerrit.chromium.org/gerrit/48728
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

tests/snow2.3/scrolling_with_sensor_jump: add test

BUG=chrome-os-partner:12358
TEST=this is the test

Change-Id: Ib30dadef51dda067e6fe56db3633529bcf8c3585
Reviewed-on: https://gerrit.chromium.org/gerrit/47845
Commit-Queue: Chung-yih Wang <cywang@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>
Tested-by: Chung-yih Wang <cywang@chromium.org>

framework: Update formatting code to show digits after decimal point

This CL uses the more flexible {:.4g} formatting type. It hides the digits
after the decimal point if they are zero and uses exponential display
for large numbers >9999 or small numbers < 0.0001.

BUG=chromium:229493
TEST=run touchtests. Check validation report for presentation

Change-Id: I33c8d193e89829092505292ec6926f4047f7e6f2
Reviewed-on: https://gerrit.chromium.org/gerrit/47663
Reviewed-by: Tai-Hsu Lin <sheckylin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

tests/lucas/scrolling_with_low_press_fingers*: Add tests

These tests were collected from the following feedback reports:
feedback:345836142

They test whether 2f scrolls with one finger at the bottom zone
at the end generate any cursor move. The ideal case is none.

BUG=chromium:217460
TEST=These are the tests

Change-Id: I668db9f6f620c0c63b8e4fafa773278edd6db597
Reviewed-on: https://gerrit.chromium.org/gerrit/47734
Commit-Queue: Tai-Hsu Lin <sheckylin@chromium.org>
Tested-by: Tai-Hsu Lin <sheckylin@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

tests/{link,lucas}/scrolling_with_low_press_fingers*: Add tests

These tests were collected from the following feedback reports:
feedback:573057759, 356786930

They test whether the cursor wrongly moves too much at the beginning
of 2f scrolls which have one finger at the bottom zone from start.
Ideally, we would like to be able to fully distinguish the case from
a 1f move with one resting thumb, but the tests can serve as a
regession check before we figure out the long term solution.

BUG=chromium:219126
TEST=These are the tests

Change-Id: I62d7f65bc24f2779975376c0f0732e77511aaf6d
Reviewed-on: https://gerrit.chromium.org/gerrit/47733
Reviewed-by: Chung-yih Wang <cywang@chromium.org>
Commit-Queue: Tai-Hsu Lin <sheckylin@chromium.org>
Tested-by: Tai-Hsu Lin <sheckylin@chromium.org>

link/right_when_left_click_intended: add test

feedback:571030759
@time 54230

BUG=chromium:219399
TEST=should pass the test when the fix is merged

Change-Id: I69d48303cfb8ac30add6ce08480c18bbca1bcc35
Reviewed-on: https://gerrit.chromium.org/gerrit/47633
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Chung-yih Wang <cywang@chromium.org>
Tested-by: Chung-yih Wang <cywang@chromium.org>

touchtests: new run mode: --gdb

Run a test case in a GDB session. Use for debugging nasty sigsevs.

BUG=chromium:22685
TEST=touchtests anytest --gdb

Change-Id: I88ab200b5143140d4d6525bbb30631a025a6bde3
Reviewed-on: https://gerrit.chromium.org/gerrit/47378
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: Updated test_factory to use device_class and xorg_conf

recently the test_runner has been adjusted to allow different
device_classes to be used and to load properties from xorg_conf files.
These CL updated the test_factory to use these changes too. This fixes a
problem where the generated gestures printed by the test_factory do not
match those generated by the test_runner.

BUG=chromium:226239
TEST=compare gestures output of creating and running a test case

Change-Id: Ib546a32cfcb5825f3bc6d1b0238e7b1ee20816ae
Reviewed-on: https://gerrit.chromium.org/gerrit/47283
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Touchtests: cleanup too specific tests

There were a couple of tests that had very specific validators that
didn't really apply to the main thing the test was supposed to be
checking.  Ie: if one fling stop appears instead of two, etc.  These
three tests broke when I changed the timeout logic for fling stops, but
the thing they're actually testing is still working.  This cleans up
their validators so they still pass, by making them more generic when
checking secondary events.

BUG=chromium:217333
TEST=regression tests

Change-Id: I9054582742ea86f8b279212aed3d177781f8280a
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/47243
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

Test re-flinging on Snow

There was a report of Snow stopping flings when it should have been
re-flinging it.  This is a regression test that uses one of those logs
to show three consecutive flings, which should be re-flinging.  That
means it needs to check that there are no "fling stops" nor should there
be any zero velocity "fling starts"

BUG=chromium:2173333
TEST=this is the test

Change-Id: Icca363136bd54f4be180e636629e1614cc292533
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/47122
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

snow2.3/flat_thumb_move: add test

This test makes sure a flat thumb (a fat finger) can generate some
cursor movement.

BUG=chrome-os-partner:13144
TEST=this is the test.

Change-Id: Ib0cf1d059bf4d6124ce49bdff2526af0342fa00e
Reviewed-on: https://gerrit.chromium.org/gerrit/47371
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Yufeng Shen <miletus@chromium.org>
Tested-by: Yufeng Shen <miletus@chromium.org>

tests/lumpy/thumb_split_*: Add tests

These tests were collected from users that experienced false right
clicks when a thumb click (left click) was intended.

BUG=chromium:218293
TEST=These are the tests

Change-Id: I1da98cd779c272648101aa8eaa5bc1c6931aa0c9
Reviewed-on: https://gerrit.chromium.org/gerrit/47269
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

link/resting_thumb: Add test

This test ensures there is no thumb movement. It does this by finding
out when other fingers are on the pad and ensures that gestures have
start/end times within those ranges.

BUG=chromium:219398
TEST=this is the test

Change-Id: Ia2c8b3e2211b88b7300961d6a307a563df7ed102
Reviewed-on: https://gerrit.chromium.org/gerrit/47076
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>

Export DESTDIR to sub-makes

The variable DESTDIR is used in sub-makes; so export it.

BUG=none
TEST=Run `make install` without seeing these error:

make[1]: Entering directory `/mnt/host/source/src/platform/touchpad-tests/framework'
install -D -m 0755 src/fuzzy_check.py  /framework/fuzzy_check.py
install: cannot create directory /framework: Permission denied
make[1]: *** [install] Error 1
make[1]: Leaving directory `/mnt/host/source/src/platform/touchpad-tests/framework'
make: *** [install] Error 2

Change-Id: Ibc5c070a5debeb9eaf8b7d4061f7f2a585a1ef04
Reviewed-on: https://gerrit.chromium.org/gerrit/47084
Tested-by: Che-Liang Chiou <clchiou@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Che-Liang Chiou <clchiou@chromium.org>

Adding a test for missed 2f scrolls on Snow

There was a bug report showing the cursor getting moved by what was
clearly intended to be a two-finger scroll.  It's working correctly now
and this adds a regression test case to the collection that checks
against this log to make sure there is a big scroll.

TEST=this is regression test
BUG=chromium:217727

Change-Id: If7b7792dc96d5212b767bc6cfd371a14cbf7eec1
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/47056
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

snow1.3/spurious_tap: Add test

This log was generating an extra tap before. Current code has this
issue fixed.

BUG=chromium:220062
TEST=this is the test

Change-Id: I077b59b98d558c6b88c04fe60401f33ec7ac60a0
Reviewed-on: https://gerrit.chromium.org/gerrit/47030
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

link/hard_click: Add test.

This gesture accidentally generated an extra click on R25.

BUG=chromium:224530
TEST=this is the test

Change-Id: I44798cd467fc12529702ed2295ced9d1e9876349
Reviewed-on: https://gerrit.chromium.org/gerrit/47018
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

link/base_palm_presence_both: Allow more motion

Since this test was created, we've been improving the behavior. It's
still not ideal, but it's good enough. Thus, with this change, we'll
say anything under 70 movement is passing.

BUG=chromium:224980
TEST=This is the test

Change-Id: I3bd68ac68b2cb48f9fd384bfccdde5b55ade0a66
Reviewed-on: https://gerrit.chromium.org/gerrit/47015
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

tests/*/brush_after_move.py: Disable tests

We no longer try to filter an accidental tap after lifting a finger,
so we must disable these tests.

BUG=chromium:224984
TEST=We don't want these tests

Change-Id: Id201b9f8a59c0ebb5065736bae78a22d1303c145
Reviewed-on: https://gerrit.chromium.org/gerrit/47014
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

framework: fixed bug that prevents pinch gestures to be generated

BUG=chromium:225502
TEST=create a log containing a pinch gesture

Change-Id: I3da0cfd20acc452664e4def91b6d18c934ed6c40
Reviewed-on: https://gerrit.chromium.org/gerrit/47036
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

New properties for Lumpy linearity filter

This changes the properties in the regression testing to the new values
used on Lumpy that enable the linearity filter.  This also tweaks the
values for the sensor_jump filter as they interact in a funky way.

TEST=regression test and manual experimentation
BUG=chromium:214518
CQ-DEPEND=Id64baabd2523d60f6a379e3d53c9660696b93d2c

Change-Id: I1af3d3f821f9b60671eb2ffdf887123a60ddd9b5
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/46681
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

new test: lumpy/high_thumb_dragging

BUG=chromium:217820
TEST=this is the test

Change-Id: Icc3036d3a63e0819da62bcd8dcd197004f8ebd9c
Reviewed-on: https://gerrit.chromium.org/gerrit/46951
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: fix start/end validator checks

the event.start/end values have to be converted to float, otherwise
comparing them to the target values will always result in False as as a
result.

BUG=chromium:217820
TEST=next test case will test this behavior

Change-Id: I0246e2a29226d8f2a30e1771773c8e53fc8bb9e2
Reviewed-on: https://gerrit.chromium.org/gerrit/46950
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

new test: parrot1.2/thumb_split_click

BUG=chromium:218279
TEST=this is the test

Change-Id: I18d525be9f3a1aa447f639a3d801227c3be2b276
Reviewed-on: https://gerrit.chromium.org/gerrit/46928
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

new test: lumpy/right_when_left_click_intended

BUG=chromium:21554
TEST=this is the test

Change-Id: I11354d643a673c2a13b109592fc12ab0c119103c
Reviewed-on: https://gerrit.chromium.org/gerrit/46919
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

new tests: right click vs left click on link and lumpy

This adds two test cases where right clicks are expected, but previously
were not detected.

BUG=chromium:217358
TEST=this is the test

Change-Id: Ifde00a4a14d14d0a2de548d6f39cd4fce15dfb7a
Reviewed-on: https://gerrit.chromium.org/gerrit/46918
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: some user-properties might be missing in old logs, ignore.

Ignore user-properties that are not available in the log files.

BUG=chromium:217358
TEST=add an old log file with touchtests -c

Change-Id: I94e0d66ff730848bf1bf1636ffc16b61628920ce
Reviewed-on: https://gerrit.chromium.org/gerrit/46908
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Regression Tests Cleanup

Investigated all test cases with score < 0.9. Either corrected them to
be more generous with values that are not tested (e.g. fling dist in
scroll tests) or made them more strict to show up as bad tests or fail.

BUG=chromium:223321
TEST=touchtests

Change-Id: Iaff6d71b9cdf41568a665505a6bbd217060f3a47
Reviewed-on: https://gerrit.chromium.org/gerrit/46887
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: TestRunner: don't depend on env variables

The parallel test runner used to depend on the TESTS_DIR env variable,
but now just reuses the path that is passed to him via the test case.
This way the TestRunner can be easily used in autotest.

BUG=chromium:224121
TEST=run touchtests

Change-Id: If91c7c177a2ad3731c376830d8fd26ad160e9f02
Reviewed-on: https://gerrit.chromium.org/gerrit/46813
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

new platform: Magic Mouse!

After adding support for different device classes the magic mouse
platform is now working.

BUG=chromium:224120
TEST=add a test case from magic mouse logs

Change-Id: I524233c950404d876ed51f774f2299ce6b12aa19
Reviewed-on: https://gerrit.chromium.org/gerrit/46678
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: add support for specifying the device class to be used

the device class can now be specified in any property file.

BUG=chromium:224120
TEST=test with follow up CL that adds the magic mouse platform

Change-Id: I9d92dc3abef2e387fa7344fe4616493fad9fc9bf
Reviewed-on: https://gerrit.chromium.org/gerrit/46677
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: Updated user property logic to skip ignored properties

This will be used by the magic mouse to ignore certain properties that
are not applicable to this device.

BUG=chromium:224120
TEST=with follow up CL that adds the magic mouse platform

Change-Id: I422f3ddb8a2d4b89cc1cfdcd45230eeabf3b12fa
Reviewed-on: https://gerrit.chromium.org/gerrit/46676
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

added: button_right_click_no_wiggle

and updated fling_stop_order.py test. It was checking for movement after
the button click which no longer appears with the updated wiggle filter.
The check was unnecessary so it was removed.

BUG=chromium:222228
TEST=this is the test

Change-Id: Ibd543ea007a2a5756b53690ef4089dea607f89f9
Reviewed-on: https://gerrit.chromium.org/gerrit/46565
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

added: link/left_click_with_resting_thumb

BUG=chromium:2837
TEST=this is the test

Change-Id: I8c9f5dc0af019520d70ce9acd2ce625a8bd678eb
Reviewed-on: https://gerrit.chromium.org/gerrit/46553
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

added test: mario/3_finger_click

BUG=chromium:223990
TEST=this is the test

Change-Id: Icb2111f2b55f22758bfbfa39ea8806bd22e3ffe2
Reviewed-on: https://gerrit.chromium.org/gerrit/46541
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>

added test: link/scroll_false_negatives

BUG=chromium:223677
TEST=this is the test

Change-Id: I2e1dbc7aa0a0479aebbb0cc2c36adcf7acc7bbe6
Reviewed-on: https://gerrit.chromium.org/gerrit/46475
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: Support new Pointer/Scroll Sensitivity

The Test Factory has been adjusted to support both logs with a single
"Sensitivty" property and newer ones with "Pointer/Scroll Sensitivity".

BUG=chromium:218453
TEST=add a new test case

Change-Id: Ib45800a4c1417aeeb5216f47e9a076e87aaa3614
Reviewed-on: https://gerrit.chromium.org/gerrit/46464
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Che-Liang Chiou <clchiou@chromium.org>

all tests: Updated properties to use pointer/scroll sensitivity

gestures has changed to use two separate properties for sensitivity.
Updated all test properties to use those instead of the old
"sensitivity" property.

BUG=chromium:218453
TEST=touchtests on ToT. No more errors.

Change-Id: I080fe2dd475b6520e6f9cc0b3336c8e4f8cda076
Reviewed-on: https://gerrit.chromium.org/gerrit/46463
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Che-Liang Chiou <clchiou@chromium.org>

link/pinch test cases

Test cases from feedback reports about accidental invocation of the
pinch gesture. Also one test case to test for variations of pinch to
zoom, which is disabled until pinch to zoom is working properly.

BUG=chromium:221098
TEST=this is the test

Change-Id: I6d89314e928b3b9eaf02c239182835bbe0f183ff
Reviewed-on: https://gerrit.chromium.org/gerrit/46451
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: Support pinch gesture

support parsing and validation of pinch gestures.

BUG=chromium:221098
TEST=next CL contains test cases using pinch gestures

Change-Id: Id402ca4e5498a546e40fada74b596bed20f961eb
Reviewed-on: https://gerrit.chromium.org/gerrit/46450
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

new test: link/fling_stop_order

This test checks if fling stop events are sent before button events, as this
is required by Chrome.

BUG=chromium:219870
TEST=this is the test

Change-Id: I9bcf683bb413f1e198956ab6b3c8352e4d40e06c
Reviewed-on: https://gerrit.chromium.org/gerrit/46329
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>

Touchpad-Tests: Fixed errornous test results

Some tests that should fail reported a zero score with success instead.
Fixed the issue and updated the result visualization:
- lines are now colored based on their result to make it easier to find
  failures
- score < 0.5 is not reported as flaky instead of success. Success just
  sounds wrong with a bad score!

BUG=chromium:222468
TEST=just run touchtests and look at the new output

Change-Id: I07cb9606c23228a8d8402b1438595e4f1ad17928
Reviewed-on: https://gerrit.chromium.org/gerrit/46161
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>

Added test link/button_click_merge_issue

Issues with finger merging appear when multiple fingers touch down at
the same time. These issues are usually resolved after 2, 3 hardware
states. This test case shows the problem with a 3 finger click.

BUG=chromium:196321
TEST=this is the test

Change-Id: I337bfd8d7a33e2fe82f729e98550d85c278584e3
Reviewed-on: https://gerrit.chromium.org/gerrit/45904
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Touchtests: Updating tests for new Fling config

The fling settings have been changed a little bit based off a
user-study.  As a result, the fling behavior is different than it was
when a couple tests here were written, and if the tolerances on what is
acceptable fling distances for the validator is small this causes
them to fail.  This CL just updates the two newly-failing validators to
check against the new values when you run the regression tests since
while the value has changed, we are confident that it is a change for
the better.

BUG=chromium:216790
TEST=This is a regression test change, ran against the new versions of
gestures
CQ-DEPEND=Ib985b987d65325140b088a844ef5f8c0ad2b88f7

Change-Id: I0e50560fa8f3ba2374a20d123902588e924b3640
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/45743
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

Fixed: link/button_middle_click_variations

the expected behavior of one click changed:
 2 cold fingers plus the touchdown of a 3rd finger that clicks the
 button is no longer supposed to do a middle click, but a left click
BUG=chromium-os:39368
TEST=This is the test.

Change-Id: I03bda35e1778ce0eb761d70e89726b2e33710c8d
Reviewed-on: https://gerrit.chromium.org/gerrit/45777
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: Only print reports for regressions

The reports were too verbose to be useful. We don't need reports of
successfull test cases, so we now only print validation reports
for regressions or failed tests.

BUG=chromium-os:39362
TEST=run touchtests

Change-Id: I92083c9a45c62b807ae8e398f6c8b0ce7024b6c4
Reviewed-on: https://gerrit.chromium.org/gerrit/45480
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: Allow tests to be documented and marked as disabled

The docstring of each Validator method is not printed in the validation
reports so each test case can have a description of what it is testing.
Also tests can now be marked as disabled if they fail for known reasons.

BUG=chromium-os:39293
TEST=touchtests
see that two failing tests for butterfly2.4 are now marked as disabled

Change-Id: Ic73098d23fc3449bce300f7535b63dd2e11e63a7
Reviewed-on: https://gerrit.chromium.org/gerrit/45479
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

link: Variations of button clicks for right and middle click

Each case contains multiple variations of finger positions and movements
that are supposed to invoke a right or middle click.

BUG=chromium-os:39368
TEST=this is the test

Change-Id: I382abc783acaa4c7ea1888fc17fdebb8ff3f32c7
Reviewed-on: https://gerrit.chromium.org/gerrit/45260
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: Smarter re-compile. Don't run if there are compile errors

Also, only show compile log if there are errors present.
Note: You will have to re-run make setup-in-place to make this work.
+ small style fixes in main.py

BUG=chromium-os:39367
TEST=run touchtests

Change-Id: I957058fbb27a719fc1bbe2d2007df754228ef8e6
Reviewed-on: https://gerrit.chromium.org/gerrit/45478
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Framework: Add --autotest flag

Add the --autotest flag. The autotest flag is set when running
touchtests on devices as part of autotest.
This will be required for future CLs to re-compile only when running
touchtests locally.

BUG=chromium-os:39367
TEST=Run touchtests --autotest. Still works the same.

Change-Id: Ifd4f1a300e5a864b6f7074ea3b5272083e460d48
Reviewed-on: https://gerrit.chromium.org/gerrit/45483
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Revert "framework: Allow tests to be documented and marked as disabled"

This reverts commit 2cae4432e00241710d6546e6c748f1c9e39dfbf5

Change-Id: I600ffdb3aa54605e6ba1d6488558eaa6c5603603
chromium-os:39367
Reviewed-on: https://gerrit.chromium.org/gerrit/45385
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

Revert "framework: Only print reports for regressions"

This reverts commit 0559fa130a39307e49ad3c72342a87e0675576fd

Change-Id: I1d9f61f5ef659418a06ec74d0f9c9b4978c3c153
chromium-os:39367
Reviewed-on: https://gerrit.chromium.org/gerrit/45384
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

Revert "framework: Smarter re-compile. Don't run if there are compile errors"

This reverts commit af6791aacca37ac38a00282cbcade6e068a0e012

BUG=chromium-os:39367

Change-Id: I815848889162b50d6d831445e2f8ee69c7adfd3e
Reviewed-on: https://gerrit.chromium.org/gerrit/45382
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

framework: Smarter re-compile. Don't run if there are compile errors

Also, only show compile log if there are errors present.
Note: You will have to re-run make setup-in-place to make this work.
+ small style fixes in main.py

BUG=chromium-os:39367
TEST=run touchtests

Change-Id: I64306c94eda5519f11013289391061ae5326f651
Reviewed-on: https://gerrit.chromium.org/gerrit/44298
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: Only print reports for regressions

The reports were too verbose to be useful. We don't need reports of
successfull test cases, so we now only print validation reports
for regressions or failed tests.

BUG=chromium-os:39362
TEST=run touchtests

Change-Id: I51f81cf312b16329ea69227efd2546f5646ac0b6
Reviewed-on: https://gerrit.chromium.org/gerrit/44287
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

framework: Allow tests to be documented and marked as disabled

The docstring of each Validator method is not printed in the validation
reports so each test case can have a description of what it is testing.
Also tests can now be marked as disabled if they fail for known reasons.

BUG=chromium-os:39293
TEST=touchtests
see that two failing tests for butterfly2.4 are now marked as disabled

Change-Id: I6fb10d49b1cd0dea31b5a19b067e1984cae63a8a
Reviewed-on: https://gerrit.chromium.org/gerrit/44286
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

fix Makefile for ebuild

BUG=chromium-os:37644
TEST=in chroot, the command 'sudo make install' should make no
  difference with the patch. For emerge on a target board,
  try the following steps:
    1. setup_board --board=lumpy
    2. cros_workon --board=lumpy start touchpad-tests
    3. emerge-lumpy touchpad-tests
  And check if the xorg-conf files of the target platform are installed
under
    /build/lumpy/usr/local/autotest/client/deps/touchpad-tests/xorg-conf-files

Change-Id: Ie4d9b58948dacbabb8649e7301c786bfca409da1
Reviewed-on: https://gerrit.chromium.org/gerrit/44029
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Commit-Queue: Chung-yih Wang <cywang@chromium.org>
Tested-by: Chung-yih Wang <cywang@chromium.org>

link/ttc_with_palm: Add test

This was a test where Pramod tried to tap twice, and both taps failed
to click.

BUG=chromium-os:39231
TEST=This is the test

Change-Id: I1f6751f1fb93616159ca49dade6c7d58236720a7
Reviewed-on: https://gerrit.chromium.org/gerrit/44225
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

Fix Fling interpretation in touchpad replay

In gesture_log.py when the Python testing framework is reinterpreting
all the gestures into Python objects it was deciding between FlingStops
and FlingStarts by checking their x and y velocities.  There is actually
a bit that is set that makes the distinction and it's legal to have a
FlingStart that have 0 velocity.  This changed it to check that bit
instead of the velocities, and patches the couple of tests that broke as
a result.

BUG=chromium-os:39266
TEST=The regression tests.  Replayed on a couple of logs that I
knew what to look for and the events appeared to be correct.

Change-Id: I6fd3cd4be38c8dd2653b2e24477beda1fad2fcfd
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/44103
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

Fix some tests that were broken for minor reasons

stationary_1F: need to merge the motion. merging was default when this
test was created.

tap_no_wiggle: The minimum pressure was not met for one of the taps,
so reduce count by 1.

base_scroll_right: We now fling, and the fling is reasonable.

BUG=chromium-os:39294
TEST=These are the tests

Change-Id: I0072b4da74dcc7b8c8cbd442f6eaf6eb4f2e939d
Reviewed-on: https://gerrit.chromium.org/gerrit/44186
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

link: Added test cases for unintended left click

Multiple reports about right click not working properly have been
turned into regression tests.

BUG=chromium-os:38276
TEST=this is the test

Change-Id: Ie23cb45e02c5051fa2f79dc9f75fe7e9980e7ab7
Reviewed-on: https://gerrit.chromium.org/gerrit/44214
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

touchtests: Tap Drag Enable is a user defined property now

So it should be copied when creating new test cases.

BUG=chromium-os:39201
TEST=add recent log with tap to drag enabled and view
touchtests testcase -val. Check if Tap Drag Enable is in the
property list.

Change-Id: I3b65a80d39016bf8a4eb4aa123d766715ff7a58a
Reviewed-on: https://gerrit.chromium.org/gerrit/43931
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

touchtests: display error when adding test-case to non-existing platform

It did not complain, but as the platform.dat file is missing the
trimming tool will crash without a proper error message.

BUG=chromium-os:37856
TEST=touchtests bla -c ... vs touchtests lumpy/bla -c

Change-Id: I69f6d139123681dcdbaca221449be6f9ee9bd68d
Reviewed-on: https://gerrit.chromium.org/gerrit/43930
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Removed common.mk, it's no longer needed

BUG=chromium-os:39109
TEST=none

Change-Id: I3f8e51d3311cabdccfa127195fc6731d168452e4
Reviewed-on: https://gerrit.chromium.org/gerrit/43929
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Link: Test case for more generous tap to drag properties

Drag works now where it did not work before.

BUG=chromium-os:39072
TEST=touchtests

Change-Id: Ib8264785118ee161c01b9fee4b0b14b52c2f6489
Reviewed-on: https://gerrit.chromium.org/gerrit/43916
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

fuzzy_check.py: Always return pair from Check()

Without this, if such a case is hit, an error is thrown.

BUG=chromium-os:39181
TEST=None

Change-Id: I5ef14dd75e201ef5539e6179b1eee1893cbc2f9d
Reviewed-on: https://gerrit.chromium.org/gerrit/43855
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

tests/butterfly2.4/move_jumped_at_end: Add test

Adds a test that a bit of motion doesn't occur on liftoff.

Also, update some tests that had regressed w/ the new changes. I
manually inspected each and they were not true regressions.

BUG=chromium-os:36699
TEST=This is the test

Change-Id: If479ef835b7683b76769c4de8e9ab98d94494081
Reviewed-on: https://gerrit.chromium.org/gerrit/41682
Reviewed-by: Yufeng Shen <miletus@chromium.org>
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

tests/link/merge_{1..5}: Add tests

These are finger merge mistakes that Dave Moore saw on Link.

BUG=chromium-os:37272
TEST=These are the tests

Change-Id: I7eb6c27ae288924154f6a3dc58d5842ec262cf0f
Reviewed-on: https://gerrit.chromium.org/gerrit/43138
Commit-Queue: Andrew de los Reyes <adlr@chromium.org>
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Andrew de los Reyes <adlr@chromium.org>

Added in-place make targets

The in-place make targets will replace local-install and make
mttools too. The touchtests command is updated to automatically
run make in-place to update gestures/evdev/replay with the latest
source.

BUG=chromium-os:38304
TEST=$ sudo make setup-in-place (required only once!)
$ touchtests
make a change to gestures
$ touchtests
see that gestures is recompiled and used for the new test run!

Change-Id: Ie7882f6b4fb49ce8039f1fd748f6718a8129b6f6
Reviewed-on: https://gerrit.chromium.org/gerrit/43814
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

New Command Line Interface

The long awaited CL to change the touchtests command line interface
to OptionParser. The new interface also integrated mtedit for
integrating the trimming process into the test creation process.

BUG=chromium-os:38304
TEST=touchtests -h

Change-Id: Ib50187797d24f5e1ba3c55ab03a6338e1c3b2fef
Reviewed-on: https://gerrit.chromium.org/gerrit/43637
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Makefile update to match latest refactorings

Replay is no longer in this repository, so don't "make" it.
Fixed XORG_CONF_DIR to point to xorg-conf/files in the chromiumos
overlay. This is only temporary until the configuration files
are moved to a separate repository.

BUG=chromium-os:38031
TEST=sudo make local-install
touchtests run all
sudo make install
cd target
./touchtests run all

Change-Id: I9b24307f63d433fa5640438518394928bf7757ee
Reviewed-on: https://gerrit.chromium.org/gerrit/43108
Reviewed-by: Yufeng Shen <miletus@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Properties: Read xorg properties for all platforms

This CL updates all platform properties files to read the current xorg
configuration properties instead of setting them manually inside
the properties files.
Some overrides are required, to keep tests passing. Updating all
properties to the latest versions from xorg does break tests. I
suggest to carefully look into the properties that are still
manually defined and decide which of these are necessary, and which
indicate an actual broken test. For now this CL will only preserve
the current behavior without changing any score.

BUG=chromium-os:38031
TEST=touchtests run all
Same results as before.

Change-Id: Ia4a428e67201f3a768596bcd85d216e58aac0da7
Reviewed-on: https://gerrit.chromium.org/gerrit/43050
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Removed replay from repository. Link to mttools.

replay will now be maintained as part of mttools, which will make
touchtests depend on mttools.
After updating to this CL, you will have to install mttools via the
following commands before you can run touchpad-tests again:
$ cd platform/mttools
$ make
$ sudo make install
This will allow us to re-use replay for other command line tools in
future.

BUG=chromium-os:38686
TEST=install mttools, then touchtests run all. Everything still works.

Change-Id: I2e04ac1ad8d742c76bb9be825cdb346a6cd7034e
Reviewed-on: https://gerrit.chromium.org/gerrit/42946
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Fixed makefile: Use LDLIBS instead of LDFLAGS

-l flags for the linker were going to LDFLAGS which caused
build errors with the latest base lib.
-l flags now go to LDLIBS where they belong

BUG=chromium-os:38449
TEST=make all

Change-Id: Iff2feceb4aa6a945bc8ad282c42d1b23af641d3a
Reviewed-on: https://gerrit.chromium.org/gerrit/42741
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Fix a typo bug in the Touchtests Makefile

There's a missing ")" in the Makefile for the Touch regression tests,
this just adds the closing paren in.

BUG=chromium-os:38358
TEST=I ran the offending install command (make local-install) and it
worked.  Then running the tests seemed to work as well after it was
installed.

Change-Id: I2c6ba2c319bfa41811bf5aa7465fac1cbff9b42f
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/42257
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

butterfly2.4: Added test case for scroll being treated as move

One of the fingers was being treated as a palm. This issue has been
fixed in another CL. See bug report.

BUG=chromium-os:38126
TEST=touchtests run all

Change-Id: Ib7137e980c69a869074d3410e2645cbcc81efa4c
Reviewed-on: https://gerrit.chromium.org/gerrit/42074
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

Adding a test for Link for accidental 2f click

This is a test based on a log from @Trod where he meant to left click,
but his palm registered in the bottom right corner of the pad and his
thumb (that was doing the physical clicking) was juuuust close enough to
trigger a 2F right click.

BUG=chrome-os-partner:16598
TEST=this is the test
CQ-DEPEND=Iedd34062d6967c22471a10b2b2a11439fa396579

Change-Id: Id7a12e600235fb14264c8e706a91d23ed59837b6
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/42017
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

Gestures: really fast physical click test

This is a test for link that makes sure that really fast physical clicks
are still registered as clicks by the system.  These logs have clicks
that happened so rapidly that the pysical button registers before the
capacitive surface ever registers the finger.  The click events should
happen even then.

BUG=chromium-os:38417
TEST=This is a regression test

Change-Id: Iee66b33a8cee0f840bec88bc70a674ef30451265
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/42410
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

Adding regression tests for zero-finger clicks

This adds two regression tests that do essentially the same thing but
for the two effected platforms: Link and Snow.

This tests if they will get a "click" event when the touchpad is
physically depressed without a finger on it.  These devices are
susceptable to bending the case in a certain way that will cause a click
to happen when you're not using the touchpad.  There is a change waiting
to go in that fixes this for Link/Snow and here are two regression tests
to confirm that they no longer generate a click when this happens

Each test consists of two clicks.
 1.) a click without any finger on the touchpad, which should be ignored
 2.) an extremely fast physical click which should still be accepted

BUG=chrome-os-partner:17406
TEST=regression test with the patch in question applied and nothing
regressed, and the two new tests passed as well.
CQ-DEPEND=I5f5ece4e8957341fc3dd10325e78085c013aa64a

Change-Id: I9ae54128e1054cb2a87098c454463eea2bc32e6c
Signed-off-by: Charlie Mooney <charliemooney@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/42008
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>

Replay: Handle kGestureTypeSwipeLift

A recent update to the gestures library introduced
kGestureTypeSwipeLift. Handle it in the replay tool to make
everything compile smoothly!

TEST=make replay
BUG=none

Change-Id: I252df34ac5ad53c7a2806902e88c4c20f4a1265f
Reviewed-on: https://gerrit.chromium.org/gerrit/42055
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

TestCase: Look for xorg settings in platform.props and inject

This change will integrate the xorg_parser module to parse xorg
config files whenever a platform.props specifies an xorg file
and identifier. See tests/lumpy/platform.props for an example.

If touchtests reports a Key Error "XORG_CONF_FILE" please reinstall
touchtests via "sudo make local-install".

BUG=chromium-os:38031
TEST=touchtests run lumpy/*
will provide the same results as before, but with reading the properties
from the xorg conf files of the source tree

Change-Id: I9d8149bace212eeedb570929046cd48bfdc2a125
Reviewed-on: https://gerrit.chromium.org/gerrit/41774
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>
Reviewed-by: Dennis Kempin <denniskempin@chromium.org>

Makefile: setup xorg-conf-files folder

In order to extract property information from the xorg-config-files
these have to be accessible by the touchtests framework. The Makefile
now installs a symlink to the xorg-conf folder of the chromiumos source
tree for local-installs.
For full installs it will create a copy of each file inside. The path
to the folder/symlink containing the config files is passed to
touchtests as an environment variable.

BUG=chromium-os:38031
TEST=make install; ls target/xorg-conf-files
make local-install; ls local-install/xorg-conf-files

Change-Id: I5a2ef2f96445a89eb4472f4c5e4a26c83901007d
Reviewed-on: https://gerrit.chromium.org/gerrit/41771
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>

New module: xorg_parser

A class for parsing xorg config files for input class options.
Unit tests are included and include a test for lumpy's config.

BUG=chromium-os:38031
TEST=run: make test. Watch XorgInputClassParserTests pass. Note
with recent changes to the framework a handfull of other test cases
are broken. This is not caused by this CL.

Change-Id: I87cfdf93fecd0cbef41c7c1fdea65d5954a0ed90
Reviewed-on: https://gerrit.chromium.org/gerrit/41650
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Commit-Queue: Dennis Kempin <denniskempin@chromium.org>
Tested-by: Dennis Kempin <denniskempin@chromium.org>