chromiumos/third_party/autotest.git
13 months agofirmware_TouchMTB: print metrics with missing values 18/66818/3 master
Joseph Hwang [Tue, 20 Aug 2013 06:46:01 +0000 (14:46 +0800)]
firmware_TouchMTB: print metrics with missing values

It is possible that some gestures have been recorded for a firmware
but are missing in the tests for another firmware. The summary module
should be able to handle this situation when printing the metrics
statistics. When there are no metrics data, it just leaves proper
spaces.

As an example, there are no drag_edge_thumb gesture files for fw_11.27.
Hence, it just leaves some blank spaces in the summary report when
printing the metrics statistics.

Test Summary (by gesture) :  fw_1.0.AA           fw_11.27
                             mean    ssd count   mean    ssd count
-------------------------------------------------------------------------------
drag_edge_thumb
  CountTrackingIDValidator:  0.50 0.71     2

BUG=chromium:235753
TEST=None. Will be tested with subsequent patches.

Change-Id: I31311f2d00ce486082c69527b3e23ccfb3daf4f1
Reviewed-on: https://gerrit.chromium.org/gerrit/66818
Reviewed-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Tested-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Commit-Queue: Joseph Shyh-In Hwang <josephsih@chromium.org>

13 months agofirmware_TouchMTB: print scores statistics with missing scores data 17/66817/3
Joseph Hwang [Tue, 20 Aug 2013 05:11:12 +0000 (13:11 +0800)]
firmware_TouchMTB: print scores statistics with missing scores data

It is possible that some gestures have been recorded for a firmware
but are missing in the tests for another firmware. The summary module
should be able to handle this situation when printing the scores
statistics. When there are no scores data, it just leaves proper
spaces.

As an example, there are no rapid_taps_20 gesture files for fw_11.27.
Hence, it just leaves some blank spaces in the summary report.

Test Summary (by gesture) :  fw_1.0.AA           fw_11.27
                             mean    ssd count   mean    ssd count
----------------------------------------------------------------------
rapid_taps_20
  CountTrackingIDValidator:  1.00   0.00     9

BUG=chromium:235753
TEST=None. Will be tested with subsequent patches.

Change-Id: I8d3148a35008ceb6edf61a65c89f77b6c8f66fe8
Reviewed-on: https://gerrit.chromium.org/gerrit/66817
Reviewed-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Tested-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Commit-Queue: Joseph Shyh-In Hwang <josephsih@chromium.org>

13 months agofirmware_TouchMTB: add a robot test log for link 16/66816/3
Joseph Hwang [Tue, 20 Aug 2013 08:36:06 +0000 (16:36 +0800)]
firmware_TouchMTB: add a robot test log for link

We already have some test logs for lumpy. In this patch, we
add a robot test log for link. This is used to conduct tests
for subsequent patches.

BUG=chromium:235753
TEST=None. Will be tested with subsequent patches

Change-Id: I3f044452cd1bdb5fabdb96b882dca0b003b16336
Reviewed-on: https://gerrit.chromium.org/gerrit/66816
Reviewed-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Tested-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Commit-Queue: Joseph Shyh-In Hwang <josephsih@chromium.org>

13 months agofirmware_TouchMTB: replay with a mocked device 45/66345/4
Joseph Hwang [Tue, 13 Aug 2013 04:17:18 +0000 (12:17 +0800)]
firmware_TouchMTB: replay with a mocked device

It is handy and sometimes essential to be able to replay the test
logs captured from a platform on another platform.

When replaying logs, the board on which the logs were captured could
be different from the board of the chromebook currently used. Hence,
the correct board should be extracted from the log specified in the
replay directory. The following priority is used to find the device
description file used to mock the particular touch device for that
board:
(1) use the device description file in the replay directory
(2) use the device description file found in tests/device directory

However, if "-d/--system_device" command line option is specified, use
the system touch device found on the chromebook instead as before.

BUG=chromium:274204
TEST=Replay the lumpy logs on both lumpy and link. Observe that
their summary reports are exactly the same.
$ cd /usr/local/autotest/tests/firmware_TouchMTB
$ tools/machine_replay.sh -b tests/logs/lumpy -s
$ ./summary.sh -d /tmp -m f

Change-Id: I95a39d0ead821de9379e2f3a26f19e42a9c829b9
Reviewed-on: https://gerrit.chromium.org/gerrit/66345
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Tested-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Commit-Queue: Joseph Shyh-In Hwang <josephsih@chromium.org>

13 months agofirmware_TouchMTB: adjustment of linearity validator 44/66344/4
Joseph Hwang [Wed, 7 Aug 2013 02:32:22 +0000 (10:32 +0800)]
firmware_TouchMTB: adjustment of linearity validator

We need to do some adjustment for the linearity validator according
to the x-t and the y-t figure in the attached png file in
chromium:248210 #6 which is a left-to-right one-finger-tracking
gesture performed by the robot.

Adjustment as follows:
  (1) Calculate the regression line based on only the middle segment.
  (2) Calculate the metrics of max errors and rms erros only on the
      middle segment. The begin segment and the end segment may only
      represent a pause.
  (3) Pick up only certain axis(es) when calculating the statistics
      of metrics:
      horizontal lines: metrics only in the x axis
      vertical   lines: metrics only in the y axis
      diagonal   lines: metrics both in the x and y axes

BUG=chromium:248120
TEST=Run the unit tests on a chromebook or in chroot
(cr) $ cd .../firmware_TouchMTB
(cr) $ python tests/run_all_unittests.py
Observe that all unit tests should pass.

Change-Id: I28566662831aae50be3274bd9b23e870506ba160
Reviewed-on: https://gerrit.chromium.org/gerrit/66344
Reviewed-by: Charlie Mooney <charliemooney@chromium.org>
Tested-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Commit-Queue: Joseph Shyh-In Hwang <josephsih@chromium.org>

13 months agoautotest: Add network_DestinationVerification to network_nightly suite 86/66886/2
Christopher Wiley [Fri, 23 Aug 2013 22:19:43 +0000 (15:19 -0700)]
autotest: Add network_DestinationVerification to network_nightly suite

This tests that we can authenticate Chromekey endpoints.  We recently
moved it out of the private autotest repository, and we should now
run it regularly.

BUG=chromium:223763
TEST=None

Change-Id: If5f376ea6cd2da3e80da9ab984dad885ea8acc44
Reviewed-on: https://gerrit.chromium.org/gerrit/66886
Tested-by: Christopher Wiley <wiley@chromium.org>
Reviewed-by: Dan Shi <dshi@chromium.org>
Commit-Queue: Christopher Wiley <wiley@chromium.org>

13 months agoCHERRY-PICK: Save logs in USB in CameraPerformance test in 'Full' test 26/66926/2 prod
Justin Chuang [Tue, 20 Aug 2013 04:05:03 +0000 (12:05 +0800)]
CHERRY-PICK: Save logs in USB in CameraPerformance test in 'Full' test

BUG=None
Test=Manually,
After 'Full' test + data_method='usb', .txt logs should be saved in
USB drive.

Change-Id: I8286906671af79543a11948efb60e847ce4a787d
Reviewed-on: https://gerrit.chromium.org/gerrit/66305
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
Commit-Queue: Justin Chuang <jchuang@chromium.org>
Tested-by: Justin Chuang <jchuang@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/66926

13 months agoAdd "security_SandboxLinuxUnittests". 15/66715/3
Jorge Lucangeli Obes [Thu, 22 Aug 2013 22:08:49 +0000 (15:08 -0700)]
Add "security_SandboxLinuxUnittests".

BUG=chromium:277816
TEST=run_remote_tests.sh against daisy.

Change-Id: I64d196356ed2388f971bd4cf47ccbbc07aa029c5
Reviewed-on: https://gerrit.chromium.org/gerrit/66715
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Jim Hebert <jimhebert@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>

13 months agoGLBench: update reference images. 68/66868/2
Ilja Friedel [Fri, 23 Aug 2013 22:14:33 +0000 (15:14 -0700)]
GLBench: update reference images.

BUG=chromium:278573
TEST=None.

Change-Id: I1ba2bcd2e4f2b48e1365930647bca08de3d038d8
Reviewed-on: https://gerrit.chromium.org/gerrit/66868
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
13 months agoFix Piglit. 62/66862/3
Ilja Friedel [Fri, 23 Aug 2013 21:35:00 +0000 (14:35 -0700)]
Fix Piglit.

crash_blacklist is a member of cros_ui_test and Piglit now is a simple test.
We move the blacklist to graphics_utils until we find a permanent place for
it. (But right now graphics tests are the only user of this functionality.)

BUG=chromium:271828
TEST=Ran on Alex and Link.

Change-Id: I9ae6e17d2519daa8738e0fab65941f1ac7019690
Reviewed-on: https://gerrit.chromium.org/gerrit/66862
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
13 months ago[autotest] In run_suite, don't flag tests with status TEST_NA. 33/66733/4
J. Richard Barnette [Thu, 22 Aug 2013 23:28:32 +0000 (16:28 -0700)]
[autotest] In run_suite, don't flag tests with status TEST_NA.

With this change, tests that end with status TEST_NA will no longer
be listed with failures on the buildbot waterfall.  The intent is to
reduce noise and confusion for sheriffs who must decide what tests
need triage and action.

BUG=chromium:278338
TEST=run_suite for dummy suite with a local image

Change-Id: I791d3736599fc1f137d6afe7fc66f9d271e40d7d
Reviewed-on: https://gerrit.chromium.org/gerrit/66733
Commit-Queue: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
13 months ago[autotest] passing_experimental.py now files bugs. 73/66573/5
Keyar Hood [Wed, 21 Aug 2013 22:17:31 +0000 (15:17 -0700)]
[autotest] passing_experimental.py now files bugs.

Instead of sending emails, passing_experimental.py will now file bugs.

manual_check_passing_experimetnal.py is used to test that
passing_experimental.py correctly submits bug reports that are deduped. It
creates a fake database and then calls passing_experimental.py. It requires
that the user then manually check that the bug is correctly submitted and
deduped.

BUG=chromium:212671
TEST=manual_check_passing_experimetnal.py submits issues using the
passing_experimental.py that are then manually checked. The unittests are also
used for testing.

Change-Id: I8b25fc7e409710dbd783145dec6e33de639c12d7
Reviewed-on: https://gerrit.chromium.org/gerrit/66573
Reviewed-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
Tested-by: Keyar Hood <keyar@chromium.org>
Commit-Queue: Keyar Hood <keyar@chromium.org>

13 months agoChanging the priority list for chrome driver instance 83/66883/2
bmahadev [Fri, 23 Aug 2013 23:31:18 +0000 (16:31 -0700)]
Changing the priority list for chrome driver instance

BUG=chromium:272652
TEST=None

Change-Id: Ie3dd775acc06df71ae9f38593454e516f7076f44
Reviewed-on: https://gerrit.chromium.org/gerrit/66883
Reviewed-by: Kris Rambish <krisr@chromium.org>
Commit-Queue: Bindu Mahadev <bmahadev@chromium.org>
Tested-by: Bindu Mahadev <bmahadev@chromium.org>
13 months agoFAFT: Adding 'platform' attribute to config object 02/66802/2
Tom Wai-Hong Tam [Fri, 23 Aug 2013 07:43:20 +0000 (15:43 +0800)]
FAFT: Adding 'platform' attribute to config object

Tests expect this attribute to exist. In order not to break the existing
tests, add the 'platform' attribute back. But long term its not certain
if this should be the place for this attribute, since its not config
exactly.

BUG=None
TEST=None

Change-Id: I77504f3e89830464c750aa5a15d5b17394c68deb
Reviewed-on: https://gerrit.chromium.org/gerrit/66802
Commit-Queue: Tom Wai-Hong Tam <waihong@chromium.org>
Tested-by: Tom Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: Yusuf Mohsinally <mohsinally@google.com>
Commit-Queue: Yusuf Mohsinally <mohsinally@chromium.org>
Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
Tested-by: Yusuf Mohsinally <mohsinally@chromium.org>
13 months ago[autotest] remove some accidentally committed debug prints 39/66839/2
Aviv Keshet [Fri, 23 Aug 2013 18:06:27 +0000 (11:06 -0700)]
[autotest] remove some accidentally committed debug prints

Oops. Nobody wanted to see that.

BUG=None
TEST=None

Change-Id: I86ec5151dc94c5a1a63ebb13b4498a04d9cf1b2d
Reviewed-on: https://gerrit.chromium.org/gerrit/66839
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>

13 months agoFix usb device detection for ARM devices 50/66750/2
Vadim Bendebury [Fri, 23 Aug 2013 01:50:12 +0000 (18:50 -0700)]
Fix usb device detection for ARM devices

The code in server.cros.faft.faft_classes.get_dut_usb_dev() uses
command 'ls /dev/sd[a-z]*' ran on the DUT with the USB stick connected
and disconnected, to determine the USB stick device. on ARM platforms
there is no other sd devices, so the shell command fails, causing test
exception and leaving the USB stick powered off.

This change makes the wildcard more broad, so that there are devices
reported by the ls command in both cases.

BUG=chrome-os-partner:21659
TEST=manual
  . the following autotest does not fail on Pit anymore:

  $ ~/trunk/src/scripts/run_remote_tests.sh --board=peach_pit --use_emerged \
       --servo --remote=192.168.1.11 firmware_SelfSignedBoot

Change-Id: If7f1acbc91314af4133263c5d463bb621368be1a
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/66750
Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
13 months ago[autotest] Isolate code for autofiled bug keyvals 92/66592/2
J. Richard Barnette [Wed, 21 Aug 2013 23:34:16 +0000 (16:34 -0700)]
[autotest] Isolate code for autofiled bug keyvals

There was a small amount of duplicated code shared between the code
that records job keyvals when a bug is filed, and the code that
extracts the bug information from keyvals when reporting suite
results.  This pulls that code into a common location so it can
be shared, and modified more transparently.

BUG=None
TEST=run dummy suite on a local autotest instance, see expected results

Change-Id: I65193559447ffadbc02b781a3654743e5143c9ee
Reviewed-on: https://gerrit.chromium.org/gerrit/66592
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Prashanth Balasubramanian <beeps@chromium.org>
Commit-Queue: Richard Barnette <jrbarnette@chromium.org>

13 months agoUpdate Connectivity Debugger expectations with metricsPrivate 04/66704/2
Jim Hebert [Thu, 22 Aug 2013 21:37:08 +0000 (14:37 -0700)]
Update Connectivity Debugger expectations with metricsPrivate

BUG=none
TEST=security_BundledExtensions passes on stout/ToT

Change-Id: I003b90b72b11812e30549b0a955eb0db4fdbf14e
Reviewed-on: https://gerrit.chromium.org/gerrit/66704
Commit-Queue: Jim Hebert <jimhebert@chromium.org>
Tested-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
13 months ago[autotest] Test health scripts will run again... 76/66576/3
Keyar Hood [Wed, 21 Aug 2013 23:04:01 +0000 (16:04 -0700)]
[autotest] Test health scripts will run again...

Do not pass script name to the argparse in test health scripts. It throws an
error as it expects the passed arguments to exclude the script name.

BUG=None
TEST=Manual testing.

Change-Id: I84187211873994f0951f77b7bfa27390015ae771
Reviewed-on: https://gerrit.chromium.org/gerrit/66576
Reviewed-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
Commit-Queue: Keyar Hood <keyar@chromium.org>
Tested-by: Keyar Hood <keyar@chromium.org>
13 months agoUpdate the APConfigurator to take the APSpec. 98/66298/5
Kris Rambish [Tue, 20 Aug 2013 01:14:51 +0000 (18:14 -0700)]
Update the APConfigurator to take the APSpec.

Moving along with the design updates.  This makes it easy to setup
an APConfigurator using an APSpec.  Also update the factory so this
can all be done in one step if desired.

TEST=Unittests
BUG=None

Change-Id: I9c1bab1b227cf90227824bf38b3506b632b0fb31
Reviewed-on: https://gerrit.chromium.org/gerrit/66298
Tested-by: Kris Rambish <krisr@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Kris Rambish <krisr@chromium.org>

13 months agopsuedomodem: Fix ModemManager DBus error constants. 10/66710/4
Ben Chan [Thu, 22 Aug 2013 21:41:51 +0000 (14:41 -0700)]
psuedomodem: Fix ModemManager DBus error constants.

ModemManager DBus errors are prefixed
"org.freedesktop.ModemManager1.Error.*" instead of
"org.freedesktop.ModemManager1.*". This CL fixes that by using the
MM_*_ERROR_DBUS_PREFIX macros to obtain the prefixes.

BUG=chromium:277825
TEST=Use mmcli to interact with pseudomodem and verify the DBus errors
reported by pseudomodem have the right prefix.

Change-Id: Ib89ff271fa2126248e51a2786cc09e1a50d7be06
Reviewed-on: https://gerrit.chromium.org/gerrit/66710
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>

13 months agoRemove unused wifi tests with Chrome dependencies 21/66721/3
Steven Bennetts [Thu, 22 Aug 2013 22:36:00 +0000 (15:36 -0700)]
Remove unused wifi tests with Chrome dependencies

BUG=chromium:259896
TEST=none (no build failures)

Change-Id: I70eabf48a3e1ecbe0346ba1f44c9a16a1a82ee62
Reviewed-on: https://gerrit.chromium.org/gerrit/66721
Reviewed-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Arman Uguray <armansito@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
13 months agoLimit the ebuild-check to client-side autotests 89/66689/3
Jim Hebert [Thu, 22 Aug 2013 20:22:22 +0000 (13:22 -0700)]
Limit the ebuild-check to client-side autotests

BUG=chromium:277731
TEST=edit the control file for platform_InstallTestImage (pass)
TEST=add a dummy client side test (should fail)

Change-Id: I4b0649385feebf7ac42949483380a1e89da9fd8e
Reviewed-on: https://gerrit.chromium.org/gerrit/66689
Commit-Queue: Jim Hebert <jimhebert@chromium.org>
Tested-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Dan Shi <dshi@chromium.org>
13 months agohardware_TrackpadFunction: remove EXPERIMENTAL flag 25/66625/2
Chung-yih Wang [Thu, 22 Aug 2013 06:13:59 +0000 (14:13 +0800)]
hardware_TrackpadFunction: remove EXPERIMENTAL flag

As the test has been running for a while(for months) without any issue
on all platforms, let's remove the experimental flag and make it
non-experimental.

BUG=chromium:209307
TEST=examine test results from cautotest waterfall on all platforms.

Change-Id: Ibc31ffd361191a200b045e5cd6cdba285f750b23
Reviewed-on: https://gerrit.chromium.org/gerrit/66625
Reviewed-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Reviewed-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
Commit-Queue: Chung-yih Wang <cywang@chromium.org>
Tested-by: Chung-yih Wang <cywang@chromium.org>
13 months agoAdd an alternate detection technique for WiFi_Regulatory 15/66015/2
Paul Stewart [Fri, 16 Aug 2013 00:33:42 +0000 (17:33 -0700)]
Add an alternate detection technique for WiFi_Regulatory

In addition to testing for ping packet loss, also test for
reception of a DEAUTH frame at the AP.  Adherence in some
devices can only be detected by packet loss (they leave
the channel silently) so leave both detection methods in
parallel.

BUG=chrome-os-partner:20691
TEST=Run test on daisy, lumpy and a WP2 device

Change-Id: Id8610d5650c1dc0edf0c51933377bdb33f11c676
Reviewed-on: https://gerrit.chromium.org/gerrit/66015
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Paul Stewart <pstew@chromium.org>
Tested-by: Paul Stewart <pstew@chromium.org>
13 months agoCreate autotest for ECHO extension to test that expected error messages 61/66161/7
andycai [Wed, 21 Aug 2013 22:24:56 +0000 (15:24 -0700)]
Create autotest for ECHO extension to test that expected error messages
are displayed

BUG=chromium:268066
TEST=Ran run_remote_tests command to test on my Chromebook.

Change-Id: I81cf472112c2e2b7de76a7b51f58688db003ca85
Reviewed-on: https://gerrit.chromium.org/gerrit/66161
Tested-by: Andy Cai <andycai@chromium.org>
Reviewed-by: Andy Cai <andycai@chromium.org>
13 months agoFix to pit platform config override file. 27/66727/2
Yusuf Mohsinally [Thu, 22 Aug 2013 23:28:20 +0000 (16:28 -0700)]
Fix to pit platform config override file.

Removing invalid 'self'.

BUG=None
TEST=None

Change-Id: I2caaa67bf0f738995c4ef63f2e69d47642f26d3d
Reviewed-on: https://gerrit.chromium.org/gerrit/66727
Commit-Queue: Yusuf Mohsinally <mohsinally@chromium.org>
Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
Tested-by: Yusuf Mohsinally <mohsinally@chromium.org>
13 months agoAllow eMMC devices to consume some small portion of storage. 13/66413/2
Todd Broch [Tue, 20 Aug 2013 19:55:39 +0000 (12:55 -0700)]
Allow eMMC devices to consume some small portion of storage.

eMMC vendors typically allocate some small amount of storage for
metadata and bad block repair which makes the available GBs less than
the raw size.

Change allows a modest amount (250MB) for the vendor below the minimum
hwqual of 16GB.

Additionally it details (does not implement) a future method using CSD
and EXT_CSD fields that may eventually make it possible to calculate
the raw bits although that does not appear to be the case for existing
eMMC devices polled.

BUG=chrome-os-partner:11308
TEST=run test on lumpy & spring and it passes

Change-Id: I7e6ba8d4d63fcd39d448c02ca73cda3001b68976
Reviewed-on: https://gerrit.chromium.org/gerrit/66413
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>

13 months ago[autotest] Count the number of times we update an autofiled bug. 30/66430/8
J. Richard Barnette [Tue, 20 Aug 2013 21:15:13 +0000 (14:15 -0700)]
[autotest] Count the number of times we update an autofiled bug.

This adds a new label to autofiled bugs to indicate a count of the
number of times autofiling updates a bug.  Each time a bug is
updated, the count is incremented.  New bugs start with a count
of 1.  Pre-existing bugs without a count will be assumed to have a
count of 1 prior to increment.

BUG=chromium:265464
TEST=unit tests, plus observe bug updates to autotest-bug-filing-test from the 'dummy' suite

Change-Id: I87d9d81420f720f488e1a1bfbdefec8990b452a3
Reviewed-on: https://gerrit.chromium.org/gerrit/66430
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Prashanth Balasubramanian <beeps@chromium.org>
Commit-Queue: Richard Barnette <jrbarnette@chromium.org>

13 months ago[autotest] Refactor SiteHost, AbstractSSHHost, SSHHost hierarchy 31/64331/10
Fang Deng [Fri, 2 Aug 2013 00:46:18 +0000 (17:46 -0700)]
[autotest] Refactor SiteHost, AbstractSSHHost, SSHHost hierarchy

This CL refactors the host classes inheriting hierarchy.
Previously, we have SiteHost as a parent class of AbstractSSHost.
This makes AbstractSSHHost/SSHHost chromeos-specific.
In the new hierarchy, SiteHost is made as a subclass of AbstractSSHHost.
This allows other types of host, such as ServoHost,
easily inherits from AbstractSSHHost/SSHHost, without unnecessarily
inheriting chromeos specific methods from SiteHost.

make_ssh_command is put inside host classes, which allows
each subclass of AbstractSSHHost to easily
override it with its own settings.

SiteHost are mixed with SSHHost or ParamikoHost in create_host.

For a thorough discussion about the refactoring design,
take a look at the design doc mentioned in crbug.com/265998.

CQ-DEPEND=CL:66136
BUG=chromium:265998
TEST=dummy and bvt suite pass locally; repair/verify jobs pass; vmtest
in a tryjob pass.
DEPLOY=scheduler

Change-Id: I03a63a3db2f3cb0eaa50884c53fe3d3f8bb779ed
Reviewed-on: https://gerrit.chromium.org/gerrit/64331
Reviewed-by: Fang Deng <fdeng@chromium.org>
Tested-by: Fang Deng <fdeng@chromium.org>
Commit-Queue: Fang Deng <fdeng@chromium.org>

13 months agoRPM Servers: Fix stuck threads issue. 08/66608/6
Simran Basi [Thu, 22 Aug 2013 00:42:00 +0000 (17:42 -0700)]
RPM Servers: Fix stuck threads issue.

This cl fixes the issue of the rpm servers running out file descriptors
due to stuck sockets. Debugged it as the following problem:

* RPM dispatcher kicks off a thread for each rpm_controller.
* Thread for rpm_controller calls set_power, something bad happens
  exception thrown. Thread is stuck.
* RPM dispatcher gets new request for that RPM and sends it to that
  stuck thread.
* Client times out, job logs error and continues.
* The drone -> frontend connection becomes close_wait and is stuck.
  Client closed it but the frontend thread is still waiting to hear
  from the dispatcher. This uses up a file descriptor.
* Frontend -> dispatcher connection is stuck as established.
  Another file descriptor used up.
* Over time (roughly a few weeks to a month) we run out of file
  descriptors and can no longer open new sockets causing all calls to
  the infrastructure to fail until it is manually restarted.

A side effect of this is now all calls to this RPM via our infrastructure
will fail, sadly this occurs silently and can only be seen in the logs
of the autoserv jobs who timed out when calling the rpm infrastructure.

In order to address this, I added a catch of all exceptions that occur
when trying to change power state. The exception will be caught and
emailed out to the team.

Also updated the error emails to go to chromeos-lab-errors@google.com

BUG=chromium:243567
TEST=Put in set_power_state an explict raise exception which recreated
the conditions we see on the live server. Then applied my fix and
verified we don't get stuck/use up file descriptors as before.

Change-Id: I69bf68564fcfbda6c387faa74202c7c4b9bbcdef
Reviewed-on: https://gerrit.chromium.org/gerrit/66608
Reviewed-by: Scott Zawalski <scottz@chromium.org>
Commit-Queue: Simran Basi <sbasi@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Tested-by: Simran Basi <sbasi@chromium.org>
13 months agoRefactoring config settings for devices in FAFT tests. 06/66006/6
Yusuf Mohsinally [Thu, 15 Aug 2013 23:09:51 +0000 (16:09 -0700)]
Refactoring config settings for devices in FAFT tests.

Created a new config system for faft tests which allow for a default file of
settings and override file for each board that requires it.

The default and override files contain a class called 'Values', in which
the config attributes are stored. The class allows for inheritence of config
values from to better organize related board settings.

The new config system provides for one 'Config' class which is the main
interface to settings for all tests. It does a cascading search, for the
requested attribute, first checking a platform specific overrides, and then
through the defaults.

Modified FAFTSequence to contain one attribute 'faft_config' which replaces
self.client_attr and self.delay which it made available to tests.

BUG=None
TEST=Manual runs of various tests at desk on link device

Change-Id: I06da7be07364d5d99bdf6b204d628ad849f8d617
Reviewed-on: https://gerrit.chromium.org/gerrit/66006
Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
Tested-by: Yusuf Mohsinally <mohsinally@chromium.org>
Tested-by: Yusuf Mohsinally <mohsinally@google.com>
13 months agoPoll the permissions check to avoid racing chmod 78/66678/2
Jim Hebert [Thu, 22 Aug 2013 17:46:31 +0000 (10:46 -0700)]
Poll the permissions check to avoid racing chmod

BUG=chromium:265725
TEST=security_ProfilePermissions passes on stout
TEST=security_ProfilePermissions fails if I tweak the file permissions
TEST=security_ProfilePermissions polls, then passes if I tweak them back

Change-Id: Ie8457f6fa8dc3f403061bdad3ccdd56abb0e2972
Reviewed-on: https://gerrit.chromium.org/gerrit/66678
Commit-Queue: Jim Hebert <jimhebert@chromium.org>
Tested-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
13 months agoWhitelist 1 additional python symlink on test images 75/66675/2
Jim Hebert [Thu, 22 Aug 2013 17:27:23 +0000 (10:27 -0700)]
Whitelist 1 additional python symlink on test images

BUG=none
TEST=the test passes on ToT/stout

Change-Id: If0caaeaf3456b4c298e91f601630654a245f112c
Reviewed-on: https://gerrit.chromium.org/gerrit/66675
Commit-Queue: Jim Hebert <jimhebert@chromium.org>
Tested-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
13 months agoAdding the missing admin_url for trendnet tew-692gr 37/66537/2
bmahadev [Wed, 21 Aug 2013 19:33:34 +0000 (12:33 -0700)]
Adding the missing admin_url for trendnet tew-692gr

BUG=None
TEST=ChaosPSK

Change-Id: I034129e5d682321dec0c1ff0688a4a5e8c2f7ffb
Reviewed-on: https://gerrit.chromium.org/gerrit/66537
Reviewed-by: Kris Rambish <krisr@chromium.org>
Commit-Queue: Bindu Mahadev <bmahadev@chromium.org>
Tested-by: Bindu Mahadev <bmahadev@chromium.org>
13 months agoFix Flash sanity test 17/66517/3
Rohit Makasana [Wed, 21 Aug 2013 14:02:00 +0000 (19:32 +0530)]
Fix Flash sanity test

BUG=chromium:276017
TEST=ran it with -i 25

Change-Id: Ida32b90bc293f326ef6879841e8a935bcaccf800
Reviewed-on: https://gerrit.chromium.org/gerrit/66517
Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
Tested-by: Rohit Makasana <rohitbm@chromium.org>
Commit-Queue: Rohit Makasana <rohitbm@chromium.org>

13 months agoDon't use telemetry's util.WaitFor. 96/66596/2
Mark Koudritsky [Thu, 22 Aug 2013 00:14:00 +0000 (20:14 -0400)]
Don't use telemetry's util.WaitFor.

Using utils.poll_for_condition() instead.

BUG=chromium:276223
TEST=./run_remote_tests.sh --remote=mylumpy  power_Consumption

Change-Id: I8135af36d5d8e76b8643a1f418bbbe3af86ce0fe
Reviewed-on: https://gerrit.chromium.org/gerrit/66596
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Mark Koudritsky <kamrik@chromium.org>
Tested-by: Mark Koudritsky <kamrik@chromium.org>
13 months agonetwork_ui: Use utils.poll_for_condition instead of util.WaitFor. 20/66420/3
Arman Uguray [Tue, 20 Aug 2013 20:49:23 +0000 (13:49 -0700)]
network_ui: Use utils.poll_for_condition instead of util.WaitFor.

Use utils from autotest_lib instead of util from telemetry in
tests.

BUG=chromium:276222
TEST=network_ChromeCellularNetworkPresent

Change-Id: I4f4a26057781bca058ab36b364ab6add723349c7
Reviewed-on: https://gerrit.chromium.org/gerrit/66420
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
13 months agofirmware_TouchMTB: refine the description for first-time user 54/65554/2
Chung-yih Wang [Mon, 12 Aug 2013 06:55:26 +0000 (14:55 +0800)]
firmware_TouchMTB: refine the description for first-time user

BUG=chromium:221864
TEST=none

Change-Id: Ic5d4e75034b95bcfa5aea25921a1c70b6d94055e
Reviewed-on: https://gerrit.chromium.org/gerrit/65554
Reviewed-by: Joseph Shyh-In Hwang <josephsih@chromium.org>
Tested-by: Chung-yih Wang <cywang@chromium.org>
Commit-Queue: Chung-yih Wang <cywang@chromium.org>

13 months agoAdd youtube page and eme tests to test scheduler 39/66539/3
Rohit Makasana [Wed, 21 Aug 2013 19:38:49 +0000 (01:08 +0530)]
Add youtube page and eme tests to test scheduler

BUG=chromium:277020
TEST=Ran suite_enumerator.py -a . youtube_page and youtube_mse_eme,
./site_utils/suite_scheduler/suite_scheduler.py --sanity

Change-Id: I72f7ebccee9141680275633b8fb1b7db16a95d05
Reviewed-on: https://gerrit.chromium.org/gerrit/66539
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Rohit Makasana <rohitbm@chromium.org>
Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
Tested-by: Rohit Makasana <rohitbm@chromium.org>
13 months agoRemove unused security_Tpmd 67/66567/2
Jim Hebert [Wed, 21 Aug 2013 22:24:25 +0000 (15:24 -0700)]
Remove unused security_Tpmd

BUG=chromium:264794
TEST=n/a

Change-Id: Id345488af192a9ac7dbd125897c22549469b9065
Reviewed-on: https://gerrit.chromium.org/gerrit/66567
Commit-Queue: Jim Hebert <jimhebert@chromium.org>
Tested-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>
13 months agoAdd Feedback to expected extensions 39/66439/2
Jim Hebert [Tue, 20 Aug 2013 22:05:54 +0000 (15:05 -0700)]
Add Feedback to expected extensions

BUG=none
TEST=security_BundledExtensions passes on ToT/stout

Change-Id: I549712f4ca0a87130ce750027640698c2a299ee5
Reviewed-on: https://gerrit.chromium.org/gerrit/66439
Tested-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Jim Hebert <jimhebert@chromium.org>

13 months ago[autotest] Pull a upstream fix about known hosts file failure. 36/66136/3
Fang Deng [Fri, 16 Aug 2013 22:19:25 +0000 (15:19 -0700)]
[autotest] Pull a upstream fix about known hosts file failure.

Need to be landed/pushed before cl 64331. Pull a upstream fix.

The host_file got by os.tmpfile() is not available for "ssh -o
UserKnownHostsFile " on ubuntu 11.10 and will have the error "Failed to
add the host to the list of known hosts (/dev/fd/11)", so the patch just
replace it with tempfile.mkstemp()

The original idea of not using '/dev/null' is that using it will
lead to too many messages like 'Warning: Permanently added
'locathost' (RSA) to the list of known hosts'.

This fix is needed when SiteHost is no longer be the parent class of
AbstractHost after 64331 is landed.
Code that creates SSHHost directly without mixing it with
SiteHost will hit this problem.

BUG=None
Test=Manually create a SSHHost (without SiteHost being a parent),
run a command via |run| on the host. Make sure it can ssh to the host
and won't hit the error. Also run dummy suite locally.

Change-Id: Id8d5c44f63a572ea482afeae074cd43cf2de9ec9
Reviewed-on: https://gerrit.chromium.org/gerrit/66136
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Fang Deng <fdeng@chromium.org>
Commit-Queue: Fang Deng <fdeng@chromium.org>

13 months ago[autotest]: Refactor bug filing. 98/65898/9
Keyar Hood [Fri, 9 Aug 2013 00:59:46 +0000 (17:59 -0700)]
[autotest]: Refactor bug filing.

This creates a new Bug class that TestFailure now derives from. This allows us
to file bugs for issues that are not test failures.

BUG=chromium:254256
TEST=Unit tests and ran the dummy suite and saw that the tests were deduped.

Change-Id: I104489e9627a64506fc9c206392f1297fa538c44
Reviewed-on: https://gerrit.chromium.org/gerrit/65898
Reviewed-by: Prashanth Balasubramanian <beeps@chromium.org>
Reviewed-by: Keyar Hood <keyar@chromium.org>
Tested-by: Keyar Hood <keyar@chromium.org>
Commit-Queue: Keyar Hood <keyar@chromium.org>

13 months agoConvert most graphics_ui_test to test.test. 33/66133/5
Ilja Friedel [Fri, 16 Aug 2013 06:35:41 +0000 (23:35 -0700)]
Convert most graphics_ui_test to test.test.

This gets rid of dependencies on Chrome and in particular pyauto. We introduce
graphics_utils.py to keep GPU state checking functionality.

BUG=chromium:271828
TEST=Ran all affected graphics_* tests.

Change-Id: Iee9971d292bd6405a92f0ee5d13d5c032f657998
Reviewed-on: https://gerrit.chromium.org/gerrit/66133
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
13 months ago[autotest]: Add --help to test health scripts. 41/66441/7
Keyar Hood [Tue, 20 Aug 2013 18:48:06 +0000 (11:48 -0700)]
[autotest]: Add --help to test health scripts.

Although these scripts have no interesting options, people will not be
suprised when they try to find out more and suddenly the script is bein ran.

BUG=chromium:276668
TEST=Manual testing.

Change-Id: I247c1e681a26314ffb74f1905575be4a1706deb8
Reviewed-on: https://gerrit.chromium.org/gerrit/66441
Reviewed-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
Commit-Queue: Keyar Hood <keyar@chromium.org>
Tested-by: Keyar Hood <keyar@chromium.org>
13 months ago[autotest] add a parent_job_id index to afe_jobs table 64/66464/2
Aviv Keshet [Wed, 21 Aug 2013 01:15:08 +0000 (18:15 -0700)]
[autotest] add a parent_job_id index to afe_jobs table

This CL adds a parent_job_id index to the afe_jobs table, which is
particularly important in light of the pending CL
I47dbc5f1a3348bdd5297ffbd2e26b82dc9d705f6.

BUG=chromium:276471
TEST=From the mysql query log, determined the underling SQL query being
used in get_jobs(parent_job_id=xxx, finished=True). Then did a
before/after comparison of the mysql EXPLAIN report.

mysql> explain extended SELECT DISTINCT id from `afe_jobs` WHERE
(`afe_jobs`.`parent_job_id` = 219  AND (id NOT IN (SELECT job_id FROM
afe_host_queue_entries WHERE not complete))) \G;
*************************** 1. row ***************************
           id: 1
  select_type: PRIMARY
        table: afe_jobs
         type: ALL
possible_keys: NULL
          key: NULL
      key_len: NULL
          ref: NULL
         rows: 232
     filtered: 100.00
        Extra: Using where
*************************** 2. row ***************************
           id: 2
  select_type: DEPENDENT SUBQUERY
        table: afe_host_queue_entries
         type: index_subquery
possible_keys: host_queue_entries_job_id_and_host_id
          key: host_queue_entries_job_id_and_host_id
      key_len: 5
          ref: func
         rows: 2
     filtered: 100.00
        Extra: Using where
2 rows in set, 1 warning (0.00 sec)

after:
*************************** 1. row ***************************
           id: 1
  select_type: PRIMARY
        table: afe_jobs
         type: ref
possible_keys: parent_job_id_index
          key: parent_job_id_index
      key_len: 5
          ref: const
         rows: 2
     filtered: 100.00
        Extra: Using where; Using index
*************************** 2. row ***************************
           id: 2
  select_type: DEPENDENT SUBQUERY
        table: afe_host_queue_entries
         type: index_subquery
possible_keys: host_queue_entries_job_id_and_host_id
          key: host_queue_entries_job_id_and_host_id
      key_len: 5
          ref: func
         rows: 2
     filtered: 100.00
        Extra: Using where

DEPLOY=migrate

Change-Id: I4b407fd0cc1a769ad0d4829bdffed87213e2da04
Reviewed-on: https://gerrit.chromium.org/gerrit/66464
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Alex Miller <milleral@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>

13 months ago[autotest] use parent_id to reduce number of db queries in suite.wait 43/66443/6
Aviv Keshet [Tue, 20 Aug 2013 21:37:13 +0000 (14:37 -0700)]
[autotest] use parent_id to reduce number of db queries in suite.wait

This CL reduces the number of queries required when waiting for a
suite's job results, by replacing (when suite_job_id is known) a loop
over afe.get_jobs(id=job.id, finished=True) for all remaining jobs in a
suite with a single call to
afe.get_jobs(parent_job_id=parent_job_id, finished=True)

I have not yet done a performance benchmark with this change, nor
examined whether the underlying SQL queries could be significantly
optimized with an intelligently chosen new database index.

CQ-DEPEND=CL:I4b407fd0cc1a769ad0d4829bdffed87213e2da04
BUG=chromium:276471
TEST=Used run_suite locally, verified that suite waiting on its child
jobs and that results were reported correctly. Added a unit test, which
passes.

Change-Id: I47dbc5f1a3348bdd5297ffbd2e26b82dc9d705f6
Reviewed-on: https://gerrit.chromium.org/gerrit/66443
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>

13 months agoAuto detect labels graphics:gl and graphics:gles. 22/66022/4
Ilja Friedel [Fri, 16 Aug 2013 01:45:27 +0000 (18:45 -0700)]
Auto detect labels graphics:gl and graphics:gles.

TEST=Ran on daisy and link and got the right label back.
BUG=chromium:271917

Change-Id: I37e19b9d371d219b88e841570ed0e0145902e3ee
Reviewed-on: https://gerrit.chromium.org/gerrit/66022
Reviewed-by: Stuart Abercrombie <sabercrombie@chromium.org>
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
13 months ago[autotest] raise DevServerException in wait_for_artifacts_staged. 40/66240/4
Dan Shi [Mon, 19 Aug 2013 21:47:13 +0000 (14:47 -0700)]
[autotest] raise DevServerException in wait_for_artifacts_staged.

When devserver responds with HTTPError, the rpc call is failed with exception.
The exception should be raised to prevent caller waiting indefinitely. When the
caller runs into connection problem, URLError that's not HTTPError may be
thrown. In such case, caller should retry the devserver call.

This CL must be work together with the CL in devserver:
https://gerrit.chromium.org/gerrit/66239

BUG=chromium:273981
DEPLOY=must repo sync devserver first (CL: 66239)
TEST=test with three different cases:
1. run_suite for a legit build, e.g.,
./run_suite.py --build=lumpy-release/R30-4501.0.0 --board=lumpy --suite=dummy
wait for artifactions to download, suite job just be created successfully.
2. run_suite for a legit build, e.g.,
./run_suite.py --build=lumpy-release/R30-4501.0.0 --board=lumpy --suite=dummy
simulate connection problem by killing devserver right after downloading starts.
Restart devserver after 30 seconds or so. Artifacts should be successfully
downloaded and suite job should be created.
3. run_suite for a non-existing build, e.g.:
./run_suite.py --build=lumpy-release/R30-no_such_build --board=lumpy --suite=dummy
run_suite command should fail with following error in 5-10 seconds:
GSUtilError: Failed to list payloads. GSUTIL cmd gsutil ls gs://chromeos-image-archive/lumpy-release/R30-no_such_build/* failed with return code 1:
CommandException: One or more URIs matched no objects.

Change-Id: I7bcefce648d77cbd72b067a45f078df61d3e7082
Reviewed-on: https://gerrit.chromium.org/gerrit/66240
Reviewed-by: Dan Shi <dshi@chromium.org>
Tested-by: Dan Shi <dshi@chromium.org>
Commit-Queue: Dan Shi <dshi@chromium.org>

13 months ago[autotest] add testing key to the ssh-agent during a test_that local run 32/66232/6
Aviv Keshet [Mon, 19 Aug 2013 21:19:26 +0000 (14:19 -0700)]
[autotest] add testing key to the ssh-agent during a test_that local run

CQ-DEPEND=CL:If48fb7e9e0aa1e9744a172db42f1a03d9b22aa56
BUG=chromium:242987, chromium:274047
TEST=test_that can now run tests against a DUT from a chroot that does
not already have a ssh-agent set up. Unit tests pass.

Change-Id: I83fe442cdd5a3ef3594cefa2a818d56c576d5969
Reviewed-on: https://gerrit.chromium.org/gerrit/66232
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>

13 months agochaos: allow packet_capture host selection 03/66203/5
Jason Abele [Fri, 16 Aug 2013 01:03:07 +0000 (18:03 -0700)]
chaos: allow packet_capture host selection

Push the capture_host argument through to the control file.

BUG=None
TEST=run_remote_tests.sh network_WiFiChaosPSK/control.debug

Change-Id: I8ef954a012dd73df3c16d3b72bbf3c365ff0eb8f
Signed-off-by: Jason Abele <jabele@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/66203

13 months agonetwork_ui: Add test for Cellular.ServingOperator property. 43/66143/2
Arman Uguray [Sat, 17 Aug 2013 00:02:55 +0000 (17:02 -0700)]
network_ui: Add test for Cellular.ServingOperator property.

network_ChromeCellularNetworkProperties now tests for
Cellular.ServingOperator in both the 3GPP and CDMA cases.

BUG=chromium:264107
TEST=network_ChromeCellularNetworkProperties

Change-Id: Ie1994a5b12162483b8795b136adbec3970082991
Reviewed-on: https://gerrit.chromium.org/gerrit/66143
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>

13 months agoUpdate security_BundledExtensions for connectivity diagnostics 90/66390/2
Jim Hebert [Tue, 20 Aug 2013 17:42:26 +0000 (10:42 -0700)]
Update security_BundledExtensions for connectivity diagnostics

BUG=none
TEST=security_BundledExtensions no longer complains about it

Change-Id: I705e7225982982a016783b9d29a6b62ebda9a815
Reviewed-on: https://gerrit.chromium.org/gerrit/66390
Commit-Queue: Jim Hebert <jimhebert@chromium.org>
Tested-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
13 months ago[autotest] include test name in test_that results directory 90/66290/2
Aviv Keshet [Tue, 20 Aug 2013 01:09:27 +0000 (18:09 -0700)]
[autotest] include test name in test_that results directory

Before this CL, if you ran a test suite with test_that, your result
directories would just be named results-0, results-1, etc. After this
CL, the results directories will include the name of the test, ie
results-01-logging_CrashSender.

TEST=Ran locally to verify behavior. Also, unit tests pass.
BUG=None

Change-Id: Id270aacf231aa0a9585eeecc952598f540305167
Reviewed-on: https://gerrit.chromium.org/gerrit/66290
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>

13 months agoRemove the auto-imager of the chaos lab. 53/66253/2
Kris Rambish [Mon, 19 Aug 2013 22:33:23 +0000 (15:33 -0700)]
Remove the auto-imager of the chaos lab.

TEST=None
BUG=None

Change-Id: I65c2d75b86228fb2d28314283f427b7f496ee7ea
Reviewed-on: https://gerrit.chromium.org/gerrit/66253
Tested-by: Kris Rambish <krisr@chromium.org>
Reviewed-by: Prashanth Balasubramanian <beeps@chromium.org>
Commit-Queue: Kris Rambish <krisr@chromium.org>

13 months agoAutotest TKO parser now sends measured perf data to chrome's performance dashboard. 72/64672/9
Dennis Jeffrey [Mon, 5 Aug 2013 18:01:27 +0000 (11:01 -0700)]
Autotest TKO parser now sends measured perf data to chrome's performance dashboard.

Any performance autotests that invoke self.output_perf_value() will now
have those outputted results uploaded to chrome's performance dashboard,
as part of the autotest TKO parsing stage.  For now, a message is logged
to the .parse.log output file indicating success or failure of the
upload.  In the future, failed uploads will need to be retried, and
better insight will need to be provided as to how well the perf_uploader
module is performing.

BUG=chromium:258232
TEST=Invoked platform_GesturesRegressionTest using a local instance of
the autotest frontend, and a local instance of Chrome team's perf
dashboard.  Then verified that the perf data outputted by the test appeared
on the perf dashboard.  Also verified that perf_uploader_unittest.py passes.

Change-Id: Id685deda129056465350a5be8effc9aa97fa9bb4
Reviewed-on: https://gerrit.chromium.org/gerrit/64672
Commit-Queue: Dennis Jeffrey <dennisjeffrey@chromium.org>
Reviewed-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
Tested-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
13 months agohardware_LightSensor: Be more tolerant of pathnames 98/66398/2
Olof Johansson [Tue, 20 Aug 2013 18:22:47 +0000 (11:22 -0700)]
hardware_LightSensor: Be more tolerant of pathnames

power manager will search for any subdirectory under /sys/bus/iio/devices/
for the ALS, while the autotest was more restrictive. Enable similar
search here to not fail when the device changes numbering.

(On snow, it ended up changing from device0 to device1 since there's an
ADC that got assigned device0).

Change-Id: I231d46149ccc095fad949a75cef8166103b81c2b
Signed-off-by: Olof Johansson <olofj@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/66398
Reviewed-by: Bryan Freed <bfreed@chromium.org>
13 months ago[autotest] improve logging in autoserv main() 05/66405/3
Aviv Keshet [Tue, 20 Aug 2013 19:11:12 +0000 (12:11 -0700)]
[autotest] improve logging in autoserv main()

Prior to this CL, if autoserv's call to run_autoserv threw an exception,
the stacktrace was printed to autoserv's stdout but not otherwise logged
anywhere. This CL causes these exceptions to be logged appropriately.

A debug level logging message giving autoserv's arguments has also been
added.

BUG=None
TEST=Ran autoserv directly; stracktrace shown in stdout. Started a suite
in such a way as to throw an exception from run_autoserv; stacktrace
visible in autoserv.DEBUG log file.

Change-Id: Ic2896b78185e7f96e8b4fec421858fe5aa503245
Reviewed-on: https://gerrit.chromium.org/gerrit/66405
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
13 months agoAdding Trendnet 692GR AP configurator and disabling Netgear N3700 95/66295/4
bmahadev [Tue, 20 Aug 2013 01:44:08 +0000 (18:44 -0700)]
Adding Trendnet 692GR AP configurator and disabling Netgear N3700

BUG=chromium:265656, chromium:273301
TEST=Chaos PSK and Open

Change-Id: I5c8bcf5b67e4a89772ef3dae83c7afae9e261989
Reviewed-on: https://gerrit.chromium.org/gerrit/66295
Tested-by: Bindu Mahadev <bmahadev@chromium.org>
Reviewed-by: Kris Rambish <krisr@chromium.org>
Commit-Queue: Bindu Mahadev <bmahadev@chromium.org>

13 months agoautotest: allow a non-lockable packet_capture host 94/65894/4
Jason Abele [Wed, 14 Aug 2013 22:25:21 +0000 (15:25 -0700)]
autotest: allow a non-lockable packet_capture host

BUG=None
TEST=python
import common
from autotest_lib.server import packet_capture
with packet_capture.PacketCaptureManager() as capturer:
    capturer.allocate_packet_capture_machine(hostname='my_capture_host')
capturer.start_capture(freq=2437)
capturer.stop_capture()

Change-Id: Id3d950a5a2796cf9ae247863794ee0c1cf946cc4
Signed-off-by: Jason Abele <jabele@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/65894
Reviewed-by: Kris Rambish <krisr@chromium.org>
13 months agologging_AsanCrashTelemetry. 21/66121/6
Achuith Bhandarkar [Thu, 1 Aug 2013 19:35:53 +0000 (12:35 -0700)]
logging_AsanCrashTelemetry.

BUG=chromium:266476

TEST=trybot run

Change-Id: I09d5d5e8b2cc454262c5a4b93dd09374f64f5e5a
Reviewed-on: https://gerrit.chromium.org/gerrit/66121
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Tested-by: Achuith Bhandarkar <achuith@chromium.org>
13 months agoBluetooth: implement bluetooth_Sanity_Discoverable 74/65074/3
Scott James Remnant [Thu, 8 Aug 2013 00:53:14 +0000 (17:53 -0700)]
Bluetooth: implement bluetooth_Sanity_Discoverable

This test is the first example of a Bluetooth test with a separate
tester device (a stumpy with the testbed-ap profile is the intent).
It can be run two ways:

 1. as bluetooth_Sanity_Discoverable - in which case the Tester will
    be used to perform a device discovery and verify that the DUT
    was detected in the process.

 2. as bluetooth_Sanity_Discoverable.manual - in which case only the
    DUT is used, and instructions presented on screen for use with
    a third-party Tester (such as the Bluetooth PTS).

BUG=chromium:256771
TEST=run_remote_tests

Change-Id: I851a05acff3ca3edba32bb2f0cd043d8042d162d
Reviewed-on: https://gerrit.chromium.org/gerrit/65074
Commit-Queue: Scott James Remnant <keybuk@chromium.org>
Reviewed-by: Scott James Remnant <keybuk@chromium.org>
Tested-by: Scott James Remnant <keybuk@chromium.org>
13 months agoAdd new files logic to devserver and clean up AU E2E test to use it. 32/65732/8
Chris Sosa [Tue, 13 Aug 2013 17:00:15 +0000 (10:00 -0700)]
Add new files logic to devserver and clean up AU E2E test to use it.

There's a couple nested things here:

1) Pipe files through the autotest-side of the devserver logic. I've gone ahead
and added 5 unittests to test this new workflow with various combos of
artifacts. The main thing here is the optional pass of archive_url + files to
the stage_artifacts methods. I've also added a convenience function to return
the url to any staged file on the devserver if you know the filename (which you
would if you are using files= API).

2) Use the new logic in AU E2E API and figure out the right URL's to pass to
stage artifacts from. This was a bit of refactoring to get right.
In order to allow me to serve any artifact I had to change a bit of of the
source version installation logic to allow me to update from any static url
(rather than one that must end in update.gz). This actually makes the
OmahaDevserver much more flexible and more Omaha-y.

BUG=chromium:267896
TEST=Unittests + tested with both an nmo + npo full run.

Change-Id: Ic490c7c0e7d76eb8c0416accefbe113b9c0bba32
Reviewed-on: https://gerrit.chromium.org/gerrit/65732
Reviewed-by: Chris Sosa <sosa@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>
Commit-Queue: Chris Sosa <sosa@chromium.org>

13 months ago[autotest] Force to collect /var/log if test is failed with device error. 13/66013/7
Dan Shi [Fri, 16 Aug 2013 00:13:27 +0000 (17:13 -0700)]
[autotest] Force to collect /var/log if test is failed with device error.

When test running in DUT is aborted and does not get a chance to run post test
hooks, diff of /var/log can not be copied to resuts folder and autoserv will
not be able to collect any log from the DUT.

This CL saves the device error failure flag to job.failed_with_device_error.
Autoserv uses this flag to determine whether to collect crash info (through
server/control_segments/crashinfo), which will collect all files in /var/log.

BUG=chromium:271703
TEST=run autoserv in local setup. Manually reboot DUT during the middle of a
test, then confirm the results collected has content in crashinfo.[DUT name].

Change-Id: I1a3757b8933fe60deea75728e867033eeb86c7cd
Reviewed-on: https://gerrit.chromium.org/gerrit/66013
Commit-Queue: Dan Shi <dshi@chromium.org>
Reviewed-by: Dan Shi <dshi@chromium.org>
Tested-by: Dan Shi <dshi@chromium.org>
13 months agoautotest: Enable automatic bug filing for network3g_pseudomodem. 74/65874/2
Arman Uguray [Wed, 14 Aug 2013 20:14:05 +0000 (13:14 -0700)]
autotest: Enable automatic bug filing for network3g_pseudomodem.

BUG=none
TEST=none

Change-Id: I1925d82fa626272934866edd7e8b429c4f142b0d
Reviewed-on: https://gerrit.chromium.org/gerrit/65874
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>

13 months agopseudomodem: Add support for 'VendorPcoInfo'. 52/66052/4
Arman Uguray [Fri, 16 Aug 2013 05:17:03 +0000 (22:17 -0700)]
pseudomodem: Add support for 'VendorPcoInfo'.

Added support for reading and debugging the Modem3gpp VendorPcoInfo property.

BUG=chromium:273847
TEST=1. stop modemmanager; pseudomodem.py -f 3GPP -i
     2. Use "set pco" to set the pco value.
     3. The org.freedesktop.ModemManager1.Modem.Modem3gpp.VendorPcoInfo
        property should update to the value set by "set pco". Check
        using DBus-Python.

Change-Id: I9c52b4165fd909f81c4cfc71c37e9778c61b741d
Reviewed-on: https://gerrit.chromium.org/gerrit/66052
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Arman Uguray <armansito@chromium.org>
Commit-Queue: Arman Uguray <armansito@chromium.org>

13 months agoAdd performance benchmark for compressed swap 87/63787/4
Stephen Barber [Tue, 30 Jul 2013 22:14:52 +0000 (15:14 -0700)]
Add performance benchmark for compressed swap

Adds a platform_CompressedSwapPerf autotest that provides performance
stats for compressed swap (time to service fault, jank estimates, etc)

BUG=chromium:220656
TEST=run_remote_tests.sh platform_CompressedSwapPerf/control$

Change-Id: I891236829575c0f737c2214258f0b10395fbe3e3
Reviewed-on: https://gerrit.chromium.org/gerrit/63787
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
Commit-Queue: Stephen Barber <smbarber@chromium.org>
Tested-by: Stephen Barber <smbarber@chromium.org>
13 months agoAdd chromeos-devserver1 back into our dev_server list. 71/66071/2
Scott Zawalski [Fri, 16 Aug 2013 13:21:02 +0000 (09:21 -0400)]
Add chromeos-devserver1 back into our dev_server list.

TEST=ran telemetry and dummy suite on chromeos-autotest.cbf
BUG=None

Change-Id: Ib401d263130809a271dbfbcf54a04bec1349130d
Reviewed-on: https://gerrit.chromium.org/gerrit/66071
Tested-by: Scott Zawalski <scottz@chromium.org>
Reviewed-by: Fang Deng <fdeng@chromium.org>
Commit-Queue: Scott Zawalski <scottz@chromium.org>
Reviewed-by: Scott Zawalski <scottz@chromium.org>
13 months ago[autotest] server-side test dirs do not need to be writable 03/66003/3
Aviv Keshet [Thu, 15 Aug 2013 23:09:03 +0000 (16:09 -0700)]
[autotest] server-side test dirs do not need to be writable

This CL causes autoserv to no longer assert that a server side tests's
test directory is writable (since at no point does autoserv actually
need to write to it). Removing this assertion allows test_that to run
VMTests on the builders (run_remote_tests.sh, which previously ran those
tests, has the obscure side-effect of chmodding the server side test
directories).

BUG=chromium:274014
TEST=This patch allowed VMTest to get passed the directory-writable
assertion failure referenced in the bug.

Change-Id: I1b3aa0460f56a13452a22807a22b12adfb86aaaa
Reviewed-on: https://gerrit.chromium.org/gerrit/66003
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Alex Miller <milleral@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>

13 months agoMove security_ProfilePermissions to security suite 22/66122/2
Jim Hebert [Fri, 16 Aug 2013 19:57:36 +0000 (12:57 -0700)]
Move security_ProfilePermissions to security suite

BUG=chromium:265725
TEST=./suite_enumerator.py security | grep ProfilePer

Change-Id: I01c5826b94c39b6183fda0f78d57290143745021
Reviewed-on: https://gerrit.chromium.org/gerrit/66122
Tested-by: Jim Hebert <jimhebert@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Jim Hebert <jimhebert@chromium.org>

13 months ago[autotest] Remove verbose drone logging. 92/66092/2
Alex Miller [Fri, 16 Aug 2013 16:44:44 +0000 (09:44 -0700)]
[autotest] Remove verbose drone logging.

There's now logging that triggers on the exact condition of the bug
we're looking for, so the overly verbose logging in place can be
removed.  Scheduler logs were getting pretty large.

BUG=chromium:262005
DEPLOY=scheduler
TEST=None

Change-Id: Ic43631eac259926f613d9debaffa1882dfb08db1
Reviewed-on: https://gerrit.chromium.org/gerrit/66092
Commit-Queue: Alex Miller <milleral@chromium.org>
Tested-by: Alex Miller <milleral@chromium.org>
Reviewed-by: Dan Shi <dshi@chromium.org>
13 months agoUpdate desktopui_Respawn to handle AutoservPidAlreadyDeadError 38/65838/4
Chris Masone [Wed, 14 Aug 2013 15:24:19 +0000 (08:24 -0700)]
Update desktopui_Respawn to handle AutoservPidAlreadyDeadError

nuke_process_by_name() will now raise AutoservPidAlreadyDeadError
if it cannot find a process by the name the caller provided.
This allows the caller to gracefully handle potential raciness when
using this method in a loop. The code here in desktopui_Respawn was
not updated to tolerate this new behavior.

BUG=chromium:273118
TEST=run the test

Change-Id: If97880b35c1e0034721cfe62221d3ec7e4a64666
Reviewed-on: https://gerrit.chromium.org/gerrit/65838
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Commit-Queue: Chris Masone <cmasone@chromium.org>

13 months agodesktopui_AudioFeedback: make test more stable 48/65948/3
Hsin-Yu Chao [Thu, 15 Aug 2013 08:40:33 +0000 (16:40 +0800)]
desktopui_AudioFeedback: make test more stable

Use browser.tabs.New() or sometimes there is no tabs[0] in present.
Call tabs.Activate() and then sleep(1) for tab to fully load test
page.

BUG=chromium:270641
TEST=Manual ./run_remote_test --remote=<ip> desktopui_AudioFeedback

Change-Id: I685b33c17e13eb8f650dae9de0a755277686c1c5
Reviewed-on: https://gerrit.chromium.org/gerrit/65948
Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
13 months ago[autotest] improve test_that's logging 93/65893/9
Aviv Keshet [Wed, 14 Aug 2013 21:11:59 +0000 (14:11 -0700)]
[autotest] improve test_that's logging

This CL accomplishes a few things:
1) Makes the output format of logging messages in test_that more in line
with the rest of autotest.

2) Makes test_that drop log files (test_that.DEBUG, .ERROR, .INFO, and
.WARNING) into the debug/ subdirectory of its logging directory.

3) Adds a --debug flag which allows the user to optionally see DEBUG
level messages in stdout.

4) In order to make the logs more readable, test_that is now calling
autoserv with its --no-console-prefix flag.

BUG=chromium:273256
TEST=Unit tests pass

Change-Id: I8b2c4594f22de40ddd25a2ba84214f65021f5c29
Reviewed-on: https://gerrit.chromium.org/gerrit/65893
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
13 months ago[autotest] demote import-time logging messages to DEBUG level 78/65978/2
Aviv Keshet [Thu, 15 Aug 2013 17:46:39 +0000 (10:46 -0700)]
[autotest] demote import-time logging messages to DEBUG level

Import-time logging messages get emitted before any of the normal
logging handlers can get set up. When a script in the chroot, like
test_that, imports some of these modules (or modules that import them)
this causes confusing-to-end-user logging messages to appear in the
script output.

BUG=None
TEST=None

Change-Id: I1260b87cafbde7390dae5553cee84f899b58c03c
Reviewed-on: https://gerrit.chromium.org/gerrit/65978
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Dan Shi <dshi@chromium.org>
Reviewed-by: Prashanth Balasubramanian <beeps@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>

13 months ago[autotest] do not run test_that as root 90/65790/7
Aviv Keshet [Wed, 14 Aug 2013 00:12:36 +0000 (17:12 -0700)]
[autotest] do not run test_that as root

CQ-DEPEND=CL:Iedf70c3bc891f639e396c2a12dfb275923d8f8e9
BUG=chromium:272575
TEST=See CQ-DEPENDED CL; Unit tests pass.

Change-Id: If5e4293bfc88255ee3eff278763634006d22a8d6
Reviewed-on: https://gerrit.chromium.org/gerrit/65790
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Commit-Queue: Aviv Keshet <akeshet@chromium.org>

13 months agoAUE2E: get rid of deprecated option that's been gone for over a month. 11/66111/5
Chris Sosa [Fri, 16 Aug 2013 18:37:35 +0000 (11:37 -0700)]
AUE2E: get rid of deprecated option that's been gone for over a month.

BUG=chromium:274000
TEST=Pylint / visual

Change-Id: I4a67057d139a9f5c436b89fb2a3a2382d4296376
Reviewed-on: https://gerrit.chromium.org/gerrit/66111
Reviewed-by: Chris Sosa <sosa@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>
13 months agoEC functional test: Exit if ectool is not installed. 01/66001/2
Todd Broch [Thu, 15 Aug 2013 22:44:51 +0000 (15:44 -0700)]
EC functional test: Exit if ectool is not installed.

Legacy systems don't have ectool support so exit more gracefully if
thats the case.  Additionally print out 'mosys ec info' for additional
platform EC info.

Bug=none
TEST=run hardware_EC on daisy_spring & lumpy successfully.

Change-Id: I4efd3fc34c57bf376dbacaa355097e3ff13f452a
Reviewed-on: https://gerrit.chromium.org/gerrit/66001
Reviewed-by: Puneet Kumar <puneetster@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>

13 months agoAutotest: Clean up unneeded test-health storage. 58/65658/3
Keyar Hood [Mon, 12 Aug 2013 21:32:39 +0000 (14:32 -0700)]
Autotest: Clean up unneeded test-health storage.

The complete_failures.py script was still using file storage but was not doing
anything with it. This patch removes this storage as there is no longer plans to
store this information.

BUG=None
TEST=Unit tests.

Change-Id: I5fe092d6aebe133676c95d8fc5681881f9d1c894
Reviewed-on: https://gerrit.chromium.org/gerrit/65658
Reviewed-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
Tested-by: Keyar Hood <keyar@chromium.org>
Commit-Queue: Keyar Hood <keyar@chromium.org>

13 months agocellular: Fixed typo in labconfig.Configuration._get_dut() 03/65903/2
Thieu Le [Wed, 14 Aug 2013 23:13:09 +0000 (16:13 -0700)]
cellular: Fixed typo in labconfig.Configuration._get_dut()

BUG=chromium:273267
TEST=Unit test, cellular_Smoke

Change-Id: Ibf1b55b272c3ec5658e70ecb5403fff2f96e6f2a
Reviewed-on: https://gerrit.chromium.org/gerrit/65903
Reviewed-by: Arman Uguray <armansito@chromium.org>
Reviewed-by: Thieu Le <thieule@chromium.org>
Tested-by: Thieu Le <thieule@chromium.org>
Commit-Queue: Thieu Le <thieule@chromium.org>

13 months agoGeneralized semiauto test framework. 72/64872/4
Katherine Threlkeld [Wed, 7 Aug 2013 02:04:17 +0000 (19:04 -0700)]
Generalized semiauto test framework.

Seperating the interactive portion of the Bluetooth semiauto tests so
that it can be used elsewhere in the future.

BUG=None
TEST=ran it

Change-Id: I68896beb3ea5137bb655cf53d96e5f82ab52fc25
Reviewed-on: https://gerrit.chromium.org/gerrit/64872
Reviewed-by: Kris Rambish <krisr@chromium.org>
Tested-by: Katherine Threlkeld <kathrelkeld@chromium.org>
Commit-Queue: Katherine Threlkeld <kathrelkeld@chromium.org>

13 months agoffmpeg_tests removal. 08/65908/4
Ilja Friedel [Thu, 15 Aug 2013 00:04:10 +0000 (17:04 -0700)]
ffmpeg_tests removal.

Chromium is removing this test binary. Hence CrOS is removing everything that
depends on it.

BUG=chromium:273278
TEST=Emerged chromeos-chrome and autotest* for Daisy.

Change-Id: I357fea769eb54e1cd5ba39b1c2c8596256edfa69
Reviewed-on: https://gerrit.chromium.org/gerrit/65908
Reviewed-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>
13 months agoRefactor client side xmlrpc server code. 73/65873/6
Yusuf Mohsinally [Wed, 14 Aug 2013 19:59:16 +0000 (12:59 -0700)]
Refactor client side xmlrpc server code.

Break out code for xmlrpc server from the code that exposes the faft functions
into two files (rpc_server.py and rpc_functions.py).

Also break out config values used for the rpc server into anther module which
can be seen by server side FAFT code which tells autotest to spin up the
rpc server.

BUG=None
TEST=Manually ran tests at desk against link device.

Change-Id: I9d8b2c3946c34fac247e8c4263f9620cba1fcd28
Reviewed-on: https://gerrit.chromium.org/gerrit/65873
Reviewed-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
Commit-Queue: Yusuf Mohsinally <mohsinally@chromium.org>
Tested-by: Yusuf Mohsinally <mohsinally@chromium.org>
13 months ago[autotest] Don't swap devservers when verifying repo_url. 58/63758/3
beeps [Tue, 30 Jul 2013 18:37:06 +0000 (11:37 -0700)]
[autotest] Don't swap devservers when verifying repo_url.

Since we're seeing more flake than we would like when
checking the health of a devserver we end up swapping
devservers and restaging contents, even when the initial
devserver is healthy. This leads to more load, which
further exacerbates the problem of flakyness, leading to
a vicious cycle. This cl restages autotest on the
job_repo_url devserver, and fails verification if the
devserver embedded in the url is down.

BUG=None
TEST=set job_repo_url and deleted directories on local
     devserver, checked that we re-stage. Didn't start
     up local devserver and checked that we received
     an URLError. Killed the devserver in the middle
     of a request and checked that the test Failed.

Change-Id: I18843d3047122b9ffea3b2b1305fb0332172b19d
Reviewed-on: https://gerrit.chromium.org/gerrit/63758
Tested-by: Prashanth Balasubramanian <beeps@chromium.org>
Reviewed-by: Alex Miller <milleral@chromium.org>
Commit-Queue: Prashanth Balasubramanian <beeps@chromium.org>

13 months agoIncrease Network3g "num" to 7 in suite_scheduler.ini. 44/65944/2
Ben Chan [Thu, 15 Aug 2013 07:33:59 +0000 (00:33 -0700)]
Increase Network3g "num" to 7 in suite_scheduler.ini.

BUG=chrome-os-partner:21893
TEST=`suite_scheduler.py --sanity`

Change-Id: Iff1cf3cce043e59f146a9bc7467ea092699d7519
Reviewed-on: https://gerrit.chromium.org/gerrit/65944
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Alex Miller <milleral@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>

13 months ago[autotest] update checksum in packager.process_all_packages 11/65911/2
Dan Shi [Wed, 14 Aug 2013 23:31:48 +0000 (16:31 -0700)]
[autotest] update checksum in packager.process_all_packages

Original code has a bug that it does not update checksum for existing package.
This leads to packages being rebuild during build process, e.g.,
client-autotest.tar.bz2, has mismatched checksum in packages.checksum.

BUG=chromium:272500
TEST=run build_package in local chroot and verify checksum matches for
client-autotest.tar.bz2

Change-Id: I9db2496df3f99606e0eec313643a5051bde4f1eb
Reviewed-on: https://gerrit.chromium.org/gerrit/65911
Reviewed-by: Alex Miller <milleral@chromium.org>
Commit-Queue: Dan Shi <dshi@chromium.org>
Tested-by: Dan Shi <dshi@chromium.org>
13 months agoClean up a logic anomaly in run_suite.main() 95/65795/2
J. Richard Barnette [Wed, 14 Aug 2013 01:03:00 +0000 (18:03 -0700)]
Clean up a logic anomaly in run_suite.main()

The code in main() for run_suite includes a loop with the condition
`while wait and True`.  The `and True` wasn't helpful, and the loop
was misplaced.  This fixes the logic so as not to frighten children
and horses.

BUG=None
TEST=run_suite with -m, with both -n True and -n False

Change-Id: Ia1e6d564b6e94e237fdb3d522022298530be516a
Reviewed-on: https://gerrit.chromium.org/gerrit/65795
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Prashanth Balasubramanian <beeps@chromium.org>
Commit-Queue: Richard Barnette <jrbarnette@chromium.org>

13 months agoUpdate sysfs path 04/65904/2
Dominik Behr [Wed, 14 Aug 2013 22:54:59 +0000 (15:54 -0700)]
Update sysfs path

Path has been updated to /sys/class/misc/mali0/device/...
Which exists both on kernel 3.4 and kernel 3.8

BUG=chromium:268717
TEST=run graphics_KernelMemory, it passes

Change-Id: I33d0860343e71f942da01fb0cfbe7499ff6a0abc
Signed-off-by: Dominik Behr <dbehr@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/65904
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
13 months ago[autotest] Remove FalcoBVT entry in suite_scheduler.ini 26/63926/2
Fang Deng [Wed, 31 Jul 2013 17:57:59 +0000 (10:57 -0700)]
[autotest] Remove FalcoBVT entry in suite_scheduler.ini

Falco release builder will be running with hwtest. Remove FalcoBVT
from suite_scheduler.

TEST=None
BUG=chromium:266329

Change-Id: I9aacfdf11c432202366f8f05fb05705e07f66a4b
Reviewed-on: https://gerrit.chromium.org/gerrit/63926
Reviewed-by: Scott Zawalski <scottz@chromium.org>
Reviewed-by: Fang Deng <fdeng@chromium.org>
Tested-by: Fang Deng <fdeng@chromium.org>
Tested-by: Scott Zawalski <scottz@chromium.org>
Commit-Queue: Fang Deng <fdeng@chromium.org>

13 months agoRestrict the gpu_hang suite to R31. 55/65955/2
J. Richard Barnette [Thu, 15 Aug 2013 15:58:44 +0000 (08:58 -0700)]
Restrict the gpu_hang suite to R31.

The suite was constrained to R30 at creation time, but it missed
the R30->R31 branch split by a couple of builds, so it's in R31
instead.

BUG=None
TEST=None

Change-Id: I4a502307bfa76078a419e2c3049749021cc02469
Reviewed-on: https://gerrit.chromium.org/gerrit/65955
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Dan Shi <dshi@chromium.org>
13 months ago[autotest] Add provisioning job provision_FirmwareUpdate 99/65399/7
Fang Deng [Fri, 9 Aug 2013 23:17:30 +0000 (16:17 -0700)]
[autotest] Add provisioning job provision_FirmwareUpdate

This CL adds site_tests/provision_FirmwareUpdate which provisions a
system to the correct firmware version.
It also updates provision.py to map fw-version label to the right
provisioning job.

BUG=chromium:250585
TEST=1) Ran the control segment manually via
|./server/autoserv server/control_segments/provision --args
"fw-version:link-firmware/R22-2695.1.144" -m MY_DUT_IP|, and confirmed
the provision_FirmwareUpdate test was invoked and passed.
2) Ran the control file of the test via
|./server/autoserv server/site_tests/provision_FirmwareUpdate/control
--args value=link-firmware/R22-2695.1.144 servo_host=MY_SERVO_IP
-m MY_DUT_IP|, and confirmed the test passed.
3) Ran ./site_utils/run_suite.py -b link -i link-release/R30-4537.0.0
-s faft_dev -f False. Confirmed firmware update provisioning job
is scheduled.
DEPLOY=scheduler

Change-Id: Id68a628106495155c74ef6d525eed93eeda09f07
Reviewed-on: https://gerrit.chromium.org/gerrit/65399
Reviewed-by: Alex Miller <milleral@chromium.org>
Commit-Queue: Fang Deng <fdeng@chromium.org>
Tested-by: Fang Deng <fdeng@chromium.org>
13 months ago[autotest] cc chromeos-lab-errors on bvt failures. 41/65841/2
beeps [Wed, 14 Aug 2013 16:30:16 +0000 (09:30 -0700)]
[autotest] cc chromeos-lab-errors on bvt failures.

TEST=https://groups.google.com/a/google.com/forum/#!topic/chromeos-lab-errors/rwfisw0aU1M
BUG=None

Change-Id: Ic819546e54fc571c42be836f349c54b44baae0ad
Reviewed-on: https://gerrit.chromium.org/gerrit/65841
Tested-by: Prashanth Balasubramanian <beeps@chromium.org>
Reviewed-by: Alex Miller <milleral@chromium.org>
Commit-Queue: Prashanth Balasubramanian <beeps@chromium.org>

13 months ago[autotest] .drone -> .hostname 71/65971/2
Alex Miller [Thu, 15 Aug 2013 18:16:40 +0000 (11:16 -0700)]
[autotest] .drone -> .hostname

whoops.

BUG=None
DEPLOY=scheduler
TEST=None

Change-Id: Ia1d8922f7e5008420cb9c40fff607c86819e636c
Reviewed-on: https://gerrit.chromium.org/gerrit/65971
Commit-Queue: Alex Miller <milleral@chromium.org>
Reviewed-by: Alex Miller <milleral@chromium.org>
Tested-by: Alex Miller <milleral@chromium.org>
13 months ago[autotest] Filter process information in drone_manager. 56/65956/4
Alex Miller [Thu, 15 Aug 2013 16:24:27 +0000 (09:24 -0700)]
[autotest] Filter process information in drone_manager.

This change is being done as the drone appears to be filtering out
existing autoserv processes incorrectly.  It's difficult to get
debugging information out of drone_utility, so the filtering of autoserv
processes has been moved to drone_mananger.

There's also a semantic change that we now will acknowledge that there
is a process running even if it isn't an autoserv process.  This is
being done in the offchance that there's something interesting going on
with the process names at startup.

BUG=chromium:262005
DEPLOY=scheduler
TEST=unit, scheduler runs locally

Change-Id: I2413007d7c5dac79a8d26119ead639d956d6ecc6
Reviewed-on: https://gerrit.chromium.org/gerrit/65956
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Alex Miller <milleral@chromium.org>
Tested-by: Alex Miller <milleral@chromium.org>
13 months agoAutotest: Fix unittest file names so they are ran. 70/65270/4
Keyar Hood [Fri, 9 Aug 2013 00:48:51 +0000 (17:48 -0700)]
Autotest: Fix unittest file names so they are ran.

The automatic test finding script does not find files of the form
*_unittests.py. These have been renamed to be *_unittest.py.

BUG=None
TEST=Ran test ./utils/unittests_suite.py with --debug flag and verified tests
were ran.

Change-Id: Idfc6ee90a19138d486e9167620d6e4df14b84c76
Reviewed-on: https://gerrit.chromium.org/gerrit/65270
Reviewed-by: Keyar Hood <keyar@chromium.org>
Tested-by: Keyar Hood <keyar@chromium.org>
Commit-Queue: Keyar Hood <keyar@chromium.org>

13 months agoAutotest: Create test health script runner. 54/65754/4
Keyar Hood [Tue, 13 Aug 2013 22:29:30 +0000 (15:29 -0700)]
Autotest: Create test health script runner.

The check_test_health.py script will be ran as a cron job. This will allow
people to add more analysis by just modifying this script.

Furthermore, this has a preperation step that allows scripts that prepare the
database to be ran before the analysis steps. In particular, this means we
moved the call to test_importer.py from passing_experimental.py to
check_test_health.py.

BUG=chromium:272534
TEST=Autotests.

Change-Id: I438bd69e1f8688ba7e94910c9db9c4cac35fffcf
Reviewed-on: https://gerrit.chromium.org/gerrit/65754
Reviewed-by: Dennis Jeffrey <dennisjeffrey@chromium.org>
Commit-Queue: Keyar Hood <keyar@chromium.org>
Tested-by: Keyar Hood <keyar@chromium.org>
13 months agoCreate AP spec object, update factory to take ap_specs 30/64730/10
Kris Rambish [Wed, 31 Jul 2013 02:55:20 +0000 (19:55 -0700)]
Create AP spec object, update factory to take ap_specs

Before the ap_spec was a dictionary object that contained a lot of
data.  Now it is an object with the a small defined scope.  The
factory has also been updated to take a ap_spec object.

TEST=unittests
BUG=None

Change-Id: I98f5f88151ab73be465e15f68e5b61e0c1dd727d
Reviewed-on: https://gerrit.chromium.org/gerrit/64730
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Tested-by: Kris Rambish <krisr@chromium.org>
Commit-Queue: Kris Rambish <krisr@chromium.org>

13 months ago[autotest] drone_utility can't handle generators 42/65942/2
Alex Miller [Thu, 15 Aug 2013 05:20:32 +0000 (22:20 -0700)]
[autotest] drone_utility can't handle generators

BUG=chromium:262005
DEPLOY=scheduler
TEST=scheduler runs in prod

Change-Id: I3dfda8c2ab2017a36ef6ae770eaee39b02a89aa0
Reviewed-on: https://gerrit.chromium.org/gerrit/65942
Commit-Queue: Alex Miller <milleral@chromium.org>
Reviewed-by: Alex Miller <milleral@chromium.org>
Tested-by: Alex Miller <milleral@chromium.org>
13 months ago[autotest] Have drone report all running processes. 41/65941/2
Alex Miller [Thu, 15 Aug 2013 05:10:35 +0000 (22:10 -0700)]
[autotest] Have drone report all running processes.

BUG=chromium:262005
DEPLOY=scheduler
TEST=scheduler runs locally

Change-Id: Ie0a786305afd976be2fd62782b3e421c58818fce
Reviewed-on: https://gerrit.chromium.org/gerrit/65941
Commit-Queue: Alex Miller <milleral@chromium.org>
Reviewed-by: Alex Miller <milleral@chromium.org>
Tested-by: Alex Miller <milleral@chromium.org>