external/dart/bleeding_edge.git
4 hours agoLet debugger find async function literals master
hausner@google.com [Wed, 1 Apr 2015 00:18:11 +0000 (00:18 +0000)]
Let debugger find async function literals

This is a fix for issue 22030.

When looking for known functions, consider even non-debuggable
functions, so that we don’t set the breakpoint too eagerly
in the outer function.

R=iposva@google.com

Review URL: https://codereview.chromium.org//1049863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44829 260f80e4-7a28-3924-810f-c04153c831b5

5 hours agoAdds armv5 build and test target.
zra@google.com [Tue, 31 Mar 2015 23:11:33 +0000 (23:11 +0000)]
Adds armv5 build and test target.

R=regis@google.com

Review URL: https://codereview.chromium.org//1043263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44828 260f80e4-7a28-3924-810f-c04153c831b5

6 hours agoUse TaskInputBuilder to compute import/export source closures.
scheglov@google.com [Tue, 31 Mar 2015 22:21:02 +0000 (22:21 +0000)]
Use TaskInputBuilder to compute import/export source closures.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1045113005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44827 260f80e4-7a28-3924-810f-c04153c831b5

6 hours agoAdd the implicit return in the correct sequence node
hausner@google.com [Tue, 31 Mar 2015 22:11:06 +0000 (22:11 +0000)]
Add the implicit return in the correct sequence node

Make sure we add the implicit return node into the sequence
node that contains the function’s code. Previously, we added
the implicit return in the outermost sequence. If the outermost
sequence is at a different context level than the sequence that
contains the function’s code, the debugger cannot access the
captured variables when stopped at the return statement.

R=regis@google.com

Review URL: https://codereview.chromium.org//1037183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44826 260f80e4-7a28-3924-810f-c04153c831b5

6 hours agodo not report _ as unused variable
danrubel@google.com [Tue, 31 Mar 2015 21:56:33 +0000 (21:56 +0000)]
do not report _ as unused variable

BUG=dartbug.com/23050
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1040083007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44825 260f80e4-7a28-3924-810f-c04153c831b5

7 hours agofix for dartbug.com/23032 - breakpoints not triggering
keertip@google.com [Tue, 31 Mar 2015 21:36:07 +0000 (21:36 +0000)]
fix for dartbug.com/23032 - breakpoints not triggering

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1047863004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44824 260f80e4-7a28-3924-810f-c04153c831b5

7 hours agoDEPS AutoUpdate: webkit to 192851 (2015-03-31 14:17:06 -0700) asiva@google.com
vsm@google.com [Tue, 31 Mar 2015 21:31:49 +0000 (21:31 +0000)]
DEPS AutoUpdate: webkit to 192851 (2015-03-31 14:17:06 -0700) asiva@google.com
Changes to account for a split snapshot (vm isolate, isolate snapshot) in Dart VM
http://src.chromium.org/viewvc/blink?view=rev&revision=192851

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44823 260f80e4-7a28-3924-810f-c04153c831b5

7 hours agoimprove parser recovery when top level function is missing parameters
danrubel@google.com [Tue, 31 Mar 2015 20:49:19 +0000 (20:49 +0000)]
improve parser recovery when top level function is missing parameters

BUG=dartbug.com/23044
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1044383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44822 260f80e4-7a28-3924-810f-c04153c831b5

7 hours agoUse parsed unit/class nodes instead of resolved in fixes.
scheglov@google.com [Tue, 31 Mar 2015 20:43:41 +0000 (20:43 +0000)]
Use parsed unit/class nodes instead of resolved in fixes.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1047673005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44821 260f80e4-7a28-3924-810f-c04153c831b5

8 hours agoForward signals to pub run processes.
nweiz@google.com [Tue, 31 Mar 2015 19:46:40 +0000 (19:46 +0000)]
Forward signals to pub run processes.

This is important for unittest, so it can catch SIGINT and gracefully clean up.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1044033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44820 260f80e4-7a28-3924-810f-c04153c831b5

8 hours agoMake "pub run foo" run "pub run foo:foo" rather than "pub run bin/foo"
nweiz@google.com [Tue, 31 Mar 2015 19:43:36 +0000 (19:43 +0000)]
Make "pub run foo" run "pub run foo:foo" rather than "pub run bin/foo"

R=rnystrom@google.com
BUG= dartbug.com/22129

Review URL: https://codereview.chromium.org//1040563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44819 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoFix some Observatory issues that crept in with my last couple changes.
turnidge@google.com [Tue, 31 Mar 2015 19:33:38 +0000 (19:33 +0000)]
Fix some Observatory issues that crept in with my last couple changes.

- need ObservatoryApplication class in ObservatoryDebugger
- mainPort is gone now

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1043953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44818 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoFix windows compilation error "cannot allocate an array of constant size 0".
asiva@google.com [Tue, 31 Mar 2015 19:32:23 +0000 (19:32 +0000)]
Fix windows compilation error "cannot allocate an array of constant size 0".

Review URL: https://codereview.chromium.org//1045253003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44817 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoUpdate matcher to 0.11.4+4.
nweiz@google.com [Tue, 31 Mar 2015 19:14:27 +0000 (19:14 +0000)]
Update matcher to 0.11.4+4.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1047263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44816 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoAdjust vmservice_dartium.cc to account for new isolate snapshot buffer name.
asiva@google.com [Tue, 31 Mar 2015 18:46:48 +0000 (18:46 +0000)]
Adjust vmservice_dartium.cc to account for new isolate snapshot buffer name.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1042563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44815 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoFirst step towards splitting a full snapshot into a vm isolate snapshot and a
asiva@google.com [Tue, 31 Mar 2015 18:46:19 +0000 (18:46 +0000)]
First step towards splitting a full snapshot into a vm isolate snapshot and a
regular isolate snapsot.
- change gen_snapshot to split a full snapshot into a vm isolate snapshot
  and an isolate snapshot
- change the build process and scripts to account for splitting the full
  snapshot

R=hausner@google.com

Review URL: https://codereview.chromium.org//1023753006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44814 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoremove debug statement
keertip@google.com [Tue, 31 Mar 2015 18:44:15 +0000 (18:44 +0000)]
remove debug statement

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1040363004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44813 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agoIssue 19929. Record the propagated type into LHS of the assignment.
scheglov@google.com [Tue, 31 Mar 2015 18:22:40 +0000 (18:22 +0000)]
Issue 19929. Record the propagated type into LHS of the assignment.

This is a fix only for https://code.google.com/p/dart/issues/detail?id=19929#c8 ,
not the whole issue.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19929

Review URL: https://codereview.chromium.org//1049303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44812 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agoFix for coverage displaying.
scheglov@google.com [Tue, 31 Mar 2015 18:19:54 +0000 (18:19 +0000)]
Fix for coverage displaying.

VM emits several coverage files now, the previous implementation of the
Editor's CoverageManager wrongly expected only one.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1046203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44811 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agofix for dartbug.com/22889 , stop on breakpoint not showing source
keertip@google.com [Tue, 31 Mar 2015 18:19:25 +0000 (18:19 +0000)]
fix for dartbug.com/22889 , stop on breakpoint not showing source

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1049733003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44810 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agoGenerateHintsTask - partial implementation.
scheglov@google.com [Tue, 31 Mar 2015 18:14:28 +0000 (18:14 +0000)]
GenerateHintsTask - partial implementation.

1. We need to ensure somehow that TypeProvider's types hierarchies are finished.

2. We need aggregating tasks to compute used imported / local elements.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1046193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44809 260f80e4-7a28-3924-810f-c04153c831b5

11 hours agoEmit diagnostics for bad NSM implementations
het@google.com [Tue, 31 Mar 2015 17:11:26 +0000 (17:11 +0000)]
Emit diagnostics for bad NSM implementations

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1023673012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44808 260f80e4-7a28-3924-810f-c04153c831b5

12 hours agoSimpler VM status file fix for if_null tests.
paulberry@google.com [Tue, 31 Mar 2015 16:25:32 +0000 (16:25 +0000)]
Simpler VM status file fix for if_null tests.

This should fix some additional buildbots
(e.g. dartium-lucid32-full-be) that were missed by r44803.

TBR=hausner@google.com

Review URL: https://codereview.chromium.org//1045333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44807 260f80e4-7a28-3924-810f-c04153c831b5

12 hours agoswitch to https
danrubel@google.com [Tue, 31 Mar 2015 16:03:05 +0000 (16:03 +0000)]
switch to https

BUG=dartbug.com/21392
R=keertip@google.com

Review URL: https://codereview.chromium.org//1049233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44806 260f80e4-7a28-3924-810f-c04153c831b5

12 hours agofix NSM error when completing imported inherited private fields
danrubel@google.com [Tue, 31 Mar 2015 16:00:31 +0000 (16:00 +0000)]
fix NSM error when completing imported inherited private fields

BUG=dartbug.com/23036
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1050483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44805 260f80e4-7a28-3924-810f-c04153c831b5

13 hours agofix for dartbug.com/22920, ignore "build" dir
keertip@google.com [Tue, 31 Mar 2015 15:06:48 +0000 (15:06 +0000)]
fix for dartbug.com/22920, ignore "build" dir

R=danrubel@google.com

Review URL: https://codereview.chromium.org//1045993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44804 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoFix Dartium test breakage after r44802.
paulberry@google.com [Tue, 31 Mar 2015 14:13:18 +0000 (14:13 +0000)]
Fix Dartium test breakage after r44802.

Compile-time errors apparently manifest in the Dartium tests as
runtime errors, so the new "if_null" tests need to be marked as
RuntimeError for Dartium.

TBR=hausner@google.com

Review URL: https://codereview.chromium.org//1047823006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44803 260f80e4-7a28-3924-810f-c04153c831b5

16 hours agoImplement the new '??' operator in analyzer.
paulberry@google.com [Tue, 31 Mar 2015 12:38:12 +0000 (12:38 +0000)]
Implement the new '??' operator in analyzer.

The new operator is only accepted by the tokenizer if the command-line
option "--enable-null-aware-operators" is supplied.

Only static analysis of '??' is implemented.  However, the tests in
tests/language/if_null_*_test.dart will also verify behavior once it
is implemented.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1045553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44802 260f80e4-7a28-3924-810f-c04153c831b5

17 hours agoFix docgen.
johnniwinther@google.com [Tue, 31 Mar 2015 10:59:09 +0000 (10:59 +0000)]
Fix docgen.

BUG=

Review URL: https://codereview.chromium.org//1046143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44801 260f80e4-7a28-3924-810f-c04153c831b5

18 hours agoHandle NewExpression in SemanticSendVisitor.
johnniwinther@google.com [Tue, 31 Mar 2015 10:02:55 +0000 (10:02 +0000)]
Handle NewExpression in SemanticSendVisitor.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1043723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44800 260f80e4-7a28-3924-810f-c04153c831b5

28 hours agoUpdate unittest to 0.11.5+4.
nweiz@google.com [Tue, 31 Mar 2015 00:24:27 +0000 (00:24 +0000)]
Update unittest to 0.11.5+4.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1034333004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44799 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoUpdate scheduled_test to 0.11.8.
nweiz@google.com [Mon, 30 Mar 2015 23:37:50 +0000 (23:37 +0000)]
Update scheduled_test to 0.11.8.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1047873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44798 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoRework handling of factory redirects in constant evaluation.
paulberry@google.com [Mon, 30 Mar 2015 21:50:43 +0000 (21:50 +0000)]
Rework handling of factory redirects in constant evaluation.

This change limits the set of elements that need to be examined in
order to determine the constant evaluation dependency graph.
Previously, when encountering a constant constructor invocation, we
would chase the sequence of factory redirects to a non-redirecting
constructor (being careful to avoid infinite regress in the case of
invalid input), and then mark the invocation as dependent on the
non-redirecting constructor.  Now, we mark the invocation as dependent
on the constructor it immediately references, and mark redirecting
factory constructors as dependent on the constructors they redirect
to.

This is a prerequisite to converting constant evaluation over to the
new task model, since once we're in the new task model there will be
no guarantee that the full sequence of factory redirects has been
resolved at the time we need to compute dependencies.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1043843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44797 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoGracefully degrade if no source for completion
danrubel@google.com [Mon, 30 Mar 2015 21:43:05 +0000 (21:43 +0000)]
Gracefully degrade if no source for completion

BUG=dartbug.com/22617
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1044463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44796 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoRemove directives validation.
scheglov@google.com [Mon, 30 Mar 2015 21:41:31 +0000 (21:41 +0000)]
Remove directives validation.

I was not able to get to this check, we stop analyzing before it.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1049013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44795 260f80e4-7a28-3924-810f-c04153c831b5

31 hours ago- Split observatory source list into separate gypi file.
johnmccutchan@google.com [Mon, 30 Mar 2015 21:21:40 +0000 (21:21 +0000)]
- Split observatory source list into separate gypi file.
- Update observatory_tool.py to support running against an SDK.

BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org//1046993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44794 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoTask: Verify Dart.
scheglov@google.com [Mon, 30 Mar 2015 21:19:12 +0000 (21:19 +0000)]
Task: Verify Dart.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1041273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44793 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoGetContentTask should catch exceptions and wrap them into AnalysisExceptions.
scheglov@google.com [Mon, 30 Mar 2015 21:16:52 +0000 (21:16 +0000)]
GetContentTask should catch exceptions and wrap them into AnalysisExceptions.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1041283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44792 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoSupport refresh of individual analysis roots (issue 22254)
brianwilkerson@google.com [Mon, 30 Mar 2015 21:07:23 +0000 (21:07 +0000)]
Support refresh of individual analysis roots (issue 22254)

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1047733004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44791 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoAdd a missing import to pub.
nweiz@google.com [Mon, 30 Mar 2015 21:07:21 +0000 (21:07 +0000)]
Add a missing import to pub.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1047013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44790 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoAvoid infinite loop if const constructor redirects don't reach a fixed point.
paulberry@google.com [Mon, 30 Mar 2015 21:00:36 +0000 (21:00 +0000)]
Avoid infinite loop if const constructor redirects don't reach a fixed point.

BUG=dartbug.com/23038
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1042963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44789 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoA few fixes for ARMv5TE.
zra@google.com [Mon, 30 Mar 2015 20:46:52 +0000 (20:46 +0000)]
A few fixes for ARMv5TE.

This CL:
- Adds SupportsHardwareDivision() to FlowGraphCompiler.
  In FlowGraphOptimizer, if SupportsHardwareDivision()
  is false, Smi and Mint division operations are not
  inlined.
- Reduces the supported addressing modes for ldrd, strd.
  For ARMv6 and up, the address only needs to be 4-byte
  aligned, for ARMv5TE and below the address must be
  8-byte aligned. So, on ARMv5TE, we can split these
  each into two instructions, which is easier to do if
  the addressing modes are restricted to base + offset,
  which is all we were using anyway.
- Uses the smull instruction on ARMv5TE and ARMv6. I don't
  remember why it was disabled, and the docs say
  it is supported. Verified working on ARMv5TE hardware.
- Fixes a bug in OSR frame entry caused by the
  difference between the PC read offset in store vs.
  other instructions.
- Fixes assembler tests that have a float return for
  targets without vfp.

R=regis@google.com

Review URL: https://codereview.chromium.org//1043943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44788 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoadd UNKNOWN_SOURCE error code and remove 2 unused legacy error codes
danrubel@google.com [Mon, 30 Mar 2015 20:12:29 +0000 (20:12 +0000)]
add UNKNOWN_SOURCE error code and remove 2 unused legacy error codes

BUG=dartbug.com/23039
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1042403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44787 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoIssue 23027. Try to make priority files analyzable.
scheglov@google.com [Mon, 30 Mar 2015 19:50:10 +0000 (19:50 +0000)]
Issue 23027. Try to make priority files analyzable.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23027

Review URL: https://codereview.chromium.org//1044463005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44786 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoWork around issue 23008 in pub.
nweiz@google.com [Mon, 30 Mar 2015 19:38:26 +0000 (19:38 +0000)]
Work around issue 23008 in pub.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//1007733004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44785 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoEvaluate parameters of static calls that throw NSM
hausner@google.com [Mon, 30 Mar 2015 19:31:20 +0000 (19:31 +0000)]
Evaluate parameters of static calls that throw NSM

The spec mandates that parameters of calls get evaluated
even if the function can’t be resolved and the call results
in a noSuchMethod being thrown.

Fixes issue 17382.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1038283004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44784 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoTest for limited optimizations on native fields
sra@google.com [Mon, 30 Mar 2015 19:24:04 +0000 (19:24 +0000)]
Test for limited optimizations on native fields

This captures some of the current status on how optimizations interact with native fields.

R=herhut@google.com

Review URL: https://codereview.chromium.org//1031073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44783 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoIssue 22617. Add/remove overlay-only sources to their containing contexts.
scheglov@google.com [Mon, 30 Mar 2015 16:57:33 +0000 (16:57 +0000)]
Issue 22617. Add/remove overlay-only sources to their containing contexts.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22617

Review URL: https://codereview.chromium.org//1042923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44782 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoClean up analyzer hints.
paulberry@google.com [Mon, 30 Mar 2015 16:54:02 +0000 (16:54 +0000)]
Clean up analyzer hints.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//1042913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44781 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoRecognize nested pubspecs (issue 22907)
brianwilkerson@google.com [Mon, 30 Mar 2015 16:01:03 +0000 (16:01 +0000)]
Recognize nested pubspecs (issue 22907)

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1042293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44780 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoBump analyzer version to 0.25.0-dev.3 in preparation for publishing.
paulberry@google.com [Mon, 30 Mar 2015 15:42:38 +0000 (15:42 +0000)]
Bump analyzer version to 0.25.0-dev.3 in preparation for publishing.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1048833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44779 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoMove definition of trace_debug_protocol to dbg_connection.cc as this file is also...
asiva@google.com [Mon, 30 Mar 2015 15:40:51 +0000 (15:40 +0000)]
Move definition of trace_debug_protocol to dbg_connection.cc as this file is also linked into libvmservice_io

R=hausner@google.com

Review URL: https://codereview.chromium.org//1040543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44778 260f80e4-7a28-3924-810f-c04153c831b5

42 hours agoDo not include names of lazy globals in minified mode.
herhut@google.com [Mon, 30 Mar 2015 10:36:31 +0000 (10:36 +0000)]
Do not include names of lazy globals in minified mode.

BUG=
R=zarah@google.com

Review URL: https://codereview.chromium.org//1022103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44777 260f80e4-7a28-3924-810f-c04153c831b5

44 hours agodart2js: remove first argument from lazy function.
zarah@google.com [Mon, 30 Mar 2015 08:19:27 +0000 (08:19 +0000)]
dart2js: remove first argument from lazy function.

R=herhut@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44660

Reverted: https://code.google.com/p/dart/source/detail?r=44665

Review URL: https://codereview.chromium.org//1029003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44776 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix co19 tests after r44774.
paulberry@google.com [Mon, 30 Mar 2015 02:37:52 +0000 (02:37 +0000)]
Fix co19 tests after r44774.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1042203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44775 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoGenerate warnings for assignment to a type.
paulberry@google.com [Mon, 30 Mar 2015 00:08:17 +0000 (00:08 +0000)]
Generate warnings for assignment to a type.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1042133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44774 260f80e4-7a28-3924-810f-c04153c831b5

3 days ago- Remove empty section from status file.
iposva@google.com [Sat, 28 Mar 2015 09:37:42 +0000 (09:37 +0000)]
- Remove empty section from status file.

Review URL: https://codereview.chromium.org//1047503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44773 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoIssue 22279. Tweak constants evaluation error messages.
scheglov@google.com [Sat, 28 Mar 2015 03:08:22 +0000 (03:08 +0000)]
Issue 22279. Tweak constants evaluation error messages.

LMK if the new messages are also not good.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22279

Review URL: https://codereview.chromium.org//1048463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44772 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoIssue 23018. Fix for inlining multiline strings with leading whitespaces.
scheglov@google.com [Sat, 28 Mar 2015 02:31:07 +0000 (02:31 +0000)]
Issue 23018. Fix for inlining multiline strings with leading whitespaces.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23018

Review URL: https://codereview.chromium.org//1042033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44771 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoScanner/parser support for DEP 9 (null-aware operators).
paulberry@google.com [Sat, 28 Mar 2015 02:25:32 +0000 (02:25 +0000)]
Scanner/parser support for DEP 9 (null-aware operators).

This adds scanner and parser support for the operators '?.', '??', and
'??='.

Support is not yet enabled--it is only turned on during the unit tests
for the new tokens and AST's.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1043583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44770 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoAnother attempt to fix the build
brianwilkerson@google.com [Sat, 28 Mar 2015 00:04:00 +0000 (00:04 +0000)]
Another attempt to fix the build

Review URL: https://codereview.chromium.org//1045463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44769 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix compile all for service isolate
johnmccutchan@google.com [Sat, 28 Mar 2015 00:00:42 +0000 (00:00 +0000)]
Fix compile all for service isolate

BUG=

Review URL: https://codereview.chromium.org//1046483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44768 260f80e4-7a28-3924-810f-c04153c831b5

4 days ago(TBR) Another attempt to fix the build
brianwilkerson@google.com [Fri, 27 Mar 2015 23:54:14 +0000 (23:54 +0000)]
(TBR) Another attempt to fix the build

Review URL: https://codereview.chromium.org//1039843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44767 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoGracefully handle IO exceptions while resolving URIs (issue 23023)
brianwilkerson@google.com [Fri, 27 Mar 2015 23:52:10 +0000 (23:52 +0000)]
Gracefully handle IO exceptions while resolving URIs (issue 23023)

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1033383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44766 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoEnable strict flags for all service tests
johnmccutchan@google.com [Fri, 27 Mar 2015 23:32:07 +0000 (23:32 +0000)]
Enable strict flags for all service tests

BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1043513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44765 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoRefactor bigint shifting code in preparation of shifting intrinsics.
regis@google.com [Fri, 27 Mar 2015 22:41:57 +0000 (22:41 +0000)]
Refactor bigint shifting code in preparation of shifting intrinsics.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1044503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44764 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoAttempt to fix the build
brianwilkerson@google.com [Fri, 27 Mar 2015 21:37:58 +0000 (21:37 +0000)]
Attempt to fix the build

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1041663004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44763 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoIsolate -> Thread for tracking owner of mutex and simulator's exclusive access.
koda@google.com [Fri, 27 Mar 2015 20:33:36 +0000 (20:33 +0000)]
Isolate -> Thread for tracking owner of mutex and simulator's exclusive access.

Prepares for multiple threads referencing the same isolate (in particular, the mutator and sweeper).

R=asiva@google.com

Review URL: https://codereview.chromium.org//999983004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44762 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix off-by-one bug in many_files_test.
rnystrom@google.com [Fri, 27 Mar 2015 20:10:51 +0000 (20:10 +0000)]
Fix off-by-one bug in many_files_test.

BUG=22996
R=nweiz@google.com

Review URL: https://codereview.chromium.org//1036343003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44761 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoimprove parser recovery for incomplete prefixed identifier in method/function paramet...
danrubel@google.com [Fri, 27 Mar 2015 20:05:18 +0000 (20:05 +0000)]
improve parser recovery for incomplete prefixed identifier in method/function parameter list

BUG=dartbug.com/22526
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1033333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44760 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix static warnings in Observatory tests.
rmacnak@google.com [Fri, 27 Mar 2015 19:49:08 +0000 (19:49 +0000)]
Fix static warnings in Observatory tests.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//1044453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44759 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoremove invalid completions in method declaration param list
danrubel@google.com [Fri, 27 Mar 2015 19:42:37 +0000 (19:42 +0000)]
remove invalid completions in method declaration param list

BUG=dartbug.com/22747
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1038113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44758 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoMark code when it instantiates an unloaded deferred type
hausner@google.com [Fri, 27 Mar 2015 19:39:31 +0000 (19:39 +0000)]
Mark code when it instantiates an unloaded deferred type

The VM registers code objects that depend on deferred library prefixes,
e.g. when calling a function in the deferred library. We didn’t do this
when instantiating a type from the deferred library.

This is a fix for issue 22443.

R=regis@google.com

Review URL: https://codereview.chromium.org//1037343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44757 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoonly suggest types when completing from a library prefix in parameter list
danrubel@google.com [Fri, 27 Mar 2015 19:39:28 +0000 (19:39 +0000)]
only suggest types when completing from a library prefix in parameter list

BUG=dartbug.com/22526
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1035283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44756 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoAdd a test for trimming leading whitespace in multiline strings
brianwilkerson@google.com [Fri, 27 Mar 2015 19:28:15 +0000 (19:28 +0000)]
Add a test for trimming leading whitespace in multiline strings

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1042523004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44755 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoIssue 20144. Reset propagated type if one of the 'if' branches changes it to a differ...
scheglov@google.com [Fri, 27 Mar 2015 19:13:50 +0000 (19:13 +0000)]
Issue 20144. Reset propagated type if one of the 'if' branches changes it to a different one.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20144

Review URL: https://codereview.chromium.org//1036233006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44754 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoTurn off observatory tests.
turnidge@google.com [Fri, 27 Mar 2015 18:41:30 +0000 (18:41 +0000)]
Turn off observatory tests.

BUG=

Review URL: https://codereview.chromium.org//1042523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44753 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix the value of multiline strings. This re-applies the changes in 44722 (which was...
brianwilkerson@google.com [Fri, 27 Mar 2015 18:26:06 +0000 (18:26 +0000)]
Fix the value of multiline strings. This re-applies the changes in 44722 (which was reverted in 44734) and fixes another bug that was uncovered by that change.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1043473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44752 260f80e4-7a28-3924-810f-c04153c831b5

4 days agofix for dartbug.com/22533, support constraints format ^1.2.3
keertip@google.com [Fri, 27 Mar 2015 18:22:10 +0000 (18:22 +0000)]
fix for dartbug.com/22533, support constraints format ^1.2.3

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1041753003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44751 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoVarious cleanup in bigint implementation:
regis@google.com [Fri, 27 Mar 2015 18:21:19 +0000 (18:21 +0000)]
Various cleanup in bigint implementation:
- reduce number of digit array allocations in divRem.
- shortcut reduce step in Classic reduction when possible.
- do not throw out of memory when value shifted left is zero.
- refactor code for future shifting operation intrinsics.
- and more...

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1038253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44750 260f80e4-7a28-3924-810f-c04153c831b5

4 days agovolatile -> const, where possible
koda@google.com [Fri, 27 Mar 2015 18:11:51 +0000 (18:11 +0000)]
volatile -> const, where possible

These 'volatile' modifiers were added to silence warnings about setjmp/longjmp clobbering, but 'const' works too and allows more optimization.

TBR=iposva@google.com

Review URL: https://codereview.chromium.org//1037333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44749 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoMark the functions of closures generated to speed up getField/setField as invisible...
rmacnak@google.com [Fri, 27 Mar 2015 18:09:49 +0000 (18:09 +0000)]
Mark the functions of closures generated to speed up getField/setField as invisible, just like other dispatchers.

BUG=http://dartbug.com/23006
R=asiva@google.com

Review URL: https://codereview.chromium.org//1036393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44748 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoTurn on observatory tests
turnidge@google.com [Fri, 27 Mar 2015 17:38:59 +0000 (17:38 +0000)]
Turn on observatory tests

BUG=

Review URL: https://codereview.chromium.org//1036383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44747 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoAdd check that no aggressive & incorrect optimizations is done.
srdjan@google.com [Fri, 27 Mar 2015 17:33:31 +0000 (17:33 +0000)]
Add check that no aggressive & incorrect optimizations is done.

R=sra@google.com

Review URL: https://codereview.chromium.org//1033873003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44746 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoIssue 22521. Drop '_J2DAccessor' suffixes.
scheglov@google.com [Fri, 27 Mar 2015 16:55:52 +0000 (16:55 +0000)]
Issue 22521. Drop '_J2DAccessor'  suffixes.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22521

Review URL: https://codereview.chromium.org//1042453003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44745 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoRename MethodInvocation.period to MethodInvocation.operator.
paulberry@google.com [Fri, 27 Mar 2015 16:38:33 +0000 (16:38 +0000)]
Rename MethodInvocation.period to MethodInvocation.operator.

The name is inaccurate--if the method invocation is part of a cascade,
it is the ".." operator.  It's going to get even more inaccurate when
null-aware operators are added, since it will also be used to
represent "?.".

Deprecated getters and setters named "period" are added to avoid
breaking the analyzer API.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1039713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44744 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoIssue 23010. Compute constant and report related errors during incremental resolution.
scheglov@google.com [Fri, 27 Mar 2015 16:29:03 +0000 (16:29 +0000)]
Issue 23010. Compute constant and report related errors during incremental resolution.

R=brianwilkerson@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23010

Review URL: https://codereview.chromium.org//1037313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44743 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoClean up observatory testing processes when we are done with them.
turnidge@google.com [Fri, 27 Mar 2015 16:09:12 +0000 (16:09 +0000)]
Clean up observatory testing processes when we are done with them.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1035943005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44742 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoTest that the target node is a SimpleIdentifier.
scheglov@google.com [Fri, 27 Mar 2015 15:48:39 +0000 (15:48 +0000)]
Test that the target node is a SimpleIdentifier.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1040733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44741 260f80e4-7a28-3924-810f-c04153c831b5

4 days agomerge editor.properties on update
keertip@google.com [Fri, 27 Mar 2015 15:46:35 +0000 (15:46 +0000)]
merge editor.properties on update

R=danrubel@google.com

Review URL: https://codereview.chromium.org//1035843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44740 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix NPE in ErrorReporter (issue 22980)
brianwilkerson@google.com [Fri, 27 Mar 2015 15:40:04 +0000 (15:40 +0000)]
Fix NPE in ErrorReporter (issue 22980)

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1040573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44739 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoMake some results private
brianwilkerson@google.com [Fri, 27 Mar 2015 15:37:01 +0000 (15:37 +0000)]
Make some results private

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1034423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44738 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix for computing overridden/implemented members from interfaces.
scheglov@google.com [Fri, 27 Mar 2015 15:16:21 +0000 (15:16 +0000)]
Fix for computing overridden/implemented members from interfaces.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1037193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44737 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoClean up naming scheme for reflection names.
herhut@google.com [Fri, 27 Mar 2015 14:43:02 +0000 (14:43 +0000)]
Clean up naming scheme for reflection names.

BUG= http://dartbug.com/22987
R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44732

Reverted: https://code.google.com/p/dart/source/detail?r=44733

Review URL: https://codereview.chromium.org//1040623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44736 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoChange type annotation buildInvokeConstructorInvocation.
karlklose@google.com [Fri, 27 Mar 2015 14:11:49 +0000 (14:11 +0000)]
Change type annotation buildInvokeConstructorInvocation.

The Dart backend uses the type directly to reconstruct malformed constructor calls and the JavaScript backend will generate code to throw an exception when encountering an ErroneousElement as target.

R=asgerf@google.com

Review URL: https://codereview.chromium.org//1036263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44735 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoRevert "Fix value computation for multi-line strings (issue 22993)"
ricow@google.com [Fri, 27 Mar 2015 13:59:13 +0000 (13:59 +0000)]
Revert "Fix value computation for multi-line strings (issue 22993)"

This reverts revision 44722

This is causing test failures:
http://build.chromium.org/p/client.dart/builders/pub-linux-be/builds/11761/steps/pub%20and%20pkg%20%20tests%20failures/logs/stdio

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1038353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44734 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoRevert "Clean up naming scheme for reflection names."
herhut@google.com [Fri, 27 Mar 2015 13:38:50 +0000 (13:38 +0000)]
Revert "Clean up naming scheme for reflection names."

This reverts commit r44732.

BUG=
TBR=ahe@google.com

Review URL: https://codereview.chromium.org//1039223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44733 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoClean up naming scheme for reflection names.
herhut@google.com [Fri, 27 Mar 2015 12:28:04 +0000 (12:28 +0000)]
Clean up naming scheme for reflection names.

BUG= http://dartbug.com/22987
R=ahe@google.com

Review URL: https://codereview.chromium.org//1040623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44732 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoMove set-membership based containment test behind a flag.
herhut@google.com [Fri, 27 Mar 2015 10:54:57 +0000 (10:54 +0000)]
Move set-membership based containment test behind a flag.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1037223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44731 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix type annotation for deferred constants.
johnniwinther@google.com [Fri, 27 Mar 2015 10:26:47 +0000 (10:26 +0000)]
Fix type annotation for deferred constants.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1033213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44730 260f80e4-7a28-3924-810f-c04153c831b5