external/dart/bleeding_edge.git
4 min agoEnsure for and if statements have a space after the statement keyword master
jwren@google.com [Wed, 17 Sep 2014 21:31:40 +0000 (21:31 +0000)]
Ensure for and if statements have a space after the statement keyword

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//581793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40403 260f80e4-7a28-3924-810f-c04153c831b5

42 min agoRemove watchdog from RemoteAnalysisServerImpl
jwren@google.com [Wed, 17 Sep 2014 20:53:21 +0000 (20:53 +0000)]
Remove watchdog from RemoteAnalysisServerImpl

R=danrubel@google.com

Review URL: https://codereview.chromium.org//575163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40400 260f80e4-7a28-3924-810f-c04153c831b5

76 min agoIndex and search of import prefixes.
scheglov@google.com [Wed, 17 Sep 2014 20:19:39 +0000 (20:19 +0000)]
Index and search of import prefixes.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//582453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40397 260f80e4-7a28-3924-810f-c04153c831b5

79 min agoChurn only: move analysis notification tests.
scheglov@google.com [Wed, 17 Sep 2014 20:16:29 +0000 (20:16 +0000)]
Churn only: move analysis notification tests.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//563373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40396 260f80e4-7a28-3924-810f-c04153c831b5

86 min agoRemove unused code.
scheglov@google.com [Wed, 17 Sep 2014 20:09:43 +0000 (20:09 +0000)]
Remove unused code.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//569243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40395 260f80e4-7a28-3924-810f-c04153c831b5

88 min agoNew analyzer snaphot.
scheglov@google.com [Wed, 17 Sep 2014 20:07:57 +0000 (20:07 +0000)]
New analyzer snaphot.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//581733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40394 260f80e4-7a28-3924-810f-c04153c831b5

98 min agoFix NPE in [toString] for merged method elements.
collinsn@google.com [Wed, 17 Sep 2014 19:57:31 +0000 (19:57 +0000)]
Fix NPE in [toString] for merged method elements.

However, this simple fix results in a slightly misleading [toString]:
e.g. for code

  class A {
    f() => 0;
  }
  class B extends A {
    f() => 1;
  }
  main(A a, B b) {
    var ab;
    if (0 < 1) {
      ab = a;
    } else {
      ab = b;
    }
    ab.f(); // Here the hover hint on [f] says [A.f()] or [B.f()]
            // and not [{A,B}.f] or whatever would be more accurate.
  }

Alternative approaches include a [toString] like

  <unknown>.f()

or

  (A or B).f()

or similar.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//574413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40393 260f80e4-7a28-3924-810f-c04153c831b5

104 min agoCache snapshots of (mostly) immutable transformer phases.
nweiz@google.com [Wed, 17 Sep 2014 19:51:31 +0000 (19:51 +0000)]
Cache snapshots of (mostly) immutable transformer phases.

This shaves off a pretty significant amount of time for packages that are
transformed but whose transformers never change (I saw a ~450ms gain in one of
my tests).

R=rnystrom@google.com
BUG=20859

Review URL: https://codereview.chromium.org//559833004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40392 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agofix for getting packages from pub.dartlang
keertip@google.com [Wed, 17 Sep 2014 19:20:15 +0000 (19:20 +0000)]
fix for getting packages from pub.dartlang

R=messick@google.com

Review URL: https://codereview.chromium.org//574063004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40390 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoConsider a prefix in an import directive as a declaration.
scheglov@google.com [Wed, 17 Sep 2014 19:07:10 +0000 (19:07 +0000)]
Consider a prefix in an import directive as a declaration.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//558543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40388 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoUse Shell.forceActive() to ensure the window is alive.
messick@google.com [Wed, 17 Sep 2014 18:58:09 +0000 (18:58 +0000)]
Use Shell.forceActive() to ensure the window is alive.
This is necessary when running in Xvfb on the FYI bot.
It if causes problems on other platforms I will add a
guard, but only if necessary.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//575073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40387 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoAvoid merging methods on union types when all methods are equal.
collinsn@google.com [Wed, 17 Sep 2014 18:37:47 +0000 (18:37 +0000)]
Avoid merging methods on union types when all methods are equal.

This CL looks a lot bigger than it actually is: the method merging
method was getting too big, so I split it into two methods.  The
actual changes are in the first, smaller method, where I check to
see if all the method to merge are actually equal.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//573103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40386 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoRemove unnecessary check in bigint division.
regis@google.com [Wed, 17 Sep 2014 18:37:39 +0000 (18:37 +0000)]
Remove unnecessary check in bigint division.

Review URL: https://codereview.chromium.org//576253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40385 260f80e4-7a28-3924-810f-c04153c831b5

3 hours agoAdd a --mode flag to pub run and pub global run.
nweiz@google.com [Wed, 17 Sep 2014 18:32:46 +0000 (18:32 +0000)]
Add a --mode flag to pub run and pub global run.

pub run now defaults to --mode=debug for local executables.

R=rnystrom@google.com
BUG=20898

Review URL: https://codereview.chromium.org//550643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40384 260f80e4-7a28-3924-810f-c04153c831b5

3 hours agoAdd an error callback to StackZoneSpecification.
nweiz@google.com [Wed, 17 Sep 2014 18:10:55 +0000 (18:10 +0000)]
Add an error callback to StackZoneSpecification.

This releases stack_trace 1.0.3.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//556363004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40383 260f80e4-7a28-3924-810f-c04153c831b5

3 hours agoBump multivm DEPS
rmacnak@google.com [Wed, 17 Sep 2014 17:44:59 +0000 (17:44 +0000)]
Bump multivm DEPS

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40382 260f80e4-7a28-3924-810f-c04153c831b5

3 hours agoParse the repo's version file when running from the repo.
rnystrom@google.com [Wed, 17 Sep 2014 17:37:48 +0000 (17:37 +0000)]
Parse the repo's version file when running from the repo.

R=nweiz@google.com

Review URL: https://codereview.chromium.org//572053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40381 260f80e4-7a28-3924-810f-c04153c831b5

4 hours agoType hierarchy view for Analysis Server.
scheglov@google.com [Wed, 17 Sep 2014 17:07:38 +0000 (17:07 +0000)]
Type hierarchy view for Analysis Server.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//575983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40380 260f80e4-7a28-3924-810f-c04153c831b5

5 hours agoUpdate images to work with Trusty
messick@google.com [Wed, 17 Sep 2014 16:29:57 +0000 (16:29 +0000)]
Update images to work with Trusty

R=danrubel@google.com, jwren@google.com

Review URL: https://codereview.chromium.org//575063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40379 260f80e4-7a28-3924-810f-c04153c831b5

7 hours agoRevert "Use ConstExp for storing constants."
sigurdm@google.com [Wed, 17 Sep 2014 14:19:45 +0000 (14:19 +0000)]
Revert "Use ConstExp for storing constants."

This reverts commit r40372.

Revert "Fix handling of native annotations."

This reverts commit r40374

R=herhut@google.com

Review URL: https://codereview.chromium.org//563863004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40376 260f80e4-7a28-3924-810f-c04153c831b5

8 hours agoInitial steps towards cleaning up integer arithmetic IR.
vegorov@google.com [Wed, 17 Sep 2014 13:31:13 +0000 (13:31 +0000)]
Initial steps towards cleaning up integer arithmetic IR.

Introduce base classes for binary and unary integer operations and move all shared logic (e.g. canonicalization) into these classes.

Start removing special cases dispatch from instructions patterns - it goes into Canonicalization pass.

Start removing duplication between instruction patterns where meaningful and possible.

Cleanup the notion of truncation in the operations: is_truncating implies !can_overflow, not the other way around.

BUG=
R=johnmccutchan@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//564843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40375 260f80e4-7a28-3924-810f-c04153c831b5

8 hours agoFix handling of native annotations.
johnniwinther@google.com [Wed, 17 Sep 2014 13:13:58 +0000 (13:13 +0000)]
Fix handling of native annotations.

BUG=

Review URL: https://codereview.chromium.org//546683004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40374 260f80e4-7a28-3924-810f-c04153c831b5

8 hours agoAdd argument error for int.parse(null).
lrn@google.com [Wed, 17 Sep 2014 12:51:20 +0000 (12:51 +0000)]
Add argument error for int.parse(null).

Slightly tweak _tryParseSmi to generate slightly less code.

BUG= http://dartbug.com/17774
R=fschneider@google.com

Review URL: https://codereview.chromium.org//581593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40373 260f80e4-7a28-3924-810f-c04153c831b5

8 hours agoUse ConstExp for storing constants.
johnniwinther@google.com [Wed, 17 Sep 2014 12:38:52 +0000 (12:38 +0000)]
Use ConstExp for storing constants.

Main modification in

compile_time_constants.dart
cps_ir/const_expression.dart
cps_ir/cps_ir_builder.dart

R=sigurdm@google.com

Review URL: https://codereview.chromium.org//574683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40372 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoMake dart2js deferred loading work in CSP mode.
sigurdm@google.com [Wed, 17 Sep 2014 12:22:41 +0000 (12:22 +0000)]
Make dart2js deferred loading work in CSP mode.

Still it will not work from a js-worker, because we use new Function to
evaluate the script instead of injecting a script tag.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//569583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40371 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoDart2dart new backend support for getters and setters.
sigurdm@google.com [Wed, 17 Sep 2014 11:46:20 +0000 (11:46 +0000)]
Dart2dart new backend support for getters and setters.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//573953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40370 260f80e4-7a28-3924-810f-c04153c831b5

12 hours agoInstead of special casing one-element interpolations, just generate a static call...
lrn@google.com [Wed, 17 Sep 2014 09:32:07 +0000 (09:32 +0000)]
Instead of special casing one-element interpolations, just generate a static call to _interpolateSingle directly in the IL.

R=fschneider@google.com

Committed: https://code.google.com/p/dart/source/detail?r=40367

Review URL: https://codereview.chromium.org//570133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40369 260f80e4-7a28-3924-810f-c04153c831b5

12 hours agoRevert r40367.
lrn@google.com [Wed, 17 Sep 2014 08:44:51 +0000 (08:44 +0000)]
Revert r40367.

Crashes in debug-mode.

Review URL: https://codereview.chromium.org//567393005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40368 260f80e4-7a28-3924-810f-c04153c831b5

13 hours agoInstead of special casing one-element interpolations, just generate a static call...
lrn@google.com [Wed, 17 Sep 2014 07:38:30 +0000 (07:38 +0000)]
Instead of special casing one-element interpolations, just generate a static call to _interpolateSingle directly in the IL.

R=fschneider@google.com

Review URL: https://codereview.chromium.org//570133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40367 260f80e4-7a28-3924-810f-c04153c831b5

17 hours agoadd element to completion suggestions
danrubel@google.com [Wed, 17 Sep 2014 03:50:46 +0000 (03:50 +0000)]
add element to completion suggestions
suggest getter rather than field element
add test for function suggestions

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//580623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40366 260f80e4-7a28-3924-810f-c04153c831b5

19 hours agoEstimate quotient digit in Bigint division using an integer division instead of
regis@google.com [Wed, 17 Sep 2014 01:44:34 +0000 (01:44 +0000)]
Estimate quotient digit in Bigint division using an integer division instead of
a floating point division.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//574213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40365 260f80e4-7a28-3924-810f-c04153c831b5

22 hours agoMake is-check type-propagation closer to spec and better for union types.
collinsn@google.com [Tue, 16 Sep 2014 23:28:40 +0000 (23:28 +0000)]
Make is-check type-propagation closer to spec and better for union types.

Discussion from comments:

    // If we aren't allowing precision loss then the third and fourth conditions check that we
    // aren't losing precision.
    //
    // Let [C] be the current type and [P] be the potential type.  When we aren't allowing
    // precision loss -- which is the case for is-checks -- we check that [! (C << P)] or  [P << C].
    // The second check, that [P << C], is analogous to part of the Dart Language Spec rule
    // for type promotion under is-checks (in the analogy [T] is [P] and [S] is [C]):
    //
    //   An is-expression of the form [v is T] shows that [v] has type [T] iff [T] is more
    //   specific than the type [S] of the expression [v] and both [T != dynamic] and
    //   [S != dynamic].
    //
    // It also covers an important case that is not applicable in the spec: for union types, we
    // want an is-check to promote from an union type to (a subtype of) any of its members.
    //
    // The first check, that [! (C << P)], covers the case where [P] and [C] are unrelated types;
    // This case is not addressed in the spec for static types.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//560063004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40363 260f80e4-7a28-3924-810f-c04153c831b5

22 hours agoconvert engine element setter to completion element setter
danrubel@google.com [Tue, 16 Sep 2014 23:21:57 +0000 (23:21 +0000)]
convert engine element setter to completion element setter

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//578673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40362 260f80e4-7a28-3924-810f-c04153c831b5

22 hours agoadd element to completion suggestion API
danrubel@google.com [Tue, 16 Sep 2014 23:17:24 +0000 (23:17 +0000)]
add element to completion suggestion API

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//572373004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40360 260f80e4-7a28-3924-810f-c04153c831b5

22 hours agoFix x64 patching of asllocation stub: the pool pointer must be set-up before patching...
srdjan@google.com [Tue, 16 Sep 2014 23:14:54 +0000 (23:14 +0000)]
Fix x64 patching of asllocation stub: the pool pointer must be set-up before patching jump is executed.

R=koda@google.com, zra@google.com

Review URL: https://codereview.chromium.org//574843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40358 260f80e4-7a28-3924-810f-c04153c831b5

22 hours agoFix compiler warning:
asiva@google.com [Tue, 16 Sep 2014 22:50:46 +0000 (22:50 +0000)]
Fix compiler warning:

[209/7854] CXX obj/dart/runtime/vm/libdart_vm.intermediate_language.o

../../dart/runtime/vm/intermediate_language.cc:1777:45: warning: implicit conversion of NULL constant to 'intptr_t' (aka 'long') [-Wnull-conversion]

        to() == kUnboxedInt32 ? deopt_id_ : NULL);

R=vegorov@google.com

Review URL: https://codereview.chromium.org//578533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40355 260f80e4-7a28-3924-810f-c04153c831b5

23 hours agoRedefine union-type subtyping to be more permissive.
collinsn@google.com [Tue, 16 Sep 2014 21:51:14 +0000 (21:51 +0000)]
Redefine union-type subtyping to be more permissive.

Here "permissive" is a euphemism for "unsound". However, since our
type analyses are sound rather than complete, the less permissive
notion of union-type subtyping could in theory lead to hints
where the user knows their code is correct.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//578643004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40352 260f80e4-7a28-3924-810f-c04153c831b5

24 hours agoSkip vm standalone tests failing for drt runtime as well.
regis@google.com [Tue, 16 Sep 2014 21:13:33 +0000 (21:13 +0000)]
Skip vm standalone tests failing for drt runtime as well.

R=vsm@google.com

Review URL: https://codereview.chromium.org//573043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40347 260f80e4-7a28-3924-810f-c04153c831b5

26 hours agoAdd support for status context with Analysis Server.
scheglov@google.com [Tue, 16 Sep 2014 19:33:26 +0000 (19:33 +0000)]
Add support for status context with Analysis Server.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//565563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40341 260f80e4-7a28-3924-810f-c04153c831b5

27 hours agoTemporarily add a public modPow method to int interface.
regis@google.com [Tue, 16 Sep 2014 18:19:12 +0000 (18:19 +0000)]
Temporarily add a public modPow method to int interface.
Make Bigint modPow support non-bigint arguments.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//570563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40335 260f80e4-7a28-3924-810f-c04153c831b5

27 hours agoAdd tools/ddbg_service.
turnidge@google.com [Tue, 16 Sep 2014 18:16:28 +0000 (18:16 +0000)]
Add tools/ddbg_service.

This is the directory where we will work on a version of ddbg that
uses the vm service.

Not yet functional.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//575853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40334 260f80e4-7a28-3924-810f-c04153c831b5

27 hours agoSend final problems even if 'validateOnly'.
scheglov@google.com [Tue, 16 Sep 2014 17:48:19 +0000 (17:48 +0000)]
Send final problems even if 'validateOnly'.

Also fix for reporting duplicate 'Rename Local' shadowing warnings.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//576703004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40332 260f80e4-7a28-3924-810f-c04153c831b5

28 hours agoTemporary disable stress testing in crashing test.
srdjan@google.com [Tue, 16 Sep 2014 17:20:16 +0000 (17:20 +0000)]
Temporary disable stress testing in crashing test.

Review URL: https://codereview.chromium.org//577673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40330 260f80e4-7a28-3924-810f-c04153c831b5

28 hours agoAdd SourceFileEdit.time field.
scheglov@google.com [Tue, 16 Sep 2014 17:19:37 +0000 (17:19 +0000)]
Add SourceFileEdit.time field.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//574573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40329 260f80e4-7a28-3924-810f-c04153c831b5

28 hours agoFix to allocation stub invalidation: we cannot just remove it as it will be collected...
srdjan@google.com [Tue, 16 Sep 2014 17:01:17 +0000 (17:01 +0000)]
Fix to allocation stub invalidation: we cannot just remove it as it will be collected even though code still may reference it. Since we should probably have two different allocation stubs, keep two in the class and switch between them. Future work will put intelligence in the allocation stub selection. Added Daniel's test flag & code.

R=koda@google.com

Review URL: https://codereview.chromium.org//566853005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40327 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoRollback https://codereview.chromium.org/575613002
scheglov@google.com [Tue, 16 Sep 2014 16:31:52 +0000 (16:31 +0000)]
Rollback https://codereview.chromium.org/575613002

I'm sorry, but I'm going to rollback this change.
We discussed this offline with Brian and decided that while it looks
technically correct, it does not work well for our use cases, as well as
probably for our users.

R=paulberry@google.com, brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19697

Review URL: https://codereview.chromium.org//560133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40324 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoEliminate 99% of allocated ExceptionHandler objects
hausner@google.com [Tue, 16 Sep 2014 16:27:04 +0000 (16:27 +0000)]
Eliminate 99% of allocated ExceptionHandler objects

The vast majority of functions have no exception handlers, thus they can all
share a single ExceptionHandler descriptor.

This CL reduces the number of ExceptionHandler objects on the heap from
about 8400 to 16, from 132KB to less than 1KB, when running dart2js.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//575663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40323 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoupdate allPhases tests
jakemac@google.com [Tue, 16 Sep 2014 15:41:41 +0000 (15:41 +0000)]
update allPhases tests

make everything get inlined inside a hidden div to prevent FOUC

only check for FOUC in entry point

BUG= http://dartbug.com/20943
R=sigmund@google.com

Review URL: https://codereview.chromium.org//575503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40320 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoSplit refactoring problems into init, options and final.
scheglov@google.com [Tue, 16 Sep 2014 15:14:51 +0000 (15:14 +0000)]
Split refactoring problems into init, options and final.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//576473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40318 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoMove diff.dart to dart2js_incremental.
ahe@google.com [Tue, 16 Sep 2014 13:45:48 +0000 (13:45 +0000)]
Move diff.dart to dart2js_incremental.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//568363004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40317 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoAdd makefile to run analyzer.
ahe@google.com [Tue, 16 Sep 2014 12:41:17 +0000 (12:41 +0000)]
Add makefile to run analyzer.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//567423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40316 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoUpdate assertion to incremental compilation.
ahe@google.com [Tue, 16 Sep 2014 12:29:52 +0000 (12:29 +0000)]
Update assertion to incremental compilation.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//566353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40315 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoAdd ElementX.declarationSite.
ahe@google.com [Tue, 16 Sep 2014 12:23:31 +0000 (12:23 +0000)]
Add ElementX.declarationSite.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//561233005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40314 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoRevert "Handle implicitly hidden exports."
johnniwinther@google.com [Tue, 16 Sep 2014 12:17:28 +0000 (12:17 +0000)]
Revert "Handle implicitly hidden exports."

This reverts commit r40310.

BUG=

Review URL: https://codereview.chromium.org//572153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40313 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoRevert r40306 because of crash.
fschneider@google.com [Tue, 16 Sep 2014 12:14:33 +0000 (12:14 +0000)]
Revert r40306 because of crash.

TBR=vegorov@google.com

Review URL: https://codereview.chromium.org//572913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40312 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoAdd LibraryLoader.resetAsync.
ahe@google.com [Tue, 16 Sep 2014 11:15:06 +0000 (11:15 +0000)]
Add LibraryLoader.resetAsync.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//564373004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40311 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoHandle implicitly hidden exports.
johnniwinther@google.com [Tue, 16 Sep 2014 11:13:56 +0000 (11:13 +0000)]
Handle implicitly hidden exports.

BUG=http://dartbug.com/20935
R=karlklose@google.com

Review URL: https://codereview.chromium.org//564403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40310 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoUpdate co19 webgl test status on Android content-shell.
whesse@google.com [Tue, 16 Sep 2014 11:10:27 +0000 (11:10 +0000)]
Update co19 webgl test status on Android content-shell.

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//574693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40309 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoAdd error-intercept for Completer.completeError and StreamController.addError.
lrn@google.com [Tue, 16 Sep 2014 10:51:01 +0000 (10:51 +0000)]
Add error-intercept for Completer.completeError and StreamController.addError.

BUG= http://dartbug.com/15105
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//555153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40308 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoImplements for-in in the CPS-ir builder.
sigurdm@google.com [Tue, 16 Sep 2014 10:40:24 +0000 (10:40 +0000)]
Implements for-in in the CPS-ir builder.

Most of the code for while is duplicated - and very similar to regular
for-loops. We might be able to extract the common parts.
That is left for later.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//537933004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40307 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoRefactor generating lazy deoptimization descriptors.
fschneider@google.com [Tue, 16 Sep 2014 10:31:47 +0000 (10:31 +0000)]
Refactor generating lazy deoptimization descriptors.

Instead of having special handling for closure calls, pass
the number of input operands down so that the correct lazy
deoptimization environment is generated at calls.

There is no functional change here - this is to simplify
having calls with pushed arguments and input operands
(like closure calls).

Runtime calls still do not have a correct lazy deoptimization environment
the environment should only be used for creating stack traces
from optimized code.

Fix a bug with --trace-deoptimization-verbose printing: We
cannot call ToCString on objects when the slots have not
been filled in yet. (e.g. Closures)

R=vegorov@google.com

Review URL: https://codereview.chromium.org//575443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40306 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoAvoid copy-propagating function declarations in the new dart backend.
sigurdm@google.com [Tue, 16 Sep 2014 10:07:29 +0000 (10:07 +0000)]
Avoid copy-propagating function declarations in the new dart backend.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//576723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40305 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoReplace unneeded giveup with assert in cps_ir_builder.
sigurdm@google.com [Tue, 16 Sep 2014 09:26:12 +0000 (09:26 +0000)]
Replace unneeded giveup with assert in cps_ir_builder.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//558583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40304 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoCount children of throw statements for inlining decisions.
herhut@google.com [Tue, 16 Sep 2014 08:23:45 +0000 (08:23 +0000)]
Count children of throw statements for inlining decisions.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//569223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40303 260f80e4-7a28-3924-810f-c04153c831b5

39 hours agoRevert "try again to not auto start editor port"
sethladd@google.com [Tue, 16 Sep 2014 05:39:29 +0000 (05:39 +0000)]
Revert "try again to not auto start editor port"

This reverts commit 043c5de2d213a3f3dd9c9b023eb42e1badefb8f0.

BUG=

Review URL: https://codereview.chromium.org//575733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40301 260f80e4-7a28-3924-810f-c04153c831b5

42 hours agotry again to not auto start editor port
sethladd@google.com [Tue, 16 Sep 2014 02:42:24 +0000 (02:42 +0000)]
try again to not auto start editor port

BUG=

Review URL: https://codereview.chromium.org//577513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40300 260f80e4-7a28-3924-810f-c04153c831b5

43 hours agoRevert "only run the admin server if admin-port is specified"
sethladd@google.com [Tue, 16 Sep 2014 02:13:13 +0000 (02:13 +0000)]
Revert "only run the admin server if admin-port is specified"

This reverts commit 9ed84a9d820a57132d915cd069b47b33ed6f5631.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//565813004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40299 260f80e4-7a28-3924-810f-c04153c831b5

43 hours agoIssue 17389. Analyzer snapshot and server tweaks to use new ParameterElement.defaultV...
scheglov@google.com [Tue, 16 Sep 2014 01:46:27 +0000 (01:46 +0000)]
Issue 17389. Analyzer snapshot and server tweaks to use new ParameterElement.defaultValueCode.

This also makes Analysis Server to return hovers with parameter default values.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=17389

Review URL: https://codereview.chromium.org//564413005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40298 260f80e4-7a28-3924-810f-c04153c831b5

44 hours agoWIP: fix Issue 20904
collinsn@google.com [Tue, 16 Sep 2014 00:52:24 +0000 (00:52 +0000)]
WIP: fix Issue 20904

This does fix the issue, but it breaks some tests that I don't
understand. Please take a look. The tests are

  SimpleResolverTest.test_argumentResolution_setter_static
  SimpleResolverTest.test_argumentResolution_setter_static_propertyAccess

and the problem is that a propagated parameter element (?) goes from
[null] to [dynamic].

https://code.google.com/p/dart/issues/detail?id=20904

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//557433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40296 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agoonly run the admin server if admin-port is specified
sethladd@google.com [Tue, 16 Sep 2014 00:21:50 +0000 (00:21 +0000)]
only run the admin server if admin-port is specified

BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//571633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40293 260f80e4-7a28-3924-810f-c04153c831b5

46 hours agoIssue 19697. Partial fix - don't search for subclasss members.
scheglov@google.com [Mon, 15 Sep 2014 23:34:15 +0000 (23:34 +0000)]
Issue 19697. Partial fix - don't search for subclasss members.

I think it still worth to commit this CL, if nothing else,
it makes search a little faster by not searching for subclasses.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19697

Review URL: https://codereview.chromium.org//575613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40290 260f80e4-7a28-3924-810f-c04153c831b5

46 hours agono longer require entry points to be specified in the build.dart file
jakemac@google.com [Mon, 15 Sep 2014 22:59:11 +0000 (22:59 +0000)]
no longer require entry points to be specified in the build.dart file

BUG= http://dartbug.com/20396
R=sigmund@google.com

Review URL: https://codereview.chromium.org//569393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40286 260f80e4-7a28-3924-810f-c04153c831b5

46 hours agofix DartReconcilingStrategy NPE
danrubel@google.com [Mon, 15 Sep 2014 22:54:49 +0000 (22:54 +0000)]
fix DartReconcilingStrategy NPE

BUG=
R=jwren@google.com

Review URL: https://codereview.chromium.org//548223004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40285 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoupdate tests to use error message templates everywhere instead of hardcoded values
jakemac@google.com [Mon, 15 Sep 2014 22:21:21 +0000 (22:21 +0000)]
update tests to use error message templates everywhere instead of hardcoded values

BUG= http://dartbug.com/20959
R=sigmund@google.com

Review URL: https://codereview.chromium.org//569403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40283 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoRestore analyzing lib/_internal with Dart-based analyzer.
scheglov@google.com [Mon, 15 Sep 2014 21:45:17 +0000 (21:45 +0000)]
Restore analyzing lib/_internal with Dart-based analyzer.

It adds 8+ minutes (to the current 4) to the analysis time, but does not timeout anymore.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//575573002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40280 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoBump multivm DEPS
rmacnak@google.com [Mon, 15 Sep 2014 21:36:18 +0000 (21:36 +0000)]
Bump multivm DEPS

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40277 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoSave more memory by compacting LocalVarDescriptors
hausner@google.com [Mon, 15 Sep 2014 21:34:58 +0000 (21:34 +0000)]
Save more memory by compacting LocalVarDescriptors

(Re-landing this change after assertions fixed.)

Instead of allocating an array for the names of local variables,
store the names in the LocalVarDescriptors structure directly.

Using dart2js to compile a small dart program results in about 7200
LVDs on the heap.

Retained memory before: 568KB
Retained memory after: 432KB (75%)

R=asiva@google.com

Review URL: https://codereview.chromium.org//577443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40276 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoCleanup and refactoring in DartCore.java, after change 573813002
jwren@google.com [Mon, 15 Sep 2014 20:33:39 +0000 (20:33 +0000)]
Cleanup and refactoring in DartCore.java, after change 573813002

R=scheglov@google.com

Review URL: https://codereview.chromium.org//574533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40274 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoSkip compilation of signature classes.
asiva@google.com [Mon, 15 Sep 2014 20:25:19 +0000 (20:25 +0000)]
Skip compilation of signature classes.

R=regis@google.com

Review URL: https://codereview.chromium.org//569313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40273 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoTemporarily add a public modPow method to _Bigint class.
regis@google.com [Mon, 15 Sep 2014 19:29:15 +0000 (19:29 +0000)]
Temporarily add a public modPow method to _Bigint class.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//567093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40271 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRestore hyperlink navigation with Analysis Server.
scheglov@google.com [Mon, 15 Sep 2014 19:12:52 +0000 (19:12 +0000)]
Restore hyperlink navigation with Analysis Server.

R=jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//575583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40269 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoUse the snapshot version of the analysis server.
jwren@google.com [Mon, 15 Sep 2014 19:08:02 +0000 (19:08 +0000)]
Use the snapshot version of the analysis server.
Remove the integration tests from the com.google.dart.server_test

R=scheglov@google.com

Review URL: https://codereview.chromium.org//573813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40267 260f80e4-7a28-3924-810f-c04153c831b5

2 days agofix for dartbug.com/19222
keertip@google.com [Mon, 15 Sep 2014 18:39:28 +0000 (18:39 +0000)]
fix for dartbug.com/19222

R=scheglov@google.com

Review URL: https://codereview.chromium.org//575543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40265 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDo not navigate to vm-connect page upon disconnect
johnmccutchan@google.com [Mon, 15 Sep 2014 18:19:48 +0000 (18:19 +0000)]
Do not navigate to vm-connect page upon disconnect

Also, prompt the user when they click a link when we hvae no connection

BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//558703005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40262 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 18926. Rename refactoring for labels.
scheglov@google.com [Mon, 15 Sep 2014 17:48:09 +0000 (17:48 +0000)]
Issue 18926. Rename refactoring for labels.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=18926

Review URL: https://codereview.chromium.org//573803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40259 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoadd breadcrumbs to error messages page
jakemac@google.com [Mon, 15 Sep 2014 17:31:48 +0000 (17:31 +0000)]
add breadcrumbs to error messages page

BUG= http://dartbug.com/20950
R=sigmund@google.com

Review URL: https://codereview.chromium.org//560933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40257 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd PKGTestSuite that will be used for package waterfall testers.
ricow@google.com [Mon, 15 Sep 2014 17:16:35 +0000 (17:16 +0000)]
Add PKGTestSuite that will be used for package waterfall testers.

This is based on the standard test suite but we specialcase html files.

There is another html file aproach currently being done by whesse@ that we may be able to utilize when it is done instead.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//567803004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40255 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoSearch for LabelElement and icon for LABEL in Editor.
scheglov@google.com [Mon, 15 Sep 2014 17:03:35 +0000 (17:03 +0000)]
Search for LabelElement and icon for LABEL in Editor.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//576443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40254 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoSemantic highlighting for LABEL elements.
scheglov@google.com [Mon, 15 Sep 2014 16:41:09 +0000 (16:41 +0000)]
Semantic highlighting for LABEL elements.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//559353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40252 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 18895. Convert an expression function body into the block function body when...
scheglov@google.com [Mon, 15 Sep 2014 15:28:31 +0000 (15:28 +0000)]
Issue 18895. Convert an expression function body into the block function body when Extract Local.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=18895

Review URL: https://codereview.chromium.org//568333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40250 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 19696. Test for potential reference to the element defined in a subclass.
scheglov@google.com [Mon, 15 Sep 2014 15:07:08 +0000 (15:07 +0000)]
Issue 19696. Test for potential reference to the element defined in a subclass.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=19696

Review URL: https://codereview.chromium.org//567243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40248 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd LABEL ElementKind, completion and highlighting kinds.
scheglov@google.com [Mon, 15 Sep 2014 15:04:52 +0000 (15:04 +0000)]
Add LABEL ElementKind, completion and highlighting kinds.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//567273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40247 260f80e4-7a28-3924-810f-c04153c831b5

2 days agopkg/docgen: include all package libraries under lib/, except those under lib/src
kevmoo@google.com [Mon, 15 Sep 2014 15:04:20 +0000 (15:04 +0000)]
pkg/docgen: include all package libraries under lib/, except those under lib/src

Also updated package dependencies

BUG= https://code.google.com/p/dart/issues/detail?id=18554
R=alanknight@google.com

Review URL: https://codereview.chromium.org//571713002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40246 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoSupport for searching LabelElements in SearchEngine.
scheglov@google.com [Mon, 15 Sep 2014 15:03:01 +0000 (15:03 +0000)]
Support for searching LabelElements in SearchEngine.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//567653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40245 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 17389. Remember Dart code of default values of parameters.
scheglov@google.com [Mon, 15 Sep 2014 14:57:24 +0000 (14:57 +0000)]
Issue 17389. Remember Dart code of default values of parameters.

...and use them in ParameterElementImpl.appendToWithoutDelimiters(), so show them in hover.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=17389

Review URL: https://codereview.chromium.org//566243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40243 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 13029. Quick fix to create a function for a Function typed named parameter.
scheglov@google.com [Mon, 15 Sep 2014 14:53:06 +0000 (14:53 +0000)]
Issue 13029. Quick fix to create a function for a Function typed named parameter.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=13029

Review URL: https://codereview.chromium.org//565023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40242 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 20892. Quick Fix 'Import Library' for type arguments.
scheglov@google.com [Mon, 15 Sep 2014 14:50:38 +0000 (14:50 +0000)]
Issue 20892. Quick Fix 'Import Library' for type arguments.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20892

Review URL: https://codereview.chromium.org//556793007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40241 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 20358. Don't report referenced names of named parameters in named expressions...
scheglov@google.com [Mon, 15 Sep 2014 14:48:36 +0000 (14:48 +0000)]
Issue 20358. Don't report referenced names of named parameters in named expressions as possible shadowing.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20358

Review URL: https://codereview.chromium.org//567083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40240 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoUpdate status for android content_shell flaky test
whesse@google.com [Mon, 15 Sep 2014 13:06:17 +0000 (13:06 +0000)]
Update status for android content_shell flaky test

BUG=dartbug.com/20956
R=ricow@google.com

Review URL: https://codereview.chromium.org//575433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40239 260f80e4-7a28-3924-810f-c04153c831b5

2 days agofix code completion import dart exception
danrubel@google.com [Mon, 15 Sep 2014 12:41:41 +0000 (12:41 +0000)]
fix code completion import dart exception

BUG=dartbug.com/20893
R=paulberry@google.com

Review URL: https://codereview.chromium.org//565793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40238 260f80e4-7a28-3924-810f-c04153c831b5