external/dart/bleeding_edge.git
2 hours agoTest editor double clicking int DartDoc comments master
messick@google.com [Fri, 22 Aug 2014 23:26:20 +0000 (23:26 +0000)]
Test editor double clicking int DartDoc comments

Apparently, functional testing tools are not intended for testing text
editors. The amount of work it took to simply produce a double-click
in text was just silly.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//486153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39506 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoBUG=
tyoverby@google.com [Fri, 22 Aug 2014 23:25:45 +0000 (23:25 +0000)]
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//490323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39505 260f80e4-7a28-3924-810f-c04153c831b5

4 hours agoAttempt to reduce Dartium debug bot redness.
rmacnak@google.com [Fri, 22 Aug 2014 20:49:42 +0000 (20:49 +0000)]
Attempt to reduce Dartium debug bot redness.

R=asiva@google.com

Review URL: https://codereview.chromium.org//502603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39504 260f80e4-7a28-3924-810f-c04153c831b5

5 hours agoAdd default style to new Polymer elements.
dgrove@google.com [Fri, 22 Aug 2014 20:22:35 +0000 (20:22 +0000)]
Add default style to new Polymer elements.

BUG=20598 .
R=sigmund@google.com

Review URL: https://codereview.chromium.org//497813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39503 260f80e4-7a28-3924-810f-c04153c831b5

5 hours agoCautionary tale about optimizing path manipulation.
rnystrom@google.com [Fri, 22 Aug 2014 19:50:33 +0000 (19:50 +0000)]
Cautionary tale about optimizing path manipulation.

BUG=https://code.google.com/p/dart/issues/detail?id=20628
R=nweiz@google.com

Review URL: https://codereview.chromium.org//485893008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39502 260f80e4-7a28-3924-810f-c04153c831b5

7 hours agoUpdate Intl to version 0.11.5
alanknight@google.com [Fri, 22 Aug 2014 17:33:45 +0000 (17:33 +0000)]
Update Intl to version 0.11.5

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//496213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39501 260f80e4-7a28-3924-810f-c04153c831b5

8 hours agoNew analyzer snapshot.
scheglov@google.com [Fri, 22 Aug 2014 17:28:29 +0000 (17:28 +0000)]
New analyzer snapshot.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//492463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39500 260f80e4-7a28-3924-810f-c04153c831b5

8 hours agoMove Location factories and RefactoringProblemSeverity.max into the generated classes.
scheglov@google.com [Fri, 22 Aug 2014 17:27:19 +0000 (17:27 +0000)]
Move Location factories and RefactoringProblemSeverity.max into the generated classes.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//462403005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39499 260f80e4-7a28-3924-810f-c04153c831b5

8 hours agoFix incremental compilation.
johnniwinther@google.com [Fri, 22 Aug 2014 17:11:18 +0000 (17:11 +0000)]
Fix incremental compilation.

BUG=

Review URL: https://codereview.chromium.org//502523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39498 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoIssue 20637. Don't insert extra semicolons for FunctionDeclarationStatement.
scheglov@google.com [Fri, 22 Aug 2014 16:24:26 +0000 (16:24 +0000)]
Issue 20637. Don't insert extra semicolons for FunctionDeclarationStatement.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20637

Review URL: https://codereview.chromium.org//488923005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39497 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agoAdd Output units.
floitsch@google.com [Fri, 22 Aug 2014 15:23:02 +0000 (15:23 +0000)]
Add Output units.

Deferred code is not working yet.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//496083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39496 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agoRename 'getRefactoring.return.status' to 'problems'.
scheglov@google.com [Fri, 22 Aug 2014 14:47:30 +0000 (14:47 +0000)]
Rename 'getRefactoring.return.status' to 'problems'.

It is a list, and we name lists with plurals.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//495273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39495 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agoMake RefactoringStatus a collection of generated RefactoringProblems.
scheglov@google.com [Fri, 22 Aug 2014 14:45:33 +0000 (14:45 +0000)]
Make RefactoringStatus a collection of generated RefactoringProblems.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//485083004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39494 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agoUse World instead of Compiler in Selector.
johnniwinther@google.com [Fri, 22 Aug 2014 14:40:04 +0000 (14:40 +0000)]
Use World instead of Compiler in Selector.

BUG=
R=herhut@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39079

Review URL: https://codereview.chromium.org//442843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39493 260f80e4-7a28-3924-810f-c04153c831b5

12 hours agoReduce reliance on Compiler.
johnniwinther@google.com [Fri, 22 Aug 2014 13:10:23 +0000 (13:10 +0000)]
Reduce reliance on Compiler.

BUG=
R=herhut@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39077

Reverted: https://code.google.com/p/dart/source/detail?r=39086

Review URL: https://codereview.chromium.org//451703003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39492 260f80e4-7a28-3924-810f-c04153c831b5

13 hours agoFix tests to work with new TypeMask interface.
herhut@google.com [Fri, 22 Aug 2014 11:59:18 +0000 (11:59 +0000)]
Fix tests to work with new TypeMask interface.

BUG=
TBR=karlklose@google.com

Review URL: https://codereview.chromium.org//474773004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39491 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoAdd optional startIndex to String.replaceFirst
lrn@google.com [Fri, 22 Aug 2014 11:27:32 +0000 (11:27 +0000)]
Add optional startIndex to String.replaceFirst

BUG= https://code.google.com/p/dart/issues/detail?id=3194
R=lrn@google.com

Review URL: https://codereview.chromium.org//462463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39490 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoMake toString of UnionTypeMask stable.
herhut@google.com [Fri, 22 Aug 2014 11:18:40 +0000 (11:18 +0000)]
Make toString of UnionTypeMask stable.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//495043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39489 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoEnsure TypeMasks are always normalized to the most constraining kind.
herhut@google.com [Fri, 22 Aug 2014 11:09:46 +0000 (11:09 +0000)]
Ensure TypeMasks are always normalized to the most constraining kind.

BUG=
R=floitsch@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//483743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39488 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoMark tests as Pass, Fail for IE11.
karlklose@google.com [Fri, 22 Aug 2014 11:05:05 +0000 (11:05 +0000)]
Mark tests as Pass, Fail for IE11.

BUG= http://dartbug.com/20659
R=whesse@google.com

Review URL: https://codereview.chromium.org//485293004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39487 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoUpdate pub barback dependency to allow 0.15.1-dev.
lrn@google.com [Fri, 22 Aug 2014 11:02:20 +0000 (11:02 +0000)]
Update pub barback dependency to allow 0.15.1-dev.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//497703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39486 260f80e4-7a28-3924-810f-c04153c831b5

16 hours agoUpdate ie11 test expectations.
karlklose@google.com [Fri, 22 Aug 2014 08:56:33 +0000 (08:56 +0000)]
Update ie11 test expectations.

BUG= http://dartbug.com/20657
R=whesse@google.com

Review URL: https://codereview.chromium.org//498673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39485 260f80e4-7a28-3924-810f-c04153c831b5

16 hours agoUpdate dart:collection to version 1.0.0
lrn@google.com [Fri, 22 Aug 2014 08:52:09 +0000 (08:52 +0000)]
Update dart:collection to version 1.0.0

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//463333004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39484 260f80e4-7a28-3924-810f-c04153c831b5

17 hours agoAddress hints in dart2js source code.
karlklose@google.com [Fri, 22 Aug 2014 08:31:51 +0000 (08:31 +0000)]
Address hints in dart2js source code.

R=sigurdm@google.com

Review URL: https://codereview.chromium.org//500473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39483 260f80e4-7a28-3924-810f-c04153c831b5

18 hours agoremove unused SourceFileElement and related classes and methods
danrubel@google.com [Fri, 22 Aug 2014 06:44:26 +0000 (06:44 +0000)]
remove unused SourceFileElement and related classes and methods

BUG=
R=jwren@google.com, messick@google.com

Review URL: https://codereview.chromium.org//493623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39482 260f80e4-7a28-3924-810f-c04153c831b5

22 hours agoInitial factory constructors for generated objects in Java server.
jwren@google.com [Fri, 22 Aug 2014 03:33:08 +0000 (03:33 +0000)]
Initial factory constructors for generated objects in Java server.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//488413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39481 260f80e4-7a28-3924-810f-c04153c831b5

25 hours agoRemove usage of petitparser methods that have moved
alanknight@google.com [Fri, 22 Aug 2014 00:07:14 +0000 (00:07 +0000)]
Remove usage of petitparser methods that have moved

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//497603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39480 260f80e4-7a28-3924-810f-c04153c831b5

25 hours agoPrecreate handles for the key object and smi values and use these
asiva@google.com [Thu, 21 Aug 2014 23:57:48 +0000 (23:57 +0000)]
Precreate handles for the key object and smi values and use these
handles in the find and insert methods instead of allocating a new
handle each time.

R=koda@google.com

Review URL: https://codereview.chromium.org//497623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39479 260f80e4-7a28-3924-810f-c04153c831b5

25 hours agoIse precreated handles to read and store type arguments of an array.
asiva@google.com [Thu, 21 Aug 2014 23:57:16 +0000 (23:57 +0000)]
Ise precreated handles to read and store type arguments of an array.

R=regis@google.com

Review URL: https://codereview.chromium.org//493173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39478 260f80e4-7a28-3924-810f-c04153c831b5

26 hours agoFix performance degradation in Havlak: prevent conflicting method recognizer kinds...
srdjan@google.com [Thu, 21 Aug 2014 22:37:47 +0000 (22:37 +0000)]
Fix performance degradation in Havlak: prevent conflicting method recognizer kinds to be stored in the function.

Review URL: https://codereview.chromium.org//497623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39477 260f80e4-7a28-3924-810f-c04153c831b5

27 hours agoMake RefactoringProblem.location optional.
scheglov@google.com [Thu, 21 Aug 2014 21:44:08 +0000 (21:44 +0000)]
Make RefactoringProblem.location optional.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//496113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39476 260f80e4-7a28-3924-810f-c04153c831b5

27 hours agoImprove Float64x2 constructor code and keep unboxed across phis
johnmccutchan@google.com [Thu, 21 Aug 2014 21:43:40 +0000 (21:43 +0000)]
Improve Float64x2 constructor code and keep unboxed across phis

BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//489273003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39475 260f80e4-7a28-3924-810f-c04153c831b5

28 hours agoRename 'kindId' to 'kind' in 'edit.getRefactoring'.
scheglov@google.com [Thu, 21 Aug 2014 20:57:14 +0000 (20:57 +0000)]
Rename 'kindId' to 'kind' in 'edit.getRefactoring'.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//473763003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39474 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoRelease polymer 0.12.2+1
sigmund@google.com [Thu, 21 Aug 2014 20:22:20 +0000 (20:22 +0000)]
Release polymer 0.12.2+1

BUG=

Review URL: https://codereview.chromium.org//475833004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39473 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoHandling of the --help option was broken in new_element.dart, too.
dgrove@google.com [Thu, 21 Aug 2014 20:12:44 +0000 (20:12 +0000)]
Handling of the --help option was broken in new_element.dart, too.

Review URL: https://codereview.chromium.org//499443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39472 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoFaster IC stubs by specializing them for two-argument Smi operations (implemented...
srdjan@google.com [Thu, 21 Aug 2014 20:08:40 +0000 (20:08 +0000)]
Faster IC stubs by specializing them for two-argument Smi operations (implemented only a few for now)

R=zra@google.com

Review URL: https://codereview.chromium.org//436643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39471 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoMake more use of generated code in analysis server.
paulberry@google.com [Thu, 21 Aug 2014 20:04:06 +0000 (20:04 +0000)]
Make more use of generated code in analysis server.

The following generated classes are now used:
- Element
- Location
- Occurrences
- Outline
- OverriddenMember
- Override
- Position
- SearchResult
- SearchResultKind
- SourceFileEdit
- TypeHierarchyItem

Generated code is used to produce the responses to these requests:
- completion.getSuggestions
- search.findElementReferences
- search.findMemberDeclarations
- search.findMemberReferences
- search.findTopLevelDeclarations
- search.getTypeHierarchy

Generated code is used to handle these notifications in unit testing:
- analysis.navigation
- analysis.occurrences
- analysis.outline
- analysis.overrides
- search.results

In addition, we no longer bother to test the JSON conversion code on
AnalysisError, since it is code generated.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//479683005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39470 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoMake servePackages's contents argument saner.
nweiz@google.com [Thu, 21 Aug 2014 18:45:57 +0000 (18:45 +0000)]
Make servePackages's contents argument saner.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//488323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39469 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoAvoid calling potentially-allocating PrintJSON methods when iterating over heap.
koda@google.com [Thu, 21 Aug 2014 18:19:07 +0000 (18:19 +0000)]
Avoid calling potentially-allocating PrintJSON methods when iterating over heap.

R=iposva@google.com

Review URL: https://codereview.chromium.org//496043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39468 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoFinish initial union types implementation!
collinsn@google.com [Thu, 21 Aug 2014 18:07:58 +0000 (18:07 +0000)]
Finish initial union types implementation!

It remains only to use union types ...

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//491293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39467 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoAdd "pub global list" command to show all globally activated packages.
rnystrom@google.com [Thu, 21 Aug 2014 18:03:40 +0000 (18:03 +0000)]
Add "pub global list" command to show all globally activated packages.
Clean up global_packages.dart.

BUG=http://dartbug.com/19962
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//489823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39466 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoAdds intrinsics for array allocation and string charAt.
zra@google.com [Thu, 21 Aug 2014 17:52:41 +0000 (17:52 +0000)]
Adds intrinsics for array allocation and string charAt.

Improves performance of unoptimized code.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//490263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39465 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoBUG=
tyoverby@google.com [Thu, 21 Aug 2014 17:49:24 +0000 (17:49 +0000)]
BUG=
R=sigurdm@google.com, sra@google.com

Review URL: https://codereview.chromium.org//486313003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39464 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoMake EXTRACT_LOCAL and EXTRACT_METHOD refactorings available when there is a selection.
scheglov@google.com [Thu, 21 Aug 2014 17:43:22 +0000 (17:43 +0000)]
Make EXTRACT_LOCAL and EXTRACT_METHOD refactorings available when there is a selection.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//490923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39463 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoFix 'Add Type Annotation' QA Java implementation.
scheglov@google.com [Thu, 21 Aug 2014 17:40:26 +0000 (17:40 +0000)]
Fix 'Add Type Annotation' QA Java implementation.

It has been already fixed in Dart implementation.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//476863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39462 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoPrepare polymer 0.12.2 release
sigmund@google.com [Thu, 21 Aug 2014 17:26:18 +0000 (17:26 +0000)]
Prepare polymer 0.12.2 release

R=jakemac@google.com

Review URL: https://codereview.chromium.org//491343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39461 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoReturn only fixes for the errors on the line of the given offset.
scheglov@google.com [Thu, 21 Aug 2014 17:25:26 +0000 (17:25 +0000)]
Return only fixes for the errors on the line of the given offset.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//494153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39460 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoPrivate names are not exported, not even if the library imports itself
hausner@google.com [Thu, 21 Aug 2014 17:07:25 +0000 (17:07 +0000)]
Private names are not exported, not even if the library imports itself

Prevent access to a private name if it’s imported through a self-import.
Adding a test case.

Fixes issue 20162

R=srdjan@google.com

Review URL: https://codereview.chromium.org//489993004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39459 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoFix build.dart: sourceUrl used to be a Strnig before the change to source_span
sigmund@google.com [Thu, 21 Aug 2014 16:57:01 +0000 (16:57 +0000)]
Fix build.dart: sourceUrl used to be a Strnig before the change to source_span

R=jakemac@google.com

Review URL: https://codereview.chromium.org//489423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39458 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoFinish 'Extract Local' refactoring.
scheglov@google.com [Thu, 21 Aug 2014 16:31:39 +0000 (16:31 +0000)]
Finish 'Extract Local' refactoring.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//489413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39457 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoCorrect handling of parameters passed to main.
dgrove@google.com [Thu, 21 Aug 2014 16:13:53 +0000 (16:13 +0000)]
Correct handling of parameters passed to main.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//492303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39456 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoFix vm/cc/StaticNonNullSumCallCodegen.
vegorov@google.com [Thu, 21 Aug 2014 16:07:11 +0000 (16:07 +0000)]
Fix vm/cc/StaticNonNullSumCallCodegen.

Instead of passing null wrapped in the Smi handle use Instance handle.

We have the following behavior:

Smi::ZoneHandle().IsSmi() -> true
Smi::Cast(Smi::ZoneHandle()).Value() -> assertion failure

This kind of behavior is completely unexpected in most parts of the system.

TBR=iposva@google.com,asiva@google.com

Review URL: https://codereview.chromium.org//473913005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39455 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoimport inliner will now make sure to keep around the logs from imports
jakemac@google.com [Thu, 21 Aug 2014 15:56:56 +0000 (15:56 +0000)]
import inliner will now make sure to keep around the logs from imports

BUG= http://dartbug.com/20538
R=kevmoo@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//483403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39454 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoIntroduce convenience methods into generated analysis server classes.
paulberry@google.com [Thu, 21 Aug 2014 15:49:35 +0000 (15:49 +0000)]
Introduce convenience methods into generated analysis server classes.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//492243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39453 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoAdd help for new_entry and new_element scripts.
dgrove@google.com [Thu, 21 Aug 2014 15:24:41 +0000 (15:24 +0000)]
Add help for new_entry and new_element scripts.

Fixes Issue 20596.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//491013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39452 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoPrevent double reporting on hex, strings, and multiline strings and comments.
srawlins@google.com [Thu, 21 Aug 2014 14:51:20 +0000 (14:51 +0000)]
Prevent double reporting on hex, strings, and multiline strings and comments.

BUG= https://code.google.com/p/dart/issues/detail?id=18574
R=ahe@google.com

Review URL: https://codereview.chromium.org//340703003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39451 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoUpdate co19 status for dartium and android.
whesse@google.com [Thu, 21 Aug 2014 13:30:41 +0000 (13:30 +0000)]
Update co19 status for dartium and android.

BUG=dartbug.com/19544
R=kustermann@google.com

Review URL: https://codereview.chromium.org//489383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39450 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoOn ia32 allow powers of two and corresponding full bit masks as safe smis.
vegorov@google.com [Thu, 21 Aug 2014 12:46:43 +0000 (12:46 +0000)]
On ia32 allow powers of two and corresponding full bit masks as safe smis.

This considerably improves generated code allowing these values (commonly used in bitwise computations) to be embedded as immediates.

R=fschneider@google.com
BUG=

Review URL: https://codereview.chromium.org//490023004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39449 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoRemove unused methods.
kasperl@google.com [Thu, 21 Aug 2014 12:20:22 +0000 (12:20 +0000)]
Remove unused methods.

R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//483323006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39448 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoFirst attempt at making a new lazy emitter. Hello, World runs!
kasperl@google.com [Thu, 21 Aug 2014 11:58:12 +0000 (11:58 +0000)]
First attempt at making a new lazy emitter. Hello, World runs!

R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//489053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39447 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoImprove polymorphic inlining of int/int double/double operations.
fschneider@google.com [Thu, 21 Aug 2014 11:13:44 +0000 (11:13 +0000)]
Improve polymorphic inlining of int/int double/double operations.

I added inlining of the native Double methods _add, _sub, _mul and _div and fromInteger
and unified the method recognition of the MethodRecognizer and the Intrinsifier classes.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//484693003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39446 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoFix VM build.
fschneider@google.com [Thu, 21 Aug 2014 10:39:45 +0000 (10:39 +0000)]
Fix VM build.

Only gcc seems to support using a non-static member name in a
sizeof expression written sizeof(A::m).

Using a dereference expression instead.

Review URL: https://codereview.chromium.org//490023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39445 260f80e4-7a28-3924-810f-c04153c831b5

39 hours agoVM: Improve performance of method recognizer and unify the it with the intrinsifier.
fschneider@google.com [Thu, 21 Aug 2014 10:21:09 +0000 (10:21 +0000)]
VM: Improve performance of method recognizer and unify the it with the intrinsifier.

The method recognizer is now in a separate file and the intrinsifier uses the
same infrastructure. Each function is marked at initialization time, so that
recognizing a method is a fast operation (reading a field from the Function object)

I cleaned the symbol table from unused symbols since I had to regenerate the
binary snapshot in the repository anyway for this change.

I had to rename the methods that are duplicated between the recognized method list
and the intrinsics list to match the naming convention used by the method recognizer.
I left the other intrinsics unchanged for now. They will be renamed in a future CL.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//468793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39444 260f80e4-7a28-3924-810f-c04153c831b5

40 hours agoUpdate test scripts to run under the Dart 1.6 vm.
whesse@google.com [Thu, 21 Aug 2014 09:30:10 +0000 (09:30 +0000)]
Update test scripts to run under the Dart 1.6 vm.

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//483353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39443 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDon't recompile dependency executables that haven't changed.
nweiz@google.com [Thu, 21 Aug 2014 01:28:44 +0000 (01:28 +0000)]
Don't recompile dependency executables that haven't changed.

R=rnystrom@google.com
BUG=20482

Review URL: https://codereview.chromium.org//491993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39441 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix tests for pub global activate.
nweiz@google.com [Thu, 21 Aug 2014 00:29:10 +0000 (00:29 +0000)]
Fix tests for pub global activate.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//496583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39440 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoImplement [appendTo] and [getDisplayName] for union types.
collinsn@google.com [Thu, 21 Aug 2014 00:29:01 +0000 (00:29 +0000)]
Implement [appendTo] and [getDisplayName] for union types.

I can't make sense of the difference between [appendTo] and
[getDisplayName]. Their implementations are almost the same
in existing types, so I've copied that pattern here without
really understanding what they're used for :P

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//491123003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39439 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix memory leak in unittest - the testCases variable doesn't release the
dgrove@google.com [Wed, 20 Aug 2014 23:42:42 +0000 (23:42 +0000)]
Fix memory leak in unittest - the testCases variable doesn't release the
closure of each test after it runs.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//495813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39438 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDon't recompute the package graph unnecessarily in Entrypoint.
nweiz@google.com [Wed, 20 Aug 2014 23:39:37 +0000 (23:39 +0000)]
Don't recompute the package graph unnecessarily in Entrypoint.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//489943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39437 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoTweak CheckArrayBound location summary.
vegorov@google.com [Wed, 20 Aug 2014 22:59:20 +0000 (22:59 +0000)]
Tweak CheckArrayBound location summary.

It does not make sense to permit memory location for the index at bounds check as it is likely to be used right after as register for actual indexed load. Instead allow length itself to be in the memory.

BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//494483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39436 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoImplement more-specific-than (<<) for union types.
collinsn@google.com [Wed, 20 Aug 2014 22:41:31 +0000 (22:41 +0000)]
Implement more-specific-than (<<) for union types.

Simplify test code per brianwilkerson's suggestion.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//492003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39435 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoInitial 'Extract Local' implementation.
scheglov@google.com [Wed, 20 Aug 2014 22:20:19 +0000 (22:20 +0000)]
Initial 'Extract Local' implementation.

Missing:

1. suggested names;
2. offsets and lengths of occurrences.
3. some clean ups.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//489973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39434 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoEdits to protocol.md.
turnidge@google.com [Wed, 20 Aug 2014 22:09:58 +0000 (22:09 +0000)]
Edits to protocol.md.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//493893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39433 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix erroneous error and preserve async information in element model
brianwilkerson@google.com [Wed, 20 Aug 2014 21:53:37 +0000 (21:53 +0000)]
Fix erroneous error and preserve async information in element model

R=scheglov@google.com

Review URL: https://codereview.chromium.org//493743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39432 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoClose servers for bin directories when precompiling executables.
nweiz@google.com [Wed, 20 Aug 2014 21:09:09 +0000 (21:09 +0000)]
Close servers for bin directories when precompiling executables.

R=rnystrom@google.com
BUG=20482

Review URL: https://codereview.chromium.org//491103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39431 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDon't use LinkedEditGroup.id.
scheglov@google.com [Wed, 20 Aug 2014 21:07:14 +0000 (21:07 +0000)]
Don't use LinkedEditGroup.id.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//495733002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39430 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoUse the version solver when choosing a version for pub global activate.
nweiz@google.com [Wed, 20 Aug 2014 21:06:01 +0000 (21:06 +0000)]
Use the version solver when choosing a version for pub global activate.

R=rnystrom@google.com
BUG=20287

Review URL: https://codereview.chromium.org//494803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39429 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoGenerate a toJson method onto our generated types, int is now represented as the...
jwren@google.com [Wed, 20 Aug 2014 20:53:40 +0000 (20:53 +0000)]
Generate a toJson method onto our generated types, int is now represented as the wrapped Integer in class

R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//485213004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39428 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoTweaks to perf jitdump support
johnmccutchan@google.com [Wed, 20 Aug 2014 20:43:54 +0000 (20:43 +0000)]
Tweaks to perf jitdump support

BUG=
R=asiva@google.com, vegorov@google.com

Review URL: https://codereview.chromium.org//489923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39427 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRound Touch attributes back to int for backwards compatibility
leafp@google.com [Wed, 20 Aug 2014 20:29:36 +0000 (20:29 +0000)]
Round Touch attributes back to int for backwards compatibility

Most of the attributes in the Touch interface (clientX/Y, screenX/Y, pageX/Y, webkitRadiusX/Y) have changed to use double instead of int.  Since we are generating dart:html from old idl, this immediately breaks for us as soon as these are used.  This CL wraps calls to these with a round to retain the old API.

BUG=http://dartbug.com/20587
R=blois@google.com

Review URL: https://codereview.chromium.org//493843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39426 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoInitial commit of service/protocol.md
turnidge@google.com [Wed, 20 Aug 2014 20:12:18 +0000 (20:12 +0000)]
Initial commit of service/protocol.md

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//466363008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39425 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoPrecompile dependencies' executables for use with "pub run".
nweiz@google.com [Wed, 20 Aug 2014 20:06:20 +0000 (20:06 +0000)]
Precompile dependencies' executables for use with "pub run".

R=rnystrom@google.com
BUG=20482

Review URL: https://codereview.chromium.org//482053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39424 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRefactor isolate startup code in preparation for making isolate spawning more truly...
turnidge@google.com [Wed, 20 Aug 2014 19:57:09 +0000 (19:57 +0000)]
Refactor isolate startup code in preparation for making isolate spawning more truly non-blocking.

Instead of passing a startup message to the new isolate, pass all
necessary information in to _startIsolate directly.  The new isolate
sends its control port and capabilities back to the parent.

R=iposva@google.com

Review URL: https://codereview.chromium.org//456983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39423 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoBullet-proofing debugger SWTBot tests
messick@google.com [Wed, 20 Aug 2014 19:30:47 +0000 (19:30 +0000)]
Bullet-proofing debugger SWTBot tests

R=pquitslund@google.com

Review URL: https://codereview.chromium.org//493843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39422 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoImplement substitution for union types.
collinsn@google.com [Wed, 20 Aug 2014 19:28:16 +0000 (19:28 +0000)]
Implement substitution for union types.

R=jwren@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//470533004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39421 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDon't use "final" in analysis server protocol classes.
paulberry@google.com [Wed, 20 Aug 2014 18:53:26 +0000 (18:53 +0000)]
Don't use "final" in analysis server protocol classes.

Doing so makes it harder to use these classes because we sometimes don't have
complete information about an object at the time we need to create it.

R=jwren@google.com

Review URL: https://codereview.chromium.org//495623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39420 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoImplement supertype (<:) for union type on RHS.
collinsn@google.com [Wed, 20 Aug 2014 18:43:24 +0000 (18:43 +0000)]
Implement supertype (<:) for union type on RHS.

The defaults for bottom and dynamic already do the right thing.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Review URL: https://codereview.chromium.org//488183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39419 260f80e4-7a28-3924-810f-c04153c831b5

2 days ago- Address review comments from https://codereview.chromium.org/474913004/
iposva@google.com [Wed, 20 Aug 2014 18:37:29 +0000 (18:37 +0000)]
- Address review comments from https://codereview.chromium.org/474913004/
- Clearly mark overrides of ThreadPool::Task::Run as virtual.

Review URL: https://codereview.chromium.org//480343003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39418 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoMoves SingleStepHandler runtime calls
zra@google.com [Wed, 20 Aug 2014 18:21:47 +0000 (18:21 +0000)]
Moves SingleStepHandler runtime calls

to match the NArgsCheckInlineCache stub.

Gives a small improvement in unoptimized code.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//496483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39417 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoNew analyzer snapshot.
scheglov@google.com [Wed, 20 Aug 2014 18:18:43 +0000 (18:18 +0000)]
New analyzer snapshot.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//489173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39416 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoTrack per-class promotion stats.
koda@google.com [Wed, 20 Aug 2014 17:57:12 +0000 (17:57 +0000)]
Track per-class promotion stats.

This will be useful for allocation policy and heap growth policy.

Also include these stats in the VM service.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//487973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39415 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIncrease launch delay to try making bots happy
messick@google.com [Wed, 20 Aug 2014 16:20:09 +0000 (16:20 +0000)]
Increase launch delay to try making bots happy

R=danrubel@google.com

Review URL: https://codereview.chromium.org//496433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39414 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoinclude inherited members in invocation suggestions
danrubel@google.com [Wed, 20 Aug 2014 16:13:30 +0000 (16:13 +0000)]
include inherited members in invocation suggestions

BUG=
R=jwren@google.com

Review URL: https://codereview.chromium.org//489813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39413 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoremove unused CompilationUnit and related classes and methods
danrubel@google.com [Wed, 20 Aug 2014 16:01:56 +0000 (16:01 +0000)]
remove unused CompilationUnit and related classes and methods

BUG=
R=messick@google.com

Review URL: https://codereview.chromium.org//490923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39412 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd SearchResultKind.UNKNOWN to the analysis server API.
paulberry@google.com [Wed, 20 Aug 2014 15:32:39 +0000 (15:32 +0000)]
Add SearchResultKind.UNKNOWN to the analysis server API.

This resolves an inconsistency between the spec and the analysis
server behavior: the server returns a SearchResultKind of UNKNOWN if
the MatchKind from the analysis engine is one of the following types:

- ANGULAR_REFERENCE
- ANGULAR_CLOSING_TAG_REFERENCE

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//488103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39411 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdjust for spec changes
brianwilkerson@google.com [Wed, 20 Aug 2014 14:53:04 +0000 (14:53 +0000)]
Adjust for spec changes

R=scheglov@google.com

Review URL: https://codereview.chromium.org//488873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39410 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoadd font rules to log widget
jakemac@google.com [Wed, 20 Aug 2014 14:50:39 +0000 (14:50 +0000)]
add font rules to log widget

BUG= http://dartbug.com/20537
R=kevmoo@google.com

Review URL: https://codereview.chromium.org//487813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39409 260f80e4-7a28-3924-810f-c04153c831b5

2 days agohtml escape log messages
jakemac@google.com [Wed, 20 Aug 2014 14:48:36 +0000 (14:48 +0000)]
html escape log messages

BUG= http://dartbug.com/20539
R=kevmoo@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//487793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39408 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRemove two empty/useless domain tests.
scheglov@google.com [Wed, 20 Aug 2014 14:16:10 +0000 (14:16 +0000)]
Remove two empty/useless domain tests.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//489703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39407 260f80e4-7a28-3924-810f-c04153c831b5

2 days ago- Address code review comment from https://codereview.chromium.org/488943002/
iposva@google.com [Wed, 20 Aug 2014 14:11:00 +0000 (14:11 +0000)]
- Address code review comment from https://codereview.chromium.org/488943002/

Review URL: https://codereview.chromium.org//468913011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39406 260f80e4-7a28-3924-810f-c04153c831b5