external/dart/bleeding_edge.git
6 hours agoTweak test for the new resolved/parsed AST management and restore it. master
scheglov@google.com [Sat, 1 Nov 2014 05:28:46 +0000 (05:28 +0000)]
Tweak test for the new resolved/parsed AST management and restore it.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//695923003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41454 260f80e4-7a28-3924-810f-c04153c831b5

13 hours agoFix issue 21474 in mirrors.
regis@google.com [Fri, 31 Oct 2014 23:16:11 +0000 (23:16 +0000)]
Fix issue 21474 in mirrors.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//690413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41453 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoOptimize LineInfo.getLocation().
rnystrom@google.com [Fri, 31 Oct 2014 21:49:10 +0000 (21:49 +0000)]
Optimize LineInfo.getLocation().

Three simple optimizations:

1. Do a binary search through _lineStarts to find the line instead of linear.
2. Store the last result and see if the offset starts there or later. If so, skip leading lines when searching.
3. See if the current offset is on the same line as the last result and exit early if so.

On my benchmark test for the formatter, this reduced it from 13.23ms to 7.57ms.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//692093004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41452 260f80e4-7a28-3924-810f-c04153c831b5

15 hours agoRemove unnecessary cast in Quick Assist.
scheglov@google.com [Fri, 31 Oct 2014 20:44:44 +0000 (20:44 +0000)]
Remove unnecessary cast in Quick Assist.

Sorry, missed it in the previous CL.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//696003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41451 260f80e4-7a28-3924-810f-c04153c831b5

15 hours agoFix for an error in the error handler.
scheglov@google.com [Fri, 31 Oct 2014 20:43:28 +0000 (20:43 +0000)]
Fix for an error in the error handler.

We pass exception as String message.

We would have caught it if we had run the server in the checked mode.
Instead it failed at the JSON serialization stage.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//698563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41450 260f80e4-7a28-3924-810f-c04153c831b5

15 hours agoDon't report problems with setting a breakpoint.
scheglov@google.com [Fri, 31 Oct 2014 20:42:37 +0000 (20:42 +0000)]
Don't report problems with setting a breakpoint.

We try to set all breakpoints now, and we don't know to spam user with these problems.

R=devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//689193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41449 260f80e4-7a28-3924-810f-c04153c831b5

15 hours agoRemove "-dev" to publish args package.
rnystrom@google.com [Fri, 31 Oct 2014 20:29:04 +0000 (20:29 +0000)]
Remove "-dev" to publish args package.

R=nweiz@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//698463004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41448 260f80e4-7a28-3924-810f-c04153c831b5

16 hours agoClarify comment explaining assert in Function::SetParameterTypeAt.
regis@google.com [Fri, 31 Oct 2014 20:14:56 +0000 (20:14 +0000)]
Clarify comment explaining assert in Function::SetParameterTypeAt.

R=zra@google.com

Review URL: https://codereview.chromium.org//693613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41447 260f80e4-7a28-3924-810f-c04153c831b5

17 hours agoFix for 'Replace if-else with conditional expression' in case of mixed expression...
scheglov@google.com [Fri, 31 Oct 2014 19:22:22 +0000 (19:22 +0000)]
Fix for 'Replace if-else with conditional expression' in case of mixed expression/return branches.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//690353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41446 260f80e4-7a28-3924-810f-c04153c831b5

17 hours agoSupport for 'Add Type Annotation' when selection if right after ';'.
scheglov@google.com [Fri, 31 Oct 2014 19:09:03 +0000 (19:09 +0000)]
Support for 'Add Type Annotation' when selection if right after ';'.

R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//693193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41445 260f80e4-7a28-3924-810f-c04153c831b5

17 hours agoDefensively create the new project directory in the new project wizard.
devoncarew@google.com [Fri, 31 Oct 2014 19:08:17 +0000 (19:08 +0000)]
Defensively create the new project directory in the new project wizard.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//694943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41444 260f80e4-7a28-3924-810f-c04153c831b5

17 hours agoClean up logging uses
brianwilkerson@google.com [Fri, 31 Oct 2014 19:05:19 +0000 (19:05 +0000)]
Clean up logging uses

R=scheglov@google.com

Review URL: https://codereview.chromium.org//685993004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41443 260f80e4-7a28-3924-810f-c04153c831b5

17 hours agomove import combinator suggestions into a separate computer
danrubel@google.com [Fri, 31 Oct 2014 18:31:18 +0000 (18:31 +0000)]
move import combinator suggestions into a separate computer

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//695773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41442 260f80e4-7a28-3924-810f-c04153c831b5

17 hours agoguard against NPE in new editor model
danrubel@google.com [Fri, 31 Oct 2014 18:28:46 +0000 (18:28 +0000)]
guard against NPE in new editor model

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//698613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41441 260f80e4-7a28-3924-810f-c04153c831b5

18 hours agoIssue 21432. Request application file when establish remote debugger connection.
scheglov@google.com [Fri, 31 Oct 2014 18:01:20 +0000 (18:01 +0000)]
Issue 21432. Request application file when establish remote debugger connection.

So, we can use this resource to find pubspec, resolve files to URIs and vice versa.

R=devoncarew@google.com, paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21432

Review URL: https://codereview.chromium.org//689133002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41440 260f80e4-7a28-3924-810f-c04153c831b5

20 hours agoFix logging API. This should fix the exception I'm seeing. I'll clean up uses of...
brianwilkerson@google.com [Fri, 31 Oct 2014 16:22:50 +0000 (16:22 +0000)]
Fix logging API. This should fix the exception I'm seeing. I'll clean up uses of the deprecated API in a separate CL.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//694833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41439 260f80e4-7a28-3924-810f-c04153c831b5

22 hours agoSupport is/as expressions in analyzer2dart.
johnniwinther@google.com [Fri, 31 Oct 2014 14:16:22 +0000 (14:16 +0000)]
Support is/as expressions in analyzer2dart.

BUG=
R=paulberry@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//693153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41438 260f80e4-7a28-3924-810f-c04153c831b5

24 hours agoIR refactoring: consolidate all boxing and unboxing instructions.
vegorov@google.com [Fri, 31 Oct 2014 12:17:12 +0000 (12:17 +0000)]
IR refactoring: consolidate all boxing and unboxing instructions.

BUG=
R=fschneider@google.com

Review URL: https://codereview.chromium.org//670263007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41437 260f80e4-7a28-3924-810f-c04153c831b5

24 hours agoMake stdout/stderr async
sgjesse@google.com [Fri, 31 Oct 2014 12:11:53 +0000 (12:11 +0000)]
Make stdout/stderr async

This makes stdout.write and stderr.write async.

This effectively reverts https://code.google.com/p/dart/source/detail?r=33645

Reapplies r41350 after the dart2js batch-runner have been changed to handle
async stdout/stderr.

R=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//693793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41436 260f80e4-7a28-3924-810f-c04153c831b5

24 hours agoMove continueWithExpression to IrBuilder.
johnniwinther@google.com [Fri, 31 Oct 2014 12:04:35 +0000 (12:04 +0000)]
Move continueWithExpression to IrBuilder.

+ cleanup of invocations
+ prepare analyzer2dart support for type operators

R=sigurdm@google.com

Review URL: https://codereview.chromium.org//693803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41435 260f80e4-7a28-3924-810f-c04153c831b5

27 hours agodart2js: Revert r36565 (Work-around for memory leak).
fschneider@google.com [Fri, 31 Oct 2014 08:43:36 +0000 (08:43 +0000)]
dart2js: Revert r36565 (Work-around for memory leak).

After fixing VM bug dartbug.com/18886 this work-around is not
needed anymore.

I tested dart2js tests in batch mode using the following command.

tools/test.py -mrelease -aia32 -cdart2js -rd8 --dart2js-batch

and it works fine.

Review URL: https://codereview.chromium.org//678083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41434 260f80e4-7a28-3924-810f-c04153c831b5

28 hours agoRemove saving/restoring of the context at function entry.
fschneider@google.com [Fri, 31 Oct 2014 07:35:51 +0000 (07:35 +0000)]
Remove saving/restoring of the context at function entry.

This is not needed anymore after I changed the current context
to always reside in a local variable.

Further simplifications and cleanup in the debugger.

This also fixes a bad memory retention problem with
non-capturing closures.

BUG=dartbug.com/18886
TEST=tests/language/vm/closure_memory_retention_test.dart
R=hausner@google.com

Review URL: https://codereview.chromium.org//695483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41433 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoPerform interceptor simplification on interceptors passed in super calls
sra@google.com [Fri, 31 Oct 2014 02:02:11 +0000 (02:02 +0000)]
Perform interceptor simplification on interceptors passed in super calls

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//687423003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41432 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoUse a constant instead of int.parse("0x10ffff")
sra@google.com [Fri, 31 Oct 2014 01:29:06 +0000 (01:29 +0000)]
Use a constant instead of int.parse("0x10ffff")

BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//651513003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41431 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoUpdate template_binding test that was still using the deprecated mutation_observer...
sigmund@google.com [Thu, 30 Oct 2014 23:22:47 +0000 (23:22 +0000)]
Update template_binding test that was still using the deprecated mutation_observer polyfill

Review URL: https://codereview.chromium.org//690163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41430 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoRemove deprecated packages from the repo
sigmund@google.com [Thu, 30 Oct 2014 22:57:29 +0000 (22:57 +0000)]
Remove deprecated packages from the repo

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//695603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41429 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoDisable a test until I can fix it
brianwilkerson@google.com [Thu, 30 Oct 2014 21:47:58 +0000 (21:47 +0000)]
Disable a test until I can fix it

Review URL: https://codereview.chromium.org//655353005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41428 260f80e4-7a28-3924-810f-c04153c831b5

39 hours agoStatus page improvements: sort context names, right align numbers, add missing data...
brianwilkerson@google.com [Thu, 30 Oct 2014 21:11:40 +0000 (21:11 +0000)]
Status page improvements: sort context names, right align numbers, add missing data descriptors.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//685123006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41427 260f80e4-7a28-3924-810f-c04153c831b5

39 hours agoFix issue 21379
brianwilkerson@google.com [Thu, 30 Oct 2014 21:07:50 +0000 (21:07 +0000)]
Fix issue 21379

R=danrubel@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//683673004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41426 260f80e4-7a28-3924-810f-c04153c831b5

41 hours agoRevert mixin fix r41424 until mirrors issue 21474 is fixed.
regis@google.com [Thu, 30 Oct 2014 19:04:02 +0000 (19:04 +0000)]
Revert mixin fix r41424 until mirrors issue 21474 is fixed.

Review URL: https://codereview.chromium.org//691053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41425 260f80e4-7a28-3924-810f-c04153c831b5

42 hours agoFix Function::Clone() and Field::Clone() to adjust the class owner of type
regis@google.com [Thu, 30 Oct 2014 17:39:40 +0000 (17:39 +0000)]
Fix Function::Clone() and Field::Clone() to adjust the class owner of type
parameters (issue 18630).
Add regression tests.
Commented out 3 lines in mirror test (issue 21474 filed).

R=srdjan@google.com

Review URL: https://codereview.chromium.org//646103005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41424 260f80e4-7a28-3924-810f-c04153c831b5

43 hours agoIntroduce --no-prune-dead-locals flag to disable dead locals pruning.
vegorov@google.com [Thu, 30 Oct 2014 16:35:39 +0000 (16:35 +0000)]
Introduce --no-prune-dead-locals flag to disable dead locals pruning.

Disabling this optimization regresses code quality but improves debugging experience.

R=fschneider@google.com
BUG=

Review URL: https://codereview.chromium.org//690043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41423 260f80e4-7a28-3924-810f-c04153c831b5

44 hours agoMake CTX allocatable by the register allocator.
fschneider@google.com [Thu, 30 Oct 2014 15:42:38 +0000 (15:42 +0000)]
Make CTX allocatable by the register allocator.

This change makes CTX available by not caching the current
context while in Dart code. Instead the current context
is held in a local variable (:saved_current_context_var) and
is passed as argument in CTX at calls.

This also simplifies a lot of code in the debugger: As a result,
Isolate::top_context is not needed anymore since the current context
can always be extracted from a Dart frame.

R=vegorov@google.com

Review URL: https://codereview.chromium.org//678763004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41422 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agoMake dart2js batch mode completely async
ricow@google.com [Thu, 30 Oct 2014 15:16:47 +0000 (15:16 +0000)]
Make dart2js batch mode completely async

The current implementation breaks with:
https://codereview.chromium.org/673193002/

R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//688263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41421 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agoadd suggestions in format parameter list
danrubel@google.com [Thu, 30 Oct 2014 15:13:57 +0000 (15:13 +0000)]
add suggestions in format parameter list

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//693573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41420 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agocleanup warnings/hints
danrubel@google.com [Thu, 30 Oct 2014 15:12:30 +0000 (15:12 +0000)]
cleanup warnings/hints

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//685363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41419 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoUpdate status for vm and analyzer.
whesse@google.com [Thu, 30 Oct 2014 12:33:50 +0000 (12:33 +0000)]
Update status for vm and analyzer.

BUG=dartbug.com/21468 dartbug.com/21469
R=ricow@google.com

Review URL: https://codereview.chromium.org//684133006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41418 260f80e4-7a28-3924-810f-c04153c831b5

2 days agolog when AnalysisServer stream unexpectedly closes
danrubel@google.com [Thu, 30 Oct 2014 11:40:26 +0000 (11:40 +0000)]
log when AnalysisServer stream unexpectedly closes

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//689853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41417 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoReapply "Port regexp tests from V8 to Dart."
zerny@google.com [Thu, 30 Oct 2014 11:34:18 +0000 (11:34 +0000)]
Reapply "Port regexp tests from V8 to Dart."

This fixes checked mode issues and reapplies commit
https://code.google.com/p/dart/source/detail?r=41354

R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//691473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41416 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoUpdate Safari status files.
whesse@google.com [Thu, 30 Oct 2014 10:17:19 +0000 (10:17 +0000)]
Update Safari status files.

BUG=dartbug.com/21434

Review URL: https://codereview.chromium.org//687353006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41415 260f80e4-7a28-3924-810f-c04153c831b5

2 days agomake deprecated elements have low suggestion relevance
danrubel@google.com [Thu, 30 Oct 2014 01:08:32 +0000 (01:08 +0000)]
make deprecated elements have low suggestion relevance

BUG=dartbug.com/19615
R=scheglov@google.com

Review URL: https://codereview.chromium.org//690793004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41414 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix for Quick Outline without the Outline view.
scheglov@google.com [Thu, 30 Oct 2014 01:07:21 +0000 (01:07 +0000)]
Fix for Quick Outline without the Outline view.

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//684123004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41413 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIgnore characters that cannot be a part of an identifier.
scheglov@google.com [Thu, 30 Oct 2014 01:05:40 +0000 (01:05 +0000)]
Ignore characters that cannot be a part of an identifier.

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//670263006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41412 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDon't analyze async_await in the repo bots.
nweiz@google.com [Thu, 30 Oct 2014 00:55:17 +0000 (00:55 +0000)]
Don't analyze async_await in the repo bots.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//687953004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41411 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDisable analysis engine flag for porting to analysis server
danrubel@google.com [Thu, 30 Oct 2014 00:01:22 +0000 (00:01 +0000)]
Disable analysis engine flag for porting to analysis server

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//687363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41410 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoSuggest names for PropertyAccess.
scheglov@google.com [Wed, 29 Oct 2014 22:07:27 +0000 (22:07 +0000)]
Suggest names for PropertyAccess.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//646103006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41409 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoImprove cache entry tests
brianwilkerson@google.com [Wed, 29 Oct 2014 21:56:56 +0000 (21:56 +0000)]
Improve cache entry tests

R=scheglov@google.com

Review URL: https://codereview.chromium.org//686293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41408 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd some additional annotations for tracking pub performance.
nweiz@google.com [Wed, 29 Oct 2014 21:47:57 +0000 (21:47 +0000)]
Add some additional annotations for tracking pub performance.

This also makes pub print more detailed timing information in
--verbose mode.

R=rnystrom@google.com
BUG=20859

Review URL: https://codereview.chromium.org//600293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41407 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoContext objects don't have a compile-type. Return dynamic-type in this case.
koda@google.com [Wed, 29 Oct 2014 21:34:59 +0000 (21:34 +0000)]
Context objects don't have a compile-type. Return dynamic-type in this case.

This is lifted from
https://codereview.chromium.org/678763004/diff/120001/runtime/vm/flow_graph_type_propagator.cc
to fix issue 21455.

BUG=21455
R=vegorov@google.com

Review URL: https://codereview.chromium.org//689713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41406 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRename ForEachStatement.iterator -> iterable.
scheglov@google.com [Wed, 29 Oct 2014 21:33:04 +0000 (21:33 +0000)]
Rename ForEachStatement.iterator -> iterable.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//689793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41405 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix unintended effects in vm.status.
koda@google.com [Wed, 29 Oct 2014 21:00:19 +0000 (21:00 +0000)]
Fix unintended effects in vm.status.

Review URL: https://codereview.chromium.org//688143002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41404 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 21458. Support for 'Add type' Quick Assist in for-each loops.
scheglov@google.com [Wed, 29 Oct 2014 20:59:29 +0000 (20:59 +0000)]
Issue 21458. Support for 'Add type' Quick Assist in for-each loops.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21458

Review URL: https://codereview.chromium.org//680133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41403 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 21451. Fix for 'Add import' Quick Fix in case when package roots is in use.
scheglov@google.com [Wed, 29 Oct 2014 20:51:07 +0000 (20:51 +0000)]
Issue 21451. Fix for 'Add import' Quick Fix in case when package roots is in use.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21451

Review URL: https://codereview.chromium.org//670263005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41402 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix a couple of Dart style naming violations in Intl
alanknight@google.com [Wed, 29 Oct 2014 20:44:19 +0000 (20:44 +0000)]
Fix a couple of Dart style naming violations in Intl

BUG=
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//670933004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41401 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoMake table entries on analysis server's '/status' page clickable.
paulberry@google.com [Wed, 29 Oct 2014 20:05:16 +0000 (20:05 +0000)]
Make table entries on analysis server's '/status' page clickable.

Clicking on a table entry now takes you to a list of files in the
given state.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//685863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41400 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd VerifiedMemory helper for write-barrier verification.
koda@google.com [Wed, 29 Oct 2014 19:56:12 +0000 (19:56 +0000)]
Add VerifiedMemory helper for write-barrier verification.

Allocates hidden extra memory after VirtualMemory, and
verified writes are duplicated at a fixed offset.

This CL only adds the helper.
Next steps:
1. Use Reserve when reserving semi-spaces and heap pages.
2. Use Write for storing pointers (+ offset in generated code).
3. Use Accept for GC-related object lifecycle.
4. Call Verify regularly.
5. Fix failures (= places where we forget/ignore write barriers).

Review URL: https://codereview.chromium.org//641243004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41399 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoTry to set any server breakpoint.
scheglov@google.com [Wed, 29 Oct 2014 18:38:12 +0000 (18:38 +0000)]
Try to set any server breakpoint.

R=devoncarew@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//684083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41398 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRetry failing tests on Safari, because it is flaky.
whesse@google.com [Wed, 29 Oct 2014 17:53:14 +0000 (17:53 +0000)]
Retry failing tests on Safari, because it is flaky.

BUG=dartbug.com/21434

Review URL: https://codereview.chromium.org//691583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41397 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRefactor CompletionSuggestionKind
danrubel@google.com [Wed, 29 Oct 2014 16:09:56 +0000 (16:09 +0000)]
Refactor CompletionSuggestionKind

- Remove many CompletionSuggestionKinds that duplicate ElementKind
- Add two new CompletionSuggestionKinds: INVOCATION and IDENTIFIER
- regenerate Analysis Server Dart and Java API and docs
- rework Dart and Java tests
- remove/rename unused Dart and Java classes and methods
- remove unnecessary reference to SDK

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//684183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41396 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFixes leak in Process.runSync().
zra@google.com [Wed, 29 Oct 2014 14:32:30 +0000 (14:32 +0000)]
Fixes leak in Process.runSync().

This removes the call to _stdin._sink.destroy()
from my previous CL, which broke a test.
stdin is closed by the native implementation.
Closing again shouldn't cause a problem, but
it looks like destroy() attempts to do a lot
more than that.

OTOH adding the remove call is sufficient to
fix the leak, so let's just stick with that.

R=iposva@google.com

Review URL: https://codereview.chromium.org//687163004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41395 260f80e4-7a28-3924-810f-c04153c831b5

2 days ago_Temporarily_ retry failing browser tests on Safari, because versions 6.2 and 7.1...
whesse@google.com [Wed, 29 Oct 2014 13:07:11 +0000 (13:07 +0000)]
_Temporarily_ retry failing browser tests on Safari, because versions 6.2 and 7.1 are flaky on dart2js output.

Add support for macos 10.9 to buildbot scripts.

BUG=dartbug.com/21434
R=ricow@google.com

Review URL: https://codereview.chromium.org//687213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41394 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoMark tests flaky on Safari 6.2
whesse@google.com [Wed, 29 Oct 2014 10:30:25 +0000 (10:30 +0000)]
Mark tests flaky on Safari 6.2

BUG=dartbug.com/21434
R=ricow@google.com

Review URL: https://codereview.chromium.org//659173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41393 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoMake Expect.throws not accept arguments that fail to be called.
lrn@google.com [Wed, 29 Oct 2014 10:06:35 +0000 (10:06 +0000)]
Make Expect.throws not accept arguments that fail to be called.

Expect.throws calls its first argument, f, with no arguments.
If f isn't callable in this way, the act of calling would throw, and this throw would be considered as makeing the Expect.throws succeeede.

Now we check the argument first, and call it outside the try/catch if it's not callable. This was already caught in checked mode, but we shouldn't accept a false positive in unchecked mode either.

R=zerny@google.com

Review URL: https://codereview.chromium.org//692463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41392 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoSupport map and list literals in analyzer2dart.
johnniwinther@google.com [Wed, 29 Oct 2014 10:05:56 +0000 (10:05 +0000)]
Support map and list literals in analyzer2dart.

BUG=
R=paulberry@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//658103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41391 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoSupport while loop in analyzer2dart.
johnniwinther@google.com [Wed, 29 Oct 2014 08:15:23 +0000 (08:15 +0000)]
Support while loop in analyzer2dart.

BUG=
R=paulberry@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//686743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41390 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoadd class type alias suggestions
danrubel@google.com [Wed, 29 Oct 2014 02:48:31 +0000 (02:48 +0000)]
add class type alias suggestions

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//689433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41388 260f80e4-7a28-3924-810f-c04153c831b5

3 days agomake patching of todomvc work from any directory
sigmund@google.com [Wed, 29 Oct 2014 02:05:58 +0000 (02:05 +0000)]
make patching of todomvc work from any directory

TBR=ricow@google.com

Review URL: https://codereview.chromium.org//678273003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41387 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoReverts 41378 for test failure.
zra@google.com [Wed, 29 Oct 2014 01:57:22 +0000 (01:57 +0000)]
Reverts 41378 for test failure.

Review URL: https://codereview.chromium.org//688443005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41386 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAdd patch for todomvc (temporary while we migrate to package bots logic)
sigmund@google.com [Wed, 29 Oct 2014 01:39:16 +0000 (01:39 +0000)]
Add patch for todomvc (temporary while we migrate to package bots logic)
R=ricow@google.com

Review URL: https://codereview.chromium.org//683063006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41385 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRedo "Constant fold charCodeAt via constant system"
sra@google.com [Wed, 29 Oct 2014 01:00:09 +0000 (01:00 +0000)]
Redo "Constant fold charCodeAt via constant system"

TBR=johnniwinther@google.com
BUG=

Review URL: https://codereview.chromium.org//682243004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41384 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAdd SpanScanner.location.
nweiz@google.com [Wed, 29 Oct 2014 00:53:21 +0000 (00:53 +0000)]
Add SpanScanner.location.

Also explicitly expose FileSpans and FileLocations.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//683323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41383 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRevert "Constant fold charCodeAt via constant system"
sra@google.com [Wed, 29 Oct 2014 00:47:02 +0000 (00:47 +0000)]
Revert "Constant fold charCodeAt via constant system"

TBR=johnniwinther@google.com
BUG=

Review URL: https://codereview.chromium.org//664283004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41382 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoConstant fold charCodeAt via constant system
sra@google.com [Tue, 28 Oct 2014 23:58:15 +0000 (23:58 +0000)]
Constant fold charCodeAt via constant system

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//681543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41381 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAllow print() to be used for debugging analysis server.
paulberry@google.com [Tue, 28 Oct 2014 23:29:27 +0000 (23:29 +0000)]
Allow print() to be used for debugging analysis server.

We now run analysis server inside a zone so that all print() calls it
executes can be captured to a buffer (rather than being sent to
standard output, where they will confuse the client).  When the server
is run in HTTP server mode, the print buffer is displayed on the
status page.

R=brianwilkerson@google.com, danrubel@google.com

Review URL: https://codereview.chromium.org//686763004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41380 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRedirect blink calls through instance
leafp@google.com [Tue, 28 Oct 2014 23:11:51 +0000 (23:11 +0000)]
Redirect blink calls through instance

Use a singleton instance object for dispatching calls from dart:html to dart:blink to make code more resilient against changes in web idl.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//684783005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41379 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoFixes memory leak in Process.runSync()
zra@google.com [Tue, 28 Oct 2014 23:02:54 +0000 (23:02 +0000)]
Fixes memory leak in Process.runSync()

This was introduced in 36665 by https://codereview.chromium.org/307503002/

R=iposva@google.com

Review URL: https://codereview.chromium.org//690513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41378 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoTweaks for the 'New Project' wizard.
scheglov@google.com [Tue, 28 Oct 2014 22:15:56 +0000 (22:15 +0000)]
Tweaks for the 'New Project' wizard.

This makes it use characters instead of pixels, prevents vertical and
horizontal scrolling for reasonable data, expands samples viewer as
dialog is resized.

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//682273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41377 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoadd functional type alias suggestions
danrubel@google.com [Tue, 28 Oct 2014 22:03:16 +0000 (22:03 +0000)]
add functional type alias suggestions

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//682953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41376 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoDEPS AutoUpdate: webkit to 184546 (2014-10-28 14:59:51 -0700) leafp@google.com
vsm@google.com [Tue, 28 Oct 2014 22:02:59 +0000 (22:02 +0000)]
DEPS AutoUpdate: webkit to 184546 (2014-10-28 14:59:51 -0700) leafp@google.com
Fix name mangling for indexed getters.
http://src.chromium.org/viewvc/blink?view=rev&revision=184546

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41375 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAdd tests of incremental scanner
brianwilkerson@google.com [Tue, 28 Oct 2014 21:51:42 +0000 (21:51 +0000)]
Add tests of incremental scanner

R=scheglov@google.com

Review URL: https://codereview.chromium.org//675173004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41374 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoIssue 21333. Constant names are not special anymore in the style guide (Dart version).
scheglov@google.com [Tue, 28 Oct 2014 21:42:46 +0000 (21:42 +0000)]
Issue 21333. Constant names are not special anymore in the style guide (Dart version).

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21333

Review URL: https://codereview.chromium.org//684863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41373 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAvoid analysis server crash when reanalyze invoked during analysis.
paulberry@google.com [Tue, 28 Oct 2014 21:15:59 +0000 (21:15 +0000)]
Avoid analysis server crash when reanalyze invoked during analysis.

BUG=dartbug.com/21448
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//678413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41372 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoIssue 21333. Constant names are not special anymore in the style guide (Java version).
scheglov@google.com [Tue, 28 Oct 2014 21:13:36 +0000 (21:13 +0000)]
Issue 21333. Constant names are not special anymore in the style guide (Java version).

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21333

Review URL: https://codereview.chromium.org//668253003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41371 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRename package_root.dart test to package_root_test.dart
paulberry@google.com [Tue, 28 Oct 2014 21:10:17 +0000 (21:10 +0000)]
Rename package_root.dart test to package_root_test.dart

So that the test will be run on the buildbots.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//685843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41370 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoadd type static constants suggestions
danrubel@google.com [Tue, 28 Oct 2014 21:03:36 +0000 (21:03 +0000)]
add type static constants suggestions

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//686843003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41369 260f80e4-7a28-3924-810f-c04153c831b5

3 days agosuggest imported functions in argument list
danrubel@google.com [Tue, 28 Oct 2014 19:03:37 +0000 (19:03 +0000)]
suggest imported functions in argument list

BUG=dartbug.com/21446
R=scheglov@google.com

Review URL: https://codereview.chromium.org//683133003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41368 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoIssue 21140. Force project's charset for files on open.
scheglov@google.com [Tue, 28 Oct 2014 17:56:21 +0000 (17:56 +0000)]
Issue 21140. Force project's charset for files on open.

User made a good claim that if the whole project is in UTF-8, we should not
be affected by the 20 years old decision of Sun about *.properties files.

R=danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21140

Review URL: https://codereview.chromium.org//684913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41367 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoMake package roots work in editor with analysis server.
paulberry@google.com [Tue, 28 Oct 2014 17:54:02 +0000 (17:54 +0000)]
Make package roots work in editor with analysis server.

R=danrubel@google.com, keertip@google.com

Review URL: https://codereview.chromium.org//677983005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41366 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoReplace custom EngineTestCase.assertEquals() with 'unorderedEquals'.
scheglov@google.com [Tue, 28 Oct 2014 17:00:06 +0000 (17:00 +0000)]
Replace custom EngineTestCase.assertEquals() with 'unorderedEquals'.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//673233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41365 260f80e4-7a28-3924-810f-c04153c831b5

3 days agofix NPE in builder when analysis server is active
danrubel@google.com [Tue, 28 Oct 2014 16:43:52 +0000 (16:43 +0000)]
fix NPE in builder when analysis server is active

BUG=dartbug.com/21447
R=scheglov@google.com

Review URL: https://codereview.chromium.org//686823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41364 260f80e4-7a28-3924-810f-c04153c831b5

3 days agostore pub package information in metadata and read on startup
keertip@google.com [Tue, 28 Oct 2014 16:24:44 +0000 (16:24 +0000)]
store pub package information in metadata and read on startup

R=danrubel@google.com

Review URL: https://codereview.chromium.org//654753009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41363 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRemove unused EngineTestCase.assertX() methods.
scheglov@google.com [Tue, 28 Oct 2014 16:19:39 +0000 (16:19 +0000)]
Remove unused EngineTestCase.assertX() methods.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//683193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41362 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoReplace EngineTestCase.assertSize() with hasLength().
scheglov@google.com [Tue, 28 Oct 2014 15:57:33 +0000 (15:57 +0000)]
Replace EngineTestCase.assertSize() with hasLength().

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//686793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41361 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAtomic update of header word on ARM.
koda@google.com [Tue, 28 Oct 2014 15:50:44 +0000 (15:50 +0000)]
Atomic update of header word on ARM.

R=zra@google.com

Review URL: https://codereview.chromium.org//636983003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41360 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoMore code clean-up
brianwilkerson@google.com [Tue, 28 Oct 2014 15:48:15 +0000 (15:48 +0000)]
More code clean-up

R=scheglov@google.com

Review URL: https://codereview.chromium.org//687663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41359 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRevert "Port regexp tests from V8 to Dart."
zerny@google.com [Tue, 28 Oct 2014 13:33:15 +0000 (13:33 +0000)]
Revert "Port regexp tests from V8 to Dart."

Reason: The tests do not run cleanly in checked mode.

TBR=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//687613002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41358 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoCapture group error has been fixed.
zerny@google.com [Tue, 28 Oct 2014 13:11:17 +0000 (13:11 +0000)]
Capture group error has been fixed.

BUG=http://dartbug.com/21396
R=lrn@google.com

Review URL: https://codereview.chromium.org//681313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41357 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRename RegExp_test.dart to regexp_kde_test.dart to avoid conflict with regexp_test...
zerny@google.com [Tue, 28 Oct 2014 13:00:54 +0000 (13:00 +0000)]
Rename RegExp_test.dart to regexp_kde_test.dart to avoid conflict with regexp_test.dart on Windows.

TBR=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//683833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41356 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoSupport for loops in analyzer2dart.
johnniwinther@google.com [Tue, 28 Oct 2014 12:53:15 +0000 (12:53 +0000)]
Support for loops in analyzer2dart.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//683803003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41355 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoPort regexp tests from V8 to Dart.
zerny@google.com [Tue, 28 Oct 2014 12:33:15 +0000 (12:33 +0000)]
Port regexp tests from V8 to Dart.

This adds V8s suite of regular expressions tests. The tests are skipped
for all none d8 runtimes until irregexp has been ported and enabled for
the other runtimes. The tests are enabled when compiling with dart2js
and running with d8.

BUG=http://dartbug.com/21396
R=lrn@google.com

Review URL: https://codereview.chromium.org//667043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41354 260f80e4-7a28-3924-810f-c04153c831b5