external/dart/bleeding_edge.git
2 hours agoEnable loading via service isolate master
johnmccutchan@google.com [Thu, 5 Mar 2015 01:37:05 +0000 (01:37 +0000)]
Enable loading via service isolate

BUG=

Review URL: https://codereview.chromium.org//980043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44251 260f80e4-7a28-3924-810f-c04153c831b5

3 hours agoFix more async machinery (issue 22579 and possibly more to be triaged).
regis@google.com [Thu, 5 Mar 2015 00:42:17 +0000 (00:42 +0000)]
Fix more async machinery (issue 22579 and possibly more to be triaged).
Add regression test.

R=hausner@google.com

Review URL: https://codereview.chromium.org//977243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44250 260f80e4-7a28-3924-810f-c04153c831b5

5 hours agoDisable some Editor tests and reapply using Analysis Server.
scheglov@google.com [Wed, 4 Mar 2015 22:55:28 +0000 (22:55 +0000)]
Disable some Editor tests and reapply using Analysis Server.

All the tests are green locally now.

R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//982653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44249 260f80e4-7a28-3924-810f-c04153c831b5

5 hours agoRollback r=44247, it causes Editor tests failures.
scheglov@google.com [Wed, 4 Mar 2015 22:31:26 +0000 (22:31 +0000)]
Rollback r=44247, it causes Editor tests failures.

TBR

I will create a new CL with both these changes and updated tests.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//977853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44248 260f80e4-7a28-3924-810f-c04153c831b5

6 hours agoTurn on using Analysis Server in Editor by default.
scheglov@google.com [Wed, 4 Mar 2015 22:04:31 +0000 (22:04 +0000)]
Turn on using Analysis Server in Editor by default.

R=brianwilkerson@google.com, danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=18632

Review URL: https://codereview.chromium.org//981653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44247 260f80e4-7a28-3924-810f-c04153c831b5

7 hours agoFix issue 22633
hausner@google.com [Wed, 4 Mar 2015 20:52:48 +0000 (20:52 +0000)]
Fix issue 22633

Put saved try context variables in the right scope when the try
statement has a label.

Added new test.

R=regis@google.com

Review URL: https://codereview.chromium.org//977993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44246 260f80e4-7a28-3924-810f-c04153c831b5

8 hours agoExpose 'typeProvider' from AnalysisContext.
scheglov@google.com [Wed, 4 Mar 2015 19:09:27 +0000 (19:09 +0000)]
Expose 'typeProvider' from AnalysisContext.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//965393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44245 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoUpdate status for macos RawSecureSocket test that times out.
whesse@google.com [Wed, 4 Mar 2015 18:28:41 +0000 (18:28 +0000)]
Update status for macos RawSecureSocket test that times out.

A high priority bug is filed to fix this issue.
BUG=dartbug.com/22658
R=kustermann@google.com

Review URL: https://codereview.chromium.org//979923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44244 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoOverwrite local instrumentation file.
scheglov@google.com [Wed, 4 Mar 2015 18:19:23 +0000 (18:19 +0000)]
Overwrite local instrumentation file.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//977953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44243 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agoFix VM bug with super-constructor invocation and mixins.
fschneider@google.com [Wed, 4 Mar 2015 18:02:40 +0000 (18:02 +0000)]
Fix VM bug with super-constructor invocation and mixins.

When using mixins, the constructor of a super-class was incorrectly
invoked twice if the super() call was not at the end of the initializer
list.

When generating the super constructor call in an implicit constructor, pass
along the phase parameter that comes in instead of invoking all phases.

BUG=dartbug.com/22604
TEST=tests/language/constructor_with_mixin_test.dart
R=hausner@google.com

Review URL: https://codereview.chromium.org//973843005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44242 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agoAdd tests for timers in background isolates in Dartium.
alanknight@google.com [Wed, 4 Mar 2015 17:31:20 +0000 (17:31 +0000)]
Add tests for timers in background isolates in Dartium.

BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//975213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44241 260f80e4-7a28-3924-810f-c04153c831b5

10 hours agofix deferred_multi_app test and change test status to reflect dartium fix
jacobr@google.com [Wed, 4 Mar 2015 17:27:10 +0000 (17:27 +0000)]
fix deferred_multi_app test and change test status to reflect dartium fix

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//974873004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44240 260f80e4-7a28-3924-810f-c04153c831b5

11 hours agofix running from snapshot (once again!)
keertip@google.com [Wed, 4 Mar 2015 16:56:52 +0000 (16:56 +0000)]
fix running from snapshot (once again!)

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//979893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44239 260f80e4-7a28-3924-810f-c04153c831b5

13 hours agoTranslate constructors without bad references.
asgerf@google.com [Wed, 4 Mar 2015 14:42:48 +0000 (14:42 +0000)]
Translate constructors without bad references.

This came up while working on integrity checks for the CPS IR.

- Empty constructors to should not create orphaned references.

- Initializers should not use the body's return continuation object, they should each have their own.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//977553004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44238 260f80e4-7a28-3924-810f-c04153c831b5

13 hours agoIssue 22644. Fix for removing non-Dartdoc comments before a declaration.
scheglov@google.com [Wed, 4 Mar 2015 14:42:23 +0000 (14:42 +0000)]
Issue 22644. Fix for removing non-Dartdoc comments before a declaration.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22644

Review URL: https://codereview.chromium.org//980513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44237 260f80e4-7a28-3924-810f-c04153c831b5

13 hours agoRecommit "Fix issues with Socket shutdown.""
whesse@google.com [Wed, 4 Mar 2015 14:37:34 +0000 (14:37 +0000)]
Recommit "Fix issues with Socket shutdown.""

This recommits revision r44178, which was reverted in r44180, with changes to
fix the issues with Process.stdin.  It also adds a test for issue 22636, duplicate READ_CLOSED message.

Changes from r44187
Test tests/standalone/io/issue_22636_test.dart added.
Line "native.closedReadEventSent = true;" added to _RawSocket._writePipe() in runtime/bin/socket_patch.dart.

BUG=http://dartbug.com/22636
BUG=http://dartbug.com/22637
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//980593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44236 260f80e4-7a28-3924-810f-c04153c831b5

13 hours agoStreamline the CPS IR Visitor interface.
kmillikin@google.com [Wed, 4 Mar 2015 14:31:59 +0000 (14:31 +0000)]
Streamline the CPS IR Visitor interface.

Previously, the visitor interface combined two things: (1) the
interface for visiting concrete IR instruction classes and (2) a
default implementation that called the visit function for the
superclass explicitly (but not through super).  For most classes that
extended Visitor this inherited implementation was used to throw an
exception if a visit method for a new class was forgotten.

Instead, it's better to make this class purely an interface which will
give a static warning when a visit method is forgotten.  This change
forces us to implement methods that previously had an inherited (not
necessary correct) implementation.

BUG=
R=asgerf@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//979693003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44235 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoAdd issue number to suppressions
ricow@google.com [Wed, 4 Mar 2015 13:57:18 +0000 (13:57 +0000)]
Add issue number to suppressions

Thank you for catching this on the original cl

R=karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//978793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44234 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoChanged construction of 'for' loops so that bindings introduced in
asgerf@google.com [Wed, 4 Mar 2015 13:49:18 +0000 (13:49 +0000)]
Changed construction of 'for' loops so that bindings introduced in
enterLoopBody are in scope in the update part.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//979753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44233 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoAdd "force inline" to internal annotations.
floitsch@google.com [Wed, 4 Mar 2015 13:37:06 +0000 (13:37 +0000)]
Add "force inline" to internal annotations.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//962703004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44232 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoFix reference counting bugs in StatementRewriter.
asgerf@google.com [Wed, 4 Mar 2015 13:32:03 +0000 (13:32 +0000)]
Fix reference counting bugs in StatementRewriter.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//970853006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44231 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoFix warning in analyzer2dart.
johnniwinther@google.com [Wed, 4 Mar 2015 13:20:48 +0000 (13:20 +0000)]
Fix warning in analyzer2dart.

BUG=http://dartbug.com/22418
R=floitsch@google.com

Review URL: https://codereview.chromium.org//982543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44230 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agodart2js: Allow to encode side-effects in the spec-string of JS and similar built...
floitsch@google.com [Wed, 4 Mar 2015 13:20:00 +0000 (13:20 +0000)]
dart2js: Allow to encode side-effects in the spec-string of JS and similar built-ins.

This patch prepares a shift towards two builtins. We currently have ~20 foreign functions that must be caught by the resolver, type-inferrer, builder, ...
In the future there will be only two:
JS(...), and JS_BUILTIN(...)

The JS_BUILTIN function would take a string or enum as second argument (after the spec-string) which would be shared between the runtime and the compiler.
This makes it easier to ensure that no builtin is forgotten in the places where they need to be handled.

This patch also gives more flexibility to the implementor.
For example `JS('bool', 'typeof self["foo"] != "undefined"')` would currently trigger a "depends on index store". With this patch the developer could override the automatic side-effect analysis and force the dependency to be empty.

Note: in theory we could make "JS" a BUILTIN itself, but, given its importance, I prefer to keep it separate.

Note2: with the "ForceInline" CL [0] we can keep the old functions (like "JS_GET_FLAG") and just forward to JS_BUILTIN:

@ForceInline()
bool JS_GET_FLAG(String name) {
  // Given: a shared enum `Builtin`.
  return JS_BUILTIN('bool', Builtin.getFlag, name);
}

[0] https://chromiumcodereview.appspot.com/962703004/

R=herhut@google.com, sra@google.com

Review URL: https://codereview.chromium.org//969093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44229 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoMark async/timer_regress22626_test as failing on dart2js-jsshell.
karlklose@google.com [Wed, 4 Mar 2015 13:20:00 +0000 (13:20 +0000)]
Mark async/timer_regress22626_test as failing on dart2js-jsshell.

R=sigurdm@google.com

Review URL: https://codereview.chromium.org//979773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44228 260f80e4-7a28-3924-810f-c04153c831b5

14 hours agoCopy the parameters to a sync* function for each invocation of .iterator
sigurdm@google.com [Wed, 4 Mar 2015 13:09:24 +0000 (13:09 +0000)]
Copy the parameters to a sync* function for each invocation of .iterator

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//977053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44227 260f80e4-7a28-3924-810f-c04153c831b5

15 hours agoFix x64 build broken by r44225.
vegorov@google.com [Wed, 4 Mar 2015 12:20:32 +0000 (12:20 +0000)]
Fix x64 build broken by r44225.

TBR=fschneider@google.com

Review URL: https://codereview.chromium.org//981533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44226 260f80e4-7a28-3924-810f-c04153c831b5

15 hours agoTrack untagged values pushed to the expression stack in unoptimized code.
vegorov@google.com [Wed, 4 Mar 2015 12:12:10 +0000 (12:12 +0000)]
Track untagged values pushed to the expression stack in unoptimized code.

Verify that they are all consumed before we hit any call.

Usage of untagged values should be limited to irregexp backend which utilizes LoadUntagged instruction.

R=fschneider@google.com

Review URL: https://codereview.chromium.org//970233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44225 260f80e4-7a28-3924-810f-c04153c831b5

20 hours agoSuppress two timeouts on chrome mac
ricow@google.com [Wed, 4 Mar 2015 07:28:56 +0000 (07:28 +0000)]
Suppress two timeouts on chrome mac

TBR=floitsch
BUG=22646

Review URL: https://codereview.chromium.org//975303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44223 260f80e4-7a28-3924-810f-c04153c831b5

22 hours agoRevert "Element.style is not null"
sra@google.com [Wed, 4 Mar 2015 05:24:57 +0000 (05:24 +0000)]
Revert "Element.style is not null"

Need to investigate:
FAILED: dart2js-chrome release_ia32 co19/LayoutTests/fast/xsl/default-html_t01
Expected: RuntimeError
Actual: Pass

Review URL: https://codereview.chromium.org//971033004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44222 260f80e4-7a28-3924-810f-c04153c831b5

22 hours agoStop using isDirty() in the reconciler altogether.
scheglov@google.com [Wed, 4 Mar 2015 05:24:01 +0000 (05:24 +0000)]
Stop using isDirty() in the reconciler altogether.

R=danrubel@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//976623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44221 260f80e4-7a28-3924-810f-c04153c831b5

24 hours agoElement.style is not null
sra@google.com [Wed, 4 Mar 2015 03:54:22 +0000 (03:54 +0000)]
Element.style is not null

BUG=

Review URL: https://codereview.chromium.org//960503006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44220 260f80e4-7a28-3924-810f-c04153c831b5

25 hours agoDEPS AutoUpdate: webkit to 191225 (2015-03-03 18:59:13 -0800) rmacnak@google.com
rmacnak@google.com [Wed, 4 Mar 2015 03:01:12 +0000 (03:01 +0000)]
DEPS AutoUpdate: webkit to 191225 (2015-03-03 18:59:13 -0800) rmacnak@google.com
Cherry-pick r191222 "Added alert dialog and console log message if Dartium expiration date is met."
http://src.chromium.org/viewvc/blink?view=rev&revision=191225

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44219 260f80e4-7a28-3924-810f-c04153c831b5

25 hours agoChanged expiration to 52 weeks
terry@google.com [Wed, 4 Mar 2015 02:25:45 +0000 (02:25 +0000)]
Changed expiration to 52 weeks

Reviwers=vsm@google.com,asiva@google.com
BUG=18560
R=asiva@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//973193003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44218 260f80e4-7a28-3924-810f-c04153c831b5

25 hours agoMark fragment-activation-focuses-target_t01 as failing on Dartium (Chromium 39 beta...
rmacnak@google.com [Wed, 4 Mar 2015 02:11:10 +0000 (02:11 +0000)]
Mark fragment-activation-focuses-target_t01 as failing on Dartium (Chromium 39 beta patches).

TBR=vsm@google.com

Review URL: https://codereview.chromium.org//982433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44217 260f80e4-7a28-3924-810f-c04153c831b5

25 hours agoFix more async machinery (capture return value when necessary, issue 22620).
regis@google.com [Wed, 4 Mar 2015 02:08:52 +0000 (02:08 +0000)]
Fix more async machinery (capture return value when necessary, issue 22620).

Review URL: https://codereview.chromium.org//981433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44216 260f80e4-7a28-3924-810f-c04153c831b5

26 hours agoExtend Omni info label to include path of the file defining the element.
scheglov@google.com [Wed, 4 Mar 2015 01:43:49 +0000 (01:43 +0000)]
Extend Omni info label to include path of the file defining the element.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//970373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44215 260f80e4-7a28-3924-810f-c04153c831b5

26 hours agoRestore highlighting for current position.
rmacnak@google.com [Wed, 4 Mar 2015 01:18:42 +0000 (01:18 +0000)]
Restore highlighting for current position.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//974153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44214 260f80e4-7a28-3924-810f-c04153c831b5

27 hours agoPick up merges of src and WebKit 39.0.2171.99, plus upstream DEPS.
rmacnak@google.com [Wed, 4 Mar 2015 00:48:08 +0000 (00:48 +0000)]
Pick up merges of src and WebKit 39.0.2171.99, plus upstream DEPS.

R=vsm@google.com

Review URL: https://codereview.chromium.org//979593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44213 260f80e4-7a28-3924-810f-c04153c831b5

27 hours agoDon't define parameters when visiting a function-typed formal parameter.
paulberry@google.com [Wed, 4 Mar 2015 00:39:14 +0000 (00:39 +0000)]
Don't define parameters when visiting a function-typed formal parameter.

BUG=dartbug.com/13179
R=scheglov@google.com

Review URL: https://codereview.chromium.org//978633003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44212 260f80e4-7a28-3924-810f-c04153c831b5

27 hours agoRemove passing test from dart2dart status file.
regis@google.com [Wed, 4 Mar 2015 00:25:35 +0000 (00:25 +0000)]
Remove passing test from dart2dart status file.

Review URL: https://codereview.chromium.org//970343003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44211 260f80e4-7a28-3924-810f-c04153c831b5

28 hours agoFix async machinery for finally clauses (issues 22445, 22300).
regis@google.com [Tue, 3 Mar 2015 23:55:18 +0000 (23:55 +0000)]
Fix async machinery for finally clauses (issues 22445, 22300).

R=hausner@google.com

Review URL: https://codereview.chromium.org//974073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44210 260f80e4-7a28-3924-810f-c04153c831b5

28 hours agoBring the 1.0.0 verison of the usage package into the svn repo (https://github.com...
devoncarew@google.com [Tue, 3 Mar 2015 23:19:03 +0000 (23:19 +0000)]
Bring the 1.0.0 verison of the usage package into the svn repo (https://github.com/dart-lang/usage).

R=ricow@google.com

Review URL: https://codereview.chromium.org//946933004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44209 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoRevert r44198.
rmacnak@google.com [Tue, 3 Mar 2015 23:01:30 +0000 (23:01 +0000)]
Revert r44198.

TBR=vsm@google.com

Review URL: https://codereview.chromium.org//972413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44208 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoMore formatter integration cleanup.
pquitslund@google.com [Tue, 3 Mar 2015 22:47:55 +0000 (22:47 +0000)]
More formatter integration cleanup.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//976853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44207 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoExclude non-project files altogether.
scheglov@google.com [Tue, 3 Mar 2015 22:28:02 +0000 (22:28 +0000)]
Exclude non-project files altogether.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//974053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44206 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoFix custom server support
brianwilkerson@google.com [Tue, 3 Mar 2015 22:12:15 +0000 (22:12 +0000)]
Fix custom server support

R=scheglov@google.com

Review URL: https://codereview.chromium.org//977743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44205 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoReplace using unconditional _recordPropagatedType() with a conditional _recordPropaga...
scheglov@google.com [Tue, 3 Mar 2015 22:06:00 +0000 (22:06 +0000)]
Replace using unconditional _recordPropagatedType() with a conditional _recordPropagatedTypeIfBetter().

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//974033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44204 260f80e4-7a28-3924-810f-c04153c831b5

30 hours ago[TBR] forgotten file
scheglov@google.com [Tue, 3 Mar 2015 21:55:25 +0000 (21:55 +0000)]
[TBR] forgotten file

Sorry, forgot to add the new file.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//972323002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44203 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoReplace provider polling with listener.
scheglov@google.com [Tue, 3 Mar 2015 21:51:32 +0000 (21:51 +0000)]
Replace provider polling with listener.

So, we refresh only once after search is complete.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//976843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44202 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoSets the native name of static native methods by using the @JSName with the @Native...
het@google.com [Tue, 3 Mar 2015 21:51:12 +0000 (21:51 +0000)]
Sets the native name of static native methods by using the @JSName with the @Native tag of the enclosing class.

BUG=22483
R=sra@google.com

Review URL: https://codereview.chromium.org//971053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44201 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoPreserve selection support for the formatter.
pquitslund@google.com [Tue, 3 Mar 2015 21:27:05 +0000 (21:27 +0000)]
Preserve selection support for the formatter.

R=rnystrom@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//977723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44200 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoFirst cut at analysis driver
brianwilkerson@google.com [Tue, 3 Mar 2015 21:24:25 +0000 (21:24 +0000)]
First cut at analysis driver

R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//913483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44199 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoDEPS AutoUpdate: webkit to 191210 (2015-03-03 13:12:29 -0800) rmacnak@google.com
rmacnak@google.com [Tue, 3 Mar 2015 21:15:43 +0000 (21:15 +0000)]
DEPS AutoUpdate: webkit to 191210 (2015-03-03 13:12:29 -0800) rmacnak@google.com
Merge upstream 39.0.2171.99 (r186555).
http://src.chromium.org/viewvc/blink?view=rev&revision=191210

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44198 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoChange the editor's debugger client to disallow stepping on source lines with the...
devoncarew@google.com [Tue, 3 Mar 2015 20:37:41 +0000 (20:37 +0000)]
Change the editor's debugger client to disallow stepping on source lines with the 'await' keyword.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//974633003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44197 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoFully parse SDK files when analyzing in batch mode.
paulberry@google.com [Tue, 3 Mar 2015 19:47:08 +0000 (19:47 +0000)]
Fully parse SDK files when analyzing in batch mode.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//973683004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44196 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoUpdate to latest dart_style.
rnystrom@google.com [Tue, 3 Mar 2015 19:28:04 +0000 (19:28 +0000)]
Update to latest dart_style.

R=pquitslund@google.com

Review URL: https://codereview.chromium.org//973003003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44195 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoMark test regress_22445_test as failing.
regis@google.com [Tue, 3 Mar 2015 19:22:16 +0000 (19:22 +0000)]
Mark test regress_22445_test as failing.

R=hausner@google.com

Review URL: https://codereview.chromium.org//977633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44194 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoFixium for dartium
hausner@google.com [Tue, 3 Mar 2015 19:16:14 +0000 (19:16 +0000)]
Fixium for dartium

Review URL: https://codereview.chromium.org//970273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44193 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoDead dart_style preference cleanup.
pquitslund@google.com [Tue, 3 Mar 2015 19:14:29 +0000 (19:14 +0000)]
Dead dart_style preference cleanup.

R=danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//971753004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44192 260f80e4-7a28-3924-810f-c04153c831b5

32 hours ago- Make sure we schedule another wakeup when handling a timeout
iposva@google.com [Tue, 3 Mar 2015 19:14:30 +0000 (19:14 +0000)]
- Make sure we schedule another wakeup when handling a timeout
  from the event handler.

Review URL: https://codereview.chromium.org//971193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44191 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoFix memory leak in CPU Profile page
johnmccutchan@google.com [Tue, 3 Mar 2015 19:00:20 +0000 (19:00 +0000)]
Fix memory leak in CPU Profile page

- Programmatically clear all onClick listeners.
- Use an iterative call tree loader.
- Load call trees on demand.
- When a sample was filled before exhausting the call stack, mark that the sample's call stack is truncated.
- Insert '[Truncated]' tag nodes into call trees.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//973553005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44190 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoOne more fix to async machinery (rethrow in finally, issue 22595).
regis@google.com [Tue, 3 Mar 2015 18:34:01 +0000 (18:34 +0000)]
One more fix to async machinery (rethrow in finally, issue 22595).

R=hausner@google.com

Review URL: https://codereview.chromium.org//973103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44189 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoPoint DEPS to a release branch for 2171 (redux).
rmacnak@google.com [Tue, 3 Mar 2015 18:15:42 +0000 (18:15 +0000)]
Point DEPS to a release branch for 2171 (redux).

Branch created with svn cp -m "Branching for 2171_2 @191152" svn://svn.chromium.org/blink/branches/dart/dartium@191152 svn://svn.chromium.org/blink/branches/dart/2171_2

R=vsm@google.com

Review URL: https://codereview.chromium.org//975763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44188 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agofix for running server from snapshot
keertip@google.com [Tue, 3 Mar 2015 18:11:49 +0000 (18:11 +0000)]
fix for running server from snapshot

R=scheglov@google.com

Review URL: https://codereview.chromium.org//970143003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44187 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agofix status_reporter
kevmoo@google.com [Tue, 3 Mar 2015 18:08:26 +0000 (18:08 +0000)]
fix status_reporter

R=ricow@google.com

Review URL: https://codereview.chromium.org//974973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44186 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoImplement async* functions in VM
hausner@google.com [Tue, 3 Mar 2015 17:49:53 +0000 (17:49 +0000)]
Implement async* functions in VM

R=iposva@google.com

Review URL: https://codereview.chromium.org//944893005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44185 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoDon't set a propagate type if the variable has already the same static type.
scheglov@google.com [Tue, 3 Mar 2015 17:39:02 +0000 (17:39 +0000)]
Don't set a propagate type if the variable has already the same static type.

This fixes displaying both "Static type" and "Propagated type" sections in UI.

Maybe also some performance improvement because of avoiding resolving propagated elements.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//971193003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44184 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agofix constructor suggestion element names
danrubel@google.com [Tue, 3 Mar 2015 17:03:24 +0000 (17:03 +0000)]
fix constructor suggestion element names

BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//962243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44183 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoSome clean-ups for Index / SearchEngine.
scheglov@google.com [Tue, 3 Mar 2015 16:54:56 +0000 (16:54 +0000)]
Some clean-ups for Index / SearchEngine.

1. Remove the TODO, it is better to keep searchTopLevelDeclarations() returning Future,
   for consistency and possible future changes.

2. Rename IndexStore.recordTopDeclaration() to recordTopLevelDeclaration().
   Sorry, I missed it initially.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//975753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44182 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoRestore the test for an unknown element search.
scheglov@google.com [Tue, 3 Mar 2015 16:53:54 +0000 (16:53 +0000)]
Restore the test for an unknown element search.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//975743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44181 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoRevert "Fix issues with Socket shutdown."
whesse@google.com [Tue, 3 Mar 2015 16:51:57 +0000 (16:51 +0000)]
Revert "Fix issues with Socket shutdown."

This reverts commit r44178, because it makes 10 tests about process stderr
and stdin fail with timeouts.
Original CL: https://codereview.chromium.org/975723002/

BUG=dartbug.com/22637
BUG=dartbug.com/22636
R=kustermann@google.com

Review URL: https://codereview.chromium.org//974953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44180 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoinclude library prefix suggestions when suggesting constructors
danrubel@google.com [Tue, 3 Mar 2015 16:51:18 +0000 (16:51 +0000)]
include library prefix suggestions when suggesting constructors

BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//972193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44179 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoFix issues with Socket shutdown.
whesse@google.com [Tue, 3 Mar 2015 16:19:23 +0000 (16:19 +0000)]
Fix issues with Socket shutdown.

BUG=dartbug.com/22637
BUG=dartbug.com/22636

Review URL: https://codereview.chromium.org//975723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44178 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoWhen a closure is extracted as a method, it does not have any return type.
scheglov@google.com [Tue, 3 Mar 2015 16:17:33 +0000 (16:17 +0000)]
When a closure is extracted as a method, it does not have any return type.

But it should not be returned as 'void'.
It should be an empty string, as any other method with unknown return type.
I guess we could improve this in the future, e.g. promote type of a returned expression into the signature.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//970063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44177 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoDon't allow to extract a closure as a getter.
scheglov@google.com [Tue, 3 Mar 2015 16:15:47 +0000 (16:15 +0000)]
Don't allow to extract a closure as a getter.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//971203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44176 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoImprove Editor Omni search performance.
scheglov@google.com [Tue, 3 Mar 2015 16:13:15 +0000 (16:13 +0000)]
Improve Editor Omni search performance.

1. Don't send top-level elements search request if the same request was jsut sent, so results are ready, of will be ready.

2. Don't wait for top-level elements results, refresh them periodically.

3. Eliminate delay in scheduling the refresh job, reduce the refresh delay.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//973473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44175 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoadd arguments to constructor completions
danrubel@google.com [Tue, 3 Mar 2015 15:58:50 +0000 (15:58 +0000)]
add arguments to constructor completions

BUG=dartbug.com/22158
R=scheglov@google.com

Review URL: https://codereview.chromium.org//972933002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44174 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoEmit stackmaps even in unoptimized code if slow path pushes untagged values.
vegorov@google.com [Tue, 3 Mar 2015 15:43:32 +0000 (15:43 +0000)]
Emit stackmaps even in unoptimized code if slow path pushes untagged values.

These stackmaps cover only pushed registers region, the rest of the stack (copied parameters, locals and temporaries) will be scanned as tagged values.

R=fschneider@google.com
BUG=http://dartbug.com/22621

Review URL: https://codereview.chromium.org//968183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44173 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoUpdates Debug mode edge count increment lengths for ARMv6.
zra@google.com [Tue, 3 Mar 2015 15:23:16 +0000 (15:23 +0000)]
Updates Debug mode edge count increment lengths for ARMv6.

Includes instructions for future updates.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//975643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44172 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoMissing named parameter.
sigurdm@google.com [Tue, 3 Mar 2015 14:23:30 +0000 (14:23 +0000)]
Missing named parameter.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//969383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44171 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoFix problems with default-cases in async code.
sigurdm@google.com [Tue, 3 Mar 2015 14:20:17 +0000 (14:20 +0000)]
Fix problems with default-cases in async code.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//976603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44170 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoFix warning in deferred_shared_and_unshared_classes_test.
paulberry@google.com [Tue, 3 Mar 2015 13:42:05 +0000 (13:42 +0000)]
Fix warning in deferred_shared_and_unshared_classes_test.

TBR=sigurdm@google.com

Review URL: https://codereview.chromium.org//971353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44169 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoFix of https://codereview.chromium.org//964553004 .
sigurdm@google.com [Tue, 3 Mar 2015 13:31:08 +0000 (13:31 +0000)]
Fix of https://codereview.chromium.org//964553004 .

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//973043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44168 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoChange test to detect checked mode.
karlklose@google.com [Tue, 3 Mar 2015 13:25:10 +0000 (13:25 +0000)]
Change test to detect checked mode.

R=ricow@google.com

Review URL: https://codereview.chromium.org//969393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44167 260f80e4-7a28-3924-810f-c04153c831b5

39 hours agoAnalyze locals in await for loops as inside a try-finally.
sigurdm@google.com [Tue, 3 Mar 2015 12:41:10 +0000 (12:41 +0000)]
Analyze locals in await for loops as inside a try-finally.

Otherwise they do not get the right boxing behavior.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//964553004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44166 260f80e4-7a28-3924-810f-c04153c831b5

39 hours agoMark corelib/hash_set_type_check_test as failing on except the VM.
karlklose@google.com [Tue, 3 Mar 2015 12:31:54 +0000 (12:31 +0000)]
Mark corelib/hash_set_type_check_test as failing on except the VM.

R=ricow@google.com

Review URL: https://codereview.chromium.org//970153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44165 260f80e4-7a28-3924-810f-c04153c831b5

40 hours agodart2js: don't emit unneeded native info.
zarah@google.com [Tue, 3 Mar 2015 11:18:40 +0000 (11:18 +0000)]
dart2js: don't emit unneeded native info.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//957973006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44164 260f80e4-7a28-3924-810f-c04153c831b5

41 hours agoSupport for a dart2js `dartDeferredLoader` hook.
sigurdm@google.com [Tue, 3 Mar 2015 10:12:09 +0000 (10:12 +0000)]
Support for a dart2js `dartDeferredLoader` hook.

Also move deferred loading special casing of d8 and jsshell to
preambles.

BUG=
R=floitsch@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//956953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44163 260f80e4-7a28-3924-810f-c04153c831b5

42 hours agoMove the dart_precompiled function inside scoping function.
sigurdm@google.com [Tue, 3 Mar 2015 09:31:29 +0000 (09:31 +0000)]
Move the dart_precompiled function inside scoping function.

Also make it a property of init.

This is also done for deferred hunks, allowing deferred loading to work
in CSP mode.

Long term I would like the precompiled function to go away, and move
the generated functions into the library-initializer when they are
 needed.

BUG=16898
R=floitsch@google.com

Review URL: https://codereview.chromium.org//968163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44162 260f80e4-7a28-3924-810f-c04153c831b5

42 hours agoIR tracer for try statements.
asgerf@google.com [Tue, 3 Mar 2015 09:23:10 +0000 (09:23 +0000)]
IR tracer for try statements.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//969753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44161 260f80e4-7a28-3924-810f-c04153c831b5

43 hours agodart2Js: bailout early when using the new emitter with mirrors.
zarah@google.com [Tue, 3 Mar 2015 08:59:27 +0000 (08:59 +0000)]
dart2Js: bailout early when using the new emitter with mirrors.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//963753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44160 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRestore context validation code by fixing old typos.
koda@google.com [Tue, 3 Mar 2015 01:46:38 +0000 (01:46 +0000)]
Restore context validation code by fixing old typos.

R=vegorov@google.com

Review URL: https://codereview.chromium.org//968313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44159 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoStatic SPPM-n1 model for Dart Core API usage
lukechurch@google.com [Tue, 3 Mar 2015 01:15:52 +0000 (01:15 +0000)]
Static SPPM-n1 model for Dart Core API usage

R=danrubel@google.com

Review URL: https://codereview.chromium.org//968283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44158 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRevert r44156. Branch for 2171 seems to be inconsistent.
rmacnak@google.com [Tue, 3 Mar 2015 01:14:42 +0000 (01:14 +0000)]
Revert r44156. Branch for 2171 seems to be inconsistent.

Review URL: https://codereview.chromium.org//962193003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44157 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoPoint DEPS to a release branch for 2171.
rmacnak@google.com [Tue, 3 Mar 2015 01:04:28 +0000 (01:04 +0000)]
Point DEPS to a release branch for 2171.

Branch was created with
svn cp -m "Branching for 2171 @191142" svn://svn.chromium.org/blink/branches/dart/dartium@191142 svn://svn.chromium.org/blink/branches/dart/2171

R=vsm@google.com

Review URL: https://codereview.chromium.org//973663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44156 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoCorrect typing of LinkedHashSet.add. Add unit test.
koda@google.com [Tue, 3 Mar 2015 00:44:31 +0000 (00:44 +0000)]
Correct typing of LinkedHashSet.add. Add unit test.

BUG=dart:22605
R=skybrian@google.com

Review URL: https://codereview.chromium.org//971833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44155 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDEPS AutoUpdate: webkit to 191152 (2015-03-02 16:16:24 -0800) jacobr@google.com
vsm@google.com [Tue, 3 Mar 2015 00:23:57 +0000 (00:23 +0000)]
DEPS AutoUpdate: webkit to 191152 (2015-03-02 16:16:24 -0800) jacobr@google.com
Revert "Support multiple DOM isolates and tweak devtools frontend to better handle large #s of libraries with long library names."
http://src.chromium.org/viewvc/blink?view=rev&revision=191152

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44154 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoMore fixes in async machinery (issue 22438 and maybe more).
regis@google.com [Mon, 2 Mar 2015 23:09:01 +0000 (23:09 +0000)]
More fixes in async machinery (issue 22438 and maybe more).
Add a regression test.

R=hausner@google.com

Review URL: https://codereview.chromium.org//969903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44153 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoImproved profiler view and inclusive profile tree
johnmccutchan@google.com [Mon, 2 Mar 2015 23:01:43 +0000 (23:01 +0000)]
Improved profiler view and inclusive profile tree

TableTree improvements:
- Row's have flex-box divs in each table cell.
- To represent depth in tree a colored vertical bar for each depth level is shown
- Expanding tree nodes is now asynchronous and animates.
- Change cursor during tree expansion.

Observatory Profiler improvements:
- Improved appearance.
- Support for inclusive (main first) call trees.
- Replace tooltip hover with info toggle.
- Visual icon attributes for code, functions and call tree nodes.
- Fetching / Load status display.
- Cleaned up Code and Function kinds.

Profiler improvements:
- When not profiling the VM (--profile-vm) only walk the stack when we are in Dart code or have exited Dart code. This removes some native stack walker noise.
- Build inclusive (main first) call trees and send across service.

Notes for analyzer team:

Analyzer command line:

./out/ReleaseIA32/dart --keep-code --trace-profiler --profile-depth=128 --observe out/ReleaseIA32/dart-sdk/bin/snapshots/dartanalyzer.dart.snapshot --dart-sdk=out/ReleaseIA32/dart-sdk pkg/compiler/lib/src/dart2js.dart

Profiler settings:

- Tags: None or VM
- Mode: Function
- Direction: Bottom up

R=asiva@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//965593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44152 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoReformat
brianwilkerson@google.com [Mon, 2 Mar 2015 22:43:12 +0000 (22:43 +0000)]
Reformat

R=paulberry@google.com

Review URL: https://codereview.chromium.org//969113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@44151 260f80e4-7a28-3924-810f-c04153c831b5