external/dart/bleeding_edge.git
14 min agoAdd timing of serialization master
brianwilkerson@google.com [Thu, 23 Oct 2014 19:38:17 +0000 (19:38 +0000)]
Add timing of serialization

R=scheglov@google.com

Review URL: https://codereview.chromium.org//666913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41270 260f80e4-7a28-3924-810f-c04153c831b5

17 min agoFix type of String.fromEnvironment() when the name is undefined.
paulberry@google.com [Thu, 23 Oct 2014 19:35:53 +0000 (19:35 +0000)]
Fix type of String.fromEnvironment() when the name is undefined.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//674953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41269 260f80e4-7a28-3924-810f-c04153c831b5

21 min agoBy default, don't use observatory during integration tests.
paulberry@google.com [Thu, 23 Oct 2014 19:31:48 +0000 (19:31 +0000)]
By default, don't use observatory during integration tests.

TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//676623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41268 260f80e4-7a28-3924-810f-c04153c831b5

34 min agoAdd support for attaching observatory to the server.
brianwilkerson@google.com [Thu, 23 Oct 2014 19:18:08 +0000 (19:18 +0000)]
Add support for attaching observatory to the server.

R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//651243005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41267 260f80e4-7a28-3924-810f-c04153c831b5

46 min ago(TBR) fix code completion ctrl-space when not using analysis server
danrubel@google.com [Thu, 23 Oct 2014 19:06:54 +0000 (19:06 +0000)]
(TBR) fix code completion ctrl-space when not using analysis server

BUG=dartbug.com/21399

Review URL: https://codereview.chromium.org//674983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41266 260f80e4-7a28-3924-810f-c04153c831b5

81 min agoFix for DartPriorityFilesHelper_NEW test.
scheglov@google.com [Thu, 23 Oct 2014 18:31:23 +0000 (18:31 +0000)]
Fix for DartPriorityFilesHelper_NEW test.

TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//672983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41265 260f80e4-7a28-3924-810f-c04153c831b5

92 min ago- Make sure the VM actually asks for libdl when being linked.
iposva@google.com [Thu, 23 Oct 2014 18:20:50 +0000 (18:20 +0000)]
- Make sure the VM actually asks for libdl when being linked.

R=asiva@google.com

Review URL: https://codereview.chromium.org//678453003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41264 260f80e4-7a28-3924-810f-c04153c831b5

102 min agoDelay sending analysis_setPriorityFiles to send only a final state.
scheglov@google.com [Thu, 23 Oct 2014 18:11:02 +0000 (18:11 +0000)]
Delay sending analysis_setPriorityFiles to send only a final state.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//670393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41263 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoBump multivm DEPS
rmacnak@google.com [Thu, 23 Oct 2014 17:35:41 +0000 (17:35 +0000)]
Bump multivm DEPS

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41262 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoIssue 21377. Specify that navigation regions are sorted and implement it.
scheglov@google.com [Thu, 23 Oct 2014 17:18:13 +0000 (17:18 +0000)]
Issue 21377. Specify that navigation regions are sorted and implement it.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21377

Review URL: https://codereview.chromium.org//649853004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41261 260f80e4-7a28-3924-810f-c04153c831b5

3 hours agorelease template_binding
sigmund@google.com [Thu, 23 Oct 2014 16:12:50 +0000 (16:12 +0000)]
release template_binding

Review URL: https://codereview.chromium.org//675773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41260 260f80e4-7a28-3924-810f-c04153c831b5

4 hours agoAdd third_party NSS, SQLite, and zlib to Dart LICENSE file
whesse@google.com [Thu, 23 Oct 2014 15:32:16 +0000 (15:32 +0000)]
Add third_party NSS, SQLite, and zlib to Dart LICENSE file

BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//657893004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41259 260f80e4-7a28-3924-810f-c04153c831b5

9 hours agoEnable isInstantiated invariant in ClassWorld.
johnniwinther@google.com [Thu, 23 Oct 2014 10:11:00 +0000 (10:11 +0000)]
Enable isInstantiated invariant in ClassWorld.

BUG=
R=herhut@google.com

Review URL: https://codereview.chromium.org//675463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41258 260f80e4-7a28-3924-810f-c04153c831b5

12 hours agoSupport unreachable code in blocks in analyzer2dart.
johnniwinther@google.com [Thu, 23 Oct 2014 06:57:44 +0000 (06:57 +0000)]
Support unreachable code in blocks in analyzer2dart.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//669693002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41256 260f80e4-7a28-3924-810f-c04153c831b5

13 hours agoAdd SExpression test and share tests between dart2dart and analyzer2dart.
johnniwinther@google.com [Thu, 23 Oct 2014 06:45:04 +0000 (06:45 +0000)]
Add SExpression test and share tests between dart2dart and analyzer2dart.

BUG=
R=paulberry@google.com, sigurdm@google.com

Review URL: https://codereview.chromium.org//669673006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41255 260f80e4-7a28-3924-810f-c04153c831b5

15 hours agoIssue 21375. Fix for FunctionTypeAliasElement-based FunctionType source.
scheglov@google.com [Thu, 23 Oct 2014 04:24:59 +0000 (04:24 +0000)]
Issue 21375. Fix for FunctionTypeAliasElement-based FunctionType source.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21375

Review URL: https://codereview.chromium.org//672013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41254 260f80e4-7a28-3924-810f-c04153c831b5

19 hours agoAdd package root setting to analysis server API.
paulberry@google.com [Thu, 23 Oct 2014 00:11:36 +0000 (00:11 +0000)]
Add package root setting to analysis server API.

The command does not have any effect yet.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//672003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41253 260f80e4-7a28-3924-810f-c04153c831b5

22 hours agoRecord types of invoked variables.
scheglov@google.com [Wed, 22 Oct 2014 21:52:26 +0000 (21:52 +0000)]
Record types of invoked variables.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//673673002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41252 260f80e4-7a28-3924-810f-c04153c831b5

23 hours agoAvoid races in capacity accounting.
koda@google.com [Wed, 22 Oct 2014 20:41:44 +0000 (20:41 +0000)]
Avoid races in capacity accounting.

Use pages_lock_ to sync access to usage_.capacity_in_words.
Also remove ASSERT no longer valid with concurrent sweep.

This does not resolve the more general issue of the growth policy not being perpared for concurrent sweeping.

BUG=21363
R=iposva@google.com

Review URL: https://codereview.chromium.org//670973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41251 260f80e4-7a28-3924-810f-c04153c831b5

23 hours agoSkip broken-ideographic-font_t01 co19 test on mac (timing out)
leafp@google.com [Wed, 22 Oct 2014 20:36:01 +0000 (20:36 +0000)]
Skip broken-ideographic-font_t01 co19 test on mac (timing out)

Should bring dartium mac full bot back to green.

TBR=vsm@google.com

BUG=

Review URL: https://codereview.chromium.org//640063006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41250 260f80e4-7a28-3924-810f-c04153c831b5

24 hours agoClean up dart2js DateTime class for better codegen
sra@google.com [Wed, 22 Oct 2014 19:46:37 +0000 (19:46 +0000)]
Clean up dart2js DateTime class for better codegen

Two changes lead to better date code:
- Ensure that the fields of DataTime are inferred as non-null.
- Defer lazyAsJsDate.

Example generated code:
before:

      t1 = Date.now();
      new P.DateTime(t1, false).DateTime$_now$0();
      if (typeof t1 !== "number")
        return t1.$add();
      minTime = t1 + 16;

after:
      minTime = Date.now() + 16;

BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//667333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41249 260f80e4-7a28-3924-810f-c04153c831b5

25 hours agoSupply a package root when editor runs analysis server from source.
paulberry@google.com [Wed, 22 Oct 2014 18:02:03 +0000 (18:02 +0000)]
Supply a package root when editor runs analysis server from source.

Since the correct package root depends on the user's build
configuration and OS, we don't bother trying to infer it.  The user
should supply it using the "-Dcom.google.dart.packageRoot" option to
editor.

This only takes effect if the argument "-Dcom.google.dart.svnRoot" has
been supplied to force editor to run the analysis server from source.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//671013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41248 260f80e4-7a28-3924-810f-c04153c831b5

27 hours agoupdate pubspec/changelog
jakemac@google.com [Wed, 22 Oct 2014 16:44:04 +0000 (16:44 +0000)]
update pubspec/changelog

R=sigmund@google.com

Review URL: https://codereview.chromium.org//675503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41247 260f80e4-7a28-3924-810f-c04153c831b5

28 hours agoAdd an integration test to verify that server I/O is asynchronous.
paulberry@google.com [Wed, 22 Oct 2014 15:48:06 +0000 (15:48 +0000)]
Add an integration test to verify that server I/O is asynchronous.

Currently disabled, since server I/O is currently synchronous.

BUG=dartbug.com/21252
R=danrubel@google.com

Review URL: https://codereview.chromium.org//668953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41246 260f80e4-7a28-3924-810f-c04153c831b5

28 hours agofix duplicate script issue
jakemac@google.com [Wed, 22 Oct 2014 15:33:27 +0000 (15:33 +0000)]
fix duplicate script issue

BUG= http://dartbug.com/21332
R=sigmund@google.com

Review URL: https://codereview.chromium.org//662013004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41245 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agodart2js: add --preserve-uris flag.
floitsch@google.com [Wed, 22 Oct 2014 09:05:26 +0000 (09:05 +0000)]
dart2js: add --preserve-uris flag.

R=blois@google.com, johnniwinther@google.com, nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41205
Reverted: https://code.google.com/p/dart/source/detail?r=41206

Review URL: https://codereview.chromium.org//582753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41244 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agodart2js: Support eagerly initialized classes in new emitter.
floitsch@google.com [Wed, 22 Oct 2014 07:48:16 +0000 (07:48 +0000)]
dart2js: Support eagerly initialized classes in new emitter.

Supersedes https://codereview.chromium.org/647023005/

R=kasperl@google.com

Review URL: https://codereview.chromium.org//650953003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41243 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoRevert revision 41241
ricow@google.com [Wed, 22 Oct 2014 05:56:53 +0000 (05:56 +0000)]
Revert revision 41241

Issue 21387  seems to have already been fixed in 41240

Review URL: https://codereview.chromium.org//636283008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41242 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoMark standalone/vmservice/websocket_client_test as flaky on the vm
ricow@google.com [Wed, 22 Oct 2014 05:48:39 +0000 (05:48 +0000)]
Mark standalone/vmservice/websocket_client_test as flaky on the vm

Filed issue 21387 to track this

R=iposva@google.com

Review URL: https://codereview.chromium.org//667383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41241 260f80e4-7a28-3924-810f-c04153c831b5

46 hours agoIgnore GC events in websocket_client_test
johnmccutchan@google.com [Tue, 21 Oct 2014 21:43:14 +0000 (21:43 +0000)]
Ignore GC events in websocket_client_test

BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//671603006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41240 260f80e4-7a28-3924-810f-c04153c831b5

46 hours agoFix History Cross Frame resolver string
leafp@google.com [Tue, 21 Oct 2014 21:25:12 +0000 (21:25 +0000)]
Fix History Cross Frame resolver string

TBR=vsm@google.com

BUG=

Review URL: https://codereview.chromium.org//665413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41239 260f80e4-7a28-3924-810f-c04153c831b5

46 hours agoBetter recovery for getters in functions
brianwilkerson@google.com [Tue, 21 Oct 2014 21:17:28 +0000 (21:17 +0000)]
Better recovery for getters in functions

R=scheglov@google.com

Review URL: https://codereview.chromium.org//668083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41238 260f80e4-7a28-3924-810f-c04153c831b5

46 hours agoDEPS AutoUpdate: webkit to 184118 (2014-10-21 13:41:29 -0700) leafp@google.com
leafp@google.com [Tue, 21 Oct 2014 21:04:53 +0000 (21:04 +0000)]
DEPS AutoUpdate: webkit to 184118 (2014-10-21 13:41:29 -0700) leafp@google.com
C++ overload resolution in bindings layer
http://src.chromium.org/viewvc/blink?view=rev&revision=184118

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41237 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoArity indexing in dart:blink entry points
leafp@google.com [Tue, 21 Oct 2014 20:46:55 +0000 (20:46 +0000)]
Arity indexing in dart:blink entry points

This CL replaces type mangling on the blink entry points with arity indexing.  So overloaded methods or methods with optional arguments now dispatch to blink entries specific to their number of arguments (but not their types).  This relies on C++ overload resolution being in place on the blink side (see https://codereview.chromium.org/668733002/).  For the time being, the dart side overload resolution code is left in place.

Resolver strings now have no type or arity info as well.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//667983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41236 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoIssue 21373. Fix for removing line info in case of exception (causes NPE in outline...
scheglov@google.com [Tue, 21 Oct 2014 20:34:31 +0000 (20:34 +0000)]
Issue 21373. Fix for removing line info in case of exception (causes NPE in outline computer).

I will update analysis_server/pubspec.yaml before commit.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21373

Review URL: https://codereview.chromium.org//652903006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41235 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoExpect int64_list_load_store_test to fail for dart2js
johnmccutchan@google.com [Tue, 21 Oct 2014 20:30:34 +0000 (20:30 +0000)]
Expect int64_list_load_store_test to fail for dart2js

BUG=

Review URL: https://codereview.chromium.org//644433005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41234 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd unboxed Mint for X64
johnmccutchan@google.com [Tue, 21 Oct 2014 18:11:43 +0000 (18:11 +0000)]
Add unboxed Mint for X64

BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org//626223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41233 260f80e4-7a28-3924-810f-c04153c831b5

2 days agochange icon/message for add package
keertip@google.com [Tue, 21 Oct 2014 17:29:00 +0000 (17:29 +0000)]
change icon/message for add package

R=danrubel@google.com

Review URL: https://codereview.chromium.org//667903005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41232 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix http://dartbug.com/21335
iposva@google.com [Tue, 21 Oct 2014 17:00:16 +0000 (17:00 +0000)]
Fix http://dartbug.com/21335
- Make the VM internal AssertionError, TypeError and CastError implement
  the public classes instead of patching them.

R=asiva@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//669733004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41231 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 21372. "Convert into block body" and "Convert into expression body" for factory...
scheglov@google.com [Tue, 21 Oct 2014 15:32:55 +0000 (15:32 +0000)]
Issue 21372. "Convert into block body" and "Convert into expression body" for factory constructors.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21372

Review URL: https://codereview.chromium.org//664403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41230 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd tree shaker support for setters and field writes.
paulberry@google.com [Tue, 21 Oct 2014 15:17:06 +0000 (15:17 +0000)]
Add tree shaker support for setters and field writes.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//652613004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41229 260f80e4-7a28-3924-810f-c04153c831b5

2 days agomove DartEditor.ini to dart directory in mac build
danrubel@google.com [Tue, 21 Oct 2014 13:31:14 +0000 (13:31 +0000)]
move DartEditor.ini to dart directory in mac build

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//667893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41228 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoClean up scripts to run Java-based analyzer.
paulberry@google.com [Tue, 21 Oct 2014 13:02:37 +0000 (13:02 +0000)]
Clean up scripts to run Java-based analyzer.

sdk/bin/dartanalyzer_developer is renamed sdk/bin/dartanalyzer_java
(replacing the old sdk/bin/dartanalyzer_java, which was unused), and
the test infrastructure is modified to use sdk/bin/dartanalyzer_java
to start the Java-based analyzer.

This frees up sdk/bin/dartanallyzer_developer to be the --host-checked
version of sdk/bin/dartanalyzer (paralleling what we do for
/sdk/bin/dart2js_developer).

R=ricow@google.com

Review URL: https://codereview.chromium.org//668743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41227 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDEPS AutoUpdate: webkit to 184080 (2014-10-21 05:49:42 -0700) terry@google.com
vsm@google.com [Tue, 21 Oct 2014 12:51:49 +0000 (12:51 +0000)]
DEPS AutoUpdate: webkit to 184080 (2014-10-21 05:49:42 -0700) terry@google.com
Initial migration
http://src.chromium.org/viewvc/blink?view=rev&revision=184080

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41226 260f80e4-7a28-3924-810f-c04153c831b5

2 days agodart2js: Use `Array` as marker value for constant lists in the new emitter.
floitsch@google.com [Tue, 21 Oct 2014 10:55:35 +0000 (10:55 +0000)]
dart2js: Use `Array` as marker value for constant lists in the new emitter.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//667683003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41225 260f80e4-7a28-3924-810f-c04153c831b5

2 days agodart2js: Don't use 'init' as a marker for existing fields in makeConstantList.
floitsch@google.com [Tue, 21 Oct 2014 10:51:58 +0000 (10:51 +0000)]
dart2js: Don't use 'init' as a marker for existing fields in makeConstantList.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//660293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41224 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoVM: Avoid repeated deoptimizations from hoisted array bounds checks.
fschneider@google.com [Tue, 21 Oct 2014 10:36:52 +0000 (10:36 +0000)]
VM: Avoid repeated deoptimizations from hoisted array bounds checks.

R=vegorov@google.com

Review URL: https://codereview.chromium.org//662543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41223 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix typemask bug.
johnniwinther@google.com [Tue, 21 Oct 2014 10:34:45 +0000 (10:34 +0000)]
Fix typemask bug.

* Enforce normalization of typemasks
* Improves message on assertion failure

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//662513006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41222 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRevert "Mac no longer fire bogus events. Fix Mac watcher."
ajohnsen@google.com [Tue, 21 Oct 2014 07:43:59 +0000 (07:43 +0000)]
Revert "Mac no longer fire bogus events. Fix Mac watcher."

BUG=

Review URL: https://codereview.chromium.org//670653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41221 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoMac no longer fire bogus events. Fix Mac watcher.
ajohnsen@google.com [Tue, 21 Oct 2014 06:06:19 +0000 (06:06 +0000)]
Mac no longer fire bogus events. Fix Mac watcher.

This is a re-apply of r37162.

BUG=
R=nweiz@google.com

Review URL: https://codereview.chromium.org//621813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41220 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDisable actions in the Files view menu that are not allowed for pub cache projects.
scheglov@google.com [Tue, 21 Oct 2014 03:25:45 +0000 (03:25 +0000)]
Disable actions in the Files view menu that are not allowed for pub cache projects.

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//654773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41219 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix test timeout; faster DEBUG String::CharAt by not using mutable accessor.
koda@google.com [Tue, 21 Oct 2014 00:15:43 +0000 (00:15 +0000)]
Fix test timeout; faster DEBUG String::CharAt by not using mutable accessor.

BUG=dart:21343
R=iposva@google.com

Review URL: https://codereview.chromium.org//666993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41218 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoSet command-line breakpoints using the path suffix.
devoncarew@google.com [Mon, 20 Oct 2014 22:59:51 +0000 (22:59 +0000)]
Set command-line breakpoints using the path suffix.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//669613006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41217 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix java-based analyzer status for test modifications in r41054.
paulberry@google.com [Mon, 20 Oct 2014 22:11:36 +0000 (22:11 +0000)]
Fix java-based analyzer status for test modifications in r41054.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//665823005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41216 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 21238. Fix for NPE in occurrences computer when FieldFormalParameterElement...
scheglov@google.com [Mon, 20 Oct 2014 21:26:09 +0000 (21:26 +0000)]
Issue 21238. Fix for NPE in occurrences computer when FieldFormalParameterElement references unresolved field.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21238

Review URL: https://codereview.chromium.org//668763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41215 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 21267. Check if DartConsoleManager is null (after shutdown?).
scheglov@google.com [Mon, 20 Oct 2014 21:01:31 +0000 (21:01 +0000)]
Issue 21267. Check if DartConsoleManager is null (after shutdown?).

R=devoncarew@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21267

Review URL: https://codereview.chromium.org//665173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41214 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix for file to URI mapping.
scheglov@google.com [Mon, 20 Oct 2014 21:00:49 +0000 (21:00 +0000)]
Fix for file to URI mapping.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//665153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41213 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoUse UriToFileResolver to convert BPs file paths to package URIs.
scheglov@google.com [Mon, 20 Oct 2014 20:45:26 +0000 (20:45 +0000)]
Use UriToFileResolver to convert BPs file paths to package URIs.

R=devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//669773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41212 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRemove debug output in PubCacheManager_NEW.
scheglov@google.com [Mon, 20 Oct 2014 20:41:26 +0000 (20:41 +0000)]
Remove debug output in PubCacheManager_NEW.

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//671523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41211 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoReapply "Stop suppressing generation of bindings with Promise. Add some tests for...
rmacnak@google.com [Mon, 20 Oct 2014 18:27:03 +0000 (18:27 +0000)]
Reapply "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises."

Fix static warning in storage_quota_test.

Fix status of fontface_loaded_test.

R=leafp@google.com

Review URL: https://codereview.chromium.org//658903005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41210 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoFix for NPE when attempt to open Element with null Source.
scheglov@google.com [Mon, 20 Oct 2014 18:26:02 +0000 (18:26 +0000)]
Fix for NPE when attempt to open Element with null Source.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//660393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41209 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoSuppress new Request type in dart:html
vsm@google.com [Mon, 20 Oct 2014 17:57:14 +0000 (17:57 +0000)]
Suppress new Request type in dart:html

This is conflicting with the Request type in IDB.  Hiding it for now.  We may want to expose with a different name or factor out into a service worker library.

BUG=http://dartbug.com/21341
R=blois@google.com

Review URL: https://codereview.chromium.org//666543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41208 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoSkip bad tests temporarily.
ahe@google.com [Mon, 20 Oct 2014 17:13:12 +0000 (17:13 +0000)]
Skip bad tests temporarily.

Review URL: https://codereview.chromium.org//652543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41207 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRevert "dart2js: add --preserve-uris flag."
floitsch@google.com [Mon, 20 Oct 2014 16:47:09 +0000 (16:47 +0000)]
Revert "dart2js: add --preserve-uris flag."

This reverts commit r41205.

Review URL: https://codereview.chromium.org//666843004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41206 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js: add --preserve-uris flag.
floitsch@google.com [Mon, 20 Oct 2014 16:32:57 +0000 (16:32 +0000)]
dart2js: add --preserve-uris flag.

R=blois@google.com, johnniwinther@google.com, nweiz@google.com

Review URL: https://codereview.chromium.org//582753002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41205 260f80e4-7a28-3924-810f-c04153c831b5

3 days agorename Installed Packages => Referenced packages, update on changes to pubspec
keertip@google.com [Mon, 20 Oct 2014 16:01:20 +0000 (16:01 +0000)]
rename Installed Packages => Referenced packages, update on changes to pubspec

R=scheglov@google.com

Review URL: https://codereview.chromium.org//667433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41204 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoTweak to fix tests after 'Referenced Packages' CL.
scheglov@google.com [Mon, 20 Oct 2014 15:36:03 +0000 (15:36 +0000)]
Tweak to fix tests after 'Referenced Packages' CL.

TBR

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//649723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41203 260f80e4-7a28-3924-810f-c04153c831b5

3 days ago- Rename flags to reflect the generation impacted.
iposva@google.com [Mon, 20 Oct 2014 15:26:04 +0000 (15:26 +0000)]
- Rename flags to reflect the generation impacted.

R=koda@google.com

Review URL: https://codereview.chromium.org//668473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41202 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoApply updates to static methods.
ahe@google.com [Mon, 20 Oct 2014 15:20:45 +0000 (15:20 +0000)]
Apply updates to static methods.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//659813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41201 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoFix build: packages is an ignored folder.
scheglov@google.com [Mon, 20 Oct 2014 15:16:08 +0000 (15:16 +0000)]
Fix build: packages is an ignored folder.

TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//666883003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41200 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUse 'Referenced Packages' node when run with the Analysis Server.
scheglov@google.com [Mon, 20 Oct 2014 15:05:11 +0000 (15:05 +0000)]
Use 'Referenced Packages' node when run with the Analysis Server.

It automatically opens all referenced package+version pairs as Eclipse projects,
or removes if some pair is not used anymore. So, we can find corresponding
resources for stack traces on the console, breakpoints, navigation.

R=brianwilkerson@google.com, danrubel@google.com, keertip@google.com
BUG=

Review URL: https://codereview.chromium.org//660653009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41199 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoFix for getAnalysisContext()
scheglov@google.com [Mon, 20 Oct 2014 15:03:50 +0000 (15:03 +0000)]
Fix for getAnalysisContext()

There was a bug when there are two contexts in folders prefix/test and prefix/test2.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//668513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41198 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUriResolver for java: URIs.
scheglov@google.com [Mon, 20 Oct 2014 15:02:20 +0000 (15:02 +0000)]
UriResolver for java: URIs.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//662953002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41197 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js: Support lazily initialized variables in the new emitter.
floitsch@google.com [Mon, 20 Oct 2014 14:39:57 +0000 (14:39 +0000)]
dart2js: Support lazily initialized variables in the new emitter.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//667493004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41196 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js: Enable explicit getters and setters in new emitter.
floitsch@google.com [Mon, 20 Oct 2014 14:29:02 +0000 (14:29 +0000)]
dart2js: Enable explicit getters and setters in new emitter.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//644433004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41195 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js: Add support for getters and setters to the new emitter.
floitsch@google.com [Mon, 20 Oct 2014 14:27:58 +0000 (14:27 +0000)]
dart2js: Add support for getters and setters to the new emitter.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//658373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41194 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAdd support for constructors and fields.
floitsch@google.com [Mon, 20 Oct 2014 14:22:34 +0000 (14:22 +0000)]
Add support for constructors and fields.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//665473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41193 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js: Add makeConstantList to new emitter.
floitsch@google.com [Mon, 20 Oct 2014 14:10:15 +0000 (14:10 +0000)]
dart2js: Add makeConstantList to new emitter.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//662053002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41192 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoIntroduced hash valued location markers in the spec
eernst@google.com [Mon, 20 Oct 2014 14:02:23 +0000 (14:02 +0000)]
Introduced hash valued location markers in the spec

Introduced support for adding SHA1 hash valued location markers
at several levels in the language specification, added long explanatory
comment at the end, added a script 'addlatexhash.dart' to normalize
spacing, remove comments, etc., in the spec, such that the hash values
are more robust than they would be with a direct usage of the spec.

The script passes the "dvi2tty test", that is, when the location markers
are empty, the resulting *.dvi files created from dartLangSpec.tex and
from the version processed by the script give rise to the same text via
dvi2tty, i.e., the script does not destroy the spec.

R=gbracha@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//646003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41191 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUpdate try status file.
floitsch@google.com [Mon, 20 Oct 2014 12:52:33 +0000 (12:52 +0000)]
Update try status file.

R=ahe@google.com

Review URL: https://codereview.chromium.org//660673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41190 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoTerminate browsers in sequence.
ahe@google.com [Mon, 20 Oct 2014 12:32:50 +0000 (12:32 +0000)]
Terminate browsers in sequence.

Also make iframe larger.

R=whesse@google.com

Review URL: https://codereview.chromium.org//660823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41189 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoSupport conditional expressions in analyzer2dart.
johnniwinther@google.com [Mon, 20 Oct 2014 12:27:21 +0000 (12:27 +0000)]
Support conditional expressions in analyzer2dart.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//666863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41188 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoIgnore redundant parallel moves when checking if a block is empty.
vegorov@google.com [Mon, 20 Oct 2014 11:29:19 +0000 (11:29 +0000)]
Ignore redundant parallel moves when checking if a block is empty.

Single predecessor blocks containing nothing but redundant parallel moves can be compacted away.

R=zerny@google.com
BUG=http://dartbug.com/21302

Review URL: https://codereview.chromium.org//669613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41187 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoSupport if-statements in analyzer2dart.
johnniwinther@google.com [Mon, 20 Oct 2014 10:21:13 +0000 (10:21 +0000)]
Support if-statements in analyzer2dart.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//662363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41186 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js: Remove dead code.
floitsch@google.com [Mon, 20 Oct 2014 07:29:22 +0000 (07:29 +0000)]
dart2js: Remove dead code.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//663813004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41185 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoCleanup constant building in IrBuilder.
johnniwinther@google.com [Mon, 20 Oct 2014 07:21:12 +0000 (07:21 +0000)]
Cleanup constant building in IrBuilder.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//657373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41184 260f80e4-7a28-3924-810f-c04153c831b5

5 days agofix failing test
danrubel@google.com [Sat, 18 Oct 2014 16:48:28 +0000 (16:48 +0000)]
fix failing test

BUG=

Review URL: https://codereview.chromium.org//669483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41183 260f80e4-7a28-3924-810f-c04153c831b5

5 days ago- Do not attempt to set parameter types if they
iposva@google.com [Fri, 17 Oct 2014 21:50:28 +0000 (21:50 +0000)]
- Do not attempt to set parameter types if they
  were already finalized.

R=zra@google.com

Review URL: https://codereview.chromium.org//652743007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41182 260f80e4-7a28-3924-810f-c04153c831b5

5 days agofix typo in error mesage polymer#42
sigmund@google.com [Fri, 17 Oct 2014 20:38:54 +0000 (20:38 +0000)]
fix typo in error mesage polymer#42

R=jakemac@google.com

Review URL: https://codereview.chromium.org//664713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41181 260f80e4-7a28-3924-810f-c04153c831b5

6 days agoDisable tests to fix the build
brianwilkerson@google.com [Fri, 17 Oct 2014 18:35:21 +0000 (18:35 +0000)]
Disable tests to fix the build

Review URL: https://codereview.chromium.org//664773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41180 260f80e4-7a28-3924-810f-c04153c831b5

6 days agoimprove suggestion param and sorting
danrubel@google.com [Fri, 17 Oct 2014 17:39:03 +0000 (17:39 +0000)]
improve suggestion param and sorting

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//658383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41179 260f80e4-7a28-3924-810f-c04153c831b5

6 days agoimprove element parameter string returned by local suggestion computer
danrubel@google.com [Fri, 17 Oct 2014 17:37:37 +0000 (17:37 +0000)]
improve element parameter string returned by local suggestion computer

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//664523003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41178 260f80e4-7a28-3924-810f-c04153c831b5

6 days agoupdate keyword suggestion priorities
danrubel@google.com [Fri, 17 Oct 2014 17:35:41 +0000 (17:35 +0000)]
update keyword suggestion priorities

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//666473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41177 260f80e4-7a28-3924-810f-c04153c831b5

6 days agoupdate protocol server getter test
danrubel@google.com [Fri, 17 Oct 2014 17:34:27 +0000 (17:34 +0000)]
update protocol server getter test

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//662013002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41176 260f80e4-7a28-3924-810f-c04153c831b5

6 days agoremove duplicate packages in fuzz test
danrubel@google.com [Fri, 17 Oct 2014 17:32:42 +0000 (17:32 +0000)]
remove duplicate packages in fuzz test

BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//656533004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41175 260f80e4-7a28-3924-810f-c04153c831b5

6 days agoDEPS AutoUpdate: webkit to 183905 (2014-10-17 10:21:01 -0700) terry@google.com
vsm@google.com [Fri, 17 Oct 2014 17:26:49 +0000 (17:26 +0000)]
DEPS AutoUpdate: webkit to 183905 (2014-10-17 10:21:01 -0700) terry@google.com
Reuse more V8 code for attributes
http://src.chromium.org/viewvc/blink?view=rev&revision=183905

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41174 260f80e4-7a28-3924-810f-c04153c831b5

6 days ago- Add a separate step to finalize the VM isolate explicitly.
iposva@google.com [Fri, 17 Oct 2014 17:02:19 +0000 (17:02 +0000)]
- Add a separate step to finalize the VM isolate explicitly.
- Allocate the method extractor parameter types and names
  only once, namely in the VM isolate.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//664593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41173 260f80e4-7a28-3924-810f-c04153c831b5

6 days agoAdd (as yet unused) task
brianwilkerson@google.com [Fri, 17 Oct 2014 16:57:33 +0000 (16:57 +0000)]
Add (as yet unused) task

R=scheglov@google.com

Review URL: https://codereview.chromium.org//660203003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41172 260f80e4-7a28-3924-810f-c04153c831b5

6 days agoAdd command-line options for instrumentation
brianwilkerson@google.com [Fri, 17 Oct 2014 16:47:11 +0000 (16:47 +0000)]
Add command-line options for instrumentation

R=paulberry@google.com

Review URL: https://codereview.chromium.org//664743002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41171 260f80e4-7a28-3924-810f-c04153c831b5

6 days agoUse launch-specific UriToFileResolver to convert URIs to/from files.
scheglov@google.com [Fri, 17 Oct 2014 16:36:20 +0000 (16:36 +0000)]
Use launch-specific UriToFileResolver to convert URIs to/from files.

R=devoncarew@google.com
BUG=

Review URL: https://codereview.chromium.org//637283006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@41170 260f80e4-7a28-3924-810f-c04153c831b5