external/dart/bleeding_edge.git
20 min agoAdds intrinsics for Float64Array [] and []=. master
zra@google.com [Tue, 22 Jul 2014 23:16:07 +0000 (23:16 +0000)]
Adds intrinsics for Float64Array [] and []=.

Improves performance in unoptimized code.

R=regis@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//408373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38483 260f80e4-7a28-3924-810f-c04153c831b5

24 min agoBump multivm DEPS
rmacnak@google.com [Tue, 22 Jul 2014 23:12:36 +0000 (23:12 +0000)]
Bump multivm DEPS

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38482 260f80e4-7a28-3924-810f-c04153c831b5

41 min agoRun SWTBot tests for Dart Editor
messick@google.com [Tue, 22 Jul 2014 22:55:15 +0000 (22:55 +0000)]
Run SWTBot tests for Dart Editor

This assumes the existence of a custom Dart Editor build that has
the SWTBot plugins (and dependencies) installed.

The script installs a listener on a socket, then forks the custom
Dart Editor, which sends its test results back over the socket.
To simplify things, the socket input is saved to a file while the
editor is running. After it exits the file is read and test results
printed to stdout in the format expected by the test framework,
including stack traces for failed tests.

This is still a work-in-progress, but it does work for me.

R=devoncarew@google.com

Review URL: https://codereview.chromium.org//406363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38481 260f80e4-7a28-3924-810f-c04153c831b5

46 min agoDEPS AutoUpdate: webkit to 178704 (2014-07-22 15:47:03 -0700) asiva@google.com
vsm@google.com [Tue, 22 Jul 2014 22:50:47 +0000 (22:50 +0000)]
DEPS AutoUpdate: webkit to 178704 (2014-07-22 15:47:03 -0700) asiva@google.com
Fix build break, mark the trampoline library as having been loaded and
http://src.chromium.org/viewvc/blink?view=rev&revision=178704

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38480 260f80e4-7a28-3924-810f-c04153c831b5

51 min agoFix dartium build break.
asiva@google.com [Tue, 22 Jul 2014 22:45:38 +0000 (22:45 +0000)]
Fix dartium build break.

R=hausner@google.com

Review URL: https://codereview.chromium.org//407073005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38479 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agopkg/serialization: updated docs and unittest dependencies
kevmoo@google.com [Tue, 22 Jul 2014 21:35:56 +0000 (21:35 +0000)]
pkg/serialization: updated docs and unittest dependencies

cleanup to readme file

R=sethladd@google.com

Review URL: https://codereview.chromium.org//414563003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38478 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agopkg/matcher: removed deprecated matchers
kevmoo@google.com [Tue, 22 Jul 2014 21:31:31 +0000 (21:31 +0000)]
pkg/matcher: removed deprecated matchers

Updated pubspec to remove documentation URL

R=sethladd@google.com

Review URL: https://codereview.chromium.org//408143009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38477 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoImplementation of the 'analysis.getErrors' API.
scheglov@google.com [Tue, 22 Jul 2014 21:24:11 +0000 (21:24 +0000)]
Implementation of the 'analysis.getErrors' API.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//407263002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38476 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoAdd Dart stack walker that relies on frame pointers.
johnmccutchan@google.com [Tue, 22 Jul 2014 21:08:22 +0000 (21:08 +0000)]
Add Dart stack walker that relies on frame pointers.

* It is used only when we don't have a top exit frame and we have the script tag set.
* Steps across exit frames and only collects Dart frames.

R=asiva@google.com

Review URL: https://codereview.chromium.org//408663004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38475 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoBump multivm DEPS
rmacnak@google.com [Tue, 22 Jul 2014 20:53:47 +0000 (20:53 +0000)]
Bump multivm DEPS

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38474 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoImplementation of the 'edit.getFixes' API in server.
scheglov@google.com [Tue, 22 Jul 2014 20:45:51 +0000 (20:45 +0000)]
Implementation of the 'edit.getFixes' API in server.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//402333006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38473 260f80e4-7a28-3924-810f-c04153c831b5

2 hours agoAddtional program argument support for Java wrapper analysis server invocation.
pquitslund@google.com [Tue, 22 Jul 2014 20:45:36 +0000 (20:45 +0000)]
Addtional program argument support for Java wrapper analysis server invocation.

R=jwren@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//412603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38472 260f80e4-7a28-3924-810f-c04153c831b5

3 hours agoFix for issue 19817
asiva@google.com [Tue, 22 Jul 2014 20:08:15 +0000 (20:08 +0000)]
Fix for issue 19817
- do not try to finalize classes on every Dart API call which could
  potentially result in calls to dart code
- Invoke Dart_FinalizeLoading after all loads are done to ensure that
  classes are finalized

R=hausner@google.com

Review URL: https://codereview.chromium.org//411633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38471 260f80e4-7a28-3924-810f-c04153c831b5

3 hours agoUnused import cleanup.
pquitslund@google.com [Tue, 22 Jul 2014 19:39:14 +0000 (19:39 +0000)]
Unused import cleanup.

R=jwren@google.com

Review URL: https://codereview.chromium.org//411553006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38470 260f80e4-7a28-3924-810f-c04153c831b5

4 hours agoUse @Native annotation instead of 'native' keyword on dart2js typed_data
sra@google.com [Tue, 22 Jul 2014 19:04:34 +0000 (19:04 +0000)]
Use @Native annotation instead of 'native' keyword on dart2js typed_data

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//402403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38469 260f80e4-7a28-3924-810f-c04153c831b5

5 hours agoFinalize the redirection type of a redirecting factory when the class of the
regis@google.com [Tue, 22 Jul 2014 18:17:24 +0000 (18:17 +0000)]
Finalize the redirection type of a redirecting factory when the class of the
factory is finalized.

R=asiva@google.com

Review URL: https://codereview.chromium.org//412543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38468 260f80e4-7a28-3924-810f-c04153c831b5

5 hours agoIn code comments print also deopt reason for deoptimization stubs.
srdjan@google.com [Tue, 22 Jul 2014 18:16:22 +0000 (18:16 +0000)]
In code comments print also deopt reason for deoptimization stubs.

R=zra@google.com

Review URL: https://codereview.chromium.org//409183003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38467 260f80e4-7a28-3924-810f-c04153c831b5

5 hours agoDEPS AutoUpdate: webkit to 178680 (2014-07-22 20:01:59 +0200) efortuna@google.com
vsm@google.com [Tue, 22 Jul 2014 18:05:15 +0000 (18:05 +0000)]
DEPS AutoUpdate: webkit to 178680 (2014-07-22 20:01:59 +0200) efortuna@google.com
Add Custom Named property getters for cssStyleDeclaration to determine the existence of a property.
http://src.chromium.org/viewvc/blink?view=rev&revision=178680

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38466 260f80e4-7a28-3924-810f-c04153c831b5

6 hours agoHandle lockfiles with null path.
rnystrom@google.com [Tue, 22 Jul 2014 17:07:07 +0000 (17:07 +0000)]
Handle lockfiles with null path.

Review URL: https://codereview.chromium.org//412553002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38465 260f80e4-7a28-3924-810f-c04153c831b5

6 hours agoDEPS AutoUpdate: webkit to 178673 (2014-07-22 18:55:57 +0200) asiva@google.com
vsm@google.com [Tue, 22 Jul 2014 17:00:30 +0000 (17:00 +0000)]
DEPS AutoUpdate: webkit to 178673 (2014-07-22 18:55:57 +0200) asiva@google.com
Adapt dartium bindings code to the new form of Dart_FinalizeLoading call.
http://src.chromium.org/viewvc/blink?view=rev&revision=178673

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38464 260f80e4-7a28-3924-810f-c04153c831b5

6 hours agoChange the Dart API call Dart_FInalizeLoading to accept an additional argument
asiva@google.com [Tue, 22 Jul 2014 16:56:14 +0000 (16:56 +0000)]
Change the Dart API call Dart_FInalizeLoading to accept an additional argument
which makes completion of deferred library futures optional.

R=hausner@google.com

Review URL: https://codereview.chromium.org//407143004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38463 260f80e4-7a28-3924-810f-c04153c831b5

7 hours agoFix lockfile error handling on Windows.
rnystrom@google.com [Tue, 22 Jul 2014 16:13:52 +0000 (16:13 +0000)]
Fix lockfile error handling on Windows.

BUG=https://code.google.com/p/dart/issues/detail?id=20104
R=nweiz@google.com

Review URL: https://codereview.chromium.org//406913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38462 260f80e4-7a28-3924-810f-c04153c831b5

7 hours agoUnit tests for correction services helpers.
scheglov@google.com [Tue, 22 Jul 2014 15:46:16 +0000 (15:46 +0000)]
Unit tests for correction services helpers.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//406943003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38461 260f80e4-7a28-3924-810f-c04153c831b5

8 hours ago- Fail if toolchain is not set instead of warning always even if not necessary.
iposva@google.com [Tue, 22 Jul 2014 15:01:05 +0000 (15:01 +0000)]
- Fail if toolchain is not set instead of warning always even if not necessary.

R=whesse@google.com

Review URL: https://codereview.chromium.org//404333004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38460 260f80e4-7a28-3924-810f-c04153c831b5

12 hours agoAdd git hashes specifying multivm reference builds.
whesse@google.com [Tue, 22 Jul 2014 10:47:52 +0000 (10:47 +0000)]
Add git hashes specifying multivm reference builds.

R=kustermann@google.com

Review URL: https://codereview.chromium.org//405363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38452 260f80e4-7a28-3924-810f-c04153c831b5

23 hours agoImplement HasToJson for change objects.
scheglov@google.com [Tue, 22 Jul 2014 00:07:46 +0000 (00:07 +0000)]
Implement HasToJson for change objects.

Plus tests for these objects.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//407993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38448 260f80e4-7a28-3924-810f-c04153c831b5

25 hours agoBump multivm DEPS
rmacnak@google.com [Mon, 21 Jul 2014 22:36:23 +0000 (22:36 +0000)]
Bump multivm DEPS

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38445 260f80e4-7a28-3924-810f-c04153c831b5

25 hours agoAs a temporary measure, allow SDK to be specified on analysis server cmd line.
paulberry@google.com [Mon, 21 Jul 2014 21:50:59 +0000 (21:50 +0000)]
As a temporary measure, allow SDK to be specified on analysis server cmd line.

Once the 'analysis.updateSdks' request is functional, this should be
unnecessary.  But for now, allow the default SDK to be set via the
command line so that we don't block development of editor plugins.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//394923004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38443 260f80e4-7a28-3924-810f-c04153c831b5

26 hours agoRedo "Correctly gather the sizes of classes by monitoring the ast pretty print."
tyoverby@google.com [Mon, 21 Jul 2014 21:12:39 +0000 (21:12 +0000)]
Redo "Correctly gather the sizes of classes by monitoring the ast pretty print."

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//404193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38442 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoRevert "Correctly gather the sizes of classes by monitoring the ast pretty print."
tyoverby@google.com [Mon, 21 Jul 2014 18:24:22 +0000 (18:24 +0000)]
Revert "Correctly gather the sizes of classes by monitoring the ast pretty print."

TBR=sra@google.com

BUG=

Review URL: https://codereview.chromium.org//402213003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38441 260f80e4-7a28-3924-810f-c04153c831b5

29 hours agoCorrectly gather the sizes of classes by monitoring the ast pretty print.
tyoverby@google.com [Mon, 21 Jul 2014 18:04:43 +0000 (18:04 +0000)]
Correctly gather the sizes of classes by monitoring the ast pretty print.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//400823003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38440 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoMake links to libraries from the main page work
alanknight@google.com [Mon, 21 Jul 2014 17:31:14 +0000 (17:31 +0000)]
Make links to libraries from the main page work

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//401003004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38439 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoUpdate status file.
floitsch@google.com [Mon, 21 Jul 2014 17:02:50 +0000 (17:02 +0000)]
Update status file.

Review URL: https://codereview.chromium.org//406013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38438 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoHide instance vars from displaying in the debugger stack frame (they're visible under...
devoncarew@google.com [Mon, 21 Jul 2014 16:57:39 +0000 (16:57 +0000)]
Hide instance vars from displaying in the debugger stack frame (they're visible under the 'this' variable).

Fixes dartbug.com/19393.

R=keertip@google.com

Review URL: https://codereview.chromium.org//405983005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38437 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoUpdate Intl docs
alanknight@google.com [Mon, 21 Jul 2014 16:49:06 +0000 (16:49 +0000)]
Update Intl docs

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//393233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38436 260f80e4-7a28-3924-810f-c04153c831b5

30 hours agoAllocate fewer empty arrays.
koda@google.com [Mon, 21 Jul 2014 16:41:05 +0000 (16:41 +0000)]
Allocate fewer empty arrays.

Use VM isolate's canonical, untyped, empty array when possible.

Takes Dart2JS benchmark from ~9000 empty arrays to ~200.

R=asiva@google.com

Review URL: https://codereview.chromium.org//381483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38435 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoOptionally display maps, sets in a logical view in the debugger.
devoncarew@google.com [Mon, 21 Jul 2014 16:32:20 +0000 (16:32 +0000)]
Optionally display maps, sets in a logical view in the debugger.

Fixes dartbug.com/19861.

R=keertip@google.com

Review URL: https://codereview.chromium.org//408813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38434 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoBuild with SWTBot
messick@google.com [Mon, 21 Jul 2014 16:02:41 +0000 (16:02 +0000)]
Build with SWTBot

Define a new product configuration and a new feature that includes SWTBot.
This is not hooked up to anything, so it won't be built or tested yet.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//397883006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38433 260f80e4-7a28-3924-810f-c04153c831b5

31 hours agoDetect invalid const constructor due to non-const initializer in field declaration.
paulberry@google.com [Mon, 21 Jul 2014 15:52:31 +0000 (15:52 +0000)]
Detect invalid const constructor due to non-const initializer in field declaration.

BUG=dartbug.com/18780
R=scheglov@google.com

Review URL: https://codereview.chromium.org//397823004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38432 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agomodify response for file not found
keertip@google.com [Mon, 21 Jul 2014 13:14:14 +0000 (13:14 +0000)]
modify response for file not found

R=danrubel@google.com

Review URL: https://codereview.chromium.org//405903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38427 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agomore progress implementing analysis server code completion
danrubel@google.com [Mon, 21 Jul 2014 02:04:49 +0000 (02:04 +0000)]
more progress implementing analysis server code completion
- add more properties returned by completion suggestion
- move completion suggestion into services
- move property constants into services for use by completion services
- move HasToJson into services for completion
- remove duplicate completion test

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//407833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38418 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoremove unused Apps View
danrubel@google.com [Sun, 20 Jul 2014 22:16:02 +0000 (22:16 +0000)]
remove unused Apps View

BUG=
R=messick@google.com

Review URL: https://codereview.chromium.org//401203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38417 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoSmall tuning of unboxing heuristic.
srdjan@google.com [Fri, 18 Jul 2014 22:42:28 +0000 (22:42 +0000)]
Small tuning of unboxing heuristic.

Review URL: https://codereview.chromium.org//403043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38414 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoSkip utf85_test on simarm64 because it timesout
johnmccutchan@google.com [Fri, 18 Jul 2014 21:44:13 +0000 (21:44 +0000)]
Skip utf85_test on simarm64 because it timesout

BUG=

Review URL: https://codereview.chromium.org//398273004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38413 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoReally fix the build
johnmccutchan@google.com [Fri, 18 Jul 2014 21:11:45 +0000 (21:11 +0000)]
Really fix the build

BUG=

Review URL: https://codereview.chromium.org//408493004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38412 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix build breakage introduced in r38409
johnmccutchan@google.com [Fri, 18 Jul 2014 21:04:36 +0000 (21:04 +0000)]
Fix build breakage introduced in r38409

BUG=

Review URL: https://codereview.chromium.org//403003003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38411 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoremove instanceof DartElement code blocks because there are no instances
danrubel@google.com [Fri, 18 Jul 2014 21:02:23 +0000 (21:02 +0000)]
remove instanceof DartElement code blocks because there are no instances

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//408513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38410 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoProfiler cleanup
johnmccutchan@google.com [Fri, 18 Jul 2014 20:55:24 +0000 (20:55 +0000)]
Profiler cleanup

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org//397163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38409 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoONe more iteration of PcDesacriptor iterator imporvement: do not copy record but...
srdjan@google.com [Fri, 18 Jul 2014 20:11:29 +0000 (20:11 +0000)]
ONe more iteration of PcDesacriptor iterator imporvement: do not copy record but access individual values when needed.

R=hausner@google.com

Review URL: https://codereview.chromium.org//403643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38408 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix compilation failure caused by r38404.
vegorov@google.com [Fri, 18 Jul 2014 18:46:57 +0000 (18:46 +0000)]
Fix compilation failure caused by r38404.

Don't mix enum and integral types in the same conditional.

TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//404873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38405 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoSupport allocation sinking for compound objects.
vegorov@google.com [Fri, 18 Jul 2014 18:35:08 +0000 (18:35 +0000)]
Support allocation sinking for compound objects.

- Improve escape/alias analysis:
-- Storing an object into a field of another object does not mean that this object escapes (or has aliases) as long as that object does not have any loads from the same place;
-- Places like X.f and Y.f don't alias if X and Y are two different allocation instructions even if X and Y themselves potentially have aliases;
-- Improve precision of alias analysis for indexed properties;

- Support dematerialization and rematerialization of objects that are referenced by other dematerialized objects.
-- Use fix-point algorithm to collect candidates for allocation sinking;
-- Support aborting unsuccessful allocation sinking.

R=fschneider@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//395943003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38404 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoadd return value back to satisfy the analyzer
jakemac@google.com [Fri, 18 Jul 2014 18:31:56 +0000 (18:31 +0000)]
add return value back to satisfy the analyzer

Review URL: https://codereview.chromium.org//402973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38403 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoDon't force range of the RangeBoundary::Shl into the Smi.
vegorov@google.com [Fri, 18 Jul 2014 18:17:31 +0000 (18:17 +0000)]
Don't force range of the RangeBoundary::Shl into the Smi.

This caused overly conservative ranges to be computed for mint-shl expressions.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//402913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38402 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoOptimize the multiplication of two 32-bit unsigned integers.
regis@google.com [Fri, 18 Jul 2014 17:59:58 +0000 (17:59 +0000)]
Optimize the multiplication of two 32-bit unsigned integers.

R=johnmccutchan@google.com, srdjan@google.com, vegorov@google.com

Review URL: https://codereview.chromium.org//396733006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38400 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoonly warn when failing to inline stylesheets or html imports when building
jakemac@google.com [Fri, 18 Jul 2014 17:59:56 +0000 (17:59 +0000)]
only warn when failing to inline stylesheets or html imports when building

BUG= http://dartbug.com/19719
R=sigmund@google.com

Review URL: https://codereview.chromium.org//397263003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38399 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoUse futures uniformly rather than a mix of futures and CPS in tests.
scheglov@google.com [Fri, 18 Jul 2014 16:22:29 +0000 (16:22 +0000)]
Use futures uniformly rather than a mix of futures and CPS in tests.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//406583002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38397 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoRemove web_ui code lab from functional tests.
messick@google.com [Fri, 18 Jul 2014 16:17:55 +0000 (16:17 +0000)]
Remove web_ui code lab from functional tests.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//401683005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38396 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoCapture debugging information
brianwilkerson@google.com [Fri, 18 Jul 2014 16:05:29 +0000 (16:05 +0000)]
Capture debugging information

R=danrubel@google.com

Review URL: https://codereview.chromium.org//400873006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38395 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix next integration branch in update script
vsm@google.com [Fri, 18 Jul 2014 15:47:26 +0000 (15:47 +0000)]
Fix next integration branch in update script

R=leafp@google.com

Review URL: https://codereview.chromium.org//400193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38392 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoMore fixes in the Fixes service.
scheglov@google.com [Fri, 18 Jul 2014 15:34:34 +0000 (15:34 +0000)]
More fixes in the Fixes service.

Limitations:

1. Not all the fixes are ported and tested yet.

2. No unit tests for helpers yet - strings, util, etc.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//405483007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38390 260f80e4-7a28-3924-810f-c04153c831b5

4 days agobefore parsing the uri encode it so that it doesn't break if there is any template...
jakemac@google.com [Fri, 18 Jul 2014 14:55:03 +0000 (14:55 +0000)]
before parsing the uri encode it so that it doesn't break if there is any template logic

BUG= http://dartbug.com/19834
R=sigmund@google.com

Review URL: https://codereview.chromium.org//396263005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38389 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoAdd warning when an identifier is used reflectively but not retained for minification.
floitsch@google.com [Fri, 18 Jul 2014 13:14:45 +0000 (13:14 +0000)]
Add warning when an identifier is used reflectively but not retained for minification.

BUG= http://dartbug.com/15795
R=ahe@google.com

Review URL: https://codereview.chromium.org//402883002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38385 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoUpdate documentation for Map and Iterable.
lrn@google.com [Fri, 18 Jul 2014 11:58:48 +0000 (11:58 +0000)]
Update documentation for Map and Iterable.

BUG= http://dartbug.com/10362
R=kustermann@google.com

Review URL: https://codereview.chromium.org//404783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38384 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoElement-model refactoring.
johnniwinther@google.com [Fri, 18 Jul 2014 10:37:07 +0000 (10:37 +0000)]
Element-model refactoring.

Introduces ExecutableElement, MemberElement (with subclass MethodElement) and LocalElement (with subclasses LocalVariableElement, LocalParameterElement, and LocalFunctionElement).

Look in elements/elements.dart for main changes.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//392873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38381 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoChange "FormatException.position" to be named "offset".
lrn@google.com [Fri, 18 Jul 2014 09:25:48 +0000 (09:25 +0000)]
Change "FormatException.position" to be named "offset".

Address comments on SpanFormatException changes.

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38373

Committed: https://code.google.com/p/dart/source/detail?r=38378

Review URL: https://codereview.chromium.org//396603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38379 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoChange "FormatException.position" to be named "offset".
lrn@google.com [Fri, 18 Jul 2014 09:22:58 +0000 (09:22 +0000)]
Change "FormatException.position" to be named "offset".

Address comments on SpanFormatException changes.

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38373

Review URL: https://codereview.chromium.org//396603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38378 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoExtends the type string support in JS to support 'returns:...;' and 'creates:...;'.
johnniwinther@google.com [Fri, 18 Jul 2014 09:22:36 +0000 (09:22 +0000)]
Extends the type string support in JS to support 'returns:...;' and 'creates:...;'.

BUG=http://dartbug.com/19866
R=floitsch@google.com, sra@google.com

Review URL: https://codereview.chromium.org//386383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38377 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoUse the new "offset" name in span.dart too.
lrn@google.com [Fri, 18 Jul 2014 08:57:34 +0000 (08:57 +0000)]
Use the new "offset" name in span.dart too.

Review URL: https://codereview.chromium.org//397343005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38376 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoAdd @Native(...) annotation for native class names.
johnniwinther@google.com [Fri, 18 Jul 2014 08:49:54 +0000 (08:49 +0000)]
Add @Native(...) annotation for native class names.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//383413003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38375 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix a type error in dart2js/backend_dart/sexpr_test
jgruber@google.com [Fri, 18 Jul 2014 08:36:30 +0000 (08:36 +0000)]
Fix a type error in dart2js/backend_dart/sexpr_test

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//406513002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38374 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoChange "FormatException.position" to be named "offset".
lrn@google.com [Fri, 18 Jul 2014 08:22:32 +0000 (08:22 +0000)]
Change "FormatException.position" to be named "offset".

Address comments on SpanFormatException changes.

R=nweiz@google.com

Review URL: https://codereview.chromium.org//396603003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38373 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoMake IterableMixinWorkaround using classes return correctly typed Iterables.
lrn@google.com [Fri, 18 Jul 2014 08:08:16 +0000 (08:08 +0000)]
Make IterableMixinWorkaround using classes return correctly typed Iterables.

BUG= http://dartbug.com/13646
R=floitsch@google.com

Review URL: https://codereview.chromium.org//397243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38372 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoMove SExpressionStringifier to its own file
jgruber@google.com [Fri, 18 Jul 2014 06:39:39 +0000 (06:39 +0000)]
Move SExpressionStringifier to its own file

Purely cut & paste plus updating of imports.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//399113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38371 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoConvert ir.InvokeStatic.target to Entity
jgruber@google.com [Fri, 18 Jul 2014 06:38:10 +0000 (06:38 +0000)]
Convert ir.InvokeStatic.target to Entity

Constructing a mock IR representation for testing purposes requires
passing a target to ir.InvokeStatic(). Changing InvokeStatic.target
from an Element to an Entity vastly simplifies this.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//396213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38370 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoAdd missing node visitors to SExpressionStringifier
jgruber@google.com [Fri, 18 Jul 2014 06:36:37 +0000 (06:36 +0000)]
Add missing node visitors to SExpressionStringifier

R=floitsch@google.com

Review URL: https://codereview.chromium.org//394173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38369 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoAdd an SExpressionStringifier test
jgruber@google.com [Fri, 18 Jul 2014 06:32:52 +0000 (06:32 +0000)]
Add an SExpressionStringifier test

Tests if the stringifier successfully generates a string containing the keywords of all nodes. Currently fails since string generation is not yet implemented for all nodes.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//396943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38368 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoMove dart2dart tests to new dedicated directory
jgruber@google.com [Fri, 18 Jul 2014 06:27:31 +0000 (06:27 +0000)]
Move dart2dart tests to new dedicated directory

R=floitsch@google.com

Review URL: https://codereview.chromium.org//398493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38367 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix analysis server 'analysis.getHover' when there is no hover information.
paulberry@google.com [Fri, 18 Jul 2014 03:30:19 +0000 (03:30 +0000)]
Fix analysis server 'analysis.getHover' when there is no hover information.

Previously we returned {'hovers': [null]}.  We now return {'hovers': []}.

Also, tweak the analysis.getHover unit tests to use futures uniformly
rather than a mix of futures and CPS.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//407443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38366 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoThree new analysis server integration tests
paulberry@google.com [Fri, 18 Jul 2014 02:20:53 +0000 (02:20 +0000)]
Three new analysis server integration tests

1. server.setSubscriptions (invalid service)
2. analysis.getHover (normal operation)
3. analysis.getHover (no hover information available)

Test 3 is disabled because it currently fails due to an analysis
server bug.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//405473006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38364 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoMark test failing for now.
rnystrom@google.com [Fri, 18 Jul 2014 02:05:55 +0000 (02:05 +0000)]
Mark test failing for now.

Review URL: https://codereview.chromium.org//399343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38363 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix the bot - type annotation was failing in checked mode.
sigmund@google.com [Fri, 18 Jul 2014 01:33:36 +0000 (01:33 +0000)]
Fix the bot - type annotation was failing in checked mode.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//401763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38362 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoWiden args dependency.
rnystrom@google.com [Fri, 18 Jul 2014 01:08:43 +0000 (01:08 +0000)]
Widen args dependency.

R=nweiz@google.com

Review URL: https://codereview.chromium.org//399293002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38361 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoExtract out a source_span package from source_maps.
nweiz@google.com [Fri, 18 Jul 2014 00:51:40 +0000 (00:51 +0000)]
Extract out a source_span package from source_maps.

This is just the first step; future CLs will add support for the new API to
various packages currently using the old one.

BUG=19930
R=sigmund@google.com

Review URL: https://codereview.chromium.org//381363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38360 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoIf ":" is omitted, use same name for package and script in pub global run.
rnystrom@google.com [Thu, 17 Jul 2014 22:54:51 +0000 (22:54 +0000)]
If ":" is omitted, use same name for package and script in pub global run.

R=nweiz@google.com

Review URL: https://codereview.chromium.org//398193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38359 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoDEPS AutoUpdate: webkit to 178402 (2014-07-18 00:47:38 +0200) asiva@google.com
vsm@google.com [Thu, 17 Jul 2014 22:50:15 +0000 (22:50 +0000)]
DEPS AutoUpdate: webkit to 178402 (2014-07-18 00:47:38 +0200) asiva@google.com
The dart version of typeddata library has changed to be compatible with the dart2js implementation
http://src.chromium.org/viewvc/blink?view=rev&revision=178402

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38358 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoUpdate status file to account for 19500 being fixed.
asiva@google.com [Thu, 17 Jul 2014 22:49:41 +0000 (22:49 +0000)]
Update status file to account for 19500 being fixed.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//388683006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38357 260f80e4-7a28-3924-810f-c04153c831b5

5 days agonormalize url attributes on entry point elements
jakemac@google.com [Thu, 17 Jul 2014 22:38:31 +0000 (22:38 +0000)]
normalize url attributes on entry point elements

BUG= http://dartbug.com/20092
R=sigmund@google.com

Review URL: https://codereview.chromium.org//404623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38356 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoSpecialize mint shift code on arm for a constant shift amount.
regis@google.com [Thu, 17 Jul 2014 22:29:33 +0000 (22:29 +0000)]
Specialize mint shift code on arm for a constant shift amount.

R=zra@google.com

Review URL: https://codereview.chromium.org//401683003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38355 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoUse ":" to separate package and executable name in pub global run.
rnystrom@google.com [Thu, 17 Jul 2014 22:24:09 +0000 (22:24 +0000)]
Use ":" to separate package and executable name in pub global run.

BUG=https://code.google.com/p/dart/issues/detail?id=19863
R=nweiz@google.com

Review URL: https://codereview.chromium.org//399763002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38354 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoDon't allow running global executables outside of bin.
rnystrom@google.com [Thu, 17 Jul 2014 22:23:22 +0000 (22:23 +0000)]
Don't allow running global executables outside of bin.

BUG=https://code.google.com/p/dart/issues/detail?id=19993
R=nweiz@google.com

Review URL: https://codereview.chromium.org//396773003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38353 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoInclude file path in JSON error when possible.
rnystrom@google.com [Thu, 17 Jul 2014 22:14:21 +0000 (22:14 +0000)]
Include file path in JSON error when possible.

I also cleaned up a bunch of unused imports.

BUG=https://code.google.com/p/dart/issues/detail?id=20067
R=nweiz@google.com

Review URL: https://codereview.chromium.org//391363004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38352 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoThe dart version of typeddata library has changed to be compatible with the dart2js...
asiva@google.com [Thu, 17 Jul 2014 22:08:07 +0000 (22:08 +0000)]
The dart version of typeddata library has changed to be compatible with the dart2js implementation
(typeddata does not implement ByteBuffer anymore).
Added new Dart API functions to account for this change.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//392043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38351 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoFix test.
rnystrom@google.com [Thu, 17 Jul 2014 22:01:44 +0000 (22:01 +0000)]
Fix test.

R=nweiz@google.com

Review URL: https://codereview.chromium.org//404633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38350 260f80e4-7a28-3924-810f-c04153c831b5

5 days agodenote completion offset using special character
danrubel@google.com [Thu, 17 Jul 2014 21:41:01 +0000 (21:41 +0000)]
denote completion offset using special character

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//402803004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38349 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoAdd .wasParsed() to ArgResults.
rnystrom@google.com [Thu, 17 Jul 2014 21:35:45 +0000 (21:35 +0000)]
Add .wasParsed() to ArgResults.

BUG=https://code.google.com/p/dart/issues/detail?id=16227
R=alanknight@google.com, nweiz@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//383913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38348 260f80e4-7a28-3924-810f-c04153c831b5

5 days agofirst cut simple code completion results
danrubel@google.com [Thu, 17 Jul 2014 21:11:39 +0000 (21:11 +0000)]
first cut simple code completion results
- not all CompletionSuggestions implemented yet
- results valid in only a few situations
- more to come

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//402723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38347 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoDisable 'Move resources' tests that are flaky on bots.
scheglov@google.com [Thu, 17 Jul 2014 20:45:40 +0000 (20:45 +0000)]
Disable 'Move resources' tests that are flaky on bots.

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//402683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38346 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoRevert using relative paths because of the problems with the Pub bots.
scheglov@google.com [Thu, 17 Jul 2014 20:42:07 +0000 (20:42 +0000)]
Revert using relative paths because of the problems with the Pub bots.

R=brianwilkerson@google.com, nweiz@google.com, paulberry@google.com, danrubel@google.com, rnystrom@google.com
BUG=

Review URL: https://codereview.chromium.org//399133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38345 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoHide dangerous interface String::Equals/Hash(uint8_t*,...
koda@google.com [Thu, 17 Jul 2014 20:07:06 +0000 (20:07 +0000)]
Hide dangerous interface String::Equals/Hash(uint8_t*,...

The method String::Equals(uint8_t*, intptr_t) was incorrectly specified as operating on UTF-8, when it was actually assuming Latin-1.

Still, friends that use templates (like Symbols) can still access the convenient overloaded Equals/Hash.

R=asiva@google.com

Review URL: https://codereview.chromium.org//400493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38343 260f80e4-7a28-3924-810f-c04153c831b5

5 days agoChange in preparation of fixing issue 19500.
asiva@google.com [Thu, 17 Jul 2014 19:40:21 +0000 (19:40 +0000)]
Change in preparation of fixing issue 19500.
The bindings code will be returning ByteBuffer in dartium so we account
for that in the FileReader return values.

R=jacobr@google.com

Review URL: https://codereview.chromium.org//395913002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38342 260f80e4-7a28-3924-810f-c04153c831b5