external/dart/bleeding_edge.git
35 hours agoImplement bitLength intrinsic on x64. master
srdjan@google.com [Fri, 23 Jan 2015 22:41:05 +0000 (22:41 +0000)]
Implement bitLength intrinsic on x64.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//867383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43126 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoDEPS AutoUpdate: webkit to 188909 (2015-01-23 14:05:37 -0800) rmacnak@google.com
rmacnak@google.com [Fri, 23 Jan 2015 22:11:31 +0000 (22:11 +0000)]
DEPS AutoUpdate: webkit to 188909 (2015-01-23 14:05:37 -0800) rmacnak@google.com
Update expected stack trace for evaluate-in-console.
http://src.chromium.org/viewvc/blink?view=rev&revision=188909

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43125 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoFix the build by disabling asynchrony_test.
scheglov@google.com [Fri, 23 Jan 2015 22:11:27 +0000 (22:11 +0000)]
Fix the build by disabling asynchrony_test.

R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//869343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43124 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoUse 'print' to send responses/notifications to the client.
scheglov@google.com [Fri, 23 Jan 2015 21:33:40 +0000 (21:33 +0000)]
Use 'print' to send responses/notifications to the client.

Ensure that Java client reads lines in a separate thread,
so that server's stdout never overflows.

R=brianwilkerson@google.com, danrubel@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//872633002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43123 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoConsistent treatment of allocation failures in old space.
koda@google.com [Fri, 23 Jan 2015 21:29:16 +0000 (21:29 +0000)]
Consistent treatment of allocation failures in old space.

On OS page allocation failure, try GC, and throw OOM.
This will be exercised more often now that there is no default hard limit.

(However, writing a reliable unit test for this path is tricky.)

R=iposva@google.com

Review URL: https://codereview.chromium.org//861033005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43122 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoRename is_visible to is_reflectable; use is_debuggable instead of is_reflectable...
rmacnak@google.com [Fri, 23 Jan 2015 21:16:40 +0000 (21:16 +0000)]
Rename is_visible to is_reflectable; use is_debuggable instead of is_reflectable to decide whether to filter a frame from stack traces.

Merge verbose_stacktrace flag into show_hidden_frames.

Don't mark native functions as non-debuggable (breakpoints don't actually work there now but nothing goes wrong).

BUG=

Review URL: https://codereview.chromium.org//868453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43121 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoInitial task support
brianwilkerson@google.com [Fri, 23 Jan 2015 20:18:11 +0000 (20:18 +0000)]
Initial task support

R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//812733004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43120 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoMove AnalysisServer to package ...generated to indicated that the file shouldnt be...
jwren@google.com [Fri, 23 Jan 2015 20:10:03 +0000 (20:10 +0000)]
Move AnalysisServer to package ...generated to indicated that the file shouldnt be changed manually.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//868183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43119 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoPrioritize analysis operations for contexts with priority files.
scheglov@google.com [Fri, 23 Jan 2015 19:29:05 +0000 (19:29 +0000)]
Prioritize analysis operations for contexts with priority files.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//869153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43118 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoConvert System.outs to Logging messages in com.google.dart.server
jwren@google.com [Fri, 23 Jan 2015 19:16:02 +0000 (19:16 +0000)]
Convert System.outs to Logging messages in com.google.dart.server

R=scheglov@google.com

Review URL: https://codereview.chromium.org//872823003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43117 260f80e4-7a28-3924-810f-c04153c831b5

39 hours agoFix Observatory disassembly view
johnmccutchan@google.com [Fri, 23 Jan 2015 18:46:14 +0000 (18:46 +0000)]
Fix Observatory disassembly view

BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//866383003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43116 260f80e4-7a28-3924-810f-c04153c831b5

40 hours agoadd flag to disable semantic highlight filtering
danrubel@google.com [Fri, 23 Jan 2015 17:46:10 +0000 (17:46 +0000)]
add flag to disable semantic highlight filtering
so that underlying semantic highlighting bug can be investigated

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//869193003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43115 260f80e4-7a28-3924-810f-c04153c831b5

40 hours agoSkip OOM tests in broswer until we can make them trigger reliably there.
koda@google.com [Fri, 23 Jan 2015 17:42:27 +0000 (17:42 +0000)]
Skip OOM tests in broswer until we can make them trigger reliably there.

The VM options are not being passed in the browser.

TBR=whesse@google.com

Review URL: https://codereview.chromium.org//871863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43114 260f80e4-7a28-3924-810f-c04153c831b5

40 hours agoadd optional request field to record time at which client made request
danrubel@google.com [Fri, 23 Jan 2015 17:41:29 +0000 (17:41 +0000)]
add optional request field to record time at which client made request

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//865383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43113 260f80e4-7a28-3924-810f-c04153c831b5

41 hours agodart2js: Fix bad is-check in native_emitter.
floitsch@google.com [Fri, 23 Jan 2015 16:35:29 +0000 (16:35 +0000)]
dart2js: Fix bad is-check in native_emitter.

Review URL: https://codereview.chromium.org//867963003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43112 260f80e4-7a28-3924-810f-c04153c831b5

41 hours agoRemove default heap size limit and add separate limit for externals.
koda@google.com [Fri, 23 Jan 2015 16:32:20 +0000 (16:32 +0000)]
Remove default heap size limit and add separate limit for externals.

Review URL: https://codereview.chromium.org//864843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43111 260f80e4-7a28-3924-810f-c04153c831b5

42 hours agoWhite-list work-around function for try.
floitsch@google.com [Fri, 23 Jan 2015 16:09:13 +0000 (16:09 +0000)]
White-list work-around function for try.

Review URL: https://codereview.chromium.org//869233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43110 260f80e4-7a28-3924-810f-c04153c831b5

42 hours agodart2js: add work-around hack for try.
floitsch@google.com [Fri, 23 Jan 2015 15:40:00 +0000 (15:40 +0000)]
dart2js: add work-around hack for try.

Review URL: https://codereview.chromium.org//871073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43109 260f80e4-7a28-3924-810f-c04153c831b5

43 hours agodart2js: Make emitInstanceMember take a Class and not a classElement.
floitsch@google.com [Fri, 23 Jan 2015 14:50:20 +0000 (14:50 +0000)]
dart2js: Make emitInstanceMember take a Class and not a classElement.

R=zarah@google.com

Review URL: https://codereview.chromium.org//866213005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43108 260f80e4-7a28-3924-810f-c04153c831b5

43 hours agodart2js: determine if a needed class is needed without having side-effects.
floitsch@google.com [Fri, 23 Jan 2015 14:44:12 +0000 (14:44 +0000)]
dart2js: determine if a needed class is needed without having side-effects.

R=zarah@google.com

Review URL: https://codereview.chromium.org//866843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43107 260f80e4-7a28-3924-810f-c04153c831b5

44 hours agoAttempt to fix clang build another time.
fschneider@google.com [Fri, 23 Jan 2015 13:47:42 +0000 (13:47 +0000)]
Attempt to fix clang build another time.

This error is not reproducible with my local clang build.

Review URL: https://codereview.chromium.org//867223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43106 260f80e4-7a28-3924-810f-c04153c831b5

44 hours agoRevert "Add a shrinking reduction for dead continuation parameters."
kmillikin@google.com [Fri, 23 Jan 2015 13:44:41 +0000 (13:44 +0000)]
Revert "Add a shrinking reduction for dead continuation parameters."

This reverts svn revision r43093, due to failures in dart2dart.  It
clashes with the commit just before it which has changed the type of
FunctionDefinition parameters.

Also, continuation eta-reduction can destroy a dead parameter
reduction.  In this case, it's not obvious which reduction we actually
want.  So though the fixes are simple, I will back this change out and
reevaluate it.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//869223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43105 260f80e4-7a28-3924-810f-c04153c831b5

44 hours agodart2js: fix csp mode.
floitsch@google.com [Fri, 23 Jan 2015 13:42:23 +0000 (13:42 +0000)]
dart2js: fix csp mode.

Review URL: https://codereview.chromium.org//871003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43104 260f80e4-7a28-3924-810f-c04153c831b5

44 hours agoFix another clang compiler warning.
fschneider@google.com [Fri, 23 Jan 2015 13:31:10 +0000 (13:31 +0000)]
Fix another clang compiler warning.

R=vegorov@google.com

Review URL: https://codereview.chromium.org//868033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43103 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agoFix clang compiler warning.
fschneider@google.com [Fri, 23 Jan 2015 13:00:11 +0000 (13:00 +0000)]
Fix clang compiler warning.

TBR=vegorov@google.com

Review URL: https://codereview.chromium.org//869203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43101 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agoStore pc offset instead of absolute pc in the pc descriptors.
fschneider@google.com [Fri, 23 Jan 2015 12:30:11 +0000 (12:30 +0000)]
Store pc offset instead of absolute pc in the pc descriptors.

This saves space on 64-bit platforms as the offset is stored
as a uint32_t compared to a pointer-size absolute address.

R=vegorov@google.com

Review URL: https://codereview.chromium.org//875443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43100 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agodart2js: store call stubs in the model.
floitsch@google.com [Fri, 23 Jan 2015 12:29:12 +0000 (12:29 +0000)]
dart2js: store call stubs in the model.

R=zarah@google.com

Review URL: https://codereview.chromium.org//865223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43099 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agodart2js: store fields in the model and make the emitters use it.
floitsch@google.com [Fri, 23 Jan 2015 12:27:40 +0000 (12:27 +0000)]
dart2js: store fields in the model and make the emitters use it.

R=zarah@google.com

Review URL: https://codereview.chromium.org//869543004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43098 260f80e4-7a28-3924-810f-c04153c831b5

46 hours agoUse RIP relative addressing to compute PC marker and load PP on x64.
vegorov@google.com [Fri, 23 Jan 2015 12:02:13 +0000 (12:02 +0000)]
Use RIP relative addressing to compute PC marker and load PP on x64.

Streamline frame entering routines removing duplicated and unused code.

BUG=
R=srdjan@google.com

Review URL: https://codereview.chromium.org//851283005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43097 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agodart2js: Don't add properties to native classes that are not needed.
floitsch@google.com [Fri, 23 Jan 2015 10:35:48 +0000 (10:35 +0000)]
dart2js: Don't add properties to native classes that are not needed.

This has no impact on the output, and almost no impact on the compilation time.
However, it makes it clearer, that unneeded native classes really are not needed, and don't need their nativeSpecProperty either.

I want to refactor this code in another CL, but I think it's cleaner if this if-check is already in place now, and not merged into a bigger change.

R=sra@google.com

Review URL: https://codereview.chromium.org//863353002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43096 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agodart2js: Fix getter/setter flags in the model.
floitsch@google.com [Fri, 23 Jan 2015 10:33:50 +0000 (10:33 +0000)]
dart2js: Fix getter/setter flags in the model.
It was inverting cases 10 and 11.

Here is the relevant part from model.dart:

  /// 00: Does not need any getter.
  /// 01:  function() { return this.field; }
  /// 10:  function(receiver) { return receiver.field; }
  /// 11:  function(receiver) { return this.field; }
  final int getterFlags;

  /// 00: Does not need any setter.
  /// 01:  function(value) { this.field = value; }
  /// 10:  function(receiver, value) { receiver.field = value; }
  /// 11:  function(receiver, value) { this.field = value; }
  final int setterFlags;

R=zarah@google.com

Review URL: https://codereview.chromium.org//862783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43095 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoVM: Emit compacter code for x64 branches to external labels.
fschneider@google.com [Fri, 23 Jan 2015 10:28:23 +0000 (10:28 +0000)]
VM: Emit compacter code for x64 branches to external labels.

Use jmp [PP + 0xiiii] instead of

movq TMP, [PP + 0xiiii]
jmp TMP

Also, remove some unused code from x64 assembler.

R=zra@google.com

Review URL: https://codereview.chromium.org//869533003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43094 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoAdd a shrinking reduction for dead continuation parameters.
kmillikin@google.com [Fri, 23 Jan 2015 10:27:46 +0000 (10:27 +0000)]
Add a shrinking reduction for dead continuation parameters.

Continuation parameters that have no uses can be eliminated.  This is
similar to the reduction for dead values except that that continuation
invocations need to be adjusted.

Performing a dead parameter reduction can create other dead parameter
redexes, dead value redexes, or continuation eta-redexes.  Detection
of these redexes does not fit the existing model, where an entire
deleted subterm is visited after being eliminated from the whole term.
Instead, they are detected explicit as part of the reduction
implementation.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//864293004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43093 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoImplement constructor bodies and initializers in CPS->JS backend.
asgerf@google.com [Fri, 23 Jan 2015 10:19:28 +0000 (10:19 +0000)]
Implement constructor bodies and initializers in CPS->JS backend.

As in the SSA backend, a constructor consists of three parts:
1. Instantiator: creates an object and sets its fields
2. Factory: evaluates field initializers, calls instantiator, then
   calls bodies.
3. Body: executes the body of a constructor.

The CreateClosureClass instruction has been replaced by CreateInstance
for invoking the instantiator for an arbitrary class.

The IrBuilderVisitor has been split into two subclasses to better
isolate the JS-specific code.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//862703002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43092 260f80e4-7a28-3924-810f-c04153c831b5

2 days ago(TBR) fix test_performAnalysisTask_importedLibraryAdd_html test
danrubel@google.com [Fri, 23 Jan 2015 03:00:12 +0000 (03:00 +0000)]
(TBR) fix test_performAnalysisTask_importedLibraryAdd_html test

BUG=

Review URL: https://codereview.chromium.org//872553003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43091 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoMove indexing into operations.
scheglov@google.com [Fri, 23 Jan 2015 00:32:30 +0000 (00:32 +0000)]
Move indexing into operations.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//869793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43090 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoMark mirrors/mirrors_reader_test as Crash on jsshell
sra@google.com [Thu, 22 Jan 2015 23:27:09 +0000 (23:27 +0000)]
Mark mirrors/mirrors_reader_test as Crash on jsshell

Dies on the bots with 10GB heap

TBR=ricow@google.com

Review URL: https://codereview.chromium.org//866253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43089 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoupdate analysis server spec and regen files
danrubel@google.com [Thu, 22 Jan 2015 23:14:09 +0000 (23:14 +0000)]
update analysis server spec and regen files
this is needed to support new UpdateContentConsumer

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//868893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43088 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoReset 'hasPendingDocumentChanges' on save.
scheglov@google.com [Thu, 22 Jan 2015 22:44:29 +0000 (22:44 +0000)]
Reset 'hasPendingDocumentChanges' on save.

R=danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//872463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43087 260f80e4-7a28-3924-810f-c04153c831b5

2 days agocleanup unused imports
danrubel@google.com [Thu, 22 Jan 2015 22:41:51 +0000 (22:41 +0000)]
cleanup unused imports

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//868803006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43086 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix build:
iposva@google.com [Thu, 22 Jan 2015 22:34:30 +0000 (22:34 +0000)]
Fix build:
- Disable test using spawnUri where appropriate.

Review URL: https://codereview.chromium.org//866203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43085 260f80e4-7a28-3924-810f-c04153c831b5

2 days agocache completion performance by default
danrubel@google.com [Thu, 22 Jan 2015 22:25:38 +0000 (22:25 +0000)]
cache completion performance by default

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//867023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43084 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIgnore semantic highlighting results if there is a pending content change for the...
scheglov@google.com [Thu, 22 Jan 2015 22:18:45 +0000 (22:18 +0000)]
Ignore semantic highlighting results if there is a pending content change for the file.

R=brianwilkerson@google.com, danrubel@google.com
BUG=

Review URL: https://codereview.chromium.org//869663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43083 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoTest that safe saves are picked up by pub serve.
rnystrom@google.com [Thu, 22 Jan 2015 22:16:54 +0000 (22:16 +0000)]
Test that safe saves are picked up by pub serve.

BUG=https://code.google.com/p/dart/issues/detail?id=21402
R=nweiz@google.com

Review URL: https://codereview.chromium.org//870703003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43082 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix 'MockContext does not implement getContents' test failures.
scheglov@google.com [Thu, 22 Jan 2015 21:35:39 +0000 (21:35 +0000)]
Fix 'MockContext does not implement getContents' test failures.

R=danrubel@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//866973002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43080 260f80e4-7a28-3924-810f-c04153c831b5

2 days ago(TBR) fix the build
danrubel@google.com [Thu, 22 Jan 2015 21:33:00 +0000 (21:33 +0000)]
(TBR) fix the build

BUG=

Review URL: https://codereview.chromium.org//872443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43079 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix http://dartbug.com/22115
iposva@google.com [Thu, 22 Jan 2015 21:28:27 +0000 (21:28 +0000)]
Fix http://dartbug.com/22115
- Make sure to lookup main in re-exported namespaces too.

R=asiva@google.com

Review URL: https://codereview.chromium.org//864233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43078 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoLibrary Dependencies Analysis service API.
pquitslund@google.com [Thu, 22 Jan 2015 21:26:28 +0000 (21:26 +0000)]
Library Dependencies Analysis service API.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//861893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43077 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoUpdate to latest version of watcher.
rnystrom@google.com [Thu, 22 Jan 2015 20:20:15 +0000 (20:20 +0000)]
Update to latest version of watcher.

R=ricow@google.com

Review URL: https://codereview.chromium.org//801943005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43076 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd some dart:html issues to their matching test suppressions
alanknight@google.com [Thu, 22 Jan 2015 17:43:36 +0000 (17:43 +0000)]
Add some dart:html issues to their matching test suppressions

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//863073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43074 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIntroduce simple Thread class to support gradual refactoring of interfaces.
koda@google.com [Thu, 22 Jan 2015 14:14:16 +0000 (14:14 +0000)]
Introduce simple Thread class to support gradual refactoring of interfaces.

This first iteration of Thread just forwards a subset of the BaseIsolate methods.

The plan is to first add Thread/Zone-based interfaces where appropriate, deprecate their Isolate-based versions, and finally remove them once all callsites have been migrated.

This CL only demonstrates a small part of this migration, for BitVector and some of the compiler classes. There are thousands of additional call-sites that will need to be updated.

R=asiva@google.com

Review URL: https://codereview.chromium.org//850183005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43073 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoPort the support for starting a detached process to Android.
sgjesse@google.com [Thu, 22 Jan 2015 13:16:07 +0000 (13:16 +0000)]
Port the support for starting a detached process to Android.

This is the Android part of r43070.

TBR=kustermann@google.com
BUG=

Review URL: https://codereview.chromium.org//864293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43072 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIncorporate some code review comments.
kmillikin@google.com [Thu, 22 Jan 2015 13:09:27 +0000 (13:09 +0000)]
Incorporate some code review comments.

Change the CPS IR's LetCont constructor to have single and multiple
continuation versions.  Update a pair of comments.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//819143007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43071 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd support for starting a detached process
sgjesse@google.com [Thu, 22 Jan 2015 11:49:39 +0000 (11:49 +0000)]
Add support for starting a detached process

BUG=http://dartbug.com/20970
R=kustermann@google.com, lrn@google.com

Review URL: https://codereview.chromium.org//798743004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43070 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix mac build, missing ;
ricow@google.com [Thu, 22 Jan 2015 11:33:47 +0000 (11:33 +0000)]
Fix mac build, missing ;

TBR=sgjesse@google.com

Review URL: https://codereview.chromium.org//870523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43069 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRevert "Change signature of lookupConstructor to only require a name."
herhut@google.com [Thu, 22 Jan 2015 10:46:18 +0000 (10:46 +0000)]
Revert "Change signature of lookupConstructor to only require a name."

This reverts revision 43067.

BUG=
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//868643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43068 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoChange signature of lookupConstructor to only require a name.
herhut@google.com [Thu, 22 Jan 2015 10:32:43 +0000 (10:32 +0000)]
Change signature of lookupConstructor to only require a name.

BUG=
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//812523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43067 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix issue with Link.target and Link.targetSync failing on some file systems
sgjesse@google.com [Thu, 22 Jan 2015 10:27:11 +0000 (10:27 +0000)]
Fix issue with Link.target and Link.targetSync failing on some file systems

Don't rely on information from lstat64 for the size of the link target. Get
the actual length from just reading the link target.

BUG=http://dartbug.com/21987
R=kustermann@google.com

Review URL: https://codereview.chromium.org//860343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43066 260f80e4-7a28-3924-810f-c04153c831b5

2 days agodart2js: Use is-checks from the model in the old emitter.
floitsch@google.com [Thu, 22 Jan 2015 10:25:54 +0000 (10:25 +0000)]
dart2js: Use is-checks from the model in the old emitter.

R=zarah@google.com

Review URL: https://codereview.chromium.org//840563005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43065 260f80e4-7a28-3924-810f-c04153c831b5

2 days agodart2js: use model in native emitter.
floitsch@google.com [Thu, 22 Jan 2015 10:23:41 +0000 (10:23 +0000)]
dart2js: use model in native emitter.

R=sra@google.com, zarah@google.com

Review URL: https://codereview.chromium.org//859843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43064 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoPush updates to browser.
ahe@google.com [Thu, 22 Jan 2015 10:02:20 +0000 (10:02 +0000)]
Push updates to browser.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//847573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43063 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoConsider updates of locals in type promotion.
herhut@google.com [Thu, 22 Jan 2015 09:52:31 +0000 (09:52 +0000)]
Consider updates of locals in type promotion.

BUG= http://dartbug.com/21271
R=floitsch@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//843613004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43062 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRename $dart_unsafe_eval to $dart_unsafe_incremental_support.
ahe@google.com [Thu, 22 Jan 2015 09:50:07 +0000 (09:50 +0000)]
Rename $dart_unsafe_eval to $dart_unsafe_incremental_support.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//856333003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43061 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoFix incorrect handling of closing stderr on Windows
sgjesse@google.com [Thu, 22 Jan 2015 09:25:17 +0000 (09:25 +0000)]
Fix incorrect handling of closing stderr on Windows

BUG=http://dartbug.com/22088
R=kustermann@google.com

Review URL: https://codereview.chromium.org//854633005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43060 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAvoid extra duplication of substrings during string.replaceAll.
lrn@google.com [Thu, 22 Jan 2015 08:27:42 +0000 (08:27 +0000)]
Avoid extra duplication of substrings during string.replaceAll.

R=asiva@google.com, zerny@google.com

Review URL: https://codereview.chromium.org//858543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43059 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoOptimize is-check to instanceof when it eliminates an interceptor
sra@google.com [Thu, 22 Jan 2015 02:24:00 +0000 (02:24 +0000)]
Optimize is-check to instanceof when it eliminates an interceptor

See http://dartbug.com/22016 for discussion

R=floitsch@google.com

Review URL: https://codereview.chromium.org//829913006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43058 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRegenerate pub's sources and remove workarounds for fixed issues.
nweiz@google.com [Thu, 22 Jan 2015 01:07:38 +0000 (01:07 +0000)]
Regenerate pub's sources and remove workarounds for fixed issues.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//868463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43057 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoBump async_await revision.
nweiz@google.com [Thu, 22 Jan 2015 00:05:57 +0000 (00:05 +0000)]
Bump async_await revision.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org/861383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43056 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRecognize and special case String.fromCharCodes for Uint8List in JavaScript.
sra@google.com [Wed, 21 Jan 2015 22:50:00 +0000 (22:50 +0000)]
Recognize and special case String.fromCharCodes for Uint8List in JavaScript.

Speeds up UTF8 decoding, boosting JsonUtf8RoundTrip 4x.
This should also improve binary protobuf parsing of strings.

R=lrn@google.com

Review URL: https://codereview.chromium.org//860273002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43055 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUse a raw string to correctly print \n in option description in the analysis server.
jwren@google.com [Wed, 21 Jan 2015 22:28:57 +0000 (22:28 +0000)]
Use a raw string to correctly print \n in option description in the analysis server.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//867433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43054 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoReapply "Mark all private functions in dart: libraries as invisible (*sniff*). Previo...
rmacnak@google.com [Wed, 21 Jan 2015 20:44:04 +0000 (20:44 +0000)]
Reapply "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list."

Broken assumption in Dartium fixed in blink r188698.

R=hausner@google.com

Review URL: https://codereview.chromium.org//862093003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43053 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoExpect objects in the VM-heap to be marked on shutdown verification.
koda@google.com [Wed, 21 Jan 2015 20:30:09 +0000 (20:30 +0000)]
Expect objects in the VM-heap to be marked on shutdown verification.

This would have failed after submitting
https://codereview.chromium.org/850183003/

R=zra@google.com

Review URL: https://codereview.chromium.org//866473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43052 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoimprove measurement of completion performance
danrubel@google.com [Wed, 21 Jan 2015 19:33:43 +0000 (19:33 +0000)]
improve measurement of completion performance

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//861153003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43051 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoDEPS AutoUpdate: webkit to 188698 (2015-01-20 13:48:22 -0800) rmacnak@google.com
rmacnak@google.com [Wed, 21 Jan 2015 18:49:20 +0000 (18:49 +0000)]
DEPS AutoUpdate: webkit to 188698 (2015-01-20 13:48:22 -0800) rmacnak@google.com
Fix bad assumption about accessibility of private core members through mirrors.
http://src.chromium.org/viewvc/blink?view=rev&revision=188698

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43050 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAdd addStatusListener to the AnalysisServer generator.
jwren@google.com [Wed, 21 Jan 2015 18:25:18 +0000 (18:25 +0000)]
Add addStatusListener to the AnalysisServer generator.

R=keertip@google.com

Review URL: https://codereview.chromium.org//864063002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43049 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoCopy-on-write class table for concurrent reading.
koda@google.com [Wed, 21 Jan 2015 18:13:12 +0000 (18:13 +0000)]
Copy-on-write class table for concurrent reading.

Make ClassTable::At thread safe by keeping old copies of the class table.
They can be safely deallocated during the stop-the-world phase of GC.

This avoids making a copy for every sweeper task, and is the first step towards removing the fake Isolate workaround.

R=iposva@google.com

Review URL: https://codereview.chromium.org//816773005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43048 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRemove unused duplicate toString() call
sra@google.com [Wed, 21 Jan 2015 18:09:15 +0000 (18:09 +0000)]
Remove unused duplicate toString() call

R=lrn@google.com

Review URL: https://codereview.chromium.org//860983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43047 260f80e4-7a28-3924-810f-c04153c831b5

3 days agocheck for analysis process process alive
keertip@google.com [Wed, 21 Jan 2015 18:07:44 +0000 (18:07 +0000)]
check for analysis process process alive

R=jwren@google.com

Review URL: https://codereview.chromium.org//862073002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43046 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUse UTF-8 when serving web pages for analysis server debug.
paulberry@google.com [Wed, 21 Jan 2015 17:57:57 +0000 (17:57 +0000)]
Use UTF-8 when serving web pages for analysis server debug.

This avoids the need to encode unicode characters using hexadecimal
escape sequences.

(Note that setting the charset using response.headers.contentType
affects the encoding used by both client and server.)

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//855643004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43045 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoremove unused enable angular analysis preference
danrubel@google.com [Wed, 21 Jan 2015 17:26:12 +0000 (17:26 +0000)]
remove unused enable angular analysis preference

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//861163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43044 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoadd a button to the toolbar to indicate server status
keertip@google.com [Wed, 21 Jan 2015 17:05:50 +0000 (17:05 +0000)]
add a button to the toolbar to indicate server status

R=danrubel@google.com

Review URL: https://codereview.chromium.org//860103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43043 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUpdate co19 status on safari
whesse@google.com [Wed, 21 Jan 2015 16:32:51 +0000 (16:32 +0000)]
Update co19 status on safari

BUG=

Review URL: https://codereview.chromium.org//865623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43042 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoDisables printing a version string to the console for GN build.
zra@google.com [Wed, 21 Jan 2015 15:18:23 +0000 (15:18 +0000)]
Disables printing a version string to the console for GN build.

R=ricow@google.com

Review URL: https://codereview.chromium.org//850053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43041 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoHandle generic parameters correctly in invocation completions.
paulberry@google.com [Wed, 21 Jan 2015 15:16:50 +0000 (15:16 +0000)]
Handle generic parameters correctly in invocation completions.

When doing invocation completions, we need to walk the interface
types, not the classes, because the interface types record the actual
types of the generic parameters.  This required some rework because
the old technique used an element visitor, and interface types can't
be visited using an element visitor.

R=danrubel@google.com

Review URL: https://codereview.chromium.org//829173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43040 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUse a typed array for the irregexp stack.
zerny@google.com [Wed, 21 Jan 2015 15:11:36 +0000 (15:11 +0000)]
Use a typed array for the irregexp stack.

BUG=
R=vegorov@google.com

Review URL: https://codereview.chromium.org//800433004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43039 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRefactor _ByteDataView.[set|get]<Type> methods to improve their performance.
vegorov@google.com [Wed, 21 Jan 2015 14:21:49 +0000 (14:21 +0000)]
Refactor _ByteDataView.[set|get]<Type> methods to improve their performance.

- don't manually truncate values before passing them to TypedData._[set|get]<Type> - these methods already have truncating semantics;

- don't call into runtime for endianess conversion, implement it in pure Dart instead (with an intent to provide optimized version on platforms that support fast byte-swapping instructions);

- force inlining of these methods (change the order of checks in the ShouldWeInline to guarantee inlining of whitelisted methods).

Unrelated change:

- tweak output of Function::CheckSourceFingerprint to be immediately copy&paste useful.

R=fschneider@google.com
BUG=http://dartbug.com/22107

Review URL: https://codereview.chromium.org//860963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43038 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js: set needsTearOff when creating the getter/setter stubs in the new emitter.
floitsch@google.com [Wed, 21 Jan 2015 14:01:13 +0000 (14:01 +0000)]
dart2js: set needsTearOff when creating the getter/setter stubs in the new emitter.

The Method constructor requires the booleans to be set:

  Method(this.element, this.name, this.code, {this.needsTearOff}) {
    assert(needsTearOff != null);

R=zarah@google.com

Review URL: https://codereview.chromium.org//830193003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43037 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoFix bug with allocation stats on x64.
fschneider@google.com [Wed, 21 Jan 2015 13:43:40 +0000 (13:43 +0000)]
Fix bug with allocation stats on x64.

Context allocations were incorrectly counted as List allocations.
As a result, the allocation profile was wrong for Context and List.

R=vegorov@google.com

Review URL: https://codereview.chromium.org//863923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43036 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js: Let the emitter generate the program.
floitsch@google.com [Wed, 21 Jan 2015 12:04:52 +0000 (12:04 +0000)]
dart2js: Let the emitter generate the program.

This gives the emitter the option to pass options to the builder.

R=zarah@google.com

Review URL: https://codereview.chromium.org//822593004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43035 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js: Don't assume fields are needed, if they are static.
floitsch@google.com [Wed, 21 Jan 2015 11:58:03 +0000 (11:58 +0000)]
dart2js: Don't assume fields are needed, if they are static.

R=herhut@google.com

Review URL: https://codereview.chromium.org//828083003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43034 260f80e4-7a28-3924-810f-c04153c831b5

4 days ago- Allow implementations to hook into the Utf8Decoder.convert method.
iposva@google.com [Wed, 21 Jan 2015 01:29:14 +0000 (01:29 +0000)]
- Allow implementations to hook into the Utf8Decoder.convert method.

R=srdjan@google.com

Review URL: https://codereview.chromium.org//791323003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43033 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoRemove Element.users support.
scheglov@google.com [Wed, 21 Jan 2015 00:48:02 +0000 (00:48 +0000)]
Remove Element.users support.

R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Review URL: https://codereview.chromium.org//854363005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43032 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoFix order of parameter input in StdioServerSocket
jwren@google.com [Tue, 20 Jan 2015 23:22:49 +0000 (23:22 +0000)]
Fix order of parameter input in StdioServerSocket

R=scheglov@google.com

Review URL: https://codereview.chromium.org//860013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43031 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoInvalidate parsing information when a file is added.
scheglov@google.com [Tue, 20 Jan 2015 23:11:58 +0000 (23:11 +0000)]
Invalidate parsing information when a file is added.

We resolve directives URIs during parse, so if a referenced file was
added after parsing, it may fix some "Unresolved URI" problems.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=22101

Review URL: https://codereview.chromium.org//860903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43030 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoBUG=
jacobr@google.com [Tue, 20 Jan 2015 23:04:27 +0000 (23:04 +0000)]
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org//863713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43029 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoAddition of the new flag "file-read-mode" into the analysis server to fix the offset...
jwren@google.com [Tue, 20 Jan 2015 21:48:00 +0000 (21:48 +0000)]
Addition of the new flag "file-read-mode" into the analysis server to fix the offset bug with IntelliJs integration.

R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//857283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43028 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoReturn outline after parse
brianwilkerson@google.com [Tue, 20 Jan 2015 21:36:14 +0000 (21:36 +0000)]
Return outline after parse

R=scheglov@google.com

Review URL: https://codereview.chromium.org//842533004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43027 260f80e4-7a28-3924-810f-c04153c831b5

4 days agoRevert "Mark all private functions in dart: libraries as invisible (*sniff*). Previou...
rmacnak@google.com [Tue, 20 Jan 2015 20:56:59 +0000 (20:56 +0000)]
Revert "Mark all private functions in dart: libraries as invisible (*sniff*). Previously these functions were only marked invisible if they were also native, a constructor, or on a black list."

Broke Dartium.

TBR=hausner@google.com

Review URL: https://codereview.chromium.org//863773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43026 260f80e4-7a28-3924-810f-c04153c831b5

4 days agodart2js: Remove obsolete comment and code.
floitsch@google.com [Tue, 20 Jan 2015 20:17:35 +0000 (20:17 +0000)]
dart2js: Remove obsolete comment and code.

R=sra@google.com

Review URL: https://codereview.chromium.org//855963002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43025 260f80e4-7a28-3924-810f-c04153c831b5

4 days agodart2js: Change mirror flag message.
floitsch@google.com [Tue, 20 Jan 2015 20:16:42 +0000 (20:16 +0000)]
dart2js: Change mirror flag message.

R=sethladd@google.com

Review URL: https://codereview.chromium.org//859463002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43024 260f80e4-7a28-3924-810f-c04153c831b5