external/dart/bleeding_edge.git
32 hours agoSkip vm/cc/ArrayLengthMaxElements on simulators while debugging issue 23254. master
koda@google.com [Sat, 18 Apr 2015 02:36:49 +0000 (02:36 +0000)]
Skip vm/cc/ArrayLengthMaxElements on simulators while debugging issue 23254.

BUG=23254
TBR=iposva@google.com

Review URL: https://codereview.chromium.org//1062463005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45267 260f80e4-7a28-3924-810f-c04153c831b5

32 hours agoEnforce token syntax for CssClassSet arguments
sra@google.com [Sat, 18 Apr 2015 01:58:20 +0000 (01:58 +0000)]
Enforce token syntax for CssClassSet arguments

Committed: https://code.google.com/p/dart/source/detail?r=45265

Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45266 260f80e4-7a28-3924-810f-c04153c831b5

33 hours agoEnforce token syntax for CssClassSet arguments
sra@google.com [Sat, 18 Apr 2015 01:53:21 +0000 (01:53 +0000)]
Enforce token syntax for CssClassSet arguments

Review URL: https://codereview.chromium.org//1077203004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45265 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoRevert "Add tests for evalutating against activation records."
rmacnak@google.com [Sat, 18 Apr 2015 00:56:26 +0000 (00:56 +0000)]
Revert "Add tests for evalutating against activation records."

BUG=

Review URL: https://codereview.chromium.org//1094993003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45264 260f80e4-7a28-3924-810f-c04153c831b5

34 hours agoAdd tests for evalutating against activation records.
rmacnak@google.com [Sat, 18 Apr 2015 00:06:21 +0000 (00:06 +0000)]
Add tests for evalutating against activation records.

Report an exception when the testee hits an assertion failure.

BUG=http://dartbug.com/20047
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1075423002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45263 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoExtend list length unit test.
koda@google.com [Fri, 17 Apr 2015 23:56:55 +0000 (23:56 +0000)]
Extend list length unit test.

R=iposva@google.com

Review URL: https://codereview.chromium.org//1072933007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45262 260f80e4-7a28-3924-810f-c04153c831b5

35 hours agoApparently every flag is modified in some test configurations on the buildbot.
turnidge@google.com [Fri, 17 Apr 2015 23:28:00 +0000 (23:28 +0000)]
Apparently every flag is modified in some test configurations on the buildbot.

This broke my assumption that I could find at least one unmodified flag.

BUG=

Review URL: https://codereview.chromium.org//1057173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45261 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoFix buildbot.
turnidge@google.com [Fri, 17 Apr 2015 22:32:09 +0000 (22:32 +0000)]
Fix buildbot.

BUG=

Review URL: https://codereview.chromium.org//1092053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45260 260f80e4-7a28-3924-810f-c04153c831b5

36 hours agoMy new tests made some bad assumptions about flag values.
turnidge@google.com [Fri, 17 Apr 2015 22:04:32 +0000 (22:04 +0000)]
My new tests made some bad assumptions about flag values.

BUG=

Review URL: https://codereview.chromium.org//1092123003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45259 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoEmit OSR check stub only if needed.
srdjan@google.com [Fri, 17 Apr 2015 21:25:53 +0000 (21:25 +0000)]
Emit OSR check stub only if needed.

R=fschneider@google.com

Review URL: https://codereview.chromium.org//1088963003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45258 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoKill service_test.cc tests in favor of dart tests for the service protocol.
turnidge@google.com [Fri, 17 Apr 2015 21:08:02 +0000 (21:08 +0000)]
Kill service_test.cc tests in favor of dart tests for the service protocol.

Associated cleanups and fixes that I noticed as I rewrote the tests.

Review URL: https://codereview.chromium.org//1090293003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45257 260f80e4-7a28-3924-810f-c04153c831b5

37 hours agoBetter hints for await in non-async functions
sigmund@google.com [Fri, 17 Apr 2015 20:58:59 +0000 (20:58 +0000)]
Better hints for await in non-async functions

BUG=23234
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1094903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45256 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoSet version back to 111
johnmccutchan@google.com [Fri, 17 Apr 2015 20:35:43 +0000 (20:35 +0000)]
Set version back to 111

BUG=

Review URL: https://codereview.chromium.org//1091373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45255 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoAnalytics version for 1.10
johnmccutchan@google.com [Fri, 17 Apr 2015 20:31:50 +0000 (20:31 +0000)]
Analytics version for 1.10

TBR=iposva

Review URL: https://codereview.chromium.org//1096613006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45254 260f80e4-7a28-3924-810f-c04153c831b5

38 hours agoFix bigint division (issue 23238).
regis@google.com [Fri, 17 Apr 2015 20:30:29 +0000 (20:30 +0000)]
Fix bigint division (issue 23238).
Add regression test.

R=zra@google.com

Review URL: https://codereview.chromium.org//1062753004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45253 260f80e4-7a28-3924-810f-c04153c831b5

39 hours agoRemove 22327 suppression now that Chrome 41 is current
alanknight@google.com [Fri, 17 Apr 2015 19:47:30 +0000 (19:47 +0000)]
Remove 22327 suppression now that Chrome 41 is current

BUG=

Review URL: https://codereview.chromium.org//1097783002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45252 260f80e4-7a28-3924-810f-c04153c831b5

39 hours agoFix tests in bots (handle 'is' as an invalid binary operator)
sigmund@google.com [Fri, 17 Apr 2015 19:20:52 +0000 (19:20 +0000)]
Fix tests in bots (handle 'is' as an invalid binary operator)

TBR=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1091343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45251 260f80e4-7a28-3924-810f-c04153c831b5

40 hours agoMake super.foo= erroneous if they are not assignable.
sigmund@google.com [Fri, 17 Apr 2015 18:34:29 +0000 (18:34 +0000)]
Make super.foo= erroneous if they are not assignable.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1090923004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45250 260f80e4-7a28-3924-810f-c04153c831b5

40 hours agoDon’t search scope of top-level class twice
hausner@google.com [Fri, 17 Apr 2015 18:08:12 +0000 (18:08 +0000)]
Don’t search scope of top-level class twice

When resolving an identifier in top-level code, we don’t need
to search the class scope. That scope is searched again when
resolving the identifier in the library scope.

Sadly, the change makes no measurable difference. It’s just a drop
in the bucket.

R=regis@google.com

Review URL: https://codereview.chromium.org//1092053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45249 260f80e4-7a28-3924-810f-c04153c831b5

41 hours agoUse UnaryOperator and BinaryOperator in ConstantSystem.
johnniwinther@google.com [Fri, 17 Apr 2015 17:52:20 +0000 (17:52 +0000)]
Use UnaryOperator and BinaryOperator in ConstantSystem.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1070293004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45248 260f80e4-7a28-3924-810f-c04153c831b5

41 hours agoFix dumpInfo: include information for methods that are not in the generated
sigmund@google.com [Fri, 17 Apr 2015 17:51:55 +0000 (17:51 +0000)]
Fix dumpInfo: include information for methods that are not in the generated
output (because of inlining, orelse)

R=sra@google.com

Review URL: https://codereview.chromium.org//1090243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45247 260f80e4-7a28-3924-810f-c04153c831b5

41 hours agoSkip spawn_function_root_library_test on Dartium.
rmacnak@google.com [Fri, 17 Apr 2015 17:44:38 +0000 (17:44 +0000)]
Skip spawn_function_root_library_test on Dartium.

BUG=

Review URL: https://codereview.chromium.org//1094933002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45246 260f80e4-7a28-3924-810f-c04153c831b5

41 hours agoRevert "Type and constant propagator should guard against mutable class ids."
vegorov@google.com [Fri, 17 Apr 2015 17:39:52 +0000 (17:39 +0000)]
Revert "Type and constant propagator should guard against mutable class ids."

This reverts commit r45243.

Reason: VM segfauls when running dart2js in Release mode.

TBR=fschneider@google.com

Review URL: https://codereview.chromium.org//1093873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45245 260f80e4-7a28-3924-810f-c04153c831b5

41 hours agoBug fixes and clean-up
brianwilkerson@google.com [Fri, 17 Apr 2015 17:03:01 +0000 (17:03 +0000)]
Bug fixes and clean-up

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1096613004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45244 260f80e4-7a28-3924-810f-c04153c831b5

41 hours agoType and constant propagator should guard against mutable class ids.
vegorov@google.com [Fri, 17 Apr 2015 16:58:25 +0000 (16:58 +0000)]
Type and constant propagator should guard against mutable class ids.

Constant strings can be externalized so we can't fold away class checks against them.

R=fschneider@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//1097723002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45243 260f80e4-7a28-3924-810f-c04153c831b5

42 hours agoAdds comments about ARM versions.
zra@google.com [Fri, 17 Apr 2015 16:42:32 +0000 (16:42 +0000)]
Adds comments about ARM versions.

R=regis@google.com

Review URL: https://codereview.chromium.org//1067663004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45242 260f80e4-7a28-3924-810f-c04153c831b5

42 hours agoMove constant systems into their own libraries.
johnniwinther@google.com [Fri, 17 Apr 2015 16:29:44 +0000 (16:29 +0000)]
Move constant systems into their own libraries.
BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1091443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45241 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agoRepair a CPS integrity violation.
kmillikin@google.com [Fri, 17 Apr 2015 13:02:20 +0000 (13:02 +0000)]
Repair a CPS integrity violation.

If replacing a use with another one will orphan the original, then it needs
to be unlinked from the CPS term graph.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//1090203002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45240 260f80e4-7a28-3924-810f-c04153c831b5

45 hours agoRevert "dart2js: fully assemble program before emitting it."
karlklose@google.com [Fri, 17 Apr 2015 12:58:05 +0000 (12:58 +0000)]
Revert "dart2js: fully assemble program before emitting it."

This reverts commit r45237.

TBR=herhut@google.com

Review URL: https://codereview.chromium.org//1095803005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45239 260f80e4-7a28-3924-810f-c04153c831b5

46 hours agoAdjust test expectations for dart2js_extra.
karlklose@google.com [Fri, 17 Apr 2015 12:47:20 +0000 (12:47 +0000)]
Adjust test expectations for dart2js_extra.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1066803006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45238 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agodart2js: fully assemble program before emitting it.
herhut@google.com [Fri, 17 Apr 2015 11:47:57 +0000 (11:47 +0000)]
dart2js: fully assemble program before emitting it.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1072403005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45237 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoAdjust test expectations for dart2js-cps-ir.
karlklose@google.com [Fri, 17 Apr 2015 11:45:51 +0000 (11:45 +0000)]
Adjust test expectations for dart2js-cps-ir.

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1092013003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45236 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoCPS implementation of throw and rethrow.
kmillikin@google.com [Fri, 17 Apr 2015 11:15:45 +0000 (11:15 +0000)]
CPS implementation of throw and rethrow.

Throw and rethrow are implemented as CPS expressions in tail position.

The CPS translation assumes that all expressions translate to a primitive
that is the value of the expression, and throw is an expression in Dart.
For simplicity of the translation, a non-tail throw Primitive is sometimes
used as a placeholder during the translation and removed immediately
afterward.

Both throw and rethrow are represented in the Tree IR.  In the Dart backend,
throw translates to throw and rethrow translates to rethrow.  In the JS
backend, throw translates to JS throw of a wrapped value.  Rethrow is not
currently implemented for the JS backend, it bails out of the compiler.

R=asgerf@google.com
BUG=

Review URL: https://codereview.chromium.org//1092023002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45235 260f80e4-7a28-3924-810f-c04153c831b5

47 hours agoDocument that Uri.scheme and Uri.host are lower-case.
lrn@google.com [Fri, 17 Apr 2015 11:11:36 +0000 (11:11 +0000)]
Document that Uri.scheme and Uri.host are lower-case.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1092903002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45234 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix typo in test, add check of error thrown.
lrn@google.com [Fri, 17 Apr 2015 10:55:30 +0000 (10:55 +0000)]
Fix typo in test, add check of error thrown.

R=karlklose@google.com

Review URL: https://codereview.chromium.org//1063603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45233 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDo not emit stubName for static functions.
herhut@google.com [Fri, 17 Apr 2015 10:24:25 +0000 (10:24 +0000)]
Do not emit stubName for static functions.

BUG=
R=zarah@google.com

Review URL: https://codereview.chromium.org//1024893002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45232 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix names of some tests in dart2js_extra.
herhut@google.com [Fri, 17 Apr 2015 09:54:24 +0000 (09:54 +0000)]
Fix names of some tests in dart2js_extra.

BUG=
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1076183002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45231 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd test for correct filtering of ClassMirror.declarations.
herhut@google.com [Fri, 17 Apr 2015 09:53:26 +0000 (09:53 +0000)]
Add test for correct filtering of ClassMirror.declarations.

BUG=
R=ahe@google.com

Review URL: https://codereview.chromium.org//1079103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45230 260f80e4-7a28-3924-810f-c04153c831b5

2 days agodart2js: reify type variables as result of class enqueueing.
herhut@google.com [Fri, 17 Apr 2015 09:51:46 +0000 (09:51 +0000)]
dart2js: reify type variables as result of class enqueueing.

BUG=
R=zarah@google.com

Review URL: https://codereview.chromium.org//1086413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45229 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRemove redundant variable descriptors from optimized code.
fschneider@google.com [Fri, 17 Apr 2015 09:11:38 +0000 (09:11 +0000)]
Remove redundant variable descriptors from optimized code.

The unoptimized code already contains a copy of these, so
we don't need to store them in two places.

R=hausner@google.com

Review URL: https://codereview.chromium.org//1077793003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45228 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd Uri.directory constructor.
lrn@google.com [Fri, 17 Apr 2015 08:56:03 +0000 (08:56 +0000)]
Add Uri.directory constructor.

Make Directory.uri getter use the new constructor.
This also fixes that the uri getter doesn't work correctly on Windows.

Add uri getter on file system entity.

BUG= http://dartbug.com/17065
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1089183004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45227 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd uri getter on file system entity.
lrn@google.com [Fri, 17 Apr 2015 07:31:26 +0000 (07:31 +0000)]
Add uri getter on file system entity.

BUG= http://dartbug.com/20362
Also:
BUG= http://dartbug.com/19428
BUG= http://dartbug.com/17065
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1083393004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45226 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd asserts that isolates have a root library set up before they become runnable.
rmacnak@google.com [Fri, 17 Apr 2015 00:44:47 +0000 (00:44 +0000)]
Add asserts that isolates have a root library set up before they become runnable.

R=iposva@google.com

Review URL: https://codereview.chromium.org//1073983010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45224 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix List length size check; add test.
koda@google.com [Fri, 17 Apr 2015 00:34:44 +0000 (00:34 +0000)]
Fix List length size check; add test.

Ensures that we throw an exception rather than exit the VM (FATAL).

BUG=dart:23227
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1096433003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45223 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix XMLHTTPRequest JS type in _loadHunk
sra@google.com [Fri, 17 Apr 2015 00:30:09 +0000 (00:30 +0000)]
Fix XMLHTTPRequest JS type in _loadHunk

Saves ~100K on apps using defered loading

TBR=sigurdm@google.com

Review URL: https://codereview.chromium.org//1094713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45222 260f80e4-7a28-3924-810f-c04153c831b5

2 days ago- Avoid inconsistency of for example IterateObjects vs VisitObjects.
iposva@google.com [Thu, 16 Apr 2015 23:16:25 +0000 (23:16 +0000)]
- Avoid inconsistency of for example IterateObjects vs VisitObjects.
  The majority of the sites uses VisitXYZ.
- Removed IterateNew* and IterateOld* as they are not needed any longer.

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1090053003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45221 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoReduce instruction size on X64.
srdjan@google.com [Thu, 16 Apr 2015 21:10:23 +0000 (21:10 +0000)]
Reduce instruction size on X64.

R=regis@google.com

Review URL: https://codereview.chromium.org//1096573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45220 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoIssue 23184. Fix for exception when 'async' is used outside of a function body.
scheglov@google.com [Thu, 16 Apr 2015 19:39:39 +0000 (19:39 +0000)]
Issue 23184. Fix for exception when 'async' is used outside of a function body.

R=brianwilkerson@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=23184

Review URL: https://codereview.chromium.org//1098493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45219 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd support for debug break in Dart source.
regis@google.com [Thu, 16 Apr 2015 19:32:48 +0000 (19:32 +0000)]
Add support for debug break in Dart source.
The new flag --enable-debug-break turns the otherwise illegal Dart statement
  break "message";
into a break instruction preceded with a debug message, the equivalent of
emitting an Assembler::Stop("message").
Add a language test expecting a syntax error without the flag.
Change expected break instruction in arm64 simulator.
Remove constants related to now deleted simulator tracing on mips and arm64.

R=johnmccutchan@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//1087383002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45218 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd annotation for function declarations. Mark functions with performance problems...
rmacnak@google.com [Thu, 16 Apr 2015 19:06:35 +0000 (19:06 +0000)]
Add annotation for function declarations. Mark functions with performance problems in red.

Reduce the saturation of the coverage markers.

Creating service-refs is horribly expensive: build the details for call sites and function declarations lazily.

Report is_inlinable instead of CanBeInlined because the latter depends whether the function currently has code or breakpoints.

Review URL: https://codereview.chromium.org//1087833005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45217 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRevert "Change ListIterator to only check for concurrent modification at each iteration"
sra@google.com [Thu, 16 Apr 2015 18:53:39 +0000 (18:53 +0000)]
Revert "Change ListIterator to only check for concurrent modification at each iteration"
Revert "Fix ListIterator.iterator function hash for VM."

This is not as easy to optimize for dart2js as initially thought.
Revert this change while we discuss.

R=floitsch@google.com

Review URL: https://codereview.chromium.org//1064053007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45216 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd page view analytics to Observatory
johnmccutchan@google.com [Thu, 16 Apr 2015 16:36:27 +0000 (16:36 +0000)]
Add page view analytics to Observatory

BUG=
R=sethladd@google.com

Review URL: https://codereview.chromium.org//1087393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45215 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRename method for consistency
brianwilkerson@google.com [Thu, 16 Apr 2015 16:22:13 +0000 (16:22 +0000)]
Rename method for consistency

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1091003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45214 260f80e4-7a28-3924-810f-c04153c831b5

2 days agosuggest "this." local fields in constructor param
danrubel@google.com [Thu, 16 Apr 2015 16:06:26 +0000 (16:06 +0000)]
suggest "this." local fields in constructor param

BUG=dartbug.com/22685
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1082233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45213 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoRename EMPTY_ARRAY to EMPTY_LIST in element model
brianwilkerson@google.com [Thu, 16 Apr 2015 15:54:10 +0000 (15:54 +0000)]
Rename EMPTY_ARRAY to EMPTY_LIST in element model

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1061993003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45212 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix additional cases where analysis server might send null, violating protocol.
paulberry@google.com [Thu, 16 Apr 2015 15:41:39 +0000 (15:41 +0000)]
Fix additional cases where analysis server might send null, violating protocol.

In addition, modify the code generation so that these protocol
violations will be caught by assertions during unit tests.
Previously, they would only be caught at runtime by client code.

R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1083223003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45211 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix "edit.format" to follow protocol when there is no selection.
paulberry@google.com [Thu, 16 Apr 2015 14:44:55 +0000 (14:44 +0000)]
Fix "edit.format" to follow protocol when there is no selection.

BUG=dartbug.com/23230
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1092653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45210 260f80e4-7a28-3924-810f-c04153c831b5

2 days agocps-ir: Replace getter-invocation methods in IR builder.
asgerf@google.com [Thu, 16 Apr 2015 14:02:57 +0000 (14:02 +0000)]
cps-ir: Replace getter-invocation methods in IR builder.

The IR builder is poorly equipped to decide the order in which to
evaluate things.

ISSUE=https://code.google.com/p/dart/issues/detail?id=23229
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1090873002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45209 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoUpdate android dartium status for timing-out test.
whesse@google.com [Thu, 16 Apr 2015 13:52:03 +0000 (13:52 +0000)]
Update android dartium status for timing-out test.

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1061753005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45208 260f80e4-7a28-3924-810f-c04153c831b5

2 days agotree-ir bugfix: Count unseen uses instead of seen uses.
asgerf@google.com [Thu, 16 Apr 2015 13:03:09 +0000 (13:03 +0000)]
tree-ir bugfix: Count unseen uses instead of seen uses.

Keeping track of the number of "seen uses" of a variable is too fragile
since it needs bookkeeping whenever we merge two variable uses.

I've changed it to track the number of unseen uses instead. The
bookkeeping is simpler because we aren't going to transform an unseen
use.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1080343003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45207 260f80e4-7a28-3924-810f-c04153c831b5

2 days agodart2js: don't reify type variables for reflectable typedefs.
zarah@google.com [Thu, 16 Apr 2015 12:39:48 +0000 (12:39 +0000)]
dart2js: don't reify type variables for reflectable typedefs.

R=herhut@google.com

Review URL: https://codereview.chromium.org//1095523002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45206 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoUse --use-cps-ir compiler option in the test script to run dart2js with the new backend.
karlklose@google.com [Thu, 16 Apr 2015 11:25:11 +0000 (11:25 +0000)]
Use --use-cps-ir compiler option in the test script to run dart2js with the new backend.

R=ricow@google.com

Review URL: https://codereview.chromium.org//1064053005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45205 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoFix typo in Completer.sync documentation.
lrn@google.com [Thu, 16 Apr 2015 11:23:09 +0000 (11:23 +0000)]
Fix typo in Completer.sync documentation.

BUG= http://dartbug.com/23171
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1076233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45204 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoAdd a command line option to use the new CPS based backend.
karlklose@google.com [Thu, 16 Apr 2015 11:22:02 +0000 (11:22 +0000)]
Add a command line option to use the new CPS based backend.

R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1089793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45203 260f80e4-7a28-3924-810f-c04153c831b5

2 days agoDon't report firefox crash reports
ricow@google.com [Thu, 16 Apr 2015 11:17:12 +0000 (11:17 +0000)]
Don't report firefox crash reports

This disables firefox crash reporting (which will show a pop up dialog)

R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1027093004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45202 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUpdate status for Chrome 42 dart2js
whesse@google.com [Thu, 16 Apr 2015 09:31:25 +0000 (09:31 +0000)]
Update status for Chrome 42 dart2js

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1089363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45200 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoFix ListIterator.iterator function hash for VM.
lrn@google.com [Thu, 16 Apr 2015 09:17:56 +0000 (09:17 +0000)]
Fix ListIterator.iterator function hash for VM.

Review URL: https://codereview.chromium.org//1094533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45199 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoChange ListIterator to only check for concurrent modification at each iteration
lrn@google.com [Thu, 16 Apr 2015 09:07:58 +0000 (09:07 +0000)]
Change ListIterator to only check for concurrent modification at each iteration
in checked mode.

It also checks at the end in all cases.

Iteration only goes from 0 to the original length of the list.
This ensures that iterating a list while adding to it (like by x.addAll(x))
is caught instead of growing until out-of-memory.
For well-behaved programs this makes no difference since length and original
length stay the same.
Also, it means that calling moveNext again later, after increasing the length,
will not make iteration continue. After returning false, iteration is always
done.
However, it means that reducing the length causes an out-of-range read before
reaching the end, and before a concurrent modification error can happen.

R=sra@google.com

Review URL: https://codereview.chromium.org//1024843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45198 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUpdate changelog.md with Isolate API and HtmlConvert changes.
lrn@google.com [Thu, 16 Apr 2015 09:02:52 +0000 (09:02 +0000)]
Update changelog.md with Isolate API and HtmlConvert changes.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1087163002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45197 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUpdate minify_many_locals_test to match capabilities.
johnniwinther@google.com [Thu, 16 Apr 2015 08:57:54 +0000 (08:57 +0000)]
Update minify_many_locals_test to match capabilities.

BUG=

Review URL: https://codereview.chromium.org//1084393002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45196 260f80e4-7a28-3924-810f-c04153c831b5

3 days agocps-ir: Clean-ups in type propagator.
asgerf@google.com [Thu, 16 Apr 2015 08:12:04 +0000 (08:12 +0000)]
cps-ir: Clean-ups in type propagator.

R=karlklose@google.com, kmillikin@google.com

Review URL: https://codereview.chromium.org//1088153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45195 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUse templates for BulkMixin messages.
johnniwinther@google.com [Thu, 16 Apr 2015 08:01:36 +0000 (08:01 +0000)]
Use templates for BulkMixin messages.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1091483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45194 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoDon't run cps backend dart2js tests in batch mode
ricow@google.com [Thu, 16 Apr 2015 07:52:45 +0000 (07:52 +0000)]
Don't run cps backend dart2js tests in batch mode

R=karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//1090813002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45193 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoMove LibraryUnitTarget into API.
scheglov@google.com [Thu, 16 Apr 2015 00:06:20 +0000 (00:06 +0000)]
Move LibraryUnitTarget into API.

We need this Target to use it in the Angular plugin.

Also increment version with the goal to publish the analyzer package and use in the Angular plugin.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1082913007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45192 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAdd fatal-warnings flag, that turns warnings into compilation errors (the name
sigmund@google.com [Wed, 15 Apr 2015 23:17:21 +0000 (23:17 +0000)]
Add fatal-warnings flag, that turns warnings into compilation errors (the name
fatal-warnings was choosen to match the flag in dartanalyzer)

BUG= http://dartbug.com/8803
R=johnniwinther@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//1077373003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45190 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoFix off-by-one error in https://code.google.com/p/dart/source/detail?r=45153
dgrove@google.com [Wed, 15 Apr 2015 23:13:40 +0000 (23:13 +0000)]
Fix off-by-one error in https://code.google.com/p/dart/source/detail?r=45153
and https://code.google.com/p/dart/source/detail?r=45154 .

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1055283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45189 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js implementation of StringBuffer.writeAll that optimizes better.
sra@google.com [Wed, 15 Apr 2015 23:13:29 +0000 (23:13 +0000)]
dart2js implementation of StringBuffer.writeAll that optimizes better.

Sometimes we can avoid the StringBuffer object:

    t1 = new P.StringBuffer(leftDelimiter);
    t1.writeAll$2(parts, ", ");
    t1 = t1._contents += rightDelimiter;
    return t1.charCodeAt(0) == 0 ? t1 : t1;
-->
    t1 = P.StringBuffer__writeAll(leftDelimiter, parts, ", ") + rightDelimiter;
    return t1.charCodeAt(0) == 0 ? t1 : t1;

Also updated tests with missing cases.

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45184
Reverted: https://code.google.com/p/dart/source/detail?r=45186

Review URL: https://codereview.chromium.org//1086043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45188 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoDo not use erroneouselement unless the member is static
sigmund@google.com [Wed, 15 Apr 2015 23:10:06 +0000 (23:10 +0000)]
Do not use erroneouselement unless the member is static

R=het@google.com, johnniwinther@google.com

Review URL: https://codereview.chromium.org//1089463003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45187 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRevert "dart2js implementation of StringBuffer.writeAll that optimizes better."
sra@google.com [Wed, 15 Apr 2015 22:55:05 +0000 (22:55 +0000)]
Revert "dart2js implementation of StringBuffer.writeAll that optimizes better."

StringBuffer.writeAll is expected by pub tests to not be patched or inlined.  I'll fix that and redo.

TBR=lrn@google.com

Review URL: https://codereview.chromium.org//1085423003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45186 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoNever mark free list elements.
koda@google.com [Wed, 15 Apr 2015 22:18:07 +0000 (22:18 +0000)]
Never mark free list elements.

Avoid confusion between heap premarking and verification by introducing the
invariant that FreeListElement is never marked.

Also fix incorrect statement about instruction objects being allocated premarked.

R=iposva@google.com

Review URL: https://codereview.chromium.org//1092473002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45185 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js implementation of StringBuffer.writeAll that optimizes better.
sra@google.com [Wed, 15 Apr 2015 22:02:05 +0000 (22:02 +0000)]
dart2js implementation of StringBuffer.writeAll that optimizes better.

Sometimes we can avoid the StringBuffer object:

    t1 = new P.StringBuffer(leftDelimiter);
    t1.writeAll$2(parts, ", ");
    t1 = t1._contents += rightDelimiter;
    return t1.charCodeAt(0) == 0 ? t1 : t1;
-->
    t1 = P.StringBuffer__writeAll(leftDelimiter, parts, ", ") + rightDelimiter;
    return t1.charCodeAt(0) == 0 ? t1 : t1;

Also updated tests with missing cases.

R=lrn@google.com

Review URL: https://codereview.chromium.org//1086043002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45184 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUse mock ProcessResult in optimizing_pub_package_map_provider_test.
paulberry@google.com [Wed, 15 Apr 2015 20:55:18 +0000 (20:55 +0000)]
Use mock ProcessResult in optimizing_pub_package_map_provider_test.

This will make it feasible to cherry-pick this test into older
versions of Dart in which the ProcessResult constructor is private.

Also, fix some "unused variable" hints.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1062853006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45183 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoImplement bigint shift intrinsics on IA32.
regis@google.com [Wed, 15 Apr 2015 20:46:24 +0000 (20:46 +0000)]
Implement bigint shift intrinsics on IA32.
Make shifter register ECX explicit in shld and shrd instructions on IA32.
Fix bad encoding of shld and shrd on X64 and update assembler tests.

Review URL: https://codereview.chromium.org//1089003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45182 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAdds a simarmv5te build and test target.
zra@google.com [Wed, 15 Apr 2015 20:44:43 +0000 (20:44 +0000)]
Adds a simarmv5te build and test target.

Also:
- Removes command line flags to choose simulated arm version.
  I think we should use build targets instead, like in this change,
  to make building and testing more obvious.
- Skips pkg tests on all simulators.

R=regis@google.com, ricow@google.com

Review URL: https://codereview.chromium.org//1077823002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45181 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAnother fix for unused elements.
scheglov@google.com [Wed, 15 Apr 2015 20:32:15 +0000 (20:32 +0000)]
Another fix for unused elements.

It turned out that the way I run analyzer tests misses the new task model tests.
And (un)fortunately bots run them correctly, so some of the are red now.

TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1089653002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45180 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoupdate changelog for 1.9.3 release and date
kevmoo@google.com [Wed, 15 Apr 2015 19:47:54 +0000 (19:47 +0000)]
update changelog for 1.9.3 release and date

R=nweiz@google.com

Review URL: https://codereview.chromium.org//1083213002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45179 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoFix another false positive for not used function type alias.
scheglov@google.com [Wed, 15 Apr 2015 19:45:49 +0000 (19:45 +0000)]
Fix another false positive for not used function type alias.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1061003004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45178 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRevert "dart2js: add compiler builtins to the core-runtime."
floitsch@google.com [Wed, 15 Apr 2015 19:30:09 +0000 (19:30 +0000)]
Revert "dart2js: add compiler builtins to the core-runtime."

This reverts commit r45176.

Review URL: https://codereview.chromium.org//1091613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45177 260f80e4-7a28-3924-810f-c04153c831b5

3 days agodart2js: add compiler builtins to the core-runtime.
floitsch@google.com [Wed, 15 Apr 2015 19:17:57 +0000 (19:17 +0000)]
dart2js: add compiler builtins to the core-runtime.

WIP.

R=johnniwinther@google.com, sra@google.com

Review URL: https://codereview.chromium.org//954253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45176 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoUpdate analyzer status files after r45169.
paulberry@google.com [Wed, 15 Apr 2015 17:17:46 +0000 (17:17 +0000)]
Update analyzer status files after r45169.

TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1085343002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45174 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoBefore write-protecting a PageSpace, return bump allocation block to freelist.
koda@google.com [Wed, 15 Apr 2015 16:59:02 +0000 (16:59 +0000)]
Before write-protecting a PageSpace, return bump allocation block to freelist.

This fixes a potential issue where attempts to iterate over a write-protected
heap might try to ensure it's walkable by writing a header into the bump block.

R=asiva@google.com

Review URL: https://codereview.chromium.org//1071393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45173 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoStop generating error when ignoring function bodies (issue 23207)
brianwilkerson@google.com [Wed, 15 Apr 2015 16:11:12 +0000 (16:11 +0000)]
Stop generating error when ignoring function bodies (issue 23207)

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1059753005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45172 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRevert "Remove an unused field from one of the CPS translation classes."
kmillikin@google.com [Wed, 15 Apr 2015 16:10:36 +0000 (16:10 +0000)]
Revert "Remove an unused field from one of the CPS translation classes."

This reverts SVN revision 45168.  The return value of
IrBuilder.buildFunctionHeader is used in the JS backend for constructor type
parameters.  It should be possible to do it a different way but it's too
tangled for a quick fix.

BUG=

Review URL: https://codereview.chromium.org//1059443008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45171 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoAvoid redundant calls to "pub list" when multiple dependencies change.
paulberry@google.com [Wed, 15 Apr 2015 16:02:18 +0000 (16:02 +0000)]
Avoid redundant calls to "pub list" when multiple dependencies change.

BUG=dartbug.com/22574
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1089453002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45170 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRemove embedder-package scheme
johnmccutchan@google.com [Wed, 15 Apr 2015 15:49:50 +0000 (15:49 +0000)]
Remove embedder-package scheme

- Soon mojo embedder private packages will be imported with a 'dart:_' prefixes.
- Add an explicit test of transitive private library access. This ensures that imports of 'dart:embedder_private_packages' cannot access anything imported within it.

R=zra@google.com

Review URL: https://codereview.chromium.org//1066613004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45169 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoRemove an unused field from one of the CPS translation classes.
kmillikin@google.com [Wed, 15 Apr 2015 15:13:22 +0000 (15:13 +0000)]
Remove an unused field from one of the CPS translation classes.

BUG=
R=asgerf@google.com

Review URL: https://codereview.chromium.org//1087243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45168 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoCapture annotations on enums (issue 23071)
brianwilkerson@google.com [Wed, 15 Apr 2015 14:33:39 +0000 (14:33 +0000)]
Capture annotations on enums (issue 23071)

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1087223002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45167 260f80e4-7a28-3924-810f-c04153c831b5

3 days agotree-ir: Always declare captured variables.
asgerf@google.com [Wed, 15 Apr 2015 13:36:20 +0000 (13:36 +0000)]
tree-ir: Always declare captured variables.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1090593002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45166 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoDon't permit annotations inside variable declarations.
paulberry@google.com [Wed, 15 Apr 2015 13:28:38 +0000 (13:28 +0000)]
Don't permit annotations inside variable declarations.

This addresses the root cause of dartbug.com/23176.

BUG=dartbug.com/23204
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1083093002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45165 260f80e4-7a28-3924-810f-c04153c831b5

3 days agoImprove precision of JS printer callbacks (2nd try)
johnniwinther@google.com [Wed, 15 Apr 2015 12:09:15 +0000 (12:09 +0000)]
Improve precision of JS printer callbacks (2nd try)

BUG=
R=floitsch@google.com, sra@google.com

Review URL: https://codereview.chromium.org//1081313003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@45164 260f80e4-7a28-3924-810f-c04153c831b5