keertip@google.com [Tue, 21 May 2013 19:59:25 +0000 (19:59 +0000)]
add support for pub deploy
R=danrubel@google.com
Review URL: https://codereview.chromium.org//
15586002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22954
260f80e4-7a28-3924-810f-
c04153c831b5
nweiz@google.com [Tue, 21 May 2013 18:59:29 +0000 (18:59 +0000)]
Stop working around issue 10721.
R=gram@google.com
Review URL: https://codereview.chromium.org//
15589002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22953
260f80e4-7a28-3924-810f-
c04153c831b5
gram@google.com [Tue, 21 May 2013 18:50:12 +0000 (18:50 +0000)]
Fix the Skia build for Android.
This will allow the APKs to build successfully, but they are not working anymore. It's a useful step towards fixing them at least.
R=vsm@google.com
Review URL: https://codereview.chromium.org//
15317012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22952
260f80e4-7a28-3924-810f-
c04153c831b5
brianwilkerson@google.com [Tue, 21 May 2013 18:39:43 +0000 (18:39 +0000)]
Failed attempt to reproduce issue 10753. Even though I couldn't reproduce the problem, I think the tests are valuable.
R=jwren@google.com
Review URL: https://codereview.chromium.org//
15581002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22951
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Tue, 21 May 2013 18:35:34 +0000 (18:35 +0000)]
Fix memory leak after closing project
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//
15568003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22950
260f80e4-7a28-3924-810f-
c04153c831b5
jwren@google.com [Tue, 21 May 2013 18:26:11 +0000 (18:26 +0000)]
Checkpoint for more inheritance error codes 'Missing inherited member' warnings.
Added isAbstract to the PropertyAccessorElement
R=brianwilkerson@google.com, scheglov@google.com
Review URL: https://codereview.chromium.org//
15500002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22949
260f80e4-7a28-3924-810f-
c04153c831b5
vsm@google.com [Tue, 21 May 2013 17:43:24 +0000 (17:43 +0000)]
Fix svg_test
This broke on last week's roll as several interfaces were removed.
R=blois@google.com
Review URL: https://codereview.chromium.org//
15404006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22948
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Tue, 21 May 2013 16:15:35 +0000 (16:15 +0000)]
Fix status files and test.
Forgot to rollback one test.
R=brianwilkerson@google.com, jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//
15563012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22947
260f80e4-7a28-3924-810f-
c04153c831b5
brianwilkerson@google.com [Tue, 21 May 2013 15:36:03 +0000 (15:36 +0000)]
Fix scanning when there is no identifier after dollar in interpolation
R=scheglov@google.com
Review URL: https://codereview.chromium.org//
15563011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22946
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Tue, 21 May 2013 15:35:43 +0000 (15:35 +0000)]
Report DUPLICATE_CONSTRUCTOR_NAME and other scope fixes
R=brianwilkerson@google.com, jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//
15271006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22945
260f80e4-7a28-3924-810f-
c04153c831b5
brianwilkerson@google.com [Tue, 21 May 2013 15:32:37 +0000 (15:32 +0000)]
Fix exception
R=scheglov@google.com
Review URL: https://codereview.chromium.org//
15402009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22944
260f80e4-7a28-3924-810f-
c04153c831b5
fschneider@google.com [Tue, 21 May 2013 15:15:47 +0000 (15:15 +0000)]
Refactor the IL for object allocation with type arguments.
Two parts:
1. Change AllocateObjectWithBoundsCheck to a normal call that takes
four arguments on the stack using PushArgument IL instructions.
Before inputs were in registers and the instruction pushed them itself
before the runtime call. This make the code more compact and simplifies
the flow graph builder.
2. Simplify instructions for building constructor type arguments for another
special case to simplify the instruction pattern and generate smaller
code for that case.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//
15564004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22943
260f80e4-7a28-3924-810f-
c04153c831b5
antonm@google.com [Tue, 21 May 2013 14:18:00 +0000 (14:18 +0000)]
Changes for the roll.
TBR=vsm@google.com
Review URL: https://codereview.chromium.org//
15250010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22942
260f80e4-7a28-3924-810f-
c04153c831b5
antonm@google.com [Tue, 21 May 2013 14:17:03 +0000 (14:17 +0000)]
Chrome roll 197749->198577.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22941
260f80e4-7a28-3924-810f-
c04153c831b5
vsm@google.com [Tue, 21 May 2013 14:13:08 +0000 (14:13 +0000)]
DEPS AutoUpdate: tools to 1244 (2013-05-21 07:07:28 -0700) antonm@google.com
Chrome roll 197749->198577.
http://src.chromium.org/viewvc/multivm/trunk/tools?view=rev&revision=1244
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22940
260f80e4-7a28-3924-810f-
c04153c831b5
ngeoffray@google.com [Tue, 21 May 2013 14:09:11 +0000 (14:09 +0000)]
When recording the type of a captured variable/parameter, use the closure field it maps to. Otherwise, there is a confusion for a parameter between the type given by its callers, and the actual type in the method, where the parameter can be updated explictly, or implicitly by the inferrer on "is checks".
R=karlklose@google.com
Review URL: https://codereview.chromium.org//
15414004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22939
260f80e4-7a28-3924-810f-
c04153c831b5
ngeoffray@google.com [Tue, 21 May 2013 13:22:16 +0000 (13:22 +0000)]
Add the cast equivalent of assertSubtype and assertSubtypeOfRuntimeType.
R=karlklose@google.com
Review URL: https://codereview.chromium.org//
15563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22938
260f80e4-7a28-3924-810f-
c04153c831b5
ricow@google.com [Tue, 21 May 2013 13:08:10 +0000 (13:08 +0000)]
Update js shell to version 21
Review URL: https://codereview.chromium.org//
15371006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22937
260f80e4-7a28-3924-810f-
c04153c831b5
ahe@google.com [Tue, 21 May 2013 11:58:03 +0000 (11:58 +0000)]
Shard dart2js unit tests as well.
R=johnniwinther@google.com, kustermann@google.com, ricow@google.com
Review URL: https://codereview.chromium.org//
15337003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22935
260f80e4-7a28-3924-810f-
c04153c831b5
ahe@google.com [Tue, 21 May 2013 11:55:52 +0000 (11:55 +0000)]
Fix a non-bool value used in boolean expression.
Review URL: https://codereview.chromium.org//
15470012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22934
260f80e4-7a28-3924-810f-
c04153c831b5
kustermann@google.com [Tue, 21 May 2013 11:54:38 +0000 (11:54 +0000)]
Correctly set the timeout of tests when using selenium
R=ricow@google.com
Review URL: https://codereview.chromium.org//
15563002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22933
260f80e4-7a28-3924-810f-
c04153c831b5
ajohnsen@google.com [Tue, 21 May 2013 11:11:49 +0000 (11:11 +0000)]
Ensure to close file-stream on all errors.
BUG=
Review URL: https://codereview.chromium.org//
15337005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22932
260f80e4-7a28-3924-810f-
c04153c831b5
fschneider@google.com [Tue, 21 May 2013 11:09:34 +0000 (11:09 +0000)]
Further improve and simplify IL for building constructor type arguments.
Generate constants in the IL directly if possible and avoid temporary
local store/load completely in some cases.
R=kmillikin@google.com
Review URL: https://codereview.chromium.org//
14672035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22931
260f80e4-7a28-3924-810f-
c04153c831b5
ngeoffray@google.com [Tue, 21 May 2013 11:06:46 +0000 (11:06 +0000)]
Fix a pretty bad bug of a class inheriting a patched class. The fix is
1) only use declarations when quering for subtypes or subclasses
2) allow to lookup injected members and super injected members in lookupSelector and forEachMember.
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//
15381002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22930
260f80e4-7a28-3924-810f-
c04153c831b5
ngeoffray@google.com [Tue, 21 May 2013 10:47:20 +0000 (10:47 +0000)]
Detect dead code, and handle breaks and continues in inferrer.
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//
14623030
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22929
260f80e4-7a28-3924-810f-
c04153c831b5
ajohnsen@google.com [Tue, 21 May 2013 10:37:20 +0000 (10:37 +0000)]
Try and fix test for windows, by delaying dir delete to file-stream's onDone is called.
BUG=
Review URL: https://codereview.chromium.org//
15360003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22928
260f80e4-7a28-3924-810f-
c04153c831b5
johnniwinther@google.com [Tue, 21 May 2013 09:59:45 +0000 (09:59 +0000)]
Fix bug in http_impl.
BUG=
Review URL: https://codereview.chromium.org//
15529005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22927
260f80e4-7a28-3924-810f-
c04153c831b5
kasperl@google.com [Tue, 21 May 2013 09:41:24 +0000 (09:41 +0000)]
Make sure ClosureClassElement implements all abstract members (parseNode) and fix == on MalformedType and GenericType.
R=johnniwinther@google.com
BUG=
Review URL: https://codereview.chromium.org//
15549002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22926
260f80e4-7a28-3924-810f-
c04153c831b5
johnniwinther@google.com [Tue, 21 May 2013 09:40:08 +0000 (09:40 +0000)]
Handle assignability for Send and SendSet.
R=karlklose@google.com
Committed: https://code.google.com/p/dart/source/detail?r=22847
Review URL: https://codereview.chromium.org//
13084013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22925
260f80e4-7a28-3924-810f-
c04153c831b5
kmillikin@google.com [Tue, 21 May 2013 09:34:50 +0000 (09:34 +0000)]
A few simple cleanups.
* Remove BlockEntryInstr::PrepareEntry and use EmitNativeCode to emit the
native code.
* Use Array::element_offset in a few places.
* Comment and identifier fixes.
R=fschneider@google.com
BUG=
Review URL: https://codereview.chromium.org//
15529003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22924
260f80e4-7a28-3924-810f-
c04153c831b5
ngeoffray@google.com [Tue, 21 May 2013 09:26:26 +0000 (09:26 +0000)]
Fix compile time warning, spotted by dart-analyzer.
R=ahe@google.com
Review URL: https://codereview.chromium.org//
15539005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22923
260f80e4-7a28-3924-810f-
c04153c831b5
ajohnsen@google.com [Tue, 21 May 2013 09:22:24 +0000 (09:22 +0000)]
Add 'start' and 'end' optional arguments to File.openRead(). This makes it possible to stream a sub-range of a file.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//
15547003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22922
260f80e4-7a28-3924-810f-
c04153c831b5
ahe@google.com [Tue, 21 May 2013 09:11:14 +0000 (09:11 +0000)]
Only reference JSUnknown when it is instantiated.
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//
15529004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22921
260f80e4-7a28-3924-810f-
c04153c831b5
ajohnsen@google.com [Tue, 21 May 2013 09:01:20 +0000 (09:01 +0000)]
Add timeouts to HttpClient.
This introduces a per-connection timeout, configurable by setting
HttpClient.idleTimeout.
This also introduces a per-HttpClient timeout that will close idle
connections, if there have been no active connections for 100 ms.
BUG=https://code.google.com/p/dart/issues/detail?id=4857
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//
15268004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22920
260f80e4-7a28-3924-810f-
c04153c831b5
ahe@google.com [Tue, 21 May 2013 07:35:46 +0000 (07:35 +0000)]
Pass enqueuer to registerCatchStatement
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//
15521006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22919
260f80e4-7a28-3924-810f-
c04153c831b5
ngeoffray@google.com [Tue, 21 May 2013 07:31:07 +0000 (07:31 +0000)]
Add a new flag to dart2js: --trust-type-annotations and implement it in the types inferrer.
R=kasperl@google.com
Review URL: https://codereview.chromium.org//
14969040
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22918
260f80e4-7a28-3924-810f-
c04153c831b5
ahe@google.com [Tue, 21 May 2013 07:24:19 +0000 (07:24 +0000)]
Don't expose native exceptions that aren't backed by a native class.
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//
15102009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22917
260f80e4-7a28-3924-810f-
c04153c831b5
kustermann@google.com [Tue, 21 May 2013 07:15:01 +0000 (07:15 +0000)]
Add '-static' to ldflags when target architecture is ARM.
R=zra@google.com
Review URL: https://codereview.chromium.org//
15293005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22916
260f80e4-7a28-3924-810f-
c04153c831b5
asiva@google.com [Tue, 21 May 2013 01:02:28 +0000 (01:02 +0000)]
- Some of the pre registered classes like Int, Double etc. were not being
marked as being prefinalized. Mark them as pre finalized.
- Replaced the check (cls.functions() != Object::empty_array().raw()) as
indicating it is a pre-registered class.
R=regis@google.com
Review URL: https://codereview.chromium.org//
15494008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22914
260f80e4-7a28-3924-810f-
c04153c831b5
rnystrom@google.com [Tue, 21 May 2013 00:09:22 +0000 (00:09 +0000)]
Gracefully handle pubspecs with dependencies using unknown sources.
BUG=https://code.google.com/p/dart/issues/detail?id=10190
R=nweiz@google.com
Review URL: https://codereview.chromium.org//
15347004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22913
260f80e4-7a28-3924-810f-
c04153c831b5
srdjan@google.com [Mon, 20 May 2013 23:59:36 +0000 (23:59 +0000)]
Intrinsify random nextState, improve perfromance significantly.
R=zra@google.com
Review URL: https://codereview.chromium.org//
15502004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22912
260f80e4-7a28-3924-810f-
c04153c831b5
vsm@google.com [Mon, 20 May 2013 23:43:44 +0000 (23:43 +0000)]
Roll IDL forward in DEPS.
R=blois@google.com
Review URL: https://codereview.chromium.org//
15499007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22911
260f80e4-7a28-3924-810f-
c04153c831b5
nweiz@google.com [Mon, 20 May 2013 23:30:37 +0000 (23:30 +0000)]
Split out unittest tests whose behavior differs in minified mode.
R=gram@google.com
Review URL: https://codereview.chromium.org//
15492003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22910
260f80e4-7a28-3924-810f-
c04153c831b5
devoncarew@google.com [Mon, 20 May 2013 23:11:55 +0000 (23:11 +0000)]
Re-add test for the chrome apps wizard.
R=pquitslund@google.com
Review URL: https://codereview.chromium.org//
15499004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22909
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Mon, 20 May 2013 21:42:00 +0000 (21:42 +0000)]
Always use dialog in rename refactoring.
R=messick@google.com
BUG=
Review URL: https://codereview.chromium.org//
15495002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22908
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Mon, 20 May 2013 21:40:53 +0000 (21:40 +0000)]
Semantic highlighting for deprecated
R=messick@google.com
BUG=
Review URL: https://codereview.chromium.org//
15495004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22907
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Mon, 20 May 2013 21:06:38 +0000 (21:06 +0000)]
Update services after issue 10017 fix
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//
15479007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22906
260f80e4-7a28-3924-810f-
c04153c831b5
devoncarew@google.com [Mon, 20 May 2013 21:02:30 +0000 (21:02 +0000)]
TBR temporarily disabling an editor test
Review URL: https://codereview.chromium.org//
15492006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22905
260f80e4-7a28-3924-810f-
c04153c831b5
iposva@google.com [Mon, 20 May 2013 21:01:31 +0000 (21:01 +0000)]
- Add a GetClassId() to Object, so that we do not have to
create a temporary class handle only to get at an object's
class id, which is stored in the object header.
R=asiva@google.com
Review URL: https://codereview.chromium.org//
15338008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22904
260f80e4-7a28-3924-810f-
c04153c831b5
devoncarew@google.com [Mon, 20 May 2013 20:55:11 +0000 (20:55 +0000)]
Update the chrome app wizard to be more in-line with the current best practices for writing chrome apps in Dart.
-use js interop to access the apis (and reference the pub chrome library)
-change the html file to use dart by default, and add a note about how to deploy as javascript
-add a build.dart which re-writes package symlinks (chrome apps do not work with symlinks)
R=pquitslund@google.com
Review URL: https://codereview.chromium.org//
15388006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22903
260f80e4-7a28-3924-810f-
c04153c831b5
pquitslund@google.com [Mon, 20 May 2013 20:44:38 +0000 (20:44 +0000)]
Fix for display of SDK version info when none is installed (dartbug.com/10606).
R=keertip@google.com
Review URL: https://codereview.chromium.org//
15338006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22902
260f80e4-7a28-3924-810f-
c04153c831b5
pquitslund@google.com [Mon, 20 May 2013 20:21:08 +0000 (20:21 +0000)]
Fix for plugin support of dart ignores (dartbug.com/10441).
R=keertip@google.com
Review URL: https://codereview.chromium.org//
15388004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22901
260f80e4-7a28-3924-810f-
c04153c831b5
danrubel@google.com [Mon, 20 May 2013 20:19:13 +0000 (20:19 +0000)]
resurrect samples tests
+ modify samples test to use new analysis engine
+ modify resolvers to prevent NPE if URI has null scheme
+ add xml attribute convenience methods
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//
15397004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22900
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Mon, 20 May 2013 19:49:44 +0000 (19:49 +0000)]
Report MULTIPLE_REDIRECTING_CONSTRUCTOR_INVOCATIONS and other redirection related.
R=brianwilkerson@google.com, jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//
15316011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22899
260f80e4-7a28-3924-810f-
c04153c831b5
brianwilkerson@google.com [Mon, 20 May 2013 19:24:59 +0000 (19:24 +0000)]
More bullet-proofing in analysis context
R=danrubel@google.com
Review URL: https://codereview.chromium.org//
15489005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22898
260f80e4-7a28-3924-810f-
c04153c831b5
pquitslund@google.com [Mon, 20 May 2013 18:41:35 +0000 (18:41 +0000)]
Tooltip resize fix (dartbug.com/10155).
R=keertip@google.com
Review URL: https://codereview.chromium.org//
15489003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22897
260f80e4-7a28-3924-810f-
c04153c831b5
keertip@google.com [Mon, 20 May 2013 18:28:46 +0000 (18:28 +0000)]
fix for editors to open file store inputs
R=pquitslund@google.com
Review URL: https://codereview.chromium.org//
15468007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22896
260f80e4-7a28-3924-810f-
c04153c831b5
brianwilkerson@google.com [Mon, 20 May 2013 18:01:10 +0000 (18:01 +0000)]
Fixes for issues 10017 and 10161
R=scheglov@google.com
Review URL: https://codereview.chromium.org//
15277005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22895
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Mon, 20 May 2013 16:55:42 +0000 (16:55 +0000)]
Restore rename project participant
R=keertip@google.com
BUG=
Review URL: https://codereview.chromium.org//
15316013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22894
260f80e4-7a28-3924-810f-
c04153c831b5
asiva@google.com [Mon, 20 May 2013 16:02:30 +0000 (16:02 +0000)]
Add a call to CheckIsolateState in all paths of Dart_GetField and Dart_SetField.
R=ager@chromium.org
Review URL: https://codereview.chromium.org//
15353002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22893
260f80e4-7a28-3924-810f-
c04153c831b5
sigmund@google.com [Mon, 20 May 2013 16:00:58 +0000 (16:00 +0000)]
remove _root from todomvc example
R=dgrove@google.com
Review URL: https://codereview.chromium.org//
15471003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22892
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Mon, 20 May 2013 15:56:52 +0000 (15:56 +0000)]
Report ParserErrorCode.CONST_CONSTRUCTOR_WITH_BODY and other body-related errors
R=brianwilkerson@google.com, jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//
15269005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22891
260f80e4-7a28-3924-810f-
c04153c831b5
vsm@google.com [Mon, 20 May 2013 15:55:06 +0000 (15:55 +0000)]
Update ENABLE_* flags
Bring this up to date with:
http://src.chromium.org/viewvc/multivm/trunk/webkit/Source/core/features.gypi?revision=1242
Note, this does *not* change any generated code. Unused flags where
removed. Added flags are precautionary. They don't affect generated
code, but they are defined in a Chromium build.
R=antonm@google.com
Review URL: https://codereview.chromium.org//
15294015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22890
260f80e4-7a28-3924-810f-
c04153c831b5
asiva@google.com [Mon, 20 May 2013 05:15:39 +0000 (05:15 +0000)]
Use handles to save the object being read before calling StorePointer to make
sure we are GC safe.
R=iposva@google.com
Review URL: https://codereview.chromium.org//
15383002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22889
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Sun, 19 May 2013 23:47:10 +0000 (23:47 +0000)]
Report CTEC.IMPLICIT_THIS_REFERENCE_IN_INITIALIZER
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//
15409002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22888
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Sun, 19 May 2013 23:38:00 +0000 (23:38 +0000)]
Update CONST_CONSTRUCTOR_WITH_NON_FINAL_FIELD to check also super/mixin types
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//
15409004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22887
260f80e4-7a28-3924-810f-
c04153c831b5
ajohnsen@google.com [Sat, 18 May 2013 09:15:29 +0000 (09:15 +0000)]
Fix socket leak in HttpServer, when the connection is closed while receiving data.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//
15293002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22886
260f80e4-7a28-3924-810f-
c04153c831b5
ajohnsen@google.com [Sat, 18 May 2013 09:12:56 +0000 (09:12 +0000)]
Use dart:crypto's Base64 methods in dart:io.
BUG=https://code.google.com/p/dart/issues/detail?id=9927
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//
15298004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22885
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Sat, 18 May 2013 01:40:17 +0000 (01:40 +0000)]
Fix dartc bot.
TBR
R=brianwilkerson@google.com, jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//
15400002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22884
260f80e4-7a28-3924-810f-
c04153c831b5
asiva@google.com [Fri, 17 May 2013 23:49:50 +0000 (23:49 +0000)]
Reuse _isOneByteWhitespace in all the classes for implementing _isWhitespace.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//
15339002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22882
260f80e4-7a28-3924-810f-
c04153c831b5
srdjan@google.com [Fri, 17 May 2013 23:45:08 +0000 (23:45 +0000)]
Cleanups: addressed your comments from https://codereview.chromium.org/
14962008/
R=iposva@google.com
Review URL: https://codereview.chromium.org//
14845021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22881
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Fri, 17 May 2013 23:10:51 +0000 (23:10 +0000)]
Remove old refactorings and tests
R=pquitslund@google.com
BUG=
Review URL: https://codereview.chromium.org//
15303013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22880
260f80e4-7a28-3924-810f-
c04153c831b5
nweiz@google.com [Fri, 17 May 2013 22:38:38 +0000 (22:38 +0000)]
Fix unittest for dart2js.
Review URL: https://codereview.chromium.org//
15350003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22878
260f80e4-7a28-3924-810f-
c04153c831b5
pquitslund@google.com [Fri, 17 May 2013 22:37:05 +0000 (22:37 +0000)]
Old model cleanup continued.
Review URL: https://codereview.chromium.org//
14676022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22877
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Fri, 17 May 2013 21:55:52 +0000 (21:55 +0000)]
Handle the new analyzer type warnings in tests.
Unfortunately we are back to 600+ failing tests.
R=brianwilkerson@google.com, jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//
14858051
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22876
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Fri, 17 May 2013 21:37:14 +0000 (21:37 +0000)]
Report ParserErrorCode.MISSING_IDENTIFIER
Fixes many trivial co19 tests.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//
15260002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22875
260f80e4-7a28-3924-810f-
c04153c831b5
nweiz@google.com [Fri, 17 May 2013 21:31:35 +0000 (21:31 +0000)]
Fix an analyzer error in unittest.
Review URL: https://codereview.chromium.org//
15344002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22874
260f80e4-7a28-3924-810f-
c04153c831b5
nweiz@google.com [Fri, 17 May 2013 21:10:15 +0000 (21:10 +0000)]
Add pretty-printing to unittest and more thoroughly print values.
This adds a prettyPrint function that knows to respect line lengths and avoid
printing too much of very large objects. Because that function has built-in
guards against over-printing, the default error formatter is changed to print
the actual value by default.
This also tweaks the output of some matchers to take advantage of the assumption
that the full actual value will always be printed.
R=gram@google.com
Review URL: https://codereview.chromium.org//
14600029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22873
260f80e4-7a28-3924-810f-
c04153c831b5
pquitslund@google.com [Fri, 17 May 2013 21:09:23 +0000 (21:09 +0000)]
Work-around for race condition in editor CU access.
Net-net: it's possible for the hyperlink detector to ask the editor for a compilation unit when there is not (yet) one. I'm guessing this happens during a parse. Anyway, this fix short-circuits hyperlink resolution in that case.
R=messick@google.com
Review URL: https://codereview.chromium.org//
14945007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22872
260f80e4-7a28-3924-810f-
c04153c831b5
asiva@google.com [Fri, 17 May 2013 20:59:39 +0000 (20:59 +0000)]
Remove obsolete code (FourByteString).
R=srdjan@google.com
Review URL: https://codereview.chromium.org//
15330002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22871
260f80e4-7a28-3924-810f-
c04153c831b5
brianwilkerson@google.com [Fri, 17 May 2013 20:55:20 +0000 (20:55 +0000)]
Fix for issue 9870
R=jwren@google.com
Review URL: https://codereview.chromium.org//
15329002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22870
260f80e4-7a28-3924-810f-
c04153c831b5
messick@google.com [Fri, 17 May 2013 20:10:22 +0000 (20:10 +0000)]
Add a proposal containing the argument list when completion is
requested in an empty argument list. Sort it to the top.
R=scheglov@google.com
Review URL: https://codereview.chromium.org//
14918011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22869
260f80e4-7a28-3924-810f-
c04153c831b5
jwren@google.com [Fri, 17 May 2013 19:54:05 +0000 (19:54 +0000)]
Checkpoint for inheritance manager error codes.
R=brianwilkerson@google.com, scheglov@google.com
Review URL: https://codereview.chromium.org//
15305010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22868
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Fri, 17 May 2013 19:40:54 +0000 (19:40 +0000)]
Document why CTEC.RECURSIVE_CONSTRUCTOR_REDIRECT was added
https://codereview.chromium.org/
15162010/
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//
15308002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22867
260f80e4-7a28-3924-810f-
c04153c831b5
hausner@google.com [Fri, 17 May 2013 18:37:28 +0000 (18:37 +0000)]
Always send kill signal to debug target
Make sure we kill the debug target process in all cases
to ensure that no zombie processes linger around.
Also make sure the cleanup code gets only called once.
Review URL: https://codereview.chromium.org//
15295014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22866
260f80e4-7a28-3924-810f-
c04153c831b5
hausner@google.com [Fri, 17 May 2013 17:08:09 +0000 (17:08 +0000)]
Make breakpoints on == fire reliably
Add breakpoints in the path taken if one of the operands
in a == b is null.
R=asiva@google.com
Review URL: https://codereview.chromium.org//
14991010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22857
260f80e4-7a28-3924-810f-
c04153c831b5
brianwilkerson@google.com [Fri, 17 May 2013 16:23:23 +0000 (16:23 +0000)]
Fix for issue 10700
R=scheglov@google.com
Review URL: https://codereview.chromium.org//
15305005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22856
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Fri, 17 May 2013 16:09:04 +0000 (16:09 +0000)]
Report UNDEFINED_CONSTRUCTOR_IN_INITIALIZER and others
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//
14856021
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22855
260f80e4-7a28-3924-810f-
c04153c831b5
brianwilkerson@google.com [Fri, 17 May 2013 15:46:01 +0000 (15:46 +0000)]
Initial support for gathering HTML tag data
R=messick@google.com
Review URL: https://codereview.chromium.org//
14861018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22854
260f80e4-7a28-3924-810f-
c04153c831b5
danrubel@google.com [Fri, 17 May 2013 15:40:31 +0000 (15:40 +0000)]
gracefully degrade if SDK is missing
+ provide mock SDK if SDK is missing
+ skip analysis if SDK is missing
+ do not auto download and install an SDK in Dart Plugins
R=brianwilkerson@google.com, pquitslund@google.com
Review URL: https://codereview.chromium.org//
14916010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22853
260f80e4-7a28-3924-810f-
c04153c831b5
scheglov@google.com [Fri, 17 May 2013 15:35:33 +0000 (15:35 +0000)]
Report CTEC.RECURSIVE_CONSTRUCTOR_REDIRECT
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//
15162010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22852
260f80e4-7a28-3924-810f-
c04153c831b5
danrubel@google.com [Fri, 17 May 2013 14:54:46 +0000 (14:54 +0000)]
java2dart cleanup
+ cleanup single line comment generation
+ null check when checking enclosing type
R=scheglov@google.com
Review URL: https://codereview.chromium.org//
14654016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22851
260f80e4-7a28-3924-810f-
c04153c831b5
ngeoffray@google.com [Fri, 17 May 2013 14:46:31 +0000 (14:46 +0000)]
Handle switch statement in simple types inferrer.
BUG=10581
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//
14890026
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22850
260f80e4-7a28-3924-810f-
c04153c831b5
danrubel@google.com [Fri, 17 May 2013 14:30:55 +0000 (14:30 +0000)]
package root fixes
+ add multiple package root test
+ fix package path on windows
R=keertip@google.com
Review URL: https://codereview.chromium.org//
14774010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22849
260f80e4-7a28-3924-810f-
c04153c831b5
ngeoffray@google.com [Fri, 17 May 2013 13:56:08 +0000 (13:56 +0000)]
Revert r22847: some dart2dart tests fail.
Review URL: https://codereview.chromium.org//
15301003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22848
260f80e4-7a28-3924-810f-
c04153c831b5
johnniwinther@google.com [Fri, 17 May 2013 12:00:47 +0000 (12:00 +0000)]
Handle assignability for Send and SendSet.
R=karlklose@google.com
Review URL: https://codereview.chromium.org//
13084013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22847
260f80e4-7a28-3924-810f-
c04153c831b5
karlklose@google.com [Fri, 17 May 2013 11:46:39 +0000 (11:46 +0000)]
Reapply "Enable full type-checks in checked mode."
R=ngeoffray@google.com
Review URL: https://codereview.chromium.org//
15299002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22846
260f80e4-7a28-3924-810f-
c04153c831b5
ngeoffray@google.com [Fri, 17 May 2013 11:13:32 +0000 (11:13 +0000)]
Reason on "is checks" in the types inferrer.
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//
14895018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22845
260f80e4-7a28-3924-810f-
c04153c831b5
ngeoffray@google.com [Fri, 17 May 2013 10:54:23 +0000 (10:54 +0000)]
Implement rethrow in dart-analyzer.
R=johnniwinther@google.com
Review URL: https://codereview.chromium.org//
15289002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22844
260f80e4-7a28-3924-810f-
c04153c831b5
karlklose@google.com [Fri, 17 May 2013 10:24:30 +0000 (10:24 +0000)]
Revert "Reapply "Enable full type-checks in checked mode.""
This reverts commit r22840.
Review URL: https://codereview.chromium.org//
15287002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22843
260f80e4-7a28-3924-810f-
c04153c831b5