external/guava-libraries.git
23 hours agoTrivial cleanups: master
Kurt Kluever [Fri, 24 May 2013 16:05:09 +0000 (12:05 -0400)]
Trivial cleanups:
- Remove stray paren in Ordering Javadoc.
- Fix runnable/executor confusion in ExecutionQueue Javadoc.
- Fix MockingModuleTester and FastStackTracer links that refer to type parameter T instead of its valid name, the erased type Object. Fix a few @see errors while there.
- Remove "This class is GWT compatible" comments, which have been redundant since we began using @GwtCompatible in testlib code.
- "unreasonable slow" => "unreasonably slow"
- Fix continued-line indent in Invokable.
- Insert spaces in cast expressions.
- Add missing spaces before open braces.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=47059317

23 hours agoAdd application/protobuf mime type, from
Kurt Kluever [Fri, 24 May 2013 16:00:35 +0000 (12:00 -0400)]
Add application/protobuf mime type, from
http://tools.ietf.org/html/draft-rfernando-protocol-buffers-00
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=47014458

23 hours agoDelete completely unused ConcurrentMapInterfaceTest.
Kurt Kluever [Fri, 24 May 2013 15:59:35 +0000 (11:59 -0400)]
Delete completely unused ConcurrentMapInterfaceTest.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=47004919

23 hours agoGuava issue 1423: fix TreeMultimap.asMap().headMap to properly register inclusivity...
Kurt Kluever [Fri, 24 May 2013 15:58:36 +0000 (11:58 -0400)]
Guava issue 1423: fix TreeMultimap.asMap().headMap to properly register inclusivity argument
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=47004337

2 days agoRemove tests for Multimap.get from AbstractMultimapTest that duplicate tests in Multi...
Chris Povirk [Wed, 22 May 2013 19:01:33 +0000 (15:01 -0400)]
Remove tests for Multimap.get from AbstractMultimapTest that duplicate tests in MultimapTestSuiteBuilder
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46990147

2 days agoAdd test suites for Multimap.equals to MultimapTestSuiteBuilder
Chris Povirk [Wed, 22 May 2013 18:57:29 +0000 (14:57 -0400)]
Add test suites for Multimap.equals to MultimapTestSuiteBuilder
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46989151

2 days agoMigrate Multimap.clear() tests (and tests to clear Multimap views) to MultimapClearTe...
Chris Povirk [Wed, 22 May 2013 18:48:26 +0000 (14:48 -0400)]
Migrate Multimap.clear() tests (and tests to clear Multimap views) to MultimapClearTester.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46987144

2 days agoRemove tests from AbstractMultimapTest that overlap with MultimapRemoveTester and...
Chris Povirk [Wed, 22 May 2013 18:43:51 +0000 (14:43 -0400)]
Remove tests from AbstractMultimapTest that overlap with MultimapRemoveTester and MultimapRemoveAllTester in MultimapTestSuiteBuilder.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46986379

3 days agoAdd MapToStringTester and MultimapToStringTester, and fix ForwardingNavigableMap...
Chris Povirk [Wed, 22 May 2013 13:17:39 +0000 (09:17 -0400)]
Add MapToStringTester and MultimapToStringTester, and fix ForwardingNavigableMap.StandardDescendingMap.toString() to correctly iterate in descending order.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46952541

3 days agoRemove get().subList() tests from AbstractListMultimapTest that are redundant with...
Chris Povirk [Wed, 22 May 2013 13:13:01 +0000 (09:13 -0400)]
Remove get().subList() tests from AbstractListMultimapTest that are redundant with ListSubListTester in the derived test suite for ListMultimapTestSuiteBuilder
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46951757

3 days agoAdd explicit type parameters in FilteredMultimapValues to make JDK6 happy.
Louis Wasserman [Tue, 21 May 2013 22:50:54 +0000 (15:50 -0700)]
Add explicit type parameters in FilteredMultimapValues to make JDK6 happy.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46951071

3 days agoDelete Multimap.contains{Key,Value} tests from AbstractMultimapTest that are redundan...
Louis Wasserman [Tue, 21 May 2013 22:49:47 +0000 (15:49 -0700)]
Delete Multimap.contains{Key,Value} tests from AbstractMultimapTest that are redundant with MultimapContains{Key,Value}Tester.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46951020

3 days agoRemove tests from AbstractListMultimapTest that are redundant with ListMultimapPutTester.
Louis Wasserman [Tue, 21 May 2013 22:48:13 +0000 (15:48 -0700)]
Remove tests from AbstractListMultimapTest that are redundant with ListMultimapPutTester.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46950561

3 days agoDelete tests from AbstractMultimapTest of the multimap views in isolation, that is...
Chris Povirk [Tue, 21 May 2013 22:27:06 +0000 (18:27 -0400)]
Delete tests from AbstractMultimapTest of the multimap views in isolation, that is, tests that initialize the multimap, get the view, and don't reference the multimap afterwards.

These tests are redundant with the derived TestSuiteBuilders in MultimapTestSuiteBuilder.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46949401

3 days agoMigrate all remaining Multimap.replaceValues tests from AbstractMultimapTest to Multi...
Chris Povirk [Tue, 21 May 2013 22:05:40 +0000 (18:05 -0400)]
Migrate all remaining Multimap.replaceValues tests from AbstractMultimapTest to MultimapReplaceAllTester
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46948091

3 days agoAdd tester to MultimapTestSuiteBuilder for Multimap.putAll(Multimap)
Chris Povirk [Tue, 21 May 2013 22:00:59 +0000 (18:00 -0400)]
Add tester to MultimapTestSuiteBuilder for Multimap.putAll(Multimap)
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46946989

3 days agoReplace Multimap.putAll(K, Iterable) tests from AbstractMultimapTest with more exhaus...
Chris Povirk [Tue, 21 May 2013 21:39:26 +0000 (17:39 -0400)]
Replace Multimap.putAll(K, Iterable) tests from AbstractMultimapTest with more exhaustive tests in MultimapPutIterableTester
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46945862

3 days agoAdd the TestSuiteBuilder for Multimap.values(), and fix Multimaps.filterXXX to pass...
Chris Povirk [Tue, 21 May 2013 21:35:16 +0000 (17:35 -0400)]
Add the TestSuiteBuilder for Multimap.values(), and fix Multimaps.filterXXX to pass those tests properly.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46945446

3 days agoRemove tests of Multimap.get() from AbstractMultimapTest that are duplicated in Multi...
Chris Povirk [Tue, 21 May 2013 20:43:06 +0000 (16:43 -0400)]
Remove tests of Multimap.get() from AbstractMultimapTest that are duplicated in MultimapGetTester
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46942143

3 days agoDelete tests from AbstractMultimapTest that duplicate tests in MultimapSizeTester.
Chris Povirk [Tue, 21 May 2013 20:16:37 +0000 (16:16 -0400)]
Delete tests from AbstractMultimapTest that duplicate tests in MultimapSizeTester.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46940075

3 days agoAdd Multimaps.asMap() helpers that return a Map with more
Chris Povirk [Tue, 21 May 2013 20:12:30 +0000 (16:12 -0400)]
Add Multimaps.asMap() helpers that return a Map with more
strongly-typed values than ListMultimap#asMap(), etc.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46939830

3 days agoAdd tests to the asMap() views of ListMultimap, SetMultimap, and SortedSetMultimap...
Chris Povirk [Tue, 21 May 2013 20:07:49 +0000 (16:07 -0400)]
Add tests to the asMap() views of ListMultimap, SetMultimap, and SortedSetMultimap to verify that the asMap().values() are of the correct type (List, Set, SortedSet) at runtime.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46939057

3 days agoChange return type of openBufferedStream() on ByteSource, ByteSink and CharSink to...
Louis Wasserman [Tue, 21 May 2013 16:22:17 +0000 (09:22 -0700)]
Change return type of openBufferedStream() on ByteSource, ByteSink and CharSink to the base stream type rather than the Buffered* type to allow implementations to avoid unnecessarily adding additional buffering to streams that do not benefit from it.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46926342

4 days agoReshuffling from internal-only changes.
Chris Povirk [Tue, 21 May 2013 14:20:45 +0000 (10:20 -0400)]
Reshuffling from internal-only changes.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46885542

4 days agoShuffling from internal-only changes.
Chris Povirk [Mon, 20 May 2013 17:31:06 +0000 (13:31 -0400)]
Shuffling from internal-only changes.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46844311

7 days agoGive removal dates for Stopwatch ctors.
Louis Wasserman [Fri, 17 May 2013 21:25:25 +0000 (14:25 -0700)]
Give removal dates for Stopwatch ctors.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46791249

7 days agoImprove error messaging in EqualsTester.
Louis Wasserman [Fri, 17 May 2013 21:23:54 +0000 (14:23 -0700)]
Improve error messaging in EqualsTester.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46753546

7 days agoImplement Object#equals() and #hashCode() for stateful HashFunctions.
Louis Wasserman [Fri, 17 May 2013 21:20:41 +0000 (14:20 -0700)]
Implement Object#equals() and #hashCode() for stateful HashFunctions.
Add tests to verify the behavior.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46751376

7 days agoOverride ImmutableBiMap.containsValue() to use the O(1) implementation, as per Guava...
Louis Wasserman [Fri, 17 May 2013 21:19:07 +0000 (14:19 -0700)]
Override ImmutableBiMap.containsValue() to use the O(1) implementation, as per Guava bug 1416.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46744049

8 days agoGive removal dates (releases) for HashFunction#hashString(CS) and
Louis Wasserman [Thu, 16 May 2013 20:30:59 +0000 (13:30 -0700)]
Give removal dates (releases) for HashFunction#hashString(CS) and
Hasher#putString(CS).
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46638784

8 days agoAdd reference to Funnels from Funnel javadocs.
Louis Wasserman [Thu, 16 May 2013 20:29:39 +0000 (13:29 -0700)]
Add reference to Funnels from Funnel javadocs.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46629147

8 days agoChange SynchronizedEventHandler to use a synchronized block rather than just synchron...
Louis Wasserman [Thu, 16 May 2013 20:27:58 +0000 (13:27 -0700)]
Change SynchronizedEventHandler to use a synchronized block rather than just synchronizing the method. Since the method body does nothing but call the super method, it (and its synchronization) was apparently being optimized away under a certain JVM: https://code.google.com/p/guava-libraries/issues/detail?id=1403
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46627764

11 days agoUse com.google.caliper.legacy.Benchmark instead of com.google.caliper.Benchmark....
Christian Edward Gruber [Mon, 13 May 2013 19:07:36 +0000 (12:07 -0700)]
Use com.google.caliper.legacy.Benchmark instead of com.google.caliper.Benchmark. This CL facilitates the move from a superclass-based API to an annotation-based API. Benchmark and legacy.Benchmark are equivalent classes, so this is NOT a behavior changing CL.

-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46556497

2 weeks agofixed NPE caused by inaccessible directory, as reported by Guava issue 1407.
Christian Edward Gruber [Sat, 11 May 2013 00:09:26 +0000 (17:09 -0700)]
fixed NPE caused by inaccessible directory, as reported by Guava issue 1407.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46478011

2 weeks agoFix the logging in Futures.CombinedFuture such that:
Christian Edward Gruber [Sat, 11 May 2013 00:07:53 +0000 (17:07 -0700)]
Fix the logging in Futures.CombinedFuture such that:

1. Errors are always logged (even if they were put into the output future)
2. If allMustSucceed is true then all failures after the first are logged
3. if allMustSucceed is false then all failures are not logged.

In the prior implementation (except for in rare races) exceptions were only logged if allMustSucceed was false.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46470009

2 weeks agoSome whitespace edits
Christian Edward Gruber [Sat, 11 May 2013 00:02:34 +0000 (17:02 -0700)]
Some whitespace edits

-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46404300

2 weeks agoUpdate Mozilla PSL.
Christian Edward Gruber [Sat, 11 May 2013 00:00:39 +0000 (17:00 -0700)]
Update Mozilla PSL.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46368166

2 weeks agoAdd some missing dependencies in a GWT module.
Christian Edward Gruber [Fri, 10 May 2013 23:58:31 +0000 (16:58 -0700)]
Add some missing dependencies in a GWT module.

-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46363258

2 weeks agoAdd Funnels#unencodedCharsFunnel (and deprecate Funnels#stringFunnel()).
Christian Edward Gruber [Fri, 10 May 2013 23:57:04 +0000 (16:57 -0700)]
Add Funnels#unencodedCharsFunnel (and deprecate Funnels#stringFunnel()).
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46350462

2 weeks agoRemove the rethrow Error behavior from AbstractFuture.
Christian Edward Gruber [Fri, 10 May 2013 23:55:35 +0000 (16:55 -0700)]
Remove the rethrow Error behavior from AbstractFuture.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46315153

2 weeks agoAdd a test for hashInt() vs. a loop w/ putByte().
Christian Edward Gruber [Fri, 10 May 2013 23:52:36 +0000 (16:52 -0700)]
Add a test for hashInt() vs. a loop w/ putByte().
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46295877

2 weeks agoChange ServiceManager.Listener to be an abstract class with empty implementations...
Christian Edward Gruber [Tue, 7 May 2013 00:26:31 +0000 (17:26 -0700)]
Change ServiceManager.Listener to be an abstract class with empty implementations of its callbacks instead of an interface.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46244288

2 weeks agoGuava issue 1322: deal with a potential overflow issue in ImmutableTable.
Colin Decker [Mon, 6 May 2013 15:30:17 +0000 (11:30 -0400)]
Guava issue 1322: deal with a potential overflow issue in ImmutableTable.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46160775

2 weeks agoFix typo in Maps.immutableEnumMap. See https://code.google.com/p/guava-libraries...
Colin Decker [Mon, 6 May 2013 15:29:14 +0000 (11:29 -0400)]
Fix typo in Maps.immutableEnumMap. See https://code.google.com/p/guava-libraries/issues/detail?id=1397
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46145330

3 weeks agoChange Service.Listener from an interface to an abstract class with no-op implementat...
Colin Decker [Wed, 1 May 2013 18:35:59 +0000 (14:35 -0400)]
Change Service.Listener from an interface to an abstract class with no-op implementations of all the callbacks.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46026613

3 weeks agoAllow a max size of 0 for EvictingQueue
Colin Decker [Wed, 1 May 2013 18:34:55 +0000 (14:34 -0400)]
Allow a max size of 0 for EvictingQueue
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=46003229

3 weeks agoUse hashFoo() shortcuts instead of newHasher().putFoo().hash().
Colin Decker [Wed, 1 May 2013 18:33:20 +0000 (14:33 -0400)]
Use hashFoo() shortcuts instead of newHasher().putFoo().hash().
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45995812

3 weeks agoRemove incorrect test using UTF_16LE.
Colin Decker [Wed, 1 May 2013 18:29:22 +0000 (14:29 -0400)]
Remove incorrect test using UTF_16LE.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45985871

3 weeks agoChanged Invokable.from(constructor).getReturnType() to return ParameterizedType inste...
Chris Povirk [Mon, 29 Apr 2013 23:53:04 +0000 (19:53 -0400)]
Changed Invokable.from(constructor).getReturnType() to return ParameterizedType instead of raw class when the class is parameterized. This makes constructor invokable more consistent with factory method invokable.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45912432

4 weeks agoSort and removed unused imports in com/google/common.
Chris Povirk [Fri, 26 Apr 2013 18:26:42 +0000 (14:26 -0400)]
Sort and removed unused imports in com/google/common.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45827926

4 weeks agoAllow HashCode#padToLong to work with hashs that have <32 bits.
Chris Povirk [Wed, 24 Apr 2013 21:41:45 +0000 (17:41 -0400)]
Allow HashCode#padToLong to work with hashs that have <32 bits.
Fix a small typo in Hasher javadocs.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45717814

4 weeks agoCHANGE: Make HostAndPort GwtCompatible by getting rid of a regex.
Chris Povirk [Tue, 23 Apr 2013 20:25:26 +0000 (16:25 -0400)]
CHANGE: Make HostAndPort GwtCompatible by getting rid of a regex.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45669298

4 weeks agoChange FileByteSource.read() to not unnecessarily copy the byte array in the normal...
Chris Povirk [Mon, 22 Apr 2013 22:15:50 +0000 (18:15 -0400)]
Change FileByteSource.read() to not unnecessarily copy the byte array in the normal case where the file size doesn't change.

It was incorrectly assuming that if the first read loop filled the original array, the last read() call would have returned -1 if it was done, which is not the case.

Guava bug: https://code.google.com/p/guava-libraries/issues/detail?id=1376
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45616868

4 weeks agoFix apparently harmless but still incorrect references to module name.
Chris Povirk [Mon, 22 Apr 2013 19:41:48 +0000 (15:41 -0400)]
Fix apparently harmless but still incorrect references to module name.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45613704

4 weeks agoRemove unused HTML dependency.
Chris Povirk [Mon, 22 Apr 2013 18:41:53 +0000 (14:41 -0400)]
Remove unused HTML dependency.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45608957

4 weeks agoFix @since for EscaperAsserts.
Chris Povirk [Mon, 22 Apr 2013 16:10:50 +0000 (12:10 -0400)]
Fix @since for EscaperAsserts.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45601740

4 weeks agoAdd links to the hash function comparisons to the Hashing javadocs.
Chris Povirk [Mon, 22 Apr 2013 15:23:04 +0000 (11:23 -0400)]
Add links to the hash function comparisons to the Hashing javadocs.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45527021

4 weeks agoAdd a test to demonstrate that hashBytes(Ints.toByteArray(i)) ==
Chris Povirk [Mon, 22 Apr 2013 15:09:14 +0000 (11:09 -0400)]
Add a test to demonstrate that hashBytes(Ints.toByteArray(i)) ==
hashInt(Integer.reverseBytes(i)).
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45476839

4 weeks agoFixed a bug in rejectTypeVariable() where we failed to account for the owner type...
Chris Povirk [Mon, 22 Apr 2013 15:04:04 +0000 (11:04 -0400)]
Fixed a bug in rejectTypeVariable() where we failed to account for the owner type's type variables. For example:

abstract class From<K> {
class To<V> {
TypeToken<To<V>> type() {
return new TypeToken<To<V>>(getClass()) {};
}
}

static <K> TypeToken<From<K>.To<?>> cheat() {
return new From<K>().new To<String>() {}.type();
}

TypeToken<From<String>.To<?>> notReallyString = TheClass.<String>cheat();
notReallyString.rejectTypeVariables(); // Should throw
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45444012

4 weeks agoAdded TypeVisitor to make it easier to navigate type hierarchy, and used it to replac...
Chris Povirk [Mon, 22 Apr 2013 14:58:58 +0000 (10:58 -0400)]
Added TypeVisitor to make it easier to navigate type hierarchy, and used it to replace a few code duplications.

TypeVisitor might be able to become something that's releasable for users to check on individual sub-components of a Type. Or, if after learning use cases, all that's needed are hasTypeVariables() and hasWildcards(), we'll just add the higher level APIs.

See Guava issue: https://code.google.com/p/guava-libraries/issues/detail?id=1362
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45443595

4 weeks agoAdd tests for common aliases of SHA1.
Chris Povirk [Mon, 22 Apr 2013 14:54:07 +0000 (10:54 -0400)]
Add tests for common aliases of SHA1.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45427688

4 weeks agoRemove Platform.clone(), along with various supersource versions.
Chris Povirk [Mon, 22 Apr 2013 14:49:27 +0000 (10:49 -0400)]
Remove Platform.clone(), along with various supersource versions.
The last non-test caller was removed in CL 45290173.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45408889

4 weeks agoReshuffling from removal of internal-only method.
Chris Povirk [Mon, 22 Apr 2013 14:44:21 +0000 (10:44 -0400)]
Reshuffling from removal of internal-only method.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45408398

4 weeks agoRelease base escaper classes, HTML escapers, XML escapers, and URL escapers into...
Chris Povirk [Mon, 22 Apr 2013 14:06:23 +0000 (10:06 -0400)]
Release base escaper classes, HTML escapers, XML escapers, and URL escapers into Guava.
Keep the source-code escapers internal until we figure out which ones to recommend and what to name them.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45374049

5 weeks agoAdded code example to AbstractInvocationHandler to suggest users to use Reflection...
Kurt Kluever [Tue, 16 Apr 2013 16:49:18 +0000 (12:49 -0400)]
Added code example to AbstractInvocationHandler to suggest users to use Reflection.newProxy().
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45317940

5 weeks agofix some docs in ExecutionQueue
Kurt Kluever [Tue, 16 Apr 2013 16:46:52 +0000 (12:46 -0400)]
fix some docs in ExecutionQueue
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45311589

5 weeks agoadd csiro.au as TLD since is not listed on Mozilla PSL
Kurt Kluever [Mon, 15 Apr 2013 18:36:42 +0000 (14:36 -0400)]
add csiro.au as TLD since is not listed on Mozilla PSL
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45307952

5 weeks agoRun "normal" GWT tests in public Guava.
Louis Wasserman [Sat, 13 Apr 2013 19:02:12 +0000 (12:02 -0700)]
Run "normal" GWT tests in public Guava.
We still don't run the suite-builder tests, so the run is incomplete, but at least it's fairly quick:
Tests run: 6667, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 155.218 sec

Among the steps of this process covered by this CL:
- Export the generated GWTTestCase files into Guava.
- Add dependencies in guava-gwt on the guava (and guava-testlib) test sources.
- Treat the GWT portion of guava-testlib as though it is part of the guava-gwt tests (to sidestep the issue that we should really have a separate guava-testlib-gwt artifact analogous to the separate guava-gwt project). (Mainly this means putting its files under guava-gwt/tests.)
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45160153

5 weeks agoUse the renamingDecorator to ensure that Services always run in appropriately named...
Louis Wasserman [Sat, 13 Apr 2013 18:59:20 +0000 (11:59 -0700)]
Use the renamingDecorator to ensure that Services always run in appropriately named threads.

AbstractIdleService and AbstractScheduledService encode the current state in the name so you should see something like

MyService (STARTING|RUNNING|STOPPING)

AbstractExecutionThread service just uses the serviceName() (so it would be "MyService")  I could additionally try to encode the state but it didn't seem worth it.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45135687

5 weeks agoProvide ExecutorService decorators that will rename the threads in which its tasks...
Louis Wasserman [Sat, 13 Apr 2013 18:58:16 +0000 (11:58 -0700)]
Provide ExecutorService decorators that will rename the threads in which its tasks run for the duration of the task.

Open issues:
1. should any of these be public?  Currently I am only planning on using them for some of the Service base classes so package private is fine, but we may want to make them public.
2. I needed/wanted to use WrappingExecutorService but it was marked GoogleInternal, so i removed @GoogleInternal.  Is this ok? or should i use a similar private class? moe-strip public from it?
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45121293

5 weeks agoApply test.include to testlib tests as well as main tests.
Louis Wasserman [Sat, 13 Apr 2013 18:56:59 +0000 (11:56 -0700)]
Apply test.include to testlib tests as well as main tests.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45103307

5 weeks agoCloser.register supports null closeable
Louis Wasserman [Sat, 13 Apr 2013 18:53:23 +0000 (11:53 -0700)]
Closer.register supports null closeable
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45058002

5 weeks agoInternal refactoring to make it easy to expose a factory method that configures the...
Louis Wasserman [Sat, 13 Apr 2013 18:52:20 +0000 (11:52 -0700)]
Internal refactoring to make it easy to expose a factory method that configures the burst size
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=45016791

5 weeks agoConvert GWT-only tests into normal tests.
Louis Wasserman [Sat, 13 Apr 2013 18:31:40 +0000 (11:31 -0700)]
Convert GWT-only tests into normal tests.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44698403

6 weeks agoAdd ByteSource.empty() and CharSource.empty().
Christian Gruber [Mon, 8 Apr 2013 16:39:41 +0000 (09:39 -0700)]
Add ByteSource.empty() and CharSource.empty().
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44815909

6 weeks agoAdd nullWriter(), a Writer that discards everything written to it.
Christian Gruber [Mon, 8 Apr 2013 16:37:02 +0000 (09:37 -0700)]
Add nullWriter(), a Writer that discards everything written to it.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44805209

6 weeks agoMention the use of slice(offset, length) for viewing a range in the array to the...
Christian Gruber [Mon, 8 Apr 2013 16:35:46 +0000 (09:35 -0700)]
Mention the use of slice(offset, length) for viewing a range in the array to the ByteSource.wrap javadoc.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44798251

6 weeks agoFall back to countByReading if InputStream available always returns zero.
Christian Gruber [Mon, 8 Apr 2013 16:34:30 +0000 (09:34 -0700)]
Fall back to countByReading if InputStream available always returns zero.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44796829

6 weeks agoremove the queuedListeners lock from both ServiceManager and AbstractService.
Christian Gruber [Mon, 8 Apr 2013 16:28:12 +0000 (09:28 -0700)]
remove the queuedListeners lock from both ServiceManager and AbstractService.

The original idea of splitting the queuedListeners queue into one queue per listenerInstance didn't pan out because it didn't actually solve the issue of not holding a lock while submitting the listener to the executor.  So this is a different strategy.

I pulled all the listener execution logic into a new class called ListenerQueue which is analogous to ExecutionList (not sure about the name though...) which cleaned up both AbstractService and ServiceManager.

The approach is two-fold
1. do not remove a listener from the queue of listeners until it has definitely been submitted to its executor
2. ensure that submitting a listener to its executor happens no more than one time (using a lock).

N.B. we are still vulnerable to a weird or buggy executor implementation. If calling execute(runnable) runs for a long time without calling runnable.run then we can still deadlock.  I don't believe we can actually solve this problem without giving up on the ordering guarantees.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44709344

6 weeks agoConvert GWT-only tests into normal tests.
Christian Gruber [Mon, 8 Apr 2013 16:27:00 +0000 (09:27 -0700)]
Convert GWT-only tests into normal tests.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44698403

7 weeks agoFix a copy/paste mistake in CharSource javadoc.
Colin Decker [Mon, 1 Apr 2013 14:53:58 +0000 (10:53 -0400)]
Fix a copy/paste mistake in CharSource javadoc.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44648058

7 weeks agoAdd isPrimitive(), wrap(), and unwrap() methods to TypeToken
Colin Decker [Mon, 1 Apr 2013 14:51:32 +0000 (10:51 -0400)]
Add isPrimitive(), wrap(), and unwrap() methods to TypeToken
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44620879

7 weeks agoFix typo in javadoc: the name of the method to override is "compare", not "compareTo".
Colin Decker [Mon, 1 Apr 2013 14:48:08 +0000 (10:48 -0400)]
Fix typo in javadoc: the name of the method to override is "compare", not "compareTo".
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44580155

8 weeks agoA few small hash changes.
Colin Decker [Thu, 28 Mar 2013 21:54:12 +0000 (17:54 -0400)]
A few small hash changes.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44571077

8 weeks agoDeprecate the constructors in com.google.common.base.Stopwatch and Stopwatch#elapsedM...
Colin Decker [Thu, 28 Mar 2013 21:53:08 +0000 (17:53 -0400)]
Deprecate the constructors in com.google.common.base.Stopwatch and Stopwatch#elapsedMillis and #elapsedTime.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44568679

8 weeks agoReduce redundant iterator creation in Multimap.putAll(K, Iterable<? extends V>)
Colin Decker [Thu, 28 Mar 2013 21:51:58 +0000 (17:51 -0400)]
Reduce redundant iterator creation in Multimap.putAll(K, Iterable<? extends V>)
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44559924

8 weeks agonew Stopwatch(); -> Stopwatch.createUnstarted();
Colin Decker [Thu, 28 Mar 2013 16:14:57 +0000 (12:14 -0400)]
new Stopwatch(); -> Stopwatch.createUnstarted();
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44556107

8 weeks agoChange ByteStreams.asByteSource calls to ByteSource.wrap and deprecate it.
Colin Decker [Wed, 27 Mar 2013 20:29:19 +0000 (16:29 -0400)]
Change ByteStreams.asByteSource calls to ByteSource.wrap and deprecate it.
Change CharStreams.asCharSource calls to CharSource.wrap and deprecate it.
Change both deprecated methods to delegate to the replacement method.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44516201

8 weeks agoReplace new Stopwatch().start() with Stopwatch.createStarted().
Colin Decker [Wed, 27 Mar 2013 20:28:29 +0000 (16:28 -0400)]
Replace new Stopwatch().start() with Stopwatch.createStarted().
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44515274

8 weeks agoNullability fixes.
Colin Decker [Wed, 27 Mar 2013 20:27:36 +0000 (16:27 -0400)]
Nullability fixes.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44514905

8 weeks agoCopy ByteStreams.asByteSource(byte[]) to ByteSource.wrap(byte[]).
Colin Decker [Wed, 27 Mar 2013 20:26:27 +0000 (16:26 -0400)]
Copy ByteStreams.asByteSource(byte[]) to ByteSource.wrap(byte[]).
Copy CharStreams.asCharSource(String) to CharSource.wrap(CharSequence).

Add package-private CharSequenceReader and tests, for use by the CharSource.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44506727

8 weeks agoAdd Class-Path cycle detection to avoid StackOverflowError
Colin Decker [Wed, 27 Mar 2013 20:23:53 +0000 (16:23 -0400)]
Add Class-Path cycle detection to avoid StackOverflowError
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44466033

8 weeks agoThrows UOE in MutableTypeToInstanceMap Entry#set()
Colin Decker [Wed, 27 Mar 2013 20:22:43 +0000 (16:22 -0400)]
Throws UOE in MutableTypeToInstanceMap Entry#set()
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44465568

8 weeks agoAdd static factory methods to Stopwatch: createStarted() and
Colin Decker [Wed, 27 Mar 2013 20:21:50 +0000 (16:21 -0400)]
Add static factory methods to Stopwatch: createStarted() and
createUnstarted().
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44465501

8 weeks agoFix up some javadoc in TypeToken re: TypeLiteral.
Colin Decker [Wed, 27 Mar 2013 20:20:50 +0000 (16:20 -0400)]
Fix up some javadoc in TypeToken re: TypeLiteral.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44411479

8 weeks agoSome more refactoring of TypeResolver.TypeTable. I was in a hurry. The TypeTable...
Colin Decker [Wed, 27 Mar 2013 20:20:01 +0000 (16:20 -0400)]
Some more refactoring of TypeResolver.TypeTable. I was in a hurry. The TypeTable code wasn't in a form I'd LGTM.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44403308

2 months agoMake TypeResolver public in Guava.
Chris Povirk [Mon, 25 Mar 2013 15:01:49 +0000 (11:01 -0400)]
Make TypeResolver public in Guava.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44329762

2 months agoFix bug in statistics benchmarks implementation of Knuth algorithms.
Chris Povirk [Mon, 25 Mar 2013 14:50:58 +0000 (10:50 -0400)]
Fix bug in statistics benchmarks implementation of Knuth algorithms.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44319466

2 months agoChange Futures.allAsList and .successfulAsList to return an unmodifiable list.
Chris Povirk [Fri, 22 Mar 2013 14:47:24 +0000 (10:47 -0400)]
Change Futures.allAsList and .successfulAsList to return an unmodifiable list.
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44306369

2 months agoHasher#putString(CharSequence) to Hasher#putUnencodedChars(CharSequence)
Chris Povirk [Fri, 22 Mar 2013 14:40:53 +0000 (10:40 -0400)]
Hasher#putString(CharSequence) to Hasher#putUnencodedChars(CharSequence)
HashFunction#hashString(CharSequence) to HashFunction#hashUnencodedChars(CharSequence)
-------------
Created by MOE: http://code.google.com/p/moe-java
MOE_MIGRATED_REVID=44304885