external/skia/gyp.git
7 weeks agoremove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE master
commit-bot@chromium.org [Sat, 31 May 2014 21:47:03 +0000 (21:47 +0000)]
remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE

R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/308953002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@15016 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoNew file for simpler updating of Android defines.
commit-bot@chromium.org [Fri, 30 May 2014 21:53:01 +0000 (21:53 +0000)]
New file for simpler updating of Android defines.

When building Skia for the Android framework, we will now read a
file which only includes defines. This will make it easier for
people deprecating APIs to add the guard to Android.

R=reed@google.com, djsollen@google.com, bungeman@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/305193002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@15013 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoRevert of remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPAR...
commit-bot@chromium.org [Fri, 30 May 2014 21:03:38 +0000 (21:03 +0000)]
Revert of remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS (https://codereview.chromium.org/308083010/)

Reason for revert:
broke skia/ext/bitmap_platform_device_cairo.cc:44:56: error: no matching function for call to ‘SkBitmap::installPixels

Original issue's description:
> remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
>
> TBR=
> NOTRY=
>
> Committed: http://code.google.com/p/skia/source/detail?r=15007

TBR=
NOTREECHECKS=true
NOTRY=true

Author: reed@google.com

Review URL: https://codereview.chromium.org/301353006

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@15010 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoremove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
commit-bot@chromium.org [Fri, 30 May 2014 20:47:13 +0000 (20:47 +0000)]
remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS

TBR=
NOTRY=

Author: reed@google.com

Review URL: https://codereview.chromium.org/308083010

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@15007 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoRevert of Initial work to get ETC1 data up to the GPU (https://codereview.chromium...
commit-bot@chromium.org [Fri, 30 May 2014 20:36:21 +0000 (20:36 +0000)]
Revert of Initial work to get ETC1 data up to the GPU (https://codereview.chromium.org/302783002/)

Reason for revert:
ETC1 linking problems with chrome.

Original issue's description:
> Initial work to get ETC1 data up to the GPU
>
> Committed: http://code.google.com/p/skia/source/detail?r=15001

R=bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/303273008

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@15004 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoInitial work to get ETC1 data up to the GPU
commit-bot@chromium.org [Fri, 30 May 2014 18:41:39 +0000 (18:41 +0000)]
Initial work to get ETC1 data up to the GPU

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/302783002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@15001 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoTest font created from paint
commit-bot@chromium.org [Fri, 30 May 2014 16:46:10 +0000 (16:46 +0000)]
Test font created from paint

This is meant to allow clients to migrate over to a SkFont api on canvas (e.g. drawText(text, font, paint)) while still permitting the current setters in paint (e.g. setTextSize, setFlags).

R=bungeman@google.com, eae@chromium.org, fmalita@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/245953003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14997 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoRevert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)"
commit-bot@chromium.org [Fri, 30 May 2014 13:26:10 +0000 (13:26 +0000)]
Revert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)"

This reverts commit eecaea4148805834f223681f70b6488ceba12d09.

R=robertphillips@google.com, scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/301283003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14989 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoFix the rendering error of SkDraw::drawVertices in gpu path for solid color.
commit-bot@chromium.org [Fri, 30 May 2014 10:08:22 +0000 (10:08 +0000)]
Fix the rendering error of SkDraw::drawVertices in gpu path for solid color.

If both textures and vertex-colors are NULL, drawVertices should stroke hairlines with the paint's color.
This behavior is a useful debugging mode to visualize the mesh.

BUG=skia:2266
R=bsalomon@google.com, reed@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/189963004

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14985 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agonew animated sample to show subpixel translate bug with high quality scaling
commit-bot@chromium.org [Thu, 29 May 2014 22:01:08 +0000 (22:01 +0000)]
new animated sample to show subpixel translate bug with high quality scaling

BUG=1445
R=reed@google.com, robertphillips@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/303123003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14981 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoRevert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)
commit-bot@chromium.org [Thu, 29 May 2014 21:10:32 +0000 (21:10 +0000)]
Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)

Reason for revert:
broke all Windows bots

Original issue's description:
> setConfig -> setInfo
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14978

R=robertphillips@google.com, reed@google.com
TBR=reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: epoger@google.com

Review URL: https://codereview.chromium.org/302053002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14979 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agosetConfig -> setInfo
commit-bot@chromium.org [Thu, 29 May 2014 20:47:53 +0000 (20:47 +0000)]
setConfig -> setInfo

BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/308683005

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14978 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agomove SkImageGenerator.cpp from src/images to src/core
reed@google.com [Thu, 29 May 2014 18:47:06 +0000 (18:47 +0000)]
move SkImageGenerator.cpp from src/images to src/core

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14973 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoAdd testing for Rectanizer-derived classes
commit-bot@chromium.org [Thu, 29 May 2014 18:46:38 +0000 (18:46 +0000)]
Add testing for Rectanizer-derived classes

This in preparation for expanding the Rectanizer API for removing rects and adding a new derived class

R=jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/304313002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14972 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoadd SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
commit-bot@chromium.org [Thu, 29 May 2014 17:28:11 +0000 (17:28 +0000)]
add SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS

TBR=
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/309543002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14968 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoReland https://codereview.chromium.org/286903025
commit-bot@chromium.org [Thu, 29 May 2014 17:10:24 +0000 (17:10 +0000)]
Reland https://codereview.chromium.org/286903025

BUG=skia:
R=bensong@google.com, epoger@google.com

Author: kelvinly@google.com

Review URL: https://codereview.chromium.org/304613002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14966 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agocleanup gyp common_variables
djsollen@google.com [Thu, 29 May 2014 17:00:28 +0000 (17:00 +0000)]
cleanup gyp common_variables

R=bungeman@google.com

Review URL: https://codereview.chromium.org/301173002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14965 2bbb7eff-a529-9590-31e7-b0007b416f81

7 weeks agoRevert "Revert of add colortable support to imagegenerator (https://codereview.chromi...
commit-bot@chromium.org [Thu, 29 May 2014 15:57:20 +0000 (15:57 +0000)]
Revert "Revert of add colortable support to imagegenerator (https://codereview.chromium.org/304443003/)"

Fix is to add colortable param to installPixels()

This reverts commit 924205aaf2e0c3c65dda13e0eaccde3e7b2a5c40.

BUG=skia:
R=scroggo@google.com, reed@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/300263005

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14958 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoSet the default discardable pool size for Android framework.
commit-bot@chromium.org [Wed, 28 May 2014 21:44:05 +0000 (21:44 +0000)]
Set the default discardable pool size for Android framework.

BUG=skia:2389
R=halcanary@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/303893002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14939 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoadd flag to disable changes to image scaling to avoid breaking every single
commit-bot@chromium.org [Wed, 28 May 2014 19:52:54 +0000 (19:52 +0000)]
add flag to disable changes to image scaling to avoid breaking every single
layout test on blink all at once.

BUG=
R=epoger@google.com
TBR=epoger
NOTRY=True
NOTREECHECKS=True

Author: humper@google.com

Review URL: https://codereview.chromium.org/298133008

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14931 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoMake image scaling have floating point scales. Third attempt to land this
commit-bot@chromium.org [Wed, 28 May 2014 17:30:02 +0000 (17:30 +0000)]
Make image scaling have floating point scales.  Third attempt to land this
due to some struggles with the CQ.  Original CL here:

https://codereview.chromium.org/298243003/

BUG=
R=bsalomon@google.com, epoger@google.com
TBR=bsalomon, epoger

Author: humper@google.com

Review URL: https://codereview.chromium.org/300113008

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14920 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoRevert of add colortable support to imagegenerator (https://codereview.chromium.org...
commit-bot@chromium.org [Wed, 28 May 2014 16:16:08 +0000 (16:16 +0000)]
Revert of add colortable support to imagegenerator (https://codereview.chromium.org/304443003/)

Reason for revert:
failing tests

Original issue's description:
> add colortable support to imagegenerator
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14916

R=halcanary@google.com, scroggo@google.com
TBR=halcanary@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/300873007

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14917 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoadd colortable support to imagegenerator
commit-bot@chromium.org [Wed, 28 May 2014 16:01:55 +0000 (16:01 +0000)]
add colortable support to imagegenerator

BUG=skia:
R=halcanary@google.com, scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/304443003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14916 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoRevert of PictureBenchmark JSON logging (https://codereview.chromium.org/286903025/)
commit-bot@chromium.org [Tue, 27 May 2014 21:51:38 +0000 (21:51 +0000)]
Revert of PictureBenchmark JSON logging (https://codereview.chromium.org/286903025/)

Reason for revert:
Broke some Windows builds; see http://skbug.com/2609 ('certain Windows Build-* bots failing since r14905').

Before re-landing with a fix, please send to some of the trybots that failed the first time.

Original issue's description:
> Add JSON logging support to bench_pictures by adding a PictureResultsWriter class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h
>
> JSON format described in code, above PictureJSONResultsWriter class
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14906

R=bensong@google.com, jcgregorio@google.com, kelvinly@google.com
TBR=bensong@google.com, jcgregorio@google.com, kelvinly@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2609

Author: epoger@google.com

Review URL: https://codereview.chromium.org/306483010

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14910 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoremove SkBitmap::asImageInfo
commit-bot@chromium.org [Tue, 27 May 2014 21:30:37 +0000 (21:30 +0000)]
remove SkBitmap::asImageInfo

BUG=skia:
R=scroggo@google.com, halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/305483005

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14909 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoManual SVN revert of https://code.google.com/p/skia/source/detail?r=14905
epoger@google.com [Tue, 27 May 2014 21:12:42 +0000 (21:12 +0000)]
Manual SVN revert of https://code.google.com/p/skia/source/detail?r=14905

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14907 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoAdd JSON logging support to bench_pictures by adding a PictureResultsWriter class...
commit-bot@chromium.org [Tue, 27 May 2014 20:57:44 +0000 (20:57 +0000)]
Add JSON logging support to bench_pictures by adding a PictureResultsWriter class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h

JSON format described in code, above PictureJSONResultsWriter class

BUG=skia:
R=bensong@google.com, jcgregorio@google.com

Author: kelvinly@google.com

Review URL: https://codereview.chromium.org/286903025

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14906 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agofloating point scale factors for images
commit-bot@chromium.org [Tue, 27 May 2014 20:54:04 +0000 (20:54 +0000)]
floating point scale factors for images

New version of https://codereview.chromium.org/298243003/ made to deal with binary file being lost.

BUG=
TBR=bsalomon
NOTRY=true

Author: humper@google.com

Review URL: https://codereview.chromium.org/307553005

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14905 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoUse SkAtomics_sync on Android
commit-bot@chromium.org [Tue, 27 May 2014 15:55:35 +0000 (15:55 +0000)]
Use SkAtomics_sync on Android

Every doc I've found about using Android's atomics says, "stop".

"* A handful of basic atomic operations.  The appropriate pthread
 * functions should be used instead of these whenever possible."

"... we recommend stopping from using these functions entirely. Very fortunately, GCC provides handy intrinsics functions that work with very reasonable performance and always provide a full barrier."

As far as I can tell, there's no code generation change here: both the __sync atomics and the android_ atomics use full memory barriers.  (And now with this all unified, it'll be easier to get the real wins by switching everything to __atomic atomics, which are like __sync atomics but allow control over memory barriers.)

BUG=skia:
R=bungeman@google.com, djsollen@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/305593002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14896 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoDrop support for non-atomic non-mutex platforms.
commit-bot@chromium.org [Tue, 27 May 2014 15:16:37 +0000 (15:16 +0000)]
Drop support for non-atomic non-mutex platforms.

(Clients can still provide these themselves if they really want.)

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/295373005

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14894 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoMove SkDecodingImageGenerator.h to include/
commit-bot@chromium.org [Tue, 27 May 2014 14:59:47 +0000 (14:59 +0000)]
Move SkDecodingImageGenerator.h to include/

This will allow Android to access it and remove SkImageRef.

Depends on https://codereview.chromium.org/293283002/

BUG=skia:2389
R=reed@google.com, djsollen@google.com, halcanary@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/228613003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14891 2bbb7eff-a529-9590-31e7-b0007b416f81

8 weeks agoremove SK_SUPPORT_LEGACY_BUILDMIPMAP
commit-bot@chromium.org [Tue, 27 May 2014 00:23:36 +0000 (00:23 +0000)]
remove SK_SUPPORT_LEGACY_BUILDMIPMAP

TBR=scroggo

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/293393007

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14885 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoremove bit rotted gyp from most
commit-bot@chromium.org [Thu, 22 May 2014 20:09:05 +0000 (20:09 +0000)]
remove bit rotted gyp from most

BUG=skia:2597
R=epoger@google.com
TBR=epoger
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/297823004

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14857 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoremove bit rot test gyp
commit-bot@chromium.org [Thu, 22 May 2014 19:58:22 +0000 (19:58 +0000)]
remove bit rot test gyp

BUG=skia:2597
R=epoger@google.com
TBR=epoger
NOTRY=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/296053016

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14856 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoSimple PKM image decoder.
robertphillips@google.com [Thu, 22 May 2014 18:40:29 +0000 (18:40 +0000)]
Simple PKM image decoder.

https://codereview.chromium.org/292663011/

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14852 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRevert "Temporarily disable NEON on Android framework builds."
commit-bot@chromium.org [Thu, 22 May 2014 13:42:34 +0000 (13:42 +0000)]
Revert "Temporarily disable NEON on Android framework builds."

R=scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/294183002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14844 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRemove unused (by clients) SkUnitMapper
commit-bot@chromium.org [Thu, 22 May 2014 12:27:41 +0000 (12:27 +0000)]
Remove unused (by clients) SkUnitMapper

This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98.

TBR=scroggo

Author: reed@google.com

Review URL: https://codereview.chromium.org/288313009

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14842 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRevert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org...
commit-bot@chromium.org [Thu, 22 May 2014 02:55:59 +0000 (02:55 +0000)]
Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (https://codereview.chromium.org/288343009/)

Reason for revert:
required blink change failed to land

Original issue's description:
> Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
>
> This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14830

R=scroggo@google.com, reed@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/296823008

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14838 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRemove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
commit-bot@chromium.org [Wed, 21 May 2014 19:56:46 +0000 (19:56 +0000)]
Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)

This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.

BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/288343009

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14830 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRemove -mfpmath=sse for clang, which does it automatically and sometimes is annoyed...
commit-bot@chromium.org [Tue, 20 May 2014 19:42:03 +0000 (19:42 +0000)]
Remove -mfpmath=sse for clang, which does it automatically and sometimes is annoyed by it.

BUG=skia:

NOTREECHECKS=true
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/296793003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14812 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoSSE2 everywhere.
commit-bot@chromium.org [Tue, 20 May 2014 19:02:55 +0000 (19:02 +0000)]
SSE2 everywhere.

As of M35, Chrome will require SSE2 on Linux (it already did on Windows, and
requires SSSE3 on Macs).  Android already requires SSE2 for x86 chips.

This effectively just forces it on for 32-bit Linux builds; everyone else already had it.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14800

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/294963002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14811 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRevert of SSE2 everywhere. (https://codereview.chromium.org/294963002/)
commit-bot@chromium.org [Tue, 20 May 2014 15:27:35 +0000 (15:27 +0000)]
Revert of SSE2 everywhere. (https://codereview.chromium.org/294963002/)

Reason for revert:
Making GM run fewer tests than expected?

Original issue's description:
> SSE2 everywhere.
>
> As of M35, Chrome will require SSE2 on Linux (it already did on Windows, and
> requires SSSE3 on Macs).  Android already requires SSE2 for x86 chips.
>
> This effectively just forces it on for 32-bit Linux builds; everyone else already had it.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14800

R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/282093015

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14803 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoSince we're only using it on Linux now, just require poppler as a system dependency.
commit-bot@chromium.org [Tue, 20 May 2014 15:07:53 +0000 (15:07 +0000)]
Since we're only using it on Linux now, just require poppler as a system dependency.

The Ubuntu package needed is libpoppler-cpp-dev.

iconv and fontconfig were only used as Poppler dependencies.  bson_c is also unused.

BUG=skia:
R=reed@google.com, rmistry@google.com, borenet@google.com, halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/294683003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14802 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoSSE2 everywhere.
commit-bot@chromium.org [Tue, 20 May 2014 14:54:09 +0000 (14:54 +0000)]
SSE2 everywhere.

As of M35, Chrome will require SSE2 on Linux (it already did on Windows, and
requires SSSE3 on Macs).  Android already requires SSE2 for x86 chips.

This effectively just forces it on for 32-bit Linux builds; everyone else already had it.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/294963002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14800 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoAdd Memcpy32 bench.
commit-bot@chromium.org [Tue, 20 May 2014 14:54:04 +0000 (14:54 +0000)]
Add Memcpy32 bench.

This compares 32-bit copies using memcpy, autovectorization, and when SSE2 is
available, aligned and unaligned SSE2.

Running this on my desktop (Intel(R) Xeon(R) CPU E5-2690 0 @ 2.90GHz), I see
all four perform essentially the same, except Clang's autovectorization looks
 a little better than GCC's.  memcpy is calling libc 2.19's __memcpy_sse2_unaligned.

BUG=skia:
R=reed@google.com, qiankun.miao@intel.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/290533002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14799 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRemove legacy constructor for blur draw looper.
commit-bot@chromium.org [Tue, 20 May 2014 14:53:32 +0000 (14:53 +0000)]
Remove legacy constructor for blur draw looper.

Now that Android no longer uses the constructor, remove it, along
with the flag.

R=djsollen@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/299683002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14797 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoAdd Dashing gpu effect for simple dashed lines
commit-bot@chromium.org [Mon, 19 May 2014 14:32:49 +0000 (14:32 +0000)]
Add Dashing gpu effect for simple dashed lines

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/274673004

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14775 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoGenerate Android.mk for DM.
commit-bot@chromium.org [Fri, 16 May 2014 18:11:51 +0000 (18:11 +0000)]
Generate Android.mk for DM.

ifdef out code that won't build where we don't have jsoncpp.

Include ctype instead of string.h for tolower.

Depends on https://codereview.chromium.org/282053002/

BUG=skia:2447
R=mtklein@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/290603002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14768 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoGenerate gm/Android.mk, minus JSON.
commit-bot@chromium.org [Fri, 16 May 2014 17:56:43 +0000 (17:56 +0000)]
Generate gm/Android.mk, minus JSON.

When running gyp_to_android.py, generate the makefile for gm.

For now, remove json functionality and do not depend on json. This
allows us to build and run until solving skbug.com/2448.

gm/gm_expectations.cpp:
gm/gm_expectations.h:
gm/gmmain.cpp:
Remove all json functionality when SK_BUILD_JSON_WRITER is not defined.
This flag is not defined when SK_BUILD_FOR_ANDROID is defined.

gyp/gm.gyp:
Depend on skia and cutils.

platform_tools/android/bin/gyp_to_android.py:
Generate gm/Android.mk.

platform_tools/android/gyp_gen/makefile_writer.py:
Build gm/Android.mk when building external/skia.

Depends on https://codereview.chromium.org/282053002/

BUG=skia:2447
BUG=skia:2448
R=epoger@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/281303003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14767 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoDisable poppler on Windows since it no longer compiles in VS2013
commit-bot@chromium.org [Fri, 16 May 2014 16:35:48 +0000 (16:35 +0000)]
Disable poppler on Windows since it no longer compiles in VS2013

R=borenet@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/285293008

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14764 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRevert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org...
commit-bot@chromium.org [Fri, 16 May 2014 13:49:08 +0000 (13:49 +0000)]
Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)

Reason for revert:
does not address all legacy callsites in chrome.

e.g.

[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919]            gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));

Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761

R=robertphillips@google.com, scroggo@google.com, george@mozilla.com
TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/287063009

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14763 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoremove unused (by clients) SkUnitMapper
commit-bot@chromium.org [Fri, 16 May 2014 13:35:01 +0000 (13:35 +0000)]
remove unused (by clients) SkUnitMapper

BUG=skia:
R=robertphillips@google.com, scroggo@google.com, george@mozilla.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/283273002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14761 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoGenerate bench/Android.mk from gyp.
commit-bot@chromium.org [Fri, 16 May 2014 13:15:41 +0000 (13:15 +0000)]
Generate bench/Android.mk from gyp.

For now, remove json functionality and do not depend on json. This
allows us to build and run until solving skbug.com/2448.

bench/DeferredSurfaceCopyBench.cpp:
Include GrRenderTarget last, so SK_SUPPORT_GPU will be set properly.

bench/ResultsWriter.h:
bench/benchmain.cpp:
Remove JSONResultsWriter when SK_BUILD_JSON_WRITER is not defined,
which is the case for the Android framework build.

gyp/bench.gyp:
Depend on skia and cutils (for android_atomic_inc etc).

gyp/common_conditions.gypi:
Define SK_BUILD_JSON_WRITER when skia_build_json_writer is set.

gyp/common_variables.gypi:
Add a flag for skia_build_json_writer, and set it only when
skia_android_framework is not set.

gyp/jsoncpp.gyp:
Do not build jsoncpp when skia_build_json_writer is not defined.
include/utils/SkJSONCPP.h:
Do not include json headers when SK_BUILD_JSON_WRITER is not defined.

platform_tools/android/bin/gyp_to_android.py:
Generate bench/Android.mk.

platform_tools/android/gyp_gen/gypd_parser.py:
Skip dest_dir when checking for include_dirs.

platform_tools/android/gyp_gen/makefile_writer.py:
Build bench/Android.mk when building external/skia.

platform_tools/android/gyp_gen/tool_makefile_writer.py:
Add a parameter for putting the binary into /data/local/tmp.

BUG=skia:2447
BUG=skia:2448
R=halcanary@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/282053002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14760 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoFactor out DumpRecord method from dump_record tool for later use
commit-bot@chromium.org [Thu, 15 May 2014 16:10:37 +0000 (16:10 +0000)]
Factor out DumpRecord method from dump_record tool for later use

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/282233003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14751 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoDM: Add --skps.
commit-bot@chromium.org [Wed, 14 May 2014 17:55:32 +0000 (17:55 +0000)]
DM: Add --skps.

This does render_pictures, plus checks SkRecord optimizations.

Disable an SkRecord optimization that draws several bot SKPs wrong.  (To be investigated.)

BUG=skia:2378
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/270543004

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14739 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoremove reference to (deleted) SkKernel33MaskFilter
commit-bot@chromium.org [Wed, 14 May 2014 17:42:42 +0000 (17:42 +0000)]
remove reference to (deleted) SkKernel33MaskFilter

BUG=skia:
R=caryclark@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/281163002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14738 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRemove legacy SkLayerRasterizer flag for Android.
commit-bot@chromium.org [Tue, 13 May 2014 14:47:17 +0000 (14:47 +0000)]
Remove legacy SkLayerRasterizer flag for Android.

Android's uses of SkLayerRasterizer have been cleaned up and no longer require
the legacy API. Remove the flag for Android.
We still have to keep the legacy API around until Mozilla have cleaned up their
uses.

BUG=skia:2187
R=reed@google.com, djsollen@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/279383006

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14710 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoFix the android framework build as it still uses mutable local matrices.
djsollen@google.com [Tue, 13 May 2014 13:35:04 +0000 (13:35 +0000)]
Fix the android framework build as it still uses mutable local matrices.

R=reed@google.com

Review URL: https://codereview.chromium.org/284663004

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14706 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoadd SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX for chrome
commit-bot@chromium.org [Tue, 13 May 2014 00:43:44 +0000 (00:43 +0000)]
add SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX for chrome

TBR=borenet@google.com
NOTRY=True

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/286563004

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14704 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRemove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
commit-bot@chromium.org [Mon, 12 May 2014 14:12:38 +0000 (14:12 +0000)]
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.

Chrome/Blink doesn't use any of the legacy methods behind this flag any more.

BUG=skia:2187

Committed: http://code.google.com/p/skia/source/detail?r=14651

R=reed@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/265973002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14692 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoremove unused Kernel33MaskFilter
commit-bot@chromium.org [Mon, 12 May 2014 13:35:55 +0000 (13:35 +0000)]
remove unused Kernel33MaskFilter

R=robertphillips@google.com
TBR=robertphilips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/280233002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14691 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRevert "remove SK_SUPPORT_LEGACY_BUILDMIPMAP"
reed@google.com [Fri, 9 May 2014 20:06:57 +0000 (20:06 +0000)]
Revert "remove SK_SUPPORT_LEGACY_BUILDMIPMAP"

This reverts commit 9acd04797101990af23f5c374b7dfcbaac12fd2b.

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14685 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoremove SK_SUPPORT_LEGACY_BUILDMIPMAP
commit-bot@chromium.org [Fri, 9 May 2014 19:54:42 +0000 (19:54 +0000)]
remove SK_SUPPORT_LEGACY_BUILDMIPMAP

TBR=djsollen@google.com
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/271253002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14684 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoAdd timing to dump_record.
commit-bot@chromium.org [Fri, 9 May 2014 14:59:29 +0000 (14:59 +0000)]
Add timing to dump_record.

Prints microsecond timing for each command in the left-hand column:

optimized flat/http___mobile_news_sandbox_google_com_news_pt0_scroll_layer_7.skp
   4.0   1 Save
2075.0   2      DrawRect
 104.0   3      BoundedDrawPosTextH
 135.4   4      DrawRect
   9.4   5      DrawRect
   5.6   6      DrawRect
   8.2   7      DrawRect
   6.8   8      DrawRect
...

(I'm sure Rietveld will just mangle the crap out of that.  It's helpfully right-aligned.)

To do this, I made Draw from SkRecordDraw Skia-public as SkRecords::Draw,
and time it command-by-command.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/272723007

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14672 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoAdd missing sfnt header files to gyp.
bungeman@google.com [Fri, 9 May 2014 14:08:28 +0000 (14:08 +0000)]
Add missing sfnt header files to gyp.

This makes finding these files easier in IDEs.

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14666 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoreland "extract some common code from PictureRenderer"
commit-bot@chromium.org [Fri, 9 May 2014 03:18:41 +0000 (03:18 +0000)]
reland "extract some common code from PictureRenderer"

re-lands https://codereview.chromium.org/273703006/

NOTRY=True
R=bungeman@google.com, djsollen@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/278633002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14662 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRevert of Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_define...
commit-bot@chromium.org [Fri, 9 May 2014 00:05:52 +0000 (00:05 +0000)]
Revert of Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines. (https://codereview.chromium.org/265973002/)

Reason for revert:
This is breaking compilation of cc_unittests in Chrome

Original issue's description:
> Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
>
> Chrome/Blink doesn't use any of the legacy methods behind this flag any more.
>
> BUG=skia:2187
>
> Committed: http://code.google.com/p/skia/source/detail?r=14651

R=reed@google.com, dominikg@chromium.org
TBR=dominikg@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2187

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/275713002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14660 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRemove non-existent header file from Android opts.
bungeman@google.com [Thu, 8 May 2014 19:41:48 +0000 (19:41 +0000)]
Remove non-existent header file from Android opts.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/274793004

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14657 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRemove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
commit-bot@chromium.org [Thu, 8 May 2014 18:13:15 +0000 (18:13 +0000)]
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.

Chrome/Blink doesn't use any of the legacy methods behind this flag any more.

BUG=skia:2187
R=reed@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/265973002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14651 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRevert of extract some common code from PictureRenderer (https://codereview.chromium...
commit-bot@chromium.org [Thu, 8 May 2014 16:23:56 +0000 (16:23 +0000)]
Revert of extract some common code from PictureRenderer (https://codereview.chromium.org/273703006/)

Reason for revert:
breaking the android debug builds.  It seems to be the result of android using shared libs and not lumping everything into one big static lib or executable. So we have more than one copy of SkString which is the root of the issue.

Original issue's description:
> extract some common code from PictureRenderer
>
> Committed: http://code.google.com/p/skia/source/detail?r=14638

R=borenet@google.com, epoger@google.com
TBR=borenet@google.com, epoger@google.com
NOTREECHECKS=true
NOTRY=true

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/274463004

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14649 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoFix Moz2D build
commit-bot@chromium.org [Thu, 8 May 2014 15:29:57 +0000 (15:29 +0000)]
Fix Moz2D build

BUG=skia:2221
R=george@mozilla.com, reed@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/277593003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14647 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoextract some common code from PictureRenderer
commit-bot@chromium.org [Thu, 8 May 2014 14:48:44 +0000 (14:48 +0000)]
extract some common code from PictureRenderer

R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/273703006

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14638 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoadd localmatrix-shader
commit-bot@chromium.org [Wed, 7 May 2014 22:26:37 +0000 (22:26 +0000)]
add localmatrix-shader

BUG=skia:
R=scroggo@google.com, dominikg@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/272593002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14633 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoremove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE
reed@google.com [Wed, 7 May 2014 20:54:58 +0000 (20:54 +0000)]
remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14629 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoStatically initialize those zero-size singletons.
commit-bot@chromium.org [Wed, 7 May 2014 19:56:27 +0000 (19:56 +0000)]
Statically initialize those zero-size singletons.

This way GCC/Clang don't generate the magic static code to call the
pointless T::T() once in a threadsafe way.  = {} is plenty initialized.

BUG=skia:2378

Committed: http://code.google.com/p/skia/source/detail?r=14623

R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/270353003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14626 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoNew GM for testing circle blur optimization
commit-bot@chromium.org [Wed, 7 May 2014 17:50:03 +0000 (17:50 +0000)]
New GM for testing circle blur optimization

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/276453002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14621 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoWhen solving the cubic line intersection directly fails, use binary search as a fallback.
commit-bot@chromium.org [Wed, 7 May 2014 15:31:40 +0000 (15:31 +0000)]
When solving the cubic line intersection directly fails, use binary search as a fallback.

The cubic line intersection math empirically works 99.99% of the time (fails 3100 out of 1B random tests) but when it fails, an intersection may be missed altogether.

The binary search is may not find a solution if the cubic line failed to find any solutions at all, but so far that case hasn't arisen.

BUG=skia:2504
TBR=reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/266063003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14614 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoDisallow Android from calling getTotalClip.
commit-bot@chromium.org [Wed, 7 May 2014 15:08:48 +0000 (15:08 +0000)]
Disallow Android from calling getTotalClip.

Remove the define that lets the function live on.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/268333002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14612 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoremove dead mipmap code from SkBitmap
commit-bot@chromium.org [Wed, 7 May 2014 15:05:34 +0000 (15:05 +0000)]
remove dead mipmap code from SkBitmap

BUG=skia:
R=fmalita@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/271693002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14611 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRevert "remove unneeded SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE"
commit-bot@chromium.org [Wed, 7 May 2014 03:57:56 +0000 (03:57 +0000)]
Revert "remove unneeded SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE"

This reverts commit 95b03ce59986ecee5e4188da630a563efca3afe8.

NOTRY=True
TBR=fmalita@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/274513002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14606 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoremove unneeded SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE
reed@google.com [Tue, 6 May 2014 21:00:01 +0000 (21:00 +0000)]
remove unneeded SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14601 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoTemporarily disable NEON on Android framework builds.
djsollen@google.com [Tue, 6 May 2014 19:47:07 +0000 (19:47 +0000)]
Temporarily disable NEON on Android framework builds.

The GCC 4.8 compiler has an AARCH64 bug that generated non-PIC output
that fails to link.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/266883011

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14597 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoAdd dump_record to make inspecting before/after SkRecordOptimize easy.
commit-bot@chromium.org [Tue, 6 May 2014 19:45:18 +0000 (19:45 +0000)]
Add dump_record to make inspecting before/after SkRecordOptimize easy.

E.g.
dump_record -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp

 0 Save
 1  DrawRect
 2  DrawRect
 3  DrawRect
 4  DrawRect
 5  Save
 6  ClipRect
 7  Restore
 8  Save
 9  ClipRect
10  Restore
11 Restore

dump_record -O -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
 0 Save
 1  DrawRect
 2  DrawRect
 3  DrawRect
 4  DrawRect
 5  NoOp
 6  NoOp
 7  NoOp
 8  NoOp
 9  NoOp
10  NoOp
11 Restore

(Reitveld sadly eats my kickass indentation.)

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/265983007

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14596 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoAdd pattern matchers for SkRecord
commit-bot@chromium.org [Mon, 5 May 2014 21:59:52 +0000 (21:59 +0000)]
Add pattern matchers for SkRecord

This is a mid-level library for finding patterns of commands in an SkRecord.  At the API level, it's a bit regex inspired.  Some examples:
 - Pattern1<Is<DrawRect>> matches a single DrawRect

 - Pattern1<Star<Is<DrawRect>>> matches 0 or more DrawRects

 - Pattern2<Is<ClipRect>, Is<DrawRect>> matches a single clip rect followed by a single draw rect

  - Pattern3<Is<Save>, Star<IsDraw>, Is<Restore>> matches a single Save, followed by any number of Draws, followed by Restore

 - Pattern1<Or<Is<DrawRect>, Is<ClipRect>>> matches a DrawRect or a ClipRect

 - Pattern1<Not<Is<ClipRect>>> matches a command that's notClipRect.

Once you have a pattern, you can call .search() on it to step through ranges of matching commands.  This means patterns can replace most of the custom iteration logic for optimization passes: the generic pattern searching steps through all the optimization candidates, which optimization-specific code further inspects and mutates.

SkRecordTraits is now unused.  Bye bye!

Generated code and performance of SkRecordOpts is very similar to what it was before.  (I had to use SK_ALWAYS_INLINE in a few places to make this so.)

BUG=skia:2378
R=fmalita@chromium.org, bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/263063002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14582 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoSplit GrResource into GrCacheable/GrGpuObject
commit-bot@chromium.org [Fri, 2 May 2014 21:38:22 +0000 (21:38 +0000)]
Split GrResource into GrCacheable/GrGpuObject

Before this change, an object needed to inherit from GrResource (and
thus be a GPU object) in order to live in the GrResourceCache. That
was a problem for caching items that weren't GPU objects themselves,
but owned GPU objects.

This change splits GrResource into two classes:

  1. GrCacheable: The base class for objects that can live in the
     GrResourceCache.

  2. GrGpuObject, which inherits from GrCacheable: The base class for
     objects that get tracked by GrGpu.

This change is purely a refactor; there is no change in functionality.

Change-Id: I3e8daeb1f123041f414aa306c1366e959ae9e39e

BUG=skia:
R=bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/251013002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14553 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRemove dead code.
commit-bot@chromium.org [Thu, 1 May 2014 21:03:53 +0000 (21:03 +0000)]
Remove dead code.

No files reference this file.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/255243002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14520 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRevert of Roll ANGLE. (https://codereview.chromium.org/237173002/)
commit-bot@chromium.org [Thu, 1 May 2014 20:20:50 +0000 (20:20 +0000)]
Revert of Roll ANGLE. (https://codereview.chromium.org/237173002/)

Reason for revert:
breaking the buildbots (see http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Release-ANGLE/builds/3198).

NOTRY=true

Original issue's description:
> Roll ANGLE.
>
> BUG=skia:2272
>
> Committed: http://code.google.com/p/skia/source/detail?r=14243
>
> Committed: http://code.google.com/p/skia/source/detail?r=14509

R=bsalomon@chromium.org, bsalomon@google.com, geofflang@chromium.org, djsollen@google.com, mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/264733006

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14517 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agogyp rules for ubsan
commit-bot@chromium.org [Thu, 1 May 2014 19:29:46 +0000 (19:29 +0000)]
gyp rules for ubsan

BUG=skia:2481
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/258393004

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14511 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRoll ANGLE.
commit-bot@chromium.org [Thu, 1 May 2014 19:22:22 +0000 (19:22 +0000)]
Roll ANGLE.

BUG=skia:2272

Committed: http://code.google.com/p/skia/source/detail?r=14243

R=bsalomon@chromium.org, bsalomon@google.com

Author: geofflang@chromium.org

Review URL: https://codereview.chromium.org/237173002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14509 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoremove unneeded SK_SUPPORT_LEGACY_PROCXFERMODE
commit-bot@chromium.org [Wed, 30 Apr 2014 21:34:14 +0000 (21:34 +0000)]
remove unneeded SK_SUPPORT_LEGACY_PROCXFERMODE

BUG=skia:
R=fmalita@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/267573003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14489 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agotry /LARGEADDRESSAWARE to give Windows 32-bit builds access to more RAM.
commit-bot@chromium.org [Wed, 30 Apr 2014 20:47:22 +0000 (20:47 +0000)]
try /LARGEADDRESSAWARE to give Windows 32-bit builds access to more RAM.

BUG=skia:2478
R=borenet@google.com, robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/258403006

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14485 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoEliminate SkPicture-related flags Chromium no longer requires
commit-bot@chromium.org [Wed, 30 Apr 2014 15:55:14 +0000 (15:55 +0000)]
Eliminate SkPicture-related flags Chromium no longer requires

This was originally reverted in r14349 (Restore SkPicture-related guard flags for Chrome - https://codereview.chromium.org/255543004/) due to Android WebView compile failures. These failures should be fixed in Chromium r267210 (Fixing Chromium Android build's reliance on old SkPicture recording API - https://codereview.chromium.org/251843005/)

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/254333003

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14471 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoCleanup of SSE optimization files.
commit-bot@chromium.org [Wed, 30 Apr 2014 14:58:46 +0000 (14:58 +0000)]
Cleanup of SSE optimization files.

General cleanup of optimization files for x86/SSEx.
Renamed the opts_check_SSE2.cpp file to _x86, since it's not specific
to SSE2. Commented out the ColorRect32 optimization, since it's
disabled anyway, to make it more visible.
Also fixed a lot of indentation, inclusion guards, spelling,
copyright headers, braces, whitespace, and sorting of includes.

Author: henrik.smiding@intel.com

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/264603002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14464 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoTurn on quilt mode in DM.
commit-bot@chromium.org [Wed, 30 Apr 2014 13:20:45 +0000 (13:20 +0000)]
Turn on quilt mode in DM.
  - Rename TileGrid -> Quilt to avoid the name overload.
  - Tag all failing GMs with kSkipTiled_Flag.

You may be wondering, do any GMs pass?  Yes, some do!  And that trends towards all of them as we increase --quiltTile.

Two GMs only fail in --quilt mode in 565.  Otherwise all GMs which fail are skipped, and those which don't fail aren't. (The 8888 variants of those two GMs are skipped even though they pass.)

BUG=skia:2477
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/256373002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14457 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoBackfill unit tests for SkRecord
commit-bot@chromium.org [Wed, 30 Apr 2014 13:18:12 +0000 (13:18 +0000)]
Backfill unit tests for SkRecord

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/251133008

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14455 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoMove GrGLInterface function ptr setup into a common function for all OpenGL GrGLInter...
commit-bot@chromium.org [Tue, 29 Apr 2014 20:06:22 +0000 (20:06 +0000)]
Move GrGLInterface function ptr setup into a common function for all OpenGL GrGLInterface factories (but not GLES yet).

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/254713006

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14444 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRemove dependency of views on angle
commit-bot@chromium.org [Tue, 29 Apr 2014 00:38:39 +0000 (00:38 +0000)]
Remove dependency of views on angle

Just like with http://code.google.com/p/skia/source/detail?r=13618,
listing angle.gyp as a dependency when in the Android tree (i.e.
w/o third_party/externals) causes gyp_to_android.py to fail.

(See http://108.170.220.27:10115/builders/Housekeeper-PerCommit-AndroidRoll/builds/229/steps/Merge/logs/stdio
for example failure.)

Fortunately, views (and views_animated) has no need to depend directly
on angle.

R=bungeman@google.com, bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com

BUG=skia:2447

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/253773004

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14426 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoRefactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag.
commit-bot@chromium.org [Mon, 28 Apr 2014 20:17:48 +0000 (20:17 +0000)]
Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag.

The current implementation relies on soon-to-be-deprecated
kClip_SaveFlag behavior. Updated to use default save flags
(kMatrixClip_SaveFlag) and stop assuming that the matrix survives
restore() calls.

R=junov@chromium.org, reed@google.com, robertphillips@chromium.org, robertphillips@google.com

Committed: http://code.google.com/p/skia/source/detail?r=14319

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/246893005

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14421 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agomove common blur types into central header
commit-bot@chromium.org [Mon, 28 Apr 2014 16:25:35 +0000 (16:25 +0000)]
move common blur types into central header

BUG=skia:
R=scroggo@google.com, djsollen@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/253833002

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14411 2bbb7eff-a529-9590-31e7-b0007b416f81

2 months agoStart using type traits in src/record instead of macros.
commit-bot@chromium.org [Mon, 28 Apr 2014 16:19:45 +0000 (16:19 +0000)]
Start using type traits in src/record instead of macros.

Simplified skip logic by always running clip commands.  No performance difference on bot or silk SKPs.

BUG=skia:2378
R=bungeman@google.com, fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/258693006

git-svn-id: http://skia.googlecode.com/svn/trunk/gyp@14410 2bbb7eff-a529-9590-31e7-b0007b416f81