external/skia/include.git
4 months agoremove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE master
commit-bot@chromium.org [Sat, 31 May 2014 21:47:03 +0000 (21:47 +0000)]
remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE

R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/308953002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15016 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org...
commit-bot@chromium.org [Sat, 31 May 2014 00:15:22 +0000 (00:15 +0000)]
Revert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org/304383005/)

Reason for revert:
linux x86-64 release segfault in src/ports/SkFontHost_fontconfig.cpp:107

http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/builds/905/steps/RunTests/logs/stdio

Original issue's description:
> Port most uses of SkOnce to SkLazyPtr.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=15006
>
> Committed: http://code.google.com/p/skia/source/detail?r=15014

R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/306063004

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15015 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoPort most uses of SkOnce to SkLazyPtr.
commit-bot@chromium.org [Fri, 30 May 2014 23:59:12 +0000 (23:59 +0000)]
Port most uses of SkOnce to SkLazyPtr.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=15006

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/304383005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15014 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoAdd a way for the gpu veto to report back the reason why it said no
commit-bot@chromium.org [Fri, 30 May 2014 21:52:52 +0000 (21:52 +0000)]
Add a way for the gpu veto to report back the reason why it said no

BUG=2334
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/301423002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15012 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agofix casting issue with or operator
commit-bot@chromium.org [Fri, 30 May 2014 21:07:05 +0000 (21:07 +0000)]
fix casting issue with or operator

R=reed@google.com, epoger@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/305253002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15011 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org...
commit-bot@chromium.org [Fri, 30 May 2014 21:00:52 +0000 (21:00 +0000)]
Revert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org/304383005/)

Reason for revert:
Leaking refs on SkTypeface on Macs.

Original issue's description:
> Port most uses of SkOnce to SkLazyPtr.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=15006

R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/304283007

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15009 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoPort most uses of SkOnce to SkLazyPtr.
commit-bot@chromium.org [Fri, 30 May 2014 20:42:00 +0000 (20:42 +0000)]
Port most uses of SkOnce to SkLazyPtr.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/304383005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15006 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoAdd an OR operator overload for SaveFlags to avoid extra static casts.
commit-bot@chromium.org [Fri, 30 May 2014 20:41:20 +0000 (20:41 +0000)]
Add an OR operator overload for SaveFlags to avoid extra static casts.

R=reed@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/303373003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15005 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert of Initial work to get ETC1 data up to the GPU (https://codereview.chromium...
commit-bot@chromium.org [Fri, 30 May 2014 20:36:21 +0000 (20:36 +0000)]
Revert of Initial work to get ETC1 data up to the GPU (https://codereview.chromium.org/302783002/)

Reason for revert:
ETC1 linking problems with chrome.

Original issue's description:
> Initial work to get ETC1 data up to the GPU
>
> Committed: http://code.google.com/p/skia/source/detail?r=15001

R=bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/303273008

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15004 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoImplement SkPictureImageFilter bounds computation.
senorblanco@chromium.org [Fri, 30 May 2014 20:36:15 +0000 (20:36 +0000)]
Implement SkPictureImageFilter bounds computation.

SkPictureImageFilter::onFilterBounds() was unimplemented, causing
incorrect results for SVG filters and impl-side painting (see Chrome
bug https://code.google.com/p/chromium/issues/detail?id=375162).

BUG=skia:
R=reed@google.com

Review URL: https://codereview.chromium.org/306733003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15003 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoInitial work to get ETC1 data up to the GPU
commit-bot@chromium.org [Fri, 30 May 2014 18:41:39 +0000 (18:41 +0000)]
Initial work to get ETC1 data up to the GPU

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/302783002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@15001 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoTest font created from paint
commit-bot@chromium.org [Fri, 30 May 2014 16:46:10 +0000 (16:46 +0000)]
Test font created from paint

This is meant to allow clients to migrate over to a SkFont api on canvas (e.g. drawText(text, font, paint)) while still permitting the current setters in paint (e.g. setTextSize, setFlags).

R=bungeman@google.com, eae@chromium.org, fmalita@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/245953003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14997 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoMove the LATC and ETC1 enum values to GrPixelConfig. I also tried to put in checks...
commit-bot@chromium.org [Fri, 30 May 2014 13:55:58 +0000 (13:55 +0000)]
Move the LATC and ETC1 enum values to GrPixelConfig. I also tried to put in checks in a few places to make sure that we weren't using these pixel configurations in places that we shouldn't be.

LATC is a DXT-esque alpha compression format that goes by a few other names (RGTC, 3DC). It might be useful to investigate using it to compress the alpha masks that we get from software rasterization. This patch set adds enums for that and recognition whether or not the device can support it.

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/304743004

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14991 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)"
commit-bot@chromium.org [Fri, 30 May 2014 13:26:10 +0000 (13:26 +0000)]
Revert "Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)"

This reverts commit eecaea4148805834f223681f70b6488ceba12d09.

R=robertphillips@google.com, scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/301283003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14989 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoFix the rendering error of SkDraw::drawVertices in gpu path for solid color.
commit-bot@chromium.org [Fri, 30 May 2014 10:08:22 +0000 (10:08 +0000)]
Fix the rendering error of SkDraw::drawVertices in gpu path for solid color.

If both textures and vertex-colors are NULL, drawVertices should stroke hairlines with the paint's color.
This behavior is a useful debugging mode to visualize the mesh.

BUG=skia:2266
R=bsalomon@google.com, reed@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/189963004

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14985 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)
commit-bot@chromium.org [Thu, 29 May 2014 21:10:32 +0000 (21:10 +0000)]
Revert of setConfig -> setInfo (https://codereview.chromium.org/308683005/)

Reason for revert:
broke all Windows bots

Original issue's description:
> setConfig -> setInfo
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14978

R=robertphillips@google.com, reed@google.com
TBR=reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: epoger@google.com

Review URL: https://codereview.chromium.org/302053002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14979 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agosetConfig -> setInfo
commit-bot@chromium.org [Thu, 29 May 2014 20:47:53 +0000 (20:47 +0000)]
setConfig -> setInfo

BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/308683005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14978 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoSkLazyPtr, mk. 2
commit-bot@chromium.org [Thu, 29 May 2014 20:13:22 +0000 (20:13 +0000)]
SkLazyPtr, mk. 2

SK_DECLARE_STATIC_LAZY_PTR and
SK_DECLARE_STATIC_LAZY_PTR_ARRAY let you declare a single or
array of static pointers that are lazily initialized.

You can think of this as a restricted, lighter-weight
version of SkOnce.  There's no guarantee that Create will be
called exactly once, but we do guarantee all threads will
agree on the resulting pointer.

We'll clean up any other extra pointers we Create()ed by
calling Destroy(), which defaults to SkDELETE.  In debug
mode, we also clean up the winning pointer at process exit,
so we can make sure we didn't leak it or free it early.

I've ported SkData (singleton) and SkXfermode (array) as
examples.  Once this lands I'll port most other users of
SkOnce.

BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/306943003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14976 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoConstify the arguments to createTexture
commit-bot@chromium.org [Thu, 29 May 2014 19:26:48 +0000 (19:26 +0000)]
Constify the arguments to createTexture

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/301993002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14975 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoAdd SkBarriers to ports.
commit-bot@chromium.org [Thu, 29 May 2014 18:24:54 +0000 (18:24 +0000)]
Add SkBarriers to ports.

This completes a TODO we've had to move our memory-barrier code out of
SkOnce.  I also want to start using sk_acquire_load elsewhere.

BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/304593003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14970 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agolegacy refEncodedData() returns data, not bool
reed@google.com [Thu, 29 May 2014 16:05:47 +0000 (16:05 +0000)]
legacy refEncodedData() returns data, not bool

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14961 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoreplace config() with colorType()
commit-bot@chromium.org [Thu, 29 May 2014 15:57:47 +0000 (15:57 +0000)]
replace config() with colorType()

BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/303543009

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14959 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert "Revert of add colortable support to imagegenerator (https://codereview.chromi...
commit-bot@chromium.org [Thu, 29 May 2014 15:57:20 +0000 (15:57 +0000)]
Revert "Revert of add colortable support to imagegenerator (https://codereview.chromium.org/304443003/)"

Fix is to add colortable param to installPixels()

This reverts commit 924205aaf2e0c3c65dda13e0eaccde3e7b2a5c40.

BUG=skia:
R=scroggo@google.com, reed@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/300263005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14958 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoMake SkPictureRecorder::partialReplay const
commit-bot@chromium.org [Thu, 29 May 2014 15:57:11 +0000 (15:57 +0000)]
Make SkPictureRecorder::partialReplay const

This will make it easier to integrate this into Android's use case.

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/307693003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14957 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert "Remove SkThread.h from public API."
commit-bot@chromium.org [Wed, 28 May 2014 20:02:17 +0000 (20:02 +0000)]
Revert "Remove SkThread.h from public API."

Too much depends on SkThread being in include/core in Chrome build.

This reverts commit b1aec17df6078115c797839c9646081ccba2bd09.

NOTREECHECKS=true
NOTRY=true
R=reed@google.com, mtklein@google.com
TBR=reed

BUG=skia:

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/303813003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14934 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRemove SkThread.h from public API.
commit-bot@chromium.org [Wed, 28 May 2014 19:24:54 +0000 (19:24 +0000)]
Remove SkThread.h from public API.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/303463009

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14926 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoAdd SkPurgeGlobalDiscardableMemoryPool, needed to replace SkImageRef
commit-bot@chromium.org [Wed, 28 May 2014 18:51:03 +0000 (18:51 +0000)]
Add  SkPurgeGlobalDiscardableMemoryPool, needed to replace SkImageRef

BUG=skia:2389
R=reed@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/298423002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14925 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert of add colortable support to imagegenerator (https://codereview.chromium.org...
commit-bot@chromium.org [Wed, 28 May 2014 16:16:08 +0000 (16:16 +0000)]
Revert of add colortable support to imagegenerator (https://codereview.chromium.org/304443003/)

Reason for revert:
failing tests

Original issue's description:
> add colortable support to imagegenerator
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14916

R=halcanary@google.com, scroggo@google.com
TBR=halcanary@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/300873007

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14917 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoadd colortable support to imagegenerator
commit-bot@chromium.org [Wed, 28 May 2014 16:01:55 +0000 (16:01 +0000)]
add colortable support to imagegenerator

BUG=skia:
R=halcanary@google.com, scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/304443003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14916 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoadd replay entry point to SkPictureRecorder for Android
commit-bot@chromium.org [Tue, 27 May 2014 23:41:45 +0000 (23:41 +0000)]
add replay entry point to SkPictureRecorder for Android

This CL adds an Android-only entry point to address the Java Picture(Picture) and serialize use cases. Note that (in its current form) it doesn't preserve the old API's handling of unbalanced saves/saveLayers (this CL always balances them).

R=reed@google.com, scroggo@google.com, djsollen@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/252873005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14911 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoremove SkBitmap::asImageInfo
commit-bot@chromium.org [Tue, 27 May 2014 21:30:37 +0000 (21:30 +0000)]
remove SkBitmap::asImageInfo

BUG=skia:
R=scroggo@google.com, halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/305483005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14909 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert of Revert of Add compressed texture capabilities for GPU devices
commit-bot@chromium.org [Tue, 27 May 2014 19:26:59 +0000 (19:26 +0000)]
Revert of Revert of Add compressed texture capabilities for GPU devices
(https://codereview.chromium.org/307543002/)

Reason for revert:
Re-landing the original CL, because the revert didn't fix things.  See http://skbug.com/2608 ('RunDecodingTests failing on multiple platforms')

Original issue's description:
> Revert of Add compressed texture capabilities for GPU devices (https://codereview.chromium.org/292323003/)
>
> Reason for revert:
> RunDecodingTests failing on multiple platforms.  Please use trybots to validate and re-land.
>
> Original issue's description:
> > Add compressed texture capabilities for GPU devices
> >
> > BUG=skia:
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14880
> >
> > Committed: http://code.google.com/p/skia/source/detail?r=14901
>
> TBR=bsalomon@google.com,robertphillips@google.com,krajcevski@google.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14902

R=bsalomon@google.com, robertphillips@google.com, krajcevski@google.com
TBR=bsalomon@google.com, krajcevski@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: epoger@google.com

Review URL: https://codereview.chromium.org/302553008

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14903 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert of Add compressed texture capabilities for GPU devices (https://codereview...
commit-bot@chromium.org [Tue, 27 May 2014 19:07:10 +0000 (19:07 +0000)]
Revert of Add compressed texture capabilities for GPU devices (https://codereview.chromium.org/292323003/)

Reason for revert:
RunDecodingTests failing on multiple platforms.  Please use trybots to validate and re-land.

Original issue's description:
> Add compressed texture capabilities for GPU devices
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14880
>
> Committed: http://code.google.com/p/skia/source/detail?r=14901

R=bsalomon@google.com, robertphillips@google.com, krajcevski@google.com
TBR=bsalomon@google.com, krajcevski@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: epoger@google.com

Review URL: https://codereview.chromium.org/307543002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14902 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoAdd compressed texture capabilities for GPU devices
commit-bot@chromium.org [Tue, 27 May 2014 18:52:24 +0000 (18:52 +0000)]
Add compressed texture capabilities for GPU devices

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14880

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/292323003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14901 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoUse SkAtomics_sync on Android
commit-bot@chromium.org [Tue, 27 May 2014 15:55:35 +0000 (15:55 +0000)]
Use SkAtomics_sync on Android

Every doc I've found about using Android's atomics says, "stop".

"* A handful of basic atomic operations.  The appropriate pthread
 * functions should be used instead of these whenever possible."

"... we recommend stopping from using these functions entirely. Very fortunately, GCC provides handy intrinsics functions that work with very reasonable performance and always provide a full barrier."

As far as I can tell, there's no code generation change here: both the __sync atomics and the android_ atomics use full memory barriers.  (And now with this all unified, it'll be easier to get the real wins by switching everything to __atomic atomics, which are like __sync atomics but allow control over memory barriers.)

BUG=skia:
R=bungeman@google.com, djsollen@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/305593002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14896 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoImplement sk_atomic_conditional_inc with sk_atomic_cas.
commit-bot@chromium.org [Tue, 27 May 2014 15:00:32 +0000 (15:00 +0000)]
Implement sk_atomic_conditional_inc with sk_atomic_cas.

Now that we have sk_atomic_cas, we can replace all the platform-specific CAS loops with one.

BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/300553003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14892 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoMove SkDecodingImageGenerator.h to include/
commit-bot@chromium.org [Tue, 27 May 2014 14:59:47 +0000 (14:59 +0000)]
Move SkDecodingImageGenerator.h to include/

This will allow Android to access it and remove SkImageRef.

Depends on https://codereview.chromium.org/293283002/

BUG=skia:2389
R=reed@google.com, djsollen@google.com, halcanary@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/228613003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14891 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agohide discardable factory from public imagegenerator api
commit-bot@chromium.org [Tue, 27 May 2014 14:14:22 +0000 (14:14 +0000)]
hide discardable factory from public imagegenerator api

BUG=skia:
R=halcanary@google.com, scroggo@google.com, djsollen@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/295243006

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14889 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoremove SK_SUPPORT_LEGACY_BITMAPFLATTEN code
commit-bot@chromium.org [Tue, 27 May 2014 14:03:51 +0000 (14:03 +0000)]
remove SK_SUPPORT_LEGACY_BITMAPFLATTEN code

BUG=skia:
R=scroggo@google.com, reed@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/303563002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14888 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoremove SK_SUPPORT_LEGACY_BUILDMIPMAP
commit-bot@chromium.org [Tue, 27 May 2014 00:23:36 +0000 (00:23 +0000)]
remove SK_SUPPORT_LEGACY_BUILDMIPMAP

TBR=scroggo

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/293393007

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14885 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 24 May 2014 03:05:26 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14884 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert of Add compressed texture capabilities for GPU devices (https://codereview...
commit-bot@chromium.org [Fri, 23 May 2014 20:40:26 +0000 (20:40 +0000)]
Revert of Add compressed texture capabilities for GPU devices (https://codereview.chromium.org/292323003/)

Reason for revert:
Signeness comparison breaks build. After working some more, I think the API design will be cleaner without the Uncompressed enum, so I'm removing it and retesting everything.

Original issue's description:
> Add compressed texture capabilities for GPU devices
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14880

R=bsalomon@google.com, robertphillips@google.com, halcanary@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/296313003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14883 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoAdd compressed texture capabilities for GPU devices
commit-bot@chromium.org [Fri, 23 May 2014 20:00:54 +0000 (20:00 +0000)]
Add compressed texture capabilities for GPU devices

BUG=skia:
R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/292323003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14880 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoRevert of Modify sample buffer size for larger displays. (https://codereview.chromium...
commit-bot@chromium.org [Fri, 23 May 2014 19:13:56 +0000 (19:13 +0000)]
Revert of Modify sample buffer size for larger displays. (https://codereview.chromium.org/240433002/)

Reason for revert:
This also changes verylargebitmap, and the difference appears to be meaningful. Henrik, I have emailed you the images that differ.

Original issue's description:
> Modify sample buffer size for larger displays.
>
> Increases the intermediate buffer size for sample pixel indexes,
> used in the sample proc function calls. If the operation is bigger
> than the buffer it's split into multiple calls, creating overhead.
> This would especially impact the performance of SIMD optimizations.
> Also, aligns the start address of the buffer to 16 bytes, to enable
> more efficient SIMD optimizations.
>
> Author: henrik.smiding@intel.com
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: http://code.google.com/p/skia/source/detail?r=14825
>
> Committed: http://code.google.com/p/skia/source/detail?r=14872

R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, bsalomon@chromium.org, bsalomon@google.com, henrik.smiding@intel.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/294023016

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14878 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoModify sample buffer size for larger displays.
commit-bot@chromium.org [Fri, 23 May 2014 16:05:43 +0000 (16:05 +0000)]
Modify sample buffer size for larger displays.

Increases the intermediate buffer size for sample pixel indexes,
used in the sample proc function calls. If the operation is bigger
than the buffer it's split into multiple calls, creating overhead.
This would especially impact the performance of SIMD optimizations.
Also, aligns the start address of the buffer to 16 bytes, to enable
more efficient SIMD optimizations.

Author: henrik.smiding@intel.com

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
Committed: http://code.google.com/p/skia/source/detail?r=14825

R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, scroggo@google.com, bsalomon@chromium.org, bsalomon@google.com

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/240433002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14872 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agostop calling SkBitmap::flatten
commit-bot@chromium.org [Fri, 23 May 2014 13:21:55 +0000 (13:21 +0000)]
stop calling SkBitmap::flatten

BUG=skia:
R=scroggo@google.com, halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/295793002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14867 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 23 May 2014 03:03:34 +0000 (03:03 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14862 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agotemporarily add back in the factores that took a unitmapper
commit-bot@chromium.org [Thu, 22 May 2014 22:35:24 +0000 (22:35 +0000)]
temporarily add back in the factores that took a unitmapper

BUG=skia:
R=fmalita@google.com, fmalita@chromium.org, reed@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/292513006

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14859 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agore-expose hasLocalMatrix for now (can't hurt) -- unblocks blink
commit-bot@chromium.org [Thu, 22 May 2014 18:43:05 +0000 (18:43 +0000)]
re-expose hasLocalMatrix for now (can't hurt) -- unblocks blink

BUG=skia:
R=fmalita@google.com, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/299043002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14853 2bbb7eff-a529-9590-31e7-b0007b416f81

4 months agoSimple PKM image decoder.
robertphillips@google.com [Thu, 22 May 2014 18:40:29 +0000 (18:40 +0000)]
Simple PKM image decoder.

https://codereview.chromium.org/292663011/

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14852 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRemove unused (by clients) SkUnitMapper
commit-bot@chromium.org [Thu, 22 May 2014 12:27:41 +0000 (12:27 +0000)]
Remove unused (by clients) SkUnitMapper

This reverts commit 874423a81b5bc2541c7397e6ab00d5e7c9fdaf98.

TBR=scroggo

Author: reed@google.com

Review URL: https://codereview.chromium.org/288313009

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14842 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRevert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org...
commit-bot@chromium.org [Thu, 22 May 2014 02:55:59 +0000 (02:55 +0000)]
Revert of Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/) (https://codereview.chromium.org/288343009/)

Reason for revert:
required blink change failed to land

Original issue's description:
> Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
>
> This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14830

R=scroggo@google.com, reed@google.com
TBR=reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/296823008

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14838 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRemove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)
commit-bot@chromium.org [Wed, 21 May 2014 19:56:46 +0000 (19:56 +0000)]
Remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)

This reverts commit dd50c83b5b34dab3a077741861b50ed1f2bc6b8f.

BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/288343009

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14830 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRevert "Modify sample buffer size for larger displays."
reed@google.com [Wed, 21 May 2014 16:38:43 +0000 (16:38 +0000)]
Revert "Modify sample buffer size for larger displays."

This reverts commit dd72f3bd0d500b9b3f900bcb8e904161ee51eae5.

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14827 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRevert of Revert ""Revert of eliminate config param -- it was always self's config...
commit-bot@chromium.org [Wed, 21 May 2014 15:58:00 +0000 (15:58 +0000)]
Revert of Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromi… (https://codereview.chromium.org/291163005/)

Reason for revert:
broke 6 webgl/canvas tests in blink (don't know why yet)

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_7/27348/layout-test-results/results.html

Original issue's description:
> Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)"""
>
> This reverts commit 3dbceb4f8283b2fb1728d0daf010d036099a2eae.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14806

R=bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/295093003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14826 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoModify sample buffer size for larger displays.
commit-bot@chromium.org [Wed, 21 May 2014 15:16:15 +0000 (15:16 +0000)]
Modify sample buffer size for larger displays.

Increases the intermediate buffer size for sample pixel indexes,
used in the sample proc function calls. If the operation is bigger
than the buffer it's split into multiple calls, creating overhead.
This would especially impact the performance of SIMD optimizations.
Also, aligns the start address of the buffer to 16 bytes, to enable
more efficient SIMD optimizations.

Author: henrik.smiding@intel.com

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, scroggo@google.com, bsalomon@chromium.org, bsalomon@google.com

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/240433002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14825 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoSSE2 implementation of memcpy32
commit-bot@chromium.org [Wed, 21 May 2014 12:43:07 +0000 (12:43 +0000)]
SSE2 implementation of memcpy32

With SSE2 version memcpy32, S32_Opaque_BlitRow32() in SkBlitRow_D32.cpp
has about 30% performance improvement. Here are the data on desktop
i7-3770.
before:
       bitmap_scale_filter_90_90   8888:  cmsecs =      2.01
      bitmaprect_FF_filter_trans   8888:  cmsecs =      3.61
    bitmaprect_FF_nofilter_trans   8888:  cmsecs =      3.57
   bitmaprect_FF_filter_identity   8888:  cmsecs =      3.53
 bitmaprect_FF_nofilter_identity   8888:  cmsecs =      3.53
              bitmap_4444_update   8888:  cmsecs =      4.84
     bitmap_4444_update_volatile   8888:  cmsecs =      4.81
                     bitmap_4444   8888:  cmsecs =      4.81
after:
       bitmap_scale_filter_90_90   8888:  cmsecs =      1.83
      bitmaprect_FF_filter_trans   8888:  cmsecs =      2.36
    bitmaprect_FF_nofilter_trans   8888:  cmsecs =      2.36
   bitmaprect_FF_filter_identity   8888:  cmsecs =      2.60
 bitmaprect_FF_nofilter_identity   8888:  cmsecs =      2.63
              bitmap_4444_update   8888:  cmsecs =      3.30
     bitmap_4444_update_volatile   8888:  cmsecs =      3.30
                     bitmap_4444   8888:  cmsecs =      3.29

BUG=skia:
R=mtklein@google.com, reed@google.com, bsalomon@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/285313002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14822 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 21 May 2014 03:05:49 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14817 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoChanged JSON formatting more, workaround bug where SkStringPrintf causes encoding...
commit-bot@chromium.org [Tue, 20 May 2014 17:35:10 +0000 (17:35 +0000)]
Changed JSON formatting more, workaround bug where SkStringPrintf causes encoding issues

BUG=skia:
R=bensong@google.com, jcgregorio@google.com, reed@google.com, bsalomon@google.com

Author: kelvinly@google.com

Review URL: https://codereview.chromium.org/294093002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14808 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoformalize named picture versions
commit-bot@chromium.org [Tue, 20 May 2014 17:31:08 +0000 (17:31 +0000)]
formalize named picture versions

BUG=skia:
R=mtklein@google.com, robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/291913004

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14807 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRevert ""Revert of eliminate config param -- it was always self's config (https:...
commit-bot@chromium.org [Tue, 20 May 2014 17:08:12 +0000 (17:08 +0000)]
Revert ""Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)"""

This reverts commit 3dbceb4f8283b2fb1728d0daf010d036099a2eae.

BUG=skia:
R=bsalomon@google.com, robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/291163005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14806 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoAdd function to get both min and max scale factors from matrix
commit-bot@chromium.org [Tue, 20 May 2014 17:02:03 +0000 (17:02 +0000)]
Add function to get both min and max scale factors from matrix

R=reed@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/298473002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14804 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRename SkMatrix::get(Max|Min)Stretch to get(Min|Max)Scale
commit-bot@chromium.org [Tue, 20 May 2014 14:53:45 +0000 (14:53 +0000)]
Rename SkMatrix::get(Max|Min)Stretch to get(Min|Max)Scale

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/295713002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14798 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRemove legacy constructor for blur draw looper.
commit-bot@chromium.org [Tue, 20 May 2014 14:53:32 +0000 (14:53 +0000)]
Remove legacy constructor for blur draw looper.

Now that Android no longer uses the constructor, remove it, along
with the flag.

R=djsollen@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/299683002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14797 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months ago"Revert of eliminate config param -- it was always self's config (https://codereview...
reed@google.com [Tue, 20 May 2014 12:39:37 +0000 (12:39 +0000)]
"Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)""

This reverts commit 65b9f33cab9f53821720f982667412e56a340093.

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14795 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoPass in GrContext instead of SkGpuDevice for dashing and Sk2GrPaint conversion
commit-bot@chromium.org [Mon, 19 May 2014 19:35:57 +0000 (19:35 +0000)]
Pass in GrContext instead of SkGpuDevice for dashing and Sk2GrPaint conversion

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/292773002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14790 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRevert "Revert of eliminate config param -- it was always self's config (https:/...
commit-bot@chromium.org [Mon, 19 May 2014 17:29:16 +0000 (17:29 +0000)]
Revert "Revert of eliminate config param -- it was always self's config (https://codereview.chromium.org/246513002/)"

TBR=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/290883005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14785 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoTry out SkMatrix::Concat.
commit-bot@chromium.org [Mon, 19 May 2014 15:51:12 +0000 (15:51 +0000)]
Try out SkMatrix::Concat.

This should RVO to the same as doing it on the stack with setConcat.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/293693002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14782 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agogradient api sans (deprecated) unitmapper
commit-bot@chromium.org [Mon, 19 May 2014 15:46:09 +0000 (15:46 +0000)]
gradient api sans (deprecated) unitmapper

BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/293643004

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14781 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoAdd Dashing gpu effect for simple dashed lines
commit-bot@chromium.org [Mon, 19 May 2014 14:32:49 +0000 (14:32 +0000)]
Add Dashing gpu effect for simple dashed lines

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/274673004

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14775 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoThis adds a checkbox to the debugger to allow seeing the effect pathops has on the...
commit-bot@chromium.org [Mon, 19 May 2014 13:53:10 +0000 (13:53 +0000)]
This adds a checkbox to the debugger to allow seeing the effect pathops has on the clip. A new tab shows the C code that the pathops generate.

Once in place, this CL found a bug in the pathops code where it was not handling empty clip stack elements correctly. The Cl also has the change to SkCanvas to fix this bug.

R=robertphillips@google.com, reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/282283002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14774 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoAdd choke point for performing a fake endRecording
commit-bot@chromium.org [Mon, 19 May 2014 12:36:15 +0000 (12:36 +0000)]
Add choke point for performing a fake endRecording

My goal here was to add a single location where we could patch up the created PicturePlayback. Unfortunately, the complexity of the recording process (e.g., the BBH) makes this quite complex.

I will investigate altering the behavior of SkPicturePlayback to account for a potentially unbalanced set of saves/saveLayers.

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/283333007

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14773 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRevert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org...
commit-bot@chromium.org [Fri, 16 May 2014 13:49:08 +0000 (13:49 +0000)]
Revert of remove unused (by clients) SkUnitMapper (https://codereview.chromium.org/283273002/)

Reason for revert:
does not address all legacy callsites in chrome.

e.g.

[13:45:32.091872] ../../ui/native_theme/native_theme_base.cc:608:76: error: no matching function for call to ‘SkGradientShader::CreateLinear(SkPoint [3], SkColor [3], NULL, int, SkShader::TileMode, NULL)’
[13:45:32.091919]            gradient_bounds, colors, NULL, 3, SkShader::kClamp_TileMode, NULL));

Original issue's description:
> remove unused (by clients) SkUnitMapper
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14761

R=robertphillips@google.com, scroggo@google.com, george@mozilla.com
TBR=george@mozilla.com, robertphillips@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/287063009

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14763 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoremove unused (by clients) SkUnitMapper
commit-bot@chromium.org [Fri, 16 May 2014 13:35:01 +0000 (13:35 +0000)]
remove unused (by clients) SkUnitMapper

BUG=skia:
R=robertphillips@google.com, scroggo@google.com, george@mozilla.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/283273002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14761 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoGenerate bench/Android.mk from gyp.
commit-bot@chromium.org [Fri, 16 May 2014 13:15:41 +0000 (13:15 +0000)]
Generate bench/Android.mk from gyp.

For now, remove json functionality and do not depend on json. This
allows us to build and run until solving skbug.com/2448.

bench/DeferredSurfaceCopyBench.cpp:
Include GrRenderTarget last, so SK_SUPPORT_GPU will be set properly.

bench/ResultsWriter.h:
bench/benchmain.cpp:
Remove JSONResultsWriter when SK_BUILD_JSON_WRITER is not defined,
which is the case for the Android framework build.

gyp/bench.gyp:
Depend on skia and cutils (for android_atomic_inc etc).

gyp/common_conditions.gypi:
Define SK_BUILD_JSON_WRITER when skia_build_json_writer is set.

gyp/common_variables.gypi:
Add a flag for skia_build_json_writer, and set it only when
skia_android_framework is not set.

gyp/jsoncpp.gyp:
Do not build jsoncpp when skia_build_json_writer is not defined.
include/utils/SkJSONCPP.h:
Do not include json headers when SK_BUILD_JSON_WRITER is not defined.

platform_tools/android/bin/gyp_to_android.py:
Generate bench/Android.mk.

platform_tools/android/gyp_gen/gypd_parser.py:
Skip dest_dir when checking for include_dirs.

platform_tools/android/gyp_gen/makefile_writer.py:
Build bench/Android.mk when building external/skia.

platform_tools/android/gyp_gen/tool_makefile_writer.py:
Add a parameter for putting the binary into /data/local/tmp.

BUG=skia:2447
BUG=skia:2448
R=halcanary@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/282053002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14760 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoMove skPaint2GrPaint to SkGr.h/cpp
commit-bot@chromium.org [Thu, 15 May 2014 20:32:48 +0000 (20:32 +0000)]
Move skPaint2GrPaint to SkGr.h/cpp

BUG=skia:
R=bsalomon@google.com, brian@thesalomons.net, robertphillips@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/283803003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14753 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRemove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag.
commit-bot@chromium.org [Thu, 15 May 2014 15:40:41 +0000 (15:40 +0000)]
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag.

Neither Chrome nor Android uses this flag anymore.
Make sure all constructors touched that only have one parameter are marked as 'explicit'.

BUG=2187
R=scroggo@google.com, reed@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/282203004

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14749 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoAlways inline SkFloatToFixed_arm.
commit-bot@chromium.org [Thu, 15 May 2014 09:46:20 +0000 (09:46 +0000)]
Always inline SkFloatToFixed_arm.

We have "inline" assembly for speed on ARM, but the compiler when
told to optimize for space wasn't inlining it, destroying any
possible performance improvement.

BUG=skbug:2550
R=mtklein@google.com, reed@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/281143002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14745 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoAdd asADash to Lua for scraping
commit-bot@chromium.org [Wed, 14 May 2014 16:03:14 +0000 (16:03 +0000)]
Add asADash to Lua for scraping

BUG=skia:
R=robertphillips@google.com, reed@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/267423006

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14733 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoAdd ownership dox for SkShader::asACompose.
commit-bot@chromium.org [Wed, 14 May 2014 14:28:34 +0000 (14:28 +0000)]
Add ownership dox for SkShader::asACompose.

Supplement the comment added in
http://code.google.com/p/skia/source/detail?r=14716

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/288713002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14724 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoBy default, Chromium optimizes for size when compiling on Android.
commit-bot@chromium.org [Wed, 14 May 2014 13:34:42 +0000 (13:34 +0000)]
By default, Chromium optimizes for size when compiling on Android.
Forcing the SkAlphaMulQ() function inline can yield as much as a 5-10%
improvement in rasterization time for some of Chromium's telemetry
tests on the Nexus 10, since it's in the inner loop of complex blends.

R=mtklein@google.com, reed@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/283753003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14723 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoInline noop willFoo/didFoo into SkCanvas.h.
commit-bot@chromium.org [Wed, 14 May 2014 13:13:44 +0000 (13:13 +0000)]
Inline noop willFoo/didFoo into SkCanvas.h.

We've got our canvas subclasses all calling back up to these via
INHERITED, all noops.  That's fine but currently a little sad as they
can't be optimized away without link-time optimization, which we and
Chrome only do on Windows.  We actually make a call for each of these
today on non-Windows.

So, move the empty implementations into the header so those chaining
calls really can be optimized away.

BUG=skia:
R=reed@google.com, fmalita@google.com, mtklein@google.com, fmalita@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/287593005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14722 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoAdd functions for inspecting SkShader.
commit-bot@chromium.org [Tue, 13 May 2014 18:14:45 +0000 (18:14 +0000)]
Add functions for inspecting SkShader.

Add a function to inspect an SkShader to determine if it is an
SkComposeShader.

Add a virtual function for determining if an SkShader is a custom
shader, which returns a custom set of information. The
implementation is in Android, and this function is only defined
if SK_BUILD_FOR_ANDROID_FRAMEWORK.

BUG=b/10650594
R=reed@google.com, scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/282733005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14716 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agore-land hide get/setLocalMatrix
commit-bot@chromium.org [Mon, 12 May 2014 20:42:21 +0000 (20:42 +0000)]
re-land hide get/setLocalMatrix

This reverts commit b1d702a43b07934f5b001b1b09db2c57ede909a1.

TBR=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/279903002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14702 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoMake gMask_00FF00FF a constant
commit-bot@chromium.org [Mon, 12 May 2014 15:38:00 +0000 (15:38 +0000)]
Make gMask_00FF00FF a constant

This is to optimize SkAlphaMulQ() in PIC mode. With the visibility=default
symbol the constant is not known at compile time (and is not a constant), but
instead is fetched through a double indirection through GOT. The function is
quite hot on one of the chromium benchmarks:
rasterize_and_record_micro.key_silk_cases.

This change replaces the symbol with a compile-time constant. As a bonus the
variable is not exported from the dynamic library, i. e. a cleaner library
interface.

See specific performance improvements on Android here:
  http://goo.gl/iMuTDt

R=skyostil@chromium.org, tomhudson@chromium.org, mtklein@google.com, reed@google.com, tomhudson@google.com

Author: pasko@chromium.org

Review URL: https://codereview.chromium.org/270473003

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14696 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoImproved x86 SSE build and run-time checks.
commit-bot@chromium.org [Mon, 12 May 2014 14:16:19 +0000 (14:16 +0000)]
Improved x86 SSE build and run-time checks.

Replaces the current build/run-time checks for SSE level in
opts_check_x86.cpp with a simpler and more future-proof version.
Also adds SSE versions 4.1 and 4.2 to the config file.

Author: henrik.smiding@intel.com

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
Committed: http://code.google.com/p/skia/source/detail?r=14644

R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/272503006

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14693 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoremove unused Kernel33MaskFilter
commit-bot@chromium.org [Mon, 12 May 2014 13:35:55 +0000 (13:35 +0000)]
remove unused Kernel33MaskFilter

R=robertphillips@google.com
TBR=robertphilips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/280233002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14691 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoFactor GrTexture into public GrTexture and private GrTextureImpl.
commit-bot@chromium.org [Fri, 9 May 2014 20:46:48 +0000 (20:46 +0000)]
Factor GrTexture into public GrTexture and private GrTextureImpl.

Committed: http://code.google.com/p/skia/source/detail?r=14680

R=jvanverth@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/275903002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14687 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoadd localmatrix parameter to shader's asNewEffect
commit-bot@chromium.org [Fri, 9 May 2014 20:28:11 +0000 (20:28 +0000)]
add localmatrix parameter to shader's asNewEffect

BUG=skia:
R=bsalomon@google.com, dominikg@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/278963002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14686 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRevert of Factor GrTexture into public GrTexture and private GrTextureImpl. (https...
commit-bot@chromium.org [Fri, 9 May 2014 18:02:51 +0000 (18:02 +0000)]
Revert of Factor GrTexture into public GrTexture and private GrTextureImpl. (https://codereview.chromium.org/275903002/)

Reason for revert:
Breaks chrome build.

Original issue's description:
> Factor GrTexture into public GrTexture and private GrTextureImpl.
>
> Committed: http://code.google.com/p/skia/source/detail?r=14680

R=jvanverth@google.com, robertphillips@google.com
TBR=jvanverth@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/278073002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14681 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoFactor GrTexture into public GrTexture and private GrTextureImpl.
commit-bot@chromium.org [Fri, 9 May 2014 17:37:55 +0000 (17:37 +0000)]
Factor GrTexture into public GrTexture and private GrTextureImpl.

R=jvanverth@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/275903002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14680 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRevert of hide get/setLocalMatrix (https://codereview.chromium.org/279563002/)
commit-bot@chromium.org [Fri, 9 May 2014 15:42:07 +0000 (15:42 +0000)]
Revert of hide get/setLocalMatrix (https://codereview.chromium.org/279563002/)

Reason for revert:
broke gms

Original issue's description:
> hide get/setLocalMatrix
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14675

R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org
TBR=dominikg@chromium.org, fmalita@chromium.org, fmalita@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/278903002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14677 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agohide get/setLocalMatrix
commit-bot@chromium.org [Fri, 9 May 2014 15:19:48 +0000 (15:19 +0000)]
hide get/setLocalMatrix

BUG=skia:
R=fmalita@google.com, dominikg@chromium.org, fmalita@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/279563002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14675 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agocleanup GrContext resource cache api
commit-bot@chromium.org [Fri, 9 May 2014 14:29:32 +0000 (14:29 +0000)]
cleanup GrContext resource cache api

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/275563005

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14669 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoDisable filtering in draw Bitmap operation when pixels are aligned
commit-bot@chromium.org [Fri, 9 May 2014 13:53:38 +0000 (13:53 +0000)]
Disable filtering in draw Bitmap operation when pixels are aligned

The check is now performed in the callers of internalDrawBitmap() to
avoid retrieve the texture with wrong filter mode when the pixels were
aligned.

This bug was spotted in Chrome for Android: Chrome for Androids's
Canvas drawImage loses fidelity in canvases larger than 64k pixels.

BUG=chromium:231916

R=bsalomon@google.com, robertphillips@google.com

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Author: siglesias@igalia.com

Review URL: https://codereview.chromium.org/264303008

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14665 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRevert of Improved x86 SSE build and run-time checks. (https://codereview.chromium...
commit-bot@chromium.org [Thu, 8 May 2014 15:27:52 +0000 (15:27 +0000)]
Revert of Improved x86 SSE build and run-time checks. (https://codereview.chromium.org/272503006/)

Reason for revert:
Windows builders breaking.  :(

Original issue's description:
> Improved x86 SSE build and run-time checks.
>
> Replaces the current build/run-time checks for SSE level in
> opts_check_x86.cpp with a simpler and more future-proof version.
> Also adds SSE versions 4.1 and 4.2 to the config file.
>
> Author: henrik.smiding@intel.com
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: http://code.google.com/p/skia/source/detail?r=14644

R=reed@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, henrik.smiding@intel.com
TBR=djsollen@google.com, henrik.smiding@intel.com, joakim.landberg@intel.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/277593004

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14646 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoImproved x86 SSE build and run-time checks.
commit-bot@chromium.org [Thu, 8 May 2014 15:17:50 +0000 (15:17 +0000)]
Improved x86 SSE build and run-time checks.

Replaces the current build/run-time checks for SSE level in
opts_check_x86.cpp with a simpler and more future-proof version.
Also adds SSE versions 4.1 and 4.2 to the config file.

Author: henrik.smiding@intel.com

Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com

Author: henrik.smiding@intel.com

Review URL: https://codereview.chromium.org/272503006

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14644 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoadd localmatrix-shader
commit-bot@chromium.org [Wed, 7 May 2014 22:26:37 +0000 (22:26 +0000)]
add localmatrix-shader

BUG=skia:
R=scroggo@google.com, dominikg@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/272593002

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14633 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoFirst pass at pre-rendering saveLayers for GPU
robertphillips@google.com [Wed, 7 May 2014 21:31:09 +0000 (21:31 +0000)]
First pass at pre-rendering saveLayers for GPU

https://codereview.chromium.org/261663003/

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14632 2bbb7eff-a529-9590-31e7-b0007b416f81

5 months agoRename from "(un)lock" to "(un)map" for geometry buffers.
commit-bot@chromium.org [Wed, 7 May 2014 20:51:05 +0000 (20:51 +0000)]
Rename from "(un)lock" to "(un)map" for geometry buffers.

This better reflects OpenGL terminology and is less overloaded ("lock" is used w.r.t. the resource cache).

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/275493004

git-svn-id: http://skia.googlecode.com/svn/trunk/include@14628 2bbb7eff-a529-9590-31e7-b0007b416f81