external/trace-viewer.git
2 days agoStyle improvements, incl Control bar left controls master
johnjbarton@chromium.org [Fri, 17 May 2013 22:40:22 +0000 (22:40 +0000)]
Style improvements, incl Control bar left controls

BUG=
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/9456043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@462 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoFixup for Bug 177, FakeLocalStorage
johnjbarton@chromium.org [Fri, 17 May 2013 22:24:44 +0000 (22:24 +0000)]
Fixup for Bug 177, FakeLocalStorage

TBR=johnjbarton@chromium.org
BUG=177

Review URL: https://codereview.appspot.com/9509043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@461 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoMock localStorage with a singleton and clear it in the test driver
johnjbarton@chromium.org [Fri, 17 May 2013 21:23:10 +0000 (21:23 +0000)]
Mock localStorage with a singleton and clear it in the test driver

BUG=177
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/9503043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@460 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoTrackSelector RegExpSelector should auto-disable if the regexp is blank
johnjbarton@chromium.org [Fri, 17 May 2013 18:13:33 +0000 (18:13 +0000)]
TrackSelector RegExpSelector should auto-disable if the regexp is blank

BUG=175
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/9356045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@459 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoStylesheets should be dependencies, not included via links on test pages
johnjbarton@chromium.org [Thu, 16 May 2013 23:45:39 +0000 (23:45 +0000)]
Stylesheets should be dependencies, not included via links on test pages

BUG=
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9453043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@458 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoEnsure one blank RegExpSelector for user
johnjbarton@chromium.org [Thu, 16 May 2013 20:39:33 +0000 (20:39 +0000)]
Ensure one blank RegExpSelector for user

Also, introduce constant ui.RegExpSelector.defaultSource

BUG=174
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/9094046

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@457 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoCreate TrackSelector dropdown menu.
johnjbarton@chromium.org [Thu, 16 May 2013 19:28:02 +0000 (19:28 +0000)]
Create TrackSelector dropdown menu.
Move Show Hidden Tracks button to TrackSelector.
Add RegExpSelector entries and merge their selections.

Add tests to timeline_view_test.html

BUG=159
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/9185045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@456 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoDon't try to use the layer if it doesn't exist
dsinclair@chromium.org [Wed, 15 May 2013 21:03:47 +0000 (21:03 +0000)]
Don't try to use the layer if it doesn't exist

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@455 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoCheck for compositing reasons before using.
dsinclair@chromium.org [Wed, 15 May 2013 20:48:07 +0000 (20:48 +0000)]
Check for compositing reasons before using.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@454 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoCreate ui.FilterControl widget
johnjbarton@chromium.org [Wed, 15 May 2013 17:42:04 +0000 (17:42 +0000)]
Create ui.FilterControl widget
Gives filterText
Takes hitCounterText

Use ui.FilterControl to Create a RegExpSelector widget.
Takes .regexp or text input.value, and text items.
Takes .isOn or click on button to activate/deactivate.
Gives .items with .matches boolean.

Two new test files

BUG=173
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/9258045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@453 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoThis ended up being a random grab bag of things. It:
dsinclair@chromium.org [Wed, 15 May 2013 13:51:43 +0000 (13:51 +0000)]
This ended up being a random grab bag of things. It:
-Removes the polling from the test suite.
-Removes all favicon requests
-Threads the dev server
-Sets the default ToggleButton values before setting the change handler to stop a bunch of events from firing.
-Adds per tests timings to the test.html file.
-Removes all empty test files.

BUG=168
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9423043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@452 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoMake data-view pickable and bolden the layer borders in minimap
nduca@chromium.org [Wed, 15 May 2013 07:33:22 +0000 (07:33 +0000)]
Make data-view pickable and bolden the layer borders in minimap

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@451 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoAdd checkbox to hide pure transform layers
nduca@chromium.org [Wed, 15 May 2013 06:35:59 +0000 (06:35 +0000)]
Add checkbox to hide pure transform layers

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@450 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoAdd support for stretched quads in quadView
nduca@chromium.org [Wed, 15 May 2013 03:43:44 +0000 (03:43 +0000)]
Add support for stretched quads in quadView

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@449 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoAdd warped test case
nduca@chromium.org [Wed, 15 May 2013 03:21:04 +0000 (03:21 +0000)]
Add warped test case

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@448 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoMisc tweaks.
nduca@chromium.org [Wed, 15 May 2013 02:39:55 +0000 (02:39 +0000)]
Misc tweaks.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@447 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoStyle tweaks
nduca@chromium.org [Wed, 15 May 2013 02:39:51 +0000 (02:39 +0000)]
Style tweaks

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@446 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agorAF-drive layer viewer update to prevent flashing
nduca@chromium.org [Wed, 15 May 2013 02:39:48 +0000 (02:39 +0000)]
rAF-drive layer viewer update to prevent flashing

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@445 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoPersist selection of disabled-by-default options
nduca@chromium.org [Wed, 15 May 2013 02:38:32 +0000 (02:38 +0000)]
Persist selection of disabled-by-default options

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@444 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoIterate through pictures in reverse so they show up correctly
enne@chromium.org [Tue, 14 May 2013 23:25:51 +0000 (23:25 +0000)]
Iterate through pictures in reverse so they show up correctly

TBR=nduca@chromium.org
BUG=none

Review URL: https://codereview.appspot.com/9363047

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@443 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoImprove performance of raster by saving the created image
nduca@chromium.org [Tue, 14 May 2013 22:53:27 +0000 (22:53 +0000)]
Improve performance of raster by saving the created image

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@442 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoFix picture rasterizing clobbering previous pictures
enne@chromium.org [Tue, 14 May 2013 22:38:34 +0000 (22:38 +0000)]
Fix picture rasterizing clobbering previous pictures

I hate JavaScript for loops.

TBR=nduca@chromium.org
BUG=none

Review URL: https://codereview.appspot.com/9363045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@441 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoNo longer need to swizzle, because of crrev.com/200054
nduca@chromium.org [Tue, 14 May 2013 22:27:19 +0000 (22:27 +0000)]
No longer need to swizzle, because of crrev.com/200054

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@440 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoAdd warning element if picture is missing
enne@chromium.org [Tue, 14 May 2013 21:57:35 +0000 (21:57 +0000)]
Add warning element if picture is missing

TBR=nduca@chromium.org
BUG=none

Review URL: https://codereview.appspot.com/9222046

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@439 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoChange registration for ContentLayer => TiledLayer
enne@chromium.org [Tue, 14 May 2013 20:41:48 +0000 (20:41 +0000)]
Change registration for ContentLayer => TiledLayer

This will match the change in https://codereview.chromium.org/14607017/

R=dsinclair@chromium.org
BUG=none

Review URL: https://codereview.appspot.com/9207046

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@438 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoAdd a 'Show Hidden Tracks' button to the control bar
johnjbarton@chromium.org [Tue, 14 May 2013 17:57:58 +0000 (17:57 +0000)]
Add a 'Show Hidden Tracks' button to the control bar

    Clicking 'Show Hidden Tracks' restores hidden tracks
    Fixup toggle-button API and CSS
    Rename ToggleButton.isTrue to ToggleButton.isOn.
    Convert control bar to modern flex box CSS.

    Add test case to timeline_view_test.html

R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/9289044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@437 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoWorkaround for Issue #162, a Cr platform bug
johnjbarton@chromium.org [Tue, 14 May 2013 17:52:10 +0000 (17:52 +0000)]
Workaround for Issue #162, a Cr platform bug

BUG=162
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9335044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@436 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoGenerate list of trace_viewer files automatically.
dsinclair@chromium.org [Tue, 14 May 2013 15:36:49 +0000 (15:36 +0000)]
Generate list of trace_viewer files automatically.

This updates the dev server to generate the list of test_data files
to be displayed in the trace_viewer. All files in ./test_data will be
returned and available for selection.

BUG=
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9409044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@435 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoShow layer bitmap when --enable-skia-benchmarking is passed
nduca@chromium.org [Tue, 14 May 2013 15:03:28 +0000 (15:03 +0000)]
Show layer bitmap when --enable-skia-benchmarking is passed

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@434 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoTeach quadView how to display byte arrays
nduca@chromium.org [Tue, 14 May 2013 15:03:23 +0000 (15:03 +0000)]
Teach quadView how to display byte arrays

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@433 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMake display of damage and pictures more clear
nduca@chromium.org [Tue, 14 May 2013 13:23:01 +0000 (13:23 +0000)]
Make display of damage and pictures more clear

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@432 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMore test data
nduca@chromium.org [Tue, 14 May 2013 13:21:09 +0000 (13:21 +0000)]
More test data

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@431 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoAdd Rect2.FromArray
nduca@chromium.org [Tue, 14 May 2013 13:21:05 +0000 (13:21 +0000)]
Add Rect2.FromArray

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@430 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMutate objects immediately while creating implicit snapshots.
nduca@chromium.org [Tue, 14 May 2013 10:23:31 +0000 (10:23 +0000)]
Mutate objects immediately while creating implicit snapshots.

We used to discover snapshots, memoize them, and then later patch up
the objects that contained them. This was a mess because we'd get confused
and patch up an the object's original args instead of the object.

This patch creates object snapshots as we encounter them, replacing
them inline, and then continuing the search for more implicit snapshots in
the newly-created snapshot.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@429 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoHandle objects being deleted properly
nduca@chromium.org [Tue, 14 May 2013 10:23:27 +0000 (10:23 +0000)]
Handle objects being deleted properly

We used to ignore 'D' events when they dont have snapshots between them.
However, an object can be deleted and then referenced in an implicit
snapshot. In that case, we get a series of deleted calls, and then
during the implicit id creation, a series of snapshot calls. In that case,
try to extend the lifetime of the deleted object that is most immediately
to the right of the snapshot.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@428 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoRough draft of showing invalidation rects for layers
nduca@chromium.org [Tue, 14 May 2013 10:23:22 +0000 (10:23 +0000)]
Rough draft of showing invalidation rects for layers

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@427 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoShow layers that dont draw content as cc::LayerImpl even though their traced type...
nduca@chromium.org [Tue, 14 May 2013 10:23:16 +0000 (10:23 +0000)]
Show layers that dont draw content as cc::LayerImpl even though their traced type is somethign else.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@426 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoAllow selection in errors dialog
nduca@chromium.org [Tue, 14 May 2013 10:23:12 +0000 (10:23 +0000)]
Allow selection in errors dialog

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@425 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoFix errors dialog selector so that overflow works
nduca@chromium.org [Tue, 14 May 2013 10:23:07 +0000 (10:23 +0000)]
Fix errors dialog selector so that overflow works

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@424 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agomore test data
nduca@chromium.org [Tue, 14 May 2013 10:19:07 +0000 (10:19 +0000)]
more test data

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@423 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMinor fixes to quads & rects
nduca@chromium.org [Tue, 14 May 2013 10:19:02 +0000 (10:19 +0000)]
Minor fixes to quads & rects

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@422 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoAdd a region type.
nduca@chromium.org [Tue, 14 May 2013 10:18:56 +0000 (10:18 +0000)]
Add a region type.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@421 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoColor viewport blue
nduca@chromium.org [Tue, 14 May 2013 10:18:51 +0000 (10:18 +0000)]
Color viewport blue

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@420 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoAdd support for coloring borders in quadview
nduca@chromium.org [Tue, 14 May 2013 10:18:47 +0000 (10:18 +0000)]
Add support for coloring borders in quadview

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@419 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoFix pending tree selector finally
nduca@chromium.org [Tue, 14 May 2013 10:18:41 +0000 (10:18 +0000)]
Fix pending tree selector finally

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@418 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMove the selection's first track into view if needed.
nduca@chromium.org [Tue, 14 May 2013 04:37:59 +0000 (04:37 +0000)]
Move the selection's first track into view if needed.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@417 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMake the analysis view bigger when viewing object
nduca@chromium.org [Tue, 14 May 2013 04:37:53 +0000 (04:37 +0000)]
Make the analysis view bigger when viewing object

Do this by making the drag handle sensitive to class names. This ends up
allowing the feature to work by simply styling the analysis view's height
differently depending on whether it is viewing an object or not.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@416 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoDont show undefined on summary rows with no label
nduca@chromium.org [Tue, 14 May 2013 04:37:49 +0000 (04:37 +0000)]
Dont show undefined on summary rows with no label

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@415 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoObtain test list from devserver instead of hard coding it in tests.html
nduca@chromium.org [Tue, 14 May 2013 04:36:57 +0000 (04:36 +0000)]
Obtain test list from devserver instead of hard coding it in tests.html

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@414 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoDisplay name of loaded file in trace viewer.
dsinclair@chromium.org [Tue, 14 May 2013 02:11:19 +0000 (02:11 +0000)]
Display name of loaded file in trace viewer.

When a file is loaded, if the name is provided, we will display the
name in the trace viewer header.

Currently, this will only display names of dropped files. When a file is
loaded using the 'Load' button the name will not be displayed until the
Chromium side of this patch is committed.

BUG=108
R=johnjbarton@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/9329043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@413 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoCommit a reference picture
nduca@chromium.org [Tue, 14 May 2013 01:59:22 +0000 (01:59 +0000)]
Commit a reference picture

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@412 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoListen to hash change in viewer
nduca@chromium.org [Tue, 14 May 2013 01:55:11 +0000 (01:55 +0000)]
Listen to hash change in viewer

R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/9398045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@411 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMove interactive tests
dsinclair@chromium.org [Tue, 14 May 2013 01:24:11 +0000 (01:24 +0000)]
Move interactive tests

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@410 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoRegenerate about_tracing with right base ordering
dsinclair@chromium.org [Tue, 14 May 2013 00:58:01 +0000 (00:58 +0000)]
Regenerate about_tracing with right base ordering

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@409 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoRevert "Yet more changes to parse_deps to try to elimiante noise in deps calculation"
dsinclair@chromium.org [Tue, 14 May 2013 00:57:59 +0000 (00:57 +0000)]
Revert "Yet more changes to parse_deps to try to elimiante noise in deps calculation"

This reverts commit c6852ea41784d6c7816f34100db43dd200eb9a67.

This forced the 'base.js' require to come last, which breaks chrome tracing as
it needs it first.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@408 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoChange base path in trace_viewer.html; fixup spelling mistake.
dsinclair@chromium.org [Tue, 14 May 2013 00:33:02 +0000 (00:33 +0000)]
Change base path in trace_viewer.html; fixup spelling mistake.

BUG=

Review URL: https://codereview.appspot.com/9297047

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@407 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoSend exceptions that happen during object import into Model.importErrors
nduca@chromium.org [Tue, 14 May 2013 00:25:18 +0000 (00:25 +0000)]
Send exceptions that happen during object import into Model.importErrors

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@406 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMake default object view have overflow so it can scroll
nduca@chromium.org [Tue, 14 May 2013 00:25:13 +0000 (00:25 +0000)]
Make default object view have overflow so it can scroll

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@405 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoAdd a selection getter to analysis view for debugging
nduca@chromium.org [Tue, 14 May 2013 00:25:08 +0000 (00:25 +0000)]
Add a selection getter to analysis view for debugging

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@404 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMake the tree type picker work.
nduca@chromium.org [Tue, 14 May 2013 00:25:03 +0000 (00:25 +0000)]
Make the tree type picker work.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@403 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoPrevent exceptions in data view when no layer is selected
nduca@chromium.org [Tue, 14 May 2013 00:24:59 +0000 (00:24 +0000)]
Prevent exceptions in data view when no layer is selected

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@402 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMake binding to first and last snapshots in an object instance more permissive
nduca@chromium.org [Tue, 14 May 2013 00:24:53 +0000 (00:24 +0000)]
Make binding to first and last snapshots in an object instance more permissive

It is often the case that you will have this form:
  ts=5  ref to 0x1000
  ts=10 snapshot 0x1000

And similarly
  ts=10 snapshot 0x1000
  ts=15 snapshot 0x1000
  ts=20 ref to 0x1000

This change lets the first example bind to the snapshot at ts=10, and the the second
example bind to the snapshot at ts=15.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@401 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoui.CreateOptions should explode when the target property is not set up correctly.
nduca@chromium.org [Tue, 14 May 2013 00:24:49 +0000 (00:24 +0000)]
ui.CreateOptions should explode when the target property is not set up correctly.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@400 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoGenerate deps automatically in the test server.
dsinclair@chromium.org [Tue, 14 May 2013 00:15:50 +0000 (00:15 +0000)]
Generate deps automatically in the test server.

This removes the deps.js file in favour of auto-generating the
contents in the dev server.

BUG=
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9098045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@399 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMake cc.js and include that in key places instead of internal classes
nduca@chromium.org [Tue, 14 May 2013 00:13:37 +0000 (00:13 +0000)]
Make cc.js and include that in key places instead of internal classes

Review URL: https://codereview.appspot.com/9036051

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@398 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoYet more changes to parse_deps to try to elimiante noise in deps calculation
nduca@chromium.org [Tue, 14 May 2013 00:12:00 +0000 (00:12 +0000)]
Yet more changes to parse_deps to try to elimiante noise in deps calculation

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@397 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoEnable toggling the grid off.
dsinclair@chromium.org [Mon, 13 May 2013 23:28:27 +0000 (23:28 +0000)]
Enable toggling the grid off.

If you press the 'g' or 'G' button we will enable the marker grid.
Currently there is no way to remove the grid, which can be annoying
when you just want to check something and end with all these red
lines on the screen.

This CL will disable the grid markers if you press the same key
again while on the same starting selection.

BUG=
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9268049

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@396 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoUpdates to the test runner.
dsinclair@chromium.org [Mon, 13 May 2013 23:27:07 +0000 (23:27 +0000)]
Updates to the test runner.

A couple of changes in this CL.

1- Gen deps every 30 seconds (makes tests run about 2 seconds faster).
2- Only generate deps.js instead of deps and about_tracing files.
3- Add some statistics to the tests.html output.
4- Moves the test iframes way off screen so we never get artifacts.
5- If tests fail, the test iframe is displayed so you can see the errors.

BUG=
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9317044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@395 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoRegister all layer types with object snapshot
enne@chromium.org [Mon, 13 May 2013 21:57:55 +0000 (21:57 +0000)]
Register all layer types with object snapshot

R=nduca@chromium.org
BUG=none

Review URL: https://codereview.appspot.com/9066048

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@394 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoUse the tracingController getter in profiling_view.
dsinclair@chromium.org [Sat, 11 May 2013 01:37:11 +0000 (01:37 +0000)]
Use the tracingController getter in profiling_view.

Due to the internal name change in r389 the profiling_view broke
because it was directly accessing the generated variable name.

This CL updates profiling_view to correctly use the getter fixing
the tracingController accesses.

TBR=johnjbarton

Review URL: https://codereview.appspot.com/9349044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@393 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoSort deps and commit updated deps files
nduca@chromium.org [Fri, 10 May 2013 20:59:19 +0000 (20:59 +0000)]
Sort deps and commit updated deps files

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@392 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoviewing-object class was being set incorrectly
nduca@chromium.org [Fri, 10 May 2013 20:52:34 +0000 (20:52 +0000)]
viewing-object class was being set incorrectly

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@391 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoDont add output if non-root as a workaround for iframe visibility bugs
nduca@chromium.org [Fri, 10 May 2013 20:52:30 +0000 (20:52 +0000)]
Dont add output if non-root as a workaround for iframe visibility bugs

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@390 0e6d7f2b-9903-5b78-7403-59d27f066143

11 days agoFixes #161, base.defineProperty private names collide
johnjbarton@chromium.org [Thu, 9 May 2013 18:20:52 +0000 (18:20 +0000)]
Fixes #161, base.defineProperty private names collide
with Google JS style private name.

Use _base_ to obfuscate private names

Upgrade base_test.html for colliding private names

BUG=161
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/9246044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@389 0e6d7f2b-9903-5b78-7403-59d27f066143

11 days agoFixes #157, base.defineProperty does not set oldValue
johnjbarton@chromium.org [Wed, 8 May 2013 20:38:17 +0000 (20:38 +0000)]
Fixes #157, base.defineProperty does not set oldValue

Allow base.defineProperty change events to bubble; fix bool attributes.

Use getAttribute() to obtain the oldValue of attribute-stored properties
(Boolean attributes have blank string values when true.)

Add base/define_properties_test.html and call in tests.html

BUG=157
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9033050

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@388 0e6d7f2b-9903-5b78-7403-59d27f066143

11 days agoSimplify cleanup logic for loaded trace data.
dsinclair@chromium.org [Wed, 8 May 2013 19:54:33 +0000 (19:54 +0000)]
Simplify cleanup logic for loaded trace data.

BUG=
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9205045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@387 0e6d7f2b-9903-5b78-7403-59d27f066143

11 days agoShow info on the selected layer
nduca@chromium.org [Wed, 8 May 2013 19:49:38 +0000 (19:49 +0000)]
Show info on the selected layer

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@386 0e6d7f2b-9903-5b78-7403-59d27f066143

11 days agoSupport dropping of files onto chrome://tracing.
dsinclair@chromium.org [Wed, 8 May 2013 19:46:45 +0000 (19:46 +0000)]
Support dropping of files onto chrome://tracing.

Add a drop handler to the profile_view. When you drop a file it will
be parsed and the UI updated to reflect the new data.

BUG=112
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/7299068

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@385 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFix remaining lint issues
nduca@chromium.org [Tue, 7 May 2013 23:16:20 +0000 (23:16 +0000)]
Fix remaining lint issues

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@384 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFix the 80col warnings in importer
nduca@chromium.org [Tue, 7 May 2013 23:16:15 +0000 (23:16 +0000)]
Fix the 80col warnings in importer

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@383 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoAllow lines ending with @supress longLineCheck to not warn
nduca@chromium.org [Tue, 7 May 2013 23:16:11 +0000 (23:16 +0000)]
Allow lines ending with @supress longLineCheck to not warn

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@382 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFix style warnings in importer
nduca@chromium.org [Tue, 7 May 2013 23:16:00 +0000 (23:16 +0000)]
Fix style warnings in importer

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@381 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFix style errors in src/tracing/tracks
nduca@chromium.org [Tue, 7 May 2013 23:15:54 +0000 (23:15 +0000)]
Fix style errors in src/tracing/tracks

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@380 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFix style issues in src/tracing/model
nduca@chromium.org [Tue, 7 May 2013 23:15:47 +0000 (23:15 +0000)]
Fix style issues in src/tracing/model

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@379 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFixup css lint errors.
dsinclair@chromium.org [Tue, 7 May 2013 20:05:03 +0000 (20:05 +0000)]
Fixup css lint errors.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@378 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFixup licenses
dsinclair@chromium.org [Tue, 7 May 2013 19:29:28 +0000 (19:29 +0000)]
Fixup licenses

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@377 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoCreate ToggleButton span widget, click toggles isTrue state.
johnjbarton@chromium.org [Tue, 7 May 2013 19:16:35 +0000 (19:16 +0000)]
Create ToggleButton span widget, click toggles isTrue state.

Test in toggle_button_test.html

Add the new toggle_button_test.html to tests.html

Refactor tracing.tracks.track to remove unused code and use ToggleButton

BUG=153
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/9275043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@376 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFix style errors in analysis
nduca@chromium.org [Tue, 7 May 2013 19:11:47 +0000 (19:11 +0000)]
Fix style errors in analysis

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@375 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFix style errors in cc
nduca@chromium.org [Tue, 7 May 2013 19:02:54 +0000 (19:02 +0000)]
Fix style errors in cc

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@374 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFix base/ style errors
nduca@chromium.org [Tue, 7 May 2013 19:01:53 +0000 (19:01 +0000)]
Fix base/ style errors

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@373 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFix style errors in src/ui
nduca@chromium.org [Tue, 7 May 2013 18:58:29 +0000 (18:58 +0000)]
Fix style errors in src/ui

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@372 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoAlso add a fixjsstyle script
nduca@chromium.org [Tue, 7 May 2013 18:58:25 +0000 (18:58 +0000)]
Also add a fixjsstyle script

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@371 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoAdd a helper script for running gjslint
nduca@chromium.org [Tue, 7 May 2013 18:54:55 +0000 (18:54 +0000)]
Add a helper script for running gjslint

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@370 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoFix failing test
nduca@chromium.org [Tue, 7 May 2013 18:54:51 +0000 (18:54 +0000)]
Fix failing test

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@369 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoReport the dependent when files cannot be found in parse_deps.py
johnjbarton@chromium.org [Tue, 7 May 2013 18:45:16 +0000 (18:45 +0000)]
Report the dependent when files cannot be found in parse_deps.py

BUG=155
R=dsinclair@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/9242044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@368 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoDisplay tooltip on href hover.
dsinclair@chromium.org [Tue, 7 May 2013 18:31:54 +0000 (18:31 +0000)]
Display tooltip on href hover.

This CL restores the display of aggregate statisitics when hovering
the links in the analysis results.

BUG=154
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9273044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@367 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoMove system and continuous tracing buttons to record dialog.
dsinclair@chromium.org [Tue, 7 May 2013 18:04:46 +0000 (18:04 +0000)]
Move system and continuous tracing buttons to record dialog.

BUG=151
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9270043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@366 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoAdd disabled by default to trace viewer selection.
dsinclair@chromium.org [Tue, 7 May 2013 13:46:04 +0000 (13:46 +0000)]
Add disabled by default to trace viewer selection.

This splits the recording and category filter dialogs apart. The recording
dialog will, currently, always show both enabled by default and disabled
by default categories, even if disabled is empty.

BUG=
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/9237043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@365 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoFirst functioning version of LayerTreeHostImplView
nduca@chromium.org [Mon, 6 May 2013 15:11:14 +0000 (15:11 +0000)]
First functioning version of LayerTreeHostImplView

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@364 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoCorrectly handle implicit object creation
nduca@chromium.org [Mon, 6 May 2013 15:11:11 +0000 (15:11 +0000)]
Correctly handle implicit object creation

Once an implicit object snapshot is created, the element within args that
pointed at it must be replaced with the newly created snapshot.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@363 0e6d7f2b-9903-5b78-7403-59d27f066143