external/trace-viewer.git
4 hours agoRename RasterTaskSliceView to RasterTaskSubView master
nduca@chromium.org [Thu, 21 Aug 2014 01:34:31 +0000 (01:34 +0000)]
Rename RasterTaskSliceView to RasterTaskSubView

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1507 0e6d7f2b-9903-5b78-7403-59d27f066143

4 hours agoMake RasterTaskSliceView a SubView
nduca@chromium.org [Thu, 21 Aug 2014 01:26:40 +0000 (01:26 +0000)]
Make RasterTaskSliceView a SubView

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1506 0e6d7f2b-9903-5b78-7403-59d27f066143

5 hours agoUpdate the depth during slider drag, too
nduca@chromium.org [Thu, 21 Aug 2014 00:45:27 +0000 (00:45 +0000)]
Update the depth during slider drag, too

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1505 0e6d7f2b-9903-5b78-7403-59d27f066143

5 hours agoAdd slider to quad stack to control stacking depth
nduca@chromium.org [Thu, 21 Aug 2014 00:41:29 +0000 (00:41 +0000)]
Add slider to quad stack to control stacking depth

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1504 0e6d7f2b-9903-5b78-7403-59d27f066143

5 hours agoAttach tracking to canvas instead of quad stack.
nduca@chromium.org [Thu, 21 Aug 2014 00:41:22 +0000 (00:41 +0000)]
Attach tracking to canvas instead of quad stack.

Without this, dragging on the widgets attached to the stack
will cause the camera to move around.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1503 0e6d7f2b-9903-5b78-7403-59d27f066143

6 hours agoFix layer picking not causing layers to get selected in LTQSV
nduca@chromium.org [Thu, 21 Aug 2014 00:13:04 +0000 (00:13 +0000)]
Fix layer picking not causing layers to get selected in LTQSV

BUG=594

Review URL: https://codereview.appspot.com/125400045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1502 0e6d7f2b-9903-5b78-7403-59d27f066143

9 hours agoRevert "Remove mapfiles"
nduca@chromium.org [Wed, 20 Aug 2014 21:10:59 +0000 (21:10 +0000)]
Revert "Remove mapfiles"

This turned out to be useful for people! My bad!

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1501 0e6d7f2b-9903-5b78-7403-59d27f066143

10 hours agoEnsure isActiveTile is on the tile object.
vmpstr@chromium.org [Wed, 20 Aug 2014 19:23:14 +0000 (19:23 +0000)]
Ensure isActiveTile is on the tile object.

This patch ensures that we move the args.isActiveTile parameter to
the tile directly.

TBR=nduca
BUG=591

Review URL: https://codereview.appspot.com/123650043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1500 0e6d7f2b-9903-5b78-7403-59d27f066143

10 hours agoFix a 'No Label' bug in the tab-view.
cvicentiu@chromium.org [Wed, 20 Aug 2014 19:20:09 +0000 (19:20 +0000)]
Fix a 'No Label' bug in the tab-view.

If used in a specific order, the tab-view could lose track of an
attribute changed on a tab that gets unselected. This is caused by the
fact that observers lose their mutation record that was not processed
upon disconnect. If we disconnect the observer that monitors attributes
A and B because we want to change attribute B programatically,
while a mutation still hasn't been handled for attribute A, we lose the
mutation notification for attribute A.

Splitting observers per attribute removes this problem.

TBR=nduca

Review URL: https://codereview.appspot.com/125620043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1499 0e6d7f2b-9903-5b78-7403-59d27f066143

13 hours agoSome custom views are not based off analysis-sub-view yet.
cvicentiu@chromium.org [Wed, 20 Aug 2014 16:53:00 +0000 (16:53 +0000)]
Some custom views are not based off analysis-sub-view yet.

This means that the tabLabel property is not yet implemented
by every subView in the analysis. This workaround fixes the display
of a tab with 'No Label'.

TBR=nduca

Review URL: https://codereview.appspot.com/124680043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1498 0e6d7f2b-9903-5b78-7403-59d27f066143

16 hours agoImplemented a toggleable container.
cvicentiu@chromium.org [Wed, 20 Aug 2014 13:59:27 +0000 (13:59 +0000)]
Implemented a toggleable container.

This container will help in improving the analysis results
statistics display. Right now, the analysis results uses a tooltip
that is very difficult to read. Also, the fact that it's hidden does not
help with discovering the feature in the first place.

The plan is to add a small button (perhaps a +/- sign) that expands
a row to show the statistics.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/124460046

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1497 0e6d7f2b-9903-5b78-7403-59d27f066143

16 hours agoFixed race condition in tests.
cvicentiu@chromium.org [Wed, 20 Aug 2014 13:56:48 +0000 (13:56 +0000)]
Fixed race condition in tests.

Whenever we register a callback that should happen after
the polymer-ready, the code should use tvcm.onPolymerReady(callback)
and pass the callback function that way.

TBR=nduca

Review URL: https://codereview.appspot.com/125600043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1496 0e6d7f2b-9903-5b78-7403-59d27f066143

17 hours agoBegin unifying old-style custom views with general analysis subviews
nduca@chromium.org [Wed, 20 Aug 2014 12:52:45 +0000 (12:52 +0000)]
Begin unifying old-style custom views with general analysis subviews

This gets us one step closer to a single subview system.

R=cvicentiu@chromium.org

Review URL: https://codereview.appspot.com/125590043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1495 0e6d7f2b-9903-5b78-7403-59d27f066143

17 hours agoRemove mapfiles
nduca@chromium.org [Wed, 20 Aug 2014 12:47:33 +0000 (12:47 +0000)]
Remove mapfiles

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1494 0e6d7f2b-9903-5b78-7403-59d27f066143

19 hours agoUse a type registration model to simplify subview creation
nduca@chromium.org [Wed, 20 Aug 2014 11:12:08 +0000 (11:12 +0000)]
Use a type registration model to simplify subview creation

R=cvicentiu@chromium.org, cvicentiu

Review URL: https://codereview.appspot.com/130320043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1493 0e6d7f2b-9903-5b78-7403-59d27f066143

20 hours agoAdd socket to fix mising-module error on finish
nduca@chromium.org [Wed, 20 Aug 2014 09:35:16 +0000 (09:35 +0000)]
Add socket to fix mising-module error on finish

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1492 0e6d7f2b-9903-5b78-7403-59d27f066143

20 hours agoPrune the organized events instead of having repeated workarounds in analysis
nduca@chromium.org [Wed, 20 Aug 2014 09:33:50 +0000 (09:33 +0000)]
Prune the organized events instead of having repeated workarounds in analysis

TBR=cvicentiu

Review URL: https://codereview.appspot.com/125560043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1491 0e6d7f2b-9903-5b78-7403-59d27f066143

29 hours agoDo not include inactive tiles in gpuMemoryUsageInBytes computation
nduca@chromium.org [Wed, 20 Aug 2014 01:03:31 +0000 (01:03 +0000)]
Do not include inactive tiles in gpuMemoryUsageInBytes computation

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1489 0e6d7f2b-9903-5b78-7403-59d27f066143

29 hours agoUse === due to type coercion for undefined
nduca@chromium.org [Wed, 20 Aug 2014 01:03:26 +0000 (01:03 +0000)]
Use === due to type coercion for undefined

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1488 0e6d7f2b-9903-5b78-7403-59d27f066143

29 hours agoDo not draw inactive tiles
nduca@chromium.org [Wed, 20 Aug 2014 01:00:14 +0000 (01:00 +0000)]
Do not draw inactive tiles

TBR=vmpstr
BUG=591

Review URL: https://codereview.appspot.com/128470043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1487 0e6d7f2b-9903-5b78-7403-59d27f066143

45 hours agoAdd unit tests for upload trace button.
mmandlis@chromium.org [Tue, 19 Aug 2014 08:33:09 +0000 (08:33 +0000)]
Add unit tests for upload trace button.

BUG=585
R=pdr@chromium.org

Review URL: https://codereview.appspot.com/126370043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1486 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoWorkaround for broken CData handling in old python
nduca@chromium.org [Tue, 19 Aug 2014 05:11:12 +0000 (05:11 +0000)]
Workaround for broken CData handling in old python

Old python treat non-</script> tags as ending the script tag section.
Thats le-wrong. This is a quick workaround for that to fix issues folks
are seeing with older pythons when building Chrome.

BUG=590

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1485 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoMake async slice group track not derive from slice group track
nduca@chromium.org [Tue, 19 Aug 2014 05:11:07 +0000 (05:11 +0000)]
Make async slice group track not derive from slice group track

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1484 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoRemoved forgotten commented out line during refactoring
cvicentiu@chromium.org [Mon, 18 Aug 2014 21:15:53 +0000 (21:15 +0000)]
Removed forgotten commented out line during refactoring

TBR=nduca

Review URL: https://codereview.appspot.com/130220043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1483 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoConvert analysis_view to polymer element.
cvicentiu@chromium.org [Mon, 18 Aug 2014 21:01:01 +0000 (21:01 +0000)]
Convert analysis_view to polymer element.

Integrate the new tab view into the analysis_view.

This is based off:
https://codereview.appspot.com/123190044/

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/129100043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1482 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoAdded Analysis Sub Views
cvicentiu@chromium.org [Mon, 18 Aug 2014 20:57:05 +0000 (20:57 +0000)]
Added Analysis Sub Views

This patch is the next stepping stone to convert the analysis-view previously used to a new polymer
element.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/123190044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1481 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoRemove unused non cross-browser lines from trace viewer (tvcm) code.
mmandlis@chromium.org [Mon, 18 Aug 2014 09:47:50 +0000 (09:47 +0000)]
Remove unused non cross-browser lines from trace viewer (tvcm) code.

remove unused non cross-browser lines from trace viewer (tvcm) code

BUG=
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/128180043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1480 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoPut raster task slice view in tall mode
nduca@chromium.org [Sat, 16 Aug 2014 07:41:11 +0000 (07:41 +0000)]
Put raster task slice view in tall mode

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1479 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoFix sizing of raster task slice view
nduca@chromium.org [Sat, 16 Aug 2014 07:41:07 +0000 (07:41 +0000)]
Fix sizing of raster task slice view

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1478 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoFix test failures following Selection.push changes
nduca@chromium.org [Sat, 16 Aug 2014 07:30:54 +0000 (07:30 +0000)]
Fix test failures following Selection.push changes

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1477 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoRemove accidental debugger statement
nduca@chromium.org [Sat, 16 Aug 2014 07:30:50 +0000 (07:30 +0000)]
Remove accidental debugger statement

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1476 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoSelection.push didn't bother about duplicates.
gholap@chromium.org [Fri, 15 Aug 2014 23:46:44 +0000 (23:46 +0000)]
Selection.push didn't bother about duplicates.
Now it adds events only if it wasn't already added.
- Added a test to check for de-duplication.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/130140044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1475 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoSystemStatsSnapshot had two constructors.
gholap@chromium.org [Fri, 15 Aug 2014 23:43:16 +0000 (23:43 +0000)]
SystemStatsSnapshot had two constructors.
Also, the second one didn't call parent constructor.

R=nduca@chromium.org
TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/126310043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1474 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoMoved window history state management code AnalysisView -> TimelineView
gholap@chromium.org [Fri, 15 Aug 2014 17:07:47 +0000 (17:07 +0000)]
Moved window history state management code AnalysisView -> TimelineView

BUG= https://code.google.com/p/trace-viewer/issues/detail?id=582
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/122450043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1473 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoPut clamping of 3000 on distanceToVisible
nduca@chromium.org [Thu, 14 Aug 2014 07:25:04 +0000 (07:25 +0000)]
Put clamping of 3000 on distanceToVisible

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1471 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoTime to visible has been removed.
nduca@chromium.org [Thu, 14 Aug 2014 07:25:00 +0000 (07:25 +0000)]
Time to visible has been removed.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1470 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoShow the value of the colormap and explanation of border color
nduca@chromium.org [Thu, 14 Aug 2014 07:24:55 +0000 (07:24 +0000)]
Show the value of the colormap and explanation of border color

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1469 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoDistanceToVisible was renamed on cc side but frame viewer was not updated.
nduca@chromium.org [Thu, 14 Aug 2014 07:24:51 +0000 (07:24 +0000)]
DistanceToVisible was renamed on cc side but frame viewer was not updated.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1468 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoAdd best-effort memory info for old traces
nduca@chromium.org [Thu, 14 Aug 2014 06:35:38 +0000 (06:35 +0000)]
Add best-effort memory info for old traces

Old frame viewer traces don't have good memory info. But, there's still
some information. Try to give as much info as possible so that we can
diagnose tile allocation issues.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1467 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoAdd even more memory debugging features to header.
nduca@chromium.org [Thu, 14 Aug 2014 02:55:13 +0000 (02:55 +0000)]
Add even more memory debugging features to header.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1466 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoWhen an empty tree is given, clear the quads and header.
nduca@chromium.org [Thu, 14 Aug 2014 02:53:42 +0000 (02:53 +0000)]
When an empty tree is given, clear the quads and header.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1465 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoFix handling of layer picker selection changes
nduca@chromium.org [Thu, 14 Aug 2014 02:53:36 +0000 (02:53 +0000)]
Fix handling of layer picker selection changes

The layer picker wasn't changing the tree on the
quad stack view when you changed its whichTree dropdown.
The selection would update but not the visualization.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1464 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoShrink header font to fit more stuff.
nduca@chromium.org [Thu, 14 Aug 2014 02:53:31 +0000 (02:53 +0000)]
Shrink header font to fit more stuff.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1463 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoFix buttons in upload popup.
dsinclair@chromium.org [Thu, 14 Aug 2014 01:23:43 +0000 (01:23 +0000)]
Fix buttons in upload popup.

'Ok' and 'Cancel' buttons appear in the popup at first, when Upload button is
clicked. Once upload starts, 'ok' button is removed and 'cancel' is renamed
to 'close'.

This CL is by mmandlis@ and was reviewed in
https://codereview.appspot.com/129170043/.

BUG=584
TBR=mmandlis

Review URL: https://codereview.appspot.com/126210043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1462 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoShow tile manager global state in lthiqsv
nduca@chromium.org [Wed, 13 Aug 2014 02:25:42 +0000 (02:25 +0000)]
Show tile manager global state in lthiqsv

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1461 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoUse ObjectInstanceGroupTrack to display and group object instances
nduca@chromium.org [Wed, 13 Aug 2014 02:25:36 +0000 (02:25 +0000)]
Use ObjectInstanceGroupTrack to display and group object instances

This fixes an issue where webview frames were unclickable: in webview, there
are two LTHIs.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1460 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoIntroduce MultiRowTrack
nduca@chromium.org [Wed, 13 Aug 2014 02:25:31 +0000 (02:25 +0000)]
Introduce MultiRowTrack

There are many tracks that want to take a list of data, group it a bit,
then produce sub tracks. This generalizes that code into MultiRowTrack.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1459 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoMove heap include to features
nduca@chromium.org [Wed, 13 Aug 2014 02:25:26 +0000 (02:25 +0000)]
Move heap include to features

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1458 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoSort object snapshots so that picking works correctly.
nduca@chromium.org [Wed, 13 Aug 2014 02:25:18 +0000 (02:25 +0000)]
Sort object snapshots so that picking works correctly.

The object instance track assumes that snapshots are sorted. When they aren't, things misbehave.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1457 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoRecognize latest raster task names
nduca@chromium.org [Wed, 13 Aug 2014 00:24:06 +0000 (00:24 +0000)]
Recognize latest raster task names

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1456 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoFixed tab_view display issues.
cvicentiu@chromium.org [Tue, 12 Aug 2014 23:18:40 +0000 (23:18 +0000)]
Fixed tab_view display issues.

The tab view is now congruent with the rest of the interface.

R=dsinclair@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/127120043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1455 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoUpdate jszip to version 2.4.0
skyostil@chromium.org [Tue, 12 Aug 2014 14:55:32 +0000 (14:55 +0000)]
Update jszip to version 2.4.0

Update jszip to fix a problem in how TextDecoder is used.

BUG=chromium:402689
R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/123250043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1454 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoRefactor Slice construction callsites to pass in args and duration.
pdr@chromium.org [Mon, 11 Aug 2014 21:06:46 +0000 (21:06 +0000)]
Refactor Slice construction callsites to pass in args and duration.

This patch refactors Slice construction sites to pass in args and
duration parameters. This simplifies two AsyncSlice construction sites.
A more general solution of passing in startThread, endThread, and
sliceId is not possible because we depend on a common signature for
creating Slices (see SliceGroup::beginSlice). Adding optional arguments
to AsyncSlice is brittle because it tightly couples AsyncSlice and Slice.

R=nduca@chromium.org, nduca

Review URL: https://codereview.appspot.com/122320043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1453 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoFixed tab_view corner case issues.
cvicentiu@chromium.org [Mon, 11 Aug 2014 14:24:45 +0000 (14:24 +0000)]
Fixed tab_view corner case issues.

Due to the asyncronous execution of the childrenUpdated_ call,
it is possible to have the selected property of the light-dom children
modified, before actually registering the child.

This patch fixes this problem.

Also, the clearSelectedTab_ was not actually clearing the selectedTab_
variable correctly, leading to a tab button staying selected.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/126850043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1452 0e6d7f2b-9903-5b78-7403-59d27f066143

10 days agoFix a trivial spelling mistake: registerd -> registered
pdr@chromium.org [Mon, 11 Aug 2014 04:12:38 +0000 (04:12 +0000)]
Fix a trivial spelling mistake: registerd -> registered

This patch fixes a trivial spelling mistake. It is interesting to track how
this line propagated through the codebase through copy, paste, and pdr.

TBR=nduca

Review URL: https://codereview.appspot.com/121490043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1451 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoUpdated instantiate template to work with polymer.
cvicentiu@chromium.org [Fri, 8 Aug 2014 09:07:04 +0000 (09:07 +0000)]
Updated instantiate template to work with polymer.

R=dsinclair@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/122080043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1450 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoShow memory usage information in frame viewer
nduca@chromium.org [Thu, 7 Aug 2014 09:25:51 +0000 (09:25 +0000)]
Show memory usage information in frame viewer

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1449 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoAdd a header to quad stack view.
nduca@chromium.org [Thu, 7 Aug 2014 09:25:47 +0000 (09:25 +0000)]
Add a header to quad stack view.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1448 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoInline quad_stack_view.css to the html file
nduca@chromium.org [Thu, 7 Aug 2014 09:25:41 +0000 (09:25 +0000)]
Inline quad_stack_view.css to the html file

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1447 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoProperly handle inlinesheets that have urls()
nduca@chromium.org [Thu, 7 Aug 2014 09:25:33 +0000 (09:25 +0000)]
Properly handle inlinesheets that have urls()

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1446 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoFix wrong usage of Promise that cause chrome to throw exception on remote tracing...
chrishenry@google.com [Wed, 6 Aug 2014 23:16:53 +0000 (23:16 +0000)]
Fix wrong usage of Promise that cause chrome to throw exception on remote tracing and not show any trace.

Fixed crbug.com/401268.

R=pdr@chromium.org

Review URL: https://codereview.appspot.com/125780043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1445 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoFixed broken update_gyp_and_gn.py
gholap@chromium.org [Wed, 6 Aug 2014 22:19:50 +0000 (22:19 +0000)]
Fixed broken update_gyp_and_gn.py

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/118700044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1444 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoFixed typos
cvicentiu@chromium.org [Tue, 5 Aug 2014 16:27:11 +0000 (16:27 +0000)]
Fixed typos

According to last comments on issue:
https://codereview.appspot.com/118980043

TBR=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/115650043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1443 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoAdded tab view module
cvicentiu@chromium.org [Tue, 5 Aug 2014 15:46:00 +0000 (15:46 +0000)]
Added tab view module

This module represents the basis for the refactoring to follow, as
discussed in the design doc[1]. This module aims to replace the AnalysisResults
module and allow for easier extension of future analysis code.

[1] https://docs.google.com/a/chromium.org/document/d/10whS9zlRdV8ici5xrFWJJd4dwEa7o7TKGRkUXUDCfkY

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/118980043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1442 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoAdjust timeline input events to be positioned relative to the canvas
pdr@chromium.org [Tue, 5 Aug 2014 05:06:50 +0000 (05:06 +0000)]
Adjust timeline input events to be positioned relative to the canvas

This patch changes how input events are adjusted to take into account
additional positioning on the timeline canvas itself. For example, if
the timeline view has margin-left, all timeline selections
would be incorrectly offset.

With this patch, a margin can be put on the timeline view and both
selection and the timing tool work properly.

Additionally, an import has been added to the timing_tool_test so
it can be run standalone. This is unrelated to this patch.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/120720044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1441 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoUpdate record category presets
pdr@chromium.org [Sat, 2 Aug 2014 00:53:55 +0000 (00:53 +0000)]
Update record category presets

This patch has 4 updates to the record category presets:
1) browser has been dropped from the Web Developer preset.
2) "Graphics and rendering" has been simplified to just "Rendering"
3) Graphics, rendering, and rasterization has been renamed "Frame Viewer"
4) A new category has been added for fancy web devs: "Javascript and rendering"

TBR=nduca

Review URL: https://codereview.appspot.com/118500044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1440 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoCorrect variable name typo while accessing TimelineViewport object from TimelineTrack...
r.kasibhatla@samsung.com [Fri, 1 Aug 2014 05:07:57 +0000 (05:07 +0000)]
Correct variable name typo while accessing TimelineViewport object from TimelineTrackView object.

TimelineViewport object is stored as viewport_ in TimelineTrackView class.
In timeline_track_view.html it is referred as this.viewport_
in some places and in some places as this.viewport.

Changed all instances to this.viewport_.

BUG=None
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/120380043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1435 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoHandle still-alive module test suite slightly better
nduca@chromium.org [Thu, 31 Jul 2014 09:28:00 +0000 (09:28 +0000)]
Handle still-alive module test suite slightly better

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1434 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoFix lingering fulfill call left over from promises conversion
nduca@chromium.org [Thu, 31 Jul 2014 09:27:55 +0000 (09:27 +0000)]
Fix lingering fulfill call left over from promises conversion

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1433 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRemove a spurious scrollbar on the new record dialog ui
pdr@chromium.org [Wed, 30 Jul 2014 23:39:34 +0000 (23:39 +0000)]
Remove a spurious scrollbar on the new record dialog ui

I primarily use OSX which has overlay scrollbars and didn't notice that
the new record dialog has an ugly scrollbar on linux. This patch
removes it.

R=nduca,chrishtr
TBR=nduca

Review URL: https://codereview.appspot.com/119360045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1432 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoQuery the document for the template, not the head.
nduca@chromium.org [Wed, 30 Jul 2014 07:39:10 +0000 (07:39 +0000)]
Query the document for the template, not the head.

There is inconsistency in behavior of where templates end up
in compiled vs uncompiled code. So, query the document instead.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1431 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRemove tvcm.testSuite 80col trick, no longer needed
nduca@chromium.org [Wed, 30 Jul 2014 07:24:08 +0000 (07:24 +0000)]
Remove tvcm.testSuite 80col trick, no longer needed

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1430 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoAdd tvcm.unittest.resetFunctions to break dependency of tvcm.unittest on settings...
nduca@chromium.org [Wed, 30 Jul 2014 07:24:02 +0000 (07:24 +0000)]
Add tvcm.unittest.resetFunctions to break dependency of tvcm.unittest on settings and key event manager

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1429 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRevert r1336: Add thread-level highlight instant events
pdr@chromium.org [Wed, 30 Jul 2014 02:55:58 +0000 (02:55 +0000)]
Revert r1336: Add thread-level highlight instant events

This patch reverts r1336[1] which added thread-level highlight instant
events. Due to the idle time on the main thread, we will need to use
an async-based approach for frames.

The original author should have listened to dsinclair from the get-go!

[1] https://code.google.com/p/trace-viewer/source/detail?r=1336

R=dsinclair@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/121810043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1428 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoAdded script to automatically update gn and gyp files based on all the files about_tr...
gholap@chromium.org [Tue, 29 Jul 2014 23:27:07 +0000 (23:27 +0000)]
Added script to automatically update gn and gyp files based on all the files about_tracing depends on.

Usage: trace_viewer/build/update_gyp_and_gn

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/113640044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1427 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoUse GetAllDependentFilenamesRecursive for CheckCommon
nduca@chromium.org [Tue, 29 Jul 2014 21:21:57 +0000 (21:21 +0000)]
Use GetAllDependentFilenamesRecursive for CheckCommon

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1426 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoAdd GetAllDependentFilenamesRecursive to Module
nduca@chromium.org [Tue, 29 Jul 2014 21:09:54 +0000 (21:09 +0000)]
Add GetAllDependentFilenamesRecursive to Module

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1425 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoTrivial: fix spelling mistake Proise->Promise
pdr@chromium.org [Tue, 29 Jul 2014 05:16:12 +0000 (05:16 +0000)]
Trivial: fix spelling mistake Proise->Promise

TBR=nduca

Review URL: https://codereview.appspot.com/121820043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1424 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRemove Promises polyfill and update callsites
nduca@chromium.org [Mon, 28 Jul 2014 08:51:28 +0000 (08:51 +0000)]
Remove Promises polyfill and update callsites

trace-viewer was using an ancient Promise polyfill. This updates
to ES6 promises, which involves a few tweaks:
- resolver -> resolve, reject
- fulfill -> resolve
- Promise.any -> Promise.race

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1423 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRemove tvcm/polymer.html: content should include this manually
nduca@chromium.org [Mon, 28 Jul 2014 08:16:21 +0000 (08:16 +0000)]
Remove tvcm/polymer.html: content should include this manually

In preparation for splitting tvcm into pieces, this patch makes
the inclusion of tvcm/polymer.html something up to the toplevel
file building up the final reuslt. This will let the baking parts
of tvcm become py-vulcanize, leaving behind helper functions and a
unit test harness.

This doesn't quite go all the way: the current handling of <script src=> causes
scripts to get processed out of order relative to imports. This makes it
impossible for the generators to put the polymer & platform files before the
imports. The short term fix for this is to make the actual js generator force
include the two raw files in question. A followup patch can clean this up.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1422 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRemove vestages of old requireTemplate system
nduca@chromium.org [Mon, 28 Jul 2014 06:30:32 +0000 (06:30 +0000)]
Remove vestages of old requireTemplate system

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1421 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRemove last vestiges of DEPS
nduca@chromium.org [Mon, 28 Jul 2014 06:30:29 +0000 (06:30 +0000)]
Remove last vestiges of DEPS

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1420 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRemove js_module
nduca@chromium.org [Mon, 28 Jul 2014 06:30:22 +0000 (06:30 +0000)]
Remove js_module

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1419 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoReland Polymerize find-control.
nduca@chromium.org [Mon, 28 Jul 2014 04:54:42 +0000 (04:54 +0000)]
Reland Polymerize find-control.

Was originally landed in r1391, then reverted in r1407. Things seem
more stable now, so trying again.

TBR=dsinclair

Review URL: https://codereview.appspot.com/113580043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1418 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoInsert polymer element names into JS when generating CSP-compliant JS
nduca@chromium.org [Mon, 28 Jul 2014 04:49:25 +0000 (04:49 +0000)]
Insert polymer element names into JS when generating CSP-compliant JS

The Polymer function has a tricky defaulting behavior. When you don't pass the
element name to the function, it looks up the calling script element's parent
hierarchy looking for a <polymer-element> tag and then uses that.

When you flatten HTML with a csp policy, script gets moved outside the HTML.
Given html liket his:
  <polymer-element name="x">
   <script>
    Polyer({})
   </script>
  </polymer-element>

The JS we need to generate is this:
   Polymer('x', {})
Note how 'x' was inserted.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1417 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoMake inline scripts into objects instead of raw strings
nduca@chromium.org [Mon, 28 Jul 2014 04:49:19 +0000 (04:49 +0000)]
Make inline scripts into objects instead of raw strings

Flattening inline script tags for polymer requires that we convert
the js portion of this:
  <polymer-element name="x">
   <script>
    Polyer({})
   </script>
  </polymer-element>
into:
   Polymer('x', {})

This patch lands objects for inline scripts and bookkeeping of the open script
tags so that in folowup patches, the actual script conversion can be done.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1416 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoFixup comment
nduca@chromium.org [Mon, 28 Jul 2014 04:49:14 +0000 (04:49 +0000)]
Fixup comment

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1415 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoIf an html module references polymer, ensure it imports tvcm.polymer
nduca@chromium.org [Mon, 28 Jul 2014 04:49:10 +0000 (04:49 +0000)]
If an html module references polymer, ensure it imports tvcm.polymer

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1414 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRemove TVCM deps and control code generation
nduca@chromium.org [Mon, 28 Jul 2014 04:49:05 +0000 (04:49 +0000)]
Remove TVCM deps and control code generation

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1413 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoDistinguish between browser failure and suite failure
nduca@chromium.org [Mon, 28 Jul 2014 00:35:56 +0000 (00:35 +0000)]
Distinguish between browser failure and suite failure

Module test cases don't start a browser, rather they rely on their parent test
case [ModuleTestSuite] to start the browser for them. When the parent suite is
running, the global _currently_active_module_test_suite is set, and the
individual cases pull their browser from there.

However, when the browser couldn't be started:
1. the error that prevented it from starting wasn't dumped, and
2. the suite wouldn't set the global, so then the module test cases would run
and the error message produced would imply that the ModuleTestSuite wasn't
working correctly.

This patch changes things to always set the global variable, even on browser
creation failure. Then, the test case can distinguish between the suite being
on versus no browser having been creation. This makes the error messages much
clearer.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1412 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRevert "Correct variable name typo while accessing TimelineViewport object from Timel...
nduca@chromium.org [Fri, 25 Jul 2014 17:17:42 +0000 (17:17 +0000)]
Revert "Correct variable name typo while accessing TimelineViewport object from TimelineTrackView object."

This reverts commit bc297618ab340ca6f4234a58828f7350e6c8e5bd.

Comments on https://codereview.appspot.com/118960043/#msg7

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1411 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoUse unix style relative path on raw scripts
nduca@chromium.org [Thu, 24 Jul 2014 17:21:29 +0000 (17:21 +0000)]
Use unix style relative path on raw scripts

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1410 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoAdd debugging to chase down windows fail
nduca@chromium.org [Thu, 24 Jul 2014 17:21:25 +0000 (17:21 +0000)]
Add debugging to chase down windows fail

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1409 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRemove -container parts of profiling_view
nduca@chromium.org [Thu, 24 Jul 2014 16:39:28 +0000 (16:39 +0000)]
Remove -container parts of profiling_view

This is partly because the container is unneeded, afaict. But,
more importantly, the styling is broken with this: the x-profiling-view-container is not stretching to fill x-profiling-view, so in about:tracing,
the UI doesn't fill the screen properly.

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/112660043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1408 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRevert "Polymerize find-control."
nduca@chromium.org [Thu, 24 Jul 2014 16:38:43 +0000 (16:38 +0000)]
Revert "Polymerize find-control."

This reverts polymerizing for now. The polymer.min.js is throwing
an exception when compiled into about:tracing, which blocks us
from doing a deps roll. We can re-land when we have time to debug.

TBR=dsinclair
BUG=574

Review URL: https://codereview.appspot.com/111660043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1407 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoCorrect variable name typo while accessing TimelineViewport object from TimelineTrack...
r.kasibhatla@samsung.com [Thu, 24 Jul 2014 12:16:02 +0000 (12:16 +0000)]
Correct variable name typo while accessing TimelineViewport object from TimelineTrackView object.

TimelineViewport object is stored as viewport_ in TimelineTrackView class.
In timeline_track_view.html it is referred as this.viewport_
in some places and in some places as this.viewport.

Changed all instances to this.viewport.

BUG=None
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/118960043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1406 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoClean up project path handling
nduca@chromium.org [Thu, 24 Jul 2014 08:37:51 +0000 (08:37 +0000)]
Clean up project path handling

Projects used to get their paths via constructor.

This made subclassing projects really crazy, because the subclassee
had to handle both adding its own paths plus maybe optional additional
paths passed in on the constructor. This was fragile in practice.

This just makes the paths mutable, and adds the right notification handling
so that if you do mutate the paths, the base project finds out.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1405 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoRemove support for tvcm.require inside inline scripts
nduca@chromium.org [Thu, 24 Jul 2014 07:34:48 +0000 (07:34 +0000)]
Remove support for tvcm.require inside inline scripts

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1404 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoForgot to remove validation code for old style testSuite
nduca@chromium.org [Thu, 24 Jul 2014 07:34:43 +0000 (07:34 +0000)]
Forgot to remove validation code for old style testSuite

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1403 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoMake testSuite take just the constructor
nduca@chromium.org [Thu, 24 Jul 2014 07:24:14 +0000 (07:24 +0000)]
Make testSuite take just the constructor

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1402 0e6d7f2b-9903-5b78-7403-59d27f066143