external/trace-viewer.git
2 hours agoCorrect variable name typo while accessing TimelineViewport object from TimelineTrack... master
r.kasibhatla@samsung.com [Thu, 24 Jul 2014 12:16:02 +0000 (12:16 +0000)]
Correct variable name typo while accessing TimelineViewport object from TimelineTrackView object.

TimelineViewport object is stored as viewport_ in TimelineTrackView class.
In timeline_track_view.html it is referred as this.viewport_
in some places and in some places as this.viewport.

Changed all instances to this.viewport.

BUG=None
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/118960043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1406 0e6d7f2b-9903-5b78-7403-59d27f066143

6 hours agoClean up project path handling
nduca@chromium.org [Thu, 24 Jul 2014 08:37:51 +0000 (08:37 +0000)]
Clean up project path handling

Projects used to get their paths via constructor.

This made subclassing projects really crazy, because the subclassee
had to handle both adding its own paths plus maybe optional additional
paths passed in on the constructor. This was fragile in practice.

This just makes the paths mutable, and adds the right notification handling
so that if you do mutate the paths, the base project finds out.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1405 0e6d7f2b-9903-5b78-7403-59d27f066143

7 hours agoRemove support for tvcm.require inside inline scripts
nduca@chromium.org [Thu, 24 Jul 2014 07:34:48 +0000 (07:34 +0000)]
Remove support for tvcm.require inside inline scripts

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1404 0e6d7f2b-9903-5b78-7403-59d27f066143

7 hours agoForgot to remove validation code for old style testSuite
nduca@chromium.org [Thu, 24 Jul 2014 07:34:43 +0000 (07:34 +0000)]
Forgot to remove validation code for old style testSuite

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1403 0e6d7f2b-9903-5b78-7403-59d27f066143

7 hours agoMake testSuite take just the constructor
nduca@chromium.org [Thu, 24 Jul 2014 07:24:14 +0000 (07:24 +0000)]
Make testSuite take just the constructor

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1402 0e6d7f2b-9903-5b78-7403-59d27f066143

7 hours agoRemove testSuite name argument from testSuite call sites
nduca@chromium.org [Thu, 24 Jul 2014 07:23:23 +0000 (07:23 +0000)]
Remove testSuite name argument from testSuite call sites

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1401 0e6d7f2b-9903-5b78-7403-59d27f066143

7 hours agoAllow testSuite name to be optional
nduca@chromium.org [Thu, 24 Jul 2014 07:23:13 +0000 (07:23 +0000)]
Allow testSuite name to be optional

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1400 0e6d7f2b-9903-5b78-7403-59d27f066143

7 hours agoPlace css imports inline where they are listed, instead of all together.
nduca@chromium.org [Thu, 24 Jul 2014 06:38:31 +0000 (06:38 +0000)]
Place css imports inline where they are listed, instead of all together.

The behavior of this was surprising and inconsistent without this change:
<style>a</style>
<link=style b.css>

This would show up in generated html as b, then a.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1399 0e6d7f2b-9903-5b78-7403-59d27f066143

9 hours agoStop fetching deps.js and remove dev_server support
nduca@chromium.org [Thu, 24 Jul 2014 05:12:54 +0000 (05:12 +0000)]
Stop fetching deps.js and remove dev_server support

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1398 0e6d7f2b-9903-5b78-7403-59d27f066143

9 hours agoRemove requireStylesheet,RawScript and Template
nduca@chromium.org [Thu, 24 Jul 2014 05:12:49 +0000 (05:12 +0000)]
Remove requireStylesheet,RawScript and Template

This removes the tvcm.html calls for the remaining old-style
loader system.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1397 0e6d7f2b-9903-5b78-7403-59d27f066143

9 hours agoAdd missing dependency
nduca@chromium.org [Thu, 24 Jul 2014 05:12:45 +0000 (05:12 +0000)]
Add missing dependency

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1396 0e6d7f2b-9903-5b78-7403-59d27f066143

9 hours agoRemove tvcm.require
nduca@chromium.org [Thu, 24 Jul 2014 05:12:40 +0000 (05:12 +0000)]
Remove tvcm.require

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1395 0e6d7f2b-9903-5b78-7403-59d27f066143

9 hours agoMove suite_loader to use imports
nduca@chromium.org [Thu, 24 Jul 2014 05:12:08 +0000 (05:12 +0000)]
Move suite_loader to use imports

SuiteLoader was the remaining use of tvcm.require. This moves
suite loader to use html imports' load events, allowing tvcm.require to be
removed.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1394 0e6d7f2b-9903-5b78-7403-59d27f066143

17 hours agoBegin removing support for JSModules
nduca@chromium.org [Wed, 23 Jul 2014 21:24:52 +0000 (21:24 +0000)]
Begin removing support for JSModules

This disables loading of JSModules and updates unit tests that still are valid
to use html modules.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1393 0e6d7f2b-9903-5b78-7403-59d27f066143

18 hours agoRemove __init__ support
nduca@chromium.org [Wed, 23 Jul 2014 19:41:20 +0000 (19:41 +0000)]
Remove __init__ support

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1392 0e6d7f2b-9903-5b78-7403-59d27f066143

44 hours agoPolymerize find-control.
dsinclair@chromium.org [Tue, 22 Jul 2014 17:46:49 +0000 (17:46 +0000)]
Polymerize find-control.

This converts the HTML module of find-control to be a Polymer Element.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/116130043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1391 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoAdd jszip to build files
dsinclair@chromium.org [Tue, 22 Jul 2014 14:36:11 +0000 (14:36 +0000)]
Add jszip to build files

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/116120043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1390 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoRemove accidental debugger call
nduca@chromium.org [Tue, 22 Jul 2014 14:18:42 +0000 (14:18 +0000)]
Remove accidental debugger call

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1389 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoEliminate the remainder of the tvcm.require calls
nduca@chromium.org [Tue, 22 Jul 2014 14:14:01 +0000 (14:14 +0000)]
Eliminate the remainder of the tvcm.require calls

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1388 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoFix skp listing
nduca@chromium.org [Tue, 22 Jul 2014 14:13:53 +0000 (14:13 +0000)]
Fix skp listing

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1387 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoMove tvcm/__init__.js to tvcm.html AND make it a dependency
nduca@chromium.org [Tue, 22 Jul 2014 14:13:26 +0000 (14:13 +0000)]
Move tvcm/__init__.js to tvcm.html AND make it a dependency

In the old system, tvcm/__init__.js was brought in manually by
the bootstrap code. This isn't very component like. In this patch,
HTMLModule is updated to complain if tvcm is not somehow referenced by
a file containing tvcm.exportTo. This allows all bootstrap lines of
tvcm/__init__.js to be removed.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1386 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoRemove implicit dependency on polymer in html modules
nduca@chromium.org [Tue, 22 Jul 2014 14:13:16 +0000 (14:13 +0000)]
Remove implicit dependency on polymer in html modules

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1385 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoMove tvcm/ to imports
nduca@chromium.org [Tue, 22 Jul 2014 08:57:52 +0000 (08:57 +0000)]
Move tvcm/ to imports

All but __init__.js has gone. That one is a bit magical.

TBR=dsinclair

Review URL: https://codereview.appspot.com/114200043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1384 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoChange how html files are decided to be modules
nduca@chromium.org [Tue, 22 Jul 2014 07:58:17 +0000 (07:58 +0000)]
Change how html files are decided to be modules

The first version of IsFilenameAModule used the presence of certain magical
tags in the filename as a signal that an html file was a tvcm module versus a
plain-old-html file.

The downside was that if a module was written without the proper tricks in it,
then it'd not be recognized. So, if you typed <!DOCTYPE HTML> instead of
<!DOCTYPE html> your module wouldn't be includable. And, other silly things
like that. This was really fragile.

This replaces the heuristics with a blacklist. All html files are assumed
to be modules, but then they can be added to the project blacklist for
non inclusion.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1383 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoSimple protection against improper script tag escaping
nduca@chromium.org [Tue, 22 Jul 2014 01:22:49 +0000 (01:22 +0000)]
Simple protection against improper script tag escaping

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1382 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoTry to detect malformed html
nduca@chromium.org [Tue, 22 Jul 2014 01:17:41 +0000 (01:17 +0000)]
Try to detect malformed html

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/111450043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1381 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoFix trace2html and generate_about_tracing_contents
nduca@chromium.org [Mon, 21 Jul 2014 23:17:25 +0000 (23:17 +0000)]
Fix trace2html and generate_about_tracing_contents

./run_tests caught this, so just fixes required.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1380 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoFix missing end token on zip_importer.html
nduca@chromium.org [Mon, 21 Jul 2014 23:07:30 +0000 (23:07 +0000)]
Fix missing end token on zip_importer.html

TBR=dsinclair

Review URL: https://codereview.appspot.com/114170043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1379 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoConvert tracks/ to HTML modules.
dsinclair@chromium.org [Mon, 21 Jul 2014 14:46:23 +0000 (14:46 +0000)]
Convert tracks/ to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/112520044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1378 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoConvert trace_model/ to HTML modules.
dsinclair@chromium.org [Mon, 21 Jul 2014 14:07:05 +0000 (14:07 +0000)]
Convert trace_model/ to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/115840047

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1377 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoConvert importers to HTML modules
dsinclair@chromium.org [Sun, 20 Jul 2014 19:30:40 +0000 (19:30 +0000)]
Convert importers to HTML modules

Note, I had to space out the <script> tags in the trace2html test to make the
parser happy that there was no use strict. This means I had to change the
importer slightly to allow the spaced syntax.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/116050044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1376 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoCommit Linux Perf importer to HTML modules
dsinclair@chromium.org [Sun, 20 Jul 2014 19:10:55 +0000 (19:10 +0000)]
Commit Linux Perf importer to HTML modules

Note, I had to remove the canImportSystraceFile test as, for some reason I
was unable to determine, having that test included causes the whole
linux_perf_importer_test module to disappear.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/116970043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1375 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoConvert ETW importer to HTML modules.
dsinclair@chromium.org [Sun, 20 Jul 2014 17:52:15 +0000 (17:52 +0000)]
Convert ETW importer to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/114110043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1374 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoConvert v8 to HTML imports.
dsinclair@chromium.org [Sun, 20 Jul 2014 15:13:26 +0000 (15:13 +0000)]
Convert v8 to HTML imports.

TBR=ndua@chromium.org

Review URL: https://codereview.appspot.com/115140043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1373 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoConvert side_panel directory to HTML modules.
dsinclair@chromium.org [Sun, 20 Jul 2014 15:00:01 +0000 (15:00 +0000)]
Convert side_panel directory to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/115130043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1372 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoConvert tracing files to HTML modules.
dsinclair@chromium.org [Sat, 19 Jul 2014 14:09:53 +0000 (14:09 +0000)]
Convert tracing files to HTML modules.

TBR=nduca@chomium.org

Review URL: https://codereview.appspot.com/114100043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1371 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoConvert analysis directory to HTML modules.
dsinclair@chromium.org [Sat, 19 Jul 2014 13:22:00 +0000 (13:22 +0000)]
Convert analysis directory to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/119900043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1370 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoConvert about_tracing to HTML modules.
dsinclair@chromium.org [Sat, 19 Jul 2014 12:44:45 +0000 (12:44 +0000)]
Convert about_tracing to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/114090044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1369 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoConvert cc directory to HTML modules.
dsinclair@chromium.org [Sat, 19 Jul 2014 04:40:09 +0000 (04:40 +0000)]
Convert cc directory to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/113340043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1367 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoConvert tcmalloc directory to a HTML module.
dsinclair@chromium.org [Sat, 19 Jul 2014 03:56:48 +0000 (03:56 +0000)]
Convert tcmalloc directory to a HTML module.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/119880044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1366 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoFix ordering in trace_viewer.html
dsinclair@chromium.org [Sat, 19 Jul 2014 03:54:24 +0000 (03:54 +0000)]
Fix ordering in trace_viewer.html

If the gpu import is put up under the script include of __init__.js there
are console exceptions. Need to load the other scripts first I believe.

We can move them all up when the conversion is complete.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/115080043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1365 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoConvert system_stats directory to HTML modules.
dsinclair@chromium.org [Sat, 19 Jul 2014 00:39:31 +0000 (00:39 +0000)]
Convert system_stats directory to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/119850043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1364 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoConvert gpu directory to HTML modules
dsinclair@chromium.org [Sat, 19 Jul 2014 00:27:55 +0000 (00:27 +0000)]
Convert gpu directory to HTML modules

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/111380044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1363 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoConvert find control and find controller to HTML module.
dsinclair@chromium.org [Fri, 18 Jul 2014 20:46:45 +0000 (20:46 +0000)]
Convert find control and find controller to HTML module.

This moves the find control and find controller from a JS module to
an HTML module.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/119840043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1362 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoExtend HTML parser support.
dsinclair@chromium.org [Fri, 18 Jul 2014 20:35:14 +0000 (20:35 +0000)]
Extend HTML parser support.

Handle self-closing tags, entity references and character references.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/112450043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1361 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoFix import and stylesheet stripping tests
nduca@chromium.org [Fri, 18 Jul 2014 20:11:23 +0000 (20:11 +0000)]
Fix import and stylesheet stripping tests

R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/115050044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1360 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoMake tvcm.quad an HTML module
nduca@chromium.org [Fri, 18 Jul 2014 20:02:19 +0000 (20:02 +0000)]
Make tvcm.quad an HTML module

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/115050043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1359 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoDon't include _test.html files in gyp/gn checks
nduca@chromium.org [Fri, 18 Jul 2014 19:31:26 +0000 (19:31 +0000)]
Don't include _test.html files in gyp/gn checks

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1358 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoMake requireRawScript and requireStylesheet executing an actual failure
nduca@chromium.org [Fri, 18 Jul 2014 19:29:01 +0000 (19:29 +0000)]
Make requireRawScript and requireStylesheet executing an actual failure

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1357 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoMerge js and html files together so renames are easier.
nduca@chromium.org [Fri, 18 Jul 2014 19:25:14 +0000 (19:25 +0000)]
Merge js and html files together so renames are easier.

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/114060045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1356 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoAllow instantiateTemplate to use specific document.
dsinclair@chromium.org [Fri, 18 Jul 2014 19:23:04 +0000 (19:23 +0000)]
Allow instantiateTemplate to use specific document.

This will allow us to pass in the import document when we start creating
HTML imported modules.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/117950043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1355 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoMake html module and test discovery work
nduca@chromium.org [Fri, 18 Jul 2014 19:08:41 +0000 (19:08 +0000)]
Make html module and test discovery work

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/111370043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1354 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoCorrect pointer to map file.
dsinclair@chromium.org [Fri, 18 Jul 2014 19:00:34 +0000 (19:00 +0000)]
Correct pointer to map file.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/108710047

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1353 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoUpgrade polymer, platform and add map files.
dsinclair@chromium.org [Fri, 18 Jul 2014 18:46:21 +0000 (18:46 +0000)]
Upgrade polymer, platform and add map files.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/111360043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1352 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoCatch socket error on finish
nduca@chromium.org [Fri, 18 Jul 2014 18:27:49 +0000 (18:27 +0000)]
Catch socket error on finish

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/108710045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1351 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoSplit FindControl and FindController.
dsinclair@chromium.org [Fri, 18 Jul 2014 18:25:14 +0000 (18:25 +0000)]
Split FindControl and FindController.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/118890045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1350 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoFix failing testContentsAsHTML
nduca@chromium.org [Fri, 18 Jul 2014 18:23:20 +0000 (18:23 +0000)]
Fix failing testContentsAsHTML

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1349 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoUse html imports for all module loading.
nduca@chromium.org [Fri, 18 Jul 2014 18:13:50 +0000 (18:13 +0000)]
Use html imports for all module loading.

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/119800043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1348 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoRequire chrome 36 or later.
dsinclair@chromium.org [Fri, 18 Jul 2014 18:04:03 +0000 (18:04 +0000)]
Require chrome 36 or later.

We are about to start using HTML imports in the dev and test environments.
This means a version of chrome of M36 or later is required.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/115040044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1347 0e6d7f2b-9903-5b78-7403-59d27f066143

5 days agoFix gl_matrix imports; fix test error
dsinclair@chromium.org [Fri, 18 Jul 2014 17:36:15 +0000 (17:36 +0000)]
Fix gl_matrix imports; fix test error

We should never be importing raw scripts directly. This needs to be handled
by the tvcm module to import those scripts. Otherwise, we can end up with
duplicate script loads and weird behaviour.

Also, fix test exception and message to be clearer.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/111320045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1346 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoMake modules constructable without having real files backing them, for testing.
nduca@chromium.org [Fri, 18 Jul 2014 08:34:42 +0000 (08:34 +0000)]
Make modules constructable without having real files backing them, for testing.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1345 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoAlphabetize imports
nduca@chromium.org [Fri, 18 Jul 2014 08:34:28 +0000 (08:34 +0000)]
Alphabetize imports

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1344 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoTeach tvcm runtime loader about html modules
nduca@chromium.org [Wed, 16 Jul 2014 20:51:08 +0000 (20:51 +0000)]
Teach tvcm runtime loader about html modules

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/114870043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1343 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoFirst implementation of html_module
nduca@chromium.org [Wed, 16 Jul 2014 16:45:37 +0000 (16:45 +0000)]
First implementation of html_module

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/118740043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1342 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoGenerateJS is still needed
nduca@chromium.org [Wed, 16 Jul 2014 05:04:18 +0000 (05:04 +0000)]
GenerateJS is still needed

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1341 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoBasic movement of generate code into module plus basic html module.
nduca@chromium.org [Wed, 16 Jul 2014 02:45:43 +0000 (02:45 +0000)]
Basic movement of generate code into module plus basic html module.

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/111220043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1340 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoThis adds a bit more parsing logic in preparation for html modules
nduca@chromium.org [Wed, 16 Jul 2014 02:01:29 +0000 (02:01 +0000)]
This adds a bit more parsing logic in preparation for html modules

R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/110970043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1339 0e6d7f2b-9903-5b78-7403-59d27f066143

10 days agoFixed lthi_cats_perf_test
cvicentiu@chromium.org [Mon, 14 Jul 2014 10:48:21 +0000 (10:48 +0000)]
Fixed lthi_cats_perf_test

The bug is caused by a wrongly specified file url to import.

Refactored the code a bit to not have url strings written twice in the code.
The problem was that we are looking for a lthi_cats.json file, while the
repository has a lthi_cats.json.gz file. Also in order to parse the gzip file,
we need to get both the gzip importer as well as the trace_event_importer.

BUG=571
R=skyostil@chromium.org

Review URL: https://codereview.appspot.com/111130044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1338 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoShow the preset trace categories
pdr@chromium.org [Fri, 11 Jul 2014 23:29:10 +0000 (23:29 +0000)]
Show the preset trace categories

Existing tracers are unsure what categories are used for each of the
presets. This patch shows the categories behind each preset in a
light and small font. I think this is a nice compromise between our
existing trace experts and new users. A preview is at
http://pr.gg/tracecats.png

The complexity in this patch is just to keep the preset <-> manual
transition looking smooth.

One unrelated change is in this patch: instead of transitioning to
opacity:1, we stop at opacity:0.99 to prevent layer churn.

BUG=
R=dsinclair@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/112140043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1337 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoAdd thread-level highlight instant events
pdr@chromium.org [Fri, 11 Jul 2014 23:10:12 +0000 (23:10 +0000)]
Add thread-level highlight instant events

This patch adds a new thread-level instant event for highlights. A
highlight event marks the transition between two highlight styles and
is drawn as a slightly dark background. Highlight events are selectable
to make time comparisons easy.

A followup patch will explore adding text describing the frame number
using metadata.

A screenshot is available at http://pr.gg/newframetimes.png

BUG=
R=dsinclair@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/111940043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1336 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoMove all side panels.
dsinclair@chromium.org [Fri, 11 Jul 2014 19:20:30 +0000 (19:20 +0000)]
Move all side panels.

This CL moves the side panels into the trace_viewer/tracing/side_panel
directory and updates the namespace to be tracing.side_panel.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/114750043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1335 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoShow sunburst view in bottom analysis panel for samples selection.
gholap@chromium.org [Fri, 11 Jul 2014 18:42:47 +0000 (18:42 +0000)]
Show sunburst view in bottom analysis panel for samples selection.

R=fmeawad@chromium.org

Review URL: https://codereview.appspot.com/109690043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1334 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoSampling summary side panel uses selection instead of model now.
gholap@chromium.org [Thu, 10 Jul 2014 21:59:47 +0000 (21:59 +0000)]
Sampling summary side panel uses selection instead of model now.

R=vmiura@chromium.org

Review URL: https://codereview.appspot.com/112110043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1333 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoFix exception printing in task.js
pdr@chromium.org [Thu, 10 Jul 2014 19:45:57 +0000 (19:45 +0000)]
Fix exception printing in task.js

This patch fixes exception stack printing in task.js's Task.RunWhenIdle.

A before/after comparison is available at http://pr.gg/tracingstacktrace.png

BUG=
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/110420045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1332 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoCleanup old examples.
dsinclair@chromium.org [Thu, 10 Jul 2014 18:43:43 +0000 (18:43 +0000)]
Cleanup old examples.

These are old and out dated. Removing.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/106630043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1331 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoKill the standalone timeline view generation script.
dsinclair@chromium.org [Thu, 10 Jul 2014 18:35:51 +0000 (18:35 +0000)]
Kill the standalone timeline view generation script.

This script is the anomoly in how we create our output. All other scripts
generate HTML, JS and CSS. This script generates JS and CSS.

If the standalone functionality is required, we should create something that
will output the correct HTML, JS and CSS.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/113740043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1330 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoAdd selection support for input latency side panel
miletus@chromium.org [Thu, 10 Jul 2014 18:16:02 +0000 (18:16 +0000)]
Add selection support for input latency side panel

1. When there is mouse selection in the input latency side panel,
update the brushed area and send selection change event to timeline
view

2. Listening to selection change in timeline view and update the
brushed area accordingly in the input latency side panel.

Screenshot at
https://docs.google.com/a/google.com/file/d/0B8DyRjJYRslBb1dyaEJINVpDZHc/edit?usp=sharing_eil

BUG=373081
TEST=manual test
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/111880044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1329 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoRemove DS_Store file.
dsinclair@chromium.org [Thu, 10 Jul 2014 14:11:17 +0000 (14:11 +0000)]
Remove DS_Store file.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/111040043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1328 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoSamples now have their own track instead of using SliceTrack.
gholap@chromium.org [Wed, 9 Jul 2014 21:41:15 +0000 (21:41 +0000)]
Samples now have their own track instead of using SliceTrack.

R=fmeawad@chromium.org
BUG=https://code.google.com/p/trace-viewer/issues/detail?id=569

Review URL: https://codereview.appspot.com/108500043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1327 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoAdded missing dependency.
gholap@chromium.org [Wed, 9 Jul 2014 21:38:57 +0000 (21:38 +0000)]
Added missing dependency.
  Problem that this fixes:
    /tvcm/tests.html                                     -- all pass.
    /tvcm/tests.html?testFilterString=sampleThreadSlices -- fails!

R=fmeawad@chromium.org

Review URL: https://codereview.appspot.com/110990043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1326 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoFixed a few doc typos.
gholap@chromium.org [Wed, 9 Jul 2014 20:11:07 +0000 (20:11 +0000)]
Fixed a few doc typos.

R=fmeawad@chromium.org

Review URL: https://codereview.appspot.com/109630043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1325 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoMoved Slice specific functionality out of RectTrack into SliceTrack.
gholap@chromium.org [Wed, 9 Jul 2014 18:28:40 +0000 (18:28 +0000)]
Moved Slice specific functionality out of RectTrack into SliceTrack.

BUG=https://code.google.com/p/trace-viewer/issues/detail?id=569
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/106550043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1324 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoPresubmit script makes sure that filenames are sorted in gyp and gn files.
gholap@chromium.org [Wed, 9 Jul 2014 18:24:09 +0000 (18:24 +0000)]
Presubmit script makes sure that filenames are sorted in gyp and gn files.

R=nduca@chromium.org
TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/110430043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1323 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoFixed gzip importer issue with parsing a string style argument
cvicentiu@chromium.org [Wed, 9 Jul 2014 11:21:36 +0000 (11:21 +0000)]
Fixed gzip importer issue with parsing a string style argument

The existing code converted the string to unicode-16 and then evaluated
the string's characters code. This lead to interpreting more than 1
byte of data per character (since unicode has more than one byte per
character). Comparing the resulting numbers lead to errors, because we
wanted to just compare bytes, in order to check for the gzip header.

R=skyostil@chromium.org

Review URL: https://codereview.appspot.com/109560043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1322 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoThread time visualization performance fix
cvicentiu@chromium.org [Wed, 9 Jul 2014 10:57:15 +0000 (10:57 +0000)]
Thread time visualization performance fix

The first part deals with performance considerations regarding thread time
visualization. In order to reduce the performance impact that drawing extra
rectangles implied, the code now takes into account a threshold value. If the
number of pixels available for the two tone slice style, one part transparent
and one solid is below a threshold, we instead only draw the rectangle as
solid.

The second part deals with updating the unit tests to feature a more relevant
trace. The 'huge_trace' has been updated to a more complex trace featuring
slices with the cpuDuration element present. Because of size of the trace, the
file is compressed into a gzip file. The zip file previously added was
featuring folder data which is of no interest, so it has been removed.

BUG=566
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/106450045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1321 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoAdd a sample Windows ETW CSwitch trace.
fdoray@chromium.org [Wed, 9 Jul 2014 00:01:22 +0000 (00:01 +0000)]
Add a sample Windows ETW CSwitch trace.

Add file trace-viewer/test_data/windows_etw_cswitch.json, which contains ETW threads and processes scheduling events.

Depends on https://codereview.appspot.com/105550045/

(3/3)

BUG=
R=etienneb@chromium.org

Review URL: https://codereview.appspot.com/109490043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1320 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoAdd support for context switches to EtwImporter.
fdoray@chromium.org [Tue, 8 Jul 2014 23:55:20 +0000 (23:55 +0000)]
Add support for context switches to EtwImporter.

This CL brings the support for simulating threads/processes scheduling
on multiple CPUs. The corresponding Slices are generated into the TraceModel.

Depends on https://codereview.appspot.com/101700043/

(2/3)

BUG=
R=etienneb@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/105550045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1319 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoLift out CpuState from the Linux Perf importer.
fdoray@chromium.org [Tue, 8 Jul 2014 23:25:08 +0000 (23:25 +0000)]
Lift out CpuState from the Linux Perf importer.

The Cpu state logic could be shared with the ETW importer. This CL moves it from the Linux Perf importer to the trace model.

(1/3)

BUG=
R=etienneb@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/101700043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1318 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoMake slice_track subclass rect_track
nduca@chromium.org [Tue, 8 Jul 2014 21:54:07 +0000 (21:54 +0000)]
Make slice_track subclass rect_track

This allows us to do a followup patch where rect_track
will stop mutating selections directly, but most bits of the code
can still just use a SliceTrack for convenience.

R=gholap@chromium.org
TBR=gholap

Review URL: https://codereview.appspot.com/106530046

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1317 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoFix slices so they render
nduca@chromium.org [Tue, 8 Jul 2014 21:43:56 +0000 (21:43 +0000)]
Fix slices so they render

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1316 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoRenamed SliceTrack to RectTrack
gholap@chromium.org [Tue, 8 Jul 2014 20:58:21 +0000 (20:58 +0000)]
Renamed SliceTrack to RectTrack

BUG=https://code.google.com/p/trace-viewer/issues/detail?id=569
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/109580043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1315 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoDon't try to read from |e.touches| when given a mouse event.
tdresser@chromium.org [Tue, 8 Jul 2014 18:00:41 +0000 (18:00 +0000)]
Don't try to read from |e.touches| when given a mouse event.

https://codereview.appspot.com/106470043/ introduced a bug
where we'd try to read the |touches| of a mouse event, and
the |clientX|, |clientY| of a touch event.

This ensures the event types are handled completely independently.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/109560044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1314 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoTouch driven panning and zooming.
tdresser@chromium.org [Tue, 8 Jul 2014 14:13:30 +0000 (14:13 +0000)]
Touch driven panning and zooming.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/106470043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1313 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoMake generate_about_tracing_contents use generate directly
nduca@chromium.org [Fri, 4 Jul 2014 17:58:18 +0000 (17:58 +0000)]
Make generate_about_tracing_contents use generate directly

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1312 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoAdded thread time visualisation
cvicentiu@chromium.org [Thu, 3 Jul 2014 17:10:39 +0000 (17:10 +0000)]
Added thread time visualisation

Event slices that contain more than just the wall clock (eg. cpu time)
are drawn differently than other slices. The slice is now formed of two
parts.
 * One part represents the percentage of active running time on the
   cpu. This part is drawn like before, only the length is proportional
   to the percentage of cpu active time.
 * The second part represents the percentage of time not spent actually
   executing on the cpu. This part is drawn using two colors. The top
   part is lighter, while the bottom part has the same color as the
   active running time cpu. The colors are controled using the alpha
   parameter.

There is also a test file in the patch.

BUG=566

Design doc:    https://docs.google.com/a/google.com/document/d/1T1UJHIgImSEPSugCt2TFrkNsraBFITPHpYFGDJStePc/edit#

R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/104400043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1311 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoFix systrace import error.
dsinclair@chromium.org [Thu, 3 Jul 2014 14:12:00 +0000 (14:12 +0000)]
Fix systrace import error.

Some of the files produced by systrace seem to have strange \n\ characters
on the end of the lines. This CL updates the importer to strip the extraneous
junk from the end of the line before we try to determine the event type.

R=skyostil@chromium.org

Review URL: https://codereview.appspot.com/111820044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1310 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoFixed sorting of samples in TraceModel.
gholap@chromium.org [Wed, 2 Jul 2014 23:13:02 +0000 (23:13 +0000)]
Fixed sorting of samples in TraceModel.
- Also, added a test (which fails without the fix).

BUG= https://code.google.com/p/trace-viewer/issues/detail?id=568
R=fmeawad@chromium.org

Review URL: https://codereview.appspot.com/109440044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1309 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agosend tracing categories and options on Tracing.start
pdr@chromium.org [Tue, 1 Jul 2014 21:27:03 +0000 (21:27 +0000)]
send tracing categories and options on Tracing.start

BUG=
R=pdr@chromium.org
TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/108210044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1308 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoFixed return value of appendTableCellWithTooltip_.
gholap@chromium.org [Tue, 1 Jul 2014 17:10:15 +0000 (17:10 +0000)]
Fixed return value of appendTableCellWithTooltip_.

R=fmeawad@chromium.org

Review URL: https://codereview.appspot.com/103670046

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1307 0e6d7f2b-9903-5b78-7403-59d27f066143

3 weeks agoFixed the fix for stack frame coloring. (108230045).
gholap@chromium.org [Sat, 28 Jun 2014 00:51:27 +0000 (00:51 +0000)]
Fixed the fix for stack frame coloring. (108230045).

R=humper@google.com

Review URL: https://codereview.appspot.com/101550044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1306 0e6d7f2b-9903-5b78-7403-59d27f066143