external/trace-viewer.git
37 min agoCorrect variable name typo while accessing TimelineViewport object from TimelineTrack... master
r.kasibhatla@samsung.com [Fri, 1 Aug 2014 05:07:57 +0000 (05:07 +0000)]
Correct variable name typo while accessing TimelineViewport object from TimelineTrackView object.

TimelineViewport object is stored as viewport_ in TimelineTrackView class.
In timeline_track_view.html it is referred as this.viewport_
in some places and in some places as this.viewport.

Changed all instances to this.viewport_.

BUG=None
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/120380043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1435 0e6d7f2b-9903-5b78-7403-59d27f066143

20 hours agoHandle still-alive module test suite slightly better
nduca@chromium.org [Thu, 31 Jul 2014 09:28:00 +0000 (09:28 +0000)]
Handle still-alive module test suite slightly better

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1434 0e6d7f2b-9903-5b78-7403-59d27f066143

20 hours agoFix lingering fulfill call left over from promises conversion
nduca@chromium.org [Thu, 31 Jul 2014 09:27:55 +0000 (09:27 +0000)]
Fix lingering fulfill call left over from promises conversion

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1433 0e6d7f2b-9903-5b78-7403-59d27f066143

30 hours agoRemove a spurious scrollbar on the new record dialog ui
pdr@chromium.org [Wed, 30 Jul 2014 23:39:34 +0000 (23:39 +0000)]
Remove a spurious scrollbar on the new record dialog ui

I primarily use OSX which has overlay scrollbars and didn't notice that
the new record dialog has an ugly scrollbar on linux. This patch
removes it.

R=nduca,chrishtr
TBR=nduca

Review URL: https://codereview.appspot.com/119360045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1432 0e6d7f2b-9903-5b78-7403-59d27f066143

46 hours agoQuery the document for the template, not the head.
nduca@chromium.org [Wed, 30 Jul 2014 07:39:10 +0000 (07:39 +0000)]
Query the document for the template, not the head.

There is inconsistency in behavior of where templates end up
in compiled vs uncompiled code. So, query the document instead.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1431 0e6d7f2b-9903-5b78-7403-59d27f066143

46 hours agoRemove tvcm.testSuite 80col trick, no longer needed
nduca@chromium.org [Wed, 30 Jul 2014 07:24:08 +0000 (07:24 +0000)]
Remove tvcm.testSuite 80col trick, no longer needed

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1430 0e6d7f2b-9903-5b78-7403-59d27f066143

46 hours agoAdd tvcm.unittest.resetFunctions to break dependency of tvcm.unittest on settings...
nduca@chromium.org [Wed, 30 Jul 2014 07:24:02 +0000 (07:24 +0000)]
Add tvcm.unittest.resetFunctions to break dependency of tvcm.unittest on settings and key event manager

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1429 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoRevert r1336: Add thread-level highlight instant events
pdr@chromium.org [Wed, 30 Jul 2014 02:55:58 +0000 (02:55 +0000)]
Revert r1336: Add thread-level highlight instant events

This patch reverts r1336[1] which added thread-level highlight instant
events. Due to the idle time on the main thread, we will need to use
an async-based approach for frames.

The original author should have listened to dsinclair from the get-go!

[1] https://code.google.com/p/trace-viewer/source/detail?r=1336

R=dsinclair@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/121810043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1428 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoAdded script to automatically update gn and gyp files based on all the files about_tr...
gholap@chromium.org [Tue, 29 Jul 2014 23:27:07 +0000 (23:27 +0000)]
Added script to automatically update gn and gyp files based on all the files about_tracing depends on.

Usage: trace_viewer/build/update_gyp_and_gn

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/113640044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1427 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoUse GetAllDependentFilenamesRecursive for CheckCommon
nduca@chromium.org [Tue, 29 Jul 2014 21:21:57 +0000 (21:21 +0000)]
Use GetAllDependentFilenamesRecursive for CheckCommon

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1426 0e6d7f2b-9903-5b78-7403-59d27f066143

2 days agoAdd GetAllDependentFilenamesRecursive to Module
nduca@chromium.org [Tue, 29 Jul 2014 21:09:54 +0000 (21:09 +0000)]
Add GetAllDependentFilenamesRecursive to Module

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1425 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoTrivial: fix spelling mistake Proise->Promise
pdr@chromium.org [Tue, 29 Jul 2014 05:16:12 +0000 (05:16 +0000)]
Trivial: fix spelling mistake Proise->Promise

TBR=nduca

Review URL: https://codereview.appspot.com/121820043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1424 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoRemove Promises polyfill and update callsites
nduca@chromium.org [Mon, 28 Jul 2014 08:51:28 +0000 (08:51 +0000)]
Remove Promises polyfill and update callsites

trace-viewer was using an ancient Promise polyfill. This updates
to ES6 promises, which involves a few tweaks:
- resolver -> resolve, reject
- fulfill -> resolve
- Promise.any -> Promise.race

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1423 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoRemove tvcm/polymer.html: content should include this manually
nduca@chromium.org [Mon, 28 Jul 2014 08:16:21 +0000 (08:16 +0000)]
Remove tvcm/polymer.html: content should include this manually

In preparation for splitting tvcm into pieces, this patch makes
the inclusion of tvcm/polymer.html something up to the toplevel
file building up the final reuslt. This will let the baking parts
of tvcm become py-vulcanize, leaving behind helper functions and a
unit test harness.

This doesn't quite go all the way: the current handling of <script src=> causes
scripts to get processed out of order relative to imports. This makes it
impossible for the generators to put the polymer & platform files before the
imports. The short term fix for this is to make the actual js generator force
include the two raw files in question. A followup patch can clean this up.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1422 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoRemove vestages of old requireTemplate system
nduca@chromium.org [Mon, 28 Jul 2014 06:30:32 +0000 (06:30 +0000)]
Remove vestages of old requireTemplate system

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1421 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoRemove last vestiges of DEPS
nduca@chromium.org [Mon, 28 Jul 2014 06:30:29 +0000 (06:30 +0000)]
Remove last vestiges of DEPS

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1420 0e6d7f2b-9903-5b78-7403-59d27f066143

3 days agoRemove js_module
nduca@chromium.org [Mon, 28 Jul 2014 06:30:22 +0000 (06:30 +0000)]
Remove js_module

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1419 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoReland Polymerize find-control.
nduca@chromium.org [Mon, 28 Jul 2014 04:54:42 +0000 (04:54 +0000)]
Reland Polymerize find-control.

Was originally landed in r1391, then reverted in r1407. Things seem
more stable now, so trying again.

TBR=dsinclair

Review URL: https://codereview.appspot.com/113580043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1418 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoInsert polymer element names into JS when generating CSP-compliant JS
nduca@chromium.org [Mon, 28 Jul 2014 04:49:25 +0000 (04:49 +0000)]
Insert polymer element names into JS when generating CSP-compliant JS

The Polymer function has a tricky defaulting behavior. When you don't pass the
element name to the function, it looks up the calling script element's parent
hierarchy looking for a <polymer-element> tag and then uses that.

When you flatten HTML with a csp policy, script gets moved outside the HTML.
Given html liket his:
  <polymer-element name="x">
   <script>
    Polyer({})
   </script>
  </polymer-element>

The JS we need to generate is this:
   Polymer('x', {})
Note how 'x' was inserted.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1417 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoMake inline scripts into objects instead of raw strings
nduca@chromium.org [Mon, 28 Jul 2014 04:49:19 +0000 (04:49 +0000)]
Make inline scripts into objects instead of raw strings

Flattening inline script tags for polymer requires that we convert
the js portion of this:
  <polymer-element name="x">
   <script>
    Polyer({})
   </script>
  </polymer-element>
into:
   Polymer('x', {})

This patch lands objects for inline scripts and bookkeeping of the open script
tags so that in folowup patches, the actual script conversion can be done.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1416 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoFixup comment
nduca@chromium.org [Mon, 28 Jul 2014 04:49:14 +0000 (04:49 +0000)]
Fixup comment

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1415 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoIf an html module references polymer, ensure it imports tvcm.polymer
nduca@chromium.org [Mon, 28 Jul 2014 04:49:10 +0000 (04:49 +0000)]
If an html module references polymer, ensure it imports tvcm.polymer

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1414 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoRemove TVCM deps and control code generation
nduca@chromium.org [Mon, 28 Jul 2014 04:49:05 +0000 (04:49 +0000)]
Remove TVCM deps and control code generation

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1413 0e6d7f2b-9903-5b78-7403-59d27f066143

4 days agoDistinguish between browser failure and suite failure
nduca@chromium.org [Mon, 28 Jul 2014 00:35:56 +0000 (00:35 +0000)]
Distinguish between browser failure and suite failure

Module test cases don't start a browser, rather they rely on their parent test
case [ModuleTestSuite] to start the browser for them. When the parent suite is
running, the global _currently_active_module_test_suite is set, and the
individual cases pull their browser from there.

However, when the browser couldn't be started:
1. the error that prevented it from starting wasn't dumped, and
2. the suite wouldn't set the global, so then the module test cases would run
and the error message produced would imply that the ModuleTestSuite wasn't
working correctly.

This patch changes things to always set the global variable, even on browser
creation failure. Then, the test case can distinguish between the suite being
on versus no browser having been creation. This makes the error messages much
clearer.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1412 0e6d7f2b-9903-5b78-7403-59d27f066143

6 days agoRevert "Correct variable name typo while accessing TimelineViewport object from Timel...
nduca@chromium.org [Fri, 25 Jul 2014 17:17:42 +0000 (17:17 +0000)]
Revert "Correct variable name typo while accessing TimelineViewport object from TimelineTrackView object."

This reverts commit bc297618ab340ca6f4234a58828f7350e6c8e5bd.

Comments on https://codereview.appspot.com/118960043/#msg7

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1411 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoUse unix style relative path on raw scripts
nduca@chromium.org [Thu, 24 Jul 2014 17:21:29 +0000 (17:21 +0000)]
Use unix style relative path on raw scripts

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1410 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoAdd debugging to chase down windows fail
nduca@chromium.org [Thu, 24 Jul 2014 17:21:25 +0000 (17:21 +0000)]
Add debugging to chase down windows fail

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1409 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoRemove -container parts of profiling_view
nduca@chromium.org [Thu, 24 Jul 2014 16:39:28 +0000 (16:39 +0000)]
Remove -container parts of profiling_view

This is partly because the container is unneeded, afaict. But,
more importantly, the styling is broken with this: the x-profiling-view-container is not stretching to fill x-profiling-view, so in about:tracing,
the UI doesn't fill the screen properly.

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/112660043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1408 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoRevert "Polymerize find-control."
nduca@chromium.org [Thu, 24 Jul 2014 16:38:43 +0000 (16:38 +0000)]
Revert "Polymerize find-control."

This reverts polymerizing for now. The polymer.min.js is throwing
an exception when compiled into about:tracing, which blocks us
from doing a deps roll. We can re-land when we have time to debug.

TBR=dsinclair
BUG=574

Review URL: https://codereview.appspot.com/111660043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1407 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoCorrect variable name typo while accessing TimelineViewport object from TimelineTrack...
r.kasibhatla@samsung.com [Thu, 24 Jul 2014 12:16:02 +0000 (12:16 +0000)]
Correct variable name typo while accessing TimelineViewport object from TimelineTrackView object.

TimelineViewport object is stored as viewport_ in TimelineTrackView class.
In timeline_track_view.html it is referred as this.viewport_
in some places and in some places as this.viewport.

Changed all instances to this.viewport.

BUG=None
R=nduca@chromium.org

Review URL: https://codereview.appspot.com/118960043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1406 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoClean up project path handling
nduca@chromium.org [Thu, 24 Jul 2014 08:37:51 +0000 (08:37 +0000)]
Clean up project path handling

Projects used to get their paths via constructor.

This made subclassing projects really crazy, because the subclassee
had to handle both adding its own paths plus maybe optional additional
paths passed in on the constructor. This was fragile in practice.

This just makes the paths mutable, and adds the right notification handling
so that if you do mutate the paths, the base project finds out.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1405 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoRemove support for tvcm.require inside inline scripts
nduca@chromium.org [Thu, 24 Jul 2014 07:34:48 +0000 (07:34 +0000)]
Remove support for tvcm.require inside inline scripts

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1404 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoForgot to remove validation code for old style testSuite
nduca@chromium.org [Thu, 24 Jul 2014 07:34:43 +0000 (07:34 +0000)]
Forgot to remove validation code for old style testSuite

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1403 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoMake testSuite take just the constructor
nduca@chromium.org [Thu, 24 Jul 2014 07:24:14 +0000 (07:24 +0000)]
Make testSuite take just the constructor

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1402 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoRemove testSuite name argument from testSuite call sites
nduca@chromium.org [Thu, 24 Jul 2014 07:23:23 +0000 (07:23 +0000)]
Remove testSuite name argument from testSuite call sites

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1401 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoAllow testSuite name to be optional
nduca@chromium.org [Thu, 24 Jul 2014 07:23:13 +0000 (07:23 +0000)]
Allow testSuite name to be optional

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1400 0e6d7f2b-9903-5b78-7403-59d27f066143

7 days agoPlace css imports inline where they are listed, instead of all together.
nduca@chromium.org [Thu, 24 Jul 2014 06:38:31 +0000 (06:38 +0000)]
Place css imports inline where they are listed, instead of all together.

The behavior of this was surprising and inconsistent without this change:
<style>a</style>
<link=style b.css>

This would show up in generated html as b, then a.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1399 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoStop fetching deps.js and remove dev_server support
nduca@chromium.org [Thu, 24 Jul 2014 05:12:54 +0000 (05:12 +0000)]
Stop fetching deps.js and remove dev_server support

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1398 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoRemove requireStylesheet,RawScript and Template
nduca@chromium.org [Thu, 24 Jul 2014 05:12:49 +0000 (05:12 +0000)]
Remove requireStylesheet,RawScript and Template

This removes the tvcm.html calls for the remaining old-style
loader system.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1397 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoAdd missing dependency
nduca@chromium.org [Thu, 24 Jul 2014 05:12:45 +0000 (05:12 +0000)]
Add missing dependency

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1396 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoRemove tvcm.require
nduca@chromium.org [Thu, 24 Jul 2014 05:12:40 +0000 (05:12 +0000)]
Remove tvcm.require

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1395 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoMove suite_loader to use imports
nduca@chromium.org [Thu, 24 Jul 2014 05:12:08 +0000 (05:12 +0000)]
Move suite_loader to use imports

SuiteLoader was the remaining use of tvcm.require. This moves
suite loader to use html imports' load events, allowing tvcm.require to be
removed.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1394 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoBegin removing support for JSModules
nduca@chromium.org [Wed, 23 Jul 2014 21:24:52 +0000 (21:24 +0000)]
Begin removing support for JSModules

This disables loading of JSModules and updates unit tests that still are valid
to use html modules.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1393 0e6d7f2b-9903-5b78-7403-59d27f066143

8 days agoRemove __init__ support
nduca@chromium.org [Wed, 23 Jul 2014 19:41:20 +0000 (19:41 +0000)]
Remove __init__ support

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1392 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoPolymerize find-control.
dsinclair@chromium.org [Tue, 22 Jul 2014 17:46:49 +0000 (17:46 +0000)]
Polymerize find-control.

This converts the HTML module of find-control to be a Polymer Element.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/116130043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1391 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoAdd jszip to build files
dsinclair@chromium.org [Tue, 22 Jul 2014 14:36:11 +0000 (14:36 +0000)]
Add jszip to build files

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/116120043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1390 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoRemove accidental debugger call
nduca@chromium.org [Tue, 22 Jul 2014 14:18:42 +0000 (14:18 +0000)]
Remove accidental debugger call

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1389 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoEliminate the remainder of the tvcm.require calls
nduca@chromium.org [Tue, 22 Jul 2014 14:14:01 +0000 (14:14 +0000)]
Eliminate the remainder of the tvcm.require calls

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1388 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoFix skp listing
nduca@chromium.org [Tue, 22 Jul 2014 14:13:53 +0000 (14:13 +0000)]
Fix skp listing

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1387 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoMove tvcm/__init__.js to tvcm.html AND make it a dependency
nduca@chromium.org [Tue, 22 Jul 2014 14:13:26 +0000 (14:13 +0000)]
Move tvcm/__init__.js to tvcm.html AND make it a dependency

In the old system, tvcm/__init__.js was brought in manually by
the bootstrap code. This isn't very component like. In this patch,
HTMLModule is updated to complain if tvcm is not somehow referenced by
a file containing tvcm.exportTo. This allows all bootstrap lines of
tvcm/__init__.js to be removed.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1386 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoRemove implicit dependency on polymer in html modules
nduca@chromium.org [Tue, 22 Jul 2014 14:13:16 +0000 (14:13 +0000)]
Remove implicit dependency on polymer in html modules

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1385 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoMove tvcm/ to imports
nduca@chromium.org [Tue, 22 Jul 2014 08:57:52 +0000 (08:57 +0000)]
Move tvcm/ to imports

All but __init__.js has gone. That one is a bit magical.

TBR=dsinclair

Review URL: https://codereview.appspot.com/114200043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1384 0e6d7f2b-9903-5b78-7403-59d27f066143

9 days agoChange how html files are decided to be modules
nduca@chromium.org [Tue, 22 Jul 2014 07:58:17 +0000 (07:58 +0000)]
Change how html files are decided to be modules

The first version of IsFilenameAModule used the presence of certain magical
tags in the filename as a signal that an html file was a tvcm module versus a
plain-old-html file.

The downside was that if a module was written without the proper tricks in it,
then it'd not be recognized. So, if you typed <!DOCTYPE HTML> instead of
<!DOCTYPE html> your module wouldn't be includable. And, other silly things
like that. This was really fragile.

This replaces the heuristics with a blacklist. All html files are assumed
to be modules, but then they can be added to the project blacklist for
non inclusion.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1383 0e6d7f2b-9903-5b78-7403-59d27f066143

10 days agoSimple protection against improper script tag escaping
nduca@chromium.org [Tue, 22 Jul 2014 01:22:49 +0000 (01:22 +0000)]
Simple protection against improper script tag escaping

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1382 0e6d7f2b-9903-5b78-7403-59d27f066143

10 days agoTry to detect malformed html
nduca@chromium.org [Tue, 22 Jul 2014 01:17:41 +0000 (01:17 +0000)]
Try to detect malformed html

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/111450043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1381 0e6d7f2b-9903-5b78-7403-59d27f066143

10 days agoFix trace2html and generate_about_tracing_contents
nduca@chromium.org [Mon, 21 Jul 2014 23:17:25 +0000 (23:17 +0000)]
Fix trace2html and generate_about_tracing_contents

./run_tests caught this, so just fixes required.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1380 0e6d7f2b-9903-5b78-7403-59d27f066143

10 days agoFix missing end token on zip_importer.html
nduca@chromium.org [Mon, 21 Jul 2014 23:07:30 +0000 (23:07 +0000)]
Fix missing end token on zip_importer.html

TBR=dsinclair

Review URL: https://codereview.appspot.com/114170043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1379 0e6d7f2b-9903-5b78-7403-59d27f066143

10 days agoConvert tracks/ to HTML modules.
dsinclair@chromium.org [Mon, 21 Jul 2014 14:46:23 +0000 (14:46 +0000)]
Convert tracks/ to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/112520044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1378 0e6d7f2b-9903-5b78-7403-59d27f066143

10 days agoConvert trace_model/ to HTML modules.
dsinclair@chromium.org [Mon, 21 Jul 2014 14:07:05 +0000 (14:07 +0000)]
Convert trace_model/ to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/115840047

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1377 0e6d7f2b-9903-5b78-7403-59d27f066143

11 days agoConvert importers to HTML modules
dsinclair@chromium.org [Sun, 20 Jul 2014 19:30:40 +0000 (19:30 +0000)]
Convert importers to HTML modules

Note, I had to space out the <script> tags in the trace2html test to make the
parser happy that there was no use strict. This means I had to change the
importer slightly to allow the spaced syntax.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/116050044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1376 0e6d7f2b-9903-5b78-7403-59d27f066143

11 days agoCommit Linux Perf importer to HTML modules
dsinclair@chromium.org [Sun, 20 Jul 2014 19:10:55 +0000 (19:10 +0000)]
Commit Linux Perf importer to HTML modules

Note, I had to remove the canImportSystraceFile test as, for some reason I
was unable to determine, having that test included causes the whole
linux_perf_importer_test module to disappear.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/116970043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1375 0e6d7f2b-9903-5b78-7403-59d27f066143

11 days agoConvert ETW importer to HTML modules.
dsinclair@chromium.org [Sun, 20 Jul 2014 17:52:15 +0000 (17:52 +0000)]
Convert ETW importer to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/114110043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1374 0e6d7f2b-9903-5b78-7403-59d27f066143

11 days agoConvert v8 to HTML imports.
dsinclair@chromium.org [Sun, 20 Jul 2014 15:13:26 +0000 (15:13 +0000)]
Convert v8 to HTML imports.

TBR=ndua@chromium.org

Review URL: https://codereview.appspot.com/115140043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1373 0e6d7f2b-9903-5b78-7403-59d27f066143

11 days agoConvert side_panel directory to HTML modules.
dsinclair@chromium.org [Sun, 20 Jul 2014 15:00:01 +0000 (15:00 +0000)]
Convert side_panel directory to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/115130043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1372 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoConvert tracing files to HTML modules.
dsinclair@chromium.org [Sat, 19 Jul 2014 14:09:53 +0000 (14:09 +0000)]
Convert tracing files to HTML modules.

TBR=nduca@chomium.org

Review URL: https://codereview.appspot.com/114100043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1371 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoConvert analysis directory to HTML modules.
dsinclair@chromium.org [Sat, 19 Jul 2014 13:22:00 +0000 (13:22 +0000)]
Convert analysis directory to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/119900043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1370 0e6d7f2b-9903-5b78-7403-59d27f066143

12 days agoConvert about_tracing to HTML modules.
dsinclair@chromium.org [Sat, 19 Jul 2014 12:44:45 +0000 (12:44 +0000)]
Convert about_tracing to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/114090044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1369 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoConvert cc directory to HTML modules.
dsinclair@chromium.org [Sat, 19 Jul 2014 04:40:09 +0000 (04:40 +0000)]
Convert cc directory to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/113340043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1367 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoConvert tcmalloc directory to a HTML module.
dsinclair@chromium.org [Sat, 19 Jul 2014 03:56:48 +0000 (03:56 +0000)]
Convert tcmalloc directory to a HTML module.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/119880044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1366 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoFix ordering in trace_viewer.html
dsinclair@chromium.org [Sat, 19 Jul 2014 03:54:24 +0000 (03:54 +0000)]
Fix ordering in trace_viewer.html

If the gpu import is put up under the script include of __init__.js there
are console exceptions. Need to load the other scripts first I believe.

We can move them all up when the conversion is complete.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/115080043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1365 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoConvert system_stats directory to HTML modules.
dsinclair@chromium.org [Sat, 19 Jul 2014 00:39:31 +0000 (00:39 +0000)]
Convert system_stats directory to HTML modules.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/119850043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1364 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoConvert gpu directory to HTML modules
dsinclair@chromium.org [Sat, 19 Jul 2014 00:27:55 +0000 (00:27 +0000)]
Convert gpu directory to HTML modules

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/111380044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1363 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoConvert find control and find controller to HTML module.
dsinclair@chromium.org [Fri, 18 Jul 2014 20:46:45 +0000 (20:46 +0000)]
Convert find control and find controller to HTML module.

This moves the find control and find controller from a JS module to
an HTML module.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/119840043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1362 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoExtend HTML parser support.
dsinclair@chromium.org [Fri, 18 Jul 2014 20:35:14 +0000 (20:35 +0000)]
Extend HTML parser support.

Handle self-closing tags, entity references and character references.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/112450043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1361 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoFix import and stylesheet stripping tests
nduca@chromium.org [Fri, 18 Jul 2014 20:11:23 +0000 (20:11 +0000)]
Fix import and stylesheet stripping tests

R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/115050044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1360 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoMake tvcm.quad an HTML module
nduca@chromium.org [Fri, 18 Jul 2014 20:02:19 +0000 (20:02 +0000)]
Make tvcm.quad an HTML module

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/115050043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1359 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoDon't include _test.html files in gyp/gn checks
nduca@chromium.org [Fri, 18 Jul 2014 19:31:26 +0000 (19:31 +0000)]
Don't include _test.html files in gyp/gn checks

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1358 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoMake requireRawScript and requireStylesheet executing an actual failure
nduca@chromium.org [Fri, 18 Jul 2014 19:29:01 +0000 (19:29 +0000)]
Make requireRawScript and requireStylesheet executing an actual failure

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1357 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoMerge js and html files together so renames are easier.
nduca@chromium.org [Fri, 18 Jul 2014 19:25:14 +0000 (19:25 +0000)]
Merge js and html files together so renames are easier.

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/114060045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1356 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoAllow instantiateTemplate to use specific document.
dsinclair@chromium.org [Fri, 18 Jul 2014 19:23:04 +0000 (19:23 +0000)]
Allow instantiateTemplate to use specific document.

This will allow us to pass in the import document when we start creating
HTML imported modules.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/117950043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1355 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoMake html module and test discovery work
nduca@chromium.org [Fri, 18 Jul 2014 19:08:41 +0000 (19:08 +0000)]
Make html module and test discovery work

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/111370043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1354 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoCorrect pointer to map file.
dsinclair@chromium.org [Fri, 18 Jul 2014 19:00:34 +0000 (19:00 +0000)]
Correct pointer to map file.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/108710047

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1353 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoUpgrade polymer, platform and add map files.
dsinclair@chromium.org [Fri, 18 Jul 2014 18:46:21 +0000 (18:46 +0000)]
Upgrade polymer, platform and add map files.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/111360043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1352 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoCatch socket error on finish
nduca@chromium.org [Fri, 18 Jul 2014 18:27:49 +0000 (18:27 +0000)]
Catch socket error on finish

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/108710045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1351 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoSplit FindControl and FindController.
dsinclair@chromium.org [Fri, 18 Jul 2014 18:25:14 +0000 (18:25 +0000)]
Split FindControl and FindController.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/118890045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1350 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoFix failing testContentsAsHTML
nduca@chromium.org [Fri, 18 Jul 2014 18:23:20 +0000 (18:23 +0000)]
Fix failing testContentsAsHTML

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1349 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoUse html imports for all module loading.
nduca@chromium.org [Fri, 18 Jul 2014 18:13:50 +0000 (18:13 +0000)]
Use html imports for all module loading.

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/119800043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1348 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoRequire chrome 36 or later.
dsinclair@chromium.org [Fri, 18 Jul 2014 18:04:03 +0000 (18:04 +0000)]
Require chrome 36 or later.

We are about to start using HTML imports in the dev and test environments.
This means a version of chrome of M36 or later is required.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/115040044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1347 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoFix gl_matrix imports; fix test error
dsinclair@chromium.org [Fri, 18 Jul 2014 17:36:15 +0000 (17:36 +0000)]
Fix gl_matrix imports; fix test error

We should never be importing raw scripts directly. This needs to be handled
by the tvcm module to import those scripts. Otherwise, we can end up with
duplicate script loads and weird behaviour.

Also, fix test exception and message to be clearer.

TBR=nduca@chromium.org

Review URL: https://codereview.appspot.com/111320045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1346 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoMake modules constructable without having real files backing them, for testing.
nduca@chromium.org [Fri, 18 Jul 2014 08:34:42 +0000 (08:34 +0000)]
Make modules constructable without having real files backing them, for testing.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1345 0e6d7f2b-9903-5b78-7403-59d27f066143

13 days agoAlphabetize imports
nduca@chromium.org [Fri, 18 Jul 2014 08:34:28 +0000 (08:34 +0000)]
Alphabetize imports

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1344 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoTeach tvcm runtime loader about html modules
nduca@chromium.org [Wed, 16 Jul 2014 20:51:08 +0000 (20:51 +0000)]
Teach tvcm runtime loader about html modules

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/114870043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1343 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoFirst implementation of html_module
nduca@chromium.org [Wed, 16 Jul 2014 16:45:37 +0000 (16:45 +0000)]
First implementation of html_module

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/118740043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1342 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoGenerateJS is still needed
nduca@chromium.org [Wed, 16 Jul 2014 05:04:18 +0000 (05:04 +0000)]
GenerateJS is still needed

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1341 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoBasic movement of generate code into module plus basic html module.
nduca@chromium.org [Wed, 16 Jul 2014 02:45:43 +0000 (02:45 +0000)]
Basic movement of generate code into module plus basic html module.

R=dsinclair@chromium.org, dsinclair

Review URL: https://codereview.appspot.com/111220043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1340 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoThis adds a bit more parsing logic in preparation for html modules
nduca@chromium.org [Wed, 16 Jul 2014 02:01:29 +0000 (02:01 +0000)]
This adds a bit more parsing logic in preparation for html modules

R=dsinclair@chromium.org

Review URL: https://codereview.appspot.com/110970043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1339 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoFixed lthi_cats_perf_test
cvicentiu@chromium.org [Mon, 14 Jul 2014 10:48:21 +0000 (10:48 +0000)]
Fixed lthi_cats_perf_test

The bug is caused by a wrongly specified file url to import.

Refactored the code a bit to not have url strings written twice in the code.
The problem was that we are looking for a lthi_cats.json file, while the
repository has a lthi_cats.json.gz file. Also in order to parse the gzip file,
we need to get both the gzip importer as well as the trace_event_importer.

BUG=571
R=skyostil@chromium.org

Review URL: https://codereview.appspot.com/111130044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1338 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoShow the preset trace categories
pdr@chromium.org [Fri, 11 Jul 2014 23:29:10 +0000 (23:29 +0000)]
Show the preset trace categories

Existing tracers are unsure what categories are used for each of the
presets. This patch shows the categories behind each preset in a
light and small font. I think this is a nice compromise between our
existing trace experts and new users. A preview is at
http://pr.gg/tracecats.png

The complexity in this patch is just to keep the preset <-> manual
transition looking smooth.

One unrelated change is in this patch: instead of transitioning to
opacity:1, we stop at opacity:0.99 to prevent layer churn.

BUG=
R=dsinclair@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/112140043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1337 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoAdd thread-level highlight instant events
pdr@chromium.org [Fri, 11 Jul 2014 23:10:12 +0000 (23:10 +0000)]
Add thread-level highlight instant events

This patch adds a new thread-level instant event for highlights. A
highlight event marks the transition between two highlight styles and
is drawn as a slightly dark background. Highlight events are selectable
to make time comparisons easy.

A followup patch will explore adding text describing the frame number
using metadata.

A screenshot is available at http://pr.gg/newframetimes.png

BUG=
R=dsinclair@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/111940043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1336 0e6d7f2b-9903-5b78-7403-59d27f066143

2 weeks agoMove all side panels.
dsinclair@chromium.org [Fri, 11 Jul 2014 19:20:30 +0000 (19:20 +0000)]
Move all side panels.

This CL moves the side panels into the trace_viewer/tracing/side_panel
directory and updates the namespace to be tracing.side_panel.

R=nduca@chromium.org

Review URL: https://codereview.appspot.com/114750043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1335 0e6d7f2b-9903-5b78-7403-59d27f066143