8 months agoFix for failing perf tests master
r.kasibhatla@samsung.com [Thu, 18 Sep 2014 03:42:10 +0000 (03:42 +0000)]
Fix for failing perf tests

Track contents drawing function is draw_() instead of drawTrackContents_().

Call to invalid function drawTrackContents_() is causing failure of performance tests:

drawTrackContents_() was renamed to draw_() as part of revision 1544 - Add collapsing to most tracks in the timeline

[1] https://code.google.com/p/trace-viewer/source/diff?spec=svn1544&r=1544&format=side&path=/trunk/trace_viewer/tracing/tracks/drawing_container.html


Review URL: https://codereview.appspot.com/142900043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1560 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoHandle missing layer and region data.
dsinclair@chromium.org [Wed, 17 Sep 2014 17:46:15 +0000 (17:46 +0000)]
Handle missing layer and region data.

It's possible that a trace will be missing the layer children and region
information.  Don't try to access the information unless we have the objects


Review URL: https://codereview.appspot.com/139710043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1559 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoVisualize input events
skyostil@chromium.org [Wed, 17 Sep 2014 17:38:02 +0000 (17:38 +0000)]
Visualize input events

Show input events in the layer tree viewer as circles.

Original patch by Vicentiu Ciorbaru <cvicentiu@chromium.org>


R=dsinclair@chromium.org, nduca@chromium.org

Review URL: https://codereview.appspot.com/146760043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1558 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoAdd utility class for accessing trace data about the Chrome browser
skyostil@chromium.org [Wed, 17 Sep 2014 15:40:28 +0000 (15:40 +0000)]
Add utility class for accessing trace data about the Chrome browser

Refactor code for looking for different Chrome processes into a utility


Review URL: https://codereview.appspot.com/145840043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1556 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoPointed the replica layer's parent to the correct place
awoloszyn@chromium.org [Wed, 17 Sep 2014 12:56:59 +0000 (12:56 +0000)]
Pointed the replica layer's parent to the correct place

R=nduca@chromium.org, dsinclair@chromium.org

Review URL: https://codereview.appspot.com/145000044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1555 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoMake trace report ID selectable and a link in the "upload complete" overlay
mmandlis@chromium.org [Tue, 16 Sep 2014 18:47:59 +0000 (18:47 +0000)]
Make trace report ID selectable and a link in the "upload complete" overlay

R=dsinclair@chromium.org, pdr@chromium.org, pdr@google.com

Review URL: https://codereview.appspot.com/130850043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1554 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoFix 'c' appearing in about:tracing
nduca@chromium.org [Mon, 15 Sep 2014 21:28:08 +0000 (21:28 +0000)]
Fix 'c' appearing in about:tracing

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1553 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoRewrite parse_html_deps to use BeautifulSoup
nduca@chromium.org [Sat, 13 Sep 2014 07:07:25 +0000 (07:07 +0000)]
Rewrite parse_html_deps to use BeautifulSoup

Wow, BeautifulSoup is much much nicer than HTMLParser. Happydance.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1552 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoBeautifulSoup to trace-viewer
nduca@chromium.org [Sat, 13 Sep 2014 07:07:16 +0000 (07:07 +0000)]
BeautifulSoup to trace-viewer

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1551 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoRemove opaque rect from Picture since it's going away in chromium.
danakj@chromium.org [Fri, 12 Sep 2014 17:45:26 +0000 (17:45 +0000)]
Remove opaque rect from Picture since it's going away in chromium.

This https://codereview.chromium.org/563963002/ CL removes it from

R=nduca@chromium.org, pdr@chromium.org

Review URL: https://codereview.appspot.com/136600043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1550 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoRevert "Add Python-2.7.6 HTMLParser to third_party and delegate to it when needed"
nduca@chromium.org [Fri, 12 Sep 2014 17:38:16 +0000 (17:38 +0000)]
Revert "Add Python-2.7.6 HTMLParser to third_party and delegate to it when needed"

This reverts the python parser addition because Chromium licensecheck can't understand it:
python library files don't have license headers.

Will switch to beautifulsoup.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1549 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoMake sunburst for samples selection-aware both ways.
gholap@chromium.org [Wed, 10 Sep 2014 21:54:24 +0000 (21:54 +0000)]
Make sunburst for samples selection-aware both ways.
- The CL https://codereview.appspot.com/112110043/
  made the sunburst initialize with selection instead of model.
- This one aims to make the current selection mutate as
  the user interacts with the sunburst chart.


Review URL: https://codereview.appspot.com/116870043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1548 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoRe-enable showing of stats at the center of sunburst chart.
gholap@chromium.org [Thu, 4 Sep 2014 23:58:20 +0000 (23:58 +0000)]
Re-enable showing of stats at the center of sunburst chart.


Review URL: https://codereview.appspot.com/134490043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1547 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoHint users about how to mark the selection
nduca@chromium.org [Tue, 2 Sep 2014 16:29:02 +0000 (16:29 +0000)]
Hint users about how to mark the selection

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1546 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoRemove stale css
nduca@chromium.org [Tue, 2 Sep 2014 16:28:59 +0000 (16:28 +0000)]
Remove stale css

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1545 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoAdd collapsing to most tracks in the timeline
nduca@chromium.org [Tue, 2 Sep 2014 15:59:58 +0000 (15:59 +0000)]
Add collapsing to most tracks in the timeline

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1544 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoAttach slice and async slice groups to model
nduca@chromium.org [Tue, 2 Sep 2014 15:59:52 +0000 (15:59 +0000)]
Attach slice and async slice groups to model

ASGs now have guids and know their parent thread. This will let us
persist their state.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1543 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoStore ephemeral TraceModelSettings internally by GUID
nduca@chromium.org [Tue, 2 Sep 2014 15:59:48 +0000 (15:59 +0000)]
Store ephemeral TraceModelSettings internally by GUID

Reduces intrusiveness of persistence system.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1542 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoRemove *insane* top-repositioning code in DrawingContainer
nduca@chromium.org [Tue, 2 Sep 2014 15:59:44 +0000 (15:59 +0000)]
Remove *insane* top-repositioning code in DrawingContainer

As near as I can tell, this existed from a much stranger time in trace-viewer. And, becaues
of how the Track.drawTrack code works, this was mostly hidden, except
when the total height of the canvas changed AND you were scrolled down.


git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1541 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoImplemented new analysis results framework.
cvicentiu@chromium.org [Fri, 29 Aug 2014 15:45:32 +0000 (15:45 +0000)]
Implemented new analysis results framework.


Review URL: https://codereview.appspot.com/131050044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1540 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoCorrect viewport size on initial load.
dsinclair@chromium.org [Fri, 29 Aug 2014 12:33:50 +0000 (12:33 +0000)]
Correct viewport size on initial load.

Currently, when I load lthi_cats the timeline ends up being a lot smaller then
the available viewport. This is because the width used in the transform
calculation is incorrect. It looks like we are attempting to set the initial
viewport before the raf to update the canvas size has fired.

This CL forces the canvas to check if there is a size update so that we will
have the correct sizing information.


Review URL: https://codereview.appspot.com/131630043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1539 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoTrailing "}" reported while building trace-viewer.
nduca@chromium.org [Thu, 28 Aug 2014 10:56:04 +0000 (10:56 +0000)]
Trailing "}" reported while building trace-viewer.

Patch fixes it.


(Console output)
FAILED: cd ../../third_party/trace-viewer;
python trace_viewer/build/generate_about_tracing_contents --outdir <out_dir>
Exception: While parsing tracing.find_control: malformed start tag,
at line 58, column 45

R=nduca@chromium.org, pdr@chromium.org

Review URL: https://codereview.appspot.com/129440043

Patch from a1.gomes <a1.gomes@sisa.samsung.com>.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1538 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoAdd Python-2.7.6 HTMLParser to third_party and delegate to it when needed
nduca@chromium.org [Thu, 28 Aug 2014 10:54:04 +0000 (10:54 +0000)]
Add Python-2.7.6 HTMLParser to third_party and delegate to it when needed

Python < 2.7.6 has seemingly subtle bugs in its HTMLParser. Rather than
keep dancing around trying to find those, I'm adding the 2.7.6 parser to
third party and delegating to it when python is sufficiently old.


git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1537 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoFix picture unit tests after skp changes
nduca@chromium.org [Thu, 28 Aug 2014 10:53:54 +0000 (10:53 +0000)]
Fix picture unit tests after skp changes

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1536 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoInvalidations are green, like they are in inspector
nduca@chromium.org [Wed, 27 Aug 2014 18:02:10 +0000 (18:02 +0000)]
Invalidations are green, like they are in inspector

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1535 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoAdd active_tiles as way of getting tiles.
vmpstr@chromium.org [Tue, 26 Aug 2014 21:51:52 +0000 (21:51 +0000)]
Add active_tiles as way of getting tiles.

Use active_tiles as a source of getting tiles, since this is where
the chrome code is moving. We still support tiles, however, since
we want to be able to process traces generated with older version of

R=nduca@chromium.org, nduca

Review URL: https://codereview.appspot.com/132210043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1534 0e6d7f2b-9903-5b78-7403-59d27f066143

8 months agoRemoved click stack from sunburst.
gholap@chromium.org [Mon, 25 Aug 2014 19:59:14 +0000 (19:59 +0000)]
Removed click stack from sunburst.


Review URL: https://codereview.appspot.com/131870043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1533 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd link to what rasterized
nduca@chromium.org [Sat, 23 Aug 2014 08:11:22 +0000 (08:11 +0000)]
Add link to what rasterized

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1532 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd handling for raster task selection from multiple lthi snapshots
nduca@chromium.org [Sat, 23 Aug 2014 07:52:23 +0000 (07:52 +0000)]
Add handling for raster task selection from multiple lthi snapshots

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1531 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoGive better names for lthi links
nduca@chromium.org [Sat, 23 Aug 2014 07:52:17 +0000 (07:52 +0000)]
Give better names for lthi links

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1530 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix bounds checking on LTHI drawnBefore logic
nduca@chromium.org [Sat, 23 Aug 2014 07:52:12 +0000 (07:52 +0000)]
Fix bounds checking on LTHI drawnBefore logic

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1529 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoRename analysis class to reflect its polymer component name
nduca@chromium.org [Sat, 23 Aug 2014 07:52:02 +0000 (07:52 +0000)]
Rename analysis class to reflect its polymer component name

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1528 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix 'f' key centering
nduca@chromium.org [Sat, 23 Aug 2014 06:49:39 +0000 (06:49 +0000)]
Fix 'f' key centering

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1527 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoClean up 'is raster task' flow
nduca@chromium.org [Sat, 23 Aug 2014 06:36:26 +0000 (06:36 +0000)]
Clean up 'is raster task' flow

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1526 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd link to lthi
nduca@chromium.org [Sat, 23 Aug 2014 06:09:41 +0000 (06:09 +0000)]
Add link to lthi

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1525 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoMake qsv slider 400
nduca@chromium.org [Fri, 22 Aug 2014 23:44:36 +0000 (23:44 +0000)]
Make qsv slider 400

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1524 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoShow how many tiles we consider during rasterization
nduca@chromium.org [Fri, 22 Aug 2014 23:44:29 +0000 (23:44 +0000)]
Show how many tiles we consider during rasterization

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1523 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoDon't draw invalidation rects when the tree has been before
nduca@chromium.org [Fri, 22 Aug 2014 23:30:09 +0000 (23:30 +0000)]
Don't draw invalidation rects when the tree has been before

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1522 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix yet more fallout from mutating the selection states on tiles
nduca@chromium.org [Fri, 22 Aug 2014 22:56:02 +0000 (22:56 +0000)]
Fix yet more fallout from mutating the selection states on tiles

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1521 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoTiles weren't selectable
nduca@chromium.org [Fri, 22 Aug 2014 22:48:04 +0000 (22:48 +0000)]
Tiles weren't selectable

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1520 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoSeparate out analysis from raster results
nduca@chromium.org [Fri, 22 Aug 2014 22:37:23 +0000 (22:37 +0000)]
Separate out analysis from raster results

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1519 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix gyp and gn
nduca@chromium.org [Thu, 21 Aug 2014 12:44:49 +0000 (12:44 +0000)]
Fix gyp and gn

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1518 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoRestore the rasterization analysis when no selection
nduca@chromium.org [Thu, 21 Aug 2014 12:44:43 +0000 (12:44 +0000)]
Restore the rasterization analysis when no selection

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1517 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd extraHighlights to the LTQSV and put the raster highlights there
nduca@chromium.org [Thu, 21 Aug 2014 12:44:35 +0000 (12:44 +0000)]
Add extraHighlights to the LTQSV and put the raster highlights there

This allows you to explore the layer tree while keeping the selected
raster tasks still highlighted.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1516 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd analysis of raster slices by layer
nduca@chromium.org [Thu, 21 Aug 2014 12:44:27 +0000 (12:44 +0000)]
Add analysis of raster slices by layer

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1515 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoMake dev server produce html error pages when appropriate
nduca@chromium.org [Thu, 21 Aug 2014 12:44:21 +0000 (12:44 +0000)]
Make dev server produce html error pages when appropriate

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1514 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoUse flex-row for sane layout on toolbar
nduca@chromium.org [Thu, 21 Aug 2014 10:28:12 +0000 (10:28 +0000)]
Use flex-row for sane layout on toolbar

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1513 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoMove ltqsv css inline
nduca@chromium.org [Thu, 21 Aug 2014 10:28:06 +0000 (10:28 +0000)]
Move ltqsv css inline

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1512 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix raster_tas_sub_view sizing again
nduca@chromium.org [Thu, 21 Aug 2014 10:28:01 +0000 (10:28 +0000)]
Fix raster_tas_sub_view sizing again

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1511 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd support for multiple raster task selections
nduca@chromium.org [Thu, 21 Aug 2014 10:06:45 +0000 (10:06 +0000)]
Add support for multiple raster task selections

This allows multiple raster tasks to be selected and be highted in
frame viewer.


git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1510 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoMake update_gyp_and_gn +x
nduca@chromium.org [Thu, 21 Aug 2014 10:06:36 +0000 (10:06 +0000)]
Make update_gyp_and_gn +x

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1509 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAnalysis was not appearing
nduca@chromium.org [Thu, 21 Aug 2014 10:06:27 +0000 (10:06 +0000)]
Analysis was not appearing

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1508 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoRename RasterTaskSliceView to RasterTaskSubView
nduca@chromium.org [Thu, 21 Aug 2014 01:34:31 +0000 (01:34 +0000)]
Rename RasterTaskSliceView to RasterTaskSubView

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1507 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoMake RasterTaskSliceView a SubView
nduca@chromium.org [Thu, 21 Aug 2014 01:26:40 +0000 (01:26 +0000)]
Make RasterTaskSliceView a SubView

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1506 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoUpdate the depth during slider drag, too
nduca@chromium.org [Thu, 21 Aug 2014 00:45:27 +0000 (00:45 +0000)]
Update the depth during slider drag, too

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1505 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd slider to quad stack to control stacking depth
nduca@chromium.org [Thu, 21 Aug 2014 00:41:29 +0000 (00:41 +0000)]
Add slider to quad stack to control stacking depth

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1504 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAttach tracking to canvas instead of quad stack.
nduca@chromium.org [Thu, 21 Aug 2014 00:41:22 +0000 (00:41 +0000)]
Attach tracking to canvas instead of quad stack.

Without this, dragging on the widgets attached to the stack
will cause the camera to move around.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1503 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix layer picking not causing layers to get selected in LTQSV
nduca@chromium.org [Thu, 21 Aug 2014 00:13:04 +0000 (00:13 +0000)]
Fix layer picking not causing layers to get selected in LTQSV


Review URL: https://codereview.appspot.com/125400045

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1502 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoRevert "Remove mapfiles"
nduca@chromium.org [Wed, 20 Aug 2014 21:10:59 +0000 (21:10 +0000)]
Revert "Remove mapfiles"

This turned out to be useful for people! My bad!

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1501 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoEnsure isActiveTile is on the tile object.
vmpstr@chromium.org [Wed, 20 Aug 2014 19:23:14 +0000 (19:23 +0000)]
Ensure isActiveTile is on the tile object.

This patch ensures that we move the args.isActiveTile parameter to
the tile directly.


Review URL: https://codereview.appspot.com/123650043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1500 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix a 'No Label' bug in the tab-view.
cvicentiu@chromium.org [Wed, 20 Aug 2014 19:20:09 +0000 (19:20 +0000)]
Fix a 'No Label' bug in the tab-view.

If used in a specific order, the tab-view could lose track of an
attribute changed on a tab that gets unselected. This is caused by the
fact that observers lose their mutation record that was not processed
upon disconnect. If we disconnect the observer that monitors attributes
A and B because we want to change attribute B programatically,
while a mutation still hasn't been handled for attribute A, we lose the
mutation notification for attribute A.

Splitting observers per attribute removes this problem.


Review URL: https://codereview.appspot.com/125620043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1499 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoSome custom views are not based off analysis-sub-view yet.
cvicentiu@chromium.org [Wed, 20 Aug 2014 16:53:00 +0000 (16:53 +0000)]
Some custom views are not based off analysis-sub-view yet.

This means that the tabLabel property is not yet implemented
by every subView in the analysis. This workaround fixes the display
of a tab with 'No Label'.


Review URL: https://codereview.appspot.com/124680043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1498 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoImplemented a toggleable container.
cvicentiu@chromium.org [Wed, 20 Aug 2014 13:59:27 +0000 (13:59 +0000)]
Implemented a toggleable container.

This container will help in improving the analysis results
statistics display. Right now, the analysis results uses a tooltip
that is very difficult to read. Also, the fact that it's hidden does not
help with discovering the feature in the first place.

The plan is to add a small button (perhaps a +/- sign) that expands
a row to show the statistics.


Review URL: https://codereview.appspot.com/124460046

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1497 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFixed race condition in tests.
cvicentiu@chromium.org [Wed, 20 Aug 2014 13:56:48 +0000 (13:56 +0000)]
Fixed race condition in tests.

Whenever we register a callback that should happen after
the polymer-ready, the code should use tvcm.onPolymerReady(callback)
and pass the callback function that way.


Review URL: https://codereview.appspot.com/125600043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1496 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoBegin unifying old-style custom views with general analysis subviews
nduca@chromium.org [Wed, 20 Aug 2014 12:52:45 +0000 (12:52 +0000)]
Begin unifying old-style custom views with general analysis subviews

This gets us one step closer to a single subview system.


Review URL: https://codereview.appspot.com/125590043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1495 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoRemove mapfiles
nduca@chromium.org [Wed, 20 Aug 2014 12:47:33 +0000 (12:47 +0000)]
Remove mapfiles

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1494 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoUse a type registration model to simplify subview creation
nduca@chromium.org [Wed, 20 Aug 2014 11:12:08 +0000 (11:12 +0000)]
Use a type registration model to simplify subview creation

R=cvicentiu@chromium.org, cvicentiu

Review URL: https://codereview.appspot.com/130320043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1493 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd socket to fix mising-module error on finish
nduca@chromium.org [Wed, 20 Aug 2014 09:35:16 +0000 (09:35 +0000)]
Add socket to fix mising-module error on finish

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1492 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoPrune the organized events instead of having repeated workarounds in analysis
nduca@chromium.org [Wed, 20 Aug 2014 09:33:50 +0000 (09:33 +0000)]
Prune the organized events instead of having repeated workarounds in analysis


Review URL: https://codereview.appspot.com/125560043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1491 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoDo not include inactive tiles in gpuMemoryUsageInBytes computation
nduca@chromium.org [Wed, 20 Aug 2014 01:03:31 +0000 (01:03 +0000)]
Do not include inactive tiles in gpuMemoryUsageInBytes computation

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1489 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoUse === due to type coercion for undefined
nduca@chromium.org [Wed, 20 Aug 2014 01:03:26 +0000 (01:03 +0000)]
Use === due to type coercion for undefined

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1488 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoDo not draw inactive tiles
nduca@chromium.org [Wed, 20 Aug 2014 01:00:14 +0000 (01:00 +0000)]
Do not draw inactive tiles


Review URL: https://codereview.appspot.com/128470043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1487 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd unit tests for upload trace button.
mmandlis@chromium.org [Tue, 19 Aug 2014 08:33:09 +0000 (08:33 +0000)]
Add unit tests for upload trace button.


Review URL: https://codereview.appspot.com/126370043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1486 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoWorkaround for broken CData handling in old python
nduca@chromium.org [Tue, 19 Aug 2014 05:11:12 +0000 (05:11 +0000)]
Workaround for broken CData handling in old python

Old python treat non-</script> tags as ending the script tag section.
Thats le-wrong. This is a quick workaround for that to fix issues folks
are seeing with older pythons when building Chrome.


git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1485 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoMake async slice group track not derive from slice group track
nduca@chromium.org [Tue, 19 Aug 2014 05:11:07 +0000 (05:11 +0000)]
Make async slice group track not derive from slice group track

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1484 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoRemoved forgotten commented out line during refactoring
cvicentiu@chromium.org [Mon, 18 Aug 2014 21:15:53 +0000 (21:15 +0000)]
Removed forgotten commented out line during refactoring


Review URL: https://codereview.appspot.com/130220043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1483 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoConvert analysis_view to polymer element.
cvicentiu@chromium.org [Mon, 18 Aug 2014 21:01:01 +0000 (21:01 +0000)]
Convert analysis_view to polymer element.

Integrate the new tab view into the analysis_view.

This is based off:


Review URL: https://codereview.appspot.com/129100043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1482 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdded Analysis Sub Views
cvicentiu@chromium.org [Mon, 18 Aug 2014 20:57:05 +0000 (20:57 +0000)]
Added Analysis Sub Views

This patch is the next stepping stone to convert the analysis-view previously used to a new polymer


Review URL: https://codereview.appspot.com/123190044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1481 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoRemove unused non cross-browser lines from trace viewer (tvcm) code.
mmandlis@chromium.org [Mon, 18 Aug 2014 09:47:50 +0000 (09:47 +0000)]
Remove unused non cross-browser lines from trace viewer (tvcm) code.

remove unused non cross-browser lines from trace viewer (tvcm) code


Review URL: https://codereview.appspot.com/128180043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1480 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoPut raster task slice view in tall mode
nduca@chromium.org [Sat, 16 Aug 2014 07:41:11 +0000 (07:41 +0000)]
Put raster task slice view in tall mode

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1479 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix sizing of raster task slice view
nduca@chromium.org [Sat, 16 Aug 2014 07:41:07 +0000 (07:41 +0000)]
Fix sizing of raster task slice view

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1478 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix test failures following Selection.push changes
nduca@chromium.org [Sat, 16 Aug 2014 07:30:54 +0000 (07:30 +0000)]
Fix test failures following Selection.push changes

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1477 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoRemove accidental debugger statement
nduca@chromium.org [Sat, 16 Aug 2014 07:30:50 +0000 (07:30 +0000)]
Remove accidental debugger statement

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1476 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoSelection.push didn't bother about duplicates.
gholap@chromium.org [Fri, 15 Aug 2014 23:46:44 +0000 (23:46 +0000)]
Selection.push didn't bother about duplicates.
Now it adds events only if it wasn't already added.
- Added a test to check for de-duplication.


Review URL: https://codereview.appspot.com/130140044

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1475 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoSystemStatsSnapshot had two constructors.
gholap@chromium.org [Fri, 15 Aug 2014 23:43:16 +0000 (23:43 +0000)]
SystemStatsSnapshot had two constructors.
Also, the second one didn't call parent constructor.


Review URL: https://codereview.appspot.com/126310043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1474 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoMoved window history state management code AnalysisView -> TimelineView
gholap@chromium.org [Fri, 15 Aug 2014 17:07:47 +0000 (17:07 +0000)]
Moved window history state management code AnalysisView -> TimelineView

BUG= https://code.google.com/p/trace-viewer/issues/detail?id=582

Review URL: https://codereview.appspot.com/122450043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1473 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoPut clamping of 3000 on distanceToVisible
nduca@chromium.org [Thu, 14 Aug 2014 07:25:04 +0000 (07:25 +0000)]
Put clamping of 3000 on distanceToVisible

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1471 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoTime to visible has been removed.
nduca@chromium.org [Thu, 14 Aug 2014 07:25:00 +0000 (07:25 +0000)]
Time to visible has been removed.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1470 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoShow the value of the colormap and explanation of border color
nduca@chromium.org [Thu, 14 Aug 2014 07:24:55 +0000 (07:24 +0000)]
Show the value of the colormap and explanation of border color

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1469 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoDistanceToVisible was renamed on cc side but frame viewer was not updated.
nduca@chromium.org [Thu, 14 Aug 2014 07:24:51 +0000 (07:24 +0000)]
DistanceToVisible was renamed on cc side but frame viewer was not updated.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1468 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd best-effort memory info for old traces
nduca@chromium.org [Thu, 14 Aug 2014 06:35:38 +0000 (06:35 +0000)]
Add best-effort memory info for old traces

Old frame viewer traces don't have good memory info. But, there's still
some information. Try to give as much info as possible so that we can
diagnose tile allocation issues.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1467 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoAdd even more memory debugging features to header.
nduca@chromium.org [Thu, 14 Aug 2014 02:55:13 +0000 (02:55 +0000)]
Add even more memory debugging features to header.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1466 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoWhen an empty tree is given, clear the quads and header.
nduca@chromium.org [Thu, 14 Aug 2014 02:53:42 +0000 (02:53 +0000)]
When an empty tree is given, clear the quads and header.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1465 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix handling of layer picker selection changes
nduca@chromium.org [Thu, 14 Aug 2014 02:53:36 +0000 (02:53 +0000)]
Fix handling of layer picker selection changes

The layer picker wasn't changing the tree on the
quad stack view when you changed its whichTree dropdown.
The selection would update but not the visualization.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1464 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoShrink header font to fit more stuff.
nduca@chromium.org [Thu, 14 Aug 2014 02:53:31 +0000 (02:53 +0000)]
Shrink header font to fit more stuff.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1463 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoFix buttons in upload popup.
dsinclair@chromium.org [Thu, 14 Aug 2014 01:23:43 +0000 (01:23 +0000)]
Fix buttons in upload popup.

'Ok' and 'Cancel' buttons appear in the popup at first, when Upload button is
clicked. Once upload starts, 'ok' button is removed and 'cancel' is renamed
to 'close'.

This CL is by mmandlis@ and was reviewed in


Review URL: https://codereview.appspot.com/126210043

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1462 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoShow tile manager global state in lthiqsv
nduca@chromium.org [Wed, 13 Aug 2014 02:25:42 +0000 (02:25 +0000)]
Show tile manager global state in lthiqsv

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1461 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoUse ObjectInstanceGroupTrack to display and group object instances
nduca@chromium.org [Wed, 13 Aug 2014 02:25:36 +0000 (02:25 +0000)]
Use ObjectInstanceGroupTrack to display and group object instances

This fixes an issue where webview frames were unclickable: in webview, there
are two LTHIs.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1460 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoIntroduce MultiRowTrack
nduca@chromium.org [Wed, 13 Aug 2014 02:25:31 +0000 (02:25 +0000)]
Introduce MultiRowTrack

There are many tracks that want to take a list of data, group it a bit,
then produce sub tracks. This generalizes that code into MultiRowTrack.

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1459 0e6d7f2b-9903-5b78-7403-59d27f066143

9 months agoMove heap include to features
nduca@chromium.org [Wed, 13 Aug 2014 02:25:26 +0000 (02:25 +0000)]
Move heap include to features

git-svn-id: http://trace-viewer.googlecode.com/svn/trunk@1458 0e6d7f2b-9903-5b78-7403-59d27f066143