grv@chromium.org [Sat, 18 May 2013 09:49:16 +0000 (09:49 +0000)]
Make search on apps-devtool case insensitive.
BUG=237299
Review URL: https://chromiumcodereview.appspot.com/
15174003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200992
0039d316-1c4b-4281-b951-
d872f2087c98
gbillock@chromium.org [Sat, 18 May 2013 09:41:56 +0000 (09:41 +0000)]
Eliminate use of the SUPPORT_MTP_DEVICE_FILESYSTEM define.
All desktop platforms now support this type of filesystem.
R=thestig@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/
15047002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200991
0039d316-1c4b-4281-b951-
d872f2087c98
trchen@chromium.org [Sat, 18 May 2013 09:40:45 +0000 (09:40 +0000)]
Correct scroll offset range for WebFrame in AutomationRendererHelper
This patch needs to be landed at the same time as
https://chromiumcodereview.appspot.com/
14703004/
Since WebFrame now uses the non-shifted(ranges [minPos, maxPos]) scroll offset.
BUG=232063
TEST=AutomationRendererHelperTest.RTLSnapshot
R=darin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
15006004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200990
0039d316-1c4b-4281-b951-
d872f2087c98
enne@chromium.org [Sat, 18 May 2013 09:40:26 +0000 (09:40 +0000)]
Only use skia::RefPtr for refcounting
For consistency and sanity in Chromium, only use skia::RefPtr in Chromium to
ref count skia classes. SkRefPtr is unsafe to use for newly created objects
because it refs the object that is passed to its constructor. skia::RefPtr
makes this adoption explicit it via skia::AdoptRef and so is much clearer.
This patch also adds a skia::ShareRef function which makes it explicit that the
callsite is adopting a ref which is already owned somewhere else. Using
AdoptRef vs. ShareRef seems much clearer than using SkRefPtr vs. skia::RefPtr.
These are the remaining code sites that use internal Skia reference counted
classes. Once these have been removed, then we can use a PRESUBMIT rule to
prevent new uses from being added.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/
15004024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200989
0039d316-1c4b-4281-b951-
d872f2087c98
vmpstr@chromium.org [Sat, 18 May 2013 09:39:06 +0000 (09:39 +0000)]
cc: Add tile and tile management section to owners
Add tile and tile management section to owners in cc/
Review URL: https://chromiumcodereview.appspot.com/
15375004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200988
0039d316-1c4b-4281-b951-
d872f2087c98
tapted@chromium.org [Sat, 18 May 2013 09:31:26 +0000 (09:31 +0000)]
Allow pages on the OSX app launcher to be turned while dragging.
Adds an interface to the AppsGridController to optionally trigger a
page scroll after a delay, when given a drag location. Scrolling is
triggered if the point is to either side of the grid view, or over a
pager segment.
BUG=138633
TEST=Added: app_list_unittests AppsGridControllerTest.ScrollingWhileDragging.
Manually, test by dragging items on the OSX app launcher past the left
or right side, or over a pager segment, to initiate page scrolling
after a 1 second delay.
Review URL: https://chromiumcodereview.appspot.com/
14999013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200987
0039d316-1c4b-4281-b951-
d872f2087c98
akalin@chromium.org [Sat, 18 May 2013 09:30:23 +0000 (09:30 +0000)]
Make gles2_conform_support depend on allocator.gyp:allocator when necessary
This fixes the heapchecker+components release build.
BUG=241938
Review URL: https://chromiumcodereview.appspot.com/
15378003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200986
0039d316-1c4b-4281-b951-
d872f2087c98
mmenke@chromium.org [Sat, 18 May 2013 09:30:05 +0000 (09:30 +0000)]
net: Fix GetLoadState of a stream request when it's waiting
on a connection to be established. The state of the
connection was not being queried, due to a old regression.
BUG=118136
Review URL: https://chromiumcodereview.appspot.com/
15322002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200985
0039d316-1c4b-4281-b951-
d872f2087c98
nick@chromium.org [Sat, 18 May 2013 09:29:01 +0000 (09:29 +0000)]
tracing_ui.cc: fix single-quote escaping issue that caused
many tracing sources to be lost.
R=nduca
BUG=237481
TEST=collect about:tracing with "tasks" category enabled. Make sure the browser thread exists.
Review URL: https://chromiumcodereview.appspot.com/
14943011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200984
0039d316-1c4b-4281-b951-
d872f2087c98
mukai@chromium.org [Sat, 18 May 2013 09:20:59 +0000 (09:20 +0000)]
Read a notification card for a11y.
BUG=239187
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/
14875010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200983
0039d316-1c4b-4281-b951-
d872f2087c98
harrym@chromium.org [Sat, 18 May 2013 09:20:07 +0000 (09:20 +0000)]
Reserve Debug Shortcuts
- Processes debug shortcuts earlier in input cycle to prevent some views from blocking them.
BUG=157650
Review URL: https://chromiumcodereview.appspot.com/
14845014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200982
0039d316-1c4b-4281-b951-
d872f2087c98
piman@chromium.org [Sat, 18 May 2013 09:19:49 +0000 (09:19 +0000)]
gpu: Refactor to support cross-channel shared textures
This CL doesn't change command semantics, but is refactoring the management of
textures on the service side.
Accounting for texture gets separated into the Texture class which wraps the
service id and the meta-data, vs the TextureRef class which is a reference to
that service id in a given context group (generally corresponding to the client
id). A Texture can now have multiple TextureRef referencing it (though in this
CL no code does yet).
TextureRef keeps the refcount, whereas the Texture is explicitly managed
(jointly owned by all the TextureRef).
The main functional change is that texture-related, per-TextureManager
meta-data, such as "Is there any texture that hasn't been cleared", "Is there
any non-renderable texture", or memory accounting is pushed from the Texture to
all the owning TextureManagers (since changes from one can affect other ones).
BUG=230137
TEST=gpu_unittests, gles2_conform_test, webgl conformance tests
Review URL: https://chromiumcodereview.appspot.com/
14844004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200981
0039d316-1c4b-4281-b951-
d872f2087c98
mukai@chromium.org [Sat, 18 May 2013 09:18:49 +0000 (09:18 +0000)]
Changes rich notification settings unsynchable.
BUG=241116
Review URL: https://chromiumcodereview.appspot.com/
14823014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200980
0039d316-1c4b-4281-b951-
d872f2087c98
akuegel@chromium.org [Sat, 18 May 2013 09:10:16 +0000 (09:10 +0000)]
Remove managed user settings page.
It was decided that we should not support local changes to
the managed user settings. Therefore the managed user
settings page has become obsolete, and this CL removes it and
all code locations which referenced the managed user
settings.
BUG=241386
Review URL: https://chromiumcodereview.appspot.com/
14791019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200979
0039d316-1c4b-4281-b951-
d872f2087c98
skuhne@chromium.org [Sat, 18 May 2013 09:09:41 +0000 (09:09 +0000)]
Adding new user menu section to the SystemTrayMenu & refactoring of user access
It is still not fully finished - but it is functional and might be useful for what you are doing (and already quite big as it is). Note that the functionality is controlled by the flag.
What is missing?
- There are no unit tests yet
- The visual Drop down box to add a new user is missing.
- The error message box which shows the error if there are already 3 users signed in is missing.
- At the moment I have ~7 lines of test code in there which I will remove before I check in. (I need them since the multi login still does not work for me)
I am not sure if you want to wait until I finish the issue - or if you'd rather want to have this to be able to rather merge early then later. I leave this up to you. If you are for the latter one, you can have at least a look at my changes and if they conflict with yours.
BUG=239201
TEST=visual
Review URL: https://chromiumcodereview.appspot.com/
14756019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200978
0039d316-1c4b-4281-b951-
d872f2087c98
achuith@chromium.org [Sat, 18 May 2013 09:09:13 +0000 (09:09 +0000)]
Deprecate switches gaia-host and gaia-url-path in favor of gaia-url
* Deprecate lso-host to replace with lso-url, which is the complete origin (not just the host).
* Allow for http access of gaia-urls, not just https.
* Add data member gaia_url_ and accessor to GaiaUrls, replacing gaia_origin_url_
* Replace javascript params gaiaOrigin and gaiaUrlPath with gaiaUrl.
* Replace SetGaiaOriginForTesting with SetGaiaUrlForTesting.
BUG=239151
TEST=manual with telemetry auth server. on linux and on the device with GAIA_FLAGS="--gaia-url=https://gaiastaging.corp.google.com --lso-url=https://test-sandbox.auth.corp.google.com --google-apis-host=www.googleapis-test.sandbox.google.com --oauth2-client-id=
236834563817.apps.googleusercontent.com --oauth2-client-secret=RsKv5AwFKSzNgE0yjnurkPVI"
Review URL: https://chromiumcodereview.appspot.com/
14786022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200977
0039d316-1c4b-4281-b951-
d872f2087c98
oshima@chromium.org [Sat, 18 May 2013 09:08:40 +0000 (09:08 +0000)]
Use override redirect window for unit tests
This is how ash works on the device (no wm) and
eliminates flaky-ness caused by WM.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/
14698005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200976
0039d316-1c4b-4281-b951-
d872f2087c98
rockot@chromium.org [Sat, 18 May 2013 08:59:40 +0000 (08:59 +0000)]
Fix broken app window frame rendering on Windows
This bug was introduced by r198375, causing fullscreen or
maximized app windows to be clobbered by stuff that shouldn't
be rendered.
BUG=238935
Review URL: https://chromiumcodereview.appspot.com/
15300009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200975
0039d316-1c4b-4281-b951-
d872f2087c98
ernstm@chromium.org [Sat, 18 May 2013 08:59:24 +0000 (08:59 +0000)]
cc: Trace based rasterize and record benchmark.
- switched rasterize and record benchmark to used traces instead of
rendering stats
BUG=226489
Review URL: https://chromiumcodereview.appspot.com/
15298011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200974
0039d316-1c4b-4281-b951-
d872f2087c98
msw@chromium.org [Sat, 18 May 2013 08:58:56 +0000 (08:58 +0000)]
Remove MissingSystemFileDialog; use Views textfields instead.
Avoid Windows native textfields/omnibox if msftedit.dll fails to load.
Remove the dialog that previously showed a warning if the dll load failed.
TODO(followup): Remove the support issue: https://support.google.com/chrome/?p=e_blankomnibox
BUG=131660
TEST=NativeTextfieldViews and OmniboxViewViews are used if msftedit.dll cannot be loaded.
R=pkasting@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
14744017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200973
0039d316-1c4b-4281-b951-
d872f2087c98
chrisgao@chromium.org [Sat, 18 May 2013 08:58:28 +0000 (08:58 +0000)]
[chromedriver] Make command Quit faster.
On Mac and Linux, we send SIGKILL directly, instead of sending SIGTERM first.
Also, leave user-data-dir and extension-dir when chrome detaches.
BUG=chromedriver:310
Review URL: https://chromiumcodereview.appspot.com/
15348002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200972
0039d316-1c4b-4281-b951-
d872f2087c98
dcblack@chromium.org [Sat, 18 May 2013 08:49:16 +0000 (08:49 +0000)]
Switch from a whitelist of OK schema to send to the page to a blacklist of bad schema, to fix queries like define:foo and site:wikipedia.org.
BUG=240489
Review URL: https://chromiumcodereview.appspot.com/
14655025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200971
0039d316-1c4b-4281-b951-
d872f2087c98
palmer@chromium.org [Sat, 18 May 2013 08:48:58 +0000 (08:48 +0000)]
Define containers for more SandboxedProcessServices.
More available, isolated renderers gives us a greater margin of safety.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
14622024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200970
0039d316-1c4b-4281-b951-
d872f2087c98
rltoscano@chromium.org [Sat, 18 May 2013 08:48:39 +0000 (08:48 +0000)]
Small refactoring to fit-to-page and bug fix.
BUG=234857
Review URL: https://chromiumcodereview.appspot.com/
14495005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200969
0039d316-1c4b-4281-b951-
d872f2087c98
gauravsh@chromium.org [Sat, 18 May 2013 08:48:22 +0000 (08:48 +0000)]
NetworkPortalDetector/NetworkStateInformer: Switch over to use NetworkStateHandler
This removes the direct network library dependency for NetworkPortalDetector,
NetworkStateInformer, and SigninScreenHandler. UpdateScreen and
LocallyManagedUserCreationHandler no longer depend on NetworkLibrary as well.
Also change active -> default network in these to be consistent with
terminology we use in NetworkStateHandler.
BUG=189093,189009
Review URL: https://chromiumcodereview.appspot.com/
14134007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200968
0039d316-1c4b-4281-b951-
d872f2087c98
chromeos-lkgm@google.com [Sat, 18 May 2013 08:48:11 +0000 (08:48 +0000)]
Automated Commit: Committing new LKGM version 4141.0.0 for chromeos.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200967
0039d316-1c4b-4281-b951-
d872f2087c98
vitalybuka@chromium.org [Sat, 18 May 2013 08:44:32 +0000 (08:44 +0000)]
Revert 200954 "Revert "InstantExtended: Prevent spurious themech..."
200954 breaks mac interactive_ui_tests:InstantExtendedTest.ReloadSearchAfterBackReloadsCorrectQuery
> Revert "InstantExtended: Prevent spurious themechanged/mostvisitedchanged events"
>
> This reverts commit
9fa73739c47280860c0e5a44af62885bee391e12.
>
> BUG=238671
>
> Review URL: https://chromiumcodereview.appspot.com/
15297013
TBR=jered@chromium.org
Review URL: https://codereview.chromium.org/
15404003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200966
0039d316-1c4b-4281-b951-
d872f2087c98
chrome-release@google.com [Sat, 18 May 2013 04:01:14 +0000 (04:01 +0000)]
Updating trunk VERSION from 1511.0 to 1512.0
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200960
0039d316-1c4b-4281-b951-
d872f2087c98
cjhopman@chromium.org [Sat, 18 May 2013 02:33:37 +0000 (02:33 +0000)]
[Android] Fix proguard
Gyp supports only very limited ways of changing behavior based upon
CONFIGURATION_NAME. Particularly, it does not support the way that was
supposed to enable/disable use of proguard.
Instead of trying to switch behavior in gyp, instead pass
CONFIGURATION_NAME, proguard_enabled, and
proguard_enabled_dex_input_path to dex.py and switch the behavior
there.
This also extracts the dex actions into build/android/dex_action.gypi
and uses that for the actions in both build/java.gypi and
build/java_apk.gypi.
BUG=240837
Review URL: https://chromiumcodereview.appspot.com/
15231006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200958
0039d316-1c4b-4281-b951-
d872f2087c98
sschmitz@chromium.org [Sat, 18 May 2013 02:17:50 +0000 (02:17 +0000)]
Unify and change logout/sleep/lock shortcuts
This CL implements an exit warning and requires the user to hold
the exit shortcut for a while, before actually exiting. This is
to prevent accidental exits due shortcut mistakes.
Expert user can exit quickly with a double press.
This is a second CL on this topic (see crrev.com/200204). The first
had issues by relying on release events, which this CL does not.
BUG=225903
R=sky@chromium.org
TEST=manual
out/Debug/ash_unittests --gtest_filter='AcceleratorControllerTest.ExitWarningHandlerTest*'
Review URL: https://chromiumcodereview.appspot.com/
14771027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200957
0039d316-1c4b-4281-b951-
d872f2087c98
jeremycho@chromium.org [Sat, 18 May 2013 02:14:46 +0000 (02:14 +0000)]
Local NTP: resize the fakebox and most visited widths with JS. Use innerWidth instead of clientWidth to take scrollbar width into account.
BUG=240510
Review URL: https://chromiumcodereview.appspot.com/
15129004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200956
0039d316-1c4b-4281-b951-
d872f2087c98
thestig@chromium.org [Sat, 18 May 2013 02:13:24 +0000 (02:13 +0000)]
Change code from r199587 to use base::PostTaskAndReplyWithResults.
Review URL: https://chromiumcodereview.appspot.com/
15244002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200955
0039d316-1c4b-4281-b951-
d872f2087c98
jered@chromium.org [Sat, 18 May 2013 01:59:44 +0000 (01:59 +0000)]
Revert "InstantExtended: Prevent spurious themechanged/mostvisitedchanged events"
This reverts commit
9fa73739c47280860c0e5a44af62885bee391e12.
BUG=238671
Review URL: https://chromiumcodereview.appspot.com/
15297013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200954
0039d316-1c4b-4281-b951-
d872f2087c98
jennyz@chromium.org [Sat, 18 May 2013 01:56:59 +0000 (01:56 +0000)]
Fix the ash_shell check fail issue caused by PowerManagerHandler not initialized.
BUG=241690
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/
15305006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200953
0039d316-1c4b-4281-b951-
d872f2087c98
danakj@chromium.org [Sat, 18 May 2013 01:56:33 +0000 (01:56 +0000)]
ui: Inline QuadF::BoundingBox()
This is a hot method, used every time we map a rect from one space
to another, which accounts for a significant amount of total work
done by the compositor.
This change is a small perf improvement in cc_perftests, taking
the ImplSidePaintingPerfTest.HeavyPage test from about
0.97 ms/commit to about 0.94 ms/commit.
R=sky
BUG=239684
Review URL: https://chromiumcodereview.appspot.com/
15298013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200952
0039d316-1c4b-4281-b951-
d872f2087c98
groby@chromium.org [Sat, 18 May 2013 01:55:04 +0000 (01:55 +0000)]
[rAC] remove sign-in cancel button. Instead, reuse signin link
R=sail@chromium.org
BUG=239865,240011
Review URL: https://chromiumcodereview.appspot.com/
14990017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200951
0039d316-1c4b-4281-b951-
d872f2087c98
dgwallinga@chromium.org [Sat, 18 May 2013 01:47:48 +0000 (01:47 +0000)]
Unflip 'autocheckout supported' bit on provisional page load. Leaving it set was causing trouble when moving from one Autocheckout flow to another in the same tab.
BUG=241294
Review URL: https://chromiumcodereview.appspot.com/
14688022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200950
0039d316-1c4b-4281-b951-
d872f2087c98
jorgelo@chromium.org [Sat, 18 May 2013 01:46:24 +0000 (01:46 +0000)]
Apply clone() restrictions only on amd64 temporarily.
BUG=241967
TEST=YouTube, Robot Unicorn Attack.
TBR=cevans
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15398002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200949
0039d316-1c4b-4281-b951-
d872f2087c98
thestig@chromium.org [Sat, 18 May 2013 01:46:07 +0000 (01:46 +0000)]
Valgrind: Speculatively disable VideoCaptureHostTest on Mac.
BUG=241919
TBR=groby
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15394002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200948
0039d316-1c4b-4281-b951-
d872f2087c98
tonyg@chromium.org [Sat, 18 May 2013 01:44:56 +0000 (01:44 +0000)]
[Telemetry] Create a tools/perf/run_measurement script.
This script will be used for running a measurement with a page set, file or URL.
It will be a backend for the forthcoming tools/perf/run_benchmark.
BUG=237412
TEST=tools/perf/run_measurement --browser=release page_cycler tools/perf/page_sets/page_cycler/moz.json
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/
15377002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200947
0039d316-1c4b-4281-b951-
d872f2087c98
ananta@chromium.org [Sat, 18 May 2013 01:38:13 +0000 (01:38 +0000)]
Move the plugin_list files to the plugins_common target.
The PluginList class depends on platform specific implementations of the ReadWebPluginInfo
function. This function was defined and implemented by the PluginLib class which iivs in the
plugin target. I moved this function to the PluginList class and deleted the platform specific
incarnations of the PluginLib class which only existed for this functionality.
Next step would be to link with plugin_common only in the chrome_browser target and to move the
common plugin files to the webkit\common folder.
BUG=237249
R=jamesr@chromium.org
Review URL: https://codereview.chromium.org/
15345002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200946
0039d316-1c4b-4281-b951-
d872f2087c98
tonyg@chromium.org [Sat, 18 May 2013 01:36:30 +0000 (01:36 +0000)]
[Telemetry] Allow a URL, file or directory to be passed for a page set.
Now we understand all of the following:
$ tools/perf/run_multipage_benchmarks --browser=release page_cycler tools/perf/page_sets/page_cycler/moz.json
$ tools/perf/run_multipage_benchmarks --browser=release page_cycler http://www.google.com/
$ tools/perf/run_multipage_benchmarks --browser=release page_cycler data/page_cycler/moz/bugzilla.mozilla.org/index.html
$ tools/perf/run_multipage_benchmarks --browser=release page_cycler data/page_cycler/moz/bugzilla.mozilla.org
BUG=None
TEST=All new permutations on linux
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/
15363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200944
0039d316-1c4b-4281-b951-
d872f2087c98
ccameron@chromium.org [Sat, 18 May 2013 01:36:05 +0000 (01:36 +0000)]
Make BitmapContentLayerUpdater free its SkCanvas
Free the SkCanvases when the tab is backgrounded.
Reference count the SkCanvas in the upload queue
so that it is not deleted while pending uploads are
using it.
BUG=230922
Review URL: https://chromiumcodereview.appspot.com/
15129006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200943
0039d316-1c4b-4281-b951-
d872f2087c98
alexeypa@chromium.org [Sat, 18 May 2013 01:35:47 +0000 (01:35 +0000)]
[Chromoting] Refactored worker process launching code and speeded up the desktop process launch.
This CL reduces time needed to start the desktop process in the user's session. The speed up is archieved by:
- Not using elevation on Win7 and below. Elevation is still required on Win8 in order to be able to inject Alt+Tab.
- If a launch attempt failed because of the job object not being ready, it is retried immediately after the job object is fully initialized.
- The initial delay when retrying a failed launch attempt reduced to 100ms.
Refactoring changes:
- Converted WorkerProcessLauncher classes into a single-threaded, synchronous class.
- Refactored and cleaned up the WorkerProcessLauncher::Delegate interface. The delegate can now launch the worker process asynchronously. Asynchronous events are reported by calling methods of WorkerProcessLauncher.
- WtsSessionProcessDelegate now uses GetNamedPipeClientProcessId() function to obtain the client's PID. The job object is still used to contain worker processes if there are more than one.
- WorkerProcessLauncher now limits time the worker process should start and connect back to 5 seconds.
- Handling of permanent exits codes was moved to WorkerProcessLauncher.
- WorkerProcessLauncher::Delegate now exposes the worker's handle instead of PID.
BUG=238821
TEST=remoting_unittests.WorkerProcessLauncherTest.*
Review URL: https://chromiumcodereview.appspot.com/
15077010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200942
0039d316-1c4b-4281-b951-
d872f2087c98
dgrogan@chromium.org [Sat, 18 May 2013 01:34:48 +0000 (01:34 +0000)]
ClangFormat a constructor's initializer list; update variable name.
RenameTime was originally only used in retrying a rename. Now it is used to
retry other operations as well.
BUG=
Review URL: https://chromiumcodereview.appspot.com/
14643025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200941
0039d316-1c4b-4281-b951-
d872f2087c98
erg@chromium.org [Sat, 18 May 2013 00:29:17 +0000 (00:29 +0000)]
linux_aura: Make the dragging code generic.
This refactor is being done so that content initiated drags can reuse the
nested message loop code used in the tab dragging code.
BUG=130806
Review URL: https://chromiumcodereview.appspot.com/
15317002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200936
0039d316-1c4b-4281-b951-
d872f2087c98
mmoss@chromium.org [Sat, 18 May 2013 00:25:37 +0000 (00:25 +0000)]
Also archive official interactive_ui_tests.exe for QA.
R=tap@google.com
BUG=238827
Review URL: https://codereview.chromium.org/
15131004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200935
0039d316-1c4b-4281-b951-
d872f2087c98
chrome-admin@google.com [Sat, 18 May 2013 00:18:33 +0000 (00:18 +0000)]
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200934
0039d316-1c4b-4281-b951-
d872f2087c98
jchaffraix@chromium.org [Sat, 18 May 2013 00:16:47 +0000 (00:16 +0000)]
Blink roll 150582:150602
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=150583:150602&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/
15318002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200933
0039d316-1c4b-4281-b951-
d872f2087c98
simonhatch@chromium.org [Sat, 18 May 2013 00:14:46 +0000 (00:14 +0000)]
Lower the priority of shared workers that aren't associated with the foreground tab.
This should help out less powerful devices in the case where there's a shared worker in another tab and a cpu intensive page in the foreground.
BUG=
TEST=Open a doc, see webworker running, switch tabs and check webworker's priority by outputting contents of /sys/fs/cgroup/cpu/chrome_renderers/background/cgroup.proc on ChromeOS. With an open doc in a background tab, run 720p video (ie. youtube) at fullscreen, should stay fairly smooth.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199840
Review URL: https://chromiumcodereview.appspot.com/
14137016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200932
0039d316-1c4b-4281-b951-
d872f2087c98
joi@chromium.org [Sat, 18 May 2013 00:07:07 +0000 (00:07 +0000)]
Eliminate BrowserProcess dependency from sign-in production code.
TBR=atwilson@chromium.org,phajdan.jr@chromium.org
BUG=233552
Review URL: https://chromiumcodereview.appspot.com/
15024007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200931
0039d316-1c4b-4281-b951-
d872f2087c98
cjhopman@chromium.org [Fri, 17 May 2013 23:57:41 +0000 (23:57 +0000)]
autofill_browser should depend on googleapis
wallet_client.cc uses googleapis and so autofill_browser should specify
this dependence.
This fixes the Android component build (of android_webview_apk).
Review URL: https://chromiumcodereview.appspot.com/
15295015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200929
0039d316-1c4b-4281-b951-
d872f2087c98
pkasting@chromium.org [Fri, 17 May 2013 23:44:38 +0000 (23:44 +0000)]
Remove NativeThemePainter.
BUG=none
TEST=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/
15341002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200928
0039d316-1c4b-4281-b951-
d872f2087c98
joaodasilva@chromium.org [Fri, 17 May 2013 23:38:59 +0000 (23:38 +0000)]
Fixed the supported version range of the SigninAllowed policy.
This policy was first introduced in Chrome 27, and is not supported on Chrome 26.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/
15293004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200927
0039d316-1c4b-4281-b951-
d872f2087c98
gab@chromium.org [Fri, 17 May 2013 23:36:35 +0000 (23:36 +0000)]
Move winaura specific methods and members from chrome/browser/browser_process.h to chrome/browser/browser_process_platform_part_winaura.h
Precursor CL to https://codereview.chromium.org/
14576015/
BUG=235648, 232842, 179830
Originally Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200576
Reverted: http://crrev.com/200656
The cause of the issue is that the current paradigm is such that you can still include the header from the base class although the base class is ruled out in gyp... this resulted in a Heap Corruption debug check when deleting the TestingBrowserProcessPlatformPart on WinAura since it would take its definition from browser_process_platform_part.h at compile time, but use the impl from browser_process_platform_part_aurawin.h at runtime...
This paradigm is being fixed in https://codereview.chromium.org/
14951007/ and thus simply #ifdefing the right definition in testing_browser_process_platform_part.h for now is fine.
Review URL: https://chromiumcodereview.appspot.com/
14698027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200926
0039d316-1c4b-4281-b951-
d872f2087c98
yoz@chromium.org [Fri, 17 May 2013 23:35:24 +0000 (23:35 +0000)]
Disable ExtensionCrashRecoveryTests on Linux.
Due to flaky failures.
BUG=174705
R=vitalybuka@google.com
Review URL: https://codereview.chromium.org/
15375003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200925
0039d316-1c4b-4281-b951-
d872f2087c98
reveman@chromium.org [Fri, 17 May 2013 23:32:51 +0000 (23:32 +0000)]
cc: Add WorkerPoolTest.
Initial unit test for WorkerPool.
BUG=
TEST=cc_unittests --gtest_filter=WorkerPoolTest.Basic
Review URL: https://chromiumcodereview.appspot.com/
14672040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200924
0039d316-1c4b-4281-b951-
d872f2087c98
thestig@chromium.org [Fri, 17 May 2013 23:30:45 +0000 (23:30 +0000)]
TSAN: Suppress Windows remoting_unittests races.
BUG=241939
TBR=sergeyu@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15370005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200923
0039d316-1c4b-4281-b951-
d872f2087c98
wjmaclean@chromium.org [Fri, 17 May 2013 23:28:46 +0000 (23:28 +0000)]
Remove enable-pinch-zoom-scrollbars flag.
As part of the cleanup before re-factoring code to implement the pinch virtual viewport
for fixed position elements and pinch-zoom scrollbars, we need to remove this now-obsolete flag.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/
15139006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200922
0039d316-1c4b-4281-b951-
d872f2087c98
tengs@chromium.org [Fri, 17 May 2013 23:24:25 +0000 (23:24 +0000)]
Escape commas in Chrome startup arguments for telemetry tests on CrOS.
BUG=239161
TEST=run_tests pass for tests with commas in startup arguments
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15313004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200921
0039d316-1c4b-4281-b951-
d872f2087c98
ajuma@chromium.org [Fri, 17 May 2013 23:22:38 +0000 (23:22 +0000)]
Ensure LayerTreeHostImpl's current frame time is updated every frame
LayerTreeHostImpl's current frame time is currently updated after every
draw. This means that if, in some frame, we try (and fail) to activate
the pending tree but we don't draw, then when we eventually do draw we'll
be using an old current frame time. As a result, animations started during
that frame will have an old start time, and hence will appear to jump during
the following frame.
This CL makes us update the current frame time after every frame, regardless
of whether drawing occurred during the frame.
BUG=240820
Review URL: https://chromiumcodereview.appspot.com/
15139007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200920
0039d316-1c4b-4281-b951-
d872f2087c98
thestig@chromium.org [Fri, 17 May 2013 23:20:32 +0000 (23:20 +0000)]
TSAN: Update a suppression after r200665. Sort some suppressions by bug #.
TBR=tfarina@chromium.org,joi@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15329003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200919
0039d316-1c4b-4281-b951-
d872f2087c98
jyasskin@chromium.org [Fri, 17 May 2013 23:18:35 +0000 (23:18 +0000)]
Add a non-blocking "OneShotEvent" class
to simplify code that needs to run after something has happened, and
start using it for the ExtensionService's READY notification.
This change doesn't, in itself replace any uses of NOTIFICATION_EXTENSIONS_READY, but it paves the way for doing so.
BUG=240968
R=atwilson@chromium.org, kalman@chromium.org, mpcomplete@chromium.org
Review URL: https://codereview.chromium.org/
14757022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200918
0039d316-1c4b-4281-b951-
d872f2087c98
thestig@chromium.org [Fri, 17 May 2013 23:15:22 +0000 (23:15 +0000)]
Valgrind: Remove some unused suppressions, widen a suppression, and add a new one.
BUG=101146,181082,241932
TBR=groby
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15370003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200917
0039d316-1c4b-4281-b951-
d872f2087c98
yoshiki@chromium.org [Fri, 17 May 2013 22:56:49 +0000 (22:56 +0000)]
Files.app: Remove unused private API "chrome.fileBrowserPrivate.getFileLocations".
"getFileLocations" is not used anywhere. We can remove it.
BUG=241695
TEST=Files.app
Review URL: https://chromiumcodereview.appspot.com/
15255002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200915
0039d316-1c4b-4281-b951-
d872f2087c98
danakj@chromium.org [Fri, 17 May 2013 22:53:03 +0000 (22:53 +0000)]
cc: Cache the twin tree's layer in PictureLayerImpl.
The PictureLayerImpl uses its twin layer to do various things
and every time it wants to find its twin, it has to go through
the LayerTreeImpl and its hash map.
Specifically, every time we create a Tile, we check make use
of the layer's twin, so we do this same lookup hundreds of times
per layer in order to UpdateTilePriorities.
This change makes PictureLayerImpl compute the twin layer once
and save it.
The ImplSidePaintingPerfTest.HeavyPage perf test shows the
improvement with a 10% reduction in time.
Before: *RESULT heavy_layer_tree: commit_cost= 0.97 ms/commit
After: *RESULT heavy_layer_tree: commit_cost= 0.89 ms/commit
Tests:
LayerTreeHostPictureTestTwinLayer
R=enne
BUG=239684
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15115004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200914
0039d316-1c4b-4281-b951-
d872f2087c98
achuith@chromium.org [Fri, 17 May 2013 22:52:15 +0000 (22:52 +0000)]
Revert 197422 "Join load-extension arguments using semicolons in..."
We patched dbus-send, so this patch is no longer needed.
BUG=240540,234781
> Join load-extension arguments using semicolons instead of commas
> due to an issue with dbus-send not tokenizing commas correctly
>
> BUG=234781
> TEST=MultipleExtensionTest.testMultipleExtensions passes on cros-chrome
> NOTRY=true
>
> Review URL: https://chromiumcodereview.appspot.com/
14659002
TBR=tengs@chromium.org
Review URL: https://codereview.chromium.org/
15357004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200913
0039d316-1c4b-4281-b951-
d872f2087c98
kkania@chromium.org [Fri, 17 May 2013 22:51:48 +0000 (22:51 +0000)]
[chromedriver] Remove unnecessary 'background' permission from extension manifest.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15348004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200912
0039d316-1c4b-4281-b951-
d872f2087c98
achuith@chromium.org [Fri, 17 May 2013 22:50:02 +0000 (22:50 +0000)]
Revert 197227 "Change load-extension command line argument to us..."
We patched dbus-send on cros, so this workaround is not needed.
BUG=240540,234781
> Change load-extension command line argument to use semicolon as a delimiter for each extension to load in addition to commas
>
> This is a workaround for an issue in which dbus-send does not permit commas in arrays of strings.
>
> BUG=234781
> TEST=new unit tests for delimiters
>
> Review URL: https://chromiumcodereview.appspot.com/
13863019
TBR=tengs@chromium.org
Review URL: https://codereview.chromium.org/
15349003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200911
0039d316-1c4b-4281-b951-
d872f2087c98
phajdan.jr@chromium.org [Fri, 17 May 2013 22:46:18 +0000 (22:46 +0000)]
Fix compile_test.py for CXX values that contain spaces.
One example is CXX="ccache g++".
Using shell=True seems to be a worse option - we'd have to
construct a string to pass to bash -c, instead of building
a nice argv array.
BUG=none
R=mark@chromium.org
Review URL: https://codereview.chromium.org/
14813020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200910
0039d316-1c4b-4281-b951-
d872f2087c98
chrome-admin@google.com [Fri, 17 May 2013 22:45:31 +0000 (22:45 +0000)]
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200909
0039d316-1c4b-4281-b951-
d872f2087c98
niklase@chromium.org [Fri, 17 May 2013 22:43:27 +0000 (22:43 +0000)]
revert r200895
TBR=yoz@chromium.org
Review URL: https://codereview.chromium.org/
15254007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200908
0039d316-1c4b-4281-b951-
d872f2087c98
yoz@chromium.org [Fri, 17 May 2013 22:41:13 +0000 (22:41 +0000)]
Disable WebViewInteractiveTest.NewWindow on all platforms.
Flakily crashes, including on trybots.
BUG=241912
TBR=fsamuel@chromium.org
Review URL: https://codereview.chromium.org/
15254006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200907
0039d316-1c4b-4281-b951-
d872f2087c98
kkania@chromium.org [Fri, 17 May 2013 22:34:15 +0000 (22:34 +0000)]
[chromedriver] Fix mac bot which is using wrong bitness of python.
The scripts were upgraded to use python2.7 (somewhere), which doesn't work with
VERSIONER_PYTHON_PREFER_32_BIT=yes. Instead of using sys.executable, use
'python' on mac.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15357003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200906
0039d316-1c4b-4281-b951-
d872f2087c98
jyasskin@chromium.org [Fri, 17 May 2013 22:32:26 +0000 (22:32 +0000)]
If OFFICIAL_BUILD is set on any platform, omit DCHECKs in Release mode.
This allows GYP_DEFINES="branding=Chromium buildtype=Official" to
remove DCHECKS on Linux. I haven't tested Mac.
BUG=16512
R=mark@chromium.org
Review URL: https://codereview.chromium.org/
14896010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200905
0039d316-1c4b-4281-b951-
d872f2087c98
jered@chromium.org [Fri, 17 May 2013 22:26:45 +0000 (22:26 +0000)]
InstantExtended: Reload when re-accepting search terms.
Previously when focusing in the omnibox and pressing enter while it
showed search results, we would re-classify the match based on the
query terms. Instead, we should refresh the search page. Not doing so
is a potential security problem and is inconsistent UI behavior, because
something that says "Search" should really do a search.
TEST=Manually and browsertest
BUG=173483,226841
Review URL: https://chromiumcodereview.appspot.com/
14752021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200904
0039d316-1c4b-4281-b951-
d872f2087c98
thestig@chromium.org [Fri, 17 May 2013 22:24:42 +0000 (22:24 +0000)]
Valgrind: Suppress a Blink leak and speculative disable some tests for Mac.
BUG=241892, 241919
TBR=groby
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15254005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200902
0039d316-1c4b-4281-b951-
d872f2087c98
binji@chromium.org [Fri, 17 May 2013 22:20:41 +0000 (22:20 +0000)]
[NaCl SDK] Add pepper_28 bundle, remove pepper_22 bundle.
BUG=none
R=sbc@chromium.org
Review URL: https://codereview.chromium.org/
15333004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200901
0039d316-1c4b-4281-b951-
d872f2087c98
cbentzel@chromium.org [Fri, 17 May 2013 22:16:27 +0000 (22:16 +0000)]
[downloads] Remove erroneous comment about redirects.
DownloadResourceHandler may go through redirects for non-navigation triggered downloads, such as "Save Link As..." or extension triggered downloads.
BUG=114487
Review URL: https://chromiumcodereview.appspot.com/
15299006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200900
0039d316-1c4b-4281-b951-
d872f2087c98
kkania@chromium.org [Fri, 17 May 2013 22:07:48 +0000 (22:07 +0000)]
[chromedriver] Disable 4 failing keyboard input tests.
A fix for 3 is in review, and the 4th is firefox-specific.
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15347003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200899
0039d316-1c4b-4281-b951-
d872f2087c98
senorblanco@chromium.org [Fri, 17 May 2013 22:03:28 +0000 (22:03 +0000)]
Revert r200891, "Added MIPS DSPr2 optimization for BGRAConvolve2D routine."
This reverts commit
7d4175c20e5c3608b9b918499aedfc4a6006932d.
TBR=
Review URL: https://codereview.chromium.org/
15352002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200898
0039d316-1c4b-4281-b951-
d872f2087c98
vandebo@chromium.org [Fri, 17 May 2013 21:58:33 +0000 (21:58 +0000)]
Find iTunes library on windows.
BUG=234837
Review URL: https://chromiumcodereview.appspot.com/
14611014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200897
0039d316-1c4b-4281-b951-
d872f2087c98
chrome-admin@google.com [Fri, 17 May 2013 21:51:48 +0000 (21:51 +0000)]
Update .DEPS.git
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200896
0039d316-1c4b-4281-b951-
d872f2087c98
niklase@chromium.org [Fri, 17 May 2013 21:49:20 +0000 (21:49 +0000)]
Roll WebRTC r4032:r4061
R=ronghuawu@chromium.org, wjia@chromium.org
Review URL: https://codereview.chromium.org/
15296012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200895
0039d316-1c4b-4281-b951-
d872f2087c98
kkania@chromium.org [Fri, 17 May 2013 21:48:48 +0000 (21:48 +0000)]
[chromedriver] Some improvments to alert handling.
-Don't set override prompt text if sendKeys isn't called
-Return kOk if command is blocked on an alert
-Wait for window loads before checking for alerts
-Don't hang if alerts block navigation
BUG=chromedriver:110,chromedriver:211
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/
15113004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200894
0039d316-1c4b-4281-b951-
d872f2087c98
grv@chromium.org [Fri, 17 May 2013 21:45:13 +0000 (21:45 +0000)]
Make item_id selectable in apps-devtool.
BUG=237321
Review URL: https://chromiumcodereview.appspot.com/
14593009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200893
0039d316-1c4b-4281-b951-
d872f2087c98
pkasting@chromium.org [Fri, 17 May 2013 21:42:11 +0000 (21:42 +0000)]
Remove some more pieces of web intents.
BUG=173194
TEST=none
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/
15333007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200892
0039d316-1c4b-4281-b951-
d872f2087c98
senorblanco@chromium.org [Fri, 17 May 2013 21:36:44 +0000 (21:36 +0000)]
Added MIPS DSPr2 optimization for BGRAConvolve2D routine.
The following routines are optimized:
- ConvolveVertically
- ConvolveHorizontally
Performance gain measured on Malta 74Kc board:
- our standalone test/bench application ~45%
- chromium unit_test ~20%
R=hubbe@chromium.org, senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
14929006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200891
0039d316-1c4b-4281-b951-
d872f2087c98
scottmg@chromium.org [Fri, 17 May 2013 21:24:47 +0000 (21:24 +0000)]
remove wrong chrome_split_dll ifdefs
In an attempt to get the renderer to load. These were supposed to
be refactored to split the affected files into two parts, but that will be
attempted later.
TBR=jam@chromium.org
R=cpu@chromium.org
BUG=237249
Review URL: https://chromiumcodereview.appspot.com/
14702007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200890
0039d316-1c4b-4281-b951-
d872f2087c98
tonyg@chromium.org [Fri, 17 May 2013 21:22:42 +0000 (21:22 +0000)]
[Telemetry] Remove arstechnica from typical_25 page set.
It flakily times out on mac.
BUG=None
TEST=None
TBR=dtu@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/
15342002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200887
0039d316-1c4b-4281-b951-
d872f2087c98
tfarina@chromium.org [Fri, 17 May 2013 21:16:58 +0000 (21:16 +0000)]
content: Extract url utility functions into url_utils.{h,cc}
BUG=104549
R=joi@chromium.org,asanka@chromium.org
TBR=thestig@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
15021020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200885
0039d316-1c4b-4281-b951-
d872f2087c98
dmazzoni@chromium.org [Fri, 17 May 2013 21:15:45 +0000 (21:15 +0000)]
Add an accessible name for the Chrome OS Launcher.
Previously the items in the launcher were accessible, but there was
no context.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/
14940003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200884
0039d316-1c4b-4281-b951-
d872f2087c98
binji@chromium.org [Fri, 17 May 2013 21:11:51 +0000 (21:11 +0000)]
[NaCl SDK] Updating a bundle shouldn't merge the new and old archives.
And reinstall shouldn't try to download the entire list of archives, either.
BUG=241174
R=sbc@chromium.org
Review URL: https://codereview.chromium.org/
14791020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200882
0039d316-1c4b-4281-b951-
d872f2087c98
stevenjb@chromium.org [Fri, 17 May 2013 21:11:13 +0000 (21:11 +0000)]
Handle NetworkConnectionHandler errors in NetworkStateListDetailedView
Explicitly handle different error types in NetworkStateListDetailedView
with NetworkConnectionHandler enabled.
Modifies the SystemTrayDelegate interface for new Handler code in
preparation of removing old code.
BUG=235243
R=gspencer@chromium.org
Review URL: https://codereview.chromium.org/
14762016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200881
0039d316-1c4b-4281-b951-
d872f2087c98
raymes@chromium.org [Fri, 17 May 2013 20:54:00 +0000 (20:54 +0000)]
Hook up V8<->Var conversion in the pepper message channel
This hooks up V8<->Var conversion in the pepper message channel so that Array/Dictionaries can be transmitted to and from the plugin using Post/HandleMessage.
This CL also adds integration tests for transmitting Arrays/Dictionaries.
BUG=236958
Review URL: https://chromiumcodereview.appspot.com/
14636009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200880
0039d316-1c4b-4281-b951-
d872f2087c98
rkc@chromium.org [Fri, 17 May 2013 20:47:19 +0000 (20:47 +0000)]
Add tests for the Audio Extension API.
Add basic test coverage for the audio extension API. This CL adds tests for the three methods in the Audio API testing various combinations of active and inactive devices. This CL also fixes two bugs that the tests found.
a.) We weren't updating the mute value for a device when getting them, fixed that.
b.) We were setting unsetting the mute for a device if it had a volume or a gain - this is incorrect since a device can have a volume and still be muted. When it gets unmuted, it would start playing at the volume it has.
Reviews requested,
owner's review: mpcomplete@
audio api changes: hshi@
cras changes: jennyz@
R=hshi@chromium.org, jennyz@chromium.org, mpcomplete@chromium.org
BUG=239227
TEST=Ran the tests to ensure that they pass.
Review URL: https://codereview.chromium.org/
14945010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200879
0039d316-1c4b-4281-b951-
d872f2087c98
gbillock@chromium.org [Fri, 17 May 2013 20:35:55 +0000 (20:35 +0000)]
[Media Galleries] Move all name generation to dialog controller.
R=vandebo@chromium.org
BUG=152808,158600,159671
Review URL: https://chromiumcodereview.appspot.com/
14698017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200878
0039d316-1c4b-4281-b951-
d872f2087c98
ananta@chromium.org [Fri, 17 May 2013 20:32:06 +0000 (20:32 +0000)]
Remove the dependency on 'glue' from the browser target as this is no longer needed with common code
being factored out to 'glue_common'.
Next step is to get rid of the dependency on 'plugins', which should hopefully get rid of the dependency on webkit.
BUG=237249
R=cpu@chromium.org
Review URL: https://codereview.chromium.org/
15068018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200877
0039d316-1c4b-4281-b951-
d872f2087c98
tonyg@chromium.org [Fri, 17 May 2013 20:27:58 +0000 (20:27 +0000)]
[Telemetry] Remove walla from intl_ar_fa_he page set.
It flakily times out on windows and mac.
BUG=None
TEST=Ran intl_ar_fa_he page_cycler on windows
NOTRY=True
TBR=dtu@chromium.org
Review URL: https://codereview.chromium.org/
15323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200876
0039d316-1c4b-4281-b951-
d872f2087c98
lliabraa@chromium.org [Fri, 17 May 2013 20:18:43 +0000 (20:18 +0000)]
Include component_resources in iOS builds.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/
15294009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200875
0039d316-1c4b-4281-b951-
d872f2087c98