git/chromium.git
20 hours agoUpdating trunk VERSION from 1949.0 to 1950.0 trunk trunk
chrome-release@google.com [Sat, 19 Apr 2014 16:39:04 +0000 (16:39 +0000)]
Updating trunk VERSION from 1949.0 to 1950.0

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264924 0039d316-1c4b-4281-b951-d872f2087c98

31 hours agoFix an issue that video surface view will block infobar
qinmin@chromium.org [Sat, 19 Apr 2014 05:24:26 +0000 (05:24 +0000)]
Fix an issue that video surface view will block infobar

When entering fullscreen video, the surface view's size is set to the size of the screen if video size is unknown.
That blocks the display of infobar.
For EME video, however, the user has to acknowledge the infobar before the video starts to play.
And since the infobar is blocked, user cannot acknowledge the infobar. And thus video won't play.

BUG=364880

Review URL: https://codereview.chromium.org/243123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264922 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoEnable QUIC version 16.
rch@chromium.org [Sat, 19 Apr 2014 04:09:59 +0000 (04:09 +0000)]
Enable QUIC version 16.

Review URL: https://codereview.chromium.org/243803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264921 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoMojo: Mojom: Fix no-namespace handling for C++ generator.
viettrungluu@chromium.org [Sat, 19 Apr 2014 03:54:30 +0000 (03:54 +0000)]
Mojo: Mojom: Fix no-namespace handling for C++ generator.

Note that, in python, foo.split('.') returns [foo] if foo doesn't
contain '.'. This is what we want if foo is nonempty, but not what we
want if it isn't.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/243733004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264920 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoGVDAH: Remove the NOTIFY_ERROR() macro.
posciak@chromium.org [Sat, 19 Apr 2014 03:34:22 +0000 (03:34 +0000)]
GVDAH: Remove the NOTIFY_ERROR() macro.

The way it is right now (with a `;') will not work as
expected if used under a non-braced if-else. This is
actually already happening in GVDAH::Send().

We could fix that, but it's not providing us too much value
here, so get rid of it instead.

BUG=None
TEST=Compile and run

Review URL: https://codereview.chromium.org/242943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264919 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoFix the output request size for AudioBufferConverter requests.
dalecurtis@chromium.org [Sat, 19 Apr 2014 03:33:29 +0000 (03:33 +0000)]
Fix the output request size for AudioBufferConverter requests.

Previously too little data was converted because the code was
incorrectly assuming the FIFO was enabled.

BUG=364990
TEST=new unittest
TBR=scherkus

Review URL: https://codereview.chromium.org/243573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264918 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoRevert "Remove notifications from PrintPreviewDialogController."
avi@chromium.org [Sat, 19 Apr 2014 03:27:27 +0000 (03:27 +0000)]
Revert "Remove notifications from PrintPreviewDialogController."

This essentially reverts r243252.

BUG=170921,359627
TEST=as in bug

Review URL: https://codereview.chromium.org/243703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264917 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoClear failed browser-initiated navigations if blank tab is modified.
creis@chromium.org [Sat, 19 Apr 2014 03:26:24 +0000 (03:26 +0000)]
Clear failed browser-initiated navigations if blank tab is modified.

BUG=355537
TEST=Create a popup tab with a slow URL, type in a 204 URL, and then have
     the opener try to inject content into the popup.  Omnibox should
     reset to about:blank.

Review URL: https://codereview.chromium.org/243493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264916 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoMojo: Add JavaScript documentation for the core, support, and unicode modules.
mpcomplete@chromium.org [Sat, 19 Apr 2014 03:25:53 +0000 (03:25 +0000)]
Mojo: Add JavaScript documentation for the core, support, and unicode modules.

The documentation is in the form of stub files placed at the path you would
expect to find the module. I also renamed these modules to be in the "public"
mojo namespace.

Review URL: https://codereview.chromium.org/235953015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264915 0039d316-1c4b-4281-b951-d872f2087c98

33 hours agoUse VAO for default_vertex_attrib_manager if available.
vmiura@chromium.org [Sat, 19 Apr 2014 03:25:17 +0000 (03:25 +0000)]
Use VAO for default_vertex_attrib_manager if available.

By using VAO's we can make virtual context switches faster
by a single glBindVertexArrayOES instead of restoring all
attributes one-by-one.

BUG=244701, 363785

Review URL: https://codereview.chromium.org/229883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264914 0039d316-1c4b-4281-b951-d872f2087c98

34 hours agoImplement chromeos::SimpleGeolocationProvider.
alemate@chromium.org [Sat, 19 Apr 2014 02:36:01 +0000 (02:36 +0000)]
Implement chromeos::SimpleGeolocationProvider.

Implement chromeos::SimpleGeolocationProvider to be used in ChromeOS
code instead of WEB geolocation.

BUG=356270
TEST=manual

Review URL: https://codereview.chromium.org/237963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264913 0039d316-1c4b-4281-b951-d872f2087c98

34 hours agoFirst cut at a ServiceWorkerStorage interface and using it from within the [un]regist...
michaeln@chromium.org [Sat, 19 Apr 2014 02:33:32 +0000 (02:33 +0000)]
First cut at a ServiceWorkerStorage interface and using it from within the [un]registration jobs to store and retrieve registration data. Nothing is stored on disk yet. This cl mostly spells out the interface and contains a set of unittests to check (some of) the spec'd behavior. The implementation of the interface is completely temporary and will be replaced with something that reads/writes to disk soon'ish (more tests will come too). Also retrofitted the [un]registration jobs to use the newly defined interface.

BUG=364247
TEST=service_worker_storage_unittest.cc + existing tests

Review URL: https://codereview.chromium.org/224913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264912 0039d316-1c4b-4281-b951-d872f2087c98

34 hours agoSwap button order on mac restart alert
ilevy@chromium.org [Sat, 19 Apr 2014 02:21:07 +0000 (02:21 +0000)]
Swap button order on mac restart alert

Switch the order of the buttons on the mac restart alert,
which makes the default action 'Restart'.  I believe this
is justified since the dialog is only shown after the user
clicks 'Update' in settings.

BUG=None

Review URL: https://codereview.chromium.org/57713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264911 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agoHttpServer: allows sending raw response data for streamed responses.
gunsch@chromium.org [Sat, 19 Apr 2014 02:12:40 +0000 (02:12 +0000)]
HttpServer: allows sending raw response data for streamed responses.

Note: this was cloned from https://codereview.chromium.org/212683006/, which was reverted for ASAN issues. Patch-set 1 is the original CL, patch-set 2 is the ASAN fixes.

BUG=347770
R=rsleevi@chromium.org,lcwu@chromium.org,mef@chromium.org,byungchul@chromium.org

Review URL: https://codereview.chromium.org/243743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264910 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agoFix punctuation and remove a word from extension permission warnings.
meacer@chromium.org [Sat, 19 Apr 2014 02:09:05 +0000 (02:09 +0000)]
Fix punctuation and remove a word from extension permission warnings.

BUG=362794
TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/236233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264909 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agocc: Add visible_rect_for_tile_priority draw properties
boliu@chromium.org [Sat, 19 Apr 2014 02:02:28 +0000 (02:02 +0000)]
cc: Add visible_rect_for_tile_priority draw properties

Maintain a separate visible_rect just for calculating tile priority.
If viewport for a draw is not valid for calculating tile priority, then
skip updating this separate rect. This way, there is no need to skip
code that might have other side effects if viewport is invalid.

BUG=341183, 350675

Review URL: https://codereview.chromium.org/238063014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264908 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agoExpose locations in the chrome.automation API
aboxhall@chromium.org [Sat, 19 Apr 2014 02:01:32 +0000 (02:01 +0000)]
Expose locations in the chrome.automation API

BUG=309681

Review URL: https://codereview.chromium.org/242093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264907 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agoPromote Apps Developer Tools in the chrome:extensions page
rdevlin.cronin@chromium.org [Sat, 19 Apr 2014 01:58:48 +0000 (01:58 +0000)]
Promote Apps Developer Tools in the chrome:extensions page

If a user does not have the Apps Developer Tools installed, display a promotion
for it under the Developer Tools controls (the promo only shows up in Dev Mode).

The promo will go away (or not appear in the first place) if the user has ADT
installed.

BUG=312396

Review URL: https://codereview.chromium.org/196413028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264906 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agoFixed multi-monitor mouse coordinates.
jamiewalch@chromium.org [Sat, 19 Apr 2014 01:50:29 +0000 (01:50 +0000)]
Fixed multi-monitor mouse coordinates.

BUG=359334

Review URL: https://codereview.chromium.org/243943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264905 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agorAc: remove some unnecessary code now that the Autofill popup hides itself in a bette...
dbeam@chromium.org [Sat, 19 Apr 2014 01:50:04 +0000 (01:50 +0000)]
rAc: remove some unnecessary code now that the Autofill popup hides itself in a better way.

R=estade@chromium.org
BUG=259529

Review URL: https://codereview.chromium.org/242153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264904 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agoFix painting glitches in menus which shows up when switching selected items.
ananta@chromium.org [Sat, 19 Apr 2014 01:22:28 +0000 (01:22 +0000)]
Fix painting glitches in menus which shows up when switching selected items.

We lose pixels when the selection is drawn due to scaling up by the device scale factor which occurs in skia. When the selection is lost the invalid rect is then scaled in the compositor to convert it to pixels. This conversion
floors the size after scaling which causes us to paint less pixels.

Fix is to scale up and ceil the size on the same lines as skia. For this we use the ToEnclosingRect helper
function after scaling.

BUG=350312
R=sky

Review URL: https://codereview.chromium.org/242443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264903 0039d316-1c4b-4281-b951-d872f2087c98

35 hours agoMoar cleanup in the Mac Bluetooth code:
isherman@chromium.org [Sat, 19 Apr 2014 01:20:01 +0000 (01:20 +0000)]
Moar cleanup in the Mac Bluetooth code:

* Remove unneeded ui_task_runner variables and DCHECKs in more places.
* Simplify some forward-declarations.
* And a few other minor tweaks.

BUG=none
TEST=none (no functional change expected)
R=rpaquay@chromium.org

Review URL: https://codereview.chromium.org/238263009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264902 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agoAdd log for recording calls for setting audio input mute/unmute.
jennyz@chromium.org [Sat, 19 Apr 2014 01:18:53 +0000 (01:18 +0000)]
Add log for recording calls for setting audio input mute/unmute.

BUG=364921

Review URL: https://codereview.chromium.org/243523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264901 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agogpu: Use ARB_sync extension for GLFence implementation when GL version is OpenGL...
reveman@chromium.org [Sat, 19 Apr 2014 01:18:28 +0000 (01:18 +0000)]
gpu: Use ARB_sync extension for GLFence implementation when GL version is OpenGL ES 3.

This increases the number of configurations for which fences are
supported.

BUG=269808,356871

Review URL: https://codereview.chromium.org/242113011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264900 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agoRemove workaround for an old bug in WCS.
sergeyu@chromium.org [Sat, 19 Apr 2014 01:04:48 +0000 (01:04 +0000)]
Remove workaround for an old bug in WCS.

Previously WCS would not always set correct IDs in the responses. We
worked this problem around by trying to match pending request to each
response, even when they have different IDs. That doesn't make sense
anymore because the WCS bug was fixed long time ago.

Review URL: https://codereview.chromium.org/240023006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264899 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agoLoad libaddressinput rules for input forms with hidden country dropdown.
rouslan@chromium.org [Sat, 19 Apr 2014 00:55:41 +0000 (00:55 +0000)]
Load libaddressinput rules for input forms with hidden country dropdown.

Wallet billing details hide the country dropdown, which prevents loading
of libaddressinput rules for the Wallet billing country. (Rules are
loaded for the default shipping/billing country and when a country
dropdown changes value.) The fix is to load libaddressinput rules for
the country in the hidden input field.

BUG=363349

Review URL: https://codereview.chromium.org/239803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264898 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agoRevert 264756 "[Telemetry] Symbolize crash stacks on Windows."
oysteine@chromium.org [Sat, 19 Apr 2014 00:49:19 +0000 (00:49 +0000)]
Revert 264756 "[Telemetry] Symbolize crash stacks on Windows."

Likely cause of https://code.google.com/p/chromium/issues/detail?id=365041

> [Telemetry] Symbolize crash stacks on Windows.
>
> BUG=223572
>
> Review URL: https://codereview.chromium.org/239873002

TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/244003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264897 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agoAdd line numbers to error console
rdevlin.cronin@chromium.org [Sat, 19 Apr 2014 00:48:05 +0000 (00:48 +0000)]
Add line numbers to error console
BUG=364529

Review URL: https://codereview.chromium.org/243683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264896 0039d316-1c4b-4281-b951-d872f2087c98

36 hours agoFrameTreeNode: Make it safe for WebContentsObservers to look at
nick@chromium.org [Sat, 19 Apr 2014 00:35:20 +0000 (00:35 +0000)]
FrameTreeNode: Make it safe for WebContentsObservers to look at
the frame tree while inside of RenderFrameDeleted(). This means
doing the removal before the delete, since the delete is what
triggers observation.

Add two tests that would crash without this fix.

BUG=304341
TEST=content_unittests

Review URL: https://codereview.chromium.org/242613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264893 0039d316-1c4b-4281-b951-d872f2087c98

37 hours ago[NaCl SDK] Improve low level logging system for nacl_io.
sbc@chromium.org [Sat, 19 Apr 2014 00:14:34 +0000 (00:14 +0000)]
[NaCl SDK] Improve low level logging system for nacl_io.

We still need a higher level logging system that goes do through
the C library but this facitity is very useful for debugging
and working on nacl_io.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/243633007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264892 0039d316-1c4b-4281-b951-d872f2087c98

37 hours ago[NaCl SDK] nacl_io: fix linux native build of nacl_io.
sbc@chromium.org [Sat, 19 Apr 2014 00:06:38 +0000 (00:06 +0000)]
[NaCl SDK] nacl_io: fix linux native build of nacl_io.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/243663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264891 0039d316-1c4b-4281-b951-d872f2087c98

37 hours agoLand Recent QUIC Changes.
rtenneti@chromium.org [Fri, 18 Apr 2014 23:44:37 +0000 (23:44 +0000)]
Land Recent QUIC Changes.

Disable QuicFlowController for QUIC versions < QUIC_VERSION_17

Chrome Beta was happily advertising a flow control receive window of
length 0, under the assumption that because the version of QUIC being
spoken didn't support flow control, a zero length window advertisement
would have no adverse effects.

On the server end, the refactoring in internal change: 64733866 resulted
in the QUIC version not being checked when querying
QuicFlowController::IsBlocked. IsBlocked would look at the client's
advertised receive window, and conclude that no data could be sent. This
would never change as the flow control accounting is protected behind
version checks.

Ultimately this means that once a stream was marked as write blocked, it
would never resume writing:

https://codereview.chromium.org/242453002/diff/1/net/quic/quic_session.cc?context=&column_width=80
(line# 286) resulting in a connection timeout.

This CL explicitly disables the QuicFlowController when the negotiated
QUIC version is < QUIC_VERSION_17.

Merge internal change: 65137349

This internal change was LGTM'ed by rch. Wanted to port this change
to disable flow control.

https://codereview.chromium.org/242583002/

Downgrading rst stream codes which wouldn't be recognized by the peer.

chromium: fixed chromium's unit tests to use AdjustErrorForVersion.

Merge internal change: 64783797
https://codereview.chromium.org/242483002/

Added WriteResult::WriteResult method for internal use.

Merge internal change: 64780998
https://codereview.chromium.org/242293003/

QUIC: When sending a RST stream for flow control accounting purposes,
include a more descriptive error code.

Prompted by alyssar's comment in internal change: 61236803

Chromium specific code:
+ deleted unused ConstructRstPacket method from
QuicNetworkTransactionTest.
+ Changed ConstructRstPacket to use the new descriptive error code.

Merge internal change: 64774941
https://codereview.chromium.org/242093003/

Pull out flow control functionality from ReliableQuicStream into a new
class, QuicFlowController.

Without this refactoring, all the accounting of bytes
sent/buffered/consumed, comparisons of these with limits to decide if
blocked or not, will be duplicated in ReliableQuicStream and
QuicConnection. Putting all this in a new class means it's easier to
have more comprehensive testing, simplifies ReliableQuicStream, and will
make it much easier to add Connection level flow control (work in
progress internal change: 63944402).

Refactor of QUIC stream flow control. No behavior change, still
protected behind FLAGS_enable_quic_stream_flow_control. This flag is
currently disabled.

Merge internal change: 64733866
https://codereview.chromium.org/242453002/

Plumbs through delta_largest_observed from
QuicSentPackerManager::HandleAckForSentPacket, up to the
QuicAckNotifier. Eventually these values get to the
QuicFasterStatsGatherer which now performs a more accurate RT
calculation.

The important changes are in QuicSentPacketManager (pulling the delta
out of ReceivedInfo), and in QuicFasterStatsGatherer (doing the new
calculation of RT). The rest is plumbing and updating tests.

Improve accuracy of QUIC FasterStats RT calculation by using the
delta time included with delayed ACKs.

Merge internal change: 64721749
https://codereview.chromium.org/241783002/

Fixed a bug in QuicPacketCreator when FEC was used for unsupported
versions, and made packet_creator tests run across all supported
versions of QUIC.

Merge internal change: 64701677
https://codereview.chromium.org/241483004/

Fix to ensure hybrid slow start is reset when QUIC's retransmission
timer fires.

Merge internal change: 64698621
https://codereview.chromium.org/241563002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/242593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264889 0039d316-1c4b-4281-b951-d872f2087c98

37 hours ago[Hotword] Disabling the extension on install should only occur if it was auto-installed.
rlp@chromium.org [Fri, 18 Apr 2014 23:41:46 +0000 (23:41 +0000)]
[Hotword] Disabling the extension on install should only occur if it was auto-installed.

BUG=364853

Review URL: https://codereview.chromium.org/243083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264888 0039d316-1c4b-4281-b951-d872f2087c98

37 hours agodisable more stacktrace usage in debug uclibc builds
mostynb@opera.com [Fri, 18 Apr 2014 23:40:16 +0000 (23:40 +0000)]
disable more stacktrace usage in debug uclibc builds

Here are a couple more instances of OutputToStream / Print that are
no longer available in uClibc builds.

BUG=361130

Review URL: https://codereview.chromium.org/234803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264887 0039d316-1c4b-4281-b951-d872f2087c98

37 hours agobase::Thread will store its |name| as a string, so take the name as a string
pkasting@chromium.org [Fri, 18 Apr 2014 23:32:40 +0000 (23:32 +0000)]
base::Thread will store its |name| as a string, so take the name as a string
instead of a char*.

Avoids a bunch of pointless c_str()s on the caller sides.

BUG=none
TEST=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/243863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264886 0039d316-1c4b-4281-b951-d872f2087c98

37 hours ago[Hotword] Making the helper function only wake up on google.com/NTP or when enabled.
rlp@chromium.org [Fri, 18 Apr 2014 23:26:52 +0000 (23:26 +0000)]
[Hotword] Making the helper function only wake up on google.com/NTP or when enabled.

BUG=358268

Review URL: https://codereview.chromium.org/223553006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264885 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoRemove RenderWidget's asynchronous swap support.
jbauman@chromium.org [Fri, 18 Apr 2014 23:17:27 +0000 (23:17 +0000)]
Remove RenderWidget's asynchronous swap support.

This is never enabled now that DoDeferredUpdate is gone.

BUG=

Review URL: https://codereview.chromium.org/241993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264884 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoConvert 8 more page sets in perf/page_sets to python.
nednguyen@google.com [Fri, 18 Apr 2014 23:09:03 +0000 (23:09 +0000)]
Convert 8 more page sets in perf/page_sets to python.

BUG=239179

Review URL: https://codereview.chromium.org/243503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264883 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoCast: Fake video codec to help testing
hclam@chromium.org [Fri, 18 Apr 2014 23:07:44 +0000 (23:07 +0000)]
Cast: Fake video codec to help testing

This change adds a new kFakeSoftwareVideo codec to help testing. The
encoder simply encodes the frame id and whether it is a key frame. A
test is added to exercise this code.

Review URL: https://codereview.chromium.org/225013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264882 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoMojo: Add support for arrays of interface handles
darin@chromium.org [Fri, 18 Apr 2014 23:01:33 +0000 (23:01 +0000)]
Mojo: Add support for arrays of interface handles

This also fixes a TODO for closing any handles held in an Array that has not been sent.

BUG=363809

Review URL: https://codereview.chromium.org/238043009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264881 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoRemoves dependency from printing on win8_util
sky@chromium.org [Fri, 18 Apr 2014 22:58:46 +0000 (22:58 +0000)]
Removes dependency from printing on win8_util

win8_util is going away as IsSingleWindowMetroMode is always false
now.

BUG=none
TEST=none
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/242113008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264880 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoChange Service<> to ServiceConnection<> and ServiceFactory<> to ServiceConnector<>
davemoore@chromium.org [Fri, 18 Apr 2014 22:48:41 +0000 (22:48 +0000)]
Change Service<> to ServiceConnection<> and ServiceFactory<> to ServiceConnector<>

R=darin@chromium.org, ben
BUG=

Review URL: https://codereview.chromium.org/242213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264879 0039d316-1c4b-4281-b951-d872f2087c98

38 hours ago[Android] Catch NotFoundExceptions when querying gesture constants
jdduke@chromium.org [Fri, 18 Apr 2014 22:36:09 +0000 (22:36 +0000)]
[Android] Catch NotFoundExceptions when querying gesture constants

Certain Sony/Japanese devices are throwing Resources.NotFoundExceptions when
looking up scale-related gesture constants.  It's not yet clear why the lookup
is failing, but in any case such lookup failure should not crash the app.  Use
a constant fallback in these cases, scaled to the current display configuration.

BUG=363484

Review URL: https://codereview.chromium.org/243503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264878 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoAdd missing DCHECK.
avi@chromium.org [Fri, 18 Apr 2014 22:33:44 +0000 (22:33 +0000)]
Add missing DCHECK.

BUG=none
TEST=shouldn't crash

Review URL: https://codereview.chromium.org/243273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264877 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoSwitch typical_25.json to typical_25.py in session_restore benchmark.
nednguyen@google.com [Fri, 18 Apr 2014 22:29:34 +0000 (22:29 +0000)]
Switch typical_25.json to typical_25.py in session_restore benchmark.
Improve debugging message.

BUG=364142

Review URL: https://codereview.chromium.org/243333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264876 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoSuppress permission warning for chrome://favicon if tabs or history is requested.
meacer@chromium.org [Fri, 18 Apr 2014 22:28:50 +0000 (22:28 +0000)]
Suppress permission warning for chrome://favicon if tabs or history is requested.

BUG=364115

Review URL: https://codereview.chromium.org/239433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264875 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoShow settings browser windows as a separate launcher item
stevenjb@chromium.org [Fri, 18 Apr 2014 22:27:39 +0000 (22:27 +0000)]
Show settings browser windows as a separate launcher item

This also fixes an issue where the shelf id for browser windows was
getting set directly by BrowserStatusMonitor regardless of whether the
browser window was represented by BrowserShortcutLauncherItemController,
causing strange shelf behavior.

BUG=359816

Review URL: https://codereview.chromium.org/237693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264874 0039d316-1c4b-4281-b951-d872f2087c98

38 hours agoFixes crash on Mac when a page's permission is changed.
leng@chromium.org [Fri, 18 Apr 2014 22:25:17 +0000 (22:25 +0000)]
Fixes crash on Mac when a page's permission is changed.

The UI is built before the bubble's |presenter_| is set, so the block used for the
permission change callback needs a reference to |self|, not |presenter_|.

BUG=364790

Review URL: https://codereview.chromium.org/242103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264873 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoFix AppMenu ListView divider height calculation.
aurimas@chromium.org [Fri, 18 Apr 2014 22:06:27 +0000 (22:06 +0000)]
Fix AppMenu ListView divider height calculation.

Get the height of the ListView divider directly from the drawable instead
of assuming it is 1dp in height.

This fixes the bug where the scrollbar would appear for short menus on XXHDPI
devices like HTC One and Nexus 5.

BUG=331960

Review URL: https://codereview.chromium.org/241783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264867 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoTweak a settings string for Easy Unlock.
isherman@chromium.org [Fri, 18 Apr 2014 22:05:51 +0000 (22:05 +0000)]
Tweak a settings string for Easy Unlock.

"Setup" is a noun.  I'm pretty sure we want the verb "set up" instead.

BUG=none
TEST=none
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/243443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264866 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoDon't clear existing properties in SetProperties in WiFiService
tbarzic@chromium.org [Fri, 18 Apr 2014 22:04:26 +0000 (22:04 +0000)]
Don't  clear existing properties in SetProperties in WiFiService

If a property has previously been set for a network, and it's not set in
new properties, networkingPrivate.setProperties should not clear it.
Instead of new properties replacing existing ones, merge new properties
into existing ones. (This matches ChromeOS behaviour).

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/241983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264865 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoDisplay metric name when giving "Invalid metric" error.
qyearsley@chromium.org [Fri, 18 Apr 2014 21:46:34 +0000 (21:46 +0000)]
Display metric name when giving "Invalid metric" error.

The main thing in this CL is at 2032: when reporting invalid metric, also report name of metric.

This CL also contains comment/style changes.

BUG=

Review URL: https://codereview.chromium.org/241743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264863 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoenvsetup.sh no longer sets OS=android to GYP_DEFINES env due to CL/170273005. Set...
prasadv@chromium.org [Fri, 18 Apr 2014 21:41:25 +0000 (21:41 +0000)]
envsetup.sh no longer sets OS=android to GYP_DEFINES env due to CL/170273005. Set this variable explicitly in order to build chrome on android.

BUG=343632
NOTRY=true

Review URL: https://codereview.chromium.org/243573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264862 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoMojo: Move .../bindings/pylib/parse to .../bindings/pylib/mojom/parse.
viettrungluu@chromium.org [Fri, 18 Apr 2014 21:31:01 +0000 (21:31 +0000)]
Mojo: Move .../bindings/pylib/parse to .../bindings/pylib/mojom/parse.

And get rid of the mojo_... filename prefixes. I want to do this
because:
* We shouldn't use filename prefixes for disambiguation.
* parser is too vague a package name (for what it does).
* Having a mojom package containing a parser subpackage (and later a
  generate subpackage) means that I have a place to put common code (and
  the subpackages can do a relative import).
* This is more pythonic; e.g., one should theoretically be able to
  install the *contents* of pylib/ into, e.g., a system python library
  directory, and have things that import mojom.parser just work (e.g.,
  install mojom_bindings_generator.py into /usr/bin or something like
  that). (Not that one *should* do this -- it'd be a horrible idea.)
* I like moving files around.

Still to do: Move pylib/generate.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/243133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264860 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoCheck if the target window for focus is a transient child of the AppListView window...
jennyz@chromium.org [Fri, 18 Apr 2014 21:23:20 +0000 (21:23 +0000)]
Check if the target window for focus is a transient child of the AppListView window when the mouse is pressed.

BUG=364337
TBR=xiyuan

Review URL: https://codereview.chromium.org/241643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264859 0039d316-1c4b-4281-b951-d872f2087c98

39 hours agoInitialize force_compositing_mode to true in WebPreferences constructor.
earthdok@chromium.org [Fri, 18 Apr 2014 21:21:39 +0000 (21:21 +0000)]
Initialize force_compositing_mode to true in WebPreferences constructor.

Fixes uninit errors introduced by r264646.

BUG=364829
R=piman@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/243243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264858 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoUpdate .DEPS.git
chrome-admin@google.com [Fri, 18 Apr 2014 21:12:09 +0000 (21:12 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264855 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoBlink roll 171922:171956
eae@chromium.org [Fri, 18 Apr 2014 21:11:12 +0000 (21:11 +0000)]
Blink roll 171922:171956

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171922:171956&mode=html

TBR=dominicc@chromium.org

Review URL: https://codereview.chromium.org/242953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264854 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoLinux: Update sysroot script to pull new tarballs with libGL.
thestig@chromium.org [Fri, 18 Apr 2014 20:55:46 +0000 (20:55 +0000)]
Linux: Update sysroot script to pull new tarballs with libGL.

Also check the sha1sum of the downloaded file.

BUG=362277
NOTRY=true

Review URL: https://codereview.chromium.org/242643006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264852 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoClear |blacklisted_extensions_| once they are acknowledged in ErrorController
rdevlin.cronin@chromium.org [Fri, 18 Apr 2014 20:55:19 +0000 (20:55 +0000)]
Clear |blacklisted_extensions_| once they are acknowledged in ErrorController

BUG=364726

Review URL: https://codereview.chromium.org/243373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264851 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoMake FormatUrl Keep Track of Full Transformation
mpearson@chromium.org [Fri, 18 Apr 2014 20:54:44 +0000 (20:54 +0000)]
Make FormatUrl Keep Track of Full Transformation

The omnibox providers usually search for matches in the formatted text
(i.e., the escaped characters in the URL are unescaped before searching).
This makes it difficult to highlight matches in URL because the location
of the matched positions does not match the location of the matched
text in the original URL spec.  The code to adjust offsets doesn't
help here because it adjusts offsets that with respect to the original
URL spec, not offsets with respect to the formatted URL.
In effect, we need to be able to reverse the transformation that
FormatUrl() does in order to get the original offsets back (if
possible) from the transformed offsets we have.

The easiest and most efficient way to compute this reverse mapping
is to keep track of the full original mapping, then reverse it later
and apply the reversed mapping to the match offsets we have where
the offsets are with respect to the formatted string.

This change include the necessary parts to keep track of the
full transformation.

In a follow-up change, I will make HistoryQuick
provider use the transformation information.
In the process of that change, I will remove the
"WithOffsets" function from net_util.

BUG=252630

Review URL: https://codereview.chromium.org/196103008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264850 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoFix "unreachable code" warning (MSVC warning 4702) in ui/wm/core/.
pkasting@chromium.org [Fri, 18 Apr 2014 20:45:32 +0000 (20:45 +0000)]
Fix "unreachable code" warning (MSVC warning 4702) in ui/wm/core/.

BUG=346399
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/242263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264848 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoRun NaClNonSfiSandboxTest in a separate binary
hamaji@chromium.org [Fri, 18 Apr 2014 20:45:31 +0000 (20:45 +0000)]
Run NaClNonSfiSandboxTest in a separate binary

This adds a new nacl_loader_unittests. For the meantime, we
keep running the same tests in components_unittests.

TEST=ninja
BUG=364751
R=jln@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/242553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264847 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoEnsure adb is in path in adb_remote_setup.sh.
newt@chromium.org [Fri, 18 Apr 2014 20:32:30 +0000 (20:32 +0000)]
Ensure adb is in path in adb_remote_setup.sh.

Review URL: https://codereview.chromium.org/239663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264845 0039d316-1c4b-4281-b951-d872f2087c98

40 hours ago[NaCl SDK] Add multi-platform zip support, and example.
binji@chromium.org [Fri, 18 Apr 2014 20:32:26 +0000 (20:32 +0000)]
[NaCl SDK] Add multi-platform zip support, and example.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/241803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264844 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoAdd SessionRestoreTestChromeOS
stevenjb@chromium.org [Fri, 18 Apr 2014 20:23:05 +0000 (20:23 +0000)]
Add SessionRestoreTestChromeOS

This adds a set of Chrome OS specific tests for restoring windows after
a restart (log out / log in) on Chrome OS. Most significantly this tests
that trusted popup windows are restored but untrusted popups are not.

This is a follow-up CL for https://codereview.chromium.org/227623007/

BUG=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/237283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264843 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoFinalize apk takes zipalign path as argument instead of hardcoding it
yusufo@chromium.org [Fri, 18 Apr 2014 20:22:43 +0000 (20:22 +0000)]
Finalize apk takes zipalign path as argument instead of hardcoding it

zipalign tool can be in sdk/tools or sdk/build-tools. This change looks
for the right place and uses that instead of having it hardcoded inside
android_sdk_root

BUG=364655

Review URL: https://codereview.chromium.org/238253015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264842 0039d316-1c4b-4281-b951-d872f2087c98

40 hours agoImprove the handling of mock screen orientation for layout tests.
mlamouri@chromium.org [Fri, 18 Apr 2014 20:20:18 +0000 (20:20 +0000)]
Improve the handling of mock screen orientation for layout tests.

BUG=162827

Review URL: https://codereview.chromium.org/242703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264841 0039d316-1c4b-4281-b951-d872f2087c98

41 hours agoRevert 264640 "Update symupload.exe to r1316 of breakpad."
wfh@chromium.org [Fri, 18 Apr 2014 20:13:47 +0000 (20:13 +0000)]
Revert 264640 "Update symupload.exe to r1316 of breakpad."

> Update symupload.exe to r1316 of breakpad.
>
> This includes revisions up to r1316 of code.google.com/google-breakpad svn.
>
> This binary was built using VS2010 and MS DIA 10.0 and tested on Chromium bots.
>
> Incompatabilities were found with DIA 12.0 (shipped with VS2013) so advice is
> to use DIA 10.0 until these issues have been resolved.
>
> BUG=360263
> TEST=
> R=mark@chromium.org
>
> Review URL: https://codereview.chromium.org/239513013

TBR=wfh@chromium.org

Review URL: https://codereview.chromium.org/243413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264839 0039d316-1c4b-4281-b951-d872f2087c98

41 hours agoFix "unreachable code" warning (MSVC warning 4702) in
pkasting@chromium.org [Fri, 18 Apr 2014 20:12:13 +0000 (20:12 +0000)]
Fix "unreachable code" warning (MSVC warning 4702) in
chrome/utility/cloud_print/.

BUG=346399
TEST=none

Review URL: https://codereview.chromium.org/241943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264838 0039d316-1c4b-4281-b951-d872f2087c98

41 hours agoPass Reason as a parameter with OnExtensionUnloaded.
DHNishi@gmail.com [Fri, 18 Apr 2014 20:05:36 +0000 (20:05 +0000)]
Pass Reason as a parameter with OnExtensionUnloaded.

BUG=354046

Review URL: https://codereview.chromium.org/222903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264837 0039d316-1c4b-4281-b951-d872f2087c98

41 hours agoMake ExtensionMessageBubbleControllers use Profile::GetOriginalProfile().
rdevlin.cronin@chromium.org [Fri, 18 Apr 2014 19:59:12 +0000 (19:59 +0000)]
Make ExtensionMessageBubbleControllers use Profile::GetOriginalProfile().
This prevents them from showing errors for each new incognito session which
occurs.
Also move the profile checking for the SettingsAPI bubble from
ExtensionMessageBubbleView to SettingsApiBubbleController, to be more analogous
with the other controllers.

BUG=363153

Review URL: https://codereview.chromium.org/239443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264835 0039d316-1c4b-4281-b951-d872f2087c98

41 hours agoRevert 264803 "Revert 264763 "Wire up codec_delay() to MP3Stream..."
dalecurtis@google.com [Fri, 18 Apr 2014 19:58:13 +0000 (19:58 +0000)]
Revert 264803 "Revert 264763 "Wire up codec_delay() to MP3Stream..."

> Revert 264763 "Wire up codec_delay() to MP3StreamParser and FFmp..."
>
> Possible candidate for broken media_unittests:
>
> http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30043/steps/media_unittests/logs/MediaSource_MP3_TimestampOffset_0
>
> > Wire up codec_delay() to MP3StreamParser and FFmpegAudioDecoder.
> >
> > Allows us to drop silent samples from the decoder after initialization
> > and resets.
> >
> > codec_delay() is always in frames, so I've changed all call sites to use
> > frames instead of a TimeDelta.
> >
> > Coincidentally also fixes an issue where not enough data was dropped from
> > Vorbis buffers with negative timestamps.
> >
> > BUG=360961
> > TEST=new pipeline_integration_test
> >
> > Review URL: https://codereview.chromium.org/239423005
>
> TBR=dalecurtis@chromium.org
>
> Review URL: https://codereview.chromium.org/242203006

TBR=rockot@chromium.org

Review URL: https://codereview.chromium.org/243653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264834 0039d316-1c4b-4281-b951-d872f2087c98

41 hours agocc: Move raster task related trace events into debug/frame_viewer_instrumentation.h.
reveman@chromium.org [Fri, 18 Apr 2014 19:56:09 +0000 (19:56 +0000)]
cc: Move raster task related trace events into debug/frame_viewer_instrumentation.h.

These trace events are used by the trace viewer and need to use
specific names and parameters to work correctly.

BUG=

Review URL: https://codereview.chromium.org/242523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264833 0039d316-1c4b-4281-b951-d872f2087c98

41 hours ago[WebsiteSettings] Forget any outstanding permissions requests upon page navigation.
gbillock@chromium.org [Fri, 18 Apr 2014 19:20:48 +0000 (19:20 +0000)]
[WebsiteSettings] Forget any outstanding permissions requests upon page navigation.

R=leng@chromium.org
TBR=markusheintz
BUG=363735

Review URL: https://codereview.chromium.org/239333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264827 0039d316-1c4b-4281-b951-d872f2087c98

42 hours agoSupport a "policy" extension location in extension features files.
kalman@chromium.org [Fri, 18 Apr 2014 19:19:04 +0000 (19:19 +0000)]
Support a "policy" extension location in extension features files.

BUG=364536

Review URL: https://codereview.chromium.org/241673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264826 0039d316-1c4b-4281-b951-d872f2087c98

42 hours ago[Hotword, WebUI] Fix formatting for reset browser settings. The formatting became...
rlp@chromium.org [Fri, 18 Apr 2014 19:15:12 +0000 (19:15 +0000)]
[Hotword, WebUI] Fix formatting for reset browser settings. The formatting became misaligned when the same variable was used for the hotwording overlay. By giving the hotwording overlay its own id, the css for the hotwording overlay no longer affects the reset browser settings checkbox

BUG=361549

Review URL: https://codereview.chromium.org/243133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264825 0039d316-1c4b-4281-b951-d872f2087c98

42 hours agoSwitch cronet to using URLRequestContextBuilder.
mmenke@chromium.org [Fri, 18 Apr 2014 19:09:43 +0000 (19:09 +0000)]
Switch cronet to using URLRequestContextBuilder.

Also modify the URLRequestContextBuilder so that it can work just as
cronet expects (Add a NetLog, don't create/start threads if they aren't
needed).

BUG=354143

Review URL: https://codereview.chromium.org/231763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264824 0039d316-1c4b-4281-b951-d872f2087c98

42 hours agoEnsure that 200px assets are loaded for dpi scales over 1.25.
ananta@chromium.org [Fri, 18 Apr 2014 18:58:53 +0000 (18:58 +0000)]
Ensure that 200px assets are loaded for dpi scales over 1.25.

This regressed during a recent change to scale bitmap resources.

BUG=351927

Review URL: https://codereview.chromium.org/242473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264823 0039d316-1c4b-4281-b951-d872f2087c98

42 hours agoProvide UI for per-extension enabling/disabling of error collection.
rdevlin.cronin@chromium.org [Fri, 18 Apr 2014 18:54:55 +0000 (18:54 +0000)]
Provide UI for per-extension enabling/disabling of error collection.
BUG=362623

Review URL: https://codereview.chromium.org/238073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264822 0039d316-1c4b-4281-b951-d872f2087c98

42 hours agoRemove desktop auto-login since we don't plan on shipping it.
rohitrao@chromium.org [Fri, 18 Apr 2014 18:21:25 +0000 (18:21 +0000)]
Remove desktop auto-login since we don't plan on shipping it.

Removes the --enable-autologin switch and associated settings UI.  Autologin is
always enabled for Android builds.  Moves the Android-specific AutoLoginPrompter
class into an android/ directory.

iOS also uses the AutoLoginInfoBarDelegate, so that class is left where it is.

BUG=347214

Review URL: https://codereview.chromium.org/235863025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264818 0039d316-1c4b-4281-b951-d872f2087c98

43 hours agoLinux: Add libGL.so and dependencies to the Debian sysroot.
thestig@chromium.org [Fri, 18 Apr 2014 18:16:48 +0000 (18:16 +0000)]
Linux: Add libGL.so and dependencies to the Debian sysroot.

BUG=362277
NOTRY=true

Review URL: https://codereview.chromium.org/241983004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264817 0039d316-1c4b-4281-b951-d872f2087c98

43 hours agobookmarks: Remove ScopedGroupBookmarkActions's ctor that takes a Profile pointer.
tfarina@chromium.org [Fri, 18 Apr 2014 17:51:44 +0000 (17:51 +0000)]
bookmarks: Remove ScopedGroupBookmarkActions's ctor that takes a Profile pointer.

This removes an unnecessary dependency on chrome's Profile.

BUG=364486
TEST=None, no functional changes.
R=droger@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/242653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264813 0039d316-1c4b-4281-b951-d872f2087c98

43 hours ago[NaCl SDK] nacl_io: add fakes for PP_Var dictionary type.
sbc@chromium.org [Fri, 18 Apr 2014 17:44:50 +0000 (17:44 +0000)]
[NaCl SDK] nacl_io: add fakes for PP_Var dictionary type.

Currently nothing uses these but I created them as part
of a separate CL which is due to land soon and it made
sense to split them off.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/242403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264812 0039d316-1c4b-4281-b951-d872f2087c98

44 hours ago[Telemetry] Add a smoke test for page sets.
tonyg@chromium.org [Fri, 18 Apr 2014 17:03:37 +0000 (17:03 +0000)]
[Telemetry] Add a smoke test for page sets.

And fix bugs that it caught.

BUG=
TBR=nednguyen@google.com

Review URL: https://codereview.chromium.org/242153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264810 0039d316-1c4b-4281-b951-d872f2087c98

44 hours agoPepper: Move URL resolves outside trusted plugin.
teravest@chromium.org [Fri, 18 Apr 2014 16:53:04 +0000 (16:53 +0000)]
Pepper: Move URL resolves outside trusted plugin.

This moves plugin_base_url and manifest_base_url outside the trusted plugin,
pulling more state over to NexeLoadManager.

I had hoped to clean up SetIsInstalled() as part of this change, but we don't
have precise semantics for what is_installed means (yet), so I can't change how
that behaves.

BUG=239656
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/241173006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264807 0039d316-1c4b-4281-b951-d872f2087c98

44 hours agoMemorySanitizer: temporarily blacklist an uninit in WebKit.
earthdok@chromium.org [Fri, 18 Apr 2014 16:47:30 +0000 (16:47 +0000)]
MemorySanitizer: temporarily blacklist an uninit in WebKit.

Generally, blacklisting is not the proper way to deal with MSan reports. I'm
making an exception because this bug is blocking our progress entirely.

BUG=363487
TBR=ykyyip@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/243203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264806 0039d316-1c4b-4281-b951-d872f2087c98

44 hours agoInstrumented libraries: add libdbusmenu-glib4.
earthdok@chromium.org [Fri, 18 Apr 2014 16:46:54 +0000 (16:46 +0000)]
Instrumented libraries: add libdbusmenu-glib4.

BUG=313751
TBR=glider@chromium.org
NOTRY=true
TEST=MSan

Review URL: https://codereview.chromium.org/242533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264805 0039d316-1c4b-4281-b951-d872f2087c98

44 hours agoRevert "Enable layer squashing by default"
eae@chromium.org [Fri, 18 Apr 2014 16:32:49 +0000 (16:32 +0000)]
Revert "Enable layer squashing by default"

This reverts r264759 (commit 3312851699c9e09fbb50a8636a638a6a8385baa9)
as it caused the following tests to start crashing:

compositing/overflow/automatically-opt-into-composited-scrolling-after-style-change.html
compositing/overflow/automatically-opt-into-composited-scrolling-part-4.html
svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml
virtual/gpu/compositedscrolling/overflow/automatically-opt-into-composited-scrolling-after-style-change.html
virtual/gpu/compositedscrolling/overflow/automatically-opt-into-composited-scrolling-part-4.html
virtual/softwarecompositing/overflow/automatically-opt-into-composited-scrolling-after-style-change.html
virtual/softwarecompositing/overflow/automatically-opt-into-composited-scrolling-part-4.html

BUG=364860
TBR=vollick@chromium.org

Review URL: https://codereview.chromium.org/243293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264804 0039d316-1c4b-4281-b951-d872f2087c98

45 hours agoRevert 264763 "Wire up codec_delay() to MP3StreamParser and FFmp..."
rockot@chromium.org [Fri, 18 Apr 2014 16:13:19 +0000 (16:13 +0000)]
Revert 264763 "Wire up codec_delay() to MP3StreamParser and FFmp..."

Possible candidate for broken media_unittests:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30043/steps/media_unittests/logs/MediaSource_MP3_TimestampOffset_0

> Wire up codec_delay() to MP3StreamParser and FFmpegAudioDecoder.
>
> Allows us to drop silent samples from the decoder after initialization
> and resets.
>
> codec_delay() is always in frames, so I've changed all call sites to use
> frames instead of a TimeDelta.
>
> Coincidentally also fixes an issue where not enough data was dropped from
> Vorbis buffers with negative timestamps.
>
> BUG=360961
> TEST=new pipeline_integration_test
>
> Review URL: https://codereview.chromium.org/239423005

TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/242203006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264803 0039d316-1c4b-4281-b951-d872f2087c98

45 hours agoRevert 264766 "Simplify AudioSplicer logic which slots buffers b..."
rockot@chromium.org [Fri, 18 Apr 2014 16:11:58 +0000 (16:11 +0000)]
Revert 264766 "Simplify AudioSplicer logic which slots buffers b..."

Possible candidate for broken media_unittests:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/30043/steps/media_unittests/logs/MediaSource_MP3_TimestampOffset_0

> Simplify AudioSplicer logic which slots buffers before or after a splice point.
>
> Since the first post splice buffer after the config change has a splice_timestamp()
> of kNoTimestamp() we can definitively say when we have the first post splice
> buffer instead of having to relying on a problematic timestamp match.
>
> The new code makes it so that clients must always call SetSpliceTimestamp() with
> kNoTimestamp() once the first post splice buffer is received.
>
> BUG=334493
> TEST=existing tests pass.
>
> Review URL: https://codereview.chromium.org/240123004

TBR=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/243263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264802 0039d316-1c4b-4281-b951-d872f2087c98

45 hours agoRevert 264778 "[fsp] [recommit] Add an initial AsyncFileUtil."
rockot@chromium.org [Fri, 18 Apr 2014 16:01:28 +0000 (16:01 +0000)]
Revert 264778 "[fsp] [recommit] Add an initial AsyncFileUtil."

Broke Linux ChromeOS ASan:

http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29&number=938

> [fsp] [recommit] Add an initial AsyncFileUtil.
>
> This patch adds the AsyncFileUtil implementation for the file system provider.
> It does not communicate with the file system provider service yet.
>
> Currently, for not supported operations SECURITY error is returned. For
> allowed, but not implemented operations, it is NOT_FOUND error.
>
> Unit tests are quite trivial at this stage, but they will grow once more
> operations are implemented.
>
> This patch has been previously committed and reverted due to test failures.
> See: https://codereview.chromium.org/236303017/
>
> TEST=unit_test: FileSystemProviderAsyncFileUtilTest*
> BUG=248427
>
> Review URL: https://codereview.chromium.org/242493002

TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/243153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264801 0039d316-1c4b-4281-b951-d872f2087c98

45 hours agoRevert 264780 "[fsp] Add FileSystemURLParser to the file system ..."
rockot@chromium.org [Fri, 18 Apr 2014 15:59:54 +0000 (15:59 +0000)]
Revert 264780 "[fsp] Add FileSystemURLParser to the file system ..."

Dependent on 264778 which broke Linux ChromeOS ASan.

> [fsp] Add FileSystemURLParser to the file system provider.
>
> The FileSystemURLParser is a class which parses a cracked FileSystemURL to
> associate it with the proper ProvidedFileSystem class handling this URL.
>
> This will be necessary to route operations from AsyncFileUtil to a proper
> providing extension.
>
> Along the way, the Service class has been fixed. Now, the provided file systems
> are gracefully unmounted in destructor. As a result, the external mount points
> are cleared neatly.
>
> TEST=unit_tests: FileSystemProviderMountPathUtilTest*
> BUG=248427
>
> Review URL: https://codereview.chromium.org/237583015

TBR=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/242113007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264800 0039d316-1c4b-4281-b951-d872f2087c98

45 hours agoRevert 264783 "Change GetMountPointPath to GetMoutPath in test."
rockot@chromium.org [Fri, 18 Apr 2014 15:58:54 +0000 (15:58 +0000)]
Revert 264783 "Change GetMountPointPath to GetMoutPath in test."

Dependent on 264780->264778 which broke Linux ChromeOS ASan.

> Change GetMountPointPath to GetMoutPath in test.
>
> CMaking change on behalf of mtomasz.
>

TBR=bungeman@chromium.org

Review URL: https://codereview.chromium.org/243173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264799 0039d316-1c4b-4281-b951-d872f2087c98

45 hours ago[cros login] Fix a bug that prevented setting GAIA iframe focus
nkostylev@chromium.org [Fri, 18 Apr 2014 15:41:57 +0000 (15:41 +0000)]
[cros login] Fix a bug that prevented setting GAIA iframe focus

BUG=351627
R=derat@chromium.org

Review URL: https://codereview.chromium.org/243033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264796 0039d316-1c4b-4281-b951-d872f2087c98

45 hours agoPrint encoded frames per second in VEA unittest.
wuchengli@chromium.org [Fri, 18 Apr 2014 15:27:06 +0000 (15:27 +0000)]
Print encoded frames per second in VEA unittest.

BUG=345181
TEST=Run the test on CrOS.

Review URL: https://codereview.chromium.org/240133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264794 0039d316-1c4b-4281-b951-d872f2087c98

46 hours agoFix cropping by touch in Files app.
mtomasz@chromium.org [Fri, 18 Apr 2014 15:14:46 +0000 (15:14 +0000)]
Fix cropping by touch in Files app.

This patch fixes cropping by touch by adding a call to Event.preventDefault(),
which prevents default behaviour of the host.

Before, the preventDefault() call was missing, and as a result the touch was
getting cancelled.

TEST=Tested manually on Pixel.
BUG=350716

Review URL: https://codereview.chromium.org/242813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264793 0039d316-1c4b-4281-b951-d872f2087c98

46 hours agoMove Infobars core files to the Infobars component
droger@chromium.org [Fri, 18 Apr 2014 15:09:41 +0000 (15:09 +0000)]
Move Infobars core files to the Infobars component

This CL sets up the directory structure for the Infobars component and the
infobars_core target. It also does a simple code move to the compoonent.

This CL does not move ConfirmInfoBarDelegate because it still has a
dependency on chrome/ (for strings).

BUG=354379
TBR=sky, reed

Review URL: https://codereview.chromium.org/240193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264792 0039d316-1c4b-4281-b951-d872f2087c98

46 hours agoThreadWatcherList: avoid re-creating a FieldTrial.
bulach@chromium.org [Fri, 18 Apr 2014 15:08:15 +0000 (15:08 +0000)]
ThreadWatcherList: avoid re-creating a FieldTrial.

On android, ThreadWatcherList can be re-started.
It should only setup FieldTrials on the first time.

BUG=364265

Review URL: https://codereview.chromium.org/240953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264790 0039d316-1c4b-4281-b951-d872f2087c98

46 hours agoRevert 264779 "DevTools: Add browser test for port forwarding"
rockot@google.com [Fri, 18 Apr 2014 15:04:59 +0000 (15:04 +0000)]
Revert 264779 "DevTools: Add browser test for port forwarding"

This broke PortForwardingTest.LoadPageWithStyleAnsScript

http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%282%29/builds/42061/steps/browser_tests/logs/LoadPageWithStyleAnsScript
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/48774/steps/browser_tests/logs/LoadPageWithStyleAnsScript
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/48775/steps/browser_tests/logs/LoadPageWithStyleAnsScript

> DevTools: Add browser test for port forwarding
>
> BUG=356617
> TEST=out/Release/browser_tests --gtest_filter=PortForwardingTest*
>
> Review URL: https://codereview.chromium.org/240283009

TBR=kaznacheev@chromium.org

Review URL: https://codereview.chromium.org/243203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264789 0039d316-1c4b-4281-b951-d872f2087c98