playground/chromium/src.git
2 years agoMerge "Revert "Revert "dude""" master
Nicolas Sylvain [Sun, 15 Jan 2012 15:34:40 +0000 (07:34 -0800)]
Merge "Revert "Revert "dude"""

3 years agoRevert "Revert "dude"" 13/7913/1
Nicolas Sylvain [Sun, 18 Sep 2011 21:51:24 +0000 (14:51 -0700)]
Revert "Revert "dude""

This reverts commit 111b6429fd6fd790e2e84bf0727c882b3d8f2ead

3 years agoMerge "Revert "dude""
Nicolas Sylvain [Sun, 18 Sep 2011 21:51:16 +0000 (14:51 -0700)]
Merge "Revert "dude""

3 years agoRevert "dude" 34/6034/1
Nicolas Sylvain [Mon, 15 Aug 2011 23:58:58 +0000 (16:58 -0700)]
Revert "dude"

This reverts commit 7ab7ee6b4d654b95e96bf09631f5a6021926aee7

3 years agoMerge "dude"
Nicolas Sylvain [Mon, 15 Aug 2011 23:57:05 +0000 (16:57 -0700)]
Merge "dude"

3 years agoMerge ssh://gerrit.chromium.org:29418/playground/chromium/src
Nicolas Sylvain [Fri, 18 Mar 2011 01:04:32 +0000 (18:04 -0700)]
Merge ssh://gerrit.chromium.org:29418/playground/chromium/src

3 years agoAdd breakpad submodule
Nicolas Sylvain [Fri, 18 Mar 2011 00:42:50 +0000 (17:42 -0700)]
Add breakpad submodule

3 years agoMerge ssh://gerrit.chromium.org:29418/playground/chromium/src
Nicolas Sylvain [Fri, 18 Mar 2011 01:03:03 +0000 (18:03 -0700)]
Merge ssh://gerrit.chromium.org:29418/playground/chromium/src

3 years agoAdd breakpad submodule
Nicolas Sylvain [Fri, 18 Mar 2011 00:42:50 +0000 (17:42 -0700)]
Add breakpad submodule

3 years agoMerge ssh://gerrit.chromium.org:29418/playground/chromium/src
Nicolas Sylvain [Fri, 18 Mar 2011 01:00:23 +0000 (18:00 -0700)]
Merge ssh://gerrit.chromium.org:29418/playground/chromium/src

3 years agoAdd breakpad submodule
Nicolas Sylvain [Fri, 18 Mar 2011 00:42:50 +0000 (17:42 -0700)]
Add breakpad submodule

3 years agoRevert 78635 - Integrate the csd-whitelist with the rest of the client-side git-svn
noelutz@google.com [Fri, 18 Mar 2011 00:53:02 +0000 (00:53 +0000)]
Revert 78635 - Integrate the csd-whitelist with the rest of the client-side
phishing detection code.

BUG=
TEST=ClientSideDetectionHostTest

Review URL: http://codereview.chromium.org/6670053

TBR=noelutz@google.com
Review URL: http://codereview.chromium.org/6713023

git-svn-id: http://src.chromium.org/svn/trunk/src@78641 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAdd breakpad submodule 57/57/1
Nicolas Sylvain [Fri, 18 Mar 2011 00:42:50 +0000 (17:42 -0700)]
Add breakpad submodule

3 years agoMove a bunch more random files from chrome\renderer to content\renderer.
jam@chromium.org [Fri, 18 Mar 2011 00:41:02 +0000 (00:41 +0000)]
Move a bunch more random files from chrome\renderer to content\renderer.

TBR=avi
Review URL: http://codereview.chromium.org/6685072

git-svn-id: http://src.chromium.org/svn/trunk/src@78640 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoPrint Preview: Cleanup JS createPDFPlugin() a bit.
thestig@chromium.org [Fri, 18 Mar 2011 00:31:56 +0000 (00:31 +0000)]
Print Preview: Cleanup JS createPDFPlugin() a bit.

Resubmit of http://codereview.chromium.org/6710009/

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6712018

git-svn-id: http://src.chromium.org/svn/trunk/src@78639 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agodude 56/56/1
Nicolas Sylvain [Fri, 18 Mar 2011 00:23:17 +0000 (17:23 -0700)]
dude

3 years agonull check for GetLastActive in NotifyThemeChanged.
achuith@chromium.org [Fri, 18 Mar 2011 00:21:13 +0000 (00:21 +0000)]
null check for GetLastActive in NotifyThemeChanged.

BUG=chromium-os:13082
TEST=none
Review URL: http://codereview.chromium.org/6688011

git-svn-id: http://src.chromium.org/svn/trunk/src@78637 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoIntegrate the csd-whitelist with the rest of the client-side
noelutz@google.com [Fri, 18 Mar 2011 00:02:58 +0000 (00:02 +0000)]
Integrate the csd-whitelist with the rest of the client-side
phishing detection code.

BUG=
TEST=ClientSideDetectionHostTest

Review URL: http://codereview.chromium.org/6670053

git-svn-id: http://src.chromium.org/svn/trunk/src@78635 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoTurn on the binary malware warning.
lzheng@chromium.org [Fri, 18 Mar 2011 00:00:07 +0000 (00:00 +0000)]
Turn on the binary malware warning.
BUG=60822
TEST=none

Review URL: http://codereview.chromium.org/6708004

git-svn-id: http://src.chromium.org/svn/trunk/src@78634 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoLoad additional NSS library files in zygote main if remoting is enabled
hclam@google.com [Thu, 17 Mar 2011 23:49:21 +0000 (23:49 +0000)]
Load additional NSS library files in zygote main if remoting is enabled

Instead of initializing NSS before the sandbox is engaged this loads the
necessary additional libraries for NSS to function properly. This allows
initializing NSS after sandbox is closed and solve the security problem
of loading NSS early.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6672034

git-svn-id: http://src.chromium.org/svn/trunk/src@78633 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoReview URL: http://codereview.chromium.org/6708020
tburkard@chromium.org [Thu, 17 Mar 2011 23:40:49 +0000 (23:40 +0000)]
Review URL: http://codereview.chromium.org/6708020

git-svn-id: http://src.chromium.org/svn/trunk/src@78631 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRemove old comment.
apatrick@chromium.org [Thu, 17 Mar 2011 23:36:28 +0000 (23:36 +0000)]
Remove old comment.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6688018

git-svn-id: http://src.chromium.org/svn/trunk/src@78629 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFix subpage closing workaround to work in scrolled window case.
estade@chromium.org [Thu, 17 Mar 2011 23:24:48 +0000 (23:24 +0000)]
Fix subpage closing workaround to work in scrolled window case.

in the content settings subpage, if you scroll to the bottom of the page and click on one of the labels there (e.g. for geolocation), the subpage still closes. This makes the workaround work for this case.

BUG=75338,chromium-os:12679
TEST=manual

Review URL: http://codereview.chromium.org/6713017

git-svn-id: http://src.chromium.org/svn/trunk/src@78626 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoStop overloading Init() in NativeMetafile.
vandebo@chromium.org [Thu, 17 Mar 2011 23:22:06 +0000 (23:22 +0000)]
Stop overloading Init() in NativeMetafile.

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/6709009

git-svn-id: http://src.chromium.org/svn/trunk/src@78625 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRoll WebKit to 81365.
simonjam@chromium.org [Thu, 17 Mar 2011 23:22:03 +0000 (23:22 +0000)]
Roll WebKit to 81365.

TBR=apavlov

git-svn-id: http://src.chromium.org/svn/trunk/src@78624 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAutofill rename GetFieldText to GetInfo
dhollowa@chromium.org [Thu, 17 Mar 2011 23:04:55 +0000 (23:04 +0000)]
Autofill rename GetFieldText to GetInfo

Renames AutofillProfile::GetFieldText to AutofillProfile::GetInfo.  To match SetInfo.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6713002

git-svn-id: http://src.chromium.org/svn/trunk/src@78622 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFixes crash in switching tabstrip orientation from recent refactoring.
sky@chromium.org [Thu, 17 Mar 2011 22:50:11 +0000 (22:50 +0000)]
Fixes crash in switching tabstrip orientation from recent refactoring.

BUG=75577
TEST=see bug
R=ben@chromium.org

Review URL: http://codereview.chromium.org/6685065

git-svn-id: http://src.chromium.org/svn/trunk/src@78621 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFix clang build
jam@chromium.org [Thu, 17 Mar 2011 22:42:24 +0000 (22:42 +0000)]
Fix clang build

git-svn-id: http://src.chromium.org/svn/trunk/src@78620 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRoll ANGLE 571:577
apatrick@chromium.org [Thu, 17 Mar 2011 22:41:06 +0000 (22:41 +0000)]
Roll ANGLE 571:577

577 Fixed framebuffer-object-attachment WebGL conformance test.
576 Update contributors and version
575 Fix clang warnings in PoolAlloc.cpp
574 Fix clang warnings: Intermediate.cpp: warning: '&&' within '||'
573 Fix clang warning: ParseHelper.cpp:264:13: warning: 8 enumeration values not handled in switch
571 Fix clang warning: ConstantUnion.h:56:17: warning: 7 enumeration values not handled in switch

TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/6712003

git-svn-id: http://src.chromium.org/svn/trunk/src@78619 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoBuild break fix.
zelidrag@chromium.org [Thu, 17 Mar 2011 22:30:01 +0000 (22:30 +0000)]
Build break fix.

TEST=none
BUG=none

git-svn-id: http://src.chromium.org/svn/trunk/src@78618 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAdd separate ContentClient interfaces for gpu/plugin/renderer processes. Since we...
jam@chromium.org [Thu, 17 Mar 2011 22:24:43 +0000 (22:24 +0000)]
Add separate ContentClient interfaces for gpu/plugin/renderer processes.  Since we don't have a need for a chrome/gpu or chrome/plugin directory, their chrome implementations are in chrome/common.  Use the renderer one for getting the sad plugin image.
Review URL: http://codereview.chromium.org/6708013

git-svn-id: http://src.chromium.org/svn/trunk/src@78617 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRemove a confusing obsolete comment from MetricsService's header
stuartmorgan@chromium.org [Thu, 17 Mar 2011 22:17:52 +0000 (22:17 +0000)]
Remove a confusing obsolete comment from MetricsService's header

This comment stopped being true almost two and a half years ago (the function doesn't even *have* a return value any more), but was never removed.

Also fixes incorrect use of "setup" as a verb, to make the interface more readable.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6712011

git-svn-id: http://src.chromium.org/svn/trunk/src@78616 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRevert 78614 - Print Preview: Cleanup JS createPDFPlugin() a bit.
thestig@chromium.org [Thu, 17 Mar 2011 22:13:57 +0000 (22:13 +0000)]
Revert 78614 - Print Preview: Cleanup JS createPDFPlugin() a bit.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6710009

TBR=thestig@chromium.org
Review URL: http://codereview.chromium.org/6708018

git-svn-id: http://src.chromium.org/svn/trunk/src@78615 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoPrint Preview: Cleanup JS createPDFPlugin() a bit.
thestig@chromium.org [Thu, 17 Mar 2011 22:07:58 +0000 (22:07 +0000)]
Print Preview: Cleanup JS createPDFPlugin() a bit.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6710009

git-svn-id: http://src.chromium.org/svn/trunk/src@78614 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoExclude ErrorPageTest.DNSError_GoBack1 to make the TSan/UI bot greener
timurrrr@chromium.org [Thu, 17 Mar 2011 22:07:43 +0000 (22:07 +0000)]
Exclude ErrorPageTest.DNSError_GoBack1 to make the TSan/UI bot greener
BUG=46643
TBR=glider
Review URL: http://codereview.chromium.org/6712017

git-svn-id: http://src.chromium.org/svn/trunk/src@78613 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRewritten MountLibrary to work with non-blocking mount API calls in libcros.
zelidrag@chromium.org [Thu, 17 Mar 2011 22:07:12 +0000 (22:07 +0000)]
Rewritten MountLibrary to work with non-blocking mount API calls in libcros.

BUG=chromium-os:13190
TEST=none
Review URL: http://codereview.chromium.org/6674043

git-svn-id: http://src.chromium.org/svn/trunk/src@78612 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoUse PipelineStatusNotification instead of a condvar for pipeline stopping.
fischman@chromium.org [Thu, 17 Mar 2011 22:03:12 +0000 (22:03 +0000)]
Use PipelineStatusNotification instead of a condvar for pipeline stopping.

BUG=none
TEST={,http/tests/}media layouttests pass.

Review URL: http://codereview.chromium.org/6688014

git-svn-id: http://src.chromium.org/svn/trunk/src@78611 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoExclude a couple of HttpNetworkTransactionTests that fail on the TSan bots
timurrrr@chromium.org [Thu, 17 Mar 2011 21:58:21 +0000 (21:58 +0000)]
Exclude a couple of HttpNetworkTransactionTests that fail on the TSan bots
BUG=76592
TBR=glider
TEST=TSan bots go greener
Review URL: http://codereview.chromium.org/6710011

git-svn-id: http://src.chromium.org/svn/trunk/src@78610 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAdd resources/touch_ntp/tools/check to whitelist for +x.
sadrul@chromium.org [Thu, 17 Mar 2011 21:54:24 +0000 (21:54 +0000)]
Add resources/touch_ntp/tools/check to whitelist for +x.
TBR=markmentovai@chromium.org

git-svn-id: http://src.chromium.org/svn/trunk/src@78609 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoTweaks selected tab rendering to look better when multiple tabs are
sky@chromium.org [Thu, 17 Mar 2011 21:53:52 +0000 (21:53 +0000)]
Tweaks selected tab rendering to look better when multiple tabs are
selected. Also converts a handful of things to use active instead of
selected. I need to rename a bunch of things, but will do that
separately.

BUG=76077
TEST=see bug, also covered by test

Review URL: http://codereview.chromium.org/6665061

git-svn-id: http://src.chromium.org/svn/trunk/src@78608 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoweb-ui settings: Fix a typo for the sans-serif preference key via font settings.
csilv@chromium.org [Thu, 17 Mar 2011 21:45:59 +0000 (21:45 +0000)]
web-ui settings: Fix a typo for the sans-serif preference key via font settings.

BUG=none
TEST=Verify that the settings page loads w/o an exception.
Review URL: http://codereview.chromium.org/6708015

git-svn-id: http://src.chromium.org/svn/trunk/src@78607 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoModified the jingle library to be able to able to update the auth token after login...
sanjeevr@chromium.org [Thu, 17 Mar 2011 21:34:27 +0000 (21:34 +0000)]
Modified the jingle library to be able to able to update the auth token after login has happened. This will allow refreshed OAuth2 access tokens to be passed in.

BUG=None
TEST=Test Cloud Print notifications with OAuth2 tokens (not live yet)

Review URL: http://codereview.chromium.org/6708005

git-svn-id: http://src.chromium.org/svn/trunk/src@78605 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoUpdates TabStripModel context menu commands to deal with multiple
sky@chromium.org [Thu, 17 Mar 2011 21:28:21 +0000 (21:28 +0000)]
Updates TabStripModel context menu commands to deal with multiple
selected tabs. A right click on an selected tab makes the action apply
to all tabs. A right click on an unselected tab only applies to that
tab.

BUG=30572
TEST=covered by unit tests.

Review URL: http://codereview.chromium.org/6673095

git-svn-id: http://src.chromium.org/svn/trunk/src@78604 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoChange LOG to VLOG to avoid a lot of messages in the bots output.
zmo@google.com [Thu, 17 Mar 2011 21:23:05 +0000 (21:23 +0000)]
Change LOG to VLOG to avoid a lot of messages in the bots output.

BUG=76576
TEST=no more libpci message in bots output.
Review URL: http://codereview.chromium.org/6713014

git-svn-id: http://src.chromium.org/svn/trunk/src@78603 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agouse classList.add in table component
rginda@chromium.org [Thu, 17 Mar 2011 21:19:07 +0000 (21:19 +0000)]
use classList.add in table component

BUG=None
TEST=verify that table component works in file-picker

Review URL: http://codereview.chromium.org/6711015

git-svn-id: http://src.chromium.org/svn/trunk/src@78602 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoTry #3 - move forward cros DEPS file.
zelidrag@chromium.org [Thu, 17 Mar 2011 21:14:22 +0000 (21:14 +0000)]
Try #3 - move forward cros DEPS file.

BUG=none
TEST=none
TBR=stevenjb
Review URL: http://codereview.chromium.org/6710008

git-svn-id: http://src.chromium.org/svn/trunk/src@78600 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRevert 78591 - Try #2 - moving forward libcros deps.
zelidrag@chromium.org [Thu, 17 Mar 2011 20:56:35 +0000 (20:56 +0000)]
Revert 78591 - Try #2 - moving forward libcros deps.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6709007

TBR=zelidrag@chromium.org
Review URL: http://codereview.chromium.org/6710007

git-svn-id: http://src.chromium.org/svn/trunk/src@78597 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoUse a specialized new tab page in TOUCH_UI builds
sadrul@chromium.org [Thu, 17 Mar 2011 20:50:06 +0000 (20:50 +0000)]
Use a specialized new tab page in TOUCH_UI builds

This has no change on regular builds (except to rename the NTP resource to
be something more generic).

On TOUCH_UI builds, an alternate NTP front-end that is optimized for touch
is embedded into chrome instead of the standard one.  In particular,
I use conditional resource processing to choose the source of the
IDR_NEW_TAB_HTML resource (new_new_tab_page.html for regular builds,
touch_ntp/newtab.html for TOUCH_UI builds).

The same WebUI back-end supports the union of functionality needed by all
front-ends.  Eg. the addition of page-index tracking is used only by this
touch-ntp, and there are many features that the touch-ntp doesn't use (yet
anyway).

The idea with this touch NTP is to focus (for now) on apps, and make it easy
to arrange them into pages.  You can swipe/drag to switch pages, and press
and hold to lift an app and rearrange it.

There is lots of further work to improve the touch NTP (including the addition
of automated tests and various UI improvements).  But it's far enough along
now that we'd like to use it as the only NTP in TOUCH_UI builds.

Note that only the files in the main 'touch_ntp' directory are embedded as
a resource in chrome.  The 'tools' sub-directory provides a script for
type and syntax checking.  The 'standalone' sub-directory is a hack that
is used only if newtab.html is loaded directly as a regular web-page.  It
enables the app to be used (with fake data) directly for rapid prototyping
and testing.

BUG=None
TEST=Existing NTP tests still pass in regular builds.  Tests for Touch_UI builds are forthcoming.

Review URL: http://codereview.chromium.org/6661024
Patch from Rick Byers <rbyers@chromium.org>.

git-svn-id: http://src.chromium.org/svn/trunk/src@78596 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFix crash with pepper 3D on multiple windows in same renderer
piman@google.com [Thu, 17 Mar 2011 20:40:29 +0000 (20:40 +0000)]
Fix crash with pepper 3D on multiple windows in same renderer

BUG=none
TEST=With pepper flash, run ATS AS2 14231, open the popup, kill it, observe no crash

Review URL: http://codereview.chromium.org/6711013

git-svn-id: http://src.chromium.org/svn/trunk/src@78595 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAdd IndexedDB browser test that causes a crash.
dgrogan@chromium.org [Thu, 17 Mar 2011 20:40:05 +0000 (20:40 +0000)]
Add IndexedDB browser test that causes a crash.

When a frame is unloaded, stop() is called on each ActiveDOMObject.
IDBDatabase::stop can cause IDBDatabase to be destroyed in a roundabout way.  Destroying an ActiveDOMObject while they are being iterated over causes a defensive crash.

BUG=75264
TEST=browser_tests --gtest_filter=IndexedDBBrowserTest.DatabaseCallbacksTest

Review URL: http://codereview.chromium.org/6677034

git-svn-id: http://src.chromium.org/svn/trunk/src@78594 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoExtensions: expose raw debugging protocol via extension API.
pfeldman@chromium.org [Thu, 17 Mar 2011 20:39:22 +0000 (20:39 +0000)]
Extensions: expose raw debugging protocol via extension API.

BUG=
TEST=

Review URL: http://codereview.chromium.org/6686051

git-svn-id: http://src.chromium.org/svn/trunk/src@78593 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoDisable DoubleDisplay and NavigateAway [mark as FAILS_].
ericu@google.com [Thu, 17 Mar 2011 20:23:58 +0000 (20:23 +0000)]
Disable DoubleDisplay and NavigateAway [mark as FAILS_].

TBR=sadrul@chromium.org
BUG=76573
TEST=none

Review URL: http://codereview.chromium.org/6712010

git-svn-id: http://src.chromium.org/svn/trunk/src@78592 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoTry #2 - moving forward libcros deps.
zelidrag@chromium.org [Thu, 17 Mar 2011 20:03:24 +0000 (20:03 +0000)]
Try #2 - moving forward libcros deps.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6709007

git-svn-id: http://src.chromium.org/svn/trunk/src@78591 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoweb-ui settings: Allow escape key to cancel the current search.
csilv@chromium.org [Thu, 17 Mar 2011 20:03:06 +0000 (20:03 +0000)]
web-ui settings: Allow escape key to cancel the current search.

BUG=74862
TEST=Start a search, hit escape.  Verify that the search has stopped.
Review URL: http://codereview.chromium.org/6709006

git-svn-id: http://src.chromium.org/svn/trunk/src@78590 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAutofill database migration to clean up bogus profiles.
dhollowa@chromium.org [Thu, 17 Mar 2011 20:01:41 +0000 (20:01 +0000)]
Autofill database migration to clean up bogus profiles.

Adds a |WebDatabase| migration to clean up old profiles.  The profiles are merged in much the same way as when aggregated using form submission.  Profiles that are identical to another, subsets of another, or contain invalid or incomplete email, state, zip, or address get filtered out.

Additionally, the filtered profiles are remembered in a "trash can" mechanism to later reflect these changes in Sync, so that they don't reappear unintentionally.

BUG=65625
TEST=PersonalDataManagerTest.*:AutoFillMergeTest.DataDrivenMergeProfiles:WebDatabaseMigrationTest.*:WebDatabaseTest.*

Review URL: http://codereview.chromium.org/6676031

git-svn-id: http://src.chromium.org/svn/trunk/src@78589 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFixes bug in instant where if the search provider didn't support
sky@chromium.org [Thu, 17 Mar 2011 19:55:00 +0000 (19:55 +0000)]
Fixes bug in instant where if the search provider didn't support
instant we would destroy the TabContents from a callback from the
TabContents, which can cause problems.

BUG=76077
TEST=see bug, also covered by test
R=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/6665058

git-svn-id: http://src.chromium.org/svn/trunk/src@78587 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFixes bug where if you click on the bookmark bubble, then change the
sky@chromium.org [Thu, 17 Mar 2011 19:51:34 +0000 (19:51 +0000)]
Fixes bug where if you click on the bookmark bubble, then change the
folder we wouldn't throb the right view. To get this to work I changed
the order of when we apply edits (change the model) to before the
bubble is closed. Previously we closed the bubble, then applied the
edits. We need to apply the edits first as bookmark bar stops
throbbing when the bubble is closed.

BUG=41082
TEST=see bug
R=ben@chromium.org

Review URL: http://codereview.chromium.org/6677050

git-svn-id: http://src.chromium.org/svn/trunk/src@78585 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoPasswords: Add a PasswordStore::Observer interface and use this to notify
jhawkins@chromium.org [Thu, 17 Mar 2011 19:42:08 +0000 (19:42 +0000)]
Passwords: Add a PasswordStore::Observer interface and use this to notify
observers when the data in the password store has changed.

BUG=67855
TEST=none

R=mdm@chromium.org,stuartmorgan@chromium.org

Review URL: http://codereview.chromium.org/6673106

git-svn-id: http://src.chromium.org/svn/trunk/src@78584 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoMac: set the arrow cursor for the bookmark toolbar and its menus.
maf@chromium.org [Thu, 17 Mar 2011 19:28:03 +0000 (19:28 +0000)]
Mac: set the arrow cursor for the bookmark toolbar and its menus.
The toolbar is handled using the standard [NSView resetCursorRects] override technique.
The menus are trickier as those weird views don't reliably get the resetCursorRects message, so we just set the cursor in the bookmark bar folder (aka fake menu) delegate whenever it gets a mouseEntered for an item(we already go to great lengths to get those messages).
BUG=54812
Review URL: http://codereview.chromium.org/6670073

git-svn-id: http://src.chromium.org/svn/trunk/src@78583 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRoll WebKit to 81349.
simonjam@chromium.org [Thu, 17 Mar 2011 19:25:59 +0000 (19:25 +0000)]
Roll WebKit to 81349.

TBR=apavlov

git-svn-id: http://src.chromium.org/svn/trunk/src@78582 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoConvenience class for wifi testing. A subclass of PyUITest that automatically sets...
dtu@chromium.org [Thu, 17 Mar 2011 19:18:57 +0000 (19:18 +0000)]
Convenience class for wifi testing. A subclass of PyUITest that automatically sets the flimflam priorities to put wifi connections first before starting tests.

BUG=none.
TEST=Test included.

Review URL: http://codereview.chromium.org/6670064

git-svn-id: http://src.chromium.org/svn/trunk/src@78580 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoMove a bunch of gpu/worker/plugin renderer code to content. I temporarily disabled...
jam@chromium.org [Thu, 17 Mar 2011 19:15:35 +0000 (19:15 +0000)]
Move a bunch of gpu/worker/plugin renderer code to content.  I temporarily disabled the sad plugin code while I add a renderer chrome interface in a follow up.

TBR=avi
Review URL: http://codereview.chromium.org/6713005

git-svn-id: http://src.chromium.org/svn/trunk/src@78579 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoDisable failing testScreenLocker.
dtu@chromium.org [Thu, 17 Mar 2011 19:12:09 +0000 (19:12 +0000)]
Disable failing testScreenLocker.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6708006

git-svn-id: http://src.chromium.org/svn/trunk/src@78578 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRevert 78571 - Moved deps forward to catch my mount library rewrite.
zelidrag@chromium.org [Thu, 17 Mar 2011 19:07:06 +0000 (19:07 +0000)]
Revert 78571 - Moved deps forward to catch my mount library rewrite.

BUG=chromium-os:13190
TEST=none
TBR=stevenjb
Review URL: http://codereview.chromium.org/6709003

TBR=zelidrag@chromium.org
Review URL: http://codereview.chromium.org/6709004

git-svn-id: http://src.chromium.org/svn/trunk/src@78577 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoStop subclassing FilterContext in URLRequestJob.
adamk@chromium.org [Thu, 17 Mar 2011 19:06:01 +0000 (19:06 +0000)]
Stop subclassing FilterContext in URLRequestJob.

Create a wrapper for URLRequestHttpJob that subclasses FilterContext,
and pass an instance of this facade to Filter::Factory().

Reduce the scope of URLRequestJob's interface as much as possible, moving
methods into URLRequestHttpJob or its facade as appropriate, and making
methods that remain in URLRequestJob non-virtual where possible.

BUG=none
TEST=net_unittests,try bots

Review URL: http://codereview.chromium.org/6677104

git-svn-id: http://src.chromium.org/svn/trunk/src@78576 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRevert 78554 - Make chrome://extension-icon resources available in incognito mode.
jstritar@chromium.org [Thu, 17 Mar 2011 19:03:43 +0000 (19:03 +0000)]
Revert 78554 - Make chrome://extension-icon resources available in incognito mode.

(Will revert, trying to determine what is causing the test flake.)

BUG=74905, 75748
TEST=ExtensionIconSourceTest

Review URL: http://codereview.chromium.org/6623057

TBR=jstritar@chromium.org
Review URL: http://codereview.chromium.org/6713007

git-svn-id: http://src.chromium.org/svn/trunk/src@78575 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoMinor OOL nit: remove a template that was only used once in syncable.h and OOL the...
erg@google.com [Thu, 17 Mar 2011 19:01:14 +0000 (19:01 +0000)]
Minor OOL nit: remove a template that was only used once in syncable.h and OOL the resulting method.

BUG=carnitas
TEST=compiles; existing tests

Review URL: http://codereview.chromium.org/6667048

git-svn-id: http://src.chromium.org/svn/trunk/src@78574 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoChanging the flash version to 10.2.154.25
sunandt@google.com [Thu, 17 Mar 2011 18:54:59 +0000 (18:54 +0000)]
Changing the flash version to 10.2.154.25

BUG=73902
TEST=Pyauto trees should be green

Review URL: http://codereview.chromium.org/6710005

git-svn-id: http://src.chromium.org/svn/trunk/src@78573 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoAdds memory cache logging, and updates disk cache logging.
mmenke@chromium.org [Thu, 17 Mar 2011 18:53:02 +0000 (18:53 +0000)]
Adds memory cache logging, and updates disk cache logging.

Memory and disk cache use the same set of events, with the same parameters (Though the disk cache has a couple events the memory cache does not).  Most disk cache events were renamed so as to no longer imply a connection to the disk cache, and all disk cache-related NetLog parameter class definitions were moved to a new file, since they're shared by both entry type.

BUG=59382
TEST=none
Review URL: http://codereview.chromium.org/6613027

git-svn-id: http://src.chromium.org/svn/trunk/src@78572 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoMoved deps forward to catch my mount library rewrite.
zelidrag@chromium.org [Thu, 17 Mar 2011 18:51:29 +0000 (18:51 +0000)]
Moved deps forward to catch my mount library rewrite.

BUG=chromium-os:13190
TEST=none
TBR=stevenjb
Review URL: http://codereview.chromium.org/6709003

git-svn-id: http://src.chromium.org/svn/trunk/src@78571 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoDon't record expiration time of unexpiring cookies.
rdsmith@chromium.org [Thu, 17 Mar 2011 18:40:24 +0000 (18:40 +0000)]
Don't record expiration time of unexpiring cookies.

BUG=76241

Review URL: http://codereview.chromium.org/6685064

git-svn-id: http://src.chromium.org/svn/trunk/src@78570 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agonet: add www.paycheckrecords.com to HSTS preloaded list.
agl@chromium.org [Thu, 17 Mar 2011 18:35:35 +0000 (18:35 +0000)]
net: add paycheckrecords.com to HSTS preloaded list.

Requested by: Paul Gibson

BUG=none
TEST=none

git-svn-id: http://src.chromium.org/svn/trunk/src@78569 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agonet: update unittests to reflect preloaded HSTS entries.
agl@chromium.org [Thu, 17 Mar 2011 18:35:32 +0000 (18:35 +0000)]
net: update unittests to reflect preloaded HSTS entries.

BUG=none
TEST=none

git-svn-id: http://src.chromium.org/svn/trunk/src@78568 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoCommitting on behalf of asharif1@chromium.org.
sanjeevr@chromium.org [Thu, 17 Mar 2011 18:31:11 +0000 (18:31 +0000)]
Committing on behalf of asharif1@chromium.org.

Original CL description: Initialized process_id variable to 0.
Original codereview URL is http://codereview.chromium.org/6697036/

BUG=76448

git-svn-id: http://src.chromium.org/svn/trunk/src@78567 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years ago[cros] Fix accelerator keys when using non-US/Latin keyboard layouts.
suzhe@google.com [Thu, 17 Mar 2011 18:21:50 +0000 (18:21 +0000)]
[cros] Fix accelerator keys when using non-US/Latin keyboard layouts.

BUG=chromium-os:10120
TEST=Switch to Russian keyboard layout, try accelerators like ctrl-t, ctrl-w, etc.

Review URL: http://codereview.chromium.org/6674052

git-svn-id: http://src.chromium.org/svn/trunk/src@78565 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoCreates the ipclist utility that chrome security team has wanted to dump
tsepez@chromium.org [Thu, 17 Mar 2011 18:20:52 +0000 (18:20 +0000)]
Creates the ipclist utility that chrome security team has wanted to dump
the known IPC messages.  Going forward, this should help identify new messages
between versions of chrome so that they may be given extra scrutiny for
potential badness.

under the common_message_generator.h umbrella.
Review URL: http://codereview.chromium.org/6646005

git-svn-id: http://src.chromium.org/svn/trunk/src@78564 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoUpdate V8 to version 3.2.3.1.
ricow@chromium.org [Thu, 17 Mar 2011 18:20:16 +0000 (18:20 +0000)]
Update V8 to version 3.2.3.1.
Review URL: http://codereview.chromium.org/6677110

git-svn-id: http://src.chromium.org/svn/trunk/src@78563 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRevert WebKit roll 81308:81349
apavlov@chromium.org [Thu, 17 Mar 2011 17:18:17 +0000 (17:18 +0000)]
Revert WebKit roll 81308:81349

TBR=simonjam@chromium.org

git-svn-id: http://src.chromium.org/svn/trunk/src@78562 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFix toast experiments, which had regressed.
grt@chromium.org [Thu, 17 Mar 2011 16:30:06 +0000 (16:30 +0000)]
Fix toast experiments, which had regressed.

BUG=76400
TEST=Try out the toast experiment, both at user- and system-level.
Review URL: http://codereview.chromium.org/6670087

git-svn-id: http://src.chromium.org/svn/trunk/src@78558 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoCreate the CookiesTreeModel on demand in the cookies view handler.
jochen@chromium.org [Thu, 17 Mar 2011 16:27:14 +0000 (16:27 +0000)]
Create the CookiesTreeModel on demand in the cookies view handler.

BUG=76292
TEST=none

Review URL: http://codereview.chromium.org/6676034

git-svn-id: http://src.chromium.org/svn/trunk/src@78556 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFix up cloud print login.
scottbyer@chromium.org [Thu, 17 Mar 2011 16:20:28 +0000 (16:20 +0000)]
Fix up cloud print login.

Fix up cloud print login to handle errors properly. The code wasn't fully
hooked up properly to deal with error states. Now also handles any needed
resizing by the login panel.

BUG=75702
TEST=Give bad credentials, see proper response instead of hang.

Review URL: http://codereview.chromium.org/6672052

git-svn-id: http://src.chromium.org/svn/trunk/src@78555 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoMake chrome://extension-icon resources available in incognito mode.
jstritar@chromium.org [Thu, 17 Mar 2011 16:20:24 +0000 (16:20 +0000)]
Make chrome://extension-icon resources available in incognito mode.

(Will revert, trying to determine what is causing the test flake.)

BUG=74905, 75748
TEST=ExtensionIconSourceTest

Review URL: http://codereview.chromium.org/6623057

git-svn-id: http://src.chromium.org/svn/trunk/src@78554 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRemove minidump analysis aides from URLRequestThrottlerManager. Leave
joi@chromium.org [Thu, 17 Mar 2011 15:46:25 +0000 (15:46 +0000)]
Remove minidump analysis aides from URLRequestThrottlerManager. Leave
in guard against null values.

We are no longer getting any new information from more minidumps for
this particular crash, so the aides are no longer necessary and I'm
leaving the guard in place to minimize the impact on our users.

BUG=71721
TEST=net_unittests

Review URL: http://codereview.chromium.org/6698033

git-svn-id: http://src.chromium.org/svn/trunk/src@78552 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoWebKit roll 81308:81349
apavlov@chromium.org [Thu, 17 Mar 2011 15:45:42 +0000 (15:45 +0000)]
WebKit roll 81308:81349

TBR=simonjam@chromium.org

git-svn-id: http://src.chromium.org/svn/trunk/src@78551 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoEnforce copyright-year updates in PRESUBMIT.
fischman@chromium.org [Thu, 17 Mar 2011 15:36:28 +0000 (15:36 +0000)]
Enforce copyright-year updates in PRESUBMIT.

This implements the policy handed down in
http://g/chrome-team/browse_thread/thread/2a27340089ff5f6c and codified in
http://dev.chromium.org/developers/coding-style#TOC-File-headers

Note that while the thread above permits the range usage (i.e. 2008-2011), the
coding-style document does not, so this change removes that usage.

BUG=none
TEST=manual testing with changes to file header.

Review URL: http://codereview.chromium.org/6694043

git-svn-id: http://src.chromium.org/svn/trunk/src@78550 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoExtracting core back-off logic into a separate class,
joi@chromium.org [Thu, 17 Mar 2011 15:35:07 +0000 (15:35 +0000)]
Extracting core back-off logic into a separate class,
BackoffEntry. Simplifying the logic slightly while I'm there,
removing special support for "after the fact" malformed
bodies (the error count doesn't need to be 100% accurate) and
removing a constant value added to back-off times (it was only
being added once anyway, had close to zero effect).

Modifying URLRequestThrottlerEntry and related tests to use the
new class instead of co-mingling sliding window logic and
exponential back-off logic.

Removing now-unnecessary StressTest and associated ugly
wart "SetEntryLifetimeMsForTest" method on the
URLRequestThrottlerEntryInterface class.

Fixing up a few minor things e.g. #pragma once while I'm in
there.

BUG=none
TEST=net_unittests.exe, unit_tests.exe

Review URL: http://codereview.chromium.org/6697001

git-svn-id: http://src.chromium.org/svn/trunk/src@78548 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRevert 78542 - History tests de-flaked.
skerner@chromium.org [Thu, 17 Mar 2011 15:16:27 +0000 (15:16 +0000)]
Revert 78542 - History tests de-flaked.

The history tests used to be flaky on all platforms.
Several fixes were made, and now the flakiness dashboard shows that the only source of failures is due to adding a URL and searching right away on windows XP.  The test that fails has been isolated in a single subtest (ExtensionHistoryApiTest.SearchAfterAdd), and all other tests are no longer marked as flaky.

BUG=26296
TEST=ExtensionHistoryApiTest.*

Review URL: http://codereview.chromium.org/6698028

TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/6674061

git-svn-id: http://src.chromium.org/svn/trunk/src@78547 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFix bug with drop arrow updating on the tabstrip. See comment in widget_win.cc
ben@chromium.org [Thu, 17 Mar 2011 14:58:00 +0000 (14:58 +0000)]
Fix bug with drop arrow updating on the tabstrip. See comment in widget_win.cc

http://crbug.com/74764
TEST=none

Review URL: http://codereview.chromium.org/6665050

git-svn-id: http://src.chromium.org/svn/trunk/src@78545 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRemove a suppression for code that no longer exists.
rsesek@chromium.org [Thu, 17 Mar 2011 14:53:23 +0000 (14:53 +0000)]
Remove a suppression for code that no longer exists.

BUG=32564
TEST=Mac Valgrind unit stays green

Review URL: http://codereview.chromium.org/6693026

git-svn-id: http://src.chromium.org/svn/trunk/src@78544 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoHistory tests de-flaked.
skerner@chromium.org [Thu, 17 Mar 2011 14:24:45 +0000 (14:24 +0000)]
History tests de-flaked.

The history tests used to be flaky on all platforms.
Several fixes were made, and now the flakiness dashboard shows that the only source of failures is due to adding a URL and searching right away on windows XP.  The test that fails has been isolated in a single subtest (ExtensionHistoryApiTest.SearchAfterAdd), and all other tests are no longer marked as flaky.

BUG=26296
TEST=ExtensionHistoryApiTest.*

Review URL: http://codereview.chromium.org/6698028

git-svn-id: http://src.chromium.org/svn/trunk/src@78542 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoImprove AlignRect() readability, and handle bad rectangles more gracefully (without...
lambroslambrou@chromium.org [Thu, 17 Mar 2011 14:22:14 +0000 (14:22 +0000)]
Improve AlignRect() readability, and handle bad rectangles more gracefully (without crashing in gfx::Rect ctor).
Also fix cpplint nit.

BUG=74809
TEST=Follow repro steps of bug.

Review URL: http://codereview.chromium.org/6628051

git-svn-id: http://src.chromium.org/svn/trunk/src@78541 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRefactor WifiDataProviderChromeOs to implement WifiDataProviderImplBase directly...
jknotten@chromium.org [Thu, 17 Mar 2011 14:18:54 +0000 (14:18 +0000)]
Refactor WifiDataProviderChromeOs to implement WifiDataProviderImplBase directly and delegate the
scan occur on the UI thread as currently required by
Chromium OS.

BUG=chromium-os:13049
TEST=Existing

Review URL: http://codereview.chromium.org/6696022

git-svn-id: http://src.chromium.org/svn/trunk/src@78540 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoNew accelerometer data from Raul Cuza.
avi@chromium.org [Thu, 17 Mar 2011 14:15:37 +0000 (14:15 +0000)]
New accelerometer data from Raul Cuza.

BUG=none
TEST=on a MacBookPro1,2

Review URL: http://codereview.chromium.org/6672074

git-svn-id: http://src.chromium.org/svn/trunk/src@78539 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRevert 78536 - Use gl_bindings instead of linking against OpenGL directly.
backer@chromium.org [Thu, 17 Mar 2011 13:49:18 +0000 (13:49 +0000)]
Revert 78536 - Use gl_bindings instead of linking against OpenGL directly.

The GPU process uses gl_bindings to decide which GL library (OpenGL,
OpenGL ES, or Angle) to link against at run-time. We should do the same.

BUG=none
TEST=by hand with 3D CSS and WebGL on Linux

Review URL: http://codereview.chromium.org/6673094

TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/6665066

git-svn-id: http://src.chromium.org/svn/trunk/src@78537 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoUse gl_bindings instead of linking against OpenGL directly.
backer@chromium.org [Thu, 17 Mar 2011 13:40:17 +0000 (13:40 +0000)]
Use gl_bindings instead of linking against OpenGL directly.

The GPU process uses gl_bindings to decide which GL library (OpenGL,
OpenGL ES, or Angle) to link against at run-time. We should do the same.

BUG=none
TEST=by hand with 3D CSS and WebGL on Linux

Review URL: http://codereview.chromium.org/6673094

git-svn-id: http://src.chromium.org/svn/trunk/src@78536 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoRemove map entry when it's not needed. Avoid one copy.
avayvod@chromium.org [Thu, 17 Mar 2011 12:49:30 +0000 (12:49 +0000)]
Remove map entry when it's not needed. Avoid one copy.
Removed unnecessary include. Added cropping of the image if it should be saved.

BUG=chromium-os:2348
TEST=Check that changed image is cropped and scaled to be a square picture.
R=altimofeev@chromium.org

Review URL: http://codereview.chromium.org/6696045

git-svn-id: http://src.chromium.org/svn/trunk/src@78535 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFixing breaking bugs in the proxy sample extension.
battre@chromium.org [Thu, 17 Mar 2011 12:35:14 +0000 (12:35 +0000)]
Fixing breaking bugs in the proxy sample extension.

Moral of the story: never refactor.
Second moral: run tests after refactoring.  :)

BUG=62700
TEST=The extension should function correctly.

Review URL: http://codereview.chromium.org/6667073
Patch from Mike West <mkwst@chromium.org>.

git-svn-id: http://src.chromium.org/svn/trunk/src@78534 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFirst step of integrating notifications content settings to the host content settings...
markusheintz@chromium.org [Thu, 17 Mar 2011 12:13:27 +0000 (12:13 +0000)]
First step of integrating notifications content settings to the host content settings map:
Add a content settings provider for notifications content settings.

BUG=63656
TEST=desktop_notification_service_unittest.cc

Review URL: http://codereview.chromium.org/6672025

git-svn-id: http://src.chromium.org/svn/trunk/src@78533 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoMove media library path resolution into Chrome path provider.
wez@chromium.org [Thu, 17 Mar 2011 11:49:25 +0000 (11:49 +0000)]
Move media library path resolution into Chrome path provider.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/6537022

git-svn-id: http://src.chromium.org/svn/trunk/src@78532 4ff67af0-8c30-449e-8e8b-ad334ec8d88c

3 years agoFix expectations for X509CertificateTest.InvalidKeyUsage:
bulach@chromium.org [Thu, 17 Mar 2011 10:48:03 +0000 (10:48 +0000)]
Fix expectations for X509CertificateTest.InvalidKeyUsage:
Tests for NE(OK..) rather than EQ(ERR_CERT_INVALID...).
Don't test for CERT_STATUS_INVALID.

Reason: openssl uses CERT_STATUS_AUTHORITY_INVALID for this cert.
(in fact, it now uses the same errors conditions as UnoSoftCertParsing).

BUG=none
TEST=X509CertificateTest.InvalidKeyUsage passes with use_openssl=1

Review URL: http://codereview.chromium.org/6665024

git-svn-id: http://src.chromium.org/svn/trunk/src@78531 4ff67af0-8c30-449e-8e8b-ad334ec8d88c