playground/w8/src.git
2 years agoInitial set of changes to interact with Metro App master
Marc-Andre Decoste [Tue, 15 Nov 2011 22:31:16 +0000 (17:31 -0500)]
Initial set of changes to interact with Metro App

3 years agoValgrind: Update a suppression after r106077, suppress new errors for Mac VideoCaptur...
thestig@chromium.org [Tue, 18 Oct 2011 20:03:44 +0000 (20:03 +0000)]
Valgrind: Update a suppression after r106077, suppress new errors for Mac VideoCaptureDevice.

BUG=100133,100772
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/8342009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106108 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoFinalize the XML writer before freeing it.
petkov@chromium.org [Tue, 18 Oct 2011 20:03:21 +0000 (20:03 +0000)]
Finalize the XML writer before freeing it.

Based on the libxml2 code and examples, this is the clean way to destroy a
writer. This cleans up libxml2 warnings/errors for unit test logs.

BUG=chromium-os:6717
TEST=unit tests, git try

Review URL: http://codereview.chromium.org/8337016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106107 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoReset static HttpStreamFactory settings before each test in a NetTestSuite.
szym@chromium.org [Tue, 18 Oct 2011 20:03:08 +0000 (20:03 +0000)]
Reset static HttpStreamFactory settings before each test in a NetTestSuite.

This improves test isolation.

BUG=
TEST=./net_unittests --gtest_shuffle=1 --gtest_random_seed=56044
More specifically:
TEST=./net_unittests --gtest_shuffle=1 --gtest_random_seed=56044 --gtest_filter=Spdy/SpdyNetworkTransactionTest.ThreeGets/1:HttpStreamFactoryTest.PreconnectHttpProxy

Review URL: http://codereview.chromium.org/8295009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106106 0039d316-1c4b-4281-b951-d872f2087c98

3 years agogtk: fix bulge in custom frame
estade@chromium.org [Tue, 18 Oct 2011 20:02:57 +0000 (20:02 +0000)]
gtk: fix bulge in custom frame

problem: when there is no Other Bookmarks button showing (because the folder is empty), you can see a small beige bulge in the custom frame at the level of the bookmark bar
cause: the other_padding GtkAlignment is still showing although the button itself is hidden (I'm not sure why this alignment extends outside the bounds of the bookmark bar, but it does)
solution: show/hide that widget instead of the button widget.

problem 2: the Other Bookmarks button is not shown/hidden when elements are added to or removed from it.
solution: call UpdateOtherBookmarksVisibility more aggressively

BUG=100724
TEST=manual

Review URL: http://codereview.chromium.org/8336011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106105 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoFixed log messages about failed initialization of GLSurface.
alokp@chromium.org [Tue, 18 Oct 2011 19:35:19 +0000 (19:35 +0000)]
Fixed log messages about failed initialization of GLSurface.
Review URL: http://codereview.chromium.org/8343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106104 0039d316-1c4b-4281-b951-d872f2087c98

3 years ago[Sync UI] Display error on personal options page when sync has an unrecoverable error.
binji@chromium.org [Tue, 18 Oct 2011 19:34:46 +0000 (19:34 +0000)]
[Sync UI] Display error on personal options page when sync has an unrecoverable error.

BUG=99250, 94976
TEST=Cause an unrecoverable error. Go to chrome://settings/personal. There should be an error message "Oops, Sync has stopped working" with a learn more link.

Review URL: http://codereview.chromium.org/8289024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106103 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoFix some disabled/flaky notification pyauto tests.
kkania@chromium.org [Tue, 18 Oct 2011 19:34:40 +0000 (19:34 +0000)]
Fix some disabled/flaky notification pyauto tests.
BUG=66072,95031
TEST=none

Review URL: http://codereview.chromium.org/8286012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106102 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoFix histogram calls to use defined constant instead of hard coding number.
rogerta@chromium.org [Tue, 18 Oct 2011 19:27:07 +0000 (19:27 +0000)]
Fix histogram calls to use defined constant instead of hard coding number.

BUG=None
TEST=Code cleanup, no user visible change

Review URL: http://codereview.chromium.org/8320006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106099 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUpdate .DEPS.git
chrome-admin@google.com [Tue, 18 Oct 2011 19:15:12 +0000 (19:15 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106098 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoBump Syzygy binaries to 0.1.8.0
chrisha@google.com [Tue, 18 Oct 2011 19:12:46 +0000 (19:12 +0000)]
Bump Syzygy binaries to 0.1.8.0
Review URL: http://codereview.chromium.org/8349003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106097 0039d316-1c4b-4281-b951-d872f2087c98

3 years agobase/json: Collapse a condition in ReadHexDigits into a single if clause.
tfarina@chromium.org [Tue, 18 Oct 2011 19:04:55 +0000 (19:04 +0000)]
base/json: Collapse a condition in ReadHexDigits into a single if clause.

TEST=base_unittests --gtest_filter=JSON*
R=tony@chromium.org

Review URL: http://codereview.chromium.org/8312004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106096 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoValgrind/Heapchecker: Suppress a WK memory error and a leak in x509 cert code.
thestig@chromium.org [Tue, 18 Oct 2011 18:57:45 +0000 (18:57 +0000)]
Valgrind/Heapchecker: Suppress a WK memory error and a leak in x509 cert code.

BUG=100661,100761
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/8343010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106094 0039d316-1c4b-4281-b951-d872f2087c98

3 years agonet: rework the NPN patch.
agl@chromium.org [Tue, 18 Oct 2011 18:56:34 +0000 (18:56 +0000)]
net: rework the NPN patch.

This change moves the protocol selection logic out of NSS and into Chromium
code. This allows some things to be a little cleaner (no more wire-encoded NPN
strings) and also allows for some tricks that we have been considering for
SPDY+WebSockets.

As a consequence of this change, next protocols are now a
std::vector<std::string> rather than an encoded char*

BUG=none
TEST=SPDY still works with Google sites.

Review URL: http://codereview.chromium.org/8156001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106093 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoDisable NoInfobarForAllowedOrigin on Win.
jennb@chromium.org [Tue, 18 Oct 2011 18:55:13 +0000 (18:55 +0000)]
Disable NoInfobarForAllowedOrigin on Win.

BUG=100763
TEST=
TBR=bulach@chromium.org

Review URL: http://codereview.chromium.org/8342006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106092 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoViews Bubble API adjustments and cleanup
msw@chromium.org [Tue, 18 Oct 2011 18:35:52 +0000 (18:35 +0000)]
Views Bubble API adjustments and cleanup

Adjust BubbleDelegateView API, add CreateBubble static factory function.
Bubble's arrow anchors with a screen point, can fade in and fade out.
Supporting changes, test updates, misc related cleanup, -275 lines.

BUG=97248,98322,98323
TEST=updated unit tests, views_examples bubbles work.

Review URL: http://codereview.chromium.org/8227003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106090 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoDisable TestFullscreenBubbleMouseLockState on Linux
sail@chromium.org [Tue, 18 Oct 2011 18:23:47 +0000 (18:23 +0000)]
Disable TestFullscreenBubbleMouseLockState on Linux

BUG=100680
TEST=
TBR=jeremya@chromium.org

Review URL: http://codereview.chromium.org/8348004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106088 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUse base::Bind instead of old callbacks in CertLibrary.
satorux@chromium.org [Tue, 18 Oct 2011 18:18:54 +0000 (18:18 +0000)]
Use base::Bind instead of old callbacks in CertLibrary.

TEST=chrome builds
BUG=none

Review URL: http://codereview.chromium.org/8321025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106087 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUpdating delete-transactions on linux-release-lowmem to go green.
dominich@chromium.org [Tue, 18 Oct 2011 18:15:32 +0000 (18:15 +0000)]
Updating delete-transactions on linux-release-lowmem to go green.
http://build.chromium.org/f/chromium/perf/linux-release-lowmem/database/report.html?history=150&rev=106076&graph=delete-transactions

BUG=100748
TBR=cmp@chromium.org

Review URL: http://codereview.chromium.org/8344007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106086 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoWrap TimeFormat unittests into unnamed namespace.
tfarina@chromium.org [Tue, 18 Oct 2011 18:12:38 +0000 (18:12 +0000)]
Wrap TimeFormat unittests into unnamed namespace.

Plus some other clean ups around.

R=phajdan.jr@chromium.org

Review URL: http://codereview.chromium.org/8313003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106085 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoOpenBSD support for yasm.
mark@chromium.org [Tue, 18 Oct 2011 18:04:27 +0000 (18:04 +0000)]
OpenBSD support for yasm.

- include the openbsd configuration for yasm
- use the correct yasm_flags on every posix system except for mac

Patch by Robert Nagy <robert.nagy@gmail.com>

BUG=
TEST=
Review URL: http://codereview.chromium.org/8348002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106083 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoReland r105832: NewRunnable* -> base::Bind for most of chrome/browser/extensions/.
adamk@chromium.org [Tue, 18 Oct 2011 18:00:36 +0000 (18:00 +0000)]
Reland r105832: NewRunnable* -> base::Bind for most of chrome/browser/extensions/.

Previous attempt didn't build on CrOS, now does.

R=aa@chromium.org

Review URL: http://codereview.chromium.org/8318021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106082 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUse more idiomatic gtest style in extension_function_test_utils.
mihaip@chromium.org [Tue, 18 Oct 2011 18:00:18 +0000 (18:00 +0000)]
Use more idiomatic gtest style in extension_function_test_utils.

R=phajdan.jr@chromium.org

Review URL: http://codereview.chromium.org/8342003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106081 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoOpenBSD patch for ipc, split from CR #8275005
mark@chromium.org [Tue, 18 Oct 2011 17:46:22 +0000 (17:46 +0000)]
OpenBSD patch for ipc, split from CR #8275005

Include <sys/uio.h> on OpenBSD and share the getpeerid code
with Mac.

Patch by Robert Nagy <robert@openbsd.org>

BUG=
TEST=
Review URL: http://codereview.chromium.org/8330025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106080 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoRemove flaky indicator from webstore inline install tests.
mihaip@chromium.org [Tue, 18 Oct 2011 17:41:09 +0000 (17:41 +0000)]
Remove flaky indicator from webstore inline install tests.

Based on the flakiness dashboard, the only recent failures have been on runs
where hundreds of other tests have failed:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WebstoreInlineInstallTest&testType=browser_tests

BUG=95246
R=asargent@chromium.org

Review URL: http://codereview.chromium.org/8343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106079 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoOpenBSD patches for base / split from CR #8275005
mark@chromium.org [Tue, 18 Oct 2011 17:41:07 +0000 (17:41 +0000)]
OpenBSD patches for base / split from CR #8275005

base/base.gypi:
- Add native_library_linux.cc to the openbsd build.
- Add '..' to include_dirs so that OS_* definitions are
  available in symbolize.cc

base/debug/debugger_posix.cc:
- Add support for figuring out if the process is being
  debugged on OpenBSD by sharing some code with Mac.

base/process_util_unittest.cc:
- Disable the OutOfMemoryTest on OpenBSD

base/third_party/symbolize/symbolize.cc:
- Include the correct elf header on OpenBSD

build/linux/system.gyp:
- The dl library is linux only, so only use it there.

BUG=
TEST=
Review URL: http://codereview.chromium.org/8329023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106078 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoDisable : pyauto_webdriver.PyAutoWebDriverTest.testCanConnectToRestartedBrowser,...
jasneet@google.com [Tue, 18 Oct 2011 17:24:08 +0000 (17:24 +0000)]
Disable : pyauto_webdriver.PyAutoWebDriverTest.testCanConnectToRestartedBrowser, pyauto_webdriver.PyAutoWebDriverTest.testTypeIntoTextBox

BUG=98526
TEST=NONE
Review URL: http://codereview.chromium.org/8346002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106077 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoMove the PageType enum to content/public/common, put it into the content namespace...
jam@chromium.org [Tue, 18 Oct 2011 17:08:53 +0000 (17:08 +0000)]
Move the PageType enum to content/public/common, put it into the content namespace, and also make it conform to the Content API enum naming convention.

BUG=98716
TBR=ananta
Review URL: http://codereview.chromium.org/8336013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106076 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoCrash fix.
sreeram@chromium.org [Tue, 18 Oct 2011 17:08:20 +0000 (17:08 +0000)]
Crash fix.

We never reset |tab_contents_| to NULL anywhere (and indeed we can't,
even in ReleasePreviewContents(), because browser.cc accesses it). We
were protected from acccessing a dangling tab_contents_ before, due to
the is_active() check that preceded a call to PrepareForCommit(). That
was removed in http://crrev.com/105664 however; hence this fix.

BUG=100521
TEST=none

Review URL: http://codereview.chromium.org/8329020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106075 0039d316-1c4b-4281-b951-d872f2087c98

3 years agobase/win: small improvement to RegKey API.
tfarina@chromium.org [Tue, 18 Oct 2011 17:02:14 +0000 (17:02 +0000)]
base/win: small improvement to RegKey API.

- Rename ValueExists() to HasValue().
- Rename ValueCount()  to GetValueCount().
- Rename ReadName()    to GetValueNameAt().

R=maruel@chromium.org,willchan@chromium.org

Review URL: http://codereview.chromium.org/8337006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106074 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoDisable TaskManagerBrowserTest.ShutdownWhileOpen on Linux
sail@chromium.org [Tue, 18 Oct 2011 16:55:17 +0000 (16:55 +0000)]
Disable TaskManagerBrowserTest.ShutdownWhileOpen on Linux
Crashes, see bug.

BUG=92297
TEST=TaskManagerBrowserTest.ShutdownWhileOpen
TBR=yoshiki@chromium.org

Review URL: http://codereview.chromium.org/8343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106073 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoImprove web-app typing.
jamiewalch@google.com [Tue, 18 Oct 2011 16:43:21 +0000 (16:43 +0000)]
Improve web-app typing.

BUG=None
TEST=Manual

Review URL: http://codereview.chromium.org/8336004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106072 0039d316-1c4b-4281-b951-d872f2087c98

3 years agontp: fix another js error
estade@chromium.org [Tue, 18 Oct 2011 16:36:49 +0000 (16:36 +0000)]
ntp: fix another js error

this one occurs when a new app is appended (as is the case when you drag from most visited)

BUG=100248
TEST=see bug

Review URL: http://codereview.chromium.org/8330024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106071 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoMove navigation_types.h from content/common to content/public/browser, and put it...
jam@chromium.org [Tue, 18 Oct 2011 16:35:08 +0000 (16:35 +0000)]
Move navigation_types.h from content/common to content/public/browser, and put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API.

BUG=98716
TBR=joi
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106029
Review URL: http://codereview.chromium.org/8339006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106070 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoFix for Memory Leak 72698_b
nrqv63@motorola.com [Tue, 18 Oct 2011 16:30:26 +0000 (16:30 +0000)]
Fix for Memory Leak 72698_b

BUG=72698
TEST=

Review URL: http://codereview.chromium.org/8330018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106069 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoAura: Use same views menu setup on win_aura and linux_aura
jamescook@chromium.org [Tue, 18 Oct 2011 16:22:50 +0000 (16:22 +0000)]
Aura: Use same views menu setup on win_aura and linux_aura

Resolves some TODOs I added in menu_config_win.cc and menu_item_view_win.cc, and harmonizes our menu rendering code between windows and linux Aura.

BUG=100586
TEST=manual

Review URL: http://codereview.chromium.org/8302017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106068 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoFirst iteration of a WebUI lock screen.
flackr@chromium.org [Tue, 18 Oct 2011 16:00:27 +0000 (16:00 +0000)]
First iteration of a WebUI lock screen.

This version displays a simple interface that can unlock the screen with a password. Ultimately the UI will come from the login screen pages, however this is just a stand-in to get the backend functionality working. This is enabled with the flag --webui-lock-screen.

BUG=97980
TEST=Tested enabling flag and locking screen with WebUI lock screen.

Review URL: http://codereview.chromium.org/8171008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106064 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoWriteInto handles length_with_null values of 1 better.
cbentzel@chromium.org [Tue, 18 Oct 2011 15:44:59 +0000 (15:44 +0000)]
WriteInto handles length_with_null values of 1 better.

In debug builds on VS2010, the old code triggered a debug assertion in
xstring, since [0] was being accessed and the size of the array was 0.

A |length_with_null| of 1 is considered a valid use of this function, so
an alternate implementation is used which returns the data() pointer.

BUG=None
TEST=net_unittests --gtest_filter=*Digest* on debug on VS2010 works.

Review URL: http://codereview.chromium.org/8143001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106062 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoSet the Keystone Glue to the "needs promotion" state when on a system ticket
mark@chromium.org [Tue, 18 Oct 2011 15:44:10 +0000 (15:44 +0000)]
Set the Keystone Glue to the "needs promotion" state when on a system ticket
but no system Keystone is present.

Fix the "needs promotion" logic in the About window to actually display the
promotion button. This seems to have broken when the promotion button moved
into the update block instead of being a separate block below it.

BUG=100632, 100633
TEST=Per http://www.google.com/support/chrome/bin/answer.py?hl=en&answer=1367288
     put Chrome on a system Keystone ticket, run
     sudo /Library/Google/GoogleSoftwareUpdate/GoogleSoftwareUpdate.bundle/Contents/Resources/GoogleSoftwareUpdateAgent.app/Contents/Resources/install.py --uninstall
     and then launch Chrome. The "Google Chrome may not be able to keep itself
     updated." infobar should be displayed unless suppressed by "Don't ask
     again" or superseded by another infobar such as the default browser
     infobar. The About window should also display "Google Chrome may not be
     able to keep itself updated." (regardless of whether the infobar was
     suppressed) and the "Set Up Automatic Updates for All Users" button
     should be present and clickable. Clicking this button or the "Set up
     automatic updates" button in the infobar should display an authorization
     dialog for promotion. Upon promotion, if the About window is open, it
     should perform an update check, and the "Set Up Automatic Updates for
     All Users" button should disappear.
Review URL: http://codereview.chromium.org/8318030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106061 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUse base::Callback in Quota related code.
tzik@chromium.org [Tue, 18 Oct 2011 14:11:03 +0000 (14:11 +0000)]
Use base::Callback in Quota related code.

BUG=None
TEST='Compilation should finished successfull and all quota related tests should be passed.'

Review URL: http://codereview.chromium.org/8070001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106060 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoSamples for `enableReferrer` and `allowThirdPartyCookies` should use the `privacy...
mkwst@chromium.org [Tue, 18 Oct 2011 13:47:31 +0000 (13:47 +0000)]
Samples for `enableReferrer` and `allowThirdPartyCookies` should use the `privacy` namespace.

While fixing these samples, I've also added `content_security_policy` as a
drive-by.

BUG=92644
TEST=

Review URL: http://codereview.chromium.org/8341010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106059 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoPermanent folders changes
noyau@chromium.org [Tue, 18 Oct 2011 13:05:43 +0000 (13:05 +0000)]
Permanent folders changes

This cl removes the non visible bookmark folders from the recently modified folder list. When sync is turned off some folders may become invisible. If this non visible folder was the last one used to create a bookmark you may end up in the situation where you can bookmark in a folder you can't see. This avoid the situation.

This cl also changes the way BookmarkNode::IsVisible() is implemented. A subsequent cl will introduce new features in there but in order to do so the Bookmark node needs to have access to the state of the sync, itself stored in the profile. I've tried a couple of approaches before settling down on this one:

- Passing the profile as argument to IsVisible().
- moving IsVisible as BookmarkModel::IsNodeVisible(BookmarkNode*) as the BookmarkModel has a profile_ instance variable.

Both those approaches required to change the calls to IsVisible all over the place and there are quite a bit of them, mostly in platform specific code. I've tried them, but they end up creating very big CL with changes in most of the platform code, with code made ugly because there are more arguments everywhere.

The simpler solution I've settled on introduces a small subclass of BookmarkNode, used only for the 3 permanent nodes ("Bookmark Bar", "Synced" and "Other"). That class get a profile on creation, and can then implement the visibility required by the feature in development.

This cl also includes a small improvement in the way the order of permanent folders is encoded. Two places in the code where enforcing the same order. I made the order of the permanent folders in the child array of the bookmark root the canonical order. The other place now explicitly uses this order.

Review URL: http://codereview.chromium.org/8273041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106058 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoImplement the final UI for the CAPS LOCK indicator (part 2 of 3)
yusukes@chromium.org [Tue, 18 Oct 2011 12:34:03 +0000 (12:34 +0000)]
Implement the final UI for the CAPS LOCK indicator (part 2 of 3)

Call OnCapsLock() only when Caps Lock status is actually changed. Currently, OnCapsLock() is called when other modifier keys (e.g. Ctrl) or mouse buttons are pressed while Caps Lock is on.

BUG=chromium-os:11690
TEST=ran browser_tests

Review URL: http://codereview.chromium.org/8334014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106057 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoAdded support for WebMessagePortChannel to WebKit platform support.
caseq@google.com [Tue, 18 Oct 2011 12:09:36 +0000 (12:09 +0000)]
Added support for WebMessagePortChannel to WebKit platform support.

BUG=none
TEST=third_party/WebKit/LayoutTest/fast/events/message-*

Review URL: http://codereview.chromium.org/8137033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106056 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoRevert 106029
nkostylev@chromium.org [Tue, 18 Oct 2011 11:24:00 +0000 (11:24 +0000)]
Revert 106029
Broke http://build.chromium.org/p/chromium.perf/console
Move navigation_types.h from content/common to content/public/browser, and put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API.

BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8339006

TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/8333018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106054 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoDisable TaskManagerBrowserTest.ShutdownWhileOpen on Mac.
nkostylev@chromium.org [Tue, 18 Oct 2011 11:04:40 +0000 (11:04 +0000)]
Disable TaskManagerBrowserTest.ShutdownWhileOpen on Mac.
Crashes, see bug.

BUG=92297
TEST=TaskManagerBrowserTest.ShutdownWhileOpen
TBR=yoshiki@chromium.org

Review URL: http://codereview.chromium.org/8336022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106053 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoDon't return settings from DefaultProvider for compound content types.
bauerb@chromium.org [Tue, 18 Oct 2011 11:04:27 +0000 (11:04 +0000)]
Don't return settings from DefaultProvider for compound content types.

BUG=99949
TEST=no dcheck in ssl client certificate selection

Review URL: http://codereview.chromium.org/8283034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106052 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoIncrease the total chrome_tests timeout to 4 hours
timurrrr@chromium.org [Tue, 18 Oct 2011 10:01:04 +0000 (10:01 +0000)]
Increase the total chrome_tests timeout to 4 hours
This is needed to run interactive_ui_tests and Dr. Memory on slow machines
TBR=thestig
Review URL: http://codereview.chromium.org/8329015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106051 0039d316-1c4b-4281-b951-d872f2087c98

3 years ago[filebrowser] More intuitive Undo behavior in the Gallery
kaznacheev@chromium.org [Tue, 18 Oct 2011 09:57:41 +0000 (09:57 +0000)]
[filebrowser] More intuitive Undo behavior in the Gallery
Also keeping the "Press enter when done" banner until the edit
is committed or cancelled.

BUG=chromium-os:21072,chromium-os:21416
TEST=

Review URL: http://codereview.chromium.org/8313022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106050 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUpdate .DEPS.git
chrome-admin@google.com [Tue, 18 Oct 2011 09:39:12 +0000 (09:39 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106049 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoWebKit roll 97678:97725
tkent@chromium.org [Tue, 18 Oct 2011 09:38:07 +0000 (09:38 +0000)]
WebKit roll 97678:97725

BUG=none
TEST=none
TBR=dpranke
Review URL: http://codereview.chromium.org/8329011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106048 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUpdating trunk VERSION from 912.0 to 913.0
chrome-release@google.com [Tue, 18 Oct 2011 09:00:42 +0000 (09:00 +0000)]
Updating trunk VERSION from 912.0 to 913.0

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106045 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoAdding `content_security_policy` to the "Mappy" sample.
mkwst@chromium.org [Tue, 18 Oct 2011 08:42:56 +0000 (08:42 +0000)]
Adding `content_security_policy` to the "Mappy" sample.

This involved pretty much rewriting the popup code to avoid a script injected
via `document.write` in the Maps API code.

BUG=92644
TEST=

Review URL: http://codereview.chromium.org/8311007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106043 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoPrint Preview: Making margin lines draggable.
dpapad@chromium.org [Tue, 18 Oct 2011 07:28:43 +0000 (07:28 +0000)]
Print Preview: Making margin lines draggable.

BUG=69337
TEST=Select custom margins. Click and drag on a margin line to adjust the value.

Review URL: http://codereview.chromium.org/8233030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106042 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoRevert 105978 - Report errors when extensions attempt to use private APIs.
nkostylev@chromium.org [Tue, 18 Oct 2011 07:17:25 +0000 (07:17 +0000)]
Revert 105978 - Report errors when extensions attempt to use private APIs.
Breaks 2 CrOS tests:
ExtensionWebSocketProxyPrivateApiTest.Pass
ExtensionApiTest.CustomizationPrivateFailTest
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromeOS/builds/717

Also, report errors when hosted apps attempt to use non-
hosted app permissions.

Also, fix a bug from r105734. Add more tests.

BUG=100489
TBR=jstritar@chromium.org

Review URL: http://codereview.chromium.org/8312013

TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/8329012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106041 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoWebUI TaskManager: Turn it on-by-default on Win/Mac/Linux
yoshiki@chromium.org [Tue, 18 Oct 2011 07:05:16 +0000 (07:05 +0000)]
WebUI TaskManager: Turn it on-by-default on Win/Mac/Linux

Modified gyp to define WEBUI_TASK_MANAGER=1.
And fixed some tests, because they had failed with WEBUI_TASK_MANAGER=1 on Windows.

BUG=99029
TEST=manual, trybots pass

Review URL: http://codereview.chromium.org/8221018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106040 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoAdd 'Toggle caps lock' to the keyboard overlay.
mazda@chromium.org [Tue, 18 Oct 2011 06:20:23 +0000 (06:20 +0000)]
Add 'Toggle caps lock' to the keyboard overlay.

This also includes recent update of sk layout data.

BUG=chromium-os:18044
TEST=Manual

Review URL: http://codereview.chromium.org/8321026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106039 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoDo not fire unnecessary native win events that confuse NVDA.
dtseng@chromium.org [Tue, 18 Oct 2011 06:15:04 +0000 (06:15 +0000)]
Do not fire unnecessary native win events that confuse NVDA.

As stated in the bug, NVDA incorrectly places focus on the containing role=group (LocationBarView) because we fire a focus event on it prior to firing a focus event on the native edit field (NativeViewHostWin). Users still encountered this bug when placing focus on the location bar through the use of ctrl-l, alt-d; ctrl-shift-t and tabbing had been fixed in an earlier patch.

Since we set the focused state of the LocationBarView to true for Chrome OS, we should avoid firing native Windows focus events on it as to  not confuse Windows screen readers.

BUG=98815
TEST=verify that NVDA places focus correctly when keyboarding to the location bar through various means: ctrl-l, alt-d, ctrl-shift-t (tab, tab)

Review URL: http://codereview.chromium.org/8317012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106038 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoAdding VideoCaptureDevice for Mac.
mflodman@chromium.org [Tue, 18 Oct 2011 06:09:45 +0000 (06:09 +0000)]
Adding VideoCaptureDevice for Mac.

Adding dependency on QTKit and CoreVideo.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8177008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106036 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoAdd a SearchToNonSearch test for the HIDDEN field trial.
sreeram@chromium.org [Tue, 18 Oct 2011 05:28:45 +0000 (05:28 +0000)]
Add a SearchToNonSearch test for the HIDDEN field trial.

Plus a couple of minor fixes (spelling, removing redundant calls).

BUG=none
TEST=InstantFieldTrialHiddenTest.SearchToNonSearch

Review URL: http://codereview.chromium.org/8319022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106035 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoSuppress first run search box for sync promo
sail@chromium.org [Tue, 18 Oct 2011 05:02:18 +0000 (05:02 +0000)]
Suppress first run search box for sync promo

This change disables the first run search box while we display the sync promo.

BUG=100299
TEST=

Review URL: http://codereview.chromium.org/8313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106034 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUpdate .DEPS.git
chrome-admin@google.com [Tue, 18 Oct 2011 04:54:14 +0000 (04:54 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106033 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoRoll NSS deps to get new exports to fix win shared build.
mattm@chromium.org [Tue, 18 Oct 2011 04:51:08 +0000 (04:51 +0000)]
Roll NSS deps to get new exports to fix win shared build.

BUG=none
TEST=none
TBR=wtc@chromium.org

Review URL: http://codereview.chromium.org/8330012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106032 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoFix native view host accessibility. We should have been passing a pointer to a pointe...
dmazzoni@chromium.org [Tue, 18 Oct 2011 04:45:35 +0000 (04:45 +0000)]
Fix native view host accessibility. We should have been passing a pointer to a pointer to the function to get the result; also switch to using AccessibleObjectFromWindow instead, which is cleaner.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8296010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106030 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoMove navigation_types.h from content/common to content/public/browser, and put it...
jam@chromium.org [Tue, 18 Oct 2011 04:37:24 +0000 (04:37 +0000)]
Move navigation_types.h from content/common to content/public/browser, and put it in the content namespace. There was no reason for it to be in common since it's only used by browser. I also updated the enum names to match the rest of the enums in the Content API.

BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8339006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106029 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoMove content_notification_types.h from content\common to content\public\browser....
jam@chromium.org [Tue, 18 Oct 2011 04:29:16 +0000 (04:29 +0000)]
Move content_notification_types.h from content\common to content\public\browser. I dropped the "content" from the name to match other files whose chrome version adds a "chrome_" prefix. I also moved it to the browser directory since notifications are only used in the browser process. I will move the other notification files in future changes.

BUG=98716
Review URL: http://codereview.chromium.org/8331001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106028 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoShow mouse lock request and status in fullscreen bubble infobar.
yzshen@chromium.org [Tue, 18 Oct 2011 04:25:55 +0000 (04:25 +0000)]
Show mouse lock request and status in fullscreen bubble infobar.

This CL handles the (platform-independent) state transition.
BUG=95136,100266
TEST=None

Review URL: http://codereview.chromium.org/8274022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106027 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUpdate .DEPS.git
chrome-admin@google.com [Tue, 18 Oct 2011 03:57:13 +0000 (03:57 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106026 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoroll gyp 1074:1075
thakis@chromium.org [Tue, 18 Oct 2011 03:55:52 +0000 (03:55 +0000)]
roll gyp 1074:1075

1075: Add an empty file that should have been part of r 1074.

BUG=100667
TEST=none
TBR=jochen

Review URL: http://codereview.chromium.org/8339007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106025 0039d316-1c4b-4281-b951-d872f2087c98

3 years agomac: Undo minor code deletion.
thakis@chromium.org [Tue, 18 Oct 2011 03:50:02 +0000 (03:50 +0000)]
mac: Undo minor code deletion.

I tried to delete startMaxY in
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?r1=105913&r2=105912&pathrev=105913
but was a bit too eager.

BUG=100668
TEST=Happy Ilya.
TBR=isherman

Review URL: http://codereview.chromium.org/8328002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106024 0039d316-1c4b-4281-b951-d872f2087c98

3 years agorecord UMA histogram for different bookmark launch types
estade@chromium.org [Tue, 18 Oct 2011 03:25:49 +0000 (03:25 +0000)]
record UMA histogram for different bookmark launch types

for now, only record on windows.

BUG=97141
TEST=none

Review URL: http://codereview.chromium.org/8231035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106023 0039d316-1c4b-4281-b951-d872f2087c98

3 years agofix ntp js errors from r105951
estade@chromium.org [Tue, 18 Oct 2011 03:22:27 +0000 (03:22 +0000)]
fix ntp js errors from r105951

BUG=none
TEST=open new tab
TBR=csilv,dbeam

Review URL: http://codereview.chromium.org/8330010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106022 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUpdate .DEPS.git
chrome-admin@google.com [Tue, 18 Oct 2011 03:21:13 +0000 (03:21 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106021 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoTrack the RTT via histograms for PING messages sent from client.
rtenneti@chromium.org [Tue, 18 Oct 2011 03:20:33 +0000 (03:20 +0000)]
Track the RTT via histograms for PING messages sent from client.

BUG=100651
R=jar,willchan
TEST=network unittests

Review URL: http://codereview.chromium.org/8333008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106020 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUpdate FFmpeg to r106016.
scherkus@chromium.org [Tue, 18 Oct 2011 03:20:16 +0000 (03:20 +0000)]
Update FFmpeg to r106016.

BUG=100464

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106019 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoviews: Change TextButtonBase API to string16.
tfarina@chromium.org [Tue, 18 Oct 2011 03:13:58 +0000 (03:13 +0000)]
views: Change TextButtonBase API to string16.

BUG=68267
R=sky@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105998

Review URL: http://codereview.chromium.org/8262003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106018 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoChange usage of AllSources to AllBrowserContextsAndSources to indicate that usage...
mirandac@chromium.org [Tue, 18 Oct 2011 03:06:26 +0000 (03:06 +0000)]
Change usage of AllSources to AllBrowserContextsAndSources to indicate that usage is safe for multiprofiles.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8314010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106017 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUpdate .DEPS.git
chrome-admin@google.com [Tue, 18 Oct 2011 02:54:13 +0000 (02:54 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106015 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoLinux: force bookmark icons to always be visible in the bookmark menu.
mdm@chromium.org [Tue, 18 Oct 2011 02:52:47 +0000 (02:52 +0000)]
Linux: force bookmark icons to always be visible in the bookmark menu.
Review URL: http://codereview.chromium.org/8330009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106012 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoRoll skia 2478->2480
vandebo@chromium.org [Tue, 18 Oct 2011 02:52:31 +0000 (02:52 +0000)]
Roll skia 2478->2480

BUG=NONE
TEST=NONE

Review URL: http://codereview.chromium.org/8337001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106011 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoLinux Mouse Lock Bubble UI
scheib@chromium.org [Tue, 18 Oct 2011 02:50:53 +0000 (02:50 +0000)]
Linux Mouse Lock Bubble UI

Builds on http://codereview.chromium.org/8274022/

BUG=95136
TEST=none

Review URL: http://codereview.chromium.org/8315002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106010 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoAdding myself to the owners file for profiles.
rlp@chromium.org [Tue, 18 Oct 2011 02:42:28 +0000 (02:42 +0000)]
Adding myself to the owners file for profiles.

BUGS=none
TEST=none

Review URL: http://codereview.chromium.org/8339005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106009 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoMake whitelist for files starting with test_ or mock_ treat path
joi@chromium.org [Tue, 18 Oct 2011 02:39:11 +0000 (02:39 +0000)]
Make whitelist for files starting with test_ or mock_ treat path
before filename correctly.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8341004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106008 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoRecovery component: Use a version from the prefs instead of the chrome version
cpu@chromium.org [Tue, 18 Oct 2011 02:35:59 +0000 (02:35 +0000)]
Recovery component: Use a version from the prefs instead of the chrome version

The chrome version is sent anyhow as a top level param of the request.

BUG=98735
TEST= see bug
Review URL: http://codereview.chromium.org/8337003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106007 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoImplement the final UI for the CAPS LOCK indicator.
yusukes@chromium.org [Tue, 18 Oct 2011 02:32:13 +0000 (02:32 +0000)]
Implement the final UI for the CAPS LOCK indicator.

- Remove the tooltip
- Insted, add a drop-down menu which looks like http://crosbug.com/11690#c18
- Split the string resource for the indicator into two since gfx canvas can not handle a string containing "\n" correctly.
- The bubble in the UI mock is NOT implemented yet.

BUG=chromium-os:11690
TEST=ran browser_tests

Review URL: http://codereview.chromium.org/8249014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106006 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoRevert 105914 - Removed the ability to disable accelerated compositing for UI tests...
thestig@chromium.org [Tue, 18 Oct 2011 02:30:53 +0000 (02:30 +0000)]
Revert 105914 - Removed the ability to disable accelerated compositing for UI tests. There is no need to disable accelerated compositing on any platform. Mac bots are always accelerated. Mesa works fine on others.
BUG=95782

Broke Linux TSAN.

Review URL: http://codereview.chromium.org/7996010

TBR=alokp@chromium.org
Review URL: http://codereview.chromium.org/8330008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106005 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoFixed crashes in webui taskmanager and tests on Win.
yoshiki@chromium.org [Tue, 18 Oct 2011 02:26:04 +0000 (02:26 +0000)]
Fixed crashes in webui taskmanager and tests on Win.

BUG=100431
TEST=run browser_test manually

Review URL: http://codereview.chromium.org/8336002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106004 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoMove PluginLoaderClient to PluginLoaderPosix in its own file.
rsesek@chromium.org [Tue, 18 Oct 2011 02:23:23 +0000 (02:23 +0000)]
Move PluginLoaderClient to PluginLoaderPosix in its own file.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8334004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106003 0039d316-1c4b-4281-b951-d872f2087c98

3 years ago[Sync UI] Fix Mac main menu sync strings.
binji@chromium.org [Tue, 18 Oct 2011 02:14:40 +0000 (02:14 +0000)]
[Sync UI] Fix Mac main menu sync strings.

BUG=29358, 99264
TEST=Load chrome for mac. Under apple menu item should say "Sign in to Chrome...". When signed in, it should say "Signed in as foo@example.com...".

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105349

Review URL: http://codereview.chromium.org/8242015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106002 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoRevert 105998 - views: Change TextButtonBase API to string16.
sail@chromium.org [Tue, 18 Oct 2011 02:12:40 +0000 (02:12 +0000)]
Revert 105998 - views: Change TextButtonBase API to string16.

BUG=68267
R=sky@chromium.org

Review URL: http://codereview.chromium.org/8262003

TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/8329010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106001 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoAdd another point at which we check for new external extensions.
miket@chromium.org [Tue, 18 Oct 2011 02:00:39 +0000 (02:00 +0000)]
Add another point at which we check for new external extensions.

The effect when multiple extensions appear is what we want (the bubble is
quickly replaced with the updated list as each extension's I/O completes),
but I feel that we're playing a bit fast and loose with the UI. It might be OK.

BUG=94494
TEST=manual.

Review URL: http://codereview.chromium.org/8329003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106000 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoviews: Change TextButtonBase API to string16.
tfarina@chromium.org [Tue, 18 Oct 2011 01:57:22 +0000 (01:57 +0000)]
views: Change TextButtonBase API to string16.

BUG=68267
R=sky@chromium.org

Review URL: http://codereview.chromium.org/8262003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105998 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUse NSS to generate Origin-Bound Certs on Win and Mac.
mattm@chromium.org [Tue, 18 Oct 2011 01:47:04 +0000 (01:47 +0000)]
Use NSS to generate Origin-Bound Certs on Win and Mac.

The platform RSAPrivateKey is used to generate the private key, which is then imported into NSS to generate the certificate.
X509Certificate::CreateOriginBound is moved to x509_util::CreateOriginBoundCert so it can be shared by those platforms, and removes the unnecessary X509Certificate generation step.

BUG=88782
TEST=X509UtilNSSTest.CreateOriginBoundCert & manual testing: try on win or mac, check if generated cert has the OBC extension.

Review URL: http://codereview.chromium.org/8296014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105997 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoRevert r104043, which causes audio not to play smoothly on Chrome OS.
enal@chromium.org [Tue, 18 Oct 2011 01:44:52 +0000 (01:44 +0000)]
Revert r104043, which causes audio not to play smoothly on Chrome OS.

BUG=chromium-os:21491

Review URL: http://codereview.chromium.org/8329004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105996 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoSet send buffer size for P2P UDP sockets.
sergeyu@chromium.org [Tue, 18 Oct 2011 01:44:40 +0000 (01:44 +0000)]
Set send buffer size for P2P UDP sockets.

On windows the default send buffer is too small. Set it explicitly to prevent packets from being lost when sending.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8304008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105995 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoAn empty brand string on Mac is used for channels other than stable, which are
mark@chromium.org [Tue, 18 Oct 2011 01:36:02 +0000 (01:36 +0000)]
An empty brand string on Mac is used for channels other than stable, which are
always organic. Refactoring in r104479 (codereview 8136006) erroneously
stoped treating empty brand strings as organic, which had the effect of
disabling the first run UI on the Mac. This means that there was no search
engine selection dialog and no opportunity to choose to enable crash reporting
and set Chrome as the default browser.

BUG=100659
TEST=Remove the profile (~/Library/Application Support/Google/Chrome or
     ~/Library/Application Support/Google/Chrome Canary). Launch Chrome or
     Chrome Canary. Expect to see the search engine selection dialog followed
     by the "Google Chrome is ready to complete your installation" dialog.
Review URL: http://codereview.chromium.org/8329007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105994 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoFix playing of 8-bit sample files via webaudio.
rtoy@google.com [Tue, 18 Oct 2011 01:34:50 +0000 (01:34 +0000)]
Fix playing of 8-bit sample files via webaudio.
The bias for 8-bit samples was incorrectly applied.

To hear the bug, go to the url: http://www.corp.google.com/~rtoy/audio/latency.html

Press space.  This should play 2 sec of an 8-bit wave file.  You will hear just a click instead of a man (on one channel) and a woman (on the other channel) speaking different sentences.

Review URL: http://codereview.chromium.org/8276006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105993 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoPrevent invalid file error when restoring session
sail@chromium.org [Tue, 18 Oct 2011 01:28:46 +0000 (01:28 +0000)]
Prevent invalid file error when restoring session

BUG=99371
TEST=

Review URL: http://codereview.chromium.org/8312007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105992 0039d316-1c4b-4281-b951-d872f2087c98

3 years agobase::Bind: Convert QuotaEvictionHandler::GetLRUOriginCallback.
jhawkins@chromium.org [Tue, 18 Oct 2011 01:23:02 +0000 (01:23 +0000)]
base::Bind: Convert QuotaEvictionHandler::GetLRUOriginCallback.

BUG=none
TEST=none

R=csilv@chromium.org

Review URL: http://codereview.chromium.org/8334001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105991 0039d316-1c4b-4281-b951-d872f2087c98

3 years agoUpdate .DEPS.git
chrome-admin@google.com [Tue, 18 Oct 2011 01:21:12 +0000 (01:21 +0000)]
Update .DEPS.git

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105990 0039d316-1c4b-4281-b951-d872f2087c98